{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/90746034","pull_request_review_id":11267106,"id":90746034,"diff_hunk":"@@ -976,7 +977,7 @@ public void testBuildSourceDisplayData() {\n \n     BigQueryIO.Read.Bound read = BigQueryIO.Read\n         .from(tableSpec)\n-        .fromQuery(\"myQuery\")\n+        .fromQuery(StaticValueProvider.of(\"myQuery\"))","path":"sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTest.java","position":67,"original_position":67,"commit_id":"4958f8634298e1078a4e20b920dc158e630d6633","original_commit_id":"4958f8634298e1078a4e20b920dc158e630d6633","user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars.githubusercontent.com/u/526415?v=3","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"body":"I'm optimistic this change (and similar above/below) is unnecessary, because BigQuery.Read has the swap-String-for-SVP already?\r\n\r\n(BigQueryTableSource need not have any swaps as it's an internal API.)","created_at":"2016-12-03T01:17:30Z","updated_at":"2016-12-03T01:17:30Z","html_url":"https://github.com/apache/incubator-beam/pull/1238#discussion_r90746034","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1238","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/90746034"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1238#discussion_r90746034"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1238"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1238","id":91704896,"html_url":"https://github.com/apache/incubator-beam/pull/1238","diff_url":"https://github.com/apache/incubator-beam/pull/1238.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1238.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1238","number":1238,"state":"open","locked":false,"title":"[BEAM-551] BigqueryIO support for ValueProvider ","user":{"login":"sammcveety","id":2364801,"avatar_url":"https://avatars.githubusercontent.com/u/2364801?v=3","gravatar_id":"","url":"https://api.github.com/users/sammcveety","html_url":"https://github.com/sammcveety","followers_url":"https://api.github.com/users/sammcveety/followers","following_url":"https://api.github.com/users/sammcveety/following{/other_user}","gists_url":"https://api.github.com/users/sammcveety/gists{/gist_id}","starred_url":"https://api.github.com/users/sammcveety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammcveety/subscriptions","organizations_url":"https://api.github.com/users/sammcveety/orgs","repos_url":"https://api.github.com/users/sammcveety/repos","events_url":"https://api.github.com/users/sammcveety/events{/privacy}","received_events_url":"https://api.github.com/users/sammcveety/received_events","type":"User","site_admin":false},"body":"R: @dhalperi \r\n\r\nThis is the serialization issue I was referencing, where I think the issue is that there is a deferred translation from String -> TableRef -> String, causing a serialization error.","created_at":"2016-10-31T22:44:40Z","updated_at":"2016-12-03T01:17:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93e21c8c1e56dee02f3ad4de6d720a9d52aaf3d1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1238/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1238/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1238/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/4958f8634298e1078a4e20b920dc158e630d6633","head":{"label":"sammcveety:sgmc/bq_vp","ref":"sgmc/bq_vp","sha":"4958f8634298e1078a4e20b920dc158e630d6633","user":{"login":"sammcveety","id":2364801,"avatar_url":"https://avatars.githubusercontent.com/u/2364801?v=3","gravatar_id":"","url":"https://api.github.com/users/sammcveety","html_url":"https://github.com/sammcveety","followers_url":"https://api.github.com/users/sammcveety/followers","following_url":"https://api.github.com/users/sammcveety/following{/other_user}","gists_url":"https://api.github.com/users/sammcveety/gists{/gist_id}","starred_url":"https://api.github.com/users/sammcveety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammcveety/subscriptions","organizations_url":"https://api.github.com/users/sammcveety/orgs","repos_url":"https://api.github.com/users/sammcveety/repos","events_url":"https://api.github.com/users/sammcveety/events{/privacy}","received_events_url":"https://api.github.com/users/sammcveety/received_events","type":"User","site_admin":false},"repo":{"id":63892406,"name":"incubator-beam","full_name":"sammcveety/incubator-beam","owner":{"login":"sammcveety","id":2364801,"avatar_url":"https://avatars.githubusercontent.com/u/2364801?v=3","gravatar_id":"","url":"https://api.github.com/users/sammcveety","html_url":"https://github.com/sammcveety","followers_url":"https://api.github.com/users/sammcveety/followers","following_url":"https://api.github.com/users/sammcveety/following{/other_user}","gists_url":"https://api.github.com/users/sammcveety/gists{/gist_id}","starred_url":"https://api.github.com/users/sammcveety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammcveety/subscriptions","organizations_url":"https://api.github.com/users/sammcveety/orgs","repos_url":"https://api.github.com/users/sammcveety/repos","events_url":"https://api.github.com/users/sammcveety/events{/privacy}","received_events_url":"https://api.github.com/users/sammcveety/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sammcveety/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/sammcveety/incubator-beam","forks_url":"https://api.github.com/repos/sammcveety/incubator-beam/forks","keys_url":"https://api.github.com/repos/sammcveety/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sammcveety/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sammcveety/incubator-beam/teams","hooks_url":"https://api.github.com/repos/sammcveety/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/sammcveety/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/sammcveety/incubator-beam/events","assignees_url":"https://api.github.com/repos/sammcveety/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/sammcveety/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/sammcveety/incubator-beam/tags","blobs_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sammcveety/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/sammcveety/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/sammcveety/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/sammcveety/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/sammcveety/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/sammcveety/incubator-beam/subscription","commits_url":"https://api.github.com/repos/sammcveety/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/sammcveety/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/sammcveety/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/sammcveety/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/sammcveety/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sammcveety/incubator-beam/merges","archive_url":"https://api.github.com/repos/sammcveety/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sammcveety/incubator-beam/downloads","issues_url":"https://api.github.com/repos/sammcveety/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/sammcveety/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/sammcveety/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/sammcveety/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sammcveety/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/sammcveety/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/sammcveety/incubator-beam/deployments","created_at":"2016-07-21T18:17:58Z","updated_at":"2016-07-21T18:18:03Z","pushed_at":"2016-12-02T23:23:59Z","git_url":"git://github.com/sammcveety/incubator-beam.git","ssh_url":"git@github.com:sammcveety/incubator-beam.git","clone_url":"https://github.com/sammcveety/incubator-beam.git","svn_url":"https://github.com/sammcveety/incubator-beam","homepage":null,"size":24346,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1abbb9007e83fc64f1bb61ff4593f37c6c386545","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-12-02T15:59:48Z","pushed_at":"2016-12-03T01:05:32Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":37196,"stargazers_count":508,"watchers_count":508,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":300,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":62,"forks":300,"open_issues":62,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1238"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1238"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1238"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1238/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1238/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1238/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/4958f8634298e1078a4e20b920dc158e630d6633"}}}}
{"actor":{"display_login":"dhalperi"}}