{"action":"closed","number":512,"pull_request":{"url":"https://api.github.com/repos/silvershop/silvershop-core/pulls/512","id":75623880,"html_url":"https://github.com/silvershop/silvershop-core/pull/512","diff_url":"https://github.com/silvershop/silvershop-core/pull/512.diff","patch_url":"https://github.com/silvershop/silvershop-core/pull/512.patch","issue_url":"https://api.github.com/repos/silvershop/silvershop-core/issues/512","number":512,"state":"closed","locked":false,"title":"Improve the way variation options are generated","user":{"login":"pmhou","id":4292357,"avatar_url":"https://avatars.githubusercontent.com/u/4292357?v=3","gravatar_id":"","url":"https://api.github.com/users/pmhou","html_url":"https://github.com/pmhou","followers_url":"https://api.github.com/users/pmhou/followers","following_url":"https://api.github.com/users/pmhou/following{/other_user}","gists_url":"https://api.github.com/users/pmhou/gists{/gist_id}","starred_url":"https://api.github.com/users/pmhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmhou/subscriptions","organizations_url":"https://api.github.com/users/pmhou/orgs","repos_url":"https://api.github.com/users/pmhou/repos","events_url":"https://api.github.com/users/pmhou/events{/privacy}","received_events_url":"https://api.github.com/users/pmhou/received_events","type":"User","site_admin":false},"body":"Page load is exponentially slowed on products with multiple attribute types due to the hidden input field that's generated by Variation Form. This fix has reduced the script execution time up to this point by over 50% on my local tests and reduces further as the number of product variations increases.","created_at":"2016-06-29T10:26:50Z","updated_at":"2016-06-29T10:56:02Z","closed_at":"2016-06-29T10:56:02Z","merged_at":"2016-06-29T10:56:02Z","merge_commit_sha":"99701b0275c9e6fa7b3c602dbc202e97678119e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/silvershop/silvershop-core/pulls/512/commits","review_comments_url":"https://api.github.com/repos/silvershop/silvershop-core/pulls/512/comments","review_comment_url":"https://api.github.com/repos/silvershop/silvershop-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silvershop/silvershop-core/issues/512/comments","statuses_url":"https://api.github.com/repos/silvershop/silvershop-core/statuses/f4f7b85b476912b5b9e4af2a04c3495c6407699a","head":{"label":"pmhou:pmhou/enhancement/variation-form","ref":"pmhou/enhancement/variation-form","sha":"f4f7b85b476912b5b9e4af2a04c3495c6407699a","user":{"login":"pmhou","id":4292357,"avatar_url":"https://avatars.githubusercontent.com/u/4292357?v=3","gravatar_id":"","url":"https://api.github.com/users/pmhou","html_url":"https://github.com/pmhou","followers_url":"https://api.github.com/users/pmhou/followers","following_url":"https://api.github.com/users/pmhou/following{/other_user}","gists_url":"https://api.github.com/users/pmhou/gists{/gist_id}","starred_url":"https://api.github.com/users/pmhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmhou/subscriptions","organizations_url":"https://api.github.com/users/pmhou/orgs","repos_url":"https://api.github.com/users/pmhou/repos","events_url":"https://api.github.com/users/pmhou/events{/privacy}","received_events_url":"https://api.github.com/users/pmhou/received_events","type":"User","site_admin":false},"repo":{"id":62212859,"name":"silvershop-core","full_name":"pmhou/silvershop-core","owner":{"login":"pmhou","id":4292357,"avatar_url":"https://avatars.githubusercontent.com/u/4292357?v=3","gravatar_id":"","url":"https://api.github.com/users/pmhou","html_url":"https://github.com/pmhou","followers_url":"https://api.github.com/users/pmhou/followers","following_url":"https://api.github.com/users/pmhou/following{/other_user}","gists_url":"https://api.github.com/users/pmhou/gists{/gist_id}","starred_url":"https://api.github.com/users/pmhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmhou/subscriptions","organizations_url":"https://api.github.com/users/pmhou/orgs","repos_url":"https://api.github.com/users/pmhou/repos","events_url":"https://api.github.com/users/pmhou/events{/privacy}","received_events_url":"https://api.github.com/users/pmhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmhou/silvershop-core","description":"SilverShop  is an e-commerce shopping cart module for the SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/pmhou/silvershop-core","forks_url":"https://api.github.com/repos/pmhou/silvershop-core/forks","keys_url":"https://api.github.com/repos/pmhou/silvershop-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmhou/silvershop-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmhou/silvershop-core/teams","hooks_url":"https://api.github.com/repos/pmhou/silvershop-core/hooks","issue_events_url":"https://api.github.com/repos/pmhou/silvershop-core/issues/events{/number}","events_url":"https://api.github.com/repos/pmhou/silvershop-core/events","assignees_url":"https://api.github.com/repos/pmhou/silvershop-core/assignees{/user}","branches_url":"https://api.github.com/repos/pmhou/silvershop-core/branches{/branch}","tags_url":"https://api.github.com/repos/pmhou/silvershop-core/tags","blobs_url":"https://api.github.com/repos/pmhou/silvershop-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmhou/silvershop-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmhou/silvershop-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmhou/silvershop-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmhou/silvershop-core/statuses/{sha}","languages_url":"https://api.github.com/repos/pmhou/silvershop-core/languages","stargazers_url":"https://api.github.com/repos/pmhou/silvershop-core/stargazers","contributors_url":"https://api.github.com/repos/pmhou/silvershop-core/contributors","subscribers_url":"https://api.github.com/repos/pmhou/silvershop-core/subscribers","subscription_url":"https://api.github.com/repos/pmhou/silvershop-core/subscription","commits_url":"https://api.github.com/repos/pmhou/silvershop-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmhou/silvershop-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmhou/silvershop-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmhou/silvershop-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmhou/silvershop-core/contents/{+path}","compare_url":"https://api.github.com/repos/pmhou/silvershop-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmhou/silvershop-core/merges","archive_url":"https://api.github.com/repos/pmhou/silvershop-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmhou/silvershop-core/downloads","issues_url":"https://api.github.com/repos/pmhou/silvershop-core/issues{/number}","pulls_url":"https://api.github.com/repos/pmhou/silvershop-core/pulls{/number}","milestones_url":"https://api.github.com/repos/pmhou/silvershop-core/milestones{/number}","notifications_url":"https://api.github.com/repos/pmhou/silvershop-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmhou/silvershop-core/labels{/name}","releases_url":"https://api.github.com/repos/pmhou/silvershop-core/releases{/id}","deployments_url":"https://api.github.com/repos/pmhou/silvershop-core/deployments","created_at":"2016-06-29T09:19:04Z","updated_at":"2016-06-29T09:19:06Z","pushed_at":"2016-06-29T10:23:57Z","git_url":"git://github.com/pmhou/silvershop-core.git","ssh_url":"git@github.com:pmhou/silvershop-core.git","clone_url":"https://github.com/pmhou/silvershop-core.git","svn_url":"https://github.com/pmhou/silvershop-core","homepage":"http://silvershop.github.io","size":8145,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silvershop:master","ref":"master","sha":"73be24f8997bf51e98e5b2392844d2a736ed8fee","user":{"login":"silvershop","id":16675430,"avatar_url":"https://avatars.githubusercontent.com/u/16675430?v=3","gravatar_id":"","url":"https://api.github.com/users/silvershop","html_url":"https://github.com/silvershop","followers_url":"https://api.github.com/users/silvershop/followers","following_url":"https://api.github.com/users/silvershop/following{/other_user}","gists_url":"https://api.github.com/users/silvershop/gists{/gist_id}","starred_url":"https://api.github.com/users/silvershop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silvershop/subscriptions","organizations_url":"https://api.github.com/users/silvershop/orgs","repos_url":"https://api.github.com/users/silvershop/repos","events_url":"https://api.github.com/users/silvershop/events{/privacy}","received_events_url":"https://api.github.com/users/silvershop/received_events","type":"Organization","site_admin":false},"repo":{"id":3253527,"name":"silvershop-core","full_name":"silvershop/silvershop-core","owner":{"login":"silvershop","id":16675430,"avatar_url":"https://avatars.githubusercontent.com/u/16675430?v=3","gravatar_id":"","url":"https://api.github.com/users/silvershop","html_url":"https://github.com/silvershop","followers_url":"https://api.github.com/users/silvershop/followers","following_url":"https://api.github.com/users/silvershop/following{/other_user}","gists_url":"https://api.github.com/users/silvershop/gists{/gist_id}","starred_url":"https://api.github.com/users/silvershop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silvershop/subscriptions","organizations_url":"https://api.github.com/users/silvershop/orgs","repos_url":"https://api.github.com/users/silvershop/repos","events_url":"https://api.github.com/users/silvershop/events{/privacy}","received_events_url":"https://api.github.com/users/silvershop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silvershop/silvershop-core","description":"SilverShop  is an e-commerce shopping cart module for the SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silvershop/silvershop-core","forks_url":"https://api.github.com/repos/silvershop/silvershop-core/forks","keys_url":"https://api.github.com/repos/silvershop/silvershop-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silvershop/silvershop-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silvershop/silvershop-core/teams","hooks_url":"https://api.github.com/repos/silvershop/silvershop-core/hooks","issue_events_url":"https://api.github.com/repos/silvershop/silvershop-core/issues/events{/number}","events_url":"https://api.github.com/repos/silvershop/silvershop-core/events","assignees_url":"https://api.github.com/repos/silvershop/silvershop-core/assignees{/user}","branches_url":"https://api.github.com/repos/silvershop/silvershop-core/branches{/branch}","tags_url":"https://api.github.com/repos/silvershop/silvershop-core/tags","blobs_url":"https://api.github.com/repos/silvershop/silvershop-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silvershop/silvershop-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silvershop/silvershop-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/silvershop/silvershop-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silvershop/silvershop-core/statuses/{sha}","languages_url":"https://api.github.com/repos/silvershop/silvershop-core/languages","stargazers_url":"https://api.github.com/repos/silvershop/silvershop-core/stargazers","contributors_url":"https://api.github.com/repos/silvershop/silvershop-core/contributors","subscribers_url":"https://api.github.com/repos/silvershop/silvershop-core/subscribers","subscription_url":"https://api.github.com/repos/silvershop/silvershop-core/subscription","commits_url":"https://api.github.com/repos/silvershop/silvershop-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/silvershop/silvershop-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/silvershop/silvershop-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/silvershop/silvershop-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/silvershop/silvershop-core/contents/{+path}","compare_url":"https://api.github.com/repos/silvershop/silvershop-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silvershop/silvershop-core/merges","archive_url":"https://api.github.com/repos/silvershop/silvershop-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silvershop/silvershop-core/downloads","issues_url":"https://api.github.com/repos/silvershop/silvershop-core/issues{/number}","pulls_url":"https://api.github.com/repos/silvershop/silvershop-core/pulls{/number}","milestones_url":"https://api.github.com/repos/silvershop/silvershop-core/milestones{/number}","notifications_url":"https://api.github.com/repos/silvershop/silvershop-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silvershop/silvershop-core/labels{/name}","releases_url":"https://api.github.com/repos/silvershop/silvershop-core/releases{/id}","deployments_url":"https://api.github.com/repos/silvershop/silvershop-core/deployments","created_at":"2012-01-24T05:42:40Z","updated_at":"2016-06-24T03:25:33Z","pushed_at":"2016-06-29T10:56:02Z","git_url":"git://github.com/silvershop/silvershop-core.git","ssh_url":"git@github.com:silvershop/silvershop-core.git","clone_url":"https://github.com/silvershop/silvershop-core.git","svn_url":"https://github.com/silvershop/silvershop-core","homepage":"http://silvershop.github.io","size":8145,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":75,"forks":56,"open_issues":75,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silvershop/silvershop-core/pulls/512"},"html":{"href":"https://github.com/silvershop/silvershop-core/pull/512"},"issue":{"href":"https://api.github.com/repos/silvershop/silvershop-core/issues/512"},"comments":{"href":"https://api.github.com/repos/silvershop/silvershop-core/issues/512/comments"},"review_comments":{"href":"https://api.github.com/repos/silvershop/silvershop-core/pulls/512/comments"},"review_comment":{"href":"https://api.github.com/repos/silvershop/silvershop-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silvershop/silvershop-core/pulls/512/commits"},"statuses":{"href":"https://api.github.com/repos/silvershop/silvershop-core/statuses/f4f7b85b476912b5b9e4af2a04c3495c6407699a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bummzack","id":1006185,"avatar_url":"https://avatars.githubusercontent.com/u/1006185?v=3","gravatar_id":"","url":"https://api.github.com/users/bummzack","html_url":"https://github.com/bummzack","followers_url":"https://api.github.com/users/bummzack/followers","following_url":"https://api.github.com/users/bummzack/following{/other_user}","gists_url":"https://api.github.com/users/bummzack/gists{/gist_id}","starred_url":"https://api.github.com/users/bummzack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bummzack/subscriptions","organizations_url":"https://api.github.com/users/bummzack/orgs","repos_url":"https://api.github.com/users/bummzack/repos","events_url":"https://api.github.com/users/bummzack/events{/privacy}","received_events_url":"https://api.github.com/users/bummzack/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"bummzack"}}