{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/55678494","id":55678494,"diff_hunk":"@@ -349,6 +369,14 @@ typename AStarAlgorithm<TGraph>::Result AStarAlgorithm<TGraph>::FindPathBidirect\n         if (!foundAnyPath || bestPathReducedLength > curPathReducedLength)\n         {\n           bestPathReducedLength = curPathReducedLength;\n+          bestPathRealLength = stateV.distance + len - pV + distW;\n+          bestPathRealLength += cur->pS;\n+\n+          if (distW > 0)","path":"routing/base/astar_algorithm.hpp","position":101,"original_position":101,"commit_id":"c2852a4c3023bfbdb64ffe653c06ab82dc7ccd3e","original_commit_id":"c2852a4c3023bfbdb64ffe653c06ab82dc7ccd3e","user":{"login":"ygorshenin","id":454567,"avatar_url":"https://avatars.githubusercontent.com/u/454567?v=3","gravatar_id":"","url":"https://api.github.com/users/ygorshenin","html_url":"https://github.com/ygorshenin","followers_url":"https://api.github.com/users/ygorshenin/followers","following_url":"https://api.github.com/users/ygorshenin/following{/other_user}","gists_url":"https://api.github.com/users/ygorshenin/gists{/gist_id}","starred_url":"https://api.github.com/users/ygorshenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ygorshenin/subscriptions","organizations_url":"https://api.github.com/users/ygorshenin/orgs","repos_url":"https://api.github.com/users/ygorshenin/repos","events_url":"https://api.github.com/users/ygorshenin/events{/privacy}","received_events_url":"https://api.github.com/users/ygorshenin/received_events","type":"User","site_admin":false},"body":"Why do we need this condition? For vertices on the shortest path reduced length can be zero, but real length is not zero (imagine a straight line between two points on a plane, and each edge is just a segment on the line. Reduced length of each edge is zero, if we assume Euclidian metric, but real length can be non-zero).\r\n\r\nAlso, for symmetry and readability, why not to rewrite formula in the following way:\r\n```c++\r\nbestPathRealLength = stateV.distance + len + distW;\r\nbestPathRealLength += cur->pS - pV;\r\nbestPathRealLength += nxt->pS - next->ConsistentHeuristic(stateW.vertex);\r\n```\r\n?","created_at":"2016-03-10T13:33:55Z","updated_at":"2016-03-10T13:33:55Z","html_url":"https://github.com/mapsme/omim/pull/1867#discussion_r55678494","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/1867","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/55678494"},"html":{"href":"https://github.com/mapsme/omim/pull/1867#discussion_r55678494"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1867"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/1867","id":58769209,"html_url":"https://github.com/mapsme/omim/pull/1867","diff_url":"https://github.com/mapsme/omim/pull/1867.diff","patch_url":"https://github.com/mapsme/omim/pull/1867.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/1867","number":1867,"state":"open","locked":false,"title":"Small mwm cross routing fixes.","user":{"login":"gardster","id":1862559,"avatar_url":"https://avatars.githubusercontent.com/u/1862559?v=3","gravatar_id":"","url":"https://api.github.com/users/gardster","html_url":"https://github.com/gardster","followers_url":"https://api.github.com/users/gardster/followers","following_url":"https://api.github.com/users/gardster/following{/other_user}","gists_url":"https://api.github.com/users/gardster/gists{/gist_id}","starred_url":"https://api.github.com/users/gardster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gardster/subscriptions","organizations_url":"https://api.github.com/users/gardster/orgs","repos_url":"https://api.github.com/users/gardster/repos","events_url":"https://api.github.com/users/gardster/events{/privacy}","received_events_url":"https://api.github.com/users/gardster/received_events","type":"User","site_admin":false},"body":"Фиксы роутинга через несколько карт.\r\n1. На пересечении границ карт рассматривается случай наличия нескольких выходов в одной точке.\r\n2. Рассматривается вариант роутинга внутри одной карты с заездом в смежные.","created_at":"2016-02-09T16:12:02Z","updated_at":"2016-03-10T13:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a5f3f56eff9af5ce2a092fdcacf5ce2f4f7d380","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/1867/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/1867/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/1867/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/c2852a4c3023bfbdb64ffe653c06ab82dc7ccd3e","head":{"label":"gardster:new-search-cross-mwm-fix","ref":"new-search-cross-mwm-fix","sha":"c2852a4c3023bfbdb64ffe653c06ab82dc7ccd3e","user":{"login":"gardster","id":1862559,"avatar_url":"https://avatars.githubusercontent.com/u/1862559?v=3","gravatar_id":"","url":"https://api.github.com/users/gardster","html_url":"https://github.com/gardster","followers_url":"https://api.github.com/users/gardster/followers","following_url":"https://api.github.com/users/gardster/following{/other_user}","gists_url":"https://api.github.com/users/gardster/gists{/gist_id}","starred_url":"https://api.github.com/users/gardster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gardster/subscriptions","organizations_url":"https://api.github.com/users/gardster/orgs","repos_url":"https://api.github.com/users/gardster/repos","events_url":"https://api.github.com/users/gardster/events{/privacy}","received_events_url":"https://api.github.com/users/gardster/received_events","type":"User","site_admin":false},"repo":{"id":43428017,"name":"omim","full_name":"gardster/omim","owner":{"login":"gardster","id":1862559,"avatar_url":"https://avatars.githubusercontent.com/u/1862559?v=3","gravatar_id":"","url":"https://api.github.com/users/gardster","html_url":"https://github.com/gardster","followers_url":"https://api.github.com/users/gardster/followers","following_url":"https://api.github.com/users/gardster/following{/other_user}","gists_url":"https://api.github.com/users/gardster/gists{/gist_id}","starred_url":"https://api.github.com/users/gardster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gardster/subscriptions","organizations_url":"https://api.github.com/users/gardster/orgs","repos_url":"https://api.github.com/users/gardster/repos","events_url":"https://api.github.com/users/gardster/events{/privacy}","received_events_url":"https://api.github.com/users/gardster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gardster/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/gardster/omim","forks_url":"https://api.github.com/repos/gardster/omim/forks","keys_url":"https://api.github.com/repos/gardster/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gardster/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gardster/omim/teams","hooks_url":"https://api.github.com/repos/gardster/omim/hooks","issue_events_url":"https://api.github.com/repos/gardster/omim/issues/events{/number}","events_url":"https://api.github.com/repos/gardster/omim/events","assignees_url":"https://api.github.com/repos/gardster/omim/assignees{/user}","branches_url":"https://api.github.com/repos/gardster/omim/branches{/branch}","tags_url":"https://api.github.com/repos/gardster/omim/tags","blobs_url":"https://api.github.com/repos/gardster/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gardster/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gardster/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/gardster/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gardster/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/gardster/omim/languages","stargazers_url":"https://api.github.com/repos/gardster/omim/stargazers","contributors_url":"https://api.github.com/repos/gardster/omim/contributors","subscribers_url":"https://api.github.com/repos/gardster/omim/subscribers","subscription_url":"https://api.github.com/repos/gardster/omim/subscription","commits_url":"https://api.github.com/repos/gardster/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/gardster/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/gardster/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/gardster/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/gardster/omim/contents/{+path}","compare_url":"https://api.github.com/repos/gardster/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gardster/omim/merges","archive_url":"https://api.github.com/repos/gardster/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gardster/omim/downloads","issues_url":"https://api.github.com/repos/gardster/omim/issues{/number}","pulls_url":"https://api.github.com/repos/gardster/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/gardster/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/gardster/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gardster/omim/labels{/name}","releases_url":"https://api.github.com/repos/gardster/omim/releases{/id}","deployments_url":"https://api.github.com/repos/gardster/omim/deployments","created_at":"2015-09-30T10:57:47Z","updated_at":"2016-01-18T10:50:39Z","pushed_at":"2016-03-10T12:38:54Z","git_url":"git://github.com/gardster/omim.git","ssh_url":"git@github.com:gardster/omim.git","clone_url":"https://github.com/gardster/omim.git","svn_url":"https://github.com/gardster/omim","homepage":null,"size":2219740,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:new-search","ref":"new-search","sha":"0b83521ae2e959e0af48533257014657469c0205","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2016-03-08T08:01:42Z","pushed_at":"2016-03-10T13:30:56Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":2275504,"stargazers_count":1642,"watchers_count":1642,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":232,"mirror_url":null,"open_issues_count":117,"forks":232,"open_issues":117,"watchers":1642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1867"},"html":{"href":"https://github.com/mapsme/omim/pull/1867"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/1867"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/1867/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1867/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1867/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/c2852a4c3023bfbdb64ffe653c06ab82dc7ccd3e"}}}}