{"action":"opened","issue":{"url":"https://api.github.com/repos/gpsbabel/gpsbabel/issues/24","labels_url":"https://api.github.com/repos/gpsbabel/gpsbabel/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/gpsbabel/gpsbabel/issues/24/comments","events_url":"https://api.github.com/repos/gpsbabel/gpsbabel/issues/24/events","html_url":"https://github.com/gpsbabel/gpsbabel/issues/24","id":125315683,"number":24,"title":"\"Short GSA sentence\" warning","user":{"login":"fbonzon","id":1116761,"avatar_url":"https://avatars.githubusercontent.com/u/1116761?v=3","gravatar_id":"","url":"https://api.github.com/users/fbonzon","html_url":"https://github.com/fbonzon","followers_url":"https://api.github.com/users/fbonzon/followers","following_url":"https://api.github.com/users/fbonzon/following{/other_user}","gists_url":"https://api.github.com/users/fbonzon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbonzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbonzon/subscriptions","organizations_url":"https://api.github.com/users/fbonzon/orgs","repos_url":"https://api.github.com/users/fbonzon/repos","events_url":"https://api.github.com/users/fbonzon/events{/privacy}","received_events_url":"https://api.github.com/users/fbonzon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-01-07T03:36:26Z","updated_at":"2016-01-07T03:36:26Z","closed_at":null,"body":"I upgraded to GPSBabel 1.5.3 and now see thousands of \"Short GSA sentence\" warnings.\r\n\r\nRaw NMEA output of Samsung Galaxy S5 phone:\r\n\r\n```\r\n$GPGSA,A,2,05,12,13,15,17,18,19,20,24,28,30,,0.9,0.7,0.7*30\r\n$GNGSA,A,2,05,12,13,15,17,18,19,20,24,28,30,,0.9,0.7,0.7*2E\r\n$GNGSA,A,2,69,70,71,73,79,80,,,,,,,0.9,0.7,0.7*28\r\n$BDGSA,A,2,,,,,,,,,,,,,0.9,0.7,0.7*2B\r\n```\r\n\r\nnmea.cc now emits this \"Short GSA sentence\" warning (since July 2015) when there are less than 2 IDs (of SVs used in position fix) in a GSA sentence.\r\n\r\nMy BDGSA sentences have no satellite IDs (talker ID \"BD\" means Beidou constellation?), presumably because there were none visible (I was indeed far away from China). I don't consider this bad data and worth a warning, and suggest to change:\r\n\r\n```c\r\n  if (scn < 4) {\r\n```\r\nto:\r\n```c\r\n  if (scn < 2) {\r\n```\r\non [this line](https://github.com/gpsbabel/gpsbabel/blob/7691a33ca73a9b9072b6e2598a90479f483d9e8c/nmea.cc#L694). May I proceed with PR?"}}