{"action":"created","issue":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/781","repository_url":"https://api.github.com/repos/electron-userland/electron-builder","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/781/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/781/comments","events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/781/events","html_url":"https://github.com/electron-userland/electron-builder/issues/781","id":179274382,"number":781,"title":"include EULA license file in windows installer","user":{"login":"fridgerator","id":2133368,"avatar_url":"https://avatars.githubusercontent.com/u/2133368?v=3","gravatar_id":"","url":"https://api.github.com/users/fridgerator","html_url":"https://github.com/fridgerator","followers_url":"https://api.github.com/users/fridgerator/followers","following_url":"https://api.github.com/users/fridgerator/following{/other_user}","gists_url":"https://api.github.com/users/fridgerator/gists{/gist_id}","starred_url":"https://api.github.com/users/fridgerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fridgerator/subscriptions","organizations_url":"https://api.github.com/users/fridgerator/orgs","repos_url":"https://api.github.com/users/fridgerator/repos","events_url":"https://api.github.com/users/fridgerator/events{/privacy}","received_events_url":"https://api.github.com/users/fridgerator/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/electron-userland/electron-builder/labels/nsis","name":"nsis","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-26T16:22:53Z","updated_at":"2016-09-27T05:33:06Z","closed_at":null,"body":"<!-- Which version of electron-builder are you using? -->\r\n* **Version**: latest **7.9.0**\r\n\r\n<!-- What target are you building for? -->\r\n* **Target**: windows 10 x64\r\n\r\n<!-- Enter your issue details below this comment. -->\r\nI am including an EULA license file in the NSIS installer.\r\n\r\nI have edited package.json to include  a custom `nsis.include` = `resources/windows/license.nsh`\r\n\r\nMy `license.nsh` script looks like this:\r\n```\r\n!include \"MUI2.nsh\"\r\n\r\n!insertmacro MUI_PAGE_LICENSE \"resources\\license.txt\"\r\n```\r\n\r\nThe NSIS installer creation fails at `common.nsh` line 11 when setting `Unicode true` with:\r\n```\r\nError: Can't change target architecture after data already got compressed or header already changed!\r\nError: Unable to set target charset (adequate stub not found?)\r\n```\r\n\r\nI can fix this temporarily by commenting out line 11 in `common.nsh`.\r\n\r\nI'm not very familiar with NSIS, I wasn't sure it its possible to check the mentioned cases in the error message before setting the `Unicode` value or not.  Or if this is even something that you all wanted to worry about."},"comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments/249770345","html_url":"https://github.com/electron-userland/electron-builder/issues/781#issuecomment-249770345","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/781","id":249770345,"user":{"login":"develar","id":350686,"avatar_url":"https://avatars.githubusercontent.com/u/350686?v=3","gravatar_id":"","url":"https://api.github.com/users/develar","html_url":"https://github.com/develar","followers_url":"https://api.github.com/users/develar/followers","following_url":"https://api.github.com/users/develar/following{/other_user}","gists_url":"https://api.github.com/users/develar/gists{/gist_id}","starred_url":"https://api.github.com/users/develar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develar/subscriptions","organizations_url":"https://api.github.com/users/develar/orgs","repos_url":"https://api.github.com/users/develar/repos","events_url":"https://api.github.com/users/develar/events{/privacy}","received_events_url":"https://api.github.com/users/develar/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T05:33:06Z","updated_at":"2016-09-27T05:33:06Z","body":"Please try to wrap your code into macro customHeader.\r\n\r\nI am on vacation — you can expect fix in 3 days."}}
{"actor":{"display_login":"develar"}}