{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments/85242676","pull_request_review_id":5969865,"id":85242676,"diff_hunk":"@@ -207,7 +207,7 @@ private void ParseUrlAction(XElement urlAction, UrlRewriteRuleBuilder builder, b\n             }\n \n             RedirectType redirectType;\n-            if (!Enum.TryParse(urlAction.Attribute(RewriteTags.RedirectType)?.Value, out redirectType))\n+            if (!Enum.TryParse(urlAction.Attribute(RewriteTags.RedirectType)?.Value, true, out redirectType))","path":"src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteFileParser.cs","position":null,"original_position":44,"commit_id":"14eeb89dedeb53591a823040ed88e76fb1275a33","original_commit_id":"f4537c3a5c0e0883f4bae4ad15843236916b5ae6","user":{"login":"mikaelm12","id":4809660,"avatar_url":"https://avatars.githubusercontent.com/u/4809660?v=3","gravatar_id":"","url":"https://api.github.com/users/mikaelm12","html_url":"https://github.com/mikaelm12","followers_url":"https://api.github.com/users/mikaelm12/followers","following_url":"https://api.github.com/users/mikaelm12/following{/other_user}","gists_url":"https://api.github.com/users/mikaelm12/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelm12/subscriptions","organizations_url":"https://api.github.com/users/mikaelm12/orgs","repos_url":"https://api.github.com/users/mikaelm12/repos","events_url":"https://api.github.com/users/mikaelm12/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelm12/received_events","type":"User","site_admin":false},"body":"Do you think we should do this for all the enum parsing?","created_at":"2016-10-26T23:40:28Z","updated_at":"2016-10-26T23:40:28Z","html_url":"https://github.com/aspnet/BasicMiddleware/pull/160#discussion_r85242676","pull_request_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments/85242676"},"html":{"href":"https://github.com/aspnet/BasicMiddleware/pull/160#discussion_r85242676"},"pull_request":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160","id":90939751,"html_url":"https://github.com/aspnet/BasicMiddleware/pull/160","diff_url":"https://github.com/aspnet/BasicMiddleware/pull/160.diff","patch_url":"https://github.com/aspnet/BasicMiddleware/pull/160.patch","issue_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/160","number":160,"state":"open","locked":false,"title":"Fix enum parsing","user":{"login":"mikaelm12","id":4809660,"avatar_url":"https://avatars.githubusercontent.com/u/4809660?v=3","gravatar_id":"","url":"https://api.github.com/users/mikaelm12","html_url":"https://github.com/mikaelm12","followers_url":"https://api.github.com/users/mikaelm12/followers","following_url":"https://api.github.com/users/mikaelm12/following{/other_user}","gists_url":"https://api.github.com/users/mikaelm12/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelm12/subscriptions","organizations_url":"https://api.github.com/users/mikaelm12/orgs","repos_url":"https://api.github.com/users/mikaelm12/repos","events_url":"https://api.github.com/users/mikaelm12/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelm12/received_events","type":"User","site_admin":false},"body":"Currently enum parsing isn't case sensitive and some of the enums have incorrect casing which is a bad combo..\r\nIssue: https://github.com/aspnet/BasicMiddleware/issues/145\r\n@BrennanConroy @natemcmaster @Tratcher ","created_at":"2016-10-26T05:42:14Z","updated_at":"2016-10-26T23:40:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"982fb96ce34e207ae22390bffd07dc342745e580","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160/commits","review_comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160/comments","review_comment_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/160/comments","statuses_url":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/14eeb89dedeb53591a823040ed88e76fb1275a33","head":{"label":"aspnet:mikaelm12/FixEnumParsing","ref":"mikaelm12/FixEnumParsing","sha":"14eeb89dedeb53591a823040ed88e76fb1275a33","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38068840,"name":"BasicMiddleware","full_name":"aspnet/BasicMiddleware","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/BasicMiddleware","description":"Basic middleware components for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/BasicMiddleware","forks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/forks","keys_url":"https://api.github.com/repos/aspnet/BasicMiddleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/BasicMiddleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/BasicMiddleware/teams","hooks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/hooks","issue_events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/events","assignees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/BasicMiddleware/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/tags","blobs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/BasicMiddleware/languages","stargazers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/stargazers","contributors_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contributors","subscribers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscribers","subscription_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscription","commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/BasicMiddleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/BasicMiddleware/merges","archive_url":"https://api.github.com/repos/aspnet/BasicMiddleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/BasicMiddleware/downloads","issues_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/BasicMiddleware/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/BasicMiddleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/BasicMiddleware/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/BasicMiddleware/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/deployments","created_at":"2015-06-25T19:15:27Z","updated_at":"2016-10-24T18:34:36Z","pushed_at":"2016-10-26T23:06:12Z","git_url":"git://github.com/aspnet/BasicMiddleware.git","ssh_url":"git@github.com:aspnet/BasicMiddleware.git","clone_url":"https://github.com/aspnet/BasicMiddleware.git","svn_url":"https://github.com/aspnet/BasicMiddleware","homepage":"","size":714,"stargazers_count":48,"watchers_count":48,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":52,"forks":13,"open_issues":52,"watchers":48,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"2a153b38fea095bb49285f65dde7c47b1c3986b5","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38068840,"name":"BasicMiddleware","full_name":"aspnet/BasicMiddleware","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/BasicMiddleware","description":"Basic middleware components for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/BasicMiddleware","forks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/forks","keys_url":"https://api.github.com/repos/aspnet/BasicMiddleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/BasicMiddleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/BasicMiddleware/teams","hooks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/hooks","issue_events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/events","assignees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/BasicMiddleware/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/tags","blobs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/BasicMiddleware/languages","stargazers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/stargazers","contributors_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contributors","subscribers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscribers","subscription_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscription","commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/BasicMiddleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/BasicMiddleware/merges","archive_url":"https://api.github.com/repos/aspnet/BasicMiddleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/BasicMiddleware/downloads","issues_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/BasicMiddleware/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/BasicMiddleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/BasicMiddleware/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/BasicMiddleware/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/deployments","created_at":"2015-06-25T19:15:27Z","updated_at":"2016-10-24T18:34:36Z","pushed_at":"2016-10-26T23:06:12Z","git_url":"git://github.com/aspnet/BasicMiddleware.git","ssh_url":"git@github.com:aspnet/BasicMiddleware.git","clone_url":"https://github.com/aspnet/BasicMiddleware.git","svn_url":"https://github.com/aspnet/BasicMiddleware","homepage":"","size":714,"stargazers_count":48,"watchers_count":48,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":52,"forks":13,"open_issues":52,"watchers":48,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160"},"html":{"href":"https://github.com/aspnet/BasicMiddleware/pull/160"},"issue":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/160"},"comments":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/14eeb89dedeb53591a823040ed88e76fb1275a33"}}}}
{"actor":{"display_login":"mikaelm12"}}