{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/87883224","pull_request_review_id":8476371,"id":87883224,"diff_hunk":"@@ -59,23 +59,23 @@ - (AppDelegate *)sfsdk_swizzled_init\n     // Need to use SalesforceSDKManagerWithSmartStore when using smartstore\n     [SalesforceSDKManager setInstanceClass:[SalesforceSDKManagerWithSmartStore class]];\n     [SalesforceSDKManager sharedManager].appConfig = appConfig;\n-    __weak typeof(self) weakSelf = self;\n+    __weak __typeof(self) weakSelf = self;\n     [SalesforceSDKManager sharedManager].postLaunchAction = ^(SFSDKLaunchAction launchActionList) {\n-        __strong typeof(weakSelf) strongSelf = weakSelf;\n-        [strongSelf log:SFLogLevelInfo format:@\"Post-launch: launch actions taken: %@\", [SalesforceSDKManager launchActionsStringRepresentation:launchActionList]];\n-        [strongSelf setupRootViewController];\n+      __strong __typeof(weakSelf) strongSelf = weakSelf;\n+      [strongSelf log:SFLogLevelInfo format:@\"Post-launch: launch actions taken: %@\", [SalesforceSDKManager launchActionsStringRepresentation:launchActionList]];\n+      [strongSelf setupRootViewController];\n     };\n     [SalesforceSDKManager sharedManager].launchErrorAction = ^(NSError *error, SFSDKLaunchAction launchActionList) {\n-        __strong typeof(weakSelf) strongSelf = weakSelf;\n-        [strongSelf log:SFLogLevelError format:@\"Error during SDK launch: %@\", [error localizedDescription]];\n-        [strongSelf initializeAppViewState];\n-        [[SalesforceSDKManager sharedManager] launch];\n+      __strong __typeof(weakSelf) strongSelf = weakSelf;\n+      [strongSelf log:SFLogLevelError format:@\"Error during SDK launch: %@\", [error localizedDescription]];\n+      [strongSelf initializeAppViewState];\n+      [[SalesforceSDKManager sharedManager] launch];\n     };\n     [SalesforceSDKManager sharedManager].postLogoutAction = ^{\n-        [weakSelf handleSdkManagerLogout];\n+      [weakSelf handleSdkManagerLogout];","path":"shared/hybrid/AppDelegate+SalesforceHybridSDK.m","position":26,"original_position":26,"commit_id":"5c7a3041c2278ac467b7b36d088aefb5d221b7ed","original_commit_id":"5c7a3041c2278ac467b7b36d088aefb5d221b7ed","user":{"login":"khawkins","id":755462,"avatar_url":"https://avatars.githubusercontent.com/u/755462?v=3","gravatar_id":"","url":"https://api.github.com/users/khawkins","html_url":"https://github.com/khawkins","followers_url":"https://api.github.com/users/khawkins/followers","following_url":"https://api.github.com/users/khawkins/following{/other_user}","gists_url":"https://api.github.com/users/khawkins/gists{/gist_id}","starred_url":"https://api.github.com/users/khawkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khawkins/subscriptions","organizations_url":"https://api.github.com/users/khawkins/orgs","repos_url":"https://api.github.com/users/khawkins/repos","events_url":"https://api.github.com/users/khawkins/events{/privacy}","received_events_url":"https://api.github.com/users/khawkins/received_events","type":"User","site_admin":false},"body":"Same here.  I'd just bulk-select the whole `sfsdk_swizzled_init` method and do Control-I on it.","created_at":"2016-11-14T20:14:44Z","updated_at":"2016-11-14T20:14:44Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1826#discussion_r87883224","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/87883224"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1826#discussion_r87883224"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826","id":93635768,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1826","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1826.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1826.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1826","number":1826,"state":"open","locked":false,"title":"Comply with Cordovas use of default C-99 C language dialect","user":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars.githubusercontent.com/u/4625334?v=3","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-14T19:54:20Z","updated_at":"2016-11-14T20:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e19ce82143fa283cc6469ca9ea29150c81ad8d31","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1826/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/5c7a3041c2278ac467b7b36d088aefb5d221b7ed","head":{"label":"trooper2013:unstable","ref":"unstable","sha":"5c7a3041c2278ac467b7b36d088aefb5d221b7ed","user":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars.githubusercontent.com/u/4625334?v=3","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"repo":{"id":62419453,"name":"SalesforceMobileSDK-iOS","full_name":"trooper2013/SalesforceMobileSDK-iOS","owner":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars.githubusercontent.com/u/4625334?v=3","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":true,"url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/deployments","created_at":"2016-07-01T21:01:11Z","updated_at":"2016-07-01T21:01:15Z","pushed_at":"2016-11-14T19:52:42Z","git_url":"git://github.com/trooper2013/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:trooper2013/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":341804,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:unstable","ref":"unstable","sha":"301f2c2c25c80d396eec268bbed7a12e176918ef","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2338086,"name":"SalesforceMobileSDK-iOS","full_name":"forcedotcom/SalesforceMobileSDK-iOS","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/deployments","created_at":"2011-09-06T23:13:57Z","updated_at":"2016-11-03T08:41:19Z","pushed_at":"2016-11-14T20:01:32Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":356582,"stargazers_count":347,"watchers_count":347,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":251,"mirror_url":null,"open_issues_count":10,"forks":251,"open_issues":10,"watchers":347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1826"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1826"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1826/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1826/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/5c7a3041c2278ac467b7b36d088aefb5d221b7ed"}}}}
{"actor":{"display_login":"khawkins"}}