{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/70184954","id":70184954,"diff_hunk":"@@ -262,55 +267,16 @@ var/list/ai_verbs_default = list(\n \r\n \t// Set ai pda name\r\n \tif(aiPDA)\r\n-\t\taiPDA.set_owner_rank_job(pickedName, \"AI\")\r\n+\t\taiPDA.ownjob = \"AI\"\r\n+\t\taiPDA.owner = pickedName\r\n+\t\taiPDA.name = pickedName + \" (\" + aiPDA.ownjob + \")\"\r","path":"code/modules/mob/living/silicon/ai/ai.dm","position":28,"original_position":28,"commit_id":"f1edccf4fd1275b177772ae8ddf15232c1bc4776","original_commit_id":"f1edccf4fd1275b177772ae8ddf15232c1bc4776","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"body":"Seems this may have been lost in a merge. Will fix.","created_at":"2016-07-10T16:52:26Z","updated_at":"2016-07-10T16:52:26Z","html_url":"https://github.com/Baystation12/Baystation12/pull/13523#discussion_r70184954","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/70184954"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/13523#discussion_r70184954"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523","id":75508263,"html_url":"https://github.com/Baystation12/Baystation12/pull/13523","diff_url":"https://github.com/Baystation12/Baystation12/pull/13523.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/13523.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13523","number":13523,"state":"open","locked":false,"title":"Tweaks AI EMP resistances","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"body":"- APCs with critical flag are now considerably more EMP resistant, failing for 1/10th of time and having better protection for the power cell. This prevents AIs from being one-shot killed by EMPing the core.\r\n- AIs power restoration routine now tries to reboot the APC's failure timer when finished\r\n- EMP still knocks out the AI for a moment, but isn't a guaranteed one hit kill due to power starvation.\r\n\r\n**Updated:**\r\nOkay, this spiraled out of control a bit. Well, it's done now, so here are the changes.\r\n\r\n- Most of these changes are under the hood, and are barely noticeable for player. I will focus on the noticeable changes in this commit message.\r\n- The power restoration routine is now rewritten to use (slightly) cleaner and easier to read code.\r\n- All AI power interaction has been moved to separate file. One main has_power() proc has been created that replaced various other variants that sort of checked the power state. Power handling shifted to separate procs - one for power restoration routine, one for oxyloss (internal capacitor) handling and one for powersupply object synchronization and power usage updates.\r\n- Considerably better synchronization between the AI and it's powersupply object. The powersupply should always be on AI's location, and it's active_power_usage should be managed by the procs the AI has.\r\n\r\n**The AI now has set of power modes controlled by set of defines.**\r\n- Charging: 70kW power usage, operates as usual and heals 2 oxyloss per tick. The define can be increased even more if we desire faster charging.\r\n- Normal: 50kW power usage (as it was before this commit). Normal operation, the AI can work as usual. Usually this means the AI has external power from the APC. The AI can also force it's power on, at the cost of burning through it's remaining capacitor charge (oxyloss) very quickly. The AI can last for about one and half minute in this state, when running off internal capacitor.\r\n- Restoration: 20kW power usage. The AI is blinded, can't control things and lacks most communication. This is automatically set when AI loses power, and comes with activation of special power restoration routine that tries to gain access to the APC. This routine reports status of the APC, and if possible, tries to reset it from EMP/misconfiguration to restore power to the AI.\r\n- Low Power: 10kW power usage. The AI is blinded, can't control things and lacks most communication methods. This is set automatically if the AI's power restoration routine fails. It can also be set manually by the ai with the \"Shutdown\" command that's intended for situations where the AI wants to conserve remaining power to survive for a little longer. The AI can last for approximately 6 minutes in this state.\r\n\r\n**New AI commands**\r\n- \"Shutdown\" - Allows the AI to shut itself down, reducing power usage to 10kW. This however prevents power restoration routine from running. The AI behaves as if it was without power, except that it doesn't take oxyloss damage (assuming the APC still provides the 10kW necessary for the AI to operate). It may be used again to cancel the shutdown, returning to normal mode. Intention of this is to provide an emergency option for the AI, when it's power is very low and when help needs time to arrive. By sacrificing communication/control/camera capabilities the AI can multiply it's remaining APC battery life up to five times.\r\n- \"Toggle Power Override\" - The AI can enable this to remain online despite the lack of external APC power. It however causes much more oxyloss per second. The idea behind this is to allow the AI to send a quick yell for help over the radio, or to allow the AI to correct it's own SMES misconfiguration or other problem that can be fixed quickly. I once again point out that the AI lasts for less than two minutes in this mode, so it's not advised to keep it on at all times, and only use it sparingly.\r\n\r\n**Note**\r\nI have noticed a minor bug, where the AI's blind overlay when powerless flickers on and off. I have been unable to determine the cause, and i am fairly certain it was there even before, and thus it's not linked to the changes in this PR. Most likely a 510-related issue. The effect is visual only - the AI can't interact with any machines, etc. despite being able to briefly see them. I guess it's not as big problem for now.","created_at":"2016-06-28T16:26:18Z","updated_at":"2016-07-10T16:52:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c60107f00941bc4d4a6c8f84234b21569ffc610","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13523/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/f1edccf4fd1275b177772ae8ddf15232c1bc4776","head":{"label":"atlantiscze:2016-06-28-NoOneShot","ref":"2016-06-28-NoOneShot","sha":"f1edccf4fd1275b177772ae8ddf15232c1bc4776","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"repo":{"id":21876216,"name":"Baystation12","full_name":"atlantiscze/Baystation12","owner":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atlantiscze/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/atlantiscze/Baystation12","forks_url":"https://api.github.com/repos/atlantiscze/Baystation12/forks","keys_url":"https://api.github.com/repos/atlantiscze/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlantiscze/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlantiscze/Baystation12/teams","hooks_url":"https://api.github.com/repos/atlantiscze/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/atlantiscze/Baystation12/events","assignees_url":"https://api.github.com/repos/atlantiscze/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/atlantiscze/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/atlantiscze/Baystation12/tags","blobs_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlantiscze/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/atlantiscze/Baystation12/languages","stargazers_url":"https://api.github.com/repos/atlantiscze/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/atlantiscze/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/atlantiscze/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/atlantiscze/Baystation12/subscription","commits_url":"https://api.github.com/repos/atlantiscze/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlantiscze/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlantiscze/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/atlantiscze/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlantiscze/Baystation12/merges","archive_url":"https://api.github.com/repos/atlantiscze/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlantiscze/Baystation12/downloads","issues_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/atlantiscze/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/atlantiscze/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/atlantiscze/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlantiscze/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/atlantiscze/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/atlantiscze/Baystation12/deployments","created_at":"2014-07-15T21:17:06Z","updated_at":"2016-01-17T03:45:38Z","pushed_at":"2016-07-06T17:40:27Z","git_url":"git://github.com/atlantiscze/Baystation12.git","ssh_url":"git@github.com:atlantiscze/Baystation12.git","clone_url":"https://github.com/atlantiscze/Baystation12.git","svn_url":"https://github.com/atlantiscze/Baystation12","homepage":"http://baystation12.net/","size":603665,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"_BAY-Dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"f5442dd506ac8e98527e5ee1772164595167e94f","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2016-07-08T02:18:57Z","pushed_at":"2016-07-10T14:18:39Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1682524,"stargazers_count":219,"watchers_count":219,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":709,"mirror_url":null,"open_issues_count":429,"forks":709,"open_issues":429,"watchers":219,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/13523"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13523"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13523/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13523/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/f1edccf4fd1275b177772ae8ddf15232c1bc4776"}}}}
{"actor":{"display_login":"atlantiscze"}}