{"action":"created","issue":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/295","labels_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/295/labels{/name}","comments_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/295/comments","events_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/295/events","html_url":"https://github.com/makersacademy/airport_challenge/pull/295","id":128382282,"number":295,"title":"David's pull request","user":{"login":"drjparry","id":13313921,"avatar_url":"https://avatars.githubusercontent.com/u/13313921?v=3","gravatar_id":"","url":"https://api.github.com/users/drjparry","html_url":"https://github.com/drjparry","followers_url":"https://api.github.com/users/drjparry/followers","following_url":"https://api.github.com/users/drjparry/following{/other_user}","gists_url":"https://api.github.com/users/drjparry/gists{/gist_id}","starred_url":"https://api.github.com/users/drjparry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjparry/subscriptions","organizations_url":"https://api.github.com/users/drjparry/orgs","repos_url":"https://api.github.com/users/drjparry/repos","events_url":"https://api.github.com/users/drjparry/events{/privacy}","received_events_url":"https://api.github.com/users/drjparry/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/makersacademy/airport_challenge/labels/QA","name":"QA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-24T08:56:28Z","updated_at":"2016-01-25T13:32:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/295","html_url":"https://github.com/makersacademy/airport_challenge/pull/295","diff_url":"https://github.com/makersacademy/airport_challenge/pull/295.diff","patch_url":"https://github.com/makersacademy/airport_challenge/pull/295.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/comments/174510208","html_url":"https://github.com/makersacademy/airport_challenge/pull/295#issuecomment-174510208","issue_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/295","id":174510208,"user":{"login":"mechacoach","id":14219150,"avatar_url":"https://avatars.githubusercontent.com/u/14219150?v=3","gravatar_id":"","url":"https://api.github.com/users/mechacoach","html_url":"https://github.com/mechacoach","followers_url":"https://api.github.com/users/mechacoach/followers","following_url":"https://api.github.com/users/mechacoach/following{/other_user}","gists_url":"https://api.github.com/users/mechacoach/gists{/gist_id}","starred_url":"https://api.github.com/users/mechacoach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mechacoach/subscriptions","organizations_url":"https://api.github.com/users/mechacoach/orgs","repos_url":"https://api.github.com/users/mechacoach/repos","events_url":"https://api.github.com/users/mechacoach/events{/privacy}","received_events_url":"https://api.github.com/users/mechacoach/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T13:32:13Z","updated_at":"2016-01-25T13:32:13Z","body":"You had your airport_challenge reviewed by **Fareed Patel**\n\n### The good points are:\n\n* Overview of project in the README\n* `context` or `describe` blocks are used (where appropriate) to group tests\n* The solution avoids vacuous tests\n* There are a minimal number of untested paths in the code\n* Unit tests all have single expectations\n* Random behaviour is stubbed where appropriate\n* The code follows Ruby naming conventions, Readability is supported by consistent naming\n* Guard clauses are used where appropriate, Booleans are returned implicitly where appropriate, removeallcommented-outcode: There is no commented-out code in the submission\n* Code avoids unnecessary public methods\n* Classes have single responsibilities, Each methods has a single responsibility\n* Code avoids strings where it should use symbols\n* Command/Query naming is not an issue in the code\n* The solution does not have any redundant code\n\n### You should consider the following improvements:\n\n* Installation Instructions should be in the README\n* Use named subject with `described_class`\n* Use `before` blocks to set up objects rather than repeat code\n* Get rid of redundant `respond_to` expectations\n* Remove all commented-out code\n* Avoid magic numbers (e.g. on capacity)\n* Improper use of attr_*\n\n### Additional comments:\nThe spec files could be refactored, but overall very well written code. \n\nAll the Rspec tests run, and do what was expected from the user story. \n\n\nWell executed!, avoidmagicnumberse.g.oncapacity: Code avoids magic numbers\n\nsee https://github.com/makersacademy/airport_challenge/blob/master/docs/review.md for more details\n"}}