{"action":"created","comment":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/comments/88094341","pull_request_review_id":8678153,"id":88094341,"diff_hunk":"@@ -27,9 +27,15 @@ function getFeedback(z) {\n   if (!z || z.score > 2) return '';\n \n   const { warning, suggestions } = z.feedback;\n+  const lookup = function(str) {","path":"app/assets/javascripts/misc/pw-strength.js","position":4,"original_position":4,"commit_id":"1eca1c0efb6e694bdb4d73169d8912fb501f569d","original_commit_id":"1eca1c0efb6e694bdb4d73169d8912fb501f569d","user":{"login":"zachmargolis","id":458784,"avatar_url":"https://avatars.githubusercontent.com/u/458784?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmargolis","html_url":"https://github.com/zachmargolis","followers_url":"https://api.github.com/users/zachmargolis/followers","following_url":"https://api.github.com/users/zachmargolis/following{/other_user}","gists_url":"https://api.github.com/users/zachmargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmargolis/subscriptions","organizations_url":"https://api.github.com/users/zachmargolis/orgs","repos_url":"https://api.github.com/users/zachmargolis/repos","events_url":"https://api.github.com/users/zachmargolis/events{/privacy}","received_events_url":"https://api.github.com/users/zachmargolis/received_events","type":"User","site_admin":false},"body":"style q: why not just declare `function lookup()` outside here?","created_at":"2016-11-15T19:30:55Z","updated_at":"2016-11-15T19:30:55Z","html_url":"https://github.com/18F/identity-idp/pull/717#discussion_r88094341","pull_request_url":"https://api.github.com/repos/18F/identity-idp/pulls/717","_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments/88094341"},"html":{"href":"https://github.com/18F/identity-idp/pull/717#discussion_r88094341"},"pull_request":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/717"}}},"pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/717","id":93241377,"html_url":"https://github.com/18F/identity-idp/pull/717","diff_url":"https://github.com/18F/identity-idp/pull/717.diff","patch_url":"https://github.com/18F/identity-idp/pull/717.patch","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/717","number":717,"state":"open","locked":false,"title":"I18n zxcvbn javascript library","user":{"login":"hursey013","id":1178494,"avatar_url":"https://avatars.githubusercontent.com/u/1178494?v=3","gravatar_id":"","url":"https://api.github.com/users/hursey013","html_url":"https://github.com/hursey013","followers_url":"https://api.github.com/users/hursey013/followers","following_url":"https://api.github.com/users/hursey013/following{/other_user}","gists_url":"https://api.github.com/users/hursey013/gists{/gist_id}","starred_url":"https://api.github.com/users/hursey013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hursey013/subscriptions","organizations_url":"https://api.github.com/users/hursey013/orgs","repos_url":"https://api.github.com/users/hursey013/repos","events_url":"https://api.github.com/users/hursey013/events{/privacy}","received_events_url":"https://api.github.com/users/hursey013/received_events","type":"User","site_admin":false},"body":"**Why**: To allow for custom translation of the zxcvbn library\r\n\r\n~~This removes the zxcvbn library from npm and replaces it with our own local copy.  Local copy has been adapted to use translation strings (feedback.coffee is the specific file that has changed).~~\r\n\r\n~~Still to do in a follow up PR... we are currently including the zxcvbn-js gem, which is basically another copy of this same javascript file that is used for server side validation.  I'd like to look into pointing that gem at our customized version of the javascript file so we can get rid of the duplication and have consistency between the client side and server side validation.~~\r\n\r\nThis intercepts the feedback from the client size zxcvbn and associates it with a corresponding i18n string.  If a corresponding string is not found, it will fall back to using the string hardcoded into the script.\r\n\r\n**Next steps**:  I was running into some issues recreating this same logic on the server side of things, so will try and accomplish that in followup PR, may need some assistance though.  I think the best way forward would be to override the path to the javascript file used by the zxcvbn-js gem to point the the npm version to ensure that the front and backend are always in sync.  Then use a similar method of intercepting the feedback server side.","created_at":"2016-11-10T22:12:51Z","updated_at":"2016-11-15T19:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"708c6358e15657a88a112ad3ab428ac9201e2109","assignee":{"login":"hursey013","id":1178494,"avatar_url":"https://avatars.githubusercontent.com/u/1178494?v=3","gravatar_id":"","url":"https://api.github.com/users/hursey013","html_url":"https://github.com/hursey013","followers_url":"https://api.github.com/users/hursey013/followers","following_url":"https://api.github.com/users/hursey013/following{/other_user}","gists_url":"https://api.github.com/users/hursey013/gists{/gist_id}","starred_url":"https://api.github.com/users/hursey013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hursey013/subscriptions","organizations_url":"https://api.github.com/users/hursey013/orgs","repos_url":"https://api.github.com/users/hursey013/repos","events_url":"https://api.github.com/users/hursey013/events{/privacy}","received_events_url":"https://api.github.com/users/hursey013/received_events","type":"User","site_admin":false},"assignees":[{"login":"hursey013","id":1178494,"avatar_url":"https://avatars.githubusercontent.com/u/1178494?v=3","gravatar_id":"","url":"https://api.github.com/users/hursey013","html_url":"https://github.com/hursey013","followers_url":"https://api.github.com/users/hursey013/followers","following_url":"https://api.github.com/users/hursey013/following{/other_user}","gists_url":"https://api.github.com/users/hursey013/gists{/gist_id}","starred_url":"https://api.github.com/users/hursey013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hursey013/subscriptions","organizations_url":"https://api.github.com/users/hursey013/orgs","repos_url":"https://api.github.com/users/hursey013/repos","events_url":"https://api.github.com/users/hursey013/events{/privacy}","received_events_url":"https://api.github.com/users/hursey013/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/18F/identity-idp/pulls/717/commits","review_comments_url":"https://api.github.com/repos/18F/identity-idp/pulls/717/comments","review_comment_url":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/717/comments","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/1eca1c0efb6e694bdb4d73169d8912fb501f569d","head":{"label":"18F:translate-zxcvbnabcdefg","ref":"translate-zxcvbnabcdefg","sha":"1eca1c0efb6e694bdb4d73169d8912fb501f569d","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2016-11-03T10:34:24Z","pushed_at":"2016-11-15T19:26:53Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://idp.demo.login.gov/","size":11349,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":27,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"03e7cc671140ce438661582fae5ff6a925fe0d7f","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2016-11-03T10:34:24Z","pushed_at":"2016-11-15T19:26:53Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://idp.demo.login.gov/","size":11349,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/717"},"html":{"href":"https://github.com/18F/identity-idp/pull/717"},"issue":{"href":"https://api.github.com/repos/18F/identity-idp/issues/717"},"comments":{"href":"https://api.github.com/repos/18F/identity-idp/issues/717/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/717/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/717/commits"},"statuses":{"href":"https://api.github.com/repos/18F/identity-idp/statuses/1eca1c0efb6e694bdb4d73169d8912fb501f569d"}}}}
{"actor":{"display_login":"zachmargolis"}}