{"action":"closed","number":194,"pull_request":{"url":"https://api.github.com/repos/dojo/dojo/pulls/194","id":54893500,"html_url":"https://github.com/dojo/dojo/pull/194","diff_url":"https://github.com/dojo/dojo/pull/194.diff","patch_url":"https://github.com/dojo/dojo/pull/194.patch","issue_url":"https://api.github.com/repos/dojo/dojo/issues/194","number":194,"state":"closed","locked":false,"title":"fixes #16257, cloning of sparse arrays","user":{"login":"dylans","id":97291,"avatar_url":"https://avatars.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"body":"Leaving this one open for review, as I want to make sure we're not doing something dumb with this change (either from a performance or unintended consequences perspective).\r\n\r\nNote that while all of the tests pass before and after this change, I also tried this test, which fails:\r\n\r\n```\r\nassert.deepEqual(obj1.baz.b, lang.clone(obj1).baz.b, \"Sparse arrays should be equal\");\r\n```\r\n\r\nWhich perhaps it should. That said, this one also passes:\r\n\r\n```\r\nassert.deepEqual(obj1.baz.b[6], lang.clone(obj1).baz.b[6], \"Sparse arrays should be equal\");\r\n```\r\n\r\nSo really I would just appreciate a quick sanity check from someone before I land this. Thanks!","created_at":"2016-01-01T17:03:28Z","updated_at":"2016-01-03T15:12:12Z","closed_at":"2016-01-03T15:12:12Z","merged_at":null,"merge_commit_sha":"f86e719940a845b9375efe05ebe2627ffd2a9828","assignee":{"login":"dylans","id":97291,"avatar_url":"https://avatars.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dojo/dojo/milestones/1","html_url":"https://github.com/dojo/dojo/milestones/1.11","labels_url":"https://api.github.com/repos/dojo/dojo/milestones/1/labels","id":625667,"number":1,"title":"1.11","description":null,"creator":{"login":"dylans","id":97291,"avatar_url":"https://avatars.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":40,"state":"open","created_at":"2014-04-09T22:44:33Z","updated_at":"2016-01-03T15:12:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dojo/dojo/pulls/194/commits","review_comments_url":"https://api.github.com/repos/dojo/dojo/pulls/194/comments","review_comment_url":"https://api.github.com/repos/dojo/dojo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/dojo/issues/194/comments","statuses_url":"https://api.github.com/repos/dojo/dojo/statuses/cd5c236111a826653c48ae400dd0c3d43c22367a","head":{"label":"dylans:t16257-clone-sparse-array","ref":"t16257-clone-sparse-array","sha":"cd5c236111a826653c48ae400dd0c3d43c22367a","user":{"login":"dylans","id":97291,"avatar_url":"https://avatars.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"repo":{"id":11210202,"name":"dojo","full_name":"dylans/dojo","owner":{"login":"dylans","id":97291,"avatar_url":"https://avatars.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dylans/dojo","description":"The Dojo Toolkit core library. Please submit bugs to https://bugs.dojotoolkit.org/","fork":true,"url":"https://api.github.com/repos/dylans/dojo","forks_url":"https://api.github.com/repos/dylans/dojo/forks","keys_url":"https://api.github.com/repos/dylans/dojo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dylans/dojo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dylans/dojo/teams","hooks_url":"https://api.github.com/repos/dylans/dojo/hooks","issue_events_url":"https://api.github.com/repos/dylans/dojo/issues/events{/number}","events_url":"https://api.github.com/repos/dylans/dojo/events","assignees_url":"https://api.github.com/repos/dylans/dojo/assignees{/user}","branches_url":"https://api.github.com/repos/dylans/dojo/branches{/branch}","tags_url":"https://api.github.com/repos/dylans/dojo/tags","blobs_url":"https://api.github.com/repos/dylans/dojo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dylans/dojo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dylans/dojo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dylans/dojo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dylans/dojo/statuses/{sha}","languages_url":"https://api.github.com/repos/dylans/dojo/languages","stargazers_url":"https://api.github.com/repos/dylans/dojo/stargazers","contributors_url":"https://api.github.com/repos/dylans/dojo/contributors","subscribers_url":"https://api.github.com/repos/dylans/dojo/subscribers","subscription_url":"https://api.github.com/repos/dylans/dojo/subscription","commits_url":"https://api.github.com/repos/dylans/dojo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dylans/dojo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dylans/dojo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dylans/dojo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dylans/dojo/contents/{+path}","compare_url":"https://api.github.com/repos/dylans/dojo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dylans/dojo/merges","archive_url":"https://api.github.com/repos/dylans/dojo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dylans/dojo/downloads","issues_url":"https://api.github.com/repos/dylans/dojo/issues{/number}","pulls_url":"https://api.github.com/repos/dylans/dojo/pulls{/number}","milestones_url":"https://api.github.com/repos/dylans/dojo/milestones{/number}","notifications_url":"https://api.github.com/repos/dylans/dojo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dylans/dojo/labels{/name}","releases_url":"https://api.github.com/repos/dylans/dojo/releases{/id}","created_at":"2013-07-05T23:33:50Z","updated_at":"2015-01-11T12:52:51Z","pushed_at":"2016-01-01T17:00:38Z","git_url":"git://github.com/dylans/dojo.git","ssh_url":"git@github.com:dylans/dojo.git","clone_url":"https://github.com/dylans/dojo.git","svn_url":"https://github.com/dylans/dojo","homepage":"https://dojotoolkit.org/","size":9680,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"a19a1c7aca0ce5fe473c848210077bbbd3955698","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":10160528,"name":"dojo","full_name":"dojo/dojo","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/dojo","description":"The Dojo Toolkit core library. Please submit bugs to https://bugs.dojotoolkit.org/","fork":false,"url":"https://api.github.com/repos/dojo/dojo","forks_url":"https://api.github.com/repos/dojo/dojo/forks","keys_url":"https://api.github.com/repos/dojo/dojo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/dojo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/dojo/teams","hooks_url":"https://api.github.com/repos/dojo/dojo/hooks","issue_events_url":"https://api.github.com/repos/dojo/dojo/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/dojo/events","assignees_url":"https://api.github.com/repos/dojo/dojo/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/dojo/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/dojo/tags","blobs_url":"https://api.github.com/repos/dojo/dojo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/dojo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/dojo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/dojo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/dojo/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/dojo/languages","stargazers_url":"https://api.github.com/repos/dojo/dojo/stargazers","contributors_url":"https://api.github.com/repos/dojo/dojo/contributors","subscribers_url":"https://api.github.com/repos/dojo/dojo/subscribers","subscription_url":"https://api.github.com/repos/dojo/dojo/subscription","commits_url":"https://api.github.com/repos/dojo/dojo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/dojo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/dojo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/dojo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/dojo/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/dojo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/dojo/merges","archive_url":"https://api.github.com/repos/dojo/dojo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/dojo/downloads","issues_url":"https://api.github.com/repos/dojo/dojo/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/dojo/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/dojo/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/dojo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/dojo/labels{/name}","releases_url":"https://api.github.com/repos/dojo/dojo/releases{/id}","created_at":"2013-05-19T19:50:18Z","updated_at":"2016-01-02T15:06:34Z","pushed_at":"2016-01-01T17:03:28Z","git_url":"git://github.com/dojo/dojo.git","ssh_url":"git@github.com:dojo/dojo.git","clone_url":"https://github.com/dojo/dojo.git","svn_url":"https://github.com/dojo/dojo","homepage":"https://dojotoolkit.org/","size":12750,"stargazers_count":744,"watchers_count":744,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":379,"mirror_url":null,"open_issues_count":8,"forks":379,"open_issues":8,"watchers":744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/dojo/pulls/194"},"html":{"href":"https://github.com/dojo/dojo/pull/194"},"issue":{"href":"https://api.github.com/repos/dojo/dojo/issues/194"},"comments":{"href":"https://api.github.com/repos/dojo/dojo/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/dojo/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/dojo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/dojo/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/dojo/statuses/cd5c236111a826653c48ae400dd0c3d43c22367a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":2}}