{"action":"created","issue":{"url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting/issues/424","repository_url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting","labels_url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting/issues/424/labels{/name}","comments_url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting/issues/424/comments","events_url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting/issues/424/events","html_url":"https://github.com/damianszczepanik/cucumber-reporting/pull/424","id":152434035,"number":424,"title":"Use bootstrap collapse function for message/embed content","user":{"login":"midopa","id":1522141,"avatar_url":"https://avatars.githubusercontent.com/u/1522141?v=3","gravatar_id":"","url":"https://api.github.com/users/midopa","html_url":"https://github.com/midopa","followers_url":"https://api.github.com/users/midopa/followers","following_url":"https://api.github.com/users/midopa/following{/other_user}","gists_url":"https://api.github.com/users/midopa/gists{/gist_id}","starred_url":"https://api.github.com/users/midopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midopa/subscriptions","organizations_url":"https://api.github.com/users/midopa/orgs","repos_url":"https://api.github.com/users/midopa/repos","events_url":"https://api.github.com/users/midopa/events{/privacy}","received_events_url":"https://api.github.com/users/midopa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-01T21:07:17Z","updated_at":"2016-05-02T07:41:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting/pulls/424","html_url":"https://github.com/damianszczepanik/cucumber-reporting/pull/424","diff_url":"https://github.com/damianszczepanik/cucumber-reporting/pull/424.diff","patch_url":"https://github.com/damianszczepanik/cucumber-reporting/pull/424.patch"},"body":"Was using custom JS to expand and collapse. Since bootstrap's collapse\r\nwas used recently for feature/scenario/step/hook collapsing, do the same\r\nso the code is more consistent.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/damianszczepanik/cucumber-reporting/pull/424%23issuecomment-216073078%22%2C%20%22https%3A//github.com/damianszczepanik/cucumber-reporting/pull/424%23discussion_r61711718%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/damianszczepanik/cucumber-reporting/pull/424%23issuecomment-216073078%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%23%23%20%5BCurrent%20coverage%5D%5Bcc-pull%5D%20is%20%2A%2A69.47%25%2A%2A%5Cn%3E%20Merging%20%5B%23424%5D%5Bcc-pull%5D%20into%20%5Bmaster%5D%5Bcc-base-branch%5D%20will%20not%20change%20coverage%5Cn%5Cn%5Cn%60%60%60diff%5Cn%40%40%20%20%20%20%20%20%20%20%20%20%20%20%20master%20%20%20%20%20%20%20%23424%20%20%20diff%20%40%40%5Cn%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%5Cn%20%20Files%20%20%20%20%20%20%20%20%20%20%20%2029%20%20%20%20%20%20%20%20%2029%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Lines%20%20%20%20%20%20%20%20%20%20%20655%20%20%20%20%20%20%20%20655%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Methods%20%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Messages%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Branches%20%20%20%20%20%20%20%20%2084%20%20%20%20%20%20%20%20%2084%20%20%20%20%20%20%20%20%20%20%5Cn%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%5Cn%20%20Hits%20%20%20%20%20%20%20%20%20%20%20%20455%20%20%20%20%20%20%20%20455%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Misses%20%20%20%20%20%20%20%20%20%20200%20%20%20%20%20%20%20%20200%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Partials%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%60%60%60%5Cn%5Cn%3E%20Powered%20by%20%5BCodecov%5D%28https%3A//codecov.io%3Fsrc%3Dpr%29.%20Last%20updated%20by%20%5Beb6b1c0...009e1a1%5D%5Bcc-compare%5D%5Cn%5Bcc-base-branch%5D%3A%20https%3A//codecov.io/gh/damianszczepanik/cucumber-reporting/branch/master%3Fsrc%3Dpr%5Cn%5Bcc-compare%5D%3A%20https%3A//codecov.io/gh/damianszczepanik/cucumber-reporting/compare/eb6b1c0cd0d2038f5affba063b614047f234a467...009e1a1f8bf193cef27e2e46bf241460c776e1eb%5Cn%5Bcc-pull%5D%3A%20https%3A//codecov.io/gh/damianszczepanik/cucumber-reporting/pull/424%3Fsrc%3Dpr%22%2C%20%22created_at%22%3A%20%222016-05-01T21%3A13%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/8655789%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/codecov-io%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%201dd13d335bfb82b68ae3301409a4c0bfdb517d93%20src/main/resources/templates/macros/report/embeddings.vm%207%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/damianszczepanik/cucumber-reporting/pull/424%23discussion_r61711718%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22ok%2C%20but%20by%20this%20change%20there%20is%20no%20clear%20UX%20that%20this%20div%20is%20expanded%5Cr%5Cn%5Cr%5Cnpreviously%20the%20label%20was%20presented%20as%20link%20so%20user%20knows%20that%20this%20is%20clickable%2C%20steps/hooks/elements%20has%20sign%20that%20indicates%20that%20div%20is%20already%20opened%20or%20can%20be%20opened%5Cr%5Cn%5Cr%5Cnnow%20you%20need%20to%20mouse%20over%20to%20see%20that%20this%20element%20is%20expandable%22%2C%20%22created_at%22%3A%20%222016-05-02T07%3A41%3A01Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9612911%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/damianszczepanik%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/main/resources/templates/macros/report/embeddings.vm%3AL51-62%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/damianszczepanik/cucumber-reporting/pull/424#issuecomment-216073078'>General Comment</a></b>\n- <a href='https://github.com/codecov-io'><img border=0 src='https://avatars.githubusercontent.com/u/8655789?v=3' height=16 width=16'></a> ## [Current coverage][cc-pull] is **69.47%**\n> Merging [#424][cc-pull] into [master][cc-base-branch] will not change coverage\n```diff\n@@             master       #424   diff @@\n==========================================\nFiles            29         29\nLines           655        655\nMethods           0          0\nMessages          0          0\nBranches         84         84\n==========================================\nHits            455        455\nMisses          200        200\nPartials          0          0\n```\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [eb6b1c0...009e1a1][cc-compare]\n[cc-base-branch]: https://codecov.io/gh/damianszczepanik/cucumber-reporting/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/damianszczepanik/cucumber-reporting/compare/eb6b1c0cd0d2038f5affba063b614047f234a467...009e1a1f8bf193cef27e2e46bf241460c776e1eb\n[cc-pull]: https://codecov.io/gh/damianszczepanik/cucumber-reporting/pull/424?src=pr\n- [ ] <a href='#crh-comment-Pull 1dd13d335bfb82b68ae3301409a4c0bfdb517d93 src/main/resources/templates/macros/report/embeddings.vm 7'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/damianszczepanik/cucumber-reporting/pull/424#discussion_r61711718'>File: src/main/resources/templates/macros/report/embeddings.vm:L51-62</a></b>\n- <a href='https://github.com/damianszczepanik'><img border=0 src='https://avatars.githubusercontent.com/u/9612911?v=3' height=16 width=16'></a> ok, but by this change there is no clear UX that this div is expanded\npreviously the label was presented as link so user knows that this is clickable, steps/hooks/elements has sign that indicates that div is already opened or can be opened\nnow you need to mouse over to see that this element is expandable\n\n\n<a href='https://www.codereviewhub.com/damianszczepanik/cucumber-reporting/pull/424?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/damianszczepanik/cucumber-reporting/pull/424?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/damianszczepanik/cucumber-reporting/pull/424'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting/issues/comments/216124483","html_url":"https://github.com/damianszczepanik/cucumber-reporting/pull/424#issuecomment-216124483","issue_url":"https://api.github.com/repos/damianszczepanik/cucumber-reporting/issues/424","id":216124483,"user":{"login":"damianszczepanik","id":9612911,"avatar_url":"https://avatars.githubusercontent.com/u/9612911?v=3","gravatar_id":"","url":"https://api.github.com/users/damianszczepanik","html_url":"https://github.com/damianszczepanik","followers_url":"https://api.github.com/users/damianszczepanik/followers","following_url":"https://api.github.com/users/damianszczepanik/following{/other_user}","gists_url":"https://api.github.com/users/damianszczepanik/gists{/gist_id}","starred_url":"https://api.github.com/users/damianszczepanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianszczepanik/subscriptions","organizations_url":"https://api.github.com/users/damianszczepanik/orgs","repos_url":"https://api.github.com/users/damianszczepanik/repos","events_url":"https://api.github.com/users/damianszczepanik/events{/privacy}","received_events_url":"https://api.github.com/users/damianszczepanik/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T07:41:48Z","updated_at":"2016-05-02T07:41:48Z","body":"Makes sure that embeddings are expandable and users instantly knows it. Also squash both commits into one"}}