{"action":"created","comment":{"url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/comments/59137218","id":59137218,"diff_hunk":"@@ -41,7 +41,49 @@ let check (contexts, finds) =\n           )\n           map\n     in\n-    List.fold_left create_varmap StringMap.empty contexts in\n+    List.fold_left create_varmap StringMap.empty contexts \n+   in\n+   let liblist = \n+    let rec add_lib_expre lis expre =","path":"src/semant.ml","position":8,"original_position":8,"commit_id":"307f40531e30e91789ccc29e6100a873811cf5f0","original_commit_id":"307f40531e30e91789ccc29e6100a873811cf5f0","user":{"login":"jzacsh","id":156228,"avatar_url":"https://avatars.githubusercontent.com/u/156228?v=3","gravatar_id":"","url":"https://api.github.com/users/jzacsh","html_url":"https://github.com/jzacsh","followers_url":"https://api.github.com/users/jzacsh/followers","following_url":"https://api.github.com/users/jzacsh/following{/other_user}","gists_url":"https://api.github.com/users/jzacsh/gists{/gist_id}","starred_url":"https://api.github.com/users/jzacsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzacsh/subscriptions","organizations_url":"https://api.github.com/users/jzacsh/orgs","repos_url":"https://api.github.com/users/jzacsh/repos","events_url":"https://api.github.com/users/jzacsh/events{/privacy}","received_events_url":"https://api.github.com/users/jzacsh/received_events","type":"User","site_admin":false},"body":"nit: `ocaml`-protip: matching is so common in ocaml, you can do thsi instead:\r\n\r\n```diff\r\n- let rec add_lib_expre lis expre =\r\n-   match expre with\r\n+ let rec add_lib_expre lis = function\r\n```\r\n_(this also gets rid of the problem where you have two `A.Expr` variables you need to distinguish)_","created_at":"2016-04-10T17:02:15Z","updated_at":"2016-04-10T17:02:15Z","html_url":"https://github.com/rxie25/PLT2016Spring/pull/68#discussion_r59137218","pull_request_url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/comments/59137218"},"html":{"href":"https://github.com/rxie25/PLT2016Spring/pull/68#discussion_r59137218"},"pull_request":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68","id":65729411,"html_url":"https://github.com/rxie25/PLT2016Spring/pull/68","diff_url":"https://github.com/rxie25/PLT2016Spring/pull/68.diff","patch_url":"https://github.com/rxie25/PLT2016Spring/pull/68.patch","issue_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/68","number":68,"state":"open","locked":false,"title":"update codegen.ml and semant.ml to generate header automatically","user":{"login":"kekeleila","id":10727215,"avatar_url":"https://avatars.githubusercontent.com/u/10727215?v=3","gravatar_id":"","url":"https://api.github.com/users/kekeleila","html_url":"https://github.com/kekeleila","followers_url":"https://api.github.com/users/kekeleila/followers","following_url":"https://api.github.com/users/kekeleila/following{/other_user}","gists_url":"https://api.github.com/users/kekeleila/gists{/gist_id}","starred_url":"https://api.github.com/users/kekeleila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kekeleila/subscriptions","organizations_url":"https://api.github.com/users/kekeleila/orgs","repos_url":"https://api.github.com/users/kekeleila/repos","events_url":"https://api.github.com/users/kekeleila/events{/privacy}","received_events_url":"https://api.github.com/users/kekeleila/received_events","type":"User","site_admin":false},"body":"Update semant.ml and codegen.ml to generate header automatically ","created_at":"2016-04-08T02:40:20Z","updated_at":"2016-04-10T17:02:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a4274078794d2eb79e34100ef04e845ba3ce27d","assignee":{"login":"jzacsh","id":156228,"avatar_url":"https://avatars.githubusercontent.com/u/156228?v=3","gravatar_id":"","url":"https://api.github.com/users/jzacsh","html_url":"https://github.com/jzacsh","followers_url":"https://api.github.com/users/jzacsh/followers","following_url":"https://api.github.com/users/jzacsh/following{/other_user}","gists_url":"https://api.github.com/users/jzacsh/gists{/gist_id}","starred_url":"https://api.github.com/users/jzacsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzacsh/subscriptions","organizations_url":"https://api.github.com/users/jzacsh/orgs","repos_url":"https://api.github.com/users/jzacsh/repos","events_url":"https://api.github.com/users/jzacsh/events{/privacy}","received_events_url":"https://api.github.com/users/jzacsh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68/commits","review_comments_url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68/comments","review_comment_url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/68/comments","statuses_url":"https://api.github.com/repos/rxie25/PLT2016Spring/statuses/307f40531e30e91789ccc29e6100a873811cf5f0","head":{"label":"rxie25:lanting-header3","ref":"lanting-header3","sha":"307f40531e30e91789ccc29e6100a873811cf5f0","user":{"login":"rxie25","id":10619450,"avatar_url":"https://avatars.githubusercontent.com/u/10619450?v=3","gravatar_id":"","url":"https://api.github.com/users/rxie25","html_url":"https://github.com/rxie25","followers_url":"https://api.github.com/users/rxie25/followers","following_url":"https://api.github.com/users/rxie25/following{/other_user}","gists_url":"https://api.github.com/users/rxie25/gists{/gist_id}","starred_url":"https://api.github.com/users/rxie25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxie25/subscriptions","organizations_url":"https://api.github.com/users/rxie25/orgs","repos_url":"https://api.github.com/users/rxie25/repos","events_url":"https://api.github.com/users/rxie25/events{/privacy}","received_events_url":"https://api.github.com/users/rxie25/received_events","type":"User","site_admin":false},"repo":{"id":50383397,"name":"PLT2016Spring","full_name":"rxie25/PLT2016Spring","owner":{"login":"rxie25","id":10619450,"avatar_url":"https://avatars.githubusercontent.com/u/10619450?v=3","gravatar_id":"","url":"https://api.github.com/users/rxie25","html_url":"https://github.com/rxie25","followers_url":"https://api.github.com/users/rxie25/followers","following_url":"https://api.github.com/users/rxie25/following{/other_user}","gists_url":"https://api.github.com/users/rxie25/gists{/gist_id}","starred_url":"https://api.github.com/users/rxie25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxie25/subscriptions","organizations_url":"https://api.github.com/users/rxie25/orgs","repos_url":"https://api.github.com/users/rxie25/repos","events_url":"https://api.github.com/users/rxie25/events{/privacy}","received_events_url":"https://api.github.com/users/rxie25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rxie25/PLT2016Spring","description":"PLT Team Project","fork":false,"url":"https://api.github.com/repos/rxie25/PLT2016Spring","forks_url":"https://api.github.com/repos/rxie25/PLT2016Spring/forks","keys_url":"https://api.github.com/repos/rxie25/PLT2016Spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rxie25/PLT2016Spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rxie25/PLT2016Spring/teams","hooks_url":"https://api.github.com/repos/rxie25/PLT2016Spring/hooks","issue_events_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/events{/number}","events_url":"https://api.github.com/repos/rxie25/PLT2016Spring/events","assignees_url":"https://api.github.com/repos/rxie25/PLT2016Spring/assignees{/user}","branches_url":"https://api.github.com/repos/rxie25/PLT2016Spring/branches{/branch}","tags_url":"https://api.github.com/repos/rxie25/PLT2016Spring/tags","blobs_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rxie25/PLT2016Spring/statuses/{sha}","languages_url":"https://api.github.com/repos/rxie25/PLT2016Spring/languages","stargazers_url":"https://api.github.com/repos/rxie25/PLT2016Spring/stargazers","contributors_url":"https://api.github.com/repos/rxie25/PLT2016Spring/contributors","subscribers_url":"https://api.github.com/repos/rxie25/PLT2016Spring/subscribers","subscription_url":"https://api.github.com/repos/rxie25/PLT2016Spring/subscription","commits_url":"https://api.github.com/repos/rxie25/PLT2016Spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/rxie25/PLT2016Spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/rxie25/PLT2016Spring/contents/{+path}","compare_url":"https://api.github.com/repos/rxie25/PLT2016Spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rxie25/PLT2016Spring/merges","archive_url":"https://api.github.com/repos/rxie25/PLT2016Spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rxie25/PLT2016Spring/downloads","issues_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues{/number}","pulls_url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls{/number}","milestones_url":"https://api.github.com/repos/rxie25/PLT2016Spring/milestones{/number}","notifications_url":"https://api.github.com/repos/rxie25/PLT2016Spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rxie25/PLT2016Spring/labels{/name}","releases_url":"https://api.github.com/repos/rxie25/PLT2016Spring/releases{/id}","deployments_url":"https://api.github.com/repos/rxie25/PLT2016Spring/deployments","created_at":"2016-01-25T21:49:20Z","updated_at":"2016-04-06T17:23:20Z","pushed_at":"2016-04-08T02:40:20Z","git_url":"git://github.com/rxie25/PLT2016Spring.git","ssh_url":"git@github.com:rxie25/PLT2016Spring.git","clone_url":"https://github.com/rxie25/PLT2016Spring.git","svn_url":"https://github.com/rxie25/PLT2016Spring","homepage":null,"size":342,"stargazers_count":3,"watchers_count":3,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":22,"forks":0,"open_issues":22,"watchers":3,"default_branch":"master"}},"base":{"label":"rxie25:master","ref":"master","sha":"b5c26365ef72eef72314726be4e134dcc4f7ba26","user":{"login":"rxie25","id":10619450,"avatar_url":"https://avatars.githubusercontent.com/u/10619450?v=3","gravatar_id":"","url":"https://api.github.com/users/rxie25","html_url":"https://github.com/rxie25","followers_url":"https://api.github.com/users/rxie25/followers","following_url":"https://api.github.com/users/rxie25/following{/other_user}","gists_url":"https://api.github.com/users/rxie25/gists{/gist_id}","starred_url":"https://api.github.com/users/rxie25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxie25/subscriptions","organizations_url":"https://api.github.com/users/rxie25/orgs","repos_url":"https://api.github.com/users/rxie25/repos","events_url":"https://api.github.com/users/rxie25/events{/privacy}","received_events_url":"https://api.github.com/users/rxie25/received_events","type":"User","site_admin":false},"repo":{"id":50383397,"name":"PLT2016Spring","full_name":"rxie25/PLT2016Spring","owner":{"login":"rxie25","id":10619450,"avatar_url":"https://avatars.githubusercontent.com/u/10619450?v=3","gravatar_id":"","url":"https://api.github.com/users/rxie25","html_url":"https://github.com/rxie25","followers_url":"https://api.github.com/users/rxie25/followers","following_url":"https://api.github.com/users/rxie25/following{/other_user}","gists_url":"https://api.github.com/users/rxie25/gists{/gist_id}","starred_url":"https://api.github.com/users/rxie25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxie25/subscriptions","organizations_url":"https://api.github.com/users/rxie25/orgs","repos_url":"https://api.github.com/users/rxie25/repos","events_url":"https://api.github.com/users/rxie25/events{/privacy}","received_events_url":"https://api.github.com/users/rxie25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rxie25/PLT2016Spring","description":"PLT Team Project","fork":false,"url":"https://api.github.com/repos/rxie25/PLT2016Spring","forks_url":"https://api.github.com/repos/rxie25/PLT2016Spring/forks","keys_url":"https://api.github.com/repos/rxie25/PLT2016Spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rxie25/PLT2016Spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rxie25/PLT2016Spring/teams","hooks_url":"https://api.github.com/repos/rxie25/PLT2016Spring/hooks","issue_events_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/events{/number}","events_url":"https://api.github.com/repos/rxie25/PLT2016Spring/events","assignees_url":"https://api.github.com/repos/rxie25/PLT2016Spring/assignees{/user}","branches_url":"https://api.github.com/repos/rxie25/PLT2016Spring/branches{/branch}","tags_url":"https://api.github.com/repos/rxie25/PLT2016Spring/tags","blobs_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rxie25/PLT2016Spring/statuses/{sha}","languages_url":"https://api.github.com/repos/rxie25/PLT2016Spring/languages","stargazers_url":"https://api.github.com/repos/rxie25/PLT2016Spring/stargazers","contributors_url":"https://api.github.com/repos/rxie25/PLT2016Spring/contributors","subscribers_url":"https://api.github.com/repos/rxie25/PLT2016Spring/subscribers","subscription_url":"https://api.github.com/repos/rxie25/PLT2016Spring/subscription","commits_url":"https://api.github.com/repos/rxie25/PLT2016Spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/rxie25/PLT2016Spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/rxie25/PLT2016Spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/rxie25/PLT2016Spring/contents/{+path}","compare_url":"https://api.github.com/repos/rxie25/PLT2016Spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rxie25/PLT2016Spring/merges","archive_url":"https://api.github.com/repos/rxie25/PLT2016Spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rxie25/PLT2016Spring/downloads","issues_url":"https://api.github.com/repos/rxie25/PLT2016Spring/issues{/number}","pulls_url":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls{/number}","milestones_url":"https://api.github.com/repos/rxie25/PLT2016Spring/milestones{/number}","notifications_url":"https://api.github.com/repos/rxie25/PLT2016Spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rxie25/PLT2016Spring/labels{/name}","releases_url":"https://api.github.com/repos/rxie25/PLT2016Spring/releases{/id}","deployments_url":"https://api.github.com/repos/rxie25/PLT2016Spring/deployments","created_at":"2016-01-25T21:49:20Z","updated_at":"2016-04-06T17:23:20Z","pushed_at":"2016-04-08T02:40:20Z","git_url":"git://github.com/rxie25/PLT2016Spring.git","ssh_url":"git@github.com:rxie25/PLT2016Spring.git","clone_url":"https://github.com/rxie25/PLT2016Spring.git","svn_url":"https://github.com/rxie25/PLT2016Spring","homepage":null,"size":342,"stargazers_count":3,"watchers_count":3,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":22,"forks":0,"open_issues":22,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68"},"html":{"href":"https://github.com/rxie25/PLT2016Spring/pull/68"},"issue":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/68"},"comments":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/rxie25/PLT2016Spring/statuses/307f40531e30e91789ccc29e6100a873811cf5f0"}}}}