{"action":"created","comment":{"url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments/62012594","id":62012594,"diff_hunk":"@@ -130,89 +130,89 @@ class AlphaThickSegmentComputer\n \n   // ----------------------- public types --------------------------------------\n   BOOST_STATIC_ASSERT(( TInputPoint::dimension == 2 ));\n-  BOOST_CONCEPT_ASSERT((boost_concepts::ReadableIterator<TConstIterator>)); \n- \n+  BOOST_CONCEPT_ASSERT((boost_concepts::ReadableIterator<TConstIterator>));\n+\n public:\n   /**\n    * Type of input point.\n    **/\n   typedef TInputPoint InputPoint;\n-  \n+\n   /**\n    * The container type of Input Point\n    **/\n   typedef std::vector< InputPoint > InputPointContainer;\n   typedef typename InputPointContainer::size_type Size;\n   typedef typename InputPointContainer::const_iterator ContainerConstIterator;\n   typedef typename DGtal::functions::Hull2D::ThicknessDefinition ThicknessDef;\n-  \n+\n   typedef typename InputPointContainer::iterator Iterator;\n   typedef TConstIterator ConstIterator;\n-  typedef ParallelStrip< SpaceND< 2,  DGtal::int32_t > ,true,true> Primitive;  \n-  \n+  typedef ParallelStrip< SpaceND< 2 > ,true,true> Primitive;  ","path":"src/DGtal/geometry/curves/AlphaThickSegmentComputer.h","position":76,"original_position":76,"commit_id":"a7cf0b15fde480eacbfa04128ea28d8d513d153c","original_commit_id":"a7cf0b15fde480eacbfa04128ea28d8d513d153c","user":{"login":"jlevallois","id":1493976,"avatar_url":"https://avatars.githubusercontent.com/u/1493976?v=3","gravatar_id":"","url":"https://api.github.com/users/jlevallois","html_url":"https://github.com/jlevallois","followers_url":"https://api.github.com/users/jlevallois/followers","following_url":"https://api.github.com/users/jlevallois/following{/other_user}","gists_url":"https://api.github.com/users/jlevallois/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevallois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevallois/subscriptions","organizations_url":"https://api.github.com/users/jlevallois/orgs","repos_url":"https://api.github.com/users/jlevallois/repos","events_url":"https://api.github.com/users/jlevallois/events{/privacy}","received_events_url":"https://api.github.com/users/jlevallois/received_events","type":"User","site_admin":false},"body":"Agree, in this case I need to change `testAlphaThickSgementComputer` who uses `Z2i::Point`/`Z2i::Domain`","created_at":"2016-05-04T09:36:13Z","updated_at":"2016-05-04T09:36:13Z","html_url":"https://github.com/DGtal-team/DGtal/pull/1163#discussion_r62012594","pull_request_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163","_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments/62012594"},"html":{"href":"https://github.com/DGtal-team/DGtal/pull/1163#discussion_r62012594"},"pull_request":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163"}}},"pull_request":{"url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163","id":68725967,"html_url":"https://github.com/DGtal-team/DGtal/pull/1163","diff_url":"https://github.com/DGtal-team/DGtal/pull/1163.diff","patch_url":"https://github.com/DGtal-team/DGtal/pull/1163.patch","issue_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/1163","number":1163,"state":"open","locked":false,"title":"Fixing arithmetic ring issue","user":{"login":"jlevallois","id":1493976,"avatar_url":"https://avatars.githubusercontent.com/u/1493976?v=3","gravatar_id":"","url":"https://api.github.com/users/jlevallois","html_url":"https://github.com/jlevallois","followers_url":"https://api.github.com/users/jlevallois/followers","following_url":"https://api.github.com/users/jlevallois/following{/other_user}","gists_url":"https://api.github.com/users/jlevallois/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevallois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevallois/subscriptions","organizations_url":"https://api.github.com/users/jlevallois/orgs","repos_url":"https://api.github.com/users/jlevallois/repos","events_url":"https://api.github.com/users/jlevallois/events{/privacy}","received_events_url":"https://api.github.com/users/jlevallois/received_events","type":"User","site_admin":false},"body":"# PR Description\r\n\r\nThe aim of this PR is to remove arithmetic ring issue when we change the integer type of `SpaceND`/`KhalimskySpaceND`.\r\nBy convention, we use `SpaceND<dim, int32_t>` and `KhalimskySpaceND<dim, int32_t>`.\r\nBut, in some case (if we want to reduce the memory footprint for example), we could be led to use `int16_t` instead of `int32_t` (or other).\r\nThe issue is that some algorithms are hard-coded to use `int32_t`. This PR try to resolve this issue.\r\n\r\n*(I'm sorry, the reviewing process will not be easy because my editor has deleted some unnecessary space in comments ...)*\r\n\r\n## Critical files modified\r\n\r\nThese files need to be closely reviewed.\r\n\r\n- `AlphaThickSegmentComputer.h`\r\n- `PowerMap.h` / `PowerMap.ih`\r\n- `VoronoiMap.h` / `VoronoiMap.ih`\r\n- `RigidTransformation3D.h`\r\n- `Display2DFactory.ih`\r\n- `DrawWithDisplay3DModifier.h`\r\n- `BasicPointFunctors.h`\r\n\r\n## Test files modified\r\n\r\n- `testAlphaThickSegmentComputer.cpp`\r\n- `testFrechetShortcut.cpp`\r\n- `testFreemanChain.cpp`\r\n- `testDistanceTransformationND.cpp`\r\n- `testImageSimple.cpp`\r\n- `testImageSpanIterators.cpp`\r\n- `testSliceImageFromFunctor.cpp`\r\n- `testDigitalSet.cpp`\r\n- `testHyperRectDomain-snippet.cpp`\r\n- `testHyperRectDomain.cpp`\r\n- `testCellularGridSpaceND.cpp`\r\n- `testSurfaceHelper.cpp`\r\n\r\n# Checklist\r\n\r\n- [ ] Unit-test of your feature with [Catch](http://dgtal.org/doc/stable/moduleCatch.html).\r\n- [ ] Doxygen documentation of the code completed (classes, methods, types, members...)\r\n- [ ] Documentation module page added or updated.\r\n- [ ] New entry in the [ChangeLog.md](https://github.com/DGtal-team/DGtal/blob/master/ChangeLog.md) added.\r\n- [ ] No warning raised in Debug ```cmake``` mode (otherwise, Travis C.I. will fail).\r\n- [ ] All continuous integration tests pass (Travis & appveyor)\r\n\r\n:octocat: ","created_at":"2016-05-03T15:35:24Z","updated_at":"2016-05-04T09:36:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2eb2af93725a79771547025bf5c5f3b4f37207e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163/commits","review_comments_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163/comments","review_comment_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/1163/comments","statuses_url":"https://api.github.com/repos/DGtal-team/DGtal/statuses/a7cf0b15fde480eacbfa04128ea28d8d513d153c","head":{"label":"jlevallois:FixArithmeticRing","ref":"FixArithmeticRing","sha":"a7cf0b15fde480eacbfa04128ea28d8d513d153c","user":{"login":"jlevallois","id":1493976,"avatar_url":"https://avatars.githubusercontent.com/u/1493976?v=3","gravatar_id":"","url":"https://api.github.com/users/jlevallois","html_url":"https://github.com/jlevallois","followers_url":"https://api.github.com/users/jlevallois/followers","following_url":"https://api.github.com/users/jlevallois/following{/other_user}","gists_url":"https://api.github.com/users/jlevallois/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevallois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevallois/subscriptions","organizations_url":"https://api.github.com/users/jlevallois/orgs","repos_url":"https://api.github.com/users/jlevallois/repos","events_url":"https://api.github.com/users/jlevallois/events{/privacy}","received_events_url":"https://api.github.com/users/jlevallois/received_events","type":"User","site_admin":false},"repo":{"id":3604924,"name":"DGtal","full_name":"jlevallois/DGtal","owner":{"login":"jlevallois","id":1493976,"avatar_url":"https://avatars.githubusercontent.com/u/1493976?v=3","gravatar_id":"","url":"https://api.github.com/users/jlevallois","html_url":"https://github.com/jlevallois","followers_url":"https://api.github.com/users/jlevallois/followers","following_url":"https://api.github.com/users/jlevallois/following{/other_user}","gists_url":"https://api.github.com/users/jlevallois/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevallois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevallois/subscriptions","organizations_url":"https://api.github.com/users/jlevallois/orgs","repos_url":"https://api.github.com/users/jlevallois/repos","events_url":"https://api.github.com/users/jlevallois/events{/privacy}","received_events_url":"https://api.github.com/users/jlevallois/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlevallois/DGtal","description":"Digital Geometry Tools and Algorithm Library","fork":true,"url":"https://api.github.com/repos/jlevallois/DGtal","forks_url":"https://api.github.com/repos/jlevallois/DGtal/forks","keys_url":"https://api.github.com/repos/jlevallois/DGtal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlevallois/DGtal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlevallois/DGtal/teams","hooks_url":"https://api.github.com/repos/jlevallois/DGtal/hooks","issue_events_url":"https://api.github.com/repos/jlevallois/DGtal/issues/events{/number}","events_url":"https://api.github.com/repos/jlevallois/DGtal/events","assignees_url":"https://api.github.com/repos/jlevallois/DGtal/assignees{/user}","branches_url":"https://api.github.com/repos/jlevallois/DGtal/branches{/branch}","tags_url":"https://api.github.com/repos/jlevallois/DGtal/tags","blobs_url":"https://api.github.com/repos/jlevallois/DGtal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlevallois/DGtal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlevallois/DGtal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlevallois/DGtal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlevallois/DGtal/statuses/{sha}","languages_url":"https://api.github.com/repos/jlevallois/DGtal/languages","stargazers_url":"https://api.github.com/repos/jlevallois/DGtal/stargazers","contributors_url":"https://api.github.com/repos/jlevallois/DGtal/contributors","subscribers_url":"https://api.github.com/repos/jlevallois/DGtal/subscribers","subscription_url":"https://api.github.com/repos/jlevallois/DGtal/subscription","commits_url":"https://api.github.com/repos/jlevallois/DGtal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlevallois/DGtal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlevallois/DGtal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlevallois/DGtal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlevallois/DGtal/contents/{+path}","compare_url":"https://api.github.com/repos/jlevallois/DGtal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlevallois/DGtal/merges","archive_url":"https://api.github.com/repos/jlevallois/DGtal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlevallois/DGtal/downloads","issues_url":"https://api.github.com/repos/jlevallois/DGtal/issues{/number}","pulls_url":"https://api.github.com/repos/jlevallois/DGtal/pulls{/number}","milestones_url":"https://api.github.com/repos/jlevallois/DGtal/milestones{/number}","notifications_url":"https://api.github.com/repos/jlevallois/DGtal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlevallois/DGtal/labels{/name}","releases_url":"https://api.github.com/repos/jlevallois/DGtal/releases{/id}","deployments_url":"https://api.github.com/repos/jlevallois/DGtal/deployments","created_at":"2012-03-02T18:32:48Z","updated_at":"2015-04-21T16:16:25Z","pushed_at":"2016-05-03T15:20:58Z","git_url":"git://github.com/jlevallois/DGtal.git","ssh_url":"git@github.com:jlevallois/DGtal.git","clone_url":"https://github.com/jlevallois/DGtal.git","svn_url":"https://github.com/jlevallois/DGtal","homepage":"http://liris.cnrs.fr/dgtal","size":145701,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DGtal-team:master","ref":"master","sha":"aaf3a31aa895048d6265bf324596bae4b0c28085","user":{"login":"DGtal-team","id":1013900,"avatar_url":"https://avatars.githubusercontent.com/u/1013900?v=3","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"repo":{"id":1709095,"name":"DGtal","full_name":"DGtal-team/DGtal","owner":{"login":"DGtal-team","id":1013900,"avatar_url":"https://avatars.githubusercontent.com/u/1013900?v=3","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DGtal-team/DGtal","description":"Digital Geometry Tools and Algorithm Library","fork":false,"url":"https://api.github.com/repos/DGtal-team/DGtal","forks_url":"https://api.github.com/repos/DGtal-team/DGtal/forks","keys_url":"https://api.github.com/repos/DGtal-team/DGtal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DGtal-team/DGtal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DGtal-team/DGtal/teams","hooks_url":"https://api.github.com/repos/DGtal-team/DGtal/hooks","issue_events_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/events{/number}","events_url":"https://api.github.com/repos/DGtal-team/DGtal/events","assignees_url":"https://api.github.com/repos/DGtal-team/DGtal/assignees{/user}","branches_url":"https://api.github.com/repos/DGtal-team/DGtal/branches{/branch}","tags_url":"https://api.github.com/repos/DGtal-team/DGtal/tags","blobs_url":"https://api.github.com/repos/DGtal-team/DGtal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DGtal-team/DGtal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DGtal-team/DGtal/git/refs{/sha}","trees_url":"https://api.github.com/repos/DGtal-team/DGtal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DGtal-team/DGtal/statuses/{sha}","languages_url":"https://api.github.com/repos/DGtal-team/DGtal/languages","stargazers_url":"https://api.github.com/repos/DGtal-team/DGtal/stargazers","contributors_url":"https://api.github.com/repos/DGtal-team/DGtal/contributors","subscribers_url":"https://api.github.com/repos/DGtal-team/DGtal/subscribers","subscription_url":"https://api.github.com/repos/DGtal-team/DGtal/subscription","commits_url":"https://api.github.com/repos/DGtal-team/DGtal/commits{/sha}","git_commits_url":"https://api.github.com/repos/DGtal-team/DGtal/git/commits{/sha}","comments_url":"https://api.github.com/repos/DGtal-team/DGtal/comments{/number}","issue_comment_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/comments{/number}","contents_url":"https://api.github.com/repos/DGtal-team/DGtal/contents/{+path}","compare_url":"https://api.github.com/repos/DGtal-team/DGtal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DGtal-team/DGtal/merges","archive_url":"https://api.github.com/repos/DGtal-team/DGtal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DGtal-team/DGtal/downloads","issues_url":"https://api.github.com/repos/DGtal-team/DGtal/issues{/number}","pulls_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls{/number}","milestones_url":"https://api.github.com/repos/DGtal-team/DGtal/milestones{/number}","notifications_url":"https://api.github.com/repos/DGtal-team/DGtal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DGtal-team/DGtal/labels{/name}","releases_url":"https://api.github.com/repos/DGtal-team/DGtal/releases{/id}","deployments_url":"https://api.github.com/repos/DGtal-team/DGtal/deployments","created_at":"2011-05-06T00:20:52Z","updated_at":"2016-04-07T16:12:33Z","pushed_at":"2016-05-04T07:02:37Z","git_url":"git://github.com/DGtal-team/DGtal.git","ssh_url":"git@github.com:DGtal-team/DGtal.git","clone_url":"https://github.com/DGtal-team/DGtal.git","svn_url":"https://github.com/DGtal-team/DGtal","homepage":"http://dgtal.org","size":202812,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":40,"forks":49,"open_issues":40,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163"},"html":{"href":"https://github.com/DGtal-team/DGtal/pull/1163"},"issue":{"href":"https://api.github.com/repos/DGtal-team/DGtal/issues/1163"},"comments":{"href":"https://api.github.com/repos/DGtal-team/DGtal/issues/1163/comments"},"review_comments":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163/comments"},"review_comment":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1163/commits"},"statuses":{"href":"https://api.github.com/repos/DGtal-team/DGtal/statuses/a7cf0b15fde480eacbfa04128ea28d8d513d153c"}}}}