{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/14","id":88328485,"html_url":"https://github.com/jeffmay/play-json-ops/pull/14","diff_url":"https://github.com/jeffmay/play-json-ops/pull/14.diff","patch_url":"https://github.com/jeffmay/play-json-ops/pull/14.patch","issue_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues/14","number":14,"state":"closed","locked":false,"title":"Moved test code out of play-json-ops to avoid dependency on test project","user":{"login":"jeffmay","id":755988,"avatar_url":"https://avatars.githubusercontent.com/u/755988?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmay","html_url":"https://github.com/jeffmay","followers_url":"https://api.github.com/users/jeffmay/followers","following_url":"https://api.github.com/users/jeffmay/following{/other_user}","gists_url":"https://api.github.com/users/jeffmay/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmay/subscriptions","organizations_url":"https://api.github.com/users/jeffmay/orgs","repos_url":"https://api.github.com/users/jeffmay/repos","events_url":"https://api.github.com/users/jeffmay/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmay/received_events","type":"User","site_admin":false},"body":"@egprentice @chrissalij-r @vodopis \r\n\r\nOk, after diving into ivy a bit, it appears that the dependency on scalacheck-ops appears in the compile dependency of play-json-ops because it's test project has a dependency on it. This must mean that the behavior of `% Test` is different between using `dependsOn` and adding it to `libraryDependencies`. Phew... I think this is the fix though.\r\n\r\nBefore:\r\n```\r\n\t<dependencies>\r\n\r\n\t\t<dependency org=\"org.scala-lang\" name=\"scala-library\" rev=\"2.11.7\" conf=\"compile->default(compile)\"/>\r\n\t\t<dependency org=\"com.rallyhealth\" name=\"play-json-tests_2.11\" rev=\"1.3.0\" conf=\"test->default(compile)\"/>\r\n\t\t<dependency org=\"com.typesafe.play\" name=\"play-json_2.11\" rev=\"2.3.10\" conf=\"compile->default(compile)\"/>\r\n\t\t<override org=\"org.scala-lang\" module=\"scala-library\" matcher=\"exact\" rev=\"2.11.7\"/>\r\n\t\t<override org=\"org.scala-lang\" module=\"scala-compiler\" matcher=\"exact\" rev=\"2.11.7\"/>\r\n\t\t<override org=\"org.scala-lang\" module=\"scala-reflect\" matcher=\"exact\" rev=\"2.11.7\"/>\r\n\t</dependencies>\r\n```\r\n\r\nAfter:\r\n```\r\n\t<dependencies>\r\n\r\n\t\t<dependency org=\"org.scala-lang\" name=\"scala-library\" rev=\"2.11.8\" conf=\"compile->default(compile)\"/>\r\n\t\t<dependency org=\"org.scoverage\" name=\"scalac-scoverage-runtime_2.11\" rev=\"1.1.1\" transitive=\"false\" conf=\"provided->default(compile)\"/>\r\n\t\t<dependency org=\"org.scoverage\" name=\"scalac-scoverage-plugin_2.11\" rev=\"1.1.1\" transitive=\"false\" conf=\"provided->default(compile)\"/>\r\n\t\t<dependency org=\"com.typesafe.play\" name=\"play-json_2.11\" rev=\"2.3.10\" conf=\"compile->default(compile)\"/>\r\n\t</dependencies>\r\n```","created_at":"2016-10-06T19:47:05Z","updated_at":"2016-10-06T19:52:56Z","closed_at":"2016-10-06T19:52:56Z","merged_at":"2016-10-06T19:52:56Z","merge_commit_sha":"1f2cf72b3b97329e34f0d9cc3fc8455407d8390a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/14/commits","review_comments_url":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/14/comments","review_comment_url":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues/14/comments","statuses_url":"https://api.github.com/repos/jeffmay/play-json-ops/statuses/9a1d28e379102f569f8bd925422aa5bcd9effc0b","head":{"label":"jeffmay:fix-dependency-graph","ref":"fix-dependency-graph","sha":"9a1d28e379102f569f8bd925422aa5bcd9effc0b","user":{"login":"jeffmay","id":755988,"avatar_url":"https://avatars.githubusercontent.com/u/755988?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmay","html_url":"https://github.com/jeffmay","followers_url":"https://api.github.com/users/jeffmay/followers","following_url":"https://api.github.com/users/jeffmay/following{/other_user}","gists_url":"https://api.github.com/users/jeffmay/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmay/subscriptions","organizations_url":"https://api.github.com/users/jeffmay/orgs","repos_url":"https://api.github.com/users/jeffmay/repos","events_url":"https://api.github.com/users/jeffmay/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmay/received_events","type":"User","site_admin":false},"repo":{"id":33217828,"name":"play-json-ops","full_name":"jeffmay/play-json-ops","owner":{"login":"jeffmay","id":755988,"avatar_url":"https://avatars.githubusercontent.com/u/755988?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmay","html_url":"https://github.com/jeffmay","followers_url":"https://api.github.com/users/jeffmay/followers","following_url":"https://api.github.com/users/jeffmay/following{/other_user}","gists_url":"https://api.github.com/users/jeffmay/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmay/subscriptions","organizations_url":"https://api.github.com/users/jeffmay/orgs","repos_url":"https://api.github.com/users/jeffmay/repos","events_url":"https://api.github.com/users/jeffmay/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffmay/play-json-ops","description":"Common Play Json implicits and helper methods","fork":false,"url":"https://api.github.com/repos/jeffmay/play-json-ops","forks_url":"https://api.github.com/repos/jeffmay/play-json-ops/forks","keys_url":"https://api.github.com/repos/jeffmay/play-json-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmay/play-json-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmay/play-json-ops/teams","hooks_url":"https://api.github.com/repos/jeffmay/play-json-ops/hooks","issue_events_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmay/play-json-ops/events","assignees_url":"https://api.github.com/repos/jeffmay/play-json-ops/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmay/play-json-ops/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmay/play-json-ops/tags","blobs_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmay/play-json-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmay/play-json-ops/languages","stargazers_url":"https://api.github.com/repos/jeffmay/play-json-ops/stargazers","contributors_url":"https://api.github.com/repos/jeffmay/play-json-ops/contributors","subscribers_url":"https://api.github.com/repos/jeffmay/play-json-ops/subscribers","subscription_url":"https://api.github.com/repos/jeffmay/play-json-ops/subscription","commits_url":"https://api.github.com/repos/jeffmay/play-json-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmay/play-json-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmay/play-json-ops/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmay/play-json-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmay/play-json-ops/merges","archive_url":"https://api.github.com/repos/jeffmay/play-json-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmay/play-json-ops/downloads","issues_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmay/play-json-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmay/play-json-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmay/play-json-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmay/play-json-ops/labels{/name}","releases_url":"https://api.github.com/repos/jeffmay/play-json-ops/releases{/id}","deployments_url":"https://api.github.com/repos/jeffmay/play-json-ops/deployments","created_at":"2015-04-01T00:34:00Z","updated_at":"2016-09-19T16:56:01Z","pushed_at":"2016-10-06T19:52:56Z","git_url":"git://github.com/jeffmay/play-json-ops.git","ssh_url":"git@github.com:jeffmay/play-json-ops.git","clone_url":"https://github.com/jeffmay/play-json-ops.git","svn_url":"https://github.com/jeffmay/play-json-ops","homepage":null,"size":118,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"jeffmay:master","ref":"master","sha":"fc8f6cc7f48de645322541efb3c9f2d1592ce3cd","user":{"login":"jeffmay","id":755988,"avatar_url":"https://avatars.githubusercontent.com/u/755988?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmay","html_url":"https://github.com/jeffmay","followers_url":"https://api.github.com/users/jeffmay/followers","following_url":"https://api.github.com/users/jeffmay/following{/other_user}","gists_url":"https://api.github.com/users/jeffmay/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmay/subscriptions","organizations_url":"https://api.github.com/users/jeffmay/orgs","repos_url":"https://api.github.com/users/jeffmay/repos","events_url":"https://api.github.com/users/jeffmay/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmay/received_events","type":"User","site_admin":false},"repo":{"id":33217828,"name":"play-json-ops","full_name":"jeffmay/play-json-ops","owner":{"login":"jeffmay","id":755988,"avatar_url":"https://avatars.githubusercontent.com/u/755988?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmay","html_url":"https://github.com/jeffmay","followers_url":"https://api.github.com/users/jeffmay/followers","following_url":"https://api.github.com/users/jeffmay/following{/other_user}","gists_url":"https://api.github.com/users/jeffmay/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmay/subscriptions","organizations_url":"https://api.github.com/users/jeffmay/orgs","repos_url":"https://api.github.com/users/jeffmay/repos","events_url":"https://api.github.com/users/jeffmay/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffmay/play-json-ops","description":"Common Play Json implicits and helper methods","fork":false,"url":"https://api.github.com/repos/jeffmay/play-json-ops","forks_url":"https://api.github.com/repos/jeffmay/play-json-ops/forks","keys_url":"https://api.github.com/repos/jeffmay/play-json-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmay/play-json-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmay/play-json-ops/teams","hooks_url":"https://api.github.com/repos/jeffmay/play-json-ops/hooks","issue_events_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmay/play-json-ops/events","assignees_url":"https://api.github.com/repos/jeffmay/play-json-ops/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmay/play-json-ops/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmay/play-json-ops/tags","blobs_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmay/play-json-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmay/play-json-ops/languages","stargazers_url":"https://api.github.com/repos/jeffmay/play-json-ops/stargazers","contributors_url":"https://api.github.com/repos/jeffmay/play-json-ops/contributors","subscribers_url":"https://api.github.com/repos/jeffmay/play-json-ops/subscribers","subscription_url":"https://api.github.com/repos/jeffmay/play-json-ops/subscription","commits_url":"https://api.github.com/repos/jeffmay/play-json-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmay/play-json-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmay/play-json-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmay/play-json-ops/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmay/play-json-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmay/play-json-ops/merges","archive_url":"https://api.github.com/repos/jeffmay/play-json-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmay/play-json-ops/downloads","issues_url":"https://api.github.com/repos/jeffmay/play-json-ops/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmay/play-json-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmay/play-json-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmay/play-json-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmay/play-json-ops/labels{/name}","releases_url":"https://api.github.com/repos/jeffmay/play-json-ops/releases{/id}","deployments_url":"https://api.github.com/repos/jeffmay/play-json-ops/deployments","created_at":"2015-04-01T00:34:00Z","updated_at":"2016-09-19T16:56:01Z","pushed_at":"2016-10-06T19:52:56Z","git_url":"git://github.com/jeffmay/play-json-ops.git","ssh_url":"git@github.com:jeffmay/play-json-ops.git","clone_url":"https://github.com/jeffmay/play-json-ops.git","svn_url":"https://github.com/jeffmay/play-json-ops","homepage":null,"size":118,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/14"},"html":{"href":"https://github.com/jeffmay/play-json-ops/pull/14"},"issue":{"href":"https://api.github.com/repos/jeffmay/play-json-ops/issues/14"},"comments":{"href":"https://api.github.com/repos/jeffmay/play-json-ops/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeffmay/play-json-ops/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/jeffmay/play-json-ops/statuses/9a1d28e379102f569f8bd925422aa5bcd9effc0b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeffmay","id":755988,"avatar_url":"https://avatars.githubusercontent.com/u/755988?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmay","html_url":"https://github.com/jeffmay","followers_url":"https://api.github.com/users/jeffmay/followers","following_url":"https://api.github.com/users/jeffmay/following{/other_user}","gists_url":"https://api.github.com/users/jeffmay/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmay/subscriptions","organizations_url":"https://api.github.com/users/jeffmay/orgs","repos_url":"https://api.github.com/users/jeffmay/repos","events_url":"https://api.github.com/users/jeffmay/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmay/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":2,"deletions":9,"changed_files":8}}
{"actor":{"display_login":"jeffmay"}}