{"action":"created","comment":{"url":"https://api.github.com/repos/nmayorov/allan-variance/pulls/comments/89296036","pull_request_review_id":9841491,"id":89296036,"diff_hunk":"@@ -7,25 +7,25 @@\n \n \n def allan_variance(x, dt=1, min_cluster_size=1, min_cluster_count='auto',\n-                   n_clusters=100):\n-    \"\"\"Compute Allan variance (AV).\n-    \n+                   n_clusters=100, input_mode=\"increment\"):","path":"allan_variance.py","position":7,"original_position":7,"commit_id":"30aaefa9eeb51b7ece520738b0046f85af71b428","original_commit_id":"72ad710bd2f157d0eb9d92465f307b55cacc43d0","user":{"login":"nmayorov","id":7074023,"avatar_url":"https://avatars.githubusercontent.com/u/7074023?v=3","gravatar_id":"","url":"https://api.github.com/users/nmayorov","html_url":"https://github.com/nmayorov","followers_url":"https://api.github.com/users/nmayorov/followers","following_url":"https://api.github.com/users/nmayorov/following{/other_user}","gists_url":"https://api.github.com/users/nmayorov/gists{/gist_id}","starred_url":"https://api.github.com/users/nmayorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmayorov/subscriptions","organizations_url":"https://api.github.com/users/nmayorov/orgs","repos_url":"https://api.github.com/users/nmayorov/repos","events_url":"https://api.github.com/users/nmayorov/events{/privacy}","received_events_url":"https://api.github.com/users/nmayorov/received_events","type":"User","site_admin":false},"body":"> This is a question of the universality of the code. And the parameter is the easiest way.\r\n\r\nYou can quickly achieve that by just passing `x * dt` when necessary. It's even less text to type. But in this case I agree that having this parameter makes sense to point out this difference in the interpretation of the input.\r\n\r\n> Can you help? ;)\r\n\r\nSure, I will thing about this later.","created_at":"2016-11-23T11:16:18Z","updated_at":"2016-11-23T11:36:01Z","html_url":"https://github.com/nmayorov/allan-variance/pull/1#discussion_r89296036","pull_request_url":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/nmayorov/allan-variance/pulls/comments/89296036"},"html":{"href":"https://github.com/nmayorov/allan-variance/pull/1#discussion_r89296036"},"pull_request":{"href":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1","id":94807487,"html_url":"https://github.com/nmayorov/allan-variance/pull/1","diff_url":"https://github.com/nmayorov/allan-variance/pull/1.diff","patch_url":"https://github.com/nmayorov/allan-variance/pull/1.patch","issue_url":"https://api.github.com/repos/nmayorov/allan-variance/issues/1","number":1,"state":"open","locked":false,"title":"allan_deviation, input_mode are added, int64 is fixed","user":{"login":"dinya","id":2182222,"avatar_url":"https://avatars.githubusercontent.com/u/2182222?v=3","gravatar_id":"","url":"https://api.github.com/users/dinya","html_url":"https://github.com/dinya","followers_url":"https://api.github.com/users/dinya/followers","following_url":"https://api.github.com/users/dinya/following{/other_user}","gists_url":"https://api.github.com/users/dinya/gists{/gist_id}","starred_url":"https://api.github.com/users/dinya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinya/subscriptions","organizations_url":"https://api.github.com/users/dinya/orgs","repos_url":"https://api.github.com/users/dinya/repos","events_url":"https://api.github.com/users/dinya/events{/privacy}","received_events_url":"https://api.github.com/users/dinya/received_events","type":"User","site_admin":false},"body":"1. ``allan_deviation`` function is added\r\n2. ``input_mode`` parameter for ``allan_variance`` for a more flexible interpretation of the input data (as mean and increment)\r\n3. ``allan_variance.py:75: RuntimeWarning: overflow encountered in long_scalars: avar[i] = np.mean(c**2, axis=0) / k**2`` error is fixed","created_at":"2016-11-22T12:49:55Z","updated_at":"2016-11-23T11:37:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1b7c888f9c184ffc461735394705127d855ba79","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nmayorov/allan-variance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nmayorov/allan-variance/issues/1/comments","statuses_url":"https://api.github.com/repos/nmayorov/allan-variance/statuses/30aaefa9eeb51b7ece520738b0046f85af71b428","head":{"label":"dinya:master","ref":"master","sha":"30aaefa9eeb51b7ece520738b0046f85af71b428","user":{"login":"dinya","id":2182222,"avatar_url":"https://avatars.githubusercontent.com/u/2182222?v=3","gravatar_id":"","url":"https://api.github.com/users/dinya","html_url":"https://github.com/dinya","followers_url":"https://api.github.com/users/dinya/followers","following_url":"https://api.github.com/users/dinya/following{/other_user}","gists_url":"https://api.github.com/users/dinya/gists{/gist_id}","starred_url":"https://api.github.com/users/dinya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinya/subscriptions","organizations_url":"https://api.github.com/users/dinya/orgs","repos_url":"https://api.github.com/users/dinya/repos","events_url":"https://api.github.com/users/dinya/events{/privacy}","received_events_url":"https://api.github.com/users/dinya/received_events","type":"User","site_admin":false},"repo":{"id":74433863,"name":"allan-variance","full_name":"dinya/allan-variance","owner":{"login":"dinya","id":2182222,"avatar_url":"https://avatars.githubusercontent.com/u/2182222?v=3","gravatar_id":"","url":"https://api.github.com/users/dinya","html_url":"https://github.com/dinya","followers_url":"https://api.github.com/users/dinya/followers","following_url":"https://api.github.com/users/dinya/following{/other_user}","gists_url":"https://api.github.com/users/dinya/gists{/gist_id}","starred_url":"https://api.github.com/users/dinya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinya/subscriptions","organizations_url":"https://api.github.com/users/dinya/orgs","repos_url":"https://api.github.com/users/dinya/repos","events_url":"https://api.github.com/users/dinya/events{/privacy}","received_events_url":"https://api.github.com/users/dinya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dinya/allan-variance","description":"Simple allan variance in Python","fork":true,"url":"https://api.github.com/repos/dinya/allan-variance","forks_url":"https://api.github.com/repos/dinya/allan-variance/forks","keys_url":"https://api.github.com/repos/dinya/allan-variance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dinya/allan-variance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dinya/allan-variance/teams","hooks_url":"https://api.github.com/repos/dinya/allan-variance/hooks","issue_events_url":"https://api.github.com/repos/dinya/allan-variance/issues/events{/number}","events_url":"https://api.github.com/repos/dinya/allan-variance/events","assignees_url":"https://api.github.com/repos/dinya/allan-variance/assignees{/user}","branches_url":"https://api.github.com/repos/dinya/allan-variance/branches{/branch}","tags_url":"https://api.github.com/repos/dinya/allan-variance/tags","blobs_url":"https://api.github.com/repos/dinya/allan-variance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dinya/allan-variance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dinya/allan-variance/git/refs{/sha}","trees_url":"https://api.github.com/repos/dinya/allan-variance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dinya/allan-variance/statuses/{sha}","languages_url":"https://api.github.com/repos/dinya/allan-variance/languages","stargazers_url":"https://api.github.com/repos/dinya/allan-variance/stargazers","contributors_url":"https://api.github.com/repos/dinya/allan-variance/contributors","subscribers_url":"https://api.github.com/repos/dinya/allan-variance/subscribers","subscription_url":"https://api.github.com/repos/dinya/allan-variance/subscription","commits_url":"https://api.github.com/repos/dinya/allan-variance/commits{/sha}","git_commits_url":"https://api.github.com/repos/dinya/allan-variance/git/commits{/sha}","comments_url":"https://api.github.com/repos/dinya/allan-variance/comments{/number}","issue_comment_url":"https://api.github.com/repos/dinya/allan-variance/issues/comments{/number}","contents_url":"https://api.github.com/repos/dinya/allan-variance/contents/{+path}","compare_url":"https://api.github.com/repos/dinya/allan-variance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dinya/allan-variance/merges","archive_url":"https://api.github.com/repos/dinya/allan-variance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dinya/allan-variance/downloads","issues_url":"https://api.github.com/repos/dinya/allan-variance/issues{/number}","pulls_url":"https://api.github.com/repos/dinya/allan-variance/pulls{/number}","milestones_url":"https://api.github.com/repos/dinya/allan-variance/milestones{/number}","notifications_url":"https://api.github.com/repos/dinya/allan-variance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dinya/allan-variance/labels{/name}","releases_url":"https://api.github.com/repos/dinya/allan-variance/releases{/id}","deployments_url":"https://api.github.com/repos/dinya/allan-variance/deployments","created_at":"2016-11-22T04:20:46Z","updated_at":"2016-11-22T04:20:47Z","pushed_at":"2016-11-23T07:45:27Z","git_url":"git://github.com/dinya/allan-variance.git","ssh_url":"git@github.com:dinya/allan-variance.git","clone_url":"https://github.com/dinya/allan-variance.git","svn_url":"https://github.com/dinya/allan-variance","homepage":"","size":66,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nmayorov:master","ref":"master","sha":"25e1f3fc42fd607d6c755e5d0be6ced811306247","user":{"login":"nmayorov","id":7074023,"avatar_url":"https://avatars.githubusercontent.com/u/7074023?v=3","gravatar_id":"","url":"https://api.github.com/users/nmayorov","html_url":"https://github.com/nmayorov","followers_url":"https://api.github.com/users/nmayorov/followers","following_url":"https://api.github.com/users/nmayorov/following{/other_user}","gists_url":"https://api.github.com/users/nmayorov/gists{/gist_id}","starred_url":"https://api.github.com/users/nmayorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmayorov/subscriptions","organizations_url":"https://api.github.com/users/nmayorov/orgs","repos_url":"https://api.github.com/users/nmayorov/repos","events_url":"https://api.github.com/users/nmayorov/events{/privacy}","received_events_url":"https://api.github.com/users/nmayorov/received_events","type":"User","site_admin":false},"repo":{"id":72187608,"name":"allan-variance","full_name":"nmayorov/allan-variance","owner":{"login":"nmayorov","id":7074023,"avatar_url":"https://avatars.githubusercontent.com/u/7074023?v=3","gravatar_id":"","url":"https://api.github.com/users/nmayorov","html_url":"https://github.com/nmayorov","followers_url":"https://api.github.com/users/nmayorov/followers","following_url":"https://api.github.com/users/nmayorov/following{/other_user}","gists_url":"https://api.github.com/users/nmayorov/gists{/gist_id}","starred_url":"https://api.github.com/users/nmayorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmayorov/subscriptions","organizations_url":"https://api.github.com/users/nmayorov/orgs","repos_url":"https://api.github.com/users/nmayorov/repos","events_url":"https://api.github.com/users/nmayorov/events{/privacy}","received_events_url":"https://api.github.com/users/nmayorov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmayorov/allan-variance","description":"Simple allan variance in Python","fork":false,"url":"https://api.github.com/repos/nmayorov/allan-variance","forks_url":"https://api.github.com/repos/nmayorov/allan-variance/forks","keys_url":"https://api.github.com/repos/nmayorov/allan-variance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmayorov/allan-variance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmayorov/allan-variance/teams","hooks_url":"https://api.github.com/repos/nmayorov/allan-variance/hooks","issue_events_url":"https://api.github.com/repos/nmayorov/allan-variance/issues/events{/number}","events_url":"https://api.github.com/repos/nmayorov/allan-variance/events","assignees_url":"https://api.github.com/repos/nmayorov/allan-variance/assignees{/user}","branches_url":"https://api.github.com/repos/nmayorov/allan-variance/branches{/branch}","tags_url":"https://api.github.com/repos/nmayorov/allan-variance/tags","blobs_url":"https://api.github.com/repos/nmayorov/allan-variance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmayorov/allan-variance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmayorov/allan-variance/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmayorov/allan-variance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmayorov/allan-variance/statuses/{sha}","languages_url":"https://api.github.com/repos/nmayorov/allan-variance/languages","stargazers_url":"https://api.github.com/repos/nmayorov/allan-variance/stargazers","contributors_url":"https://api.github.com/repos/nmayorov/allan-variance/contributors","subscribers_url":"https://api.github.com/repos/nmayorov/allan-variance/subscribers","subscription_url":"https://api.github.com/repos/nmayorov/allan-variance/subscription","commits_url":"https://api.github.com/repos/nmayorov/allan-variance/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmayorov/allan-variance/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmayorov/allan-variance/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmayorov/allan-variance/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmayorov/allan-variance/contents/{+path}","compare_url":"https://api.github.com/repos/nmayorov/allan-variance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmayorov/allan-variance/merges","archive_url":"https://api.github.com/repos/nmayorov/allan-variance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmayorov/allan-variance/downloads","issues_url":"https://api.github.com/repos/nmayorov/allan-variance/issues{/number}","pulls_url":"https://api.github.com/repos/nmayorov/allan-variance/pulls{/number}","milestones_url":"https://api.github.com/repos/nmayorov/allan-variance/milestones{/number}","notifications_url":"https://api.github.com/repos/nmayorov/allan-variance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmayorov/allan-variance/labels{/name}","releases_url":"https://api.github.com/repos/nmayorov/allan-variance/releases{/id}","deployments_url":"https://api.github.com/repos/nmayorov/allan-variance/deployments","created_at":"2016-10-28T08:10:47Z","updated_at":"2016-11-18T06:02:18Z","pushed_at":"2016-11-23T07:45:28Z","git_url":"git://github.com/nmayorov/allan-variance.git","ssh_url":"git@github.com:nmayorov/allan-variance.git","clone_url":"https://github.com/nmayorov/allan-variance.git","svn_url":"https://github.com/nmayorov/allan-variance","homepage":"","size":20,"stargazers_count":2,"watchers_count":2,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1"},"html":{"href":"https://github.com/nmayorov/allan-variance/pull/1"},"issue":{"href":"https://api.github.com/repos/nmayorov/allan-variance/issues/1"},"comments":{"href":"https://api.github.com/repos/nmayorov/allan-variance/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nmayorov/allan-variance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nmayorov/allan-variance/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nmayorov/allan-variance/statuses/30aaefa9eeb51b7ece520738b0046f85af71b428"}}}}
{"actor":{"display_login":"nmayorov"}}