{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/comments/67568422","id":67568422,"diff_hunk":"@@ -0,0 +1,97 @@\n+/*\n+ * This file is part of Sponge, licensed under the MIT License (MIT).\n+ *\n+ * Copyright (c) SpongePowered <https://www.spongepowered.org>\n+ * Copyright (c) contributors\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+package org.spongepowered.server.launch.plugin;\n+\n+import net.minecraft.launchwrapper.Launch;\n+\n+import java.net.MalformedURLException;\n+import java.nio.file.Path;\n+import java.util.Optional;\n+\n+import javax.annotation.Nullable;\n+\n+public final class PluginSource {\n+\n+    public static final PluginSource CLASSPATH = new PluginSource();\n+\n+    private final Optional<Path> source;\n+    private boolean onClasspath;\n+\n+    private PluginSource() {\n+        this.source = Optional.empty();\n+        this.onClasspath = true;\n+    }\n+\n+    PluginSource(Path path) {\n+        this.source = Optional.of(path);\n+    }\n+\n+    public Optional<Path> getPath() {\n+        return this.source;\n+    }\n+\n+    public void addToClasspath() {","path":"src/main/java/org/spongepowered/server/launch/plugin/PluginSource.java","position":55,"original_position":55,"commit_id":"3adce04893e53fa1674fcdfd76348f67ae754b48","original_commit_id":"3adce04893e53fa1674fcdfd76348f67ae754b48","user":{"login":"Mumfrey","id":1147071,"avatar_url":"https://avatars.githubusercontent.com/u/1147071?v=3","gravatar_id":"","url":"https://api.github.com/users/Mumfrey","html_url":"https://github.com/Mumfrey","followers_url":"https://api.github.com/users/Mumfrey/followers","following_url":"https://api.github.com/users/Mumfrey/following{/other_user}","gists_url":"https://api.github.com/users/Mumfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/Mumfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mumfrey/subscriptions","organizations_url":"https://api.github.com/users/Mumfrey/orgs","repos_url":"https://api.github.com/users/Mumfrey/repos","events_url":"https://api.github.com/users/Mumfrey/events{/privacy}","received_events_url":"https://api.github.com/users/Mumfrey/received_events","type":"User","site_admin":false},"body":"This is exactly how I do this in LiteLoader, I approve!","created_at":"2016-06-17T20:11:01Z","updated_at":"2016-06-17T20:11:01Z","html_url":"https://github.com/SpongePowered/SpongeVanilla/pull/250#discussion_r67568422","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/comments/67568422"},"html":{"href":"https://github.com/SpongePowered/SpongeVanilla/pull/250#discussion_r67568422"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250","id":74286579,"html_url":"https://github.com/SpongePowered/SpongeVanilla/pull/250","diff_url":"https://github.com/SpongePowered/SpongeVanilla/pull/250.diff","patch_url":"https://github.com/SpongePowered/SpongeVanilla/pull/250.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/250","number":250,"state":"open","locked":false,"title":"[WIP] Add support for plugin-provided Mixins","user":{"login":"Minecrell","id":3035868,"avatar_url":"https://avatars.githubusercontent.com/u/3035868?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecrell","html_url":"https://github.com/Minecrell","followers_url":"https://api.github.com/users/Minecrell/followers","following_url":"https://api.github.com/users/Minecrell/following{/other_user}","gists_url":"https://api.github.com/users/Minecrell/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecrell/subscriptions","organizations_url":"https://api.github.com/users/Minecrell/orgs","repos_url":"https://api.github.com/users/Minecrell/repos","events_url":"https://api.github.com/users/Minecrell/events{/privacy}","received_events_url":"https://api.github.com/users/Minecrell/received_events","type":"User","site_admin":false},"body":"Fixes #249.\r\n\r\nWith these changes plugins can define Mixin configs in their manifest which will be loaded and applied by SpongeVanilla under the condition that the `TweakClass` in the manifest is set to the Mixin tweaker - even though the tweaker is never actually applied on SpongeVanilla.\r\n\r\nLoading any kinds of tweakers can be still added later on since that requires more complex changes and is not as safe as simply applying some Mixins. (Since the transformers can basically do anything and therefore break things much easier if not done properly.)","created_at":"2016-06-17T18:36:10Z","updated_at":"2016-06-17T20:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae1dc64f182169f1498fe24f16bbd5dc05ead898","assignee":{"login":"Minecrell","id":3035868,"avatar_url":"https://avatars.githubusercontent.com/u/3035868?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecrell","html_url":"https://github.com/Minecrell","followers_url":"https://api.github.com/users/Minecrell/followers","following_url":"https://api.github.com/users/Minecrell/following{/other_user}","gists_url":"https://api.github.com/users/Minecrell/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecrell/subscriptions","organizations_url":"https://api.github.com/users/Minecrell/orgs","repos_url":"https://api.github.com/users/Minecrell/repos","events_url":"https://api.github.com/users/Minecrell/events{/privacy}","received_events_url":"https://api.github.com/users/Minecrell/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/250/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/statuses/3adce04893e53fa1674fcdfd76348f67ae754b48","head":{"label":"SpongePowered:feature/plugin-mixins","ref":"feature/plugin-mixins","sha":"3adce04893e53fa1674fcdfd76348f67ae754b48","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23766683,"name":"SpongeVanilla","full_name":"SpongePowered/SpongeVanilla","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeVanilla","description":"The SpongeAPI implementation for Vanilla Minecraft.","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeVanilla","forks_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/deployments","created_at":"2014-09-07T18:00:22Z","updated_at":"2016-06-17T06:22:32Z","pushed_at":"2016-06-17T18:36:10Z","git_url":"git://github.com/SpongePowered/SpongeVanilla.git","ssh_url":"git@github.com:SpongePowered/SpongeVanilla.git","clone_url":"https://github.com/SpongePowered/SpongeVanilla.git","svn_url":"https://github.com/SpongePowered/SpongeVanilla","homepage":"http://www.spongepowered.org/","size":4396,"stargazers_count":164,"watchers_count":164,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":8,"forks":68,"open_issues":8,"watchers":164,"default_branch":"master"}},"base":{"label":"SpongePowered:bleeding","ref":"bleeding","sha":"8e8ffea183f991d26d1a709e555a6d0007b8d8da","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23766683,"name":"SpongeVanilla","full_name":"SpongePowered/SpongeVanilla","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeVanilla","description":"The SpongeAPI implementation for Vanilla Minecraft.","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeVanilla","forks_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeVanilla/deployments","created_at":"2014-09-07T18:00:22Z","updated_at":"2016-06-17T06:22:32Z","pushed_at":"2016-06-17T18:36:10Z","git_url":"git://github.com/SpongePowered/SpongeVanilla.git","ssh_url":"git@github.com:SpongePowered/SpongeVanilla.git","clone_url":"https://github.com/SpongePowered/SpongeVanilla.git","svn_url":"https://github.com/SpongePowered/SpongeVanilla","homepage":"http://www.spongepowered.org/","size":4396,"stargazers_count":164,"watchers_count":164,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":8,"forks":68,"open_issues":8,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250"},"html":{"href":"https://github.com/SpongePowered/SpongeVanilla/pull/250"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/250"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeVanilla/statuses/3adce04893e53fa1674fcdfd76348f67ae754b48"}}}}
{"actor":{"display_login":"Mumfrey"}}