{"action":"created","comment":{"url":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments/86980216","pull_request_review_id":7609804,"id":86980216,"diff_hunk":"@@ -239,7 +239,16 @@ While `ContainerInterface` only defines one mandatory parameter in `get()`, it i\n existing containers that have additional optional parameters. PHP allows an implementation to offer more parameters\n as long as they are optional, because the implementation *does* satisfy the interface.\n \n-This issue has been discussed in [container-interop's issue #6](https://github.com/container-interop/container-interop/issues/6).\n+Difference with container-interop: [The container-interop spec](https://github.com/container-interop/container-interop/blob/master/docs/ContainerInterface.md) stated that:\n+\n+> While `ContainerInterface` only defines one mandatory parameter in `get()`, implementations MAY accept additional optional parameters.\n+\n+This sentence was removed from PSR-11 because:\n+\n+- It is something that stems from OO principles in PHP, so this is not directly related to PSR-11\n+- We do not want to encourage implementors to add additional parameters as we recommend coding against the interface and not the implementation\n+\n+Yet, some implementations have extra optional parameters; that's technically legal. Such implementations are compatible with PSR-11. [[6]](#link_get_optional_parameters)","path":"proposed/container-meta.md","position":14,"original_position":14,"commit_id":"92c9385c5fc27bb23a4c3e2de584997237f155a5","original_commit_id":"92c9385c5fc27bb23a4c3e2de584997237f155a5","user":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars.githubusercontent.com/u/1290952?v=3","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"body":"@Crell , I agree when you say:\r\n\r\n>  Most other spec metadocs have had a specific section dedicated to external links, such as key polls or such, but not in the prose of the metadoc itself. Having the links interspersed implies \"you really need to go read these to understand this\", aka, \"this metadoc is incomplete.\"\r\n\r\nI also agree with @stefanotorresi when he says:\r\n\r\n> historically there have been a few instances were outsiders posted doubts, questions or critiques on the ML, only to recieve the response \"this has already been dicussed in link\", so keeping track of such references on the metadoc should be welcomed.\r\n\r\nI've changed this commit to synthesize your point of views:\r\n\r\nI'm simply putting a small reference at the end of the chapter that points to the \"links\" section at the end of the document.\r\n\r\nThat way, the meta-document remains readable by itself (as requested by @Crell), and yet, I'm adding more links at the end of the document so that people who want to deep dive in the discussions can do it (as requested by @stefanotorresi )\r\n\r\nAre you ok with this approach? If yes, I'll submit another PR that moves all other links of the meta doc to the links section at the bottom of the doc.\r\n\r\nOn a side note, I also removed the reference to the previous version of the spec, but kept the reference to container-interop (as this is something I believe is important to track since PSR-11 will deprecate container-interop).","created_at":"2016-11-08T12:41:51Z","updated_at":"2016-11-08T12:41:51Z","html_url":"https://github.com/php-fig/fig-standards/pull/831#discussion_r86980216","pull_request_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/831","_links":{"self":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments/86980216"},"html":{"href":"https://github.com/php-fig/fig-standards/pull/831#discussion_r86980216"},"pull_request":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/831"}}},"pull_request":{"url":"https://api.github.com/repos/php-fig/fig-standards/pulls/831","id":92345620,"html_url":"https://github.com/php-fig/fig-standards/pull/831","diff_url":"https://github.com/php-fig/fig-standards/pull/831.diff","patch_url":"https://github.com/php-fig/fig-standards/pull/831.patch","issue_url":"https://api.github.com/repos/php-fig/fig-standards/issues/831","number":831,"state":"open","locked":false,"title":"Adding clarifications about get optional parameters","user":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars.githubusercontent.com/u/1290952?v=3","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"body":"This is a PR following discussion about [the authorization of optional arguments of the *get* method](https://groups.google.com/forum/#!topic/php-fig/zY6FAG4-oz8).\r\n\r\nIn essence, I removed the sentence from *container.md* and I added some clarifications in the META.\r\n\r\n@crell @mnapoli I tried to make a synthesis of your points of view. Let me know if you are ok with the new wording or if you want to make improvements/changes.\r\n\r\n// cc @php-fig/psr-11 ","created_at":"2016-11-04T14:05:31Z","updated_at":"2016-11-08T12:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caf690752cf23e2686fbb57fdcc42797990c07ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/831/commits","review_comments_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/831/comments","review_comment_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-fig/fig-standards/issues/831/comments","statuses_url":"https://api.github.com/repos/php-fig/fig-standards/statuses/92c9385c5fc27bb23a4c3e2de584997237f155a5","head":{"label":"moufmouf:get_optional_parameters","ref":"get_optional_parameters","sha":"92c9385c5fc27bb23a4c3e2de584997237f155a5","user":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars.githubusercontent.com/u/1290952?v=3","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"repo":{"id":12245783,"name":"fig-standards","full_name":"moufmouf/fig-standards","owner":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars.githubusercontent.com/u/1290952?v=3","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moufmouf/fig-standards","description":"Standards either proposed or approved by the Framework Interop Group","fork":true,"url":"https://api.github.com/repos/moufmouf/fig-standards","forks_url":"https://api.github.com/repos/moufmouf/fig-standards/forks","keys_url":"https://api.github.com/repos/moufmouf/fig-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moufmouf/fig-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moufmouf/fig-standards/teams","hooks_url":"https://api.github.com/repos/moufmouf/fig-standards/hooks","issue_events_url":"https://api.github.com/repos/moufmouf/fig-standards/issues/events{/number}","events_url":"https://api.github.com/repos/moufmouf/fig-standards/events","assignees_url":"https://api.github.com/repos/moufmouf/fig-standards/assignees{/user}","branches_url":"https://api.github.com/repos/moufmouf/fig-standards/branches{/branch}","tags_url":"https://api.github.com/repos/moufmouf/fig-standards/tags","blobs_url":"https://api.github.com/repos/moufmouf/fig-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moufmouf/fig-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moufmouf/fig-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/moufmouf/fig-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moufmouf/fig-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/moufmouf/fig-standards/languages","stargazers_url":"https://api.github.com/repos/moufmouf/fig-standards/stargazers","contributors_url":"https://api.github.com/repos/moufmouf/fig-standards/contributors","subscribers_url":"https://api.github.com/repos/moufmouf/fig-standards/subscribers","subscription_url":"https://api.github.com/repos/moufmouf/fig-standards/subscription","commits_url":"https://api.github.com/repos/moufmouf/fig-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/moufmouf/fig-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/moufmouf/fig-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/moufmouf/fig-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/moufmouf/fig-standards/contents/{+path}","compare_url":"https://api.github.com/repos/moufmouf/fig-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moufmouf/fig-standards/merges","archive_url":"https://api.github.com/repos/moufmouf/fig-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moufmouf/fig-standards/downloads","issues_url":"https://api.github.com/repos/moufmouf/fig-standards/issues{/number}","pulls_url":"https://api.github.com/repos/moufmouf/fig-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/moufmouf/fig-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/moufmouf/fig-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moufmouf/fig-standards/labels{/name}","releases_url":"https://api.github.com/repos/moufmouf/fig-standards/releases{/id}","deployments_url":"https://api.github.com/repos/moufmouf/fig-standards/deployments","created_at":"2013-08-20T14:54:06Z","updated_at":"2015-08-28T15:48:59Z","pushed_at":"2016-11-08T12:33:03Z","git_url":"git://github.com/moufmouf/fig-standards.git","ssh_url":"git@github.com:moufmouf/fig-standards.git","clone_url":"https://github.com/moufmouf/fig-standards.git","svn_url":"https://github.com/moufmouf/fig-standards","homepage":"http://www.php-fig.org/","size":2210,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"psr11"}},"base":{"label":"php-fig:master","ref":"master","sha":"154fe192d102954434e2d9bac0bcaa3a7b5b4a23","user":{"login":"php-fig","id":468401,"avatar_url":"https://avatars.githubusercontent.com/u/468401?v=3","gravatar_id":"","url":"https://api.github.com/users/php-fig","html_url":"https://github.com/php-fig","followers_url":"https://api.github.com/users/php-fig/followers","following_url":"https://api.github.com/users/php-fig/following{/other_user}","gists_url":"https://api.github.com/users/php-fig/gists{/gist_id}","starred_url":"https://api.github.com/users/php-fig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-fig/subscriptions","organizations_url":"https://api.github.com/users/php-fig/orgs","repos_url":"https://api.github.com/users/php-fig/repos","events_url":"https://api.github.com/users/php-fig/events{/privacy}","received_events_url":"https://api.github.com/users/php-fig/received_events","type":"Organization","site_admin":false},"repo":{"id":1053270,"name":"fig-standards","full_name":"php-fig/fig-standards","owner":{"login":"php-fig","id":468401,"avatar_url":"https://avatars.githubusercontent.com/u/468401?v=3","gravatar_id":"","url":"https://api.github.com/users/php-fig","html_url":"https://github.com/php-fig","followers_url":"https://api.github.com/users/php-fig/followers","following_url":"https://api.github.com/users/php-fig/following{/other_user}","gists_url":"https://api.github.com/users/php-fig/gists{/gist_id}","starred_url":"https://api.github.com/users/php-fig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-fig/subscriptions","organizations_url":"https://api.github.com/users/php-fig/orgs","repos_url":"https://api.github.com/users/php-fig/repos","events_url":"https://api.github.com/users/php-fig/events{/privacy}","received_events_url":"https://api.github.com/users/php-fig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-fig/fig-standards","description":"Standards either proposed or approved by the Framework Interop Group","fork":false,"url":"https://api.github.com/repos/php-fig/fig-standards","forks_url":"https://api.github.com/repos/php-fig/fig-standards/forks","keys_url":"https://api.github.com/repos/php-fig/fig-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-fig/fig-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-fig/fig-standards/teams","hooks_url":"https://api.github.com/repos/php-fig/fig-standards/hooks","issue_events_url":"https://api.github.com/repos/php-fig/fig-standards/issues/events{/number}","events_url":"https://api.github.com/repos/php-fig/fig-standards/events","assignees_url":"https://api.github.com/repos/php-fig/fig-standards/assignees{/user}","branches_url":"https://api.github.com/repos/php-fig/fig-standards/branches{/branch}","tags_url":"https://api.github.com/repos/php-fig/fig-standards/tags","blobs_url":"https://api.github.com/repos/php-fig/fig-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-fig/fig-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-fig/fig-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-fig/fig-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-fig/fig-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/php-fig/fig-standards/languages","stargazers_url":"https://api.github.com/repos/php-fig/fig-standards/stargazers","contributors_url":"https://api.github.com/repos/php-fig/fig-standards/contributors","subscribers_url":"https://api.github.com/repos/php-fig/fig-standards/subscribers","subscription_url":"https://api.github.com/repos/php-fig/fig-standards/subscription","commits_url":"https://api.github.com/repos/php-fig/fig-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-fig/fig-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-fig/fig-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-fig/fig-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-fig/fig-standards/contents/{+path}","compare_url":"https://api.github.com/repos/php-fig/fig-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-fig/fig-standards/merges","archive_url":"https://api.github.com/repos/php-fig/fig-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-fig/fig-standards/downloads","issues_url":"https://api.github.com/repos/php-fig/fig-standards/issues{/number}","pulls_url":"https://api.github.com/repos/php-fig/fig-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/php-fig/fig-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/php-fig/fig-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-fig/fig-standards/labels{/name}","releases_url":"https://api.github.com/repos/php-fig/fig-standards/releases{/id}","deployments_url":"https://api.github.com/repos/php-fig/fig-standards/deployments","created_at":"2010-11-05T04:44:12Z","updated_at":"2016-11-08T09:24:27Z","pushed_at":"2016-11-08T12:33:07Z","git_url":"git://github.com/php-fig/fig-standards.git","ssh_url":"git@github.com:php-fig/fig-standards.git","clone_url":"https://github.com/php-fig/fig-standards.git","svn_url":"https://github.com/php-fig/fig-standards","homepage":"http://www.php-fig.org/","size":4221,"stargazers_count":8428,"watchers_count":8428,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2248,"mirror_url":null,"open_issues_count":25,"forks":2248,"open_issues":25,"watchers":8428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/831"},"html":{"href":"https://github.com/php-fig/fig-standards/pull/831"},"issue":{"href":"https://api.github.com/repos/php-fig/fig-standards/issues/831"},"comments":{"href":"https://api.github.com/repos/php-fig/fig-standards/issues/831/comments"},"review_comments":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/831/comments"},"review_comment":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/831/commits"},"statuses":{"href":"https://api.github.com/repos/php-fig/fig-standards/statuses/92c9385c5fc27bb23a4c3e2de584997237f155a5"}}}}
{"actor":{"display_login":"moufmouf"}}