{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/1093","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/1093/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1093/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/1093/events","html_url":"https://github.com/apache/zeppelin/pull/1093","id":162420660,"number":1093,"title":"[Bug Fix] Fix \"stackedAreaChart\", \"lineWithFocusChart\" graph when dataset contains \"NULL\" value.","user":{"login":"voyageth","id":366810,"avatar_url":"https://avatars.githubusercontent.com/u/366810?v=3","gravatar_id":"","url":"https://api.github.com/users/voyageth","html_url":"https://github.com/voyageth","followers_url":"https://api.github.com/users/voyageth/followers","following_url":"https://api.github.com/users/voyageth/following{/other_user}","gists_url":"https://api.github.com/users/voyageth/gists{/gist_id}","starred_url":"https://api.github.com/users/voyageth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voyageth/subscriptions","organizations_url":"https://api.github.com/users/voyageth/orgs","repos_url":"https://api.github.com/users/voyageth/repos","events_url":"https://api.github.com/users/voyageth/events{/privacy}","received_events_url":"https://api.github.com/users/voyageth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-27T10:28:48Z","updated_at":"2016-07-06T04:47:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1093","html_url":"https://github.com/apache/zeppelin/pull/1093","diff_url":"https://github.com/apache/zeppelin/pull/1093.diff","patch_url":"https://github.com/apache/zeppelin/pull/1093.patch"},"body":"### What is this PR for?\r\nFix \"stackedAreaChart\", \"lineWithFocusChart\" graph when dataset contains \"NULL\" value.\r\n\r\n- wired graph with \"NULL\" value\r\n![asis1](https://cloud.githubusercontent.com/assets/366810/16553574/4e3b34b4-4204-11e6-96bc-2624619bd82e.PNG)\r\n![asis2](https://cloud.githubusercontent.com/assets/366810/16553575/50a26358-4204-11e6-9356-e54ac3c93274.PNG)\r\n- fixed graph with \"NULL\" value\r\n![tobe1](https://cloud.githubusercontent.com/assets/366810/16553578/5236f904-4204-11e6-87e2-289e85914381.PNG)\r\n![tobe2](https://cloud.githubusercontent.com/assets/366810/16553580/551e5fae-4204-11e6-8a6f-6292e652023c.PNG)\r\n\r\n### What type of PR is it?\r\nBug Fix\r\n\r\n### Todos\r\n* [x] - Check side effect.\r\n* [x] - Need fix when maxRowValue == rowIdx\r\n\r\n### What is the Jira issue?\r\n- https://issues.apache.org/jira/browse/ZEPPELIN-1103\r\n\r\n### How should this be tested?\r\n- This problem can regenerate under dataset like this.\r\n![image](https://cloud.githubusercontent.com/assets/366810/16553605/83210050-4204-11e6-8c77-4e1c441f7d93.png)\r\n\r\n- rowIndexValue variable is like this on 1777 line.\r\nrowIndexValue : Object {0: \"0\", 1: \"1\", 2: \"2\", 3: \"3\", 4: \"4\", 5: \"5\", 6: \"6\", 7: \"7\", 8: \"8\", 9: \"9\", 10: \"10\", 11: \"11\", 12: \"12\", 13: \"13\", 14: \"14\", 15: \"15\", 16: \"16\", 17: \"17\", 18: \"18\", 19: \"19\", 20: \"20\", 21: \"21\", 22: \"22\", 23: \"23\", 24: \"24\", 25: \"25\", 26: \"26\", 27: \"27\", 28: \"28\", 29: \"29\", 30: \"30\", 31: \"31\", 32: \"32\", 33: \"33\", 34: \"34\", 35: \"35\", 36: \"36\", 37: \"37\", 38: \"38\", 39: \"39\", 40: \"40\", 41: \"41\", 42: \"42\", 43: \"43\", 44: \"52\"}\r\nrowNameIndex : Object {0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6, 7: 7, 8: 8, 9: 9, 10: 10, 11: 11, 12: 12, 13: 13, 14: 14, 15: 15, 16: 16, 17: 17, 18: 18, 19: 19, 20: 20, 21: 21, 22: 22, 23: 23, 24: 24, 25: 25, 26: 26, 27: 27, 28: 28, 29: 29, 30: 30, 31: 31, 32: 32, 33: 33, 34: 34, 35: 35, 36: 36, 37: 37, 38: 38, 39: 39, 40: 40, 41: 41, 42: 42, 43: 43, 52: 44}"},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/230670108","html_url":"https://github.com/apache/zeppelin/pull/1093#issuecomment-230670108","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1093","id":230670108,"user":{"login":"voyageth","id":366810,"avatar_url":"https://avatars.githubusercontent.com/u/366810?v=3","gravatar_id":"","url":"https://api.github.com/users/voyageth","html_url":"https://github.com/voyageth","followers_url":"https://api.github.com/users/voyageth/followers","following_url":"https://api.github.com/users/voyageth/following{/other_user}","gists_url":"https://api.github.com/users/voyageth/gists{/gist_id}","starred_url":"https://api.github.com/users/voyageth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voyageth/subscriptions","organizations_url":"https://api.github.com/users/voyageth/orgs","repos_url":"https://api.github.com/users/voyageth/repos","events_url":"https://api.github.com/users/voyageth/events{/privacy}","received_events_url":"https://api.github.com/users/voyageth/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T04:47:10Z","updated_at":"2016-07-06T04:47:10Z","body":"Oh, empty string also make wired graph too!\r\nThis PR doesn't consider that condition.\r\n\r\nThis PR can fix following condition.\r\n`%sh echo -e \"%table key\\tvalue\\nnull\\t1000\\n1\\t100\\n2\\t200\\n99\\t900\"`\r\n\r\n- before apply PR\r\n![asis3](https://cloud.githubusercontent.com/assets/366810/16607769/dc2c09f2-437f-11e6-93c9-c4257eb6afd6.PNG)\r\n- after apply PR\r\n![tobe3](https://cloud.githubusercontent.com/assets/366810/16607770/dd342d34-437f-11e6-8837-295c63cffc43.PNG)\r\n\r\n"}}
{"actor":{"display_login":"voyageth"}}