{"action":"created","issue":{"url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/34","repository_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync","labels_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/34/comments","events_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/34/events","html_url":"https://github.com/skiflink/googlemaps_dbsync/pull/34","id":192141875,"number":34,"title":"Sync feature spec","user":{"login":"skiflink","id":4578986,"avatar_url":"https://avatars.githubusercontent.com/u/4578986?v=3","gravatar_id":"","url":"https://api.github.com/users/skiflink","html_url":"https://github.com/skiflink","followers_url":"https://api.github.com/users/skiflink/followers","following_url":"https://api.github.com/users/skiflink/following{/other_user}","gists_url":"https://api.github.com/users/skiflink/gists{/gist_id}","starred_url":"https://api.github.com/users/skiflink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skiflink/subscriptions","organizations_url":"https://api.github.com/users/skiflink/orgs","repos_url":"https://api.github.com/users/skiflink/repos","events_url":"https://api.github.com/users/skiflink/events{/privacy}","received_events_url":"https://api.github.com/users/skiflink/received_events","type":"User","site_admin":false},"labels":[{"id":487395180,"url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/labels/work-in-progress","name":"work-in-progress","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-28T23:03:35Z","updated_at":"2016-11-29T11:57:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/pulls/34","html_url":"https://github.com/skiflink/googlemaps_dbsync/pull/34","diff_url":"https://github.com/skiflink/googlemaps_dbsync/pull/34.diff","patch_url":"https://github.com/skiflink/googlemaps_dbsync/pull/34.patch"},"body":"This PR involves increasing the coverage of the test suite.. by starting to add some feature specs.\r\n\r\nOriginally I was against this because I wanted to keep the test suite as quick as possible, but feature specs are *ESSENTIAL*. Without feature specs, you just have to hope that you've covered every scenario in your service specs and everything _just works_. \r\n\r\nOnce I created my feature spec, added Sepia (HTTP interaction recorder), and ran.. it was clear that without feature specs, I'd be running a faulty application and I wouldn't have even known!\r\n\r\nRunning a feature spec that tested the syncing feature as a whole, found that:\r\n* My shop count was breaking completely (one instance where the count was not being passed back properly)\r\n* My database functions weren't escaping text as they should be (it seems I've gotten too used to using ORMs).\r\n\r\nThis feature spec will also save my back in the future as I update the sync and refactor it so it's nice and clean. Code coverage is essential, and you will learn this when you need ~100% uptime applications. You can lose a lot of uptime, just by a simple bug that you didn't pick up in your test, basically because you were lacking in code coverage or you aren't doing enough expectations.\r\n\r\nTLDR; Added a feature spec for my syncing feature.. found some errors I didn't find through service specs. I have a lot more confidence in my application now, and this is only the beginning."},"comment":{"url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/comments/263551963","html_url":"https://github.com/skiflink/googlemaps_dbsync/pull/34#issuecomment-263551963","issue_url":"https://api.github.com/repos/skiflink/googlemaps_dbsync/issues/34","id":263551963,"user":{"login":"skiflink","id":4578986,"avatar_url":"https://avatars.githubusercontent.com/u/4578986?v=3","gravatar_id":"","url":"https://api.github.com/users/skiflink","html_url":"https://github.com/skiflink","followers_url":"https://api.github.com/users/skiflink/followers","following_url":"https://api.github.com/users/skiflink/following{/other_user}","gists_url":"https://api.github.com/users/skiflink/gists{/gist_id}","starred_url":"https://api.github.com/users/skiflink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skiflink/subscriptions","organizations_url":"https://api.github.com/users/skiflink/orgs","repos_url":"https://api.github.com/users/skiflink/repos","events_url":"https://api.github.com/users/skiflink/events{/privacy}","received_events_url":"https://api.github.com/users/skiflink/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T11:57:57Z","updated_at":"2016-11-29T11:57:57Z","body":"Going to implement https://www.npmjs.com/package/dotenv for google maps api key.. Will add an example .env"}}
{"actor":{"display_login":"skiflink"}}