{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/comments/68646589","id":68646589,"diff_hunk":"@@ -30,32 +30,64 @@ class RecipeHistory extends React.Component {\n     const { revisionLog } = this.state;\n     const { recipeId, recipe, dispatch } = this.props;\n     return (\n-      <div className=\"fluid-8\">\n+      <div className=\"fluid-8 recipe-history\">\n         <h3>Viewing revision log for: <b>{recipe ? recipe.name : ''}</b></h3>\n         <ul>\n-            {\n-              this.state.revisionLog.map((revision, index) =>\n-                <li key={revision.date_created} onClick={(e) => {\n-                  let revisionInfo = {};\n-                  if (index !== 0) {\n-                    revisionInfo = {\n-                      query: { revisionId: `${revision.id}` },\n-                      state: { selectedRevision: revision.recipe }\n-                    }\n-                  }\n-                  dispatch(push({\n-                    pathname: `/control/recipe/${recipeId}/`,\n-                    ...revisionInfo\n-                  }))\n-                }}><p className=\"revision-number\">#{revision.recipe.revision_id} </p>\n-                  <p><span className=\"label\">Created On:</span>{ moment(revision.date_created).format('MMM Do YYYY - h:mmA') }</p>\n-                </li>\n-              )\n-            }\n+            {this.state.revisionLog.map((revision, index) =>\n+              <HistoryItem\n+                key={revision.id}\n+                revision={revision}\n+                recipe={recipe}\n+                dispatch={dispatch}\n+              />\n+            )}\n         </ul>\n       </div>\n     )\n   }\n }\n \n+class HistoryItem extends React.Component {\n+  render() {\n+    const { revision, recipe } = this.props;\n+    const isCurrent = revision.recipe.revision_id === recipe.revision_id;","path":"normandy/control/static/control/js/components/RecipeHistory.jsx","position":61,"original_position":61,"commit_id":"1d3df7b5c55bbc204a38204aa39072817a019cd3","original_commit_id":"1d3df7b5c55bbc204a38204aa39072817a019cd3","user":{"login":"mythmon","id":305049,"avatar_url":"https://avatars.githubusercontent.com/u/305049?v=3","gravatar_id":"","url":"https://api.github.com/users/mythmon","html_url":"https://github.com/mythmon","followers_url":"https://api.github.com/users/mythmon/followers","following_url":"https://api.github.com/users/mythmon/following{/other_user}","gists_url":"https://api.github.com/users/mythmon/gists{/gist_id}","starred_url":"https://api.github.com/users/mythmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mythmon/subscriptions","organizations_url":"https://api.github.com/users/mythmon/orgs","repos_url":"https://api.github.com/users/mythmon/repos","events_url":"https://api.github.com/users/mythmon/events{/privacy}","received_events_url":"https://api.github.com/users/mythmon/received_events","type":"User","site_admin":false},"body":"Adding proptypes to the component will likely help track down the issue, and we should probably start doing that on new components.","created_at":"2016-06-27T20:10:11Z","updated_at":"2016-06-27T20:10:11Z","html_url":"https://github.com/mozilla/normandy/pull/179#discussion_r68646589","pull_request_url":"https://api.github.com/repos/mozilla/normandy/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/comments/68646589"},"html":{"href":"https://github.com/mozilla/normandy/pull/179#discussion_r68646589"},"pull_request":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/179","id":75218827,"html_url":"https://github.com/mozilla/normandy/pull/179","diff_url":"https://github.com/mozilla/normandy/pull/179.diff","patch_url":"https://github.com/mozilla/normandy/pull/179.patch","issue_url":"https://api.github.com/repos/mozilla/normandy/issues/179","number":179,"state":"open","locked":false,"title":"Add status indicator for the current revision.","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"body":"Includes a mild refactoring of the history view. Reuses the preview status indicator.\r\n\r\n@brittanystoroz r?","created_at":"2016-06-26T01:28:43Z","updated_at":"2016-06-27T20:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e58076655f96354601dd0eae9f1c2140acecea35","assignee":{"login":"brittanystoroz","id":856935,"avatar_url":"https://avatars.githubusercontent.com/u/856935?v=3","gravatar_id":"","url":"https://api.github.com/users/brittanystoroz","html_url":"https://github.com/brittanystoroz","followers_url":"https://api.github.com/users/brittanystoroz/followers","following_url":"https://api.github.com/users/brittanystoroz/following{/other_user}","gists_url":"https://api.github.com/users/brittanystoroz/gists{/gist_id}","starred_url":"https://api.github.com/users/brittanystoroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittanystoroz/subscriptions","organizations_url":"https://api.github.com/users/brittanystoroz/orgs","repos_url":"https://api.github.com/users/brittanystoroz/repos","events_url":"https://api.github.com/users/brittanystoroz/events{/privacy}","received_events_url":"https://api.github.com/users/brittanystoroz/received_events","type":"User","site_admin":false},"assignees":[{"login":"brittanystoroz","id":856935,"avatar_url":"https://avatars.githubusercontent.com/u/856935?v=3","gravatar_id":"","url":"https://api.github.com/users/brittanystoroz","html_url":"https://github.com/brittanystoroz","followers_url":"https://api.github.com/users/brittanystoroz/followers","following_url":"https://api.github.com/users/brittanystoroz/following{/other_user}","gists_url":"https://api.github.com/users/brittanystoroz/gists{/gist_id}","starred_url":"https://api.github.com/users/brittanystoroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittanystoroz/subscriptions","organizations_url":"https://api.github.com/users/brittanystoroz/orgs","repos_url":"https://api.github.com/users/brittanystoroz/repos","events_url":"https://api.github.com/users/brittanystoroz/events{/privacy}","received_events_url":"https://api.github.com/users/brittanystoroz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/normandy/pulls/179/commits","review_comments_url":"https://api.github.com/repos/mozilla/normandy/pulls/179/comments","review_comment_url":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/normandy/issues/179/comments","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/1d3df7b5c55bbc204a38204aa39072817a019cd3","head":{"label":"Osmose:current-revision-marker","ref":"current-revision-marker","sha":"1d3df7b5c55bbc204a38204aa39072817a019cd3","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"repo":{"id":48456654,"name":"normandy","full_name":"Osmose/normandy","owner":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Osmose/normandy","description":"Self-Repair 2","fork":true,"url":"https://api.github.com/repos/Osmose/normandy","forks_url":"https://api.github.com/repos/Osmose/normandy/forks","keys_url":"https://api.github.com/repos/Osmose/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Osmose/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Osmose/normandy/teams","hooks_url":"https://api.github.com/repos/Osmose/normandy/hooks","issue_events_url":"https://api.github.com/repos/Osmose/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/Osmose/normandy/events","assignees_url":"https://api.github.com/repos/Osmose/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/Osmose/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/Osmose/normandy/tags","blobs_url":"https://api.github.com/repos/Osmose/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Osmose/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Osmose/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Osmose/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Osmose/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/Osmose/normandy/languages","stargazers_url":"https://api.github.com/repos/Osmose/normandy/stargazers","contributors_url":"https://api.github.com/repos/Osmose/normandy/contributors","subscribers_url":"https://api.github.com/repos/Osmose/normandy/subscribers","subscription_url":"https://api.github.com/repos/Osmose/normandy/subscription","commits_url":"https://api.github.com/repos/Osmose/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Osmose/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Osmose/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Osmose/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Osmose/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/Osmose/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Osmose/normandy/merges","archive_url":"https://api.github.com/repos/Osmose/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Osmose/normandy/downloads","issues_url":"https://api.github.com/repos/Osmose/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/Osmose/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/Osmose/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/Osmose/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Osmose/normandy/labels{/name}","releases_url":"https://api.github.com/repos/Osmose/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/Osmose/normandy/deployments","created_at":"2015-12-22T22:18:41Z","updated_at":"2016-03-24T23:19:10Z","pushed_at":"2016-06-26T01:27:46Z","git_url":"git://github.com/Osmose/normandy.git","ssh_url":"git@github.com:Osmose/normandy.git","clone_url":"https://github.com/Osmose/normandy.git","svn_url":"https://github.com/Osmose/normandy","homepage":null,"size":1777,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"9d39bc553bae542a93df8d9b01b25bd5337e4dd0","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":48456638,"name":"normandy","full_name":"mozilla/normandy","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/normandy","description":"Firefox recipe server","fork":false,"url":"https://api.github.com/repos/mozilla/normandy","forks_url":"https://api.github.com/repos/mozilla/normandy/forks","keys_url":"https://api.github.com/repos/mozilla/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/normandy/teams","hooks_url":"https://api.github.com/repos/mozilla/normandy/hooks","issue_events_url":"https://api.github.com/repos/mozilla/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/normandy/events","assignees_url":"https://api.github.com/repos/mozilla/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/normandy/tags","blobs_url":"https://api.github.com/repos/mozilla/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/normandy/languages","stargazers_url":"https://api.github.com/repos/mozilla/normandy/stargazers","contributors_url":"https://api.github.com/repos/mozilla/normandy/contributors","subscribers_url":"https://api.github.com/repos/mozilla/normandy/subscribers","subscription_url":"https://api.github.com/repos/mozilla/normandy/subscription","commits_url":"https://api.github.com/repos/mozilla/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/normandy/merges","archive_url":"https://api.github.com/repos/mozilla/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/normandy/downloads","issues_url":"https://api.github.com/repos/mozilla/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/normandy/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/normandy/deployments","created_at":"2015-12-22T22:18:19Z","updated_at":"2016-06-15T08:01:18Z","pushed_at":"2016-06-27T20:07:40Z","git_url":"git://github.com/mozilla/normandy.git","ssh_url":"git@github.com:mozilla/normandy.git","clone_url":"https://github.com/mozilla/normandy.git","svn_url":"https://github.com/mozilla/normandy","homepage":"https://wiki.mozilla.org/Firefox/Recipe_Server","size":1789,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/179"},"html":{"href":"https://github.com/mozilla/normandy/pull/179"},"issue":{"href":"https://api.github.com/repos/mozilla/normandy/issues/179"},"comments":{"href":"https://api.github.com/repos/mozilla/normandy/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/normandy/statuses/1d3df7b5c55bbc204a38204aa39072817a019cd3"}}}}
{"actor":{"display_login":"mythmon"}}