{"action":"created","issue":{"url":"https://api.github.com/repos/chili-epfl/ros_markers/issues/7","repository_url":"https://api.github.com/repos/chili-epfl/ros_markers","labels_url":"https://api.github.com/repos/chili-epfl/ros_markers/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/chili-epfl/ros_markers/issues/7/comments","events_url":"https://api.github.com/repos/chili-epfl/ros_markers/issues/7/events","html_url":"https://github.com/chili-epfl/ros_markers/issues/7","id":170014479,"number":7,"title":"Use a catkin wrapper instead of PkgConfig","user":{"login":"nicolov","id":10729479,"avatar_url":"https://avatars.githubusercontent.com/u/10729479?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolov","html_url":"https://github.com/nicolov","followers_url":"https://api.github.com/users/nicolov/followers","following_url":"https://api.github.com/users/nicolov/following{/other_user}","gists_url":"https://api.github.com/users/nicolov/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolov/subscriptions","organizations_url":"https://api.github.com/users/nicolov/orgs","repos_url":"https://api.github.com/users/nicolov/repos","events_url":"https://api.github.com/users/nicolov/events{/privacy}","received_events_url":"https://api.github.com/users/nicolov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-08T20:14:30Z","updated_at":"2016-09-12T10:09:21Z","closed_at":null,"body":"Hi, thank you very much for open-sourcing the code, there's a lot to learn from.\r\n\r\nIn ROS, a common pattern to handle external pure-cmake projects is to create a catkin wrapper that compiles the shared libraries and exports the includes. By doing this, any other ROS package can just  REQUIRED COMPONENTS the wrapper and the library gets linked in automatically.\r\n\r\nIMHO, this is neater than having people install chilitags system-wide using CMake, as it plays nicer with the rest of the ROS ecosystem (.deb packaging, cleaning, multiple workspaces,..)\r\n\r\nI've created such a wrapper [here](https://github.com/nicolov/chilitags_catkin) and pushed the (little) changes needed to use it [in my fork](https://github.com/nicolov/ros_markers).\r\n\r\nIs this something you would be interested in merging?"},"comment":{"url":"https://api.github.com/repos/chili-epfl/ros_markers/issues/comments/246304643","html_url":"https://github.com/chili-epfl/ros_markers/issues/7#issuecomment-246304643","issue_url":"https://api.github.com/repos/chili-epfl/ros_markers/issues/7","id":246304643,"user":{"login":"severin-lemaignan","id":385379,"avatar_url":"https://avatars.githubusercontent.com/u/385379?v=3","gravatar_id":"","url":"https://api.github.com/users/severin-lemaignan","html_url":"https://github.com/severin-lemaignan","followers_url":"https://api.github.com/users/severin-lemaignan/followers","following_url":"https://api.github.com/users/severin-lemaignan/following{/other_user}","gists_url":"https://api.github.com/users/severin-lemaignan/gists{/gist_id}","starred_url":"https://api.github.com/users/severin-lemaignan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/severin-lemaignan/subscriptions","organizations_url":"https://api.github.com/users/severin-lemaignan/orgs","repos_url":"https://api.github.com/users/severin-lemaignan/repos","events_url":"https://api.github.com/users/severin-lemaignan/events{/privacy}","received_events_url":"https://api.github.com/users/severin-lemaignan/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T10:09:21Z","updated_at":"2016-09-12T10:09:21Z","body":"Sounds good! Looking forward the PR."}}
{"actor":{"display_login":"severin-lemaignan"}}