{"action":"opened","number":410,"pull_request":{"url":"https://api.github.com/repos/yahoo/fluxible/pulls/410","id":64720933,"html_url":"https://github.com/yahoo/fluxible/pull/410","diff_url":"https://github.com/yahoo/fluxible/pull/410.diff","patch_url":"https://github.com/yahoo/fluxible/pull/410.patch","issue_url":"https://api.github.com/repos/yahoo/fluxible/issues/410","number":410,"state":"open","locked":false,"title":"Add query in some missing places","user":{"login":"irae","id":98254,"avatar_url":"https://avatars.githubusercontent.com/u/98254?v=3","gravatar_id":"","url":"https://api.github.com/users/irae","html_url":"https://github.com/irae","followers_url":"https://api.github.com/users/irae/followers","following_url":"https://api.github.com/users/irae/following{/other_user}","gists_url":"https://api.github.com/users/irae/gists{/gist_id}","starred_url":"https://api.github.com/users/irae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irae/subscriptions","organizations_url":"https://api.github.com/users/irae/orgs","repos_url":"https://api.github.com/users/irae/repos","events_url":"https://api.github.com/users/irae/events{/privacy}","received_events_url":"https://api.github.com/users/irae/received_events","type":"User","site_admin":false},"body":"I was trying to do some advanced routing and I found out a few places it looks like the query might be useful.\r\n\r\nTurns out I managed to do what I need without this changes. But I do think this might be a good idea for fluxible-router 1.0.0 because now you support query string on the NavLink. Suppose a user uses NavLink with the same route params, the history might be badly handled.\r\n\r\nFeel free to close the Pull Request if this is not useful or if it is a mistake. I didn't fully test but this was the easier way to send a diff of the changes I wanted to suggest.","created_at":"2016-03-31T01:03:42Z","updated_at":"2016-03-31T01:03:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/fluxible/pulls/410/commits","review_comments_url":"https://api.github.com/repos/yahoo/fluxible/pulls/410/comments","review_comment_url":"https://api.github.com/repos/yahoo/fluxible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/fluxible/issues/410/comments","statuses_url":"https://api.github.com/repos/yahoo/fluxible/statuses/8ae0cc326ea9479a6a8ef0886b76593e6438c2ff","head":{"label":"irae:missing-query","ref":"missing-query","sha":"8ae0cc326ea9479a6a8ef0886b76593e6438c2ff","user":{"login":"irae","id":98254,"avatar_url":"https://avatars.githubusercontent.com/u/98254?v=3","gravatar_id":"","url":"https://api.github.com/users/irae","html_url":"https://github.com/irae","followers_url":"https://api.github.com/users/irae/followers","following_url":"https://api.github.com/users/irae/following{/other_user}","gists_url":"https://api.github.com/users/irae/gists{/gist_id}","starred_url":"https://api.github.com/users/irae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irae/subscriptions","organizations_url":"https://api.github.com/users/irae/orgs","repos_url":"https://api.github.com/users/irae/repos","events_url":"https://api.github.com/users/irae/events{/privacy}","received_events_url":"https://api.github.com/users/irae/received_events","type":"User","site_admin":false},"repo":{"id":55108567,"name":"fluxible","full_name":"irae/fluxible","owner":{"login":"irae","id":98254,"avatar_url":"https://avatars.githubusercontent.com/u/98254?v=3","gravatar_id":"","url":"https://api.github.com/users/irae","html_url":"https://github.com/irae","followers_url":"https://api.github.com/users/irae/followers","following_url":"https://api.github.com/users/irae/following{/other_user}","gists_url":"https://api.github.com/users/irae/gists{/gist_id}","starred_url":"https://api.github.com/users/irae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irae/subscriptions","organizations_url":"https://api.github.com/users/irae/orgs","repos_url":"https://api.github.com/users/irae/repos","events_url":"https://api.github.com/users/irae/events{/privacy}","received_events_url":"https://api.github.com/users/irae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/irae/fluxible","description":"A pluggable container for universal flux applications","fork":true,"url":"https://api.github.com/repos/irae/fluxible","forks_url":"https://api.github.com/repos/irae/fluxible/forks","keys_url":"https://api.github.com/repos/irae/fluxible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irae/fluxible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irae/fluxible/teams","hooks_url":"https://api.github.com/repos/irae/fluxible/hooks","issue_events_url":"https://api.github.com/repos/irae/fluxible/issues/events{/number}","events_url":"https://api.github.com/repos/irae/fluxible/events","assignees_url":"https://api.github.com/repos/irae/fluxible/assignees{/user}","branches_url":"https://api.github.com/repos/irae/fluxible/branches{/branch}","tags_url":"https://api.github.com/repos/irae/fluxible/tags","blobs_url":"https://api.github.com/repos/irae/fluxible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irae/fluxible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irae/fluxible/git/refs{/sha}","trees_url":"https://api.github.com/repos/irae/fluxible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irae/fluxible/statuses/{sha}","languages_url":"https://api.github.com/repos/irae/fluxible/languages","stargazers_url":"https://api.github.com/repos/irae/fluxible/stargazers","contributors_url":"https://api.github.com/repos/irae/fluxible/contributors","subscribers_url":"https://api.github.com/repos/irae/fluxible/subscribers","subscription_url":"https://api.github.com/repos/irae/fluxible/subscription","commits_url":"https://api.github.com/repos/irae/fluxible/commits{/sha}","git_commits_url":"https://api.github.com/repos/irae/fluxible/git/commits{/sha}","comments_url":"https://api.github.com/repos/irae/fluxible/comments{/number}","issue_comment_url":"https://api.github.com/repos/irae/fluxible/issues/comments{/number}","contents_url":"https://api.github.com/repos/irae/fluxible/contents/{+path}","compare_url":"https://api.github.com/repos/irae/fluxible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irae/fluxible/merges","archive_url":"https://api.github.com/repos/irae/fluxible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irae/fluxible/downloads","issues_url":"https://api.github.com/repos/irae/fluxible/issues{/number}","pulls_url":"https://api.github.com/repos/irae/fluxible/pulls{/number}","milestones_url":"https://api.github.com/repos/irae/fluxible/milestones{/number}","notifications_url":"https://api.github.com/repos/irae/fluxible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irae/fluxible/labels{/name}","releases_url":"https://api.github.com/repos/irae/fluxible/releases{/id}","deployments_url":"https://api.github.com/repos/irae/fluxible/deployments","created_at":"2016-03-31T00:56:43Z","updated_at":"2016-03-31T00:56:46Z","pushed_at":"2016-03-31T01:00:01Z","git_url":"git://github.com/irae/fluxible.git","ssh_url":"git@github.com:irae/fluxible.git","clone_url":"https://github.com/irae/fluxible.git","svn_url":"https://github.com/irae/fluxible","homepage":"http://fluxible.io","size":1523,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"b702e5fec503ba6f3721447d99e942ddeb8ef801","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":26189434,"name":"fluxible","full_name":"yahoo/fluxible","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fluxible","description":"A pluggable container for universal flux applications","fork":false,"url":"https://api.github.com/repos/yahoo/fluxible","forks_url":"https://api.github.com/repos/yahoo/fluxible/forks","keys_url":"https://api.github.com/repos/yahoo/fluxible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fluxible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fluxible/teams","hooks_url":"https://api.github.com/repos/yahoo/fluxible/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fluxible/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fluxible/events","assignees_url":"https://api.github.com/repos/yahoo/fluxible/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fluxible/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fluxible/tags","blobs_url":"https://api.github.com/repos/yahoo/fluxible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fluxible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fluxible/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fluxible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fluxible/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fluxible/languages","stargazers_url":"https://api.github.com/repos/yahoo/fluxible/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fluxible/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fluxible/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fluxible/subscription","commits_url":"https://api.github.com/repos/yahoo/fluxible/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fluxible/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fluxible/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fluxible/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fluxible/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fluxible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fluxible/merges","archive_url":"https://api.github.com/repos/yahoo/fluxible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fluxible/downloads","issues_url":"https://api.github.com/repos/yahoo/fluxible/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fluxible/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fluxible/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fluxible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fluxible/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fluxible/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fluxible/deployments","created_at":"2014-11-04T21:25:38Z","updated_at":"2016-03-30T13:49:46Z","pushed_at":"2016-03-30T18:29:24Z","git_url":"git://github.com/yahoo/fluxible.git","ssh_url":"git@github.com:yahoo/fluxible.git","clone_url":"https://github.com/yahoo/fluxible.git","svn_url":"https://github.com/yahoo/fluxible","homepage":"http://fluxible.io","size":1880,"stargazers_count":1510,"watchers_count":1510,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":166,"mirror_url":null,"open_issues_count":23,"forks":166,"open_issues":23,"watchers":1510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/fluxible/pulls/410"},"html":{"href":"https://github.com/yahoo/fluxible/pull/410"},"issue":{"href":"https://api.github.com/repos/yahoo/fluxible/issues/410"},"comments":{"href":"https://api.github.com/repos/yahoo/fluxible/issues/410/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/fluxible/pulls/410/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/fluxible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/fluxible/pulls/410/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/fluxible/statuses/8ae0cc326ea9479a6a8ef0886b76593e6438c2ff"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":3,"changed_files":2}}