{"action":"created","comment":{"url":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/comments/73713751","id":73713751,"diff_hunk":"@@ -24,11 +27,14 @@ public void run(Map<String,String> parameters) throws UserErrorMessage {\n \t\t\r\n \t\tODPDBAccess db = getDB();\r\n \t\tCachedDatastoreService ds = getDS();\r\n-\t\t\r\n+\t\tCachedEntity character = db.getCurrentCharacter(request);\r\n \t\tLong characterId = tryParseId(parameters,\"characterId\");\r\n         CachedEntity otherCharacter = db.getEntity(KeyFactory.createKey(\"Character\", characterId));\r\n-          \r\n-        db.startTrade(null, db.getCurrentCharacter(request), otherCharacter);\r\n+        \r\n+        if (GameUtils.equals(((Key)character.getProperty(\"locationKey\")),((Key)otherCharacter.getProperty(\"locationKey\"))))\r","path":"Initium-Odp/src/com/universeprojects/miniup/server/commands/CommandTradeStartTrade.java","position":26,"original_position":26,"commit_id":"70448a1658725979f59b01f0834463b26744531d","original_commit_id":"70448a1658725979f59b01f0834463b26744531d","user":{"login":"Emperorlou","id":315164,"avatar_url":"https://avatars.githubusercontent.com/u/315164?v=3","gravatar_id":"","url":"https://api.github.com/users/Emperorlou","html_url":"https://github.com/Emperorlou","followers_url":"https://api.github.com/users/Emperorlou/followers","following_url":"https://api.github.com/users/Emperorlou/following{/other_user}","gists_url":"https://api.github.com/users/Emperorlou/gists{/gist_id}","starred_url":"https://api.github.com/users/Emperorlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emperorlou/subscriptions","organizations_url":"https://api.github.com/users/Emperorlou/orgs","repos_url":"https://api.github.com/users/Emperorlou/repos","events_url":"https://api.github.com/users/Emperorlou/events{/privacy}","received_events_url":"https://api.github.com/users/Emperorlou/received_events","type":"User","site_admin":false},"body":"This should be == false","created_at":"2016-08-05T15:43:08Z","updated_at":"2016-08-05T15:43:08Z","html_url":"https://github.com/Emperorlou/initium-odp/pull/66#discussion_r73713751","pull_request_url":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/comments/73713751"},"html":{"href":"https://github.com/Emperorlou/initium-odp/pull/66#discussion_r73713751"},"pull_request":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66","id":80257942,"html_url":"https://github.com/Emperorlou/initium-odp/pull/66","diff_url":"https://github.com/Emperorlou/initium-odp/pull/66.diff","patch_url":"https://github.com/Emperorlou/initium-odp/pull/66.patch","issue_url":"https://api.github.com/repos/Emperorlou/initium-odp/issues/66","number":66,"state":"open","locked":false,"title":"Collapsed ODPDBAccess trade stuff into Commands.","user":{"login":"Davos-Onomous","id":20169281,"avatar_url":"https://avatars.githubusercontent.com/u/20169281?v=3","gravatar_id":"","url":"https://api.github.com/users/Davos-Onomous","html_url":"https://github.com/Davos-Onomous","followers_url":"https://api.github.com/users/Davos-Onomous/followers","following_url":"https://api.github.com/users/Davos-Onomous/following{/other_user}","gists_url":"https://api.github.com/users/Davos-Onomous/gists{/gist_id}","starred_url":"https://api.github.com/users/Davos-Onomous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Davos-Onomous/subscriptions","organizations_url":"https://api.github.com/users/Davos-Onomous/orgs","repos_url":"https://api.github.com/users/Davos-Onomous/repos","events_url":"https://api.github.com/users/Davos-Onomous/events{/privacy}","received_events_url":"https://api.github.com/users/Davos-Onomous/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-05T15:03:35Z","updated_at":"2016-08-05T15:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93b5d572a18d9a4c58df082dbeaadda504bba886","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66/commits","review_comments_url":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66/comments","review_comment_url":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Emperorlou/initium-odp/issues/66/comments","statuses_url":"https://api.github.com/repos/Emperorlou/initium-odp/statuses/70448a1658725979f59b01f0834463b26744531d","head":{"label":"Davos-Onomous:master","ref":"master","sha":"70448a1658725979f59b01f0834463b26744531d","user":{"login":"Davos-Onomous","id":20169281,"avatar_url":"https://avatars.githubusercontent.com/u/20169281?v=3","gravatar_id":"","url":"https://api.github.com/users/Davos-Onomous","html_url":"https://github.com/Davos-Onomous","followers_url":"https://api.github.com/users/Davos-Onomous/followers","following_url":"https://api.github.com/users/Davos-Onomous/following{/other_user}","gists_url":"https://api.github.com/users/Davos-Onomous/gists{/gist_id}","starred_url":"https://api.github.com/users/Davos-Onomous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Davos-Onomous/subscriptions","organizations_url":"https://api.github.com/users/Davos-Onomous/orgs","repos_url":"https://api.github.com/users/Davos-Onomous/repos","events_url":"https://api.github.com/users/Davos-Onomous/events{/privacy}","received_events_url":"https://api.github.com/users/Davos-Onomous/received_events","type":"User","site_admin":false},"repo":{"id":65026797,"name":"initium-odp","full_name":"Davos-Onomous/initium-odp","owner":{"login":"Davos-Onomous","id":20169281,"avatar_url":"https://avatars.githubusercontent.com/u/20169281?v=3","gravatar_id":"","url":"https://api.github.com/users/Davos-Onomous","html_url":"https://github.com/Davos-Onomous","followers_url":"https://api.github.com/users/Davos-Onomous/followers","following_url":"https://api.github.com/users/Davos-Onomous/following{/other_user}","gists_url":"https://api.github.com/users/Davos-Onomous/gists{/gist_id}","starred_url":"https://api.github.com/users/Davos-Onomous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Davos-Onomous/subscriptions","organizations_url":"https://api.github.com/users/Davos-Onomous/orgs","repos_url":"https://api.github.com/users/Davos-Onomous/repos","events_url":"https://api.github.com/users/Davos-Onomous/events{/privacy}","received_events_url":"https://api.github.com/users/Davos-Onomous/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Davos-Onomous/initium-odp","description":"This project allows people to contribute to the parts of Initium that are open source.","fork":true,"url":"https://api.github.com/repos/Davos-Onomous/initium-odp","forks_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/forks","keys_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/teams","hooks_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/hooks","issue_events_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/issues/events{/number}","events_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/events","assignees_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/assignees{/user}","branches_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/branches{/branch}","tags_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/tags","blobs_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/languages","stargazers_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/stargazers","contributors_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/contributors","subscribers_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/subscribers","subscription_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/subscription","commits_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/contents/{+path}","compare_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/merges","archive_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/downloads","issues_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/issues{/number}","pulls_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/labels{/name}","releases_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/releases{/id}","deployments_url":"https://api.github.com/repos/Davos-Onomous/initium-odp/deployments","created_at":"2016-08-05T14:53:51Z","updated_at":"2016-08-05T14:53:53Z","pushed_at":"2016-08-05T15:25:21Z","git_url":"git://github.com/Davos-Onomous/initium-odp.git","ssh_url":"git@github.com:Davos-Onomous/initium-odp.git","clone_url":"https://github.com/Davos-Onomous/initium-odp.git","svn_url":"https://github.com/Davos-Onomous/initium-odp","homepage":null,"size":39576,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Emperorlou:master","ref":"master","sha":"c2a8f6e1a1c10759918ba6bf86d49c2cf49b5b25","user":{"login":"Emperorlou","id":315164,"avatar_url":"https://avatars.githubusercontent.com/u/315164?v=3","gravatar_id":"","url":"https://api.github.com/users/Emperorlou","html_url":"https://github.com/Emperorlou","followers_url":"https://api.github.com/users/Emperorlou/followers","following_url":"https://api.github.com/users/Emperorlou/following{/other_user}","gists_url":"https://api.github.com/users/Emperorlou/gists{/gist_id}","starred_url":"https://api.github.com/users/Emperorlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emperorlou/subscriptions","organizations_url":"https://api.github.com/users/Emperorlou/orgs","repos_url":"https://api.github.com/users/Emperorlou/repos","events_url":"https://api.github.com/users/Emperorlou/events{/privacy}","received_events_url":"https://api.github.com/users/Emperorlou/received_events","type":"User","site_admin":false},"repo":{"id":54856890,"name":"initium-odp","full_name":"Emperorlou/initium-odp","owner":{"login":"Emperorlou","id":315164,"avatar_url":"https://avatars.githubusercontent.com/u/315164?v=3","gravatar_id":"","url":"https://api.github.com/users/Emperorlou","html_url":"https://github.com/Emperorlou","followers_url":"https://api.github.com/users/Emperorlou/followers","following_url":"https://api.github.com/users/Emperorlou/following{/other_user}","gists_url":"https://api.github.com/users/Emperorlou/gists{/gist_id}","starred_url":"https://api.github.com/users/Emperorlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emperorlou/subscriptions","organizations_url":"https://api.github.com/users/Emperorlou/orgs","repos_url":"https://api.github.com/users/Emperorlou/repos","events_url":"https://api.github.com/users/Emperorlou/events{/privacy}","received_events_url":"https://api.github.com/users/Emperorlou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Emperorlou/initium-odp","description":"This project allows people to contribute to the parts of Initium that are open source.","fork":false,"url":"https://api.github.com/repos/Emperorlou/initium-odp","forks_url":"https://api.github.com/repos/Emperorlou/initium-odp/forks","keys_url":"https://api.github.com/repos/Emperorlou/initium-odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Emperorlou/initium-odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Emperorlou/initium-odp/teams","hooks_url":"https://api.github.com/repos/Emperorlou/initium-odp/hooks","issue_events_url":"https://api.github.com/repos/Emperorlou/initium-odp/issues/events{/number}","events_url":"https://api.github.com/repos/Emperorlou/initium-odp/events","assignees_url":"https://api.github.com/repos/Emperorlou/initium-odp/assignees{/user}","branches_url":"https://api.github.com/repos/Emperorlou/initium-odp/branches{/branch}","tags_url":"https://api.github.com/repos/Emperorlou/initium-odp/tags","blobs_url":"https://api.github.com/repos/Emperorlou/initium-odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Emperorlou/initium-odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Emperorlou/initium-odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Emperorlou/initium-odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Emperorlou/initium-odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Emperorlou/initium-odp/languages","stargazers_url":"https://api.github.com/repos/Emperorlou/initium-odp/stargazers","contributors_url":"https://api.github.com/repos/Emperorlou/initium-odp/contributors","subscribers_url":"https://api.github.com/repos/Emperorlou/initium-odp/subscribers","subscription_url":"https://api.github.com/repos/Emperorlou/initium-odp/subscription","commits_url":"https://api.github.com/repos/Emperorlou/initium-odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Emperorlou/initium-odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Emperorlou/initium-odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Emperorlou/initium-odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Emperorlou/initium-odp/contents/{+path}","compare_url":"https://api.github.com/repos/Emperorlou/initium-odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Emperorlou/initium-odp/merges","archive_url":"https://api.github.com/repos/Emperorlou/initium-odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Emperorlou/initium-odp/downloads","issues_url":"https://api.github.com/repos/Emperorlou/initium-odp/issues{/number}","pulls_url":"https://api.github.com/repos/Emperorlou/initium-odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Emperorlou/initium-odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Emperorlou/initium-odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Emperorlou/initium-odp/labels{/name}","releases_url":"https://api.github.com/repos/Emperorlou/initium-odp/releases{/id}","deployments_url":"https://api.github.com/repos/Emperorlou/initium-odp/deployments","created_at":"2016-03-28T01:31:30Z","updated_at":"2016-08-01T21:05:53Z","pushed_at":"2016-08-05T15:25:21Z","git_url":"git://github.com/Emperorlou/initium-odp.git","ssh_url":"git@github.com:Emperorlou/initium-odp.git","clone_url":"https://github.com/Emperorlou/initium-odp.git","svn_url":"https://github.com/Emperorlou/initium-odp","homepage":null,"size":39625,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66"},"html":{"href":"https://github.com/Emperorlou/initium-odp/pull/66"},"issue":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/issues/66"},"comments":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/Emperorlou/initium-odp/statuses/70448a1658725979f59b01f0834463b26744531d"}}}}
{"actor":{"display_login":"Emperorlou"}}