{"action":"created","comment":{"url":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/comments/88856684","pull_request_review_id":9415353,"id":88856684,"diff_hunk":"@@ -0,0 +1,77 @@\n+package meirs.topologymonitor.dds;\n+\n+import com.rti.dds.domain.DomainParticipant;\n+import com.rti.dds.domain.DomainParticipantFactory;\n+import com.rti.dds.domain.DomainParticipantQos;\n+import com.rti.dds.infrastructure.StatusKind;\n+import com.rti.dds.topic.Topic;\n+import com.rti.dds.topic.TopicDescription;\n+import com.rti.dds.topic.TopicQos;\n+import com.rti.dds.topic.TypeSupportImpl;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+/**\n+ * Created by mich8bsp on 18/11/16.","path":"backend/src/main/java/meirs/topologymonitor/dds/DDSUtils.java","position":15,"original_position":15,"commit_id":"5686936f748d48d1fca6e91fcb88825523d16997","original_commit_id":"5686936f748d48d1fca6e91fcb88825523d16997","user":{"login":"meirshal","id":10099743,"avatar_url":"https://avatars.githubusercontent.com/u/10099743?v=3","gravatar_id":"","url":"https://api.github.com/users/meirshal","html_url":"https://github.com/meirshal","followers_url":"https://api.github.com/users/meirshal/followers","following_url":"https://api.github.com/users/meirshal/following{/other_user}","gists_url":"https://api.github.com/users/meirshal/gists{/gist_id}","starred_url":"https://api.github.com/users/meirshal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirshal/subscriptions","organizations_url":"https://api.github.com/users/meirshal/orgs","repos_url":"https://api.github.com/users/meirshal/repos","events_url":"https://api.github.com/users/meirshal/events{/privacy}","received_events_url":"https://api.github.com/users/meirshal/received_events","type":"User","site_admin":false},"body":"let's make it a convention to write our full name.","created_at":"2016-11-21T09:36:24Z","updated_at":"2016-11-21T09:57:19Z","html_url":"https://github.com/meirshal/dds-topology-monitor/pull/7#discussion_r88856684","pull_request_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/comments/88856684"},"html":{"href":"https://github.com/meirshal/dds-topology-monitor/pull/7#discussion_r88856684"},"pull_request":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7","id":94358320,"html_url":"https://github.com/meirshal/dds-topology-monitor/pull/7","diff_url":"https://github.com/meirshal/dds-topology-monitor/pull/7.diff","patch_url":"https://github.com/meirshal/dds-topology-monitor/pull/7.patch","issue_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/issues/7","number":7,"state":"open","locked":false,"title":"Adding manual scenario to check end-to-end flow","user":{"login":"mich8bsp","id":5719693,"avatar_url":"https://avatars.githubusercontent.com/u/5719693?v=3","gravatar_id":"","url":"https://api.github.com/users/mich8bsp","html_url":"https://github.com/mich8bsp","followers_url":"https://api.github.com/users/mich8bsp/followers","following_url":"https://api.github.com/users/mich8bsp/following{/other_user}","gists_url":"https://api.github.com/users/mich8bsp/gists{/gist_id}","starred_url":"https://api.github.com/users/mich8bsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mich8bsp/subscriptions","organizations_url":"https://api.github.com/users/mich8bsp/orgs","repos_url":"https://api.github.com/users/mich8bsp/repos","events_url":"https://api.github.com/users/mich8bsp/events{/privacy}","received_events_url":"https://api.github.com/users/mich8bsp/received_events","type":"User","site_admin":false},"body":"1. moving participant and topic creating to DDSUtils  …\r\n2. using lookup topic on participant instead of creating, if exists (causes errors when trying to create a new one with the same name)\r\n3. Storing the QoS profile used when creating the participant and creating other entities with it.\r\n4. Adding \"ShapesDemo\" profile with monitoring library. (set NDDS_QOS_PROFILES env variable to the new location)\r\n5. Test scenario creating a bunch of writers/readers","created_at":"2016-11-18T13:04:19Z","updated_at":"2016-11-21T09:57:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82ceaa54c338609926db3199a53015b250244483","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7/commits","review_comments_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7/comments","review_comment_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/issues/7/comments","statuses_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/statuses/5686936f748d48d1fca6e91fcb88825523d16997","head":{"label":"mich8bsp:master","ref":"master","sha":"5686936f748d48d1fca6e91fcb88825523d16997","user":{"login":"mich8bsp","id":5719693,"avatar_url":"https://avatars.githubusercontent.com/u/5719693?v=3","gravatar_id":"","url":"https://api.github.com/users/mich8bsp","html_url":"https://github.com/mich8bsp","followers_url":"https://api.github.com/users/mich8bsp/followers","following_url":"https://api.github.com/users/mich8bsp/following{/other_user}","gists_url":"https://api.github.com/users/mich8bsp/gists{/gist_id}","starred_url":"https://api.github.com/users/mich8bsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mich8bsp/subscriptions","organizations_url":"https://api.github.com/users/mich8bsp/orgs","repos_url":"https://api.github.com/users/mich8bsp/repos","events_url":"https://api.github.com/users/mich8bsp/events{/privacy}","received_events_url":"https://api.github.com/users/mich8bsp/received_events","type":"User","site_admin":false},"repo":{"id":73745183,"name":"dds-topology-monitor","full_name":"mich8bsp/dds-topology-monitor","owner":{"login":"mich8bsp","id":5719693,"avatar_url":"https://avatars.githubusercontent.com/u/5719693?v=3","gravatar_id":"","url":"https://api.github.com/users/mich8bsp","html_url":"https://github.com/mich8bsp","followers_url":"https://api.github.com/users/mich8bsp/followers","following_url":"https://api.github.com/users/mich8bsp/following{/other_user}","gists_url":"https://api.github.com/users/mich8bsp/gists{/gist_id}","starred_url":"https://api.github.com/users/mich8bsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mich8bsp/subscriptions","organizations_url":"https://api.github.com/users/mich8bsp/orgs","repos_url":"https://api.github.com/users/mich8bsp/repos","events_url":"https://api.github.com/users/mich8bsp/events{/privacy}","received_events_url":"https://api.github.com/users/mich8bsp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mich8bsp/dds-topology-monitor","description":null,"fork":true,"url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor","forks_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/forks","keys_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/teams","hooks_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/hooks","issue_events_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/events","assignees_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/tags","blobs_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/languages","stargazers_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/stargazers","contributors_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/contributors","subscribers_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/subscribers","subscription_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/subscription","commits_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/merges","archive_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/downloads","issues_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/labels{/name}","releases_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/mich8bsp/dds-topology-monitor/deployments","created_at":"2016-11-14T20:42:12Z","updated_at":"2016-11-14T20:42:17Z","pushed_at":"2016-11-18T12:59:51Z","git_url":"git://github.com/mich8bsp/dds-topology-monitor.git","ssh_url":"git@github.com:mich8bsp/dds-topology-monitor.git","clone_url":"https://github.com/mich8bsp/dds-topology-monitor.git","svn_url":"https://github.com/mich8bsp/dds-topology-monitor","homepage":null,"size":343,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meirshal:master","ref":"master","sha":"f9977f8833f0eaaa8675002c86394a7ce97f4915","user":{"login":"meirshal","id":10099743,"avatar_url":"https://avatars.githubusercontent.com/u/10099743?v=3","gravatar_id":"","url":"https://api.github.com/users/meirshal","html_url":"https://github.com/meirshal","followers_url":"https://api.github.com/users/meirshal/followers","following_url":"https://api.github.com/users/meirshal/following{/other_user}","gists_url":"https://api.github.com/users/meirshal/gists{/gist_id}","starred_url":"https://api.github.com/users/meirshal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirshal/subscriptions","organizations_url":"https://api.github.com/users/meirshal/orgs","repos_url":"https://api.github.com/users/meirshal/repos","events_url":"https://api.github.com/users/meirshal/events{/privacy}","received_events_url":"https://api.github.com/users/meirshal/received_events","type":"User","site_admin":false},"repo":{"id":66145866,"name":"dds-topology-monitor","full_name":"meirshal/dds-topology-monitor","owner":{"login":"meirshal","id":10099743,"avatar_url":"https://avatars.githubusercontent.com/u/10099743?v=3","gravatar_id":"","url":"https://api.github.com/users/meirshal","html_url":"https://github.com/meirshal","followers_url":"https://api.github.com/users/meirshal/followers","following_url":"https://api.github.com/users/meirshal/following{/other_user}","gists_url":"https://api.github.com/users/meirshal/gists{/gist_id}","starred_url":"https://api.github.com/users/meirshal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirshal/subscriptions","organizations_url":"https://api.github.com/users/meirshal/orgs","repos_url":"https://api.github.com/users/meirshal/repos","events_url":"https://api.github.com/users/meirshal/events{/privacy}","received_events_url":"https://api.github.com/users/meirshal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meirshal/dds-topology-monitor","description":null,"fork":false,"url":"https://api.github.com/repos/meirshal/dds-topology-monitor","forks_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/forks","keys_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/teams","hooks_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/hooks","issue_events_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/events","assignees_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/tags","blobs_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/languages","stargazers_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/stargazers","contributors_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/contributors","subscribers_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/subscribers","subscription_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/subscription","commits_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/merges","archive_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/downloads","issues_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/labels{/name}","releases_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/meirshal/dds-topology-monitor/deployments","created_at":"2016-08-20T12:35:52Z","updated_at":"2016-08-20T12:54:47Z","pushed_at":"2016-11-18T13:04:19Z","git_url":"git://github.com/meirshal/dds-topology-monitor.git","ssh_url":"git@github.com:meirshal/dds-topology-monitor.git","clone_url":"https://github.com/meirshal/dds-topology-monitor.git","svn_url":"https://github.com/meirshal/dds-topology-monitor","homepage":null,"size":341,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7"},"html":{"href":"https://github.com/meirshal/dds-topology-monitor/pull/7"},"issue":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/issues/7"},"comments":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/meirshal/dds-topology-monitor/statuses/5686936f748d48d1fca6e91fcb88825523d16997"}}}}
{"actor":{"display_login":"meirshal"}}