{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/sulu/pulls/comments/91682347","pull_request_review_id":12191682,"id":91682347,"diff_hunk":"@@ -59,99 +54,118 @@ private function getGetBooleanRequestParameterReflection()\n \n     public function testGetRequestParameter()\n     {\n-        $request = $this->getRequestMock(\n-            [\n-                ['test', null, false, 'data'],\n-                ['none', 'default', false, 'default'],\n-            ]\n-        );\n+        $request = $this->prophesize(Request::class);\n+        $request->get('test', null)->willReturn('data');\n+        $request->get('none', 'default')->willReturn('default');\n \n         $getRequestParameterReflection = $this->getGetRequestParameterReflection();\n \n         $this->assertEquals(\n             'data',\n-            $getRequestParameterReflection->invoke($this->requestParametersTrait, $request, 'test')\n+            $getRequestParameterReflection->invoke($this->requestParametersTrait, $request->reveal(), 'test')\n         );\n \n         $this->assertEquals(\n             'data',\n-            $getRequestParameterReflection->invoke($this->requestParametersTrait, $request, 'test', true)\n+            $getRequestParameterReflection->invoke($this->requestParametersTrait, $request->reveal(), 'test', true)\n         );\n \n         $this->assertEquals(\n             'default',\n-            $getRequestParameterReflection->invoke($this->requestParametersTrait, $request, 'none', false, 'default')\n+            $getRequestParameterReflection->invoke(\n+                $this->requestParametersTrait,\n+                $request->reveal(),\n+                'none',\n+                false,\n+                'default'\n+            )\n         );\n     }\n \n     public function testGetRequestParameterFail()\n     {\n-        $this->setExpectedException('Sulu\\Component\\Rest\\Exception\\MissingParameterException');\n+        $this->setExpectedException(MissingParameterException::class);\n \n         $getRequestParameterReflection = $this->getGetRequestParameterReflection();\n-        $request = $this->getRequestMock([]);\n+        $request = $this->prophesize(Request::class);\n \n-        $getRequestParameterReflection->invoke($this->requestParametersTrait, $request, 'test', true);\n+        $getRequestParameterReflection->invoke($this->requestParametersTrait, $request->reveal(), 'test', true);\n     }\n \n     public function testGetBooleanRequestParameter()\n     {\n-        $request = $this->getRequestMock(\n-            [\n-                ['test1', null, false, 'true'],\n-                ['test2', null, false, 'false'],\n-                ['none', 'default', false, null],\n-            ]\n-        );\n+        $request = $this->prophesize(Request::class);\n+        $request->get('test1', null)->willReturn('true');\n+        $request->get('test2', null)->willReturn('false');\n+        $request->get('none', null)->willReturn(null);\n+        $request->get('none', true)->willReturn(true);","path":"src/Sulu/Component/Rest/Tests/Unit/RequestParametersTraitTest.php","position":107,"original_position":107,"commit_id":"4eb167d955926ea965800a6d7f1940ebedf0a2b2","original_commit_id":"4eb167d955926ea965800a6d7f1940ebedf0a2b2","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"Same as above","created_at":"2016-12-09T09:27:38Z","updated_at":"2016-12-09T09:27:38Z","html_url":"https://github.com/sulu/sulu/pull/3072#discussion_r91682347","pull_request_url":"https://api.github.com/repos/sulu/sulu/pulls/3072","_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments/91682347"},"html":{"href":"https://github.com/sulu/sulu/pull/3072#discussion_r91682347"},"pull_request":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3072"}}},"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/3072","id":96888749,"html_url":"https://github.com/sulu/sulu/pull/3072","diff_url":"https://github.com/sulu/sulu/pull/3072.diff","patch_url":"https://github.com/sulu/sulu/pull/3072.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/3072","number":3072,"state":"open","locked":false,"title":"Fixed testcases of admin- and snippet-bundle for symfony 3.0","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | no\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | none\r\n| Related issues/PRs | is a part of #2106 \r\n| License | MIT\r\n| Documentation PR | none\r\n\r\n#### What's in this PR?\r\n\r\nThis PR fixes testcases of admin- and snippet-bundle for symfony 3.\r\n\r\n* AdminBundle\r\n* SnippetBundle","created_at":"2016-12-07T09:43:43Z","updated_at":"2016-12-09T09:28:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e602de985129f0ba6ac40e15eb6f092c2f075cc7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/3072/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/3072/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/3072/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/4eb167d955926ea965800a6d7f1940ebedf0a2b2","head":{"label":"wachterjohannes:enhancement/symfony-3-deprectations","ref":"enhancement/symfony-3-deprectations","sha":"4eb167d955926ea965800a6d7f1940ebedf0a2b2","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"repo":{"id":53324547,"name":"sulu","full_name":"wachterjohannes/sulu","owner":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wachterjohannes/sulu","description":"Sulu core bundles & components","fork":true,"url":"https://api.github.com/repos/wachterjohannes/sulu","forks_url":"https://api.github.com/repos/wachterjohannes/sulu/forks","keys_url":"https://api.github.com/repos/wachterjohannes/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wachterjohannes/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wachterjohannes/sulu/teams","hooks_url":"https://api.github.com/repos/wachterjohannes/sulu/hooks","issue_events_url":"https://api.github.com/repos/wachterjohannes/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/wachterjohannes/sulu/events","assignees_url":"https://api.github.com/repos/wachterjohannes/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/wachterjohannes/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/wachterjohannes/sulu/tags","blobs_url":"https://api.github.com/repos/wachterjohannes/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wachterjohannes/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wachterjohannes/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/wachterjohannes/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wachterjohannes/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/wachterjohannes/sulu/languages","stargazers_url":"https://api.github.com/repos/wachterjohannes/sulu/stargazers","contributors_url":"https://api.github.com/repos/wachterjohannes/sulu/contributors","subscribers_url":"https://api.github.com/repos/wachterjohannes/sulu/subscribers","subscription_url":"https://api.github.com/repos/wachterjohannes/sulu/subscription","commits_url":"https://api.github.com/repos/wachterjohannes/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/wachterjohannes/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/wachterjohannes/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/wachterjohannes/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/wachterjohannes/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/wachterjohannes/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wachterjohannes/sulu/merges","archive_url":"https://api.github.com/repos/wachterjohannes/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wachterjohannes/sulu/downloads","issues_url":"https://api.github.com/repos/wachterjohannes/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/wachterjohannes/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/wachterjohannes/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/wachterjohannes/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wachterjohannes/sulu/labels{/name}","releases_url":"https://api.github.com/repos/wachterjohannes/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/wachterjohannes/sulu/deployments","created_at":"2016-03-07T12:38:55Z","updated_at":"2016-03-07T12:39:01Z","pushed_at":"2016-12-09T08:29:01Z","git_url":"git://github.com/wachterjohannes/sulu.git","ssh_url":"git@github.com:wachterjohannes/sulu.git","clone_url":"https://github.com/wachterjohannes/sulu.git","svn_url":"https://github.com/wachterjohannes/sulu","homepage":"sulu.io","size":84535,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:develop","ref":"develop","sha":"c3166ee0e5228cefd36caef222f292caca9cfeef","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-12-05T20:13:20Z","pushed_at":"2016-12-09T08:03:39Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":95864,"stargazers_count":155,"watchers_count":155,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":442,"forks":69,"open_issues":442,"watchers":155,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3072"},"html":{"href":"https://github.com/sulu/sulu/pull/3072"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/3072"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/3072/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3072/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3072/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/4eb167d955926ea965800a6d7f1940ebedf0a2b2"}}}}
{"actor":{"display_login":"danrot"}}