{"action":"created","issue":{"url":"https://api.github.com/repos/cms-analysis/flashgg/issues/522","labels_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/522/labels{/name}","comments_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/522/comments","events_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/522/events","html_url":"https://github.com/cms-analysis/flashgg/pull/522","id":129774938,"number":522,"title":"electron id scale factors","user":{"login":"martinamalberti","id":4562259,"avatar_url":"https://avatars.githubusercontent.com/u/4562259?v=3","gravatar_id":"","url":"https://api.github.com/users/martinamalberti","html_url":"https://github.com/martinamalberti","followers_url":"https://api.github.com/users/martinamalberti/followers","following_url":"https://api.github.com/users/martinamalberti/following{/other_user}","gists_url":"https://api.github.com/users/martinamalberti/gists{/gist_id}","starred_url":"https://api.github.com/users/martinamalberti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinamalberti/subscriptions","organizations_url":"https://api.github.com/users/martinamalberti/orgs","repos_url":"https://api.github.com/users/martinamalberti/repos","events_url":"https://api.github.com/users/martinamalberti/events{/privacy}","received_events_url":"https://api.github.com/users/martinamalberti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-29T14:07:44Z","updated_at":"2016-01-29T14:55:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/522","html_url":"https://github.com/cms-analysis/flashgg/pull/522","diff_url":"https://github.com/cms-analysis/flashgg/pull/522.diff","patch_url":"https://github.com/cms-analysis/flashgg/pull/522.patch"},"body":"Electron ID scale factors for cutbased Id, loose working point.\r\nPreliminary values from M. Sani: /afs/cern.ch/work/a/arun/public/forEGM/CutBased_textFiles_withSyst/CutBasedID_LooseWP_fromTemplates_withSyst_v1.txt"},"comment":{"url":"https://api.github.com/repos/cms-analysis/flashgg/issues/comments/176795103","html_url":"https://github.com/cms-analysis/flashgg/pull/522#issuecomment-176795103","issue_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/522","id":176795103,"user":{"login":"ferriff","id":4131370,"avatar_url":"https://avatars.githubusercontent.com/u/4131370?v=3","gravatar_id":"","url":"https://api.github.com/users/ferriff","html_url":"https://github.com/ferriff","followers_url":"https://api.github.com/users/ferriff/followers","following_url":"https://api.github.com/users/ferriff/following{/other_user}","gists_url":"https://api.github.com/users/ferriff/gists{/gist_id}","starred_url":"https://api.github.com/users/ferriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferriff/subscriptions","organizations_url":"https://api.github.com/users/ferriff/orgs","repos_url":"https://api.github.com/users/ferriff/repos","events_url":"https://api.github.com/users/ferriff/events{/privacy}","received_events_url":"https://api.github.com/users/ferriff/received_events","type":"User","site_admin":false},"created_at":"2016-01-29T14:55:28Z","updated_at":"2016-01-29T14:55:28Z","body":"OK with me.\n\nOn Fri, Jan 29, 2016 at 06:40:40AM -0800, Matteo Sani wrote:\n> I think it make sense to remove the interpolation.\n> \n> Regards,\n>      Matteo.\n> \n> +++++++++++\n> Matteo Sani\n> University of California, San Diego, US.\n> Tel: +41227671577\n> CERN Office: 40-3-A02\n> \n> \n> On Fri, Jan 29, 2016 at 3:33 PM, Seth Zenz <notifications@github.com> wrote:\n> \n> > @molmedon <https://github.com/molmedon> can confirm, but I think the\n> > interpolation code isn't set up to interpolate in some variables and not\n> > others. In fact I am not quite sure what it will do if there's >1 variable\n> > at a time:\n> >\n> >\n> > https://github.com/cms-analysis/flashgg/blob/master/Systematics/interface/ObjectSystMethodBinnedByFunctor.h#L49-L91\n> >\n> > https://github.com/cms-analysis/flashgg/blob/master/Systematics/interface/ObjectEffScale.h#L39-L114\n> >\n> > Therefore the proposal is that we turn off all interpolation for the\n> > current round and revisit it later. This does not require changing this PR;\n> > I'll make the change afterward. But comments are appreciated!\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <https://github.com/cms-analysis/flashgg/pull/522#issuecomment-176783485>.\n> >\n> \n> \n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/cms-analysis/flashgg/pull/522#issuecomment-176787301\n"}}