{"action":"created","comment":{"url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments/55143339","id":55143339,"diff_hunk":"@@ -119,6 +119,6 @@ def play(self):\n \n     def sparklines(self, c_symbol=u'█', d_symbol=u' '):\n         return (\n-            sparkline(self._player1.history, c_symbol, d_symbol) +\n+            sparkline(self.player1.history, c_symbol, d_symbol) +\n             u'\\n' +\n-            sparkline(self._player2.history, c_symbol, d_symbol))\n+            sparkline(self.player2.history, c_symbol, d_symbol))","path":"axelrod/match.py","position":58,"original_position":58,"commit_id":"34b9f9aa3c24994d0efb60c188c41df9a4f1c2c0","original_commit_id":"34b9f9aa3c24994d0efb60c188c41df9a4f1c2c0","user":{"login":"meatballs","id":338846,"avatar_url":"https://avatars.githubusercontent.com/u/338846?v=3","gravatar_id":"","url":"https://api.github.com/users/meatballs","html_url":"https://github.com/meatballs","followers_url":"https://api.github.com/users/meatballs/followers","following_url":"https://api.github.com/users/meatballs/following{/other_user}","gists_url":"https://api.github.com/users/meatballs/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballs/subscriptions","organizations_url":"https://api.github.com/users/meatballs/orgs","repos_url":"https://api.github.com/users/meatballs/repos","events_url":"https://api.github.com/users/meatballs/events{/privacy}","received_events_url":"https://api.github.com/users/meatballs/received_events","type":"User","site_admin":false},"body":"cock up!","created_at":"2016-03-06T16:25:44Z","updated_at":"2016-03-06T16:25:44Z","html_url":"https://github.com/Axelrod-Python/Axelrod/pull/474#discussion_r55143339","pull_request_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474","_links":{"self":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments/55143339"},"html":{"href":"https://github.com/Axelrod-Python/Axelrod/pull/474#discussion_r55143339"},"pull_request":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474"}}},"pull_request":{"url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474","id":61577570,"html_url":"https://github.com/Axelrod-Python/Axelrod/pull/474","diff_url":"https://github.com/Axelrod-Python/Axelrod/pull/474.diff","patch_url":"https://github.com/Axelrod-Python/Axelrod/pull/474.patch","issue_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/474","number":474,"state":"open","locked":false,"title":"Interactions and RoundRobin","user":{"login":"meatballs","id":338846,"avatar_url":"https://avatars.githubusercontent.com/u/338846?v=3","gravatar_id":"","url":"https://api.github.com/users/meatballs","html_url":"https://github.com/meatballs","followers_url":"https://api.github.com/users/meatballs/followers","following_url":"https://api.github.com/users/meatballs/following{/other_user}","gists_url":"https://api.github.com/users/meatballs/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballs/subscriptions","organizations_url":"https://api.github.com/users/meatballs/orgs","repos_url":"https://api.github.com/users/meatballs/repos","events_url":"https://api.github.com/users/meatballs/events{/privacy}","received_events_url":"https://api.github.com/users/meatballs/received_events","type":"User","site_admin":false},"body":"This is the final piece of work on #284. It will:\r\n\r\n* Add tournament_type.py\r\nThis module contains a ```round_robin``` function which is passed to the Tournament class. It defines the set of Match objects to be be played for the tournament.\r\n\r\nThe idea is that other types of tournament could be represented as functions with the same signature and passed to Tournament objects. This could be done either within the tournament_type module, if we want that type permanently within the library, or ad-hoc by individual users.\r\n\r\n* Add ```Tournament.type```\r\nThis is a new parameter in the __init__ method for Tournament. It expects a function to be passed which defines the set of matches to play.\r\n\r\n* Refactor the ```Tournament._play_round_robin``` method\r\nThis is replaced by ```Tournament.play_matches``` and the ```tournament_type``` module.\r\n\r\n* Remove the now redundant RoundRobin class\r\n\r\n* Rename the integration test ```test_round_robin``` to ```test_sample_tournaments``` and refactor its content\r\n\r\n* Add ```Tournament.matches```\r\nThis is a list of lists - one entry per repetition each containing a list of axelrod.Match objects. Its population is controlled by the ```keep_matches``` parameter which has been added to ```Tournament.__init__``` with a default value of False.\r\n","created_at":"2016-03-03T15:41:17Z","updated_at":"2016-03-06T16:25:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8a956894f2ddf169a7c34529b73421c5cd59bcb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474/commits","review_comments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474/comments","review_comment_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/474/comments","statuses_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/statuses/34b9f9aa3c24994d0efb60c188c41df9a4f1c2c0","head":{"label":"Axelrod-Python:284","ref":"284","sha":"34b9f9aa3c24994d0efb60c188c41df9a4f1c2c0","user":{"login":"Axelrod-Python","id":11720937,"avatar_url":"https://avatars.githubusercontent.com/u/11720937?v=3","gravatar_id":"","url":"https://api.github.com/users/Axelrod-Python","html_url":"https://github.com/Axelrod-Python","followers_url":"https://api.github.com/users/Axelrod-Python/followers","following_url":"https://api.github.com/users/Axelrod-Python/following{/other_user}","gists_url":"https://api.github.com/users/Axelrod-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Axelrod-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axelrod-Python/subscriptions","organizations_url":"https://api.github.com/users/Axelrod-Python/orgs","repos_url":"https://api.github.com/users/Axelrod-Python/repos","events_url":"https://api.github.com/users/Axelrod-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Axelrod-Python/received_events","type":"Organization","site_admin":false},"repo":{"id":30959449,"name":"Axelrod","full_name":"Axelrod-Python/Axelrod","owner":{"login":"Axelrod-Python","id":11720937,"avatar_url":"https://avatars.githubusercontent.com/u/11720937?v=3","gravatar_id":"","url":"https://api.github.com/users/Axelrod-Python","html_url":"https://github.com/Axelrod-Python","followers_url":"https://api.github.com/users/Axelrod-Python/followers","following_url":"https://api.github.com/users/Axelrod-Python/following{/other_user}","gists_url":"https://api.github.com/users/Axelrod-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Axelrod-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axelrod-Python/subscriptions","organizations_url":"https://api.github.com/users/Axelrod-Python/orgs","repos_url":"https://api.github.com/users/Axelrod-Python/repos","events_url":"https://api.github.com/users/Axelrod-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Axelrod-Python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Axelrod-Python/Axelrod","description":"A library to run Iterated Prisoner's Dilemma tournaments","fork":false,"url":"https://api.github.com/repos/Axelrod-Python/Axelrod","forks_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/forks","keys_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/teams","hooks_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/hooks","issue_events_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/events{/number}","events_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/events","assignees_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/assignees{/user}","branches_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/branches{/branch}","tags_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/tags","blobs_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/refs{/sha}","trees_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/statuses/{sha}","languages_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/languages","stargazers_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/stargazers","contributors_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/contributors","subscribers_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/subscribers","subscription_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/subscription","commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/commits{/sha}","git_commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/commits{/sha}","comments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/comments{/number}","issue_comment_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/comments{/number}","contents_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/contents/{+path}","compare_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/merges","archive_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/downloads","issues_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues{/number}","pulls_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls{/number}","milestones_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/milestones{/number}","notifications_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/labels{/name}","releases_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/releases{/id}","deployments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/deployments","created_at":"2015-02-18T09:37:17Z","updated_at":"2016-01-17T21:06:05Z","pushed_at":"2016-03-05T10:03:40Z","git_url":"git://github.com/Axelrod-Python/Axelrod.git","ssh_url":"git@github.com:Axelrod-Python/Axelrod.git","clone_url":"https://github.com/Axelrod-Python/Axelrod.git","svn_url":"https://github.com/Axelrod-Python/Axelrod","homepage":"http://axelrod.readthedocs.org/","size":136859,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":25,"forks":44,"open_issues":25,"watchers":56,"default_branch":"master"}},"base":{"label":"Axelrod-Python:master","ref":"master","sha":"26813804c6765148a870a39f3f005a301b9e597a","user":{"login":"Axelrod-Python","id":11720937,"avatar_url":"https://avatars.githubusercontent.com/u/11720937?v=3","gravatar_id":"","url":"https://api.github.com/users/Axelrod-Python","html_url":"https://github.com/Axelrod-Python","followers_url":"https://api.github.com/users/Axelrod-Python/followers","following_url":"https://api.github.com/users/Axelrod-Python/following{/other_user}","gists_url":"https://api.github.com/users/Axelrod-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Axelrod-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axelrod-Python/subscriptions","organizations_url":"https://api.github.com/users/Axelrod-Python/orgs","repos_url":"https://api.github.com/users/Axelrod-Python/repos","events_url":"https://api.github.com/users/Axelrod-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Axelrod-Python/received_events","type":"Organization","site_admin":false},"repo":{"id":30959449,"name":"Axelrod","full_name":"Axelrod-Python/Axelrod","owner":{"login":"Axelrod-Python","id":11720937,"avatar_url":"https://avatars.githubusercontent.com/u/11720937?v=3","gravatar_id":"","url":"https://api.github.com/users/Axelrod-Python","html_url":"https://github.com/Axelrod-Python","followers_url":"https://api.github.com/users/Axelrod-Python/followers","following_url":"https://api.github.com/users/Axelrod-Python/following{/other_user}","gists_url":"https://api.github.com/users/Axelrod-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Axelrod-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axelrod-Python/subscriptions","organizations_url":"https://api.github.com/users/Axelrod-Python/orgs","repos_url":"https://api.github.com/users/Axelrod-Python/repos","events_url":"https://api.github.com/users/Axelrod-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Axelrod-Python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Axelrod-Python/Axelrod","description":"A library to run Iterated Prisoner's Dilemma tournaments","fork":false,"url":"https://api.github.com/repos/Axelrod-Python/Axelrod","forks_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/forks","keys_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/teams","hooks_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/hooks","issue_events_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/events{/number}","events_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/events","assignees_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/assignees{/user}","branches_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/branches{/branch}","tags_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/tags","blobs_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/refs{/sha}","trees_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/statuses/{sha}","languages_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/languages","stargazers_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/stargazers","contributors_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/contributors","subscribers_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/subscribers","subscription_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/subscription","commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/commits{/sha}","git_commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/commits{/sha}","comments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/comments{/number}","issue_comment_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/comments{/number}","contents_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/contents/{+path}","compare_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/merges","archive_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/downloads","issues_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues{/number}","pulls_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls{/number}","milestones_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/milestones{/number}","notifications_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/labels{/name}","releases_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/releases{/id}","deployments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/deployments","created_at":"2015-02-18T09:37:17Z","updated_at":"2016-01-17T21:06:05Z","pushed_at":"2016-03-05T10:03:40Z","git_url":"git://github.com/Axelrod-Python/Axelrod.git","ssh_url":"git@github.com:Axelrod-Python/Axelrod.git","clone_url":"https://github.com/Axelrod-Python/Axelrod.git","svn_url":"https://github.com/Axelrod-Python/Axelrod","homepage":"http://axelrod.readthedocs.org/","size":136859,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":25,"forks":44,"open_issues":25,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474"},"html":{"href":"https://github.com/Axelrod-Python/Axelrod/pull/474"},"issue":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/474"},"comments":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/statuses/34b9f9aa3c24994d0efb60c188c41df9a4f1c2c0"}}}}