{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/2361","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/2361/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/2361/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/2361/events","html_url":"https://github.com/oppia/oppia/pull/2361","id":170477633,"number":2361,"title":"Simplify logic and use one-time binding syntax in admin page","user":{"login":"526avijitgupta","id":7583815,"avatar_url":"https://avatars.githubusercontent.com/u/7583815?v=3","gravatar_id":"","url":"https://api.github.com/users/526avijitgupta","html_url":"https://github.com/526avijitgupta","followers_url":"https://api.github.com/users/526avijitgupta/followers","following_url":"https://api.github.com/users/526avijitgupta/following{/other_user}","gists_url":"https://api.github.com/users/526avijitgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/526avijitgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/526avijitgupta/subscriptions","organizations_url":"https://api.github.com/users/526avijitgupta/orgs","repos_url":"https://api.github.com/users/526avijitgupta/repos","events_url":"https://api.github.com/users/526avijitgupta/events{/privacy}","received_events_url":"https://api.github.com/users/526avijitgupta/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/oppia/oppia/labels/PR:%20don't%20merge%20-%20IN%20REVIEW","name":"PR: don't merge - IN REVIEW","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"assignees":[{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-08-10T17:50:00Z","updated_at":"2016-09-09T09:32:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/2361","html_url":"https://github.com/oppia/oppia/pull/2361","diff_url":"https://github.com/oppia/oppia/pull/2361.diff","patch_url":"https://github.com/oppia/oppia/pull/2361.patch"},"body":"Tasklist:\r\n- [x] Found out that the logic in admin page was unnecessarily complex, and the same function was being called twice when switching tabs (due to it being bound to ng-click, as well as a watcher on url's hash!) -- thus simplified the logic.\r\n\r\n\r\n- [x] ~~Use one-time binding for variables used as constants, or any other expressions.~~\r\n- [x] ~~Get variables unbounded to `$scope` or `$rootScope` if not necessary.~~\r\n\r\n^To be done in a new PR."},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/245866206","html_url":"https://github.com/oppia/oppia/pull/2361#issuecomment-245866206","issue_url":"https://api.github.com/repos/oppia/oppia/issues/2361","id":245866206,"user":{"login":"526avijitgupta","id":7583815,"avatar_url":"https://avatars.githubusercontent.com/u/7583815?v=3","gravatar_id":"","url":"https://api.github.com/users/526avijitgupta","html_url":"https://github.com/526avijitgupta","followers_url":"https://api.github.com/users/526avijitgupta/followers","following_url":"https://api.github.com/users/526avijitgupta/following{/other_user}","gists_url":"https://api.github.com/users/526avijitgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/526avijitgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/526avijitgupta/subscriptions","organizations_url":"https://api.github.com/users/526avijitgupta/orgs","repos_url":"https://api.github.com/users/526avijitgupta/repos","events_url":"https://api.github.com/users/526avijitgupta/events{/privacy}","received_events_url":"https://api.github.com/users/526avijitgupta/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T09:32:54Z","updated_at":"2016-09-09T09:32:54Z","body":"@seanlip Unfortunately no. I've had a look at the output of the failing tests a couple of times, but haven't been able to conclude anything fruitful yet. Currently, I have my exams going on and I plan to sit down and fix this just after the exams are over (which should be by 13th/14th Sept)."}}
{"actor":{"display_login":"526avijitgupta"}}