{"action":"created","comment":{"url":"https://api.github.com/repos/ancestorak/brief/pulls/comments/65109430","id":65109430,"diff_hunk":"@@ -1480,35 +1480,39 @@ function showElement(aElement, aAnimate) {\n }\n \n \n-this.__defineGetter__('Strings', () => {\n-    let cachedStringsList = [\n-        'entryDate.justNow',\n-        'minute.pluralForms',\n-        'hour.pluralForms',\n-        'entryDate.today',\n-        'entryDate.yesterday',\n-        'entryWasUpdated',\n-        'markEntryAsUnreadTooltip',\n-        'markEntryAsReadTooltip',\n-        'deleteEntryTooltip',\n-        'restoreEntryTooltip',\n-        'bookmarkEntryTooltip',\n-        'editBookmarkTooltip',\n-    ]\n-\n-    let bundle = getElement('main-bundle');\n-    let obj = {};\n-    for (let stringName of cachedStringsList)\n-        obj[stringName] = bundle.getString(stringName);\n-\n-    delete this.Strings;\n-    return this.Strings = obj;\n-})\n-\n-this.__defineGetter__('Finder', () => {\n-    let finder = Cc['@mozilla.org/embedcomp/rangefind;1'].createInstance(Ci.nsIFind);\n-    finder.caseSensitive = false;\n-\n-    delete this.Finder;\n-    return this.Finder = finder;\n-})\n+Object.defineProperty(this, 'Strings', {\n+    get: () => {\n+        let cachedStringsList = [\n+            'entryDate.justNow',\n+            'minute.pluralForms',\n+            'hour.pluralForms',\n+            'entryDate.today',\n+            'entryDate.yesterday',\n+            'entryWasUpdated',\n+            'markEntryAsUnreadTooltip',\n+            'markEntryAsReadTooltip',\n+            'deleteEntryTooltip',\n+            'restoreEntryTooltip',\n+            'bookmarkEntryTooltip',\n+            'editBookmarkTooltip',\n+        ]\n+\n+        let bundle = getElement('main-bundle');\n+        let obj = {};\n+        for (let stringName of cachedStringsList)\n+            obj[stringName] = bundle.getString(stringName);\n+\n+        delete this.Strings;\n+        return this.Strings = obj;\n+    }\n+});\n+\n+Object.defineProperty(this, 'Finder', {\n+    get: () => {\n+        let finder = Cc['@mozilla.org/embedcomp/rangefind;1'].createInstance(Ci.nsIFind);\n+        finder.caseSensitive = false;\n+\n+        delete this.Finder;\n+        return this.Finder = finder;\n+    }\n+});","path":"chrome/content/feedview.js","position":71,"original_position":71,"commit_id":"d79c078c24247a8a2861d5bcb0d86ac9d390cfec","original_commit_id":"d79c078c24247a8a2861d5bcb0d86ac9d390cfec","user":{"login":"simonlindholm","id":371089,"avatar_url":"https://avatars.githubusercontent.com/u/371089?v=3","gravatar_id":"","url":"https://api.github.com/users/simonlindholm","html_url":"https://github.com/simonlindholm","followers_url":"https://api.github.com/users/simonlindholm/followers","following_url":"https://api.github.com/users/simonlindholm/following{/other_user}","gists_url":"https://api.github.com/users/simonlindholm/gists{/gist_id}","starred_url":"https://api.github.com/users/simonlindholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonlindholm/subscriptions","organizations_url":"https://api.github.com/users/simonlindholm/orgs","repos_url":"https://api.github.com/users/simonlindholm/repos","events_url":"https://api.github.com/users/simonlindholm/events{/privacy}","received_events_url":"https://api.github.com/users/simonlindholm/received_events","type":"User","site_admin":false},"body":"These both need to be `configurable: true` for the `delete` to work.","created_at":"2016-05-30T22:50:00Z","updated_at":"2016-05-30T22:50:00Z","html_url":"https://github.com/ancestorak/brief/pull/191#discussion_r65109430","pull_request_url":"https://api.github.com/repos/ancestorak/brief/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/ancestorak/brief/pulls/comments/65109430"},"html":{"href":"https://github.com/ancestorak/brief/pull/191#discussion_r65109430"},"pull_request":{"href":"https://api.github.com/repos/ancestorak/brief/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/ancestorak/brief/pulls/191","id":69376730,"html_url":"https://github.com/ancestorak/brief/pull/191","diff_url":"https://github.com/ancestorak/brief/pull/191.diff","patch_url":"https://github.com/ancestorak/brief/pull/191.patch","issue_url":"https://api.github.com/repos/ancestorak/brief/issues/191","number":191,"state":"open","locked":false,"title":"Added future-safe getters","user":{"login":"vakata","id":146052,"avatar_url":"https://avatars.githubusercontent.com/u/146052?v=3","gravatar_id":"","url":"https://api.github.com/users/vakata","html_url":"https://github.com/vakata","followers_url":"https://api.github.com/users/vakata/followers","following_url":"https://api.github.com/users/vakata/following{/other_user}","gists_url":"https://api.github.com/users/vakata/gists{/gist_id}","starred_url":"https://api.github.com/users/vakata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakata/subscriptions","organizations_url":"https://api.github.com/users/vakata/orgs","repos_url":"https://api.github.com/users/vakata/repos","events_url":"https://api.github.com/users/vakata/events{/privacy}","received_events_url":"https://api.github.com/users/vakata/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-09T16:57:06Z","updated_at":"2016-05-30T22:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df03a8cfa5bad6e5470c86b235ce856b77d4eb20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ancestorak/brief/pulls/191/commits","review_comments_url":"https://api.github.com/repos/ancestorak/brief/pulls/191/comments","review_comment_url":"https://api.github.com/repos/ancestorak/brief/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ancestorak/brief/issues/191/comments","statuses_url":"https://api.github.com/repos/ancestorak/brief/statuses/d79c078c24247a8a2861d5bcb0d86ac9d390cfec","head":{"label":"vakata:patch-1","ref":"patch-1","sha":"d79c078c24247a8a2861d5bcb0d86ac9d390cfec","user":{"login":"vakata","id":146052,"avatar_url":"https://avatars.githubusercontent.com/u/146052?v=3","gravatar_id":"","url":"https://api.github.com/users/vakata","html_url":"https://github.com/vakata","followers_url":"https://api.github.com/users/vakata/followers","following_url":"https://api.github.com/users/vakata/following{/other_user}","gists_url":"https://api.github.com/users/vakata/gists{/gist_id}","starred_url":"https://api.github.com/users/vakata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakata/subscriptions","organizations_url":"https://api.github.com/users/vakata/orgs","repos_url":"https://api.github.com/users/vakata/repos","events_url":"https://api.github.com/users/vakata/events{/privacy}","received_events_url":"https://api.github.com/users/vakata/received_events","type":"User","site_admin":false},"repo":{"id":58393218,"name":"brief","full_name":"vakata/brief","owner":{"login":"vakata","id":146052,"avatar_url":"https://avatars.githubusercontent.com/u/146052?v=3","gravatar_id":"","url":"https://api.github.com/users/vakata","html_url":"https://github.com/vakata","followers_url":"https://api.github.com/users/vakata/followers","following_url":"https://api.github.com/users/vakata/following{/other_user}","gists_url":"https://api.github.com/users/vakata/gists{/gist_id}","starred_url":"https://api.github.com/users/vakata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakata/subscriptions","organizations_url":"https://api.github.com/users/vakata/orgs","repos_url":"https://api.github.com/users/vakata/repos","events_url":"https://api.github.com/users/vakata/events{/privacy}","received_events_url":"https://api.github.com/users/vakata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vakata/brief","description":"RSS reader extension for Firefox","fork":true,"url":"https://api.github.com/repos/vakata/brief","forks_url":"https://api.github.com/repos/vakata/brief/forks","keys_url":"https://api.github.com/repos/vakata/brief/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vakata/brief/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vakata/brief/teams","hooks_url":"https://api.github.com/repos/vakata/brief/hooks","issue_events_url":"https://api.github.com/repos/vakata/brief/issues/events{/number}","events_url":"https://api.github.com/repos/vakata/brief/events","assignees_url":"https://api.github.com/repos/vakata/brief/assignees{/user}","branches_url":"https://api.github.com/repos/vakata/brief/branches{/branch}","tags_url":"https://api.github.com/repos/vakata/brief/tags","blobs_url":"https://api.github.com/repos/vakata/brief/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vakata/brief/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vakata/brief/git/refs{/sha}","trees_url":"https://api.github.com/repos/vakata/brief/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vakata/brief/statuses/{sha}","languages_url":"https://api.github.com/repos/vakata/brief/languages","stargazers_url":"https://api.github.com/repos/vakata/brief/stargazers","contributors_url":"https://api.github.com/repos/vakata/brief/contributors","subscribers_url":"https://api.github.com/repos/vakata/brief/subscribers","subscription_url":"https://api.github.com/repos/vakata/brief/subscription","commits_url":"https://api.github.com/repos/vakata/brief/commits{/sha}","git_commits_url":"https://api.github.com/repos/vakata/brief/git/commits{/sha}","comments_url":"https://api.github.com/repos/vakata/brief/comments{/number}","issue_comment_url":"https://api.github.com/repos/vakata/brief/issues/comments{/number}","contents_url":"https://api.github.com/repos/vakata/brief/contents/{+path}","compare_url":"https://api.github.com/repos/vakata/brief/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vakata/brief/merges","archive_url":"https://api.github.com/repos/vakata/brief/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vakata/brief/downloads","issues_url":"https://api.github.com/repos/vakata/brief/issues{/number}","pulls_url":"https://api.github.com/repos/vakata/brief/pulls{/number}","milestones_url":"https://api.github.com/repos/vakata/brief/milestones{/number}","notifications_url":"https://api.github.com/repos/vakata/brief/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vakata/brief/labels{/name}","releases_url":"https://api.github.com/repos/vakata/brief/releases{/id}","deployments_url":"https://api.github.com/repos/vakata/brief/deployments","created_at":"2016-05-09T16:55:43Z","updated_at":"2016-05-09T16:55:44Z","pushed_at":"2016-05-09T16:56:43Z","git_url":"git://github.com/vakata/brief.git","ssh_url":"git@github.com:vakata/brief.git","clone_url":"https://github.com/vakata/brief.git","svn_url":"https://github.com/vakata/brief","homepage":null,"size":3473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ancestorak:master","ref":"master","sha":"c71ee4c4ed940044b15b2cdb2a793bccc7e49a0c","user":{"login":"ancestorak","id":4984599,"avatar_url":"https://avatars.githubusercontent.com/u/4984599?v=3","gravatar_id":"","url":"https://api.github.com/users/ancestorak","html_url":"https://github.com/ancestorak","followers_url":"https://api.github.com/users/ancestorak/followers","following_url":"https://api.github.com/users/ancestorak/following{/other_user}","gists_url":"https://api.github.com/users/ancestorak/gists{/gist_id}","starred_url":"https://api.github.com/users/ancestorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancestorak/subscriptions","organizations_url":"https://api.github.com/users/ancestorak/orgs","repos_url":"https://api.github.com/users/ancestorak/repos","events_url":"https://api.github.com/users/ancestorak/events{/privacy}","received_events_url":"https://api.github.com/users/ancestorak/received_events","type":"User","site_admin":false},"repo":{"id":11324859,"name":"brief","full_name":"ancestorak/brief","owner":{"login":"ancestorak","id":4984599,"avatar_url":"https://avatars.githubusercontent.com/u/4984599?v=3","gravatar_id":"","url":"https://api.github.com/users/ancestorak","html_url":"https://github.com/ancestorak","followers_url":"https://api.github.com/users/ancestorak/followers","following_url":"https://api.github.com/users/ancestorak/following{/other_user}","gists_url":"https://api.github.com/users/ancestorak/gists{/gist_id}","starred_url":"https://api.github.com/users/ancestorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancestorak/subscriptions","organizations_url":"https://api.github.com/users/ancestorak/orgs","repos_url":"https://api.github.com/users/ancestorak/repos","events_url":"https://api.github.com/users/ancestorak/events{/privacy}","received_events_url":"https://api.github.com/users/ancestorak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ancestorak/brief","description":"RSS reader extension for Firefox","fork":false,"url":"https://api.github.com/repos/ancestorak/brief","forks_url":"https://api.github.com/repos/ancestorak/brief/forks","keys_url":"https://api.github.com/repos/ancestorak/brief/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ancestorak/brief/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ancestorak/brief/teams","hooks_url":"https://api.github.com/repos/ancestorak/brief/hooks","issue_events_url":"https://api.github.com/repos/ancestorak/brief/issues/events{/number}","events_url":"https://api.github.com/repos/ancestorak/brief/events","assignees_url":"https://api.github.com/repos/ancestorak/brief/assignees{/user}","branches_url":"https://api.github.com/repos/ancestorak/brief/branches{/branch}","tags_url":"https://api.github.com/repos/ancestorak/brief/tags","blobs_url":"https://api.github.com/repos/ancestorak/brief/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ancestorak/brief/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ancestorak/brief/git/refs{/sha}","trees_url":"https://api.github.com/repos/ancestorak/brief/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ancestorak/brief/statuses/{sha}","languages_url":"https://api.github.com/repos/ancestorak/brief/languages","stargazers_url":"https://api.github.com/repos/ancestorak/brief/stargazers","contributors_url":"https://api.github.com/repos/ancestorak/brief/contributors","subscribers_url":"https://api.github.com/repos/ancestorak/brief/subscribers","subscription_url":"https://api.github.com/repos/ancestorak/brief/subscription","commits_url":"https://api.github.com/repos/ancestorak/brief/commits{/sha}","git_commits_url":"https://api.github.com/repos/ancestorak/brief/git/commits{/sha}","comments_url":"https://api.github.com/repos/ancestorak/brief/comments{/number}","issue_comment_url":"https://api.github.com/repos/ancestorak/brief/issues/comments{/number}","contents_url":"https://api.github.com/repos/ancestorak/brief/contents/{+path}","compare_url":"https://api.github.com/repos/ancestorak/brief/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ancestorak/brief/merges","archive_url":"https://api.github.com/repos/ancestorak/brief/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ancestorak/brief/downloads","issues_url":"https://api.github.com/repos/ancestorak/brief/issues{/number}","pulls_url":"https://api.github.com/repos/ancestorak/brief/pulls{/number}","milestones_url":"https://api.github.com/repos/ancestorak/brief/milestones{/number}","notifications_url":"https://api.github.com/repos/ancestorak/brief/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ancestorak/brief/labels{/name}","releases_url":"https://api.github.com/repos/ancestorak/brief/releases{/id}","deployments_url":"https://api.github.com/repos/ancestorak/brief/deployments","created_at":"2013-07-10T21:20:38Z","updated_at":"2016-05-20T03:40:41Z","pushed_at":"2016-05-09T16:57:07Z","git_url":"git://github.com/ancestorak/brief.git","ssh_url":"git@github.com:ancestorak/brief.git","clone_url":"https://github.com/ancestorak/brief.git","svn_url":"https://github.com/ancestorak/brief","homepage":null,"size":4216,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":65,"forks":23,"open_issues":65,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ancestorak/brief/pulls/191"},"html":{"href":"https://github.com/ancestorak/brief/pull/191"},"issue":{"href":"https://api.github.com/repos/ancestorak/brief/issues/191"},"comments":{"href":"https://api.github.com/repos/ancestorak/brief/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/ancestorak/brief/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/ancestorak/brief/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ancestorak/brief/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/ancestorak/brief/statuses/d79c078c24247a8a2861d5bcb0d86ac9d390cfec"}}}}
{"actor":{"display_login":"simonlindholm"}}