{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/74815530","id":74815530,"diff_hunk":"@@ -216,15 +216,15 @@ <h2 id=\"preview-title\">{% trans \"Wiki Revision Preview\" %}<span class=\"sr\">, {%\n         {% trans \"Back to history view\" %}\n       </a>\n       {% if article|can_write:user %}\n-        <a href=\"#\" class=\"btn btn-large btn-primary switch-to-revision\">\n+        <button type=\"button\" class=\"btn btn-large btn-primary switch-to-revision\">","path":"lms/templates/wiki/history.html","position":5,"original_position":5,"commit_id":"667730c7f72fb718422e9a483fa7ddbfa33899eb","original_commit_id":"486d014a8dd327f0870ed8deb0552d8bc9690b92","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"body":"Yes, this looks OK.","created_at":"2016-08-15T19:06:09Z","updated_at":"2016-08-15T19:06:09Z","html_url":"https://github.com/edx/edx-platform/pull/12993#discussion_r74815530","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/12993","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/74815530"},"html":{"href":"https://github.com/edx/edx-platform/pull/12993#discussion_r74815530"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12993"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12993","id":77341907,"html_url":"https://github.com/edx/edx-platform/pull/12993","diff_url":"https://github.com/edx/edx-platform/pull/12993.diff","patch_url":"https://github.com/edx/edx-platform/pull/12993.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12993","number":12993,"state":"open","locked":false,"title":"AC-530 fixing link-href ignores in the platform","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"body":"# AC-530\r\n\r\nThis fixes `link-href` ignored a11y checks in the platform, specifically the LMS. The remaining instances are:\r\n\r\n* discussion forums (because they're currently being worked on)\r\n* problem types (because they're currently being worked on)\r\n* still quite a bit of un-tested a href=\"#\" in Studio, but we'll do those later\r\n\r\n## Visual changes\r\n\r\nI changed the links on the Instructor Dashboard to buttons. The styling changed, but we are wanting to move away from ALL CAPS anyway, so I think it works.\r\n\r\n<img width=\"1002\" alt=\"screen shot 2016-08-02 at 8 55 05 am\" src=\"https://cloud.githubusercontent.com/assets/2112024/17329073/eb642700-588e-11e6-8994-d6cf4fbc7d87.png\">\r\n_before_\r\n\r\n<img width=\"808\" alt=\"screen shot 2016-08-02 at 8 54 13 am\" src=\"https://cloud.githubusercontent.com/assets/2112024/17329077/f27edaf8-588e-11e6-822d-b40750a0a8ef.png\">\r\n_after_\r\n\r\nOther changes I tried to keep the same, requiring some updates to various Sass partials.\r\n\r\n## Accessibility tests\r\n\r\nI added accessibility checks were applicable. The staff view test had 27 errors, but since that's technically out of scope for this deadline, I created a ticket (AC-559) and ignored those checks for now.\r\n\r\n## Safe template failures\r\n\r\nThere were 137 various safe template failures here. I started fixing them, but more things broke in the process. Since this ticket is long overdue and Quality tests are passing, I'm going to skip those for now. A TNL ticket has been created to revisit them later. More information in [TNL-5259](https://openedx.atlassian.net/browse/TNL-5259).\r\n\r\n## Sandbox\r\n\r\nhttps://clrux-ac-530.sandbox.edx.org\r\n\r\n## Tickets as a result of this work\r\n\r\n* https://openedx.atlassian.net/browse/AC-560\r\n\r\n## Reviewers\r\n\r\n- [ ] @cptvitamin (Accessibility, overall)\r\n- [ ] @cahrens (T&L, overall)\r\n- [x] @saleem-latif (Marketing footer links specifically)\r\n\r\n## Documentation updates\r\n\r\nLinks that were previously empty (`href=\"#\"`) are now buttons. @lamagnifica #","created_at":"2016-07-13T18:53:41Z","updated_at":"2016-08-15T19:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37357161da0ce86d7f403a8480e1832477994230","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/12993/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/12993/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12993/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/667730c7f72fb718422e9a483fa7ddbfa33899eb","head":{"label":"edx:clrux/ac-530","ref":"clrux/ac-530","sha":"667730c7f72fb718422e9a483fa7ddbfa33899eb","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-08-15T10:25:23Z","pushed_at":"2016-08-15T18:38:42Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":807395,"stargazers_count":2723,"watchers_count":2723,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1640,"mirror_url":null,"open_issues_count":134,"forks":1640,"open_issues":134,"watchers":2723,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"28922ca6880f19e8b75b5e381b3fff84e29a4441","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-08-15T10:25:23Z","pushed_at":"2016-08-15T18:38:42Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":807395,"stargazers_count":2723,"watchers_count":2723,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1640,"mirror_url":null,"open_issues_count":134,"forks":1640,"open_issues":134,"watchers":2723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12993"},"html":{"href":"https://github.com/edx/edx-platform/pull/12993"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12993"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12993/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12993/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12993/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/667730c7f72fb718422e9a483fa7ddbfa33899eb"}}}}
{"actor":{"display_login":"clrux"}}