{"action":"created","comment":{"url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/comments/73052654","id":73052654,"diff_hunk":"@@ -28,10 +28,8 @@ class AssociationsControllerAssociation extends JControllerForm\n \tpublic function cancel($key = null)\n \t{\n \t\tJSession::checkToken() or jexit(JText::_('JINVALID_TOKEN'));\n-\n-\t\t$extension = $this->input->get('extension', '', 'string');\n-\n-\t\t$key = $extension !== '' ? 'com_categories.category|' . $extension : $this->input->get('acomponent', '') . '.' . $this->input->get('aview', '');\n+\t\t\n+\t\t$key = $this->input->get('component', '', 'string');\n \t\t$cp  = AssociationsHelper::getComponentProperties($key);","path":"administrator/components/com_associations/controllers/association.php","position":10,"original_position":10,"commit_id":"6437fd2446f0caecf708eeb8d811358b643a7bad","original_commit_id":"6437fd2446f0caecf708eeb8d811358b643a7bad","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"body":"just\r\n$cp  = AssociationsHelper::getComponentProperties($this->input->get('component', '', 'string'));","created_at":"2016-08-01T21:04:14Z","updated_at":"2016-08-01T21:04:14Z","html_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual/pull/37#discussion_r73052654","pull_request_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/comments/73052654"},"html":{"href":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual/pull/37#discussion_r73052654"},"pull_request":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37","id":79325425,"html_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual/pull/37","diff_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual/pull/37.diff","patch_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual/pull/37.patch","issue_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/issues/37","number":37,"state":"open","locked":false,"title":"ACL for list and side by side views","user":{"login":"jreys","id":16468676,"avatar_url":"https://avatars.githubusercontent.com/u/16468676?v=3","gravatar_id":"","url":"https://api.github.com/users/jreys","html_url":"https://github.com/jreys","followers_url":"https://api.github.com/users/jreys/followers","following_url":"https://api.github.com/users/jreys/following{/other_user}","gists_url":"https://api.github.com/users/jreys/gists{/gist_id}","starred_url":"https://api.github.com/users/jreys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreys/subscriptions","organizations_url":"https://api.github.com/users/jreys/orgs","repos_url":"https://api.github.com/users/jreys/repos","events_url":"https://api.github.com/users/jreys/events{/privacy}","received_events_url":"https://api.github.com/users/jreys/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #7.\r\n\r\n#### Summary of Changes\r\n\r\nAdding ACL in com_associations\r\n\r\n#### Notes\r\n\r\n- When a user accesses a forbidden item, it should be redirected back to the list view with a notice/error, I'm aware of that\r\n- Reference is not yet implemented, I'm thinking in using JS to hide the button in case the user is not authorised, it won't compromise security since the save action is triggered by the iframe.","created_at":"2016-07-29T08:42:02Z","updated_at":"2016-08-01T21:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d64287c72f5a509623107cf97be0d25fa155a7b3","assignee":{"login":"jreys","id":16468676,"avatar_url":"https://avatars.githubusercontent.com/u/16468676?v=3","gravatar_id":"","url":"https://api.github.com/users/jreys","html_url":"https://github.com/jreys","followers_url":"https://api.github.com/users/jreys/followers","following_url":"https://api.github.com/users/jreys/following{/other_user}","gists_url":"https://api.github.com/users/jreys/gists{/gist_id}","starred_url":"https://api.github.com/users/jreys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreys/subscriptions","organizations_url":"https://api.github.com/users/jreys/orgs","repos_url":"https://api.github.com/users/jreys/repos","events_url":"https://api.github.com/users/jreys/events{/privacy}","received_events_url":"https://api.github.com/users/jreys/received_events","type":"User","site_admin":false},"assignees":[{"login":"jreys","id":16468676,"avatar_url":"https://avatars.githubusercontent.com/u/16468676?v=3","gravatar_id":"","url":"https://api.github.com/users/jreys","html_url":"https://github.com/jreys","followers_url":"https://api.github.com/users/jreys/followers","following_url":"https://api.github.com/users/jreys/following{/other_user}","gists_url":"https://api.github.com/users/jreys/gists{/gist_id}","starred_url":"https://api.github.com/users/jreys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreys/subscriptions","organizations_url":"https://api.github.com/users/jreys/orgs","repos_url":"https://api.github.com/users/jreys/repos","events_url":"https://api.github.com/users/jreys/events{/privacy}","received_events_url":"https://api.github.com/users/jreys/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/milestones/11","html_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual/milestones/10th%20week%20CP%20(up%20to%2031%20July)","labels_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/milestones/11/labels","id":1813292,"number":11,"title":"10th week CP (up to 31 July)","description":"","creator":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":20,"state":"open","created_at":"2016-06-07T12:27:25Z","updated_at":"2016-07-31T13:24:53Z","due_on":"2016-07-30T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37/commits","review_comments_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37/comments","review_comment_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/issues/37/comments","statuses_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/statuses/6437fd2446f0caecf708eeb8d811358b643a7bad","head":{"label":"jreys:acl","ref":"acl","sha":"6437fd2446f0caecf708eeb8d811358b643a7bad","user":{"login":"jreys","id":16468676,"avatar_url":"https://avatars.githubusercontent.com/u/16468676?v=3","gravatar_id":"","url":"https://api.github.com/users/jreys","html_url":"https://github.com/jreys","followers_url":"https://api.github.com/users/jreys/followers","following_url":"https://api.github.com/users/jreys/following{/other_user}","gists_url":"https://api.github.com/users/jreys/gists{/gist_id}","starred_url":"https://api.github.com/users/jreys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreys/subscriptions","organizations_url":"https://api.github.com/users/jreys/orgs","repos_url":"https://api.github.com/users/jreys/repos","events_url":"https://api.github.com/users/jreys/events{/privacy}","received_events_url":"https://api.github.com/users/jreys/received_events","type":"User","site_admin":false},"repo":{"id":59004477,"name":"gsoc16_improved-multi-lingual","full_name":"jreys/gsoc16_improved-multi-lingual","owner":{"login":"jreys","id":16468676,"avatar_url":"https://avatars.githubusercontent.com/u/16468676?v=3","gravatar_id":"","url":"https://api.github.com/users/jreys","html_url":"https://github.com/jreys","followers_url":"https://api.github.com/users/jreys/followers","following_url":"https://api.github.com/users/jreys/following{/other_user}","gists_url":"https://api.github.com/users/jreys/gists{/gist_id}","starred_url":"https://api.github.com/users/jreys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreys/subscriptions","organizations_url":"https://api.github.com/users/jreys/orgs","repos_url":"https://api.github.com/users/jreys/repos","events_url":"https://api.github.com/users/jreys/events{/privacy}","received_events_url":"https://api.github.com/users/jreys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jreys/gsoc16_improved-multi-lingual","description":"Improved multi-lingual content management‏","fork":true,"url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual","forks_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/forks","keys_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/teams","hooks_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/hooks","issue_events_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/issues/events{/number}","events_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/events","assignees_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/assignees{/user}","branches_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/branches{/branch}","tags_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/tags","blobs_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/git/refs{/sha}","trees_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/statuses/{sha}","languages_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/languages","stargazers_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/stargazers","contributors_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/contributors","subscribers_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/subscribers","subscription_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/subscription","commits_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/commits{/sha}","git_commits_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/git/commits{/sha}","comments_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/comments{/number}","issue_comment_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/issues/comments{/number}","contents_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/contents/{+path}","compare_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/merges","archive_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/downloads","issues_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/issues{/number}","pulls_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/pulls{/number}","milestones_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/milestones{/number}","notifications_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/labels{/name}","releases_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/releases{/id}","deployments_url":"https://api.github.com/repos/jreys/gsoc16_improved-multi-lingual/deployments","created_at":"2016-05-17T08:28:44Z","updated_at":"2016-05-17T08:29:16Z","pushed_at":"2016-08-01T21:01:37Z","git_url":"git://github.com/jreys/gsoc16_improved-multi-lingual.git","ssh_url":"git@github.com:jreys/gsoc16_improved-multi-lingual.git","clone_url":"https://github.com/jreys/gsoc16_improved-multi-lingual.git","svn_url":"https://github.com/jreys/gsoc16_improved-multi-lingual","homepage":" https://summerofcode.withgoogle.com/projects/#5929290470260736","size":131905,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla-projects:staging","ref":"staging","sha":"0cd8aaf03a7829ffc6742956df7feef5abed5f78","user":{"login":"joomla-projects","id":4417437,"avatar_url":"https://avatars.githubusercontent.com/u/4417437?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":57291148,"name":"gsoc16_improved-multi-lingual","full_name":"joomla-projects/gsoc16_improved-multi-lingual","owner":{"login":"joomla-projects","id":4417437,"avatar_url":"https://avatars.githubusercontent.com/u/4417437?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual","description":"Improved multi-lingual content management‏","fork":false,"url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual","forks_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/forks","keys_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/teams","hooks_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/hooks","issue_events_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/issues/events{/number}","events_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/events","assignees_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/assignees{/user}","branches_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/branches{/branch}","tags_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/tags","blobs_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/languages","stargazers_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/stargazers","contributors_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/contributors","subscribers_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/subscribers","subscription_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/subscription","commits_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/contents/{+path}","compare_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/merges","archive_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/downloads","issues_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/issues{/number}","pulls_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/labels{/name}","releases_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/releases{/id}","deployments_url":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/deployments","created_at":"2016-04-28T10:01:57Z","updated_at":"2016-04-30T14:30:55Z","pushed_at":"2016-08-01T21:01:38Z","git_url":"git://github.com/joomla-projects/gsoc16_improved-multi-lingual.git","ssh_url":"git@github.com:joomla-projects/gsoc16_improved-multi-lingual.git","clone_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual.git","svn_url":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual","homepage":" https://summerofcode.withgoogle.com/projects/#5929290470260736","size":132047,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":0,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37"},"html":{"href":"https://github.com/joomla-projects/gsoc16_improved-multi-lingual/pull/37"},"issue":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/issues/37"},"comments":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/joomla-projects/gsoc16_improved-multi-lingual/statuses/6437fd2446f0caecf708eeb8d811358b643a7bad"}}}}
{"actor":{"display_login":"andrepereiradasilva"}}