{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack/pulls/comments/90403685","pull_request_review_id":10920679,"id":90403685,"diff_hunk":"@@ -460,20 +471,29 @@ Stats.jsonToString = function jsonToString(obj, useColors) {\n \t\tcolors.bold(obj.publicPath);\n \t\tnewline();\n \t}\n+\n \tif(obj.assets && obj.assets.length > 0) {\n \t\tvar t = [\n-\t\t\t[\"Asset\", \"Size\", \"Chunks\", \"\", \"Chunk Names\"]\n+\t\t\t[\n+\t\t\t\t{value: \"Asset\", color: colors.bold},\n+\t\t\t\t{value: \"Size\", color: colors.bold},\n+\t\t\t\t{value: \"Chunks\", color: colors.bold},\n+\t\t\t\t{value: \"\", color: colors.bold},\n+\t\t\t\t{value: \"\", color: colors.bold},","path":"lib/Stats.js","position":102,"original_position":102,"commit_id":"f360e1ebaec4cb7f0665bf627cfec69679a06bd3","original_commit_id":"f360e1ebaec4cb7f0665bf627cfec69679a06bd3","user":{"login":"sokra","id":1365881,"avatar_url":"https://avatars.githubusercontent.com/u/1365881?v=3","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"body":":+1: but sadly this changes the stats output in a weirds way:\r\n\r\n``` diff\r\n     Hash: 8bac53cc0c37d71baf6b\r\n       Time: Xms\r\n      -    Asset     Size  Chunks                  Chunk Names\r\n      -bundle.js  7.22 kB       0  [emitted]       main\r\n      +    Asset     Size  Chunks             Chunk Names\r\n      +bundle.js  7.22 kB       0  [emitted]  main\r\n```\r\n\r\nCould you make sure that empty columns doesn't need size? A simple check of `colSizes[col] !== 0` in `table` above would do that.","created_at":"2016-12-01T08:48:29Z","updated_at":"2016-12-01T09:00:40Z","html_url":"https://github.com/webpack/webpack/pull/3350#discussion_r90403685","pull_request_url":"https://api.github.com/repos/webpack/webpack/pulls/3350","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments/90403685"},"html":{"href":"https://github.com/webpack/webpack/pull/3350#discussion_r90403685"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack/pulls/3350"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/3350","id":94874802,"html_url":"https://github.com/webpack/webpack/pull/3350","diff_url":"https://github.com/webpack/webpack/pull/3350.diff","patch_url":"https://github.com/webpack/webpack/pull/3350.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/3350","number":3350,"state":"open","locked":false,"title":"feat(performance): webpack performance budgets ","user":{"login":"TheLarkInn","id":3408176,"avatar_url":"https://avatars.githubusercontent.com/u/3408176?v=3","gravatar_id":"","url":"https://api.github.com/users/TheLarkInn","html_url":"https://github.com/TheLarkInn","followers_url":"https://api.github.com/users/TheLarkInn/followers","following_url":"https://api.github.com/users/TheLarkInn/following{/other_user}","gists_url":"https://api.github.com/users/TheLarkInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLarkInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLarkInn/subscriptions","organizations_url":"https://api.github.com/users/TheLarkInn/orgs","repos_url":"https://api.github.com/users/TheLarkInn/repos","events_url":"https://api.github.com/users/TheLarkInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheLarkInn/received_events","type":"User","site_admin":false},"body":"**What kind of change does this PR introduce?**\r\nA feature\r\n\r\n**Did you add tests for your changes?**\r\nYes \r\n\r\n**If relevant, did you update the documentation?**\r\nNot yet\r\n\r\n**Summary**\r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n<!-- Try to link to an open issue for more information. -->\r\n\r\n**Does this PR introduce a breaking change?**\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\nIt doesn't introduce a breaking change. \r\n\r\n**Other information**\r\nPerformance budgets PR here is implementation of @addyosmani's RFC #3216 \r\n\r\nHere are the schema properties with descriptors:\r\n\r\n```json\r\n    \"performance\": {\r\n      \"description\": \"Configuration for web performance recommendations.\",\r\n      \"additionalProperties\": false,\r\n      \"properties\": {\r\n        \"hints\": {\r\n          \"description\": \"Turn hints on or off\",\r\n          \"type\": \"boolean\"\r\n        },\r\n        \"maxInitialChunkSize\": {\r\n          \"description\": \"Total size of all initial chunks (in bytes)\",\r\n          \"type\": \"number\"\r\n        },\r\n        \"maxAssetSize\": {\r\n          \"description\": \"Filesize limit (in bytes) when exceeded, that webpack will provide performance hints\",\r\n          \"type\": \"number\"\r\n        },\r\n        \"errorOnHint\": {\r\n          \"description\": \"Throw errors instead of warnings when performance hints are found\",\r\n          \"type\": \"boolean\"\r\n        }\r\n      },\r\n      \"type\": \"object\"\r\n    }\r\n```\r\n","created_at":"2016-11-22T18:49:20Z","updated_at":"2016-12-01T09:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50378d57c96fbc6822be6c2cd8157a11ad8defea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/3350/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/3350/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/3350/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/f360e1ebaec4cb7f0665bf627cfec69679a06bd3","head":{"label":"webpack:feature/custom_stats","ref":"feature/custom_stats","sha":"f360e1ebaec4cb7f0665bf627cfec69679a06bd3","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2016-12-01T08:59:17Z","pushed_at":"2016-12-01T08:50:01Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.github.io","size":7264,"stargazers_count":21336,"watchers_count":21336,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2328,"mirror_url":null,"open_issues_count":696,"forks":2328,"open_issues":696,"watchers":21336,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"f4adee3e9d7f6025356a90c6a71cb7c14c5c22c4","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2016-12-01T08:59:17Z","pushed_at":"2016-12-01T08:50:01Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.github.io","size":7264,"stargazers_count":21336,"watchers_count":21336,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2328,"mirror_url":null,"open_issues_count":696,"forks":2328,"open_issues":696,"watchers":21336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/3350"},"html":{"href":"https://github.com/webpack/webpack/pull/3350"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/3350"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/3350/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/3350/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/3350/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/f360e1ebaec4cb7f0665bf627cfec69679a06bd3"}}}}
{"actor":{"display_login":"sokra"}}