{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7494","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7494/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7494/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7494/events","html_url":"https://github.com/nodejs/node/pull/7494","id":163102014,"number":7494,"title":"Fix various overflows and UB in src/","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-30T07:46:53Z","updated_at":"2016-06-30T07:47:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7494","html_url":"https://github.com/nodejs/node/pull/7494","diff_url":"https://github.com/nodejs/node/pull/7494.diff","patch_url":"https://github.com/nodejs/node/pull/7494.patch"},"body":"##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nsrc\r\n\r\n##### Description of change\r\n\r\nFix various overflows and UB in src/\r\n\r\nR= @bnoordhuis and/or @nodejs/collaborators \r\n\r\n\r\n---\r\n\r\nNOTE: This doesn't fix:\r\n\r\n```\r\n../src/string_search.h:231:68: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long')\r\nSUMMARY: AddressSanitizer: undefined-behavior ../src/string_search.h:231:68 in\r\n../src/string_search.h:186:34: runtime error: index 18446744073709451866 out of bounds for type 'int [251]'\r\nSUMMARY: AddressSanitizer: undefined-behavior ../src/string_search.h:186:34 in\r\n../src/string_search.h:194:25: runtime error: index 18446744073709451866 out of bounds for type 'int [251]'\r\nSUMMARY: AddressSanitizer: undefined-behavior ../src/string_search.h:194:25 in\r\n```\r\n\r\nI'm open to suggestions how it could be approached, though."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/229585687","html_url":"https://github.com/nodejs/node/pull/7494#issuecomment-229585687","issue_url":"https://api.github.com/repos/nodejs/node/issues/7494","id":229585687,"user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T07:47:11Z","updated_at":"2016-06-30T07:47:11Z","body":"Discovered with:\r\n\r\n`-fsanitize=undefined,address,signed-integer-overflow,unsigned-integer-overflow,integer`"}}
{"actor":{"display_login":"indutny"}}