{"action":"created","comment":{"url":"https://api.github.com/repos/indico/indico/pulls/comments/66985150","id":66985150,"diff_hunk":"@@ -865,3 +868,33 @@ def render_protection_message(self):\n \n class IndicoTagListField(HiddenFieldList):\n     widget = JinjaWidget('forms/tag_list_widget.html', single_kwargs=True)\n+\n+\n+class IndicoMarkdownField(TextAreaField):\n+    widget = JinjaWidget('forms/markdown_widget.html', single_kwargs=True, rows=15)\n+\n+\n+class IndicoTimezoneSelectField(SelectField):\n+    def __init__(self, *args, **kwargs):\n+        super(IndicoTimezoneSelectField, self).__init__(*args, **kwargs)\n+        config = Config.getInstance()\n+        self.choices = [(v, v) for v in pytz.common_timezones]\n+        self.default = config.getDefaultTimezone()\n+\n+    def process_data(self, value):\n+        try:","path":"indico/web/forms/fields.py","position":48,"original_position":48,"commit_id":"17901e17596151cb7c415800fb362c7a42945540","original_commit_id":"17901e17596151cb7c415800fb362c7a42945540","user":{"login":"ThiefMaster","id":179599,"avatar_url":"https://avatars.githubusercontent.com/u/179599?v=3","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"body":"why not call `super()`?\r\n\r\n    def process_data(self, value):\r\n        try:\r\n            self.data = self.coerce(value)\r\n        except (ValueError, TypeError):\r\n            self.data = None\r\n\r\n(from SelectField - exactly what you have here)","created_at":"2016-06-14T14:47:24Z","updated_at":"2016-06-14T14:47:24Z","html_url":"https://github.com/indico/indico/pull/2467#discussion_r66985150","pull_request_url":"https://api.github.com/repos/indico/indico/pulls/2467","_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/comments/66985150"},"html":{"href":"https://github.com/indico/indico/pull/2467#discussion_r66985150"},"pull_request":{"href":"https://api.github.com/repos/indico/indico/pulls/2467"}}},"pull_request":{"url":"https://api.github.com/repos/indico/indico/pulls/2467","id":73726109,"html_url":"https://github.com/indico/indico/pull/2467","diff_url":"https://github.com/indico/indico/pull/2467.diff","patch_url":"https://github.com/indico/indico/pull/2467.patch","issue_url":"https://api.github.com/repos/indico/indico/issues/2467","number":2467,"state":"open","locked":false,"title":"Basic category settings page","user":{"login":"pferreir","id":2699,"avatar_url":"https://avatars.githubusercontent.com/u/2699?v=3","gravatar_id":"","url":"https://api.github.com/users/pferreir","html_url":"https://github.com/pferreir","followers_url":"https://api.github.com/users/pferreir/followers","following_url":"https://api.github.com/users/pferreir/following{/other_user}","gists_url":"https://api.github.com/users/pferreir/gists{/gist_id}","starred_url":"https://api.github.com/users/pferreir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pferreir/subscriptions","organizations_url":"https://api.github.com/users/pferreir/orgs","repos_url":"https://api.github.com/users/pferreir/repos","events_url":"https://api.github.com/users/pferreir/events{/privacy}","received_events_url":"https://api.github.com/users/pferreir/received_events","type":"User","site_admin":false},"body":"Things missing:\r\n * [ ] Warning if categories above are more visibility-restrictive than current one.","created_at":"2016-06-14T11:53:37Z","updated_at":"2016-06-14T14:47:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95f3cd978f63f0ef09e40f9bf9ca319fa4179312","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/indico/indico/pulls/2467/commits","review_comments_url":"https://api.github.com/repos/indico/indico/pulls/2467/comments","review_comment_url":"https://api.github.com/repos/indico/indico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indico/indico/issues/2467/comments","statuses_url":"https://api.github.com/repos/indico/indico/statuses/17901e17596151cb7c415800fb362c7a42945540","head":{"label":"pferreir:wip/categ-settings","ref":"wip/categ-settings","sha":"17901e17596151cb7c415800fb362c7a42945540","user":{"login":"pferreir","id":2699,"avatar_url":"https://avatars.githubusercontent.com/u/2699?v=3","gravatar_id":"","url":"https://api.github.com/users/pferreir","html_url":"https://github.com/pferreir","followers_url":"https://api.github.com/users/pferreir/followers","following_url":"https://api.github.com/users/pferreir/following{/other_user}","gists_url":"https://api.github.com/users/pferreir/gists{/gist_id}","starred_url":"https://api.github.com/users/pferreir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pferreir/subscriptions","organizations_url":"https://api.github.com/users/pferreir/orgs","repos_url":"https://api.github.com/users/pferreir/repos","events_url":"https://api.github.com/users/pferreir/events{/privacy}","received_events_url":"https://api.github.com/users/pferreir/received_events","type":"User","site_admin":false},"repo":{"id":3867135,"name":"indico","full_name":"pferreir/indico","owner":{"login":"pferreir","id":2699,"avatar_url":"https://avatars.githubusercontent.com/u/2699?v=3","gravatar_id":"","url":"https://api.github.com/users/pferreir","html_url":"https://github.com/pferreir","followers_url":"https://api.github.com/users/pferreir/followers","following_url":"https://api.github.com/users/pferreir/following{/other_user}","gists_url":"https://api.github.com/users/pferreir/gists{/gist_id}","starred_url":"https://api.github.com/users/pferreir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pferreir/subscriptions","organizations_url":"https://api.github.com/users/pferreir/orgs","repos_url":"https://api.github.com/users/pferreir/repos","events_url":"https://api.github.com/users/pferreir/events{/privacy}","received_events_url":"https://api.github.com/users/pferreir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pferreir/indico","description":"The Indico Project (mirror)","fork":true,"url":"https://api.github.com/repos/pferreir/indico","forks_url":"https://api.github.com/repos/pferreir/indico/forks","keys_url":"https://api.github.com/repos/pferreir/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pferreir/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pferreir/indico/teams","hooks_url":"https://api.github.com/repos/pferreir/indico/hooks","issue_events_url":"https://api.github.com/repos/pferreir/indico/issues/events{/number}","events_url":"https://api.github.com/repos/pferreir/indico/events","assignees_url":"https://api.github.com/repos/pferreir/indico/assignees{/user}","branches_url":"https://api.github.com/repos/pferreir/indico/branches{/branch}","tags_url":"https://api.github.com/repos/pferreir/indico/tags","blobs_url":"https://api.github.com/repos/pferreir/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pferreir/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pferreir/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/pferreir/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pferreir/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/pferreir/indico/languages","stargazers_url":"https://api.github.com/repos/pferreir/indico/stargazers","contributors_url":"https://api.github.com/repos/pferreir/indico/contributors","subscribers_url":"https://api.github.com/repos/pferreir/indico/subscribers","subscription_url":"https://api.github.com/repos/pferreir/indico/subscription","commits_url":"https://api.github.com/repos/pferreir/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/pferreir/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/pferreir/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/pferreir/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/pferreir/indico/contents/{+path}","compare_url":"https://api.github.com/repos/pferreir/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pferreir/indico/merges","archive_url":"https://api.github.com/repos/pferreir/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pferreir/indico/downloads","issues_url":"https://api.github.com/repos/pferreir/indico/issues{/number}","pulls_url":"https://api.github.com/repos/pferreir/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/pferreir/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/pferreir/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pferreir/indico/labels{/name}","releases_url":"https://api.github.com/repos/pferreir/indico/releases{/id}","deployments_url":"https://api.github.com/repos/pferreir/indico/deployments","created_at":"2012-03-29T15:01:36Z","updated_at":"2015-05-04T14:44:08Z","pushed_at":"2016-06-14T11:51:30Z","git_url":"git://github.com/pferreir/indico.git","ssh_url":"git@github.com:pferreir/indico.git","clone_url":"https://github.com/pferreir/indico.git","svn_url":"https://github.com/pferreir/indico","homepage":"http://indico-software.org","size":191266,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"indico:devel","ref":"devel","sha":"b654185bda85f5ac1496903912920828523e0941","user":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"repo":{"id":2113067,"name":"indico","full_name":"indico/indico","owner":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indico/indico","description":"The Indico Project","fork":false,"url":"https://api.github.com/repos/indico/indico","forks_url":"https://api.github.com/repos/indico/indico/forks","keys_url":"https://api.github.com/repos/indico/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indico/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indico/indico/teams","hooks_url":"https://api.github.com/repos/indico/indico/hooks","issue_events_url":"https://api.github.com/repos/indico/indico/issues/events{/number}","events_url":"https://api.github.com/repos/indico/indico/events","assignees_url":"https://api.github.com/repos/indico/indico/assignees{/user}","branches_url":"https://api.github.com/repos/indico/indico/branches{/branch}","tags_url":"https://api.github.com/repos/indico/indico/tags","blobs_url":"https://api.github.com/repos/indico/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indico/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indico/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/indico/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indico/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/indico/indico/languages","stargazers_url":"https://api.github.com/repos/indico/indico/stargazers","contributors_url":"https://api.github.com/repos/indico/indico/contributors","subscribers_url":"https://api.github.com/repos/indico/indico/subscribers","subscription_url":"https://api.github.com/repos/indico/indico/subscription","commits_url":"https://api.github.com/repos/indico/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/indico/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/indico/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/indico/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/indico/indico/contents/{+path}","compare_url":"https://api.github.com/repos/indico/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indico/indico/merges","archive_url":"https://api.github.com/repos/indico/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indico/indico/downloads","issues_url":"https://api.github.com/repos/indico/indico/issues{/number}","pulls_url":"https://api.github.com/repos/indico/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/indico/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/indico/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indico/indico/labels{/name}","releases_url":"https://api.github.com/repos/indico/indico/releases{/id}","deployments_url":"https://api.github.com/repos/indico/indico/deployments","created_at":"2011-07-27T13:56:30Z","updated_at":"2016-06-11T13:56:56Z","pushed_at":"2016-06-14T14:34:34Z","git_url":"git://github.com/indico/indico.git","ssh_url":"git@github.com:indico/indico.git","clone_url":"https://github.com/indico/indico.git","svn_url":"https://github.com/indico/indico","homepage":"http://indico-software.org","size":199543,"stargazers_count":144,"watchers_count":144,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":623,"forks":72,"open_issues":623,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/2467"},"html":{"href":"https://github.com/indico/indico/pull/2467"},"issue":{"href":"https://api.github.com/repos/indico/indico/issues/2467"},"comments":{"href":"https://api.github.com/repos/indico/indico/issues/2467/comments"},"review_comments":{"href":"https://api.github.com/repos/indico/indico/pulls/2467/comments"},"review_comment":{"href":"https://api.github.com/repos/indico/indico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indico/indico/pulls/2467/commits"},"statuses":{"href":"https://api.github.com/repos/indico/indico/statuses/17901e17596151cb7c415800fb362c7a42945540"}}}}
{"actor":{"display_login":"ThiefMaster"}}