{"action":"created","comment":{"url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments/83641105","pull_request_review_id":4470784,"id":83641105,"diff_hunk":"@@ -286,25 +286,7 @@ class Engine {\n           result.statistics = statistics.summarizeDeep(options);\n         }\n       }).tap((result) => {\n-        // don't bother if no statistics or silent x2\n-        if (!result.statistics || !result.statistics.timings || !result.statistics.timings.pageTimings || options.silent > 1) return result;\n-\n-        let run = result.browserScripts[0].timings,\n-          nRuns = result.browserScripts.length,\n-          pt = result.statistics.timings.pageTimings,\n-          t = result.statistics.timings,\n-          m = nRuns > 1,\n-          lines = [\n-            `${run.resourceTimings.length + 1} requests`,\n-            util.formatMetric('firstPaint', t.firstPaint, m),\n-            util.formatMetric('DOMContentLoaded', pt.domContentLoadedTime, m),\n-            util.formatMetric('Load', pt.pageLoadTime, m),\n-            util.formatMetric('rumSpeedIndex', t.rumSpeedIndex, m),\n-          ],\n-          note = m ? ` (${nRuns} runs)` : '';\n-\n-        lines = lines.filter(Boolean).join(', ');\n-        log.info(`${lines}${note}`);\n+        log.info(util.getResultLogLine(result,options));","path":"lib/core/engine.js","position":23,"original_position":23,"commit_id":"edd5fad553bf3d29238306e67e113a7221880f66","original_commit_id":"edd5fad553bf3d29238306e67e113a7221880f66","user":{"login":"tobli","id":540266,"avatar_url":"https://avatars.githubusercontent.com/u/540266?v=3","gravatar_id":"","url":"https://api.github.com/users/tobli","html_url":"https://github.com/tobli","followers_url":"https://api.github.com/users/tobli/followers","following_url":"https://api.github.com/users/tobli/following{/other_user}","gists_url":"https://api.github.com/users/tobli/gists{/gist_id}","starred_url":"https://api.github.com/users/tobli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobli/subscriptions","organizations_url":"https://api.github.com/users/tobli/orgs","repos_url":"https://api.github.com/users/tobli/repos","events_url":"https://api.github.com/users/tobli/events{/privacy}","received_events_url":"https://api.github.com/users/tobli/received_events","type":"User","site_admin":false},"body":"I think the options.silent check belongs here, it's the callers responsibility. Additionally a check for an empty result, to avoid logging undefined/an empty row.","created_at":"2016-10-17T13:24:00Z","updated_at":"2016-10-17T13:32:34Z","html_url":"https://github.com/sitespeedio/browsertime/pull/197#discussion_r83641105","pull_request_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments/83641105"},"html":{"href":"https://github.com/sitespeedio/browsertime/pull/197#discussion_r83641105"},"pull_request":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197","id":89617299,"html_url":"https://github.com/sitespeedio/browsertime/pull/197","diff_url":"https://github.com/sitespeedio/browsertime/pull/197.diff","patch_url":"https://github.com/sitespeedio/browsertime/pull/197.patch","issue_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/197","number":197,"state":"open","locked":false,"title":"Log the total size of the page using the HAR","user":{"login":"soulgalore","id":540757,"avatar_url":"https://avatars.githubusercontent.com/u/540757?v=3","gravatar_id":"","url":"https://api.github.com/users/soulgalore","html_url":"https://github.com/soulgalore","followers_url":"https://api.github.com/users/soulgalore/followers","following_url":"https://api.github.com/users/soulgalore/following{/other_user}","gists_url":"https://api.github.com/users/soulgalore/gists{/gist_id}","starred_url":"https://api.github.com/users/soulgalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulgalore/subscriptions","organizations_url":"https://api.github.com/users/soulgalore/orgs","repos_url":"https://api.github.com/users/soulgalore/repos","events_url":"https://api.github.com/users/soulgalore/events{/privacy}","received_events_url":"https://api.github.com/users/soulgalore/received_events","type":"User","site_admin":false},"body":"Also broke out the creation of the logline to a utility method.","created_at":"2016-10-17T12:51:58Z","updated_at":"2016-10-17T13:32:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c0772612481784bd6d28df73092b135fc404c85","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197/commits","review_comments_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197/comments","review_comment_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/197/comments","statuses_url":"https://api.github.com/repos/sitespeedio/browsertime/statuses/edd5fad553bf3d29238306e67e113a7221880f66","head":{"label":"sitespeedio:log-pagesize","ref":"log-pagesize","sha":"edd5fad553bf3d29238306e67e113a7221880f66","user":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars.githubusercontent.com/u/5693541?v=3","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"repo":{"id":12298355,"name":"browsertime","full_name":"sitespeedio/browsertime","owner":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars.githubusercontent.com/u/5693541?v=3","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sitespeedio/browsertime","description":"Your browser, your page, your scripts!","fork":false,"url":"https://api.github.com/repos/sitespeedio/browsertime","forks_url":"https://api.github.com/repos/sitespeedio/browsertime/forks","keys_url":"https://api.github.com/repos/sitespeedio/browsertime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sitespeedio/browsertime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sitespeedio/browsertime/teams","hooks_url":"https://api.github.com/repos/sitespeedio/browsertime/hooks","issue_events_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/events{/number}","events_url":"https://api.github.com/repos/sitespeedio/browsertime/events","assignees_url":"https://api.github.com/repos/sitespeedio/browsertime/assignees{/user}","branches_url":"https://api.github.com/repos/sitespeedio/browsertime/branches{/branch}","tags_url":"https://api.github.com/repos/sitespeedio/browsertime/tags","blobs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sitespeedio/browsertime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/refs{/sha}","trees_url":"https://api.github.com/repos/sitespeedio/browsertime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sitespeedio/browsertime/statuses/{sha}","languages_url":"https://api.github.com/repos/sitespeedio/browsertime/languages","stargazers_url":"https://api.github.com/repos/sitespeedio/browsertime/stargazers","contributors_url":"https://api.github.com/repos/sitespeedio/browsertime/contributors","subscribers_url":"https://api.github.com/repos/sitespeedio/browsertime/subscribers","subscription_url":"https://api.github.com/repos/sitespeedio/browsertime/subscription","commits_url":"https://api.github.com/repos/sitespeedio/browsertime/commits{/sha}","git_commits_url":"https://api.github.com/repos/sitespeedio/browsertime/git/commits{/sha}","comments_url":"https://api.github.com/repos/sitespeedio/browsertime/comments{/number}","issue_comment_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/comments{/number}","contents_url":"https://api.github.com/repos/sitespeedio/browsertime/contents/{+path}","compare_url":"https://api.github.com/repos/sitespeedio/browsertime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sitespeedio/browsertime/merges","archive_url":"https://api.github.com/repos/sitespeedio/browsertime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sitespeedio/browsertime/downloads","issues_url":"https://api.github.com/repos/sitespeedio/browsertime/issues{/number}","pulls_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls{/number}","milestones_url":"https://api.github.com/repos/sitespeedio/browsertime/milestones{/number}","notifications_url":"https://api.github.com/repos/sitespeedio/browsertime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sitespeedio/browsertime/labels{/name}","releases_url":"https://api.github.com/repos/sitespeedio/browsertime/releases{/id}","deployments_url":"https://api.github.com/repos/sitespeedio/browsertime/deployments","created_at":"2013-08-22T14:00:15Z","updated_at":"2016-09-19T14:23:28Z","pushed_at":"2016-10-17T12:51:58Z","git_url":"git://github.com/sitespeedio/browsertime.git","ssh_url":"git@github.com:sitespeedio/browsertime.git","clone_url":"https://github.com/sitespeedio/browsertime.git","svn_url":"https://github.com/sitespeedio/browsertime","homepage":"","size":83601,"stargazers_count":153,"watchers_count":153,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":28,"forks":24,"open_issues":28,"watchers":153,"default_branch":"master"}},"base":{"label":"sitespeedio:master","ref":"master","sha":"203e4e12a93d9c126730fb9dda3ffba93a776fab","user":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars.githubusercontent.com/u/5693541?v=3","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"repo":{"id":12298355,"name":"browsertime","full_name":"sitespeedio/browsertime","owner":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars.githubusercontent.com/u/5693541?v=3","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sitespeedio/browsertime","description":"Your browser, your page, your scripts!","fork":false,"url":"https://api.github.com/repos/sitespeedio/browsertime","forks_url":"https://api.github.com/repos/sitespeedio/browsertime/forks","keys_url":"https://api.github.com/repos/sitespeedio/browsertime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sitespeedio/browsertime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sitespeedio/browsertime/teams","hooks_url":"https://api.github.com/repos/sitespeedio/browsertime/hooks","issue_events_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/events{/number}","events_url":"https://api.github.com/repos/sitespeedio/browsertime/events","assignees_url":"https://api.github.com/repos/sitespeedio/browsertime/assignees{/user}","branches_url":"https://api.github.com/repos/sitespeedio/browsertime/branches{/branch}","tags_url":"https://api.github.com/repos/sitespeedio/browsertime/tags","blobs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sitespeedio/browsertime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/refs{/sha}","trees_url":"https://api.github.com/repos/sitespeedio/browsertime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sitespeedio/browsertime/statuses/{sha}","languages_url":"https://api.github.com/repos/sitespeedio/browsertime/languages","stargazers_url":"https://api.github.com/repos/sitespeedio/browsertime/stargazers","contributors_url":"https://api.github.com/repos/sitespeedio/browsertime/contributors","subscribers_url":"https://api.github.com/repos/sitespeedio/browsertime/subscribers","subscription_url":"https://api.github.com/repos/sitespeedio/browsertime/subscription","commits_url":"https://api.github.com/repos/sitespeedio/browsertime/commits{/sha}","git_commits_url":"https://api.github.com/repos/sitespeedio/browsertime/git/commits{/sha}","comments_url":"https://api.github.com/repos/sitespeedio/browsertime/comments{/number}","issue_comment_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/comments{/number}","contents_url":"https://api.github.com/repos/sitespeedio/browsertime/contents/{+path}","compare_url":"https://api.github.com/repos/sitespeedio/browsertime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sitespeedio/browsertime/merges","archive_url":"https://api.github.com/repos/sitespeedio/browsertime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sitespeedio/browsertime/downloads","issues_url":"https://api.github.com/repos/sitespeedio/browsertime/issues{/number}","pulls_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls{/number}","milestones_url":"https://api.github.com/repos/sitespeedio/browsertime/milestones{/number}","notifications_url":"https://api.github.com/repos/sitespeedio/browsertime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sitespeedio/browsertime/labels{/name}","releases_url":"https://api.github.com/repos/sitespeedio/browsertime/releases{/id}","deployments_url":"https://api.github.com/repos/sitespeedio/browsertime/deployments","created_at":"2013-08-22T14:00:15Z","updated_at":"2016-09-19T14:23:28Z","pushed_at":"2016-10-17T12:51:58Z","git_url":"git://github.com/sitespeedio/browsertime.git","ssh_url":"git@github.com:sitespeedio/browsertime.git","clone_url":"https://github.com/sitespeedio/browsertime.git","svn_url":"https://github.com/sitespeedio/browsertime","homepage":"","size":83601,"stargazers_count":153,"watchers_count":153,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":28,"forks":24,"open_issues":28,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197"},"html":{"href":"https://github.com/sitespeedio/browsertime/pull/197"},"issue":{"href":"https://api.github.com/repos/sitespeedio/browsertime/issues/197"},"comments":{"href":"https://api.github.com/repos/sitespeedio/browsertime/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/sitespeedio/browsertime/statuses/edd5fad553bf3d29238306e67e113a7221880f66"}}}}
{"actor":{"display_login":"tobli"}}