{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/61539725","id":61539725,"diff_hunk":"@@ -7094,11 +7103,24 @@ int icmp(S1, S2)(S1 str1, S2 str2)\n }\n \n ///\n-unittest{\n+unittest\n+{\n     assert(icmp(\"Rußland\", \"Russland\") == 0);\n     assert(icmp(\"ᾩ -> \\u1F70\\u03B9\", \"\\u1F61\\u03B9 -> ᾲ\") == 0);\n }\n \n+/**\n+ * By using $(XREF utf, byUTF) and its aliases, GC allocations via auto-decoding\n+ * and thrown exceptions can be avoided, making `icmp` `@safe @nogc nothrow pure`.\n+ */\n+@safe @nogc nothrow pure unittest\n+{\n+    import std.utf : byDchar;\n+\n+    assert(icmp(\"Rußland\".byDchar, \"Russland\".byDchar) == 0);","path":"std/uni.d","position":77,"original_position":77,"commit_id":"afd54b5f1cf16c32ef9001f0f0e73e40850bc2eb","original_commit_id":"afd54b5f1cf16c32ef9001f0f0e73e40850bc2eb","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"Wait what??? \r\nIn German (my mother tongue) this is not guaranteed to be correct. From Wikipedia:\r\n\r\nThus it helps to distinguish words like Buße (long vowel) 'penance, fine' and Busse (short vowel) 'buses'. \r\n\r\nhttps://en.m.wikipedia.org/wiki/%C3%9F","created_at":"2016-04-29T06:45:45Z","updated_at":"2016-04-29T06:45:45Z","html_url":"https://github.com/dlang/phobos/pull/4256#discussion_r61539725","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/4256","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/61539725"},"html":{"href":"https://github.com/dlang/phobos/pull/4256#discussion_r61539725"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4256"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/4256","id":68236894,"html_url":"https://github.com/dlang/phobos/pull/4256","diff_url":"https://github.com/dlang/phobos/pull/4256.diff","patch_url":"https://github.com/dlang/phobos/pull/4256.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/4256","number":4256,"state":"open","locked":false,"title":"Improvements to std.uni.sicmp and std.uni.icmp","user":{"login":"JackStouffer","id":680068,"avatar_url":"https://avatars.githubusercontent.com/u/680068?v=3","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},"body":"The main points:\r\n\r\n1. The constraints for `sicmp` were completely wrong because `decode` cannot be called with forward ranges. In the future this could be made to work with forward ranges but for now this needs to be fixed\r\n2. Emphasized the fact that `icmp` can be `@nogc @safe nothrow pure` if used with `byUTF`.\r\n3. Added more detail to `icmp`'s docs","created_at":"2016-04-28T15:06:27Z","updated_at":"2016-04-29T06:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5dbec5330d4e90964a122b0d3cb3610028f3d7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/4256/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/4256/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/4256/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/afd54b5f1cf16c32ef9001f0f0e73e40850bc2eb","head":{"label":"JackStouffer:sicmp","ref":"sicmp","sha":"afd54b5f1cf16c32ef9001f0f0e73e40850bc2eb","user":{"login":"JackStouffer","id":680068,"avatar_url":"https://avatars.githubusercontent.com/u/680068?v=3","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},"repo":{"id":41213554,"name":"phobos","full_name":"JackStouffer/phobos","owner":{"login":"JackStouffer","id":680068,"avatar_url":"https://avatars.githubusercontent.com/u/680068?v=3","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JackStouffer/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/JackStouffer/phobos","forks_url":"https://api.github.com/repos/JackStouffer/phobos/forks","keys_url":"https://api.github.com/repos/JackStouffer/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JackStouffer/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JackStouffer/phobos/teams","hooks_url":"https://api.github.com/repos/JackStouffer/phobos/hooks","issue_events_url":"https://api.github.com/repos/JackStouffer/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/JackStouffer/phobos/events","assignees_url":"https://api.github.com/repos/JackStouffer/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/JackStouffer/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/JackStouffer/phobos/tags","blobs_url":"https://api.github.com/repos/JackStouffer/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JackStouffer/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JackStouffer/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/JackStouffer/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JackStouffer/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/JackStouffer/phobos/languages","stargazers_url":"https://api.github.com/repos/JackStouffer/phobos/stargazers","contributors_url":"https://api.github.com/repos/JackStouffer/phobos/contributors","subscribers_url":"https://api.github.com/repos/JackStouffer/phobos/subscribers","subscription_url":"https://api.github.com/repos/JackStouffer/phobos/subscription","commits_url":"https://api.github.com/repos/JackStouffer/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/JackStouffer/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/JackStouffer/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/JackStouffer/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/JackStouffer/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/JackStouffer/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JackStouffer/phobos/merges","archive_url":"https://api.github.com/repos/JackStouffer/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JackStouffer/phobos/downloads","issues_url":"https://api.github.com/repos/JackStouffer/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/JackStouffer/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/JackStouffer/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/JackStouffer/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JackStouffer/phobos/labels{/name}","releases_url":"https://api.github.com/repos/JackStouffer/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/JackStouffer/phobos/deployments","created_at":"2015-08-22T15:33:19Z","updated_at":"2016-01-13T20:23:30Z","pushed_at":"2016-04-28T19:01:22Z","git_url":"git://github.com/JackStouffer/phobos.git","ssh_url":"git@github.com:JackStouffer/phobos.git","clone_url":"https://github.com/JackStouffer/phobos.git","svn_url":"https://github.com/JackStouffer/phobos","homepage":"dlang.org/phobos","size":48724,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"e56537dedbd78fb7cf165d64413c26134a1f3771","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-04-27T21:40:35Z","pushed_at":"2016-04-28T22:19:48Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":75998,"stargazers_count":705,"watchers_count":705,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":477,"mirror_url":null,"open_issues_count":79,"forks":477,"open_issues":79,"watchers":705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4256"},"html":{"href":"https://github.com/dlang/phobos/pull/4256"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/4256"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/4256/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4256/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4256/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/afd54b5f1cf16c32ef9001f0f0e73e40850bc2eb"}}}}