{"action":"created","comment":{"url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/comments/77987089","id":77987089,"diff_hunk":"@@ -28,7 +29,7 @@ trait SchedulerClient {\n    *\n    * @return a `Future` with the list of all previously scheduled job status.","path":"src/main/scala/eu/shiftforward/adstax/scheduler/SchedulerClient.scala","position":22,"original_position":22,"commit_id":"c4053bcbb40cffe6dfd35d14b927af20d8e89242","original_commit_id":"c4053bcbb40cffe6dfd35d14b927af20d8e89242","user":{"login":"jcazevedo","id":143188,"avatar_url":"https://avatars.githubusercontent.com/u/143188?v=3","gravatar_id":"","url":"https://api.github.com/users/jcazevedo","html_url":"https://github.com/jcazevedo","followers_url":"https://api.github.com/users/jcazevedo/followers","following_url":"https://api.github.com/users/jcazevedo/following{/other_user}","gists_url":"https://api.github.com/users/jcazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcazevedo/subscriptions","organizations_url":"https://api.github.com/users/jcazevedo/orgs","repos_url":"https://api.github.com/users/jcazevedo/repos","events_url":"https://api.github.com/users/jcazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/jcazevedo/received_events","type":"User","site_admin":false},"body":"Update the ScalaDoc here. We're no longer returning the the list of all previously scheduled job status.","created_at":"2016-09-08T11:14:22Z","updated_at":"2016-09-08T11:14:22Z","html_url":"https://github.com/ShiftForward/adstax-sdk-scala/pull/5#discussion_r77987089","pull_request_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/comments/77987089"},"html":{"href":"https://github.com/ShiftForward/adstax-sdk-scala/pull/5#discussion_r77987089"},"pull_request":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5","id":84324714,"html_url":"https://github.com/ShiftForward/adstax-sdk-scala/pull/5","diff_url":"https://github.com/ShiftForward/adstax-sdk-scala/pull/5.diff","patch_url":"https://github.com/ShiftForward/adstax-sdk-scala/pull/5.patch","issue_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/5","number":5,"state":"open","locked":false,"title":"Refactor/scheduler job listing","user":{"login":"belerophon","id":203170,"avatar_url":"https://avatars.githubusercontent.com/u/203170?v=3","gravatar_id":"","url":"https://api.github.com/users/belerophon","html_url":"https://github.com/belerophon","followers_url":"https://api.github.com/users/belerophon/followers","following_url":"https://api.github.com/users/belerophon/following{/other_user}","gists_url":"https://api.github.com/users/belerophon/gists{/gist_id}","starred_url":"https://api.github.com/users/belerophon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belerophon/subscriptions","organizations_url":"https://api.github.com/users/belerophon/orgs","repos_url":"https://api.github.com/users/belerophon/repos","events_url":"https://api.github.com/users/belerophon/events{/privacy}","received_events_url":"https://api.github.com/users/belerophon/received_events","type":"User","site_admin":false},"body":"This PR changes the scheduler interface, and makes the methods `scheduleAction` and `getJobsStatus` return the scheduler action and a map of ids to actions, respectively. The first method, returns the action that was just scheduled, if no error occurs. The second one, gives us a map of all the currently scheduled actions, indexed by action id.\r\n\r\nThis interface seems to be more useful than the one where only a list of ids were returned. Also, the amount of data to return for each of the available scheduler actions does not seem to prohibit this approach.","created_at":"2016-09-07T15:40:20Z","updated_at":"2016-09-08T11:14:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03b13528755b9f9a60400992c3a2bf24e4025bca","assignee":{"login":"jcazevedo","id":143188,"avatar_url":"https://avatars.githubusercontent.com/u/143188?v=3","gravatar_id":"","url":"https://api.github.com/users/jcazevedo","html_url":"https://github.com/jcazevedo","followers_url":"https://api.github.com/users/jcazevedo/followers","following_url":"https://api.github.com/users/jcazevedo/following{/other_user}","gists_url":"https://api.github.com/users/jcazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcazevedo/subscriptions","organizations_url":"https://api.github.com/users/jcazevedo/orgs","repos_url":"https://api.github.com/users/jcazevedo/repos","events_url":"https://api.github.com/users/jcazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/jcazevedo/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcazevedo","id":143188,"avatar_url":"https://avatars.githubusercontent.com/u/143188?v=3","gravatar_id":"","url":"https://api.github.com/users/jcazevedo","html_url":"https://github.com/jcazevedo","followers_url":"https://api.github.com/users/jcazevedo/followers","following_url":"https://api.github.com/users/jcazevedo/following{/other_user}","gists_url":"https://api.github.com/users/jcazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcazevedo/subscriptions","organizations_url":"https://api.github.com/users/jcazevedo/orgs","repos_url":"https://api.github.com/users/jcazevedo/repos","events_url":"https://api.github.com/users/jcazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/jcazevedo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/5/comments","statuses_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/c4053bcbb40cffe6dfd35d14b927af20d8e89242","head":{"label":"ShiftForward:refactor/scheduler-job-listing","ref":"refactor/scheduler-job-listing","sha":"c4053bcbb40cffe6dfd35d14b927af20d8e89242","user":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"repo":{"id":63863997,"name":"adstax-sdk-scala","full_name":"ShiftForward/adstax-sdk-scala","owner":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ShiftForward/adstax-sdk-scala","description":"Tools for programmatic interaction with an AdStax instance using Scala","fork":false,"url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala","forks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/forks","keys_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/teams","hooks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/hooks","issue_events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/events{/number}","events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/events","assignees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/assignees{/user}","branches_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/branches{/branch}","tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/tags","blobs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/languages","stargazers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/stargazers","contributors_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contributors","subscribers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscribers","subscription_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscription","commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contents/{+path}","compare_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/merges","archive_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/downloads","issues_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues{/number}","pulls_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/labels{/name}","releases_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/releases{/id}","deployments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/deployments","created_at":"2016-07-21T11:32:44Z","updated_at":"2016-08-03T17:32:19Z","pushed_at":"2016-09-07T15:40:20Z","git_url":"git://github.com/ShiftForward/adstax-sdk-scala.git","ssh_url":"git@github.com:ShiftForward/adstax-sdk-scala.git","clone_url":"https://github.com/ShiftForward/adstax-sdk-scala.git","svn_url":"https://github.com/ShiftForward/adstax-sdk-scala","homepage":null,"size":304,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"ShiftForward:master","ref":"master","sha":"f5f69ca79f7f5b1b4016cba7b2fb77c04a38de8f","user":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"repo":{"id":63863997,"name":"adstax-sdk-scala","full_name":"ShiftForward/adstax-sdk-scala","owner":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ShiftForward/adstax-sdk-scala","description":"Tools for programmatic interaction with an AdStax instance using Scala","fork":false,"url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala","forks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/forks","keys_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/teams","hooks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/hooks","issue_events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/events{/number}","events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/events","assignees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/assignees{/user}","branches_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/branches{/branch}","tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/tags","blobs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/languages","stargazers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/stargazers","contributors_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contributors","subscribers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscribers","subscription_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscription","commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contents/{+path}","compare_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/merges","archive_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/downloads","issues_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues{/number}","pulls_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/labels{/name}","releases_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/releases{/id}","deployments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/deployments","created_at":"2016-07-21T11:32:44Z","updated_at":"2016-08-03T17:32:19Z","pushed_at":"2016-09-07T15:40:20Z","git_url":"git://github.com/ShiftForward/adstax-sdk-scala.git","ssh_url":"git@github.com:ShiftForward/adstax-sdk-scala.git","clone_url":"https://github.com/ShiftForward/adstax-sdk-scala.git","svn_url":"https://github.com/ShiftForward/adstax-sdk-scala","homepage":null,"size":304,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5"},"html":{"href":"https://github.com/ShiftForward/adstax-sdk-scala/pull/5"},"issue":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/5"},"comments":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/c4053bcbb40cffe6dfd35d14b927af20d8e89242"}}}}
{"actor":{"display_login":"jcazevedo"}}