{"action":"created","issue":{"url":"https://api.github.com/repos/real-logic/simple-binary-encoding/issues/362","repository_url":"https://api.github.com/repos/real-logic/simple-binary-encoding","labels_url":"https://api.github.com/repos/real-logic/simple-binary-encoding/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/real-logic/simple-binary-encoding/issues/362/comments","events_url":"https://api.github.com/repos/real-logic/simple-binary-encoding/issues/362/events","html_url":"https://github.com/real-logic/simple-binary-encoding/issues/362","id":164407242,"number":362,"title":"Incorrect Code Generation?","user":{"login":"structurechart","id":6512702,"avatar_url":"https://avatars.githubusercontent.com/u/6512702?v=3","gravatar_id":"","url":"https://api.github.com/users/structurechart","html_url":"https://github.com/structurechart","followers_url":"https://api.github.com/users/structurechart/followers","following_url":"https://api.github.com/users/structurechart/following{/other_user}","gists_url":"https://api.github.com/users/structurechart/gists{/gist_id}","starred_url":"https://api.github.com/users/structurechart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/structurechart/subscriptions","organizations_url":"https://api.github.com/users/structurechart/orgs","repos_url":"https://api.github.com/users/structurechart/repos","events_url":"https://api.github.com/users/structurechart/events{/privacy}","received_events_url":"https://api.github.com/users/structurechart/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/real-logic/simple-binary-encoding/labels/question","name":"question","color":"cc317c"},{"url":"https://api.github.com/repos/real-logic/simple-binary-encoding/labels/wontfix","name":"wontfix","color":"ffffff"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-07T21:05:42Z","updated_at":"2016-07-14T15:35:05Z","closed_at":"2016-07-12T15:56:28Z","body":"Hi,\r\n\r\nI am using this XML file:\r\nftp://ftp.cmegroup.com/SBEFix/Production/Templates/templates_FixBinary.xml\r\n\r\nAfter I generated with the latest build, it generated MDIncrementalRefreshVolume37.hpp that contains:\r\n\r\n>     class NoMDEntries\r\n>     {\r\n> ..........\r\n>         inline NoMDEntries &next(void)\r\n>         {\r\n> ...........\r\n>          }\r\n> ...........\r\n>         const char *mDEntryType(void) const\r\n>         {\r\n>             static sbe_uint8_t mDEntryTypeValues[] = {101};\r\n> \r\n>             return (const char *)mDEntryTypeValues;\r\n>         }\r\n> ...........\r\n>     }\r\n> \r\n\r\nAccording to the XML template, MDEntryType is a const char not a const char*.\r\n\r\nI would expect that MDIncrementalRefreshVolume37.hpp contained \"char mDEntryType(void) const\" instead as the XML template states MDEntryType is a char.\r\n\r\nThanks in advance."},"comment":{"url":"https://api.github.com/repos/real-logic/simple-binary-encoding/issues/comments/232701705","html_url":"https://github.com/real-logic/simple-binary-encoding/issues/362#issuecomment-232701705","issue_url":"https://api.github.com/repos/real-logic/simple-binary-encoding/issues/362","id":232701705,"user":{"login":"tmontgomery","id":1979352,"avatar_url":"https://avatars.githubusercontent.com/u/1979352?v=3","gravatar_id":"","url":"https://api.github.com/users/tmontgomery","html_url":"https://github.com/tmontgomery","followers_url":"https://api.github.com/users/tmontgomery/followers","following_url":"https://api.github.com/users/tmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/tmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/tmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmontgomery/subscriptions","organizations_url":"https://api.github.com/users/tmontgomery/orgs","repos_url":"https://api.github.com/users/tmontgomery/repos","events_url":"https://api.github.com/users/tmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/tmontgomery/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T15:35:05Z","updated_at":"2016-07-14T15:35:05Z","body":"@structurechart The field in question is a constant field for a char and not an enum. This is all in the control of the schema. RC3 added constant enums, in part, for this reason.\r\n\r\nThere are other considerations with how constant fields are used and some assumptions about how they might change (as they don't require any binary compatibility). @mjpt777 and I have discussed it and will continue to.\r\n"}}
{"actor":{"display_login":"tmontgomery"}}