{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/264","repository_url":"https://api.github.com/repos/cfpb/college-costs","labels_url":"https://api.github.com/repos/cfpb/college-costs/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/college-costs/issues/264/comments","events_url":"https://api.github.com/repos/cfpb/college-costs/issues/264/events","html_url":"https://github.com/cfpb/college-costs/pull/264","id":169722607,"number":264,"title":"don't treat PID as numeric","user":{"login":"higs4281","id":515885,"avatar_url":"https://avatars.githubusercontent.com/u/515885?v=3","gravatar_id":"","url":"https://api.github.com/users/higs4281","html_url":"https://github.com/higs4281","followers_url":"https://api.github.com/users/higs4281/followers","following_url":"https://api.github.com/users/higs4281/following{/other_user}","gists_url":"https://api.github.com/users/higs4281/gists{/gist_id}","starred_url":"https://api.github.com/users/higs4281/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/higs4281/subscriptions","organizations_url":"https://api.github.com/users/higs4281/orgs","repos_url":"https://api.github.com/users/higs4281/repos","events_url":"https://api.github.com/users/higs4281/events{/privacy}","received_events_url":"https://api.github.com/users/higs4281/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-06T01:32:13Z","updated_at":"2016-08-08T13:03:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/college-costs/pulls/264","html_url":"https://github.com/cfpb/college-costs/pull/264","diff_url":"https://github.com/cfpb/college-costs/pull/264.diff","patch_url":"https://github.com/cfpb/college-costs/pull/264.patch"},"body":"PID values are allowed to have characters and should not be stripped.\r\nSorry I'm tumbling to this so late, but stripping will defeat some program IDs.\r\n\r\n## Changes\r\n\r\n- Take pid out of the `numercKeys` list\r\n\r\n## Testing\r\n- We can't test this with current EDMC programs, because as luck would have it they made all their IDs integers. But here's how you can hack a program locally to test it:\r\n\r\n- fire up runserver\r\n```\r\n.manage.py runserver\r\n```\r\n\r\n- In another tab, fire up the virtual env and open a shell session\r\n\r\n```\r\n./manage.py shell\r\n```\r\n\r\nThen in shell, paste all this in:\r\n\r\n```\r\nfrom paying_for_college.models import *\r\np = Program.objects.get(program_code='1832')\r\np.program_code = 'a832'\r\np.save()\r\nexit()\r\n```\r\n\r\nThen try [this disclosure](http://localhost:8000/paying-for-college2/understanding-your-financial-aid-offer/offer/?iped=449898&pid=a832&oid=fa8283b5b7c939a058889f997949efa566c616a1&book=1500&gib=0&gpl=0&hous=5611&insi=5.0&insl=3000&inst=36&mta=0&othg=100&othr=6079&parl=7000&pelg=1500&perl=5500&ppl=0&prvl=2000&prvf=2.1&prvi=4.55&schg=2000&stag=2000&subl=3500&totl=44700&tran=500&tuit=22322&unsl=2000&wkst=1000)\r\nIt should render a disclosure without errors, using a pid with a letter in it.\r\n\r\nThen check out master, run `gulp` and refresh the same URL. It should go wonky because the API program call will fail (with a stripped ID) but the back end won't raise a warning because the pid is valid before it hits the page.\r\n\r\nif you want to reset your programs to their former pristine state:\r\n\r\n```\r\n./manage.py purge programs\r\n./manage.py loaddata collegedata\r\n```\r\n\r\n## Review\r\n- @mistergone or @marteki \r\n\r\n* [x] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/comments/238228591","html_url":"https://github.com/cfpb/college-costs/pull/264#issuecomment-238228591","issue_url":"https://api.github.com/repos/cfpb/college-costs/issues/264","id":238228591,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T13:03:25Z","updated_at":"2016-08-08T13:03:25Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7350219/badge)](https://coveralls.io/builds/7350219)\n\nCoverage remained the same at 100.0% when pulling **c773d6cffa138831223553644ca82ed588db358d on string-pid** into **c4ecdb1fa2ff23a92f6540421f1b90e984941006 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}