{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/59807077","id":59807077,"diff_hunk":"@@ -1350,14 +1350,6 @@ create_allocator (int atype, gboolean slowpath)\n \t\tmono_mb_emit_byte (mb, MONO_CEE_ADD);\n \t\tmono_mb_emit_ldarg (mb, 1);\n \t\tmono_mb_emit_byte (mb, MONO_CEE_STIND_I4);\n-\t\t/* s->chars [len] = 0; */\n-\t\tmono_mb_emit_ldloc (mb, p_var);\n-\t\tmono_mb_emit_ldloc (mb, size_var);\n-\t\tmono_mb_emit_icon (mb, 2);\n-\t\tmono_mb_emit_byte (mb, MONO_CEE_SUB);\n-\t\tmono_mb_emit_byte (mb, MONO_CEE_ADD);\n-\t\tmono_mb_emit_icon (mb, 0);\n-\t\tmono_mb_emit_byte (mb, MONO_CEE_STIND_I2);","path":"mono/metadata/sgen-mono.c","position":11,"original_position":11,"commit_id":"30f0795c825559124fb2d4b46963e7b88dcd3246","original_commit_id":"30f0795c825559124fb2d4b46963e7b88dcd3246","user":{"login":"schani","id":61363,"avatar_url":"https://avatars.githubusercontent.com/u/61363?v=3","gravatar_id":"","url":"https://api.github.com/users/schani","html_url":"https://github.com/schani","followers_url":"https://api.github.com/users/schani/followers","following_url":"https://api.github.com/users/schani/following{/other_user}","gists_url":"https://api.github.com/users/schani/gists{/gist_id}","starred_url":"https://api.github.com/users/schani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schani/subscriptions","organizations_url":"https://api.github.com/users/schani/orgs","repos_url":"https://api.github.com/users/schani/repos","events_url":"https://api.github.com/users/schani/events{/privacy}","received_events_url":"https://api.github.com/users/schani/received_events","type":"User","site_admin":false},"body":"Why is this wrong?","created_at":"2016-04-14T23:11:39Z","updated_at":"2016-04-14T23:11:39Z","html_url":"https://github.com/mono/mono/pull/2890#discussion_r59807077","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/2890","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/59807077"},"html":{"href":"https://github.com/mono/mono/pull/2890#discussion_r59807077"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/2890"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/2890","id":66552484,"html_url":"https://github.com/mono/mono/pull/2890","diff_url":"https://github.com/mono/mono/pull/2890.diff","patch_url":"https://github.com/mono/mono/pull/2890.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/2890","number":2890,"state":"open","locked":false,"title":"[TEST][sgen] Remove unnecessary and wrong IL code on string managed allocators","user":{"login":"alexischr","id":1048813,"avatar_url":"https://avatars.githubusercontent.com/u/1048813?v=3","gravatar_id":"","url":"https://api.github.com/users/alexischr","html_url":"https://github.com/alexischr","followers_url":"https://api.github.com/users/alexischr/followers","following_url":"https://api.github.com/users/alexischr/following{/other_user}","gists_url":"https://api.github.com/users/alexischr/gists{/gist_id}","starred_url":"https://api.github.com/users/alexischr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexischr/subscriptions","organizations_url":"https://api.github.com/users/alexischr/orgs","repos_url":"https://api.github.com/users/alexischr/repos","events_url":"https://api.github.com/users/alexischr/events{/privacy}","received_events_url":"https://api.github.com/users/alexischr/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-14T20:56:39Z","updated_at":"2016-04-14T23:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86c54caf8cfa991b2ea9594ff7b72ac5ed63a5f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/2890/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/2890/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/2890/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/30f0795c825559124fb2d4b46963e7b88dcd3246","head":{"label":"mono:alexischr/remove-managed-alloc-string-zeroing","ref":"alexischr/remove-managed-alloc-string-zeroing","sha":"30f0795c825559124fb2d4b46963e7b88dcd3246","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-04-14T14:48:13Z","pushed_at":"2016-04-14T22:42:31Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":469351,"stargazers_count":4510,"watchers_count":4510,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2157,"mirror_url":null,"open_issues_count":112,"forks":2157,"open_issues":112,"watchers":4510,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"5e80f625b93706328c9a22b1cbb73300f2ea2186","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-04-14T14:48:13Z","pushed_at":"2016-04-14T22:42:31Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":469351,"stargazers_count":4510,"watchers_count":4510,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2157,"mirror_url":null,"open_issues_count":112,"forks":2157,"open_issues":112,"watchers":4510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/2890"},"html":{"href":"https://github.com/mono/mono/pull/2890"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/2890"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/2890/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/2890/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/2890/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/30f0795c825559124fb2d4b46963e7b88dcd3246"}}}}