{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/liquid-c/pulls/comments/68806470","id":68806470,"diff_hunk":"@@ -68,7 +72,22 @@ static VALUE rb_block_parse(VALUE self, VALUE tokens, VALUE options)\n             }\n             case TOKEN_VARIABLE:\n             {\n-                VALUE args[2] = {rb_enc_str_new(token.str + 2, token.length - 4, utf8_encoding), options};\n+                const char *start = token.str + 2;\n+                long end = token.length - 4;\n+\n+                if (token.str[2] == '-') {\n+                    VALUE last_node = rb_ary_pop(nodelist);\n+                    rb_funcall(last_node, rb_intern(\"rstrip!\"), 0);","path":"ext/liquid_c/block.c","position":21,"original_position":21,"commit_id":"66f3bf985f553232ccd5b6775fe353446c5c5e80","original_commit_id":"66f3bf985f553232ccd5b6775fe353446c5c5e80","user":{"login":"pushrax","id":984857,"avatar_url":"https://avatars.githubusercontent.com/u/984857?v=3","gravatar_id":"","url":"https://api.github.com/users/pushrax","html_url":"https://github.com/pushrax","followers_url":"https://api.github.com/users/pushrax/followers","following_url":"https://api.github.com/users/pushrax/following{/other_user}","gists_url":"https://api.github.com/users/pushrax/gists{/gist_id}","starred_url":"https://api.github.com/users/pushrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushrax/subscriptions","organizations_url":"https://api.github.com/users/pushrax/orgs","repos_url":"https://api.github.com/users/pushrax/repos","events_url":"https://api.github.com/users/pushrax/events{/privacy}","received_events_url":"https://api.github.com/users/pushrax/received_events","type":"User","site_admin":false},"body":"I don't mind `rstrip!` because it just sets the length – no memmove required.","created_at":"2016-06-28T17:45:55Z","updated_at":"2016-06-28T17:45:55Z","html_url":"https://github.com/Shopify/liquid-c/pull/30#discussion_r68806470","pull_request_url":"https://api.github.com/repos/Shopify/liquid-c/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/Shopify/liquid-c/pulls/comments/68806470"},"html":{"href":"https://github.com/Shopify/liquid-c/pull/30#discussion_r68806470"},"pull_request":{"href":"https://api.github.com/repos/Shopify/liquid-c/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/liquid-c/pulls/30","id":75359242,"html_url":"https://github.com/Shopify/liquid-c/pull/30","diff_url":"https://github.com/Shopify/liquid-c/pull/30.diff","patch_url":"https://github.com/Shopify/liquid-c/pull/30.patch","issue_url":"https://api.github.com/repos/Shopify/liquid-c/issues/30","number":30,"state":"open","locked":false,"title":"Add support for whitespace control character.","user":{"login":"evulse","id":1631174,"avatar_url":"https://avatars.githubusercontent.com/u/1631174?v=3","gravatar_id":"","url":"https://api.github.com/users/evulse","html_url":"https://github.com/evulse","followers_url":"https://api.github.com/users/evulse/followers","following_url":"https://api.github.com/users/evulse/following{/other_user}","gists_url":"https://api.github.com/users/evulse/gists{/gist_id}","starred_url":"https://api.github.com/users/evulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evulse/subscriptions","organizations_url":"https://api.github.com/users/evulse/orgs","repos_url":"https://api.github.com/users/evulse/repos","events_url":"https://api.github.com/users/evulse/events{/privacy}","received_events_url":"https://api.github.com/users/evulse/received_events","type":"User","site_admin":false},"body":"This matches up with Shopify/liquid#746 to resolve issues Shopify/liquid#216, Shopify/liquid#215, Shopify/liquid#214, Shopify/liquid#194, Shopify/liquid#171, Shopify/liquid#162\r\n\r\nThis pull request is designed to be standalone and will pass all tests without its counterpart Shopify/liquid#746 however Shopify/liquid#746 requires this pull request and will be updated with this dependancy once merged.","created_at":"2016-06-27T18:40:44Z","updated_at":"2016-06-28T17:45:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"735f8b34aac29b0ebb599d7e498f111b13d3c7ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/liquid-c/pulls/30/commits","review_comments_url":"https://api.github.com/repos/Shopify/liquid-c/pulls/30/comments","review_comment_url":"https://api.github.com/repos/Shopify/liquid-c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/liquid-c/issues/30/comments","statuses_url":"https://api.github.com/repos/Shopify/liquid-c/statuses/66f3bf985f553232ccd5b6775fe353446c5c5e80","head":{"label":"evulse:whitespace-control","ref":"whitespace-control","sha":"66f3bf985f553232ccd5b6775fe353446c5c5e80","user":{"login":"evulse","id":1631174,"avatar_url":"https://avatars.githubusercontent.com/u/1631174?v=3","gravatar_id":"","url":"https://api.github.com/users/evulse","html_url":"https://github.com/evulse","followers_url":"https://api.github.com/users/evulse/followers","following_url":"https://api.github.com/users/evulse/following{/other_user}","gists_url":"https://api.github.com/users/evulse/gists{/gist_id}","starred_url":"https://api.github.com/users/evulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evulse/subscriptions","organizations_url":"https://api.github.com/users/evulse/orgs","repos_url":"https://api.github.com/users/evulse/repos","events_url":"https://api.github.com/users/evulse/events{/privacy}","received_events_url":"https://api.github.com/users/evulse/received_events","type":"User","site_admin":false},"repo":{"id":57024710,"name":"liquid-c","full_name":"evulse/liquid-c","owner":{"login":"evulse","id":1631174,"avatar_url":"https://avatars.githubusercontent.com/u/1631174?v=3","gravatar_id":"","url":"https://api.github.com/users/evulse","html_url":"https://github.com/evulse","followers_url":"https://api.github.com/users/evulse/followers","following_url":"https://api.github.com/users/evulse/following{/other_user}","gists_url":"https://api.github.com/users/evulse/gists{/gist_id}","starred_url":"https://api.github.com/users/evulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evulse/subscriptions","organizations_url":"https://api.github.com/users/evulse/orgs","repos_url":"https://api.github.com/users/evulse/repos","events_url":"https://api.github.com/users/evulse/events{/privacy}","received_events_url":"https://api.github.com/users/evulse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evulse/liquid-c","description":"Liquid performance extension in C.","fork":true,"url":"https://api.github.com/repos/evulse/liquid-c","forks_url":"https://api.github.com/repos/evulse/liquid-c/forks","keys_url":"https://api.github.com/repos/evulse/liquid-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evulse/liquid-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evulse/liquid-c/teams","hooks_url":"https://api.github.com/repos/evulse/liquid-c/hooks","issue_events_url":"https://api.github.com/repos/evulse/liquid-c/issues/events{/number}","events_url":"https://api.github.com/repos/evulse/liquid-c/events","assignees_url":"https://api.github.com/repos/evulse/liquid-c/assignees{/user}","branches_url":"https://api.github.com/repos/evulse/liquid-c/branches{/branch}","tags_url":"https://api.github.com/repos/evulse/liquid-c/tags","blobs_url":"https://api.github.com/repos/evulse/liquid-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evulse/liquid-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evulse/liquid-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/evulse/liquid-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evulse/liquid-c/statuses/{sha}","languages_url":"https://api.github.com/repos/evulse/liquid-c/languages","stargazers_url":"https://api.github.com/repos/evulse/liquid-c/stargazers","contributors_url":"https://api.github.com/repos/evulse/liquid-c/contributors","subscribers_url":"https://api.github.com/repos/evulse/liquid-c/subscribers","subscription_url":"https://api.github.com/repos/evulse/liquid-c/subscription","commits_url":"https://api.github.com/repos/evulse/liquid-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/evulse/liquid-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/evulse/liquid-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/evulse/liquid-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/evulse/liquid-c/contents/{+path}","compare_url":"https://api.github.com/repos/evulse/liquid-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evulse/liquid-c/merges","archive_url":"https://api.github.com/repos/evulse/liquid-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evulse/liquid-c/downloads","issues_url":"https://api.github.com/repos/evulse/liquid-c/issues{/number}","pulls_url":"https://api.github.com/repos/evulse/liquid-c/pulls{/number}","milestones_url":"https://api.github.com/repos/evulse/liquid-c/milestones{/number}","notifications_url":"https://api.github.com/repos/evulse/liquid-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evulse/liquid-c/labels{/name}","releases_url":"https://api.github.com/repos/evulse/liquid-c/releases{/id}","deployments_url":"https://api.github.com/repos/evulse/liquid-c/deployments","created_at":"2016-04-25T08:26:53Z","updated_at":"2016-04-25T08:26:54Z","pushed_at":"2016-06-27T18:34:09Z","git_url":"git://github.com/evulse/liquid-c.git","ssh_url":"git@github.com:evulse/liquid-c.git","clone_url":"https://github.com/evulse/liquid-c.git","svn_url":"https://github.com/evulse/liquid-c","homepage":null,"size":266,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"28822cbd0a59546e103b3a2246adf73b1aafe83c","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":18155944,"name":"liquid-c","full_name":"Shopify/liquid-c","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/liquid-c","description":"Liquid performance extension in C.","fork":false,"url":"https://api.github.com/repos/Shopify/liquid-c","forks_url":"https://api.github.com/repos/Shopify/liquid-c/forks","keys_url":"https://api.github.com/repos/Shopify/liquid-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/liquid-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/liquid-c/teams","hooks_url":"https://api.github.com/repos/Shopify/liquid-c/hooks","issue_events_url":"https://api.github.com/repos/Shopify/liquid-c/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/liquid-c/events","assignees_url":"https://api.github.com/repos/Shopify/liquid-c/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/liquid-c/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/liquid-c/tags","blobs_url":"https://api.github.com/repos/Shopify/liquid-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/liquid-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/liquid-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/liquid-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/liquid-c/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/liquid-c/languages","stargazers_url":"https://api.github.com/repos/Shopify/liquid-c/stargazers","contributors_url":"https://api.github.com/repos/Shopify/liquid-c/contributors","subscribers_url":"https://api.github.com/repos/Shopify/liquid-c/subscribers","subscription_url":"https://api.github.com/repos/Shopify/liquid-c/subscription","commits_url":"https://api.github.com/repos/Shopify/liquid-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/liquid-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/liquid-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/liquid-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/liquid-c/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/liquid-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/liquid-c/merges","archive_url":"https://api.github.com/repos/Shopify/liquid-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/liquid-c/downloads","issues_url":"https://api.github.com/repos/Shopify/liquid-c/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/liquid-c/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/liquid-c/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/liquid-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/liquid-c/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/liquid-c/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/liquid-c/deployments","created_at":"2014-03-26T22:20:17Z","updated_at":"2016-04-21T17:58:20Z","pushed_at":"2016-06-27T18:40:45Z","git_url":"git://github.com/Shopify/liquid-c.git","ssh_url":"git@github.com:Shopify/liquid-c.git","clone_url":"https://github.com/Shopify/liquid-c.git","svn_url":"https://github.com/Shopify/liquid-c","homepage":null,"size":873,"stargazers_count":26,"watchers_count":26,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/liquid-c/pulls/30"},"html":{"href":"https://github.com/Shopify/liquid-c/pull/30"},"issue":{"href":"https://api.github.com/repos/Shopify/liquid-c/issues/30"},"comments":{"href":"https://api.github.com/repos/Shopify/liquid-c/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/liquid-c/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/liquid-c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/liquid-c/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/liquid-c/statuses/66f3bf985f553232ccd5b6775fe353446c5c5e80"}}}}
{"actor":{"display_login":"pushrax"}}