{"action":"created","issue":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9147","repository_url":"https://api.github.com/repos/qooxdoo/qooxdoo","labels_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9147/labels{/name}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9147/comments","events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9147/events","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9147","id":174127221,"number":9147,"title":"Integrate eslint-config-qx with Qooxdoo and lint.","user":{"login":"pcdummy","id":358074,"avatar_url":"https://avatars.githubusercontent.com/u/358074?v=3","gravatar_id":"","url":"https://api.github.com/users/pcdummy","html_url":"https://github.com/pcdummy","followers_url":"https://api.github.com/users/pcdummy/followers","following_url":"https://api.github.com/users/pcdummy/following{/other_user}","gists_url":"https://api.github.com/users/pcdummy/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdummy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdummy/subscriptions","organizations_url":"https://api.github.com/users/pcdummy/orgs","repos_url":"https://api.github.com/users/pcdummy/repos","events_url":"https://api.github.com/users/pcdummy/events{/privacy}","received_events_url":"https://api.github.com/users/pcdummy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-08-30T21:11:56Z","updated_at":"2016-09-01T21:37:33Z","closed_at":"2016-08-31T17:55:08Z","pull_request":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9147","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9147","diff_url":"https://github.com/qooxdoo/qooxdoo/pull/9147.diff","patch_url":"https://github.com/qooxdoo/qooxdoo/pull/9147.patch"},"body":"This is my try to integrate [eslint-config-qx](http://npmjs.com/package/eslint-config-qx) and lint the framework.\r\n\r\nFirst I've run:\r\n\r\n```bash\r\nfind . -type f -iname '*.js' | xargs perl -0777 -i.original -pe 's/qx.Class.define\\((.*),\\s*\\n\\{/qx.Class.define($1, {/mg' {}\r\n```\r\n\r\nto make all qx.Class.define open curly braces on the same line.\r\n\r\nThen I've linted: qx.application.*.\r\n\r\nI'll lint the whole code if everyone is ok with that style.\r\n\r\nSigned-off-by: Rene Jochum <rene@jochums.at>"},"comment":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/comments/244220730","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9147#issuecomment-244220730","issue_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9147","id":244220730,"user":{"login":"thron7","id":885920,"avatar_url":"https://avatars.githubusercontent.com/u/885920?v=3","gravatar_id":"","url":"https://api.github.com/users/thron7","html_url":"https://github.com/thron7","followers_url":"https://api.github.com/users/thron7/followers","following_url":"https://api.github.com/users/thron7/following{/other_user}","gists_url":"https://api.github.com/users/thron7/gists{/gist_id}","starred_url":"https://api.github.com/users/thron7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thron7/subscriptions","organizations_url":"https://api.github.com/users/thron7/orgs","repos_url":"https://api.github.com/users/thron7/repos","events_url":"https://api.github.com/users/thron7/events{/privacy}","received_events_url":"https://api.github.com/users/thron7/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T21:37:33Z","updated_at":"2016-09-01T21:37:33Z","body":"I'm certain there are useful things eslint can do above generate.py lint. And, without looking at it, there is probably a good way to teach eslint new things that are useful for qooxdoo. I was the one to push for replacing Python with JS, years before it was actually started. What I find difficult, though, is not analyzing requirements carefully when going forward. And since the project has been transferred to the community there is a bit of a tendency to ignore existing things rather than to learn from them.\r\n\r\nAnd no, the framework itself was hardly maintained using automatic tools. It was all carefully hand-crafted, a labor of love :-)."}}
{"actor":{"display_login":"thron7"}}