{"action":"created","issue":{"url":"https://api.github.com/repos/lkl/linux/issues/189","repository_url":"https://api.github.com/repos/lkl/linux","labels_url":"https://api.github.com/repos/lkl/linux/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/lkl/linux/issues/189/comments","events_url":"https://api.github.com/repos/lkl/linux/issues/189/events","html_url":"https://github.com/lkl/linux/pull/189","id":169196776,"number":189,"title":"Add test for tap offloading","user":{"login":"liuyuan10","id":4546386,"avatar_url":"https://avatars.githubusercontent.com/u/4546386?v=3","gravatar_id":"","url":"https://api.github.com/users/liuyuan10","html_url":"https://github.com/liuyuan10","followers_url":"https://api.github.com/users/liuyuan10/followers","following_url":"https://api.github.com/users/liuyuan10/following{/other_user}","gists_url":"https://api.github.com/users/liuyuan10/gists{/gist_id}","starred_url":"https://api.github.com/users/liuyuan10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuyuan10/subscriptions","organizations_url":"https://api.github.com/users/liuyuan10/orgs","repos_url":"https://api.github.com/users/liuyuan10/repos","events_url":"https://api.github.com/users/liuyuan10/events{/privacy}","received_events_url":"https://api.github.com/users/liuyuan10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-03T18:11:50Z","updated_at":"2016-08-03T18:19:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lkl/linux/pulls/189","html_url":"https://github.com/lkl/linux/pull/189","diff_url":"https://github.com/lkl/linux/pull/189.diff","patch_url":"https://github.com/lkl/linux/pull/189.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/lkl/linux/189)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/lkl/linux/issues/comments/237323423","html_url":"https://github.com/lkl/linux/pull/189#issuecomment-237323423","issue_url":"https://api.github.com/repos/lkl/linux/issues/189","id":237323423,"user":{"login":"opurdila","id":16593486,"avatar_url":"https://avatars.githubusercontent.com/u/16593486?v=3","gravatar_id":"","url":"https://api.github.com/users/opurdila","html_url":"https://github.com/opurdila","followers_url":"https://api.github.com/users/opurdila/followers","following_url":"https://api.github.com/users/opurdila/following{/other_user}","gists_url":"https://api.github.com/users/opurdila/gists{/gist_id}","starred_url":"https://api.github.com/users/opurdila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opurdila/subscriptions","organizations_url":"https://api.github.com/users/opurdila/orgs","repos_url":"https://api.github.com/users/opurdila/repos","events_url":"https://api.github.com/users/opurdila/events{/privacy}","received_events_url":"https://api.github.com/users/opurdila/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T18:19:31Z","updated_at":"2016-08-03T18:19:31Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReviewed 3 of 3 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[tools/lkl/tests/hijack-test.sh, line 106 \\[r1\\]](https://reviewable.io:443/reviews/lkl/linux/189#-KOGc9BzjozY02OOJXe4:-KOGc9BzjozY02OOJXe5:-40785944) ([raw file](https://github.com/lkl/linux/blob/ddf318c6813a4de7572d7df6754e907be16e6747/tools/lkl/tests/hijack-test.sh#L106)):*\n> ```Shell\n> # LKL_VIRTIO_NET_F_HOST_TSO4 && LKL_VIRTIO_NET_F_GUEST_TSO4\n> # LKL_VIRTIO_NET_F_CSUM && LKL_VIRTIO_NET_F_GUEST_CSUM\n> LKL_HIJACK_OFFLOAD=0x883 sh ${script_dir}/run_netperf.sh 192.168.13.1 1 0 TCP_STREAM\n> ```\n\nNot something for this PR, but it would be great if we can also verify the numbers that netperf produces and put a conservative low limit, to easily identify regressions by CircleCI.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/lkl/linux/189#-:-KOGcQYHpY5I-TQz1sW8:1417088721)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"opurdila"}}