{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/68207642","id":68207642,"diff_hunk":"@@ -306,11 +306,39 @@ public function testThatCloningIsNotSupported()\n         $this->assertFalse($class->isCloneable());\n         $this->assertTrue($clone->isPrivate());\n     }\n+\n+    /** @group legacy */\n+    public function testUnsetInternalPrivateServiceIsDeprecated()\n+    {\n+        $c = new ProjectServiceContainer();\n+        $c->set('internal', null);","path":"src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php","position":18,"original_position":18,"commit_id":"9af32f882f9ceeb31a637c5aab4420c491a5b20a","original_commit_id":"9af32f882f9ceeb31a637c5aab4420c491a5b20a","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"See #18880","created_at":"2016-06-23T10:01:11Z","updated_at":"2016-06-23T10:01:11Z","html_url":"https://github.com/symfony/symfony/pull/19146#discussion_r68207642","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/19146","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/68207642"},"html":{"href":"https://github.com/symfony/symfony/pull/19146#discussion_r68207642"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19146"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19146","id":74848333,"html_url":"https://github.com/symfony/symfony/pull/19146","diff_url":"https://github.com/symfony/symfony/pull/19146.diff","patch_url":"https://github.com/symfony/symfony/pull/19146.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19146","number":19146,"state":"open","locked":false,"title":"[WIP] [DependencyInjection] deprecate access to private shared services.","user":{"login":"hhamon","id":235550,"avatar_url":"https://avatars.githubusercontent.com/u/235550?v=3","gravatar_id":"","url":"https://api.github.com/users/hhamon","html_url":"https://github.com/hhamon","followers_url":"https://api.github.com/users/hhamon/followers","following_url":"https://api.github.com/users/hhamon/following{/other_user}","gists_url":"https://api.github.com/users/hhamon/gists{/gist_id}","starred_url":"https://api.github.com/users/hhamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhamon/subscriptions","organizations_url":"https://api.github.com/users/hhamon/orgs","repos_url":"https://api.github.com/users/hhamon/repos","events_url":"https://api.github.com/users/hhamon/events{/privacy}","received_events_url":"https://api.github.com/users/hhamon/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | no\r\n| Fixed tickets | #19117 \r\n| License       | MIT\r\n| Doc PR        | ~\r\n","created_at":"2016-06-22T20:08:37Z","updated_at":"2016-06-23T10:01:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abca2b041ef16b183da6b13abe39482679d6d8a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19146/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19146/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19146/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/9af32f882f9ceeb31a637c5aab4420c491a5b20a","head":{"label":"hhamon:private-services-fix","ref":"private-services-fix","sha":"9af32f882f9ceeb31a637c5aab4420c491a5b20a","user":{"login":"hhamon","id":235550,"avatar_url":"https://avatars.githubusercontent.com/u/235550?v=3","gravatar_id":"","url":"https://api.github.com/users/hhamon","html_url":"https://github.com/hhamon","followers_url":"https://api.github.com/users/hhamon/followers","following_url":"https://api.github.com/users/hhamon/following{/other_user}","gists_url":"https://api.github.com/users/hhamon/gists{/gist_id}","starred_url":"https://api.github.com/users/hhamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhamon/subscriptions","organizations_url":"https://api.github.com/users/hhamon/orgs","repos_url":"https://api.github.com/users/hhamon/repos","events_url":"https://api.github.com/users/hhamon/events{/privacy}","received_events_url":"https://api.github.com/users/hhamon/received_events","type":"User","site_admin":false},"repo":{"id":1434974,"name":"symfony","full_name":"hhamon/symfony","owner":{"login":"hhamon","id":235550,"avatar_url":"https://avatars.githubusercontent.com/u/235550?v=3","gravatar_id":"","url":"https://api.github.com/users/hhamon","html_url":"https://github.com/hhamon","followers_url":"https://api.github.com/users/hhamon/followers","following_url":"https://api.github.com/users/hhamon/following{/other_user}","gists_url":"https://api.github.com/users/hhamon/gists{/gist_id}","starred_url":"https://api.github.com/users/hhamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhamon/subscriptions","organizations_url":"https://api.github.com/users/hhamon/orgs","repos_url":"https://api.github.com/users/hhamon/repos","events_url":"https://api.github.com/users/hhamon/events{/privacy}","received_events_url":"https://api.github.com/users/hhamon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhamon/symfony","description":"The Symfony2 PHP framework (PHP 5.3 only -- not yet stable) -- documentation for master is at http://symfony.com/doc/2.0","fork":true,"url":"https://api.github.com/repos/hhamon/symfony","forks_url":"https://api.github.com/repos/hhamon/symfony/forks","keys_url":"https://api.github.com/repos/hhamon/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhamon/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhamon/symfony/teams","hooks_url":"https://api.github.com/repos/hhamon/symfony/hooks","issue_events_url":"https://api.github.com/repos/hhamon/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/hhamon/symfony/events","assignees_url":"https://api.github.com/repos/hhamon/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/hhamon/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/hhamon/symfony/tags","blobs_url":"https://api.github.com/repos/hhamon/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhamon/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhamon/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhamon/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhamon/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/hhamon/symfony/languages","stargazers_url":"https://api.github.com/repos/hhamon/symfony/stargazers","contributors_url":"https://api.github.com/repos/hhamon/symfony/contributors","subscribers_url":"https://api.github.com/repos/hhamon/symfony/subscribers","subscription_url":"https://api.github.com/repos/hhamon/symfony/subscription","commits_url":"https://api.github.com/repos/hhamon/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhamon/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhamon/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhamon/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhamon/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/hhamon/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhamon/symfony/merges","archive_url":"https://api.github.com/repos/hhamon/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhamon/symfony/downloads","issues_url":"https://api.github.com/repos/hhamon/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/hhamon/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/hhamon/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/hhamon/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhamon/symfony/labels{/name}","releases_url":"https://api.github.com/repos/hhamon/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/hhamon/symfony/deployments","created_at":"2011-03-03T13:09:35Z","updated_at":"2015-04-18T07:52:05Z","pushed_at":"2016-06-22T20:23:28Z","git_url":"git://github.com/hhamon/symfony.git","ssh_url":"git@github.com:hhamon/symfony.git","clone_url":"https://github.com/hhamon/symfony.git","svn_url":"https://github.com/hhamon/symfony","homepage":"http://symfony.com","size":72771,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"1298ce51cb08b6cf780784056e723fd542db84cc","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-06-22T20:12:17Z","pushed_at":"2016-06-23T09:32:32Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":134074,"stargazers_count":12535,"watchers_count":12535,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4896,"mirror_url":null,"open_issues_count":682,"forks":4896,"open_issues":682,"watchers":12535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19146"},"html":{"href":"https://github.com/symfony/symfony/pull/19146"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19146"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19146/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19146/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19146/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/9af32f882f9ceeb31a637c5aab4420c491a5b20a"}}}}
{"actor":{"display_login":"nicolas-grekas"}}