{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5200","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5200/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5200/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5200/events","html_url":"https://github.com/Automattic/wp-calypso/pull/5200","id":152897158,"number":5200,"title":"WIP: Add/instagram shortcode wizard","user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars.githubusercontent.com/u/5431237?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Editor","name":"Editor","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Plans","name":"Plans","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20In%20Progress","name":"[Status] In Progress","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/85","html_url":"https://github.com/Automattic/wp-calypso/milestones/Plans:%20Iteration%202","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/85/labels","id":1743970,"number":85,"title":"Plans: Iteration 2","description":"","creator":{"login":"rralian","id":134044,"avatar_url":"https://avatars.githubusercontent.com/u/134044?v=3","gravatar_id":"","url":"https://api.github.com/users/rralian","html_url":"https://github.com/rralian","followers_url":"https://api.github.com/users/rralian/followers","following_url":"https://api.github.com/users/rralian/following{/other_user}","gists_url":"https://api.github.com/users/rralian/gists{/gist_id}","starred_url":"https://api.github.com/users/rralian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rralian/subscriptions","organizations_url":"https://api.github.com/users/rralian/orgs","repos_url":"https://api.github.com/users/rralian/repos","events_url":"https://api.github.com/users/rralian/events{/privacy}","received_events_url":"https://api.github.com/users/rralian/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":7,"state":"open","created_at":"2016-05-03T03:49:33Z","updated_at":"2016-05-04T19:03:44Z","due_on":"2016-05-31T05:00:00Z","closed_at":null},"comments":3,"created_at":"2016-05-03T23:26:46Z","updated_at":"2016-05-04T19:43:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/5200","html_url":"https://github.com/Automattic/wp-calypso/pull/5200","diff_url":"https://github.com/Automattic/wp-calypso/pull/5200.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/5200.patch"},"body":"Follows #5070 and #5071 \r\n\r\nRelated: #1729\r\n\r\nThis PR is mainly about the new shortcode wizard infrastructure being added to the editor. It includes an Instagram shortcode \"wizard\" as a demonstration of how to hook into the _plugin generator_.\r\n\r\nThe purpose of this new code is to enable creating a series of wizard-style modals for the editor without needing to mix a bunch of TinyMCE-specific code into them.\r\n\r\nAs this is still a work-in-progress and a demonstration PR, **please ignore the ugly button on the left side of the TinyMCE toolbar**. It depends on #5071 and will end up being a menu item on the dropdown in there.\r\n\r\n**Questions**\r\n - [ ] How can we get the shortcode to be replaced by the embedded area and then provide the hover/tap edit/delete buttons?\r\n - [ ] Is the given API robust enough for the types of embeds/widgets/shortcodes we want to create?\r\n - [ ] Is the level of modularity/separation of concerns appropriate for the tasks at hand? As designed, the wizard modals can be tested in isolation without mocking.\r\n\r\n**Testing**\r\nOpen the editor and try to mess around with the new embed. Please look at the code and suggest any recommendations you might have.\r\n\r\nThanks!\r\n\r\ncc: @rodrigoi @aduth @blowery "},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/216979668","html_url":"https://github.com/Automattic/wp-calypso/pull/5200#issuecomment-216979668","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5200","id":216979668,"user":{"login":"rodrigoi","id":233601,"avatar_url":"https://avatars.githubusercontent.com/u/233601?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigoi","html_url":"https://github.com/rodrigoi","followers_url":"https://api.github.com/users/rodrigoi/followers","following_url":"https://api.github.com/users/rodrigoi/following{/other_user}","gists_url":"https://api.github.com/users/rodrigoi/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigoi/subscriptions","organizations_url":"https://api.github.com/users/rodrigoi/orgs","repos_url":"https://api.github.com/users/rodrigoi/repos","events_url":"https://api.github.com/users/rodrigoi/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigoi/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T19:43:10Z","updated_at":"2016-05-04T19:43:10Z","body":"I have more of a philosophical question. How is the better than the current experience?\r\n\r\n![instagram](https://cloud.githubusercontent.com/assets/233601/15026765/664c7e5a-1216-11e6-93e5-7be5a9310970.png)\r\n\r\nIf you pase a instagram url (or facebook, twitter or tumblr) this component kicks in and renders the embed: https://github.com/Automattic/wp-calypso/blob/master/client/components/embed-container/index.jsx\r\n\r\nThis is not documented, nor is it intuitive (it's buried on the [WordPress.com support](https://en.support.wordpress.com/instagram/instagram-images/)) but I think that the experience is far better than using a dialog window."}}