{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8960","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8960/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8960/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8960/events","html_url":"https://github.com/nodejs/node/pull/8960","id":181509874,"number":8960,"title":"test: add coverage for spawnSync() killSignal","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/child_process","name":"child_process","color":"f7c6c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-06T19:54:26Z","updated_at":"2016-10-10T14:40:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8960","html_url":"https://github.com/nodejs/node/pull/8960","diff_url":"https://github.com/nodejs/node/pull/8960.diff","patch_url":"https://github.com/nodejs/node/pull/8960.patch"},"body":"##### Checklist\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ntest\r\n\r\n##### Description of change\r\nThis commit adds a test for the `killSignal` option to `spawnSync()`, and the other sync child process functions by extension.\r\n\r\nThis was previously untested according to https://node-core-coverage.addaleax.net/"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/252641064","html_url":"https://github.com/nodejs/node/pull/8960#issuecomment-252641064","issue_url":"https://api.github.com/repos/nodejs/node/issues/8960","id":252641064,"user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T14:40:17Z","updated_at":"2016-10-10T14:40:17Z","body":"CI with the suggestion incorporated: https://ci.nodejs.org/job/node-test-pull-request/4445/"}}
{"actor":{"display_login":"cjihrig"}}