{"action":"created","comment":{"url":"https://api.github.com/repos/linzjs/linz/pulls/comments/66179759","id":66179759,"diff_hunk":"@@ -137,3 +137,20 @@ exports.noOp = function (_cb) {\n \t}\n \n };\n+\n+/**\n+ * Return true if object is empty else false\n+ * @param {Object} obj   Object to be tested if it is empty or not\n+ * @return {Bollean}\n+ */\n+exports.isEmptyObject = function (obj) {","path":"lib/utils.js","position":10,"original_position":10,"commit_id":"6e4d79e680f5419d0000f83ddaf1f75bd5a35e7a","original_commit_id":"6e4d79e680f5419d0000f83ddaf1f75bd5a35e7a","user":{"login":"sandytrinh","id":3323860,"avatar_url":"https://avatars.githubusercontent.com/u/3323860?v=3","gravatar_id":"","url":"https://api.github.com/users/sandytrinh","html_url":"https://github.com/sandytrinh","followers_url":"https://api.github.com/users/sandytrinh/followers","following_url":"https://api.github.com/users/sandytrinh/following{/other_user}","gists_url":"https://api.github.com/users/sandytrinh/gists{/gist_id}","starred_url":"https://api.github.com/users/sandytrinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandytrinh/subscriptions","organizations_url":"https://api.github.com/users/sandytrinh/orgs","repos_url":"https://api.github.com/users/sandytrinh/repos","events_url":"https://api.github.com/users/sandytrinh/events{/privacy}","received_events_url":"https://api.github.com/users/sandytrinh/received_events","type":"User","site_admin":false},"body":"Not sure why you need this function, we normally use `Object.keys(obj).length` to determine is an object has any keys.","created_at":"2016-06-08T01:12:27Z","updated_at":"2016-06-08T01:12:27Z","html_url":"https://github.com/linzjs/linz/pull/102#discussion_r66179759","pull_request_url":"https://api.github.com/repos/linzjs/linz/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/linzjs/linz/pulls/comments/66179759"},"html":{"href":"https://github.com/linzjs/linz/pull/102#discussion_r66179759"},"pull_request":{"href":"https://api.github.com/repos/linzjs/linz/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/linzjs/linz/pulls/102","id":71675590,"html_url":"https://github.com/linzjs/linz/pull/102","diff_url":"https://github.com/linzjs/linz/pull/102.diff","patch_url":"https://github.com/linzjs/linz/pull/102.patch","issue_url":"https://api.github.com/repos/linzjs/linz/issues/102","number":102,"state":"open","locked":false,"title":"Make Overview ui look like Edit UI and render Tabs  ","user":{"login":"patelswapnil","id":12613138,"avatar_url":"https://avatars.githubusercontent.com/u/12613138?v=3","gravatar_id":"","url":"https://api.github.com/users/patelswapnil","html_url":"https://github.com/patelswapnil","followers_url":"https://api.github.com/users/patelswapnil/followers","following_url":"https://api.github.com/users/patelswapnil/following{/other_user}","gists_url":"https://api.github.com/users/patelswapnil/gists{/gist_id}","starred_url":"https://api.github.com/users/patelswapnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patelswapnil/subscriptions","organizations_url":"https://api.github.com/users/patelswapnil/orgs","repos_url":"https://api.github.com/users/patelswapnil/repos","events_url":"https://api.github.com/users/patelswapnil/events{/privacy}","received_events_url":"https://api.github.com/users/patelswapnil/received_events","type":"User","site_admin":false},"body":"This PR completes following user story:\r\n[chas-40] (https://flashmedia.atlassian.net/browse/CHAS-40)\r\n\r\n### Set up\r\n -  Checkout `overview-ui` branch of `Linz` and make your local `chasis` project to use this branch of linz on your host\r\n\r\n - Add following code to `rasMember.js` file located at `chasis > app > root > app > models`:\r\n\r\n```\r\ndetails: {\r\n    fields: [\r\n        'businessName', 'code', 'type', 'bActive'\r\n    ],\r\n    tabs: [\r\n        {\r\n            label: 'Details',\r\n            fields: [\r\n                'bHasConsumerWebsite', 'slug', 'address1', 'address2', 'suburb', 'state', 'postcode', 'loc'\r\n            ]\r\n        },\r\n        {\r\n            label: 'Services',\r\n            fields: [\r\n                'specialistServices'\r\n            ]\r\n        },\r\n        {\r\n            label: 'Custom',\r\n            body: function (rq, rs, record, model, cb) {\r\n                return cb(null, '<p>Testing Custom tab</p>');\r\n            }\r\n        }\r\n    ]\r\n}\r\n```\r\n\r\n### To Verify\r\n - [ ] browse to `https://chassis.repcoservice.local` on your host machine\r\n - [ ] go to members list and click on edit link of any member from the list\r\n - [ ] once you are on the edit page, change the last bit of the url from `edit` to `overview` and enter to render overview page of the member\r\n - [ ] make sure `Member details`  and `four tabs`are rendered after Summary details as set in the `rasMember.js` file in the model in chasis \r\n - [ ] make sure each tab works and appropriate content is displayed under each tab\r\n - [ ] remove the `details` added to the `rasMember.js` file in the model in chassis and refresh the member's overview page. Now, overview page should render only summary\r\n - [ ] Test the Overview UI with empty details, details containing only filed, details containing only tabs. The Overview UI should contain only summary, summary and fields and summary and tabs respectively\r\n - [ ] pass non existing filed names to fields in details. The Overview UI should only render the valid form fields.\r\n\r\n__NOTE:__ Remember to undo changes made in your local branch of `chasis` after this PR has been reviewed. ","created_at":"2016-05-27T08:12:07Z","updated_at":"2016-06-08T01:12:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8bc69d19b20746863b2011b95aca2c6e873b74d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linzjs/linz/pulls/102/commits","review_comments_url":"https://api.github.com/repos/linzjs/linz/pulls/102/comments","review_comment_url":"https://api.github.com/repos/linzjs/linz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linzjs/linz/issues/102/comments","statuses_url":"https://api.github.com/repos/linzjs/linz/statuses/6e4d79e680f5419d0000f83ddaf1f75bd5a35e7a","head":{"label":"linzjs:overview-ui","ref":"overview-ui","sha":"6e4d79e680f5419d0000f83ddaf1f75bd5a35e7a","user":{"login":"linzjs","id":11432541,"avatar_url":"https://avatars.githubusercontent.com/u/11432541?v=3","gravatar_id":"","url":"https://api.github.com/users/linzjs","html_url":"https://github.com/linzjs","followers_url":"https://api.github.com/users/linzjs/followers","following_url":"https://api.github.com/users/linzjs/following{/other_user}","gists_url":"https://api.github.com/users/linzjs/gists{/gist_id}","starred_url":"https://api.github.com/users/linzjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linzjs/subscriptions","organizations_url":"https://api.github.com/users/linzjs/orgs","repos_url":"https://api.github.com/users/linzjs/repos","events_url":"https://api.github.com/users/linzjs/events{/privacy}","received_events_url":"https://api.github.com/users/linzjs/received_events","type":"Organization","site_admin":false},"repo":{"id":12881781,"name":"linz","full_name":"linzjs/linz","owner":{"login":"linzjs","id":11432541,"avatar_url":"https://avatars.githubusercontent.com/u/11432541?v=3","gravatar_id":"","url":"https://api.github.com/users/linzjs","html_url":"https://github.com/linzjs","followers_url":"https://api.github.com/users/linzjs/followers","following_url":"https://api.github.com/users/linzjs/following{/other_user}","gists_url":"https://api.github.com/users/linzjs/gists{/gist_id}","starred_url":"https://api.github.com/users/linzjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linzjs/subscriptions","organizations_url":"https://api.github.com/users/linzjs/orgs","repos_url":"https://api.github.com/users/linzjs/repos","events_url":"https://api.github.com/users/linzjs/events{/privacy}","received_events_url":"https://api.github.com/users/linzjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linzjs/linz","description":"NodeJS Content Management System","fork":false,"url":"https://api.github.com/repos/linzjs/linz","forks_url":"https://api.github.com/repos/linzjs/linz/forks","keys_url":"https://api.github.com/repos/linzjs/linz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linzjs/linz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linzjs/linz/teams","hooks_url":"https://api.github.com/repos/linzjs/linz/hooks","issue_events_url":"https://api.github.com/repos/linzjs/linz/issues/events{/number}","events_url":"https://api.github.com/repos/linzjs/linz/events","assignees_url":"https://api.github.com/repos/linzjs/linz/assignees{/user}","branches_url":"https://api.github.com/repos/linzjs/linz/branches{/branch}","tags_url":"https://api.github.com/repos/linzjs/linz/tags","blobs_url":"https://api.github.com/repos/linzjs/linz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linzjs/linz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linzjs/linz/git/refs{/sha}","trees_url":"https://api.github.com/repos/linzjs/linz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linzjs/linz/statuses/{sha}","languages_url":"https://api.github.com/repos/linzjs/linz/languages","stargazers_url":"https://api.github.com/repos/linzjs/linz/stargazers","contributors_url":"https://api.github.com/repos/linzjs/linz/contributors","subscribers_url":"https://api.github.com/repos/linzjs/linz/subscribers","subscription_url":"https://api.github.com/repos/linzjs/linz/subscription","commits_url":"https://api.github.com/repos/linzjs/linz/commits{/sha}","git_commits_url":"https://api.github.com/repos/linzjs/linz/git/commits{/sha}","comments_url":"https://api.github.com/repos/linzjs/linz/comments{/number}","issue_comment_url":"https://api.github.com/repos/linzjs/linz/issues/comments{/number}","contents_url":"https://api.github.com/repos/linzjs/linz/contents/{+path}","compare_url":"https://api.github.com/repos/linzjs/linz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linzjs/linz/merges","archive_url":"https://api.github.com/repos/linzjs/linz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linzjs/linz/downloads","issues_url":"https://api.github.com/repos/linzjs/linz/issues{/number}","pulls_url":"https://api.github.com/repos/linzjs/linz/pulls{/number}","milestones_url":"https://api.github.com/repos/linzjs/linz/milestones{/number}","notifications_url":"https://api.github.com/repos/linzjs/linz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linzjs/linz/labels{/name}","releases_url":"https://api.github.com/repos/linzjs/linz/releases{/id}","deployments_url":"https://api.github.com/repos/linzjs/linz/deployments","created_at":"2013-09-16T23:56:05Z","updated_at":"2016-04-04T05:17:27Z","pushed_at":"2016-06-08T00:52:13Z","git_url":"git://github.com/linzjs/linz.git","ssh_url":"git@github.com:linzjs/linz.git","clone_url":"https://github.com/linzjs/linz.git","svn_url":"https://github.com/linzjs/linz","homepage":null,"size":2010,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":28,"forks":1,"open_issues":28,"watchers":2,"default_branch":"master"}},"base":{"label":"linzjs:master","ref":"master","sha":"42a8a3c2c4a5e852ff13d36ce202134621694e76","user":{"login":"linzjs","id":11432541,"avatar_url":"https://avatars.githubusercontent.com/u/11432541?v=3","gravatar_id":"","url":"https://api.github.com/users/linzjs","html_url":"https://github.com/linzjs","followers_url":"https://api.github.com/users/linzjs/followers","following_url":"https://api.github.com/users/linzjs/following{/other_user}","gists_url":"https://api.github.com/users/linzjs/gists{/gist_id}","starred_url":"https://api.github.com/users/linzjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linzjs/subscriptions","organizations_url":"https://api.github.com/users/linzjs/orgs","repos_url":"https://api.github.com/users/linzjs/repos","events_url":"https://api.github.com/users/linzjs/events{/privacy}","received_events_url":"https://api.github.com/users/linzjs/received_events","type":"Organization","site_admin":false},"repo":{"id":12881781,"name":"linz","full_name":"linzjs/linz","owner":{"login":"linzjs","id":11432541,"avatar_url":"https://avatars.githubusercontent.com/u/11432541?v=3","gravatar_id":"","url":"https://api.github.com/users/linzjs","html_url":"https://github.com/linzjs","followers_url":"https://api.github.com/users/linzjs/followers","following_url":"https://api.github.com/users/linzjs/following{/other_user}","gists_url":"https://api.github.com/users/linzjs/gists{/gist_id}","starred_url":"https://api.github.com/users/linzjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linzjs/subscriptions","organizations_url":"https://api.github.com/users/linzjs/orgs","repos_url":"https://api.github.com/users/linzjs/repos","events_url":"https://api.github.com/users/linzjs/events{/privacy}","received_events_url":"https://api.github.com/users/linzjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linzjs/linz","description":"NodeJS Content Management System","fork":false,"url":"https://api.github.com/repos/linzjs/linz","forks_url":"https://api.github.com/repos/linzjs/linz/forks","keys_url":"https://api.github.com/repos/linzjs/linz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linzjs/linz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linzjs/linz/teams","hooks_url":"https://api.github.com/repos/linzjs/linz/hooks","issue_events_url":"https://api.github.com/repos/linzjs/linz/issues/events{/number}","events_url":"https://api.github.com/repos/linzjs/linz/events","assignees_url":"https://api.github.com/repos/linzjs/linz/assignees{/user}","branches_url":"https://api.github.com/repos/linzjs/linz/branches{/branch}","tags_url":"https://api.github.com/repos/linzjs/linz/tags","blobs_url":"https://api.github.com/repos/linzjs/linz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linzjs/linz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linzjs/linz/git/refs{/sha}","trees_url":"https://api.github.com/repos/linzjs/linz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linzjs/linz/statuses/{sha}","languages_url":"https://api.github.com/repos/linzjs/linz/languages","stargazers_url":"https://api.github.com/repos/linzjs/linz/stargazers","contributors_url":"https://api.github.com/repos/linzjs/linz/contributors","subscribers_url":"https://api.github.com/repos/linzjs/linz/subscribers","subscription_url":"https://api.github.com/repos/linzjs/linz/subscription","commits_url":"https://api.github.com/repos/linzjs/linz/commits{/sha}","git_commits_url":"https://api.github.com/repos/linzjs/linz/git/commits{/sha}","comments_url":"https://api.github.com/repos/linzjs/linz/comments{/number}","issue_comment_url":"https://api.github.com/repos/linzjs/linz/issues/comments{/number}","contents_url":"https://api.github.com/repos/linzjs/linz/contents/{+path}","compare_url":"https://api.github.com/repos/linzjs/linz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linzjs/linz/merges","archive_url":"https://api.github.com/repos/linzjs/linz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linzjs/linz/downloads","issues_url":"https://api.github.com/repos/linzjs/linz/issues{/number}","pulls_url":"https://api.github.com/repos/linzjs/linz/pulls{/number}","milestones_url":"https://api.github.com/repos/linzjs/linz/milestones{/number}","notifications_url":"https://api.github.com/repos/linzjs/linz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linzjs/linz/labels{/name}","releases_url":"https://api.github.com/repos/linzjs/linz/releases{/id}","deployments_url":"https://api.github.com/repos/linzjs/linz/deployments","created_at":"2013-09-16T23:56:05Z","updated_at":"2016-04-04T05:17:27Z","pushed_at":"2016-06-08T00:52:13Z","git_url":"git://github.com/linzjs/linz.git","ssh_url":"git@github.com:linzjs/linz.git","clone_url":"https://github.com/linzjs/linz.git","svn_url":"https://github.com/linzjs/linz","homepage":null,"size":2010,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":28,"forks":1,"open_issues":28,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linzjs/linz/pulls/102"},"html":{"href":"https://github.com/linzjs/linz/pull/102"},"issue":{"href":"https://api.github.com/repos/linzjs/linz/issues/102"},"comments":{"href":"https://api.github.com/repos/linzjs/linz/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/linzjs/linz/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/linzjs/linz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linzjs/linz/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/linzjs/linz/statuses/6e4d79e680f5419d0000f83ddaf1f75bd5a35e7a"}}}}
{"actor":{"display_login":"sandytrinh"}}