{"action":"created","issue":{"url":"https://api.github.com/repos/SilenceIM/Silence/issues/390","repository_url":"https://api.github.com/repos/SilenceIM/Silence","labels_url":"https://api.github.com/repos/SilenceIM/Silence/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/SilenceIM/Silence/issues/390/comments","events_url":"https://api.github.com/repos/SilenceIM/Silence/issues/390/events","html_url":"https://github.com/SilenceIM/Silence/pull/390","id":151362754,"number":390,"title":"Add XMPP transport support","user":{"login":"BastienLQ","id":7220484,"avatar_url":"https://avatars.githubusercontent.com/u/7220484?v=3","gravatar_id":"","url":"https://api.github.com/users/BastienLQ","html_url":"https://github.com/BastienLQ","followers_url":"https://api.github.com/users/BastienLQ/followers","following_url":"https://api.github.com/users/BastienLQ/following{/other_user}","gists_url":"https://api.github.com/users/BastienLQ/gists{/gist_id}","starred_url":"https://api.github.com/users/BastienLQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BastienLQ/subscriptions","organizations_url":"https://api.github.com/users/BastienLQ/orgs","repos_url":"https://api.github.com/users/BastienLQ/repos","events_url":"https://api.github.com/users/BastienLQ/events{/privacy}","received_events_url":"https://api.github.com/users/BastienLQ/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SilenceIM/Silence/labels/work%20in%20progress","name":"work in progress","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"BastienLQ","id":7220484,"avatar_url":"https://avatars.githubusercontent.com/u/7220484?v=3","gravatar_id":"","url":"https://api.github.com/users/BastienLQ","html_url":"https://github.com/BastienLQ","followers_url":"https://api.github.com/users/BastienLQ/followers","following_url":"https://api.github.com/users/BastienLQ/following{/other_user}","gists_url":"https://api.github.com/users/BastienLQ/gists{/gist_id}","starred_url":"https://api.github.com/users/BastienLQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BastienLQ/subscriptions","organizations_url":"https://api.github.com/users/BastienLQ/orgs","repos_url":"https://api.github.com/users/BastienLQ/repos","events_url":"https://api.github.com/users/BastienLQ/events{/privacy}","received_events_url":"https://api.github.com/users/BastienLQ/received_events","type":"User","site_admin":false},"assignees":[{"login":"BastienLQ","id":7220484,"avatar_url":"https://avatars.githubusercontent.com/u/7220484?v=3","gravatar_id":"","url":"https://api.github.com/users/BastienLQ","html_url":"https://github.com/BastienLQ","followers_url":"https://api.github.com/users/BastienLQ/followers","following_url":"https://api.github.com/users/BastienLQ/following{/other_user}","gists_url":"https://api.github.com/users/BastienLQ/gists{/gist_id}","starred_url":"https://api.github.com/users/BastienLQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BastienLQ/subscriptions","organizations_url":"https://api.github.com/users/BastienLQ/orgs","repos_url":"https://api.github.com/users/BastienLQ/repos","events_url":"https://api.github.com/users/BastienLQ/events{/privacy}","received_events_url":"https://api.github.com/users/BastienLQ/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2016-04-27T11:28:12Z","updated_at":"2016-07-14T09:49:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SilenceIM/Silence/pulls/390","html_url":"https://github.com/SilenceIM/Silence/pull/390","diff_url":"https://github.com/SilenceIM/Silence/pull/390.diff","patch_url":"https://github.com/SilenceIM/Silence/pull/390.patch"},"body":"This PR adds XMPP transport to send secure messages only.\r\n\r\nTODO/Features:\r\n- [x] Add XMPP page into intro screen\r\n- [x] Add new \"XMPP address\" message type to do not use a centralized directory\r\n- [x] Add new XMPP message type when transport is set to XMPP\r\n- [x] Switch to secure SMS if the recipient is offline\r\n- [ ] Improve XMPP address sharing mecanism\r\n- [ ] Include a list of trusted XMPP servers to allow users to register\r\n- [x] Allow user to use a custom XMPP server\r\n- [x] Display a warning if the custom XMPP server doesn't support XEP-0198 Stream Management (required to do not lost messages when switching from a network to another or on unreliable connectivities)\r\n- [x] Fix bad encryption with long XMPP messages\r\n- [ ] Fix recipient status (sometime a recipient is seen as offline but it is actually online)\r\n- [ ] Add support for XMPP media messages (for now, Silence crashes)\r\n- [ ] Write documentation\r\n- [ ] Delete XMPP account if the user disables XMPP feature\r\n- [ ] Implement a form to manually set up an XMPP address\r\n- [x] Ask the user to optionally set up XMPP on first boot\r\n- [x] Display an XMPP icon for XMPP messages\r\n\r\nThis PR fixes #370 as a side effect because it starts Silence on boot.\r\nFor now, the list of \"trusted XMPP servers\" only contains xmpp.silence.im, which is not designed to be used except for testing. We won't host an XMPP server in the short term.\r\n\r\nThis is **not** OMEMO."},"comment":{"url":"https://api.github.com/repos/SilenceIM/Silence/issues/comments/232619219","html_url":"https://github.com/SilenceIM/Silence/pull/390#issuecomment-232619219","issue_url":"https://api.github.com/repos/SilenceIM/Silence/issues/390","id":232619219,"user":{"login":"doodhout","id":10937516,"avatar_url":"https://avatars.githubusercontent.com/u/10937516?v=3","gravatar_id":"","url":"https://api.github.com/users/doodhout","html_url":"https://github.com/doodhout","followers_url":"https://api.github.com/users/doodhout/followers","following_url":"https://api.github.com/users/doodhout/following{/other_user}","gists_url":"https://api.github.com/users/doodhout/gists{/gist_id}","starred_url":"https://api.github.com/users/doodhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doodhout/subscriptions","organizations_url":"https://api.github.com/users/doodhout/orgs","repos_url":"https://api.github.com/users/doodhout/repos","events_url":"https://api.github.com/users/doodhout/events{/privacy}","received_events_url":"https://api.github.com/users/doodhout/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T09:49:10Z","updated_at":"2016-07-14T09:49:10Z","body":"> @doodhout, unfortunately it's true. The official explanation for this is:\r\n> \r\n>> The question was brought up in the session on Android M Permissions at Google I/O 2015, during the Q&A portion of the talk. An attendee confirmed that there was no permission group for Internet, and went on to ask if absolutely any app could have access to the Internet. The session speaker, Ben Poiesz, gave affirmative responses to both questions and explained that the logic for this decision was based around the idea that if all of a user's data is protected by default, there's very little reason to be concerned that an app can communicate with the outside world.\r\n> \r\n> but it's clearly done so don't disable the Internet permission to block ads.\r\n> \r\n> I'm also looking forward to the merge of this PR.\r\n\r\nI understand the motive, but what I don't understand is why they would still list (or not) \"full network access\" in the list of app permissions when that clearly doesn't matter at all.\r\n\r\nI'm quite concerned about this; I will try rooting my GFs Android phone and install a firewall on there as well. The less they can snoop and send the snooping results home, the better."}}
{"actor":{"display_login":"doodhout"}}