{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/hyperswitch/issues/63","repository_url":"https://api.github.com/repos/wikimedia/hyperswitch","labels_url":"https://api.github.com/repos/wikimedia/hyperswitch/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/hyperswitch/issues/63/comments","events_url":"https://api.github.com/repos/wikimedia/hyperswitch/issues/63/events","html_url":"https://github.com/wikimedia/hyperswitch/pull/63","id":179569877,"number":63,"title":"Enable TCP_NODELAY by default; v0.7.2","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-27T18:09:03Z","updated_at":"2016-09-27T18:12:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/hyperswitch/pulls/63","html_url":"https://github.com/wikimedia/hyperswitch/pull/63","diff_url":"https://github.com/wikimedia/hyperswitch/pull/63.diff","patch_url":"https://github.com/wikimedia/hyperswitch/pull/63.patch"},"body":"Benchmarks of the serviceworker proxy showed a minimum response latency\r\nof 40ms for streamed responses. This turned out to be caused by Nagle's\r\nalgorithm applied to pipelined HTTP connections, when using streamed\r\nresponses.\r\n\r\nWe use zlib streams to compress all textual content, and are also moving\r\ntowards supporting streaming more directly in services like the\r\nserviceworker proxy. Varnish is using persistent HTTP connections by\r\ndefault, so is also hitting this issue.\r\n\r\nThis patch removes the delay by setting TCP_NODELAY on all http sockets,\r\nat connection creation time. Benchmark results show significantly\r\nimproved latency *and* throughput. The latter might be caused by a\r\nreduced concurrency in node, which outweighs the slightly higher\r\nnetworking cost from sending incomplete packets."},"comment":{"url":"https://api.github.com/repos/wikimedia/hyperswitch/issues/comments/249949775","html_url":"https://github.com/wikimedia/hyperswitch/pull/63#issuecomment-249949775","issue_url":"https://api.github.com/repos/wikimedia/hyperswitch/issues/63","id":249949775,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T18:12:47Z","updated_at":"2016-09-27T18:12:47Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8077183/badge)](https://coveralls.io/builds/8077183)\n\nCoverage increased (+0.01%) to 92.399% when pulling **cf02bacf6ac72a6db27f40c5b175a714c50e3509 on gwicke:nodelay** into **3b66fd4808a695b76709f36949534a8c22d3d358 on wikimedia:master**.\n"}}
{"actor":{"display_login":"coveralls"}}