{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/70519590","id":70519590,"diff_hunk":"@@ -116,6 +116,11 @@ func verifyDevicePath(devicePaths []string) (string, error) {\n \n // Unmount the global mount path, which should be the only one, and delete it.\n func unmountPDAndRemoveGlobalPath(globalMountPath string, mounter mount.Interface) error {\n+\tif pathExists, pathErr := pathExists(globalMountPath); pathErr != nil {\n+\t\treturn fmt.Errorf(\"Error checking if path exists: %v\", pathErr)\n+\t} else if !pathExists {","path":"pkg/volume/aws_ebs/aws_util.go","position":6,"original_position":6,"commit_id":"e3a47f6d03c14f36dc5ea56ca75f14f704254a2a","original_commit_id":"1be49a59b1481ca79206c90e9904be0a37549664","user":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"body":"> Is this expected that we are trying to unmount a path and it does not exist? Are we failing silently?\r\n\r\nIt is possible. Assume globalMountPath unmount succeeds but the OpenFile check afterwards fails (because there is a stray process holding on to a device mount in another namespace, for example) then subsequent calls to unmount will find no globalMountPath (since it has already been unmounted and removed).\r\n\r\n> Are we failing silently?\r\n\r\nYes. We should `glog.V(5)` a warning message indicating unmounting is being skipped because the globalMountPath does not exist.\r\n\r\n> Should this preamble be a util function as we are writing it three times?\r\n\r\nAlways good to have repeated code in one place instead of many.","created_at":"2016-07-12T20:50:07Z","updated_at":"2016-07-12T20:50:07Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28714#discussion_r70519590","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/70519590"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28714#discussion_r70519590"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714","id":76822281,"html_url":"https://github.com/kubernetes/kubernetes/pull/28714","diff_url":"https://github.com/kubernetes/kubernetes/pull/28714.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28714.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28714","number":28714,"state":"open","locked":false,"title":"Add OpenFile check if device is in use before unmount","user":{"login":"ciwang","id":9274442,"avatar_url":"https://avatars.githubusercontent.com/u/9274442?v=3","gravatar_id":"","url":"https://api.github.com/users/ciwang","html_url":"https://github.com/ciwang","followers_url":"https://api.github.com/users/ciwang/followers","following_url":"https://api.github.com/users/ciwang/following{/other_user}","gists_url":"https://api.github.com/users/ciwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ciwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciwang/subscriptions","organizations_url":"https://api.github.com/users/ciwang/orgs","repos_url":"https://api.github.com/users/ciwang/repos","events_url":"https://api.github.com/users/ciwang/events{/privacy}","received_events_url":"https://api.github.com/users/ciwang/received_events","type":"User","site_admin":false},"body":"```no-release-note\r\n```\r\n\r\n\r\n[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()","created_at":"2016-07-08T22:20:35Z","updated_at":"2016-07-12T20:50:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a831867422b988c5c88e759710792b1429debe5","assignee":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"assignees":[{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},{"login":"matchstick","id":19715963,"avatar_url":"https://avatars.githubusercontent.com/u/19715963?v=3","gravatar_id":"","url":"https://api.github.com/users/matchstick","html_url":"https://github.com/matchstick","followers_url":"https://api.github.com/users/matchstick/followers","following_url":"https://api.github.com/users/matchstick/following{/other_user}","gists_url":"https://api.github.com/users/matchstick/gists{/gist_id}","starred_url":"https://api.github.com/users/matchstick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matchstick/subscriptions","organizations_url":"https://api.github.com/users/matchstick/orgs","repos_url":"https://api.github.com/users/matchstick/repos","events_url":"https://api.github.com/users/matchstick/events{/privacy}","received_events_url":"https://api.github.com/users/matchstick/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28714/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e3a47f6d03c14f36dc5ea56ca75f14f704254a2a","head":{"label":"ciwang:robust-unmount","ref":"robust-unmount","sha":"e3a47f6d03c14f36dc5ea56ca75f14f704254a2a","user":{"login":"ciwang","id":9274442,"avatar_url":"https://avatars.githubusercontent.com/u/9274442?v=3","gravatar_id":"","url":"https://api.github.com/users/ciwang","html_url":"https://github.com/ciwang","followers_url":"https://api.github.com/users/ciwang/followers","following_url":"https://api.github.com/users/ciwang/following{/other_user}","gists_url":"https://api.github.com/users/ciwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ciwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciwang/subscriptions","organizations_url":"https://api.github.com/users/ciwang/orgs","repos_url":"https://api.github.com/users/ciwang/repos","events_url":"https://api.github.com/users/ciwang/events{/privacy}","received_events_url":"https://api.github.com/users/ciwang/received_events","type":"User","site_admin":false},"repo":{"id":61570078,"name":"kubernetes","full_name":"ciwang/kubernetes","owner":{"login":"ciwang","id":9274442,"avatar_url":"https://avatars.githubusercontent.com/u/9274442?v=3","gravatar_id":"","url":"https://api.github.com/users/ciwang","html_url":"https://github.com/ciwang","followers_url":"https://api.github.com/users/ciwang/followers","following_url":"https://api.github.com/users/ciwang/following{/other_user}","gists_url":"https://api.github.com/users/ciwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ciwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciwang/subscriptions","organizations_url":"https://api.github.com/users/ciwang/orgs","repos_url":"https://api.github.com/users/ciwang/repos","events_url":"https://api.github.com/users/ciwang/events{/privacy}","received_events_url":"https://api.github.com/users/ciwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ciwang/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/ciwang/kubernetes","forks_url":"https://api.github.com/repos/ciwang/kubernetes/forks","keys_url":"https://api.github.com/repos/ciwang/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciwang/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciwang/kubernetes/teams","hooks_url":"https://api.github.com/repos/ciwang/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ciwang/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ciwang/kubernetes/events","assignees_url":"https://api.github.com/repos/ciwang/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ciwang/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ciwang/kubernetes/tags","blobs_url":"https://api.github.com/repos/ciwang/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciwang/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciwang/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciwang/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciwang/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ciwang/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ciwang/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ciwang/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ciwang/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ciwang/kubernetes/subscription","commits_url":"https://api.github.com/repos/ciwang/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciwang/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciwang/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciwang/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciwang/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ciwang/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciwang/kubernetes/merges","archive_url":"https://api.github.com/repos/ciwang/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciwang/kubernetes/downloads","issues_url":"https://api.github.com/repos/ciwang/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ciwang/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ciwang/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ciwang/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciwang/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ciwang/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ciwang/kubernetes/deployments","created_at":"2016-06-20T18:17:35Z","updated_at":"2016-06-20T18:17:51Z","pushed_at":"2016-07-11T18:46:33Z","git_url":"git://github.com/ciwang/kubernetes.git","ssh_url":"git@github.com:ciwang/kubernetes.git","clone_url":"https://github.com/ciwang/kubernetes.git","svn_url":"https://github.com/ciwang/kubernetes","homepage":"http://kubernetes.io","size":280119,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1376c993273299b82a9af3bf389bb397c126a799","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-12T19:54:16Z","pushed_at":"2016-07-12T20:46:15Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":491288,"stargazers_count":15477,"watchers_count":15477,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4856,"mirror_url":null,"open_issues_count":3930,"forks":4856,"open_issues":3930,"watchers":15477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28714"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28714"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28714/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28714/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e3a47f6d03c14f36dc5ea56ca75f14f704254a2a"}}}}
{"actor":{"display_login":"saad-ali"}}