{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/comments/75731675","id":75731675,"diff_hunk":"@@ -12,10 +12,14 @@ grinder.bf.query_url=\"http://localhost:20000\"\n grinder.bf.max_multiplot_metrics=10\n grinder.bf.name_fmt=\"org.example.metric.%d\"\n \n+#grinder.bf.throttling_group.ingest.max_requests_per_minute=100000000\n+#grinder.bf.throttling_group.query.max_requests_per_minute=100000000\n+","path":"properties/grinder.properties.local","position":6,"original_position":6,"commit_id":"e924f5bfa21989631498ba0aedf5684cb64fe110","original_commit_id":"ea3582da5f255e907849e09245c96890727e1dcc","user":{"login":"glyph","id":716529,"avatar_url":"https://avatars.githubusercontent.com/u/716529?v=3","gravatar_id":"","url":"https://api.github.com/users/glyph","html_url":"https://github.com/glyph","followers_url":"https://api.github.com/users/glyph/followers","following_url":"https://api.github.com/users/glyph/following{/other_user}","gists_url":"https://api.github.com/users/glyph/gists{/gist_id}","starred_url":"https://api.github.com/users/glyph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyph/subscriptions","organizations_url":"https://api.github.com/users/glyph/orgs","repos_url":"https://api.github.com/users/glyph/repos","events_url":"https://api.github.com/users/glyph/events{/privacy}","received_events_url":"https://api.github.com/users/glyph/received_events","type":"User","site_admin":false},"body":"If this is the documentation idiom for this project, then I don't really have any objection.  However, I will note that \"commented-out lines in a config file with no explanation\" is perhaps not the *best* documentation idiom :).\r\n\r\nBasically my position is: the right place to put this is in the project's documentation, but if there's no formal docs for all these options then having these present here is better than nothing.","created_at":"2016-08-22T18:27:32Z","updated_at":"2016-08-22T18:27:32Z","html_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts/pull/2#discussion_r75731675","pull_request_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/comments/75731675"},"html":{"href":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts/pull/2#discussion_r75731675"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2","id":81385272,"html_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts/pull/2","diff_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts/pull/2.diff","patch_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts/pull/2.patch","issue_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/2","number":2,"state":"open","locked":false,"title":"Throttling","user":{"login":"izrik","id":1711679,"avatar_url":"https://avatars.githubusercontent.com/u/1711679?v=3","gravatar_id":"","url":"https://api.github.com/users/izrik","html_url":"https://github.com/izrik","followers_url":"https://api.github.com/users/izrik/followers","following_url":"https://api.github.com/users/izrik/following{/other_user}","gists_url":"https://api.github.com/users/izrik/gists{/gist_id}","starred_url":"https://api.github.com/users/izrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izrik/subscriptions","organizations_url":"https://api.github.com/users/izrik/orgs","repos_url":"https://api.github.com/users/izrik/repos","events_url":"https://api.github.com/users/izrik/events{/privacy}","received_events_url":"https://api.github.com/users/izrik/received_events","type":"User","site_admin":false},"body":"This PR adds the `ThrottlingGroup` class, which is used to limit the number of requests sent by all threads utilizing one such object. It also adds config properties that control throttling groups and assigns them to threads.\r\n\r\nThe `properties/grinder.properties.local` file can be used as an example. It defined two throttling groups, one for ingest-type threads and one for query-type threads.\r\n\r\nNote that enum-related threads are not assigned throttling groups, because they are planned to be removed.","created_at":"2016-08-15T22:19:12Z","updated_at":"2016-08-22T18:27:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"512fb851ca0aa704d8bf96c6b323b81c8a083b59","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/2/comments","statuses_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/statuses/e924f5bfa21989631498ba0aedf5684cb64fe110","head":{"label":"rackerlabs:throttling","ref":"throttling","sha":"e924f5bfa21989631498ba0aedf5684cb64fe110","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":64854159,"name":"cloudmetrics-perf-test-scripts","full_name":"rackerlabs/cloudmetrics-perf-test-scripts","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts","description":"Grinder scripts for performance testing of Rackspace Metrics https://one.rackspace.com/display/cloudmetrics/Rackspace+Metrics","fork":false,"url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts","forks_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/forks","keys_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/teams","hooks_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/events","assignees_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/tags","blobs_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/subscription","commits_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/merges","archive_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/downloads","issues_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/deployments","created_at":"2016-08-03T14:50:08Z","updated_at":"2016-08-15T15:04:05Z","pushed_at":"2016-08-22T15:30:20Z","git_url":"git://github.com/rackerlabs/cloudmetrics-perf-test-scripts.git","ssh_url":"git@github.com:rackerlabs/cloudmetrics-perf-test-scripts.git","clone_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts.git","svn_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts","homepage":null,"size":219,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"01d70f657bc84ae3b49b8c11df9cc55e06034fb6","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":64854159,"name":"cloudmetrics-perf-test-scripts","full_name":"rackerlabs/cloudmetrics-perf-test-scripts","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts","description":"Grinder scripts for performance testing of Rackspace Metrics https://one.rackspace.com/display/cloudmetrics/Rackspace+Metrics","fork":false,"url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts","forks_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/forks","keys_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/teams","hooks_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/events","assignees_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/tags","blobs_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/subscription","commits_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/merges","archive_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/downloads","issues_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/deployments","created_at":"2016-08-03T14:50:08Z","updated_at":"2016-08-15T15:04:05Z","pushed_at":"2016-08-22T15:30:20Z","git_url":"git://github.com/rackerlabs/cloudmetrics-perf-test-scripts.git","ssh_url":"git@github.com:rackerlabs/cloudmetrics-perf-test-scripts.git","clone_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts.git","svn_url":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts","homepage":null,"size":219,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2"},"html":{"href":"https://github.com/rackerlabs/cloudmetrics-perf-test-scripts/pull/2"},"issue":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/2"},"comments":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/cloudmetrics-perf-test-scripts/statuses/e924f5bfa21989631498ba0aedf5684cb64fe110"}}}}
{"actor":{"display_login":"glyph"}}