{"action":"created","issue":{"url":"https://api.github.com/repos/ladderlife/cellophane/issues/7","repository_url":"https://api.github.com/repos/ladderlife/cellophane","labels_url":"https://api.github.com/repos/ladderlife/cellophane/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ladderlife/cellophane/issues/7/comments","events_url":"https://api.github.com/repos/ladderlife/cellophane/issues/7/events","html_url":"https://github.com/ladderlife/cellophane/issues/7","id":157107931,"number":7,"title":"wait for render","user":{"login":"eyston","id":187389,"avatar_url":"https://avatars.githubusercontent.com/u/187389?v=3","gravatar_id":"","url":"https://api.github.com/users/eyston","html_url":"https://github.com/eyston","followers_url":"https://api.github.com/users/eyston/followers","following_url":"https://api.github.com/users/eyston/following{/other_user}","gists_url":"https://api.github.com/users/eyston/gists{/gist_id}","starred_url":"https://api.github.com/users/eyston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyston/subscriptions","organizations_url":"https://api.github.com/users/eyston/orgs","repos_url":"https://api.github.com/users/eyston/repos","events_url":"https://api.github.com/users/eyston/events{/privacy}","received_events_url":"https://api.github.com/users/eyston/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-05-27T00:39:24Z","updated_at":"2016-05-28T23:05:25Z","closed_at":null,"body":"Om.next will not render until parser receives data which might be due to remotes.\r\n\r\nhttps://github.com/ladderlife/cellophane/blob/master/src/cellophane/next.clj#L1505-L1506\r\n\r\n```\r\n(when-not (empty? v)\r\n  (renderf v))\r\n```\r\n\r\nShould the return from `add-root!` maybe be a promise instead of an atom?  This would allow blocking on a remote send for a parse.\r\n\r\nCurrent flow:\r\n\r\n- local parse returns an empty result (it has no data)\r\n- remote sends get sent\r\n- `add-root!` returns a `nil` and the caller doesn't have a reference to the atom\r\n- remote send results don't matter\r\n\r\nProposed flow:\r\n\r\n- local parse returns an empty result (it has no data)\r\n- remote sends get sent\r\n- `ret` hasn't been set yet\r\n- remote sends call `send-cb`, parse returns data, `renderf` is called\r\n- `ret` gets set with this value\r\n- `add-root!` returns with the constructed component\r\n\r\nI could be misunderstanding so lemme know if something is wrong.  The idea is we want to SSR *after* remotes have complete."},"comment":{"url":"https://api.github.com/repos/ladderlife/cellophane/issues/comments/222333753","html_url":"https://github.com/ladderlife/cellophane/issues/7#issuecomment-222333753","issue_url":"https://api.github.com/repos/ladderlife/cellophane/issues/7","id":222333753,"user":{"login":"eyston","id":187389,"avatar_url":"https://avatars.githubusercontent.com/u/187389?v=3","gravatar_id":"","url":"https://api.github.com/users/eyston","html_url":"https://github.com/eyston","followers_url":"https://api.github.com/users/eyston/followers","following_url":"https://api.github.com/users/eyston/following{/other_user}","gists_url":"https://api.github.com/users/eyston/gists{/gist_id}","starred_url":"https://api.github.com/users/eyston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyston/subscriptions","organizations_url":"https://api.github.com/users/eyston/orgs","repos_url":"https://api.github.com/users/eyston/repos","events_url":"https://api.github.com/users/eyston/events{/privacy}","received_events_url":"https://api.github.com/users/eyston/received_events","type":"User","site_admin":false},"created_at":"2016-05-28T23:05:25Z","updated_at":"2016-05-28T23:05:25Z","body":"can just make the send blocking instead of cellophane :)\r\n\r\nclosing!"}}
{"actor":{"display_login":"eyston"}}