{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/caravel/pulls/comments/81054515","pull_request_review_id":2063007,"id":81054515,"diff_hunk":"@@ -1833,6 +1841,32 @@ def csv(self, client_id):\n         return response\n \n     @has_access\n+    @expose(\"/fetch_datasource_metadata\")\n+    @log_this\n+    def fetch_datasource_metadata(self):\n+        # TODO: check permissions","path":"caravel/views.py","position":31,"original_position":32,"commit_id":"6ad3bf73a42e0cf46eec5cb4c5c694e23541e7c2","original_commit_id":"ee61d1738c680c3896a8acae4471d44345245eed","user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"body":"ah gotcha, good catch","created_at":"2016-09-29T02:18:36Z","updated_at":"2016-09-29T02:18:37Z","html_url":"https://github.com/airbnb/caravel/pull/1205#discussion_r81054515","pull_request_url":"https://api.github.com/repos/airbnb/caravel/pulls/1205","_links":{"self":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/comments/81054515"},"html":{"href":"https://github.com/airbnb/caravel/pull/1205#discussion_r81054515"},"pull_request":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1205"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/caravel/pulls/1205","id":86977647,"html_url":"https://github.com/airbnb/caravel/pull/1205","diff_url":"https://github.com/airbnb/caravel/pull/1205.diff","patch_url":"https://github.com/airbnb/caravel/pull/1205.patch","issue_url":"https://api.github.com/repos/airbnb/caravel/issues/1205","number":1205,"state":"open","locked":false,"title":"Explore control panel - Chart control, TimeFilter, GroupBy, Filters","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"body":"Sorry I should have divided this to smaller PRs, will work on Todos in future smaller PR\r\nneeds-review @ascott \r\n\r\nDone:\r\n - Endpoint for data attached to a datasource\r\n - Chart options, Time Filter, GroupBy, SQL and Filters component\r\n - redux-thunk for getting column options for one datasouce\r\n - actions/reducers for updating states from form-data\r\n - populates fields in control panel with url params retrieved from bootstrap_data.viz.form_data\r\n\r\nTodo:\r\n - Renovate ugly UI, use panel/O2 stuff\r\n - Add support for druid\r\n - Multi-select for filter values: (as in here) https://github.com/airbnb/caravel/pull/1061\r\n - Tests\r\n\r\nSide note: \r\ndata for slice stored in { bootstrapData.viz.data }\r\ndata for pre-populating form stored in { bootstrapData.viz.form_data }\r\n\r\n","created_at":"2016-09-27T17:42:28Z","updated_at":"2016-09-29T02:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb4bc10836381e1d05e7d101385f1232323d54de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/caravel/pulls/1205/commits","review_comments_url":"https://api.github.com/repos/airbnb/caravel/pulls/1205/comments","review_comment_url":"https://api.github.com/repos/airbnb/caravel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/caravel/issues/1205/comments","statuses_url":"https://api.github.com/repos/airbnb/caravel/statuses/6ad3bf73a42e0cf46eec5cb4c5c694e23541e7c2","head":{"label":"vera-liu:vliu_explore_control","ref":"vliu_explore_control","sha":"6ad3bf73a42e0cf46eec5cb4c5c694e23541e7c2","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"repo":{"id":65501764,"name":"caravel","full_name":"vera-liu/caravel","owner":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vera-liu/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":true,"url":"https://api.github.com/repos/vera-liu/caravel","forks_url":"https://api.github.com/repos/vera-liu/caravel/forks","keys_url":"https://api.github.com/repos/vera-liu/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vera-liu/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vera-liu/caravel/teams","hooks_url":"https://api.github.com/repos/vera-liu/caravel/hooks","issue_events_url":"https://api.github.com/repos/vera-liu/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/vera-liu/caravel/events","assignees_url":"https://api.github.com/repos/vera-liu/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/vera-liu/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/vera-liu/caravel/tags","blobs_url":"https://api.github.com/repos/vera-liu/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vera-liu/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vera-liu/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/vera-liu/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vera-liu/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/vera-liu/caravel/languages","stargazers_url":"https://api.github.com/repos/vera-liu/caravel/stargazers","contributors_url":"https://api.github.com/repos/vera-liu/caravel/contributors","subscribers_url":"https://api.github.com/repos/vera-liu/caravel/subscribers","subscription_url":"https://api.github.com/repos/vera-liu/caravel/subscription","commits_url":"https://api.github.com/repos/vera-liu/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/vera-liu/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/vera-liu/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/vera-liu/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/vera-liu/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/vera-liu/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vera-liu/caravel/merges","archive_url":"https://api.github.com/repos/vera-liu/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vera-liu/caravel/downloads","issues_url":"https://api.github.com/repos/vera-liu/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/vera-liu/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/vera-liu/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/vera-liu/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vera-liu/caravel/labels{/name}","releases_url":"https://api.github.com/repos/vera-liu/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/vera-liu/caravel/deployments","created_at":"2016-08-11T21:10:17Z","updated_at":"2016-08-11T21:10:18Z","pushed_at":"2016-09-29T01:05:34Z","git_url":"git://github.com/vera-liu/caravel.git","ssh_url":"git@github.com:vera-liu/caravel.git","clone_url":"https://github.com/vera-liu/caravel.git","svn_url":"https://github.com/vera-liu/caravel","homepage":"","size":37451,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:alanna-explore-v2-main","ref":"alanna-explore-v2-main","sha":"b67906cfe13a667105228e73fbca0f2dc0a11520","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"caravel","full_name":"airbnb/caravel","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/caravel","forks_url":"https://api.github.com/repos/airbnb/caravel/forks","keys_url":"https://api.github.com/repos/airbnb/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/caravel/teams","hooks_url":"https://api.github.com/repos/airbnb/caravel/hooks","issue_events_url":"https://api.github.com/repos/airbnb/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/caravel/events","assignees_url":"https://api.github.com/repos/airbnb/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/caravel/tags","blobs_url":"https://api.github.com/repos/airbnb/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/caravel/languages","stargazers_url":"https://api.github.com/repos/airbnb/caravel/stargazers","contributors_url":"https://api.github.com/repos/airbnb/caravel/contributors","subscribers_url":"https://api.github.com/repos/airbnb/caravel/subscribers","subscription_url":"https://api.github.com/repos/airbnb/caravel/subscription","commits_url":"https://api.github.com/repos/airbnb/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/caravel/merges","archive_url":"https://api.github.com/repos/airbnb/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/caravel/downloads","issues_url":"https://api.github.com/repos/airbnb/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/caravel/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/caravel/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-09-28T19:46:41Z","pushed_at":"2016-09-29T01:05:34Z","git_url":"git://github.com/airbnb/caravel.git","ssh_url":"git@github.com:airbnb/caravel.git","clone_url":"https://github.com/airbnb/caravel.git","svn_url":"https://github.com/airbnb/caravel","homepage":"","size":43148,"stargazers_count":7528,"watchers_count":7528,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":870,"mirror_url":null,"open_issues_count":242,"forks":870,"open_issues":242,"watchers":7528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1205"},"html":{"href":"https://github.com/airbnb/caravel/pull/1205"},"issue":{"href":"https://api.github.com/repos/airbnb/caravel/issues/1205"},"comments":{"href":"https://api.github.com/repos/airbnb/caravel/issues/1205/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1205/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1205/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/caravel/statuses/6ad3bf73a42e0cf46eec5cb4c5c694e23541e7c2"}}}}
{"actor":{"display_login":"ascott"}}