{"action":"created","issue":{"url":"https://api.github.com/repos/php-coder/mystamps/issues/328","labels_url":"https://api.github.com/repos/php-coder/mystamps/issues/328/labels{/name}","comments_url":"https://api.github.com/repos/php-coder/mystamps/issues/328/comments","events_url":"https://api.github.com/repos/php-coder/mystamps/issues/328/events","html_url":"https://github.com/php-coder/mystamps/pull/328","id":128038558,"number":328,"title":"Gh205 Remove id from country url","user":{"login":"AleksSPb","id":12548195,"avatar_url":"https://avatars.githubusercontent.com/u/12548195?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksSPb","html_url":"https://github.com/AleksSPb","followers_url":"https://api.github.com/users/AleksSPb/followers","following_url":"https://api.github.com/users/AleksSPb/following{/other_user}","gists_url":"https://api.github.com/users/AleksSPb/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksSPb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksSPb/subscriptions","organizations_url":"https://api.github.com/users/AleksSPb/orgs","repos_url":"https://api.github.com/users/AleksSPb/repos","events_url":"https://api.github.com/users/AleksSPb/events{/privacy}","received_events_url":"https://api.github.com/users/AleksSPb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/php-coder/mystamps/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-01-21T22:41:22Z","updated_at":"2016-02-01T17:39:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php-coder/mystamps/pulls/328","html_url":"https://github.com/php-coder/mystamps/pull/328","diff_url":"https://github.com/php-coder/mystamps/pull/328.diff","patch_url":"https://github.com/php-coder/mystamps/pull/328.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/php-coder/mystamps/328)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/php-coder/mystamps/issues/comments/178089183","html_url":"https://github.com/php-coder/mystamps/pull/328#issuecomment-178089183","issue_url":"https://api.github.com/repos/php-coder/mystamps/issues/328","id":178089183,"user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T17:39:07Z","updated_at":"2016-02-01T17:39:07Z","body":"\n\n\n\nReviewed 4 of 5 files at r5.\nReview status: 13 of 14 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.\n\n---\n\n*[src/main/java/ru/mystamps/web/Url.java, line 68 \\[r5\\]](https://reviewable.io:443/reviews/php-coder/mystamps/328#-K9SsOcrl5LfEJDJKJqZ:-K9SsOcrl5LfEJDJKJq_:188020578) ([raw file](https://github.com/php-coder/mystamps/blob/1273171ab09b29edfb106e9990dbcac263f74729/src/main/java/ru/mystamps/web/Url.java#L68)):*\nHm, interesting... `/country/add` also matches pattern `/country/{slug}` Is it possible that we broke adding countries?\n\n---\n\n*[src/main/java/ru/mystamps/web/Url.java, line 131 \\[r5\\]](https://reviewable.io:443/reviews/php-coder/mystamps/328#-K9SsDRZRvXLzvCXEdg1:-K9SsDRZRvXLzvCXEdg2:611147761) ([raw file](https://github.com/php-coder/mystamps/blob/1273171ab09b29edfb106e9990dbcac263f74729/src/main/java/ru/mystamps/web/Url.java#L131)):*\nWe don't need to export this outdated url. Instead we should update code to use new url.\n\n---\n\n*[src/main/resources/liquibase/version/0.4/2016-01-14--unique_slug_in_countries.xml, line 11 \\[r3\\]](https://reviewable.io:443/reviews/php-coder/mystamps/328#-K8zhnUzs436yX1hduIv:-K9SsoLt5p-XlhlB5Vlr:-1548724689) ([raw file](https://github.com/php-coder/mystamps/blob/e333021c4074c820cca4a7da64e03697810051a9/src/main/resources/liquibase/version/0.4/2016-01-14--unique_slug_in_countries.xml#L11)):*\nOne of us need to make experiments with data: if this query returns empty set, than maybe we should append `UNION SELECT 0` to end of the query.\n\n---\n\n*[src/test/groovy/ru/mystamps/web/service/CountryServiceImplTest.groovy, line 266 \\[r5\\]](https://reviewable.io:443/reviews/php-coder/mystamps/328#-K9StBRCBOUZiX0H59a6:-K9StBRCBOUZiX0H59a7:203561420) ([raw file](https://github.com/php-coder/mystamps/blob/1273171ab09b29edfb106e9990dbcac263f74729/src/test/groovy/ru/mystamps/web/service/CountryServiceImplTest.groovy#L266)):*\nI suggest to combine this test case and make it parameterized. So, it should be renamed to `findOneAsLinkEntity() should throw exception when country slug is '#slug'` and also use `@Unroll` (https://spockframework.github.io/spock/docs/1.0/data_driven_testing.html#_method_unrolling).\n\n---\n\n*[src/test/groovy/ru/mystamps/web/service/CountryServiceImplTest.groovy, line 282 \\[r5\\]](https://reviewable.io:443/reviews/php-coder/mystamps/328#-K9SuZHgordUqEU5IM3z:-K9SuZHh5Cva0yR9l7Qz:-1146731887) ([raw file](https://github.com/php-coder/mystamps/blob/1273171ab09b29edfb106e9990dbcac263f74729/src/test/groovy/ru/mystamps/web/service/CountryServiceImplTest.groovy#L282)):*\nJust `slug` and `expectedSlug` will be enough.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/php-coder/mystamps/328)*\n<!-- Sent from Reviewable.io -->\n"}}