{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/94106704","pull_request_review_id":14636888,"id":94106704,"diff_hunk":"@@ -17,15 +18,15 @@ def initialize(*)\n       end\n \n       def broadcast(channel, payload)\n-        redis_connection_for_broadcasts.publish(channel, payload)\n+        redis_connection_for_broadcasts.publish(channel_name(channel), payload)","path":"actioncable/lib/action_cable/subscription_adapter/redis.rb","position":13,"original_position":13,"commit_id":"ff1a9e10c8863d04b738e41f84516a4e12df3e7b","original_commit_id":"ff1a9e10c8863d04b738e41f84516a4e12df3e7b","user":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"body":"Instead of making the adapter call `channel_name`, if we `prepend` the module, it could define `broadcast`/`subscribe`/`unsubscribe` methods that mangle the name then `super`.","created_at":"2016-12-29T07:07:40Z","updated_at":"2016-12-29T07:09:59Z","html_url":"https://github.com/rails/rails/pull/27425#discussion_r94106704","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/27425","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/94106704"},"html":{"href":"https://github.com/rails/rails/pull/27425#discussion_r94106704"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/27425"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/27425","id":98972199,"html_url":"https://github.com/rails/rails/pull/27425","diff_url":"https://github.com/rails/rails/pull/27425.diff","patch_url":"https://github.com/rails/rails/pull/27425.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/27425","number":27425,"state":"open","locked":false,"title":"Add channel_prefix support to AC redis/evented_redis adapters ","user":{"login":"matrix9180","id":23177703,"avatar_url":"https://avatars.githubusercontent.com/u/23177703?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix9180","html_url":"https://github.com/matrix9180","followers_url":"https://api.github.com/users/matrix9180/followers","following_url":"https://api.github.com/users/matrix9180/following{/other_user}","gists_url":"https://api.github.com/users/matrix9180/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix9180/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix9180/subscriptions","organizations_url":"https://api.github.com/users/matrix9180/orgs","repos_url":"https://api.github.com/users/matrix9180/repos","events_url":"https://api.github.com/users/matrix9180/events{/privacy}","received_events_url":"https://api.github.com/users/matrix9180/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\n#27224 \r\n\r\nIn Redis, Pub/Sub has no relation to the key space. It was made to not interfere with it on any level, including database numbers.\r\nPublishing on db 10, will be heard by a subscriber on db 1. \r\n(https://redis.io/topics/pubsub#database-amp-scoping)\r\n\r\nTo avoid problems when multiple Rails applications use the same Redis instance, the redis/evented_redis subscription adapters now support a channel_prefix option (specified in cable.yml)\r\n\r\nOther backends do not appear to have this issue.\r\n\r\nThe generated cable.yml has also been updated to reflect this change. ","created_at":"2016-12-21T17:21:13Z","updated_at":"2016-12-29T07:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b4da5b847d74b5dd8946ed8e199e1750b7bc3a6","assignee":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"assignees":[{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/27425/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/27425/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/27425/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/ff1a9e10c8863d04b738e41f84516a4e12df3e7b","head":{"label":"matrix9180:action_cable_channel_prefix","ref":"action_cable_channel_prefix","sha":"ff1a9e10c8863d04b738e41f84516a4e12df3e7b","user":{"login":"matrix9180","id":23177703,"avatar_url":"https://avatars.githubusercontent.com/u/23177703?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix9180","html_url":"https://github.com/matrix9180","followers_url":"https://api.github.com/users/matrix9180/followers","following_url":"https://api.github.com/users/matrix9180/following{/other_user}","gists_url":"https://api.github.com/users/matrix9180/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix9180/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix9180/subscriptions","organizations_url":"https://api.github.com/users/matrix9180/orgs","repos_url":"https://api.github.com/users/matrix9180/repos","events_url":"https://api.github.com/users/matrix9180/events{/privacy}","received_events_url":"https://api.github.com/users/matrix9180/received_events","type":"User","site_admin":false},"repo":{"id":75296819,"name":"rails","full_name":"matrix9180/rails","owner":{"login":"matrix9180","id":23177703,"avatar_url":"https://avatars.githubusercontent.com/u/23177703?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix9180","html_url":"https://github.com/matrix9180","followers_url":"https://api.github.com/users/matrix9180/followers","following_url":"https://api.github.com/users/matrix9180/following{/other_user}","gists_url":"https://api.github.com/users/matrix9180/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix9180/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix9180/subscriptions","organizations_url":"https://api.github.com/users/matrix9180/orgs","repos_url":"https://api.github.com/users/matrix9180/repos","events_url":"https://api.github.com/users/matrix9180/events{/privacy}","received_events_url":"https://api.github.com/users/matrix9180/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matrix9180/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/matrix9180/rails","forks_url":"https://api.github.com/repos/matrix9180/rails/forks","keys_url":"https://api.github.com/repos/matrix9180/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix9180/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix9180/rails/teams","hooks_url":"https://api.github.com/repos/matrix9180/rails/hooks","issue_events_url":"https://api.github.com/repos/matrix9180/rails/issues/events{/number}","events_url":"https://api.github.com/repos/matrix9180/rails/events","assignees_url":"https://api.github.com/repos/matrix9180/rails/assignees{/user}","branches_url":"https://api.github.com/repos/matrix9180/rails/branches{/branch}","tags_url":"https://api.github.com/repos/matrix9180/rails/tags","blobs_url":"https://api.github.com/repos/matrix9180/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix9180/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix9180/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix9180/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix9180/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix9180/rails/languages","stargazers_url":"https://api.github.com/repos/matrix9180/rails/stargazers","contributors_url":"https://api.github.com/repos/matrix9180/rails/contributors","subscribers_url":"https://api.github.com/repos/matrix9180/rails/subscribers","subscription_url":"https://api.github.com/repos/matrix9180/rails/subscription","commits_url":"https://api.github.com/repos/matrix9180/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix9180/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix9180/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix9180/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix9180/rails/contents/{+path}","compare_url":"https://api.github.com/repos/matrix9180/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix9180/rails/merges","archive_url":"https://api.github.com/repos/matrix9180/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix9180/rails/downloads","issues_url":"https://api.github.com/repos/matrix9180/rails/issues{/number}","pulls_url":"https://api.github.com/repos/matrix9180/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix9180/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix9180/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix9180/rails/labels{/name}","releases_url":"https://api.github.com/repos/matrix9180/rails/releases{/id}","deployments_url":"https://api.github.com/repos/matrix9180/rails/deployments","created_at":"2016-12-01T13:49:27Z","updated_at":"2016-12-01T13:50:34Z","pushed_at":"2016-12-21T19:39:45Z","git_url":"git://github.com/matrix9180/rails.git","ssh_url":"git@github.com:matrix9180/rails.git","clone_url":"https://github.com/matrix9180/rails.git","svn_url":"https://github.com/matrix9180/rails","homepage":"http://rubyonrails.org","size":140635,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"85b2a3ea2f4b614c1b7135e28b86e14fc109e8e5","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-12-29T06:12:53Z","pushed_at":"2016-12-29T06:41:05Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":141107,"stargazers_count":33910,"watchers_count":33910,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13793,"mirror_url":null,"open_issues_count":1253,"forks":13793,"open_issues":1253,"watchers":33910,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/27425"},"html":{"href":"https://github.com/rails/rails/pull/27425"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/27425"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/27425/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/27425/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/27425/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/ff1a9e10c8863d04b738e41f84516a4e12df3e7b"}}}}
{"actor":{"display_login":"matthewd"}}