{"action":"opened","number":870,"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/870","id":92980492,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/870","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/870.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/870.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/870","number":870,"state":"open","locked":false,"title":"(Fix) Posting cash rounding","user":{"login":"sfount","id":2844572,"avatar_url":"https://avatars.githubusercontent.com/u/2844572?v=3","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"body":"Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application.  Thanks!\r\n\r\nThis commit resolves two bugs found in the core cash posting process.\r\n* Any cash payments that resulted in a loss to the enterprise (the\r\n  debtor under pays and this is rounded up) caused a 400 Bad Request.\r\n  This was because of an additional column in the VALUE statement\r\n  that has been removed.\r\n* Both gain and loss rounding statements included references to both the\r\n  debtor entity and the invoice that was being paid. However if the\r\n  debtor is over paying and the system is rounding down that means the\r\n  invoice has been paid in full. By referencing the invoice on the\r\n  additional rounding line this means the debtor's balance is never\r\n  zeroed.\r\n\r\n---\r\n\r\n - [x] Run your code through JSHint.  [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md).\r\n - [x] Run integration tests.\r\n - [x] Run end-to-end tests.\r\n - [x] Accurately described the changes your are making in this pull request.","created_at":"2016-11-09T15:13:07Z","updated_at":"2016-11-09T15:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/870/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/870/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/870/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/0b1027e5a34ea8c41f8971ecb962f243d82508f0","head":{"label":"sfount:core-finance-rounding","ref":"core-finance-rounding","sha":"0b1027e5a34ea8c41f8971ecb962f243d82508f0","user":{"login":"sfount","id":2844572,"avatar_url":"https://avatars.githubusercontent.com/u/2844572?v=3","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"repo":{"id":49060358,"name":"bhima-2.X","full_name":"sfount/bhima-2.X","owner":{"login":"sfount","id":2844572,"avatar_url":"https://avatars.githubusercontent.com/u/2844572?v=3","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfount/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":true,"url":"https://api.github.com/repos/sfount/bhima-2.X","forks_url":"https://api.github.com/repos/sfount/bhima-2.X/forks","keys_url":"https://api.github.com/repos/sfount/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfount/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfount/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/sfount/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/sfount/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/sfount/bhima-2.X/events","assignees_url":"https://api.github.com/repos/sfount/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/sfount/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/sfount/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/sfount/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfount/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfount/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfount/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfount/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/sfount/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/sfount/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/sfount/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/sfount/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/sfount/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/sfount/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfount/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfount/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfount/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfount/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/sfount/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfount/bhima-2.X/merges","archive_url":"https://api.github.com/repos/sfount/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfount/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/sfount/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/sfount/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/sfount/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/sfount/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfount/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/sfount/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/sfount/bhima-2.X/deployments","created_at":"2016-01-05T10:55:13Z","updated_at":"2016-03-27T15:46:19Z","pushed_at":"2016-11-09T15:10:57Z","git_url":"git://github.com/sfount/bhima-2.X.git","ssh_url":"git@github.com:sfount/bhima-2.X.git","clone_url":"https://github.com/sfount/bhima-2.X.git","svn_url":"https://github.com/sfount/bhima-2.X","homepage":null,"size":6612,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:master","ref":"master","sha":"bac5a5ed318c21ba2e3e4c6c222146c633513856","user":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":49052669,"name":"bhima-2.X","full_name":"IMA-WorldHealth/bhima-2.X","owner":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X","description":"A hospital information management application for rural Congolese hospitals","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/deployments","created_at":"2016-01-05T08:30:30Z","updated_at":"2016-11-07T22:14:59Z","pushed_at":"2016-11-09T14:08:55Z","git_url":"git://github.com/IMA-WorldHealth/bhima-2.X.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima-2.X.git","clone_url":"https://github.com/IMA-WorldHealth/bhima-2.X.git","svn_url":"https://github.com/IMA-WorldHealth/bhima-2.X","homepage":"","size":7519,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":159,"forks":8,"open_issues":159,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/870"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/870"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/870"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/870/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/870/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/870/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/0b1027e5a34ea8c41f8971ecb962f243d82508f0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"sfount"}}