{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments/84871142","pull_request_review_id":5620166,"id":84871142,"diff_hunk":"@@ -21,15 +25,18 @@ add_files /etc/xinetd.d/tftp\n [ -d \"/var/lib/tftpboot\" ] && add_cmd \"find /var/lib/tftpboot -exec ls -ld {} +\" \"tftpboot_tree\"\n \n # ISC bind\n-add_files /etc/named.conf /var/log/named.log\n-add_files /var/named/* /var/named/{data,dynamic,slaves}/*\n+add_files /etc/named.conf\n+add_files /var/log/named.log\n+for SUBDIR in /var/named /var/named/{data,dynamic,slaves}; do\n+  add_files $SUBDIR/\n+done\n \n # Puppet master and CA\n add_files /var/lib/puppet/ssl/certs/$(hostname -f).pem /var/lib/puppet/ssl/certs/ca.pem\n-add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/* /var/log/puppet/*.log*\n+add_files /etc/puppet/*.conf /etc/puppet/rack/* /etc/puppet/manifests/*","path":"extra/foreman-debug-proxy","position":29,"original_position":29,"commit_id":"bb7198830af76c9918745e72ae812711da103196","original_commit_id":"bb7198830af76c9918745e72ae812711da103196","user":{"login":"witlessbird","id":8957,"avatar_url":"https://avatars.githubusercontent.com/u/8957?v=3","gravatar_id":"","url":"https://api.github.com/users/witlessbird","html_url":"https://github.com/witlessbird","followers_url":"https://api.github.com/users/witlessbird/followers","following_url":"https://api.github.com/users/witlessbird/following{/other_user}","gists_url":"https://api.github.com/users/witlessbird/gists{/gist_id}","starred_url":"https://api.github.com/users/witlessbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witlessbird/subscriptions","organizations_url":"https://api.github.com/users/witlessbird/orgs","repos_url":"https://api.github.com/users/witlessbird/repos","events_url":"https://api.github.com/users/witlessbird/events{/privacy}","received_events_url":"https://api.github.com/users/witlessbird/received_events","type":"User","site_admin":false},"body":"These are locations for older versions of puppet (pre 4.0). Current versions use ```/etc/puppetlabs/*```.","created_at":"2016-10-25T10:15:44Z","updated_at":"2016-10-25T10:18:37Z","html_url":"https://github.com/theforeman/smart-proxy/pull/461#discussion_r84871142","pull_request_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments/84871142"},"html":{"href":"https://github.com/theforeman/smart-proxy/pull/461#discussion_r84871142"},"pull_request":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461","id":86613826,"html_url":"https://github.com/theforeman/smart-proxy/pull/461","diff_url":"https://github.com/theforeman/smart-proxy/pull/461.diff","patch_url":"https://github.com/theforeman/smart-proxy/pull/461.patch","issue_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/461","number":461,"state":"open","locked":false,"title":"Fixes #16680 - foreman-debug to collect whole newest (log)files ..","user":{"login":"pmoravec","id":4340368,"avatar_url":"https://avatars.githubusercontent.com/u/4340368?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoravec","html_url":"https://github.com/pmoravec","followers_url":"https://api.github.com/users/pmoravec/followers","following_url":"https://api.github.com/users/pmoravec/following{/other_user}","gists_url":"https://api.github.com/users/pmoravec/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoravec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoravec/subscriptions","organizations_url":"https://api.github.com/users/pmoravec/orgs","repos_url":"https://api.github.com/users/pmoravec/repos","events_url":"https://api.github.com/users/pmoravec/events{/privacy}","received_events_url":"https://api.github.com/users/pmoravec/received_events","type":"User","site_admin":false},"body":".. instead of tailing all (log)files\r\n\r\nUpdate calling add_files (modified in foreman-debug).\r\n\r\nSigned-off-by: Pavel Moravec <pmoravec@redhat.com>","created_at":"2016-09-24T10:02:14Z","updated_at":"2016-10-25T10:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ba993f6b6fab9ca275b04cc2cc028f27ab38262","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461/commits","review_comments_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461/comments","review_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/461/comments","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/bb7198830af76c9918745e72ae812711da103196","head":{"label":"pmoravec:smart-proxy-pmoravec-foreman-debug-newest-files","ref":"smart-proxy-pmoravec-foreman-debug-newest-files","sha":"bb7198830af76c9918745e72ae812711da103196","user":{"login":"pmoravec","id":4340368,"avatar_url":"https://avatars.githubusercontent.com/u/4340368?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoravec","html_url":"https://github.com/pmoravec","followers_url":"https://api.github.com/users/pmoravec/followers","following_url":"https://api.github.com/users/pmoravec/following{/other_user}","gists_url":"https://api.github.com/users/pmoravec/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoravec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoravec/subscriptions","organizations_url":"https://api.github.com/users/pmoravec/orgs","repos_url":"https://api.github.com/users/pmoravec/repos","events_url":"https://api.github.com/users/pmoravec/events{/privacy}","received_events_url":"https://api.github.com/users/pmoravec/received_events","type":"User","site_admin":false},"repo":{"id":69088745,"name":"smart-proxy","full_name":"pmoravec/smart-proxy","owner":{"login":"pmoravec","id":4340368,"avatar_url":"https://avatars.githubusercontent.com/u/4340368?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoravec","html_url":"https://github.com/pmoravec","followers_url":"https://api.github.com/users/pmoravec/followers","following_url":"https://api.github.com/users/pmoravec/following{/other_user}","gists_url":"https://api.github.com/users/pmoravec/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoravec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoravec/subscriptions","organizations_url":"https://api.github.com/users/pmoravec/orgs","repos_url":"https://api.github.com/users/pmoravec/repos","events_url":"https://api.github.com/users/pmoravec/events{/privacy}","received_events_url":"https://api.github.com/users/pmoravec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmoravec/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP, BMC and Puppet","fork":true,"url":"https://api.github.com/repos/pmoravec/smart-proxy","forks_url":"https://api.github.com/repos/pmoravec/smart-proxy/forks","keys_url":"https://api.github.com/repos/pmoravec/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmoravec/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmoravec/smart-proxy/teams","hooks_url":"https://api.github.com/repos/pmoravec/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/pmoravec/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/pmoravec/smart-proxy/events","assignees_url":"https://api.github.com/repos/pmoravec/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/pmoravec/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/pmoravec/smart-proxy/tags","blobs_url":"https://api.github.com/repos/pmoravec/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmoravec/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmoravec/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmoravec/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmoravec/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/pmoravec/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/pmoravec/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/pmoravec/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/pmoravec/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/pmoravec/smart-proxy/subscription","commits_url":"https://api.github.com/repos/pmoravec/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmoravec/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmoravec/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmoravec/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmoravec/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/pmoravec/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmoravec/smart-proxy/merges","archive_url":"https://api.github.com/repos/pmoravec/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmoravec/smart-proxy/downloads","issues_url":"https://api.github.com/repos/pmoravec/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/pmoravec/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/pmoravec/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/pmoravec/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmoravec/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/pmoravec/smart-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/pmoravec/smart-proxy/deployments","created_at":"2016-09-24T07:56:55Z","updated_at":"2016-09-24T07:56:58Z","pushed_at":"2016-10-24T12:04:26Z","git_url":"git://github.com/pmoravec/smart-proxy.git","ssh_url":"git@github.com:pmoravec/smart-proxy.git","clone_url":"https://github.com/pmoravec/smart-proxy.git","svn_url":"https://github.com/pmoravec/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":1477,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"78da2d1ef03ac150812226946ac1ec546838624c","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":986551,"name":"smart-proxy","full_name":"theforeman/smart-proxy","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP, BMC and Puppet","fork":false,"url":"https://api.github.com/repos/theforeman/smart-proxy","forks_url":"https://api.github.com/repos/theforeman/smart-proxy/forks","keys_url":"https://api.github.com/repos/theforeman/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/smart-proxy/teams","hooks_url":"https://api.github.com/repos/theforeman/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/smart-proxy/events","assignees_url":"https://api.github.com/repos/theforeman/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/smart-proxy/tags","blobs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/theforeman/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/theforeman/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/theforeman/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/theforeman/smart-proxy/subscription","commits_url":"https://api.github.com/repos/theforeman/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/smart-proxy/merges","archive_url":"https://api.github.com/repos/theforeman/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/smart-proxy/downloads","issues_url":"https://api.github.com/repos/theforeman/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/smart-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/smart-proxy/deployments","created_at":"2010-10-14T10:00:51Z","updated_at":"2016-10-18T19:45:02Z","pushed_at":"2016-10-25T08:35:16Z","git_url":"git://github.com/theforeman/smart-proxy.git","ssh_url":"git@github.com:theforeman/smart-proxy.git","clone_url":"https://github.com/theforeman/smart-proxy.git","svn_url":"https://github.com/theforeman/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":2165,"stargazers_count":134,"watchers_count":134,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":18,"forks":166,"open_issues":18,"watchers":134,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461"},"html":{"href":"https://github.com/theforeman/smart-proxy/pull/461"},"issue":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/461"},"comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/smart-proxy/statuses/bb7198830af76c9918745e72ae812711da103196"}}}}
{"actor":{"display_login":"witlessbird"}}