{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/73197400","id":73197400,"diff_hunk":"@@ -278,8 +278,8 @@ namespace Js {\n         virtual BOOL GetEnumerator(BOOL enumNonEnumerable, Var* enumerator, ScriptContext * requestContext, bool preferSnapshotSemantics = true, bool enumSymbols = false);\n         virtual BOOL ToPrimitive(JavascriptHint hint, Var* value, ScriptContext * requestContext);\n         virtual BOOL SetAccessors(PropertyId propertyId, Var getter, Var setter, PropertyOperationFlags flags = PropertyOperation_None);\n-        virtual BOOL Equals(Var other, BOOL* value, ScriptContext* requestContext);\n-        virtual BOOL StrictEquals(Var other, BOOL* value, ScriptContext* requestContext);\n+        virtual BOOL Equals(__in Var other, __out BOOL* value, ScriptContext* requestContext);\n+        virtual BOOL StrictEquals(__in Var other, __out BOOL* value, ScriptContext* requestContext);","path":"lib/Runtime/Types/RecyclableObject.h","position":7,"original_position":7,"commit_id":"45535dd562285d15e5613d3accd2588562a7b1b2","original_commit_id":"45535dd562285d15e5613d3accd2588562a7b1b2","user":{"login":"Yongqu","id":6556530,"avatar_url":"https://avatars.githubusercontent.com/u/6556530?v=3","gravatar_id":"","url":"https://api.github.com/users/Yongqu","html_url":"https://github.com/Yongqu","followers_url":"https://api.github.com/users/Yongqu/followers","following_url":"https://api.github.com/users/Yongqu/following{/other_user}","gists_url":"https://api.github.com/users/Yongqu/gists{/gist_id}","starred_url":"https://api.github.com/users/Yongqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yongqu/subscriptions","organizations_url":"https://api.github.com/users/Yongqu/orgs","repos_url":"https://api.github.com/users/Yongqu/repos","events_url":"https://api.github.com/users/Yongqu/events{/privacy}","received_events_url":"https://api.github.com/users/Yongqu/received_events","type":"User","site_admin":false},"body":"does this require the output to be set on return (compiler warning otherwise?)","created_at":"2016-08-02T17:15:25Z","updated_at":"2016-08-02T17:15:25Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1365#discussion_r73197400","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/73197400"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1365#discussion_r73197400"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365","id":79605334,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1365","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1365.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1365.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1365","number":1365,"state":"open","locked":false,"title":"Add SAL annotations to Equals and StrictEquals","user":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-01T17:31:24Z","updated_at":"2016-08-02T17:15:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3448d8fa3f794d9e9223bf215c9e62ff1e86427","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1365/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/45535dd562285d15e5613d3accd2588562a7b1b2","head":{"label":"agarwal-sandeep:addsal","ref":"addsal","sha":"45535dd562285d15e5613d3accd2588562a7b1b2","user":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"repo":{"id":51044322,"name":"ChakraCore","full_name":"agarwal-sandeep/ChakraCore","owner":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agarwal-sandeep/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore","forks_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/forks","keys_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/teams","hooks_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/events","assignees_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/tags","blobs_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/subscription","commits_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/merges","archive_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/downloads","issues_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/deployments","created_at":"2016-02-04T01:40:19Z","updated_at":"2016-02-04T01:40:34Z","pushed_at":"2016-08-01T17:31:24Z","git_url":"git://github.com/agarwal-sandeep/ChakraCore.git","ssh_url":"git@github.com:agarwal-sandeep/ChakraCore.git","clone_url":"https://github.com/agarwal-sandeep/ChakraCore.git","svn_url":"https://github.com/agarwal-sandeep/ChakraCore","homepage":null,"size":33124,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"6390a6c9fb46be7feceef32fdcb25d5085a9c8c9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-08-02T14:01:49Z","pushed_at":"2016-08-02T13:13:20Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":45025,"stargazers_count":5495,"watchers_count":5495,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":611,"mirror_url":null,"open_issues_count":165,"forks":611,"open_issues":165,"watchers":5495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1365"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1365"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1365/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1365/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/45535dd562285d15e5613d3accd2588562a7b1b2"}}}}
{"actor":{"display_login":"Yongqu"}}