{"action":"opened","number":488,"pull_request":{"url":"https://api.github.com/repos/vhbb/cmssw/pulls/488","id":77488772,"html_url":"https://github.com/vhbb/cmssw/pull/488","diff_url":"https://github.com/vhbb/cmssw/pull/488.diff","patch_url":"https://github.com/vhbb/cmssw/pull/488.patch","issue_url":"https://api.github.com/repos/vhbb/cmssw/issues/488","number":488,"state":"open","locked":false,"title":"L1objects for heppy","user":{"login":"silviodonato","id":6177433,"avatar_url":"https://avatars.githubusercontent.com/u/6177433?v=3","gravatar_id":"","url":"https://api.github.com/users/silviodonato","html_url":"https://github.com/silviodonato","followers_url":"https://api.github.com/users/silviodonato/followers","following_url":"https://api.github.com/users/silviodonato/following{/other_user}","gists_url":"https://api.github.com/users/silviodonato/gists{/gist_id}","starred_url":"https://api.github.com/users/silviodonato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silviodonato/subscriptions","organizations_url":"https://api.github.com/users/silviodonato/orgs","repos_url":"https://api.github.com/users/silviodonato/repos","events_url":"https://api.github.com/users/silviodonato/events{/privacy}","received_events_url":"https://api.github.com/users/silviodonato/received_events","type":"User","site_admin":false},"body":"This code add the L1stage-2 objects in the VHbb ntuples (eg. L1 jets).\r\n\r\nA few comments:\r\n- At the moment, the L1 stage-2 objects are contained only in data and \"reHLT\" MC\r\n- https://github.com/silviodonato/cmssw/blob/l1objects_Heppy/VHbbAnalysis/Heppy/test/vhbb.py#L396 needs to be overwritten with 'HLT2' in order to run with the reHLT samples \r\n- I needed to use an ugly repetitions of try/except in  https://github.com/silviodonato/cmssw/blob/l1objects_Heppy/PhysicsTools/Heppy/python/analyzers/core/L1TriggerAnalyzer.py#L45 in order to have a code working also with the no-reHLT MC\r\n     - I tried to use the isValid() command, but it is always False until you call product()\r\n     - I prefered to keep separated loops for each kind of object (jets,taus, EGammas, muons) \r\n\r\nI intend also to add two important features:\r\n- add the L1 prescale information\r\n- add more information about the object (eg. isolation for  EGamma objects).","created_at":"2016-07-14T16:50:46Z","updated_at":"2016-07-14T16:50:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vhbb/cmssw/pulls/488/commits","review_comments_url":"https://api.github.com/repos/vhbb/cmssw/pulls/488/comments","review_comment_url":"https://api.github.com/repos/vhbb/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vhbb/cmssw/issues/488/comments","statuses_url":"https://api.github.com/repos/vhbb/cmssw/statuses/c388185a1f7a73c501f8adb94c67f30259c510ac","head":{"label":"silviodonato:l1objects_Heppy","ref":"l1objects_Heppy","sha":"c388185a1f7a73c501f8adb94c67f30259c510ac","user":{"login":"silviodonato","id":6177433,"avatar_url":"https://avatars.githubusercontent.com/u/6177433?v=3","gravatar_id":"","url":"https://api.github.com/users/silviodonato","html_url":"https://github.com/silviodonato","followers_url":"https://api.github.com/users/silviodonato/followers","following_url":"https://api.github.com/users/silviodonato/following{/other_user}","gists_url":"https://api.github.com/users/silviodonato/gists{/gist_id}","starred_url":"https://api.github.com/users/silviodonato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silviodonato/subscriptions","organizations_url":"https://api.github.com/users/silviodonato/orgs","repos_url":"https://api.github.com/users/silviodonato/repos","events_url":"https://api.github.com/users/silviodonato/events{/privacy}","received_events_url":"https://api.github.com/users/silviodonato/received_events","type":"User","site_admin":false},"repo":{"id":15160975,"name":"cmssw","full_name":"silviodonato/cmssw","owner":{"login":"silviodonato","id":6177433,"avatar_url":"https://avatars.githubusercontent.com/u/6177433?v=3","gravatar_id":"","url":"https://api.github.com/users/silviodonato","html_url":"https://github.com/silviodonato","followers_url":"https://api.github.com/users/silviodonato/followers","following_url":"https://api.github.com/users/silviodonato/following{/other_user}","gists_url":"https://api.github.com/users/silviodonato/gists{/gist_id}","starred_url":"https://api.github.com/users/silviodonato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silviodonato/subscriptions","organizations_url":"https://api.github.com/users/silviodonato/orgs","repos_url":"https://api.github.com/users/silviodonato/repos","events_url":"https://api.github.com/users/silviodonato/events{/privacy}","received_events_url":"https://api.github.com/users/silviodonato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/silviodonato/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/silviodonato/cmssw","forks_url":"https://api.github.com/repos/silviodonato/cmssw/forks","keys_url":"https://api.github.com/repos/silviodonato/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silviodonato/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silviodonato/cmssw/teams","hooks_url":"https://api.github.com/repos/silviodonato/cmssw/hooks","issue_events_url":"https://api.github.com/repos/silviodonato/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/silviodonato/cmssw/events","assignees_url":"https://api.github.com/repos/silviodonato/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/silviodonato/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/silviodonato/cmssw/tags","blobs_url":"https://api.github.com/repos/silviodonato/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silviodonato/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silviodonato/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/silviodonato/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silviodonato/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/silviodonato/cmssw/languages","stargazers_url":"https://api.github.com/repos/silviodonato/cmssw/stargazers","contributors_url":"https://api.github.com/repos/silviodonato/cmssw/contributors","subscribers_url":"https://api.github.com/repos/silviodonato/cmssw/subscribers","subscription_url":"https://api.github.com/repos/silviodonato/cmssw/subscription","commits_url":"https://api.github.com/repos/silviodonato/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/silviodonato/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/silviodonato/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/silviodonato/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/silviodonato/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/silviodonato/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silviodonato/cmssw/merges","archive_url":"https://api.github.com/repos/silviodonato/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silviodonato/cmssw/downloads","issues_url":"https://api.github.com/repos/silviodonato/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/silviodonato/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/silviodonato/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/silviodonato/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silviodonato/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/silviodonato/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/silviodonato/cmssw/deployments","created_at":"2013-12-13T10:29:37Z","updated_at":"2014-06-25T05:12:33Z","pushed_at":"2016-07-14T16:37:11Z","git_url":"git://github.com/silviodonato/cmssw.git","ssh_url":"git@github.com:silviodonato/cmssw.git","clone_url":"https://github.com/silviodonato/cmssw.git","svn_url":"https://github.com/silviodonato/cmssw","homepage":"cms-sw.github.io/cmssw","size":1364153,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_4_1_X"}},"base":{"label":"vhbb:vhbbHeppy80X","ref":"vhbbHeppy80X","sha":"05bcb481cb5b4ede32ddb2cecabfaabc9a16d226","user":{"login":"vhbb","id":5072911,"avatar_url":"https://avatars.githubusercontent.com/u/5072911?v=3","gravatar_id":"","url":"https://api.github.com/users/vhbb","html_url":"https://github.com/vhbb","followers_url":"https://api.github.com/users/vhbb/followers","following_url":"https://api.github.com/users/vhbb/following{/other_user}","gists_url":"https://api.github.com/users/vhbb/gists{/gist_id}","starred_url":"https://api.github.com/users/vhbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhbb/subscriptions","organizations_url":"https://api.github.com/users/vhbb/orgs","repos_url":"https://api.github.com/users/vhbb/repos","events_url":"https://api.github.com/users/vhbb/events{/privacy}","received_events_url":"https://api.github.com/users/vhbb/received_events","type":"Organization","site_admin":false},"repo":{"id":11608804,"name":"cmssw","full_name":"vhbb/cmssw","owner":{"login":"vhbb","id":5072911,"avatar_url":"https://avatars.githubusercontent.com/u/5072911?v=3","gravatar_id":"","url":"https://api.github.com/users/vhbb","html_url":"https://github.com/vhbb","followers_url":"https://api.github.com/users/vhbb/followers","following_url":"https://api.github.com/users/vhbb/following{/other_user}","gists_url":"https://api.github.com/users/vhbb/gists{/gist_id}","starred_url":"https://api.github.com/users/vhbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhbb/subscriptions","organizations_url":"https://api.github.com/users/vhbb/orgs","repos_url":"https://api.github.com/users/vhbb/repos","events_url":"https://api.github.com/users/vhbb/events{/privacy}","received_events_url":"https://api.github.com/users/vhbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vhbb/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/vhbb/cmssw","forks_url":"https://api.github.com/repos/vhbb/cmssw/forks","keys_url":"https://api.github.com/repos/vhbb/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vhbb/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vhbb/cmssw/teams","hooks_url":"https://api.github.com/repos/vhbb/cmssw/hooks","issue_events_url":"https://api.github.com/repos/vhbb/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/vhbb/cmssw/events","assignees_url":"https://api.github.com/repos/vhbb/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/vhbb/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/vhbb/cmssw/tags","blobs_url":"https://api.github.com/repos/vhbb/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vhbb/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vhbb/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/vhbb/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vhbb/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/vhbb/cmssw/languages","stargazers_url":"https://api.github.com/repos/vhbb/cmssw/stargazers","contributors_url":"https://api.github.com/repos/vhbb/cmssw/contributors","subscribers_url":"https://api.github.com/repos/vhbb/cmssw/subscribers","subscription_url":"https://api.github.com/repos/vhbb/cmssw/subscription","commits_url":"https://api.github.com/repos/vhbb/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/vhbb/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/vhbb/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/vhbb/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/vhbb/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/vhbb/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vhbb/cmssw/merges","archive_url":"https://api.github.com/repos/vhbb/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vhbb/cmssw/downloads","issues_url":"https://api.github.com/repos/vhbb/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/vhbb/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/vhbb/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/vhbb/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vhbb/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/vhbb/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/vhbb/cmssw/deployments","created_at":"2013-07-23T13:22:20Z","updated_at":"2016-03-15T21:13:20Z","pushed_at":"2016-07-14T16:50:46Z","git_url":"git://github.com/vhbb/cmssw.git","ssh_url":"git@github.com:vhbb/cmssw.git","clone_url":"https://github.com/vhbb/cmssw.git","svn_url":"https://github.com/vhbb/cmssw","homepage":"cms-sw.github.io/cmssw","size":1304383,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":3,"default_branch":"vhbbHeppy80X"}},"_links":{"self":{"href":"https://api.github.com/repos/vhbb/cmssw/pulls/488"},"html":{"href":"https://github.com/vhbb/cmssw/pull/488"},"issue":{"href":"https://api.github.com/repos/vhbb/cmssw/issues/488"},"comments":{"href":"https://api.github.com/repos/vhbb/cmssw/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/vhbb/cmssw/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/vhbb/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vhbb/cmssw/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/vhbb/cmssw/statuses/c388185a1f7a73c501f8adb94c67f30259c510ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":128,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"silviodonato"}}