{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219","repository_url":"https://api.github.com/repos/Microsoft/vcpkg","labels_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219/comments","events_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219/events","html_url":"https://github.com/Microsoft/vcpkg/pull/219","id":185276114,"number":219,"title":"Qt5 add","user":{"login":"Barath-Kannan","id":3630546,"avatar_url":"https://avatars.githubusercontent.com/u/3630546?v=3","gravatar_id":"","url":"https://api.github.com/users/Barath-Kannan","html_url":"https://github.com/Barath-Kannan","followers_url":"https://api.github.com/users/Barath-Kannan/followers","following_url":"https://api.github.com/users/Barath-Kannan/following{/other_user}","gists_url":"https://api.github.com/users/Barath-Kannan/gists{/gist_id}","starred_url":"https://api.github.com/users/Barath-Kannan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barath-Kannan/subscriptions","organizations_url":"https://api.github.com/users/Barath-Kannan/orgs","repos_url":"https://api.github.com/users/Barath-Kannan/repos","events_url":"https://api.github.com/users/Barath-Kannan/events{/privacy}","received_events_url":"https://api.github.com/users/Barath-Kannan/received_events","type":"User","site_admin":false},"labels":[{"id":446354983,"url":"https://api.github.com/repos/Microsoft/vcpkg/labels/cla-signed","name":"cla-signed","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2016-10-26T01:41:41Z","updated_at":"2016-11-02T09:02:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vcpkg/pulls/219","html_url":"https://github.com/Microsoft/vcpkg/pull/219","diff_url":"https://github.com/Microsoft/vcpkg/pull/219.diff","patch_url":"https://github.com/Microsoft/vcpkg/pull/219.patch"},"body":"Added Qt5.7 application framework. The webengine, tests, and examples have been excluded as they would significantly increase the build time and storage requirements (it already needs like ~3GB for a dynamic build, and ~7GB for a static build). These can be added later in separate package. The webengine is also known to be very fickle during builds. I had to add in another function (vcpkg_execute_required_process_repeat) which will repeatedly try to build up to a certain number of failures, as the build can sometimes fail when performing a static build and just needs to be re-run to continue. I also added the jom tool; Qt's version of nmake which supports parallel builds. Without it, the build time would increase by several orders of magnitude. Qt already takes an hour or 2 to build and install so this would be very undesirable. Also of note, this package builds the open source version of Qt, which is LGPLv3. If needed, another package can be added for the commercial version. \n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/comments/257808192","html_url":"https://github.com/Microsoft/vcpkg/pull/219#issuecomment-257808192","issue_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219","id":257808192,"user":{"login":"Barath-Kannan","id":3630546,"avatar_url":"https://avatars.githubusercontent.com/u/3630546?v=3","gravatar_id":"","url":"https://api.github.com/users/Barath-Kannan","html_url":"https://github.com/Barath-Kannan","followers_url":"https://api.github.com/users/Barath-Kannan/followers","following_url":"https://api.github.com/users/Barath-Kannan/following{/other_user}","gists_url":"https://api.github.com/users/Barath-Kannan/gists{/gist_id}","starred_url":"https://api.github.com/users/Barath-Kannan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barath-Kannan/subscriptions","organizations_url":"https://api.github.com/users/Barath-Kannan/orgs","repos_url":"https://api.github.com/users/Barath-Kannan/repos","events_url":"https://api.github.com/users/Barath-Kannan/events{/privacy}","received_events_url":"https://api.github.com/users/Barath-Kannan/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T09:02:52Z","updated_at":"2016-11-02T09:02:52Z","body":"I've merged your changes @barcharcraz, but do we really want the tests in the base directory?\r\n@ras0219-msft actually I thought that there were preprocessor directives for a namespace wrapper around 3rd party library calls so that it can use system/inbuilt safely without creating ambiguity, but I just checked the source and it seems I was mistaken, so there is some risk there"}}
{"actor":{"display_login":"Barath-Kannan"}}