{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/892","repository_url":"https://api.github.com/repos/Microsoft/ChakraCore","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/892/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/892/comments","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/892/events","html_url":"https://github.com/Microsoft/ChakraCore/pull/892","id":151930172,"number":892,"title":"Fixing scope issues with function expressions with split scope","user":{"login":"aneeshdk","id":5985960,"avatar_url":"https://avatars.githubusercontent.com/u/5985960?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshdk","html_url":"https://github.com/aneeshdk","followers_url":"https://api.github.com/users/aneeshdk/followers","following_url":"https://api.github.com/users/aneeshdk/following{/other_user}","gists_url":"https://api.github.com/users/aneeshdk/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshdk/subscriptions","organizations_url":"https://api.github.com/users/aneeshdk/orgs","repos_url":"https://api.github.com/users/aneeshdk/repos","events_url":"https://api.github.com/users/aneeshdk/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshdk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/cla-not-required","name":"cla-not-required","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-29T17:40:04Z","updated_at":"2016-04-30T00:03:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/892","html_url":"https://github.com/Microsoft/ChakraCore/pull/892","diff_url":"https://github.com/Microsoft/ChakraCore/pull/892.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/892.patch"},"body":"This change fixes multiple issues with using function expression symbols in split scope.\n\nOne issue was if the function expression is not captured and has not eval\nthen we were adding the function expression symbol to body scope. In split\nscope case I changed it to add to the param scope. But we don't have to\nduplicate the function expression name symbol in the body.\n\nFunction expression should be pop out only after taking out the param scope. Another issue was while creating the new frame display during BeginBodyScope we have to skip the function expression.\n\nIn split scope the body scope was always getting marked as must\ninstantiate even though no closure was there in the body scope. I added a\nnew flag to the scope object to mark whether a closure is there.\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments/215911219","html_url":"https://github.com/Microsoft/ChakraCore/pull/892#issuecomment-215911219","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/892","id":215911219,"user":{"login":"dilijev","id":494055,"avatar_url":"https://avatars.githubusercontent.com/u/494055?v=3","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false},"created_at":"2016-04-30T00:03:11Z","updated_at":"2016-04-30T00:03:11Z","body":"@dotnet-bot test this please"}}