{"action":"closed","number":4271,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/4271","id":86624757,"html_url":"https://github.com/brave/browser-laptop/pull/4271","diff_url":"https://github.com/brave/browser-laptop/pull/4271.diff","patch_url":"https://github.com/brave/browser-laptop/pull/4271.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/4271","number":4271,"state":"closed","locked":false,"title":"Update favicon from importer","user":{"login":"darkdh","id":11330831,"avatar_url":"https://avatars.githubusercontent.com/u/11330831?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n\r\nfix #4270\r\n\r\nAuditors: @bbondy\r\n\r\nTest Plan:\r\n1. Make sure \"Favicons\" in \"about:preferences#general\" is on\r\n2. Import bookmarks from other browser or html file\r\n3. There should be favicon for bookmarks","created_at":"2016-09-24T17:32:07Z","updated_at":"2016-09-26T15:17:14Z","closed_at":"2016-09-26T15:17:13Z","merged_at":"2016-09-26T15:17:13Z","merge_commit_sha":"17256bfe7cef35c29bd18cd3917f4f6f105b8f52","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/4271/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/4271/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/4271/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/2520fe394c1840f0daaeaf82f4cf0f6da1a10510","head":{"label":"darkdh:4270","ref":"4270","sha":"2520fe394c1840f0daaeaf82f4cf0f6da1a10510","user":{"login":"darkdh","id":11330831,"avatar_url":"https://avatars.githubusercontent.com/u/11330831?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false},"repo":{"id":61865077,"name":"browser-laptop","full_name":"darkdh/browser-laptop","owner":{"login":"darkdh","id":11330831,"avatar_url":"https://avatars.githubusercontent.com/u/11330831?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darkdh/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/darkdh/browser-laptop","forks_url":"https://api.github.com/repos/darkdh/browser-laptop/forks","keys_url":"https://api.github.com/repos/darkdh/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkdh/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkdh/browser-laptop/teams","hooks_url":"https://api.github.com/repos/darkdh/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/darkdh/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/darkdh/browser-laptop/events","assignees_url":"https://api.github.com/repos/darkdh/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/darkdh/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/darkdh/browser-laptop/tags","blobs_url":"https://api.github.com/repos/darkdh/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkdh/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkdh/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkdh/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkdh/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/darkdh/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/darkdh/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/darkdh/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/darkdh/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/darkdh/browser-laptop/subscription","commits_url":"https://api.github.com/repos/darkdh/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkdh/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkdh/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkdh/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkdh/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/darkdh/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkdh/browser-laptop/merges","archive_url":"https://api.github.com/repos/darkdh/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkdh/browser-laptop/downloads","issues_url":"https://api.github.com/repos/darkdh/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/darkdh/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/darkdh/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/darkdh/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkdh/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/darkdh/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/darkdh/browser-laptop/deployments","created_at":"2016-06-24T07:21:11Z","updated_at":"2016-06-24T07:21:14Z","pushed_at":"2016-09-25T15:10:47Z","git_url":"git://github.com/darkdh/browser-laptop.git","ssh_url":"git@github.com:darkdh/browser-laptop.git","clone_url":"https://github.com/darkdh/browser-laptop.git","svn_url":"https://github.com/darkdh/browser-laptop","homepage":"https://www.brave.com","size":28630,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"bbf5fc9cc54992dadafc88d5f9c96643d28640f7","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-09-26T13:44:57Z","pushed_at":"2016-09-26T15:17:14Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":40488,"stargazers_count":3483,"watchers_count":3483,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":1222,"forks":393,"open_issues":1222,"watchers":3483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4271"},"html":{"href":"https://github.com/brave/browser-laptop/pull/4271"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/4271"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/4271/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4271/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4271/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/2520fe394c1840f0daaeaf82f4cf0f6da1a10510"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":14,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"bbondy"}}