{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5230","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5230/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5230/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5230/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/5230","id":182399574,"number":5230,"title":"massive rewrite to boto3","user":{"login":"tedder","id":97914,"avatar_url":"https://avatars.githubusercontent.com/u/97914?v=3","gravatar_id":"","url":"https://api.github.com/users/tedder","html_url":"https://github.com/tedder","followers_url":"https://api.github.com/users/tedder/followers","following_url":"https://api.github.com/users/tedder/following{/other_user}","gists_url":"https://api.github.com/users/tedder/gists{/gist_id}","starred_url":"https://api.github.com/users/tedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedder/subscriptions","organizations_url":"https://api.github.com/users/tedder/orgs","repos_url":"https://api.github.com/users/tedder/repos","events_url":"https://api.github.com/users/tedder/events{/privacy}","received_events_url":"https://api.github.com/users/tedder/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/cloud","name":"cloud","color":"c7def8"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/feature_pull_request","name":"feature_pull_request","color":"006b75"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/needs_revision","name":"needs_revision","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-10-11T23:28:07Z","updated_at":"2016-10-18T03:25:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/5230","html_url":"https://github.com/ansible/ansible-modules-core/pull/5230","diff_url":"https://github.com/ansible/ansible-modules-core/pull/5230.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/5230.patch"},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\ncloudformation\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\nansible 2.2.0 (devel 1f03801fcc) last updated 2016/09/29 14:29:35 (GMT -700)\r\n  lib/ansible/modules/core: (cloudformation_to_boto3 5868eab238) last updated 2016/10/11 16:18:32 (GMT -700)\r\n  lib/ansible/modules/extras: (devel 6c31d91fa5) last updated 2016/10/11 16:10:16 (GMT -700)\r\n  config file = \r\n  configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\nCompletely rewrote cloudformation to boto3. I believe this is allowed/expected in 2.3.\r\n\r\n- removed star-imports, which wasn't possible in Ansible 1.x\r\n- boto doesn't have any of the modern features (most notably, changesets), so this rewrite goes all-in on boto3.\r\n- tags are updateable, at least in boto3. Fix documentation.\r\n- staying with \"ansible yaml to json conversion\" because I'm trying to keep this scoped properly. The next PR will have AWS-native yaml support.\r\n- documented the output. Tried to leave it backwards-compatible but the changes to 'events' might break someone's flow. However, the existing data wasn't terribly useful so I don't assume it will hurt.\r\n- split up the code into functions. This should make unit testing possible.\r\n- added forward-facing code: 'six' for iterating, started using AWSRetry, common tag conversion.\r\n- add todo list\r\n\r\nI'm concerned that the listed maintainer, @jsmartin, is not around. He has very little activity on his github profile, and there are a bunch of pending pull requests for this module: #4517 #2819 #1224 #5112 #3293 #2314 #1460 #1370 "},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/254396838","html_url":"https://github.com/ansible/ansible-modules-core/pull/5230#issuecomment-254396838","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5230","id":254396838,"user":{"login":"gregdek","id":252125,"avatar_url":"https://avatars.githubusercontent.com/u/252125?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdek","html_url":"https://github.com/gregdek","followers_url":"https://api.github.com/users/gregdek/followers","following_url":"https://api.github.com/users/gregdek/following{/other_user}","gists_url":"https://api.github.com/users/gregdek/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdek/subscriptions","organizations_url":"https://api.github.com/users/gregdek/orgs","repos_url":"https://api.github.com/users/gregdek/repos","events_url":"https://api.github.com/users/gregdek/events{/privacy}","received_events_url":"https://api.github.com/users/gregdek/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T03:25:18Z","updated_at":"2016-10-18T03:25:18Z","body":"Thanks @tedder for this PR. This PR requires revisions, either because it fails to build or by reviewer request. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.\n\n[This message brought to you by your friendly Ansibull-bot.]"}}
{"actor":{"display_login":"gregdek"}}