{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/56714535","id":56714535,"diff_hunk":"@@ -1,15 +1,17 @@\n {% set metrics_memory = \"200Mi\" -%}\n {% set eventer_memory = \"200Mi\" -%}\n+{% set metrics_memory_per_node = 4 -%}","path":"cluster/addons/cluster-monitoring/google/heapster-controller.yaml","position":3,"original_position":3,"commit_id":"726bbc4bfce110601fc17bf568386e413b4bd3de","original_commit_id":"726bbc4bfce110601fc17bf568386e413b4bd3de","user":{"login":"Q-Lee","id":13410337,"avatar_url":"https://avatars.githubusercontent.com/u/13410337?v=3","gravatar_id":"","url":"https://api.github.com/users/Q-Lee","html_url":"https://github.com/Q-Lee","followers_url":"https://api.github.com/users/Q-Lee/followers","following_url":"https://api.github.com/users/Q-Lee/following{/other_user}","gists_url":"https://api.github.com/users/Q-Lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Q-Lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Q-Lee/subscriptions","organizations_url":"https://api.github.com/users/Q-Lee/orgs","repos_url":"https://api.github.com/users/Q-Lee/repos","events_url":"https://api.github.com/users/Q-Lee/events{/privacy}","received_events_url":"https://api.github.com/users/Q-Lee/received_events","type":"User","site_admin":false},"body":"I can't, because I use this constant in math down below. Unless you mean something like \"metrics_memory_per_node_unit\"?","created_at":"2016-03-18T20:05:25Z","updated_at":"2016-03-18T20:05:25Z","html_url":"https://github.com/kubernetes/kubernetes/pull/22893#discussion_r56714535","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/56714535"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22893#discussion_r56714535"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893","id":62626651,"html_url":"https://github.com/kubernetes/kubernetes/pull/22893","diff_url":"https://github.com/kubernetes/kubernetes/pull/22893.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/22893.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22893","number":22893,"state":"open","locked":false,"title":"Support addon Deployments, make heapster a deployment with a nanny.","user":{"login":"Q-Lee","id":13410337,"avatar_url":"https://avatars.githubusercontent.com/u/13410337?v=3","gravatar_id":"","url":"https://api.github.com/users/Q-Lee","html_url":"https://github.com/Q-Lee","followers_url":"https://api.github.com/users/Q-Lee/followers","following_url":"https://api.github.com/users/Q-Lee/following{/other_user}","gists_url":"https://api.github.com/users/Q-Lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Q-Lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Q-Lee/subscriptions","organizations_url":"https://api.github.com/users/Q-Lee/orgs","repos_url":"https://api.github.com/users/Q-Lee/repos","events_url":"https://api.github.com/users/Q-Lee/events{/privacy}","received_events_url":"https://api.github.com/users/Q-Lee/received_events","type":"User","site_admin":false},"body":"1. Heapster uses a deployment here.\r\n2. Changed kube-addon-update.sh to include deployments (this seems like a transitional change while we're moving all addons to deployments).\r\n3. Adding a nanny to resize heapster with the number of nodes.\r\n\r\n\r\n\r\n","created_at":"2016-03-12T01:45:58Z","updated_at":"2016-03-18T20:05:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81f9e3827eac0173a3da289886b8017a2e90e75e","assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22893/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/726bbc4bfce110601fc17bf568386e413b4bd3de","head":{"label":"Q-Lee:nanny-heapster","ref":"nanny-heapster","sha":"726bbc4bfce110601fc17bf568386e413b4bd3de","user":{"login":"Q-Lee","id":13410337,"avatar_url":"https://avatars.githubusercontent.com/u/13410337?v=3","gravatar_id":"","url":"https://api.github.com/users/Q-Lee","html_url":"https://github.com/Q-Lee","followers_url":"https://api.github.com/users/Q-Lee/followers","following_url":"https://api.github.com/users/Q-Lee/following{/other_user}","gists_url":"https://api.github.com/users/Q-Lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Q-Lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Q-Lee/subscriptions","organizations_url":"https://api.github.com/users/Q-Lee/orgs","repos_url":"https://api.github.com/users/Q-Lee/repos","events_url":"https://api.github.com/users/Q-Lee/events{/privacy}","received_events_url":"https://api.github.com/users/Q-Lee/received_events","type":"User","site_admin":false},"repo":{"id":51333025,"name":"kubernetes","full_name":"Q-Lee/kubernetes","owner":{"login":"Q-Lee","id":13410337,"avatar_url":"https://avatars.githubusercontent.com/u/13410337?v=3","gravatar_id":"","url":"https://api.github.com/users/Q-Lee","html_url":"https://github.com/Q-Lee","followers_url":"https://api.github.com/users/Q-Lee/followers","following_url":"https://api.github.com/users/Q-Lee/following{/other_user}","gists_url":"https://api.github.com/users/Q-Lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Q-Lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Q-Lee/subscriptions","organizations_url":"https://api.github.com/users/Q-Lee/orgs","repos_url":"https://api.github.com/users/Q-Lee/repos","events_url":"https://api.github.com/users/Q-Lee/events{/privacy}","received_events_url":"https://api.github.com/users/Q-Lee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Q-Lee/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/Q-Lee/kubernetes","forks_url":"https://api.github.com/repos/Q-Lee/kubernetes/forks","keys_url":"https://api.github.com/repos/Q-Lee/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Q-Lee/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Q-Lee/kubernetes/teams","hooks_url":"https://api.github.com/repos/Q-Lee/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Q-Lee/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Q-Lee/kubernetes/events","assignees_url":"https://api.github.com/repos/Q-Lee/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Q-Lee/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Q-Lee/kubernetes/tags","blobs_url":"https://api.github.com/repos/Q-Lee/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Q-Lee/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Q-Lee/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Q-Lee/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Q-Lee/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Q-Lee/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Q-Lee/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Q-Lee/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Q-Lee/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Q-Lee/kubernetes/subscription","commits_url":"https://api.github.com/repos/Q-Lee/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Q-Lee/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Q-Lee/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Q-Lee/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Q-Lee/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Q-Lee/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Q-Lee/kubernetes/merges","archive_url":"https://api.github.com/repos/Q-Lee/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Q-Lee/kubernetes/downloads","issues_url":"https://api.github.com/repos/Q-Lee/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Q-Lee/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Q-Lee/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Q-Lee/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Q-Lee/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Q-Lee/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Q-Lee/kubernetes/deployments","created_at":"2016-02-08T22:49:53Z","updated_at":"2016-02-08T22:50:05Z","pushed_at":"2016-03-18T00:12:14Z","git_url":"git://github.com/Q-Lee/kubernetes.git","ssh_url":"git@github.com:Q-Lee/kubernetes.git","clone_url":"https://github.com/Q-Lee/kubernetes.git","svn_url":"https://github.com/Q-Lee/kubernetes","homepage":"http://kubernetes.io","size":181913,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"62c737324ed2d62c590009f8ae740133d788761c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-03-18T20:05:20Z","pushed_at":"2016-03-18T20:05:11Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":344142,"stargazers_count":13320,"watchers_count":13320,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3859,"mirror_url":null,"open_issues_count":3029,"forks":3859,"open_issues":3029,"watchers":13320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22893"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22893"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22893/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22893/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/726bbc4bfce110601fc17bf568386e413b4bd3de"}}}}