{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/75917856","id":75917856,"diff_hunk":"@@ -287,17 +428,45 @@ func (rc *raftNode) serveChannels() {\n \t\tcase <-ticker.C:\n \t\t\trc.node.Tick()\n \n-\t\t// store raft entries to wal, then publish over commit channel\n+\t\t\t// store raft entries to wal, then publish over commit channel\n \t\tcase rd := <-rc.node.Ready():\n-\t\t\trc.wal.Save(rd.HardState, rd.Entries)\n+\t\t\tisLeader := false\n+\t\t\tif rd.SoftState != nil && rd.SoftState.RaftState == raft.StateLeader {\n+\t\t\t\tisLeader = true\n+\t\t\t}\n+\n+\t\t\tapplyDone := make(chan bool)\n+\t\t\tgo rc.applyAll(pr, &apply{\n+\t\t\t\tentriesToApply: rd.CommittedEntries,\n+\t\t\t\tsnapshotToSave: rd.Snapshot,\n+\t\t\t\tapplyDone:      applyDone,\n+\t\t\t})\n+\n+\t\t\t// (Raft §10.2.1 Writing to the leader’s disk in parallel, p.141)","path":"contrib/raftexample/raft.go","position":278,"original_position":278,"commit_id":"95e1160e07ea0e110b55673740a99f99739c6545","original_commit_id":"95e1160e07ea0e110b55673740a99f99739c6545","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"body":"Ok will keep it simple. Thanks.","created_at":"2016-08-23T17:53:54Z","updated_at":"2016-08-23T17:53:54Z","html_url":"https://github.com/coreos/etcd/pull/6244#discussion_r75917856","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/6244","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/75917856"},"html":{"href":"https://github.com/coreos/etcd/pull/6244#discussion_r75917856"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6244"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/6244","id":82284356,"html_url":"https://github.com/coreos/etcd/pull/6244","diff_url":"https://github.com/coreos/etcd/pull/6244.diff","patch_url":"https://github.com/coreos/etcd/pull/6244.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/6244","number":6244,"state":"open","locked":false,"title":"raftexample: implement Raft snapshot (like etcdserver)","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/coreos/etcd/issues/4019.\r\n\r\nTried to make it work like etcdserver snapshot, with simple storage backend.\r\nTests became a bit messy when `raftNode` embeds `kvstore`, though.\r\n\r\nPlease review. Thanks.\r\n/cc @heyitsanthony @xiang90 \r\n","created_at":"2016-08-23T00:11:18Z","updated_at":"2016-08-23T17:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9305b326665a51127b00d42c86934e9bab7d02d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/6244/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/6244/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/6244/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/95e1160e07ea0e110b55673740a99f99739c6545","head":{"label":"gyuho:raft-example","ref":"raft-example","sha":"95e1160e07ea0e110b55673740a99f99739c6545","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"repo":{"id":42982042,"name":"etcd","full_name":"gyuho/etcd","owner":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gyuho/etcd","description":"A distributed consistent key-value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/gyuho/etcd","forks_url":"https://api.github.com/repos/gyuho/etcd/forks","keys_url":"https://api.github.com/repos/gyuho/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gyuho/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gyuho/etcd/teams","hooks_url":"https://api.github.com/repos/gyuho/etcd/hooks","issue_events_url":"https://api.github.com/repos/gyuho/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/gyuho/etcd/events","assignees_url":"https://api.github.com/repos/gyuho/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/gyuho/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/gyuho/etcd/tags","blobs_url":"https://api.github.com/repos/gyuho/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gyuho/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gyuho/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gyuho/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gyuho/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/gyuho/etcd/languages","stargazers_url":"https://api.github.com/repos/gyuho/etcd/stargazers","contributors_url":"https://api.github.com/repos/gyuho/etcd/contributors","subscribers_url":"https://api.github.com/repos/gyuho/etcd/subscribers","subscription_url":"https://api.github.com/repos/gyuho/etcd/subscription","commits_url":"https://api.github.com/repos/gyuho/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gyuho/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gyuho/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gyuho/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gyuho/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/gyuho/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gyuho/etcd/merges","archive_url":"https://api.github.com/repos/gyuho/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gyuho/etcd/downloads","issues_url":"https://api.github.com/repos/gyuho/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/gyuho/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/gyuho/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/gyuho/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gyuho/etcd/labels{/name}","releases_url":"https://api.github.com/repos/gyuho/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/gyuho/etcd/deployments","created_at":"2015-09-23T06:15:42Z","updated_at":"2016-01-24T02:32:04Z","pushed_at":"2016-08-23T17:44:53Z","git_url":"git://github.com/gyuho/etcd.git","ssh_url":"git@github.com:gyuho/etcd.git","clone_url":"https://github.com/gyuho/etcd.git","svn_url":"https://github.com/gyuho/etcd","homepage":"","size":22829,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"13f79affb6315aabdfab3c2090cddaaad517100b","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-08-23T16:15:17Z","pushed_at":"2016-08-23T17:50:47Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":30226,"stargazers_count":10594,"watchers_count":10594,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1847,"mirror_url":null,"open_issues_count":122,"forks":1847,"open_issues":122,"watchers":10594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6244"},"html":{"href":"https://github.com/coreos/etcd/pull/6244"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/6244"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/6244/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6244/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6244/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/95e1160e07ea0e110b55673740a99f99739c6545"}}}}
{"actor":{"display_login":"gyuho"}}