{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/68980361","id":68980361,"diff_hunk":"@@ -447,7 +447,7 @@ enum scrub_error_type PGBackend::be_compare_scrub_objects(\n \t\t  << (known ? \"known\" : \"best guess\")\n \t\t  << \" omap_digest 0x\" << auth.omap_digest << std::dec\n \t\t  << \" from auth shard \" << auth_shard;\n-      result.set_omap_digest_mismatch();\n+      result.set_omap_digest_mismatch(known);","path":"src/osd/PGBackend.cc","position":14,"original_position":14,"commit_id":"45d262281e5b64522c35e541fcc22b1fb2bf3016","original_commit_id":"da04bec78647c389d4bc29b1740804ae77e90efe","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"body":"@dzafman \r\nIs the only difference between the case where we have no oi digest but the shards do not match each other and the case where we do have the oi.digest and at least one shard does not match that digest that in the latter case at least one shard will have have a digest error?  I don't think that's good -- I'd rather the top level error list distinguish between those cases explicitly so that the user of this interface knows what to look for.","created_at":"2016-06-29T16:28:15Z","updated_at":"2016-06-29T16:28:15Z","html_url":"https://github.com/ceph/ceph/pull/9613#discussion_r68980361","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9613","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/68980361"},"html":{"href":"https://github.com/ceph/ceph/pull/9613#discussion_r68980361"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9613"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9613","id":73266142,"html_url":"https://github.com/ceph/ceph/pull/9613","diff_url":"https://github.com/ceph/ceph/pull/9613.diff","patch_url":"https://github.com/ceph/ceph/pull/9613.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9613","number":9613,"state":"open","locked":false,"title":"DNM: common osd: Best guess scrub errors get object marked not particular shards","user":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars.githubusercontent.com/u/2467610?v=3","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-09T18:50:57Z","updated_at":"2016-06-29T16:28:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d9d68aef66f8ddde571adf215a4f1b5abc74ab2","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9613/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9613/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9613/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/45d262281e5b64522c35e541fcc22b1fb2bf3016","head":{"label":"dzafman:wip-16064","ref":"wip-16064","sha":"45d262281e5b64522c35e541fcc22b1fb2bf3016","user":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars.githubusercontent.com/u/2467610?v=3","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"repo":{"id":7757983,"name":"ceph","full_name":"dzafman/ceph","owner":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars.githubusercontent.com/u/2467610?v=3","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzafman/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/dzafman/ceph","forks_url":"https://api.github.com/repos/dzafman/ceph/forks","keys_url":"https://api.github.com/repos/dzafman/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzafman/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzafman/ceph/teams","hooks_url":"https://api.github.com/repos/dzafman/ceph/hooks","issue_events_url":"https://api.github.com/repos/dzafman/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/dzafman/ceph/events","assignees_url":"https://api.github.com/repos/dzafman/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/dzafman/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/dzafman/ceph/tags","blobs_url":"https://api.github.com/repos/dzafman/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzafman/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzafman/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzafman/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzafman/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/dzafman/ceph/languages","stargazers_url":"https://api.github.com/repos/dzafman/ceph/stargazers","contributors_url":"https://api.github.com/repos/dzafman/ceph/contributors","subscribers_url":"https://api.github.com/repos/dzafman/ceph/subscribers","subscription_url":"https://api.github.com/repos/dzafman/ceph/subscription","commits_url":"https://api.github.com/repos/dzafman/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzafman/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzafman/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzafman/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzafman/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/dzafman/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzafman/ceph/merges","archive_url":"https://api.github.com/repos/dzafman/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzafman/ceph/downloads","issues_url":"https://api.github.com/repos/dzafman/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/dzafman/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/dzafman/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/dzafman/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzafman/ceph/labels{/name}","releases_url":"https://api.github.com/repos/dzafman/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/dzafman/ceph/deployments","created_at":"2013-01-22T18:07:43Z","updated_at":"2014-06-25T02:23:55Z","pushed_at":"2016-06-29T02:30:17Z","git_url":"git://github.com/dzafman/ceph.git","ssh_url":"git@github.com:dzafman/ceph.git","clone_url":"https://github.com/dzafman/ceph.git","svn_url":"https://github.com/dzafman/ceph","homepage":"http://ceph.com","size":155265,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"af7731b04b7eb2770c65ad9db97e726a3f496736","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-06-29T15:24:47Z","pushed_at":"2016-06-29T16:15:00Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":223870,"stargazers_count":2267,"watchers_count":2267,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1348,"mirror_url":null,"open_issues_count":420,"forks":1348,"open_issues":420,"watchers":2267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9613"},"html":{"href":"https://github.com/ceph/ceph/pull/9613"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9613"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9613/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9613/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9613/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/45d262281e5b64522c35e541fcc22b1fb2bf3016"}}}}
{"actor":{"display_login":"athanatos"}}