{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/928","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/928/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/928/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/928/events","html_url":"https://github.com/greenplum-db/gpdb/pull/928","id":164549432,"number":928,"title":"Initialize the subroot for pre-planned subqueries","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-08T14:58:28Z","updated_at":"2016-07-15T20:46:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/928","html_url":"https://github.com/greenplum-db/gpdb/pull/928","diff_url":"https://github.com/greenplum-db/gpdb/pull/928.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/928.patch"},"body":"When we get a pre-planned Plan from window_planner we must set the subroot accordingly to avoid a null pointer deref a few lines later when converting the subquery pathkeys. This would only happen for parallel window plans which had to be enabled with the `gp_enable_sequential_window_plans` GUC. Reading the parallel window planning code this seems to be right thing to me but a careful set of eyes would be much appreciated as I might be missing something. \r\n\r\nAdded a test case running for both GUC values to ensure it produce the same results."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/233065656","html_url":"https://github.com/greenplum-db/gpdb/pull/928#issuecomment-233065656","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/928","id":233065656,"user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T20:46:40Z","updated_at":"2016-07-15T20:46:40Z","body":"LGTM at a quick glance (except the set optimizer=off bit)"}}
{"actor":{"display_login":"hlinnaka"}}