{"action":"created","comment":{"url":"https://api.github.com/repos/apache/camel/pulls/comments/81969713","pull_request_review_id":2909806,"id":81969713,"diff_hunk":"@@ -290,6 +290,15 @@ public Exchange get(CamelContext camelContext, String key) {\n         return unmarshallExchange(camelContext, cache.get(key));\n     }\n     \n+    /**\n+     * Checks if the key in question is in the repository.\n+     * \n+     * @param key Object - key in question\n+     */\n+    public boolean containsKey(Object key){\n+        return cache.containsKey(key);","path":"components/camel-hazelcast/src/main/java/org/apache/camel/processor/aggregate/hazelcast/HazelcastAggregationRepository.java","position":10,"original_position":10,"commit_id":"02bae291cf0fbaa48c8e0f60e0a0c8e622a9fd4e","original_commit_id":"02bae291cf0fbaa48c8e0f60e0a0c8e622a9fd4e","user":{"login":"thuri","id":1602552,"avatar_url":"https://avatars.githubusercontent.com/u/1602552?v=3","gravatar_id":"","url":"https://api.github.com/users/thuri","html_url":"https://github.com/thuri","followers_url":"https://api.github.com/users/thuri/followers","following_url":"https://api.github.com/users/thuri/following{/other_user}","gists_url":"https://api.github.com/users/thuri/gists{/gist_id}","starred_url":"https://api.github.com/users/thuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thuri/subscriptions","organizations_url":"https://api.github.com/users/thuri/orgs","repos_url":"https://api.github.com/users/thuri/repos","events_url":"https://api.github.com/users/thuri/events{/privacy}","received_events_url":"https://api.github.com/users/thuri/received_events","type":"User","site_admin":false},"body":"Not quite sure about it. The persistedCache is used only in the recoveryMode. As far as i've seen entries are added to the persistedCache only in the remove method after the entry has been removed from cache. So i think we should only look into the cache.\r\n\r\nAlso the existing getKeys method does only look into the cache too but only retrieves the keys from the cache. ","created_at":"2016-10-05T13:21:52Z","updated_at":"2016-10-05T13:21:52Z","html_url":"https://github.com/apache/camel/pull/1195#discussion_r81969713","pull_request_url":"https://api.github.com/repos/apache/camel/pulls/1195","_links":{"self":{"href":"https://api.github.com/repos/apache/camel/pulls/comments/81969713"},"html":{"href":"https://github.com/apache/camel/pull/1195#discussion_r81969713"},"pull_request":{"href":"https://api.github.com/repos/apache/camel/pulls/1195"}}},"pull_request":{"url":"https://api.github.com/repos/apache/camel/pulls/1195","id":87859252,"html_url":"https://github.com/apache/camel/pull/1195","diff_url":"https://github.com/apache/camel/pull/1195.diff","patch_url":"https://github.com/apache/camel/pull/1195.patch","issue_url":"https://api.github.com/repos/apache/camel/issues/1195","number":1195,"state":"open","locked":false,"title":"added method to check for key existence","user":{"login":"thuri","id":1602552,"avatar_url":"https://avatars.githubusercontent.com/u/1602552?v=3","gravatar_id":"","url":"https://api.github.com/users/thuri","html_url":"https://github.com/thuri","followers_url":"https://api.github.com/users/thuri/followers","following_url":"https://api.github.com/users/thuri/following{/other_user}","gists_url":"https://api.github.com/users/thuri/gists{/gist_id}","starred_url":"https://api.github.com/users/thuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thuri/subscriptions","organizations_url":"https://api.github.com/users/thuri/orgs","repos_url":"https://api.github.com/users/thuri/repos","events_url":"https://api.github.com/users/thuri/events{/privacy}","received_events_url":"https://api.github.com/users/thuri/received_events","type":"User","site_admin":false},"body":"Sometimes it is necessary to check for the existence but not fetching the value.\r\n\r\nFor example in a filefilter that uses the aggregationRepository to dtermine wheter a file should be consumed or not we don't need to fetch the actual DefaultExchangeHolder object and unmarshal it. \r\n\r\nSo in this fileFilter we can use the containsKey method to delegate to the actual map and return the presence of the key.\r\n\r\nIf possible we'd like to have that change from camel 2.16.x \r\n\r\nThanks,\r\nMichael","created_at":"2016-10-04T09:24:33Z","updated_at":"2016-10-05T13:21:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90cbf4b3a79f2f515f0aee9b4641d4c35e0b118","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/camel/pulls/1195/commits","review_comments_url":"https://api.github.com/repos/apache/camel/pulls/1195/comments","review_comment_url":"https://api.github.com/repos/apache/camel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/camel/issues/1195/comments","statuses_url":"https://api.github.com/repos/apache/camel/statuses/02bae291cf0fbaa48c8e0f60e0a0c8e622a9fd4e","head":{"label":"thuri:master","ref":"master","sha":"02bae291cf0fbaa48c8e0f60e0a0c8e622a9fd4e","user":{"login":"thuri","id":1602552,"avatar_url":"https://avatars.githubusercontent.com/u/1602552?v=3","gravatar_id":"","url":"https://api.github.com/users/thuri","html_url":"https://github.com/thuri","followers_url":"https://api.github.com/users/thuri/followers","following_url":"https://api.github.com/users/thuri/following{/other_user}","gists_url":"https://api.github.com/users/thuri/gists{/gist_id}","starred_url":"https://api.github.com/users/thuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thuri/subscriptions","organizations_url":"https://api.github.com/users/thuri/orgs","repos_url":"https://api.github.com/users/thuri/repos","events_url":"https://api.github.com/users/thuri/events{/privacy}","received_events_url":"https://api.github.com/users/thuri/received_events","type":"User","site_admin":false},"repo":{"id":69944574,"name":"camel","full_name":"thuri/camel","owner":{"login":"thuri","id":1602552,"avatar_url":"https://avatars.githubusercontent.com/u/1602552?v=3","gravatar_id":"","url":"https://api.github.com/users/thuri","html_url":"https://github.com/thuri","followers_url":"https://api.github.com/users/thuri/followers","following_url":"https://api.github.com/users/thuri/following{/other_user}","gists_url":"https://api.github.com/users/thuri/gists{/gist_id}","starred_url":"https://api.github.com/users/thuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thuri/subscriptions","organizations_url":"https://api.github.com/users/thuri/orgs","repos_url":"https://api.github.com/users/thuri/repos","events_url":"https://api.github.com/users/thuri/events{/privacy}","received_events_url":"https://api.github.com/users/thuri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thuri/camel","description":"Mirror of Apache Camel","fork":true,"url":"https://api.github.com/repos/thuri/camel","forks_url":"https://api.github.com/repos/thuri/camel/forks","keys_url":"https://api.github.com/repos/thuri/camel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thuri/camel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thuri/camel/teams","hooks_url":"https://api.github.com/repos/thuri/camel/hooks","issue_events_url":"https://api.github.com/repos/thuri/camel/issues/events{/number}","events_url":"https://api.github.com/repos/thuri/camel/events","assignees_url":"https://api.github.com/repos/thuri/camel/assignees{/user}","branches_url":"https://api.github.com/repos/thuri/camel/branches{/branch}","tags_url":"https://api.github.com/repos/thuri/camel/tags","blobs_url":"https://api.github.com/repos/thuri/camel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thuri/camel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thuri/camel/git/refs{/sha}","trees_url":"https://api.github.com/repos/thuri/camel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thuri/camel/statuses/{sha}","languages_url":"https://api.github.com/repos/thuri/camel/languages","stargazers_url":"https://api.github.com/repos/thuri/camel/stargazers","contributors_url":"https://api.github.com/repos/thuri/camel/contributors","subscribers_url":"https://api.github.com/repos/thuri/camel/subscribers","subscription_url":"https://api.github.com/repos/thuri/camel/subscription","commits_url":"https://api.github.com/repos/thuri/camel/commits{/sha}","git_commits_url":"https://api.github.com/repos/thuri/camel/git/commits{/sha}","comments_url":"https://api.github.com/repos/thuri/camel/comments{/number}","issue_comment_url":"https://api.github.com/repos/thuri/camel/issues/comments{/number}","contents_url":"https://api.github.com/repos/thuri/camel/contents/{+path}","compare_url":"https://api.github.com/repos/thuri/camel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thuri/camel/merges","archive_url":"https://api.github.com/repos/thuri/camel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thuri/camel/downloads","issues_url":"https://api.github.com/repos/thuri/camel/issues{/number}","pulls_url":"https://api.github.com/repos/thuri/camel/pulls{/number}","milestones_url":"https://api.github.com/repos/thuri/camel/milestones{/number}","notifications_url":"https://api.github.com/repos/thuri/camel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thuri/camel/labels{/name}","releases_url":"https://api.github.com/repos/thuri/camel/releases{/id}","deployments_url":"https://api.github.com/repos/thuri/camel/deployments","created_at":"2016-10-04T07:57:07Z","updated_at":"2016-10-04T07:58:02Z","pushed_at":"2016-10-04T09:19:53Z","git_url":"git://github.com/thuri/camel.git","ssh_url":"git@github.com:thuri/camel.git","clone_url":"https://github.com/thuri/camel.git","svn_url":"https://github.com/thuri/camel","homepage":null,"size":138838,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5a4f1f3924c097c11870422c897e5333b6c4cd78","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206317,"name":"camel","full_name":"apache/camel","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/camel","description":"Mirror of Apache Camel","fork":false,"url":"https://api.github.com/repos/apache/camel","forks_url":"https://api.github.com/repos/apache/camel/forks","keys_url":"https://api.github.com/repos/apache/camel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/camel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/camel/teams","hooks_url":"https://api.github.com/repos/apache/camel/hooks","issue_events_url":"https://api.github.com/repos/apache/camel/issues/events{/number}","events_url":"https://api.github.com/repos/apache/camel/events","assignees_url":"https://api.github.com/repos/apache/camel/assignees{/user}","branches_url":"https://api.github.com/repos/apache/camel/branches{/branch}","tags_url":"https://api.github.com/repos/apache/camel/tags","blobs_url":"https://api.github.com/repos/apache/camel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/camel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/camel/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/camel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/camel/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/camel/languages","stargazers_url":"https://api.github.com/repos/apache/camel/stargazers","contributors_url":"https://api.github.com/repos/apache/camel/contributors","subscribers_url":"https://api.github.com/repos/apache/camel/subscribers","subscription_url":"https://api.github.com/repos/apache/camel/subscription","commits_url":"https://api.github.com/repos/apache/camel/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/camel/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/camel/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/camel/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/camel/contents/{+path}","compare_url":"https://api.github.com/repos/apache/camel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/camel/merges","archive_url":"https://api.github.com/repos/apache/camel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/camel/downloads","issues_url":"https://api.github.com/repos/apache/camel/issues{/number}","pulls_url":"https://api.github.com/repos/apache/camel/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/camel/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/camel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/camel/labels{/name}","releases_url":"https://api.github.com/repos/apache/camel/releases{/id}","deployments_url":"https://api.github.com/repos/apache/camel/deployments","created_at":"2009-05-21T00:25:36Z","updated_at":"2016-10-05T07:05:02Z","pushed_at":"2016-10-05T10:16:32Z","git_url":"git://github.com/apache/camel.git","ssh_url":"git@github.com:apache/camel.git","clone_url":"https://github.com/apache/camel.git","svn_url":"https://github.com/apache/camel","homepage":null,"size":157486,"stargazers_count":950,"watchers_count":950,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1424,"mirror_url":"git://git.apache.org/camel.git","open_issues_count":14,"forks":1424,"open_issues":14,"watchers":950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/camel/pulls/1195"},"html":{"href":"https://github.com/apache/camel/pull/1195"},"issue":{"href":"https://api.github.com/repos/apache/camel/issues/1195"},"comments":{"href":"https://api.github.com/repos/apache/camel/issues/1195/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/camel/pulls/1195/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/camel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/camel/pulls/1195/commits"},"statuses":{"href":"https://api.github.com/repos/apache/camel/statuses/02bae291cf0fbaa48c8e0f60e0a0c8e622a9fd4e"}}}}
{"actor":{"display_login":"thuri"}}