{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10942","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10942/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10942/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10942/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10942","id":174553655,"number":10942,"title":"[WIP] Check RBAC for toolbar buttons","user":{"login":"PanSpagetka","id":9535558,"avatar_url":"https://avatars.githubusercontent.com/u/9535558?v=3","gravatar_id":"","url":"https://api.github.com/users/PanSpagetka","html_url":"https://github.com/PanSpagetka","followers_url":"https://api.github.com/users/PanSpagetka/followers","following_url":"https://api.github.com/users/PanSpagetka/following{/other_user}","gists_url":"https://api.github.com/users/PanSpagetka/gists{/gist_id}","starred_url":"https://api.github.com/users/PanSpagetka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanSpagetka/subscriptions","organizations_url":"https://api.github.com/users/PanSpagetka/orgs","repos_url":"https://api.github.com/users/PanSpagetka/repos","events_url":"https://api.github.com/users/PanSpagetka/events{/privacy}","received_events_url":"https://api.github.com/users/PanSpagetka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"assignees":[{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-09-01T15:26:15Z","updated_at":"2016-09-05T13:16:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10942","html_url":"https://github.com/ManageIQ/manageiq/pull/10942","diff_url":"https://github.com/ManageIQ/manageiq/pull/10942.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10942.patch"},"body":"Purpose or Intent\r\n-----------------\r\nBefere we render toolbar button, we want to check RBAC. In default is button id used as RBAC feature. For specific RBAC checking you can override `check_rbac` method.\r\nFor now, there are some exceptions for checking RBAC, but will be removed when this buttons will be refactored.\r\n\r\n    # TODO: add things to feature.yml\r\n    # TODO: create separate clases for download_csv, download_text, custom_button\r\n    # TODO: change pdf button class"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/244744663","html_url":"https://github.com/ManageIQ/manageiq/pull/10942#issuecomment-244744663","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10942","id":244744663,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T13:16:56Z","updated_at":"2016-09-05T13:16:56Z","body":"<rubocop />Checked commit https://github.com/PanSpagetka/manageiq/commit/1a6b8f172e41f6cf461a0d5d9279d306de31beb3 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n4 files checked, 3 offenses detected\n\n**app/helpers/application_helper/button/miq_request_approval.rb**\n- [ ] :exclamation: - [Line 6](https://github.com/PanSpagetka/manageiq/blob/1a6b8f172e41f6cf461a0d5d9279d306de31beb3/app/helpers/application_helper/button/miq_request_approval.rb#L6), Col 73 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for an array of words.\n- [ ] :exclamation: - [Line 7](https://github.com/PanSpagetka/manageiq/blob/1a6b8f172e41f6cf461a0d5d9279d306de31beb3/app/helpers/application_helper/button/miq_request_approval.rb#L7), Col 20 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for an array of words.\n- [ ] :grey_exclamation: - [Line 6](https://github.com/PanSpagetka/manageiq/blob/1a6b8f172e41f6cf461a0d5d9279d306de31beb3/app/helpers/application_helper/button/miq_request_approval.rb#L6), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [128/120]\n"}}
{"actor":{"display_login":"miq-bot"}}