{"action":"created","issue":{"url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument/issues/23","repository_url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument","labels_url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument/issues/23/comments","events_url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument/issues/23/events","html_url":"https://github.com/istanbuljs/istanbul-lib-instrument/pull/23","id":175092196,"number":23,"title":"Include input source map in file coverage","user":{"login":"DatenMetzgerX","id":1203881,"avatar_url":"https://avatars.githubusercontent.com/u/1203881?v=3","gravatar_id":"","url":"https://api.github.com/users/DatenMetzgerX","html_url":"https://github.com/DatenMetzgerX","followers_url":"https://api.github.com/users/DatenMetzgerX/followers","following_url":"https://api.github.com/users/DatenMetzgerX/following{/other_user}","gists_url":"https://api.github.com/users/DatenMetzgerX/gists{/gist_id}","starred_url":"https://api.github.com/users/DatenMetzgerX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatenMetzgerX/subscriptions","organizations_url":"https://api.github.com/users/DatenMetzgerX/orgs","repos_url":"https://api.github.com/users/DatenMetzgerX/repos","events_url":"https://api.github.com/users/DatenMetzgerX/events{/privacy}","received_events_url":"https://api.github.com/users/DatenMetzgerX/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-05T15:21:56Z","updated_at":"2016-11-07T07:58:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument/pulls/23","html_url":"https://github.com/istanbuljs/istanbul-lib-instrument/pull/23","diff_url":"https://github.com/istanbuljs/istanbul-lib-instrument/pull/23.diff","patch_url":"https://github.com/istanbuljs/istanbul-lib-instrument/pull/23.patch"},"body":"Add an option to include an input source map. The input source map\nis the source map that maps the code before its instumentation back it's\noriginal form. This is needed to support more complex setups, e.g. when\nbundlers are involved. If a bundler like webpack, browserify - or you\nname it - is used, then there are several, intermediate, source maps\ninvolved. The main issue is, that the instrumented code is bundled\ninto a single file, and therefore a new source map is created. But the\nsource map of the bundled file cannot be used to remap the istanbul coverage.\nTherefore, these intermediate source maps need to be stored to be available\nwhen creating the report or remaping.\n\nThis solution is kind of hacky and should start a discussion how to solve\nit best. Anyway, it fixes variouis issues that, up to now, required hacky\nsolutions.\n\nrefs SitePen/remap-istanbul#2\n"},"comment":{"url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument/issues/comments/258768824","html_url":"https://github.com/istanbuljs/istanbul-lib-instrument/pull/23#issuecomment-258768824","issue_url":"https://api.github.com/repos/istanbuljs/istanbul-lib-instrument/issues/23","id":258768824,"user":{"login":"DatenMetzgerX","id":1203881,"avatar_url":"https://avatars.githubusercontent.com/u/1203881?v=3","gravatar_id":"","url":"https://api.github.com/users/DatenMetzgerX","html_url":"https://github.com/DatenMetzgerX","followers_url":"https://api.github.com/users/DatenMetzgerX/followers","following_url":"https://api.github.com/users/DatenMetzgerX/following{/other_user}","gists_url":"https://api.github.com/users/DatenMetzgerX/gists{/gist_id}","starred_url":"https://api.github.com/users/DatenMetzgerX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatenMetzgerX/subscriptions","organizations_url":"https://api.github.com/users/DatenMetzgerX/orgs","repos_url":"https://api.github.com/users/DatenMetzgerX/repos","events_url":"https://api.github.com/users/DatenMetzgerX/events{/privacy}","received_events_url":"https://api.github.com/users/DatenMetzgerX/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T07:58:11Z","updated_at":"2016-11-07T07:58:11Z","body":"Added a simple unit test that verifies if the inputSourceMap is included\r\n\r\n> If I'm reading this correctly, this doesn't change any of the existing API, just allows us to attach an additional piece of information to the coverage object?\r\n\r\nThats right. If the option is not provided (and with your suggested change), the coverage object should be exactly equal to the one before.\r\n\r\nOne question is left. Should inputSourceMap be exposed (no need for .data.inputSourceMap)? Would be more consistent, however, if the coverage object is converted to json that the new property is always included...."}}
{"actor":{"display_login":"DatenMetzgerX"}}