{"action":"created","comment":{"url":"https://api.github.com/repos/jcholast/freeipa/pulls/comments/86975340","pull_request_review_id":7605105,"id":86975340,"diff_hunk":"@@ -200,7 +200,9 @@ class BaseServerDNS(common.Installable, core.Group, core.Composite):\n \n     @reverse_zones.validator\n     def reverse_zones(self, values):\n-        if not self.allow_zone_overlap:\n+        try:","path":"ipaserver/install/server/common.py","position":null,"original_position":5,"commit_id":"d36f007184ffafb88059138363e59e4f6ea0b1e6","original_commit_id":"44e5fe87c7b4f8a9f8c2363c511d229bee26a232","user":{"login":"mbasti-rh","id":20207783,"avatar_url":"https://avatars.githubusercontent.com/u/20207783?v=3","gravatar_id":"","url":"https://api.github.com/users/mbasti-rh","html_url":"https://github.com/mbasti-rh","followers_url":"https://api.github.com/users/mbasti-rh/followers","following_url":"https://api.github.com/users/mbasti-rh/following{/other_user}","gists_url":"https://api.github.com/users/mbasti-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasti-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasti-rh/subscriptions","organizations_url":"https://api.github.com/users/mbasti-rh/orgs","repos_url":"https://api.github.com/users/mbasti-rh/repos","events_url":"https://api.github.com/users/mbasti-rh/events{/privacy}","received_events_url":"https://api.github.com/users/mbasti-rh/received_events","type":"User","site_admin":false},"body":"Why this change is needed for Flags?  It doesnt look for me to catch Attribute error instead comparing True/False for flags","created_at":"2016-11-08T12:05:00Z","updated_at":"2016-11-08T12:05:00Z","html_url":"https://github.com/jcholast/freeipa/pull/5#discussion_r86975340","pull_request_url":"https://api.github.com/repos/jcholast/freeipa/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/comments/86975340"},"html":{"href":"https://github.com/jcholast/freeipa/pull/5#discussion_r86975340"},"pull_request":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/jcholast/freeipa/pulls/5","id":90360088,"html_url":"https://github.com/jcholast/freeipa/pull/5","diff_url":"https://github.com/jcholast/freeipa/pull/5.diff","patch_url":"https://github.com/jcholast/freeipa/pull/5.patch","issue_url":"https://api.github.com/repos/jcholast/freeipa/issues/5","number":5,"state":"open","locked":false,"title":"install: introduce installer class hierarchy","user":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-21T10:30:39Z","updated_at":"2016-11-08T12:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bba64f5e2b9bba3f8976ab9949735ea6d2076f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jcholast/freeipa/pulls/5/commits","review_comments_url":"https://api.github.com/repos/jcholast/freeipa/pulls/5/comments","review_comment_url":"https://api.github.com/repos/jcholast/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jcholast/freeipa/issues/5/comments","statuses_url":"https://api.github.com/repos/jcholast/freeipa/statuses/d36f007184ffafb88059138363e59e4f6ea0b1e6","head":{"label":"jcholast:installer-classes","ref":"installer-classes","sha":"d36f007184ffafb88059138363e59e4f6ea0b1e6","user":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"repo":{"id":54029853,"name":"freeipa","full_name":"jcholast/freeipa","owner":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcholast/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/jcholast/freeipa","forks_url":"https://api.github.com/repos/jcholast/freeipa/forks","keys_url":"https://api.github.com/repos/jcholast/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcholast/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcholast/freeipa/teams","hooks_url":"https://api.github.com/repos/jcholast/freeipa/hooks","issue_events_url":"https://api.github.com/repos/jcholast/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/jcholast/freeipa/events","assignees_url":"https://api.github.com/repos/jcholast/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/jcholast/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/jcholast/freeipa/tags","blobs_url":"https://api.github.com/repos/jcholast/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcholast/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcholast/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcholast/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcholast/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/jcholast/freeipa/languages","stargazers_url":"https://api.github.com/repos/jcholast/freeipa/stargazers","contributors_url":"https://api.github.com/repos/jcholast/freeipa/contributors","subscribers_url":"https://api.github.com/repos/jcholast/freeipa/subscribers","subscription_url":"https://api.github.com/repos/jcholast/freeipa/subscription","commits_url":"https://api.github.com/repos/jcholast/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcholast/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcholast/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcholast/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcholast/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/jcholast/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcholast/freeipa/merges","archive_url":"https://api.github.com/repos/jcholast/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcholast/freeipa/downloads","issues_url":"https://api.github.com/repos/jcholast/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/jcholast/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/jcholast/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/jcholast/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcholast/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/jcholast/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/jcholast/freeipa/deployments","created_at":"2016-03-16T12:27:08Z","updated_at":"2016-03-16T12:27:13Z","pushed_at":"2016-11-08T08:58:18Z","git_url":"git://github.com/jcholast/freeipa.git","ssh_url":"git@github.com:jcholast/freeipa.git","clone_url":"https://github.com/jcholast/freeipa.git","svn_url":"https://github.com/jcholast/freeipa","homepage":"http://freeipa.org/","size":36885,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"jcholast:installer-refactoring","ref":"installer-refactoring","sha":"4256203484b914a3a7bc9f56544078fcdc540276","user":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"repo":{"id":54029853,"name":"freeipa","full_name":"jcholast/freeipa","owner":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcholast/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/jcholast/freeipa","forks_url":"https://api.github.com/repos/jcholast/freeipa/forks","keys_url":"https://api.github.com/repos/jcholast/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcholast/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcholast/freeipa/teams","hooks_url":"https://api.github.com/repos/jcholast/freeipa/hooks","issue_events_url":"https://api.github.com/repos/jcholast/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/jcholast/freeipa/events","assignees_url":"https://api.github.com/repos/jcholast/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/jcholast/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/jcholast/freeipa/tags","blobs_url":"https://api.github.com/repos/jcholast/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcholast/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcholast/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcholast/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcholast/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/jcholast/freeipa/languages","stargazers_url":"https://api.github.com/repos/jcholast/freeipa/stargazers","contributors_url":"https://api.github.com/repos/jcholast/freeipa/contributors","subscribers_url":"https://api.github.com/repos/jcholast/freeipa/subscribers","subscription_url":"https://api.github.com/repos/jcholast/freeipa/subscription","commits_url":"https://api.github.com/repos/jcholast/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcholast/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcholast/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcholast/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcholast/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/jcholast/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcholast/freeipa/merges","archive_url":"https://api.github.com/repos/jcholast/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcholast/freeipa/downloads","issues_url":"https://api.github.com/repos/jcholast/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/jcholast/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/jcholast/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/jcholast/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcholast/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/jcholast/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/jcholast/freeipa/deployments","created_at":"2016-03-16T12:27:08Z","updated_at":"2016-03-16T12:27:13Z","pushed_at":"2016-11-08T08:58:18Z","git_url":"git://github.com/jcholast/freeipa.git","ssh_url":"git@github.com:jcholast/freeipa.git","clone_url":"https://github.com/jcholast/freeipa.git","svn_url":"https://github.com/jcholast/freeipa","homepage":"http://freeipa.org/","size":36885,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/5"},"html":{"href":"https://github.com/jcholast/freeipa/pull/5"},"issue":{"href":"https://api.github.com/repos/jcholast/freeipa/issues/5"},"comments":{"href":"https://api.github.com/repos/jcholast/freeipa/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/jcholast/freeipa/statuses/d36f007184ffafb88059138363e59e4f6ea0b1e6"}}}}
{"actor":{"display_login":"mbasti-rh"}}