{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/opulencephp/Opulence/pulls/11","id":74855872,"html_url":"https://github.com/opulencephp/Opulence/pull/11","diff_url":"https://github.com/opulencephp/Opulence/pull/11.diff","patch_url":"https://github.com/opulencephp/Opulence/pull/11.patch","issue_url":"https://api.github.com/repos/opulencephp/Opulence/issues/11","number":11,"state":"closed","locked":false,"title":"Generic view caching","user":{"login":"MaartenStaa","id":2743160,"avatar_url":"https://avatars.githubusercontent.com/u/2743160?v=3","gravatar_id":"","url":"https://api.github.com/users/MaartenStaa","html_url":"https://github.com/MaartenStaa","followers_url":"https://api.github.com/users/MaartenStaa/followers","following_url":"https://api.github.com/users/MaartenStaa/following{/other_user}","gists_url":"https://api.github.com/users/MaartenStaa/gists{/gist_id}","starred_url":"https://api.github.com/users/MaartenStaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaartenStaa/subscriptions","organizations_url":"https://api.github.com/users/MaartenStaa/orgs","repos_url":"https://api.github.com/users/MaartenStaa/repos","events_url":"https://api.github.com/users/MaartenStaa/events{/privacy}","received_events_url":"https://api.github.com/users/MaartenStaa/received_events","type":"User","site_admin":false},"body":"This PR adds a Opulence\\Views\\Caching\\GenericCache that takes an ICacheBridge implementation for its actual storage. Figured this might come in handy.\r\n\r\nI also modified the ArrayBridge to ignore set calls with negative lifetimes. If you want to I can undo that, but the tests for the view FileCache seemed to indicate this is the desired behaviour.","created_at":"2016-06-22T20:56:04Z","updated_at":"2016-06-23T02:15:21Z","closed_at":"2016-06-23T02:15:21Z","merged_at":"2016-06-23T02:15:21Z","merge_commit_sha":"d1b69f1731d4db397965bf40f2e248c9133965d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opulencephp/Opulence/pulls/11/commits","review_comments_url":"https://api.github.com/repos/opulencephp/Opulence/pulls/11/comments","review_comment_url":"https://api.github.com/repos/opulencephp/Opulence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opulencephp/Opulence/issues/11/comments","statuses_url":"https://api.github.com/repos/opulencephp/Opulence/statuses/d1b69f1731d4db397965bf40f2e248c9133965d5","head":{"label":"MaartenStaa:generic-view-caching","ref":"generic-view-caching","sha":"d1b69f1731d4db397965bf40f2e248c9133965d5","user":{"login":"MaartenStaa","id":2743160,"avatar_url":"https://avatars.githubusercontent.com/u/2743160?v=3","gravatar_id":"","url":"https://api.github.com/users/MaartenStaa","html_url":"https://github.com/MaartenStaa","followers_url":"https://api.github.com/users/MaartenStaa/followers","following_url":"https://api.github.com/users/MaartenStaa/following{/other_user}","gists_url":"https://api.github.com/users/MaartenStaa/gists{/gist_id}","starred_url":"https://api.github.com/users/MaartenStaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaartenStaa/subscriptions","organizations_url":"https://api.github.com/users/MaartenStaa/orgs","repos_url":"https://api.github.com/users/MaartenStaa/repos","events_url":"https://api.github.com/users/MaartenStaa/events{/privacy}","received_events_url":"https://api.github.com/users/MaartenStaa/received_events","type":"User","site_admin":false},"repo":{"id":61745557,"name":"Opulence","full_name":"MaartenStaa/Opulence","owner":{"login":"MaartenStaa","id":2743160,"avatar_url":"https://avatars.githubusercontent.com/u/2743160?v=3","gravatar_id":"","url":"https://api.github.com/users/MaartenStaa","html_url":"https://github.com/MaartenStaa","followers_url":"https://api.github.com/users/MaartenStaa/followers","following_url":"https://api.github.com/users/MaartenStaa/following{/other_user}","gists_url":"https://api.github.com/users/MaartenStaa/gists{/gist_id}","starred_url":"https://api.github.com/users/MaartenStaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaartenStaa/subscriptions","organizations_url":"https://api.github.com/users/MaartenStaa/orgs","repos_url":"https://api.github.com/users/MaartenStaa/repos","events_url":"https://api.github.com/users/MaartenStaa/events{/privacy}","received_events_url":"https://api.github.com/users/MaartenStaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaartenStaa/Opulence","description":"A simple, secure, and scalable PHP application framework","fork":true,"url":"https://api.github.com/repos/MaartenStaa/Opulence","forks_url":"https://api.github.com/repos/MaartenStaa/Opulence/forks","keys_url":"https://api.github.com/repos/MaartenStaa/Opulence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaartenStaa/Opulence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaartenStaa/Opulence/teams","hooks_url":"https://api.github.com/repos/MaartenStaa/Opulence/hooks","issue_events_url":"https://api.github.com/repos/MaartenStaa/Opulence/issues/events{/number}","events_url":"https://api.github.com/repos/MaartenStaa/Opulence/events","assignees_url":"https://api.github.com/repos/MaartenStaa/Opulence/assignees{/user}","branches_url":"https://api.github.com/repos/MaartenStaa/Opulence/branches{/branch}","tags_url":"https://api.github.com/repos/MaartenStaa/Opulence/tags","blobs_url":"https://api.github.com/repos/MaartenStaa/Opulence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaartenStaa/Opulence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaartenStaa/Opulence/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaartenStaa/Opulence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaartenStaa/Opulence/statuses/{sha}","languages_url":"https://api.github.com/repos/MaartenStaa/Opulence/languages","stargazers_url":"https://api.github.com/repos/MaartenStaa/Opulence/stargazers","contributors_url":"https://api.github.com/repos/MaartenStaa/Opulence/contributors","subscribers_url":"https://api.github.com/repos/MaartenStaa/Opulence/subscribers","subscription_url":"https://api.github.com/repos/MaartenStaa/Opulence/subscription","commits_url":"https://api.github.com/repos/MaartenStaa/Opulence/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaartenStaa/Opulence/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaartenStaa/Opulence/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaartenStaa/Opulence/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaartenStaa/Opulence/contents/{+path}","compare_url":"https://api.github.com/repos/MaartenStaa/Opulence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaartenStaa/Opulence/merges","archive_url":"https://api.github.com/repos/MaartenStaa/Opulence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaartenStaa/Opulence/downloads","issues_url":"https://api.github.com/repos/MaartenStaa/Opulence/issues{/number}","pulls_url":"https://api.github.com/repos/MaartenStaa/Opulence/pulls{/number}","milestones_url":"https://api.github.com/repos/MaartenStaa/Opulence/milestones{/number}","notifications_url":"https://api.github.com/repos/MaartenStaa/Opulence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaartenStaa/Opulence/labels{/name}","releases_url":"https://api.github.com/repos/MaartenStaa/Opulence/releases{/id}","deployments_url":"https://api.github.com/repos/MaartenStaa/Opulence/deployments","created_at":"2016-06-22T19:22:34Z","updated_at":"2016-06-22T19:22:36Z","pushed_at":"2016-06-22T21:39:48Z","git_url":"git://github.com/MaartenStaa/Opulence.git","ssh_url":"git@github.com:MaartenStaa/Opulence.git","clone_url":"https://github.com/MaartenStaa/Opulence.git","svn_url":"https://github.com/MaartenStaa/Opulence","homepage":"https://www.opulencephp.com","size":3953,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.0"}},"base":{"label":"opulencephp:1.0","ref":"1.0","sha":"eb3ad51633d4f13a24699c56754f6d29c48efa26","user":{"login":"opulencephp","id":6652430,"avatar_url":"https://avatars.githubusercontent.com/u/6652430?v=3","gravatar_id":"","url":"https://api.github.com/users/opulencephp","html_url":"https://github.com/opulencephp","followers_url":"https://api.github.com/users/opulencephp/followers","following_url":"https://api.github.com/users/opulencephp/following{/other_user}","gists_url":"https://api.github.com/users/opulencephp/gists{/gist_id}","starred_url":"https://api.github.com/users/opulencephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opulencephp/subscriptions","organizations_url":"https://api.github.com/users/opulencephp/orgs","repos_url":"https://api.github.com/users/opulencephp/repos","events_url":"https://api.github.com/users/opulencephp/events{/privacy}","received_events_url":"https://api.github.com/users/opulencephp/received_events","type":"User","site_admin":false},"repo":{"id":39270428,"name":"Opulence","full_name":"opulencephp/Opulence","owner":{"login":"opulencephp","id":6652430,"avatar_url":"https://avatars.githubusercontent.com/u/6652430?v=3","gravatar_id":"","url":"https://api.github.com/users/opulencephp","html_url":"https://github.com/opulencephp","followers_url":"https://api.github.com/users/opulencephp/followers","following_url":"https://api.github.com/users/opulencephp/following{/other_user}","gists_url":"https://api.github.com/users/opulencephp/gists{/gist_id}","starred_url":"https://api.github.com/users/opulencephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opulencephp/subscriptions","organizations_url":"https://api.github.com/users/opulencephp/orgs","repos_url":"https://api.github.com/users/opulencephp/repos","events_url":"https://api.github.com/users/opulencephp/events{/privacy}","received_events_url":"https://api.github.com/users/opulencephp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opulencephp/Opulence","description":"A simple, secure, and scalable PHP application framework","fork":false,"url":"https://api.github.com/repos/opulencephp/Opulence","forks_url":"https://api.github.com/repos/opulencephp/Opulence/forks","keys_url":"https://api.github.com/repos/opulencephp/Opulence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opulencephp/Opulence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opulencephp/Opulence/teams","hooks_url":"https://api.github.com/repos/opulencephp/Opulence/hooks","issue_events_url":"https://api.github.com/repos/opulencephp/Opulence/issues/events{/number}","events_url":"https://api.github.com/repos/opulencephp/Opulence/events","assignees_url":"https://api.github.com/repos/opulencephp/Opulence/assignees{/user}","branches_url":"https://api.github.com/repos/opulencephp/Opulence/branches{/branch}","tags_url":"https://api.github.com/repos/opulencephp/Opulence/tags","blobs_url":"https://api.github.com/repos/opulencephp/Opulence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opulencephp/Opulence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opulencephp/Opulence/git/refs{/sha}","trees_url":"https://api.github.com/repos/opulencephp/Opulence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opulencephp/Opulence/statuses/{sha}","languages_url":"https://api.github.com/repos/opulencephp/Opulence/languages","stargazers_url":"https://api.github.com/repos/opulencephp/Opulence/stargazers","contributors_url":"https://api.github.com/repos/opulencephp/Opulence/contributors","subscribers_url":"https://api.github.com/repos/opulencephp/Opulence/subscribers","subscription_url":"https://api.github.com/repos/opulencephp/Opulence/subscription","commits_url":"https://api.github.com/repos/opulencephp/Opulence/commits{/sha}","git_commits_url":"https://api.github.com/repos/opulencephp/Opulence/git/commits{/sha}","comments_url":"https://api.github.com/repos/opulencephp/Opulence/comments{/number}","issue_comment_url":"https://api.github.com/repos/opulencephp/Opulence/issues/comments{/number}","contents_url":"https://api.github.com/repos/opulencephp/Opulence/contents/{+path}","compare_url":"https://api.github.com/repos/opulencephp/Opulence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opulencephp/Opulence/merges","archive_url":"https://api.github.com/repos/opulencephp/Opulence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opulencephp/Opulence/downloads","issues_url":"https://api.github.com/repos/opulencephp/Opulence/issues{/number}","pulls_url":"https://api.github.com/repos/opulencephp/Opulence/pulls{/number}","milestones_url":"https://api.github.com/repos/opulencephp/Opulence/milestones{/number}","notifications_url":"https://api.github.com/repos/opulencephp/Opulence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opulencephp/Opulence/labels{/name}","releases_url":"https://api.github.com/repos/opulencephp/Opulence/releases{/id}","deployments_url":"https://api.github.com/repos/opulencephp/Opulence/deployments","created_at":"2015-07-17T18:56:05Z","updated_at":"2016-06-23T01:50:11Z","pushed_at":"2016-06-23T02:15:21Z","git_url":"git://github.com/opulencephp/Opulence.git","ssh_url":"git@github.com:opulencephp/Opulence.git","clone_url":"https://github.com/opulencephp/Opulence.git","svn_url":"https://github.com/opulencephp/Opulence","homepage":"https://www.opulencephp.com","size":3954,"stargazers_count":252,"watchers_count":252,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":252,"default_branch":"1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/opulencephp/Opulence/pulls/11"},"html":{"href":"https://github.com/opulencephp/Opulence/pull/11"},"issue":{"href":"https://api.github.com/repos/opulencephp/Opulence/issues/11"},"comments":{"href":"https://api.github.com/repos/opulencephp/Opulence/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/opulencephp/Opulence/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/opulencephp/Opulence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opulencephp/Opulence/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/opulencephp/Opulence/statuses/d1b69f1731d4db397965bf40f2e248c9133965d5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"opulencephp","id":6652430,"avatar_url":"https://avatars.githubusercontent.com/u/6652430?v=3","gravatar_id":"","url":"https://api.github.com/users/opulencephp","html_url":"https://github.com/opulencephp","followers_url":"https://api.github.com/users/opulencephp/followers","following_url":"https://api.github.com/users/opulencephp/following{/other_user}","gists_url":"https://api.github.com/users/opulencephp/gists{/gist_id}","starred_url":"https://api.github.com/users/opulencephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opulencephp/subscriptions","organizations_url":"https://api.github.com/users/opulencephp/orgs","repos_url":"https://api.github.com/users/opulencephp/repos","events_url":"https://api.github.com/users/opulencephp/events{/privacy}","received_events_url":"https://api.github.com/users/opulencephp/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":270,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"opulencephp"}}