{"action":"closed","number":129,"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/129","id":55903459,"html_url":"https://github.com/spring-cloud/spring-cloud-consul/pull/129","diff_url":"https://github.com/spring-cloud/spring-cloud-consul/pull/129.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-consul/pull/129.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/issues/129","number":129,"state":"closed","locked":false,"title":"Add support for registering using an alternate external port","user":{"login":"darylrobbins","id":2270905,"avatar_url":"https://avatars.githubusercontent.com/u/2270905?v=3","gravatar_id":"","url":"https://api.github.com/users/darylrobbins","html_url":"https://github.com/darylrobbins","followers_url":"https://api.github.com/users/darylrobbins/followers","following_url":"https://api.github.com/users/darylrobbins/following{/other_user}","gists_url":"https://api.github.com/users/darylrobbins/gists{/gist_id}","starred_url":"https://api.github.com/users/darylrobbins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darylrobbins/subscriptions","organizations_url":"https://api.github.com/users/darylrobbins/orgs","repos_url":"https://api.github.com/users/darylrobbins/repos","events_url":"https://api.github.com/users/darylrobbins/events{/privacy}","received_events_url":"https://api.github.com/users/darylrobbins/received_events","type":"User","site_admin":false},"body":"Sometimes the port that clients use to access a service is not the same port that the service is listening on. Maybe you have a web server sitting in front or maybe you're running in a docker container. In either case, one needs the ability to specify this alternate external port.\r\n\r\nThis PR adds an additional option to ConsulDiscoveryProperties for the external port. If it is provided, it is used when registering the service, otherwise it falls back to status quo behaviour.","created_at":"2016-01-13T14:25:19Z","updated_at":"2016-01-13T22:18:53Z","closed_at":"2016-01-13T22:18:53Z","merged_at":null,"merge_commit_sha":"94bcf0a7acf31329330d5c2631336f8f0d964f18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/129/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/129/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/issues/129/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/statuses/2e44bace2f3bebcfe892ef89043404b311fdd121","head":{"label":"darylrobbins:external-port","ref":"external-port","sha":"2e44bace2f3bebcfe892ef89043404b311fdd121","user":{"login":"darylrobbins","id":2270905,"avatar_url":"https://avatars.githubusercontent.com/u/2270905?v=3","gravatar_id":"","url":"https://api.github.com/users/darylrobbins","html_url":"https://github.com/darylrobbins","followers_url":"https://api.github.com/users/darylrobbins/followers","following_url":"https://api.github.com/users/darylrobbins/following{/other_user}","gists_url":"https://api.github.com/users/darylrobbins/gists{/gist_id}","starred_url":"https://api.github.com/users/darylrobbins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darylrobbins/subscriptions","organizations_url":"https://api.github.com/users/darylrobbins/orgs","repos_url":"https://api.github.com/users/darylrobbins/repos","events_url":"https://api.github.com/users/darylrobbins/events{/privacy}","received_events_url":"https://api.github.com/users/darylrobbins/received_events","type":"User","site_admin":false},"repo":{"id":49574884,"name":"spring-cloud-consul","full_name":"darylrobbins/spring-cloud-consul","owner":{"login":"darylrobbins","id":2270905,"avatar_url":"https://avatars.githubusercontent.com/u/2270905?v=3","gravatar_id":"","url":"https://api.github.com/users/darylrobbins","html_url":"https://github.com/darylrobbins","followers_url":"https://api.github.com/users/darylrobbins/followers","following_url":"https://api.github.com/users/darylrobbins/following{/other_user}","gists_url":"https://api.github.com/users/darylrobbins/gists{/gist_id}","starred_url":"https://api.github.com/users/darylrobbins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darylrobbins/subscriptions","organizations_url":"https://api.github.com/users/darylrobbins/orgs","repos_url":"https://api.github.com/users/darylrobbins/repos","events_url":"https://api.github.com/users/darylrobbins/events{/privacy}","received_events_url":"https://api.github.com/users/darylrobbins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darylrobbins/spring-cloud-consul","description":"Spring Cloud Consul","fork":true,"url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul","forks_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/forks","keys_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/teams","hooks_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/hooks","issue_events_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/issues/events{/number}","events_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/events","assignees_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/assignees{/user}","branches_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/branches{/branch}","tags_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/tags","blobs_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/languages","stargazers_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/stargazers","contributors_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/contributors","subscribers_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/subscribers","subscription_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/subscription","commits_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/contents/{+path}","compare_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/merges","archive_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/downloads","issues_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/issues{/number}","pulls_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/labels{/name}","releases_url":"https://api.github.com/repos/darylrobbins/spring-cloud-consul/releases{/id}","created_at":"2016-01-13T13:18:24Z","updated_at":"2016-01-13T13:18:25Z","pushed_at":"2016-01-13T18:45:46Z","git_url":"git://github.com/darylrobbins/spring-cloud-consul.git","ssh_url":"git@github.com:darylrobbins/spring-cloud-consul.git","clone_url":"https://github.com/darylrobbins/spring-cloud-consul.git","svn_url":"https://github.com/darylrobbins/spring-cloud-consul","homepage":"","size":1579,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"b75baec67305ba3705e3fe713ed8a14bb12d6f8f","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":27404315,"name":"spring-cloud-consul","full_name":"spring-cloud/spring-cloud-consul","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-consul","description":"Spring Cloud Consul","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/releases{/id}","created_at":"2014-12-01T22:56:34Z","updated_at":"2016-01-12T09:00:20Z","pushed_at":"2016-01-13T22:18:10Z","git_url":"git://github.com/spring-cloud/spring-cloud-consul.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-consul.git","clone_url":"https://github.com/spring-cloud/spring-cloud-consul.git","svn_url":"https://github.com/spring-cloud/spring-cloud-consul","homepage":"","size":1844,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":23,"forks":56,"open_issues":23,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/129"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-consul/pull/129"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/issues/129"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-consul/statuses/2e44bace2f3bebcfe892ef89043404b311fdd121"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":11,"review_comments":0,"commits":2,"additions":31,"deletions":7,"changed_files":3}}