{"action":"created","issue":{"url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock/issues/18","repository_url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock","labels_url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock/issues/18/comments","events_url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock/issues/18/events","html_url":"https://github.com/conda-forge/conda-forge-build-setup-feedstock/pull/18","id":164164090,"number":18,"title":"Remove MAKEFLAGS","user":{"login":"ocefpaf","id":950575,"avatar_url":"https://avatars.githubusercontent.com/u/950575?v=3","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-06T20:17:19Z","updated_at":"2016-07-07T09:50:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock/pulls/18","html_url":"https://github.com/conda-forge/conda-forge-build-setup-feedstock/pull/18","diff_url":"https://github.com/conda-forge/conda-forge-build-setup-feedstock/pull/18.diff","patch_url":"https://github.com/conda-forge/conda-forge-build-setup-feedstock/pull/18.patch"},"body":"Setting `MAKEFLAGS` by default interferes with the builds and it is not always desired. IMO these should be set in the `build.sh` explicitly.\r\n\r\nSee [here](https://github.com/conda-forge/staged-recipes/pull/810/files#diff-184b8de768ec3b5604f175db2c6fba5eR11) for an example.\r\n\r\nPing @pelson this particular flag bring the same danger as the `toolchain`. Also, if such a flags is really needed to be set by default, I recommend that it lives in the `toolchain` rather than this setup. That way it goes together with the rest of the build flags making it easier to find and debug issues.\r\n\r\n@msarahan what is your opinion on having flags set by default?"},"comment":{"url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock/issues/comments/231033858","html_url":"https://github.com/conda-forge/conda-forge-build-setup-feedstock/pull/18#issuecomment-231033858","issue_url":"https://api.github.com/repos/conda-forge/conda-forge-build-setup-feedstock/issues/18","id":231033858,"user":{"login":"ocefpaf","id":950575,"avatar_url":"https://avatars.githubusercontent.com/u/950575?v=3","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T09:50:43Z","updated_at":"2016-07-07T09:50:43Z","body":"> I don't really care. If setting them by default is breaking things, then I don't think we should set them by default.\r\n\r\nIt is not only about breaking things. Things may pass and the user does not know the `flags` used and have a hard time reproducing the build somewhere else until s/he finds that it was a default setting buried somewhere. I believe that the setting of any build flags should be explicit in the `build.sh` to easy debug and make out builds more friendly to other who may be building them outside `conda-forge`.\r\n\r\n> As I discussed with @pelson and he agreed, we don't think this should live in the `toolchain`.\r\n\r\nCatch 22! My whole point is that we should not have a `toolchain`. Everything should be explicitly defined."}}
{"actor":{"display_login":"ocefpaf"}}