{"action":"created","comment":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/63006105","id":63006105,"diff_hunk":"@@ -38,7 +38,8 @@ class TestREPL(script: String) extends REPL {\n     out.close()\n     val printed = out.toString\n     val transcript = printed.drop(printed.indexOf(config.prompt))\n-    if (transcript.toString != script) {\n+    val transcriptNoColors = transcript.toString.replaceAll(\"\\u001B\\\\[[;\\\\d]*m\", \"\")","path":"test/test/TestREPL.scala","position":5,"original_position":5,"commit_id":"fabf35735af3ea8a6c4850b8e65c4a73a946ac08","original_commit_id":"952fb20f37f8350bd31ae1fd4f06fc51bda099c3","user":{"login":"smarter","id":63430,"avatar_url":"https://avatars.githubusercontent.com/u/63430?v=3","gravatar_id":"","url":"https://api.github.com/users/smarter","html_url":"https://github.com/smarter","followers_url":"https://api.github.com/users/smarter/followers","following_url":"https://api.github.com/users/smarter/following{/other_user}","gists_url":"https://api.github.com/users/smarter/gists{/gist_id}","starred_url":"https://api.github.com/users/smarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarter/subscriptions","organizations_url":"https://api.github.com/users/smarter/orgs","repos_url":"https://api.github.com/users/smarter/repos","events_url":"https://api.github.com/users/smarter/events{/privacy}","received_events_url":"https://api.github.com/users/smarter/received_events","type":"User","site_admin":false},"body":"the scala REPL has `-Dscala.color`: https://github.com/scala/scala/blob/99a82be91cbb85239f70508f6695c6b21fd3558c/src/repl/scala/tools/nsc/interpreter/ReplProps.scala#L20","created_at":"2016-05-12T11:48:35Z","updated_at":"2016-05-12T11:48:35Z","html_url":"https://github.com/lampepfl/dotty/pull/1251#discussion_r63006105","pull_request_url":"https://api.github.com/repos/lampepfl/dotty/pulls/1251","_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/63006105"},"html":{"href":"https://github.com/lampepfl/dotty/pull/1251#discussion_r63006105"},"pull_request":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1251"}}},"pull_request":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/1251","id":69805961,"html_url":"https://github.com/lampepfl/dotty/pull/1251","diff_url":"https://github.com/lampepfl/dotty/pull/1251.diff","patch_url":"https://github.com/lampepfl/dotty/pull/1251.patch","issue_url":"https://api.github.com/repos/lampepfl/dotty/issues/1251","number":1251,"state":"open","locked":false,"title":"Fix stdout redirect for REPL's println","user":{"login":"felixmulder","id":1530049,"avatar_url":"https://avatars.githubusercontent.com/u/1530049?v=3","gravatar_id":"","url":"https://api.github.com/users/felixmulder","html_url":"https://github.com/felixmulder","followers_url":"https://api.github.com/users/felixmulder/followers","following_url":"https://api.github.com/users/felixmulder/following{/other_user}","gists_url":"https://api.github.com/users/felixmulder/gists{/gist_id}","starred_url":"https://api.github.com/users/felixmulder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixmulder/subscriptions","organizations_url":"https://api.github.com/users/felixmulder/orgs","repos_url":"https://api.github.com/users/felixmulder/repos","events_url":"https://api.github.com/users/felixmulder/events{/privacy}","received_events_url":"https://api.github.com/users/felixmulder/received_events","type":"User","site_admin":false},"body":"When printing in the REPL via `println`, the output would end up on the\r\nsame line, since stdout had not been redirected. This commit remedies\r\nthat.\r\n\r\nIt also adds syntax highlighting to result types.\r\n\r\nReview: @smarter ","created_at":"2016-05-12T09:34:57Z","updated_at":"2016-05-12T11:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82f10fb92e2c3df78788a156b46fcdec4718cc44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lampepfl/dotty/pulls/1251/commits","review_comments_url":"https://api.github.com/repos/lampepfl/dotty/pulls/1251/comments","review_comment_url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lampepfl/dotty/issues/1251/comments","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/fabf35735af3ea8a6c4850b8e65c4a73a946ac08","head":{"label":"felixmulder:topic/fix-stdoutredirect-repl","ref":"topic/fix-stdoutredirect-repl","sha":"fabf35735af3ea8a6c4850b8e65c4a73a946ac08","user":{"login":"felixmulder","id":1530049,"avatar_url":"https://avatars.githubusercontent.com/u/1530049?v=3","gravatar_id":"","url":"https://api.github.com/users/felixmulder","html_url":"https://github.com/felixmulder","followers_url":"https://api.github.com/users/felixmulder/followers","following_url":"https://api.github.com/users/felixmulder/following{/other_user}","gists_url":"https://api.github.com/users/felixmulder/gists{/gist_id}","starred_url":"https://api.github.com/users/felixmulder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixmulder/subscriptions","organizations_url":"https://api.github.com/users/felixmulder/orgs","repos_url":"https://api.github.com/users/felixmulder/repos","events_url":"https://api.github.com/users/felixmulder/events{/privacy}","received_events_url":"https://api.github.com/users/felixmulder/received_events","type":"User","site_admin":false},"repo":{"id":52869692,"name":"dotty","full_name":"felixmulder/dotty","owner":{"login":"felixmulder","id":1530049,"avatar_url":"https://avatars.githubusercontent.com/u/1530049?v=3","gravatar_id":"","url":"https://api.github.com/users/felixmulder","html_url":"https://github.com/felixmulder","followers_url":"https://api.github.com/users/felixmulder/followers","following_url":"https://api.github.com/users/felixmulder/following{/other_user}","gists_url":"https://api.github.com/users/felixmulder/gists{/gist_id}","starred_url":"https://api.github.com/users/felixmulder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixmulder/subscriptions","organizations_url":"https://api.github.com/users/felixmulder/orgs","repos_url":"https://api.github.com/users/felixmulder/repos","events_url":"https://api.github.com/users/felixmulder/events{/privacy}","received_events_url":"https://api.github.com/users/felixmulder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixmulder/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":true,"url":"https://api.github.com/repos/felixmulder/dotty","forks_url":"https://api.github.com/repos/felixmulder/dotty/forks","keys_url":"https://api.github.com/repos/felixmulder/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixmulder/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixmulder/dotty/teams","hooks_url":"https://api.github.com/repos/felixmulder/dotty/hooks","issue_events_url":"https://api.github.com/repos/felixmulder/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/felixmulder/dotty/events","assignees_url":"https://api.github.com/repos/felixmulder/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/felixmulder/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/felixmulder/dotty/tags","blobs_url":"https://api.github.com/repos/felixmulder/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixmulder/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixmulder/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixmulder/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixmulder/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/felixmulder/dotty/languages","stargazers_url":"https://api.github.com/repos/felixmulder/dotty/stargazers","contributors_url":"https://api.github.com/repos/felixmulder/dotty/contributors","subscribers_url":"https://api.github.com/repos/felixmulder/dotty/subscribers","subscription_url":"https://api.github.com/repos/felixmulder/dotty/subscription","commits_url":"https://api.github.com/repos/felixmulder/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixmulder/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixmulder/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixmulder/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixmulder/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/felixmulder/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixmulder/dotty/merges","archive_url":"https://api.github.com/repos/felixmulder/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixmulder/dotty/downloads","issues_url":"https://api.github.com/repos/felixmulder/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/felixmulder/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/felixmulder/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/felixmulder/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixmulder/dotty/labels{/name}","releases_url":"https://api.github.com/repos/felixmulder/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/felixmulder/dotty/deployments","created_at":"2016-03-01T10:47:55Z","updated_at":"2016-05-03T10:53:51Z","pushed_at":"2016-05-12T11:41:06Z","git_url":"git://github.com/felixmulder/dotty.git","ssh_url":"git@github.com:felixmulder/dotty.git","clone_url":"https://github.com/felixmulder/dotty.git","svn_url":"https://github.com/felixmulder/dotty","homepage":"","size":17744,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lampepfl:master","ref":"master","sha":"134ad7a6a172fec97dc438dd0aff3766a0f0944a","user":{"login":"lampepfl","id":2684793,"avatar_url":"https://avatars.githubusercontent.com/u/2684793?v=3","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"repo":{"id":7035651,"name":"dotty","full_name":"lampepfl/dotty","owner":{"login":"lampepfl","id":2684793,"avatar_url":"https://avatars.githubusercontent.com/u/2684793?v=3","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lampepfl/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":false,"url":"https://api.github.com/repos/lampepfl/dotty","forks_url":"https://api.github.com/repos/lampepfl/dotty/forks","keys_url":"https://api.github.com/repos/lampepfl/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lampepfl/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lampepfl/dotty/teams","hooks_url":"https://api.github.com/repos/lampepfl/dotty/hooks","issue_events_url":"https://api.github.com/repos/lampepfl/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/lampepfl/dotty/events","assignees_url":"https://api.github.com/repos/lampepfl/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/lampepfl/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/lampepfl/dotty/tags","blobs_url":"https://api.github.com/repos/lampepfl/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lampepfl/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lampepfl/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/lampepfl/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/lampepfl/dotty/languages","stargazers_url":"https://api.github.com/repos/lampepfl/dotty/stargazers","contributors_url":"https://api.github.com/repos/lampepfl/dotty/contributors","subscribers_url":"https://api.github.com/repos/lampepfl/dotty/subscribers","subscription_url":"https://api.github.com/repos/lampepfl/dotty/subscription","commits_url":"https://api.github.com/repos/lampepfl/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/lampepfl/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/lampepfl/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/lampepfl/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/lampepfl/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/lampepfl/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lampepfl/dotty/merges","archive_url":"https://api.github.com/repos/lampepfl/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lampepfl/dotty/downloads","issues_url":"https://api.github.com/repos/lampepfl/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/lampepfl/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/lampepfl/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/lampepfl/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lampepfl/dotty/labels{/name}","releases_url":"https://api.github.com/repos/lampepfl/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/lampepfl/dotty/deployments","created_at":"2012-12-06T12:57:33Z","updated_at":"2016-05-12T11:24:46Z","pushed_at":"2016-05-12T11:41:08Z","git_url":"git://github.com/lampepfl/dotty.git","ssh_url":"git@github.com:lampepfl/dotty.git","clone_url":"https://github.com/lampepfl/dotty.git","svn_url":"https://github.com/lampepfl/dotty","homepage":"","size":24766,"stargazers_count":902,"watchers_count":902,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":143,"forks":115,"open_issues":143,"watchers":902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1251"},"html":{"href":"https://github.com/lampepfl/dotty/pull/1251"},"issue":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/1251"},"comments":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/1251/comments"},"review_comments":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1251/comments"},"review_comment":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1251/commits"},"statuses":{"href":"https://api.github.com/repos/lampepfl/dotty/statuses/fabf35735af3ea8a6c4850b8e65c4a73a946ac08"}}}}