{"action":"created","comment":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/60333358","id":60333358,"diff_hunk":"@@ -2,7 +2,7 @@ Twisted>=10.0.0\n lxml\n pyOpenSSL\n cssselect>=0.9\n-w3lib>=1.13.0\n+w3lib>=1.14.1","path":"requirements.txt","position":5,"original_position":5,"commit_id":"d42a98d3b590515bae30fb698e7aba2d7511608e","original_commit_id":"d42a98d3b590515bae30fb698e7aba2d7511608e","user":{"login":"kmike","id":107893,"avatar_url":"https://avatars.githubusercontent.com/u/107893?v=3","gravatar_id":"","url":"https://api.github.com/users/kmike","html_url":"https://github.com/kmike","followers_url":"https://api.github.com/users/kmike/followers","following_url":"https://api.github.com/users/kmike/following{/other_user}","gists_url":"https://api.github.com/users/kmike/gists{/gist_id}","starred_url":"https://api.github.com/users/kmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmike/subscriptions","organizations_url":"https://api.github.com/users/kmike/orgs","repos_url":"https://api.github.com/users/kmike/repos","events_url":"https://api.github.com/users/kmike/events{/privacy}","received_events_url":"https://api.github.com/users/kmike/received_events","type":"User","site_admin":false},"body":"let's bump it to 1.14.2","created_at":"2016-04-20T00:08:44Z","updated_at":"2016-04-20T00:08:44Z","html_url":"https://github.com/scrapy/scrapy/pull/1923#discussion_r60333358","pull_request_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1923","_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/60333358"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1923#discussion_r60333358"},"pull_request":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1923"}}},"pull_request":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/1923","id":66074640,"html_url":"https://github.com/scrapy/scrapy/pull/1923","diff_url":"https://github.com/scrapy/scrapy/pull/1923.diff","patch_url":"https://github.com/scrapy/scrapy/pull/1923.patch","issue_url":"https://api.github.com/repos/scrapy/scrapy/issues/1923","number":1923,"state":"open","locked":false,"title":"Use newer w3lib.url.safe_url_string() and re-enable HTTP request tests","user":{"login":"redapple","id":886296,"avatar_url":"https://avatars.githubusercontent.com/u/886296?v=3","gravatar_id":"","url":"https://api.github.com/users/redapple","html_url":"https://github.com/redapple","followers_url":"https://api.github.com/users/redapple/followers","following_url":"https://api.github.com/users/redapple/following{/other_user}","gists_url":"https://api.github.com/users/redapple/gists{/gist_id}","starred_url":"https://api.github.com/users/redapple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redapple/subscriptions","organizations_url":"https://api.github.com/users/redapple/orgs","repos_url":"https://api.github.com/users/redapple/repos","events_url":"https://api.github.com/users/redapple/events{/privacy}","received_events_url":"https://api.github.com/users/redapple/received_events","type":"User","site_admin":false},"body":"Starting from w3lib 1.14.1, `safe_url_string` implementation follows browsers' behavior better.\r\nLet's use it from now on.\r\n\r\nThese changes were originally part of https://github.com/scrapy/scrapy/pull/1874, split here so as to seperate topics.\r\n","created_at":"2016-04-11T22:42:36Z","updated_at":"2016-04-20T00:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3085b6316cf02d97bbf74629c3d1098337df327","assignee":null,"milestone":{"url":"https://api.github.com/repos/scrapy/scrapy/milestones/7","html_url":"https://github.com/scrapy/scrapy/milestones/v1.1","labels_url":"https://api.github.com/repos/scrapy/scrapy/milestones/7/labels","id":1008005,"number":7,"title":"v1.1","description":"","creator":{"login":"pablohoffman","id":185212,"avatar_url":"https://avatars.githubusercontent.com/u/185212?v=3","gravatar_id":"","url":"https://api.github.com/users/pablohoffman","html_url":"https://github.com/pablohoffman","followers_url":"https://api.github.com/users/pablohoffman/followers","following_url":"https://api.github.com/users/pablohoffman/following{/other_user}","gists_url":"https://api.github.com/users/pablohoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/pablohoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablohoffman/subscriptions","organizations_url":"https://api.github.com/users/pablohoffman/orgs","repos_url":"https://api.github.com/users/pablohoffman/repos","events_url":"https://api.github.com/users/pablohoffman/events{/privacy}","received_events_url":"https://api.github.com/users/pablohoffman/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":85,"state":"open","created_at":"2015-03-05T18:14:46Z","updated_at":"2016-04-19T08:34:15Z","due_on":"2016-03-15T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1923/commits","review_comments_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1923/comments","review_comment_url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapy/scrapy/issues/1923/comments","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/d42a98d3b590515bae30fb698e7aba2d7511608e","head":{"label":"scrapy:request-new-safe_url_string","ref":"request-new-safe_url_string","sha":"d42a98d3b590515bae30fb698e7aba2d7511608e","user":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"repo":{"id":529502,"name":"scrapy","full_name":"scrapy/scrapy","owner":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapy/scrapy","description":"Scrapy, a fast high-level web crawling & scraping framework for Python.","fork":false,"url":"https://api.github.com/repos/scrapy/scrapy","forks_url":"https://api.github.com/repos/scrapy/scrapy/forks","keys_url":"https://api.github.com/repos/scrapy/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapy/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapy/scrapy/teams","hooks_url":"https://api.github.com/repos/scrapy/scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapy/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapy/scrapy/events","assignees_url":"https://api.github.com/repos/scrapy/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapy/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapy/scrapy/tags","blobs_url":"https://api.github.com/repos/scrapy/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapy/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapy/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapy/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapy/scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapy/scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapy/scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapy/scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapy/scrapy/subscription","commits_url":"https://api.github.com/repos/scrapy/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapy/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapy/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapy/scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapy/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapy/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapy/scrapy/merges","archive_url":"https://api.github.com/repos/scrapy/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapy/scrapy/downloads","issues_url":"https://api.github.com/repos/scrapy/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapy/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapy/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapy/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapy/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapy/scrapy/releases{/id}","deployments_url":"https://api.github.com/repos/scrapy/scrapy/deployments","created_at":"2010-02-22T02:01:14Z","updated_at":"2016-04-19T23:17:29Z","pushed_at":"2016-04-19T23:48:21Z","git_url":"git://github.com/scrapy/scrapy.git","ssh_url":"git@github.com:scrapy/scrapy.git","clone_url":"https://github.com/scrapy/scrapy.git","svn_url":"https://github.com/scrapy/scrapy","homepage":"http://scrapy.org","size":32082,"stargazers_count":13648,"watchers_count":13648,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3812,"mirror_url":null,"open_issues_count":370,"forks":3812,"open_issues":370,"watchers":13648,"default_branch":"master"}},"base":{"label":"scrapy:master","ref":"master","sha":"10d03ee4192c43a4c71bbf5a7585cbbe0978bb1b","user":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"repo":{"id":529502,"name":"scrapy","full_name":"scrapy/scrapy","owner":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapy/scrapy","description":"Scrapy, a fast high-level web crawling & scraping framework for Python.","fork":false,"url":"https://api.github.com/repos/scrapy/scrapy","forks_url":"https://api.github.com/repos/scrapy/scrapy/forks","keys_url":"https://api.github.com/repos/scrapy/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapy/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapy/scrapy/teams","hooks_url":"https://api.github.com/repos/scrapy/scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapy/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapy/scrapy/events","assignees_url":"https://api.github.com/repos/scrapy/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapy/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapy/scrapy/tags","blobs_url":"https://api.github.com/repos/scrapy/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapy/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapy/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapy/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapy/scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapy/scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapy/scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapy/scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapy/scrapy/subscription","commits_url":"https://api.github.com/repos/scrapy/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapy/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapy/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapy/scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapy/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapy/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapy/scrapy/merges","archive_url":"https://api.github.com/repos/scrapy/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapy/scrapy/downloads","issues_url":"https://api.github.com/repos/scrapy/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapy/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapy/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapy/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapy/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapy/scrapy/releases{/id}","deployments_url":"https://api.github.com/repos/scrapy/scrapy/deployments","created_at":"2010-02-22T02:01:14Z","updated_at":"2016-04-19T23:17:29Z","pushed_at":"2016-04-19T23:48:21Z","git_url":"git://github.com/scrapy/scrapy.git","ssh_url":"git@github.com:scrapy/scrapy.git","clone_url":"https://github.com/scrapy/scrapy.git","svn_url":"https://github.com/scrapy/scrapy","homepage":"http://scrapy.org","size":32082,"stargazers_count":13648,"watchers_count":13648,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3812,"mirror_url":null,"open_issues_count":370,"forks":3812,"open_issues":370,"watchers":13648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1923"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1923"},"issue":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1923"},"comments":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1923/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1923/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1923/commits"},"statuses":{"href":"https://api.github.com/repos/scrapy/scrapy/statuses/d42a98d3b590515bae30fb698e7aba2d7511608e"}}}}