{"action":"created","issue":{"url":"https://api.github.com/repos/julianshapiro/velocity/issues/726","repository_url":"https://api.github.com/repos/julianshapiro/velocity","labels_url":"https://api.github.com/repos/julianshapiro/velocity/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/julianshapiro/velocity/issues/726/comments","events_url":"https://api.github.com/repos/julianshapiro/velocity/issues/726/events","html_url":"https://github.com/julianshapiro/velocity/issues/726","id":192837021,"number":726,"title":"Allow 0% duration for  compatibility with css keyFrames","user":{"login":"kritollm","id":12444201,"avatar_url":"https://avatars.githubusercontent.com/u/12444201?v=3","gravatar_id":"","url":"https://api.github.com/users/kritollm","html_url":"https://github.com/kritollm","followers_url":"https://api.github.com/users/kritollm/followers","following_url":"https://api.github.com/users/kritollm/following{/other_user}","gists_url":"https://api.github.com/users/kritollm/gists{/gist_id}","starred_url":"https://api.github.com/users/kritollm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kritollm/subscriptions","organizations_url":"https://api.github.com/users/kritollm/orgs","repos_url":"https://api.github.com/users/kritollm/repos","events_url":"https://api.github.com/users/kritollm/events{/privacy}","received_events_url":"https://api.github.com/users/kritollm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T12:45:06Z","updated_at":"2016-12-01T13:51:34Z","closed_at":null,"body":"I made a css animations to Velocity effects script and found a bug that is easy to fix.\r\n\r\nTo simulate css key frames I use the 0% keyframe as force feeding (same as css), but 0(%) is false so the value is replaced with 1 (100%).\r\n\r\nLine 135:\r\n```javascript\r\n/* Assign the whitelisted per-call options. */\r\n    opts.duration = redirectDuration * (durationPercentage || 1);\r\n```\r\n\r\nchange to:\r\n\r\n```javascript\r\n/* Assign the whitelisted per-call options. */\r\n    durationPercentage = (durationPercentage || durationPercentage === 0) ? durationPercentage : 1;\r\n    opts.duration = redirectDuration * durationPercentage;\r\n```"},"comment":{"url":"https://api.github.com/repos/julianshapiro/velocity/issues/comments/264177766","html_url":"https://github.com/julianshapiro/velocity/issues/726#issuecomment-264177766","issue_url":"https://api.github.com/repos/julianshapiro/velocity/issues/726","id":264177766,"user":{"login":"Rycochet","id":290714,"avatar_url":"https://avatars.githubusercontent.com/u/290714?v=3","gravatar_id":"","url":"https://api.github.com/users/Rycochet","html_url":"https://github.com/Rycochet","followers_url":"https://api.github.com/users/Rycochet/followers","following_url":"https://api.github.com/users/Rycochet/following{/other_user}","gists_url":"https://api.github.com/users/Rycochet/gists{/gist_id}","starred_url":"https://api.github.com/users/Rycochet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rycochet/subscriptions","organizations_url":"https://api.github.com/users/Rycochet/orgs","repos_url":"https://api.github.com/users/Rycochet/repos","events_url":"https://api.github.com/users/Rycochet/events{/privacy}","received_events_url":"https://api.github.com/users/Rycochet/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T13:51:34Z","updated_at":"2016-12-01T13:51:34Z","body":"Maybe better with this instead?\r\n\r\n```javascript\r\nopts.duration = redirectDuration * (Type.isNumber(durationPercentage) ? durationPercentage : 1);\r\n```"}}
{"actor":{"display_login":"Rycochet"}}