{"action":"closed","number":139,"pull_request":{"url":"https://api.github.com/repos/okfn/messytables/pulls/139","id":41786630,"html_url":"https://github.com/okfn/messytables/pull/139","diff_url":"https://github.com/okfn/messytables/pull/139.diff","patch_url":"https://github.com/okfn/messytables/pull/139.patch","issue_url":"https://api.github.com/repos/okfn/messytables/issues/139","number":139,"state":"closed","locked":false,"title":"Use `typecast` for type conversion.","user":{"login":"pudo","id":41628,"avatar_url":"https://avatars.githubusercontent.com/u/41628?v=3","gravatar_id":"","url":"https://api.github.com/users/pudo","html_url":"https://github.com/pudo","followers_url":"https://api.github.com/users/pudo/followers","following_url":"https://api.github.com/users/pudo/following{/other_user}","gists_url":"https://api.github.com/users/pudo/gists{/gist_id}","starred_url":"https://api.github.com/users/pudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pudo/subscriptions","organizations_url":"https://api.github.com/users/pudo/orgs","repos_url":"https://api.github.com/users/pudo/repos","events_url":"https://api.github.com/users/pudo/events{/privacy}","received_events_url":"https://api.github.com/users/pudo/received_events","type":"User","site_admin":false},"body":"I've started factoring out the type conversion code from ``messytables`` into a stand-alone library for use in another project. This pull requests removes internal support for type conversion in messytables and depends on [that library](https://github.com/pudo/typecast) instead.\r\n\r\nPro:\r\n* Better type detection, particularly on dates, booleans, etc.\r\n* High test coverage \r\n\r\nCon:\r\n* Not perfectly backward-compat, e.g. distinction between ``Date`` and ``DateTime`` columns.\r\n* Slower, since it performs more date checks.\r\n\r\n**NOTE** Right now this breaks many tests. Most of these seem to be cases where recognition is more precise now, and specific values (e.g. dates, booleans) are recognised where formerly only strings were found.\r\n\r\nLet me know if there's interest in this, I'm happy to fix the breaking tests.","created_at":"2015-08-06T13:21:32Z","updated_at":"2016-07-23T12:37:20Z","closed_at":"2016-07-23T12:37:20Z","merged_at":null,"merge_commit_sha":"4bbf2d6414596cf68a11cdf8802b665d76ae1b50","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/okfn/messytables/pulls/139/commits","review_comments_url":"https://api.github.com/repos/okfn/messytables/pulls/139/comments","review_comment_url":"https://api.github.com/repos/okfn/messytables/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okfn/messytables/issues/139/comments","statuses_url":"https://api.github.com/repos/okfn/messytables/statuses/3c97004314cb8bb92ca093fdab3a7369f7a69e9b","head":{"label":"okfn:use-typecast-type-conversion","ref":"use-typecast-type-conversion","sha":"3c97004314cb8bb92ca093fdab3a7369f7a69e9b","user":{"login":"okfn","id":304263,"avatar_url":"https://avatars.githubusercontent.com/u/304263?v=3","gravatar_id":"","url":"https://api.github.com/users/okfn","html_url":"https://github.com/okfn","followers_url":"https://api.github.com/users/okfn/followers","following_url":"https://api.github.com/users/okfn/following{/other_user}","gists_url":"https://api.github.com/users/okfn/gists{/gist_id}","starred_url":"https://api.github.com/users/okfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okfn/subscriptions","organizations_url":"https://api.github.com/users/okfn/orgs","repos_url":"https://api.github.com/users/okfn/repos","events_url":"https://api.github.com/users/okfn/events{/privacy}","received_events_url":"https://api.github.com/users/okfn/received_events","type":"Organization","site_admin":false},"repo":{"id":2114339,"name":"messytables","full_name":"okfn/messytables","owner":{"login":"okfn","id":304263,"avatar_url":"https://avatars.githubusercontent.com/u/304263?v=3","gravatar_id":"","url":"https://api.github.com/users/okfn","html_url":"https://github.com/okfn","followers_url":"https://api.github.com/users/okfn/followers","following_url":"https://api.github.com/users/okfn/following{/other_user}","gists_url":"https://api.github.com/users/okfn/gists{/gist_id}","starred_url":"https://api.github.com/users/okfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okfn/subscriptions","organizations_url":"https://api.github.com/users/okfn/orgs","repos_url":"https://api.github.com/users/okfn/repos","events_url":"https://api.github.com/users/okfn/events{/privacy}","received_events_url":"https://api.github.com/users/okfn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okfn/messytables","description":"Tools for parsing messy tabular data. ","fork":false,"url":"https://api.github.com/repos/okfn/messytables","forks_url":"https://api.github.com/repos/okfn/messytables/forks","keys_url":"https://api.github.com/repos/okfn/messytables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okfn/messytables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okfn/messytables/teams","hooks_url":"https://api.github.com/repos/okfn/messytables/hooks","issue_events_url":"https://api.github.com/repos/okfn/messytables/issues/events{/number}","events_url":"https://api.github.com/repos/okfn/messytables/events","assignees_url":"https://api.github.com/repos/okfn/messytables/assignees{/user}","branches_url":"https://api.github.com/repos/okfn/messytables/branches{/branch}","tags_url":"https://api.github.com/repos/okfn/messytables/tags","blobs_url":"https://api.github.com/repos/okfn/messytables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okfn/messytables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okfn/messytables/git/refs{/sha}","trees_url":"https://api.github.com/repos/okfn/messytables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okfn/messytables/statuses/{sha}","languages_url":"https://api.github.com/repos/okfn/messytables/languages","stargazers_url":"https://api.github.com/repos/okfn/messytables/stargazers","contributors_url":"https://api.github.com/repos/okfn/messytables/contributors","subscribers_url":"https://api.github.com/repos/okfn/messytables/subscribers","subscription_url":"https://api.github.com/repos/okfn/messytables/subscription","commits_url":"https://api.github.com/repos/okfn/messytables/commits{/sha}","git_commits_url":"https://api.github.com/repos/okfn/messytables/git/commits{/sha}","comments_url":"https://api.github.com/repos/okfn/messytables/comments{/number}","issue_comment_url":"https://api.github.com/repos/okfn/messytables/issues/comments{/number}","contents_url":"https://api.github.com/repos/okfn/messytables/contents/{+path}","compare_url":"https://api.github.com/repos/okfn/messytables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okfn/messytables/merges","archive_url":"https://api.github.com/repos/okfn/messytables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okfn/messytables/downloads","issues_url":"https://api.github.com/repos/okfn/messytables/issues{/number}","pulls_url":"https://api.github.com/repos/okfn/messytables/pulls{/number}","milestones_url":"https://api.github.com/repos/okfn/messytables/milestones{/number}","notifications_url":"https://api.github.com/repos/okfn/messytables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okfn/messytables/labels{/name}","releases_url":"https://api.github.com/repos/okfn/messytables/releases{/id}","deployments_url":"https://api.github.com/repos/okfn/messytables/deployments","created_at":"2011-07-27T18:08:21Z","updated_at":"2016-07-20T19:49:10Z","pushed_at":"2016-07-23T12:36:46Z","git_url":"git://github.com/okfn/messytables.git","ssh_url":"git@github.com:okfn/messytables.git","clone_url":"https://github.com/okfn/messytables.git","svn_url":"https://github.com/okfn/messytables","homepage":"http://messytables.readthedocs.io/","size":5397,"stargazers_count":216,"watchers_count":216,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":27,"forks":62,"open_issues":27,"watchers":216,"default_branch":"master"}},"base":{"label":"okfn:master","ref":"master","sha":"33f6d7e625a969bc0d060c72d5018d7d16cc867b","user":{"login":"okfn","id":304263,"avatar_url":"https://avatars.githubusercontent.com/u/304263?v=3","gravatar_id":"","url":"https://api.github.com/users/okfn","html_url":"https://github.com/okfn","followers_url":"https://api.github.com/users/okfn/followers","following_url":"https://api.github.com/users/okfn/following{/other_user}","gists_url":"https://api.github.com/users/okfn/gists{/gist_id}","starred_url":"https://api.github.com/users/okfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okfn/subscriptions","organizations_url":"https://api.github.com/users/okfn/orgs","repos_url":"https://api.github.com/users/okfn/repos","events_url":"https://api.github.com/users/okfn/events{/privacy}","received_events_url":"https://api.github.com/users/okfn/received_events","type":"Organization","site_admin":false},"repo":{"id":2114339,"name":"messytables","full_name":"okfn/messytables","owner":{"login":"okfn","id":304263,"avatar_url":"https://avatars.githubusercontent.com/u/304263?v=3","gravatar_id":"","url":"https://api.github.com/users/okfn","html_url":"https://github.com/okfn","followers_url":"https://api.github.com/users/okfn/followers","following_url":"https://api.github.com/users/okfn/following{/other_user}","gists_url":"https://api.github.com/users/okfn/gists{/gist_id}","starred_url":"https://api.github.com/users/okfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okfn/subscriptions","organizations_url":"https://api.github.com/users/okfn/orgs","repos_url":"https://api.github.com/users/okfn/repos","events_url":"https://api.github.com/users/okfn/events{/privacy}","received_events_url":"https://api.github.com/users/okfn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okfn/messytables","description":"Tools for parsing messy tabular data. ","fork":false,"url":"https://api.github.com/repos/okfn/messytables","forks_url":"https://api.github.com/repos/okfn/messytables/forks","keys_url":"https://api.github.com/repos/okfn/messytables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okfn/messytables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okfn/messytables/teams","hooks_url":"https://api.github.com/repos/okfn/messytables/hooks","issue_events_url":"https://api.github.com/repos/okfn/messytables/issues/events{/number}","events_url":"https://api.github.com/repos/okfn/messytables/events","assignees_url":"https://api.github.com/repos/okfn/messytables/assignees{/user}","branches_url":"https://api.github.com/repos/okfn/messytables/branches{/branch}","tags_url":"https://api.github.com/repos/okfn/messytables/tags","blobs_url":"https://api.github.com/repos/okfn/messytables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okfn/messytables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okfn/messytables/git/refs{/sha}","trees_url":"https://api.github.com/repos/okfn/messytables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okfn/messytables/statuses/{sha}","languages_url":"https://api.github.com/repos/okfn/messytables/languages","stargazers_url":"https://api.github.com/repos/okfn/messytables/stargazers","contributors_url":"https://api.github.com/repos/okfn/messytables/contributors","subscribers_url":"https://api.github.com/repos/okfn/messytables/subscribers","subscription_url":"https://api.github.com/repos/okfn/messytables/subscription","commits_url":"https://api.github.com/repos/okfn/messytables/commits{/sha}","git_commits_url":"https://api.github.com/repos/okfn/messytables/git/commits{/sha}","comments_url":"https://api.github.com/repos/okfn/messytables/comments{/number}","issue_comment_url":"https://api.github.com/repos/okfn/messytables/issues/comments{/number}","contents_url":"https://api.github.com/repos/okfn/messytables/contents/{+path}","compare_url":"https://api.github.com/repos/okfn/messytables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okfn/messytables/merges","archive_url":"https://api.github.com/repos/okfn/messytables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okfn/messytables/downloads","issues_url":"https://api.github.com/repos/okfn/messytables/issues{/number}","pulls_url":"https://api.github.com/repos/okfn/messytables/pulls{/number}","milestones_url":"https://api.github.com/repos/okfn/messytables/milestones{/number}","notifications_url":"https://api.github.com/repos/okfn/messytables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okfn/messytables/labels{/name}","releases_url":"https://api.github.com/repos/okfn/messytables/releases{/id}","deployments_url":"https://api.github.com/repos/okfn/messytables/deployments","created_at":"2011-07-27T18:08:21Z","updated_at":"2016-07-20T19:49:10Z","pushed_at":"2016-07-23T12:36:46Z","git_url":"git://github.com/okfn/messytables.git","ssh_url":"git@github.com:okfn/messytables.git","clone_url":"https://github.com/okfn/messytables.git","svn_url":"https://github.com/okfn/messytables","homepage":"http://messytables.readthedocs.io/","size":5397,"stargazers_count":216,"watchers_count":216,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":27,"forks":62,"open_issues":27,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okfn/messytables/pulls/139"},"html":{"href":"https://github.com/okfn/messytables/pull/139"},"issue":{"href":"https://api.github.com/repos/okfn/messytables/issues/139"},"comments":{"href":"https://api.github.com/repos/okfn/messytables/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/okfn/messytables/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/okfn/messytables/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okfn/messytables/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/okfn/messytables/statuses/3c97004314cb8bb92ca093fdab3a7369f7a69e9b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":4,"additions":103,"deletions":351,"changed_files":8}}
{"actor":{"display_login":"pudo"}}