{"action":"created","issue":{"url":"https://api.github.com/repos/rgbkrk/nbformatjs/issues/3","repository_url":"https://api.github.com/repos/rgbkrk/nbformatjs","labels_url":"https://api.github.com/repos/rgbkrk/nbformatjs/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/rgbkrk/nbformatjs/issues/3/comments","events_url":"https://api.github.com/repos/rgbkrk/nbformatjs/issues/3/events","html_url":"https://github.com/rgbkrk/nbformatjs/pull/3","id":99769694,"number":3,"title":"Switch to ajv. Looks promising.","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2015-08-08T04:22:17Z","updated_at":"2016-08-10T22:47:15Z","closed_at":"2016-08-10T22:47:15Z","pull_request":{"url":"https://api.github.com/repos/rgbkrk/nbformatjs/pulls/3","html_url":"https://github.com/rgbkrk/nbformatjs/pull/3","diff_url":"https://github.com/rgbkrk/nbformatjs/pull/3.diff","patch_url":"https://github.com/rgbkrk/nbformatjs/pull/3.patch"},"body":"https://github.com/ebdrup/json-schema-benchmark\r\n\r\n```\r\n> NotebookValidator = require('./nbformat');\r\n> nbv = new NotebookValidator();\r\n> var fs = require('fs');\r\n> var nb = \"tests/test4.ipynb\";\r\n> var nbModel = JSON.parse(fs.readFileSync(nb, 'utf8'))\r\n> nbv.validateNotebook(nbModel)\r\ntrue\r\n> nbModel = JSON.parse(fs.readFileSync(\"tests/invalid.ipynb\", 'utf8'));\r\n> nbv.validateNotebook(nbModel)\r\nfalse\r\n> nbv.errors\r\n[ { keyword: 'oneOf',\r\n    dataPath: '.cells[0]',\r\n    message: 'should match exactly one schema in oneOf' } ]\r\n```\r\n\r\nActually, the output in #1 is much better for errors. `ajv` is faster though."},"comment":{"url":"https://api.github.com/repos/rgbkrk/nbformatjs/issues/comments/239028145","html_url":"https://github.com/rgbkrk/nbformatjs/pull/3#issuecomment-239028145","issue_url":"https://api.github.com/repos/rgbkrk/nbformatjs/issues/3","id":239028145,"user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T22:47:15Z","updated_at":"2016-08-10T22:47:15Z","body":"Closing this one too, I think our decision was to stick with nbschema."}}
{"actor":{"display_login":"rgbkrk"}}