{"action":"created","issue":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/658","repository_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map","labels_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/658/labels{/name}","comments_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/658/comments","events_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/658/events","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/658","id":166682725,"number":658,"title":"Move --only --ignore to run earlier","user":{"login":"NgJason","id":6984333,"avatar_url":"https://avatars.githubusercontent.com/u/6984333?v=3","gravatar_id":"","url":"https://api.github.com/users/NgJason","html_url":"https://github.com/NgJason","followers_url":"https://api.github.com/users/NgJason/followers","following_url":"https://api.github.com/users/NgJason/following{/other_user}","gists_url":"https://api.github.com/users/NgJason/gists{/gist_id}","starred_url":"https://api.github.com/users/NgJason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NgJason/subscriptions","organizations_url":"https://api.github.com/users/NgJason/orgs","repos_url":"https://api.github.com/users/NgJason/repos","events_url":"https://api.github.com/users/NgJason/events{/privacy}","received_events_url":"https://api.github.com/users/NgJason/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-20T21:09:29Z","updated_at":"2016-07-20T22:35:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/pulls/658","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/658","diff_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/658.diff","patch_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/658.patch"},"body":"## Description\r\nMove --ignore and --only \"down\" , don't save it in to the db at all since we don't need it.\r\n\r\n## Motivation and Context\r\nIncrease performance. This is also part of:https://github.com/AHAAAAAAA/PokemonGo-Map/pull/631\r\nWe do not need to save Pokemons that we do not need in to the db, since they will be ignored when get_active() executes. This will make the query[] shorter by X amount less iterations, where X is number of ignored Pokemons. \r\n\r\n## How Has This Been Tested?\r\n- [ ] Testing\r\nPokemon servers are currently down, but ran some test in https://github.com/AHAAAAAAA/PokemonGo-Map/pull/631 before.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly."},"comment":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/comments/234105159","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/658#issuecomment-234105159","issue_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/658","id":234105159,"user":{"login":"toumaz","id":1131759,"avatar_url":"https://avatars.githubusercontent.com/u/1131759?v=3","gravatar_id":"","url":"https://api.github.com/users/toumaz","html_url":"https://github.com/toumaz","followers_url":"https://api.github.com/users/toumaz/followers","following_url":"https://api.github.com/users/toumaz/following{/other_user}","gists_url":"https://api.github.com/users/toumaz/gists{/gist_id}","starred_url":"https://api.github.com/users/toumaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toumaz/subscriptions","organizations_url":"https://api.github.com/users/toumaz/orgs","repos_url":"https://api.github.com/users/toumaz/repos","events_url":"https://api.github.com/users/toumaz/events{/privacy}","received_events_url":"https://api.github.com/users/toumaz/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T22:35:49Z","updated_at":"2016-07-20T22:35:49Z","body":"@NgJason Yes, but the database will still be populated with data from the previous search.\r\n\r\nLet me try to explain it better. Right now, if you show  `--only` certain Pokémon, you'll still store data for all the rest, adding that to the database.\r\n\r\nLet's say you then restart the app, deciding to show _all_ Pokémon, instead. You are correct in that search restarts, but since results are stored in and queried from the database, the previously found Pokémon will immediately be populated onto the map."}}
{"actor":{"display_login":"toumaz"}}