{"action":"created","issue":{"url":"https://api.github.com/repos/poststatus/wptest/issues/51","repository_url":"https://api.github.com/repos/poststatus/wptest","labels_url":"https://api.github.com/repos/poststatus/wptest/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/poststatus/wptest/issues/51/comments","events_url":"https://api.github.com/repos/poststatus/wptest/issues/51/events","html_url":"https://github.com/poststatus/wptest/issues/51","id":150100739,"number":51,"title":"WP-CLI setup script improvements","user":{"login":"franz-josef-kaiser","id":387666,"avatar_url":"https://avatars.githubusercontent.com/u/387666?v=3","gravatar_id":"","url":"https://api.github.com/users/franz-josef-kaiser","html_url":"https://github.com/franz-josef-kaiser","followers_url":"https://api.github.com/users/franz-josef-kaiser/followers","following_url":"https://api.github.com/users/franz-josef-kaiser/following{/other_user}","gists_url":"https://api.github.com/users/franz-josef-kaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/franz-josef-kaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz-josef-kaiser/subscriptions","organizations_url":"https://api.github.com/users/franz-josef-kaiser/orgs","repos_url":"https://api.github.com/users/franz-josef-kaiser/repos","events_url":"https://api.github.com/users/franz-josef-kaiser/events{/privacy}","received_events_url":"https://api.github.com/users/franz-josef-kaiser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-04-21T15:01:11Z","updated_at":"2016-09-30T06:42:46Z","closed_at":null,"body":"Currently there are two problems with the import shell script:\r\n\r\n1. It does assume that `wp` is installed and available. That can easily be [checked up front](http://stackoverflow.com/a/677212/376483) and if not, abort gracefully, informing the user what to do.\r\n1. It does not allow to run as root. In a Docker install, we have the problem that Docker containers in nearly all cases run as root, so the `--allow-root` flag should be used for the `wp` command. Maybe the best would be to allow running the script with one additional argument. That could simply be a yes/no flag that is prompted and `read`.\r\n1. When the \"WP Importer\" is not present or active, it's hard to install. Maybe there should be a check if the plugin is installed. `wp ${ROOT} plugin is-installed wordpress-importer` and then prompt if the user wants to install and activate it: `wp ${ROOT} plugin install wordpress-importer --activate`.\r\n1. The prompt for the WordPress path could slightly be improved. As the relative directory/path might be unknown, it might be better to ask for an \"absolute\" path.\r\n1. When automating this, the prompt is not really nice. It would be nice to either take the argument as flag or argument, and if not present: ask for the argument during processing."},"comment":{"url":"https://api.github.com/repos/poststatus/wptest/issues/comments/250671436","html_url":"https://github.com/poststatus/wptest/issues/51#issuecomment-250671436","issue_url":"https://api.github.com/repos/poststatus/wptest/issues/51","id":250671436,"user":{"login":"JeffMatson","id":6805601,"avatar_url":"https://avatars.githubusercontent.com/u/6805601?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffMatson","html_url":"https://github.com/JeffMatson","followers_url":"https://api.github.com/users/JeffMatson/followers","following_url":"https://api.github.com/users/JeffMatson/following{/other_user}","gists_url":"https://api.github.com/users/JeffMatson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffMatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffMatson/subscriptions","organizations_url":"https://api.github.com/users/JeffMatson/orgs","repos_url":"https://api.github.com/users/JeffMatson/repos","events_url":"https://api.github.com/users/JeffMatson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffMatson/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T06:42:46Z","updated_at":"2016-09-30T06:42:46Z","body":"I addressed several of these in PR #54 "}}
{"actor":{"display_login":"JeffMatson"}}