{"action":"created","issue":{"url":"https://api.github.com/repos/dCache/dcache/issues/2391","repository_url":"https://api.github.com/repos/dCache/dcache","labels_url":"https://api.github.com/repos/dCache/dcache/issues/2391/labels{/name}","comments_url":"https://api.github.com/repos/dCache/dcache/issues/2391/comments","events_url":"https://api.github.com/repos/dCache/dcache/issues/2391/events","html_url":"https://github.com/dCache/dcache/pull/2391","id":152745711,"number":2391,"title":"pnfsmanager: fix atime update regression","user":{"login":"kofemann","id":575965,"avatar_url":"https://avatars.githubusercontent.com/u/575965?v=3","gravatar_id":"","url":"https://api.github.com/users/kofemann","html_url":"https://github.com/kofemann","followers_url":"https://api.github.com/users/kofemann/followers","following_url":"https://api.github.com/users/kofemann/following{/other_user}","gists_url":"https://api.github.com/users/kofemann/gists{/gist_id}","starred_url":"https://api.github.com/users/kofemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofemann/subscriptions","organizations_url":"https://api.github.com/users/kofemann/orgs","repos_url":"https://api.github.com/users/kofemann/repos","events_url":"https://api.github.com/users/kofemann/events{/privacy}","received_events_url":"https://api.github.com/users/kofemann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-03T10:45:12Z","updated_at":"2016-05-12T15:43:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dCache/dcache/pulls/2391","html_url":"https://github.com/dCache/dcache/pull/2391","diff_url":"https://github.com/dCache/dcache/pull/2391.diff","patch_url":"https://github.com/dCache/dcache/pull/2391.patch"},"body":"Motivation:\r\nSetting atime-gap to -1 (default value) should disable file's last access\r\ntime updates. Nevertheless, this was not the case and atime update was always\r\nenabled.\r\n\r\nThe main reason of disabling atime update is to reduce the load on DB.\r\n\r\nModification:\r\nFix atime condition check from != -1 to >= 0 as\r\n\r\nTimeUnit.SECONDS.toMillis(-1) return -1000.\r\n\r\nResult:\r\nFile's last access time can be disabled as described in the documentation.\r\n\r\nFixes: #2390\r\nAcked-by: Gerd Behrmann\r\nTarget: master, 2.15, 2.14, 2.13, 2.12\r\nRequire-book: no\r\nRequire-notes: yes\r\n(cherry picked from commit 487095d9e0f9b2b322349f2d06b958e606d15ed8)\r\nSigned-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>"},"comment":{"url":"https://api.github.com/repos/dCache/dcache/issues/comments/218798181","html_url":"https://github.com/dCache/dcache/pull/2391#issuecomment-218798181","issue_url":"https://api.github.com/repos/dCache/dcache/issues/2391","id":218798181,"user":{"login":"paulmillar","id":533081,"avatar_url":"https://avatars.githubusercontent.com/u/533081?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmillar","html_url":"https://github.com/paulmillar","followers_url":"https://api.github.com/users/paulmillar/followers","following_url":"https://api.github.com/users/paulmillar/following{/other_user}","gists_url":"https://api.github.com/users/paulmillar/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmillar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmillar/subscriptions","organizations_url":"https://api.github.com/users/paulmillar/orgs","repos_url":"https://api.github.com/users/paulmillar/repos","events_url":"https://api.github.com/users/paulmillar/events{/privacy}","received_events_url":"https://api.github.com/users/paulmillar/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T15:43:50Z","updated_at":"2016-05-12T15:43:50Z","body":"retest this please"}}