{"action":"created","comment":{"url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/comments/80254993","id":80254993,"diff_hunk":"@@ -109,19 +109,17 @@ def add(self, delay):\n class Delay(WeakAutoUnload):\n     \"\"\"Execute a callback after a given delay.\"\"\"\n \n-    def __init__(\n-        self, delay, callback, cancel_on_map_end=False, *args, **kwargs\n-    ):\n+    def __init__(self, delay, callback, cancel_on_map_end=False, args=(), kwargs={}):","path":"addons/source-python/packages/source-python/listeners/tick.py","position":null,"original_position":7,"commit_id":"3396c8f82d5665534d0168a912668fe040ccce76","original_commit_id":"bd3d9c7fa89df61ec0eb3cff29ba23df81326987","user":{"login":"Mahi","id":11020883,"avatar_url":"https://avatars.githubusercontent.com/u/11020883?v=3","gravatar_id":"","url":"https://api.github.com/users/Mahi","html_url":"https://github.com/Mahi","followers_url":"https://api.github.com/users/Mahi/followers","following_url":"https://api.github.com/users/Mahi/following{/other_user}","gists_url":"https://api.github.com/users/Mahi/gists{/gist_id}","starred_url":"https://api.github.com/users/Mahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mahi/subscriptions","organizations_url":"https://api.github.com/users/Mahi/orgs","repos_url":"https://api.github.com/users/Mahi/repos","events_url":"https://api.github.com/users/Mahi/events{/privacy}","received_events_url":"https://api.github.com/users/Mahi/received_events","type":"User","site_admin":false},"body":"\"Better practice\" as in your favourite? ^^ I do realize that threading uses `kwargs=None`, and there's absolutely nothing wrong with that approach! I even said it's fine:\r\n\r\n> I find it more clear to use a dictionary directly than `None`, not that there's anything wrong with `None` either.\r\n\r\nTbh you're just claiming that it's \"better\" practice and my practice is bad, yet you have no arguments other than \"someone might get confused\"... Someone could very easily mistake any implementation, mine works and is perfectly valid so it's just a matter of opinion. I do know that `None` is used more often, but it's highly due to not having to convert the arguments afterwards in the method with `self.x = dict(x)`.","created_at":"2016-09-23T14:25:40Z","updated_at":"2016-09-23T14:25:40Z","html_url":"https://github.com/Source-Python-Dev-Team/Source.Python/pull/147#discussion_r80254993","pull_request_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/comments/80254993"},"html":{"href":"https://github.com/Source-Python-Dev-Team/Source.Python/pull/147#discussion_r80254993"},"pull_request":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147","id":86503462,"html_url":"https://github.com/Source-Python-Dev-Team/Source.Python/pull/147","diff_url":"https://github.com/Source-Python-Dev-Team/Source.Python/pull/147.diff","patch_url":"https://github.com/Source-Python-Dev-Team/Source.Python/pull/147.patch","issue_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/issues/147","number":147,"state":"closed","locked":false,"title":"Tick update","user":{"login":"Mahi","id":11020883,"avatar_url":"https://avatars.githubusercontent.com/u/11020883?v=3","gravatar_id":"","url":"https://api.github.com/users/Mahi","html_url":"https://github.com/Mahi","followers_url":"https://api.github.com/users/Mahi/followers","following_url":"https://api.github.com/users/Mahi/following{/other_user}","gists_url":"https://api.github.com/users/Mahi/gists{/gist_id}","starred_url":"https://api.github.com/users/Mahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mahi/subscriptions","organizations_url":"https://api.github.com/users/Mahi/orgs","repos_url":"https://api.github.com/users/Mahi/repos","events_url":"https://api.github.com/users/Mahi/events{/privacy}","received_events_url":"https://api.github.com/users/Mahi/received_events","type":"User","site_admin":false},"body":"Updated `Delay` to use normal arguments for `args` and `kwargs` instead of `*args` and `**kwargs` for the arguments that get forwarded to the delayed callback. Also changed `cancel_on_map_end` to a keyword argument.","created_at":"2016-09-23T12:22:55Z","updated_at":"2016-09-23T14:25:40Z","closed_at":"2016-09-23T12:44:01Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147/commits","review_comments_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147/comments","review_comment_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/issues/147/comments","statuses_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/statuses/3396c8f82d5665534d0168a912668fe040ccce76","head":{"label":"Mahi:tick_update","ref":"tick_update","sha":"3396c8f82d5665534d0168a912668fe040ccce76","user":{"login":"Mahi","id":11020883,"avatar_url":"https://avatars.githubusercontent.com/u/11020883?v=3","gravatar_id":"","url":"https://api.github.com/users/Mahi","html_url":"https://github.com/Mahi","followers_url":"https://api.github.com/users/Mahi/followers","following_url":"https://api.github.com/users/Mahi/following{/other_user}","gists_url":"https://api.github.com/users/Mahi/gists{/gist_id}","starred_url":"https://api.github.com/users/Mahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mahi/subscriptions","organizations_url":"https://api.github.com/users/Mahi/orgs","repos_url":"https://api.github.com/users/Mahi/repos","events_url":"https://api.github.com/users/Mahi/events{/privacy}","received_events_url":"https://api.github.com/users/Mahi/received_events","type":"User","site_admin":false},"repo":{"id":69022200,"name":"Source.Python","full_name":"Mahi/Source.Python","owner":{"login":"Mahi","id":11020883,"avatar_url":"https://avatars.githubusercontent.com/u/11020883?v=3","gravatar_id":"","url":"https://api.github.com/users/Mahi","html_url":"https://github.com/Mahi","followers_url":"https://api.github.com/users/Mahi/followers","following_url":"https://api.github.com/users/Mahi/following{/other_user}","gists_url":"https://api.github.com/users/Mahi/gists{/gist_id}","starred_url":"https://api.github.com/users/Mahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mahi/subscriptions","organizations_url":"https://api.github.com/users/Mahi/orgs","repos_url":"https://api.github.com/users/Mahi/repos","events_url":"https://api.github.com/users/Mahi/events{/privacy}","received_events_url":"https://api.github.com/users/Mahi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mahi/Source.Python","description":"This plugin aims to use boost::python and create an easily accessible wrapper around the Source Engine API for scripter use.","fork":true,"url":"https://api.github.com/repos/Mahi/Source.Python","forks_url":"https://api.github.com/repos/Mahi/Source.Python/forks","keys_url":"https://api.github.com/repos/Mahi/Source.Python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mahi/Source.Python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mahi/Source.Python/teams","hooks_url":"https://api.github.com/repos/Mahi/Source.Python/hooks","issue_events_url":"https://api.github.com/repos/Mahi/Source.Python/issues/events{/number}","events_url":"https://api.github.com/repos/Mahi/Source.Python/events","assignees_url":"https://api.github.com/repos/Mahi/Source.Python/assignees{/user}","branches_url":"https://api.github.com/repos/Mahi/Source.Python/branches{/branch}","tags_url":"https://api.github.com/repos/Mahi/Source.Python/tags","blobs_url":"https://api.github.com/repos/Mahi/Source.Python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mahi/Source.Python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mahi/Source.Python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mahi/Source.Python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mahi/Source.Python/statuses/{sha}","languages_url":"https://api.github.com/repos/Mahi/Source.Python/languages","stargazers_url":"https://api.github.com/repos/Mahi/Source.Python/stargazers","contributors_url":"https://api.github.com/repos/Mahi/Source.Python/contributors","subscribers_url":"https://api.github.com/repos/Mahi/Source.Python/subscribers","subscription_url":"https://api.github.com/repos/Mahi/Source.Python/subscription","commits_url":"https://api.github.com/repos/Mahi/Source.Python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mahi/Source.Python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mahi/Source.Python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mahi/Source.Python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mahi/Source.Python/contents/{+path}","compare_url":"https://api.github.com/repos/Mahi/Source.Python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mahi/Source.Python/merges","archive_url":"https://api.github.com/repos/Mahi/Source.Python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mahi/Source.Python/downloads","issues_url":"https://api.github.com/repos/Mahi/Source.Python/issues{/number}","pulls_url":"https://api.github.com/repos/Mahi/Source.Python/pulls{/number}","milestones_url":"https://api.github.com/repos/Mahi/Source.Python/milestones{/number}","notifications_url":"https://api.github.com/repos/Mahi/Source.Python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mahi/Source.Python/labels{/name}","releases_url":"https://api.github.com/repos/Mahi/Source.Python/releases{/id}","deployments_url":"https://api.github.com/repos/Mahi/Source.Python/deployments","created_at":"2016-09-23T12:20:10Z","updated_at":"2016-09-23T12:20:21Z","pushed_at":"2016-09-23T12:38:30Z","git_url":"git://github.com/Mahi/Source.Python.git","ssh_url":"git@github.com:Mahi/Source.Python.git","clone_url":"https://github.com/Mahi/Source.Python.git","svn_url":"https://github.com/Mahi/Source.Python","homepage":"http://forums.sourcepython.com","size":327606,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Source-Python-Dev-Team:tick_update","ref":"tick_update","sha":"e624cfdedde97fd1ffa34b4b6408c6d843309208","user":{"login":"Source-Python-Dev-Team","id":5440368,"avatar_url":"https://avatars.githubusercontent.com/u/5440368?v=3","gravatar_id":"","url":"https://api.github.com/users/Source-Python-Dev-Team","html_url":"https://github.com/Source-Python-Dev-Team","followers_url":"https://api.github.com/users/Source-Python-Dev-Team/followers","following_url":"https://api.github.com/users/Source-Python-Dev-Team/following{/other_user}","gists_url":"https://api.github.com/users/Source-Python-Dev-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Source-Python-Dev-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Source-Python-Dev-Team/subscriptions","organizations_url":"https://api.github.com/users/Source-Python-Dev-Team/orgs","repos_url":"https://api.github.com/users/Source-Python-Dev-Team/repos","events_url":"https://api.github.com/users/Source-Python-Dev-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Source-Python-Dev-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":12771934,"name":"Source.Python","full_name":"Source-Python-Dev-Team/Source.Python","owner":{"login":"Source-Python-Dev-Team","id":5440368,"avatar_url":"https://avatars.githubusercontent.com/u/5440368?v=3","gravatar_id":"","url":"https://api.github.com/users/Source-Python-Dev-Team","html_url":"https://github.com/Source-Python-Dev-Team","followers_url":"https://api.github.com/users/Source-Python-Dev-Team/followers","following_url":"https://api.github.com/users/Source-Python-Dev-Team/following{/other_user}","gists_url":"https://api.github.com/users/Source-Python-Dev-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Source-Python-Dev-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Source-Python-Dev-Team/subscriptions","organizations_url":"https://api.github.com/users/Source-Python-Dev-Team/orgs","repos_url":"https://api.github.com/users/Source-Python-Dev-Team/repos","events_url":"https://api.github.com/users/Source-Python-Dev-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Source-Python-Dev-Team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Source-Python-Dev-Team/Source.Python","description":"This plugin aims to use boost::python and create an easily accessible wrapper around the Source Engine API for scripter use.","fork":false,"url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python","forks_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/forks","keys_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/teams","hooks_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/hooks","issue_events_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/issues/events{/number}","events_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/events","assignees_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/assignees{/user}","branches_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/branches{/branch}","tags_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/tags","blobs_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/statuses/{sha}","languages_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/languages","stargazers_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/stargazers","contributors_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/contributors","subscribers_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/subscribers","subscription_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/subscription","commits_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/contents/{+path}","compare_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/merges","archive_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/downloads","issues_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/issues{/number}","pulls_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls{/number}","milestones_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/milestones{/number}","notifications_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/labels{/name}","releases_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/releases{/id}","deployments_url":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/deployments","created_at":"2013-09-12T01:13:58Z","updated_at":"2016-09-17T00:20:11Z","pushed_at":"2016-09-23T13:13:45Z","git_url":"git://github.com/Source-Python-Dev-Team/Source.Python.git","ssh_url":"git@github.com:Source-Python-Dev-Team/Source.Python.git","clone_url":"https://github.com/Source-Python-Dev-Team/Source.Python.git","svn_url":"https://github.com/Source-Python-Dev-Team/Source.Python","homepage":"http://forums.sourcepython.com","size":338205,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":12,"forks":17,"open_issues":12,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147"},"html":{"href":"https://github.com/Source-Python-Dev-Team/Source.Python/pull/147"},"issue":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/issues/147"},"comments":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/Source-Python-Dev-Team/Source.Python/statuses/3396c8f82d5665534d0168a912668fe040ccce76"}}}}
{"actor":{"display_login":"Mahi"}}