{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/61594763","id":61594763,"diff_hunk":"@@ -30,22 +30,24 @@ const (\n \t// be executed too close to the TTL check timeout\n \tcheckMinBuffer = 100 * time.Millisecond\n \n+\t// consulRetryInterval specifies the retry duration to use when an\n+\t// API call to the Consul agent fails.\n+\tconsulRetryInterval = 1 * time.Second\n+\n \t// defaultCheckTimeout changes the timeout of TTL checks\n \tdefaultCheckTimeout = 5 * time.Second\n \n-\t// defaultCheckInterval specifies the default interval used to send\n-\t// checks\n-\tdefaultCheckInterval = 4 * time.Second\n-\n \t// defaultServiceName is the default Consul service name used when\n \t// advertising a Vault instance.\n \tdefaultServiceName = \"vault\"\n \n-\t// registrationRetryInterval specifies the retry duration to use when\n-\t// a registration to the Consul agent fails.\n-\tregistrationRetryInterval = 1 * time.Second\n+\t// reconcileTimeout is how often Vault should query Consul to detect\n+\t// and fix any state drift.\n+\treconcileTimeout = 60 * time.Second\n )\n \n+type notifyEvent struct{}","path":"physical/consul.go","position":27,"original_position":27,"commit_id":"01fac00f20f4cae6fd47798004f70729c00ccea9","original_commit_id":"01fac00f20f4cae6fd47798004f70729c00ccea9","user":{"login":"vishalnayak","id":3053672,"avatar_url":"https://avatars.githubusercontent.com/u/3053672?v=3","gravatar_id":"","url":"https://api.github.com/users/vishalnayak","html_url":"https://github.com/vishalnayak","followers_url":"https://api.github.com/users/vishalnayak/followers","following_url":"https://api.github.com/users/vishalnayak/following{/other_user}","gists_url":"https://api.github.com/users/vishalnayak/gists{/gist_id}","starred_url":"https://api.github.com/users/vishalnayak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishalnayak/subscriptions","organizations_url":"https://api.github.com/users/vishalnayak/orgs","repos_url":"https://api.github.com/users/vishalnayak/repos","events_url":"https://api.github.com/users/vishalnayak/events{/privacy}","received_events_url":"https://api.github.com/users/vishalnayak/received_events","type":"User","site_admin":false},"body":"This gives an impression that we are sending some info down the channel.\r\nIt can simply be like this:\r\n`notifyActiveCh chan notifyEvent` --> `notifyActiveCh chan struct{}`\r\n`case c.notifyActiveCh <- notifyEvent{}` --> `case c.notifyActiveCh <- struct{}{}`","created_at":"2016-04-29T15:22:37Z","updated_at":"2016-04-29T15:22:37Z","html_url":"https://github.com/hashicorp/vault/pull/1355#discussion_r61594763","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/1355","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/61594763"},"html":{"href":"https://github.com/hashicorp/vault/pull/1355#discussion_r61594763"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1355"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/1355","id":68264535,"html_url":"https://github.com/hashicorp/vault/pull/1355","diff_url":"https://github.com/hashicorp/vault/pull/1355.diff","patch_url":"https://github.com/hashicorp/vault/pull/1355.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/1355","number":1355,"state":"open","locked":false,"title":"F vault service","user":{"login":"sean-","id":349516,"avatar_url":"https://avatars.githubusercontent.com/u/349516?v=3","gravatar_id":"","url":"https://api.github.com/users/sean-","html_url":"https://github.com/sean-","followers_url":"https://api.github.com/users/sean-/followers","following_url":"https://api.github.com/users/sean-/following{/other_user}","gists_url":"https://api.github.com/users/sean-/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-/subscriptions","organizations_url":"https://api.github.com/users/sean-/orgs","repos_url":"https://api.github.com/users/sean-/repos","events_url":"https://api.github.com/users/sean-/events{/privacy}","received_events_url":"https://api.github.com/users/sean-/received_events","type":"User","site_admin":false},"body":"Refactor Consul Service Discovery to use an evented demuxer.","created_at":"2016-04-28T18:06:19Z","updated_at":"2016-04-29T15:22:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae8a8bc8ffb8bf9a96aa693d1e2887de0283c218","assignee":{"login":"sean-","id":349516,"avatar_url":"https://avatars.githubusercontent.com/u/349516?v=3","gravatar_id":"","url":"https://api.github.com/users/sean-","html_url":"https://github.com/sean-","followers_url":"https://api.github.com/users/sean-/followers","following_url":"https://api.github.com/users/sean-/following{/other_user}","gists_url":"https://api.github.com/users/sean-/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-/subscriptions","organizations_url":"https://api.github.com/users/sean-/orgs","repos_url":"https://api.github.com/users/sean-/repos","events_url":"https://api.github.com/users/sean-/events{/privacy}","received_events_url":"https://api.github.com/users/sean-/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/1355/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/1355/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/1355/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/01fac00f20f4cae6fd47798004f70729c00ccea9","head":{"label":"hashicorp:f-vault-service","ref":"f-vault-service","sha":"01fac00f20f4cae6fd47798004f70729c00ccea9","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for managing secrets.","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2016-04-29T13:28:41Z","pushed_at":"2016-04-29T14:33:58Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":15179,"stargazers_count":4483,"watchers_count":4483,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":158,"forks":408,"open_issues":158,"watchers":4483,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"b5b8ac8686cc8efe6835fc2e2e0287cbe64173da","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for managing secrets.","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2016-04-29T13:28:41Z","pushed_at":"2016-04-29T14:33:58Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":15179,"stargazers_count":4483,"watchers_count":4483,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":158,"forks":408,"open_issues":158,"watchers":4483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1355"},"html":{"href":"https://github.com/hashicorp/vault/pull/1355"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/1355"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/1355/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1355/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1355/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/01fac00f20f4cae6fd47798004f70729c00ccea9"}}}}