{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/internals/issues/182","repository_url":"https://api.github.com/repos/laravel/internals","labels_url":"https://api.github.com/repos/laravel/internals/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/laravel/internals/issues/182/comments","events_url":"https://api.github.com/repos/laravel/internals/issues/182/events","html_url":"https://github.com/laravel/internals/issues/182","id":173401507,"number":182,"title":"[5.4] Remove macros on router","user":{"login":"garygreen","id":1702638,"avatar_url":"https://avatars.githubusercontent.com/u/1702638?v=3","gravatar_id":"","url":"https://api.github.com/users/garygreen","html_url":"https://github.com/garygreen","followers_url":"https://api.github.com/users/garygreen/followers","following_url":"https://api.github.com/users/garygreen/following{/other_user}","gists_url":"https://api.github.com/users/garygreen/gists{/gist_id}","starred_url":"https://api.github.com/users/garygreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garygreen/subscriptions","organizations_url":"https://api.github.com/users/garygreen/orgs","repos_url":"https://api.github.com/users/garygreen/repos","events_url":"https://api.github.com/users/garygreen/events{/privacy}","received_events_url":"https://api.github.com/users/garygreen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-26T08:46:12Z","updated_at":"2016-08-26T08:53:18Z","closed_at":"2016-08-26T08:53:18Z","body":"Macros break the ability to cache routes - this promotes bad practise and should be removed.\r\n\r\n```\r\nRoute::macro('i_break_all_the_cachings', function() {\r\n    \r\n});\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/laravel/internals/issues/comments/242671051","html_url":"https://github.com/laravel/internals/issues/182#issuecomment-242671051","issue_url":"https://api.github.com/repos/laravel/internals/issues/182","id":242671051,"user":{"login":"garygreen","id":1702638,"avatar_url":"https://avatars.githubusercontent.com/u/1702638?v=3","gravatar_id":"","url":"https://api.github.com/users/garygreen","html_url":"https://github.com/garygreen","followers_url":"https://api.github.com/users/garygreen/followers","following_url":"https://api.github.com/users/garygreen/following{/other_user}","gists_url":"https://api.github.com/users/garygreen/gists{/gist_id}","starred_url":"https://api.github.com/users/garygreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garygreen/subscriptions","organizations_url":"https://api.github.com/users/garygreen/orgs","repos_url":"https://api.github.com/users/garygreen/repos","events_url":"https://api.github.com/users/garygreen/events{/privacy}","received_events_url":"https://api.github.com/users/garygreen/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T08:53:18Z","updated_at":"2016-08-26T08:53:18Z","body":"Hmm if you did something like this you could still use macros and route caching...\r\n\r\n```php\r\nclass Test {\r\n\r\n    public function __invoke($url)\r\n    {\r\n        //\r\n    }\r\n    \r\n}\r\n\r\nRoute::macro('i_break_all_the_cachings', new Test);\r\n```\r\n\r\nSo I guess it's still a viable option."}}
{"actor":{"display_login":"garygreen"}}