{"action":"created","issue":{"url":"https://api.github.com/repos/request/request/issues/2058","repository_url":"https://api.github.com/repos/request/request","labels_url":"https://api.github.com/repos/request/request/issues/2058/labels{/name}","comments_url":"https://api.github.com/repos/request/request/issues/2058/comments","events_url":"https://api.github.com/repos/request/request/issues/2058/events","html_url":"https://github.com/request/request/pull/2058","id":131452542,"number":2058,"title":"Karma fixes for latest versions","user":{"login":"eiriksm","id":865153,"avatar_url":"https://avatars.githubusercontent.com/u/865153?v=3","gravatar_id":"","url":"https://api.github.com/users/eiriksm","html_url":"https://github.com/eiriksm","followers_url":"https://api.github.com/users/eiriksm/followers","following_url":"https://api.github.com/users/eiriksm/following{/other_user}","gists_url":"https://api.github.com/users/eiriksm/gists{/gist_id}","starred_url":"https://api.github.com/users/eiriksm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eiriksm/subscriptions","organizations_url":"https://api.github.com/users/eiriksm/orgs","repos_url":"https://api.github.com/users/eiriksm/repos","events_url":"https://api.github.com/users/eiriksm/events{/privacy}","received_events_url":"https://api.github.com/users/eiriksm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-04T19:33:59Z","updated_at":"2016-02-04T19:35:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/request/request/pulls/2058","html_url":"https://github.com/request/request/pull/2058","diff_url":"https://github.com/request/request/pull/2058.diff","patch_url":"https://github.com/request/request/pull/2058.patch"},"body":"So, here is some fixes that closes #2035 and #2044 \r\n\r\nFirst off, one of the issues were that we are testing across 3 versions of npm. They have different behaviours when encountering peerDependencies. So ideally I would almost say we should upgrade npm to at least npm@2 for node 0.10. But open to opinions there. This was the least disruptive change, in my opinion.\r\n\r\nSecond, one of the issues were pointing out that the response object changed for one of the tests. So I ran the same test code with node, where the result was illuminating the fact that the browser test was testing for something only happening in the browser. So I changed that test, so it can check for a result that also is the same result when running on node."},"comment":{"url":"https://api.github.com/repos/request/request/issues/comments/180016562","html_url":"https://github.com/request/request/pull/2058#issuecomment-180016562","issue_url":"https://api.github.com/repos/request/request/issues/2058","id":180016562,"user":{"login":"eiriksm","id":865153,"avatar_url":"https://avatars.githubusercontent.com/u/865153?v=3","gravatar_id":"","url":"https://api.github.com/users/eiriksm","html_url":"https://github.com/eiriksm","followers_url":"https://api.github.com/users/eiriksm/followers","following_url":"https://api.github.com/users/eiriksm/following{/other_user}","gists_url":"https://api.github.com/users/eiriksm/gists{/gist_id}","starred_url":"https://api.github.com/users/eiriksm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eiriksm/subscriptions","organizations_url":"https://api.github.com/users/eiriksm/orgs","repos_url":"https://api.github.com/users/eiriksm/repos","events_url":"https://api.github.com/users/eiriksm/events{/privacy}","received_events_url":"https://api.github.com/users/eiriksm/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T19:35:06Z","updated_at":"2016-02-04T19:35:06Z","body":"Also, let me know if I should squash these commits. Had to do a couple of runs to get the suite to run it on travis to be sure :)"}}