{"action":"opened","number":182,"pull_request":{"url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/182","id":79131643,"html_url":"https://github.com/eris-ltd/eris-db/pull/182","diff_url":"https://github.com/eris-ltd/eris-db/pull/182.diff","patch_url":"https://github.com/eris-ltd/eris-db/pull/182.patch","issue_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/182","number":182,"state":"open","locked":false,"title":"Create fix","user":{"login":"ebuchman","id":2300911,"avatar_url":"https://avatars.githubusercontent.com/u/2300911?v=3","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"body":"So this was actually pretty bad. Amazing that we never got it, probably because we never really cared about tokens. Basic \"address.send()\" from a contract [was broken](https://github.com/eris-ltd/eris-db/compare/create_fix?expand=1#diff-735ecc7ace7329b12bfb59eaa38f682bR495)! [This comment/contract](https://github.com/eris-ltd/eris-db/blob/develop/manager/eris-mint/evm/vm.go#L116) wasn't true, since we were [making calls without adding the account to the tx cache](https://github.com/eris-ltd/eris-db/blob/develop/manager/eris-mint/evm/vm.go#L814).\r\n\r\nThe new tests involve pre-compiled solidity contracts. It may be better to move them to epm, or to replace them with hand-written minimal byte code that captures the functionality.","created_at":"2016-07-28T03:18:53Z","updated_at":"2016-07-28T03:18:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/182/commits","review_comments_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/182/comments","review_comment_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/182/comments","statuses_url":"https://api.github.com/repos/eris-ltd/eris-db/statuses/694163381d2f1f9906ab32a9d0ea71e672a3e108","head":{"label":"eris-ltd:create_fix","ref":"create_fix","sha":"694163381d2f1f9906ab32a9d0ea71e672a3e108","user":{"login":"eris-ltd","id":7984777,"avatar_url":"https://avatars.githubusercontent.com/u/7984777?v=3","gravatar_id":"","url":"https://api.github.com/users/eris-ltd","html_url":"https://github.com/eris-ltd","followers_url":"https://api.github.com/users/eris-ltd/followers","following_url":"https://api.github.com/users/eris-ltd/following{/other_user}","gists_url":"https://api.github.com/users/eris-ltd/gists{/gist_id}","starred_url":"https://api.github.com/users/eris-ltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eris-ltd/subscriptions","organizations_url":"https://api.github.com/users/eris-ltd/orgs","repos_url":"https://api.github.com/users/eris-ltd/repos","events_url":"https://api.github.com/users/eris-ltd/events{/privacy}","received_events_url":"https://api.github.com/users/eris-ltd/received_events","type":"Organization","site_admin":false},"repo":{"id":37093171,"name":"eris-db","full_name":"eris-ltd/eris-db","owner":{"login":"eris-ltd","id":7984777,"avatar_url":"https://avatars.githubusercontent.com/u/7984777?v=3","gravatar_id":"","url":"https://api.github.com/users/eris-ltd","html_url":"https://github.com/eris-ltd","followers_url":"https://api.github.com/users/eris-ltd/followers","following_url":"https://api.github.com/users/eris-ltd/following{/other_user}","gists_url":"https://api.github.com/users/eris-ltd/gists{/gist_id}","starred_url":"https://api.github.com/users/eris-ltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eris-ltd/subscriptions","organizations_url":"https://api.github.com/users/eris-ltd/orgs","repos_url":"https://api.github.com/users/eris-ltd/repos","events_url":"https://api.github.com/users/eris-ltd/events{/privacy}","received_events_url":"https://api.github.com/users/eris-ltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eris-ltd/eris-db","description":"Eris Industries' Blockchain Design (EVM+Permissions+Mint4Consensus)","fork":false,"url":"https://api.github.com/repos/eris-ltd/eris-db","forks_url":"https://api.github.com/repos/eris-ltd/eris-db/forks","keys_url":"https://api.github.com/repos/eris-ltd/eris-db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eris-ltd/eris-db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eris-ltd/eris-db/teams","hooks_url":"https://api.github.com/repos/eris-ltd/eris-db/hooks","issue_events_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/events{/number}","events_url":"https://api.github.com/repos/eris-ltd/eris-db/events","assignees_url":"https://api.github.com/repos/eris-ltd/eris-db/assignees{/user}","branches_url":"https://api.github.com/repos/eris-ltd/eris-db/branches{/branch}","tags_url":"https://api.github.com/repos/eris-ltd/eris-db/tags","blobs_url":"https://api.github.com/repos/eris-ltd/eris-db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eris-ltd/eris-db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eris-ltd/eris-db/git/refs{/sha}","trees_url":"https://api.github.com/repos/eris-ltd/eris-db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eris-ltd/eris-db/statuses/{sha}","languages_url":"https://api.github.com/repos/eris-ltd/eris-db/languages","stargazers_url":"https://api.github.com/repos/eris-ltd/eris-db/stargazers","contributors_url":"https://api.github.com/repos/eris-ltd/eris-db/contributors","subscribers_url":"https://api.github.com/repos/eris-ltd/eris-db/subscribers","subscription_url":"https://api.github.com/repos/eris-ltd/eris-db/subscription","commits_url":"https://api.github.com/repos/eris-ltd/eris-db/commits{/sha}","git_commits_url":"https://api.github.com/repos/eris-ltd/eris-db/git/commits{/sha}","comments_url":"https://api.github.com/repos/eris-ltd/eris-db/comments{/number}","issue_comment_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/comments{/number}","contents_url":"https://api.github.com/repos/eris-ltd/eris-db/contents/{+path}","compare_url":"https://api.github.com/repos/eris-ltd/eris-db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eris-ltd/eris-db/merges","archive_url":"https://api.github.com/repos/eris-ltd/eris-db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eris-ltd/eris-db/downloads","issues_url":"https://api.github.com/repos/eris-ltd/eris-db/issues{/number}","pulls_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls{/number}","milestones_url":"https://api.github.com/repos/eris-ltd/eris-db/milestones{/number}","notifications_url":"https://api.github.com/repos/eris-ltd/eris-db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eris-ltd/eris-db/labels{/name}","releases_url":"https://api.github.com/repos/eris-ltd/eris-db/releases{/id}","deployments_url":"https://api.github.com/repos/eris-ltd/eris-db/deployments","created_at":"2015-06-08T21:14:27Z","updated_at":"2016-06-25T18:27:09Z","pushed_at":"2016-07-28T03:10:39Z","git_url":"git://github.com/eris-ltd/eris-db.git","ssh_url":"git@github.com:eris-ltd/eris-db.git","clone_url":"https://github.com/eris-ltd/eris-db.git","svn_url":"https://github.com/eris-ltd/eris-db","homepage":"https://docs.erisindustries.com","size":11931,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":48,"forks":20,"open_issues":48,"watchers":37,"default_branch":"develop"}},"base":{"label":"eris-ltd:develop","ref":"develop","sha":"809a7eab271eb9dede3f89b0f2a76eba14a3bfc1","user":{"login":"eris-ltd","id":7984777,"avatar_url":"https://avatars.githubusercontent.com/u/7984777?v=3","gravatar_id":"","url":"https://api.github.com/users/eris-ltd","html_url":"https://github.com/eris-ltd","followers_url":"https://api.github.com/users/eris-ltd/followers","following_url":"https://api.github.com/users/eris-ltd/following{/other_user}","gists_url":"https://api.github.com/users/eris-ltd/gists{/gist_id}","starred_url":"https://api.github.com/users/eris-ltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eris-ltd/subscriptions","organizations_url":"https://api.github.com/users/eris-ltd/orgs","repos_url":"https://api.github.com/users/eris-ltd/repos","events_url":"https://api.github.com/users/eris-ltd/events{/privacy}","received_events_url":"https://api.github.com/users/eris-ltd/received_events","type":"Organization","site_admin":false},"repo":{"id":37093171,"name":"eris-db","full_name":"eris-ltd/eris-db","owner":{"login":"eris-ltd","id":7984777,"avatar_url":"https://avatars.githubusercontent.com/u/7984777?v=3","gravatar_id":"","url":"https://api.github.com/users/eris-ltd","html_url":"https://github.com/eris-ltd","followers_url":"https://api.github.com/users/eris-ltd/followers","following_url":"https://api.github.com/users/eris-ltd/following{/other_user}","gists_url":"https://api.github.com/users/eris-ltd/gists{/gist_id}","starred_url":"https://api.github.com/users/eris-ltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eris-ltd/subscriptions","organizations_url":"https://api.github.com/users/eris-ltd/orgs","repos_url":"https://api.github.com/users/eris-ltd/repos","events_url":"https://api.github.com/users/eris-ltd/events{/privacy}","received_events_url":"https://api.github.com/users/eris-ltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eris-ltd/eris-db","description":"Eris Industries' Blockchain Design (EVM+Permissions+Mint4Consensus)","fork":false,"url":"https://api.github.com/repos/eris-ltd/eris-db","forks_url":"https://api.github.com/repos/eris-ltd/eris-db/forks","keys_url":"https://api.github.com/repos/eris-ltd/eris-db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eris-ltd/eris-db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eris-ltd/eris-db/teams","hooks_url":"https://api.github.com/repos/eris-ltd/eris-db/hooks","issue_events_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/events{/number}","events_url":"https://api.github.com/repos/eris-ltd/eris-db/events","assignees_url":"https://api.github.com/repos/eris-ltd/eris-db/assignees{/user}","branches_url":"https://api.github.com/repos/eris-ltd/eris-db/branches{/branch}","tags_url":"https://api.github.com/repos/eris-ltd/eris-db/tags","blobs_url":"https://api.github.com/repos/eris-ltd/eris-db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eris-ltd/eris-db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eris-ltd/eris-db/git/refs{/sha}","trees_url":"https://api.github.com/repos/eris-ltd/eris-db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eris-ltd/eris-db/statuses/{sha}","languages_url":"https://api.github.com/repos/eris-ltd/eris-db/languages","stargazers_url":"https://api.github.com/repos/eris-ltd/eris-db/stargazers","contributors_url":"https://api.github.com/repos/eris-ltd/eris-db/contributors","subscribers_url":"https://api.github.com/repos/eris-ltd/eris-db/subscribers","subscription_url":"https://api.github.com/repos/eris-ltd/eris-db/subscription","commits_url":"https://api.github.com/repos/eris-ltd/eris-db/commits{/sha}","git_commits_url":"https://api.github.com/repos/eris-ltd/eris-db/git/commits{/sha}","comments_url":"https://api.github.com/repos/eris-ltd/eris-db/comments{/number}","issue_comment_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/comments{/number}","contents_url":"https://api.github.com/repos/eris-ltd/eris-db/contents/{+path}","compare_url":"https://api.github.com/repos/eris-ltd/eris-db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eris-ltd/eris-db/merges","archive_url":"https://api.github.com/repos/eris-ltd/eris-db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eris-ltd/eris-db/downloads","issues_url":"https://api.github.com/repos/eris-ltd/eris-db/issues{/number}","pulls_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls{/number}","milestones_url":"https://api.github.com/repos/eris-ltd/eris-db/milestones{/number}","notifications_url":"https://api.github.com/repos/eris-ltd/eris-db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eris-ltd/eris-db/labels{/name}","releases_url":"https://api.github.com/repos/eris-ltd/eris-db/releases{/id}","deployments_url":"https://api.github.com/repos/eris-ltd/eris-db/deployments","created_at":"2015-06-08T21:14:27Z","updated_at":"2016-06-25T18:27:09Z","pushed_at":"2016-07-28T03:10:39Z","git_url":"git://github.com/eris-ltd/eris-db.git","ssh_url":"git@github.com:eris-ltd/eris-db.git","clone_url":"https://github.com/eris-ltd/eris-db.git","svn_url":"https://github.com/eris-ltd/eris-db","homepage":"https://docs.erisindustries.com","size":11931,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":48,"forks":20,"open_issues":48,"watchers":37,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/182"},"html":{"href":"https://github.com/eris-ltd/eris-db/pull/182"},"issue":{"href":"https://api.github.com/repos/eris-ltd/eris-db/issues/182"},"comments":{"href":"https://api.github.com/repos/eris-ltd/eris-db/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/eris-ltd/eris-db/statuses/694163381d2f1f9906ab32a9d0ea71e672a3e108"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":159,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"ebuchman"}}