{"action":"created","comment":{"url":"https://api.github.com/repos/zikula/core/pulls/comments/75994468","id":75994468,"diff_hunk":"@@ -79,25 +76,23 @@ public function initPhp()\n \n     public function requirementsMet(ContainerInterface $container)\n     {\n+        // several other requirements are checked before Symfony is loaded.\n+        // @see app/SymfonyRequirements.php\n+        // @see \\Zikula\\Bundle\\CoreInstallerBundle\\Util\\ZikulaRequirements::runSymfonyChecks\n         $results = [];\n \n         $x = explode('.', str_replace('-', '.', phpversion()));\n         $phpVersion = \"$x[0].$x[1].$x[2]\";\n         $results['phpsatisfied'] = version_compare($phpVersion, \\Zikula_Core::PHP_MINIMUM_VERSION, \">=\");\n \n-        $results['datetimezone'] = ini_get('date.timezone');\n         $results['pdo'] = extension_loaded('pdo');\n-        $results['phptokens'] = function_exists('token_get_all');\n         $results['mbstring'] = function_exists('mb_get_info');","path":"src/lib/Zikula/Bundle/CoreInstallerBundle/Util/ControllerUtil.php","position":26,"original_position":26,"commit_id":"a137f9cace1918d294b632a7c895b5cd9c7666c6","original_commit_id":"a137f9cace1918d294b632a7c895b5cd9c7666c6","user":{"login":"Guite","id":277531,"avatar_url":"https://avatars.githubusercontent.com/u/277531?v=3","gravatar_id":"","url":"https://api.github.com/users/Guite","html_url":"https://github.com/Guite","followers_url":"https://api.github.com/users/Guite/followers","following_url":"https://api.github.com/users/Guite/following{/other_user}","gists_url":"https://api.github.com/users/Guite/gists{/gist_id}","starred_url":"https://api.github.com/users/Guite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guite/subscriptions","organizations_url":"https://api.github.com/users/Guite/orgs","repos_url":"https://api.github.com/users/Guite/repos","events_url":"https://api.github.com/users/Guite/events{/privacy}","received_events_url":"https://api.github.com/users/Guite/received_events","type":"User","site_admin":false},"body":"You added a `mbstring` requirement in `ZikulaRequirements`, so maybe this one here is redundant to that?","created_at":"2016-08-24T04:49:40Z","updated_at":"2016-08-24T04:49:40Z","html_url":"https://github.com/zikula/core/pull/3023#discussion_r75994468","pull_request_url":"https://api.github.com/repos/zikula/core/pulls/3023","_links":{"self":{"href":"https://api.github.com/repos/zikula/core/pulls/comments/75994468"},"html":{"href":"https://github.com/zikula/core/pull/3023#discussion_r75994468"},"pull_request":{"href":"https://api.github.com/repos/zikula/core/pulls/3023"}}},"pull_request":{"url":"https://api.github.com/repos/zikula/core/pulls/3023","id":82236773,"html_url":"https://github.com/zikula/core/pull/3023","diff_url":"https://github.com/zikula/core/pull/3023.diff","patch_url":"https://github.com/zikula/core/pull/3023.patch","issue_url":"https://api.github.com/repos/zikula/core/issues/3023","number":3023,"state":"open","locked":false,"title":"add install checker ","user":{"login":"craigh","id":350048,"avatar_url":"https://avatars.githubusercontent.com/u/350048?v=3","gravatar_id":"","url":"https://api.github.com/users/craigh","html_url":"https://github.com/craigh","followers_url":"https://api.github.com/users/craigh/followers","following_url":"https://api.github.com/users/craigh/following{/other_user}","gists_url":"https://api.github.com/users/craigh/gists{/gist_id}","starred_url":"https://api.github.com/users/craigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigh/subscriptions","organizations_url":"https://api.github.com/users/craigh/orgs","repos_url":"https://api.github.com/users/craigh/repos","events_url":"https://api.github.com/users/craigh/events{/privacy}","received_events_url":"https://api.github.com/users/craigh/received_events","type":"User","site_admin":false},"body":"| Q                 | A\r\n| ----------------- | ---\r\n| Bug fix?          | no\r\n| New feature?      | yes\r\n| BC breaks?        | no\r\n| Deprecations?     | no\r\n| Fixed tickets     | -\r\n| Refs tickets      | #3025, #2235, #3012 \r\n| License           | MIT\r\n| Changelog updated | yes\r\n\r\n## Description\r\nAdd Symfony Installer's requirements check to our own installation and upgrade processes. Update and improve install and upgrade docs. Eliminate the use of system constants to indicate currently installed version and replace with permanently written parameter.\r\n","created_at":"2016-08-22T18:11:39Z","updated_at":"2016-08-24T04:49:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a276b5626a79440bae655f5427e3d8e5d595aa8e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zikula/core/milestones/20","html_url":"https://github.com/zikula/core/milestones/1.4.3","labels_url":"https://api.github.com/repos/zikula/core/milestones/20/labels","id":1572760,"number":20,"title":"1.4.3","description":"Third service release for 1.4.x series","creator":{"login":"craigh","id":350048,"avatar_url":"https://avatars.githubusercontent.com/u/350048?v=3","gravatar_id":"","url":"https://api.github.com/users/craigh","html_url":"https://github.com/craigh","followers_url":"https://api.github.com/users/craigh/followers","following_url":"https://api.github.com/users/craigh/following{/other_user}","gists_url":"https://api.github.com/users/craigh/gists{/gist_id}","starred_url":"https://api.github.com/users/craigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigh/subscriptions","organizations_url":"https://api.github.com/users/craigh/orgs","repos_url":"https://api.github.com/users/craigh/repos","events_url":"https://api.github.com/users/craigh/events{/privacy}","received_events_url":"https://api.github.com/users/craigh/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":147,"state":"open","created_at":"2016-02-09T15:30:01Z","updated_at":"2016-08-23T15:10:45Z","due_on":"2016-08-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zikula/core/pulls/3023/commits","review_comments_url":"https://api.github.com/repos/zikula/core/pulls/3023/comments","review_comment_url":"https://api.github.com/repos/zikula/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zikula/core/issues/3023/comments","statuses_url":"https://api.github.com/repos/zikula/core/statuses/a137f9cace1918d294b632a7c895b5cd9c7666c6","head":{"label":"zikula:installerChecks","ref":"installerChecks","sha":"a137f9cace1918d294b632a7c895b5cd9c7666c6","user":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=3","gravatar_id":"","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"repo":{"id":781544,"name":"core","full_name":"zikula/core","owner":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=3","gravatar_id":"","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zikula/core","description":"Zikula Core Framework","fork":false,"url":"https://api.github.com/repos/zikula/core","forks_url":"https://api.github.com/repos/zikula/core/forks","keys_url":"https://api.github.com/repos/zikula/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikula/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikula/core/teams","hooks_url":"https://api.github.com/repos/zikula/core/hooks","issue_events_url":"https://api.github.com/repos/zikula/core/issues/events{/number}","events_url":"https://api.github.com/repos/zikula/core/events","assignees_url":"https://api.github.com/repos/zikula/core/assignees{/user}","branches_url":"https://api.github.com/repos/zikula/core/branches{/branch}","tags_url":"https://api.github.com/repos/zikula/core/tags","blobs_url":"https://api.github.com/repos/zikula/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikula/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikula/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikula/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikula/core/statuses/{sha}","languages_url":"https://api.github.com/repos/zikula/core/languages","stargazers_url":"https://api.github.com/repos/zikula/core/stargazers","contributors_url":"https://api.github.com/repos/zikula/core/contributors","subscribers_url":"https://api.github.com/repos/zikula/core/subscribers","subscription_url":"https://api.github.com/repos/zikula/core/subscription","commits_url":"https://api.github.com/repos/zikula/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikula/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikula/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikula/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikula/core/contents/{+path}","compare_url":"https://api.github.com/repos/zikula/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikula/core/merges","archive_url":"https://api.github.com/repos/zikula/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikula/core/downloads","issues_url":"https://api.github.com/repos/zikula/core/issues{/number}","pulls_url":"https://api.github.com/repos/zikula/core/pulls{/number}","milestones_url":"https://api.github.com/repos/zikula/core/milestones{/number}","notifications_url":"https://api.github.com/repos/zikula/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikula/core/labels{/name}","releases_url":"https://api.github.com/repos/zikula/core/releases{/id}","deployments_url":"https://api.github.com/repos/zikula/core/deployments","created_at":"2010-07-18T10:35:53Z","updated_at":"2016-08-20T21:20:21Z","pushed_at":"2016-08-24T00:12:17Z","git_url":"git://github.com/zikula/core.git","ssh_url":"git@github.com:zikula/core.git","clone_url":"https://github.com/zikula/core.git","svn_url":"https://github.com/zikula/core","homepage":"http://zikula.org/","size":73129,"stargazers_count":178,"watchers_count":178,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":175,"forks":77,"open_issues":175,"watchers":178,"default_branch":"1.4"}},"base":{"label":"zikula:1.4","ref":"1.4","sha":"948ba641743a8442e577c01bfed7f8a63a3622f4","user":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=3","gravatar_id":"","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"repo":{"id":781544,"name":"core","full_name":"zikula/core","owner":{"login":"zikula","id":251211,"avatar_url":"https://avatars.githubusercontent.com/u/251211?v=3","gravatar_id":"","url":"https://api.github.com/users/zikula","html_url":"https://github.com/zikula","followers_url":"https://api.github.com/users/zikula/followers","following_url":"https://api.github.com/users/zikula/following{/other_user}","gists_url":"https://api.github.com/users/zikula/gists{/gist_id}","starred_url":"https://api.github.com/users/zikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikula/subscriptions","organizations_url":"https://api.github.com/users/zikula/orgs","repos_url":"https://api.github.com/users/zikula/repos","events_url":"https://api.github.com/users/zikula/events{/privacy}","received_events_url":"https://api.github.com/users/zikula/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zikula/core","description":"Zikula Core Framework","fork":false,"url":"https://api.github.com/repos/zikula/core","forks_url":"https://api.github.com/repos/zikula/core/forks","keys_url":"https://api.github.com/repos/zikula/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikula/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikula/core/teams","hooks_url":"https://api.github.com/repos/zikula/core/hooks","issue_events_url":"https://api.github.com/repos/zikula/core/issues/events{/number}","events_url":"https://api.github.com/repos/zikula/core/events","assignees_url":"https://api.github.com/repos/zikula/core/assignees{/user}","branches_url":"https://api.github.com/repos/zikula/core/branches{/branch}","tags_url":"https://api.github.com/repos/zikula/core/tags","blobs_url":"https://api.github.com/repos/zikula/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikula/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikula/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikula/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikula/core/statuses/{sha}","languages_url":"https://api.github.com/repos/zikula/core/languages","stargazers_url":"https://api.github.com/repos/zikula/core/stargazers","contributors_url":"https://api.github.com/repos/zikula/core/contributors","subscribers_url":"https://api.github.com/repos/zikula/core/subscribers","subscription_url":"https://api.github.com/repos/zikula/core/subscription","commits_url":"https://api.github.com/repos/zikula/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikula/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikula/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikula/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikula/core/contents/{+path}","compare_url":"https://api.github.com/repos/zikula/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikula/core/merges","archive_url":"https://api.github.com/repos/zikula/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikula/core/downloads","issues_url":"https://api.github.com/repos/zikula/core/issues{/number}","pulls_url":"https://api.github.com/repos/zikula/core/pulls{/number}","milestones_url":"https://api.github.com/repos/zikula/core/milestones{/number}","notifications_url":"https://api.github.com/repos/zikula/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikula/core/labels{/name}","releases_url":"https://api.github.com/repos/zikula/core/releases{/id}","deployments_url":"https://api.github.com/repos/zikula/core/deployments","created_at":"2010-07-18T10:35:53Z","updated_at":"2016-08-20T21:20:21Z","pushed_at":"2016-08-24T00:12:17Z","git_url":"git://github.com/zikula/core.git","ssh_url":"git@github.com:zikula/core.git","clone_url":"https://github.com/zikula/core.git","svn_url":"https://github.com/zikula/core","homepage":"http://zikula.org/","size":73129,"stargazers_count":178,"watchers_count":178,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":175,"forks":77,"open_issues":175,"watchers":178,"default_branch":"1.4"}},"_links":{"self":{"href":"https://api.github.com/repos/zikula/core/pulls/3023"},"html":{"href":"https://github.com/zikula/core/pull/3023"},"issue":{"href":"https://api.github.com/repos/zikula/core/issues/3023"},"comments":{"href":"https://api.github.com/repos/zikula/core/issues/3023/comments"},"review_comments":{"href":"https://api.github.com/repos/zikula/core/pulls/3023/comments"},"review_comment":{"href":"https://api.github.com/repos/zikula/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zikula/core/pulls/3023/commits"},"statuses":{"href":"https://api.github.com/repos/zikula/core/statuses/a137f9cace1918d294b632a7c895b5cd9c7666c6"}}}}
{"actor":{"display_login":"Guite"}}