{"action":"created","issue":{"url":"https://api.github.com/repos/insomnia-lab/libreant/issues/241","repository_url":"https://api.github.com/repos/insomnia-lab/libreant","labels_url":"https://api.github.com/repos/insomnia-lab/libreant/issues/241/labels{/name}","comments_url":"https://api.github.com/repos/insomnia-lab/libreant/issues/241/comments","events_url":"https://api.github.com/repos/insomnia-lab/libreant/issues/241/events","html_url":"https://github.com/insomnia-lab/libreant/pull/241","id":131506642,"number":241,"title":"misc add volume improvements","user":{"login":"boyska","id":14236,"avatar_url":"https://avatars.githubusercontent.com/u/14236?v=3","gravatar_id":"","url":"https://api.github.com/users/boyska","html_url":"https://github.com/boyska","followers_url":"https://api.github.com/users/boyska/followers","following_url":"https://api.github.com/users/boyska/following{/other_user}","gists_url":"https://api.github.com/users/boyska/gists{/gist_id}","starred_url":"https://api.github.com/users/boyska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyska/subscriptions","organizations_url":"https://api.github.com/users/boyska/orgs","repos_url":"https://api.github.com/users/boyska/repos","events_url":"https://api.github.com/users/boyska/events{/privacy}","received_events_url":"https://api.github.com/users/boyska/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/insomnia-lab/libreant/milestones/6","html_url":"https://github.com/insomnia-lab/libreant/milestones/0.4","labels_url":"https://api.github.com/repos/insomnia-lab/libreant/milestones/6/labels","id":1465334,"number":6,"title":"0.4","description":"","creator":{"login":"boyska","id":14236,"avatar_url":"https://avatars.githubusercontent.com/u/14236?v=3","gravatar_id":"","url":"https://api.github.com/users/boyska","html_url":"https://github.com/boyska","followers_url":"https://api.github.com/users/boyska/followers","following_url":"https://api.github.com/users/boyska/following{/other_user}","gists_url":"https://api.github.com/users/boyska/gists{/gist_id}","starred_url":"https://api.github.com/users/boyska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyska/subscriptions","organizations_url":"https://api.github.com/users/boyska/orgs","repos_url":"https://api.github.com/users/boyska/repos","events_url":"https://api.github.com/users/boyska/events{/privacy}","received_events_url":"https://api.github.com/users/boyska/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2015-12-17T17:27:01Z","updated_at":"2016-03-01T10:04:04Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-02-04T23:36:12Z","updated_at":"2016-03-12T21:37:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/insomnia-lab/libreant/pulls/241","html_url":"https://github.com/insomnia-lab/libreant/pull/241","diff_url":"https://github.com/insomnia-lab/libreant/pull/241.diff","patch_url":"https://github.com/insomnia-lab/libreant/pull/241.patch"},"body":"yes, this is kinda all-mixed-in so consider this a request for opinions.\r\nThe first commit is really just moving code around so to look nicer\r\nThe second commit is about validating new volumes. Yes, this is done at the webant layer, which is probably not the best thing to do. Still, it cannot be done by `archivant` alone (archivant doesn't know about presets) and we still don't have an intermediate \"controller\" layer.\r\n\r\nLast two commits add a new preset called \"bag\", which is basically a set (but \"set\" is a very ambigous word!). You may prefer to call it as a list. It has no real UI to handle lists (unless you call \"just add `;` \" an UI) but it works. I will *not* do the UI part of it until we have decided if duplicates are ok, which character is the separator, and this kind of stuff, because I would have to write more code, and because I'm lazy :) This would close #39 "},"comment":{"url":"https://api.github.com/repos/insomnia-lab/libreant/issues/comments/195811959","html_url":"https://github.com/insomnia-lab/libreant/pull/241#issuecomment-195811959","issue_url":"https://api.github.com/repos/insomnia-lab/libreant/issues/241","id":195811959,"user":{"login":"boyska","id":14236,"avatar_url":"https://avatars.githubusercontent.com/u/14236?v=3","gravatar_id":"","url":"https://api.github.com/users/boyska","html_url":"https://github.com/boyska","followers_url":"https://api.github.com/users/boyska/followers","following_url":"https://api.github.com/users/boyska/following{/other_user}","gists_url":"https://api.github.com/users/boyska/gists{/gist_id}","starred_url":"https://api.github.com/users/boyska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyska/subscriptions","organizations_url":"https://api.github.com/users/boyska/orgs","repos_url":"https://api.github.com/users/boyska/repos","events_url":"https://api.github.com/users/boyska/events{/privacy}","received_events_url":"https://api.github.com/users/boyska/received_events","type":"User","site_admin":false},"created_at":"2016-03-12T21:37:02Z","updated_at":"2016-03-12T21:37:02Z","body":"This seems to be stuck. Seems there are (too) many things in this PR, it might be better to split in several parts.\r\n@ael-code what's your opinion on the first commits up to \"webant validate volumes\" ? this would postpone the discussion about the `list` type allowing for some progress"}}