{"comment":{"url":"https://api.github.com/repos/CVC4/CVC4/comments/19703806","html_url":"https://github.com/CVC4/CVC4/commit/60cd271c46e7b250e3799f1c3b1fc20015723999#commitcomment-19703806","id":19703806,"user":{"login":"ajreynol","id":2973467,"avatar_url":"https://avatars.githubusercontent.com/u/2973467?v=3","gravatar_id":"","url":"https://api.github.com/users/ajreynol","html_url":"https://github.com/ajreynol","followers_url":"https://api.github.com/users/ajreynol/followers","following_url":"https://api.github.com/users/ajreynol/following{/other_user}","gists_url":"https://api.github.com/users/ajreynol/gists{/gist_id}","starred_url":"https://api.github.com/users/ajreynol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajreynol/subscriptions","organizations_url":"https://api.github.com/users/ajreynol/orgs","repos_url":"https://api.github.com/users/ajreynol/repos","events_url":"https://api.github.com/users/ajreynol/events{/privacy}","received_events_url":"https://api.github.com/users/ajreynol/received_events","type":"User","site_admin":false},"position":16,"line":158,"path":"src/smt/smt_engine.h","commit_id":"60cd271c46e7b250e3799f1c3b1fc20015723999","created_at":"2016-11-04T21:53:16Z","updated_at":"2016-11-04T21:53:16Z","body":"The part of the code in question stores user-context-dependent information about what recursive functions are defined.\r\n\r\nPreviously this involved storing a context-dependent Node -> NodeList* mapping. I suppose this leaked memory since individual members were not getting deleted.\r\n\r\nRegardless, my preference is to store simpler context-dependent + auxiliary context-independent data structures, hence the change.  The new code is equivalent to the old, modulo memory management.\r\n \r\n-Andy"}}
{"actor":{"display_login":"ajreynol"}}