{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/126","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/126/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/126/events","html_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/126","id":176617683,"number":126,"title":"Resolves eslint \"You should not set properties on $scope in controlle…","user":{"login":"AllenBW","id":6640236,"avatar_url":"https://avatars.githubusercontent.com/u/6640236?v=3","gravatar_id":"","url":"https://api.github.com/users/AllenBW","html_url":"https://github.com/AllenBW","followers_url":"https://api.github.com/users/AllenBW/followers","following_url":"https://api.github.com/users/AllenBW/following{/other_user}","gists_url":"https://api.github.com/users/AllenBW/gists{/gist_id}","starred_url":"https://api.github.com/users/AllenBW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllenBW/subscriptions","organizations_url":"https://api.github.com/users/AllenBW/orgs","repos_url":"https://api.github.com/users/AllenBW/repos","events_url":"https://api.github.com/users/AllenBW/events{/privacy}","received_events_url":"https://api.github.com/users/AllenBW/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"chriskacerguis","id":2414647,"avatar_url":"https://avatars.githubusercontent.com/u/2414647?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskacerguis","html_url":"https://github.com/chriskacerguis","followers_url":"https://api.github.com/users/chriskacerguis/followers","following_url":"https://api.github.com/users/chriskacerguis/following{/other_user}","gists_url":"https://api.github.com/users/chriskacerguis/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskacerguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskacerguis/subscriptions","organizations_url":"https://api.github.com/users/chriskacerguis/orgs","repos_url":"https://api.github.com/users/chriskacerguis/repos","events_url":"https://api.github.com/users/chriskacerguis/events{/privacy}","received_events_url":"https://api.github.com/users/chriskacerguis/received_events","type":"User","site_admin":false},"assignees":[{"login":"chriskacerguis","id":2414647,"avatar_url":"https://avatars.githubusercontent.com/u/2414647?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskacerguis","html_url":"https://github.com/chriskacerguis","followers_url":"https://api.github.com/users/chriskacerguis/followers","following_url":"https://api.github.com/users/chriskacerguis/following{/other_user}","gists_url":"https://api.github.com/users/chriskacerguis/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskacerguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskacerguis/subscriptions","organizations_url":"https://api.github.com/users/chriskacerguis/orgs","repos_url":"https://api.github.com/users/chriskacerguis/repos","events_url":"https://api.github.com/users/chriskacerguis/events{/privacy}","received_events_url":"https://api.github.com/users/chriskacerguis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-09-13T11:38:52Z","updated_at":"2016-09-13T16:04:02Z","closed_at":"2016-09-13T14:26:04Z","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/pulls/126","html_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/126","diff_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/126.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/126.patch"},"body":"Resolves eslint \"You should not set properties on $scope in controllers\"\r\n(pushes all things local to a component onto `vm` an alias for `this`. This keeps us from polluting scope.\r\n\r\nResolves eslint DI-IN (dependency injection) form absent from components\r\n(principally makes ssui minification hardy, but also for the curious https://en.wikipedia.org/wiki/Dependency_injection)\r\n\r\n@dtaylor113 don't hate me\r\nalso, if you get a hot sec, could you drop in on this branch and confirm I didn't make a royal mess? 🙏 🙇 :feelsgood: \r\n\r\n#121 is inched ahead just a bit farther, there are a number of eslint errors outstanding, wanted to tackle hairier ones first"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/comments/246732981","html_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/126#issuecomment-246732981","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/126","id":246732981,"user":{"login":"dtaylor113","id":12733153,"avatar_url":"https://avatars.githubusercontent.com/u/12733153?v=3","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T16:04:02Z","updated_at":"2016-09-13T16:04:02Z","body":"Hi @AllenBW & @chriskacerguis, umm...yeah, this PR royally clobbered my files.  It is going to take me a while to merge this with my latest branches  I can't even understand what happened to editorCtrls.js:  https://github.com/ManageIQ/manageiq-ui-self_service/pull/126/files#diff-14924860d0c7815b3c18fdf581826666 :sob: "}}
{"actor":{"display_login":"dtaylor113"}}