{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/3461","repository_url":"https://api.github.com/repos/Particular/NServiceBus","labels_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3461/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3461/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3461/events","html_url":"https://github.com/Particular/NServiceBus/pull/3461","id":133245469,"number":3461,"title":"No longer register Conventions on container","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Particular/NServiceBus/labels/State:%20In%20Progress","name":"State: In Progress","color":"ededed"},{"url":"https://api.github.com/repos/Particular/NServiceBus/labels/Type:%20Refactoring","name":"Type: Refactoring","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-12T13:45:52Z","updated_at":"2016-02-12T15:50:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3461","html_url":"https://github.com/Particular/NServiceBus/pull/3461","diff_url":"https://github.com/Particular/NServiceBus/pull/3461.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3461.patch"},"body":"While checking for `RegisterSingleton` usages I stumbled over the conventions. It was both registered in the settings dictionary and on the container. The core only needed it on the container for the best practices behaviors and the data bus behaviors. This PR removes `Conventions` from the container\r\n\r\n@Particular/nservicebus-maintainers please review"},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments/183382686","html_url":"https://github.com/Particular/NServiceBus/pull/3461#issuecomment-183382686","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3461","id":183382686,"user":{"login":"timbussmann","id":3524870,"avatar_url":"https://avatars.githubusercontent.com/u/3524870?v=3","gravatar_id":"","url":"https://api.github.com/users/timbussmann","html_url":"https://github.com/timbussmann","followers_url":"https://api.github.com/users/timbussmann/followers","following_url":"https://api.github.com/users/timbussmann/following{/other_user}","gists_url":"https://api.github.com/users/timbussmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timbussmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbussmann/subscriptions","organizations_url":"https://api.github.com/users/timbussmann/orgs","repos_url":"https://api.github.com/users/timbussmann/repos","events_url":"https://api.github.com/users/timbussmann/events{/privacy}","received_events_url":"https://api.github.com/users/timbussmann/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T15:50:09Z","updated_at":"2016-02-12T15:50:09Z","body":":+1: "}}