{"action":"closed","issue":{"url":"https://api.github.com/repos/mtdowling/jmespath.rs/issues/16","repository_url":"https://api.github.com/repos/mtdowling/jmespath.rs","labels_url":"https://api.github.com/repos/mtdowling/jmespath.rs/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/mtdowling/jmespath.rs/issues/16/comments","events_url":"https://api.github.com/repos/mtdowling/jmespath.rs/issues/16/events","html_url":"https://github.com/mtdowling/jmespath.rs/issues/16","id":172524360,"number":16,"title":"Problem with simple testcase","user":{"login":"silvio","id":79472,"avatar_url":"https://avatars.githubusercontent.com/u/79472?v=3","gravatar_id":"","url":"https://api.github.com/users/silvio","html_url":"https://github.com/silvio","followers_url":"https://api.github.com/users/silvio/followers","following_url":"https://api.github.com/users/silvio/following{/other_user}","gists_url":"https://api.github.com/users/silvio/gists{/gist_id}","starred_url":"https://api.github.com/users/silvio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silvio/subscriptions","organizations_url":"https://api.github.com/users/silvio/orgs","repos_url":"https://api.github.com/users/silvio/repos","events_url":"https://api.github.com/users/silvio/events{/privacy}","received_events_url":"https://api.github.com/users/silvio/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-22T18:41:45Z","updated_at":"2016-12-05T05:28:53Z","closed_at":"2016-12-05T05:28:53Z","body":"Hi,\n\nis this project still active?\nI have a wrong behaviour with the (compliance) test cases. I don't know what is going wrong, but something bad happen here.\n\nI added two test cases like this one:\n\n``` diff\ndiff --git a/tests/compliance/basic.json b/tests/compliance/basic.json\nindex d550e96..38b41db 100644\n--- a/tests/compliance/basic.json\n+++ b/tests/compliance/basic.json\n@@ -92,5 +92,20 @@\n             \"result\": \"bar\"\n          }\n     ]\n+},\n+{\n+    \"given\": {\"a\": true},\n+    \"cases\": [\n+        {\n+            \"comment\": \"simple basic test true\",\n+            \"expression\": \"a\",\n+            \"result\": true\n+        },\n+        {\n+            \"comment\": \"simple basic test false\",\n+            \"expression\": \"a\",\n+            \"result\": false\n+        }\n+    ]\n }\n ]\n```\n\nI get this result:\n\n``` plain\ntest test_basic_0_0_simple_basic_test_true ... ok\ntest test_basic_0_1_simple_basic_test_false ... ok\n```\n\nMy expectation was that one of this tests should fail. I'm wrong?\n\nSome investigation: The characteristic of the problem is that  `Assertion::assert` returns with an `Ok(())` because `r.as_string()` returns a `None`. The function `as_string()` returns only a string object if the `Variable` is a `String` typed value. (doc/src/jmespath/variable.rs.html#170-175)\n"}}
{"actor":{"display_login":"mtdowling"}}