{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/76405796","id":76405796,"diff_hunk":"@@ -0,0 +1,54 @@\n+<?php\n+/**\n+ * 2007-2016 PrestaShop.\n+ *\n+ * NOTICE OF LICENSE\n+ *\n+ * This source file is subject to the Open Software License (OSL 3.0)\n+ * that is bundled with this package in the file LICENSE.txt.\n+ * It is also available through the world-wide-web at this URL:\n+ * http://opensource.org/licenses/osl-3.0.php\n+ * If you did not receive a copy of the license and are unable to\n+ * obtain it through the world-wide-web, please send an email\n+ * to license@prestashop.com so we can send you a copy immediately.\n+ *\n+ * DISCLAIMER\n+ *\n+ * Do not edit or add to this file if you wish to upgrade PrestaShop to newer\n+ * versions in the future. If you wish to customize PrestaShop for your\n+ * needs please refer to http://www.prestashop.com for more information.\n+ *\n+ *  @author \tPrestaShop SA <contact@prestashop.com>\n+ *  @copyright  2007-2016 PrestaShop SA\n+ *  @license    http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)\n+ *  International Registered Trademark & Property of PrestaShop SA\n+ */\n+\n+namespace PrestaShopBundle\\Translation\\Provider;\n+\n+use Symfony\\Component\\Finder\\Finder;\n+use Symfony\\Component\\Translation\\Loader\\XliffFileLoader;\n+use Symfony\\Component\\Translation\\MessageCatalogue;\n+\n+trait TranslationFinderTrait","path":"src/PrestaShopBundle/Translation/Provider/TranslationFinderTrait.php","position":33,"original_position":33,"commit_id":"e98e1d19388dba1e8f225e739c0a9d73d7033e5c","original_commit_id":"e98e1d19388dba1e8f225e739c0a9d73d7033e5c","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"this is not an argument :)\r\n\r\nthe good argument is \"put it in the AbstractProvider class\", I didn't have any abstract class when I have made this trait and wanted to avoid vertical inheritance only for one \"independant\" feature :)","created_at":"2016-08-26T11:50:20Z","updated_at":"2016-08-26T11:50:20Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/6074#discussion_r76405796","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/76405796"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/6074#discussion_r76405796"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074","id":82687451,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/6074","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/6074.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/6074.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/6074","number":6074,"state":"open","locked":false,"title":"Enabled translations selector by domain","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information: -->\r\n\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | In 1.6 we could filter translation keys by domains: FO, BO, emails... I re-introduce this feature for 1.7, adapted for the new domains.\r\n| Type?         | new feature\r\n| Category?     | BO\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed ticket? | part of [http://forge.prestashop.com/browse/BOOM-1248](http://forge.prestashop.com/browse/BOOM-1248)\r\n| How to test?  | In BO translations page, select a domain: ou should access to a pre-filtered collection of translations keys.\r\n\r\n![translation_selector](https://cloud.githubusercontent.com/assets/1247388/17964051/8c2c36a6-6ab8-11e6-86c5-206922a8ac6e.png)\r\n\r\n\r\n<!-- Click the form's \"Preview button\" to make sure the table is functional in GitHub. Thank you! -->\r\n\r\n#### Important guidelines\r\n\r\n* Make sure [your local branch is up to date](https://help.github.com/articles/syncing-a-fork/) before commiting your changes!\r\n* Your code MUST respect [our Coding Standards](http://doc.prestashop.com/display/PS16/Coding+Standards) (for code written in PHP, JavaScript, HTML/CSS/Smarty/Twig, SQL)!\r\n* Your commit name MUST respect our [naming convention](http://doc.prestashop.com/display/PS16/How+to+write+a+commit+message)!\r\n\r\n","created_at":"2016-08-25T09:39:20Z","updated_at":"2016-08-26T11:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f12dbbc7104acce2c62730cb596f4226645bb241","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/6074/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/e98e1d19388dba1e8f225e739c0a9d73d7033e5c","head":{"label":"mickaelandrieu:enable-translate-by-domain","ref":"enable-translate-by-domain","sha":"e98e1d19388dba1e8f225e739c0a9d73d7033e5c","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"repo":{"id":45130346,"name":"PrestaShop","full_name":"mickaelandrieu/PrestaShop","owner":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mickaelandrieu/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/mickaelandrieu/PrestaShop","forks_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/forks","keys_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/teams","hooks_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/events","assignees_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/tags","blobs_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/subscription","commits_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/merges","archive_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/downloads","issues_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/mickaelandrieu/PrestaShop/deployments","created_at":"2015-10-28T17:34:50Z","updated_at":"2016-01-12T13:36:53Z","pushed_at":"2016-08-26T08:49:51Z","git_url":"git://github.com/mickaelandrieu/PrestaShop.git","ssh_url":"git@github.com:mickaelandrieu/PrestaShop.git","clone_url":"https://github.com/mickaelandrieu/PrestaShop.git","svn_url":"https://github.com/mickaelandrieu/PrestaShop","homepage":"http://www.prestashop.com/","size":255334,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"3243a239eafd25aa2c995933c9588c5171cdef85","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2016-08-26T10:08:02Z","pushed_at":"2016-08-26T11:36:37Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":324722,"stargazers_count":1953,"watchers_count":1953,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1973,"mirror_url":null,"open_issues_count":269,"forks":1973,"open_issues":269,"watchers":1953,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/6074"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/6074"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/6074/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/6074/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/e98e1d19388dba1e8f225e739c0a9d73d7033e5c"}}}}
{"actor":{"display_login":"mickaelandrieu"}}