{"action":"created","issue":{"url":"https://api.github.com/repos/tyarkoni/coda/issues/1","repository_url":"https://api.github.com/repos/tyarkoni/coda","labels_url":"https://api.github.com/repos/tyarkoni/coda/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/tyarkoni/coda/issues/1/comments","events_url":"https://api.github.com/repos/tyarkoni/coda/issues/1/events","html_url":"https://github.com/tyarkoni/coda/issues/1","id":191129937,"number":1,"title":"Add BIDS support in FileReader","user":{"login":"tyarkoni","id":303932,"avatar_url":"https://avatars.githubusercontent.com/u/303932?v=3","gravatar_id":"","url":"https://api.github.com/users/tyarkoni","html_url":"https://github.com/tyarkoni","followers_url":"https://api.github.com/users/tyarkoni/followers","following_url":"https://api.github.com/users/tyarkoni/following{/other_user}","gists_url":"https://api.github.com/users/tyarkoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tyarkoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyarkoni/subscriptions","organizations_url":"https://api.github.com/users/tyarkoni/orgs","repos_url":"https://api.github.com/users/tyarkoni/repos","events_url":"https://api.github.com/users/tyarkoni/events{/privacy}","received_events_url":"https://api.github.com/users/tyarkoni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"adelavega","id":2774448,"avatar_url":"https://avatars.githubusercontent.com/u/2774448?v=3","gravatar_id":"","url":"https://api.github.com/users/adelavega","html_url":"https://github.com/adelavega","followers_url":"https://api.github.com/users/adelavega/followers","following_url":"https://api.github.com/users/adelavega/following{/other_user}","gists_url":"https://api.github.com/users/adelavega/gists{/gist_id}","starred_url":"https://api.github.com/users/adelavega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelavega/subscriptions","organizations_url":"https://api.github.com/users/adelavega/orgs","repos_url":"https://api.github.com/users/adelavega/repos","events_url":"https://api.github.com/users/adelavega/events{/privacy}","received_events_url":"https://api.github.com/users/adelavega/received_events","type":"User","site_admin":false},"assignees":[{"login":"adelavega","id":2774448,"avatar_url":"https://avatars.githubusercontent.com/u/2774448?v=3","gravatar_id":"","url":"https://api.github.com/users/adelavega","html_url":"https://github.com/adelavega","followers_url":"https://api.github.com/users/adelavega/followers","following_url":"https://api.github.com/users/adelavega/following{/other_user}","gists_url":"https://api.github.com/users/adelavega/gists{/gist_id}","starred_url":"https://api.github.com/users/adelavega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelavega/subscriptions","organizations_url":"https://api.github.com/users/adelavega/orgs","repos_url":"https://api.github.com/users/adelavega/repos","events_url":"https://api.github.com/users/adelavega/events{/privacy}","received_events_url":"https://api.github.com/users/adelavega/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-22T21:33:25Z","updated_at":"2016-11-30T23:50:11Z","closed_at":null,"body":"Look for and handle events.tsv."},"comment":{"url":"https://api.github.com/repos/tyarkoni/coda/issues/comments/264034332","html_url":"https://github.com/tyarkoni/coda/issues/1#issuecomment-264034332","issue_url":"https://api.github.com/repos/tyarkoni/coda/issues/1","id":264034332,"user":{"login":"tyarkoni","id":303932,"avatar_url":"https://avatars.githubusercontent.com/u/303932?v=3","gravatar_id":"","url":"https://api.github.com/users/tyarkoni","html_url":"https://github.com/tyarkoni","followers_url":"https://api.github.com/users/tyarkoni/followers","following_url":"https://api.github.com/users/tyarkoni/following{/other_user}","gists_url":"https://api.github.com/users/tyarkoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tyarkoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyarkoni/subscriptions","organizations_url":"https://api.github.com/users/tyarkoni/orgs","repos_url":"https://api.github.com/users/tyarkoni/repos","events_url":"https://api.github.com/users/tyarkoni/events{/privacy}","received_events_url":"https://api.github.com/users/tyarkoni/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T23:50:11Z","updated_at":"2016-11-30T23:50:11Z","body":"Good point. I think we want to (a) emphasize ease of use above code simplicity in this case, and (b) stick to the BIDS spec as closely as possible and not force our own extension on it. So I think we want to implement both approaches you mention, and the logic should be to first check if a `trial_type` column is present (case 1), and if not, then assume that each column is a separate condition (case 2). The default `condition_column` value should probably be set to `trial_type` (and if the passed value is missing from events.tsv, then it gets interpreted like `None`).\r\n\r\nThat also allows us to change the `amplitude_column` handling to allow a value of `None` (which should be the default). The logic for this column becomes as follows:\r\n\r\n1. If `amplitude_column` is set to a value other than `None`, all amplitudes are read from that column.\r\n2. If `amplitude_column` is `None` and `trial_type` is present, all amplitudes are set to 1.\r\n3. If `amplitude_column` is `None` and `trial_type` is None, all extra columns are recoded as new conditions, where the name of the condition is each column name, and the values are the amplitudes.\r\n\r\nI think the above makes it very easy for a user to exert near-total control over how the file is read, while still maintaining sane defaults that will, in probably > 95% of cases, require no explicit changing of the default flags."}}
{"actor":{"display_login":"tyarkoni"}}