{"action":"created","comment":{"url":"https://api.github.com/repos/larsga/Duke/pulls/comments/71989127","id":71989127,"diff_hunk":"@@ -0,0 +1,72 @@\n+\n+package no.priv.garshol.duke.cleaners;\n+\n+import no.priv.garshol.duke.Cleaner;\n+\n+import java.io.*;\n+import java.util.List;\n+import java.util.ArrayList;\n+\n+/**\n+ * A cleaner which removes english stopwords from a string.\n+ */\n+\n+public class StopwordsCleaner implements Cleaner {\n+    private LowerCaseNormalizeCleaner sub;\n+    private String[] stopwords;","path":"duke-core/src/main/java/no/priv/garshol/duke/cleaners/StopwordsCleaner.java","position":16,"original_position":16,"commit_id":"f1a78b2eb0038cb2d1d7b2c6734ddf6022cce5bb","original_commit_id":"f1a78b2eb0038cb2d1d7b2c6734ddf6022cce5bb","user":{"login":"larsga","id":446984,"avatar_url":"https://avatars.githubusercontent.com/u/446984?v=3","gravatar_id":"","url":"https://api.github.com/users/larsga","html_url":"https://github.com/larsga","followers_url":"https://api.github.com/users/larsga/followers","following_url":"https://api.github.com/users/larsga/following{/other_user}","gists_url":"https://api.github.com/users/larsga/gists{/gist_id}","starred_url":"https://api.github.com/users/larsga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsga/subscriptions","organizations_url":"https://api.github.com/users/larsga/orgs","repos_url":"https://api.github.com/users/larsga/repos","events_url":"https://api.github.com/users/larsga/events{/privacy}","received_events_url":"https://api.github.com/users/larsga/received_events","type":"User","site_admin":false},"body":"Searching this array for stop words is very inefficient. Please use a HashSet instead. That will be much faster and also easier to use.","created_at":"2016-07-24T14:04:25Z","updated_at":"2016-07-24T14:04:25Z","html_url":"https://github.com/larsga/Duke/pull/228#discussion_r71989127","pull_request_url":"https://api.github.com/repos/larsga/Duke/pulls/228","_links":{"self":{"href":"https://api.github.com/repos/larsga/Duke/pulls/comments/71989127"},"html":{"href":"https://github.com/larsga/Duke/pull/228#discussion_r71989127"},"pull_request":{"href":"https://api.github.com/repos/larsga/Duke/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/larsga/Duke/pulls/228","id":78536014,"html_url":"https://github.com/larsga/Duke/pull/228","diff_url":"https://github.com/larsga/Duke/pull/228.diff","patch_url":"https://github.com/larsga/Duke/pull/228.patch","issue_url":"https://api.github.com/repos/larsga/Duke/issues/228","number":228,"state":"open","locked":false,"title":"added stopwords cleaner with tests","user":{"login":"shivam5992","id":4301965,"avatar_url":"https://avatars.githubusercontent.com/u/4301965?v=3","gravatar_id":"","url":"https://api.github.com/users/shivam5992","html_url":"https://github.com/shivam5992","followers_url":"https://api.github.com/users/shivam5992/followers","following_url":"https://api.github.com/users/shivam5992/following{/other_user}","gists_url":"https://api.github.com/users/shivam5992/gists{/gist_id}","starred_url":"https://api.github.com/users/shivam5992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivam5992/subscriptions","organizations_url":"https://api.github.com/users/shivam5992/orgs","repos_url":"https://api.github.com/users/shivam5992/repos","events_url":"https://api.github.com/users/shivam5992/events{/privacy}","received_events_url":"https://api.github.com/users/shivam5992/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-22T20:33:26Z","updated_at":"2016-07-24T14:04:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b014404012743169094c44c9b8e59c4bcf448a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/larsga/Duke/pulls/228/commits","review_comments_url":"https://api.github.com/repos/larsga/Duke/pulls/228/comments","review_comment_url":"https://api.github.com/repos/larsga/Duke/pulls/comments{/number}","comments_url":"https://api.github.com/repos/larsga/Duke/issues/228/comments","statuses_url":"https://api.github.com/repos/larsga/Duke/statuses/f1a78b2eb0038cb2d1d7b2c6734ddf6022cce5bb","head":{"label":"shivam5992:master","ref":"master","sha":"f1a78b2eb0038cb2d1d7b2c6734ddf6022cce5bb","user":{"login":"shivam5992","id":4301965,"avatar_url":"https://avatars.githubusercontent.com/u/4301965?v=3","gravatar_id":"","url":"https://api.github.com/users/shivam5992","html_url":"https://github.com/shivam5992","followers_url":"https://api.github.com/users/shivam5992/followers","following_url":"https://api.github.com/users/shivam5992/following{/other_user}","gists_url":"https://api.github.com/users/shivam5992/gists{/gist_id}","starred_url":"https://api.github.com/users/shivam5992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivam5992/subscriptions","organizations_url":"https://api.github.com/users/shivam5992/orgs","repos_url":"https://api.github.com/users/shivam5992/repos","events_url":"https://api.github.com/users/shivam5992/events{/privacy}","received_events_url":"https://api.github.com/users/shivam5992/received_events","type":"User","site_admin":false},"repo":{"id":63981456,"name":"Duke","full_name":"shivam5992/Duke","owner":{"login":"shivam5992","id":4301965,"avatar_url":"https://avatars.githubusercontent.com/u/4301965?v=3","gravatar_id":"","url":"https://api.github.com/users/shivam5992","html_url":"https://github.com/shivam5992","followers_url":"https://api.github.com/users/shivam5992/followers","following_url":"https://api.github.com/users/shivam5992/following{/other_user}","gists_url":"https://api.github.com/users/shivam5992/gists{/gist_id}","starred_url":"https://api.github.com/users/shivam5992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivam5992/subscriptions","organizations_url":"https://api.github.com/users/shivam5992/orgs","repos_url":"https://api.github.com/users/shivam5992/repos","events_url":"https://api.github.com/users/shivam5992/events{/privacy}","received_events_url":"https://api.github.com/users/shivam5992/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shivam5992/Duke","description":"Duke is a fast and flexible deduplication engine written in Java","fork":true,"url":"https://api.github.com/repos/shivam5992/Duke","forks_url":"https://api.github.com/repos/shivam5992/Duke/forks","keys_url":"https://api.github.com/repos/shivam5992/Duke/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivam5992/Duke/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivam5992/Duke/teams","hooks_url":"https://api.github.com/repos/shivam5992/Duke/hooks","issue_events_url":"https://api.github.com/repos/shivam5992/Duke/issues/events{/number}","events_url":"https://api.github.com/repos/shivam5992/Duke/events","assignees_url":"https://api.github.com/repos/shivam5992/Duke/assignees{/user}","branches_url":"https://api.github.com/repos/shivam5992/Duke/branches{/branch}","tags_url":"https://api.github.com/repos/shivam5992/Duke/tags","blobs_url":"https://api.github.com/repos/shivam5992/Duke/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivam5992/Duke/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivam5992/Duke/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivam5992/Duke/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivam5992/Duke/statuses/{sha}","languages_url":"https://api.github.com/repos/shivam5992/Duke/languages","stargazers_url":"https://api.github.com/repos/shivam5992/Duke/stargazers","contributors_url":"https://api.github.com/repos/shivam5992/Duke/contributors","subscribers_url":"https://api.github.com/repos/shivam5992/Duke/subscribers","subscription_url":"https://api.github.com/repos/shivam5992/Duke/subscription","commits_url":"https://api.github.com/repos/shivam5992/Duke/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivam5992/Duke/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivam5992/Duke/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivam5992/Duke/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivam5992/Duke/contents/{+path}","compare_url":"https://api.github.com/repos/shivam5992/Duke/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivam5992/Duke/merges","archive_url":"https://api.github.com/repos/shivam5992/Duke/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivam5992/Duke/downloads","issues_url":"https://api.github.com/repos/shivam5992/Duke/issues{/number}","pulls_url":"https://api.github.com/repos/shivam5992/Duke/pulls{/number}","milestones_url":"https://api.github.com/repos/shivam5992/Duke/milestones{/number}","notifications_url":"https://api.github.com/repos/shivam5992/Duke/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivam5992/Duke/labels{/name}","releases_url":"https://api.github.com/repos/shivam5992/Duke/releases{/id}","deployments_url":"https://api.github.com/repos/shivam5992/Duke/deployments","created_at":"2016-07-22T20:31:40Z","updated_at":"2016-07-22T20:31:42Z","pushed_at":"2016-07-22T20:33:01Z","git_url":"git://github.com/shivam5992/Duke.git","ssh_url":"git@github.com:shivam5992/Duke.git","clone_url":"https://github.com/shivam5992/Duke.git","svn_url":"https://github.com/shivam5992/Duke","homepage":null,"size":3544,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"larsga:master","ref":"master","sha":"dda63901a144a624ed7d68e3a17cc9403d77a70e","user":{"login":"larsga","id":446984,"avatar_url":"https://avatars.githubusercontent.com/u/446984?v=3","gravatar_id":"","url":"https://api.github.com/users/larsga","html_url":"https://github.com/larsga","followers_url":"https://api.github.com/users/larsga/followers","following_url":"https://api.github.com/users/larsga/following{/other_user}","gists_url":"https://api.github.com/users/larsga/gists{/gist_id}","starred_url":"https://api.github.com/users/larsga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsga/subscriptions","organizations_url":"https://api.github.com/users/larsga/orgs","repos_url":"https://api.github.com/users/larsga/repos","events_url":"https://api.github.com/users/larsga/events{/privacy}","received_events_url":"https://api.github.com/users/larsga/received_events","type":"User","site_admin":false},"repo":{"id":16458851,"name":"Duke","full_name":"larsga/Duke","owner":{"login":"larsga","id":446984,"avatar_url":"https://avatars.githubusercontent.com/u/446984?v=3","gravatar_id":"","url":"https://api.github.com/users/larsga","html_url":"https://github.com/larsga","followers_url":"https://api.github.com/users/larsga/followers","following_url":"https://api.github.com/users/larsga/following{/other_user}","gists_url":"https://api.github.com/users/larsga/gists{/gist_id}","starred_url":"https://api.github.com/users/larsga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsga/subscriptions","organizations_url":"https://api.github.com/users/larsga/orgs","repos_url":"https://api.github.com/users/larsga/repos","events_url":"https://api.github.com/users/larsga/events{/privacy}","received_events_url":"https://api.github.com/users/larsga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larsga/Duke","description":"Duke is a fast and flexible deduplication engine written in Java","fork":false,"url":"https://api.github.com/repos/larsga/Duke","forks_url":"https://api.github.com/repos/larsga/Duke/forks","keys_url":"https://api.github.com/repos/larsga/Duke/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsga/Duke/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsga/Duke/teams","hooks_url":"https://api.github.com/repos/larsga/Duke/hooks","issue_events_url":"https://api.github.com/repos/larsga/Duke/issues/events{/number}","events_url":"https://api.github.com/repos/larsga/Duke/events","assignees_url":"https://api.github.com/repos/larsga/Duke/assignees{/user}","branches_url":"https://api.github.com/repos/larsga/Duke/branches{/branch}","tags_url":"https://api.github.com/repos/larsga/Duke/tags","blobs_url":"https://api.github.com/repos/larsga/Duke/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsga/Duke/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsga/Duke/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsga/Duke/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsga/Duke/statuses/{sha}","languages_url":"https://api.github.com/repos/larsga/Duke/languages","stargazers_url":"https://api.github.com/repos/larsga/Duke/stargazers","contributors_url":"https://api.github.com/repos/larsga/Duke/contributors","subscribers_url":"https://api.github.com/repos/larsga/Duke/subscribers","subscription_url":"https://api.github.com/repos/larsga/Duke/subscription","commits_url":"https://api.github.com/repos/larsga/Duke/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsga/Duke/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsga/Duke/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsga/Duke/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsga/Duke/contents/{+path}","compare_url":"https://api.github.com/repos/larsga/Duke/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsga/Duke/merges","archive_url":"https://api.github.com/repos/larsga/Duke/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsga/Duke/downloads","issues_url":"https://api.github.com/repos/larsga/Duke/issues{/number}","pulls_url":"https://api.github.com/repos/larsga/Duke/pulls{/number}","milestones_url":"https://api.github.com/repos/larsga/Duke/milestones{/number}","notifications_url":"https://api.github.com/repos/larsga/Duke/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsga/Duke/labels{/name}","releases_url":"https://api.github.com/repos/larsga/Duke/releases{/id}","deployments_url":"https://api.github.com/repos/larsga/Duke/deployments","created_at":"2014-02-02T17:17:38Z","updated_at":"2016-07-22T06:07:23Z","pushed_at":"2016-07-22T20:33:27Z","git_url":"git://github.com/larsga/Duke.git","ssh_url":"git@github.com:larsga/Duke.git","clone_url":"https://github.com/larsga/Duke.git","svn_url":"https://github.com/larsga/Duke","homepage":null,"size":3907,"stargazers_count":340,"watchers_count":340,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":83,"forks":121,"open_issues":83,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/larsga/Duke/pulls/228"},"html":{"href":"https://github.com/larsga/Duke/pull/228"},"issue":{"href":"https://api.github.com/repos/larsga/Duke/issues/228"},"comments":{"href":"https://api.github.com/repos/larsga/Duke/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/larsga/Duke/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/larsga/Duke/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/larsga/Duke/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/larsga/Duke/statuses/f1a78b2eb0038cb2d1d7b2c6734ddf6022cce5bb"}}}}
{"actor":{"display_login":"larsga"}}