{"action":"created","issue":{"url":"https://api.github.com/repos/noelboss/featherlight/issues/259","repository_url":"https://api.github.com/repos/noelboss/featherlight","labels_url":"https://api.github.com/repos/noelboss/featherlight/issues/259/labels{/name}","comments_url":"https://api.github.com/repos/noelboss/featherlight/issues/259/comments","events_url":"https://api.github.com/repos/noelboss/featherlight/issues/259/events","html_url":"https://github.com/noelboss/featherlight/issues/259","id":187201115,"number":259,"title":"Better focus management for a11y","user":{"login":"mrwweb","id":1238696,"avatar_url":"https://avatars.githubusercontent.com/u/1238696?v=3","gravatar_id":"","url":"https://api.github.com/users/mrwweb","html_url":"https://github.com/mrwweb","followers_url":"https://api.github.com/users/mrwweb/followers","following_url":"https://api.github.com/users/mrwweb/following{/other_user}","gists_url":"https://api.github.com/users/mrwweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrwweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrwweb/subscriptions","organizations_url":"https://api.github.com/users/mrwweb/orgs","repos_url":"https://api.github.com/users/mrwweb/repos","events_url":"https://api.github.com/users/mrwweb/events{/privacy}","received_events_url":"https://api.github.com/users/mrwweb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-03T21:55:35Z","updated_at":"2016-11-16T20:36:05Z","closed_at":"2016-11-16T20:36:05Z","body":"What kind of issue is this? (put 'x' between the square brackets)\r\n\r\n - [X ] Bug report. If you’ve found a bug, you must provide a minimal example in a CodePen,\r\n       starting from http://jsfiddle.net/JNsu6/15/ .\r\n\r\n - [X ] Feature Request. Make sure there's no good way to do what you want first;\r\n       consider asking on http://stackoverflow.com/questions/ask first.\r\n\r\nThis is half-feature-request-half-bug since bad focus management is _really_ bad for accessibility. As detailed in \"[Learning to focus()](https://www.sitepoint.com/learning-to-focus/)\", when users toggle open the lightbox, the keyboard focus should be shifted to/inside the modal. Just as importantly, focus should be _returned_ to the element that triggered the lightbox when it's closed.\r\n\r\nYes, this could be implemented with custom functions and the available events provided by featherlight (as in #151), but there's no reason why it shouldn't be baked in. I could even imagine a shiftFocusTo argument with a select for specifying the best element in the lightbox to receive focus (form field, close button, etc.)\r\n\r\nSee also: \"[Managing focus for modal dialogs](https://www.w3.org/WAI/GL/wiki/Managing_focus_for_modal_dialogs)\""},"comment":{"url":"https://api.github.com/repos/noelboss/featherlight/issues/comments/261064019","html_url":"https://github.com/noelboss/featherlight/issues/259#issuecomment-261064019","issue_url":"https://api.github.com/repos/noelboss/featherlight/issues/259","id":261064019,"user":{"login":"marcandre","id":33770,"avatar_url":"https://avatars.githubusercontent.com/u/33770?v=3","gravatar_id":"","url":"https://api.github.com/users/marcandre","html_url":"https://github.com/marcandre","followers_url":"https://api.github.com/users/marcandre/followers","following_url":"https://api.github.com/users/marcandre/following{/other_user}","gists_url":"https://api.github.com/users/marcandre/gists{/gist_id}","starred_url":"https://api.github.com/users/marcandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcandre/subscriptions","organizations_url":"https://api.github.com/users/marcandre/orgs","repos_url":"https://api.github.com/users/marcandre/repos","events_url":"https://api.github.com/users/marcandre/events{/privacy}","received_events_url":"https://api.github.com/users/marcandre/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T20:36:05Z","updated_at":"2016-11-16T20:36:05Z","body":"Cool. Published `1.6.0`"}}
{"actor":{"display_login":"marcandre"}}