{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/82346077","pull_request_review_id":3260595,"id":82346077,"diff_hunk":"@@ -173,6 +173,10 @@ def _guess_measurement_info(self):\n                     this_info['kind'] = FIFF.FIFFV_MISC_CH\n                 elif ch.startswith('SYS'):\n                     this_info['kind'] = FIFF.FIFFV_SYST_CH\n+                else:\n+                    # unknown channel type, do not include\n+                    warn('Unknown channel type in FieldTrip header: %s' % ch)","path":"mne/realtime/fieldtrip_client.py","position":6,"original_position":6,"commit_id":"c8b437507821557d221e0db6cf9c3a627a4dcc48","original_commit_id":"c8b437507821557d221e0db6cf9c3a627a4dcc48","user":{"login":"jasmainak","id":15852194,"avatar_url":"https://avatars.githubusercontent.com/u/15852194?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmainak","html_url":"https://github.com/jasmainak","followers_url":"https://api.github.com/users/jasmainak/followers","following_url":"https://api.github.com/users/jasmainak/following{/other_user}","gists_url":"https://api.github.com/users/jasmainak/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmainak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmainak/subscriptions","organizations_url":"https://api.github.com/users/jasmainak/orgs","repos_url":"https://api.github.com/users/jasmainak/repos","events_url":"https://api.github.com/users/jasmainak/events{/privacy}","received_events_url":"https://api.github.com/users/jasmainak/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2016-10-07T08:15:53Z","updated_at":"2016-10-07T08:15:53Z","html_url":"https://github.com/mne-tools/mne-python/pull/3646#discussion_r82346077","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/82346077"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3646#discussion_r82346077"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646","id":88275159,"html_url":"https://github.com/mne-tools/mne-python/pull/3646","diff_url":"https://github.com/mne-tools/mne-python/pull/3646.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3646.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3646","number":3646,"state":"open","locked":false,"title":"skip updating meas info on unknown channel type","user":{"login":"jjnurminen","id":8491321,"avatar_url":"https://avatars.githubusercontent.com/u/8491321?v=3","gravatar_id":"","url":"https://api.github.com/users/jjnurminen","html_url":"https://github.com/jjnurminen","followers_url":"https://api.github.com/users/jjnurminen/followers","following_url":"https://api.github.com/users/jjnurminen/following{/other_user}","gists_url":"https://api.github.com/users/jjnurminen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjnurminen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjnurminen/subscriptions","organizations_url":"https://api.github.com/users/jjnurminen/orgs","repos_url":"https://api.github.com/users/jjnurminen/repos","events_url":"https://api.github.com/users/jjnurminen/events{/privacy}","received_events_url":"https://api.github.com/users/jjnurminen/received_events","type":"User","site_admin":false},"body":"I was testing the realtime client and got an error from `_guess_measurement_info` when it could not parse CHPI* channels that were sent (from a file) to the FieldTrip buffer. (The code does not write the 'kind' field for unknown channel types). I already had the same problem with TRIUX sys channels.\r\n\r\nI propose this small fix that would simply skip updating `info['chs']` if it cannot comprehend the channel type. That should make it more future proof.\r\n\r\n\r\n","created_at":"2016-10-06T14:40:11Z","updated_at":"2016-10-07T08:15:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b26d9d1678492adc40f17a935516ed7437f6f5a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3646/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/c8b437507821557d221e0db6cf9c3a627a4dcc48","head":{"label":"jjnurminen:realtime_chtype_fix","ref":"realtime_chtype_fix","sha":"c8b437507821557d221e0db6cf9c3a627a4dcc48","user":{"login":"jjnurminen","id":8491321,"avatar_url":"https://avatars.githubusercontent.com/u/8491321?v=3","gravatar_id":"","url":"https://api.github.com/users/jjnurminen","html_url":"https://github.com/jjnurminen","followers_url":"https://api.github.com/users/jjnurminen/followers","following_url":"https://api.github.com/users/jjnurminen/following{/other_user}","gists_url":"https://api.github.com/users/jjnurminen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjnurminen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjnurminen/subscriptions","organizations_url":"https://api.github.com/users/jjnurminen/orgs","repos_url":"https://api.github.com/users/jjnurminen/repos","events_url":"https://api.github.com/users/jjnurminen/events{/privacy}","received_events_url":"https://api.github.com/users/jjnurminen/received_events","type":"User","site_admin":false},"repo":{"id":55834470,"name":"mne-python","full_name":"jjnurminen/mne-python","owner":{"login":"jjnurminen","id":8491321,"avatar_url":"https://avatars.githubusercontent.com/u/8491321?v=3","gravatar_id":"","url":"https://api.github.com/users/jjnurminen","html_url":"https://github.com/jjnurminen","followers_url":"https://api.github.com/users/jjnurminen/followers","following_url":"https://api.github.com/users/jjnurminen/following{/other_user}","gists_url":"https://api.github.com/users/jjnurminen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjnurminen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjnurminen/subscriptions","organizations_url":"https://api.github.com/users/jjnurminen/orgs","repos_url":"https://api.github.com/users/jjnurminen/repos","events_url":"https://api.github.com/users/jjnurminen/events{/privacy}","received_events_url":"https://api.github.com/users/jjnurminen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjnurminen/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/jjnurminen/mne-python","forks_url":"https://api.github.com/repos/jjnurminen/mne-python/forks","keys_url":"https://api.github.com/repos/jjnurminen/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjnurminen/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjnurminen/mne-python/teams","hooks_url":"https://api.github.com/repos/jjnurminen/mne-python/hooks","issue_events_url":"https://api.github.com/repos/jjnurminen/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/jjnurminen/mne-python/events","assignees_url":"https://api.github.com/repos/jjnurminen/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/jjnurminen/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/jjnurminen/mne-python/tags","blobs_url":"https://api.github.com/repos/jjnurminen/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjnurminen/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjnurminen/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjnurminen/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjnurminen/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jjnurminen/mne-python/languages","stargazers_url":"https://api.github.com/repos/jjnurminen/mne-python/stargazers","contributors_url":"https://api.github.com/repos/jjnurminen/mne-python/contributors","subscribers_url":"https://api.github.com/repos/jjnurminen/mne-python/subscribers","subscription_url":"https://api.github.com/repos/jjnurminen/mne-python/subscription","commits_url":"https://api.github.com/repos/jjnurminen/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjnurminen/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjnurminen/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjnurminen/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjnurminen/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/jjnurminen/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjnurminen/mne-python/merges","archive_url":"https://api.github.com/repos/jjnurminen/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjnurminen/mne-python/downloads","issues_url":"https://api.github.com/repos/jjnurminen/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/jjnurminen/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jjnurminen/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jjnurminen/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjnurminen/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/jjnurminen/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/jjnurminen/mne-python/deployments","created_at":"2016-04-09T08:48:30Z","updated_at":"2016-04-09T08:48:34Z","pushed_at":"2016-10-06T14:43:36Z","git_url":"git://github.com/jjnurminen/mne-python.git","ssh_url":"git@github.com:jjnurminen/mne-python.git","clone_url":"https://github.com/jjnurminen/mne-python.git","svn_url":"https://github.com/jjnurminen/mne-python","homepage":"http://martinos.org/mne/","size":89261,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"4b6a1744e8be9e8ff6e1e238953f5b6667062673","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-10-04T12:07:01Z","pushed_at":"2016-10-07T07:15:42Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":181778,"stargazers_count":233,"watchers_count":233,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":207,"forks":220,"open_issues":207,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3646"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3646"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3646/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3646/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/c8b437507821557d221e0db6cf9c3a627a4dcc48"}}}}
{"actor":{"display_login":"jasmainak"}}