{"action":"created","issue":{"url":"https://api.github.com/repos/patchthecode/JTAppleCalendar/issues/250","repository_url":"https://api.github.com/repos/patchthecode/JTAppleCalendar","labels_url":"https://api.github.com/repos/patchthecode/JTAppleCalendar/issues/250/labels{/name}","comments_url":"https://api.github.com/repos/patchthecode/JTAppleCalendar/issues/250/comments","events_url":"https://api.github.com/repos/patchthecode/JTAppleCalendar/issues/250/events","html_url":"https://github.com/patchthecode/JTAppleCalendar/issues/250","id":198239706,"number":250,"title":"Need sanity check for config","user":{"login":"squarefrog","id":343450,"avatar_url":"https://avatars.githubusercontent.com/u/343450?v=3","gravatar_id":"","url":"https://api.github.com/users/squarefrog","html_url":"https://github.com/squarefrog","followers_url":"https://api.github.com/users/squarefrog/followers","following_url":"https://api.github.com/users/squarefrog/following{/other_user}","gists_url":"https://api.github.com/users/squarefrog/gists{/gist_id}","starred_url":"https://api.github.com/users/squarefrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squarefrog/subscriptions","organizations_url":"https://api.github.com/users/squarefrog/orgs","repos_url":"https://api.github.com/users/squarefrog/repos","events_url":"https://api.github.com/users/squarefrog/events{/privacy}","received_events_url":"https://api.github.com/users/squarefrog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-31T17:06:16Z","updated_at":"2017-01-01T00:15:59Z","closed_at":null,"body":"I've just spent a couple of hours trying to figure out why my project crashes when I load the calendar. It worked fine up until today (first clue there...).\r\n\r\nIt turns out I was trying to set `endDate` to something before `startDate`. In my case, this would only happen on the last day of the month, although it was very tricky to debug as the exception is raised far away from where you'd expect it to fail.\r\n\r\nI propose a safer solution would be to add an `assert` that `endDate > startDate` at some point once ConfigurationParameters is set."},"comment":{"url":"https://api.github.com/repos/patchthecode/JTAppleCalendar/issues/comments/269887013","html_url":"https://github.com/patchthecode/JTAppleCalendar/issues/250#issuecomment-269887013","issue_url":"https://api.github.com/repos/patchthecode/JTAppleCalendar/issues/250","id":269887013,"user":{"login":"squarefrog","id":343450,"avatar_url":"https://avatars.githubusercontent.com/u/343450?v=3","gravatar_id":"","url":"https://api.github.com/users/squarefrog","html_url":"https://github.com/squarefrog","followers_url":"https://api.github.com/users/squarefrog/followers","following_url":"https://api.github.com/users/squarefrog/following{/other_user}","gists_url":"https://api.github.com/users/squarefrog/gists{/gist_id}","starred_url":"https://api.github.com/users/squarefrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squarefrog/subscriptions","organizations_url":"https://api.github.com/users/squarefrog/orgs","repos_url":"https://api.github.com/users/squarefrog/repos","events_url":"https://api.github.com/users/squarefrog/events{/privacy}","received_events_url":"https://api.github.com/users/squarefrog/received_events","type":"User","site_admin":false},"created_at":"2017-01-01T00:15:59Z","updated_at":"2017-01-01T00:15:59Z","body":"That's correct! So the issue is my code for sure, but because it took me so long to figure out, whereas an assert should have picked it up. \r\n\r\nI previously set the `endDate` to the start of the day of the last day of the month. Of course this failed today when I had the `startDate` as this afternoon. \r\n\r\nSo a good test case would be `startDate == \"2016-12-31 12:34:56\"` and `endDate == \"2016-12-31 00:00:00`. \r\n\r\nI'm happy to do some testing tomorrow once the hangover wares off! Happy new year! :tada:"}}
{"actor":{"display_login":"squarefrog"}}