{"action":"created","issue":{"url":"https://api.github.com/repos/ReactTraining/react-router/issues/4247","repository_url":"https://api.github.com/repos/ReactTraining/react-router","labels_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4247/labels{/name}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4247/comments","events_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4247/events","html_url":"https://github.com/ReactTraining/react-router/pull/4247","id":193441499,"number":4247,"title":"Fix Link component conflicting with Angular router","user":{"login":"kujma10","id":2605976,"avatar_url":"https://avatars.githubusercontent.com/u/2605976?v=3","gravatar_id":"","url":"https://api.github.com/users/kujma10","html_url":"https://github.com/kujma10","followers_url":"https://api.github.com/users/kujma10/followers","following_url":"https://api.github.com/users/kujma10/following{/other_user}","gists_url":"https://api.github.com/users/kujma10/gists{/gist_id}","starred_url":"https://api.github.com/users/kujma10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kujma10/subscriptions","organizations_url":"https://api.github.com/users/kujma10/orgs","repos_url":"https://api.github.com/users/kujma10/repos","events_url":"https://api.github.com/users/kujma10/events{/privacy}","received_events_url":"https://api.github.com/users/kujma10/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-05T08:53:57Z","updated_at":"2016-12-08T14:36:23Z","closed_at":"2016-12-05T17:29:09Z","pull_request":{"url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4247","html_url":"https://github.com/ReactTraining/react-router/pull/4247","diff_url":"https://github.com/ReactTraining/react-router/pull/4247.diff","patch_url":"https://github.com/ReactTraining/react-router/pull/4247.patch"},"body":"This allows to create `<a>` tag without an href property.\r\nThe necessity of `noHref` property comes from the fact that angular router is in conflict with react-router's Link component. To be more precise, Angular is [listening to all click events](https://github.com/angular/angular/blob/cf269d9ff43b913dbac4ba0ed6932c708ae58512/modules/angular1_router/src/ng_route_shim.js#L285) and if the click is on an <a> tag with an href that it [recognizes as one of its routes](https://github.com/angular/angular/blob/cf269d9ff43b913dbac4ba0ed6932c708ae58512/modules/angular1_router/src/ng_route_shim.js#L294) and it calls preventDefault() on the event. The Link implementation [checks for default being prevented](https://github.com/ReactTraining/react-router/blob/master/modules/Link.js#L78) and does nothing if it has."},"comment":{"url":"https://api.github.com/repos/ReactTraining/react-router/issues/comments/265754377","html_url":"https://github.com/ReactTraining/react-router/pull/4247#issuecomment-265754377","issue_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4247","id":265754377,"user":{"login":"kujma10","id":2605976,"avatar_url":"https://avatars.githubusercontent.com/u/2605976?v=3","gravatar_id":"","url":"https://api.github.com/users/kujma10","html_url":"https://github.com/kujma10","followers_url":"https://api.github.com/users/kujma10/followers","following_url":"https://api.github.com/users/kujma10/following{/other_user}","gists_url":"https://api.github.com/users/kujma10/gists{/gist_id}","starred_url":"https://api.github.com/users/kujma10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kujma10/subscriptions","organizations_url":"https://api.github.com/users/kujma10/orgs","repos_url":"https://api.github.com/users/kujma10/repos","events_url":"https://api.github.com/users/kujma10/events{/privacy}","received_events_url":"https://api.github.com/users/kujma10/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T14:36:23Z","updated_at":"2016-12-08T14:36:23Z","body":"@timdorr can you please reconsider this Pull Request? "}}
{"actor":{"display_login":"kujma10"}}