{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/67543808","id":67543808,"diff_hunk":"@@ -123,8 +106,9 @@ def pre(self, job):\n                 self._lock(job)\n         except Exception as detail:\n             msg = \"Failure trying to set Avocado-VT job lock: %s\" % detail\n-            self._abort(msg, job)\n+            self.log.error(msg)\n+            sys.exit(exit_codes.AVOCADO_JOB_FAIL | job.exitcode)\n \n     def post(self, job):\n         if self.lock_file is not None:\n-            self._unlock()\n+            os.unlink(self.lock_file)","path":"avocado_vt/plugins/vt_joblock.py","position":141,"original_position":92,"commit_id":"594b053146e6ed192e3f6c2a89ff9e608d2c9417","original_commit_id":"594b053146e6ed192e3f6c2a89ff9e608d2c9417","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"body":"Well currently interruption inside `post` interrupts everything. We might introduce something like `atexit` does, which means ignore the exceptions and proceed with next function...","created_at":"2016-06-17T17:10:48Z","updated_at":"2016-06-17T17:10:48Z","html_url":"https://github.com/avocado-framework/avocado-vt/pull/578#discussion_r67543808","pull_request_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/67543808"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/578#discussion_r67543808"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578"}}},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578","id":74138024,"html_url":"https://github.com/avocado-framework/avocado-vt/pull/578","diff_url":"https://github.com/avocado-framework/avocado-vt/pull/578.diff","patch_url":"https://github.com/avocado-framework/avocado-vt/pull/578.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/578","number":578,"state":"open","locked":false,"title":"Job lock: create the lock and then check for other locks","user":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"body":"This attempts to implement the good points raised on issue #567.\r\n\r\nIt changes the behavior of how locks are acquired, by first creating the process own lock, and then checking if other exist.  If other lock files exist, check if they're stale.  If they're stale, remove them. If they're not stale, that is, the process is alive, bail out.\r\n\r\nThis requires the following fix to Avocado's `avocado.utils.process.pid_exists()`:\r\n\r\nhttps://github.com/avocado-framework/avocado/pull/1267","created_at":"2016-06-16T19:28:36Z","updated_at":"2016-06-17T17:10:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d23bee88cb3e0b6883a7719bb5a6565d9d77c2c","assignee":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/578/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/594b053146e6ed192e3f6c2a89ff9e608d2c9417","head":{"label":"clebergnu:job_lock_create_then_check","ref":"job_lock_create_then_check","sha":"594b053146e6ed192e3f6c2a89ff9e608d2c9417","user":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"repo":{"id":39959083,"name":"avocado-vt","full_name":"clebergnu/avocado-vt","owner":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clebergnu/avocado-vt","description":"Avocado Compatibility Layer for Legacy Virt Tests (autotest based)","fork":true,"url":"https://api.github.com/repos/clebergnu/avocado-vt","forks_url":"https://api.github.com/repos/clebergnu/avocado-vt/forks","keys_url":"https://api.github.com/repos/clebergnu/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clebergnu/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clebergnu/avocado-vt/teams","hooks_url":"https://api.github.com/repos/clebergnu/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/clebergnu/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/clebergnu/avocado-vt/events","assignees_url":"https://api.github.com/repos/clebergnu/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/clebergnu/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/clebergnu/avocado-vt/tags","blobs_url":"https://api.github.com/repos/clebergnu/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clebergnu/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clebergnu/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/clebergnu/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clebergnu/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/clebergnu/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/clebergnu/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/clebergnu/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/clebergnu/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/clebergnu/avocado-vt/subscription","commits_url":"https://api.github.com/repos/clebergnu/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/clebergnu/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/clebergnu/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/clebergnu/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/clebergnu/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/clebergnu/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clebergnu/avocado-vt/merges","archive_url":"https://api.github.com/repos/clebergnu/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clebergnu/avocado-vt/downloads","issues_url":"https://api.github.com/repos/clebergnu/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/clebergnu/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/clebergnu/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/clebergnu/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clebergnu/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/clebergnu/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/clebergnu/avocado-vt/deployments","created_at":"2015-07-30T15:54:28Z","updated_at":"2016-05-02T12:02:54Z","pushed_at":"2016-06-16T19:25:09Z","git_url":"git://github.com/clebergnu/avocado-vt.git","ssh_url":"git@github.com:clebergnu/avocado-vt.git","clone_url":"https://github.com/clebergnu/avocado-vt.git","svn_url":"https://github.com/clebergnu/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":19458,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"e37732b7561f2ee4fe43207ea33962ee87340ec3","user":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":36371959,"name":"avocado-vt","full_name":"avocado-framework/avocado-vt","owner":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado-vt","description":"Avocado VT Plugin","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado-vt","forks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado-vt/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado-vt/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado-vt/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/deployments","created_at":"2015-05-27T14:22:13Z","updated_at":"2016-06-01T10:32:24Z","pushed_at":"2016-06-17T12:26:30Z","git_url":"git://github.com/avocado-framework/avocado-vt.git","ssh_url":"git@github.com:avocado-framework/avocado-vt.git","clone_url":"https://github.com/avocado-framework/avocado-vt.git","svn_url":"https://github.com/avocado-framework/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":19860,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":59,"forks":53,"open_issues":59,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/578"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/578"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/594b053146e6ed192e3f6c2a89ff9e608d2c9417"}}}}
{"actor":{"display_login":"ldoktor"}}