{"action":"opened","issue":{"url":"https://api.github.com/repos/openshift/openshift-restclient-java/issues/246","repository_url":"https://api.github.com/repos/openshift/openshift-restclient-java","labels_url":"https://api.github.com/repos/openshift/openshift-restclient-java/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-restclient-java/issues/246/comments","events_url":"https://api.github.com/repos/openshift/openshift-restclient-java/issues/246/events","html_url":"https://github.com/openshift/openshift-restclient-java/issues/246","id":195820805,"number":246,"title":"Serverside filtering of GET requests","user":{"login":"bjartek","id":10621,"avatar_url":"https://avatars.githubusercontent.com/u/10621?v=3","gravatar_id":"","url":"https://api.github.com/users/bjartek","html_url":"https://github.com/bjartek","followers_url":"https://api.github.com/users/bjartek/followers","following_url":"https://api.github.com/users/bjartek/following{/other_user}","gists_url":"https://api.github.com/users/bjartek/gists{/gist_id}","starred_url":"https://api.github.com/users/bjartek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjartek/subscriptions","organizations_url":"https://api.github.com/users/bjartek/orgs","repos_url":"https://api.github.com/users/bjartek/repos","events_url":"https://api.github.com/users/bjartek/events{/privacy}","received_events_url":"https://api.github.com/users/bjartek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-15T14:36:06Z","updated_at":"2016-12-15T14:36:06Z","closed_at":null,"body":"When doing a GET request with labels the filtering is now done clientside. There is a todo in the code to figure out how to do this serverside. \r\n\r\nAll GET queries to the oapi endpoints support a labelQuery queryparameter. So in my eyes a solution could be to convert labels to csv string and add them as a query paramter to the URL builder. \r\n\r\nI have done an attempt in my fork on how to do this. I have not managed to get the tests to run quite yet so there might be some small bugs. \r\n\r\nIt should be noted that labelQuery supports features that cannot be directly mapped to a map of key=value. I.E this is a valid labelQuery \"label2,!label3\". This basically says fetch resources that have label2 set but not label3. So it would perhaps be wise to add a method to get kinds with a predefined labelQuery as a string. \r\n\r\n"}}
{"actor":{"display_login":"bjartek"}}