{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/11790","repository_url":"https://api.github.com/repos/atom/atom","labels_url":"https://api.github.com/repos/atom/atom/issues/11790/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/11790/comments","events_url":"https://api.github.com/repos/atom/atom/issues/11790/events","html_url":"https://github.com/atom/atom/pull/11790","id":155829134,"number":11790,"title":"replace OSX window title bar with custom title-bar","user":{"login":"brumm","id":170500,"avatar_url":"https://avatars.githubusercontent.com/u/170500?v=3","gravatar_id":"","url":"https://api.github.com/users/brumm","html_url":"https://github.com/brumm","followers_url":"https://api.github.com/users/brumm/followers","following_url":"https://api.github.com/users/brumm/following{/other_user}","gists_url":"https://api.github.com/users/brumm/gists{/gist_id}","starred_url":"https://api.github.com/users/brumm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brumm/subscriptions","organizations_url":"https://api.github.com/users/brumm/orgs","repos_url":"https://api.github.com/users/brumm/repos","events_url":"https://api.github.com/users/brumm/events{/privacy}","received_events_url":"https://api.github.com/users/brumm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atom/atom/labels/needs-testing","name":"needs-testing","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-05-19T20:36:50Z","updated_at":"2016-05-26T08:45:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/11790","html_url":"https://github.com/atom/atom/pull/11790","diff_url":"https://github.com/atom/atom/pull/11790.diff","patch_url":"https://github.com/atom/atom/pull/11790.patch"},"body":"This pull request is intended to naively implement a custom titlebar on OSX.\r\n\r\nI've included fallback styling to match El Capitan's titlebars, which is probably not necessary as I modified the four included themes to provide their own titlebar styling. I'll create PRs for these in their respective repositories if this PR gets considered.\r\n\r\nI'd like to hear your thoughts on the implementation, I just banged on the code until it worked 😁 \r\n\r\nThis is what it looks like by default: \r\n![image](https://cloud.githubusercontent.com/assets/170500/15407444/211946aa-1e0b-11e6-871b-4f332cbab894.png)\r\n\r\nThis is the titlebar provided by one-dark-ui, with the oceanic-next syntax\r\n![image](https://cloud.githubusercontent.com/assets/170500/15407534/ad8b0c4a-1e0b-11e6-842e-de6df82d5e15.png)\r\n\r\nThis is one-light-ui, with the atom-light syntax\r\n![image](https://cloud.githubusercontent.com/assets/170500/15407555/c5222ba4-1e0b-11e6-9aeb-2f7693e20a2d.png)\r\n\r\nThings left to do:\r\n- [x] ✅ specs\r\n\r\nThis is a partial continuation of https://github.com/atom/atom/pull/10208 albeit without the combined title-bar-and-tabs functionality, for which this would be the groundwork. (As requested in https://github.com/atom/atom/issues/4599 for example.)"},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/221812669","html_url":"https://github.com/atom/atom/pull/11790#issuecomment-221812669","issue_url":"https://api.github.com/repos/atom/atom/issues/11790","id":221812669,"user":{"login":"simurai","id":378023,"avatar_url":"https://avatars.githubusercontent.com/u/378023?v=3","gravatar_id":"","url":"https://api.github.com/users/simurai","html_url":"https://github.com/simurai","followers_url":"https://api.github.com/users/simurai/followers","following_url":"https://api.github.com/users/simurai/following{/other_user}","gists_url":"https://api.github.com/users/simurai/gists{/gist_id}","starred_url":"https://api.github.com/users/simurai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simurai/subscriptions","organizations_url":"https://api.github.com/users/simurai/orgs","repos_url":"https://api.github.com/users/simurai/repos","events_url":"https://api.github.com/users/simurai/events{/privacy}","received_events_url":"https://api.github.com/users/simurai/received_events","type":"User","site_admin":true},"created_at":"2016-05-26T08:45:04Z","updated_at":"2016-05-26T08:45:04Z","body":">  After much back-and-forth I decided against `@tab-bar-background-color` to preserve some contrast between title-bar and the rest of the UI, but I do like both.\r\n\r\nYeah, sounds good. For the bundled One + Atom themes, we can still thinking about customizing it. Also having a border by default should help make it clear where you can start dragging the window.\r\n\r\n@FezVrasta In case your favorite theme doesn't look seamless, you could always make it transparent in your `styles.less` with:\r\n\r\n```css\r\n.title-bar {\r\n  background-color: transparent;\r\n  border-color: transparent;\r\n}\r\n```\r\n\r\n> Should I squash now or after another once-over?\r\n\r\nOnly if you want, so far we haven't really bothered about it. Maybe one day we will enable it on the merge button, now that GitHub added that feature.\r\n\r\n> As far as I can tell, the failed travis build doesn't seem to be related to my changes.\r\n\r\nYa, looks like an unlreated timeout."}}
{"actor":{"display_login":"simurai"}}