{"action":"opened","number":708,"pull_request":{"url":"https://api.github.com/repos/libopencm3/libopencm3/pulls/708","id":92467700,"html_url":"https://github.com/libopencm3/libopencm3/pull/708","diff_url":"https://github.com/libopencm3/libopencm3/pull/708.diff","patch_url":"https://github.com/libopencm3/libopencm3/pull/708.patch","issue_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/708","number":708,"state":"open","locked":false,"title":"cm3/fpb: Fix overly strict ARMv7 check","user":{"login":"devanlai","id":1348448,"avatar_url":"https://avatars.githubusercontent.com/u/1348448?v=3","gravatar_id":"","url":"https://api.github.com/users/devanlai","html_url":"https://github.com/devanlai","followers_url":"https://api.github.com/users/devanlai/followers","following_url":"https://api.github.com/users/devanlai/following{/other_user}","gists_url":"https://api.github.com/users/devanlai/gists{/gist_id}","starred_url":"https://api.github.com/users/devanlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devanlai/subscriptions","organizations_url":"https://api.github.com/users/devanlai/orgs","repos_url":"https://api.github.com/users/devanlai/repos","events_url":"https://api.github.com/users/devanlai/events{/privacy}","received_events_url":"https://api.github.com/users/devanlai/received_events","type":"User","site_admin":false},"body":"The check to see if the architecture is ARMv7 was negated incorrectly, reporting an error if either of `__ARM_ARCH_7M__` or `__ARM_ARCH_7EM__` is not defined instead of only triggering when both are undefined.\r\n\r\nAFAICT,  `-mcpu=cortex-m3` only defines `__ARM_ARCH_7M__` and `-mcpu=cortex-m4` only defines `__ARM_ARCH_7EM__`, so this always errors out.\r\n\r\nThis commit makes the check consistent with the versions in `itm.h` and `tpiu.h`.","created_at":"2016-11-05T21:19:44Z","updated_at":"2016-11-05T21:19:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libopencm3/libopencm3/pulls/708/commits","review_comments_url":"https://api.github.com/repos/libopencm3/libopencm3/pulls/708/comments","review_comment_url":"https://api.github.com/repos/libopencm3/libopencm3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/708/comments","statuses_url":"https://api.github.com/repos/libopencm3/libopencm3/statuses/011b5c615ad398bd14bbc58e43d9b3335cfaa1b8","head":{"label":"devanlai:fix-armv7-check","ref":"fix-armv7-check","sha":"011b5c615ad398bd14bbc58e43d9b3335cfaa1b8","user":{"login":"devanlai","id":1348448,"avatar_url":"https://avatars.githubusercontent.com/u/1348448?v=3","gravatar_id":"","url":"https://api.github.com/users/devanlai","html_url":"https://github.com/devanlai","followers_url":"https://api.github.com/users/devanlai/followers","following_url":"https://api.github.com/users/devanlai/following{/other_user}","gists_url":"https://api.github.com/users/devanlai/gists{/gist_id}","starred_url":"https://api.github.com/users/devanlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devanlai/subscriptions","organizations_url":"https://api.github.com/users/devanlai/orgs","repos_url":"https://api.github.com/users/devanlai/repos","events_url":"https://api.github.com/users/devanlai/events{/privacy}","received_events_url":"https://api.github.com/users/devanlai/received_events","type":"User","site_admin":false},"repo":{"id":42081692,"name":"libopencm3","full_name":"devanlai/libopencm3","owner":{"login":"devanlai","id":1348448,"avatar_url":"https://avatars.githubusercontent.com/u/1348448?v=3","gravatar_id":"","url":"https://api.github.com/users/devanlai","html_url":"https://github.com/devanlai","followers_url":"https://api.github.com/users/devanlai/followers","following_url":"https://api.github.com/users/devanlai/following{/other_user}","gists_url":"https://api.github.com/users/devanlai/gists{/gist_id}","starred_url":"https://api.github.com/users/devanlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devanlai/subscriptions","organizations_url":"https://api.github.com/users/devanlai/orgs","repos_url":"https://api.github.com/users/devanlai/repos","events_url":"https://api.github.com/users/devanlai/events{/privacy}","received_events_url":"https://api.github.com/users/devanlai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devanlai/libopencm3","description":"Open Source ARM cortex m microcontroller library","fork":true,"url":"https://api.github.com/repos/devanlai/libopencm3","forks_url":"https://api.github.com/repos/devanlai/libopencm3/forks","keys_url":"https://api.github.com/repos/devanlai/libopencm3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devanlai/libopencm3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devanlai/libopencm3/teams","hooks_url":"https://api.github.com/repos/devanlai/libopencm3/hooks","issue_events_url":"https://api.github.com/repos/devanlai/libopencm3/issues/events{/number}","events_url":"https://api.github.com/repos/devanlai/libopencm3/events","assignees_url":"https://api.github.com/repos/devanlai/libopencm3/assignees{/user}","branches_url":"https://api.github.com/repos/devanlai/libopencm3/branches{/branch}","tags_url":"https://api.github.com/repos/devanlai/libopencm3/tags","blobs_url":"https://api.github.com/repos/devanlai/libopencm3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devanlai/libopencm3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devanlai/libopencm3/git/refs{/sha}","trees_url":"https://api.github.com/repos/devanlai/libopencm3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devanlai/libopencm3/statuses/{sha}","languages_url":"https://api.github.com/repos/devanlai/libopencm3/languages","stargazers_url":"https://api.github.com/repos/devanlai/libopencm3/stargazers","contributors_url":"https://api.github.com/repos/devanlai/libopencm3/contributors","subscribers_url":"https://api.github.com/repos/devanlai/libopencm3/subscribers","subscription_url":"https://api.github.com/repos/devanlai/libopencm3/subscription","commits_url":"https://api.github.com/repos/devanlai/libopencm3/commits{/sha}","git_commits_url":"https://api.github.com/repos/devanlai/libopencm3/git/commits{/sha}","comments_url":"https://api.github.com/repos/devanlai/libopencm3/comments{/number}","issue_comment_url":"https://api.github.com/repos/devanlai/libopencm3/issues/comments{/number}","contents_url":"https://api.github.com/repos/devanlai/libopencm3/contents/{+path}","compare_url":"https://api.github.com/repos/devanlai/libopencm3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devanlai/libopencm3/merges","archive_url":"https://api.github.com/repos/devanlai/libopencm3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devanlai/libopencm3/downloads","issues_url":"https://api.github.com/repos/devanlai/libopencm3/issues{/number}","pulls_url":"https://api.github.com/repos/devanlai/libopencm3/pulls{/number}","milestones_url":"https://api.github.com/repos/devanlai/libopencm3/milestones{/number}","notifications_url":"https://api.github.com/repos/devanlai/libopencm3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devanlai/libopencm3/labels{/name}","releases_url":"https://api.github.com/repos/devanlai/libopencm3/releases{/id}","deployments_url":"https://api.github.com/repos/devanlai/libopencm3/deployments","created_at":"2015-09-08T00:59:46Z","updated_at":"2016-05-28T00:51:16Z","pushed_at":"2016-11-05T20:59:00Z","git_url":"git://github.com/devanlai/libopencm3.git","ssh_url":"git@github.com:devanlai/libopencm3.git","clone_url":"https://github.com/devanlai/libopencm3.git","svn_url":"https://github.com/devanlai/libopencm3","homepage":"http://libopencm3.org/","size":4671,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libopencm3:master","ref":"master","sha":"8c74128ff6aaa2f785d8e994e82746a6e937e46c","user":{"login":"libopencm3","id":1656279,"avatar_url":"https://avatars.githubusercontent.com/u/1656279?v=3","gravatar_id":"","url":"https://api.github.com/users/libopencm3","html_url":"https://github.com/libopencm3","followers_url":"https://api.github.com/users/libopencm3/followers","following_url":"https://api.github.com/users/libopencm3/following{/other_user}","gists_url":"https://api.github.com/users/libopencm3/gists{/gist_id}","starred_url":"https://api.github.com/users/libopencm3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopencm3/subscriptions","organizations_url":"https://api.github.com/users/libopencm3/orgs","repos_url":"https://api.github.com/users/libopencm3/repos","events_url":"https://api.github.com/users/libopencm3/events{/privacy}","received_events_url":"https://api.github.com/users/libopencm3/received_events","type":"Organization","site_admin":false},"repo":{"id":4065980,"name":"libopencm3","full_name":"libopencm3/libopencm3","owner":{"login":"libopencm3","id":1656279,"avatar_url":"https://avatars.githubusercontent.com/u/1656279?v=3","gravatar_id":"","url":"https://api.github.com/users/libopencm3","html_url":"https://github.com/libopencm3","followers_url":"https://api.github.com/users/libopencm3/followers","following_url":"https://api.github.com/users/libopencm3/following{/other_user}","gists_url":"https://api.github.com/users/libopencm3/gists{/gist_id}","starred_url":"https://api.github.com/users/libopencm3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopencm3/subscriptions","organizations_url":"https://api.github.com/users/libopencm3/orgs","repos_url":"https://api.github.com/users/libopencm3/repos","events_url":"https://api.github.com/users/libopencm3/events{/privacy}","received_events_url":"https://api.github.com/users/libopencm3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libopencm3/libopencm3","description":"Open Source ARM cortex m microcontroller library","fork":false,"url":"https://api.github.com/repos/libopencm3/libopencm3","forks_url":"https://api.github.com/repos/libopencm3/libopencm3/forks","keys_url":"https://api.github.com/repos/libopencm3/libopencm3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopencm3/libopencm3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopencm3/libopencm3/teams","hooks_url":"https://api.github.com/repos/libopencm3/libopencm3/hooks","issue_events_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/events{/number}","events_url":"https://api.github.com/repos/libopencm3/libopencm3/events","assignees_url":"https://api.github.com/repos/libopencm3/libopencm3/assignees{/user}","branches_url":"https://api.github.com/repos/libopencm3/libopencm3/branches{/branch}","tags_url":"https://api.github.com/repos/libopencm3/libopencm3/tags","blobs_url":"https://api.github.com/repos/libopencm3/libopencm3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopencm3/libopencm3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopencm3/libopencm3/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopencm3/libopencm3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopencm3/libopencm3/statuses/{sha}","languages_url":"https://api.github.com/repos/libopencm3/libopencm3/languages","stargazers_url":"https://api.github.com/repos/libopencm3/libopencm3/stargazers","contributors_url":"https://api.github.com/repos/libopencm3/libopencm3/contributors","subscribers_url":"https://api.github.com/repos/libopencm3/libopencm3/subscribers","subscription_url":"https://api.github.com/repos/libopencm3/libopencm3/subscription","commits_url":"https://api.github.com/repos/libopencm3/libopencm3/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopencm3/libopencm3/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopencm3/libopencm3/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopencm3/libopencm3/contents/{+path}","compare_url":"https://api.github.com/repos/libopencm3/libopencm3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopencm3/libopencm3/merges","archive_url":"https://api.github.com/repos/libopencm3/libopencm3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopencm3/libopencm3/downloads","issues_url":"https://api.github.com/repos/libopencm3/libopencm3/issues{/number}","pulls_url":"https://api.github.com/repos/libopencm3/libopencm3/pulls{/number}","milestones_url":"https://api.github.com/repos/libopencm3/libopencm3/milestones{/number}","notifications_url":"https://api.github.com/repos/libopencm3/libopencm3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopencm3/libopencm3/labels{/name}","releases_url":"https://api.github.com/repos/libopencm3/libopencm3/releases{/id}","deployments_url":"https://api.github.com/repos/libopencm3/libopencm3/deployments","created_at":"2012-04-18T16:51:38Z","updated_at":"2016-11-05T04:25:02Z","pushed_at":"2016-11-05T21:19:44Z","git_url":"git://github.com/libopencm3/libopencm3.git","ssh_url":"git@github.com:libopencm3/libopencm3.git","clone_url":"https://github.com/libopencm3/libopencm3.git","svn_url":"https://github.com/libopencm3/libopencm3","homepage":"http://libopencm3.org/","size":7359,"stargazers_count":519,"watchers_count":519,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":144,"forks":328,"open_issues":144,"watchers":519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopencm3/libopencm3/pulls/708"},"html":{"href":"https://github.com/libopencm3/libopencm3/pull/708"},"issue":{"href":"https://api.github.com/repos/libopencm3/libopencm3/issues/708"},"comments":{"href":"https://api.github.com/repos/libopencm3/libopencm3/issues/708/comments"},"review_comments":{"href":"https://api.github.com/repos/libopencm3/libopencm3/pulls/708/comments"},"review_comment":{"href":"https://api.github.com/repos/libopencm3/libopencm3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopencm3/libopencm3/pulls/708/commits"},"statuses":{"href":"https://api.github.com/repos/libopencm3/libopencm3/statuses/011b5c615ad398bd14bbc58e43d9b3335cfaa1b8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"devanlai"}}