{"action":"created","issue":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/348","repository_url":"https://api.github.com/repos/wxWidgets/wxWidgets","labels_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/348/labels{/name}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/348/comments","events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/348/events","html_url":"https://github.com/wxWidgets/wxWidgets/pull/348","id":190589784,"number":348,"title":"Allow pasting using Cmd+V in wxTextCtrl with wxTE_PASSWORD style","user":{"login":"vadz","id":146917,"avatar_url":"https://avatars.githubusercontent.com/u/146917?v=3","gravatar_id":"","url":"https://api.github.com/users/vadz","html_url":"https://github.com/vadz","followers_url":"https://api.github.com/users/vadz/followers","following_url":"https://api.github.com/users/vadz/following{/other_user}","gists_url":"https://api.github.com/users/vadz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadz/subscriptions","organizations_url":"https://api.github.com/users/vadz/orgs","repos_url":"https://api.github.com/users/vadz/repos","events_url":"https://api.github.com/users/vadz/events{/privacy}","received_events_url":"https://api.github.com/users/vadz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-20T22:46:04Z","updated_at":"2016-11-22T13:11:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/348","html_url":"https://github.com/wxWidgets/wxWidgets/pull/348","diff_url":"https://github.com/wxWidgets/wxWidgets/pull/348.diff","patch_url":"https://github.com/wxWidgets/wxWidgets/pull/348.patch"},"body":"For some reason known only to Apple, NSSecureTextField allows pasting text\r\ninto it using its standard context menu, but not using the standard Cmd+V\r\nkeyboard shortcut. Moreover, apparently the control does something special to\r\ndisable it because pressing Cmd+V does result in a call to\r\n-[NSSecureTextField control:textView:doCommandBySelector:], but with a dummy\r\n\"noop:\" selector.\r\n\r\nDetect this specific situation and check if we're called while handling Cmd+V\r\nevent and, if this is indeed the case, do paste the text into the control.\r\n\r\nWhile it could be argued that this changes the platform behaviour, it seems\r\nvery hard, if not impossible, to imagine a situation in which this would be a\r\nproblem while not being able to easily paste into password fields is\r\ndefinitely a real usability bug.\r\n\r\n---\r\n\r\n@vslavik I'd appreciate any comments about this, TIA!"},"comment":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/comments/262236664","html_url":"https://github.com/wxWidgets/wxWidgets/pull/348#issuecomment-262236664","issue_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/348","id":262236664,"user":{"login":"vadz","id":146917,"avatar_url":"https://avatars.githubusercontent.com/u/146917?v=3","gravatar_id":"","url":"https://api.github.com/users/vadz","html_url":"https://github.com/vadz","followers_url":"https://api.github.com/users/vadz/followers","following_url":"https://api.github.com/users/vadz/following{/other_user}","gists_url":"https://api.github.com/users/vadz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadz/subscriptions","organizations_url":"https://api.github.com/users/vadz/orgs","repos_url":"https://api.github.com/users/vadz/repos","events_url":"https://api.github.com/users/vadz/events{/privacy}","received_events_url":"https://api.github.com/users/vadz/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T13:11:50Z","updated_at":"2016-11-22T13:11:50Z","body":"I think that any `#ifdef PLATFORM` check in the code is a failure of wxWidgets. Granted, in practice they're unavoidable but surely the best solution would avoid them.\r\n\r\nIn this case it does seem to mean adding the \"Edit\" menu automatically, but, as I wrote, there are several potential issues with doing it..."}}
{"actor":{"display_login":"vadz"}}