{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/52135154","id":52135154,"diff_hunk":"@@ -188,11 +188,11 @@ function createProject(name, verbose) {\n }\n \n function run(root, projectName) {\n-  exec('npm install --save react-native', function(e, stdout, stderr) {\n+  exec('npm install --save react react-native', function(e, stdout, stderr) {","path":"react-native-cli/index.js","position":14,"original_position":14,"commit_id":"659bf0e5873ccd2da4951a351a887f463868bcef","original_commit_id":"659bf0e5873ccd2da4951a351a887f463868bcef","user":{"login":"frantic","id":192222,"avatar_url":"https://avatars.githubusercontent.com/u/192222?v=3","gravatar_id":"","url":"https://api.github.com/users/frantic","html_url":"https://github.com/frantic","followers_url":"https://api.github.com/users/frantic/followers","following_url":"https://api.github.com/users/frantic/following{/other_user}","gists_url":"https://api.github.com/users/frantic/gists{/gist_id}","starred_url":"https://api.github.com/users/frantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frantic/subscriptions","organizations_url":"https://api.github.com/users/frantic/orgs","repos_url":"https://api.github.com/users/frantic/repos","events_url":"https://api.github.com/users/frantic/events{/privacy}","received_events_url":"https://api.github.com/users/frantic/received_events","type":"User","site_admin":false},"body":"might be worth moving `npm install --save react` to `local-cli`? This way existing users won't have to upgrade global `react-native-cli`","created_at":"2016-02-08T05:52:26Z","updated_at":"2016-02-08T05:52:26Z","html_url":"https://github.com/facebook/react-native/pull/5813#discussion_r52135154","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/5813","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/52135154"},"html":{"href":"https://github.com/facebook/react-native/pull/5813#discussion_r52135154"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5813"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/5813","id":58572192,"html_url":"https://github.com/facebook/react-native/pull/5813","diff_url":"https://github.com/facebook/react-native/pull/5813.diff","patch_url":"https://github.com/facebook/react-native/pull/5813.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/5813","number":5813,"state":"open","locked":false,"title":"Move `react` to peerDependencies","user":{"login":"skevy","id":131916,"avatar_url":"https://avatars.githubusercontent.com/u/131916?v=3","gravatar_id":"","url":"https://api.github.com/users/skevy","html_url":"https://github.com/skevy","followers_url":"https://api.github.com/users/skevy/followers","following_url":"https://api.github.com/users/skevy/following{/other_user}","gists_url":"https://api.github.com/users/skevy/gists{/gist_id}","starred_url":"https://api.github.com/users/skevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skevy/subscriptions","organizations_url":"https://api.github.com/users/skevy/orgs","repos_url":"https://api.github.com/users/skevy/repos","events_url":"https://api.github.com/users/skevy/events{/privacy}","received_events_url":"https://api.github.com/users/skevy/received_events","type":"User","site_admin":false},"body":"This PR moves `react` from dependencies to peerDependencies.\r\n\r\nIn general, this would have only been important for those people using packages that depend on `react` and were using npm@2...npm@3 would automatically de-dupe.\r\n\r\nHowever, when #5812 gets merged, dependencies will be scoped to react-native (on both npm@2 & npm@3), thus breaking projects that are using a package like `react-redux` for example, which depends on `react`. There would be two copies of React installed, and due to the use of haste modules in `react`, this would break the packager and cause naming collisions.\r\n\r\nThis PR does three things -\r\n\r\n1. Moves the dependency from dependencies to peerDependencies\r\n2. Updates react-native-cli to install `react`, in addition to `react-native` (this is necessary due to how npm@3 deals with peerDeps). *Note: this will require a release of a new version of rn CLI @mkonicek\"\r\n3. Updates `react-native upgrade` to warn if `react` is not listed in the package.json's dependencies.\r\n\r\n**Note: This will require a shrinkwrap update.**","created_at":"2016-02-08T05:27:32Z","updated_at":"2016-02-08T05:52:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66dd7545bebdd53551a640c45b3210477d00731b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/5813/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/5813/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/5813/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/659bf0e5873ccd2da4951a351a887f463868bcef","head":{"label":"skevy:react-peer-dep","ref":"react-peer-dep","sha":"659bf0e5873ccd2da4951a351a887f463868bcef","user":{"login":"skevy","id":131916,"avatar_url":"https://avatars.githubusercontent.com/u/131916?v=3","gravatar_id":"","url":"https://api.github.com/users/skevy","html_url":"https://github.com/skevy","followers_url":"https://api.github.com/users/skevy/followers","following_url":"https://api.github.com/users/skevy/following{/other_user}","gists_url":"https://api.github.com/users/skevy/gists{/gist_id}","starred_url":"https://api.github.com/users/skevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skevy/subscriptions","organizations_url":"https://api.github.com/users/skevy/orgs","repos_url":"https://api.github.com/users/skevy/repos","events_url":"https://api.github.com/users/skevy/events{/privacy}","received_events_url":"https://api.github.com/users/skevy/received_events","type":"User","site_admin":false},"repo":{"id":35853418,"name":"react-native","full_name":"skevy/react-native","owner":{"login":"skevy","id":131916,"avatar_url":"https://avatars.githubusercontent.com/u/131916?v=3","gravatar_id":"","url":"https://api.github.com/users/skevy","html_url":"https://github.com/skevy","followers_url":"https://api.github.com/users/skevy/followers","following_url":"https://api.github.com/users/skevy/following{/other_user}","gists_url":"https://api.github.com/users/skevy/gists{/gist_id}","starred_url":"https://api.github.com/users/skevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skevy/subscriptions","organizations_url":"https://api.github.com/users/skevy/orgs","repos_url":"https://api.github.com/users/skevy/repos","events_url":"https://api.github.com/users/skevy/events{/privacy}","received_events_url":"https://api.github.com/users/skevy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skevy/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/skevy/react-native","forks_url":"https://api.github.com/repos/skevy/react-native/forks","keys_url":"https://api.github.com/repos/skevy/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skevy/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skevy/react-native/teams","hooks_url":"https://api.github.com/repos/skevy/react-native/hooks","issue_events_url":"https://api.github.com/repos/skevy/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/skevy/react-native/events","assignees_url":"https://api.github.com/repos/skevy/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/skevy/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/skevy/react-native/tags","blobs_url":"https://api.github.com/repos/skevy/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skevy/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skevy/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/skevy/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skevy/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/skevy/react-native/languages","stargazers_url":"https://api.github.com/repos/skevy/react-native/stargazers","contributors_url":"https://api.github.com/repos/skevy/react-native/contributors","subscribers_url":"https://api.github.com/repos/skevy/react-native/subscribers","subscription_url":"https://api.github.com/repos/skevy/react-native/subscription","commits_url":"https://api.github.com/repos/skevy/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/skevy/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/skevy/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/skevy/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/skevy/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/skevy/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skevy/react-native/merges","archive_url":"https://api.github.com/repos/skevy/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skevy/react-native/downloads","issues_url":"https://api.github.com/repos/skevy/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/skevy/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/skevy/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/skevy/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skevy/react-native/labels{/name}","releases_url":"https://api.github.com/repos/skevy/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/skevy/react-native/deployments","created_at":"2015-05-19T02:03:01Z","updated_at":"2016-02-01T21:10:27Z","pushed_at":"2016-02-08T05:27:21Z","git_url":"git://github.com/skevy/react-native.git","ssh_url":"git@github.com:skevy/react-native.git","clone_url":"https://github.com/skevy/react-native.git","svn_url":"https://github.com/skevy/react-native","homepage":"http://facebook.github.io/react-native/","size":35621,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"577206fe51cf94d53cd69123ac64bf70cd2cc0ba","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-02-08T03:46:18Z","pushed_at":"2016-02-08T05:51:54Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":75371,"stargazers_count":26907,"watchers_count":26907,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4849,"mirror_url":null,"open_issues_count":1069,"forks":4849,"open_issues":1069,"watchers":26907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5813"},"html":{"href":"https://github.com/facebook/react-native/pull/5813"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/5813"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/5813/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5813/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5813/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/659bf0e5873ccd2da4951a351a887f463868bcef"}}}}