{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1626","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1626/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1626/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1626/events","html_url":"https://github.com/openshift/openshift-ansible/pull/1626","id":141329850,"number":1626,"title":"libvirt cluster variables cleanup","user":{"login":"codificat","id":709574,"avatar_url":"https://avatars.githubusercontent.com/u/709574?v=3","gravatar_id":"","url":"https://api.github.com/users/codificat","html_url":"https://github.com/codificat","followers_url":"https://api.github.com/users/codificat/followers","following_url":"https://api.github.com/users/codificat/following{/other_user}","gists_url":"https://api.github.com/users/codificat/gists{/gist_id}","starred_url":"https://api.github.com/users/codificat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codificat/subscriptions","organizations_url":"https://api.github.com/users/codificat/orgs","repos_url":"https://api.github.com/users/codificat/repos","events_url":"https://api.github.com/users/codificat/events{/privacy}","received_events_url":"https://api.github.com/users/codificat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-16T16:38:28Z","updated_at":"2016-03-17T16:01:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1626","html_url":"https://github.com/openshift/openshift-ansible/pull/1626","diff_url":"https://github.com/openshift/openshift-ansible/pull/1626.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1626.patch"},"body":"An install of a libvirt cluster was failing if the `libvirt_instance_memory_mib` option introduced in #1578 (d4fa9b2) was not specified.\r\n\r\nWhile investigating this I saw that there were several `os_libvirt_*` variables that were apparently redundant: they seemed to be meant to have default values, but they were actually always getting the values of their corresponding `libvirt_*` counterparts. Moreover, these ones were hard-coded with different values than the intended default values for `os_libvirt_*`.\r\n\r\nThis patch cleans that up by removing the various `os_libvirt_*` and having all the `libvirt_*` in `vars.yaml` configurable.\r\n\r\nIt's unclear to me what the purpose of these `os_libvirt_*` was, so please let me know if that was the wrong approach.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/197948249","html_url":"https://github.com/openshift/openshift-ansible/pull/1626#issuecomment-197948249","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1626","id":197948249,"user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T16:01:13Z","updated_at":"2016-03-17T16:01:13Z","body":"@wshearn "}}