{"action":"closed","number":8199,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/8199","id":74300630,"html_url":"https://github.com/facebook/react-native/pull/8199","diff_url":"https://github.com/facebook/react-native/pull/8199.diff","patch_url":"https://github.com/facebook/react-native/pull/8199.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/8199","number":8199,"state":"closed","locked":false,"title":"Fix timestamps on android touch events to use milliseconds, to be consistent with iOS","user":{"login":"mikelambert","id":7953259,"avatar_url":"https://avatars.githubusercontent.com/u/7953259?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelambert","html_url":"https://github.com/mikelambert","followers_url":"https://api.github.com/users/mikelambert/followers","following_url":"https://api.github.com/users/mikelambert/following{/other_user}","gists_url":"https://api.github.com/users/mikelambert/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelambert/subscriptions","organizations_url":"https://api.github.com/users/mikelambert/orgs","repos_url":"https://api.github.com/users/mikelambert/repos","events_url":"https://api.github.com/users/mikelambert/events{/privacy}","received_events_url":"https://api.github.com/users/mikelambert/received_events","type":"User","site_admin":false},"body":"So `PanReponder.onPanResponderRelease/onPanResponderTerminate` receive a `gestureState` object containing a `onPanResponderTerminate.vx/vy` property. On Android and iOS, they appear to be orders of magnitude different, which appear to be due to the different scale of timestamps that are used when generating touch events.\r\n\r\nThis pull request fixes the timestamps to be milliseconds on both platforms (since I assume iOS is the more authoritative one, and is the one that `react-native-viewpager`'s vx thresholds written written to compare against.)\r\n\r\nAs far as I can tell, the RN code doesn't use the `vx/vy` properties, so they should be okay. And looks like the RN code only cares about relative values of `startTimestamp/currentTimestamp/previousTimestamp` though, so should be fine too. it's quite possible there will be downstream android breakage with this change, particularly for those who are already compensating for the RN discrepancy.","created_at":"2016-06-17T20:27:53Z","updated_at":"2016-07-07T13:00:04Z","closed_at":"2016-07-07T13:00:04Z","merged_at":null,"merge_commit_sha":"d0b1fac9888ddba205cc1d7e509563232050d4d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/8199/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/8199/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/8199/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/d4f433b24478fcae157e22dd1b0a74be9aea7bdc","head":{"label":"mikelambert:timestamps","ref":"timestamps","sha":"d4f433b24478fcae157e22dd1b0a74be9aea7bdc","user":{"login":"mikelambert","id":7953259,"avatar_url":"https://avatars.githubusercontent.com/u/7953259?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelambert","html_url":"https://github.com/mikelambert","followers_url":"https://api.github.com/users/mikelambert/followers","following_url":"https://api.github.com/users/mikelambert/following{/other_user}","gists_url":"https://api.github.com/users/mikelambert/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelambert/subscriptions","organizations_url":"https://api.github.com/users/mikelambert/orgs","repos_url":"https://api.github.com/users/mikelambert/repos","events_url":"https://api.github.com/users/mikelambert/events{/privacy}","received_events_url":"https://api.github.com/users/mikelambert/received_events","type":"User","site_admin":false},"repo":{"id":58318059,"name":"react-native","full_name":"mikelambert/react-native","owner":{"login":"mikelambert","id":7953259,"avatar_url":"https://avatars.githubusercontent.com/u/7953259?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelambert","html_url":"https://github.com/mikelambert","followers_url":"https://api.github.com/users/mikelambert/followers","following_url":"https://api.github.com/users/mikelambert/following{/other_user}","gists_url":"https://api.github.com/users/mikelambert/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelambert/subscriptions","organizations_url":"https://api.github.com/users/mikelambert/orgs","repos_url":"https://api.github.com/users/mikelambert/repos","events_url":"https://api.github.com/users/mikelambert/events{/privacy}","received_events_url":"https://api.github.com/users/mikelambert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikelambert/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/mikelambert/react-native","forks_url":"https://api.github.com/repos/mikelambert/react-native/forks","keys_url":"https://api.github.com/repos/mikelambert/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikelambert/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikelambert/react-native/teams","hooks_url":"https://api.github.com/repos/mikelambert/react-native/hooks","issue_events_url":"https://api.github.com/repos/mikelambert/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/mikelambert/react-native/events","assignees_url":"https://api.github.com/repos/mikelambert/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/mikelambert/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/mikelambert/react-native/tags","blobs_url":"https://api.github.com/repos/mikelambert/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikelambert/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikelambert/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikelambert/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikelambert/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mikelambert/react-native/languages","stargazers_url":"https://api.github.com/repos/mikelambert/react-native/stargazers","contributors_url":"https://api.github.com/repos/mikelambert/react-native/contributors","subscribers_url":"https://api.github.com/repos/mikelambert/react-native/subscribers","subscription_url":"https://api.github.com/repos/mikelambert/react-native/subscription","commits_url":"https://api.github.com/repos/mikelambert/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikelambert/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikelambert/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikelambert/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikelambert/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/mikelambert/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikelambert/react-native/merges","archive_url":"https://api.github.com/repos/mikelambert/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikelambert/react-native/downloads","issues_url":"https://api.github.com/repos/mikelambert/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/mikelambert/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mikelambert/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mikelambert/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikelambert/react-native/labels{/name}","releases_url":"https://api.github.com/repos/mikelambert/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/mikelambert/react-native/deployments","created_at":"2016-05-08T15:17:44Z","updated_at":"2016-05-08T15:17:50Z","pushed_at":"2016-07-06T23:38:08Z","git_url":"git://github.com/mikelambert/react-native.git","ssh_url":"git@github.com:mikelambert/react-native.git","clone_url":"https://github.com/mikelambert/react-native.git","svn_url":"https://github.com/mikelambert/react-native","homepage":"http://facebook.github.io/react-native/","size":63047,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"e209f2f1e93b12d64be8197bbe8eba7e28355ded","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-07-07T12:49:58Z","pushed_at":"2016-07-07T12:59:45Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":109457,"stargazers_count":34525,"watchers_count":34525,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7298,"mirror_url":null,"open_issues_count":1057,"forks":7298,"open_issues":1057,"watchers":34525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/8199"},"html":{"href":"https://github.com/facebook/react-native/pull/8199"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/8199"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/8199/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/8199/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/8199/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/d4f433b24478fcae157e22dd1b0a74be9aea7bdc"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":17,"review_comments":1,"commits":1,"additions":57,"deletions":53,"changed_files":20}}
{"actor":{"display_login":"facebook-github-bot-2"}}