{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/2264","repository_url":"https://api.github.com/repos/alphagov/smart-answers","labels_url":"https://api.github.com/repos/alphagov/smart-answers/issues/2264/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/issues/2264/comments","events_url":"https://api.github.com/repos/alphagov/smart-answers/issues/2264/events","html_url":"https://github.com/alphagov/smart-answers/pull/2264","id":132633636,"number":2264,"title":"Initial refactor of marriage-abroad","user":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars.githubusercontent.com/u/6556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"floehopper","id":3169,"avatar_url":"https://avatars.githubusercontent.com/u/3169?v=3","gravatar_id":"","url":"https://api.github.com/users/floehopper","html_url":"https://github.com/floehopper","followers_url":"https://api.github.com/users/floehopper/followers","following_url":"https://api.github.com/users/floehopper/following{/other_user}","gists_url":"https://api.github.com/users/floehopper/gists{/gist_id}","starred_url":"https://api.github.com/users/floehopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floehopper/subscriptions","organizations_url":"https://api.github.com/users/floehopper/orgs","repos_url":"https://api.github.com/users/floehopper/repos","events_url":"https://api.github.com/users/floehopper/events{/privacy}","received_events_url":"https://api.github.com/users/floehopper/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-02-10T08:18:21Z","updated_at":"2016-02-10T10:11:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/2264","html_url":"https://github.com/alphagov/smart-answers/pull/2264","diff_url":"https://github.com/alphagov/smart-answers/pull/2264.diff","patch_url":"https://github.com/alphagov/smart-answers/pull/2264.patch"},"body":"This replaces PR #2262 and is now ready for review and merge (assuming it all looks OK).\r\n\r\nI've started refactoring marriage-abroad, following the [steps we've used to refactor other Smart Answers](https://github.com/alphagov/smart-answers/blob/master/doc/refactoring.md).\r\n\r\nMy hope is that making these small incremental improvements will lead to a more maintainable Smart Answer. It's not going to be easy (it looks as though we currently have three marriage-abroad PRs open) but I think the pain will ultimately be worth it.\r\n\r\nThis branch introduces the `MarriageAbroadCalculator` and uses it to store the answers to `:country_of_ceremony?`, `:legal_residency?` and `:what_is_your_partners_nationality?`. I’ve introduced convenience methods that both remove duplication and hopefully result in more readable code.\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/comments/182291654","html_url":"https://github.com/alphagov/smart-answers/pull/2264#issuecomment-182291654","issue_url":"https://api.github.com/repos/alphagov/smart-answers/issues/2264","id":182291654,"user":{"login":"floehopper","id":3169,"avatar_url":"https://avatars.githubusercontent.com/u/3169?v=3","gravatar_id":"","url":"https://api.github.com/users/floehopper","html_url":"https://github.com/floehopper","followers_url":"https://api.github.com/users/floehopper/followers","following_url":"https://api.github.com/users/floehopper/following{/other_user}","gists_url":"https://api.github.com/users/floehopper/gists{/gist_id}","starred_url":"https://api.github.com/users/floehopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floehopper/subscriptions","organizations_url":"https://api.github.com/users/floehopper/orgs","repos_url":"https://api.github.com/users/floehopper/repos","events_url":"https://api.github.com/users/floehopper/events{/privacy}","received_events_url":"https://api.github.com/users/floehopper/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T10:11:26Z","updated_at":"2016-02-10T10:11:26Z","body":"All my comments are very minor. This looks good to me and I'd be happy to see it merged."}}