{"action":"created","issue":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/1958","repository_url":"https://api.github.com/repos/kangax/fabric.js","labels_url":"https://api.github.com/repos/kangax/fabric.js/issues/1958/labels{/name}","comments_url":"https://api.github.com/repos/kangax/fabric.js/issues/1958/comments","events_url":"https://api.github.com/repos/kangax/fabric.js/issues/1958/events","html_url":"https://github.com/kangax/fabric.js/pull/1958","id":56308452,"number":1958,"title":"Fixes svg rendering rules","user":{"login":"asturur","id":1194048,"avatar_url":"https://avatars.githubusercontent.com/u/1194048?v=3","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-02-02T23:11:09Z","updated_at":"2016-08-31T13:05:05Z","closed_at":"2015-02-05T09:53:41Z","pull_request":{"url":"https://api.github.com/repos/kangax/fabric.js/pulls/1958","html_url":"https://github.com/kangax/fabric.js/pull/1958","diff_url":"https://github.com/kangax/fabric.js/pull/1958.diff","patch_url":"https://github.com/kangax/fabric.js/pull/1958.patch"},"body":"This PR fixes some bugs of svg import:\r\n\r\nCircle class:\r\nRadius equal 0 is not an error, but the circle should not be rendered ( this is handled with normal if object.width and object.height both equal 0 early return from rendering );\r\n\r\nPolygon and polyline, empty point should not give empty object, just not rendered object.\r\nSame for odd point number. Firefox and chrome are rendering it, but they should not.\r\n\r\nRect: whilec canvas draw a 0 width OR 0 height stroke rectangle, svg says not. So simply set visible equal false to rect coming from svg elements with width or height equal to 0.\r\n\r\nThose SVG where previously not rendered in fabric and were throwing errors.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1194048/6011116/da48347a-ab38-11e4-8487-8f57ae946c23.png)\r\n\r\nRendering by browsers:\r\n![image](https://cloud.githubusercontent.com/assets/1194048/6011134/f8a2dea2-ab38-11e4-9622-cee8e2645b72.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1194048/6011137/fed932bc-ab38-11e4-8cba-61097f1a555e.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1194048/6011143/0742be28-ab39-11e4-86c7-2297052070f0.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1194048/6011152/110645d8-ab39-11e4-902d-4c76fa52d19b.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/comments/243757165","html_url":"https://github.com/kangax/fabric.js/pull/1958#issuecomment-243757165","issue_url":"https://api.github.com/repos/kangax/fabric.js/issues/1958","id":243757165,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T13:05:05Z","updated_at":"2016-08-31T13:05:05Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7687405/badge)](https://coveralls.io/builds/7687405)\n\nChanges Unknown when pulling **69880b5104e33dce5d0fe184c7fc51100ef93b5c on asturur:Fix-svg-tiny-test-suite** into ** on kangax:master**.\n"}}
{"actor":{"display_login":"coveralls"}}