{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/63199691","id":63199691,"diff_hunk":"@@ -233,6 +233,8 @@ UPGRADE FROM 2.x to 3.0\n \n ### Form\n \n+ * The max_length option was removed. Use the attr option instead by setting it to an array with a maxlength key.","path":"UPGRADE-3.0.md","position":4,"original_position":4,"commit_id":"5fefeac1c823765a5804345c6e1e0ee612742317","original_commit_id":"5fefeac1c823765a5804345c6e1e0ee612742317","user":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"body":"``max_length``, ``attr``, ``array`` and ``maxlength`` should be quoted","created_at":"2016-05-13T15:11:04Z","updated_at":"2016-05-13T15:11:04Z","html_url":"https://github.com/symfony/symfony/pull/18772#discussion_r63199691","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/18772","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/63199691"},"html":{"href":"https://github.com/symfony/symfony/pull/18772#discussion_r63199691"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18772"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/18772","id":70007772,"html_url":"https://github.com/symfony/symfony/pull/18772","diff_url":"https://github.com/symfony/symfony/pull/18772.diff","patch_url":"https://github.com/symfony/symfony/pull/18772.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/18772","number":18772,"state":"open","locked":false,"title":"Update UPGRADE FROM 2.x to 3.0","user":{"login":"bradbyu","id":5098494,"avatar_url":"https://avatars.githubusercontent.com/u/5098494?v=3","gravatar_id":"","url":"https://api.github.com/users/bradbyu","html_url":"https://github.com/bradbyu","followers_url":"https://api.github.com/users/bradbyu/followers","following_url":"https://api.github.com/users/bradbyu/following{/other_user}","gists_url":"https://api.github.com/users/bradbyu/gists{/gist_id}","starred_url":"https://api.github.com/users/bradbyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradbyu/subscriptions","organizations_url":"https://api.github.com/users/bradbyu/orgs","repos_url":"https://api.github.com/users/bradbyu/repos","events_url":"https://api.github.com/users/bradbyu/events{/privacy}","received_events_url":"https://api.github.com/users/bradbyu/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | \"master\"\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | none\r\n| License       | MIT\r\n| Doc PR        | http://symfony.com/doc/2.8/reference/forms/types/text.html for starters\r\n\r\nYou missed the Form max_length option deprecation in several field types (Text, Password, Email, etc...).","created_at":"2016-05-13T14:48:25Z","updated_at":"2016-05-13T15:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"975cbc424e67b109ae59bd6705c023186e97514a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/18772/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/18772/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/18772/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/5fefeac1c823765a5804345c6e1e0ee612742317","head":{"label":"bradbyu:patch-1","ref":"patch-1","sha":"5fefeac1c823765a5804345c6e1e0ee612742317","user":{"login":"bradbyu","id":5098494,"avatar_url":"https://avatars.githubusercontent.com/u/5098494?v=3","gravatar_id":"","url":"https://api.github.com/users/bradbyu","html_url":"https://github.com/bradbyu","followers_url":"https://api.github.com/users/bradbyu/followers","following_url":"https://api.github.com/users/bradbyu/following{/other_user}","gists_url":"https://api.github.com/users/bradbyu/gists{/gist_id}","starred_url":"https://api.github.com/users/bradbyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradbyu/subscriptions","organizations_url":"https://api.github.com/users/bradbyu/orgs","repos_url":"https://api.github.com/users/bradbyu/repos","events_url":"https://api.github.com/users/bradbyu/events{/privacy}","received_events_url":"https://api.github.com/users/bradbyu/received_events","type":"User","site_admin":false},"repo":{"id":58747667,"name":"symfony","full_name":"bradbyu/symfony","owner":{"login":"bradbyu","id":5098494,"avatar_url":"https://avatars.githubusercontent.com/u/5098494?v=3","gravatar_id":"","url":"https://api.github.com/users/bradbyu","html_url":"https://github.com/bradbyu","followers_url":"https://api.github.com/users/bradbyu/followers","following_url":"https://api.github.com/users/bradbyu/following{/other_user}","gists_url":"https://api.github.com/users/bradbyu/gists{/gist_id}","starred_url":"https://api.github.com/users/bradbyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradbyu/subscriptions","organizations_url":"https://api.github.com/users/bradbyu/orgs","repos_url":"https://api.github.com/users/bradbyu/repos","events_url":"https://api.github.com/users/bradbyu/events{/privacy}","received_events_url":"https://api.github.com/users/bradbyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradbyu/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/bradbyu/symfony","forks_url":"https://api.github.com/repos/bradbyu/symfony/forks","keys_url":"https://api.github.com/repos/bradbyu/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradbyu/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradbyu/symfony/teams","hooks_url":"https://api.github.com/repos/bradbyu/symfony/hooks","issue_events_url":"https://api.github.com/repos/bradbyu/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/bradbyu/symfony/events","assignees_url":"https://api.github.com/repos/bradbyu/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/bradbyu/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/bradbyu/symfony/tags","blobs_url":"https://api.github.com/repos/bradbyu/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradbyu/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradbyu/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradbyu/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradbyu/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/bradbyu/symfony/languages","stargazers_url":"https://api.github.com/repos/bradbyu/symfony/stargazers","contributors_url":"https://api.github.com/repos/bradbyu/symfony/contributors","subscribers_url":"https://api.github.com/repos/bradbyu/symfony/subscribers","subscription_url":"https://api.github.com/repos/bradbyu/symfony/subscription","commits_url":"https://api.github.com/repos/bradbyu/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradbyu/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradbyu/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradbyu/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradbyu/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/bradbyu/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradbyu/symfony/merges","archive_url":"https://api.github.com/repos/bradbyu/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradbyu/symfony/downloads","issues_url":"https://api.github.com/repos/bradbyu/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/bradbyu/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/bradbyu/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/bradbyu/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradbyu/symfony/labels{/name}","releases_url":"https://api.github.com/repos/bradbyu/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/bradbyu/symfony/deployments","created_at":"2016-05-13T14:35:02Z","updated_at":"2016-05-13T14:35:19Z","pushed_at":"2016-05-13T14:45:15Z","git_url":"git://github.com/bradbyu/symfony.git","ssh_url":"git@github.com:bradbyu/symfony.git","clone_url":"https://github.com/bradbyu/symfony.git","svn_url":"https://github.com/bradbyu/symfony","homepage":"symfony.com","size":70866,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"8f6c3b0711e7d5cb408d197bacb57f0d65504712","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-05-13T13:33:13Z","pushed_at":"2016-05-13T15:09:35Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":129629,"stargazers_count":12311,"watchers_count":12311,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4830,"mirror_url":null,"open_issues_count":754,"forks":4830,"open_issues":754,"watchers":12311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18772"},"html":{"href":"https://github.com/symfony/symfony/pull/18772"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/18772"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/18772/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18772/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18772/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/5fefeac1c823765a5804345c6e1e0ee612742317"}}}}