{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments/55104598","id":55104598,"diff_hunk":"@@ -173,13 +173,15 @@ aws ec2 run-instances \\\n   --key-name mykey \\\n   --security-group-ids $SECURITY_GROUP_ID \\\n   --user-data file://<PATH_TO_CLOUD_CONFIG>/user-data-first\n-#  --subnet $SUBNET_ID \n+#  --subnet $SUBNET_ID\n #  Include the subnet param above if using a non-default VPC\n+\n+INSTANCE_ID_1=<InstanceId>","path":"docs/calico-with-docker/AWS.md","position":127,"original_position":127,"commit_id":"77b59bdafe8671cb14f1aa2935ef30257b3ee536","original_commit_id":"77b59bdafe8671cb14f1aa2935ef30257b3ee536","user":{"login":"matthewdupre","id":9053570,"avatar_url":"https://avatars.githubusercontent.com/u/9053570?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdupre","html_url":"https://github.com/matthewdupre","followers_url":"https://api.github.com/users/matthewdupre/followers","following_url":"https://api.github.com/users/matthewdupre/following{/other_user}","gists_url":"https://api.github.com/users/matthewdupre/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdupre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdupre/subscriptions","organizations_url":"https://api.github.com/users/matthewdupre/orgs","repos_url":"https://api.github.com/users/matthewdupre/repos","events_url":"https://api.github.com/users/matthewdupre/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdupre/received_events","type":"User","site_admin":false},"body":"TBH I'm not a fan of this syntax, I think having these additional steps just makes the doc longer (when the variables are generally used once), and people still have to copy the values around.  Every extra sentence in a doc reduces the chance that people will actually follow all the other ones by some tiny percentage, unmeasurable individually but very clear in aggregate.\r\n\r\nIf we want our docs to be shell scripts, then they should be shell scripts...","created_at":"2016-03-04T23:29:19Z","updated_at":"2016-03-04T23:29:19Z","html_url":"https://github.com/projectcalico/calico-containers/pull/843#discussion_r55104598","pull_request_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments/55104598"},"html":{"href":"https://github.com/projectcalico/calico-containers/pull/843#discussion_r55104598"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843","id":61650553,"html_url":"https://github.com/projectcalico/calico-containers/pull/843","diff_url":"https://github.com/projectcalico/calico-containers/pull/843.diff","patch_url":"https://github.com/projectcalico/calico-containers/pull/843.patch","issue_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/843","number":843,"state":"open","locked":false,"title":"Update AWS docs to use Disable Source/Dest. Check instead of IP-in-IP","user":{"login":"matthewdupre","id":9053570,"avatar_url":"https://avatars.githubusercontent.com/u/9053570?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdupre","html_url":"https://github.com/matthewdupre","followers_url":"https://api.github.com/users/matthewdupre/followers","following_url":"https://api.github.com/users/matthewdupre/following{/other_user}","gists_url":"https://api.github.com/users/matthewdupre/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdupre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdupre/subscriptions","organizations_url":"https://api.github.com/users/matthewdupre/orgs","repos_url":"https://api.github.com/users/matthewdupre/repos","events_url":"https://api.github.com/users/matthewdupre/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdupre/received_events","type":"User","site_admin":false},"body":"I think this covers all the relevant docs, but it's possible I've missed some (particularly if there's anything outside this repository).","created_at":"2016-03-04T00:42:16Z","updated_at":"2016-03-04T23:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80f862b02767cb3c733f0b7efe6ca4a44a83beb5","assignee":{"login":"TrimBiggs","id":1302077,"avatar_url":"https://avatars.githubusercontent.com/u/1302077?v=3","gravatar_id":"","url":"https://api.github.com/users/TrimBiggs","html_url":"https://github.com/TrimBiggs","followers_url":"https://api.github.com/users/TrimBiggs/followers","following_url":"https://api.github.com/users/TrimBiggs/following{/other_user}","gists_url":"https://api.github.com/users/TrimBiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/TrimBiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrimBiggs/subscriptions","organizations_url":"https://api.github.com/users/TrimBiggs/orgs","repos_url":"https://api.github.com/users/TrimBiggs/repos","events_url":"https://api.github.com/users/TrimBiggs/events{/privacy}","received_events_url":"https://api.github.com/users/TrimBiggs/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/843/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico-containers/statuses/77b59bdafe8671cb14f1aa2935ef30257b3ee536","head":{"label":"matthewdupre:aws-ipip","ref":"aws-ipip","sha":"77b59bdafe8671cb14f1aa2935ef30257b3ee536","user":{"login":"matthewdupre","id":9053570,"avatar_url":"https://avatars.githubusercontent.com/u/9053570?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdupre","html_url":"https://github.com/matthewdupre","followers_url":"https://api.github.com/users/matthewdupre/followers","following_url":"https://api.github.com/users/matthewdupre/following{/other_user}","gists_url":"https://api.github.com/users/matthewdupre/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdupre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdupre/subscriptions","organizations_url":"https://api.github.com/users/matthewdupre/orgs","repos_url":"https://api.github.com/users/matthewdupre/repos","events_url":"https://api.github.com/users/matthewdupre/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdupre/received_events","type":"User","site_admin":false},"repo":{"id":50355163,"name":"calico-containers","full_name":"matthewdupre/calico-containers","owner":{"login":"matthewdupre","id":9053570,"avatar_url":"https://avatars.githubusercontent.com/u/9053570?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdupre","html_url":"https://github.com/matthewdupre","followers_url":"https://api.github.com/users/matthewdupre/followers","following_url":"https://api.github.com/users/matthewdupre/following{/other_user}","gists_url":"https://api.github.com/users/matthewdupre/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdupre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdupre/subscriptions","organizations_url":"https://api.github.com/users/matthewdupre/orgs","repos_url":"https://api.github.com/users/matthewdupre/repos","events_url":"https://api.github.com/users/matthewdupre/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdupre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewdupre/calico-containers","description":"Project Calico deployed in a containerized environment","fork":true,"url":"https://api.github.com/repos/matthewdupre/calico-containers","forks_url":"https://api.github.com/repos/matthewdupre/calico-containers/forks","keys_url":"https://api.github.com/repos/matthewdupre/calico-containers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewdupre/calico-containers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewdupre/calico-containers/teams","hooks_url":"https://api.github.com/repos/matthewdupre/calico-containers/hooks","issue_events_url":"https://api.github.com/repos/matthewdupre/calico-containers/issues/events{/number}","events_url":"https://api.github.com/repos/matthewdupre/calico-containers/events","assignees_url":"https://api.github.com/repos/matthewdupre/calico-containers/assignees{/user}","branches_url":"https://api.github.com/repos/matthewdupre/calico-containers/branches{/branch}","tags_url":"https://api.github.com/repos/matthewdupre/calico-containers/tags","blobs_url":"https://api.github.com/repos/matthewdupre/calico-containers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewdupre/calico-containers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewdupre/calico-containers/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewdupre/calico-containers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewdupre/calico-containers/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewdupre/calico-containers/languages","stargazers_url":"https://api.github.com/repos/matthewdupre/calico-containers/stargazers","contributors_url":"https://api.github.com/repos/matthewdupre/calico-containers/contributors","subscribers_url":"https://api.github.com/repos/matthewdupre/calico-containers/subscribers","subscription_url":"https://api.github.com/repos/matthewdupre/calico-containers/subscription","commits_url":"https://api.github.com/repos/matthewdupre/calico-containers/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewdupre/calico-containers/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewdupre/calico-containers/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewdupre/calico-containers/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewdupre/calico-containers/contents/{+path}","compare_url":"https://api.github.com/repos/matthewdupre/calico-containers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewdupre/calico-containers/merges","archive_url":"https://api.github.com/repos/matthewdupre/calico-containers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewdupre/calico-containers/downloads","issues_url":"https://api.github.com/repos/matthewdupre/calico-containers/issues{/number}","pulls_url":"https://api.github.com/repos/matthewdupre/calico-containers/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewdupre/calico-containers/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewdupre/calico-containers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewdupre/calico-containers/labels{/name}","releases_url":"https://api.github.com/repos/matthewdupre/calico-containers/releases{/id}","deployments_url":"https://api.github.com/repos/matthewdupre/calico-containers/deployments","created_at":"2016-01-25T14:18:49Z","updated_at":"2016-01-25T14:18:50Z","pushed_at":"2016-03-04T20:09:40Z","git_url":"git://github.com/matthewdupre/calico-containers.git","ssh_url":"git@github.com:matthewdupre/calico-containers.git","clone_url":"https://github.com/matthewdupre/calico-containers.git","svn_url":"https://github.com/matthewdupre/calico-containers","homepage":"http://www.projectcalico.org","size":19638,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"c3e684615eda7eb2136ed60625eb93f2e93b5e5a","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":29629333,"name":"calico-containers","full_name":"projectcalico/calico-containers","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calico-containers","description":"Project Calico deployed in a containerized environment","fork":false,"url":"https://api.github.com/repos/projectcalico/calico-containers","forks_url":"https://api.github.com/repos/projectcalico/calico-containers/forks","keys_url":"https://api.github.com/repos/projectcalico/calico-containers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico-containers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico-containers/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico-containers/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico-containers/events","assignees_url":"https://api.github.com/repos/projectcalico/calico-containers/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico-containers/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico-containers/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico-containers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico-containers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico-containers/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico-containers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico-containers/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico-containers/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico-containers/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico-containers/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico-containers/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico-containers/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico-containers/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico-containers/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico-containers/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico-containers/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico-containers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico-containers/merges","archive_url":"https://api.github.com/repos/projectcalico/calico-containers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico-containers/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico-containers/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico-containers/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico-containers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico-containers/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico-containers/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calico-containers/deployments","created_at":"2015-01-21T23:46:47Z","updated_at":"2016-03-03T14:47:39Z","pushed_at":"2016-03-04T23:27:04Z","git_url":"git://github.com/projectcalico/calico-containers.git","ssh_url":"git@github.com:projectcalico/calico-containers.git","clone_url":"https://github.com/projectcalico/calico-containers.git","svn_url":"https://github.com/projectcalico/calico-containers","homepage":"http://www.projectcalico.org","size":20314,"stargazers_count":315,"watchers_count":315,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":58,"forks":67,"open_issues":58,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843"},"html":{"href":"https://github.com/projectcalico/calico-containers/pull/843"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico-containers/issues/843"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico-containers/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico-containers/statuses/77b59bdafe8671cb14f1aa2935ef30257b3ee536"}}}}