{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/83066449","pull_request_review_id":3930988,"id":83066449,"diff_hunk":"@@ -0,0 +1,147 @@\n+import {NgModule, Injector, NgZone, FactoryProvider, ComponentFactory, ComponentFactoryResolver} from '@angular/core';\n+import * as angular from './angular_js';\n+\n+// Temporary global location where the ng1Injector is stored during bootstrap\n+let tempGlobalNg1Injector: angular.IInjectorService = null;\n+\n+///////////////////////////////////\n+// START: ng1 service factories\n+// We must use exported named functions for the ng2 factories\n+// to keep the compiler happy:\n+// > Metadata collected contains an error that will be reported at runtime:\n+// >   Function calls are not supported.\n+// >   Consider replacing the function or lambda with a reference to an exported function\n+export function $injectorFactory() {\n+  return tempGlobalNg1Injector;\n+}\n+export function $rootScopeFactory(i: angular.IInjectorService) {\n+  return i.get('$rootScope');\n+}\n+export function $compileFactory(i: angular.IInjectorService) {\n+  return i.get('$compile');\n+}\n+// END: ng1 service factories\n+///////////////////////////////////\n+\n+\n+/**\n+ * UpgradeModule is the base class for the module that will contain all the\n+ * information about what Angular providers and component are to be bridged\n+ * between Angular 1 and Angular 2+\n+ */\n+@NgModule({\n+  providers: [\n+    { provide: '$injector', useFactory: $injectorFactory },\n+    { provide: '$rootScope', useFactory: $rootScopeFactory, deps: ['$injector']},\n+    { provide: '$compile', useFactory: $compileFactory, deps: ['$injector']}","path":"modules/@angular/upgrade/src/upgrade_module.ts","position":36,"original_position":36,"commit_id":"8f766f8f3fc5c72ff15c1f2f4a947135374980ba","original_commit_id":"8f766f8f3fc5c72ff15c1f2f4a947135374980ba","user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"Should we re-export all of the `$*` items?","created_at":"2016-10-12T18:16:17Z","updated_at":"2016-10-12T18:16:17Z","html_url":"https://github.com/angular/angular/pull/12239#discussion_r83066449","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/12239","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/83066449"},"html":{"href":"https://github.com/angular/angular/pull/12239#discussion_r83066449"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/12239"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/12239","id":89018480,"html_url":"https://github.com/angular/angular/pull/12239","diff_url":"https://github.com/angular/angular/pull/12239.diff","patch_url":"https://github.com/angular/angular/pull/12239.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/12239","number":12239,"state":"open","locked":false,"title":"Ngupgrade aot","user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [ ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[ ] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\n\r\n\r\n**What is the new behavior?**\r\n\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[ ] No\r\n```\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\n","created_at":"2016-10-12T13:44:01Z","updated_at":"2016-10-12T18:41:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c86adf9cef0caac91fb159381d4459e14e9cf87f","assignee":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"assignees":[{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/12239/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/12239/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/12239/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/8f766f8f3fc5c72ff15c1f2f4a947135374980ba","head":{"label":"petebacondarwin:ngupgrade-aot","ref":"ngupgrade-aot","sha":"8f766f8f3fc5c72ff15c1f2f4a947135374980ba","user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"repo":{"id":27181953,"name":"angular","full_name":"petebacondarwin/angular","owner":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petebacondarwin/angular","description":"","fork":true,"url":"https://api.github.com/repos/petebacondarwin/angular","forks_url":"https://api.github.com/repos/petebacondarwin/angular/forks","keys_url":"https://api.github.com/repos/petebacondarwin/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petebacondarwin/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petebacondarwin/angular/teams","hooks_url":"https://api.github.com/repos/petebacondarwin/angular/hooks","issue_events_url":"https://api.github.com/repos/petebacondarwin/angular/issues/events{/number}","events_url":"https://api.github.com/repos/petebacondarwin/angular/events","assignees_url":"https://api.github.com/repos/petebacondarwin/angular/assignees{/user}","branches_url":"https://api.github.com/repos/petebacondarwin/angular/branches{/branch}","tags_url":"https://api.github.com/repos/petebacondarwin/angular/tags","blobs_url":"https://api.github.com/repos/petebacondarwin/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petebacondarwin/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petebacondarwin/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/petebacondarwin/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petebacondarwin/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/petebacondarwin/angular/languages","stargazers_url":"https://api.github.com/repos/petebacondarwin/angular/stargazers","contributors_url":"https://api.github.com/repos/petebacondarwin/angular/contributors","subscribers_url":"https://api.github.com/repos/petebacondarwin/angular/subscribers","subscription_url":"https://api.github.com/repos/petebacondarwin/angular/subscription","commits_url":"https://api.github.com/repos/petebacondarwin/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/petebacondarwin/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/petebacondarwin/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/petebacondarwin/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/petebacondarwin/angular/contents/{+path}","compare_url":"https://api.github.com/repos/petebacondarwin/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petebacondarwin/angular/merges","archive_url":"https://api.github.com/repos/petebacondarwin/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petebacondarwin/angular/downloads","issues_url":"https://api.github.com/repos/petebacondarwin/angular/issues{/number}","pulls_url":"https://api.github.com/repos/petebacondarwin/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/petebacondarwin/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/petebacondarwin/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petebacondarwin/angular/labels{/name}","releases_url":"https://api.github.com/repos/petebacondarwin/angular/releases{/id}","deployments_url":"https://api.github.com/repos/petebacondarwin/angular/deployments","created_at":"2014-11-26T15:01:46Z","updated_at":"2014-11-26T15:01:46Z","pushed_at":"2016-10-12T18:10:05Z","git_url":"git://github.com/petebacondarwin/angular.git","ssh_url":"git@github.com:petebacondarwin/angular.git","clone_url":"https://github.com/petebacondarwin/angular.git","svn_url":"https://github.com/petebacondarwin/angular","homepage":null,"size":29935,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"17e3410d986d1d24dff0c4075ba3c82f9aedc89e","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-10-12T18:14:08Z","pushed_at":"2016-10-12T18:38:29Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":647078,"stargazers_count":17189,"watchers_count":17189,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4356,"mirror_url":null,"open_issues_count":853,"forks":4356,"open_issues":853,"watchers":17189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/12239"},"html":{"href":"https://github.com/angular/angular/pull/12239"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/12239"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/12239/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/12239/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/12239/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/8f766f8f3fc5c72ff15c1f2f4a947135374980ba"}}}}
{"actor":{"display_login":"mhevery"}}