{"action":"created","issue":{"url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt/issues/41","repository_url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt","labels_url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt/issues/41/comments","events_url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt/issues/41/events","html_url":"https://github.com/PetroleumCyberneticsGroup/FieldOpt/pull/41","id":163057379,"number":41,"title":"Feature/implementing oneoff runner wed 20160629","user":{"login":"Bellout","id":7349603,"avatar_url":"https://avatars.githubusercontent.com/u/7349603?v=3","gravatar_id":"","url":"https://api.github.com/users/Bellout","html_url":"https://github.com/Bellout","followers_url":"https://api.github.com/users/Bellout/followers","following_url":"https://api.github.com/users/Bellout/following{/other_user}","gists_url":"https://api.github.com/users/Bellout/gists{/gist_id}","starred_url":"https://api.github.com/users/Bellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bellout/subscriptions","organizations_url":"https://api.github.com/users/Bellout/orgs","repos_url":"https://api.github.com/users/Bellout/repos","events_url":"https://api.github.com/users/Bellout/events{/privacy}","received_events_url":"https://api.github.com/users/Bellout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-30T00:33:30Z","updated_at":"2016-06-30T07:35:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt/pulls/41","html_url":"https://github.com/PetroleumCyberneticsGroup/FieldOpt/pull/41","diff_url":"https://github.com/PetroleumCyberneticsGroup/FieldOpt/pull/41.diff","patch_url":"https://github.com/PetroleumCyberneticsGroup/FieldOpt/pull/41.patch"},"body":"Some editing of verbosity output of runtime settings. Verbosity messages are now embedded within each option paragraph, and often come just before runtime error check, since then we can see what we have input before the error is thrown. \r\n\r\nThe option paragraphs can still be reordered to make it nicer, but works well for debugging now.\r\n\r\nStill to-do: verbosity levels. (Is is just a matter of changing the verbose_ variable to int?)"},"comment":{"url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt/issues/comments/229582551","html_url":"https://github.com/PetroleumCyberneticsGroup/FieldOpt/pull/41#issuecomment-229582551","issue_url":"https://api.github.com/repos/PetroleumCyberneticsGroup/FieldOpt/issues/41","id":229582551,"user":{"login":"einar90","id":3439573,"avatar_url":"https://avatars.githubusercontent.com/u/3439573?v=3","gravatar_id":"","url":"https://api.github.com/users/einar90","html_url":"https://github.com/einar90","followers_url":"https://api.github.com/users/einar90/followers","following_url":"https://api.github.com/users/einar90/following{/other_user}","gists_url":"https://api.github.com/users/einar90/gists{/gist_id}","starred_url":"https://api.github.com/users/einar90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/einar90/subscriptions","organizations_url":"https://api.github.com/users/einar90/orgs","repos_url":"https://api.github.com/users/einar90/repos","events_url":"https://api.github.com/users/einar90/events{/privacy}","received_events_url":"https://api.github.com/users/einar90/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T07:35:16Z","updated_at":"2016-06-30T07:35:16Z","body":"The logging in the serial runner is okay, and I agree with turning `verbose_` into an `int`, but I dont like the changes in verbosity logging for the runtime settings.\r\n\r\n- If an error is detected when setting the runtime settings, an exception is thrown and information about the error that occurred is shown. If there's an error, it needs to be fixed before the other information is at all relevant, so logging before all the settings have been shown does not add ease debugging.\r\n- It unnecessarily clutters the code that does the actual work.\r\n- It adds more than verbose checks where previously there was only one.\r\n- It makes it more difficult to see will be shown in the terminal (which properties in which format)."}}
{"actor":{"display_login":"einar90"}}