{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/8732","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/8732/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8732/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/8732/events","html_url":"https://github.com/xbmc/xbmc/pull/8732","id":124549438,"number":8732,"title":"[PVR] Echo up important Status info to Timer Rules","user":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Krypton","name":"Krypton","color":"fbca04"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/PVR","name":"PVR","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-01-01T16:24:06Z","updated_at":"2016-01-03T20:54:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8732","html_url":"https://github.com/xbmc/xbmc/pull/8732","diff_url":"https://github.com/xbmc/xbmc/pull/8732.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8732.patch"},"body":" - Number of 'Will Record' Child Timers\r\n - Presence of InProg Child Timers\r\n - Presence of Conflict_NOK or Error Child Timers\r\n\r\nAlso adds 'Completed' status as distinct from 'Enabled'\r\n![screenshot037](https://cloud.githubusercontent.com/assets/12870817/12071357/93f10002-b09f-11e5-93b2-eef4388a54db.png)\r\n\r\nNo sure how this will play with all existing pvr clients, but I can't see it breaking anything.\r\nSmall tweaks may need to be made to the reported status of 'Timer Rules' in each client to get it to work fully as intended. I'm hoping the logic is sound so it should just 'work'.\r\n\r\nIf a client already echos up 'Conflict / Error / Recording' status the behaviour should be unchanged. \r\nOnly a status of 'NEW' or 'SCHEDULED' and in the case of recording in prog, 'COMPLETED' will be replaced with the new information based on child timer states.\r\n(I made some changes to pvr.mythtv to get 'COMPLETED' to work as shown which I will PR if this is accepted)\r\n\r\nI'm a little uncomfortable about putting the child timer status reset in CPVRTimerInfoTag::UpdateEntry and the updates in CPVRTimers::UpdateEntries. Happy to move it all to CPVRTimers::UpdateEntries if there are strong opinions.\r\n\r\npings: @ksooo, @ryangribble, @janbar, @jalle19"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/168540223","html_url":"https://github.com/xbmc/xbmc/pull/8732#issuecomment-168540223","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8732","id":168540223,"user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"created_at":"2016-01-03T20:54:43Z","updated_at":"2016-01-03T20:54:43Z","body":"You're welcome and thanks for this nice improvement."}}