{"action":"created","issue":{"url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/issues/202","repository_url":"https://api.github.com/repos/yiisoft/yii2-app-advanced","labels_url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/issues/202/comments","events_url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/issues/202/events","html_url":"https://github.com/yiisoft/yii2-app-advanced/issues/202","id":177985809,"number":202,"title":"Codeception rules in root .gitignore can be removed & typo in frontend acceptance tests ","user":{"login":"Coksnuss","id":3457747,"avatar_url":"https://avatars.githubusercontent.com/u/3457747?v=3","gravatar_id":"","url":"https://api.github.com/users/Coksnuss","html_url":"https://github.com/Coksnuss","followers_url":"https://api.github.com/users/Coksnuss/followers","following_url":"https://api.github.com/users/Coksnuss/following{/other_user}","gists_url":"https://api.github.com/users/Coksnuss/gists{/gist_id}","starred_url":"https://api.github.com/users/Coksnuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coksnuss/subscriptions","organizations_url":"https://api.github.com/users/Coksnuss/orgs","repos_url":"https://api.github.com/users/Coksnuss/repos","events_url":"https://api.github.com/users/Coksnuss/events{/privacy}","received_events_url":"https://api.github.com/users/Coksnuss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/milestones/7","html_url":"https://github.com/yiisoft/yii2-app-advanced/milestones/2.0.10","labels_url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/milestones/7/labels","id":1736859,"number":7,"title":"2.0.10","description":"","creator":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":11,"state":"open","created_at":"2016-04-28T16:27:14Z","updated_at":"2016-09-20T08:21:15Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-09-20T07:30:19Z","updated_at":"2016-09-20T08:48:08Z","closed_at":null,"body":"I believe the bottom lines([1]) in `.gitignore` inside the project root directory can be removed as these rules do already exist in separate nested `.gitignore` files([2],[3],[4]) and it would also be more consistent with the existing rules in that file (which only ignore files and directories within the root directory).\r\nFurthermore it lowers the error potential when adding a new module (by copying an existing one) as `.gitignore` does not need any adaption.\r\n\r\n// EDIT:\r\nThe `acceptance.suite.yml.example` file has a typo([5]) on line 8 which causes the test suite to fail (`WebDriver module conflicts with Yii2`)\r\nacceptance.suite.yml.example:\r\n```yaml\r\n        - Yii2:\r\n            parts: init\r\n```\r\nshould be:\r\n```yaml\r\n        - Yii2:\r\n            part: init\r\n```\r\n\r\n// EDIT 2:\r\nAlso the namespace of HomeCest.php inside frontend/tests should be adapted from\r\n`namespace tests\\frontend\\acceptance;` to `namespace frontend\\tests\\acceptance;` as well as the use statement from `use tests\\frontend\\AcceptanceTester;` to `use frontend\\tests\\AcceptanceTester;`\r\n\r\n[1]: https://github.com/yiisoft/yii2-app-advanced/blob/master/.gitignore#L35-L38\r\n[2]: https://github.com/yiisoft/yii2-app-advanced/blob/master/common/tests/_support/.gitignore#L1\r\n[3]: https://github.com/yiisoft/yii2-app-advanced/blob/master/frontend/tests/_support/.gitignore#L1\r\n[4]: https://github.com/yiisoft/yii2-app-advanced/blob/master/backend/tests/_support/.gitignore#L1\r\n[5]: https://github.com/yiisoft/yii2-app-advanced/blob/master/frontend/tests/acceptance.suite.yml.example#L8"},"comment":{"url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/issues/comments/248241805","html_url":"https://github.com/yiisoft/yii2-app-advanced/issues/202#issuecomment-248241805","issue_url":"https://api.github.com/repos/yiisoft/yii2-app-advanced/issues/202","id":248241805,"user":{"login":"Coksnuss","id":3457747,"avatar_url":"https://avatars.githubusercontent.com/u/3457747?v=3","gravatar_id":"","url":"https://api.github.com/users/Coksnuss","html_url":"https://github.com/Coksnuss","followers_url":"https://api.github.com/users/Coksnuss/followers","following_url":"https://api.github.com/users/Coksnuss/following{/other_user}","gists_url":"https://api.github.com/users/Coksnuss/gists{/gist_id}","starred_url":"https://api.github.com/users/Coksnuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coksnuss/subscriptions","organizations_url":"https://api.github.com/users/Coksnuss/orgs","repos_url":"https://api.github.com/users/Coksnuss/repos","events_url":"https://api.github.com/users/Coksnuss/events{/privacy}","received_events_url":"https://api.github.com/users/Coksnuss/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T08:48:08Z","updated_at":"2016-09-20T08:48:08Z","body":"I believe there is another inconsistency related to the reorganisation of the tests:\r\nThe file `yii2-app-advanced/common/config/test-local.php` should not be part of the repository but rather belongs into `yii2-app-advanced/environments/(prod|dev)/common/config/` respectively.\r\nFurthermore the contents of `config/test-local.php` and `config/test.php` should be switched. The db configuration belongs to the `test-local.php` file whereas the user component configuration belongs into the `test.php` file"}}
{"actor":{"display_login":"Coksnuss"}}