{"action":"created","issue":{"url":"https://api.github.com/repos/portier/portier-broker/issues/121","repository_url":"https://api.github.com/repos/portier/portier-broker","labels_url":"https://api.github.com/repos/portier/portier-broker/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/portier/portier-broker/issues/121/comments","events_url":"https://api.github.com/repos/portier/portier-broker/issues/121/events","html_url":"https://github.com/portier/portier-broker/pull/121","id":192327883,"number":121,"title":"Add a metadata block and a `valid_from` to keys.","user":{"login":"stephank","id":89950,"avatar_url":"https://avatars.githubusercontent.com/u/89950?v=3","gravatar_id":"","url":"https://api.github.com/users/stephank","html_url":"https://github.com/stephank","followers_url":"https://api.github.com/users/stephank/followers","following_url":"https://api.github.com/users/stephank/following{/other_user}","gists_url":"https://api.github.com/users/stephank/gists{/gist_id}","starred_url":"https://api.github.com/users/stephank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephank/subscriptions","organizations_url":"https://api.github.com/users/stephank/orgs","repos_url":"https://api.github.com/users/stephank/repos","events_url":"https://api.github.com/users/stephank/events{/privacy}","received_events_url":"https://api.github.com/users/stephank/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-29T16:20:13Z","updated_at":"2016-11-29T16:24:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/portier/portier-broker/pulls/121","html_url":"https://github.com/portier/portier-broker/pull/121","diff_url":"https://github.com/portier/portier-broker/pull/121.diff","patch_url":"https://github.com/portier/portier-broker/pull/121.patch"},"body":"This PR changes the output of config errors a bit, and we now fail when the keys could not be parsed. Example error:\r\n\r\n```\r\n$ cargo run -- ./config.toml\r\nFailed to build configuration: failed to parse key 'private.pem': An error in the OpenSSL library: bad base64 decode\r\n```\r\n\r\nBut the main purpose here is to add metadata to keys, with for now just a `valid_from`. This field is to facilitate key rotation, where we need to have a grace period during which we introduce the new key, but don't use it yet. This grace period allows clients with a cached keys document to keep functioning."},"comment":{"url":"https://api.github.com/repos/portier/portier-broker/issues/comments/263619131","html_url":"https://github.com/portier/portier-broker/pull/121#issuecomment-263619131","issue_url":"https://api.github.com/repos/portier/portier-broker/issues/121","id":263619131,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T16:24:05Z","updated_at":"2016-11-29T16:24:05Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9046050/badge)](https://coveralls.io/builds/9046050)\n\nChanges Unknown when pulling **ce899b852054b1e50071ab620407f09bf50be356 on featureRotateKeys** into ** on master**.\n"}}
{"actor":{"display_login":"coveralls"}}