{"action":"opened","number":197,"pull_request":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/197","id":85341669,"html_url":"https://github.com/rabbitmq/rabbitmq-java-client/pull/197","diff_url":"https://github.com/rabbitmq/rabbitmq-java-client/pull/197.diff","patch_url":"https://github.com/rabbitmq/rabbitmq-java-client/pull/197.patch","issue_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/issues/197","number":197,"state":"open","locked":false,"title":"Recovery related changes","user":{"login":"vikinghawk","id":11447323,"avatar_url":"https://avatars.githubusercontent.com/u/11447323?v=3","gravatar_id":"","url":"https://api.github.com/users/vikinghawk","html_url":"https://github.com/vikinghawk","followers_url":"https://api.github.com/users/vikinghawk/followers","following_url":"https://api.github.com/users/vikinghawk/following{/other_user}","gists_url":"https://api.github.com/users/vikinghawk/gists{/gist_id}","starred_url":"https://api.github.com/users/vikinghawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikinghawk/subscriptions","organizations_url":"https://api.github.com/users/vikinghawk/orgs","repos_url":"https://api.github.com/users/vikinghawk/repos","events_url":"https://api.github.com/users/vikinghawk/events{/privacy}","received_events_url":"https://api.github.com/users/vikinghawk/received_events","type":"User","site_admin":false},"body":"This PR contains some changes related to recovery. Note i cleaned up a bunch of compiler warnings by adding the missing Override tags on methods. I can submit another PR without those changes if you guys would prefer.\r\n\r\nNon-cosmetic changes are in AutorecoveringConnection and AutorecoveringChannel.\r\n\r\nFixes:\r\n1) fixes a NPE that can occur when a thread attempts to create a new channel after a connection has been recovered but before channel recovery has completed. More details of issue at https://groups.google.com/forum/#!topic/rabbitmq-users/7P5fYQLLP6g. Fixes the NPE in AutorecoveringChannel, but then also changed the AutorecoveryingConnection to not set the connection delegate until channel recovery is complete. This allows channel recovery to complete without error at the expense of the separate thread attempting to create a new channel of getting an AlreadyClosedException because it would happen on the old delegate.\r\n\r\nOther changes:\r\n1) Added a check in recoverQueues() that skips over all the queue name change logic if the name remained the same.","created_at":"2016-09-15T03:49:24Z","updated_at":"2016-09-15T03:49:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/197/commits","review_comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/197/comments","review_comment_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/issues/197/comments","statuses_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/statuses/a54abfc05f5e685a1d0bfb65f48535b23a8d0ad8","head":{"label":"vikinghawk:master","ref":"master","sha":"a54abfc05f5e685a1d0bfb65f48535b23a8d0ad8","user":{"login":"vikinghawk","id":11447323,"avatar_url":"https://avatars.githubusercontent.com/u/11447323?v=3","gravatar_id":"","url":"https://api.github.com/users/vikinghawk","html_url":"https://github.com/vikinghawk","followers_url":"https://api.github.com/users/vikinghawk/followers","following_url":"https://api.github.com/users/vikinghawk/following{/other_user}","gists_url":"https://api.github.com/users/vikinghawk/gists{/gist_id}","starred_url":"https://api.github.com/users/vikinghawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikinghawk/subscriptions","organizations_url":"https://api.github.com/users/vikinghawk/orgs","repos_url":"https://api.github.com/users/vikinghawk/repos","events_url":"https://api.github.com/users/vikinghawk/events{/privacy}","received_events_url":"https://api.github.com/users/vikinghawk/received_events","type":"User","site_admin":false},"repo":{"id":67661986,"name":"rabbitmq-java-client","full_name":"vikinghawk/rabbitmq-java-client","owner":{"login":"vikinghawk","id":11447323,"avatar_url":"https://avatars.githubusercontent.com/u/11447323?v=3","gravatar_id":"","url":"https://api.github.com/users/vikinghawk","html_url":"https://github.com/vikinghawk","followers_url":"https://api.github.com/users/vikinghawk/followers","following_url":"https://api.github.com/users/vikinghawk/following{/other_user}","gists_url":"https://api.github.com/users/vikinghawk/gists{/gist_id}","starred_url":"https://api.github.com/users/vikinghawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikinghawk/subscriptions","organizations_url":"https://api.github.com/users/vikinghawk/orgs","repos_url":"https://api.github.com/users/vikinghawk/repos","events_url":"https://api.github.com/users/vikinghawk/events{/privacy}","received_events_url":"https://api.github.com/users/vikinghawk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vikinghawk/rabbitmq-java-client","description":"RabbitMQ Java client","fork":true,"url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client","forks_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/forks","keys_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/teams","hooks_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/hooks","issue_events_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/events","assignees_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/tags","blobs_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/languages","stargazers_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/stargazers","contributors_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/contributors","subscribers_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/subscribers","subscription_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/subscription","commits_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/merges","archive_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/downloads","issues_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/labels{/name}","releases_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/vikinghawk/rabbitmq-java-client/deployments","created_at":"2016-09-08T02:42:42Z","updated_at":"2016-09-08T02:42:48Z","pushed_at":"2016-09-14T21:32:03Z","git_url":"git://github.com/vikinghawk/rabbitmq-java-client.git","ssh_url":"git@github.com:vikinghawk/rabbitmq-java-client.git","clone_url":"https://github.com/vikinghawk/rabbitmq-java-client.git","svn_url":"https://github.com/vikinghawk/rabbitmq-java-client","homepage":"https://www.rabbitmq.com/","size":29670,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rabbitmq:master","ref":"master","sha":"8374f588ff0efdab4956024a985a9adf68aedd37","user":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"repo":{"id":924572,"name":"rabbitmq-java-client","full_name":"rabbitmq/rabbitmq-java-client","owner":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rabbitmq/rabbitmq-java-client","description":"RabbitMQ Java client","fork":false,"url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client","forks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/forks","keys_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/teams","hooks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/hooks","issue_events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/events","assignees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/tags","blobs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/languages","stargazers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/stargazers","contributors_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/contributors","subscribers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/subscribers","subscription_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/subscription","commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/merges","archive_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/downloads","issues_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/labels{/name}","releases_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/deployments","created_at":"2010-09-20T10:43:18Z","updated_at":"2016-09-09T03:31:09Z","pushed_at":"2016-09-14T16:24:32Z","git_url":"git://github.com/rabbitmq/rabbitmq-java-client.git","ssh_url":"git@github.com:rabbitmq/rabbitmq-java-client.git","clone_url":"https://github.com/rabbitmq/rabbitmq-java-client.git","svn_url":"https://github.com/rabbitmq/rabbitmq-java-client","homepage":"https://www.rabbitmq.com/","size":32662,"stargazers_count":234,"watchers_count":234,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":9,"forks":160,"open_issues":9,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/197"},"html":{"href":"https://github.com/rabbitmq/rabbitmq-java-client/pull/197"},"issue":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/issues/197"},"comments":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-java-client/statuses/a54abfc05f5e685a1d0bfb65f48535b23a8d0ad8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":417,"deletions":92,"changed_files":45}}
{"actor":{"display_login":"vikinghawk"}}