{"action":"created","issue":{"url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12","repository_url":"https://api.github.com/repos/feedhenry/grunt-fh-build","labels_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12/comments","events_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12/events","html_url":"https://github.com/feedhenry/grunt-fh-build/pull/12","id":141664898,"number":12,"title":"[RHMAP-5128] Change grunt-fh-build to use ESLint instead of JSHint","user":{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars.githubusercontent.com/u/1294893?v=3","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-17T18:15:46Z","updated_at":"2016-03-18T09:44:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/12","html_url":"https://github.com/feedhenry/grunt-fh-build/pull/12","diff_url":"https://github.com/feedhenry/grunt-fh-build/pull/12.diff","patch_url":"https://github.com/feedhenry/grunt-fh-build/pull/12.patch"},"body":"Also removed `plato` since AFAIK `eslint` has a builtin rule for complexity.\r\n\r\nI have a question: why do we target the `lib/` and `bin/` directories specifically? on `fh-fhc` for instance we have a lot of small rule violations inside `test/`, for instance. I tried changing the target configuration to `['**/*.js']` but the task broke for some reason.\r\n\r\nI've also tried creating another variation of the task like `grunt eslint:fix`, but I think it would always run alongside the main task, and we should probably run `eslint --fix` straight from the cli anyways.\r\n\r\nI've bumped the minor in this PR, since it's kind of a breaking change. I'll also squash the commits before merging.\r\n\r\nping @jasonmadigan, @wei-lee, @wtrocki, @ziccardi, @odra"},"comment":{"url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/comments/198282480","html_url":"https://github.com/feedhenry/grunt-fh-build/pull/12#issuecomment-198282480","issue_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12","id":198282480,"user":{"login":"grdryn","id":442386,"avatar_url":"https://avatars.githubusercontent.com/u/442386?v=3","gravatar_id":"","url":"https://api.github.com/users/grdryn","html_url":"https://github.com/grdryn","followers_url":"https://api.github.com/users/grdryn/followers","following_url":"https://api.github.com/users/grdryn/following{/other_user}","gists_url":"https://api.github.com/users/grdryn/gists{/gist_id}","starred_url":"https://api.github.com/users/grdryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grdryn/subscriptions","organizations_url":"https://api.github.com/users/grdryn/orgs","repos_url":"https://api.github.com/users/grdryn/repos","events_url":"https://api.github.com/users/grdryn/events{/privacy}","received_events_url":"https://api.github.com/users/grdryn/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T09:44:56Z","updated_at":"2016-03-18T09:44:56Z","body":"Like @wtrocki says, these changes will require changes in jenkins-bob-builder also, to make sure that jshint and plato steps are removed.\r\n\r\n@wtrocki I don't think adding any framework support is necessary: I think we could update all projects in jenkins-bob-builder, then leave jshint and plato options here, rather than removing them. What do you think? Would framework support still be necessary? I think ideally we don't have two things that do the same thing for too long.\r\n\r\nAlso, would we be able to identify which projects could need builds of older versions, and of those, which depend on jshint or plato (and how strong of a dependency this is)? If an old version of something gets a hotfix, what job config will it use, the old version or the latest version? I think the latest version but I could be wrong. Either way, depending on the version matcher for grunt-fh-build in the package.json of the older module version, do we know which version of this plugin will be pulled in? (this reminds me, if this PR is removing functionality, it should bump major! :))"}}