{"action":"created","issue":{"url":"https://api.github.com/repos/novoda/spikes/issues/107","repository_url":"https://api.github.com/repos/novoda/spikes","labels_url":"https://api.github.com/repos/novoda/spikes/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/novoda/spikes/issues/107/comments","events_url":"https://api.github.com/repos/novoda/spikes/issues/107/events","html_url":"https://github.com/novoda/spikes/pull/107","id":161236107,"number":107,"title":"Draw bubble backgrounds manually","user":{"login":"JozefCeluch","id":1104656,"avatar_url":"https://avatars.githubusercontent.com/u/1104656?v=3","gravatar_id":"","url":"https://api.github.com/users/JozefCeluch","html_url":"https://github.com/JozefCeluch","followers_url":"https://api.github.com/users/JozefCeluch/followers","following_url":"https://api.github.com/users/JozefCeluch/following{/other_user}","gists_url":"https://api.github.com/users/JozefCeluch/gists{/gist_id}","starred_url":"https://api.github.com/users/JozefCeluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JozefCeluch/subscriptions","organizations_url":"https://api.github.com/users/JozefCeluch/orgs","repos_url":"https://api.github.com/users/JozefCeluch/repos","events_url":"https://api.github.com/users/JozefCeluch/events{/privacy}","received_events_url":"https://api.github.com/users/JozefCeluch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/novoda/spikes/labels/pt-firebase","name":"pt-firebase","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-20T16:22:07Z","updated_at":"2016-06-21T13:32:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/novoda/spikes/pulls/107","html_url":"https://github.com/novoda/spikes/pull/107","diff_url":"https://github.com/novoda/spikes/pull/107.diff","patch_url":"https://github.com/novoda/spikes/pull/107.patch"},"body":"#### Problem\r\n\r\nDrawable XMLs that we use for backgrounds are not drawn correctly on SDK version smaller than 23. \r\n\r\nThe weight/height attributes of items in the layer-list are ignored and the items are stretched to match the parent size. This made it impossible to create small circles in the message layout and the welcome/login screen layouts.\r\n\r\n#### Solution\r\n\r\nRemove the XML drawables and draw the backgrounds directly in the onDraw method of the custom views.\r\n\r\n#### Screenshots \r\n\r\n| Before | After |\r\n| --- | --- |\r\n| ![login_before](https://cloud.githubusercontent.com/assets/1104656/16201830/fc5c3188-370a-11e6-9c19-6471c0d11387.png) | ![login_after](https://cloud.githubusercontent.com/assets/1104656/16201870/28de44b2-370b-11e6-86d8-f2a8c73708e1.png) |\r\n| ![message_before](https://cloud.githubusercontent.com/assets/1104656/16201877/325b2492-370b-11e6-87e2-63fb323132cf.png) | ![message_after](https://cloud.githubusercontent.com/assets/1104656/16201912/5f8e6de8-370b-11e6-80b9-c1b3970754f6.png) |\r\n"},"comment":{"url":"https://api.github.com/repos/novoda/spikes/issues/comments/227440424","html_url":"https://github.com/novoda/spikes/pull/107#issuecomment-227440424","issue_url":"https://api.github.com/repos/novoda/spikes/issues/107","id":227440424,"user":{"login":"rock3r","id":153802,"avatar_url":"https://avatars.githubusercontent.com/u/153802?v=3","gravatar_id":"","url":"https://api.github.com/users/rock3r","html_url":"https://github.com/rock3r","followers_url":"https://api.github.com/users/rock3r/followers","following_url":"https://api.github.com/users/rock3r/following{/other_user}","gists_url":"https://api.github.com/users/rock3r/gists{/gist_id}","starred_url":"https://api.github.com/users/rock3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock3r/subscriptions","organizations_url":"https://api.github.com/users/rock3r/orgs","repos_url":"https://api.github.com/users/rock3r/repos","events_url":"https://api.github.com/users/rock3r/events{/privacy}","received_events_url":"https://api.github.com/users/rock3r/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T13:32:41Z","updated_at":"2016-06-21T13:32:41Z","body":"I think it'd be way easier to create a `BubbleDrawable` instead, and use that for BGs..."}}
{"actor":{"display_login":"rock3r"}}