{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/82404469","pull_request_review_id":3316383,"id":82404469,"diff_hunk":"@@ -102,6 +102,11 @@ func PodManifestPath(root string) string {\n \treturn filepath.Join(root, \"pod\")\n }\n \n+// PodManifestLockPath returns the path in root to the Pod Manifest lock file\n+func PodManifestLockPath(root string) string {","path":"common/common.go","position":5,"original_position":5,"commit_id":"56a14e26c648a413ca1b58debffab96db0940982","original_commit_id":"56a14e26c648a413ca1b58debffab96db0940982","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"body":"We are `os.Rename`ing the original pod manifest file to make the change atomic, hence we need a different lock file (or directory). Wondering were to document this fact though ... I'll do it here, and in the lifecycle document.","created_at":"2016-10-07T14:50:38Z","updated_at":"2016-10-07T14:50:38Z","html_url":"https://github.com/coreos/rkt/pull/3255#discussion_r82404469","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/3255","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/82404469"},"html":{"href":"https://github.com/coreos/rkt/pull/3255#discussion_r82404469"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3255"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/3255","id":87878369,"html_url":"https://github.com/coreos/rkt/pull/3255","diff_url":"https://github.com/coreos/rkt/pull/3255.diff","patch_url":"https://github.com/coreos/rkt/pull/3255.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/3255","number":3255,"state":"open","locked":false,"title":"cri: synchronize app add/rm operations","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"body":"Fixes #3259","created_at":"2016-10-04T11:45:25Z","updated_at":"2016-10-07T14:50:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"841577b7ede928150b7e7a9bff2b3a103fb8c014","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/51","html_url":"https://github.com/coreos/rkt/milestones/v1.17.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/51/labels","id":1981766,"number":51,"title":"v1.17.0","description":"","creator":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":10,"state":"open","created_at":"2016-09-03T19:29:22Z","updated_at":"2016-10-07T14:36:45Z","due_on":"2016-10-13T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/3255/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/3255/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/3255/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/56a14e26c648a413ca1b58debffab96db0940982","head":{"label":"s-urbaniak:cri-sync","ref":"cri-sync","sha":"56a14e26c648a413ca1b58debffab96db0940982","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"repo":{"id":55501235,"name":"rkt","full_name":"s-urbaniak/rkt","owner":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-urbaniak/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/s-urbaniak/rkt","forks_url":"https://api.github.com/repos/s-urbaniak/rkt/forks","keys_url":"https://api.github.com/repos/s-urbaniak/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-urbaniak/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-urbaniak/rkt/teams","hooks_url":"https://api.github.com/repos/s-urbaniak/rkt/hooks","issue_events_url":"https://api.github.com/repos/s-urbaniak/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/s-urbaniak/rkt/events","assignees_url":"https://api.github.com/repos/s-urbaniak/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/s-urbaniak/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/s-urbaniak/rkt/tags","blobs_url":"https://api.github.com/repos/s-urbaniak/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-urbaniak/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-urbaniak/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-urbaniak/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-urbaniak/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/s-urbaniak/rkt/languages","stargazers_url":"https://api.github.com/repos/s-urbaniak/rkt/stargazers","contributors_url":"https://api.github.com/repos/s-urbaniak/rkt/contributors","subscribers_url":"https://api.github.com/repos/s-urbaniak/rkt/subscribers","subscription_url":"https://api.github.com/repos/s-urbaniak/rkt/subscription","commits_url":"https://api.github.com/repos/s-urbaniak/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-urbaniak/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-urbaniak/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-urbaniak/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-urbaniak/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/s-urbaniak/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-urbaniak/rkt/merges","archive_url":"https://api.github.com/repos/s-urbaniak/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-urbaniak/rkt/downloads","issues_url":"https://api.github.com/repos/s-urbaniak/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/s-urbaniak/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/s-urbaniak/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/s-urbaniak/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-urbaniak/rkt/labels{/name}","releases_url":"https://api.github.com/repos/s-urbaniak/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/s-urbaniak/rkt/deployments","created_at":"2016-04-05T11:09:13Z","updated_at":"2016-04-05T11:09:14Z","pushed_at":"2016-10-07T14:12:48Z","git_url":"git://github.com/s-urbaniak/rkt.git","ssh_url":"git@github.com:s-urbaniak/rkt.git","clone_url":"https://github.com/s-urbaniak/rkt.git","svn_url":"https://github.com/s-urbaniak/rkt","homepage":"","size":25527,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:cri","ref":"cri","sha":"2ef08852d24536ea71be638bb1f457c7735dffcc","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is a container engine for Linux designed to be composable, secure, and built on standards","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-10-07T14:43:47Z","pushed_at":"2016-10-07T14:36:46Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":33230,"stargazers_count":6167,"watchers_count":6167,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":604,"mirror_url":null,"open_issues_count":396,"forks":604,"open_issues":396,"watchers":6167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3255"},"html":{"href":"https://github.com/coreos/rkt/pull/3255"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/3255"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/3255/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3255/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3255/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/56a14e26c648a413ca1b58debffab96db0940982"}}}}
{"actor":{"display_login":"s-urbaniak"}}