{"action":"created","comment":{"url":"https://api.github.com/repos/yuqiangcui/framework/pulls/comments/78352609","id":78352609,"diff_hunk":"@@ -102,10 +101,10 @@ public void deleteBatch(ID[] ids) {\n     }\n \n     @SuppressWarnings(\"unchecked\")\n-    public Page<T> findBySearchable(Searchable searchable) {\n+    public Pagination<T> findBySearchable(Searchable searchable) {\n         List<T> content = getDaoMapper().findBySearchable(searchable);\n         long total = searchable.hasPageable() ? countBySearchable(searchable) : content.size();\n-        return new PageImpl<T>(content, searchable.getPage(), total);\n+        return new BasePagination<T>(content, Integer.parseInt(String.valueOf(total)));","path":"framework-core/src/main/java/cn/vansky/framework/core/dao/ConfigurableBaseSqlMapDao.java","position":29,"original_position":29,"commit_id":"0793c1400802ee9f3bf2f0d1db06aa4b3eb3da5d","original_commit_id":"0793c1400802ee9f3bf2f0d1db06aa4b3eb3da5d","user":{"login":"yuqiangcui","id":16114842,"avatar_url":"https://avatars.githubusercontent.com/u/16114842?v=3","gravatar_id":"","url":"https://api.github.com/users/yuqiangcui","html_url":"https://github.com/yuqiangcui","followers_url":"https://api.github.com/users/yuqiangcui/followers","following_url":"https://api.github.com/users/yuqiangcui/following{/other_user}","gists_url":"https://api.github.com/users/yuqiangcui/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqiangcui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqiangcui/subscriptions","organizations_url":"https://api.github.com/users/yuqiangcui/orgs","repos_url":"https://api.github.com/users/yuqiangcui/repos","events_url":"https://api.github.com/users/yuqiangcui/events{/privacy}","received_events_url":"https://api.github.com/users/yuqiangcui/received_events","type":"User","site_admin":false},"body":"底层直接返回int就行了","created_at":"2016-09-12T11:05:23Z","updated_at":"2016-09-12T11:05:23Z","html_url":"https://github.com/yuqiangcui/framework/pull/7#discussion_r78352609","pull_request_url":"https://api.github.com/repos/yuqiangcui/framework/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/yuqiangcui/framework/pulls/comments/78352609"},"html":{"href":"https://github.com/yuqiangcui/framework/pull/7#discussion_r78352609"},"pull_request":{"href":"https://api.github.com/repos/yuqiangcui/framework/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/yuqiangcui/framework/pulls/7","id":84847388,"html_url":"https://github.com/yuqiangcui/framework/pull/7","diff_url":"https://github.com/yuqiangcui/framework/pull/7.diff","patch_url":"https://github.com/yuqiangcui/framework/pull/7.patch","issue_url":"https://api.github.com/repos/yuqiangcui/framework/issues/7","number":7,"state":"open","locked":false,"title":"master","user":{"login":"wyzhangjie","id":7983369,"avatar_url":"https://avatars.githubusercontent.com/u/7983369?v=3","gravatar_id":"","url":"https://api.github.com/users/wyzhangjie","html_url":"https://github.com/wyzhangjie","followers_url":"https://api.github.com/users/wyzhangjie/followers","following_url":"https://api.github.com/users/wyzhangjie/following{/other_user}","gists_url":"https://api.github.com/users/wyzhangjie/gists{/gist_id}","starred_url":"https://api.github.com/users/wyzhangjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyzhangjie/subscriptions","organizations_url":"https://api.github.com/users/wyzhangjie/orgs","repos_url":"https://api.github.com/users/wyzhangjie/repos","events_url":"https://api.github.com/users/wyzhangjie/events{/privacy}","received_events_url":"https://api.github.com/users/wyzhangjie/received_events","type":"User","site_admin":false},"body":"删掉多余代码","created_at":"2016-09-12T10:22:59Z","updated_at":"2016-09-12T11:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b6b0c3300bf3e84647041b65943a37d8583bed1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuqiangcui/framework/pulls/7/commits","review_comments_url":"https://api.github.com/repos/yuqiangcui/framework/pulls/7/comments","review_comment_url":"https://api.github.com/repos/yuqiangcui/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuqiangcui/framework/issues/7/comments","statuses_url":"https://api.github.com/repos/yuqiangcui/framework/statuses/0793c1400802ee9f3bf2f0d1db06aa4b3eb3da5d","head":{"label":"wyzhangjie:master","ref":"master","sha":"0793c1400802ee9f3bf2f0d1db06aa4b3eb3da5d","user":{"login":"wyzhangjie","id":7983369,"avatar_url":"https://avatars.githubusercontent.com/u/7983369?v=3","gravatar_id":"","url":"https://api.github.com/users/wyzhangjie","html_url":"https://github.com/wyzhangjie","followers_url":"https://api.github.com/users/wyzhangjie/followers","following_url":"https://api.github.com/users/wyzhangjie/following{/other_user}","gists_url":"https://api.github.com/users/wyzhangjie/gists{/gist_id}","starred_url":"https://api.github.com/users/wyzhangjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyzhangjie/subscriptions","organizations_url":"https://api.github.com/users/wyzhangjie/orgs","repos_url":"https://api.github.com/users/wyzhangjie/repos","events_url":"https://api.github.com/users/wyzhangjie/events{/privacy}","received_events_url":"https://api.github.com/users/wyzhangjie/received_events","type":"User","site_admin":false},"repo":{"id":67688790,"name":"framework","full_name":"wyzhangjie/framework","owner":{"login":"wyzhangjie","id":7983369,"avatar_url":"https://avatars.githubusercontent.com/u/7983369?v=3","gravatar_id":"","url":"https://api.github.com/users/wyzhangjie","html_url":"https://github.com/wyzhangjie","followers_url":"https://api.github.com/users/wyzhangjie/followers","following_url":"https://api.github.com/users/wyzhangjie/following{/other_user}","gists_url":"https://api.github.com/users/wyzhangjie/gists{/gist_id}","starred_url":"https://api.github.com/users/wyzhangjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyzhangjie/subscriptions","organizations_url":"https://api.github.com/users/wyzhangjie/orgs","repos_url":"https://api.github.com/users/wyzhangjie/repos","events_url":"https://api.github.com/users/wyzhangjie/events{/privacy}","received_events_url":"https://api.github.com/users/wyzhangjie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wyzhangjie/framework","description":null,"fork":true,"url":"https://api.github.com/repos/wyzhangjie/framework","forks_url":"https://api.github.com/repos/wyzhangjie/framework/forks","keys_url":"https://api.github.com/repos/wyzhangjie/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wyzhangjie/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wyzhangjie/framework/teams","hooks_url":"https://api.github.com/repos/wyzhangjie/framework/hooks","issue_events_url":"https://api.github.com/repos/wyzhangjie/framework/issues/events{/number}","events_url":"https://api.github.com/repos/wyzhangjie/framework/events","assignees_url":"https://api.github.com/repos/wyzhangjie/framework/assignees{/user}","branches_url":"https://api.github.com/repos/wyzhangjie/framework/branches{/branch}","tags_url":"https://api.github.com/repos/wyzhangjie/framework/tags","blobs_url":"https://api.github.com/repos/wyzhangjie/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wyzhangjie/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wyzhangjie/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wyzhangjie/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wyzhangjie/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wyzhangjie/framework/languages","stargazers_url":"https://api.github.com/repos/wyzhangjie/framework/stargazers","contributors_url":"https://api.github.com/repos/wyzhangjie/framework/contributors","subscribers_url":"https://api.github.com/repos/wyzhangjie/framework/subscribers","subscription_url":"https://api.github.com/repos/wyzhangjie/framework/subscription","commits_url":"https://api.github.com/repos/wyzhangjie/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wyzhangjie/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wyzhangjie/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wyzhangjie/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wyzhangjie/framework/contents/{+path}","compare_url":"https://api.github.com/repos/wyzhangjie/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wyzhangjie/framework/merges","archive_url":"https://api.github.com/repos/wyzhangjie/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wyzhangjie/framework/downloads","issues_url":"https://api.github.com/repos/wyzhangjie/framework/issues{/number}","pulls_url":"https://api.github.com/repos/wyzhangjie/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wyzhangjie/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wyzhangjie/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wyzhangjie/framework/labels{/name}","releases_url":"https://api.github.com/repos/wyzhangjie/framework/releases{/id}","deployments_url":"https://api.github.com/repos/wyzhangjie/framework/deployments","created_at":"2016-09-08T09:25:50Z","updated_at":"2016-09-08T09:25:52Z","pushed_at":"2016-09-12T10:47:22Z","git_url":"git://github.com/wyzhangjie/framework.git","ssh_url":"git@github.com:wyzhangjie/framework.git","clone_url":"https://github.com/wyzhangjie/framework.git","svn_url":"https://github.com/wyzhangjie/framework","homepage":null,"size":5136,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yuqiangcui:master","ref":"master","sha":"3ad3ae50bb5457520d149078b9cae635cc96720d","user":{"login":"yuqiangcui","id":16114842,"avatar_url":"https://avatars.githubusercontent.com/u/16114842?v=3","gravatar_id":"","url":"https://api.github.com/users/yuqiangcui","html_url":"https://github.com/yuqiangcui","followers_url":"https://api.github.com/users/yuqiangcui/followers","following_url":"https://api.github.com/users/yuqiangcui/following{/other_user}","gists_url":"https://api.github.com/users/yuqiangcui/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqiangcui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqiangcui/subscriptions","organizations_url":"https://api.github.com/users/yuqiangcui/orgs","repos_url":"https://api.github.com/users/yuqiangcui/repos","events_url":"https://api.github.com/users/yuqiangcui/events{/privacy}","received_events_url":"https://api.github.com/users/yuqiangcui/received_events","type":"User","site_admin":false},"repo":{"id":63558492,"name":"framework","full_name":"yuqiangcui/framework","owner":{"login":"yuqiangcui","id":16114842,"avatar_url":"https://avatars.githubusercontent.com/u/16114842?v=3","gravatar_id":"","url":"https://api.github.com/users/yuqiangcui","html_url":"https://github.com/yuqiangcui","followers_url":"https://api.github.com/users/yuqiangcui/followers","following_url":"https://api.github.com/users/yuqiangcui/following{/other_user}","gists_url":"https://api.github.com/users/yuqiangcui/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqiangcui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqiangcui/subscriptions","organizations_url":"https://api.github.com/users/yuqiangcui/orgs","repos_url":"https://api.github.com/users/yuqiangcui/repos","events_url":"https://api.github.com/users/yuqiangcui/events{/privacy}","received_events_url":"https://api.github.com/users/yuqiangcui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuqiangcui/framework","description":null,"fork":false,"url":"https://api.github.com/repos/yuqiangcui/framework","forks_url":"https://api.github.com/repos/yuqiangcui/framework/forks","keys_url":"https://api.github.com/repos/yuqiangcui/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuqiangcui/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuqiangcui/framework/teams","hooks_url":"https://api.github.com/repos/yuqiangcui/framework/hooks","issue_events_url":"https://api.github.com/repos/yuqiangcui/framework/issues/events{/number}","events_url":"https://api.github.com/repos/yuqiangcui/framework/events","assignees_url":"https://api.github.com/repos/yuqiangcui/framework/assignees{/user}","branches_url":"https://api.github.com/repos/yuqiangcui/framework/branches{/branch}","tags_url":"https://api.github.com/repos/yuqiangcui/framework/tags","blobs_url":"https://api.github.com/repos/yuqiangcui/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuqiangcui/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuqiangcui/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuqiangcui/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuqiangcui/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/yuqiangcui/framework/languages","stargazers_url":"https://api.github.com/repos/yuqiangcui/framework/stargazers","contributors_url":"https://api.github.com/repos/yuqiangcui/framework/contributors","subscribers_url":"https://api.github.com/repos/yuqiangcui/framework/subscribers","subscription_url":"https://api.github.com/repos/yuqiangcui/framework/subscription","commits_url":"https://api.github.com/repos/yuqiangcui/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuqiangcui/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuqiangcui/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuqiangcui/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuqiangcui/framework/contents/{+path}","compare_url":"https://api.github.com/repos/yuqiangcui/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuqiangcui/framework/merges","archive_url":"https://api.github.com/repos/yuqiangcui/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuqiangcui/framework/downloads","issues_url":"https://api.github.com/repos/yuqiangcui/framework/issues{/number}","pulls_url":"https://api.github.com/repos/yuqiangcui/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/yuqiangcui/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/yuqiangcui/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuqiangcui/framework/labels{/name}","releases_url":"https://api.github.com/repos/yuqiangcui/framework/releases{/id}","deployments_url":"https://api.github.com/repos/yuqiangcui/framework/deployments","created_at":"2016-07-18T00:22:14Z","updated_at":"2016-07-18T00:37:45Z","pushed_at":"2016-09-12T10:47:22Z","git_url":"git://github.com/yuqiangcui/framework.git","ssh_url":"git@github.com:yuqiangcui/framework.git","clone_url":"https://github.com/yuqiangcui/framework.git","svn_url":"https://github.com/yuqiangcui/framework","homepage":null,"size":5130,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuqiangcui/framework/pulls/7"},"html":{"href":"https://github.com/yuqiangcui/framework/pull/7"},"issue":{"href":"https://api.github.com/repos/yuqiangcui/framework/issues/7"},"comments":{"href":"https://api.github.com/repos/yuqiangcui/framework/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/yuqiangcui/framework/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/yuqiangcui/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuqiangcui/framework/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/yuqiangcui/framework/statuses/0793c1400802ee9f3bf2f0d1db06aa4b3eb3da5d"}}}}
{"actor":{"display_login":"yuqiangcui"}}