{"action":"created","comment":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/93600998","pull_request_review_id":14131481,"id":93600998,"diff_hunk":"@@ -68,6 +68,11 @@ def information\n \n   end\n \n+  def destroy\n+    @membership_application.destroy\n+    redirect_to membership_applications_url, notice: t('membership_applications.application_deleted')","path":"app/controllers/membership_applications_controller.rb","position":15,"original_position":15,"commit_id":"1554ffd47b06a5f21ab9a17ff47dfa7395889805","original_commit_id":"32cd04b1eeba18b9c3b41df58b246e3be961732b","user":{"login":"thesuss","id":7266909,"avatar_url":"https://avatars.githubusercontent.com/u/7266909?v=3","gravatar_id":"","url":"https://api.github.com/users/thesuss","html_url":"https://github.com/thesuss","followers_url":"https://api.github.com/users/thesuss/followers","following_url":"https://api.github.com/users/thesuss/following{/other_user}","gists_url":"https://api.github.com/users/thesuss/gists{/gist_id}","starred_url":"https://api.github.com/users/thesuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesuss/subscriptions","organizations_url":"https://api.github.com/users/thesuss/orgs","repos_url":"https://api.github.com/users/thesuss/repos","events_url":"https://api.github.com/users/thesuss/events{/privacy}","received_events_url":"https://api.github.com/users/thesuss/received_events","type":"User","site_admin":false},"body":"The swedish was there (hardcoded in the views/messages), its the english that is added","created_at":"2016-12-22T10:42:32Z","updated_at":"2016-12-22T10:42:32Z","html_url":"https://github.com/AgileVentures/shf-project/pull/96#discussion_r93600998","pull_request_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/93600998"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/96#discussion_r93600998"},"pull_request":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96","id":98649649,"html_url":"https://github.com/AgileVentures/shf-project/pull/96","diff_url":"https://github.com/AgileVentures/shf-project/pull/96.diff","patch_url":"https://github.com/AgileVentures/shf-project/pull/96.patch","issue_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/96","number":96,"state":"open","locked":false,"title":"Bugfix  add delete to show Membership Application for admin ","user":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"body":"PT Story: **Can't delete duplicated applications**\r\nhttps://www.pivotaltracker.com/story/show/136390979\r\n\r\nChanges proposed in this pull request:\r\n1. Red Delete/Ta bort - link visible only to admin on \"View membership application\" page (used a link instead of a button just to keep things simple. (no underlying form needed for just the 1 button). Could be styled as a button, though.)\r\n2. refactored the policies: moved `is_admin?` up to common parent (ApplicationPolicy)\r\n3. added policy check for `MembershipApplicationController#destroy?`\r\n\r\nScreenshot: \r\n<img width=\"287\" alt=\"skarmavbild 2016-12-20 kl 08 22 25\" src=\"https://cloud.githubusercontent.com/assets/7266909/21341559/78c155fc-c68d-11e6-99a0-dd8700958c5a.png\">\r\n\r\nready for review\r\n@AgileVentures/shf-project-team \r\n","created_at":"2016-12-19T22:12:22Z","updated_at":"2016-12-22T10:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"855538c3044af4ebd5684b1cee87880867fd685b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96/commits","review_comments_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96/comments","review_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/96/comments","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/1554ffd47b06a5f21ab9a17ff47dfa7395889805","head":{"label":"weedySeaDragon:bugfix--add-delete-to-admin-views","ref":"bugfix--add-delete-to-admin-views","sha":"1554ffd47b06a5f21ab9a17ff47dfa7395889805","user":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"repo":{"id":72142277,"name":"shf-project","full_name":"weedySeaDragon/shf-project","owner":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weedySeaDragon/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/weedySeaDragon/shf-project","forks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/forks","keys_url":"https://api.github.com/repos/weedySeaDragon/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weedySeaDragon/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weedySeaDragon/shf-project/teams","hooks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/hooks","issue_events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/events","assignees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/weedySeaDragon/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/tags","blobs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weedySeaDragon/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/weedySeaDragon/shf-project/languages","stargazers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/stargazers","contributors_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contributors","subscribers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscribers","subscription_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscription","commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/weedySeaDragon/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weedySeaDragon/shf-project/merges","archive_url":"https://api.github.com/repos/weedySeaDragon/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weedySeaDragon/shf-project/downloads","issues_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/weedySeaDragon/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/weedySeaDragon/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/weedySeaDragon/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weedySeaDragon/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/weedySeaDragon/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/deployments","created_at":"2016-10-27T19:44:01Z","updated_at":"2016-10-21T07:42:18Z","pushed_at":"2016-12-22T09:50:26Z","git_url":"git://github.com/weedySeaDragon/shf-project.git","ssh_url":"git@github.com:weedySeaDragon/shf-project.git","clone_url":"https://github.com/weedySeaDragon/shf-project.git","svn_url":"https://github.com/weedySeaDragon/shf-project","homepage":null,"size":1746,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AgileVentures:develop","ref":"develop","sha":"10e16badcdab327e97b19b01e60ba5d64ee217c7","user":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"repo":{"id":71157737,"name":"shf-project","full_name":"AgileVentures/shf-project","owner":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgileVentures/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/AgileVentures/shf-project","forks_url":"https://api.github.com/repos/AgileVentures/shf-project/forks","keys_url":"https://api.github.com/repos/AgileVentures/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileVentures/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileVentures/shf-project/teams","hooks_url":"https://api.github.com/repos/AgileVentures/shf-project/hooks","issue_events_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/AgileVentures/shf-project/events","assignees_url":"https://api.github.com/repos/AgileVentures/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/AgileVentures/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/AgileVentures/shf-project/tags","blobs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileVentures/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileVentures/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileVentures/shf-project/languages","stargazers_url":"https://api.github.com/repos/AgileVentures/shf-project/stargazers","contributors_url":"https://api.github.com/repos/AgileVentures/shf-project/contributors","subscribers_url":"https://api.github.com/repos/AgileVentures/shf-project/subscribers","subscription_url":"https://api.github.com/repos/AgileVentures/shf-project/subscription","commits_url":"https://api.github.com/repos/AgileVentures/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileVentures/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgileVentures/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/AgileVentures/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileVentures/shf-project/merges","archive_url":"https://api.github.com/repos/AgileVentures/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileVentures/shf-project/downloads","issues_url":"https://api.github.com/repos/AgileVentures/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileVentures/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileVentures/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileVentures/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/AgileVentures/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/AgileVentures/shf-project/deployments","created_at":"2016-10-17T16:18:10Z","updated_at":"2016-12-02T13:34:05Z","pushed_at":"2016-12-22T09:50:26Z","git_url":"git://github.com/AgileVentures/shf-project.git","ssh_url":"git@github.com:AgileVentures/shf-project.git","clone_url":"https://github.com/AgileVentures/shf-project.git","svn_url":"https://github.com/AgileVentures/shf-project","homepage":null,"size":1420,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/96"},"issue":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/96"},"comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/AgileVentures/shf-project/statuses/1554ffd47b06a5f21ab9a17ff47dfa7395889805"}}}}
{"actor":{"display_login":"thesuss"}}