{"action":"created","issue":{"url":"https://api.github.com/repos/lede-project/source/issues/181","repository_url":"https://api.github.com/repos/lede-project/source","labels_url":"https://api.github.com/repos/lede-project/source/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/lede-project/source/issues/181/comments","events_url":"https://api.github.com/repos/lede-project/source/issues/181/events","html_url":"https://github.com/lede-project/source/pull/181","id":164162018,"number":181,"title":"samba: update smb template socket options defaults","user":{"login":"kdarbyshirebryant","id":6500011,"avatar_url":"https://avatars.githubusercontent.com/u/6500011?v=3","gravatar_id":"","url":"https://api.github.com/users/kdarbyshirebryant","html_url":"https://github.com/kdarbyshirebryant","followers_url":"https://api.github.com/users/kdarbyshirebryant/followers","following_url":"https://api.github.com/users/kdarbyshirebryant/following{/other_user}","gists_url":"https://api.github.com/users/kdarbyshirebryant/gists{/gist_id}","starred_url":"https://api.github.com/users/kdarbyshirebryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdarbyshirebryant/subscriptions","organizations_url":"https://api.github.com/users/kdarbyshirebryant/orgs","repos_url":"https://api.github.com/users/kdarbyshirebryant/repos","events_url":"https://api.github.com/users/kdarbyshirebryant/events{/privacy}","received_events_url":"https://api.github.com/users/kdarbyshirebryant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-06T20:06:22Z","updated_at":"2016-07-07T01:11:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lede-project/source/pulls/181","html_url":"https://github.com/lede-project/source/pull/181","diff_url":"https://github.com/lede-project/source/pull/181.diff","patch_url":"https://github.com/lede-project/source/pull/181.patch"},"body":"Removed socket options = TCP_NODELAY IPTOS_LOWDELAY\r\n\r\nTCP_NODELAY (disables Nagle algorithm) is default since samba2.\r\nIPTOS_LOWDELAY sets DSCP 0x10 coding (CS2)\r\nThe alternate IPTOS_THROUGHPUT sets DSCP 0x08 coding (CS1)\r\n\r\nCS1 is a scavenger class, whilst CS2 is more OAM/interactive\r\n(SNMP,SSH,syslog)\r\n\r\nUsing CS2 is definitely an abuse of DSCP classification, CS1 less so\r\nhowever even if the ISP takes note of DSCP codings having a default that\r\nsets traffic to CS2 is wrong.  Better to use the default Best Effort\r\nclass.\r\n\r\nSigned-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>"},"comment":{"url":"https://api.github.com/repos/lede-project/source/issues/comments/230952624","html_url":"https://github.com/lede-project/source/pull/181#issuecomment-230952624","issue_url":"https://api.github.com/repos/lede-project/source/issues/181","id":230952624,"user":{"login":"lynxis","id":272583,"avatar_url":"https://avatars.githubusercontent.com/u/272583?v=3","gravatar_id":"","url":"https://api.github.com/users/lynxis","html_url":"https://github.com/lynxis","followers_url":"https://api.github.com/users/lynxis/followers","following_url":"https://api.github.com/users/lynxis/following{/other_user}","gists_url":"https://api.github.com/users/lynxis/gists{/gist_id}","starred_url":"https://api.github.com/users/lynxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynxis/subscriptions","organizations_url":"https://api.github.com/users/lynxis/orgs","repos_url":"https://api.github.com/users/lynxis/repos","events_url":"https://api.github.com/users/lynxis/events{/privacy}","received_events_url":"https://api.github.com/users/lynxis/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T01:11:31Z","updated_at":"2016-07-07T01:11:31Z","body":"LGTM.\r\nwait for felix to respond @nbd168 "}}
{"actor":{"display_login":"lynxis"}}