{"action":"created","comment":{"url":"https://api.github.com/repos/outscale/butterfly/pulls/comments/75080960","id":75080960,"diff_hunk":"@@ -365,14 +365,21 @@ function delete_nic {\n }\n \n function add_nic_port_open {\n-    sg=$1\n-    but_id=$2\n-    nic_id=$3\n-    vni=$4\n-    protocol=$5\n-    port=$6\n+    sg=$2\n+    but_id=$3\n+    nic_id=$4\n+    vni=$5\n+    port_tcp_udp=$6\n+    if [ \"$1\" == \"tcp\" ]; then\n+\ttcp_udp_protocol=6\n+    elif [ \"$1\" == \"udp\" ]; then\n+\ttcp_udp_protocol=17\n+    else\n+\techo -e \"protocol not set, check protocol please\"\n+\tRETURN_CODE=1\n+    fi\n     f=/tmp/butterfly-client.req\n-    echo \"add nic $nic_id with only port $port opened in butterfly $but_id in vni $vni\"\n+    echo \"add nic $nic_id $1 port $port_tcp_udp opened in butterfly $but_id in vni $vni\"","path":"tests/functions.sh","position":43,"original_position":43,"commit_id":"153b7444b045e45d5592c61b10b888468b1c409c","original_commit_id":"7a0e7b4d74ea559cc702bf618eb7381addacfe53","user":{"login":"outscale-jju","id":10711235,"avatar_url":"https://avatars.githubusercontent.com/u/10711235?v=3","gravatar_id":"","url":"https://api.github.com/users/outscale-jju","html_url":"https://github.com/outscale-jju","followers_url":"https://api.github.com/users/outscale-jju/followers","following_url":"https://api.github.com/users/outscale-jju/following{/other_user}","gists_url":"https://api.github.com/users/outscale-jju/gists{/gist_id}","starred_url":"https://api.github.com/users/outscale-jju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outscale-jju/subscriptions","organizations_url":"https://api.github.com/users/outscale-jju/orgs","repos_url":"https://api.github.com/users/outscale-jju/repos","events_url":"https://api.github.com/users/outscale-jju/events{/privacy}","received_events_url":"https://api.github.com/users/outscale-jju/received_events","type":"User","site_admin":false},"body":"why don't you set `protocol=$1` like other arguments ?","created_at":"2016-08-17T08:23:11Z","updated_at":"2016-08-17T08:23:11Z","html_url":"https://github.com/outscale/butterfly/pull/92#discussion_r75080960","pull_request_url":"https://api.github.com/repos/outscale/butterfly/pulls/92","_links":{"self":{"href":"https://api.github.com/repos/outscale/butterfly/pulls/comments/75080960"},"html":{"href":"https://github.com/outscale/butterfly/pull/92#discussion_r75080960"},"pull_request":{"href":"https://api.github.com/repos/outscale/butterfly/pulls/92"}}},"pull_request":{"url":"https://api.github.com/repos/outscale/butterfly/pulls/92","id":77982208,"html_url":"https://github.com/outscale/butterfly/pull/92","diff_url":"https://github.com/outscale/butterfly/pull/92.diff","patch_url":"https://github.com/outscale/butterfly/pull/92.patch","issue_url":"https://api.github.com/repos/outscale/butterfly/issues/92","number":92,"state":"open","locked":false,"title":"Tcp udp sg rules tests ok","user":{"login":"outscale-toa","id":16779167,"avatar_url":"https://avatars.githubusercontent.com/u/16779167?v=3","gravatar_id":"","url":"https://api.github.com/users/outscale-toa","html_url":"https://github.com/outscale-toa","followers_url":"https://api.github.com/users/outscale-toa/followers","following_url":"https://api.github.com/users/outscale-toa/following{/other_user}","gists_url":"https://api.github.com/users/outscale-toa/gists{/gist_id}","starred_url":"https://api.github.com/users/outscale-toa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outscale-toa/subscriptions","organizations_url":"https://api.github.com/users/outscale-toa/orgs","repos_url":"https://api.github.com/users/outscale-toa/repos","events_url":"https://api.github.com/users/outscale-toa/events{/privacy}","received_events_url":"https://api.github.com/users/outscale-toa/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-19T14:06:46Z","updated_at":"2016-08-17T08:23:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"748540b497c6c7712714d1db2723dbcd37b0f440","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/outscale/butterfly/pulls/92/commits","review_comments_url":"https://api.github.com/repos/outscale/butterfly/pulls/92/comments","review_comment_url":"https://api.github.com/repos/outscale/butterfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/outscale/butterfly/issues/92/comments","statuses_url":"https://api.github.com/repos/outscale/butterfly/statuses/153b7444b045e45d5592c61b10b888468b1c409c","head":{"label":"outscale-toa:tcp_udp_rules_tests_ok","ref":"tcp_udp_rules_tests_ok","sha":"153b7444b045e45d5592c61b10b888468b1c409c","user":{"login":"outscale-toa","id":16779167,"avatar_url":"https://avatars.githubusercontent.com/u/16779167?v=3","gravatar_id":"","url":"https://api.github.com/users/outscale-toa","html_url":"https://github.com/outscale-toa","followers_url":"https://api.github.com/users/outscale-toa/followers","following_url":"https://api.github.com/users/outscale-toa/following{/other_user}","gists_url":"https://api.github.com/users/outscale-toa/gists{/gist_id}","starred_url":"https://api.github.com/users/outscale-toa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outscale-toa/subscriptions","organizations_url":"https://api.github.com/users/outscale-toa/orgs","repos_url":"https://api.github.com/users/outscale-toa/repos","events_url":"https://api.github.com/users/outscale-toa/events{/privacy}","received_events_url":"https://api.github.com/users/outscale-toa/received_events","type":"User","site_admin":false},"repo":{"id":55783011,"name":"butterfly","full_name":"outscale-toa/butterfly","owner":{"login":"outscale-toa","id":16779167,"avatar_url":"https://avatars.githubusercontent.com/u/16779167?v=3","gravatar_id":"","url":"https://api.github.com/users/outscale-toa","html_url":"https://github.com/outscale-toa","followers_url":"https://api.github.com/users/outscale-toa/followers","following_url":"https://api.github.com/users/outscale-toa/following{/other_user}","gists_url":"https://api.github.com/users/outscale-toa/gists{/gist_id}","starred_url":"https://api.github.com/users/outscale-toa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outscale-toa/subscriptions","organizations_url":"https://api.github.com/users/outscale-toa/orgs","repos_url":"https://api.github.com/users/outscale-toa/repos","events_url":"https://api.github.com/users/outscale-toa/events{/privacy}","received_events_url":"https://api.github.com/users/outscale-toa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/outscale-toa/butterfly","description":"max_pkts","fork":true,"url":"https://api.github.com/repos/outscale-toa/butterfly","forks_url":"https://api.github.com/repos/outscale-toa/butterfly/forks","keys_url":"https://api.github.com/repos/outscale-toa/butterfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/outscale-toa/butterfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/outscale-toa/butterfly/teams","hooks_url":"https://api.github.com/repos/outscale-toa/butterfly/hooks","issue_events_url":"https://api.github.com/repos/outscale-toa/butterfly/issues/events{/number}","events_url":"https://api.github.com/repos/outscale-toa/butterfly/events","assignees_url":"https://api.github.com/repos/outscale-toa/butterfly/assignees{/user}","branches_url":"https://api.github.com/repos/outscale-toa/butterfly/branches{/branch}","tags_url":"https://api.github.com/repos/outscale-toa/butterfly/tags","blobs_url":"https://api.github.com/repos/outscale-toa/butterfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/outscale-toa/butterfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/outscale-toa/butterfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/outscale-toa/butterfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/outscale-toa/butterfly/statuses/{sha}","languages_url":"https://api.github.com/repos/outscale-toa/butterfly/languages","stargazers_url":"https://api.github.com/repos/outscale-toa/butterfly/stargazers","contributors_url":"https://api.github.com/repos/outscale-toa/butterfly/contributors","subscribers_url":"https://api.github.com/repos/outscale-toa/butterfly/subscribers","subscription_url":"https://api.github.com/repos/outscale-toa/butterfly/subscription","commits_url":"https://api.github.com/repos/outscale-toa/butterfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/outscale-toa/butterfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/outscale-toa/butterfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/outscale-toa/butterfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/outscale-toa/butterfly/contents/{+path}","compare_url":"https://api.github.com/repos/outscale-toa/butterfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/outscale-toa/butterfly/merges","archive_url":"https://api.github.com/repos/outscale-toa/butterfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/outscale-toa/butterfly/downloads","issues_url":"https://api.github.com/repos/outscale-toa/butterfly/issues{/number}","pulls_url":"https://api.github.com/repos/outscale-toa/butterfly/pulls{/number}","milestones_url":"https://api.github.com/repos/outscale-toa/butterfly/milestones{/number}","notifications_url":"https://api.github.com/repos/outscale-toa/butterfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/outscale-toa/butterfly/labels{/name}","releases_url":"https://api.github.com/repos/outscale-toa/butterfly/releases{/id}","deployments_url":"https://api.github.com/repos/outscale-toa/butterfly/deployments","created_at":"2016-04-08T13:59:19Z","updated_at":"2016-04-08T13:59:20Z","pushed_at":"2016-08-16T13:15:10Z","git_url":"git://github.com/outscale-toa/butterfly.git","ssh_url":"git@github.com:outscale-toa/butterfly.git","clone_url":"https://github.com/outscale-toa/butterfly.git","svn_url":"https://github.com/outscale-toa/butterfly","homepage":"","size":891,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"outscale:master","ref":"master","sha":"81616bc250634c4a722e48d907ddbcd3dfd20525","user":{"login":"outscale","id":8233735,"avatar_url":"https://avatars.githubusercontent.com/u/8233735?v=3","gravatar_id":"","url":"https://api.github.com/users/outscale","html_url":"https://github.com/outscale","followers_url":"https://api.github.com/users/outscale/followers","following_url":"https://api.github.com/users/outscale/following{/other_user}","gists_url":"https://api.github.com/users/outscale/gists{/gist_id}","starred_url":"https://api.github.com/users/outscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outscale/subscriptions","organizations_url":"https://api.github.com/users/outscale/orgs","repos_url":"https://api.github.com/users/outscale/repos","events_url":"https://api.github.com/users/outscale/events{/privacy}","received_events_url":"https://api.github.com/users/outscale/received_events","type":"Organization","site_admin":false},"repo":{"id":35087520,"name":"butterfly","full_name":"outscale/butterfly","owner":{"login":"outscale","id":8233735,"avatar_url":"https://avatars.githubusercontent.com/u/8233735?v=3","gravatar_id":"","url":"https://api.github.com/users/outscale","html_url":"https://github.com/outscale","followers_url":"https://api.github.com/users/outscale/followers","following_url":"https://api.github.com/users/outscale/following{/other_user}","gists_url":"https://api.github.com/users/outscale/gists{/gist_id}","starred_url":"https://api.github.com/users/outscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outscale/subscriptions","organizations_url":"https://api.github.com/users/outscale/orgs","repos_url":"https://api.github.com/users/outscale/repos","events_url":"https://api.github.com/users/outscale/events{/privacy}","received_events_url":"https://api.github.com/users/outscale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/outscale/butterfly","description":"max_pkts","fork":false,"url":"https://api.github.com/repos/outscale/butterfly","forks_url":"https://api.github.com/repos/outscale/butterfly/forks","keys_url":"https://api.github.com/repos/outscale/butterfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/outscale/butterfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/outscale/butterfly/teams","hooks_url":"https://api.github.com/repos/outscale/butterfly/hooks","issue_events_url":"https://api.github.com/repos/outscale/butterfly/issues/events{/number}","events_url":"https://api.github.com/repos/outscale/butterfly/events","assignees_url":"https://api.github.com/repos/outscale/butterfly/assignees{/user}","branches_url":"https://api.github.com/repos/outscale/butterfly/branches{/branch}","tags_url":"https://api.github.com/repos/outscale/butterfly/tags","blobs_url":"https://api.github.com/repos/outscale/butterfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/outscale/butterfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/outscale/butterfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/outscale/butterfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/outscale/butterfly/statuses/{sha}","languages_url":"https://api.github.com/repos/outscale/butterfly/languages","stargazers_url":"https://api.github.com/repos/outscale/butterfly/stargazers","contributors_url":"https://api.github.com/repos/outscale/butterfly/contributors","subscribers_url":"https://api.github.com/repos/outscale/butterfly/subscribers","subscription_url":"https://api.github.com/repos/outscale/butterfly/subscription","commits_url":"https://api.github.com/repos/outscale/butterfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/outscale/butterfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/outscale/butterfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/outscale/butterfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/outscale/butterfly/contents/{+path}","compare_url":"https://api.github.com/repos/outscale/butterfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/outscale/butterfly/merges","archive_url":"https://api.github.com/repos/outscale/butterfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/outscale/butterfly/downloads","issues_url":"https://api.github.com/repos/outscale/butterfly/issues{/number}","pulls_url":"https://api.github.com/repos/outscale/butterfly/pulls{/number}","milestones_url":"https://api.github.com/repos/outscale/butterfly/milestones{/number}","notifications_url":"https://api.github.com/repos/outscale/butterfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/outscale/butterfly/labels{/name}","releases_url":"https://api.github.com/repos/outscale/butterfly/releases{/id}","deployments_url":"https://api.github.com/repos/outscale/butterfly/deployments","created_at":"2015-05-05T08:30:57Z","updated_at":"2016-01-25T15:59:17Z","pushed_at":"2016-08-17T07:26:06Z","git_url":"git://github.com/outscale/butterfly.git","ssh_url":"git@github.com:outscale/butterfly.git","clone_url":"https://github.com/outscale/butterfly.git","svn_url":"https://github.com/outscale/butterfly","homepage":"","size":1082,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":35,"forks":6,"open_issues":35,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/outscale/butterfly/pulls/92"},"html":{"href":"https://github.com/outscale/butterfly/pull/92"},"issue":{"href":"https://api.github.com/repos/outscale/butterfly/issues/92"},"comments":{"href":"https://api.github.com/repos/outscale/butterfly/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/outscale/butterfly/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/outscale/butterfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/outscale/butterfly/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/outscale/butterfly/statuses/153b7444b045e45d5592c61b10b888468b1c409c"}}}}
{"actor":{"display_login":"outscale-jju"}}