{"action":"created","comment":{"url":"https://api.github.com/repos/rubinius/rubinius/pulls/comments/49938033","id":49938033,"diff_hunk":"@@ -1195,6 +1195,21 @@ def self.sticky?(file_name)\n     return false\n   end\n \n+  def self.mkfifo(file_name, mode = 0666)\n+    raise NotImplementedError, \"mkfifo is not implemented on this platform\" unless Rubinius::HAVE_MKFIFO","path":"kernel/common/file.rb","position":5,"original_position":5,"commit_id":"317ba57d74521ed38bec9706d9ca9921d05de331","original_commit_id":"317ba57d74521ed38bec9706d9ca9921d05de331","user":{"login":"YorickPeterse","id":86065,"avatar_url":"https://avatars.githubusercontent.com/u/86065?v=3","gravatar_id":"","url":"https://api.github.com/users/YorickPeterse","html_url":"https://github.com/YorickPeterse","followers_url":"https://api.github.com/users/YorickPeterse/followers","following_url":"https://api.github.com/users/YorickPeterse/following{/other_user}","gists_url":"https://api.github.com/users/YorickPeterse/gists{/gist_id}","starred_url":"https://api.github.com/users/YorickPeterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorickPeterse/subscriptions","organizations_url":"https://api.github.com/users/YorickPeterse/orgs","repos_url":"https://api.github.com/users/YorickPeterse/repos","events_url":"https://api.github.com/users/YorickPeterse/events{/privacy}","received_events_url":"https://api.github.com/users/YorickPeterse/received_events","type":"User","site_admin":false},"body":"I think it's better to only define this method when `mkfifo` is actually present, opposed to checking for it on every call.","created_at":"2016-01-16T22:13:59Z","updated_at":"2016-01-16T22:13:59Z","html_url":"https://github.com/rubinius/rubinius/pull/3578#discussion_r49938033","pull_request_url":"https://api.github.com/repos/rubinius/rubinius/pulls/3578","_links":{"self":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/comments/49938033"},"html":{"href":"https://github.com/rubinius/rubinius/pull/3578#discussion_r49938033"},"pull_request":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/3578"}}},"pull_request":{"url":"https://api.github.com/repos/rubinius/rubinius/pulls/3578","id":56263771,"html_url":"https://github.com/rubinius/rubinius/pull/3578","diff_url":"https://github.com/rubinius/rubinius/pull/3578.diff","patch_url":"https://github.com/rubinius/rubinius/pull/3578.patch","issue_url":"https://api.github.com/repos/rubinius/rubinius/issues/3578","number":3578,"state":"open","locked":false,"title":"Implement File.mkfifo","user":{"login":"ahmadsherif","id":1060507,"avatar_url":"https://avatars.githubusercontent.com/u/1060507?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmadsherif","html_url":"https://github.com/ahmadsherif","followers_url":"https://api.github.com/users/ahmadsherif/followers","following_url":"https://api.github.com/users/ahmadsherif/following{/other_user}","gists_url":"https://api.github.com/users/ahmadsherif/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmadsherif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmadsherif/subscriptions","organizations_url":"https://api.github.com/users/ahmadsherif/orgs","repos_url":"https://api.github.com/users/ahmadsherif/repos","events_url":"https://api.github.com/users/ahmadsherif/events{/privacy}","received_events_url":"https://api.github.com/users/ahmadsherif/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-16T21:38:52Z","updated_at":"2016-01-16T22:13:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e6b0c27efbc7d9dfa1f1310a7c4007f99c48d80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rubinius/rubinius/pulls/3578/commits","review_comments_url":"https://api.github.com/repos/rubinius/rubinius/pulls/3578/comments","review_comment_url":"https://api.github.com/repos/rubinius/rubinius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubinius/rubinius/issues/3578/comments","statuses_url":"https://api.github.com/repos/rubinius/rubinius/statuses/317ba57d74521ed38bec9706d9ca9921d05de331","head":{"label":"ahmadsherif:feature/implement-file-mkfifo","ref":"feature/implement-file-mkfifo","sha":"317ba57d74521ed38bec9706d9ca9921d05de331","user":{"login":"ahmadsherif","id":1060507,"avatar_url":"https://avatars.githubusercontent.com/u/1060507?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmadsherif","html_url":"https://github.com/ahmadsherif","followers_url":"https://api.github.com/users/ahmadsherif/followers","following_url":"https://api.github.com/users/ahmadsherif/following{/other_user}","gists_url":"https://api.github.com/users/ahmadsherif/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmadsherif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmadsherif/subscriptions","organizations_url":"https://api.github.com/users/ahmadsherif/orgs","repos_url":"https://api.github.com/users/ahmadsherif/repos","events_url":"https://api.github.com/users/ahmadsherif/events{/privacy}","received_events_url":"https://api.github.com/users/ahmadsherif/received_events","type":"User","site_admin":false},"repo":{"id":46279387,"name":"rubinius","full_name":"ahmadsherif/rubinius","owner":{"login":"ahmadsherif","id":1060507,"avatar_url":"https://avatars.githubusercontent.com/u/1060507?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmadsherif","html_url":"https://github.com/ahmadsherif","followers_url":"https://api.github.com/users/ahmadsherif/followers","following_url":"https://api.github.com/users/ahmadsherif/following{/other_user}","gists_url":"https://api.github.com/users/ahmadsherif/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmadsherif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmadsherif/subscriptions","organizations_url":"https://api.github.com/users/ahmadsherif/orgs","repos_url":"https://api.github.com/users/ahmadsherif/repos","events_url":"https://api.github.com/users/ahmadsherif/events{/privacy}","received_events_url":"https://api.github.com/users/ahmadsherif/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmadsherif/rubinius","description":"The Rubinius Language Platform","fork":true,"url":"https://api.github.com/repos/ahmadsherif/rubinius","forks_url":"https://api.github.com/repos/ahmadsherif/rubinius/forks","keys_url":"https://api.github.com/repos/ahmadsherif/rubinius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmadsherif/rubinius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmadsherif/rubinius/teams","hooks_url":"https://api.github.com/repos/ahmadsherif/rubinius/hooks","issue_events_url":"https://api.github.com/repos/ahmadsherif/rubinius/issues/events{/number}","events_url":"https://api.github.com/repos/ahmadsherif/rubinius/events","assignees_url":"https://api.github.com/repos/ahmadsherif/rubinius/assignees{/user}","branches_url":"https://api.github.com/repos/ahmadsherif/rubinius/branches{/branch}","tags_url":"https://api.github.com/repos/ahmadsherif/rubinius/tags","blobs_url":"https://api.github.com/repos/ahmadsherif/rubinius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmadsherif/rubinius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmadsherif/rubinius/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmadsherif/rubinius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmadsherif/rubinius/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmadsherif/rubinius/languages","stargazers_url":"https://api.github.com/repos/ahmadsherif/rubinius/stargazers","contributors_url":"https://api.github.com/repos/ahmadsherif/rubinius/contributors","subscribers_url":"https://api.github.com/repos/ahmadsherif/rubinius/subscribers","subscription_url":"https://api.github.com/repos/ahmadsherif/rubinius/subscription","commits_url":"https://api.github.com/repos/ahmadsherif/rubinius/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmadsherif/rubinius/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmadsherif/rubinius/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmadsherif/rubinius/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmadsherif/rubinius/contents/{+path}","compare_url":"https://api.github.com/repos/ahmadsherif/rubinius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmadsherif/rubinius/merges","archive_url":"https://api.github.com/repos/ahmadsherif/rubinius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmadsherif/rubinius/downloads","issues_url":"https://api.github.com/repos/ahmadsherif/rubinius/issues{/number}","pulls_url":"https://api.github.com/repos/ahmadsherif/rubinius/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmadsherif/rubinius/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmadsherif/rubinius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmadsherif/rubinius/labels{/name}","releases_url":"https://api.github.com/repos/ahmadsherif/rubinius/releases{/id}","created_at":"2015-11-16T14:23:29Z","updated_at":"2015-11-16T14:23:46Z","pushed_at":"2016-01-16T21:36:55Z","git_url":"git://github.com/ahmadsherif/rubinius.git","ssh_url":"git@github.com:ahmadsherif/rubinius.git","clone_url":"https://github.com/ahmadsherif/rubinius.git","svn_url":"https://github.com/ahmadsherif/rubinius","homepage":"http://rubini.us","size":162177,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubinius:master","ref":"master","sha":"97ff097cfbc550b89d77501ba16ac9fa5859580e","user":{"login":"rubinius","id":317747,"avatar_url":"https://avatars.githubusercontent.com/u/317747?v=3","gravatar_id":"","url":"https://api.github.com/users/rubinius","html_url":"https://github.com/rubinius","followers_url":"https://api.github.com/users/rubinius/followers","following_url":"https://api.github.com/users/rubinius/following{/other_user}","gists_url":"https://api.github.com/users/rubinius/gists{/gist_id}","starred_url":"https://api.github.com/users/rubinius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubinius/subscriptions","organizations_url":"https://api.github.com/users/rubinius/orgs","repos_url":"https://api.github.com/users/rubinius/repos","events_url":"https://api.github.com/users/rubinius/events{/privacy}","received_events_url":"https://api.github.com/users/rubinius/received_events","type":"Organization","site_admin":false},"repo":{"id":27,"name":"rubinius","full_name":"rubinius/rubinius","owner":{"login":"rubinius","id":317747,"avatar_url":"https://avatars.githubusercontent.com/u/317747?v=3","gravatar_id":"","url":"https://api.github.com/users/rubinius","html_url":"https://github.com/rubinius","followers_url":"https://api.github.com/users/rubinius/followers","following_url":"https://api.github.com/users/rubinius/following{/other_user}","gists_url":"https://api.github.com/users/rubinius/gists{/gist_id}","starred_url":"https://api.github.com/users/rubinius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubinius/subscriptions","organizations_url":"https://api.github.com/users/rubinius/orgs","repos_url":"https://api.github.com/users/rubinius/repos","events_url":"https://api.github.com/users/rubinius/events{/privacy}","received_events_url":"https://api.github.com/users/rubinius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubinius/rubinius","description":"The Rubinius Language Platform","fork":false,"url":"https://api.github.com/repos/rubinius/rubinius","forks_url":"https://api.github.com/repos/rubinius/rubinius/forks","keys_url":"https://api.github.com/repos/rubinius/rubinius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubinius/rubinius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubinius/rubinius/teams","hooks_url":"https://api.github.com/repos/rubinius/rubinius/hooks","issue_events_url":"https://api.github.com/repos/rubinius/rubinius/issues/events{/number}","events_url":"https://api.github.com/repos/rubinius/rubinius/events","assignees_url":"https://api.github.com/repos/rubinius/rubinius/assignees{/user}","branches_url":"https://api.github.com/repos/rubinius/rubinius/branches{/branch}","tags_url":"https://api.github.com/repos/rubinius/rubinius/tags","blobs_url":"https://api.github.com/repos/rubinius/rubinius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubinius/rubinius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubinius/rubinius/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubinius/rubinius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubinius/rubinius/statuses/{sha}","languages_url":"https://api.github.com/repos/rubinius/rubinius/languages","stargazers_url":"https://api.github.com/repos/rubinius/rubinius/stargazers","contributors_url":"https://api.github.com/repos/rubinius/rubinius/contributors","subscribers_url":"https://api.github.com/repos/rubinius/rubinius/subscribers","subscription_url":"https://api.github.com/repos/rubinius/rubinius/subscription","commits_url":"https://api.github.com/repos/rubinius/rubinius/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubinius/rubinius/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubinius/rubinius/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubinius/rubinius/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubinius/rubinius/contents/{+path}","compare_url":"https://api.github.com/repos/rubinius/rubinius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubinius/rubinius/merges","archive_url":"https://api.github.com/repos/rubinius/rubinius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubinius/rubinius/downloads","issues_url":"https://api.github.com/repos/rubinius/rubinius/issues{/number}","pulls_url":"https://api.github.com/repos/rubinius/rubinius/pulls{/number}","milestones_url":"https://api.github.com/repos/rubinius/rubinius/milestones{/number}","notifications_url":"https://api.github.com/repos/rubinius/rubinius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubinius/rubinius/labels{/name}","releases_url":"https://api.github.com/repos/rubinius/rubinius/releases{/id}","created_at":"2008-01-12T16:46:52Z","updated_at":"2016-01-15T19:15:23Z","pushed_at":"2016-01-16T22:00:18Z","git_url":"git://github.com/rubinius/rubinius.git","ssh_url":"git@github.com:rubinius/rubinius.git","clone_url":"https://github.com/rubinius/rubinius.git","svn_url":"https://github.com/rubinius/rubinius","homepage":"http://rubinius.com","size":176336,"stargazers_count":2548,"watchers_count":2548,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":597,"mirror_url":null,"open_issues_count":197,"forks":597,"open_issues":197,"watchers":2548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/3578"},"html":{"href":"https://github.com/rubinius/rubinius/pull/3578"},"issue":{"href":"https://api.github.com/repos/rubinius/rubinius/issues/3578"},"comments":{"href":"https://api.github.com/repos/rubinius/rubinius/issues/3578/comments"},"review_comments":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/3578/comments"},"review_comment":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/3578/commits"},"statuses":{"href":"https://api.github.com/repos/rubinius/rubinius/statuses/317ba57d74521ed38bec9706d9ca9921d05de331"}}}}