{"action":"opened","number":3814,"pull_request":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3814","id":86140079,"html_url":"https://github.com/pioneerspacesim/pioneer/pull/3814","diff_url":"https://github.com/pioneerspacesim/pioneer/pull/3814.diff","patch_url":"https://github.com/pioneerspacesim/pioneer/pull/3814.patch","issue_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3814","number":3814,"state":"open","locked":false,"title":"Model pattern range and status checking","user":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars.githubusercontent.com/u/825083?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"body":"<!-- Please describe new feature, possible with screenshot if needed. -->\r\nThis PR does two things:\r\n - Check that a model actually supports patterns before using them,\r\n - Limit the range correctly by subtracting 1 from `GetNumPatterns()`\r\n\r\nThanks to @clausimu for discovering that this was wrong!\r\n<!-- Please make sure you've read documentation on contributing -->\r\n\r\n","created_at":"2016-09-21T10:55:49Z","updated_at":"2016-09-21T10:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"797b1f435306b1aa1ee0c91db43d00c49a2cd473","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3814/commits","review_comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3814/comments","review_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3814/comments","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/f63b844b46ee76576d24085560c4ff63fcdc872f","head":{"label":"fluffyfreak:pattern-limit","ref":"pattern-limit","sha":"f63b844b46ee76576d24085560c4ff63fcdc872f","user":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars.githubusercontent.com/u/825083?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"repo":{"id":1836647,"name":"pioneer","full_name":"fluffyfreak/pioneer","owner":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars.githubusercontent.com/u/825083?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fluffyfreak/pioneer","description":"space simulation adventure game","fork":true,"url":"https://api.github.com/repos/fluffyfreak/pioneer","forks_url":"https://api.github.com/repos/fluffyfreak/pioneer/forks","keys_url":"https://api.github.com/repos/fluffyfreak/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluffyfreak/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluffyfreak/pioneer/teams","hooks_url":"https://api.github.com/repos/fluffyfreak/pioneer/hooks","issue_events_url":"https://api.github.com/repos/fluffyfreak/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/fluffyfreak/pioneer/events","assignees_url":"https://api.github.com/repos/fluffyfreak/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/fluffyfreak/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/fluffyfreak/pioneer/tags","blobs_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluffyfreak/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/fluffyfreak/pioneer/languages","stargazers_url":"https://api.github.com/repos/fluffyfreak/pioneer/stargazers","contributors_url":"https://api.github.com/repos/fluffyfreak/pioneer/contributors","subscribers_url":"https://api.github.com/repos/fluffyfreak/pioneer/subscribers","subscription_url":"https://api.github.com/repos/fluffyfreak/pioneer/subscription","commits_url":"https://api.github.com/repos/fluffyfreak/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluffyfreak/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluffyfreak/pioneer/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluffyfreak/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/fluffyfreak/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluffyfreak/pioneer/merges","archive_url":"https://api.github.com/repos/fluffyfreak/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluffyfreak/pioneer/downloads","issues_url":"https://api.github.com/repos/fluffyfreak/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/fluffyfreak/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/fluffyfreak/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/fluffyfreak/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluffyfreak/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/fluffyfreak/pioneer/releases{/id}","deployments_url":"https://api.github.com/repos/fluffyfreak/pioneer/deployments","created_at":"2011-06-02T10:53:44Z","updated_at":"2016-09-03T19:05:10Z","pushed_at":"2016-09-21T10:52:57Z","git_url":"git://github.com/fluffyfreak/pioneer.git","ssh_url":"git@github.com:fluffyfreak/pioneer.git","clone_url":"https://github.com/fluffyfreak/pioneer.git","svn_url":"https://github.com/fluffyfreak/pioneer","homepage":"http://pioneerspacesim.net/","size":853757,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":3,"default_branch":"master"}},"base":{"label":"pioneerspacesim:master","ref":"master","sha":"5faa2e9f3e4acafe6f3c5cab8b8c205bea983c87","user":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"repo":{"id":1593053,"name":"pioneer","full_name":"pioneerspacesim/pioneer","owner":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneerspacesim/pioneer","description":"A game of lonely space adventure","fork":false,"url":"https://api.github.com/repos/pioneerspacesim/pioneer","forks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/forks","keys_url":"https://api.github.com/repos/pioneerspacesim/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneerspacesim/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneerspacesim/pioneer/teams","hooks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/hooks","issue_events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/events","assignees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/pioneerspacesim/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/tags","blobs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneerspacesim/pioneer/languages","stargazers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/stargazers","contributors_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contributors","subscribers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscribers","subscription_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscription","commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/comments{/number}","contents_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/pioneerspacesim/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneerspacesim/pioneer/merges","archive_url":"https://api.github.com/repos/pioneerspacesim/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneerspacesim/pioneer/downloads","issues_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneerspacesim/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneerspacesim/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/pioneerspacesim/pioneer/releases{/id}","deployments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/deployments","created_at":"2011-04-09T22:17:05Z","updated_at":"2016-09-18T10:13:48Z","pushed_at":"2016-09-21T10:55:49Z","git_url":"git://github.com/pioneerspacesim/pioneer.git","ssh_url":"git@github.com:pioneerspacesim/pioneer.git","clone_url":"https://github.com/pioneerspacesim/pioneer.git","svn_url":"https://github.com/pioneerspacesim/pioneer","homepage":"http://pioneerspacesim.net/","size":1446506,"stargazers_count":550,"watchers_count":550,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":296,"forks":238,"open_issues":296,"watchers":550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3814"},"html":{"href":"https://github.com/pioneerspacesim/pioneer/pull/3814"},"issue":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3814"},"comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3814/comments"},"review_comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3814/comments"},"review_comment":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3814/commits"},"statuses":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/f63b844b46ee76576d24085560c4ff63fcdc872f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":11,"changed_files":5}}
{"actor":{"display_login":"fluffyfreak"}}