{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8226","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8226/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8226/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8226/events","html_url":"https://github.com/cockroachdb/cockroach/pull/8226","id":168894178,"number":8226,"title":"gossip: don't add self resolver to gossip during bootstrapping","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-02T14:06:42Z","updated_at":"2016-08-02T15:45:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8226","html_url":"https://github.com/cockroachdb/cockroach/pull/8226","diff_url":"https://github.com/cockroachdb/cockroach/pull/8226.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8226.patch"},"body":"It's not clear from the code why we added a self resolver during\nbootstrapping. It doesn't appear to be necessary and doing so created a\ndiscrepancy between starting a node and going through bootstrapping and\nrestarting an existing single node cluster. In the latter case we\nwouldn't have a self resolver while in the former we would.\n\nDon't signal the stalled channel if there are no resolvers as is the\ncase in a single node cluster.\n\nSee #8129\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8226)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/236946731","html_url":"https://github.com/cockroachdb/cockroach/pull/8226#issuecomment-236946731","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8226","id":236946731,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T15:45:31Z","updated_at":"2016-08-02T15:45:31Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\nI don't know why the self resolver was added either. \n\n---\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/8226#-:-KOAvS3iXyc577D7Zvi9:-238018792)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"bdarnell"}}