{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/10768","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/10768/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/10768/comments","events_url":"https://api.github.com/repos/servo/servo/issues/10768/events","html_url":"https://github.com/servo/servo/pull/10768","id":149933211,"number":10768,"title":"Extract out 'net/storage_thread' into separate components.","user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-04-21T01:36:25Z","updated_at":"2016-04-25T20:31:01Z","closed_at":"2016-04-25T20:31:01Z","pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/10768","html_url":"https://github.com/servo/servo/pull/10768","diff_url":"https://github.com/servo/servo/pull/10768.diff","patch_url":"https://github.com/servo/servo/pull/10768.patch"},"body":"The logic for `storage_thread.rs` (in `net` and `net_traits`) is\r\nalready isolated from the rest of the other modules in the crates.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/10768)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/214511321","html_url":"https://github.com/servo/servo/pull/10768#issuecomment-214511321","issue_url":"https://api.github.com/repos/servo/servo/issues/10768","id":214511321,"user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"created_at":"2016-04-25T20:31:01Z","updated_at":"2016-04-25T20:31:01Z","body":"Thanks for investigating this! I think the argument against doing this now is that the net crate builds quickly, and each new crate introduces a little bit more cognitive overhead when figuring out dependencies. Since I don't see a compelling reason to make this split right now in terms of addressing a known problem or facilitating a known improvement, I'm going to go ahead and close this."}}