{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/335","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/335/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/335/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/335/events","html_url":"https://github.com/trilinos/Trilinos/issues/335","id":153037919,"number":335,"title":"NOX:  Handling of model changes in Thyra::NOXNonlinearSolver","user":{"login":"etphipp","id":9464144,"avatar_url":"https://avatars.githubusercontent.com/u/9464144?v=3","gravatar_id":"","url":"https://api.github.com/users/etphipp","html_url":"https://github.com/etphipp","followers_url":"https://api.github.com/users/etphipp/followers","following_url":"https://api.github.com/users/etphipp/following{/other_user}","gists_url":"https://api.github.com/users/etphipp/gists{/gist_id}","starred_url":"https://api.github.com/users/etphipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etphipp/subscriptions","organizations_url":"https://api.github.com/users/etphipp/orgs","repos_url":"https://api.github.com/users/etphipp/repos","events_url":"https://api.github.com/users/etphipp/events{/privacy}","received_events_url":"https://api.github.com/users/etphipp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trilinos/Trilinos/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/trilinos/Trilinos/labels/NOX","name":"NOX","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"rppawlo","id":2109877,"avatar_url":"https://avatars.githubusercontent.com/u/2109877?v=3","gravatar_id":"","url":"https://api.github.com/users/rppawlo","html_url":"https://github.com/rppawlo","followers_url":"https://api.github.com/users/rppawlo/followers","following_url":"https://api.github.com/users/rppawlo/following{/other_user}","gists_url":"https://api.github.com/users/rppawlo/gists{/gist_id}","starred_url":"https://api.github.com/users/rppawlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rppawlo/subscriptions","organizations_url":"https://api.github.com/users/rppawlo/orgs","repos_url":"https://api.github.com/users/rppawlo/repos","events_url":"https://api.github.com/users/rppawlo/events{/privacy}","received_events_url":"https://api.github.com/users/rppawlo/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-05-04T15:15:19Z","updated_at":"2016-05-20T13:40:46Z","closed_at":null,"body":"The Thyra::NOXNonlinearSolver has a method to update the Thyra::ModelEvaluator model used within the nonlinear solve, however that model is not propagated to the internal NOX group if the internal solver has already been setup.  I ran into this with Dakota/ROL runs where I was doing a sequence of transient solves at different parameter values.  After each transient solve, a new model is created however the same nonlinear solver is reused.  After the first transient solve, we would compute a new model and set it in the nonlinear solver, but subsequent nonlinear solves were still using the old model.  We can work around this by reseting the solver after each transient run, but it would be ideal of the NOXNonlinearSolver handled this.\r\n\r\n@rppawlo @eric-c-cyr"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/220608327","html_url":"https://github.com/trilinos/Trilinos/issues/335#issuecomment-220608327","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/335","id":220608327,"user":{"login":"rppawlo","id":2109877,"avatar_url":"https://avatars.githubusercontent.com/u/2109877?v=3","gravatar_id":"","url":"https://api.github.com/users/rppawlo","html_url":"https://github.com/rppawlo","followers_url":"https://api.github.com/users/rppawlo/followers","following_url":"https://api.github.com/users/rppawlo/following{/other_user}","gists_url":"https://api.github.com/users/rppawlo/gists{/gist_id}","starred_url":"https://api.github.com/users/rppawlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rppawlo/subscriptions","organizations_url":"https://api.github.com/users/rppawlo/orgs","repos_url":"https://api.github.com/users/rppawlo/repos","events_url":"https://api.github.com/users/rppawlo/events{/privacy}","received_events_url":"https://api.github.com/users/rppawlo/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T13:40:46Z","updated_at":"2016-05-20T13:40:46Z","body":"@etphipp the solvers and the groups currently don't accept a new model. The assumption was that if a new model is set then you need to rebuild the solver. To add this functionality I would need to add a new method to the base classes and then add the logic to all solvers to loop over owned groups. I can do that, but it will require more work to all solvers and groups. A simpler alternative is that if we set the model on the Thyra::NOXNonlinearSolver then it will automatically rebuild the group. If that is ok, that will be much quicker to implement."}}
{"actor":{"display_login":"rppawlo"}}