{"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/comments/84634279","pull_request_review_id":5398600,"id":84634279,"diff_hunk":"@@ -6,16 +6,18 @@\n use Pim\\Bundle\\ExtendedMeasureBundle\\Exception\\UnresolvableUnitException;\n \n /**\n- * Resolve a measure to a a PIM unit\n+ * Resolve a measure to a a PIM unit by its symbol or unit.\n  *\n  * @author JM Leroux <jean-marie.leroux@akeneo.com>\n  */\n class MeasureResolver implements MeasureResolverInterface\n {\n     /**\n+     * Akeneo PIM merged measures configurations\n+     *\n      * @var array\n      */\n-    private $config;\n+    private $pimConfig;","path":"src/Resolver/MeasureResolver.php","position":17,"original_position":17,"commit_id":"4acf7bafc24f2f1eff1d52da1daa2d31e87918d5","original_commit_id":"4acf7bafc24f2f1eff1d52da1daa2d31e87918d5","user":{"login":"fitn","id":2131005,"avatar_url":"https://avatars.githubusercontent.com/u/2131005?v=3","gravatar_id":"","url":"https://api.github.com/users/fitn","html_url":"https://github.com/fitn","followers_url":"https://api.github.com/users/fitn/followers","following_url":"https://api.github.com/users/fitn/following{/other_user}","gists_url":"https://api.github.com/users/fitn/gists{/gist_id}","starred_url":"https://api.github.com/users/fitn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitn/subscriptions","organizations_url":"https://api.github.com/users/fitn/orgs","repos_url":"https://api.github.com/users/fitn/repos","events_url":"https://api.github.com/users/fitn/events{/privacy}","received_events_url":"https://api.github.com/users/fitn/received_events","type":"User","site_admin":false},"body":"Could be removed","created_at":"2016-10-24T07:45:24Z","updated_at":"2016-10-24T07:47:51Z","html_url":"https://github.com/akeneo/ExtendedMeasureBundle/pull/9#discussion_r84634279","pull_request_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/comments/84634279"},"html":{"href":"https://github.com/akeneo/ExtendedMeasureBundle/pull/9#discussion_r84634279"},"pull_request":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9","id":90480186,"html_url":"https://github.com/akeneo/ExtendedMeasureBundle/pull/9","diff_url":"https://github.com/akeneo/ExtendedMeasureBundle/pull/9.diff","patch_url":"https://github.com/akeneo/ExtendedMeasureBundle/pull/9.patch","issue_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/9","number":9,"state":"open","locked":false,"title":"DI configuration + specs","user":{"login":"jmleroux","id":1516770,"avatar_url":"https://avatars.githubusercontent.com/u/1516770?v=3","gravatar_id":"","url":"https://api.github.com/users/jmleroux","html_url":"https://github.com/jmleroux","followers_url":"https://api.github.com/users/jmleroux/followers","following_url":"https://api.github.com/users/jmleroux/following{/other_user}","gists_url":"https://api.github.com/users/jmleroux/gists{/gist_id}","starred_url":"https://api.github.com/users/jmleroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmleroux/subscriptions","organizations_url":"https://api.github.com/users/jmleroux/orgs","repos_url":"https://api.github.com/users/jmleroux/repos","events_url":"https://api.github.com/users/jmleroux/events{/privacy}","received_events_url":"https://api.github.com/users/jmleroux/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-22T12:15:40Z","updated_at":"2016-10-24T07:47:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4aacf30c1974240cf8530e9caf69afb23c440ca","assignee":{"login":"jmleroux","id":1516770,"avatar_url":"https://avatars.githubusercontent.com/u/1516770?v=3","gravatar_id":"","url":"https://api.github.com/users/jmleroux","html_url":"https://github.com/jmleroux","followers_url":"https://api.github.com/users/jmleroux/followers","following_url":"https://api.github.com/users/jmleroux/following{/other_user}","gists_url":"https://api.github.com/users/jmleroux/gists{/gist_id}","starred_url":"https://api.github.com/users/jmleroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmleroux/subscriptions","organizations_url":"https://api.github.com/users/jmleroux/orgs","repos_url":"https://api.github.com/users/jmleroux/repos","events_url":"https://api.github.com/users/jmleroux/events{/privacy}","received_events_url":"https://api.github.com/users/jmleroux/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmleroux","id":1516770,"avatar_url":"https://avatars.githubusercontent.com/u/1516770?v=3","gravatar_id":"","url":"https://api.github.com/users/jmleroux","html_url":"https://github.com/jmleroux","followers_url":"https://api.github.com/users/jmleroux/followers","following_url":"https://api.github.com/users/jmleroux/following{/other_user}","gists_url":"https://api.github.com/users/jmleroux/gists{/gist_id}","starred_url":"https://api.github.com/users/jmleroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmleroux/subscriptions","organizations_url":"https://api.github.com/users/jmleroux/orgs","repos_url":"https://api.github.com/users/jmleroux/repos","events_url":"https://api.github.com/users/jmleroux/events{/privacy}","received_events_url":"https://api.github.com/users/jmleroux/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9/commits","review_comments_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9/comments","review_comment_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/9/comments","statuses_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/statuses/4acf7bafc24f2f1eff1d52da1daa2d31e87918d5","head":{"label":"akeneo:jml-di-configuration","ref":"jml-di-configuration","sha":"4acf7bafc24f2f1eff1d52da1daa2d31e87918d5","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":70821527,"name":"ExtendedMeasureBundle","full_name":"akeneo/ExtendedMeasureBundle","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/ExtendedMeasureBundle","description":"Extended measures for Akeno PIM","fork":false,"url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle","forks_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/forks","keys_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/teams","hooks_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/hooks","issue_events_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/events","assignees_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/tags","blobs_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/languages","stargazers_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/stargazers","contributors_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/contributors","subscribers_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/subscribers","subscription_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/subscription","commits_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/merges","archive_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/downloads","issues_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/deployments","created_at":"2016-10-13T15:36:00Z","updated_at":"2016-10-18T16:01:52Z","pushed_at":"2016-10-24T07:05:43Z","git_url":"git://github.com/akeneo/ExtendedMeasureBundle.git","ssh_url":"git@github.com:akeneo/ExtendedMeasureBundle.git","clone_url":"https://github.com/akeneo/ExtendedMeasureBundle.git","svn_url":"https://github.com/akeneo/ExtendedMeasureBundle","homepage":"","size":67,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"akeneo:master","ref":"master","sha":"29cfd451a48fb4238ade3fe56570999460c8c9f3","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":70821527,"name":"ExtendedMeasureBundle","full_name":"akeneo/ExtendedMeasureBundle","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/ExtendedMeasureBundle","description":"Extended measures for Akeno PIM","fork":false,"url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle","forks_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/forks","keys_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/teams","hooks_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/hooks","issue_events_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/events","assignees_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/tags","blobs_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/languages","stargazers_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/stargazers","contributors_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/contributors","subscribers_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/subscribers","subscription_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/subscription","commits_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/merges","archive_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/downloads","issues_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/deployments","created_at":"2016-10-13T15:36:00Z","updated_at":"2016-10-18T16:01:52Z","pushed_at":"2016-10-24T07:05:43Z","git_url":"git://github.com/akeneo/ExtendedMeasureBundle.git","ssh_url":"git@github.com:akeneo/ExtendedMeasureBundle.git","clone_url":"https://github.com/akeneo/ExtendedMeasureBundle.git","svn_url":"https://github.com/akeneo/ExtendedMeasureBundle","homepage":"","size":67,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9"},"html":{"href":"https://github.com/akeneo/ExtendedMeasureBundle/pull/9"},"issue":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/9"},"comments":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/ExtendedMeasureBundle/statuses/4acf7bafc24f2f1eff1d52da1daa2d31e87918d5"}}}}
{"actor":{"display_login":"fitn"}}