{"action":"opened","number":288,"pull_request":{"url":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/288","id":63470965,"html_url":"https://github.com/unexpectedjs/unexpected/pull/288","diff_url":"https://github.com/unexpectedjs/unexpected/pull/288.diff","patch_url":"https://github.com/unexpectedjs/unexpected/pull/288.patch","issue_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/288","number":288,"state":"open","locked":false,"title":"add eslint and use the onelint shared configuration","user":{"login":"gustavnikolaj","id":1371503,"avatar_url":"https://avatars.githubusercontent.com/u/1371503?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavnikolaj","html_url":"https://github.com/gustavnikolaj","followers_url":"https://api.github.com/users/gustavnikolaj/followers","following_url":"https://api.github.com/users/gustavnikolaj/following{/other_user}","gists_url":"https://api.github.com/users/gustavnikolaj/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavnikolaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavnikolaj/subscriptions","organizations_url":"https://api.github.com/users/gustavnikolaj/orgs","repos_url":"https://api.github.com/users/gustavnikolaj/repos","events_url":"https://api.github.com/users/gustavnikolaj/events{/privacy}","received_events_url":"https://api.github.com/users/gustavnikolaj/received_events","type":"User","site_admin":false},"body":"@sunesimonsen here's a demo of the integration with eslint and eslint-config-onelint, as we talked briefly about last time. Let me know what you think. If you would like to many any changes (in case you like it enough to adopt it) feel free to ask for them. I know that there's probably some differences between the existing unexpected linter config and the onelint setup that I ported.\r\n\r\nIt was a pretty easy transition to make, but there's one thing I'm still not quite certain about.\r\n\r\n[Eslint does not have a preset for an es3 environment](https://github.com/eslint/eslint/issues/2835), as you use with jshint. There were some comments ignoring specific portions of the code because of that, that I could just remove.\r\n\r\nI don't know what implications that might have, with regards to browser support, if someone accidentally adds something that jshint in es3 mode would have caugt.","created_at":"2016-03-19T15:54:24Z","updated_at":"2016-03-19T15:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/288/commits","review_comments_url":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/288/comments","review_comment_url":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/288/comments","statuses_url":"https://api.github.com/repos/unexpectedjs/unexpected/statuses/d336f565861c7b206d7306033f54b29a64a113ac","head":{"label":"unexpectedjs:feature/onelint","ref":"feature/onelint","sha":"d336f565861c7b206d7306033f54b29a64a113ac","user":{"login":"unexpectedjs","id":11270290,"avatar_url":"https://avatars.githubusercontent.com/u/11270290?v=3","gravatar_id":"","url":"https://api.github.com/users/unexpectedjs","html_url":"https://github.com/unexpectedjs","followers_url":"https://api.github.com/users/unexpectedjs/followers","following_url":"https://api.github.com/users/unexpectedjs/following{/other_user}","gists_url":"https://api.github.com/users/unexpectedjs/gists{/gist_id}","starred_url":"https://api.github.com/users/unexpectedjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unexpectedjs/subscriptions","organizations_url":"https://api.github.com/users/unexpectedjs/orgs","repos_url":"https://api.github.com/users/unexpectedjs/repos","events_url":"https://api.github.com/users/unexpectedjs/events{/privacy}","received_events_url":"https://api.github.com/users/unexpectedjs/received_events","type":"Organization","site_admin":false},"repo":{"id":9507628,"name":"unexpected","full_name":"unexpectedjs/unexpected","owner":{"login":"unexpectedjs","id":11270290,"avatar_url":"https://avatars.githubusercontent.com/u/11270290?v=3","gravatar_id":"","url":"https://api.github.com/users/unexpectedjs","html_url":"https://github.com/unexpectedjs","followers_url":"https://api.github.com/users/unexpectedjs/followers","following_url":"https://api.github.com/users/unexpectedjs/following{/other_user}","gists_url":"https://api.github.com/users/unexpectedjs/gists{/gist_id}","starred_url":"https://api.github.com/users/unexpectedjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unexpectedjs/subscriptions","organizations_url":"https://api.github.com/users/unexpectedjs/orgs","repos_url":"https://api.github.com/users/unexpectedjs/repos","events_url":"https://api.github.com/users/unexpectedjs/events{/privacy}","received_events_url":"https://api.github.com/users/unexpectedjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unexpectedjs/unexpected","description":"The extensible BDD assertion toolkit","fork":false,"url":"https://api.github.com/repos/unexpectedjs/unexpected","forks_url":"https://api.github.com/repos/unexpectedjs/unexpected/forks","keys_url":"https://api.github.com/repos/unexpectedjs/unexpected/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unexpectedjs/unexpected/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unexpectedjs/unexpected/teams","hooks_url":"https://api.github.com/repos/unexpectedjs/unexpected/hooks","issue_events_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/events{/number}","events_url":"https://api.github.com/repos/unexpectedjs/unexpected/events","assignees_url":"https://api.github.com/repos/unexpectedjs/unexpected/assignees{/user}","branches_url":"https://api.github.com/repos/unexpectedjs/unexpected/branches{/branch}","tags_url":"https://api.github.com/repos/unexpectedjs/unexpected/tags","blobs_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/refs{/sha}","trees_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unexpectedjs/unexpected/statuses/{sha}","languages_url":"https://api.github.com/repos/unexpectedjs/unexpected/languages","stargazers_url":"https://api.github.com/repos/unexpectedjs/unexpected/stargazers","contributors_url":"https://api.github.com/repos/unexpectedjs/unexpected/contributors","subscribers_url":"https://api.github.com/repos/unexpectedjs/unexpected/subscribers","subscription_url":"https://api.github.com/repos/unexpectedjs/unexpected/subscription","commits_url":"https://api.github.com/repos/unexpectedjs/unexpected/commits{/sha}","git_commits_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/commits{/sha}","comments_url":"https://api.github.com/repos/unexpectedjs/unexpected/comments{/number}","issue_comment_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/comments{/number}","contents_url":"https://api.github.com/repos/unexpectedjs/unexpected/contents/{+path}","compare_url":"https://api.github.com/repos/unexpectedjs/unexpected/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unexpectedjs/unexpected/merges","archive_url":"https://api.github.com/repos/unexpectedjs/unexpected/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unexpectedjs/unexpected/downloads","issues_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues{/number}","pulls_url":"https://api.github.com/repos/unexpectedjs/unexpected/pulls{/number}","milestones_url":"https://api.github.com/repos/unexpectedjs/unexpected/milestones{/number}","notifications_url":"https://api.github.com/repos/unexpectedjs/unexpected/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unexpectedjs/unexpected/labels{/name}","releases_url":"https://api.github.com/repos/unexpectedjs/unexpected/releases{/id}","deployments_url":"https://api.github.com/repos/unexpectedjs/unexpected/deployments","created_at":"2013-04-17T21:08:28Z","updated_at":"2016-03-10T09:08:38Z","pushed_at":"2016-03-19T15:48:42Z","git_url":"git://github.com/unexpectedjs/unexpected.git","ssh_url":"git@github.com:unexpectedjs/unexpected.git","clone_url":"https://github.com/unexpectedjs/unexpected.git","svn_url":"https://github.com/unexpectedjs/unexpected","homepage":"http://unexpected.js.org/","size":9204,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":29,"forks":8,"open_issues":29,"watchers":131,"default_branch":"master"}},"base":{"label":"unexpectedjs:master","ref":"master","sha":"6c9ff6e93a7da95689f773f9dfef0b7cc8ee5c0e","user":{"login":"unexpectedjs","id":11270290,"avatar_url":"https://avatars.githubusercontent.com/u/11270290?v=3","gravatar_id":"","url":"https://api.github.com/users/unexpectedjs","html_url":"https://github.com/unexpectedjs","followers_url":"https://api.github.com/users/unexpectedjs/followers","following_url":"https://api.github.com/users/unexpectedjs/following{/other_user}","gists_url":"https://api.github.com/users/unexpectedjs/gists{/gist_id}","starred_url":"https://api.github.com/users/unexpectedjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unexpectedjs/subscriptions","organizations_url":"https://api.github.com/users/unexpectedjs/orgs","repos_url":"https://api.github.com/users/unexpectedjs/repos","events_url":"https://api.github.com/users/unexpectedjs/events{/privacy}","received_events_url":"https://api.github.com/users/unexpectedjs/received_events","type":"Organization","site_admin":false},"repo":{"id":9507628,"name":"unexpected","full_name":"unexpectedjs/unexpected","owner":{"login":"unexpectedjs","id":11270290,"avatar_url":"https://avatars.githubusercontent.com/u/11270290?v=3","gravatar_id":"","url":"https://api.github.com/users/unexpectedjs","html_url":"https://github.com/unexpectedjs","followers_url":"https://api.github.com/users/unexpectedjs/followers","following_url":"https://api.github.com/users/unexpectedjs/following{/other_user}","gists_url":"https://api.github.com/users/unexpectedjs/gists{/gist_id}","starred_url":"https://api.github.com/users/unexpectedjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unexpectedjs/subscriptions","organizations_url":"https://api.github.com/users/unexpectedjs/orgs","repos_url":"https://api.github.com/users/unexpectedjs/repos","events_url":"https://api.github.com/users/unexpectedjs/events{/privacy}","received_events_url":"https://api.github.com/users/unexpectedjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unexpectedjs/unexpected","description":"The extensible BDD assertion toolkit","fork":false,"url":"https://api.github.com/repos/unexpectedjs/unexpected","forks_url":"https://api.github.com/repos/unexpectedjs/unexpected/forks","keys_url":"https://api.github.com/repos/unexpectedjs/unexpected/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unexpectedjs/unexpected/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unexpectedjs/unexpected/teams","hooks_url":"https://api.github.com/repos/unexpectedjs/unexpected/hooks","issue_events_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/events{/number}","events_url":"https://api.github.com/repos/unexpectedjs/unexpected/events","assignees_url":"https://api.github.com/repos/unexpectedjs/unexpected/assignees{/user}","branches_url":"https://api.github.com/repos/unexpectedjs/unexpected/branches{/branch}","tags_url":"https://api.github.com/repos/unexpectedjs/unexpected/tags","blobs_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/refs{/sha}","trees_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unexpectedjs/unexpected/statuses/{sha}","languages_url":"https://api.github.com/repos/unexpectedjs/unexpected/languages","stargazers_url":"https://api.github.com/repos/unexpectedjs/unexpected/stargazers","contributors_url":"https://api.github.com/repos/unexpectedjs/unexpected/contributors","subscribers_url":"https://api.github.com/repos/unexpectedjs/unexpected/subscribers","subscription_url":"https://api.github.com/repos/unexpectedjs/unexpected/subscription","commits_url":"https://api.github.com/repos/unexpectedjs/unexpected/commits{/sha}","git_commits_url":"https://api.github.com/repos/unexpectedjs/unexpected/git/commits{/sha}","comments_url":"https://api.github.com/repos/unexpectedjs/unexpected/comments{/number}","issue_comment_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/comments{/number}","contents_url":"https://api.github.com/repos/unexpectedjs/unexpected/contents/{+path}","compare_url":"https://api.github.com/repos/unexpectedjs/unexpected/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unexpectedjs/unexpected/merges","archive_url":"https://api.github.com/repos/unexpectedjs/unexpected/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unexpectedjs/unexpected/downloads","issues_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues{/number}","pulls_url":"https://api.github.com/repos/unexpectedjs/unexpected/pulls{/number}","milestones_url":"https://api.github.com/repos/unexpectedjs/unexpected/milestones{/number}","notifications_url":"https://api.github.com/repos/unexpectedjs/unexpected/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unexpectedjs/unexpected/labels{/name}","releases_url":"https://api.github.com/repos/unexpectedjs/unexpected/releases{/id}","deployments_url":"https://api.github.com/repos/unexpectedjs/unexpected/deployments","created_at":"2013-04-17T21:08:28Z","updated_at":"2016-03-10T09:08:38Z","pushed_at":"2016-03-19T15:48:42Z","git_url":"git://github.com/unexpectedjs/unexpected.git","ssh_url":"git@github.com:unexpectedjs/unexpected.git","clone_url":"https://github.com/unexpectedjs/unexpected.git","svn_url":"https://github.com/unexpectedjs/unexpected","homepage":"http://unexpected.js.org/","size":9204,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":29,"forks":8,"open_issues":29,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/288"},"html":{"href":"https://github.com/unexpectedjs/unexpected/pull/288"},"issue":{"href":"https://api.github.com/repos/unexpectedjs/unexpected/issues/288"},"comments":{"href":"https://api.github.com/repos/unexpectedjs/unexpected/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/unexpectedjs/unexpected/statuses/d336f565861c7b206d7306033f54b29a64a113ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":34,"deletions":260,"changed_files":18}}