{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68333125","id":68333125,"diff_hunk":"@@ -0,0 +1,51 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+    http://www.apache.org/licenses/LICENSE-2.0\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package cm\n+\n+// ResourceConfig holds information about all the supported cgroup resource parameters.\n+type ResourceConfig struct {\n+\t// Memory limit (in bytes).\n+\tMemory *int64\n+\t// CPU shares (relative weight vs. other containers).\n+\tCpuShares *int64\n+\t// CPU hardcap limit (in usecs). Allowed cpu time in a given period.\n+\tCpuQuota *int64\n+}\n+\n+// CgroupConfig holds the cgroup configuration information.\n+// This is common object which is used to specify\n+// cgroup information to both systemd and raw cgroup fs\n+// implementation of the Cgroup Manager interface.\n+type CgroupConfig struct {\n+\t// We would expect systemd implementation to make appropriate\n+\t// name conversion. For example, if we pass /foo/bar\n+\t// then systemd should convert the name to something like\n+\t// foo.slice/foo-bar.slice\n+\n+\t// Fully qualified name\n+\tName string","path":"pkg/kubelet/cm/types.go","position":37,"original_position":37,"commit_id":"773b7e7144cb41cbb65d45b4e902e3888636af17","original_commit_id":"773b7e7144cb41cbb65d45b4e902e3888636af17","user":{"login":"dubstack","id":6484332,"avatar_url":"https://avatars.githubusercontent.com/u/6484332?v=3","gravatar_id":"","url":"https://api.github.com/users/dubstack","html_url":"https://github.com/dubstack","followers_url":"https://api.github.com/users/dubstack/followers","following_url":"https://api.github.com/users/dubstack/following{/other_user}","gists_url":"https://api.github.com/users/dubstack/gists{/gist_id}","starred_url":"https://api.github.com/users/dubstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubstack/subscriptions","organizations_url":"https://api.github.com/users/dubstack/orgs","repos_url":"https://api.github.com/users/dubstack/repos","events_url":"https://api.github.com/users/dubstack/events{/privacy}","received_events_url":"https://api.github.com/users/dubstack/received_events","type":"User","site_admin":false},"body":"Ack! Thanks.","created_at":"2016-06-23T23:29:45Z","updated_at":"2016-06-23T23:29:45Z","html_url":"https://github.com/kubernetes/kubernetes/pull/27755#discussion_r68333125","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68333125"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27755#discussion_r68333125"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755","id":74552231,"html_url":"https://github.com/kubernetes/kubernetes/pull/27755","diff_url":"https://github.com/kubernetes/kubernetes/pull/27755.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27755.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27755","number":27755,"state":"open","locked":false,"title":"[Do not Merge]Add support for basic QoS and pod level cgroup management","user":{"login":"dubstack","id":6484332,"avatar_url":"https://avatars.githubusercontent.com/u/6484332?v=3","gravatar_id":"","url":"https://api.github.com/users/dubstack","html_url":"https://github.com/dubstack","followers_url":"https://api.github.com/users/dubstack/followers","following_url":"https://api.github.com/users/dubstack/following{/other_user}","gists_url":"https://api.github.com/users/dubstack/gists{/gist_id}","starred_url":"https://api.github.com/users/dubstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubstack/subscriptions","organizations_url":"https://api.github.com/users/dubstack/orgs","repos_url":"https://api.github.com/users/dubstack/repos","events_url":"https://api.github.com/users/dubstack/events{/privacy}","received_events_url":"https://api.github.com/users/dubstack/received_events","type":"User","site_admin":false},"body":"This PR is a WIP and is tied to this upstream issue #27204 \r\nIt adds support for creation,deletion and updates of cgroups in Kubernetes.\r\n@vishh PTAL\r\n\r\nPlease note that the first commit is part of this PR: #27749\r\ncc @kubernetes/sig-node\r\n\r\nSigned-off-by: Buddha Prakash <buddhap@google.com>","created_at":"2016-06-21T05:10:11Z","updated_at":"2016-06-23T23:29:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e363097f760b61203d9f1b7056b63e02b7cc8ac","assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"assignees":[{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27755/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/773b7e7144cb41cbb65d45b4e902e3888636af17","head":{"label":"dubstack:dubstack-cgroup-interface","ref":"dubstack-cgroup-interface","sha":"773b7e7144cb41cbb65d45b4e902e3888636af17","user":{"login":"dubstack","id":6484332,"avatar_url":"https://avatars.githubusercontent.com/u/6484332?v=3","gravatar_id":"","url":"https://api.github.com/users/dubstack","html_url":"https://github.com/dubstack","followers_url":"https://api.github.com/users/dubstack/followers","following_url":"https://api.github.com/users/dubstack/following{/other_user}","gists_url":"https://api.github.com/users/dubstack/gists{/gist_id}","starred_url":"https://api.github.com/users/dubstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubstack/subscriptions","organizations_url":"https://api.github.com/users/dubstack/orgs","repos_url":"https://api.github.com/users/dubstack/repos","events_url":"https://api.github.com/users/dubstack/events{/privacy}","received_events_url":"https://api.github.com/users/dubstack/received_events","type":"User","site_admin":false},"repo":{"id":57923446,"name":"kubernetes","full_name":"dubstack/kubernetes","owner":{"login":"dubstack","id":6484332,"avatar_url":"https://avatars.githubusercontent.com/u/6484332?v=3","gravatar_id":"","url":"https://api.github.com/users/dubstack","html_url":"https://github.com/dubstack","followers_url":"https://api.github.com/users/dubstack/followers","following_url":"https://api.github.com/users/dubstack/following{/other_user}","gists_url":"https://api.github.com/users/dubstack/gists{/gist_id}","starred_url":"https://api.github.com/users/dubstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubstack/subscriptions","organizations_url":"https://api.github.com/users/dubstack/orgs","repos_url":"https://api.github.com/users/dubstack/repos","events_url":"https://api.github.com/users/dubstack/events{/privacy}","received_events_url":"https://api.github.com/users/dubstack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dubstack/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/dubstack/kubernetes","forks_url":"https://api.github.com/repos/dubstack/kubernetes/forks","keys_url":"https://api.github.com/repos/dubstack/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dubstack/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dubstack/kubernetes/teams","hooks_url":"https://api.github.com/repos/dubstack/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dubstack/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dubstack/kubernetes/events","assignees_url":"https://api.github.com/repos/dubstack/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dubstack/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dubstack/kubernetes/tags","blobs_url":"https://api.github.com/repos/dubstack/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dubstack/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dubstack/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dubstack/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dubstack/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dubstack/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dubstack/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dubstack/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dubstack/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dubstack/kubernetes/subscription","commits_url":"https://api.github.com/repos/dubstack/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dubstack/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dubstack/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dubstack/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dubstack/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dubstack/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dubstack/kubernetes/merges","archive_url":"https://api.github.com/repos/dubstack/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dubstack/kubernetes/downloads","issues_url":"https://api.github.com/repos/dubstack/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dubstack/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dubstack/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dubstack/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dubstack/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dubstack/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dubstack/kubernetes/deployments","created_at":"2016-05-02T21:46:26Z","updated_at":"2016-05-02T21:46:41Z","pushed_at":"2016-06-23T17:52:15Z","git_url":"git://github.com/dubstack/kubernetes.git","ssh_url":"git@github.com:dubstack/kubernetes.git","clone_url":"https://github.com/dubstack/kubernetes.git","svn_url":"https://github.com/dubstack/kubernetes","homepage":"http://kubernetes.io","size":271032,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1de2bddae7c3b8fbda741610cfc4d160d8a8f631","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-23T23:02:10Z","pushed_at":"2016-06-23T23:29:25Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":483152,"stargazers_count":15067,"watchers_count":15067,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4691,"mirror_url":null,"open_issues_count":3816,"forks":4691,"open_issues":3816,"watchers":15067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27755"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27755"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27755/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27755/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/773b7e7144cb41cbb65d45b4e902e3888636af17"}}}}
{"actor":{"display_login":"dubstack"}}