{"action":"created","issue":{"url":"https://api.github.com/repos/apache/nutch/issues/153","repository_url":"https://api.github.com/repos/apache/nutch","labels_url":"https://api.github.com/repos/apache/nutch/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/apache/nutch/issues/153/comments","events_url":"https://api.github.com/repos/apache/nutch/issues/153/events","html_url":"https://github.com/apache/nutch/pull/153","id":181402641,"number":153,"title":"Bug in setting default linkdb path","user":{"login":"sachin086","id":22659868,"avatar_url":"https://avatars.githubusercontent.com/u/22659868?v=3","gravatar_id":"","url":"https://api.github.com/users/sachin086","html_url":"https://github.com/sachin086","followers_url":"https://api.github.com/users/sachin086/followers","following_url":"https://api.github.com/users/sachin086/following{/other_user}","gists_url":"https://api.github.com/users/sachin086/gists{/gist_id}","starred_url":"https://api.github.com/users/sachin086/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachin086/subscriptions","organizations_url":"https://api.github.com/users/sachin086/orgs","repos_url":"https://api.github.com/users/sachin086/repos","events_url":"https://api.github.com/users/sachin086/events{/privacy}","received_events_url":"https://api.github.com/users/sachin086/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-06T12:36:06Z","updated_at":"2016-10-12T15:43:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/nutch/pulls/153","html_url":"https://github.com/apache/nutch/pull/153","diff_url":"https://github.com/apache/nutch/pull/153.diff","patch_url":"https://github.com/apache/nutch/pull/153.patch"},"body":"There was an extra if condition in run( ) method where it sets linkdb path. It is evident when we use nutch REST api.\r\n\r\nhttps://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/indexer/IndexingJob.java#L272"},"comment":{"url":"https://api.github.com/repos/apache/nutch/issues/comments/253251613","html_url":"https://github.com/apache/nutch/pull/153#issuecomment-253251613","issue_url":"https://api.github.com/repos/apache/nutch/issues/153","id":253251613,"user":{"login":"sujen1412","id":6220682,"avatar_url":"https://avatars.githubusercontent.com/u/6220682?v=3","gravatar_id":"","url":"https://api.github.com/users/sujen1412","html_url":"https://github.com/sujen1412","followers_url":"https://api.github.com/users/sujen1412/followers","following_url":"https://api.github.com/users/sujen1412/following{/other_user}","gists_url":"https://api.github.com/users/sujen1412/gists{/gist_id}","starred_url":"https://api.github.com/users/sujen1412/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sujen1412/subscriptions","organizations_url":"https://api.github.com/users/sujen1412/orgs","repos_url":"https://api.github.com/users/sujen1412/repos","events_url":"https://api.github.com/users/sujen1412/events{/privacy}","received_events_url":"https://api.github.com/users/sujen1412/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T15:43:20Z","updated_at":"2016-10-12T15:43:20Z","body":"Nice find, thank you @sachin086!\r\n\r\n@sebastian-nagel you're right, the intention was to have it like \r\n```   \r\n if(args.containsKey(Nutch.ARG_LINKDB)){\r\n    if(args.get(Nutch.ARG_LINKDB) != null) {\r\n```\r\n\r\nThis was because the other commands in the REST API do not require the user to give the full path of the crawldb, segment, linkdb directories as they are all mapped through their corresponding crawlIDs. \r\nHence, the args {} containing and key=linkdb with value=null would act as a flag indicating that the user wants to use the linkdb associated with this crawlId for indexing. \r\nOr else, if the value=<some path> then that would be used for the linkdb. \r\n\r\nIf there is a better way to achieve this please suggest, my thought to do it this way was to keep the format of requests for the job endpoint consistent across different jobs. \r\n"}}
{"actor":{"display_login":"sujen1412"}}