{"action":"created","comment":{"url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/comments/55751136","id":55751136,"diff_hunk":"@@ -0,0 +1,25 @@\n+package BusinessLogicLayer;\n+\n+import java.util.concurrent.atomic.AtomicInteger;\n+\n+/**\n+ * Created by HassanMahmud on 09/03/2016.\n+ */\n+public class IncrementalIDGenerator {\n+\n+    private AtomicInteger termAtomicInt = new AtomicInteger(0);\n+    private AtomicInteger documentAtomicInt = new AtomicInteger(0);\n+\n+//        UUID randomUUID = UUID.randomUUID();","path":"BusinessLogic/src/main/java/BusinessLogicLayer/IncrementalIDGenerator.java","position":13,"original_position":13,"commit_id":"b21369f88385eaaa9bc48325cb28e34500005988","original_commit_id":"b21369f88385eaaa9bc48325cb28e34500005988","user":{"login":"anthonymonori","id":935897,"avatar_url":"https://avatars.githubusercontent.com/u/935897?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonymonori","html_url":"https://github.com/anthonymonori","followers_url":"https://api.github.com/users/anthonymonori/followers","following_url":"https://api.github.com/users/anthonymonori/following{/other_user}","gists_url":"https://api.github.com/users/anthonymonori/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonymonori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonymonori/subscriptions","organizations_url":"https://api.github.com/users/anthonymonori/orgs","repos_url":"https://api.github.com/users/anthonymonori/repos","events_url":"https://api.github.com/users/anthonymonori/events{/privacy}","received_events_url":"https://api.github.com/users/anthonymonori/received_events","type":"User","site_admin":false},"body":"Never mind, I can see you already doing that.","created_at":"2016-03-10T21:19:24Z","updated_at":"2016-03-10T21:19:24Z","html_url":"https://github.com/hass123uk/EnronSearchEngine/pull/13#discussion_r55751136","pull_request_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/comments/55751136"},"html":{"href":"https://github.com/hass123uk/EnronSearchEngine/pull/13#discussion_r55751136"},"pull_request":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13","id":62385037,"html_url":"https://github.com/hass123uk/EnronSearchEngine/pull/13","diff_url":"https://github.com/hass123uk/EnronSearchEngine/pull/13.diff","patch_url":"https://github.com/hass123uk/EnronSearchEngine/pull/13.patch","issue_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/13","number":13,"state":"open","locked":false,"title":"ID-Generator NOT WORKING. Help wanted","user":{"login":"hass123uk","id":7426703,"avatar_url":"https://avatars.githubusercontent.com/u/7426703?v=3","gravatar_id":"","url":"https://api.github.com/users/hass123uk","html_url":"https://github.com/hass123uk","followers_url":"https://api.github.com/users/hass123uk/followers","following_url":"https://api.github.com/users/hass123uk/following{/other_user}","gists_url":"https://api.github.com/users/hass123uk/gists{/gist_id}","starred_url":"https://api.github.com/users/hass123uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hass123uk/subscriptions","organizations_url":"https://api.github.com/users/hass123uk/orgs","repos_url":"https://api.github.com/users/hass123uk/repos","events_url":"https://api.github.com/users/hass123uk/events{/privacy}","received_events_url":"https://api.github.com/users/hass123uk/received_events","type":"User","site_admin":false},"body":"Changed the ID data type from int to string in both DB and App. \r\nImplemented the ID generator using UUID. \r\nRefactored IndexFileCallable and SynchronizedTermsMap to use UUIDGenerator.\r\n\r\nUUID.RandomUUID is thread safe from my research and I have tried the same with an Atomic integer and the same results.\r\n\r\nDuplicate IDs are being created and the DB is throwing errors on Primary key.","created_at":"2016-03-10T12:52:52Z","updated_at":"2016-03-10T21:19:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7674d278ff01da27ac66dc31ae801061ee22cd61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13/commits","review_comments_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13/comments","review_comment_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/13/comments","statuses_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/statuses/b21369f88385eaaa9bc48325cb28e34500005988","head":{"label":"hass123uk:ID_InAppGenerator","ref":"ID_InAppGenerator","sha":"b21369f88385eaaa9bc48325cb28e34500005988","user":{"login":"hass123uk","id":7426703,"avatar_url":"https://avatars.githubusercontent.com/u/7426703?v=3","gravatar_id":"","url":"https://api.github.com/users/hass123uk","html_url":"https://github.com/hass123uk","followers_url":"https://api.github.com/users/hass123uk/followers","following_url":"https://api.github.com/users/hass123uk/following{/other_user}","gists_url":"https://api.github.com/users/hass123uk/gists{/gist_id}","starred_url":"https://api.github.com/users/hass123uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hass123uk/subscriptions","organizations_url":"https://api.github.com/users/hass123uk/orgs","repos_url":"https://api.github.com/users/hass123uk/repos","events_url":"https://api.github.com/users/hass123uk/events{/privacy}","received_events_url":"https://api.github.com/users/hass123uk/received_events","type":"User","site_admin":false},"repo":{"id":51366365,"name":"EnronSearchEngine","full_name":"hass123uk/EnronSearchEngine","owner":{"login":"hass123uk","id":7426703,"avatar_url":"https://avatars.githubusercontent.com/u/7426703?v=3","gravatar_id":"","url":"https://api.github.com/users/hass123uk","html_url":"https://github.com/hass123uk","followers_url":"https://api.github.com/users/hass123uk/followers","following_url":"https://api.github.com/users/hass123uk/following{/other_user}","gists_url":"https://api.github.com/users/hass123uk/gists{/gist_id}","starred_url":"https://api.github.com/users/hass123uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hass123uk/subscriptions","organizations_url":"https://api.github.com/users/hass123uk/orgs","repos_url":"https://api.github.com/users/hass123uk/repos","events_url":"https://api.github.com/users/hass123uk/events{/privacy}","received_events_url":"https://api.github.com/users/hass123uk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hass123uk/EnronSearchEngine","description":"","fork":false,"url":"https://api.github.com/repos/hass123uk/EnronSearchEngine","forks_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/forks","keys_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/teams","hooks_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/hooks","issue_events_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/events{/number}","events_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/events","assignees_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/assignees{/user}","branches_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/branches{/branch}","tags_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/tags","blobs_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/languages","stargazers_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/stargazers","contributors_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/contributors","subscribers_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/subscribers","subscription_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/subscription","commits_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/contents/{+path}","compare_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/merges","archive_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/downloads","issues_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues{/number}","pulls_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/labels{/name}","releases_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/releases{/id}","deployments_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/deployments","created_at":"2016-02-09T12:49:40Z","updated_at":"2016-02-09T12:53:31Z","pushed_at":"2016-03-10T13:11:09Z","git_url":"git://github.com/hass123uk/EnronSearchEngine.git","ssh_url":"git@github.com:hass123uk/EnronSearchEngine.git","clone_url":"https://github.com/hass123uk/EnronSearchEngine.git","svn_url":"https://github.com/hass123uk/EnronSearchEngine","homepage":null,"size":5055,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"hass123uk:master","ref":"master","sha":"b1ba800b94d688c5588df29e16531a2cdef5fed7","user":{"login":"hass123uk","id":7426703,"avatar_url":"https://avatars.githubusercontent.com/u/7426703?v=3","gravatar_id":"","url":"https://api.github.com/users/hass123uk","html_url":"https://github.com/hass123uk","followers_url":"https://api.github.com/users/hass123uk/followers","following_url":"https://api.github.com/users/hass123uk/following{/other_user}","gists_url":"https://api.github.com/users/hass123uk/gists{/gist_id}","starred_url":"https://api.github.com/users/hass123uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hass123uk/subscriptions","organizations_url":"https://api.github.com/users/hass123uk/orgs","repos_url":"https://api.github.com/users/hass123uk/repos","events_url":"https://api.github.com/users/hass123uk/events{/privacy}","received_events_url":"https://api.github.com/users/hass123uk/received_events","type":"User","site_admin":false},"repo":{"id":51366365,"name":"EnronSearchEngine","full_name":"hass123uk/EnronSearchEngine","owner":{"login":"hass123uk","id":7426703,"avatar_url":"https://avatars.githubusercontent.com/u/7426703?v=3","gravatar_id":"","url":"https://api.github.com/users/hass123uk","html_url":"https://github.com/hass123uk","followers_url":"https://api.github.com/users/hass123uk/followers","following_url":"https://api.github.com/users/hass123uk/following{/other_user}","gists_url":"https://api.github.com/users/hass123uk/gists{/gist_id}","starred_url":"https://api.github.com/users/hass123uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hass123uk/subscriptions","organizations_url":"https://api.github.com/users/hass123uk/orgs","repos_url":"https://api.github.com/users/hass123uk/repos","events_url":"https://api.github.com/users/hass123uk/events{/privacy}","received_events_url":"https://api.github.com/users/hass123uk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hass123uk/EnronSearchEngine","description":"","fork":false,"url":"https://api.github.com/repos/hass123uk/EnronSearchEngine","forks_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/forks","keys_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/teams","hooks_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/hooks","issue_events_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/events{/number}","events_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/events","assignees_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/assignees{/user}","branches_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/branches{/branch}","tags_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/tags","blobs_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/languages","stargazers_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/stargazers","contributors_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/contributors","subscribers_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/subscribers","subscription_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/subscription","commits_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/contents/{+path}","compare_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/merges","archive_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/downloads","issues_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues{/number}","pulls_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/labels{/name}","releases_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/releases{/id}","deployments_url":"https://api.github.com/repos/hass123uk/EnronSearchEngine/deployments","created_at":"2016-02-09T12:49:40Z","updated_at":"2016-02-09T12:53:31Z","pushed_at":"2016-03-10T13:11:09Z","git_url":"git://github.com/hass123uk/EnronSearchEngine.git","ssh_url":"git@github.com:hass123uk/EnronSearchEngine.git","clone_url":"https://github.com/hass123uk/EnronSearchEngine.git","svn_url":"https://github.com/hass123uk/EnronSearchEngine","homepage":null,"size":5055,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13"},"html":{"href":"https://github.com/hass123uk/EnronSearchEngine/pull/13"},"issue":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/13"},"comments":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/hass123uk/EnronSearchEngine/statuses/b21369f88385eaaa9bc48325cb28e34500005988"}}}}