{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/986","repository_url":"https://api.github.com/repos/apache/kafka","labels_url":"https://api.github.com/repos/apache/kafka/issues/986/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/986/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/986/events","html_url":"https://github.com/apache/kafka/pull/986","id":137414087,"number":986,"title":"KAFKA-3307: Add ProtocolVersion request/response and server side handling.","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-02-29T23:35:04Z","updated_at":"2016-04-25T16:26:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/986","html_url":"https://github.com/apache/kafka/pull/986","diff_url":"https://github.com/apache/kafka/pull/986.diff","patch_url":"https://github.com/apache/kafka/pull/986.patch"},"body":"The patch does the following.\r\n1. For unknown requests or protocol versions, broker sends an empty response, instead of simple closing the connection.\r\n2. Adds ProtocolVersion request and response, and server side implementation."},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/214429516","html_url":"https://github.com/apache/kafka/pull/986#issuecomment-214429516","issue_url":"https://api.github.com/repos/apache/kafka/issues/986","id":214429516,"user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"created_at":"2016-04-25T16:26:48Z","updated_at":"2016-04-25T16:26:48Z","body":"I have completed my review. Mostly minor comments with a couple of exceptions:\r\n1. Testing that involves the `KafkaApis` code\r\n2. A couple of naming questions, which I think are important to agree on a path forward before we merge."}}