{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/20771","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/20771/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20771/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/20771/events","html_url":"https://github.com/symfony/symfony/issues/20771","id":193616305,"number":20771,"title":"[Form] BC break in choice based form type extensions","user":{"login":"Padam87","id":776488,"avatar_url":"https://avatars.githubusercontent.com/u/776488?v=3","gravatar_id":"","url":"https://api.github.com/users/Padam87","html_url":"https://github.com/Padam87","followers_url":"https://api.github.com/users/Padam87/followers","following_url":"https://api.github.com/users/Padam87/following{/other_user}","gists_url":"https://api.github.com/users/Padam87/gists{/gist_id}","starred_url":"https://api.github.com/users/Padam87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Padam87/subscriptions","organizations_url":"https://api.github.com/users/Padam87/orgs","repos_url":"https://api.github.com/users/Padam87/repos","events_url":"https://api.github.com/users/Padam87/events{/privacy}","received_events_url":"https://api.github.com/users/Padam87/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-05T21:34:28Z","updated_at":"2016-12-05T23:08:30Z","closed_at":null,"body":"3.2 changed the way that choice based types load choices. They now use `choice_loader` instead of `choices`. This caused all type extensions which used to override choices to break, because the choice loader takes priority.\r\n\r\n**As a simple fix we can add `'choice_loader' => null,` as default to our extensions.**\r\n\r\nEffected types are:\r\n- `CountryType `\r\n- `CurrencyType`\r\n- `LanguageType `\r\n- `LocaleType `\r\n- `TimezoneType `\r\n\r\nSince not many of us write extensions for these types, and providing BC for this might be hard, I'm leaving this note for others to save some debug time :)"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/265008040","html_url":"https://github.com/symfony/symfony/issues/20771#issuecomment-265008040","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20771","id":265008040,"user":{"login":"HeahDude","id":10107633,"avatar_url":"https://avatars.githubusercontent.com/u/10107633?v=3","gravatar_id":"","url":"https://api.github.com/users/HeahDude","html_url":"https://github.com/HeahDude","followers_url":"https://api.github.com/users/HeahDude/followers","following_url":"https://api.github.com/users/HeahDude/following{/other_user}","gists_url":"https://api.github.com/users/HeahDude/gists{/gist_id}","starred_url":"https://api.github.com/users/HeahDude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeahDude/subscriptions","organizations_url":"https://api.github.com/users/HeahDude/orgs","repos_url":"https://api.github.com/users/HeahDude/repos","events_url":"https://api.github.com/users/HeahDude/events{/privacy}","received_events_url":"https://api.github.com/users/HeahDude/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T23:08:30Z","updated_at":"2016-12-05T23:08:30Z","body":"Oh yes, you're right, `choices` has priority only for `EntityType`, https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L121.\r\n\r\nHmmm, not sure how we should handle this BC break then :/"}}
{"actor":{"display_login":"HeahDude"}}