{"action":"closed","issue":{"url":"https://api.github.com/repos/larshp/abapGit/issues/412","repository_url":"https://api.github.com/repos/larshp/abapGit","labels_url":"https://api.github.com/repos/larshp/abapGit/issues/412/labels{/name}","comments_url":"https://api.github.com/repos/larshp/abapGit/issues/412/comments","events_url":"https://api.github.com/repos/larshp/abapGit/issues/412/events","html_url":"https://github.com/larshp/abapGit/issues/412","id":188210499,"number":412,"title":"HTTP failure on systems using a Proxy","user":{"login":"EduardoCopat","id":2248490,"avatar_url":"https://avatars.githubusercontent.com/u/2248490?v=3","gravatar_id":"","url":"https://api.github.com/users/EduardoCopat","html_url":"https://github.com/EduardoCopat","followers_url":"https://api.github.com/users/EduardoCopat/followers","following_url":"https://api.github.com/users/EduardoCopat/following{/other_user}","gists_url":"https://api.github.com/users/EduardoCopat/gists{/gist_id}","starred_url":"https://api.github.com/users/EduardoCopat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EduardoCopat/subscriptions","organizations_url":"https://api.github.com/users/EduardoCopat/orgs","repos_url":"https://api.github.com/users/EduardoCopat/repos","events_url":"https://api.github.com/users/EduardoCopat/events{/privacy}","received_events_url":"https://api.github.com/users/EduardoCopat/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-09T10:16:51Z","updated_at":"2016-11-11T08:39:11Z","closed_at":"2016-11-11T08:39:11Z","body":"Hello,\r\n\r\nWhen running the program `ZABAPGIT_TEST_SSL` to test my connection, I was receiving a HTTP Communication Failure. My SAP system/network has a proxy.\r\n\r\nChecking the `cl_http_client`, I noticed it takes as an optional parameter the proxy URL and Proxy Port. I added it and it worked:\r\n\r\n```abap\r\n  cl_http_client=>create_by_url(\r\n    EXPORTING\r\n      url           = lv_url\r\n      ssl_id        = 'ANONYM'\r\n      proxy_host    = 'proxy' \"proxy URL\r\n      proxy_service = '8080'  \"proxy port\r\n    IMPORTING\r\n      client        = li_client ).\r\n```\r\n\r\nBeing so, I also needed to modify this in the ZABAP_GIT. Specifically at the `lcl_git_transport=>branch_list` method.\r\n\r\nI believe we could provide this values as a setting/configuration, similar to what is offered with the Name and Email when commiting (i.e., save in the persistence). What do you think?"}}
{"actor":{"display_login":"larshp"}}