{"action":"created","comment":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/66694988","id":66694988,"diff_hunk":"@@ -143,6 +143,8 @@ task testIntelDeflater(type: Test){\n }\n \n task testSRA(type: Test){\n+    jvmArgs '-Dsamjdk.sra_libraries_download=true'","path":"build.gradle","position":13,"original_position":13,"commit_id":"39fc710b481e0e4017eda50ab88fe1decaa3828b","original_commit_id":"39fc710b481e0e4017eda50ab88fe1decaa3828b","user":{"login":"yfarjoun","id":2745554,"avatar_url":"https://avatars.githubusercontent.com/u/2745554?v=3","gravatar_id":"","url":"https://api.github.com/users/yfarjoun","html_url":"https://github.com/yfarjoun","followers_url":"https://api.github.com/users/yfarjoun/followers","following_url":"https://api.github.com/users/yfarjoun/following{/other_user}","gists_url":"https://api.github.com/users/yfarjoun/gists{/gist_id}","starred_url":"https://api.github.com/users/yfarjoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yfarjoun/subscriptions","organizations_url":"https://api.github.com/users/yfarjoun/orgs","repos_url":"https://api.github.com/users/yfarjoun/repos","events_url":"https://api.github.com/users/yfarjoun/events{/privacy}","received_events_url":"https://api.github.com/users/yfarjoun/received_events","type":"User","site_admin":false},"body":"can you also test that without any jvmArguments there is no downloading?","created_at":"2016-06-10T23:42:43Z","updated_at":"2016-06-10T23:42:43Z","html_url":"https://github.com/samtools/htsjdk/pull/634#discussion_r66694988","pull_request_url":"https://api.github.com/repos/samtools/htsjdk/pulls/634","_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/66694988"},"html":{"href":"https://github.com/samtools/htsjdk/pull/634#discussion_r66694988"},"pull_request":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/634"}}},"pull_request":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/634","id":72568321,"html_url":"https://github.com/samtools/htsjdk/pull/634","diff_url":"https://github.com/samtools/htsjdk/pull/634.diff","patch_url":"https://github.com/samtools/htsjdk/pull/634.patch","issue_url":"https://api.github.com/repos/samtools/htsjdk/issues/634","number":634,"state":"open","locked":false,"title":"Provided an option to disable auto-download of SRA native libraries","user":{"login":"a-nikitiuk","id":12701013,"avatar_url":"https://avatars.githubusercontent.com/u/12701013?v=3","gravatar_id":"","url":"https://api.github.com/users/a-nikitiuk","html_url":"https://github.com/a-nikitiuk","followers_url":"https://api.github.com/users/a-nikitiuk/followers","following_url":"https://api.github.com/users/a-nikitiuk/following{/other_user}","gists_url":"https://api.github.com/users/a-nikitiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-nikitiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-nikitiuk/subscriptions","organizations_url":"https://api.github.com/users/a-nikitiuk/orgs","repos_url":"https://api.github.com/users/a-nikitiuk/repos","events_url":"https://api.github.com/users/a-nikitiuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-nikitiuk/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis PR implements optional SRA native libraries auto-download, as requested in #414\r\nIn case, when ngs-java fails to locate/load native libraries, we throw a subclass of java.lang.Error with details of what went wrong and a recommendation on how to fix the problem.\r\n\r\nIn ngs-java 1.2.4 we also improved version checking of native libraries before loading them and addressed issue #462 \r\n\r\nWe also fixed an issue with keeping references to SRA objects forever, which prevented them from being garbage collected and sometimes produced issues with reaching a limit of opened file handlers.\r\n\r\n","created_at":"2016-06-03T20:52:36Z","updated_at":"2016-06-10T23:42:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7af115661f5924886ef2acf6f4e9654dae2254eb","assignee":{"login":"yfarjoun","id":2745554,"avatar_url":"https://avatars.githubusercontent.com/u/2745554?v=3","gravatar_id":"","url":"https://api.github.com/users/yfarjoun","html_url":"https://github.com/yfarjoun","followers_url":"https://api.github.com/users/yfarjoun/followers","following_url":"https://api.github.com/users/yfarjoun/following{/other_user}","gists_url":"https://api.github.com/users/yfarjoun/gists{/gist_id}","starred_url":"https://api.github.com/users/yfarjoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yfarjoun/subscriptions","organizations_url":"https://api.github.com/users/yfarjoun/orgs","repos_url":"https://api.github.com/users/yfarjoun/repos","events_url":"https://api.github.com/users/yfarjoun/events{/privacy}","received_events_url":"https://api.github.com/users/yfarjoun/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/samtools/htsjdk/pulls/634/commits","review_comments_url":"https://api.github.com/repos/samtools/htsjdk/pulls/634/comments","review_comment_url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samtools/htsjdk/issues/634/comments","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/39fc710b481e0e4017eda50ab88fe1decaa3828b","head":{"label":"a-nikitiuk:sra-auto-download","ref":"sra-auto-download","sha":"39fc710b481e0e4017eda50ab88fe1decaa3828b","user":{"login":"a-nikitiuk","id":12701013,"avatar_url":"https://avatars.githubusercontent.com/u/12701013?v=3","gravatar_id":"","url":"https://api.github.com/users/a-nikitiuk","html_url":"https://github.com/a-nikitiuk","followers_url":"https://api.github.com/users/a-nikitiuk/followers","following_url":"https://api.github.com/users/a-nikitiuk/following{/other_user}","gists_url":"https://api.github.com/users/a-nikitiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-nikitiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-nikitiuk/subscriptions","organizations_url":"https://api.github.com/users/a-nikitiuk/orgs","repos_url":"https://api.github.com/users/a-nikitiuk/repos","events_url":"https://api.github.com/users/a-nikitiuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-nikitiuk/received_events","type":"User","site_admin":false},"repo":{"id":40136007,"name":"htsjdk","full_name":"a-nikitiuk/htsjdk","owner":{"login":"a-nikitiuk","id":12701013,"avatar_url":"https://avatars.githubusercontent.com/u/12701013?v=3","gravatar_id":"","url":"https://api.github.com/users/a-nikitiuk","html_url":"https://github.com/a-nikitiuk","followers_url":"https://api.github.com/users/a-nikitiuk/followers","following_url":"https://api.github.com/users/a-nikitiuk/following{/other_user}","gists_url":"https://api.github.com/users/a-nikitiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-nikitiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-nikitiuk/subscriptions","organizations_url":"https://api.github.com/users/a-nikitiuk/orgs","repos_url":"https://api.github.com/users/a-nikitiuk/repos","events_url":"https://api.github.com/users/a-nikitiuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-nikitiuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-nikitiuk/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":true,"url":"https://api.github.com/repos/a-nikitiuk/htsjdk","forks_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/forks","keys_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/teams","hooks_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/events","assignees_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/tags","blobs_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/languages","stargazers_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/subscription","commits_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/merges","archive_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/downloads","issues_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/a-nikitiuk/htsjdk/deployments","created_at":"2015-08-03T16:39:32Z","updated_at":"2016-05-09T16:04:10Z","pushed_at":"2016-06-07T23:30:45Z","git_url":"git://github.com/a-nikitiuk/htsjdk.git","ssh_url":"git@github.com:a-nikitiuk/htsjdk.git","clone_url":"https://github.com/a-nikitiuk/htsjdk.git","svn_url":"https://github.com/a-nikitiuk/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":57939,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samtools:master","ref":"master","sha":"91cc48dd224b4c63ddffbf4f8adbe737ca787e3f","user":{"login":"samtools","id":1518450,"avatar_url":"https://avatars.githubusercontent.com/u/1518450?v=3","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"repo":{"id":19272315,"name":"htsjdk","full_name":"samtools/htsjdk","owner":{"login":"samtools","id":1518450,"avatar_url":"https://avatars.githubusercontent.com/u/1518450?v=3","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samtools/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":false,"url":"https://api.github.com/repos/samtools/htsjdk","forks_url":"https://api.github.com/repos/samtools/htsjdk/forks","keys_url":"https://api.github.com/repos/samtools/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samtools/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samtools/htsjdk/teams","hooks_url":"https://api.github.com/repos/samtools/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/samtools/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/samtools/htsjdk/events","assignees_url":"https://api.github.com/repos/samtools/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/samtools/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/samtools/htsjdk/tags","blobs_url":"https://api.github.com/repos/samtools/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samtools/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samtools/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/samtools/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/samtools/htsjdk/languages","stargazers_url":"https://api.github.com/repos/samtools/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/samtools/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/samtools/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/samtools/htsjdk/subscription","commits_url":"https://api.github.com/repos/samtools/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/samtools/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/samtools/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/samtools/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/samtools/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/samtools/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samtools/htsjdk/merges","archive_url":"https://api.github.com/repos/samtools/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samtools/htsjdk/downloads","issues_url":"https://api.github.com/repos/samtools/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/samtools/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/samtools/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/samtools/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samtools/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/samtools/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/samtools/htsjdk/deployments","created_at":"2014-04-29T10:11:28Z","updated_at":"2016-06-01T00:41:57Z","pushed_at":"2016-06-10T21:21:13Z","git_url":"git://github.com/samtools/htsjdk.git","ssh_url":"git@github.com:samtools/htsjdk.git","clone_url":"https://github.com/samtools/htsjdk.git","svn_url":"https://github.com/samtools/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":69333,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"open_issues_count":140,"forks":115,"open_issues":140,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/634"},"html":{"href":"https://github.com/samtools/htsjdk/pull/634"},"issue":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/634"},"comments":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/samtools/htsjdk/statuses/39fc710b481e0e4017eda50ab88fe1decaa3828b"}}}}
{"actor":{"display_login":"yfarjoun"}}