{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63573883","id":63573883,"diff_hunk":"@@ -1547,8 +1715,22 @@ func (r *Runtime) GarbageCollect(gcPolicy kubecontainer.ContainerGCPolicy) error\n \t\tif strings.HasPrefix(serviceName, kubernetesUnitPrefix) {\n \t\t\trktUUID := getRktUUIDFromServiceFileName(serviceName)\n \t\t\tif _, ok := allPods[rktUUID]; !ok {\n+\t\t\t\tserviceFile := serviceFilePath(f.Name())\n+\t\t\t\tid, name, namespace, err := podDetailsFromServiceFile(serviceFile)\n+\t\t\t\tif err == nil {\n+\t\t\t\t\tr.cleanupPodNetwork(&api.Pod{","path":"pkg/kubelet/rkt/rkt.go","position":364,"original_position":364,"commit_id":"57a087aca044e4e9d24814127bc98f0224ab6df9","original_commit_id":"57a087aca044e4e9d24814127bc98f0224ab6df9","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"Everytime there is an error, we invoke cleanupPodNetwork. Is it possible that we defer a validation function? In this function, check if the current operation succeeded, and then invoke cleanupPodNetwork if needed. ","created_at":"2016-05-17T18:06:26Z","updated_at":"2016-05-17T18:06:26Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25062#discussion_r63573883","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63573883"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25062#discussion_r63573883"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062","id":68644745,"html_url":"https://github.com/kubernetes/kubernetes/pull/25062","diff_url":"https://github.com/kubernetes/kubernetes/pull/25062.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25062.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25062","number":25062,"state":"open","locked":false,"title":"Hook rkt kubelet runtime up to network plugins","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-03T00:51:09Z","updated_at":"2016-05-17T18:06:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d9b3a2ad23d519533c0a28d7d618fe3fe3382af","assignee":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/19","html_url":"https://github.com/kubernetes/kubernetes/milestones/rktnetes-v1.0","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/19/labels","id":1685452,"number":19,"title":"rktnetes-v1.0","description":"","creator":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":23,"state":"open","created_at":"2016-04-05T19:02:11Z","updated_at":"2016-05-17T02:35:04Z","due_on":"2016-05-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25062/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/57a087aca044e4e9d24814127bc98f0224ab6df9","head":{"label":"dcbw:kubenet-rkt","ref":"kubenet-rkt","sha":"57a087aca044e4e9d24814127bc98f0224ab6df9","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"repo":{"id":43094783,"name":"kubernetes","full_name":"dcbw/kubernetes","owner":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcbw/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/dcbw/kubernetes","forks_url":"https://api.github.com/repos/dcbw/kubernetes/forks","keys_url":"https://api.github.com/repos/dcbw/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcbw/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcbw/kubernetes/teams","hooks_url":"https://api.github.com/repos/dcbw/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dcbw/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dcbw/kubernetes/events","assignees_url":"https://api.github.com/repos/dcbw/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dcbw/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dcbw/kubernetes/tags","blobs_url":"https://api.github.com/repos/dcbw/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcbw/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcbw/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcbw/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcbw/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dcbw/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dcbw/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dcbw/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dcbw/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dcbw/kubernetes/subscription","commits_url":"https://api.github.com/repos/dcbw/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcbw/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcbw/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcbw/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcbw/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dcbw/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcbw/kubernetes/merges","archive_url":"https://api.github.com/repos/dcbw/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcbw/kubernetes/downloads","issues_url":"https://api.github.com/repos/dcbw/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dcbw/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dcbw/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dcbw/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcbw/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dcbw/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dcbw/kubernetes/deployments","created_at":"2015-09-24T21:46:52Z","updated_at":"2016-02-04T14:52:56Z","pushed_at":"2016-05-16T20:38:23Z","git_url":"git://github.com/dcbw/kubernetes.git","ssh_url":"git@github.com:dcbw/kubernetes.git","clone_url":"https://github.com/dcbw/kubernetes.git","svn_url":"https://github.com/dcbw/kubernetes","homepage":"http://kubernetes.io","size":191657,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"835a2577f8d0e47938d0893447485c5225c56368","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-17T15:55:57Z","pushed_at":"2016-05-17T18:05:14Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":411176,"stargazers_count":14418,"watchers_count":14418,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4357,"mirror_url":null,"open_issues_count":3588,"forks":4357,"open_issues":3588,"watchers":14418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25062"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25062"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25062/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25062/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/57a087aca044e4e9d24814127bc98f0224ab6df9"}}}}