{"action":"created","comment":{"url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments/78013906","id":78013906,"diff_hunk":"@@ -2,6 +2,10 @@ import videojs from 'video.js';\n import window from 'global/window';\n import document from 'global/document';\n \n+// The logic below is used to check if flash is disabled or not installed\n+// in IE browser and show the appropriate message to the user.\n+const flashObj = videojs.getComponent('Flash');","path":"src/plugin.js","position":6,"original_position":6,"commit_id":"286fa87acad74468fb695196ff98d4354901a167","original_commit_id":"286fa87acad74468fb695196ff98d4354901a167","user":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"body":"The comment for this seems to be inaccurate now. It could probably just be removed.\r\n\r\nAnd I think this should be named consistently with other components/classes with a capital first letter (i.e. `Flash`).","created_at":"2016-09-08T14:13:57Z","updated_at":"2016-09-08T14:13:57Z","html_url":"https://github.com/brightcove/videojs-errors/pull/41#discussion_r78013906","pull_request_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments/78013906"},"html":{"href":"https://github.com/brightcove/videojs-errors/pull/41#discussion_r78013906"},"pull_request":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41","id":81892704,"html_url":"https://github.com/brightcove/videojs-errors/pull/41","diff_url":"https://github.com/brightcove/videojs-errors/pull/41.diff","patch_url":"https://github.com/brightcove/videojs-errors/pull/41.patch","issue_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/41","number":41,"state":"open","locked":false,"title":"Add in a user-friendly message for disabled Flash in IE","user":{"login":"vdeshpande","id":1349170,"avatar_url":"https://avatars.githubusercontent.com/u/1349170?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeshpande","html_url":"https://github.com/vdeshpande","followers_url":"https://api.github.com/users/vdeshpande/followers","following_url":"https://api.github.com/users/vdeshpande/following{/other_user}","gists_url":"https://api.github.com/users/vdeshpande/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeshpande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeshpande/subscriptions","organizations_url":"https://api.github.com/users/vdeshpande/orgs","repos_url":"https://api.github.com/users/vdeshpande/repos","events_url":"https://api.github.com/users/vdeshpande/events{/privacy}","received_events_url":"https://api.github.com/users/vdeshpande/received_events","type":"User","site_admin":false},"body":"**Problem Description** \r\n\r\nWhen trying to play the video in IE **_(when Flash has been disabled or not installed)_** , users presented with a `MEDIA_ERR_SRC_NOT_SUPPORTED` error along with the associated technical details\r\n\r\n**Fix Details**\r\n\r\nThe technical details / description does not say anything about flash being disabled, so adding a description after the Flash enabled check has been made, will provide the user with a clue if there is no Flash installed or disabled in IE.\r\n\r\nAfter the Fix the technical description should read this\r\n\r\n>`ASSOCIATED_TECHNICAL_DESCRIPTION` + . You could also try installing Flash.\r\n\r\n**Latest Changes in the fix proposed:**\r\nWe are going to add in the flash message after the technical description instead of appending it as stated above in fix details.","created_at":"2016-08-18T21:36:52Z","updated_at":"2016-09-08T14:13:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4de937c0805c015984e795188fc380eca1b878e9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41/commits","review_comments_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41/comments","review_comment_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/41/comments","statuses_url":"https://api.github.com/repos/brightcove/videojs-errors/statuses/286fa87acad74468fb695196ff98d4354901a167","head":{"label":"vdeshpande:userFriendlyError","ref":"userFriendlyError","sha":"286fa87acad74468fb695196ff98d4354901a167","user":{"login":"vdeshpande","id":1349170,"avatar_url":"https://avatars.githubusercontent.com/u/1349170?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeshpande","html_url":"https://github.com/vdeshpande","followers_url":"https://api.github.com/users/vdeshpande/followers","following_url":"https://api.github.com/users/vdeshpande/following{/other_user}","gists_url":"https://api.github.com/users/vdeshpande/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeshpande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeshpande/subscriptions","organizations_url":"https://api.github.com/users/vdeshpande/orgs","repos_url":"https://api.github.com/users/vdeshpande/repos","events_url":"https://api.github.com/users/vdeshpande/events{/privacy}","received_events_url":"https://api.github.com/users/vdeshpande/received_events","type":"User","site_admin":false},"repo":{"id":63891652,"name":"videojs-errors","full_name":"vdeshpande/videojs-errors","owner":{"login":"vdeshpande","id":1349170,"avatar_url":"https://avatars.githubusercontent.com/u/1349170?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeshpande","html_url":"https://github.com/vdeshpande","followers_url":"https://api.github.com/users/vdeshpande/followers","following_url":"https://api.github.com/users/vdeshpande/following{/other_user}","gists_url":"https://api.github.com/users/vdeshpande/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeshpande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeshpande/subscriptions","organizations_url":"https://api.github.com/users/vdeshpande/orgs","repos_url":"https://api.github.com/users/vdeshpande/repos","events_url":"https://api.github.com/users/vdeshpande/events{/privacy}","received_events_url":"https://api.github.com/users/vdeshpande/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdeshpande/videojs-errors","description":"A video.js plugin that displays error messages to video viewers.","fork":true,"url":"https://api.github.com/repos/vdeshpande/videojs-errors","forks_url":"https://api.github.com/repos/vdeshpande/videojs-errors/forks","keys_url":"https://api.github.com/repos/vdeshpande/videojs-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdeshpande/videojs-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdeshpande/videojs-errors/teams","hooks_url":"https://api.github.com/repos/vdeshpande/videojs-errors/hooks","issue_events_url":"https://api.github.com/repos/vdeshpande/videojs-errors/issues/events{/number}","events_url":"https://api.github.com/repos/vdeshpande/videojs-errors/events","assignees_url":"https://api.github.com/repos/vdeshpande/videojs-errors/assignees{/user}","branches_url":"https://api.github.com/repos/vdeshpande/videojs-errors/branches{/branch}","tags_url":"https://api.github.com/repos/vdeshpande/videojs-errors/tags","blobs_url":"https://api.github.com/repos/vdeshpande/videojs-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdeshpande/videojs-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdeshpande/videojs-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdeshpande/videojs-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdeshpande/videojs-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/vdeshpande/videojs-errors/languages","stargazers_url":"https://api.github.com/repos/vdeshpande/videojs-errors/stargazers","contributors_url":"https://api.github.com/repos/vdeshpande/videojs-errors/contributors","subscribers_url":"https://api.github.com/repos/vdeshpande/videojs-errors/subscribers","subscription_url":"https://api.github.com/repos/vdeshpande/videojs-errors/subscription","commits_url":"https://api.github.com/repos/vdeshpande/videojs-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdeshpande/videojs-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdeshpande/videojs-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdeshpande/videojs-errors/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdeshpande/videojs-errors/contents/{+path}","compare_url":"https://api.github.com/repos/vdeshpande/videojs-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdeshpande/videojs-errors/merges","archive_url":"https://api.github.com/repos/vdeshpande/videojs-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdeshpande/videojs-errors/downloads","issues_url":"https://api.github.com/repos/vdeshpande/videojs-errors/issues{/number}","pulls_url":"https://api.github.com/repos/vdeshpande/videojs-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/vdeshpande/videojs-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/vdeshpande/videojs-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdeshpande/videojs-errors/labels{/name}","releases_url":"https://api.github.com/repos/vdeshpande/videojs-errors/releases{/id}","deployments_url":"https://api.github.com/repos/vdeshpande/videojs-errors/deployments","created_at":"2016-07-21T18:06:32Z","updated_at":"2016-07-21T18:06:33Z","pushed_at":"2016-09-07T22:58:32Z","git_url":"git://github.com/vdeshpande/videojs-errors.git","ssh_url":"git@github.com:vdeshpande/videojs-errors.git","clone_url":"https://github.com/vdeshpande/videojs-errors.git","svn_url":"https://github.com/vdeshpande/videojs-errors","homepage":null,"size":234,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brightcove:master","ref":"master","sha":"82d1cc4035bb929ce7c156d762ffcde57b43eb0c","user":{"login":"brightcove","id":277032,"avatar_url":"https://avatars.githubusercontent.com/u/277032?v=3","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"repo":{"id":8689507,"name":"videojs-errors","full_name":"brightcove/videojs-errors","owner":{"login":"brightcove","id":277032,"avatar_url":"https://avatars.githubusercontent.com/u/277032?v=3","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brightcove/videojs-errors","description":"A video.js plugin that displays error messages to video viewers.","fork":false,"url":"https://api.github.com/repos/brightcove/videojs-errors","forks_url":"https://api.github.com/repos/brightcove/videojs-errors/forks","keys_url":"https://api.github.com/repos/brightcove/videojs-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brightcove/videojs-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brightcove/videojs-errors/teams","hooks_url":"https://api.github.com/repos/brightcove/videojs-errors/hooks","issue_events_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/events{/number}","events_url":"https://api.github.com/repos/brightcove/videojs-errors/events","assignees_url":"https://api.github.com/repos/brightcove/videojs-errors/assignees{/user}","branches_url":"https://api.github.com/repos/brightcove/videojs-errors/branches{/branch}","tags_url":"https://api.github.com/repos/brightcove/videojs-errors/tags","blobs_url":"https://api.github.com/repos/brightcove/videojs-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brightcove/videojs-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brightcove/videojs-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/brightcove/videojs-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brightcove/videojs-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/brightcove/videojs-errors/languages","stargazers_url":"https://api.github.com/repos/brightcove/videojs-errors/stargazers","contributors_url":"https://api.github.com/repos/brightcove/videojs-errors/contributors","subscribers_url":"https://api.github.com/repos/brightcove/videojs-errors/subscribers","subscription_url":"https://api.github.com/repos/brightcove/videojs-errors/subscription","commits_url":"https://api.github.com/repos/brightcove/videojs-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/brightcove/videojs-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/brightcove/videojs-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/comments{/number}","contents_url":"https://api.github.com/repos/brightcove/videojs-errors/contents/{+path}","compare_url":"https://api.github.com/repos/brightcove/videojs-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brightcove/videojs-errors/merges","archive_url":"https://api.github.com/repos/brightcove/videojs-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brightcove/videojs-errors/downloads","issues_url":"https://api.github.com/repos/brightcove/videojs-errors/issues{/number}","pulls_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/brightcove/videojs-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/brightcove/videojs-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brightcove/videojs-errors/labels{/name}","releases_url":"https://api.github.com/repos/brightcove/videojs-errors/releases{/id}","deployments_url":"https://api.github.com/repos/brightcove/videojs-errors/deployments","created_at":"2013-03-10T18:31:15Z","updated_at":"2016-08-26T18:51:19Z","pushed_at":"2016-09-07T22:58:32Z","git_url":"git://github.com/brightcove/videojs-errors.git","ssh_url":"git@github.com:brightcove/videojs-errors.git","clone_url":"https://github.com/brightcove/videojs-errors.git","svn_url":"https://github.com/brightcove/videojs-errors","homepage":null,"size":356,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41"},"html":{"href":"https://github.com/brightcove/videojs-errors/pull/41"},"issue":{"href":"https://api.github.com/repos/brightcove/videojs-errors/issues/41"},"comments":{"href":"https://api.github.com/repos/brightcove/videojs-errors/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/brightcove/videojs-errors/statuses/286fa87acad74468fb695196ff98d4354901a167"}}}}
{"actor":{"display_login":"misteroneill"}}