{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/91847297","pull_request_review_id":12359270,"id":91847297,"diff_hunk":"@@ -18,16 +20,12 @@ def set_locals_for_render\n \n   # Get root nodes count/array for explorer tree\n   def x_get_tree_roots(count_only, _options)\n-    roots = rbac_filtered_objects(Service.roots)\n-\n-    # Preload the root service picture since it's called by TreeNodeBuilder#build\n-    MiqPreloader.preload(roots, :picture)\n-\n-    count_only_or_objects(count_only, roots, \"name\")\n-  end\n-\n-  def x_get_tree_service_kids(object, count_only)\n-    objects = rbac_filtered_objects(object.direct_service_children.select(&:display).sort_by { |o| o.name.downcase })\n-    count_only_or_objects(count_only, objects, 'name')\n+    all_services = Rbac.filtered(Service.where(:display => true))","path":"app/presenters/tree_builder_services.rb","position":22,"original_position":22,"commit_id":"5540f6a19bb8cbc03e3e7bba156e69edceb5cfd1","original_commit_id":"5540f6a19bb8cbc03e3e7bba156e69edceb5cfd1","user":{"login":"NickLaMuro","id":314014,"avatar_url":"https://avatars.githubusercontent.com/u/314014?v=3","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"body":"I admit to not taking the time to look this up, but do we know what the difference is between `rbac_filtered_objects` and `Rbac.filtered`)?  I assume they are equivalent, but just want to make sure this wasn't something that is a `darga` specific method here.","created_at":"2016-12-11T04:00:40Z","updated_at":"2016-12-11T04:02:39Z","html_url":"https://github.com/ManageIQ/manageiq/pull/13107#discussion_r91847297","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/91847297"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/13107#discussion_r91847297"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107","id":97447352,"html_url":"https://github.com/ManageIQ/manageiq/pull/13107","diff_url":"https://github.com/ManageIQ/manageiq/pull/13107.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/13107.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/13107","number":13107,"state":"open","locked":false,"title":"[DARGA] Support ancestry for services","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"This is a manual backport of #11171 for darga.\r\n\r\n@kbrock Please verify.\r\ncc @chessbyte @gtanzillo @jrafanie @NickLaMuro ","created_at":"2016-12-11T03:43:51Z","updated_at":"2016-12-11T04:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85221a49fa6e24257dd6c8d5c464ac6596026f60","assignee":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"assignees":[{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/13107/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5540f6a19bb8cbc03e3e7bba156e69edceb5cfd1","head":{"label":"Fryguy:darga_backport_11171","ref":"darga_backport_11171","sha":"5540f6a19bb8cbc03e3e7bba156e69edceb5cfd1","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"repo":{"id":20789885,"name":"manageiq","full_name":"Fryguy/manageiq","owner":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fryguy/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Fryguy/manageiq","forks_url":"https://api.github.com/repos/Fryguy/manageiq/forks","keys_url":"https://api.github.com/repos/Fryguy/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fryguy/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fryguy/manageiq/teams","hooks_url":"https://api.github.com/repos/Fryguy/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Fryguy/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Fryguy/manageiq/events","assignees_url":"https://api.github.com/repos/Fryguy/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Fryguy/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Fryguy/manageiq/tags","blobs_url":"https://api.github.com/repos/Fryguy/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fryguy/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fryguy/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fryguy/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fryguy/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Fryguy/manageiq/languages","stargazers_url":"https://api.github.com/repos/Fryguy/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Fryguy/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Fryguy/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Fryguy/manageiq/subscription","commits_url":"https://api.github.com/repos/Fryguy/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fryguy/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fryguy/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fryguy/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fryguy/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Fryguy/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fryguy/manageiq/merges","archive_url":"https://api.github.com/repos/Fryguy/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fryguy/manageiq/downloads","issues_url":"https://api.github.com/repos/Fryguy/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Fryguy/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Fryguy/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Fryguy/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fryguy/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Fryguy/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/Fryguy/manageiq/deployments","created_at":"2014-06-13T02:37:50Z","updated_at":"2014-07-02T02:07:48Z","pushed_at":"2016-12-11T03:42:31Z","git_url":"git://github.com/Fryguy/manageiq.git","ssh_url":"git@github.com:Fryguy/manageiq.git","clone_url":"https://github.com/Fryguy/manageiq.git","svn_url":"https://github.com/Fryguy/manageiq","homepage":null,"size":172550,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:darga","ref":"darga","sha":"44dfbf860199e3d37bd9fab7a2272d06de3454d2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-12-10T15:43:58Z","pushed_at":"2016-12-11T03:43:53Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":231565,"stargazers_count":364,"watchers_count":364,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":394,"mirror_url":null,"open_issues_count":901,"forks":394,"open_issues":901,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/13107"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/13107"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/13107/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13107/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5540f6a19bb8cbc03e3e7bba156e69edceb5cfd1"}}}}
{"actor":{"display_login":"NickLaMuro"}}