{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/75426971","id":75426971,"diff_hunk":"@@ -42,19 +42,26 @@ class EvaluatorImpl\n   Issues = Issues\n \n   def initialize\n+    @@initialized ||= static_initialize\n+\n+    # Use null migration checker unless given in context\n+    @migration_checker = (Puppet.lookup(:migration_checker) { Migration::MigrationChecker.singleton() })\n+  end\n+\n+  # @api private\n+  def static_initialize\n     @@eval_visitor     ||= Visitor.new(self, \"eval\", 1, 1)\n     @@lvalue_visitor   ||= Visitor.new(self, \"lvalue\", 1, 1)\n     @@assign_visitor   ||= Visitor.new(self, \"assign\", 3, 3)\n     @@string_visitor   ||= Visitor.new(self, \"string\", 1, 1)\n \n-    @@type_calculator  ||= Types::TypeCalculator.new()\n+    @@type_calculator  ||= Types::TypeCalculator.singleton()\n \n-    @@compare_operator     ||= CompareOperator.new()\n+    @@compare_operator      ||= CompareOperator.new()","path":"lib/puppet/pops/evaluator/evaluator_impl.rb","position":21,"original_position":21,"commit_id":"c34a6ba5c84d5cb4db98562edaa2fceac6078bf7","original_commit_id":"c34a6ba5c84d5cb4db98562edaa2fceac6078bf7","user":{"login":"thallgren","id":209495,"avatar_url":"https://avatars.githubusercontent.com/u/209495?v=3","gravatar_id":"","url":"https://api.github.com/users/thallgren","html_url":"https://github.com/thallgren","followers_url":"https://api.github.com/users/thallgren/followers","following_url":"https://api.github.com/users/thallgren/following{/other_user}","gists_url":"https://api.github.com/users/thallgren/gists{/gist_id}","starred_url":"https://api.github.com/users/thallgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallgren/subscriptions","organizations_url":"https://api.github.com/users/thallgren/orgs","repos_url":"https://api.github.com/users/thallgren/repos","events_url":"https://api.github.com/users/thallgren/events{/privacy}","received_events_url":"https://api.github.com/users/thallgren/received_events","type":"User","site_admin":false},"body":"Nitpick, loose the extra parenthesis","created_at":"2016-08-19T04:45:09Z","updated_at":"2016-08-19T04:45:09Z","html_url":"https://github.com/puppetlabs/puppet/pull/5215#discussion_r75426971","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/75426971"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5215#discussion_r75426971"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215","id":81834842,"html_url":"https://github.com/puppetlabs/puppet/pull/5215","diff_url":"https://github.com/puppetlabs/puppet/pull/5215.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5215.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5215","number":5215,"state":"open","locked":false,"title":"(PUP-6582) loader bound functions cannot bind scope instance","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=3","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"This refactors Closure into two specific subclasses: Dynamic (for lambdas), and Named (static, bound by loader). This is done to ensure that all Named function closures refer to top-scope in a way that is resolved on demand rather than being bound in a member variable. The dynamic closures must bind to a scope. Such closures may never be bound in something that survives a compilation.","created_at":"2016-08-18T15:20:31Z","updated_at":"2016-08-19T04:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"489b16b371635281141feb2a4401d9498b6d6079","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5215/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/c34a6ba5c84d5cb4db98562edaa2fceac6078bf7","head":{"label":"hlindberg:PUP-6582_loader-bound-functions-must-have-nil-closure-scope","ref":"PUP-6582_loader-bound-functions-must-have-nil-closure-scope","sha":"c34a6ba5c84d5cb4db98562edaa2fceac6078bf7","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=3","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"repo":{"id":5693635,"name":"puppet","full_name":"hlindberg/puppet","owner":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=3","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlindberg/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/hlindberg/puppet","forks_url":"https://api.github.com/repos/hlindberg/puppet/forks","keys_url":"https://api.github.com/repos/hlindberg/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlindberg/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlindberg/puppet/teams","hooks_url":"https://api.github.com/repos/hlindberg/puppet/hooks","issue_events_url":"https://api.github.com/repos/hlindberg/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/hlindberg/puppet/events","assignees_url":"https://api.github.com/repos/hlindberg/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/hlindberg/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/hlindberg/puppet/tags","blobs_url":"https://api.github.com/repos/hlindberg/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlindberg/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlindberg/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlindberg/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlindberg/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/hlindberg/puppet/languages","stargazers_url":"https://api.github.com/repos/hlindberg/puppet/stargazers","contributors_url":"https://api.github.com/repos/hlindberg/puppet/contributors","subscribers_url":"https://api.github.com/repos/hlindberg/puppet/subscribers","subscription_url":"https://api.github.com/repos/hlindberg/puppet/subscription","commits_url":"https://api.github.com/repos/hlindberg/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlindberg/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlindberg/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlindberg/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/hlindberg/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/hlindberg/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlindberg/puppet/merges","archive_url":"https://api.github.com/repos/hlindberg/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlindberg/puppet/downloads","issues_url":"https://api.github.com/repos/hlindberg/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/hlindberg/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/hlindberg/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/hlindberg/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlindberg/puppet/labels{/name}","releases_url":"https://api.github.com/repos/hlindberg/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/hlindberg/puppet/deployments","created_at":"2012-09-05T21:08:12Z","updated_at":"2014-06-25T01:27:30Z","pushed_at":"2016-08-18T15:16:42Z","git_url":"git://github.com/hlindberg/puppet.git","ssh_url":"git@github.com:hlindberg/puppet.git","clone_url":"https://github.com/hlindberg/puppet.git","svn_url":"https://github.com/hlindberg/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":157936,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"c8090f58657d771908fe48b2edcd3718f534fe78","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-08-19T00:20:36Z","pushed_at":"2016-08-19T04:09:31Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":80836,"stargazers_count":4104,"watchers_count":4104,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1696,"mirror_url":null,"open_issues_count":64,"forks":1696,"open_issues":64,"watchers":4104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5215"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5215"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5215/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5215/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/c34a6ba5c84d5cb4db98562edaa2fceac6078bf7"}}}}
{"actor":{"display_login":"thallgren"}}