{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/75688904","id":75688904,"diff_hunk":"@@ -0,0 +1,77 @@\n+// Copyright 2016 The rkt Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package distribution\n+\n+import (\n+\t\"fmt\"\n+\t\"net/url\"\n+)\n+\n+// DistType represents a distribution type\n+type DistType string\n+\n+const (\n+\tDistScheme = \"cimd\"\n+\n+\t// Distribution types\n+\tDistTypeAppc       DistType = \"appc\"","path":"common/distribution/dist.go","position":29,"original_position":29,"commit_id":"369af1f2b35e9c176cd171bb008be8f5dbb424a1","original_commit_id":"369af1f2b35e9c176cd171bb008be8f5dbb424a1","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"I was thinking that forcing a Distribution to implement `ComparableString() string` will add two things in one:\r\n\r\n* Have a ready to use and reproducible distribution serialization string.\r\n* avoid them implementing a Compare method and use the common Compare function.\r\n\r\nBut these can also be done removing the `ComparableString() string` method from the interface and add a `Compare(Distribution) bool` method. For distribution serialization just URI().String() could be used (so an user isn't tempted to just compare two distribution string but use the `Compare` method.\r\nIt'll probably be cleaner. Will experiment with this.\r\n\r\n ","created_at":"2016-08-22T14:35:32Z","updated_at":"2016-08-22T14:35:32Z","html_url":"https://github.com/coreos/rkt/pull/3101#discussion_r75688904","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/3101","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/75688904"},"html":{"href":"https://github.com/coreos/rkt/pull/3101#discussion_r75688904"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3101"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/3101","id":82171838,"html_url":"https://github.com/coreos/rkt/pull/3101","diff_url":"https://github.com/coreos/rkt/pull/3101.diff","patch_url":"https://github.com/coreos/rkt/pull/3101.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/3101","number":3101,"state":"open","locked":false,"title":"rkt: Implement distribution concept","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"This is the implementation of the distribution concept proposed in #2953.\r\n\r\n--\r\n\r\nThis patch implements the distribution concept with the three initial kind of\r\ndistributions already used by rkt (appc, aci-archive, docker).\r\n\r\nIt just makes the smallest required changes to the fetchers logic to make them\r\nwork and pass the functional tests.\r\n\r\nThis is the base for future fetchers (#2964) and store (#3071) refactors.","created_at":"2016-08-22T11:05:55Z","updated_at":"2016-08-22T14:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0c914428b900797db7fb5bc9ca1036b8fd75d1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/3101/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/3101/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/3101/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/369af1f2b35e9c176cd171bb008be8f5dbb424a1","head":{"label":"sgotti:distribution_uri_impl","ref":"distribution_uri_impl","sha":"369af1f2b35e9c176cd171bb008be8f5dbb424a1","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"repo":{"id":27428376,"name":"rkt","full_name":"sgotti/rkt","owner":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgotti/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/sgotti/rkt","forks_url":"https://api.github.com/repos/sgotti/rkt/forks","keys_url":"https://api.github.com/repos/sgotti/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgotti/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgotti/rkt/teams","hooks_url":"https://api.github.com/repos/sgotti/rkt/hooks","issue_events_url":"https://api.github.com/repos/sgotti/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/sgotti/rkt/events","assignees_url":"https://api.github.com/repos/sgotti/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/sgotti/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/sgotti/rkt/tags","blobs_url":"https://api.github.com/repos/sgotti/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgotti/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgotti/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgotti/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgotti/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/sgotti/rkt/languages","stargazers_url":"https://api.github.com/repos/sgotti/rkt/stargazers","contributors_url":"https://api.github.com/repos/sgotti/rkt/contributors","subscribers_url":"https://api.github.com/repos/sgotti/rkt/subscribers","subscription_url":"https://api.github.com/repos/sgotti/rkt/subscription","commits_url":"https://api.github.com/repos/sgotti/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgotti/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgotti/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgotti/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgotti/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/sgotti/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgotti/rkt/merges","archive_url":"https://api.github.com/repos/sgotti/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgotti/rkt/downloads","issues_url":"https://api.github.com/repos/sgotti/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/sgotti/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/sgotti/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/sgotti/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgotti/rkt/labels{/name}","releases_url":"https://api.github.com/repos/sgotti/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/sgotti/rkt/deployments","created_at":"2014-12-02T10:56:31Z","updated_at":"2016-03-21T15:26:18Z","pushed_at":"2016-08-22T12:27:46Z","git_url":"git://github.com/sgotti/rkt.git","ssh_url":"git@github.com:sgotti/rkt.git","clone_url":"https://github.com/sgotti/rkt.git","svn_url":"https://github.com/sgotti/rkt","homepage":"","size":22900,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"0b40dcd5378e189f07a167f23ec848ed8c22c04d","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is a container engine for Linux designed to be composable, secure, and built on standards","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-08-22T10:31:27Z","pushed_at":"2016-08-22T14:19:39Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":32613,"stargazers_count":5829,"watchers_count":5829,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":570,"mirror_url":null,"open_issues_count":366,"forks":570,"open_issues":366,"watchers":5829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3101"},"html":{"href":"https://github.com/coreos/rkt/pull/3101"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/3101"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/3101/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3101/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3101/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/369af1f2b35e9c176cd171bb008be8f5dbb424a1"}}}}
{"actor":{"display_login":"sgotti"}}