{"action":"closed","number":736,"pull_request":{"url":"https://api.github.com/repos/owncloud/calendar/pulls/736","id":84453066,"html_url":"https://github.com/owncloud/calendar/pull/736","diff_url":"https://github.com/owncloud/calendar/pull/736.diff","patch_url":"https://github.com/owncloud/calendar/pull/736.patch","issue_url":"https://api.github.com/repos/owncloud/calendar/issues/736","number":736,"state":"closed","locked":false,"title":"Rename lang to locale for FullCalendar 3.0.0","user":{"login":"peternowee","id":10220583,"avatar_url":"https://avatars.githubusercontent.com/u/10220583?v=3","gravatar_id":"","url":"https://api.github.com/users/peternowee","html_url":"https://github.com/peternowee","followers_url":"https://api.github.com/users/peternowee/followers","following_url":"https://api.github.com/users/peternowee/following{/other_user}","gists_url":"https://api.github.com/users/peternowee/gists{/gist_id}","starred_url":"https://api.github.com/users/peternowee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternowee/subscriptions","organizations_url":"https://api.github.com/users/peternowee/orgs","repos_url":"https://api.github.com/users/peternowee/repos","events_url":"https://api.github.com/users/peternowee/events{/privacy}","received_events_url":"https://api.github.com/users/peternowee/received_events","type":"User","site_admin":false},"body":"In FullCalendar 3.0.0, the `lang` option was renamed to `locale`.\r\n\r\nUsing the old `lang` option, the FullCalendar locale will not be set, which might lead to unexpected results. For example, week numbers will be calculated wrong (using the week number option proposed in owncloud/calendar#262):\r\n\r\n**Before this fix**\r\nCalendar app with FullCalendar 3.0.0, German locale, using option `lang`, showing week numbers 1 too high:\r\n![20160908 oc week number wrong after fc v3 renamed lang to locale](https://cloud.githubusercontent.com/assets/10220583/18345991/544bf30a-75be-11e6-9ec6-fa09f3868e95.png)\r\n\r\n**After this fix**\r\nCalendar app with FullCalendar 3.0.0, German locale, using option `locale`, showing correct week numbers:\r\n![20160908 oc week number fixed after fc v3 renamed lang to locale](https://cloud.githubusercontent.com/assets/10220583/18345995/55db7e0c-75be-11e6-87d8-d66fdb517f82.png)\r\n\r\nFiling a separate PR because it might lead to other problems (not related to week numbers) as well.","created_at":"2016-09-08T10:35:19Z","updated_at":"2016-09-09T13:59:13Z","closed_at":"2016-09-09T13:59:13Z","merged_at":"2016-09-09T13:59:13Z","merge_commit_sha":"f6cdbff771de74b50fcdf6d732b3616bce28ef94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/calendar/pulls/736/commits","review_comments_url":"https://api.github.com/repos/owncloud/calendar/pulls/736/comments","review_comment_url":"https://api.github.com/repos/owncloud/calendar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/calendar/issues/736/comments","statuses_url":"https://api.github.com/repos/owncloud/calendar/statuses/baccafebe0d2a3894cfc7399a37554592d531a8f","head":{"label":"peternowee:fix-fc-locale","ref":"fix-fc-locale","sha":"baccafebe0d2a3894cfc7399a37554592d531a8f","user":{"login":"peternowee","id":10220583,"avatar_url":"https://avatars.githubusercontent.com/u/10220583?v=3","gravatar_id":"","url":"https://api.github.com/users/peternowee","html_url":"https://github.com/peternowee","followers_url":"https://api.github.com/users/peternowee/followers","following_url":"https://api.github.com/users/peternowee/following{/other_user}","gists_url":"https://api.github.com/users/peternowee/gists{/gist_id}","starred_url":"https://api.github.com/users/peternowee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternowee/subscriptions","organizations_url":"https://api.github.com/users/peternowee/orgs","repos_url":"https://api.github.com/users/peternowee/repos","events_url":"https://api.github.com/users/peternowee/events{/privacy}","received_events_url":"https://api.github.com/users/peternowee/received_events","type":"User","site_admin":false},"repo":{"id":50183200,"name":"calendar","full_name":"peternowee/calendar","owner":{"login":"peternowee","id":10220583,"avatar_url":"https://avatars.githubusercontent.com/u/10220583?v=3","gravatar_id":"","url":"https://api.github.com/users/peternowee","html_url":"https://github.com/peternowee","followers_url":"https://api.github.com/users/peternowee/followers","following_url":"https://api.github.com/users/peternowee/following{/other_user}","gists_url":"https://api.github.com/users/peternowee/gists{/gist_id}","starred_url":"https://api.github.com/users/peternowee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternowee/subscriptions","organizations_url":"https://api.github.com/users/peternowee/orgs","repos_url":"https://api.github.com/users/peternowee/repos","events_url":"https://api.github.com/users/peternowee/events{/privacy}","received_events_url":"https://api.github.com/users/peternowee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peternowee/calendar","description":":date: Calendar app for ownCloud 9+","fork":true,"url":"https://api.github.com/repos/peternowee/calendar","forks_url":"https://api.github.com/repos/peternowee/calendar/forks","keys_url":"https://api.github.com/repos/peternowee/calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peternowee/calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peternowee/calendar/teams","hooks_url":"https://api.github.com/repos/peternowee/calendar/hooks","issue_events_url":"https://api.github.com/repos/peternowee/calendar/issues/events{/number}","events_url":"https://api.github.com/repos/peternowee/calendar/events","assignees_url":"https://api.github.com/repos/peternowee/calendar/assignees{/user}","branches_url":"https://api.github.com/repos/peternowee/calendar/branches{/branch}","tags_url":"https://api.github.com/repos/peternowee/calendar/tags","blobs_url":"https://api.github.com/repos/peternowee/calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peternowee/calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peternowee/calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/peternowee/calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peternowee/calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/peternowee/calendar/languages","stargazers_url":"https://api.github.com/repos/peternowee/calendar/stargazers","contributors_url":"https://api.github.com/repos/peternowee/calendar/contributors","subscribers_url":"https://api.github.com/repos/peternowee/calendar/subscribers","subscription_url":"https://api.github.com/repos/peternowee/calendar/subscription","commits_url":"https://api.github.com/repos/peternowee/calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/peternowee/calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/peternowee/calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/peternowee/calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/peternowee/calendar/contents/{+path}","compare_url":"https://api.github.com/repos/peternowee/calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peternowee/calendar/merges","archive_url":"https://api.github.com/repos/peternowee/calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peternowee/calendar/downloads","issues_url":"https://api.github.com/repos/peternowee/calendar/issues{/number}","pulls_url":"https://api.github.com/repos/peternowee/calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/peternowee/calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/peternowee/calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peternowee/calendar/labels{/name}","releases_url":"https://api.github.com/repos/peternowee/calendar/releases{/id}","deployments_url":"https://api.github.com/repos/peternowee/calendar/deployments","created_at":"2016-01-22T13:33:10Z","updated_at":"2016-03-03T17:34:31Z","pushed_at":"2016-09-09T12:05:18Z","git_url":"git://github.com/peternowee/calendar.git","ssh_url":"git@github.com:peternowee/calendar.git","clone_url":"https://github.com/peternowee/calendar.git","svn_url":"https://github.com/peternowee/calendar","homepage":"https://webchat.freenode.net/?channels=owncloud-calendar","size":12379,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"8dd47536b3d4b943b7a0a24a3dc88bc41d559b2f","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":41913731,"name":"calendar","full_name":"owncloud/calendar","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/calendar","description":":date: Calendar app for ownCloud/Nextcloud 9+","fork":false,"url":"https://api.github.com/repos/owncloud/calendar","forks_url":"https://api.github.com/repos/owncloud/calendar/forks","keys_url":"https://api.github.com/repos/owncloud/calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/calendar/teams","hooks_url":"https://api.github.com/repos/owncloud/calendar/hooks","issue_events_url":"https://api.github.com/repos/owncloud/calendar/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/calendar/events","assignees_url":"https://api.github.com/repos/owncloud/calendar/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/calendar/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/calendar/tags","blobs_url":"https://api.github.com/repos/owncloud/calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/calendar/languages","stargazers_url":"https://api.github.com/repos/owncloud/calendar/stargazers","contributors_url":"https://api.github.com/repos/owncloud/calendar/contributors","subscribers_url":"https://api.github.com/repos/owncloud/calendar/subscribers","subscription_url":"https://api.github.com/repos/owncloud/calendar/subscription","commits_url":"https://api.github.com/repos/owncloud/calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/calendar/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/calendar/merges","archive_url":"https://api.github.com/repos/owncloud/calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/calendar/downloads","issues_url":"https://api.github.com/repos/owncloud/calendar/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/calendar/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/calendar/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/calendar/deployments","created_at":"2015-09-04T12:08:35Z","updated_at":"2016-09-09T11:01:36Z","pushed_at":"2016-09-09T13:59:13Z","git_url":"git://github.com/owncloud/calendar.git","ssh_url":"git@github.com:owncloud/calendar.git","clone_url":"https://github.com/owncloud/calendar.git","svn_url":"https://github.com/owncloud/calendar","homepage":"https://webchat.freenode.net/?channels=owncloud-calendar","size":15903,"stargazers_count":78,"watchers_count":78,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":104,"forks":35,"open_issues":104,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/736"},"html":{"href":"https://github.com/owncloud/calendar/pull/736"},"issue":{"href":"https://api.github.com/repos/owncloud/calendar/issues/736"},"comments":{"href":"https://api.github.com/repos/owncloud/calendar/issues/736/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/736/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/736/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/calendar/statuses/baccafebe0d2a3894cfc7399a37554592d531a8f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"raghunayyar","id":992488,"avatar_url":"https://avatars.githubusercontent.com/u/992488?v=3","gravatar_id":"","url":"https://api.github.com/users/raghunayyar","html_url":"https://github.com/raghunayyar","followers_url":"https://api.github.com/users/raghunayyar/followers","following_url":"https://api.github.com/users/raghunayyar/following{/other_user}","gists_url":"https://api.github.com/users/raghunayyar/gists{/gist_id}","starred_url":"https://api.github.com/users/raghunayyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghunayyar/subscriptions","organizations_url":"https://api.github.com/users/raghunayyar/orgs","repos_url":"https://api.github.com/users/raghunayyar/repos","events_url":"https://api.github.com/users/raghunayyar/events{/privacy}","received_events_url":"https://api.github.com/users/raghunayyar/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"raghunayyar"}}