{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/49016535","id":49016535,"diff_hunk":"@@ -99,47 +121,95 @@ class LoginDetailViewController: UITableViewController {\n         UIMenuController.sharedMenuController().menuItems = [copyItem, revealPasswordItem, hidePasswordItem, openAndFillItem]\n         UIMenuController.sharedMenuController().update()\n \n-        NSNotificationCenter.defaultCenter().addObserver(self, selector: \"SELwillShowMenuController\", name: UIMenuControllerWillShowMenuNotification, object: nil)\n-        NSNotificationCenter.defaultCenter().addObserver(self, selector: \"SELwillHideMenuController\", name: UIMenuControllerWillHideMenuNotification, object: nil)\n+        let notificationCenter = NSNotificationCenter.defaultCenter()\n+        notificationCenter.addObserver(self, selector: \"SELwillShowMenuController\", name: UIMenuControllerWillShowMenuNotification, object: nil)\n+        notificationCenter.addObserver(self, selector: \"SELwillHideMenuController\", name: UIMenuControllerWillHideMenuNotification, object: nil)\n     }\n \n     deinit {\n-        NSNotificationCenter.defaultCenter().removeObserver(self, name: UIMenuControllerWillShowMenuNotification, object: nil)\n-        NSNotificationCenter.defaultCenter().removeObserver(self, name: UIMenuControllerWillHideMenuNotification, object: nil)\n-    }\n-\n-    override func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {\n-        let section = ListSection(rawValue: indexPath.section)!\n-\n-        switch section {\n-        case .Info:\n-            let loginCell = tableView.dequeueReusableCellWithIdentifier(LoginCellIdentifier, forIndexPath: indexPath) as! LoginTableViewCell\n-            loginCell.selectionStyle = .None\n-            loginCell.delegate = self\n-\n-            switch InfoItem(rawValue: indexPath.row)! {\n-            case .TitleItem:\n-                loginCell.style = .IconAndDescriptionLabel\n-                loginCell.descriptionLabel.text = login.hostname\n-            case .UsernameItem:\n-                loginCell.style = .NoIconAndBothLabels\n-                loginCell.highlightedLabel.text = NSLocalizedString(\"username\", tableName: \"LoginManager\", comment: \"Title for username row in Login Detail View\")\n-                loginCell.descriptionLabel.text = login.username\n-            case .PasswordItem:\n-                loginCell.style = .NoIconAndBothLabels\n-                loginCell.highlightedLabel.text = NSLocalizedString(\"password\", tableName: \"LoginManager\", comment: \"Title for password row in Login Detail View\")\n-                loginCell.descriptionLabel.text = login.password\n-                loginCell.descriptionLabel.secureTextEntry = true\n-                loginCell.enabledActions = [.Copy, .Reveal]\n-            case .WebsiteItem:\n-                loginCell.style = .NoIconAndBothLabels\n-                loginCell.highlightedLabel.text = NSLocalizedString(\"website\", tableName: \"LoginManager\", comment: \"Title for website row in Login Detail View\")\n-                loginCell.descriptionLabel.text = login.hostname\n-                loginCell.enabledActions = [.Copy, .OpenAndFill]\n-            }\n+        let notificationCenter = NSNotificationCenter.defaultCenter()\n+        notificationCenter.removeObserver(self, name: NotificationProfileDidFinishSyncing, object: nil)\n+        notificationCenter.removeObserver(self, name: UIMenuControllerWillShowMenuNotification, object: nil)\n+        notificationCenter.removeObserver(self, name: UIMenuControllerWillHideMenuNotification, object: nil)\n+    }\n+\n+    override func viewDidLayoutSubviews() {\n+        super.viewDidLayoutSubviews()\n+\n+        // The following hacks are to prevent the default cell seperators from displaying. We want to\n+        // hide the default seperator for the website/last modified cells since the last modified cell\n+        // draws it's own seperators. The last item in the list draws its seperator full width. The reason","path":"Client/Frontend/Settings/LoginDetailViewController.swift","position":178,"original_position":178,"commit_id":"3e0901a6680d5c1e23dcf81cdff0315cff4544c9","original_commit_id":"3e0901a6680d5c1e23dcf81cdff0315cff4544c9","user":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"body":"Nit: `it's` -> `its`. Also, finish (or delete) the next sentence.","created_at":"2016-01-06T22:07:29Z","updated_at":"2016-01-06T22:07:29Z","html_url":"https://github.com/mozilla/firefox-ios/pull/1406#discussion_r49016535","pull_request_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406","_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/49016535"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/1406#discussion_r49016535"},"pull_request":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406","id":55236179,"html_url":"https://github.com/mozilla/firefox-ios/pull/1406","diff_url":"https://github.com/mozilla/firefox-ios/pull/1406.diff","patch_url":"https://github.com/mozilla/firefox-ios/pull/1406.patch","issue_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/1406","number":1406,"state":"open","locked":false,"title":"Bug 1221595 - Editing login from detail screen","user":{"login":"sleroux","id":434322,"avatar_url":"https://avatars.githubusercontent.com/u/434322?v=3","gravatar_id":"","url":"https://api.github.com/users/sleroux","html_url":"https://github.com/sleroux","followers_url":"https://api.github.com/users/sleroux/followers","following_url":"https://api.github.com/users/sleroux/following{/other_user}","gists_url":"https://api.github.com/users/sleroux/gists{/gist_id}","starred_url":"https://api.github.com/users/sleroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleroux/subscriptions","organizations_url":"https://api.github.com/users/sleroux/orgs","repos_url":"https://api.github.com/users/sleroux/repos","events_url":"https://api.github.com/users/sleroux/events{/privacy}","received_events_url":"https://api.github.com/users/sleroux/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-01-06T16:59:12Z","updated_at":"2016-01-06T22:07:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6b39331aa166698527a97bfc566fcca6a52380f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406/commits","review_comments_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406/comments","review_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/1406/comments","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/3e0901a6680d5c1e23dcf81cdff0315cff4544c9","head":{"label":"mozilla:sleroux/Bug1221595-EditLoginDetail","ref":"sleroux/Bug1221595-EditLoginDetail","sha":"3e0901a6680d5c1e23dcf81cdff0315cff4544c9","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla/firefox-ios","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla/firefox-ios","forks_url":"https://api.github.com/repos/mozilla/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/firefox-ios/releases{/id}","created_at":"2014-11-03T19:07:02Z","updated_at":"2016-01-06T18:56:36Z","pushed_at":"2016-01-06T22:03:53Z","git_url":"git://github.com/mozilla/firefox-ios.git","ssh_url":"git@github.com:mozilla/firefox-ios.git","clone_url":"https://github.com/mozilla/firefox-ios.git","svn_url":"https://github.com/mozilla/firefox-ios","homepage":"","size":114935,"stargazers_count":5164,"watchers_count":5164,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":932,"mirror_url":null,"open_issues_count":96,"forks":932,"open_issues":96,"watchers":5164,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"a39e055f41293abfe1ed1db35fc916a01dd8f3d2","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla/firefox-ios","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla/firefox-ios","forks_url":"https://api.github.com/repos/mozilla/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/firefox-ios/releases{/id}","created_at":"2014-11-03T19:07:02Z","updated_at":"2016-01-06T18:56:36Z","pushed_at":"2016-01-06T22:03:53Z","git_url":"git://github.com/mozilla/firefox-ios.git","ssh_url":"git@github.com:mozilla/firefox-ios.git","clone_url":"https://github.com/mozilla/firefox-ios.git","svn_url":"https://github.com/mozilla/firefox-ios","homepage":"","size":114935,"stargazers_count":5164,"watchers_count":5164,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":932,"mirror_url":null,"open_issues_count":96,"forks":932,"open_issues":96,"watchers":5164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/1406"},"issue":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/1406"},"comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/1406/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/1406/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/firefox-ios/statuses/3e0901a6680d5c1e23dcf81cdff0315cff4544c9"}}}}