{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/55148076","id":55148076,"diff_hunk":"@@ -46,6 +46,7 @@ stdenv.mkDerivation rec {\n   # I set --disable-strip because later we strip anyway. And it fails to strip\n   # properly when cross building.\n   configureFlags = [\n+    \"--sbindir=\\${out}/bin\"","path":"pkgs/tools/networking/openssh/default.nix","position":4,"original_position":4,"commit_id":"bb39304ce6169ca0c7f421f15cb1b0c378999b7e","original_commit_id":"bb39304ce6169ca0c7f421f15cb1b0c378999b7e","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"body":"The fixup script does work here, but I'd rather use the configure flag to point sbin at the bin dir in the first place instead of putting it in sbin and using the script to fix it up. Essentially, I consider the fixup script a bit of a hack, and I'd rather see it get less usage instead of more, considering there is a sanctioned way to do this via configure.\r\n\r\nThis should also be (very slightly) faster.","created_at":"2016-03-06T21:02:34Z","updated_at":"2016-03-06T21:02:34Z","html_url":"https://github.com/NixOS/nixpkgs/pull/13705#discussion_r55148076","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/55148076"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13705#discussion_r55148076"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705","id":61834224,"html_url":"https://github.com/NixOS/nixpkgs/pull/13705","diff_url":"https://github.com/NixOS/nixpkgs/pull/13705.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/13705.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13705","number":13705,"state":"open","locked":false,"title":"openssh: use bin instead of sbin folder","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"body":"###### Things done:\r\n\r\n- [ ] Tested using sandboxing (`nix-build --option build-use-chroot true` or [nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS)\r\n- [x] Built on platform(s): Nix on Arch Linux\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\nThe nox-review command had this output, so I don't know if I used it properly:\r\n```\r\nNo uncommit changes. Did you mean to use the \"--against\" option?\r\n```\r\n\r\nReferences #11939.","created_at":"2016-03-06T05:14:45Z","updated_at":"2016-03-06T21:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8fc73115ec34bfd7eedda89892f8d6cf387eb72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13705/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bb39304ce6169ca0c7f421f15cb1b0c378999b7e","head":{"label":"aneeshusa:use-bin-instead-of-sbin-for-openssh","ref":"use-bin-instead-of-sbin-for-openssh","sha":"bb39304ce6169ca0c7f421f15cb1b0c378999b7e","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"repo":{"id":43405996,"name":"nixpkgs","full_name":"aneeshusa/nixpkgs","owner":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aneeshusa/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/aneeshusa/nixpkgs","forks_url":"https://api.github.com/repos/aneeshusa/nixpkgs/forks","keys_url":"https://api.github.com/repos/aneeshusa/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aneeshusa/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aneeshusa/nixpkgs/teams","hooks_url":"https://api.github.com/repos/aneeshusa/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/aneeshusa/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/aneeshusa/nixpkgs/events","assignees_url":"https://api.github.com/repos/aneeshusa/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/aneeshusa/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/aneeshusa/nixpkgs/tags","blobs_url":"https://api.github.com/repos/aneeshusa/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aneeshusa/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aneeshusa/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/aneeshusa/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aneeshusa/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/aneeshusa/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/aneeshusa/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/aneeshusa/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/aneeshusa/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/aneeshusa/nixpkgs/subscription","commits_url":"https://api.github.com/repos/aneeshusa/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/aneeshusa/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/aneeshusa/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/aneeshusa/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/aneeshusa/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/aneeshusa/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aneeshusa/nixpkgs/merges","archive_url":"https://api.github.com/repos/aneeshusa/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aneeshusa/nixpkgs/downloads","issues_url":"https://api.github.com/repos/aneeshusa/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/aneeshusa/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/aneeshusa/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/aneeshusa/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aneeshusa/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/aneeshusa/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/aneeshusa/nixpkgs/deployments","created_at":"2015-09-30T02:03:44Z","updated_at":"2016-02-18T06:17:24Z","pushed_at":"2016-03-06T04:57:48Z","git_url":"git://github.com/aneeshusa/nixpkgs.git","ssh_url":"git@github.com:aneeshusa/nixpkgs.git","clone_url":"https://github.com/aneeshusa/nixpkgs.git","svn_url":"https://github.com/aneeshusa/nixpkgs","homepage":null,"size":319207,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"0bf8a1a86df67649893726d50761567121330006","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-03-03T14:36:30Z","pushed_at":"2016-03-06T20:59:40Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":357124,"stargazers_count":967,"watchers_count":967,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1303,"mirror_url":null,"open_issues_count":1290,"forks":1303,"open_issues":1290,"watchers":967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13705"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13705"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13705/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13705/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bb39304ce6169ca0c7f421f15cb1b0c378999b7e"}}}}