{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/4772","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/4772/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/4772/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/4772/events","html_url":"https://github.com/minetest/minetest/pull/4772","id":188981000,"number":4772,"title":"[WIP] Hide map generators, warn about discouraged map generators and seed in world creation by subgame request","user":{"login":"Wuzzy2","id":1675853,"avatar_url":"https://avatars.githubusercontent.com/u/1675853?v=3","gravatar_id":"","url":"https://api.github.com/users/Wuzzy2","html_url":"https://github.com/Wuzzy2","followers_url":"https://api.github.com/users/Wuzzy2/followers","following_url":"https://api.github.com/users/Wuzzy2/following{/other_user}","gists_url":"https://api.github.com/users/Wuzzy2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wuzzy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wuzzy2/subscriptions","organizations_url":"https://api.github.com/users/Wuzzy2/orgs","repos_url":"https://api.github.com/users/Wuzzy2/repos","events_url":"https://api.github.com/users/Wuzzy2/events{/privacy}","received_events_url":"https://api.github.com/users/Wuzzy2/received_events","type":"User","site_admin":false},"labels":[{"id":110411003,"url":"https://api.github.com/repos/minetest/minetest/labels/WIP","name":"WIP","color":"aa3000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-13T16:58:50Z","updated_at":"2016-11-14T07:47:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/4772","html_url":"https://github.com/minetest/minetest/pull/4772","diff_url":"https://github.com/minetest/minetest/pull/4772.diff","patch_url":"https://github.com/minetest/minetest/pull/4772.patch"},"body":"**This is a work in progress! Do not merge yet.**\r\n\r\nSee: https://github.com/minetest/minetest/issues/4768\r\n\r\nThe subgame's game.conf now supports 3 optional new settings:\r\n- available_mapgens: List of mapgens which are available for this subgame. Useful to filter out unused or broken (for the subgame) mapgens.\r\n- discouraged_mapgens: List of mapgens which don't work very well with the subgame but are not completely useless.\r\n- mapgen_seed_used: If false, subgame does not need the seed.\r\n\r\nThese settings currently affect the world creation window. Unavailable mapgens will be hidden, discouraged mapgens show a warning when selected and the seed input field is hidden if it is not needed by the subgame.\r\n\r\nTODO:\r\n- Update widgets when user selects new subgame in this window.\r\n- Update widgets when user selects new mapgen\r\n- Update docs"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/260268826","html_url":"https://github.com/minetest/minetest/pull/4772#issuecomment-260268826","issue_url":"https://api.github.com/repos/minetest/minetest/issues/4772","id":260268826,"user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T07:47:58Z","updated_at":"2016-11-14T07:47:58Z","body":":-1: \r\nA subgame is a collection of mods, it doesn't make sense to have this feature for subgames and not mods, and i'm not suggesting it should be added for mods, it can't be because mods are enabled after world creation.\r\nThis is also overcomplex, we do not need 'discouraged mapgens' or 'mapgen seed used'.\r\n'discouraged mapgens' is overkill, a subgame either supports a mapgen or it doesn't.\r\n\r\n> Even the \"seed\" field might not be needed for a singlenode game that intends to have a deterministic map generation, like the tutorial game for example.\r\n\r\nIf it's not used there's no harm in entering it by mistake, code to avoid this is not justified. A subgame not using a seed is very rare anyway.\r\n\r\nIf a subgame works well in 3 mapgens and not in the others, it will have code to change the mapgen to a supported one."}}
{"actor":{"display_login":"paramat"}}