{"action":"created","comment":{"url":"https://api.github.com/repos/firehol/netdata/pulls/comments/59099923","id":59099923,"diff_hunk":"@@ -0,0 +1,15 @@\n+@localstatedir_POST@/log/netdata/*.log {\n+\tdaily\n+\tmissingok\n+\trotate 14\n+\tcompress\n+\tdelaycompress\n+\tnotifempty\n+\tsharedscripts\n+\tpostrotate\n+\t\tif service netdata status > /dev/null ; then \\\n+\t\t\tservice netdata restart > /dev/null; \\\n+\t\tfi;","path":"system/netdata.logrotate.in","position":12,"original_position":12,"commit_id":"62d8fc5c2279613fe86456ff0f6c99ad699d6ca4","original_commit_id":"b29e2950b20377593ad4e6a3ce13e59c64bf9a12","user":{"login":"mcnewton","id":1319836,"avatar_url":"https://avatars.githubusercontent.com/u/1319836?v=3","gravatar_id":"","url":"https://api.github.com/users/mcnewton","html_url":"https://github.com/mcnewton","followers_url":"https://api.github.com/users/mcnewton/followers","following_url":"https://api.github.com/users/mcnewton/following{/other_user}","gists_url":"https://api.github.com/users/mcnewton/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnewton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnewton/subscriptions","organizations_url":"https://api.github.com/users/mcnewton/orgs","repos_url":"https://api.github.com/users/mcnewton/repos","events_url":"https://api.github.com/users/mcnewton/events{/privacy}","received_events_url":"https://api.github.com/users/mcnewton/received_events","type":"User","site_admin":false},"body":"Do the children write to the logfiles in /var/log/netdata as well, though? It's just access.log, debug.log and error.log.","created_at":"2016-04-08T22:54:13Z","updated_at":"2016-04-08T22:54:13Z","html_url":"https://github.com/firehol/netdata/pull/132#discussion_r59099923","pull_request_url":"https://api.github.com/repos/firehol/netdata/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/firehol/netdata/pulls/comments/59099923"},"html":{"href":"https://github.com/firehol/netdata/pull/132#discussion_r59099923"},"pull_request":{"href":"https://api.github.com/repos/firehol/netdata/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/firehol/netdata/pulls/132","id":65005558,"html_url":"https://github.com/firehol/netdata/pull/132","diff_url":"https://github.com/firehol/netdata/pull/132.diff","patch_url":"https://github.com/firehol/netdata/pull/132.patch","issue_url":"https://api.github.com/repos/firehol/netdata/issues/132","number":132,"state":"open","locked":false,"title":"Add Debian packaging","user":{"login":"mcnewton","id":1319836,"avatar_url":"https://avatars.githubusercontent.com/u/1319836?v=3","gravatar_id":"","url":"https://api.github.com/users/mcnewton","html_url":"https://github.com/mcnewton","followers_url":"https://api.github.com/users/mcnewton/followers","following_url":"https://api.github.com/users/mcnewton/following{/other_user}","gists_url":"https://api.github.com/users/mcnewton/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnewton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnewton/subscriptions","organizations_url":"https://api.github.com/users/mcnewton/orgs","repos_url":"https://api.github.com/users/mcnewton/repos","events_url":"https://api.github.com/users/mcnewton/events{/privacy}","received_events_url":"https://api.github.com/users/mcnewton/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI wanted to put this (great looking!) software on a couple of servers for testing. However, we need it in Debian packages for that and there was no debian/ directory, so I've created basic Debian packaging for it.\r\n\r\nIt's not entirely lintian clean; the main issue being no init script so Jessie only (and a few things such as sources missing for minified js files, which probably should be pulled in from other Debian packages per normal Debian policy), but it's fine for use on a local system.\r\n\r\nI added in the standard configure script, which was missing, so that there is no build dependency on the autoconf/automake tools. Systems shouldn't generally be required to have these installed to be able to build.\r\n\r\nThe packaging puts the systemd service file on as well as a logrotate script. As the web files are user-editable it puts them in /var/lib/netdata owned by a new netdata user which it creates/removes.\r\n\r\nI think the only possible controversial thing it does is to chmod 4755 the apps plugin. Your installer does this, but I think it's generally frowned upon in Debian circles because of the security risk (might be wrong, though). Maybe the daemon could keep enough root privileges to be able to run plugins as root when required, rather than making them setuid and accessible by any user of the system? The normal Debian solution would probably be to install the file non-suid (so lose the functionality) but mention it in the Debian README.\r\n\r\nAside from that, it seems to work fine here. Hope this is useful!\r\n\r\nCheers,\r\nMatthew","created_at":"2016-04-01T21:09:07Z","updated_at":"2016-04-08T22:54:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bdd03ab3b6e1c29d7486ea51802d6524b0a4173","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/firehol/netdata/pulls/132/commits","review_comments_url":"https://api.github.com/repos/firehol/netdata/pulls/132/comments","review_comment_url":"https://api.github.com/repos/firehol/netdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/132/comments","statuses_url":"https://api.github.com/repos/firehol/netdata/statuses/62d8fc5c2279613fe86456ff0f6c99ad699d6ca4","head":{"label":"mcnewton:debianpkg","ref":"debianpkg","sha":"62d8fc5c2279613fe86456ff0f6c99ad699d6ca4","user":{"login":"mcnewton","id":1319836,"avatar_url":"https://avatars.githubusercontent.com/u/1319836?v=3","gravatar_id":"","url":"https://api.github.com/users/mcnewton","html_url":"https://github.com/mcnewton","followers_url":"https://api.github.com/users/mcnewton/followers","following_url":"https://api.github.com/users/mcnewton/following{/other_user}","gists_url":"https://api.github.com/users/mcnewton/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnewton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnewton/subscriptions","organizations_url":"https://api.github.com/users/mcnewton/orgs","repos_url":"https://api.github.com/users/mcnewton/repos","events_url":"https://api.github.com/users/mcnewton/events{/privacy}","received_events_url":"https://api.github.com/users/mcnewton/received_events","type":"User","site_admin":false},"repo":{"id":55258375,"name":"netdata","full_name":"mcnewton/netdata","owner":{"login":"mcnewton","id":1319836,"avatar_url":"https://avatars.githubusercontent.com/u/1319836?v=3","gravatar_id":"","url":"https://api.github.com/users/mcnewton","html_url":"https://github.com/mcnewton","followers_url":"https://api.github.com/users/mcnewton/followers","following_url":"https://api.github.com/users/mcnewton/following{/other_user}","gists_url":"https://api.github.com/users/mcnewton/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnewton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnewton/subscriptions","organizations_url":"https://api.github.com/users/mcnewton/orgs","repos_url":"https://api.github.com/users/mcnewton/repos","events_url":"https://api.github.com/users/mcnewton/events{/privacy}","received_events_url":"https://api.github.com/users/mcnewton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcnewton/netdata","description":"Real-time performance monitoring, done right!","fork":true,"url":"https://api.github.com/repos/mcnewton/netdata","forks_url":"https://api.github.com/repos/mcnewton/netdata/forks","keys_url":"https://api.github.com/repos/mcnewton/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcnewton/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcnewton/netdata/teams","hooks_url":"https://api.github.com/repos/mcnewton/netdata/hooks","issue_events_url":"https://api.github.com/repos/mcnewton/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/mcnewton/netdata/events","assignees_url":"https://api.github.com/repos/mcnewton/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/mcnewton/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/mcnewton/netdata/tags","blobs_url":"https://api.github.com/repos/mcnewton/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcnewton/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcnewton/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcnewton/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcnewton/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/mcnewton/netdata/languages","stargazers_url":"https://api.github.com/repos/mcnewton/netdata/stargazers","contributors_url":"https://api.github.com/repos/mcnewton/netdata/contributors","subscribers_url":"https://api.github.com/repos/mcnewton/netdata/subscribers","subscription_url":"https://api.github.com/repos/mcnewton/netdata/subscription","commits_url":"https://api.github.com/repos/mcnewton/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcnewton/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcnewton/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcnewton/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcnewton/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/mcnewton/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcnewton/netdata/merges","archive_url":"https://api.github.com/repos/mcnewton/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcnewton/netdata/downloads","issues_url":"https://api.github.com/repos/mcnewton/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/mcnewton/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/mcnewton/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/mcnewton/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcnewton/netdata/labels{/name}","releases_url":"https://api.github.com/repos/mcnewton/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/mcnewton/netdata/deployments","created_at":"2016-04-01T19:50:09Z","updated_at":"2016-04-01T19:50:10Z","pushed_at":"2016-04-08T22:39:45Z","git_url":"git://github.com/mcnewton/netdata.git","ssh_url":"git@github.com:mcnewton/netdata.git","clone_url":"https://github.com/mcnewton/netdata.git","svn_url":"https://github.com/mcnewton/netdata","homepage":"http://netdata.firehol.org","size":2986,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firehol:master","ref":"master","sha":"781418661c0309059eb2debbe352d39f750bf21d","user":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"repo":{"id":10744183,"name":"netdata","full_name":"firehol/netdata","owner":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firehol/netdata","description":"Real-time performance monitoring, done right!","fork":false,"url":"https://api.github.com/repos/firehol/netdata","forks_url":"https://api.github.com/repos/firehol/netdata/forks","keys_url":"https://api.github.com/repos/firehol/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firehol/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firehol/netdata/teams","hooks_url":"https://api.github.com/repos/firehol/netdata/hooks","issue_events_url":"https://api.github.com/repos/firehol/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/firehol/netdata/events","assignees_url":"https://api.github.com/repos/firehol/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/firehol/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/firehol/netdata/tags","blobs_url":"https://api.github.com/repos/firehol/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firehol/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firehol/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/firehol/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firehol/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/firehol/netdata/languages","stargazers_url":"https://api.github.com/repos/firehol/netdata/stargazers","contributors_url":"https://api.github.com/repos/firehol/netdata/contributors","subscribers_url":"https://api.github.com/repos/firehol/netdata/subscribers","subscription_url":"https://api.github.com/repos/firehol/netdata/subscription","commits_url":"https://api.github.com/repos/firehol/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/firehol/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/firehol/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/firehol/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/firehol/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/firehol/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firehol/netdata/merges","archive_url":"https://api.github.com/repos/firehol/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firehol/netdata/downloads","issues_url":"https://api.github.com/repos/firehol/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/firehol/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/firehol/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/firehol/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firehol/netdata/labels{/name}","releases_url":"https://api.github.com/repos/firehol/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/firehol/netdata/deployments","created_at":"2013-06-17T18:39:10Z","updated_at":"2016-04-08T22:49:00Z","pushed_at":"2016-04-08T22:39:46Z","git_url":"git://github.com/firehol/netdata.git","ssh_url":"git@github.com:firehol/netdata.git","clone_url":"https://github.com/firehol/netdata.git","svn_url":"https://github.com/firehol/netdata","homepage":"http://netdata.firehol.org","size":3379,"stargazers_count":8475,"watchers_count":8475,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":452,"mirror_url":null,"open_issues_count":69,"forks":452,"open_issues":69,"watchers":8475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firehol/netdata/pulls/132"},"html":{"href":"https://github.com/firehol/netdata/pull/132"},"issue":{"href":"https://api.github.com/repos/firehol/netdata/issues/132"},"comments":{"href":"https://api.github.com/repos/firehol/netdata/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/firehol/netdata/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/firehol/netdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firehol/netdata/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/firehol/netdata/statuses/62d8fc5c2279613fe86456ff0f6c99ad699d6ca4"}}}}