{"action":"created","issue":{"url":"https://api.github.com/repos/i18next/i18next-parser/issues/53","repository_url":"https://api.github.com/repos/i18next/i18next-parser","labels_url":"https://api.github.com/repos/i18next/i18next-parser/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/i18next/i18next-parser/issues/53/comments","events_url":"https://api.github.com/repos/i18next/i18next-parser/issues/53/events","html_url":"https://github.com/i18next/i18next-parser/issues/53","id":174716337,"number":53,"title":"Starting from version 0.8.0 scanning i18n.t(var1 + var2) is broken","user":{"login":"bitkeeper","id":1525169,"avatar_url":"https://avatars.githubusercontent.com/u/1525169?v=3","gravatar_id":"","url":"https://api.github.com/users/bitkeeper","html_url":"https://github.com/bitkeeper","followers_url":"https://api.github.com/users/bitkeeper/followers","following_url":"https://api.github.com/users/bitkeeper/following{/other_user}","gists_url":"https://api.github.com/users/bitkeeper/gists{/gist_id}","starred_url":"https://api.github.com/users/bitkeeper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitkeeper/subscriptions","organizations_url":"https://api.github.com/users/bitkeeper/orgs","repos_url":"https://api.github.com/users/bitkeeper/repos","events_url":"https://api.github.com/users/bitkeeper/events{/privacy}","received_events_url":"https://api.github.com/users/bitkeeper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-02T09:21:14Z","updated_at":"2016-09-02T11:56:08Z","closed_at":null,"body":"Scanning\r\n```javascript\r\n  i18n.t(prefix + param);\r\n```\r\nWill result in:\r\n```\r\n[exec] [error] i18next-parser does not support variables in translation functions, use a string literal: t(prefix + param)\r\n```\r\nVersion 0.7.0 or lower doesn't have this issue.\r\nIs this construction is deliberately not supported anymore or did something break ?\r\n\r\n\r\nbtw thanks for this great scanner !"},"comment":{"url":"https://api.github.com/repos/i18next/i18next-parser/issues/comments/244355382","html_url":"https://github.com/i18next/i18next-parser/issues/53#issuecomment-244355382","issue_url":"https://api.github.com/repos/i18next/i18next-parser/issues/53","id":244355382,"user":{"login":"laszlopandy","id":927584,"avatar_url":"https://avatars.githubusercontent.com/u/927584?v=3","gravatar_id":"","url":"https://api.github.com/users/laszlopandy","html_url":"https://github.com/laszlopandy","followers_url":"https://api.github.com/users/laszlopandy/followers","following_url":"https://api.github.com/users/laszlopandy/following{/other_user}","gists_url":"https://api.github.com/users/laszlopandy/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlopandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlopandy/subscriptions","organizations_url":"https://api.github.com/users/laszlopandy/orgs","repos_url":"https://api.github.com/users/laszlopandy/repos","events_url":"https://api.github.com/users/laszlopandy/events{/privacy}","received_events_url":"https://api.github.com/users/laszlopandy/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T11:56:08Z","updated_at":"2016-09-02T11:56:08Z","body":"If you anyway have the strings in a different namespace, why don't you use a different function to get the translation for them? `I18n.t` for literals and `I18n.v` for variables for example. Then the scanner would still give you a warning if you accidentally did this:\r\n```js\r\nvar msg = \"Really long translatable string which we put into a variable so the next line doesn't wrap\";\r\ninitializeWidgets([Buttons.OK, Buttons.CANCEL], I18n.t(msg), callback);\r\n```"}}
{"actor":{"display_login":"laszlopandy"}}