{"action":"created","issue":{"url":"https://api.github.com/repos/pczarn/gameroom-task/issues/17","repository_url":"https://api.github.com/repos/pczarn/gameroom-task","labels_url":"https://api.github.com/repos/pczarn/gameroom-task/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/pczarn/gameroom-task/issues/17/comments","events_url":"https://api.github.com/repos/pczarn/gameroom-task/issues/17/events","html_url":"https://github.com/pczarn/gameroom-task/pull/17","id":183415400,"number":17,"title":"Improve code and app quality","user":{"login":"pczarn","id":3356767,"avatar_url":"https://avatars.githubusercontent.com/u/3356767?v=3","gravatar_id":"","url":"https://api.github.com/users/pczarn","html_url":"https://github.com/pczarn","followers_url":"https://api.github.com/users/pczarn/followers","following_url":"https://api.github.com/users/pczarn/following{/other_user}","gists_url":"https://api.github.com/users/pczarn/gists{/gist_id}","starred_url":"https://api.github.com/users/pczarn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pczarn/subscriptions","organizations_url":"https://api.github.com/users/pczarn/orgs","repos_url":"https://api.github.com/users/pczarn/repos","events_url":"https://api.github.com/users/pczarn/events{/privacy}","received_events_url":"https://api.github.com/users/pczarn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-17T13:25:46Z","updated_at":"2016-10-18T11:20:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pczarn/gameroom-task/pulls/17","html_url":"https://github.com/pczarn/gameroom-task/pull/17","diff_url":"https://github.com/pczarn/gameroom-task/pull/17.diff","patch_url":"https://github.com/pczarn/gameroom-task/pull/17.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pczarn/gameroom-task/17)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pczarn/gameroom-task/issues/comments/254478800","html_url":"https://github.com/pczarn/gameroom-task/pull/17#issuecomment-254478800","issue_url":"https://api.github.com/repos/pczarn/gameroom-task/issues/17","id":254478800,"user":{"login":"kapone89","id":1898786,"avatar_url":"https://avatars.githubusercontent.com/u/1898786?v=3","gravatar_id":"","url":"https://api.github.com/users/kapone89","html_url":"https://github.com/kapone89","followers_url":"https://api.github.com/users/kapone89/followers","following_url":"https://api.github.com/users/kapone89/following{/other_user}","gists_url":"https://api.github.com/users/kapone89/gists{/gist_id}","starred_url":"https://api.github.com/users/kapone89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapone89/subscriptions","organizations_url":"https://api.github.com/users/kapone89/orgs","repos_url":"https://api.github.com/users/kapone89/repos","events_url":"https://api.github.com/users/kapone89/events{/privacy}","received_events_url":"https://api.github.com/users/kapone89/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T11:20:32Z","updated_at":"2016-10-18T11:20:32Z","body":"\n\n\n\nReviewed 18 of 39 files at r1.\nReview status: 18 of 39 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[app/models/user.rb, line 28 at r1](https://reviewable.io:443/reviews/pczarn/gameroom-task/17#-KUMUHQsZi6xwIO7qwef:-KUMUHQsZi6xwIO7qweg:b-d8bskk) ([raw file](https://github.com/pczarn/gameroom-task/blob/08042b0979a1f6aed44e9f37c5c7195bcbc0385b/app/models/user.rb#L28)):*\n> ```Ruby\n> \n>   validates :name, :email, presence: true, uniqueness: true\n>   validates :email, format: /@/\n> ```\n\nPlease improve this regexp.\n\n---\n\n*[app/views/tournament_status_mailer/notify_about_match_result.text.erb, line 5 at r1](https://reviewable.io:443/reviews/pczarn/gameroom-task/17#-KUMVLlQXEVOFA_fv9an:-KUMVLlQXEVOFA_fv9ao:bvx4ylj) ([raw file](https://github.com/pczarn/gameroom-task/blob/08042b0979a1f6aed44e9f37c5c7195bcbc0385b/app/views/tournament_status_mailer/notify_about_match_result.text.erb#L5)):*\n> ```erb\n> \n> <% if @result == :win %>\n>   You won the match.\n> ```\n\nI guess you will have 2 blank spaces at the beginning of line.\n\n---\n\n*[app/views/tournament_status_mailer/notify_about_match_result.text.erb, line 10 at r1](https://reviewable.io:443/reviews/pczarn/gameroom-task/17#-KUMUygGseBYJExclE2J:-KUMUygGseBYJExclE2K:b-4hw43a) ([raw file](https://github.com/pczarn/gameroom-task/blob/08042b0979a1f6aed44e9f37c5c7195bcbc0385b/app/views/tournament_status_mailer/notify_about_match_result.text.erb#L10)):*\n> ```erb\n> <% else %>\n>   The match is finished.\n> <% end %>\n> ```\n\nThere should be more information (what match, etc.). And please use \"case\" here.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pczarn/gameroom-task/17)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"kapone89"}}