{"action":"created","comment":{"url":"https://api.github.com/repos/firmata/arduino/pulls/comments/48815469","id":48815469,"diff_hunk":"@@ -243,6 +243,23 @@ writePort(port, value, bitmask):  Write an 8 bit port.\n #define PIN_TO_SERVO(p)         ((p) - 2)\n \n \n+// Arduino/Genuino MKR1000\n+#elif defined(ARDUINO_SAMD_MKR1000)\n+#define TOTAL_ANALOG_PINS       7\n+#define TOTAL_PINS              22 // 8 digital + 3 spi + 2 i2c + 2 uart + 7 analog\n+#define IS_PIN_DIGITAL(p)       (((p) >= 0 && (p) <= 21) && !IS_PIN_SERIAL(p))\n+#define IS_PIN_ANALOG(p)        ((p) >= 15 && (p) < 15 + TOTAL_ANALOG_PINS)\n+#define IS_PIN_PWM(p)           digitalPinHasPWM(p)\n+#define IS_PIN_SERVO(p)         (IS_PIN_DIGITAL(p) && (p) < MAX_SERVOS) // deprecated since v2.4\n+#define IS_PIN_I2C(p)           ((p) == 11 || (p) == 12) // SDA = 20, SCL = 21\n+#define IS_PIN_SPI(p)           ((p) == SS || (p) == MOSI || (p) == MISO || (p) == SCK) // SS = A2\n+#define IS_PIN_SERIAL(p)        ((p) == PIN_SERIAL1_RX || (p) == PIN_SERIAL1_TX)","path":"Boards.h","position":14,"original_position":14,"commit_id":"e6876e7592a71c9e7a392a5e2e9e0d740bdf771c","original_commit_id":"e6876e7592a71c9e7a392a5e2e9e0d740bdf771c","user":{"login":"soundanalogous","id":401539,"avatar_url":"https://avatars.githubusercontent.com/u/401539?v=3","gravatar_id":"","url":"https://api.github.com/users/soundanalogous","html_url":"https://github.com/soundanalogous","followers_url":"https://api.github.com/users/soundanalogous/followers","following_url":"https://api.github.com/users/soundanalogous/following{/other_user}","gists_url":"https://api.github.com/users/soundanalogous/gists{/gist_id}","starred_url":"https://api.github.com/users/soundanalogous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundanalogous/subscriptions","organizations_url":"https://api.github.com/users/soundanalogous/orgs","repos_url":"https://api.github.com/users/soundanalogous/repos","events_url":"https://api.github.com/users/soundanalogous/events{/privacy}","received_events_url":"https://api.github.com/users/soundanalogous/received_events","type":"User","site_admin":false},"body":"Does the variant file actually define `PIN_SERIAL1_RX` and `PIN_SERIAL1_TX`? Also is SS mapped to A2?","created_at":"2016-01-05T06:20:30Z","updated_at":"2016-01-05T06:20:30Z","html_url":"https://github.com/firmata/arduino/pull/261#discussion_r48815469","pull_request_url":"https://api.github.com/repos/firmata/arduino/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/firmata/arduino/pulls/comments/48815469"},"html":{"href":"https://github.com/firmata/arduino/pull/261#discussion_r48815469"},"pull_request":{"href":"https://api.github.com/repos/firmata/arduino/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/firmata/arduino/pulls/261","id":55057736,"html_url":"https://github.com/firmata/arduino/pull/261","diff_url":"https://github.com/firmata/arduino/pull/261.diff","patch_url":"https://github.com/firmata/arduino/pull/261.patch","issue_url":"https://api.github.com/repos/firmata/arduino/issues/261","number":261,"state":"open","locked":false,"title":"Added MKR1000 entry to Boards.h","user":{"login":"turkycat","id":5198897,"avatar_url":"https://avatars.githubusercontent.com/u/5198897?v=3","gravatar_id":"","url":"https://api.github.com/users/turkycat","html_url":"https://github.com/turkycat","followers_url":"https://api.github.com/users/turkycat/followers","following_url":"https://api.github.com/users/turkycat/following{/other_user}","gists_url":"https://api.github.com/users/turkycat/gists{/gist_id}","starred_url":"https://api.github.com/users/turkycat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turkycat/subscriptions","organizations_url":"https://api.github.com/users/turkycat/orgs","repos_url":"https://api.github.com/users/turkycat/repos","events_url":"https://api.github.com/users/turkycat/events{/privacy}","received_events_url":"https://api.github.com/users/turkycat/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-05T06:08:07Z","updated_at":"2016-01-05T06:20:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"befcaf5cf7dc9e07350d24ee9a093d022fc858cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/firmata/arduino/pulls/261/commits","review_comments_url":"https://api.github.com/repos/firmata/arduino/pulls/261/comments","review_comment_url":"https://api.github.com/repos/firmata/arduino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firmata/arduino/issues/261/comments","statuses_url":"https://api.github.com/repos/firmata/arduino/statuses/e6876e7592a71c9e7a392a5e2e9e0d740bdf771c","head":{"label":"turkycat:mkr1000","ref":"mkr1000","sha":"e6876e7592a71c9e7a392a5e2e9e0d740bdf771c","user":{"login":"turkycat","id":5198897,"avatar_url":"https://avatars.githubusercontent.com/u/5198897?v=3","gravatar_id":"","url":"https://api.github.com/users/turkycat","html_url":"https://github.com/turkycat","followers_url":"https://api.github.com/users/turkycat/followers","following_url":"https://api.github.com/users/turkycat/following{/other_user}","gists_url":"https://api.github.com/users/turkycat/gists{/gist_id}","starred_url":"https://api.github.com/users/turkycat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turkycat/subscriptions","organizations_url":"https://api.github.com/users/turkycat/orgs","repos_url":"https://api.github.com/users/turkycat/repos","events_url":"https://api.github.com/users/turkycat/events{/privacy}","received_events_url":"https://api.github.com/users/turkycat/received_events","type":"User","site_admin":false},"repo":{"id":48013749,"name":"arduino","full_name":"turkycat/arduino","owner":{"login":"turkycat","id":5198897,"avatar_url":"https://avatars.githubusercontent.com/u/5198897?v=3","gravatar_id":"","url":"https://api.github.com/users/turkycat","html_url":"https://github.com/turkycat","followers_url":"https://api.github.com/users/turkycat/followers","following_url":"https://api.github.com/users/turkycat/following{/other_user}","gists_url":"https://api.github.com/users/turkycat/gists{/gist_id}","starred_url":"https://api.github.com/users/turkycat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turkycat/subscriptions","organizations_url":"https://api.github.com/users/turkycat/orgs","repos_url":"https://api.github.com/users/turkycat/repos","events_url":"https://api.github.com/users/turkycat/events{/privacy}","received_events_url":"https://api.github.com/users/turkycat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/turkycat/arduino","description":"Firmata firmware for Arduino","fork":true,"url":"https://api.github.com/repos/turkycat/arduino","forks_url":"https://api.github.com/repos/turkycat/arduino/forks","keys_url":"https://api.github.com/repos/turkycat/arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/turkycat/arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/turkycat/arduino/teams","hooks_url":"https://api.github.com/repos/turkycat/arduino/hooks","issue_events_url":"https://api.github.com/repos/turkycat/arduino/issues/events{/number}","events_url":"https://api.github.com/repos/turkycat/arduino/events","assignees_url":"https://api.github.com/repos/turkycat/arduino/assignees{/user}","branches_url":"https://api.github.com/repos/turkycat/arduino/branches{/branch}","tags_url":"https://api.github.com/repos/turkycat/arduino/tags","blobs_url":"https://api.github.com/repos/turkycat/arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/turkycat/arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/turkycat/arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/turkycat/arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/turkycat/arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/turkycat/arduino/languages","stargazers_url":"https://api.github.com/repos/turkycat/arduino/stargazers","contributors_url":"https://api.github.com/repos/turkycat/arduino/contributors","subscribers_url":"https://api.github.com/repos/turkycat/arduino/subscribers","subscription_url":"https://api.github.com/repos/turkycat/arduino/subscription","commits_url":"https://api.github.com/repos/turkycat/arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/turkycat/arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/turkycat/arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/turkycat/arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/turkycat/arduino/contents/{+path}","compare_url":"https://api.github.com/repos/turkycat/arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/turkycat/arduino/merges","archive_url":"https://api.github.com/repos/turkycat/arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/turkycat/arduino/downloads","issues_url":"https://api.github.com/repos/turkycat/arduino/issues{/number}","pulls_url":"https://api.github.com/repos/turkycat/arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/turkycat/arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/turkycat/arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/turkycat/arduino/labels{/name}","releases_url":"https://api.github.com/repos/turkycat/arduino/releases{/id}","created_at":"2015-12-15T02:10:38Z","updated_at":"2015-12-15T02:10:39Z","pushed_at":"2016-01-05T06:07:08Z","git_url":"git://github.com/turkycat/arduino.git","ssh_url":"git@github.com:turkycat/arduino.git","clone_url":"https://github.com/turkycat/arduino.git","svn_url":"https://github.com/turkycat/arduino","homepage":"","size":810,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firmata:master","ref":"master","sha":"4529ae1f210a6755dcf13ae32913598cb9c9fd90","user":{"login":"firmata","id":1351140,"avatar_url":"https://avatars.githubusercontent.com/u/1351140?v=3","gravatar_id":"","url":"https://api.github.com/users/firmata","html_url":"https://github.com/firmata","followers_url":"https://api.github.com/users/firmata/followers","following_url":"https://api.github.com/users/firmata/following{/other_user}","gists_url":"https://api.github.com/users/firmata/gists{/gist_id}","starred_url":"https://api.github.com/users/firmata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firmata/subscriptions","organizations_url":"https://api.github.com/users/firmata/orgs","repos_url":"https://api.github.com/users/firmata/repos","events_url":"https://api.github.com/users/firmata/events{/privacy}","received_events_url":"https://api.github.com/users/firmata/received_events","type":"Organization","site_admin":false},"repo":{"id":3214984,"name":"arduino","full_name":"firmata/arduino","owner":{"login":"firmata","id":1351140,"avatar_url":"https://avatars.githubusercontent.com/u/1351140?v=3","gravatar_id":"","url":"https://api.github.com/users/firmata","html_url":"https://github.com/firmata","followers_url":"https://api.github.com/users/firmata/followers","following_url":"https://api.github.com/users/firmata/following{/other_user}","gists_url":"https://api.github.com/users/firmata/gists{/gist_id}","starred_url":"https://api.github.com/users/firmata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firmata/subscriptions","organizations_url":"https://api.github.com/users/firmata/orgs","repos_url":"https://api.github.com/users/firmata/repos","events_url":"https://api.github.com/users/firmata/events{/privacy}","received_events_url":"https://api.github.com/users/firmata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firmata/arduino","description":"Firmata firmware for Arduino","fork":false,"url":"https://api.github.com/repos/firmata/arduino","forks_url":"https://api.github.com/repos/firmata/arduino/forks","keys_url":"https://api.github.com/repos/firmata/arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firmata/arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firmata/arduino/teams","hooks_url":"https://api.github.com/repos/firmata/arduino/hooks","issue_events_url":"https://api.github.com/repos/firmata/arduino/issues/events{/number}","events_url":"https://api.github.com/repos/firmata/arduino/events","assignees_url":"https://api.github.com/repos/firmata/arduino/assignees{/user}","branches_url":"https://api.github.com/repos/firmata/arduino/branches{/branch}","tags_url":"https://api.github.com/repos/firmata/arduino/tags","blobs_url":"https://api.github.com/repos/firmata/arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firmata/arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firmata/arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/firmata/arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firmata/arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/firmata/arduino/languages","stargazers_url":"https://api.github.com/repos/firmata/arduino/stargazers","contributors_url":"https://api.github.com/repos/firmata/arduino/contributors","subscribers_url":"https://api.github.com/repos/firmata/arduino/subscribers","subscription_url":"https://api.github.com/repos/firmata/arduino/subscription","commits_url":"https://api.github.com/repos/firmata/arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/firmata/arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/firmata/arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/firmata/arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/firmata/arduino/contents/{+path}","compare_url":"https://api.github.com/repos/firmata/arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firmata/arduino/merges","archive_url":"https://api.github.com/repos/firmata/arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firmata/arduino/downloads","issues_url":"https://api.github.com/repos/firmata/arduino/issues{/number}","pulls_url":"https://api.github.com/repos/firmata/arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/firmata/arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/firmata/arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firmata/arduino/labels{/name}","releases_url":"https://api.github.com/repos/firmata/arduino/releases{/id}","created_at":"2012-01-19T04:01:55Z","updated_at":"2016-01-04T21:50:17Z","pushed_at":"2016-01-05T06:08:07Z","git_url":"git://github.com/firmata/arduino.git","ssh_url":"git@github.com:firmata/arduino.git","clone_url":"https://github.com/firmata/arduino.git","svn_url":"https://github.com/firmata/arduino","homepage":"","size":1438,"stargazers_count":366,"watchers_count":366,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":42,"forks":145,"open_issues":42,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firmata/arduino/pulls/261"},"html":{"href":"https://github.com/firmata/arduino/pull/261"},"issue":{"href":"https://api.github.com/repos/firmata/arduino/issues/261"},"comments":{"href":"https://api.github.com/repos/firmata/arduino/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/firmata/arduino/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/firmata/arduino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firmata/arduino/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/firmata/arduino/statuses/e6876e7592a71c9e7a392a5e2e9e0d740bdf771c"}}}}