{"action":"opened","number":2915,"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/2915","id":97451632,"html_url":"https://github.com/serverless/serverless/pull/2915","diff_url":"https://github.com/serverless/serverless/pull/2915.diff","patch_url":"https://github.com/serverless/serverless/pull/2915.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/2915","number":2915,"state":"open","locked":false,"title":"fix aws metrics plugin lint issues","user":{"login":"laardee","id":4726921,"avatar_url":"https://avatars.githubusercontent.com/u/4726921?v=3","gravatar_id":"","url":"https://api.github.com/users/laardee","html_url":"https://github.com/laardee","followers_url":"https://api.github.com/users/laardee/followers","following_url":"https://api.github.com/users/laardee/following{/other_user}","gists_url":"https://api.github.com/users/laardee/gists{/gist_id}","starred_url":"https://api.github.com/users/laardee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laardee/subscriptions","organizations_url":"https://api.github.com/users/laardee/orgs","repos_url":"https://api.github.com/users/laardee/repos","events_url":"https://api.github.com/users/laardee/events{/privacy}","received_events_url":"https://api.github.com/users/laardee/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\n\r\nThis PR will fix aws metrics plugin lint issue.\r\n\r\nCloses #12345\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\nI refactored the code just a little bit so that the intends matches lint rules.\r\n\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\n\r\nExecute `npm run lint` and no errors should exists.\r\n\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nExamples:\r\n* serverless.yml - Fully functioning to easily deploy changes\r\n* Screenshots - Showing the difference between your output and the master\r\n* AWS CLI commands - To list AWS resources and show that the correct config is in place\r\n* Other - Anything else that comes to mind to help us evaluate\r\n-->\r\n\r\n\r\n## Todos:\r\n\r\n- [ ] Write tests\r\n- [ ] Write documentation\r\n- [ ] Fix linting errors\r\n- [ ] Make sure code coverage hasn't dropped\r\n- [ ] Provide verification config/commands/resources\r\n- [ ] Enable [\"Allow edits from maintainers\"](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for this PR\r\n- [ ] Change ready for review message below\r\n\r\n\r\n***Is this ready for review?:*** YES\r\n\r\n","created_at":"2016-12-11T07:57:07Z","updated_at":"2016-12-11T07:57:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c69e70377d627b9f25cbfbfd2cd70600a81f560","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/2915/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/2915/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/2915/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/0ff67612b537dccda99c33d9d6378b6486ce4577","head":{"label":"laardee:fix-aws-metrics-plugin-lint","ref":"fix-aws-metrics-plugin-lint","sha":"0ff67612b537dccda99c33d9d6378b6486ce4577","user":{"login":"laardee","id":4726921,"avatar_url":"https://avatars.githubusercontent.com/u/4726921?v=3","gravatar_id":"","url":"https://api.github.com/users/laardee","html_url":"https://github.com/laardee","followers_url":"https://api.github.com/users/laardee/followers","following_url":"https://api.github.com/users/laardee/following{/other_user}","gists_url":"https://api.github.com/users/laardee/gists{/gist_id}","starred_url":"https://api.github.com/users/laardee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laardee/subscriptions","organizations_url":"https://api.github.com/users/laardee/orgs","repos_url":"https://api.github.com/users/laardee/repos","events_url":"https://api.github.com/users/laardee/events{/privacy}","received_events_url":"https://api.github.com/users/laardee/received_events","type":"User","site_admin":false},"repo":{"id":66736393,"name":"serverless","full_name":"laardee/serverless","owner":{"login":"laardee","id":4726921,"avatar_url":"https://avatars.githubusercontent.com/u/4726921?v=3","gravatar_id":"","url":"https://api.github.com/users/laardee","html_url":"https://github.com/laardee","followers_url":"https://api.github.com/users/laardee/followers","following_url":"https://api.github.com/users/laardee/following{/other_user}","gists_url":"https://api.github.com/users/laardee/gists{/gist_id}","starred_url":"https://api.github.com/users/laardee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laardee/subscriptions","organizations_url":"https://api.github.com/users/laardee/orgs","repos_url":"https://api.github.com/users/laardee/repos","events_url":"https://api.github.com/users/laardee/events{/privacy}","received_events_url":"https://api.github.com/users/laardee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laardee/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":true,"url":"https://api.github.com/repos/laardee/serverless","forks_url":"https://api.github.com/repos/laardee/serverless/forks","keys_url":"https://api.github.com/repos/laardee/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laardee/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laardee/serverless/teams","hooks_url":"https://api.github.com/repos/laardee/serverless/hooks","issue_events_url":"https://api.github.com/repos/laardee/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/laardee/serverless/events","assignees_url":"https://api.github.com/repos/laardee/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/laardee/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/laardee/serverless/tags","blobs_url":"https://api.github.com/repos/laardee/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laardee/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laardee/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/laardee/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laardee/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/laardee/serverless/languages","stargazers_url":"https://api.github.com/repos/laardee/serverless/stargazers","contributors_url":"https://api.github.com/repos/laardee/serverless/contributors","subscribers_url":"https://api.github.com/repos/laardee/serverless/subscribers","subscription_url":"https://api.github.com/repos/laardee/serverless/subscription","commits_url":"https://api.github.com/repos/laardee/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/laardee/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/laardee/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/laardee/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/laardee/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/laardee/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laardee/serverless/merges","archive_url":"https://api.github.com/repos/laardee/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laardee/serverless/downloads","issues_url":"https://api.github.com/repos/laardee/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/laardee/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/laardee/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/laardee/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laardee/serverless/labels{/name}","releases_url":"https://api.github.com/repos/laardee/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/laardee/serverless/deployments","created_at":"2016-08-27T21:31:19Z","updated_at":"2016-08-27T21:31:21Z","pushed_at":"2016-12-11T07:52:25Z","git_url":"git://github.com/laardee/serverless.git","ssh_url":"git@github.com:laardee/serverless.git","clone_url":"https://github.com/laardee/serverless.git","svn_url":"https://github.com/laardee/serverless","homepage":"http://www.serverless.com","size":72884,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"ee19ce660915728c6b265ae704fd079c19bd1ef3","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2016-12-11T05:31:47Z","pushed_at":"2016-12-11T07:57:07Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":91822,"stargazers_count":13263,"watchers_count":13263,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1093,"mirror_url":null,"open_issues_count":195,"forks":1093,"open_issues":195,"watchers":13263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2915"},"html":{"href":"https://github.com/serverless/serverless/pull/2915"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/2915"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/2915/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2915/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2915/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/0ff67612b537dccda99c33d9d6378b6486ce4577"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":96,"deletions":88,"changed_files":1}}
{"actor":{"display_login":"laardee"}}