{"action":"created","issue":{"url":"https://api.github.com/repos/ufz/ogs/issues/1359","repository_url":"https://api.github.com/repos/ufz/ogs","labels_url":"https://api.github.com/repos/ufz/ogs/issues/1359/labels{/name}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1359/comments","events_url":"https://api.github.com/repos/ufz/ogs/issues/1359/events","html_url":"https://github.com/ufz/ogs/pull/1359","id":171739950,"number":1359,"title":"Mechanics invariants and B-matrices","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ufz/ogs/labels/WIP","name":"WIP","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-08-17T19:27:39Z","updated_at":"2016-08-19T16:19:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1359","html_url":"https://github.com/ufz/ogs/pull/1359","diff_url":"https://github.com/ufz/ogs/pull/1359.diff","patch_url":"https://github.com/ufz/ogs/pull/1359.patch"},"body":"This is part of the mechanics PR #1340.\r\n\r\nIncludes:\r\n - deformation process specific invariants in the Kelvin mapping.\r\n - B-matrices (like shape-matrices for mechanics) and Kelvin vector types.\r\n\r\nFor the tests the error bounds were eyeballed from a gnuplot graphics showing the error vs. input vector norm. Tried to make them as tight as possible. It might happen that they will need to be increased a little bit... we'll see.\r\n\r\nAside from the failing compiler (of the test code) this is ready for review.\r\n\r\nTodo: \r\n - [ ] fix MSVC12 compilation.\r\n - [x] Maybe rename BMatrixPolicy::_columns to \"number of DOF\"? (And _rows to _kelvin_vector_size?)\r\n - [x] Merge/Unify ShapeMatrixPolicy and the BMatrixPolicy\r\n  -  Now you use the ::detail::EigenMatrixType, why not the respective type from ShapeMatricesType?\r\n  -  Wouldn't it be better to use the typedefs from ShapeMatrixPolicy here instead of always using fixed size matrices?\r\n  - DynamicBMatrixPolicy Can be merged with the above into one type using only the typedefs from ShapeMatrixPolicyType.\r\n - [ ] rename files/classes. Will do at the very end to reduce rereview:\r\n  - MathLib/mechanics_invariants.h > MathLib/KelvinVectorLinAlg.h\r\n  - Split off impl.h or even .cpp for specializations of det/inv.\r\n - [ ] Possibly add test of LinearBMatrix using computeStrain function.\r\n - [ ] Test P_dev * P_sph == P_sph * P_dev == 0; P_dev + P_sph == identity; identity == A * inv(A); A * identity == A"},"comment":{"url":"https://api.github.com/repos/ufz/ogs/issues/comments/241063659","html_url":"https://github.com/ufz/ogs/pull/1359#issuecomment-241063659","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1359","id":241063659,"user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T16:19:17Z","updated_at":"2016-08-19T16:19:17Z","body":"Not sure if the more general names e.g.: \r\n\r\nResidualVectorType instead of NodalForceVectorType\r\nLocalVectorType instead of StressVectorType\r\nGlobalSystemMatrixType  instead of StiffnessMatrixType\r\nLocalSystemMatrixType instead of ModulusMatrixType\r\n\r\nwould be more clear."}}
{"actor":{"display_login":"endJunction"}}