{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments/85827940","pull_request_review_id":6520721,"id":85827940,"diff_hunk":"@@ -155,14 +180,21 @@ class SetupLiveUser(object):\n \n         if EOS_INSTALLER not in icon_tree['desktop']:\n             icon_tree['desktop'].insert(0, EOS_INSTALLER)\n-            self.update(ICON_GRID_LAYOUT, GLib.Variant('a{sas}', icon_tree))\n+            updates = self.updates[SHELL_SCHEMA]\n+            updates.set(ICON_GRID_LAYOUT,\n+                        GLib.Variant('a{sas}', icon_tree))","path":"gnome-initial-setup/pages/live-chooser/eos-setup-live-user","position":91,"original_position":91,"commit_id":"d24eed32bbfadb1d39194240d98c0dc79c068ea4","original_commit_id":"d24eed32bbfadb1d39194240d98c0dc79c068ea4","user":{"login":"cosimoc","id":13906,"avatar_url":"https://avatars.githubusercontent.com/u/13906?v=3","gravatar_id":"","url":"https://api.github.com/users/cosimoc","html_url":"https://github.com/cosimoc","followers_url":"https://api.github.com/users/cosimoc/followers","following_url":"https://api.github.com/users/cosimoc/following{/other_user}","gists_url":"https://api.github.com/users/cosimoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cosimoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosimoc/subscriptions","organizations_url":"https://api.github.com/users/cosimoc/orgs","repos_url":"https://api.github.com/users/cosimoc/repos","events_url":"https://api.github.com/users/cosimoc/events{/privacy}","received_events_url":"https://api.github.com/users/cosimoc/received_events","type":"User","site_admin":false},"body":"Nitpick: prefer `self.update(SHELL_SCHEMA, ICON_GRID_LAYOUT, ...)`","created_at":"2016-10-31T20:40:27Z","updated_at":"2016-10-31T20:40:27Z","html_url":"https://github.com/endlessm/gnome-initial-setup/pull/137#discussion_r85827940","pull_request_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments/85827940"},"html":{"href":"https://github.com/endlessm/gnome-initial-setup/pull/137#discussion_r85827940"},"pull_request":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137","id":91675870,"html_url":"https://github.com/endlessm/gnome-initial-setup/pull/137","diff_url":"https://github.com/endlessm/gnome-initial-setup/pull/137.diff","patch_url":"https://github.com/endlessm/gnome-initial-setup/pull/137.patch","issue_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/137","number":137,"state":"open","locked":false,"title":"eos-setup-live-user: Disallow updates on GNOME Software","user":{"login":"joaquimrocha","id":1029635,"avatar_url":"https://avatars.githubusercontent.com/u/1029635?v=3","gravatar_id":"","url":"https://api.github.com/users/joaquimrocha","html_url":"https://github.com/joaquimrocha","followers_url":"https://api.github.com/users/joaquimrocha/followers","following_url":"https://api.github.com/users/joaquimrocha/following{/other_user}","gists_url":"https://api.github.com/users/joaquimrocha/gists{/gist_id}","starred_url":"https://api.github.com/users/joaquimrocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaquimrocha/subscriptions","organizations_url":"https://api.github.com/users/joaquimrocha/orgs","repos_url":"https://api.github.com/users/joaquimrocha/repos","events_url":"https://api.github.com/users/joaquimrocha/events{/privacy}","received_events_url":"https://api.github.com/users/joaquimrocha/received_events","type":"User","site_admin":false},"body":"For allowing to update the settings of a component that is not the\r\nshell these changes also reimplement how the gsettings overrides\r\nare implemented inside eos-setup-live-user. It should now be easy to\r\nadd any new modules that need their gsettings overridden.\r\n\r\nhttps://phabricator.endlessm.com/T13950","created_at":"2016-10-31T19:39:24Z","updated_at":"2016-10-31T20:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5122fff443b4f22f20488c8822874d0be6f81a83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137/commits","review_comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137/comments","review_comment_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/137/comments","statuses_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/d24eed32bbfadb1d39194240d98c0dc79c068ea4","head":{"label":"endlessm:T13950","ref":"T13950","sha":"d24eed32bbfadb1d39194240d98c0dc79c068ea4","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17677386,"name":"gnome-initial-setup","full_name":"endlessm/gnome-initial-setup","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/gnome-initial-setup","description":"Fork of gnome-initial-setup with endless customizations and translations","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-initial-setup","forks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/deployments","created_at":"2014-03-12T18:10:28Z","updated_at":"2016-07-26T09:03:56Z","pushed_at":"2016-10-31T19:39:24Z","git_url":"git://github.com/endlessm/gnome-initial-setup.git","ssh_url":"git@github.com:endlessm/gnome-initial-setup.git","clone_url":"https://github.com/endlessm/gnome-initial-setup.git","svn_url":"https://github.com/endlessm/gnome-initial-setup","homepage":null,"size":6190,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"6b9246fe453bc5004a731214cfc19cb53674879d","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17677386,"name":"gnome-initial-setup","full_name":"endlessm/gnome-initial-setup","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/gnome-initial-setup","description":"Fork of gnome-initial-setup with endless customizations and translations","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-initial-setup","forks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/deployments","created_at":"2014-03-12T18:10:28Z","updated_at":"2016-07-26T09:03:56Z","pushed_at":"2016-10-31T19:39:24Z","git_url":"git://github.com/endlessm/gnome-initial-setup.git","ssh_url":"git@github.com:endlessm/gnome-initial-setup.git","clone_url":"https://github.com/endlessm/gnome-initial-setup.git","svn_url":"https://github.com/endlessm/gnome-initial-setup","homepage":null,"size":6190,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137"},"html":{"href":"https://github.com/endlessm/gnome-initial-setup/pull/137"},"issue":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/137"},"comments":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/d24eed32bbfadb1d39194240d98c0dc79c068ea4"}}}}
{"actor":{"display_login":"cosimoc"}}