{"action":"created","comment":{"url":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/comments/84390241","pull_request_review_id":5172394,"id":84390241,"diff_hunk":"@@ -175,5 +205,41 @@ protected override int QueryStatusCommand(uint itemid, ref Guid pguidCmdGroup, u\n \n             return base.QueryStatusCommand(itemid, ref pguidCmdGroup, cCmds, prgCmds, pCmdText);\n         }\n+\n+        #region IVsProjectSpecialFiles Members\n+\n+        int IVsProjectSpecialFiles.GetFile(int fileID, uint grfFlags, out uint pitemid, out string pbstrFilename)\n+        {\n+            pitemid = (uint)VSConstants.VSITEMID.Nil;\n+            pbstrFilename = string.Empty;\n+            if ((__PSFFILEID5)fileID == __PSFFILEID5.PSFFILEID_AppxManifest)\n+            {\n+                // It's okay for pbstrFilename to be empty since it will be set correctly by VS packaging code\n+                return VSConstants.S_OK;\n+            }\n+            return VSConstants.E_NOTIMPL; // Same as what base returns","path":"Product/ProjectFlavor/NodejsUwpProjectFlavor.cs","position":113,"original_position":113,"commit_id":"cc7aa2e0cf0479573e32394847d39d743a43348d","original_commit_id":"eba612909109942fe4bc5e5377d23a84ba139d8a","user":{"login":"munyirik","id":8389594,"avatar_url":"https://avatars.githubusercontent.com/u/8389594?v=3","gravatar_id":"","url":"https://api.github.com/users/munyirik","html_url":"https://github.com/munyirik","followers_url":"https://api.github.com/users/munyirik/followers","following_url":"https://api.github.com/users/munyirik/following{/other_user}","gists_url":"https://api.github.com/users/munyirik/gists{/gist_id}","starred_url":"https://api.github.com/users/munyirik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munyirik/subscriptions","organizations_url":"https://api.github.com/users/munyirik/orgs","repos_url":"https://api.github.com/users/munyirik/repos","events_url":"https://api.github.com/users/munyirik/events{/privacy}","received_events_url":"https://api.github.com/users/munyirik/received_events","type":"User","site_admin":false},"body":"so base here I mean [ProjectNode](https://github.com/Microsoft/nodejstools/blob/master/Common/Product/SharedProject/ProjectNode.cs#L4872) (maybe 'base' is not the best description here). I want to avoid adding code to get the ProjectNode instance and make the call to return the same thing.","created_at":"2016-10-20T22:39:21Z","updated_at":"2016-10-20T22:39:21Z","html_url":"https://github.com/ms-iot/ntvsiot/pull/116#discussion_r84390241","pull_request_url":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/comments/84390241"},"html":{"href":"https://github.com/ms-iot/ntvsiot/pull/116#discussion_r84390241"},"pull_request":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116","id":90267726,"html_url":"https://github.com/ms-iot/ntvsiot/pull/116","diff_url":"https://github.com/ms-iot/ntvsiot/pull/116.diff","patch_url":"https://github.com/ms-iot/ntvsiot/pull/116.patch","issue_url":"https://api.github.com/repos/ms-iot/ntvsiot/issues/116","number":116,"state":"open","locked":false,"title":"Version 1.5.6 update","user":{"login":"munyirik","id":8389594,"avatar_url":"https://avatars.githubusercontent.com/u/8389594?v=3","gravatar_id":"","url":"https://api.github.com/users/munyirik","html_url":"https://github.com/munyirik","followers_url":"https://api.github.com/users/munyirik/followers","following_url":"https://api.github.com/users/munyirik/following{/other_user}","gists_url":"https://api.github.com/users/munyirik/gists{/gist_id}","starred_url":"https://api.github.com/users/munyirik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munyirik/subscriptions","organizations_url":"https://api.github.com/users/munyirik/orgs","repos_url":"https://api.github.com/users/munyirik/repos","events_url":"https://api.github.com/users/munyirik/events{/privacy}","received_events_url":"https://api.github.com/users/munyirik/received_events","type":"User","site_admin":false},"body":"Last PR before 1.5.6 release. It includes:\r\n* Addition of reference tests and fixing existing tests\r\n* Enabling manifest designer and store app menu (the latter is still not fully functional).\r\n* Removing WinJS imports from templates which imported unnecessary properties.\r\n* Fixes some bugs with build and deployment.","created_at":"2016-10-20T19:43:27Z","updated_at":"2016-10-20T22:39:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d56277c3826d2df13de3107eaa1831ed85354b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116/commits","review_comments_url":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116/comments","review_comment_url":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ms-iot/ntvsiot/issues/116/comments","statuses_url":"https://api.github.com/repos/ms-iot/ntvsiot/statuses/cc7aa2e0cf0479573e32394847d39d743a43348d","head":{"label":"munyirik:master","ref":"master","sha":"cc7aa2e0cf0479573e32394847d39d743a43348d","user":{"login":"munyirik","id":8389594,"avatar_url":"https://avatars.githubusercontent.com/u/8389594?v=3","gravatar_id":"","url":"https://api.github.com/users/munyirik","html_url":"https://github.com/munyirik","followers_url":"https://api.github.com/users/munyirik/followers","following_url":"https://api.github.com/users/munyirik/following{/other_user}","gists_url":"https://api.github.com/users/munyirik/gists{/gist_id}","starred_url":"https://api.github.com/users/munyirik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munyirik/subscriptions","organizations_url":"https://api.github.com/users/munyirik/orgs","repos_url":"https://api.github.com/users/munyirik/repos","events_url":"https://api.github.com/users/munyirik/events{/privacy}","received_events_url":"https://api.github.com/users/munyirik/received_events","type":"User","site_admin":false},"repo":{"id":43910253,"name":"ntvsiot","full_name":"munyirik/ntvsiot","owner":{"login":"munyirik","id":8389594,"avatar_url":"https://avatars.githubusercontent.com/u/8389594?v=3","gravatar_id":"","url":"https://api.github.com/users/munyirik","html_url":"https://github.com/munyirik","followers_url":"https://api.github.com/users/munyirik/followers","following_url":"https://api.github.com/users/munyirik/following{/other_user}","gists_url":"https://api.github.com/users/munyirik/gists{/gist_id}","starred_url":"https://api.github.com/users/munyirik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munyirik/subscriptions","organizations_url":"https://api.github.com/users/munyirik/orgs","repos_url":"https://api.github.com/users/munyirik/repos","events_url":"https://api.github.com/users/munyirik/events{/privacy}","received_events_url":"https://api.github.com/users/munyirik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/munyirik/ntvsiot","description":null,"fork":true,"url":"https://api.github.com/repos/munyirik/ntvsiot","forks_url":"https://api.github.com/repos/munyirik/ntvsiot/forks","keys_url":"https://api.github.com/repos/munyirik/ntvsiot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/munyirik/ntvsiot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/munyirik/ntvsiot/teams","hooks_url":"https://api.github.com/repos/munyirik/ntvsiot/hooks","issue_events_url":"https://api.github.com/repos/munyirik/ntvsiot/issues/events{/number}","events_url":"https://api.github.com/repos/munyirik/ntvsiot/events","assignees_url":"https://api.github.com/repos/munyirik/ntvsiot/assignees{/user}","branches_url":"https://api.github.com/repos/munyirik/ntvsiot/branches{/branch}","tags_url":"https://api.github.com/repos/munyirik/ntvsiot/tags","blobs_url":"https://api.github.com/repos/munyirik/ntvsiot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/munyirik/ntvsiot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/munyirik/ntvsiot/git/refs{/sha}","trees_url":"https://api.github.com/repos/munyirik/ntvsiot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/munyirik/ntvsiot/statuses/{sha}","languages_url":"https://api.github.com/repos/munyirik/ntvsiot/languages","stargazers_url":"https://api.github.com/repos/munyirik/ntvsiot/stargazers","contributors_url":"https://api.github.com/repos/munyirik/ntvsiot/contributors","subscribers_url":"https://api.github.com/repos/munyirik/ntvsiot/subscribers","subscription_url":"https://api.github.com/repos/munyirik/ntvsiot/subscription","commits_url":"https://api.github.com/repos/munyirik/ntvsiot/commits{/sha}","git_commits_url":"https://api.github.com/repos/munyirik/ntvsiot/git/commits{/sha}","comments_url":"https://api.github.com/repos/munyirik/ntvsiot/comments{/number}","issue_comment_url":"https://api.github.com/repos/munyirik/ntvsiot/issues/comments{/number}","contents_url":"https://api.github.com/repos/munyirik/ntvsiot/contents/{+path}","compare_url":"https://api.github.com/repos/munyirik/ntvsiot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/munyirik/ntvsiot/merges","archive_url":"https://api.github.com/repos/munyirik/ntvsiot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/munyirik/ntvsiot/downloads","issues_url":"https://api.github.com/repos/munyirik/ntvsiot/issues{/number}","pulls_url":"https://api.github.com/repos/munyirik/ntvsiot/pulls{/number}","milestones_url":"https://api.github.com/repos/munyirik/ntvsiot/milestones{/number}","notifications_url":"https://api.github.com/repos/munyirik/ntvsiot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/munyirik/ntvsiot/labels{/name}","releases_url":"https://api.github.com/repos/munyirik/ntvsiot/releases{/id}","deployments_url":"https://api.github.com/repos/munyirik/ntvsiot/deployments","created_at":"2015-10-08T19:01:21Z","updated_at":"2016-01-11T20:29:38Z","pushed_at":"2016-10-20T20:18:10Z","git_url":"git://github.com/munyirik/ntvsiot.git","ssh_url":"git@github.com:munyirik/ntvsiot.git","clone_url":"https://github.com/munyirik/ntvsiot.git","svn_url":"https://github.com/munyirik/ntvsiot","homepage":null,"size":41975,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ms-iot:master","ref":"master","sha":"b922f8ea14c5e071c121600ef9510b659a016790","user":{"login":"ms-iot","id":7927770,"avatar_url":"https://avatars.githubusercontent.com/u/7927770?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-iot","html_url":"https://github.com/ms-iot","followers_url":"https://api.github.com/users/ms-iot/followers","following_url":"https://api.github.com/users/ms-iot/following{/other_user}","gists_url":"https://api.github.com/users/ms-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-iot/subscriptions","organizations_url":"https://api.github.com/users/ms-iot/orgs","repos_url":"https://api.github.com/users/ms-iot/repos","events_url":"https://api.github.com/users/ms-iot/events{/privacy}","received_events_url":"https://api.github.com/users/ms-iot/received_events","type":"Organization","site_admin":false},"repo":{"id":34470458,"name":"ntvsiot","full_name":"ms-iot/ntvsiot","owner":{"login":"ms-iot","id":7927770,"avatar_url":"https://avatars.githubusercontent.com/u/7927770?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-iot","html_url":"https://github.com/ms-iot","followers_url":"https://api.github.com/users/ms-iot/followers","following_url":"https://api.github.com/users/ms-iot/following{/other_user}","gists_url":"https://api.github.com/users/ms-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-iot/subscriptions","organizations_url":"https://api.github.com/users/ms-iot/orgs","repos_url":"https://api.github.com/users/ms-iot/repos","events_url":"https://api.github.com/users/ms-iot/events{/privacy}","received_events_url":"https://api.github.com/users/ms-iot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ms-iot/ntvsiot","description":null,"fork":false,"url":"https://api.github.com/repos/ms-iot/ntvsiot","forks_url":"https://api.github.com/repos/ms-iot/ntvsiot/forks","keys_url":"https://api.github.com/repos/ms-iot/ntvsiot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ms-iot/ntvsiot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ms-iot/ntvsiot/teams","hooks_url":"https://api.github.com/repos/ms-iot/ntvsiot/hooks","issue_events_url":"https://api.github.com/repos/ms-iot/ntvsiot/issues/events{/number}","events_url":"https://api.github.com/repos/ms-iot/ntvsiot/events","assignees_url":"https://api.github.com/repos/ms-iot/ntvsiot/assignees{/user}","branches_url":"https://api.github.com/repos/ms-iot/ntvsiot/branches{/branch}","tags_url":"https://api.github.com/repos/ms-iot/ntvsiot/tags","blobs_url":"https://api.github.com/repos/ms-iot/ntvsiot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ms-iot/ntvsiot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ms-iot/ntvsiot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ms-iot/ntvsiot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ms-iot/ntvsiot/statuses/{sha}","languages_url":"https://api.github.com/repos/ms-iot/ntvsiot/languages","stargazers_url":"https://api.github.com/repos/ms-iot/ntvsiot/stargazers","contributors_url":"https://api.github.com/repos/ms-iot/ntvsiot/contributors","subscribers_url":"https://api.github.com/repos/ms-iot/ntvsiot/subscribers","subscription_url":"https://api.github.com/repos/ms-iot/ntvsiot/subscription","commits_url":"https://api.github.com/repos/ms-iot/ntvsiot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ms-iot/ntvsiot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ms-iot/ntvsiot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ms-iot/ntvsiot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ms-iot/ntvsiot/contents/{+path}","compare_url":"https://api.github.com/repos/ms-iot/ntvsiot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ms-iot/ntvsiot/merges","archive_url":"https://api.github.com/repos/ms-iot/ntvsiot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ms-iot/ntvsiot/downloads","issues_url":"https://api.github.com/repos/ms-iot/ntvsiot/issues{/number}","pulls_url":"https://api.github.com/repos/ms-iot/ntvsiot/pulls{/number}","milestones_url":"https://api.github.com/repos/ms-iot/ntvsiot/milestones{/number}","notifications_url":"https://api.github.com/repos/ms-iot/ntvsiot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ms-iot/ntvsiot/labels{/name}","releases_url":"https://api.github.com/repos/ms-iot/ntvsiot/releases{/id}","deployments_url":"https://api.github.com/repos/ms-iot/ntvsiot/deployments","created_at":"2015-04-23T17:15:11Z","updated_at":"2016-10-19T20:39:30Z","pushed_at":"2016-10-20T20:17:14Z","git_url":"git://github.com/ms-iot/ntvsiot.git","ssh_url":"git@github.com:ms-iot/ntvsiot.git","clone_url":"https://github.com/ms-iot/ntvsiot.git","svn_url":"https://github.com/ms-iot/ntvsiot","homepage":null,"size":41959,"stargazers_count":86,"watchers_count":86,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":6,"forks":19,"open_issues":6,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116"},"html":{"href":"https://github.com/ms-iot/ntvsiot/pull/116"},"issue":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/issues/116"},"comments":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/ms-iot/ntvsiot/statuses/cc7aa2e0cf0479573e32394847d39d743a43348d"}}}}
{"actor":{"display_login":"munyirik"}}