{"action":"closed","number":325,"pull_request":{"url":"https://api.github.com/repos/metaeducation/ren-c/pulls/325","id":91890482,"html_url":"https://github.com/metaeducation/ren-c/pull/325","diff_url":"https://github.com/metaeducation/ren-c/pull/325.diff","patch_url":"https://github.com/metaeducation/ren-c/pull/325.patch","issue_url":"https://api.github.com/repos/metaeducation/ren-c/issues/325","number":325,"state":"closed","locked":false,"title":"Eliminate bad cast usage in HTTPS (breaking read on matrix.org)","user":{"login":"hostilefork","id":20440,"avatar_url":"https://avatars.githubusercontent.com/u/20440?v=3","gravatar_id":"","url":"https://api.github.com/users/hostilefork","html_url":"https://github.com/hostilefork","followers_url":"https://api.github.com/users/hostilefork/followers","following_url":"https://api.github.com/users/hostilefork/following{/other_user}","gists_url":"https://api.github.com/users/hostilefork/gists{/gist_id}","starred_url":"https://api.github.com/users/hostilefork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hostilefork/subscriptions","organizations_url":"https://api.github.com/users/hostilefork/orgs","repos_url":"https://api.github.com/users/hostilefork/repos","events_url":"https://api.github.com/users/hostilefork/events{/privacy}","received_events_url":"https://api.github.com/users/hostilefork/received_events","type":"User","site_admin":false},"body":"The internal structure of a REBSER node was changed inside the core.\r\nAn invisible dependency on the layout existed in %host-core.c, which\r\nwas exposed when certain encryption methods were used:\r\n\r\nhttps://github.com/zsx/r3/blob/e95a54cb5eb7a5fc38054547879e15eddfb27bbb/src/os/host-core.c#L531\r\n\r\n    //hack! - will set the tail to key size\r\n    *((REBCNT*)(((void**)priv_key.series)+1)) = dh_ctx.len;\r\n\r\nThis was attempting to set the length of the series, by assuming that\r\nthe series length could be found one 32-bit-pointer's width inside\r\nthe data structure.  This would not have ever been true on 64-bit\r\nsystems, and is obviously a very sketchy thing to be doing...if the\r\ninternals of the data structure ever changed.\r\n\r\nThis replaces the corresponding calls with the now-exported API for\r\nRL_SET_SERIES_LEN (although the \"RL\" API is being retooled to speak\r\nin terms of lifetime-managed REBVALs only, and not raw series.)  It\r\nalso fixes some memory leaks.\r\n\r\n(Note: %host-core.c is an antiquated and scary piece of code, which is\r\nslated for complete replacement.)","created_at":"2016-11-02T00:33:04Z","updated_at":"2016-11-02T00:47:38Z","closed_at":"2016-11-02T00:47:38Z","merged_at":"2016-11-02T00:47:38Z","merge_commit_sha":"e09ae08d9d50a2a726bc65caa312d3dc3491b2c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/metaeducation/ren-c/pulls/325/commits","review_comments_url":"https://api.github.com/repos/metaeducation/ren-c/pulls/325/comments","review_comment_url":"https://api.github.com/repos/metaeducation/ren-c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metaeducation/ren-c/issues/325/comments","statuses_url":"https://api.github.com/repos/metaeducation/ren-c/statuses/e09ae08d9d50a2a726bc65caa312d3dc3491b2c3","head":{"label":"hostilefork:fix-https-cast","ref":"fix-https-cast","sha":"e09ae08d9d50a2a726bc65caa312d3dc3491b2c3","user":{"login":"hostilefork","id":20440,"avatar_url":"https://avatars.githubusercontent.com/u/20440?v=3","gravatar_id":"","url":"https://api.github.com/users/hostilefork","html_url":"https://github.com/hostilefork","followers_url":"https://api.github.com/users/hostilefork/followers","following_url":"https://api.github.com/users/hostilefork/following{/other_user}","gists_url":"https://api.github.com/users/hostilefork/gists{/gist_id}","starred_url":"https://api.github.com/users/hostilefork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hostilefork/subscriptions","organizations_url":"https://api.github.com/users/hostilefork/orgs","repos_url":"https://api.github.com/users/hostilefork/repos","events_url":"https://api.github.com/users/hostilefork/events{/privacy}","received_events_url":"https://api.github.com/users/hostilefork/received_events","type":"User","site_admin":false},"repo":{"id":7182655,"name":"rebol","full_name":"hostilefork/rebol","owner":{"login":"hostilefork","id":20440,"avatar_url":"https://avatars.githubusercontent.com/u/20440?v=3","gravatar_id":"","url":"https://api.github.com/users/hostilefork","html_url":"https://github.com/hostilefork","followers_url":"https://api.github.com/users/hostilefork/followers","following_url":"https://api.github.com/users/hostilefork/following{/other_user}","gists_url":"https://api.github.com/users/hostilefork/gists{/gist_id}","starred_url":"https://api.github.com/users/hostilefork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hostilefork/subscriptions","organizations_url":"https://api.github.com/users/hostilefork/orgs","repos_url":"https://api.github.com/users/hostilefork/repos","events_url":"https://api.github.com/users/hostilefork/events{/privacy}","received_events_url":"https://api.github.com/users/hostilefork/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hostilefork/rebol","description":"Source code for the Rebol interpreter","fork":true,"url":"https://api.github.com/repos/hostilefork/rebol","forks_url":"https://api.github.com/repos/hostilefork/rebol/forks","keys_url":"https://api.github.com/repos/hostilefork/rebol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hostilefork/rebol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hostilefork/rebol/teams","hooks_url":"https://api.github.com/repos/hostilefork/rebol/hooks","issue_events_url":"https://api.github.com/repos/hostilefork/rebol/issues/events{/number}","events_url":"https://api.github.com/repos/hostilefork/rebol/events","assignees_url":"https://api.github.com/repos/hostilefork/rebol/assignees{/user}","branches_url":"https://api.github.com/repos/hostilefork/rebol/branches{/branch}","tags_url":"https://api.github.com/repos/hostilefork/rebol/tags","blobs_url":"https://api.github.com/repos/hostilefork/rebol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hostilefork/rebol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hostilefork/rebol/git/refs{/sha}","trees_url":"https://api.github.com/repos/hostilefork/rebol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hostilefork/rebol/statuses/{sha}","languages_url":"https://api.github.com/repos/hostilefork/rebol/languages","stargazers_url":"https://api.github.com/repos/hostilefork/rebol/stargazers","contributors_url":"https://api.github.com/repos/hostilefork/rebol/contributors","subscribers_url":"https://api.github.com/repos/hostilefork/rebol/subscribers","subscription_url":"https://api.github.com/repos/hostilefork/rebol/subscription","commits_url":"https://api.github.com/repos/hostilefork/rebol/commits{/sha}","git_commits_url":"https://api.github.com/repos/hostilefork/rebol/git/commits{/sha}","comments_url":"https://api.github.com/repos/hostilefork/rebol/comments{/number}","issue_comment_url":"https://api.github.com/repos/hostilefork/rebol/issues/comments{/number}","contents_url":"https://api.github.com/repos/hostilefork/rebol/contents/{+path}","compare_url":"https://api.github.com/repos/hostilefork/rebol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hostilefork/rebol/merges","archive_url":"https://api.github.com/repos/hostilefork/rebol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hostilefork/rebol/downloads","issues_url":"https://api.github.com/repos/hostilefork/rebol/issues{/number}","pulls_url":"https://api.github.com/repos/hostilefork/rebol/pulls{/number}","milestones_url":"https://api.github.com/repos/hostilefork/rebol/milestones{/number}","notifications_url":"https://api.github.com/repos/hostilefork/rebol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hostilefork/rebol/labels{/name}","releases_url":"https://api.github.com/repos/hostilefork/rebol/releases{/id}","deployments_url":"https://api.github.com/repos/hostilefork/rebol/deployments","created_at":"2012-12-15T18:44:43Z","updated_at":"2016-05-26T01:04:22Z","pushed_at":"2016-11-02T00:32:44Z","git_url":"git://github.com/hostilefork/rebol.git","ssh_url":"git@github.com:hostilefork/rebol.git","clone_url":"https://github.com/hostilefork/rebol.git","svn_url":"https://github.com/hostilefork/rebol","homepage":"http://www.rebol.com/","size":51244,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"metaeducation:master","ref":"master","sha":"35e8e7d99606409189297fb21794f228bf8b5b2e","user":{"login":"metaeducation","id":8308455,"avatar_url":"https://avatars.githubusercontent.com/u/8308455?v=3","gravatar_id":"","url":"https://api.github.com/users/metaeducation","html_url":"https://github.com/metaeducation","followers_url":"https://api.github.com/users/metaeducation/followers","following_url":"https://api.github.com/users/metaeducation/following{/other_user}","gists_url":"https://api.github.com/users/metaeducation/gists{/gist_id}","starred_url":"https://api.github.com/users/metaeducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaeducation/subscriptions","organizations_url":"https://api.github.com/users/metaeducation/orgs","repos_url":"https://api.github.com/users/metaeducation/repos","events_url":"https://api.github.com/users/metaeducation/events{/privacy}","received_events_url":"https://api.github.com/users/metaeducation/received_events","type":"Organization","site_admin":false},"repo":{"id":35589720,"name":"ren-c","full_name":"metaeducation/ren-c","owner":{"login":"metaeducation","id":8308455,"avatar_url":"https://avatars.githubusercontent.com/u/8308455?v=3","gravatar_id":"","url":"https://api.github.com/users/metaeducation","html_url":"https://github.com/metaeducation","followers_url":"https://api.github.com/users/metaeducation/followers","following_url":"https://api.github.com/users/metaeducation/following{/other_user}","gists_url":"https://api.github.com/users/metaeducation/gists{/gist_id}","starred_url":"https://api.github.com/users/metaeducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaeducation/subscriptions","organizations_url":"https://api.github.com/users/metaeducation/orgs","repos_url":"https://api.github.com/users/metaeducation/repos","events_url":"https://api.github.com/users/metaeducation/events{/privacy}","received_events_url":"https://api.github.com/users/metaeducation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metaeducation/ren-c","description":"Library for embedding a Rebol interpreter into C codebases","fork":true,"url":"https://api.github.com/repos/metaeducation/ren-c","forks_url":"https://api.github.com/repos/metaeducation/ren-c/forks","keys_url":"https://api.github.com/repos/metaeducation/ren-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metaeducation/ren-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metaeducation/ren-c/teams","hooks_url":"https://api.github.com/repos/metaeducation/ren-c/hooks","issue_events_url":"https://api.github.com/repos/metaeducation/ren-c/issues/events{/number}","events_url":"https://api.github.com/repos/metaeducation/ren-c/events","assignees_url":"https://api.github.com/repos/metaeducation/ren-c/assignees{/user}","branches_url":"https://api.github.com/repos/metaeducation/ren-c/branches{/branch}","tags_url":"https://api.github.com/repos/metaeducation/ren-c/tags","blobs_url":"https://api.github.com/repos/metaeducation/ren-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metaeducation/ren-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metaeducation/ren-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/metaeducation/ren-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metaeducation/ren-c/statuses/{sha}","languages_url":"https://api.github.com/repos/metaeducation/ren-c/languages","stargazers_url":"https://api.github.com/repos/metaeducation/ren-c/stargazers","contributors_url":"https://api.github.com/repos/metaeducation/ren-c/contributors","subscribers_url":"https://api.github.com/repos/metaeducation/ren-c/subscribers","subscription_url":"https://api.github.com/repos/metaeducation/ren-c/subscription","commits_url":"https://api.github.com/repos/metaeducation/ren-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/metaeducation/ren-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/metaeducation/ren-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/metaeducation/ren-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/metaeducation/ren-c/contents/{+path}","compare_url":"https://api.github.com/repos/metaeducation/ren-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metaeducation/ren-c/merges","archive_url":"https://api.github.com/repos/metaeducation/ren-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metaeducation/ren-c/downloads","issues_url":"https://api.github.com/repos/metaeducation/ren-c/issues{/number}","pulls_url":"https://api.github.com/repos/metaeducation/ren-c/pulls{/number}","milestones_url":"https://api.github.com/repos/metaeducation/ren-c/milestones{/number}","notifications_url":"https://api.github.com/repos/metaeducation/ren-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metaeducation/ren-c/labels{/name}","releases_url":"https://api.github.com/repos/metaeducation/ren-c/releases{/id}","deployments_url":"https://api.github.com/repos/metaeducation/ren-c/deployments","created_at":"2015-05-14T03:55:55Z","updated_at":"2016-10-23T18:25:53Z","pushed_at":"2016-11-02T00:47:37Z","git_url":"git://github.com/metaeducation/ren-c.git","ssh_url":"git@github.com:metaeducation/ren-c.git","clone_url":"https://github.com/metaeducation/ren-c.git","svn_url":"https://github.com/metaeducation/ren-c","homepage":"","size":52048,"stargazers_count":38,"watchers_count":38,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":17,"forks":13,"open_issues":17,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metaeducation/ren-c/pulls/325"},"html":{"href":"https://github.com/metaeducation/ren-c/pull/325"},"issue":{"href":"https://api.github.com/repos/metaeducation/ren-c/issues/325"},"comments":{"href":"https://api.github.com/repos/metaeducation/ren-c/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/metaeducation/ren-c/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/metaeducation/ren-c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metaeducation/ren-c/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/metaeducation/ren-c/statuses/e09ae08d9d50a2a726bc65caa312d3dc3491b2c3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hostilefork","id":20440,"avatar_url":"https://avatars.githubusercontent.com/u/20440?v=3","gravatar_id":"","url":"https://api.github.com/users/hostilefork","html_url":"https://github.com/hostilefork","followers_url":"https://api.github.com/users/hostilefork/followers","following_url":"https://api.github.com/users/hostilefork/following{/other_user}","gists_url":"https://api.github.com/users/hostilefork/gists{/gist_id}","starred_url":"https://api.github.com/users/hostilefork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hostilefork/subscriptions","organizations_url":"https://api.github.com/users/hostilefork/orgs","repos_url":"https://api.github.com/users/hostilefork/repos","events_url":"https://api.github.com/users/hostilefork/events{/privacy}","received_events_url":"https://api.github.com/users/hostilefork/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":21,"changed_files":1}}
{"actor":{"display_login":"hostilefork"}}