{"action":"created","comment":{"url":"https://api.github.com/repos/tobli/browsertime/pulls/comments/53459656","id":53459656,"diff_hunk":"@@ -297,6 +302,12 @@ module.exports = {\n       }\n     }\n \n+    entries.sort((a,b) => {","path":"lib/support/chrome-perflog-parser.js","position":68,"original_position":68,"commit_id":"7885fe2d78119a2eb79748d9e5e997bbbf05b1d9","original_commit_id":"7885fe2d78119a2eb79748d9e5e997bbbf05b1d9","user":{"login":"tobli","id":540266,"avatar_url":"https://avatars.githubusercontent.com/u/540266?v=3","gravatar_id":"","url":"https://api.github.com/users/tobli","html_url":"https://github.com/tobli","followers_url":"https://api.github.com/users/tobli/followers","following_url":"https://api.github.com/users/tobli/following{/other_user}","gists_url":"https://api.github.com/users/tobli/gists{/gist_id}","starred_url":"https://api.github.com/users/tobli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobli/subscriptions","organizations_url":"https://api.github.com/users/tobli/orgs","repos_url":"https://api.github.com/users/tobli/repos","events_url":"https://api.github.com/users/tobli/events{/privacy}","received_events_url":"https://api.github.com/users/tobli/received_events","type":"User","site_admin":false},"body":"Hmm, what does this do? parseFloat of an entry would just be NaN.","created_at":"2016-02-19T13:24:15Z","updated_at":"2016-02-19T13:24:15Z","html_url":"https://github.com/tobli/browsertime/pull/109#discussion_r53459656","pull_request_url":"https://api.github.com/repos/tobli/browsertime/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/tobli/browsertime/pulls/comments/53459656"},"html":{"href":"https://github.com/tobli/browsertime/pull/109#discussion_r53459656"},"pull_request":{"href":"https://api.github.com/repos/tobli/browsertime/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/tobli/browsertime/pulls/109","id":59905490,"html_url":"https://github.com/tobli/browsertime/pull/109","diff_url":"https://github.com/tobli/browsertime/pull/109.diff","patch_url":"https://github.com/tobli/browsertime/pull/109.patch","issue_url":"https://api.github.com/repos/tobli/browsertime/issues/109","number":109,"state":"open","locked":false,"title":"Use previous connection id's time as blocking time","user":{"login":"beenanner","id":723985,"avatar_url":"https://avatars.githubusercontent.com/u/723985?v=3","gravatar_id":"","url":"https://api.github.com/users/beenanner","html_url":"https://github.com/beenanner","followers_url":"https://api.github.com/users/beenanner/followers","following_url":"https://api.github.com/users/beenanner/following{/other_user}","gists_url":"https://api.github.com/users/beenanner/gists{/gist_id}","starred_url":"https://api.github.com/users/beenanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beenanner/subscriptions","organizations_url":"https://api.github.com/users/beenanner/orgs","repos_url":"https://api.github.com/users/beenanner/repos","events_url":"https://api.github.com/users/beenanner/events{/privacy}","received_events_url":"https://api.github.com/users/beenanner/received_events","type":"User","site_admin":false},"body":"@tobli / @soulgalore for #102 It's ugly and needs some clean up, but should work. \r\n\r\n*Note since Chrome has \"Stalled\" and \"Queued\"  and and they do not surface either in the logs I had no choice but to report both as \"blocking\". In Chrome's Dev Tools \"stalled\" actually pushes the start time out and \"queued\" actually reports as blocking time for the next request on the shared connection id. IMO  adding to \"blocking\" time for both makes more sense to me since if they are sharing connection ids they can't do anything until the previous request is complete in HTTP/1. It more clearly shows performance bottlenecks with having too many requests going to a single domain","created_at":"2016-02-19T05:11:53Z","updated_at":"2016-02-19T13:24:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"461e0ba8aa83e8419dcf8684330a722bdc87b5d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tobli/browsertime/pulls/109/commits","review_comments_url":"https://api.github.com/repos/tobli/browsertime/pulls/109/comments","review_comment_url":"https://api.github.com/repos/tobli/browsertime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tobli/browsertime/issues/109/comments","statuses_url":"https://api.github.com/repos/tobli/browsertime/statuses/7885fe2d78119a2eb79748d9e5e997bbbf05b1d9","head":{"label":"beenanner:fix-for-chrome-waterfall","ref":"fix-for-chrome-waterfall","sha":"7885fe2d78119a2eb79748d9e5e997bbbf05b1d9","user":{"login":"beenanner","id":723985,"avatar_url":"https://avatars.githubusercontent.com/u/723985?v=3","gravatar_id":"","url":"https://api.github.com/users/beenanner","html_url":"https://github.com/beenanner","followers_url":"https://api.github.com/users/beenanner/followers","following_url":"https://api.github.com/users/beenanner/following{/other_user}","gists_url":"https://api.github.com/users/beenanner/gists{/gist_id}","starred_url":"https://api.github.com/users/beenanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beenanner/subscriptions","organizations_url":"https://api.github.com/users/beenanner/orgs","repos_url":"https://api.github.com/users/beenanner/repos","events_url":"https://api.github.com/users/beenanner/events{/privacy}","received_events_url":"https://api.github.com/users/beenanner/received_events","type":"User","site_admin":false},"repo":{"id":49925754,"name":"browsertime","full_name":"beenanner/browsertime","owner":{"login":"beenanner","id":723985,"avatar_url":"https://avatars.githubusercontent.com/u/723985?v=3","gravatar_id":"","url":"https://api.github.com/users/beenanner","html_url":"https://github.com/beenanner","followers_url":"https://api.github.com/users/beenanner/followers","following_url":"https://api.github.com/users/beenanner/following{/other_user}","gists_url":"https://api.github.com/users/beenanner/gists{/gist_id}","starred_url":"https://api.github.com/users/beenanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beenanner/subscriptions","organizations_url":"https://api.github.com/users/beenanner/orgs","repos_url":"https://api.github.com/users/beenanner/repos","events_url":"https://api.github.com/users/beenanner/events{/privacy}","received_events_url":"https://api.github.com/users/beenanner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beenanner/browsertime","description":"The Web Performance Timeline, from your browser, in your terminal.","fork":true,"url":"https://api.github.com/repos/beenanner/browsertime","forks_url":"https://api.github.com/repos/beenanner/browsertime/forks","keys_url":"https://api.github.com/repos/beenanner/browsertime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beenanner/browsertime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beenanner/browsertime/teams","hooks_url":"https://api.github.com/repos/beenanner/browsertime/hooks","issue_events_url":"https://api.github.com/repos/beenanner/browsertime/issues/events{/number}","events_url":"https://api.github.com/repos/beenanner/browsertime/events","assignees_url":"https://api.github.com/repos/beenanner/browsertime/assignees{/user}","branches_url":"https://api.github.com/repos/beenanner/browsertime/branches{/branch}","tags_url":"https://api.github.com/repos/beenanner/browsertime/tags","blobs_url":"https://api.github.com/repos/beenanner/browsertime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beenanner/browsertime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beenanner/browsertime/git/refs{/sha}","trees_url":"https://api.github.com/repos/beenanner/browsertime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beenanner/browsertime/statuses/{sha}","languages_url":"https://api.github.com/repos/beenanner/browsertime/languages","stargazers_url":"https://api.github.com/repos/beenanner/browsertime/stargazers","contributors_url":"https://api.github.com/repos/beenanner/browsertime/contributors","subscribers_url":"https://api.github.com/repos/beenanner/browsertime/subscribers","subscription_url":"https://api.github.com/repos/beenanner/browsertime/subscription","commits_url":"https://api.github.com/repos/beenanner/browsertime/commits{/sha}","git_commits_url":"https://api.github.com/repos/beenanner/browsertime/git/commits{/sha}","comments_url":"https://api.github.com/repos/beenanner/browsertime/comments{/number}","issue_comment_url":"https://api.github.com/repos/beenanner/browsertime/issues/comments{/number}","contents_url":"https://api.github.com/repos/beenanner/browsertime/contents/{+path}","compare_url":"https://api.github.com/repos/beenanner/browsertime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beenanner/browsertime/merges","archive_url":"https://api.github.com/repos/beenanner/browsertime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beenanner/browsertime/downloads","issues_url":"https://api.github.com/repos/beenanner/browsertime/issues{/number}","pulls_url":"https://api.github.com/repos/beenanner/browsertime/pulls{/number}","milestones_url":"https://api.github.com/repos/beenanner/browsertime/milestones{/number}","notifications_url":"https://api.github.com/repos/beenanner/browsertime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beenanner/browsertime/labels{/name}","releases_url":"https://api.github.com/repos/beenanner/browsertime/releases{/id}","deployments_url":"https://api.github.com/repos/beenanner/browsertime/deployments","created_at":"2016-01-19T04:18:00Z","updated_at":"2016-01-19T04:18:01Z","pushed_at":"2016-02-19T05:50:22Z","git_url":"git://github.com/beenanner/browsertime.git","ssh_url":"git@github.com:beenanner/browsertime.git","clone_url":"https://github.com/beenanner/browsertime.git","svn_url":"https://github.com/beenanner/browsertime","homepage":"","size":82752,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tobli:1.0","ref":"1.0","sha":"1ca7f5dfed00cb2ae79f829b45783156cbd7bb57","user":{"login":"tobli","id":540266,"avatar_url":"https://avatars.githubusercontent.com/u/540266?v=3","gravatar_id":"","url":"https://api.github.com/users/tobli","html_url":"https://github.com/tobli","followers_url":"https://api.github.com/users/tobli/followers","following_url":"https://api.github.com/users/tobli/following{/other_user}","gists_url":"https://api.github.com/users/tobli/gists{/gist_id}","starred_url":"https://api.github.com/users/tobli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobli/subscriptions","organizations_url":"https://api.github.com/users/tobli/orgs","repos_url":"https://api.github.com/users/tobli/repos","events_url":"https://api.github.com/users/tobli/events{/privacy}","received_events_url":"https://api.github.com/users/tobli/received_events","type":"User","site_admin":false},"repo":{"id":12298355,"name":"browsertime","full_name":"tobli/browsertime","owner":{"login":"tobli","id":540266,"avatar_url":"https://avatars.githubusercontent.com/u/540266?v=3","gravatar_id":"","url":"https://api.github.com/users/tobli","html_url":"https://github.com/tobli","followers_url":"https://api.github.com/users/tobli/followers","following_url":"https://api.github.com/users/tobli/following{/other_user}","gists_url":"https://api.github.com/users/tobli/gists{/gist_id}","starred_url":"https://api.github.com/users/tobli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobli/subscriptions","organizations_url":"https://api.github.com/users/tobli/orgs","repos_url":"https://api.github.com/users/tobli/repos","events_url":"https://api.github.com/users/tobli/events{/privacy}","received_events_url":"https://api.github.com/users/tobli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobli/browsertime","description":"The Web Performance Timeline, from your browser, in your terminal.","fork":false,"url":"https://api.github.com/repos/tobli/browsertime","forks_url":"https://api.github.com/repos/tobli/browsertime/forks","keys_url":"https://api.github.com/repos/tobli/browsertime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobli/browsertime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobli/browsertime/teams","hooks_url":"https://api.github.com/repos/tobli/browsertime/hooks","issue_events_url":"https://api.github.com/repos/tobli/browsertime/issues/events{/number}","events_url":"https://api.github.com/repos/tobli/browsertime/events","assignees_url":"https://api.github.com/repos/tobli/browsertime/assignees{/user}","branches_url":"https://api.github.com/repos/tobli/browsertime/branches{/branch}","tags_url":"https://api.github.com/repos/tobli/browsertime/tags","blobs_url":"https://api.github.com/repos/tobli/browsertime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobli/browsertime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobli/browsertime/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobli/browsertime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobli/browsertime/statuses/{sha}","languages_url":"https://api.github.com/repos/tobli/browsertime/languages","stargazers_url":"https://api.github.com/repos/tobli/browsertime/stargazers","contributors_url":"https://api.github.com/repos/tobli/browsertime/contributors","subscribers_url":"https://api.github.com/repos/tobli/browsertime/subscribers","subscription_url":"https://api.github.com/repos/tobli/browsertime/subscription","commits_url":"https://api.github.com/repos/tobli/browsertime/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobli/browsertime/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobli/browsertime/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobli/browsertime/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobli/browsertime/contents/{+path}","compare_url":"https://api.github.com/repos/tobli/browsertime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobli/browsertime/merges","archive_url":"https://api.github.com/repos/tobli/browsertime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobli/browsertime/downloads","issues_url":"https://api.github.com/repos/tobli/browsertime/issues{/number}","pulls_url":"https://api.github.com/repos/tobli/browsertime/pulls{/number}","milestones_url":"https://api.github.com/repos/tobli/browsertime/milestones{/number}","notifications_url":"https://api.github.com/repos/tobli/browsertime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobli/browsertime/labels{/name}","releases_url":"https://api.github.com/repos/tobli/browsertime/releases{/id}","deployments_url":"https://api.github.com/repos/tobli/browsertime/deployments","created_at":"2013-08-22T14:00:15Z","updated_at":"2016-02-13T08:08:16Z","pushed_at":"2016-02-19T05:50:22Z","git_url":"git://github.com/tobli/browsertime.git","ssh_url":"git@github.com:tobli/browsertime.git","clone_url":"https://github.com/tobli/browsertime.git","svn_url":"https://github.com/tobli/browsertime","homepage":"","size":82557,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tobli/browsertime/pulls/109"},"html":{"href":"https://github.com/tobli/browsertime/pull/109"},"issue":{"href":"https://api.github.com/repos/tobli/browsertime/issues/109"},"comments":{"href":"https://api.github.com/repos/tobli/browsertime/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/tobli/browsertime/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/tobli/browsertime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tobli/browsertime/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/tobli/browsertime/statuses/7885fe2d78119a2eb79748d9e5e997bbbf05b1d9"}}}}