{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/56560811","id":56560811,"diff_hunk":"@@ -272,12 +293,12 @@ exports.resolve = function(hostname, type_, callback_) {\n   if (typeof resolver === 'function') {\n     return resolver(hostname, callback);\n   } else {\n-    throw new Error('Unknown type \"' + type_ + '\"');\n+    throw new Error(`Unknown type ${type_}`);\n   }\n };\n \n \n-exports.getServers = function() {\n+exports.getServers = () => {\n   return cares.getServers();\n };","path":"lib/dns.js","position":221,"original_position":221,"commit_id":"4f124f71328457a00b3e7c64f6818f3c100772fb","original_commit_id":"4f124f71328457a00b3e7c64f6818f3c100772fb","user":{"login":"williamkapke","id":739813,"avatar_url":"https://avatars.githubusercontent.com/u/739813?v=3","gravatar_id":"","url":"https://api.github.com/users/williamkapke","html_url":"https://github.com/williamkapke","followers_url":"https://api.github.com/users/williamkapke/followers","following_url":"https://api.github.com/users/williamkapke/following{/other_user}","gists_url":"https://api.github.com/users/williamkapke/gists{/gist_id}","starred_url":"https://api.github.com/users/williamkapke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamkapke/subscriptions","organizations_url":"https://api.github.com/users/williamkapke/orgs","repos_url":"https://api.github.com/users/williamkapke/repos","events_url":"https://api.github.com/users/williamkapke/events{/privacy}","received_events_url":"https://api.github.com/users/williamkapke/received_events","type":"User","site_admin":false},"body":"```javascript\r\nexports.getServers = () => cares.getServers();\r\n```\r\nAre the curlys required by coding convention here? ::shrugs::","created_at":"2016-03-17T19:07:04Z","updated_at":"2016-03-17T19:07:04Z","html_url":"https://github.com/nodejs/node/pull/5762#discussion_r56560811","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/5762","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/56560811"},"html":{"href":"https://github.com/nodejs/node/pull/5762#discussion_r56560811"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/5762"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5762","id":63258060,"html_url":"https://github.com/nodejs/node/pull/5762","diff_url":"https://github.com/nodejs/node/pull/5762.diff","patch_url":"https://github.com/nodejs/node/pull/5762.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/5762","number":5762,"state":"open","locked":false,"title":"dns: refactor dns to more modern JavaScript","user":{"login":"benjamingr","id":1315533,"avatar_url":"https://avatars.githubusercontent.com/u/1315533?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamingr","html_url":"https://github.com/benjamingr","followers_url":"https://api.github.com/users/benjamingr/followers","following_url":"https://api.github.com/users/benjamingr/following{/other_user}","gists_url":"https://api.github.com/users/benjamingr/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingr/subscriptions","organizations_url":"https://api.github.com/users/benjamingr/orgs","repos_url":"https://api.github.com/users/benjamingr/repos","events_url":"https://api.github.com/users/benjamingr/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingr/received_events","type":"User","site_admin":false},"body":"### Pull Request check-list\r\n\r\n\r\n### Affected core subsystem(s)\r\n\r\ndns \r\n\r\n### Description of change\r\n\r\nThe current dns.js file contains some pretty outdated JavaScript practices - this pull request aims to improve the file and bring it up to the standard coding style the rest of the project has.\r\n\r\nWIP: meanwhile feedback is appreciated.","created_at":"2016-03-17T17:07:31Z","updated_at":"2016-03-17T19:07:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e142e79557130fefe1059dab713f90e531943e5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/5762/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/5762/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5762/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/4f124f71328457a00b3e7c64f6818f3c100772fb","head":{"label":"benjamingr:dns-refactor","ref":"dns-refactor","sha":"4f124f71328457a00b3e7c64f6818f3c100772fb","user":{"login":"benjamingr","id":1315533,"avatar_url":"https://avatars.githubusercontent.com/u/1315533?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamingr","html_url":"https://github.com/benjamingr","followers_url":"https://api.github.com/users/benjamingr/followers","following_url":"https://api.github.com/users/benjamingr/following{/other_user}","gists_url":"https://api.github.com/users/benjamingr/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingr/subscriptions","organizations_url":"https://api.github.com/users/benjamingr/orgs","repos_url":"https://api.github.com/users/benjamingr/repos","events_url":"https://api.github.com/users/benjamingr/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingr/received_events","type":"User","site_admin":false},"repo":{"id":31790980,"name":"io.js","full_name":"benjamingr/io.js","owner":{"login":"benjamingr","id":1315533,"avatar_url":"https://avatars.githubusercontent.com/u/1315533?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamingr","html_url":"https://github.com/benjamingr","followers_url":"https://api.github.com/users/benjamingr/followers","following_url":"https://api.github.com/users/benjamingr/following{/other_user}","gists_url":"https://api.github.com/users/benjamingr/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingr/subscriptions","organizations_url":"https://api.github.com/users/benjamingr/orgs","repos_url":"https://api.github.com/users/benjamingr/repos","events_url":"https://api.github.com/users/benjamingr/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjamingr/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/benjamingr/io.js","forks_url":"https://api.github.com/repos/benjamingr/io.js/forks","keys_url":"https://api.github.com/repos/benjamingr/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjamingr/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjamingr/io.js/teams","hooks_url":"https://api.github.com/repos/benjamingr/io.js/hooks","issue_events_url":"https://api.github.com/repos/benjamingr/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/benjamingr/io.js/events","assignees_url":"https://api.github.com/repos/benjamingr/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/benjamingr/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/benjamingr/io.js/tags","blobs_url":"https://api.github.com/repos/benjamingr/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjamingr/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjamingr/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjamingr/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjamingr/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/benjamingr/io.js/languages","stargazers_url":"https://api.github.com/repos/benjamingr/io.js/stargazers","contributors_url":"https://api.github.com/repos/benjamingr/io.js/contributors","subscribers_url":"https://api.github.com/repos/benjamingr/io.js/subscribers","subscription_url":"https://api.github.com/repos/benjamingr/io.js/subscription","commits_url":"https://api.github.com/repos/benjamingr/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjamingr/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjamingr/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjamingr/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjamingr/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/benjamingr/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjamingr/io.js/merges","archive_url":"https://api.github.com/repos/benjamingr/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjamingr/io.js/downloads","issues_url":"https://api.github.com/repos/benjamingr/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/benjamingr/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/benjamingr/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/benjamingr/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjamingr/io.js/labels{/name}","releases_url":"https://api.github.com/repos/benjamingr/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/benjamingr/io.js/deployments","created_at":"2015-03-06T22:01:35Z","updated_at":"2015-03-06T22:01:39Z","pushed_at":"2016-03-17T18:57:05Z","git_url":"git://github.com/benjamingr/io.js.git","ssh_url":"git@github.com:benjamingr/io.js.git","clone_url":"https://github.com/benjamingr/io.js.git","svn_url":"https://github.com/benjamingr/io.js","homepage":"https://iojs.org","size":183688,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"nodejs:master","ref":"master","sha":"2e1ae3ead1a3bb7edb8bdb0e717135207d3bfd12","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-03-17T18:52:05Z","pushed_at":"2016-03-17T19:01:17Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":225459,"stargazers_count":21173,"watchers_count":21173,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2763,"mirror_url":null,"open_issues_count":752,"forks":2763,"open_issues":752,"watchers":21173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/5762"},"html":{"href":"https://github.com/nodejs/node/pull/5762"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/5762"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/5762/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/5762/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/5762/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/4f124f71328457a00b3e7c64f6818f3c100772fb"}}}}