{"action":"created","issue":{"url":"https://api.github.com/repos/deployphp/deployer/issues/688","repository_url":"https://api.github.com/repos/deployphp/deployer","labels_url":"https://api.github.com/repos/deployphp/deployer/issues/688/labels{/name}","comments_url":"https://api.github.com/repos/deployphp/deployer/issues/688/comments","events_url":"https://api.github.com/repos/deployphp/deployer/issues/688/events","html_url":"https://github.com/deployphp/deployer/pull/688","id":158564347,"number":688,"title":"Refactoring/Cleanup/Fixes for Symfony-related Recipes","user":{"login":"robfrawley","id":3967713,"avatar_url":"https://avatars.githubusercontent.com/u/3967713?v=3","gravatar_id":"","url":"https://api.github.com/users/robfrawley","html_url":"https://github.com/robfrawley","followers_url":"https://api.github.com/users/robfrawley/followers","following_url":"https://api.github.com/users/robfrawley/following{/other_user}","gists_url":"https://api.github.com/users/robfrawley/gists{/gist_id}","starred_url":"https://api.github.com/users/robfrawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfrawley/subscriptions","organizations_url":"https://api.github.com/users/robfrawley/orgs","repos_url":"https://api.github.com/users/robfrawley/repos","events_url":"https://api.github.com/users/robfrawley/events{/privacy}","received_events_url":"https://api.github.com/users/robfrawley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/deployphp/deployer/labels/bugfix","name":"bugfix","color":"0e8a16"},{"url":"https://api.github.com/repos/deployphp/deployer/labels/DX","name":"DX","color":"5319e7"},{"url":"https://api.github.com/repos/deployphp/deployer/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2016-06-05T17:17:25Z","updated_at":"2016-08-04T19:07:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deployphp/deployer/pulls/688","html_url":"https://github.com/deployphp/deployer/pull/688","diff_url":"https://github.com/deployphp/deployer/pull/688.diff","patch_url":"https://github.com/deployphp/deployer/pull/688.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | Yes\r\n| New feature?  | Yes\r\n| BC breaks?    | Yes\r\n| Deprecations? | No\r\n| Fixed tickets | N/A\r\n\r\n- Removed overridden `deploy:assetic:dump` task in `symfony3` recipe, as it implied this command was no longer valid and should be overridden with `deploy:assets:install` command. In reality, `deploy:assets:install` should exist in all symfony versions, as should `deploy:assetic:dump` (although this is arguable, as `deploy:assetic:dump` isn't a Symfony command, it is a kriswallsmith/assetic command). \r\n- Changed default for `deploy:assetic:dump` to `false` (via `dump_assets`) as this is not a core Symfony package and should not be assumed to be installed. It relies on kriswallsmith/assetic and symfony/assetic-bundle.\r\n- Added `deploy:assets:install` task as this is a symfony-core command that is intended to be called prior to other asset compilation commands (such as `deploy:assetic:dump`). Its purpose to is to install any bundle assets (within `<bundleName>/Resource/public`) and put them in `web/bundles/<bundleName>`.\r\n- `composer_action` created\r\n- Fixed `SYMFONY_ENV` value in `env_vars` to correctly refer to the configured `env` value.\r\n- Created `bin/console` to cleanup calls to Symfony console command (there was a ton of duplicated lines prior)\r\n- created `console_options` so the options passed to `bin/console` reflect what should be passed per the configured environment (for example, the `--no-debug` options cannot be passed for any environment except for `prod` and will likely break hard when passed for `dev` environment)\r\n- General cleanup..."},"comment":{"url":"https://api.github.com/repos/deployphp/deployer/issues/comments/237652483","html_url":"https://github.com/deployphp/deployer/pull/688#issuecomment-237652483","issue_url":"https://api.github.com/repos/deployphp/deployer/issues/688","id":237652483,"user":{"login":"elfet","id":141232,"avatar_url":"https://avatars.githubusercontent.com/u/141232?v=3","gravatar_id":"","url":"https://api.github.com/users/elfet","html_url":"https://github.com/elfet","followers_url":"https://api.github.com/users/elfet/followers","following_url":"https://api.github.com/users/elfet/following{/other_user}","gists_url":"https://api.github.com/users/elfet/gists{/gist_id}","starred_url":"https://api.github.com/users/elfet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfet/subscriptions","organizations_url":"https://api.github.com/users/elfet/orgs","repos_url":"https://api.github.com/users/elfet/repos","events_url":"https://api.github.com/users/elfet/events{/privacy}","received_events_url":"https://api.github.com/users/elfet/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T19:07:33Z","updated_at":"2016-08-04T19:07:33Z","body":"@robfrawley please check [4.x branch](https://github.com/deployphp/deployer/tree/4.x)."}}
{"actor":{"display_login":"elfet"}}