{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/3","id":68108839,"html_url":"https://github.com/qandidate-labs/qandidate-toggle-ui/pull/3","diff_url":"https://github.com/qandidate-labs/qandidate-toggle-ui/pull/3.diff","patch_url":"https://github.com/qandidate-labs/qandidate-toggle-ui/pull/3.patch","issue_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/issues/3","number":3,"state":"closed","locked":false,"title":"Allow multiple name changes","user":{"login":"reenl","id":951945,"avatar_url":"https://avatars.githubusercontent.com/u/951945?v=3","gravatar_id":"","url":"https://api.github.com/users/reenl","html_url":"https://github.com/reenl","followers_url":"https://api.github.com/users/reenl/followers","following_url":"https://api.github.com/users/reenl/following{/other_user}","gists_url":"https://api.github.com/users/reenl/gists{/gist_id}","starred_url":"https://api.github.com/users/reenl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reenl/subscriptions","organizations_url":"https://api.github.com/users/reenl/orgs","repos_url":"https://api.github.com/users/reenl/repos","events_url":"https://api.github.com/users/reenl/events{/privacy}","received_events_url":"https://api.github.com/users/reenl/received_events","type":"User","site_admin":false},"body":"Changing the name of a toggle multiple times within the same requests yield errors. This PR resolves this issue.\r\n\r\nIt also binds the enter key to the name input field.\r\n\r\nThe final commit \"fixes\" the fact that the save button appears for all toggles when a single toggle is changed. And it will also remove the save button again once saved.\r\n\r\nSidenotes:\r\n\r\n* CS Was inconsistent, so I used 4 spaces\r\n* Changes are in separate commits, let me know if there is anything you don't like and I'll remove it\r\n* My intend was just to do a little practice with angular :)\r\n* Didn't get the e2e tests to work `failed to proxy /app/index-e2e.html`\r\n* Had to be [creative](https://github.com/qandidate-labs/qandidate-toggle-ui/pull/3/commits/ecab77aac56ff5b16a05b56870cebb54c20c5da9#diff-40084eb42a8e52b0a5ff0264ef426c94R54) to remove the dirty class from the form not sure how bad it is...\r\n  (The controller is bound to the toggleForm in the scope)","created_at":"2016-04-27T19:16:28Z","updated_at":"2016-06-14T18:36:34Z","closed_at":"2016-06-14T18:36:34Z","merged_at":"2016-06-14T18:36:34Z","merge_commit_sha":"c4e2befbff1ff4fe321ec7a9f5f73f59bb0afd43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/3/commits","review_comments_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/3/comments","review_comment_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/issues/3/comments","statuses_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/statuses/33ce9886bf6e618ee312f15f828ea4336630fd6b","head":{"label":"reenl:allow-multiple-name-changes","ref":"allow-multiple-name-changes","sha":"33ce9886bf6e618ee312f15f828ea4336630fd6b","user":{"login":"reenl","id":951945,"avatar_url":"https://avatars.githubusercontent.com/u/951945?v=3","gravatar_id":"","url":"https://api.github.com/users/reenl","html_url":"https://github.com/reenl","followers_url":"https://api.github.com/users/reenl/followers","following_url":"https://api.github.com/users/reenl/following{/other_user}","gists_url":"https://api.github.com/users/reenl/gists{/gist_id}","starred_url":"https://api.github.com/users/reenl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reenl/subscriptions","organizations_url":"https://api.github.com/users/reenl/orgs","repos_url":"https://api.github.com/users/reenl/repos","events_url":"https://api.github.com/users/reenl/events{/privacy}","received_events_url":"https://api.github.com/users/reenl/received_events","type":"User","site_admin":false},"repo":{"id":57239607,"name":"qandidate-toggle-ui","full_name":"reenl/qandidate-toggle-ui","owner":{"login":"reenl","id":951945,"avatar_url":"https://avatars.githubusercontent.com/u/951945?v=3","gravatar_id":"","url":"https://api.github.com/users/reenl","html_url":"https://github.com/reenl","followers_url":"https://api.github.com/users/reenl/followers","following_url":"https://api.github.com/users/reenl/following{/other_user}","gists_url":"https://api.github.com/users/reenl/gists{/gist_id}","starred_url":"https://api.github.com/users/reenl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reenl/subscriptions","organizations_url":"https://api.github.com/users/reenl/orgs","repos_url":"https://api.github.com/users/reenl/repos","events_url":"https://api.github.com/users/reenl/events{/privacy}","received_events_url":"https://api.github.com/users/reenl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reenl/qandidate-toggle-ui","description":"","fork":true,"url":"https://api.github.com/repos/reenl/qandidate-toggle-ui","forks_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/forks","keys_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/teams","hooks_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/hooks","issue_events_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/issues/events{/number}","events_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/events","assignees_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/assignees{/user}","branches_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/branches{/branch}","tags_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/tags","blobs_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/languages","stargazers_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/stargazers","contributors_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/contributors","subscribers_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/subscribers","subscription_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/subscription","commits_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/contents/{+path}","compare_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/merges","archive_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/downloads","issues_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/issues{/number}","pulls_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/labels{/name}","releases_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/releases{/id}","deployments_url":"https://api.github.com/repos/reenl/qandidate-toggle-ui/deployments","created_at":"2016-04-27T19:11:36Z","updated_at":"2016-04-27T19:11:38Z","pushed_at":"2016-05-03T21:42:51Z","git_url":"git://github.com/reenl/qandidate-toggle-ui.git","ssh_url":"git@github.com:reenl/qandidate-toggle-ui.git","clone_url":"https://github.com/reenl/qandidate-toggle-ui.git","svn_url":"https://github.com/reenl/qandidate-toggle-ui","homepage":null,"size":527,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qandidate-labs:master","ref":"master","sha":"29abcda50b05ad7fba9b950fcc72a0edaccfeb57","user":{"login":"qandidate-labs","id":4686531,"avatar_url":"https://avatars.githubusercontent.com/u/4686531?v=3","gravatar_id":"","url":"https://api.github.com/users/qandidate-labs","html_url":"https://github.com/qandidate-labs","followers_url":"https://api.github.com/users/qandidate-labs/followers","following_url":"https://api.github.com/users/qandidate-labs/following{/other_user}","gists_url":"https://api.github.com/users/qandidate-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/qandidate-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qandidate-labs/subscriptions","organizations_url":"https://api.github.com/users/qandidate-labs/orgs","repos_url":"https://api.github.com/users/qandidate-labs/repos","events_url":"https://api.github.com/users/qandidate-labs/events{/privacy}","received_events_url":"https://api.github.com/users/qandidate-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":23112254,"name":"qandidate-toggle-ui","full_name":"qandidate-labs/qandidate-toggle-ui","owner":{"login":"qandidate-labs","id":4686531,"avatar_url":"https://avatars.githubusercontent.com/u/4686531?v=3","gravatar_id":"","url":"https://api.github.com/users/qandidate-labs","html_url":"https://github.com/qandidate-labs","followers_url":"https://api.github.com/users/qandidate-labs/followers","following_url":"https://api.github.com/users/qandidate-labs/following{/other_user}","gists_url":"https://api.github.com/users/qandidate-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/qandidate-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qandidate-labs/subscriptions","organizations_url":"https://api.github.com/users/qandidate-labs/orgs","repos_url":"https://api.github.com/users/qandidate-labs/repos","events_url":"https://api.github.com/users/qandidate-labs/events{/privacy}","received_events_url":"https://api.github.com/users/qandidate-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qandidate-labs/qandidate-toggle-ui","description":"","fork":false,"url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui","forks_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/forks","keys_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/teams","hooks_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/hooks","issue_events_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/issues/events{/number}","events_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/events","assignees_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/assignees{/user}","branches_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/branches{/branch}","tags_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/tags","blobs_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/languages","stargazers_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/stargazers","contributors_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/contributors","subscribers_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/subscribers","subscription_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/subscription","commits_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/contents/{+path}","compare_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/merges","archive_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/downloads","issues_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/issues{/number}","pulls_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/labels{/name}","releases_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/releases{/id}","deployments_url":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/deployments","created_at":"2014-08-19T14:02:21Z","updated_at":"2016-05-29T10:01:53Z","pushed_at":"2016-06-14T18:36:34Z","git_url":"git://github.com/qandidate-labs/qandidate-toggle-ui.git","ssh_url":"git@github.com:qandidate-labs/qandidate-toggle-ui.git","clone_url":"https://github.com/qandidate-labs/qandidate-toggle-ui.git","svn_url":"https://github.com/qandidate-labs/qandidate-toggle-ui","homepage":null,"size":712,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/3"},"html":{"href":"https://github.com/qandidate-labs/qandidate-toggle-ui/pull/3"},"issue":{"href":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/issues/3"},"comments":{"href":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/qandidate-labs/qandidate-toggle-ui/statuses/33ce9886bf6e618ee312f15f828ea4336630fd6b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wjzijderveld","id":450201,"avatar_url":"https://avatars.githubusercontent.com/u/450201?v=3","gravatar_id":"","url":"https://api.github.com/users/wjzijderveld","html_url":"https://github.com/wjzijderveld","followers_url":"https://api.github.com/users/wjzijderveld/followers","following_url":"https://api.github.com/users/wjzijderveld/following{/other_user}","gists_url":"https://api.github.com/users/wjzijderveld/gists{/gist_id}","starred_url":"https://api.github.com/users/wjzijderveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjzijderveld/subscriptions","organizations_url":"https://api.github.com/users/wjzijderveld/orgs","repos_url":"https://api.github.com/users/wjzijderveld/repos","events_url":"https://api.github.com/users/wjzijderveld/events{/privacy}","received_events_url":"https://api.github.com/users/wjzijderveld/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"commits":3,"additions":60,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"wjzijderveld"}}