{"action":"created","comment":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/comments/64521423","id":64521423,"diff_hunk":"@@ -13,16 +13,14 @@ import {DataComponent} from './data';\n  * Stacked scale data source, for feeding the shared scale.\n  */\n export namespace stackScale {\n-  export function parseUnit(model: UnitModel): VgData {\n+  export function parseUnit(model: Model): VgData {\n     const stackProps = model.stack();\n \n     if (stackProps) {\n       // produce stacked scale\n       const groupbyChannel = stackProps.groupbyChannel;\n       const fieldChannel = stackProps.fieldChannel;\n       return {\n-        name: model.dataName(STACKED_SCALE),","path":"src/compile/data/stackscale.ts","position":26,"original_position":26,"commit_id":"29bd3472158d2b201694d56fbb97c428f0d5a4a2","original_commit_id":"918a2c2f50d59e472a66c6164343b590787bf385","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars.githubusercontent.com/u/111269?v=3","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"Ok.  It goes to `assembleData`.  ","created_at":"2016-05-25T06:30:56Z","updated_at":"2016-05-25T06:30:56Z","html_url":"https://github.com/vega/vega-lite/pull/1304#discussion_r64521423","pull_request_url":"https://api.github.com/repos/vega/vega-lite/pulls/1304","_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments/64521423"},"html":{"href":"https://github.com/vega/vega-lite/pull/1304#discussion_r64521423"},"pull_request":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/1304"}}},"pull_request":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/1304","id":66949602,"html_url":"https://github.com/vega/vega-lite/pull/1304","diff_url":"https://github.com/vega/vega-lite/pull/1304.diff","patch_url":"https://github.com/vega/vega-lite/pull/1304.patch","issue_url":"https://api.github.com/repos/vega/vega-lite/issues/1304","number":1304,"state":"open","locked":false,"title":"[WIP] Layering revisions","user":{"login":"domoritz","id":589034,"avatar_url":"https://avatars.githubusercontent.com/u/589034?v=3","gravatar_id":"","url":"https://api.github.com/users/domoritz","html_url":"https://github.com/domoritz","followers_url":"https://api.github.com/users/domoritz/followers","following_url":"https://api.github.com/users/domoritz/following{/other_user}","gists_url":"https://api.github.com/users/domoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoritz/subscriptions","organizations_url":"https://api.github.com/users/domoritz/orgs","repos_url":"https://api.github.com/users/domoritz/repos","events_url":"https://api.github.com/users/domoritz/events{/privacy}","received_events_url":"https://api.github.com/users/domoritz/received_events","type":"User","site_admin":false},"body":"A clean version of layering\r\n\r\n- Eliminate distinction between `SOURCE` and `SUMMARY` data source so we remove the weird `dataTable()` method in model.\r\n\r\n- [x] reimplement scale merging\r\n- [x] reimplement data merging\r\n- [ ] reimplement layout merging\r\n- [ ] Independent axes (support 2, then throw error)\r\n- [ ] Clean up unnecessary data sources (can be done later)\r\n- [ ] Some Unit Tests\r\n\r\nBased on some changes from https://github.com/vega/vega-lite/compare/repeat3Selections3\r\n\r\n# Ham's Review Checklist\r\n\r\n- [ ] aggregateComponent as an array or single component -- this can be problematic with facet.\r\n\r\n- [ ] facet component.  Discuss the following statement, which highly influence how dom structure facet code\r\n\r\n>  We only need to add the facet fields as dimensions to the summary component.  \r\n\r\n- [ ] put `formula` and `calculate` side-by-side \r\n\r\n- [ ] `hash` => `key`\r\n\r\n## `data/aggregate.ts`\r\n\r\n- [ ] `merge()` in `src/compile/data/aggregate.ts`  \r\n\r\n- [ ] Where does logic for renaming child data in  `parseFacet` in  `src/compile/data/summary.ts`   (now `aggregate.ts`) go?\r\n\r\n## `data/data.ts`\r\n\r\n- [ ] `parseFacetData` very weird.  (Facet can have its own `bin`, `timeUnit`, `calculate`, `filter` but the code assume that's not true.)\r\n  - [ ]  (Facet should support its own `bin`, `timeUnit`, `calculate`, `filter`)\r\n  - [ ] Why does the facet just take data from the child? weird.\r\n\r\n- [ ] BUG? If the child data already have source, we should not override its source. Plus, we can't merge anything. Why isn't there an abort logic for source there.\r\n\r\n- [ ] weird location for `dataHash` method \r\n\r\n- [ ] Why is time unit domain moved up in `parseLayerData()`, but not in `parseFacetData()`.\r\n\r\n- [ ] `assembleData` Probably need to create intermediate source if contains scale sort.\r\n\r\n## `data/formatparse.ts`\r\n\r\n- [ ] `merge()` -- only returns the merge results, but does not return whether the merge completes.\r\nDon't you have to care if the something cannot be merged, then terminate the overall merge process?\r\nAlso, unlike transform, parse is a part of data source. So if parse are not compatible, we cannot merge two data sources at all.\r\n\r\n## `data/nonpositivenullfilter.ts`  \r\n\r\n- [ ] file name\r\n\r\n- [ ] `mergeIfCompatible()` -- when would parent have nonPositiveFilter? This only comes from log scale and none of facet / concat / repeat / layer can have log scale.\r\n\r\n\r\n\r\n## `data\r\n\r\n## `spec.ts`\r\n\r\n- [ ] `ResolveStrategy` => `ResolveMode` ?\r\n- [ ] `Resolve` => `ChannelResolve`\r\n- [ ] `guide` => `axis` | `legend`\r\n\r\n## Question\r\n\r\n- [ ] The other day, we discussed that some merge could be handled by `layer(layer(a,b), c)`  (if data of `a` and `b` should be merged).   –– but that requires supporting layer of layer (not just layer of unit)","created_at":"2016-04-19T01:55:57Z","updated_at":"2016-05-25T06:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7edb4f172c9f1e1df705b2d1903421786357d1d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-lite/pulls/1304/commits","review_comments_url":"https://api.github.com/repos/vega/vega-lite/pulls/1304/comments","review_comment_url":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-lite/issues/1304/comments","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/29bd3472158d2b201694d56fbb97c428f0d5a4a2","head":{"label":"vega:dom/layer-revision","ref":"dom/layer-revision","sha":"29bd3472158d2b201694d56fbb97c428f0d5a4a2","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A high-level grammar for visual analysis, built on top of Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2016-05-24T23:33:37Z","pushed_at":"2016-05-25T06:18:23Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":21404,"stargazers_count":366,"watchers_count":366,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":151,"forks":42,"open_issues":151,"watchers":366,"default_branch":"master"}},"base":{"label":"vega:master","ref":"master","sha":"46597bd6a4e6000c68899289b5aa2fdc3c7fdcd9","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A high-level grammar for visual analysis, built on top of Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2016-05-24T23:33:37Z","pushed_at":"2016-05-25T06:18:23Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":21404,"stargazers_count":366,"watchers_count":366,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":151,"forks":42,"open_issues":151,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/1304"},"html":{"href":"https://github.com/vega/vega-lite/pull/1304"},"issue":{"href":"https://api.github.com/repos/vega/vega-lite/issues/1304"},"comments":{"href":"https://api.github.com/repos/vega/vega-lite/issues/1304/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/1304/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/1304/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-lite/statuses/29bd3472158d2b201694d56fbb97c428f0d5a4a2"}}}}
{"actor":{"display_login":"kanitw"}}