{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3112","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3112/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3112/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3112/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/3112","id":136186543,"number":3112,"title":"added sql_log_bin setting to disable binary logging as option","user":{"login":"Jmainguy","id":1372228,"avatar_url":"https://avatars.githubusercontent.com/u/1372228?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmainguy","html_url":"https://github.com/Jmainguy","followers_url":"https://api.github.com/users/Jmainguy/followers","following_url":"https://api.github.com/users/Jmainguy/following{/other_user}","gists_url":"https://api.github.com/users/Jmainguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmainguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmainguy/subscriptions","organizations_url":"https://api.github.com/users/Jmainguy/orgs","repos_url":"https://api.github.com/users/Jmainguy/repos","events_url":"https://api.github.com/users/Jmainguy/events{/privacy}","received_events_url":"https://api.github.com/users/Jmainguy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/owner_pr","name":"owner_pr","color":"bfe5bf"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/shipit","name":"shipit","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-24T21:08:03Z","updated_at":"2016-03-02T18:42:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3112","html_url":"https://github.com/ansible/ansible-modules-core/pull/3112","diff_url":"https://github.com/ansible/ansible-modules-core/pull/3112.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/3112.patch"},"body":"    ##### Issue Type:\r\n\r\n     - Feature Pull Request\r\n\r\n    ##### Plugin Name:\r\n\r\n    mysql_user\r\n\r\n    ##### Ansible Version:\r\n\r\n    ```\r\n    ansible 2.1.0\r\n    ```\r\n\r\n    ##### Summary:\r\n\r\n    Adds ability to disable sql_log_bin"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/191366561","html_url":"https://github.com/ansible/ansible-modules-core/pull/3112#issuecomment-191366561","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3112","id":191366561,"user":{"login":"grypyrg","id":1330700,"avatar_url":"https://avatars.githubusercontent.com/u/1330700?v=3","gravatar_id":"","url":"https://api.github.com/users/grypyrg","html_url":"https://github.com/grypyrg","followers_url":"https://api.github.com/users/grypyrg/followers","following_url":"https://api.github.com/users/grypyrg/following{/other_user}","gists_url":"https://api.github.com/users/grypyrg/gists{/gist_id}","starred_url":"https://api.github.com/users/grypyrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grypyrg/subscriptions","organizations_url":"https://api.github.com/users/grypyrg/orgs","repos_url":"https://api.github.com/users/grypyrg/repos","events_url":"https://api.github.com/users/grypyrg/events{/privacy}","received_events_url":"https://api.github.com/users/grypyrg/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T18:42:04Z","updated_at":"2016-03-02T18:42:04Z","body":"@Jmainguy : yes, any `user_mod`, `user_delete` should have this too. I wrote it originally to disable binary logging just after the connection is created.\r\nThe rebase that was pushed here does not, it only does it in `user_add`\r\n\r\nAlso, if I quickly check the code that you wrote, you basically disable binary logging by default, when it's set to `True`.\r\nhttps://github.com/Jmainguy/ansible-modules-core/commit/367f8d0b4d08b88247fbdc0477c20b2eaf62f183#diff-b4dbfbaa641f4d515d58a88ce227a981R231\r\n\r\n```\r\n +    if sql_log_bin:\r\n +        cursor.execute(\"SET SQL_LOG_BIN=0;\")\r\n +\r\n```\r\n\r\n It should be the other way around, if `sql_log_bin is false`, then we set `SQL_LOG_BIN=0`"}}