{"action":"created","issue":{"url":"https://api.github.com/repos/amiga-mui/thebar/issues/5","repository_url":"https://api.github.com/repos/amiga-mui/thebar","labels_url":"https://api.github.com/repos/amiga-mui/thebar/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/amiga-mui/thebar/issues/5/comments","events_url":"https://api.github.com/repos/amiga-mui/thebar/issues/5/events","html_url":"https://github.com/amiga-mui/thebar/issues/5","id":152051749,"number":5,"title":"Improve graying out algorithm for toolbars with no explicit disabled images","user":{"login":"softwarefailure","id":6772528,"avatar_url":"https://avatars.githubusercontent.com/u/6772528?v=3","gravatar_id":"","url":"https://api.github.com/users/softwarefailure","html_url":"https://github.com/softwarefailure","followers_url":"https://api.github.com/users/softwarefailure/followers","following_url":"https://api.github.com/users/softwarefailure/following{/other_user}","gists_url":"https://api.github.com/users/softwarefailure/gists{/gist_id}","starred_url":"https://api.github.com/users/softwarefailure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softwarefailure/subscriptions","organizations_url":"https://api.github.com/users/softwarefailure/orgs","repos_url":"https://api.github.com/users/softwarefailure/repos","events_url":"https://api.github.com/users/softwarefailure/events{/privacy}","received_events_url":"https://api.github.com/users/softwarefailure/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-30T20:46:26Z","updated_at":"2016-05-02T16:23:03Z","closed_at":null,"body":"When creating a toolbar which doesn't specify separate images for disabled buttons, the standard \"graying out\" algorithm used by TheBar doesn't look so attractive. See here:\r\n\r\n![os4](https://cloud.githubusercontent.com/assets/6772528/14938481/316ae788-0f25-11e6-94e2-4c66122e81d3.png)\r\n\r\nIMHO it would be nicer to use a different algorithm that converts the icon to grayscale or something like that. The current algorithm doesn't look so nice for alphachannel images. It was probably designed for palette based graphics."},"comment":{"url":"https://api.github.com/repos/amiga-mui/thebar/issues/comments/216283296","html_url":"https://github.com/amiga-mui/thebar/issues/5#issuecomment-216283296","issue_url":"https://api.github.com/repos/amiga-mui/thebar/issues/5","id":216283296,"user":{"login":"softwarefailure","id":6772528,"avatar_url":"https://avatars.githubusercontent.com/u/6772528?v=3","gravatar_id":"","url":"https://api.github.com/users/softwarefailure","html_url":"https://github.com/softwarefailure","followers_url":"https://api.github.com/users/softwarefailure/followers","following_url":"https://api.github.com/users/softwarefailure/following{/other_user}","gists_url":"https://api.github.com/users/softwarefailure/gists{/gist_id}","starred_url":"https://api.github.com/users/softwarefailure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softwarefailure/subscriptions","organizations_url":"https://api.github.com/users/softwarefailure/orgs","repos_url":"https://api.github.com/users/softwarefailure/repos","events_url":"https://api.github.com/users/softwarefailure/events{/privacy}","received_events_url":"https://api.github.com/users/softwarefailure/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T16:23:03Z","updated_at":"2016-05-02T16:23:03Z","body":"If you have the ARGB data, it's really simple make disabled images. You could just mix 50% white into the data, or 50% black or convert the color channels to grey and then darken it a little. Here is a case study quickly made in Hollywood:\r\n\r\n![study](https://cloud.githubusercontent.com/assets/6772528/14959969/8c3d426e-1092-11e6-9b84-594c8b2cc5ef.png)\r\n\r\nI think each of the three looks better than the current algorithm. Of course, there is no perfect algorithm, e.g. the algorithms based on blackening won't look significantly different from toolbar images which are already mostly grey while the whitening one won't look so good on images which are mostly white.\r\n\r\nThere is no perfect generic solution so people who really care should use custom images for the disabled state. Still, I think that the current algorithm is really ugly and should use an enhancement, e.g. one from the ones presented above or your custom idea...\r\n"}}