{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/92043231","pull_request_review_id":12552679,"id":92043231,"diff_hunk":"@@ -435,6 +464,24 @@ func (cc *ClientConn) lbWatcher() {\n \t}\n }\n \n+func (cc *ClientConn) scWatcher() {\n+\tfor {\n+\t\tselect {\n+\t\tcase sc, ok := <-cc.dopts.sc:\n+\t\t\tif !ok {\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tcc.mu.Lock()\n+\t\t\t// TODO: load balance policy runtime change is ignored.","path":"clientconn.go","position":138,"original_position":123,"commit_id":"5dd7b302f1a75ddbc186fb7560c8d3b01c9e33b2","original_commit_id":"d5433c8e6a3effce84ebf6b334f318a42e0634d9","user":{"login":"markdroth","id":18664614,"avatar_url":"https://avatars.githubusercontent.com/u/18664614?v=3","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"body":"We should definitely fix this (although it doesn't need to be part of this PR).  We need to support the case where (e.g.) a server name switches from pick_first to grpclb (or vice-versa).","created_at":"2016-12-12T21:23:28Z","updated_at":"2016-12-12T21:30:10Z","html_url":"https://github.com/grpc/grpc-go/pull/1009#discussion_r92043231","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1009","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/92043231"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1009#discussion_r92043231"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1009"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/1009","id":96365761,"html_url":"https://github.com/grpc/grpc-go/pull/1009","diff_url":"https://github.com/grpc/grpc-go/pull/1009.diff","patch_url":"https://github.com/grpc/grpc-go/pull/1009.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/1009","number":1009,"state":"open","locked":false,"title":"Add the initial service config support","user":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"body":"The overview will be published in grpc/grpc shortly.","created_at":"2016-12-02T22:40:19Z","updated_at":"2016-12-12T21:30:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3353ca33ec90f3d8a803fcd634d6b269a51984b","assignee":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"assignees":[{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1009/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1009/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/1009/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/5dd7b302f1a75ddbc186fb7560c8d3b01c9e33b2","head":{"label":"iamqizhao:sc","ref":"sc","sha":"5dd7b302f1a75ddbc186fb7560c8d3b01c9e33b2","user":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"repo":{"id":31390988,"name":"grpc-go","full_name":"iamqizhao/grpc-go","owner":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamqizhao/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/iamqizhao/grpc-go","forks_url":"https://api.github.com/repos/iamqizhao/grpc-go/forks","keys_url":"https://api.github.com/repos/iamqizhao/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamqizhao/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamqizhao/grpc-go/teams","hooks_url":"https://api.github.com/repos/iamqizhao/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/iamqizhao/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/iamqizhao/grpc-go/events","assignees_url":"https://api.github.com/repos/iamqizhao/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/iamqizhao/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/iamqizhao/grpc-go/tags","blobs_url":"https://api.github.com/repos/iamqizhao/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamqizhao/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamqizhao/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamqizhao/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamqizhao/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/iamqizhao/grpc-go/languages","stargazers_url":"https://api.github.com/repos/iamqizhao/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/iamqizhao/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/iamqizhao/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/iamqizhao/grpc-go/subscription","commits_url":"https://api.github.com/repos/iamqizhao/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamqizhao/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamqizhao/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamqizhao/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamqizhao/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/iamqizhao/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamqizhao/grpc-go/merges","archive_url":"https://api.github.com/repos/iamqizhao/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamqizhao/grpc-go/downloads","issues_url":"https://api.github.com/repos/iamqizhao/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/iamqizhao/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/iamqizhao/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/iamqizhao/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamqizhao/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/iamqizhao/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/iamqizhao/grpc-go/deployments","created_at":"2015-02-26T21:58:15Z","updated_at":"2016-10-24T22:29:42Z","pushed_at":"2016-12-12T21:28:18Z","git_url":"git://github.com/iamqizhao/grpc-go.git","ssh_url":"git@github.com:iamqizhao/grpc-go.git","clone_url":"https://github.com/iamqizhao/grpc-go.git","svn_url":"https://github.com/iamqizhao/grpc-go","homepage":"","size":2638,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"708a7f9f3283aa2d4f6132d287d78683babe55c8","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-12-12T20:40:13Z","pushed_at":"2016-12-12T21:28:19Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":3967,"stargazers_count":2625,"watchers_count":2625,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":441,"mirror_url":null,"open_issues_count":120,"forks":441,"open_issues":120,"watchers":2625,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1009"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1009"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1009"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1009/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1009/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1009/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/5dd7b302f1a75ddbc186fb7560c8d3b01c9e33b2"}}}}
{"actor":{"display_login":"markdroth"}}