{"action":"created","issue":{"url":"https://api.github.com/repos/landlab/landlab/issues/327","repository_url":"https://api.github.com/repos/landlab/landlab","labels_url":"https://api.github.com/repos/landlab/landlab/issues/327/labels{/name}","comments_url":"https://api.github.com/repos/landlab/landlab/issues/327/comments","events_url":"https://api.github.com/repos/landlab/landlab/issues/327/events","html_url":"https://github.com/landlab/landlab/pull/327","id":154891073,"number":327,"title":"Remove usages of deprecated functions","user":{"login":"mcflugen","id":6618196,"avatar_url":"https://avatars.githubusercontent.com/u/6618196?v=3","gravatar_id":"","url":"https://api.github.com/users/mcflugen","html_url":"https://github.com/mcflugen","followers_url":"https://api.github.com/users/mcflugen/followers","following_url":"https://api.github.com/users/mcflugen/following{/other_user}","gists_url":"https://api.github.com/users/mcflugen/gists{/gist_id}","starred_url":"https://api.github.com/users/mcflugen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcflugen/subscriptions","organizations_url":"https://api.github.com/users/mcflugen/orgs","repos_url":"https://api.github.com/users/mcflugen/repos","events_url":"https://api.github.com/users/mcflugen/events{/privacy}","received_events_url":"https://api.github.com/users/mcflugen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/landlab/landlab/milestones/2","html_url":"https://github.com/landlab/landlab/milestones/1.0","labels_url":"https://api.github.com/repos/landlab/landlab/milestones/2/labels","id":1672928,"number":2,"title":"1.0","description":"The landlab 1.0 release.","creator":{"login":"mcflugen","id":6618196,"avatar_url":"https://avatars.githubusercontent.com/u/6618196?v=3","gravatar_id":"","url":"https://api.github.com/users/mcflugen","html_url":"https://github.com/mcflugen","followers_url":"https://api.github.com/users/mcflugen/followers","following_url":"https://api.github.com/users/mcflugen/following{/other_user}","gists_url":"https://api.github.com/users/mcflugen/gists{/gist_id}","starred_url":"https://api.github.com/users/mcflugen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcflugen/subscriptions","organizations_url":"https://api.github.com/users/mcflugen/orgs","repos_url":"https://api.github.com/users/mcflugen/repos","events_url":"https://api.github.com/users/mcflugen/events{/privacy}","received_events_url":"https://api.github.com/users/mcflugen/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2016-03-29T22:31:12Z","updated_at":"2016-05-15T05:21:14Z","due_on":"2016-04-30T06:00:00Z","closed_at":null},"comments":13,"created_at":"2016-05-15T05:21:14Z","updated_at":"2016-05-15T17:25:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/landlab/landlab/pulls/327","html_url":"https://github.com/landlab/landlab/pull/327","diff_url":"https://github.com/landlab/landlab/pull/327.diff","patch_url":"https://github.com/landlab/landlab/pull/327.patch"},"body":"This pull request removes usages of many (but not all) deprecated functions/methods. Most of the remaining usages are either private methods, in doctests for the deprecated functions themselves, or not straightforward to convert to an alternative.\r\n\r\nNote that in this pull request I have disabled warnings for methods that start with an underscore. This can easily be turned back on.\r\n\r\n@SiccarPoint: One problem I had was with active links. The `active_links` attribute doesn't seem to ever include active *diagonal* links. This is a problem when replacing `grid.calc_grad_at_active_link()` with `calc_grad_at_link()[grid.active_links]`.\r\n\r\n@saisiddu: In the radiation component when I switched from,\r\n```python\r\nself._slope, self._aspect = grid.calculate_slope_aspect_at_nodes_burrough(vals='topographic__elevation')\r\n```\r\nto\r\n```python\r\nelevation = grid.at_node['topographic__elevation']\r\nself._slope = grid.calc_slope_at_node(elevs=elevation)[grid.core_nodes]\r\nself._aspect = np.radians(grid.calc_aspect_at_node(elevs=elevation)[grid.core_nodes])\r\n```\r\nI got slightly different results so I stuck with the original. I still would like to figure out what's going on there. Do you have any ideas?"},"comment":{"url":"https://api.github.com/repos/landlab/landlab/issues/comments/219298748","html_url":"https://github.com/landlab/landlab/pull/327#issuecomment-219298748","issue_url":"https://api.github.com/repos/landlab/landlab/issues/327","id":219298748,"user":{"login":"SiccarPoint","id":6867260,"avatar_url":"https://avatars.githubusercontent.com/u/6867260?v=3","gravatar_id":"","url":"https://api.github.com/users/SiccarPoint","html_url":"https://github.com/SiccarPoint","followers_url":"https://api.github.com/users/SiccarPoint/followers","following_url":"https://api.github.com/users/SiccarPoint/following{/other_user}","gists_url":"https://api.github.com/users/SiccarPoint/gists{/gist_id}","starred_url":"https://api.github.com/users/SiccarPoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiccarPoint/subscriptions","organizations_url":"https://api.github.com/users/SiccarPoint/orgs","repos_url":"https://api.github.com/users/SiccarPoint/repos","events_url":"https://api.github.com/users/SiccarPoint/events{/privacy}","received_events_url":"https://api.github.com/users/SiccarPoint/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T17:25:52Z","updated_at":"2016-05-15T17:25:52Z","body":"Yesssssss\n\n\n> On 15 May 2016, at 11:14, Eric Hutton <notifications@github.com> wrote:\n> \n> Oh sure! By suppressing their warnings!\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub <https://github.com/landlab/landlab/pull/327#issuecomment-219298136>\n\n"}}