{"action":"created","issue":{"url":"https://api.github.com/repos/johndyer/mediaelement/issues/1878","repository_url":"https://api.github.com/repos/johndyer/mediaelement","labels_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1878/labels{/name}","comments_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1878/comments","events_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1878/events","html_url":"https://github.com/johndyer/mediaelement/pull/1878","id":182549558,"number":1878,"title":"Jshint and remove whitespace","user":{"login":"albell","id":1142025,"avatar_url":"https://avatars.githubusercontent.com/u/1142025?v=3","gravatar_id":"","url":"https://api.github.com/users/albell","html_url":"https://github.com/albell","followers_url":"https://api.github.com/users/albell/followers","following_url":"https://api.github.com/users/albell/following{/other_user}","gists_url":"https://api.github.com/users/albell/gists{/gist_id}","starred_url":"https://api.github.com/users/albell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albell/subscriptions","organizations_url":"https://api.github.com/users/albell/orgs","repos_url":"https://api.github.com/users/albell/repos","events_url":"https://api.github.com/users/albell/events{/privacy}","received_events_url":"https://api.github.com/users/albell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-12T15:01:38Z","updated_at":"2016-10-12T19:08:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1878","html_url":"https://github.com/johndyer/mediaelement/pull/1878","diff_url":"https://github.com/johndyer/mediaelement/pull/1878.diff","patch_url":"https://github.com/johndyer/mediaelement/pull/1878.patch"},"body":"Being new here, I'm having trouble figuring out my mistakes in my BEM branch. Let's take a more incremental approach? This PR adds jshint and removes all trailing whitespace from the player source files, a good step overall I think. Notice that when you grunt now you will get \"128 errors in 60 files\". Some of these are obvious fixes. Some I'm not sure about the assumptions being made in the existing code, and I'm hesitant to make changes. Can you audit these?\r\n\r\nAlso, totally separately, when I run `grunt html5only` it puts lots of new PNGs in the build folder. These obviously aren't gitignore'd, and I haven't touched them so I don't want to commit them. I wind up stashing them each time I build, to get rid of them. Tedious. Is this the expected build behavior?"},"comment":{"url":"https://api.github.com/repos/johndyer/mediaelement/issues/comments/253308444","html_url":"https://github.com/johndyer/mediaelement/pull/1878#issuecomment-253308444","issue_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1878","id":253308444,"user":{"login":"albell","id":1142025,"avatar_url":"https://avatars.githubusercontent.com/u/1142025?v=3","gravatar_id":"","url":"https://api.github.com/users/albell","html_url":"https://github.com/albell","followers_url":"https://api.github.com/users/albell/followers","following_url":"https://api.github.com/users/albell/following{/other_user}","gists_url":"https://api.github.com/users/albell/gists{/gist_id}","starred_url":"https://api.github.com/users/albell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albell/subscriptions","organizations_url":"https://api.github.com/users/albell/orgs","repos_url":"https://api.github.com/users/albell/repos","events_url":"https://api.github.com/users/albell/events{/privacy}","received_events_url":"https://api.github.com/users/albell/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T19:08:34Z","updated_at":"2016-10-12T19:08:34Z","body":"I am out all day. Deadlines. I can do tmrw. Or you can just commit similar?"}}
{"actor":{"display_login":"albell"}}