{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10009","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10009/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10009/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10009/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10009","id":183231516,"number":10009,"title":"sql: Persist DB names to view descriptors with new Format flag","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-15T20:34:28Z","updated_at":"2016-10-16T15:39:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10009","html_url":"https://github.com/cockroachdb/cockroach/pull/10009","diff_url":"https://github.com/cockroachdb/cockroach/pull/10009.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10009.patch"},"body":"We don't have to go this way, but as explained in the comment thread on https://github.com/cockroachdb/cockroach/issues/9921#issuecomment-254009800, this was enough easier than trying to adapt Walk that I thought it was worth putting together as a proof of concept, at the very least.\r\n\r\n@knz\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10009)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/254054175","html_url":"https://github.com/cockroachdb/cockroach/pull/10009#issuecomment-254054175","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10009","id":254054175,"user":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T15:39:51Z","updated_at":"2016-10-16T15:39:51Z","body":"Wow, color me amazed. This is a rather nifty/elegant trick. Congrats on getting this to work with such a minimal-but-yet-rather-smart change.\n\n<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReviewed 6 of 6 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.\n\n---\n\n*[pkg/sql/create.go, line 934 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/10009#-KUD8Da0BFk_qBOV2YsU:-KUD8Da0BFk_qBOV2YsV:b9hj7kv) ([raw file](https://github.com/cockroachdb/cockroach/blob/63d49ca328a9b07ffcb96d1b555a2784cd605d15/pkg/sql/create.go#L934)):*\n> ```Go\n> \t\t\ttn, err := n.p.QualifyWithDatabase(t)\n> \t\t\tif err != nil {\n> \t\t\t\tlog.Warningf(n.p.ctx(), \"Failed to qualify table name %q with database name: %v\", t, err)\n> ```\n\nfor consistency, use small letter \"f\" at the start of the message.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/10009#-:-KUD84HeDtodQXagx0WM:b1s6ilv)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"knz"}}