{"action":"created","issue":{"url":"https://api.github.com/repos/Selz/plyr/issues/382","repository_url":"https://api.github.com/repos/Selz/plyr","labels_url":"https://api.github.com/repos/Selz/plyr/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/Selz/plyr/issues/382/comments","events_url":"https://api.github.com/repos/Selz/plyr/issues/382/events","html_url":"https://github.com/Selz/plyr/issues/382","id":179864652,"number":382,"title":"Documentation on the 'Vimeo Hack'","user":{"login":"zamiang","id":110563,"avatar_url":"https://avatars.githubusercontent.com/u/110563?v=3","gravatar_id":"","url":"https://api.github.com/users/zamiang","html_url":"https://github.com/zamiang","followers_url":"https://api.github.com/users/zamiang/followers","following_url":"https://api.github.com/users/zamiang/following{/other_user}","gists_url":"https://api.github.com/users/zamiang/gists{/gist_id}","starred_url":"https://api.github.com/users/zamiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamiang/subscriptions","organizations_url":"https://api.github.com/users/zamiang/orgs","repos_url":"https://api.github.com/users/zamiang/repos","events_url":"https://api.github.com/users/zamiang/events{/privacy}","received_events_url":"https://api.github.com/users/zamiang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-28T19:26:45Z","updated_at":"2016-09-28T22:27:10Z","closed_at":null,"body":"I am currently trying to support some vertical and square videos from Vimeo. \r\n\r\nIt looks like I will need to set some of the 'vimeo hack' attributes manually (since they are setup for 16:9 videos). But I don't understand where these magic numbers come from:\r\n```\r\n    > div {\r\n        position: relative;\r\n        padding-bottom: 200%;\r\n        transform: translateY(-35.95%);\r\n    }\r\n```\r\nhttps://github.com/Selz/plyr/blob/a318e8588ba9b48d0c13cd573455695bd3bb0678/src/scss/plyr.scss#L197\r\n\r\nThere should likely be some documentation around what brought about those particular numbers.\r\n"},"comment":{"url":"https://api.github.com/repos/Selz/plyr/issues/comments/250319985","html_url":"https://github.com/Selz/plyr/issues/382#issuecomment-250319985","issue_url":"https://api.github.com/repos/Selz/plyr/issues/382","id":250319985,"user":{"login":"SamPotts","id":719092,"avatar_url":"https://avatars.githubusercontent.com/u/719092?v=3","gravatar_id":"","url":"https://api.github.com/users/SamPotts","html_url":"https://github.com/SamPotts","followers_url":"https://api.github.com/users/SamPotts/followers","following_url":"https://api.github.com/users/SamPotts/following{/other_user}","gists_url":"https://api.github.com/users/SamPotts/gists{/gist_id}","starred_url":"https://api.github.com/users/SamPotts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamPotts/subscriptions","organizations_url":"https://api.github.com/users/SamPotts/orgs","repos_url":"https://api.github.com/users/SamPotts/repos","events_url":"https://api.github.com/users/SamPotts/events{/privacy}","received_events_url":"https://api.github.com/users/SamPotts/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T22:27:10Z","updated_at":"2016-09-28T22:27:10Z","body":"They were the numbers which worked really - from trial and error. The common method of achieving 16:9 ratio for the iframe embeds is with padding-bottom: 56.25% but that would have meant the controls were visible. Vimeo decided that hiding the controls by with a flag is a \"premium\" feature (you need a Pro account) yet YouTube just allows it. It's not ideal both technically and ethically (getting around their limitation) I suppose, but it works. "}}
{"actor":{"display_login":"SamPotts"}}