{"action":"created","issue":{"url":"https://api.github.com/repos/getgauge/gauge-java/issues/74","repository_url":"https://api.github.com/repos/getgauge/gauge-java","labels_url":"https://api.github.com/repos/getgauge/gauge-java/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/getgauge/gauge-java/issues/74/comments","events_url":"https://api.github.com/repos/getgauge/gauge-java/issues/74/events","html_url":"https://github.com/getgauge/gauge-java/pull/74","id":186090055,"number":74,"title":"Support failing cases","user":{"login":"boazberman","id":14139261,"avatar_url":"https://avatars.githubusercontent.com/u/14139261?v=3","gravatar_id":"","url":"https://api.github.com/users/boazberman","html_url":"https://github.com/boazberman","followers_url":"https://api.github.com/users/boazberman/followers","following_url":"https://api.github.com/users/boazberman/following{/other_user}","gists_url":"https://api.github.com/users/boazberman/gists{/gist_id}","starred_url":"https://api.github.com/users/boazberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boazberman/subscriptions","organizations_url":"https://api.github.com/users/boazberman/orgs","repos_url":"https://api.github.com/users/boazberman/repos","events_url":"https://api.github.com/users/boazberman/events{/privacy}","received_events_url":"https://api.github.com/users/boazberman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-29T17:22:44Z","updated_at":"2016-11-10T05:50:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getgauge/gauge-java/pulls/74","html_url":"https://github.com/getgauge/gauge-java/pull/74","diff_url":"https://github.com/getgauge/gauge-java/pull/74.diff","patch_url":"https://github.com/getgauge/gauge-java/pull/74.patch"},"body":"As described in Ref #70 :\n# Buy\n## Clothes\n- Buy a \"red\" shirt\n## Another\n- Buy a \"\" shirt\n\nWill now provide the proper error message.\n"},"comment":{"url":"https://api.github.com/repos/getgauge/gauge-java/issues/comments/259607166","html_url":"https://github.com/getgauge/gauge-java/pull/74#issuecomment-259607166","issue_url":"https://api.github.com/repos/getgauge/gauge-java/issues/74","id":259607166,"user":{"login":"mahendrakariya","id":2538874,"avatar_url":"https://avatars.githubusercontent.com/u/2538874?v=3","gravatar_id":"","url":"https://api.github.com/users/mahendrakariya","html_url":"https://github.com/mahendrakariya","followers_url":"https://api.github.com/users/mahendrakariya/followers","following_url":"https://api.github.com/users/mahendrakariya/following{/other_user}","gists_url":"https://api.github.com/users/mahendrakariya/gists{/gist_id}","starred_url":"https://api.github.com/users/mahendrakariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahendrakariya/subscriptions","organizations_url":"https://api.github.com/users/mahendrakariya/orgs","repos_url":"https://api.github.com/users/mahendrakariya/repos","events_url":"https://api.github.com/users/mahendrakariya/events{/privacy}","received_events_url":"https://api.github.com/users/mahendrakariya/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T05:50:25Z","updated_at":"2016-11-10T05:50:25Z","body":"@boazberman We follow Sun Coding standards, with a few minor changes. To enforce coding standards for the project, we have added [`checkstyle.xml`](https://github.com/getgauge/gauge-java/blob/master/checkstyle.xml) file to the repo, which is forked from [`checkstyle/sun_checks.xml`](https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml). We have also integrated style audit with the build life cycle. \r\n\r\nOn your machine, you can use the [Eclipse Checkstyle plugin](http://eclipse-cs.sourceforge.net/#!/) and configure it to pick the styles from `checkstyle.xml`. This will ensure that Eclipse formats the code based on these styles.\r\n\r\nIf you have some suggestions for the coding standards, feel free to send us a PR with relevant changes in `checkstyle.xml`.\r\n\r\n> a new exception type, but that would be in contrast to your code standard\r\n\r\nWe haven't enforced any coding standards for catching `Exception` as of now. But in general, catching a generic `Exception` type is a bad practice. There are a few such try/catch blocks in the codebase, which is a tech debt and it needs to be cleaned up.\r\n\r\n> I would be thrilled to wrap all of the code in a new exception type\r\n\r\nCould you give us more details about this? What is the new exception type you are thinking about and what all would be wrapped in it? If the proposal is promising, we will be more than happy to implement it.\r\n\r\n> The method StepExecutionStage.executeStepMethod is huge and requires a refactor\r\n\r\nTotally agree! Would you like to take a stab at refactoring it?\r\n"}}
{"actor":{"display_login":"mahendrakariya"}}