{"action":"closed","issue":{"url":"https://api.github.com/repos/MooveAgency/MooveProtectionPlugin/issues/4","labels_url":"https://api.github.com/repos/MooveAgency/MooveProtectionPlugin/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/MooveAgency/MooveProtectionPlugin/issues/4/comments","events_url":"https://api.github.com/repos/MooveAgency/MooveProtectionPlugin/issues/4/events","html_url":"https://github.com/MooveAgency/MooveProtectionPlugin/issues/4","id":126867781,"number":4,"title":"WordPress PHP Coding Standards?","user":{"login":"david-binda","id":3651036,"avatar_url":"https://avatars.githubusercontent.com/u/3651036?v=3","gravatar_id":"","url":"https://api.github.com/users/david-binda","html_url":"https://github.com/david-binda","followers_url":"https://api.github.com/users/david-binda/followers","following_url":"https://api.github.com/users/david-binda/following{/other_user}","gists_url":"https://api.github.com/users/david-binda/gists{/gist_id}","starred_url":"https://api.github.com/users/david-binda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-binda/subscriptions","organizations_url":"https://api.github.com/users/david-binda/orgs","repos_url":"https://api.github.com/users/david-binda/repos","events_url":"https://api.github.com/users/david-binda/events{/privacy}","received_events_url":"https://api.github.com/users/david-binda/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-01-15T12:59:50Z","updated_at":"2016-01-26T13:56:23Z","closed_at":"2016-01-26T13:56:23Z","body":"I do always wonder what leads developers to not following the WordPress PHP Coding Standards.\r\n\r\nhttps://make.wordpress.org/core/handbook/best-practices/coding-standards/php/\r\n\r\nNamely using CameCase (all plugin's classes and their methods are using CameCase notation):\r\n\r\n> Use lowercase letters in variable, action, and function names (never camelCase).\r\n\r\nThis plugin also suffers not only from not following the declared whitespace conventions, but there are also inconsistencies inside a single functions. Eg: https://github.com/MooveAgency/MooveProtectionPlugin/blob/master/moove-content.php#L34,L46\r\n\r\nThere are also indendation issues. For instance: https://github.com/MooveAgency/MooveProtectionPlugin/blob/master/moove-options.php#L180 or https://github.com/MooveAgency/MooveProtectionPlugin/blob/master/moove-controller.php\r\n\r\nFurther, there is no consistency in using brackets in function declarations:\r\n\r\n```\r\nfunction registerContentElements()\r\n\t{\r\n```\r\n\r\nvs. \r\n\r\n```\r\nfunction moove_add_protection_modal() {\r\n```\r\n\r\nThis makes the code really hard to read.\r\n\r\nWe've got a lot of neat tools nowadays, which makes developer’s and team’s live much easier:\r\n\r\n* https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards\r\n* https://github.com/Automattic/PhpStorm-Resources\r\n"}}