{"action":"closed","number":1556,"pull_request":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1556","id":94294853,"html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1556","diff_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1556.diff","patch_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1556.patch","issue_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1556","number":1556,"state":"closed","locked":false,"title":"Reduced and improved the requests to emulate an actual API call (as an app would)","user":{"login":"chowderchow","id":16789070,"avatar_url":"https://avatars.githubusercontent.com/u/16789070?v=3","gravatar_id":"","url":"https://api.github.com/users/chowderchow","html_url":"https://github.com/chowderchow","followers_url":"https://api.github.com/users/chowderchow/followers","following_url":"https://api.github.com/users/chowderchow/following{/other_user}","gists_url":"https://api.github.com/users/chowderchow/gists{/gist_id}","starred_url":"https://api.github.com/users/chowderchow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowderchow/subscriptions","organizations_url":"https://api.github.com/users/chowderchow/orgs","repos_url":"https://api.github.com/users/chowderchow/repos","events_url":"https://api.github.com/users/chowderchow/events{/privacy}","received_events_url":"https://api.github.com/users/chowderchow/received_events","type":"User","site_admin":false},"body":"## Description\r\n***IMPORTANT\r\nYou will need to enable the elevation API here:***\r\nhttps://console.developers.google.com/apis/api/elevation_backend\r\n\r\n1. Instead of calling checkChallenge whenever 2 consecutive empty calls have been made, it's now scripted to check with every getMapObjects call. \r\n\r\n2. Modified map_request to mimic an actual request envelope as from an app \r\n\r\n3. Modified step_location to contain actual altitude\r\n\r\nPSEUDO-CODE FLOW:\r\n```\r\nreq = api.create_request()\r\nreq.check_challenge()\r\nreq.get_map_objects(...)\r\n...\r\nresponse = req.call()\r\nreturn response\r\n```\r\nThis will make only one API call, so no extra calls due to captcha checking as in the current implementation.\r\n\r\nAll the captcha flags are the same as before:\r\n```\r\n-cs --captcha-solving\r\n-ck --captcha-key\r\n-cds --captcha-datasitekey (OPTIONAL)\r\n```\r\n\r\n## Motivation and Context\r\nSome people were 'experiencing' a higher observed captcha rate while using the current map. I think it may be due to the extra check_challenge request every 2 consecutive empty scans and improper API calls.\r\n\r\n## How Has This Been Tested?\r\n\r\n## Screenshots (if appropriate):\r\n![image](https://cloud.githubusercontent.com/assets/16789070/20417126/30a48822-ad3b-11e6-9ad1-2605c0b7b754.png)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n","created_at":"2016-11-18T03:01:34Z","updated_at":"2016-11-20T10:56:33Z","closed_at":"2016-11-20T10:56:33Z","merged_at":null,"merge_commit_sha":"66d2cc5f826bf25a234942702066090252c1ab84","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/milestones/3","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/milestones/4.0.0","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/milestones/3/labels","id":1979345,"number":3,"title":"4.0.0","description":"","creator":{"login":"chuyskywalker","id":131800,"avatar_url":"https://avatars.githubusercontent.com/u/131800?v=3","gravatar_id":"","url":"https://api.github.com/users/chuyskywalker","html_url":"https://github.com/chuyskywalker","followers_url":"https://api.github.com/users/chuyskywalker/followers","following_url":"https://api.github.com/users/chuyskywalker/following{/other_user}","gists_url":"https://api.github.com/users/chuyskywalker/gists{/gist_id}","starred_url":"https://api.github.com/users/chuyskywalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuyskywalker/subscriptions","organizations_url":"https://api.github.com/users/chuyskywalker/orgs","repos_url":"https://api.github.com/users/chuyskywalker/repos","events_url":"https://api.github.com/users/chuyskywalker/events{/privacy}","received_events_url":"https://api.github.com/users/chuyskywalker/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":20,"state":"open","created_at":"2016-09-02T05:39:26Z","updated_at":"2016-11-20T10:56:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1556/commits","review_comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1556/comments","review_comment_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1556/comments","statuses_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/statuses/03344ad7e39f006344840ec9a7791799a32d8895","head":{"label":"chowderchow:develop","ref":"develop","sha":"03344ad7e39f006344840ec9a7791799a32d8895","user":{"login":"chowderchow","id":16789070,"avatar_url":"https://avatars.githubusercontent.com/u/16789070?v=3","gravatar_id":"","url":"https://api.github.com/users/chowderchow","html_url":"https://github.com/chowderchow","followers_url":"https://api.github.com/users/chowderchow/followers","following_url":"https://api.github.com/users/chowderchow/following{/other_user}","gists_url":"https://api.github.com/users/chowderchow/gists{/gist_id}","starred_url":"https://api.github.com/users/chowderchow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowderchow/subscriptions","organizations_url":"https://api.github.com/users/chowderchow/orgs","repos_url":"https://api.github.com/users/chowderchow/repos","events_url":"https://api.github.com/users/chowderchow/events{/privacy}","received_events_url":"https://api.github.com/users/chowderchow/received_events","type":"User","site_admin":false},"repo":{"id":70757885,"name":"PokemonGo-Map","full_name":"chowderchow/PokemonGo-Map","owner":{"login":"chowderchow","id":16789070,"avatar_url":"https://avatars.githubusercontent.com/u/16789070?v=3","gravatar_id":"","url":"https://api.github.com/users/chowderchow","html_url":"https://github.com/chowderchow","followers_url":"https://api.github.com/users/chowderchow/followers","following_url":"https://api.github.com/users/chowderchow/following{/other_user}","gists_url":"https://api.github.com/users/chowderchow/gists{/gist_id}","starred_url":"https://api.github.com/users/chowderchow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowderchow/subscriptions","organizations_url":"https://api.github.com/users/chowderchow/orgs","repos_url":"https://api.github.com/users/chowderchow/repos","events_url":"https://api.github.com/users/chowderchow/events{/privacy}","received_events_url":"https://api.github.com/users/chowderchow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chowderchow/PokemonGo-Map","description":"🌏 Live visualization of all the pokemon in your area... and more!","fork":true,"url":"https://api.github.com/repos/chowderchow/PokemonGo-Map","forks_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/forks","keys_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/teams","hooks_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/hooks","issue_events_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/issues/events{/number}","events_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/events","assignees_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/assignees{/user}","branches_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/branches{/branch}","tags_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/tags","blobs_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/git/refs{/sha}","trees_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/statuses/{sha}","languages_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/languages","stargazers_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/stargazers","contributors_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/contributors","subscribers_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/subscribers","subscription_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/subscription","commits_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/commits{/sha}","git_commits_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/git/commits{/sha}","comments_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/comments{/number}","issue_comment_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/issues/comments{/number}","contents_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/contents/{+path}","compare_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/merges","archive_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/downloads","issues_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/issues{/number}","pulls_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/pulls{/number}","milestones_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/milestones{/number}","notifications_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/labels{/name}","releases_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/releases{/id}","deployments_url":"https://api.github.com/repos/chowderchow/PokemonGo-Map/deployments","created_at":"2016-10-13T01:44:22Z","updated_at":"2016-11-20T03:30:24Z","pushed_at":"2016-11-20T10:52:35Z","git_url":"git://github.com/chowderchow/PokemonGo-Map.git","ssh_url":"git@github.com:chowderchow/PokemonGo-Map.git","clone_url":"https://github.com/chowderchow/PokemonGo-Map.git","svn_url":"https://github.com/chowderchow/PokemonGo-Map","homepage":"","size":24404,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"PokemonGoMap:develop","ref":"develop","sha":"3a48f5241ca0c98996fe4af08c428b325fdae2a1","user":{"login":"PokemonGoMap","id":20848202,"avatar_url":"https://avatars.githubusercontent.com/u/20848202?v=3","gravatar_id":"","url":"https://api.github.com/users/PokemonGoMap","html_url":"https://github.com/PokemonGoMap","followers_url":"https://api.github.com/users/PokemonGoMap/followers","following_url":"https://api.github.com/users/PokemonGoMap/following{/other_user}","gists_url":"https://api.github.com/users/PokemonGoMap/gists{/gist_id}","starred_url":"https://api.github.com/users/PokemonGoMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PokemonGoMap/subscriptions","organizations_url":"https://api.github.com/users/PokemonGoMap/orgs","repos_url":"https://api.github.com/users/PokemonGoMap/repos","events_url":"https://api.github.com/users/PokemonGoMap/events{/privacy}","received_events_url":"https://api.github.com/users/PokemonGoMap/received_events","type":"Organization","site_admin":false},"repo":{"id":64970925,"name":"PokemonGo-Map","full_name":"PokemonGoMap/PokemonGo-Map","owner":{"login":"PokemonGoMap","id":20848202,"avatar_url":"https://avatars.githubusercontent.com/u/20848202?v=3","gravatar_id":"","url":"https://api.github.com/users/PokemonGoMap","html_url":"https://github.com/PokemonGoMap","followers_url":"https://api.github.com/users/PokemonGoMap/followers","following_url":"https://api.github.com/users/PokemonGoMap/following{/other_user}","gists_url":"https://api.github.com/users/PokemonGoMap/gists{/gist_id}","starred_url":"https://api.github.com/users/PokemonGoMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PokemonGoMap/subscriptions","organizations_url":"https://api.github.com/users/PokemonGoMap/orgs","repos_url":"https://api.github.com/users/PokemonGoMap/repos","events_url":"https://api.github.com/users/PokemonGoMap/events{/privacy}","received_events_url":"https://api.github.com/users/PokemonGoMap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PokemonGoMap/PokemonGo-Map","description":"🌏 Live visualization of all the pokemon in your area... and more!","fork":false,"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map","forks_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/forks","keys_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/teams","hooks_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/hooks","issue_events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/events{/number}","events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/events","assignees_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/assignees{/user}","branches_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/branches{/branch}","tags_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/tags","blobs_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/refs{/sha}","trees_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/statuses/{sha}","languages_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/languages","stargazers_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/stargazers","contributors_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/contributors","subscribers_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/subscribers","subscription_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/subscription","commits_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/commits{/sha}","git_commits_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/commits{/sha}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/comments{/number}","issue_comment_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/comments{/number}","contents_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/contents/{+path}","compare_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/merges","archive_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/downloads","issues_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues{/number}","pulls_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls{/number}","milestones_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/milestones{/number}","notifications_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/labels{/name}","releases_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/releases{/id}","deployments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/deployments","created_at":"2016-08-04T22:18:49Z","updated_at":"2016-11-20T08:31:42Z","pushed_at":"2016-11-20T10:52:35Z","git_url":"git://github.com/PokemonGoMap/PokemonGo-Map.git","ssh_url":"git@github.com:PokemonGoMap/PokemonGo-Map.git","clone_url":"https://github.com/PokemonGoMap/PokemonGo-Map.git","svn_url":"https://github.com/PokemonGoMap/PokemonGo-Map","homepage":"","size":34317,"stargazers_count":2547,"watchers_count":2547,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1465,"mirror_url":null,"open_issues_count":211,"forks":1465,"open_issues":211,"watchers":2547,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1556"},"html":{"href":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1556"},"issue":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1556"},"comments":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1556/comments"},"review_comments":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1556/comments"},"review_comment":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1556/commits"},"statuses":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/statuses/03344ad7e39f006344840ec9a7791799a32d8895"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":18,"review_comments":0,"commits":30,"additions":54,"deletions":44,"changed_files":4}}
{"actor":{"display_login":"FrostTheFox"}}