{"action":"closed","number":6460,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/6460","id":62849506,"html_url":"https://github.com/facebook/react-native/pull/6460","diff_url":"https://github.com/facebook/react-native/pull/6460.diff","patch_url":"https://github.com/facebook/react-native/pull/6460.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/6460","number":6460,"state":"closed","locked":false,"title":"MapView annotations displayed is less than setted","user":{"login":"chieryw","id":6397941,"avatar_url":"https://avatars.githubusercontent.com/u/6397941?v=3","gravatar_id":"","url":"https://api.github.com/users/chieryw","html_url":"https://github.com/chieryw","followers_url":"https://api.github.com/users/chieryw/followers","following_url":"https://api.github.com/users/chieryw/following{/other_user}","gists_url":"https://api.github.com/users/chieryw/gists{/gist_id}","starred_url":"https://api.github.com/users/chieryw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chieryw/subscriptions","organizations_url":"https://api.github.com/users/chieryw/orgs","repos_url":"https://api.github.com/users/chieryw/repos","events_url":"https://api.github.com/users/chieryw/events{/privacy}","received_events_url":"https://api.github.com/users/chieryw/received_events","type":"User","site_admin":false},"body":"Show items in mapView,and change type by segmentControl.\r\nWhen changed selected，the different type items will show in mapView.\r\nBut,i found the item displayed is less than setted.\r\n\r\nProblems cropped up in RCTMapAnnotationView, the function of \r\n```\r\n- (void)setContentView:(UIView *)contentView\r\n{\r\n  [_contentView removeFromSuperview];\r\n  _contentView = contentView;\r\n  [self addSubview:_contentView];\r\n}\r\n```\r\n\r\nThe pointer of _contentView may be equal to the  pre added of contentView. When remove from superview,the pre added of contentView will be removed.\r\n\r\nFixed function is \r\n```\r\n- (void)setContentView:(UIView *)contentView\r\n{\r\n   while (self.subviews.count) {\r\n        UIView* child = self.subviews.lastObject;\r\n        [child removeFromSuperview];\r\n    }  \r\n\r\n  _contentView = contentView;\r\n  [self addSubview:content];\r\n}\r\n```","created_at":"2016-03-15T03:11:53Z","updated_at":"2016-09-09T10:01:58Z","closed_at":"2016-09-09T10:01:58Z","merged_at":null,"merge_commit_sha":"8b717cf595817fbda731aa2dc87306411e1d561a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/6460/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/6460/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/6460/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/c787ebd55a31ce1b6a0cf48693cb151800950cdd","head":{"label":"chieryw:master","ref":"master","sha":"c787ebd55a31ce1b6a0cf48693cb151800950cdd","user":{"login":"chieryw","id":6397941,"avatar_url":"https://avatars.githubusercontent.com/u/6397941?v=3","gravatar_id":"","url":"https://api.github.com/users/chieryw","html_url":"https://github.com/chieryw","followers_url":"https://api.github.com/users/chieryw/followers","following_url":"https://api.github.com/users/chieryw/following{/other_user}","gists_url":"https://api.github.com/users/chieryw/gists{/gist_id}","starred_url":"https://api.github.com/users/chieryw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chieryw/subscriptions","organizations_url":"https://api.github.com/users/chieryw/orgs","repos_url":"https://api.github.com/users/chieryw/repos","events_url":"https://api.github.com/users/chieryw/events{/privacy}","received_events_url":"https://api.github.com/users/chieryw/received_events","type":"User","site_admin":false},"repo":{"id":53851630,"name":"react-native","full_name":"chieryw/react-native","owner":{"login":"chieryw","id":6397941,"avatar_url":"https://avatars.githubusercontent.com/u/6397941?v=3","gravatar_id":"","url":"https://api.github.com/users/chieryw","html_url":"https://github.com/chieryw","followers_url":"https://api.github.com/users/chieryw/followers","following_url":"https://api.github.com/users/chieryw/following{/other_user}","gists_url":"https://api.github.com/users/chieryw/gists{/gist_id}","starred_url":"https://api.github.com/users/chieryw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chieryw/subscriptions","organizations_url":"https://api.github.com/users/chieryw/orgs","repos_url":"https://api.github.com/users/chieryw/repos","events_url":"https://api.github.com/users/chieryw/events{/privacy}","received_events_url":"https://api.github.com/users/chieryw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chieryw/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/chieryw/react-native","forks_url":"https://api.github.com/repos/chieryw/react-native/forks","keys_url":"https://api.github.com/repos/chieryw/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chieryw/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chieryw/react-native/teams","hooks_url":"https://api.github.com/repos/chieryw/react-native/hooks","issue_events_url":"https://api.github.com/repos/chieryw/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/chieryw/react-native/events","assignees_url":"https://api.github.com/repos/chieryw/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/chieryw/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/chieryw/react-native/tags","blobs_url":"https://api.github.com/repos/chieryw/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chieryw/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chieryw/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/chieryw/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chieryw/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/chieryw/react-native/languages","stargazers_url":"https://api.github.com/repos/chieryw/react-native/stargazers","contributors_url":"https://api.github.com/repos/chieryw/react-native/contributors","subscribers_url":"https://api.github.com/repos/chieryw/react-native/subscribers","subscription_url":"https://api.github.com/repos/chieryw/react-native/subscription","commits_url":"https://api.github.com/repos/chieryw/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/chieryw/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/chieryw/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/chieryw/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/chieryw/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/chieryw/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chieryw/react-native/merges","archive_url":"https://api.github.com/repos/chieryw/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chieryw/react-native/downloads","issues_url":"https://api.github.com/repos/chieryw/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/chieryw/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/chieryw/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/chieryw/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chieryw/react-native/labels{/name}","releases_url":"https://api.github.com/repos/chieryw/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/chieryw/react-native/deployments","created_at":"2016-03-14T11:42:25Z","updated_at":"2016-03-14T11:42:31Z","pushed_at":"2016-03-24T03:41:44Z","git_url":"git://github.com/chieryw/react-native.git","ssh_url":"git@github.com:chieryw/react-native.git","clone_url":"https://github.com/chieryw/react-native.git","svn_url":"https://github.com/chieryw/react-native","homepage":"http://facebook.github.io/react-native/","size":49332,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a72f45bb61662990a049c86cf5764c154e405767","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-09-09T09:55:54Z","pushed_at":"2016-09-09T08:54:34Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":129854,"stargazers_count":37379,"watchers_count":37379,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8248,"mirror_url":null,"open_issues_count":1205,"forks":8248,"open_issues":1205,"watchers":37379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6460"},"html":{"href":"https://github.com/facebook/react-native/pull/6460"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/6460"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/6460/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6460/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6460/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/c787ebd55a31ce1b6a0cf48693cb151800950cdd"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"commits":3,"additions":6,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"mkonicek"}}