{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/universal-search/issues/305","repository_url":"https://api.github.com/repos/mozilla/universal-search","labels_url":"https://api.github.com/repos/mozilla/universal-search/issues/305/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/universal-search/issues/305/comments","events_url":"https://api.github.com/repos/mozilla/universal-search/issues/305/events","html_url":"https://github.com/mozilla/universal-search/pull/305","id":173567474,"number":305,"title":"Disable one-off search buttons and simplify popup initialization","user":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/universal-search/labels/status:under%20review","name":"status:under review","color":"444444"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-27T00:27:19Z","updated_at":"2016-08-29T16:24:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/universal-search/pulls/305","html_url":"https://github.com/mozilla/universal-search/pull/305","diff_url":"https://github.com/mozilla/universal-search/pull/305.diff","patch_url":"https://github.com/mozilla/universal-search/pull/305.patch"},"body":"@chuckharmston, @0c0w3, mind taking a look? Commit message continues below:\r\n\r\n\r\nThis commit contains a small cluster of changes that jointly fix #286:\r\n\r\nConnecting the urlbar to the popup in an XBL constructor works far\r\nbetter than the old onFirstPopupOpen approach. This is a better way of\r\nfixing #138, and it resolves the 'maxRows - 1 is undefined' error.\r\n\r\nDisabling one-off search by disabling the pref and removing the one-off\r\nsearch buttons from the XUL DOM (via hidden=true) closes #292,\r\ncloses #293, closes #298--but those bugs aren't really fixed, just\r\nhidden. Filed #304 to re-enable one-off search as time allows. Note that\r\nthe disabletab attribute was added just to make the set of attributes in\r\nour one-off-search-buttons element match the element in FF.)\r\n\r\nSwitching our popup.js listener from the 'popupshowing' event to the\r\n'popupshown' event fixes #295, with some cascading changes related to\r\nrenaming the function and the signal fired by the function.\r\n\r\n\\o/"},"comment":{"url":"https://api.github.com/repos/mozilla/universal-search/issues/comments/243174925","html_url":"https://github.com/mozilla/universal-search/pull/305#issuecomment-243174925","issue_url":"https://api.github.com/repos/mozilla/universal-search/issues/305","id":243174925,"user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T16:24:14Z","updated_at":"2016-08-29T16:24:14Z","body":"I'm not super thrilled that the solution is to hide the one-off search buttons (mostly since we're kind of smothering the other place you can make one-off searches), but I trust your judgement that it would be much more challenging to try to work with it.\r\n\r\nCode looks good. I probably won't have a chance to test the code on my machine this week, so if you're comfortable, feel free to merge it and ship a new releases."}}
{"actor":{"display_login":"chuckharmston"}}