{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/83266574","pull_request_review_id":4121925,"id":83266574,"diff_hunk":"@@ -83,3 +83,105 @@ def impl(context):\n     row_count = getRows('template1', qry)[0][0]\n     if row_count != 1:\n         raise Exception('Expected mirror segment %s on host %s to be down, but it is running.' % (context.remote_mirror_datadir, context.remote_mirror_segdbname))\n+\n+@given('the mirror with content id \"{cid}\" is marked down in config')\n+@when('the mirror with content id \"{cid}\" is marked down in config')\n+@then('the mirror with content id \"{cid}\" is marked down in config')\n+def impl(context, cid):\n+    qry = \"\"\"select count(*) from gp_segment_configuration where status='d' and content='%s' and role='m'\"\"\" % (cid)\n+    row_count = getRows('template1', qry)[0][0]\n+    if row_count != 1:\n+        raise Exception('Expected mirror segment cid %s to be down, but it is up.' % cid)\n+\n+@given('user runs the command \"{cmd}\" on segment \"{cid}\"')\n+@when('user runs the command \"{cmd}\" on segment \"{cid}\"')\n+@then('user runs the command \"{cmd}\" on segment \"{cid}\"')\n+def impl(context, cmd, cid):\n+    dbid = getPrimaryDbIdFromCid(context, cid)\n+    cmdStr = '%s -s %s' % (cmd, int(dbid))\n+    cmd=Command(name='user command', cmdStr=cmdStr)\n+    cmd.run(validateAfter=True)\n+\n+@given('segment with content \"{cid}\" has persistent tables that were rebuilt with mirrors disabled')\n+@when('segment with content \"{cid}\" has persistent tables that were rebuilt with mirrors disabled')\n+@then('segment with content \"{cid}\" has persistent tables that were rebuilt with mirrors disabled')\n+def impl(context, cid):\n+    add_persistent_query = '''select\n+    gp_add_persistent_relation_node_entry(NULL,tablespace_oid, database_oid,\n+    relfilenode_oid, segment_file_num, relation_storage_manager,\n+    persistent_state,create_mirror_data_loss_tracking_session_num, '1',","path":"gpMgmt/bin/gppylib/test/behave/mgmt_utils/steps/recoverseg_mgmt_utils.py","position":null,"original_position":39,"commit_id":"38fad5b4a2f88c32293796027fe15ac289c686c3","original_commit_id":"64a5cd0cbea7e3027b4d8774c9dc1f04c62241a3","user":{"login":"chrishajas","id":1610524,"avatar_url":"https://avatars.githubusercontent.com/u/1610524?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"body":"Thanks, changed.","created_at":"2016-10-13T17:19:07Z","updated_at":"2016-10-13T17:19:07Z","html_url":"https://github.com/greenplum-db/gpdb/pull/1196#discussion_r83266574","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/83266574"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1196#discussion_r83266574"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196","id":88880860,"html_url":"https://github.com/greenplum-db/gpdb/pull/1196","diff_url":"https://github.com/greenplum-db/gpdb/pull/1196.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1196.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1196","number":1196,"state":"open","locked":false,"title":"gprecoverseg shouldn't recover segments with persistent mirroring dis…","user":{"login":"chrishajas","id":1610524,"avatar_url":"https://avatars.githubusercontent.com/u/1610524?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"body":"…abled\r\n\r\nIf a cluster with mirrors was rebuilt with the gp persistent rebuild tool without\r\nmirrors, catalog inconsistencies may be present. gprecoverseg should\r\nnot attempt to recover these segment, but should still recover segments\r\nwithout this inconsistency.\r\n\r\nAuthors: Chris Hajas, Chumki Roy, Karen Huddleston","created_at":"2016-10-11T18:01:58Z","updated_at":"2016-10-13T17:19:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3af976af3fba649e1364e7058f30488a3885b5e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1196/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/38fad5b4a2f88c32293796027fe15ac289c686c3","head":{"label":"chrishajas:gprecoverseg_id_no_mirrors","ref":"gprecoverseg_id_no_mirrors","sha":"38fad5b4a2f88c32293796027fe15ac289c686c3","user":{"login":"chrishajas","id":1610524,"avatar_url":"https://avatars.githubusercontent.com/u/1610524?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"repo":{"id":49305453,"name":"gpdb","full_name":"chrishajas/gpdb","owner":{"login":"chrishajas","id":1610524,"avatar_url":"https://avatars.githubusercontent.com/u/1610524?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrishajas/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/chrishajas/gpdb","forks_url":"https://api.github.com/repos/chrishajas/gpdb/forks","keys_url":"https://api.github.com/repos/chrishajas/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrishajas/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrishajas/gpdb/teams","hooks_url":"https://api.github.com/repos/chrishajas/gpdb/hooks","issue_events_url":"https://api.github.com/repos/chrishajas/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/chrishajas/gpdb/events","assignees_url":"https://api.github.com/repos/chrishajas/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/chrishajas/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/chrishajas/gpdb/tags","blobs_url":"https://api.github.com/repos/chrishajas/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrishajas/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrishajas/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrishajas/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrishajas/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/chrishajas/gpdb/languages","stargazers_url":"https://api.github.com/repos/chrishajas/gpdb/stargazers","contributors_url":"https://api.github.com/repos/chrishajas/gpdb/contributors","subscribers_url":"https://api.github.com/repos/chrishajas/gpdb/subscribers","subscription_url":"https://api.github.com/repos/chrishajas/gpdb/subscription","commits_url":"https://api.github.com/repos/chrishajas/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrishajas/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrishajas/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrishajas/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrishajas/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/chrishajas/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrishajas/gpdb/merges","archive_url":"https://api.github.com/repos/chrishajas/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrishajas/gpdb/downloads","issues_url":"https://api.github.com/repos/chrishajas/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/chrishajas/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/chrishajas/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/chrishajas/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrishajas/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/chrishajas/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/chrishajas/gpdb/deployments","created_at":"2016-01-09T01:11:36Z","updated_at":"2016-07-11T22:20:58Z","pushed_at":"2016-10-13T17:17:27Z","git_url":"git://github.com/chrishajas/gpdb.git","ssh_url":"git@github.com:chrishajas/gpdb.git","clone_url":"https://github.com/chrishajas/gpdb.git","svn_url":"https://github.com/chrishajas/gpdb","homepage":"http://greenplum.org","size":177546,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"ae90706bc5d273629fc92a49c70e85a5fc5e2caf","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-10-13T13:36:55Z","pushed_at":"2016-10-13T17:17:27Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":229997,"stargazers_count":1633,"watchers_count":1633,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":460,"mirror_url":null,"open_issues_count":120,"forks":460,"open_issues":120,"watchers":1633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1196"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1196"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1196/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1196/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/38fad5b4a2f88c32293796027fe15ac289c686c3"}}}}
{"actor":{"display_login":"chrishajas"}}