{"action":"created","issue":{"url":"https://api.github.com/repos/threatstream/scalaPSL/issues/1","repository_url":"https://api.github.com/repos/threatstream/scalaPSL","labels_url":"https://api.github.com/repos/threatstream/scalaPSL/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/threatstream/scalaPSL/issues/1/comments","events_url":"https://api.github.com/repos/threatstream/scalaPSL/issues/1/events","html_url":"https://github.com/threatstream/scalaPSL/pull/1","id":166394296,"number":1,"title":"Allow for domain to equal a Public Suffix","user":{"login":"cruzer911","id":1091926,"avatar_url":"https://avatars.githubusercontent.com/u/1091926?v=3","gravatar_id":"","url":"https://api.github.com/users/cruzer911","html_url":"https://github.com/cruzer911","followers_url":"https://api.github.com/users/cruzer911/followers","following_url":"https://api.github.com/users/cruzer911/following{/other_user}","gists_url":"https://api.github.com/users/cruzer911/gists{/gist_id}","starred_url":"https://api.github.com/users/cruzer911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruzer911/subscriptions","organizations_url":"https://api.github.com/users/cruzer911/orgs","repos_url":"https://api.github.com/users/cruzer911/repos","events_url":"https://api.github.com/users/cruzer911/events{/privacy}","received_events_url":"https://api.github.com/users/cruzer911/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/threatstream/scalaPSL/labels/bug","name":"bug","color":"ee0701"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-19T17:57:55Z","updated_at":"2016-07-19T18:24:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/threatstream/scalaPSL/pulls/1","html_url":"https://github.com/threatstream/scalaPSL/pull/1","diff_url":"https://github.com/threatstream/scalaPSL/pull/1.diff","patch_url":"https://github.com/threatstream/scalaPSL/pull/1.patch"},"body":"<a href=\"https://threatstream.atlassian.net/browse/LABS-2272\">Jira</a>\r\n\r\nThis library fails a domain if it equals a public suffix list exactly.\r\nFor example, `getPublicSuffix(\"ac.id\")` would return `None` even though `ac.id` is a valid public suffix. However, if would pass something like - `x.ac.id`. \r\n\r\nThis pr fixes this.\r\n"},"comment":{"url":"https://api.github.com/repos/threatstream/scalaPSL/issues/comments/233722380","html_url":"https://github.com/threatstream/scalaPSL/pull/1#issuecomment-233722380","issue_url":"https://api.github.com/repos/threatstream/scalaPSL/issues/1","id":233722380,"user":{"login":"cruzer911","id":1091926,"avatar_url":"https://avatars.githubusercontent.com/u/1091926?v=3","gravatar_id":"","url":"https://api.github.com/users/cruzer911","html_url":"https://github.com/cruzer911","followers_url":"https://api.github.com/users/cruzer911/followers","following_url":"https://api.github.com/users/cruzer911/following{/other_user}","gists_url":"https://api.github.com/users/cruzer911/gists{/gist_id}","starred_url":"https://api.github.com/users/cruzer911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruzer911/subscriptions","organizations_url":"https://api.github.com/users/cruzer911/orgs","repos_url":"https://api.github.com/users/cruzer911/repos","events_url":"https://api.github.com/users/cruzer911/events{/privacy}","received_events_url":"https://api.github.com/users/cruzer911/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T18:24:59Z","updated_at":"2016-07-19T18:24:59Z","body":"@jt6211 Unfortunately, this lib already has such use cases like - https://github.com/threatstream/scalaPSL/blob/master/src/main/scala/com/kodekutters/psl/TestApp.scala#L113\r\n\r\nHowever, these test cases are severely outdated and most of them fail. In fact, test cases related to my previous fix to the repo, already existed but were failing. This repo would require an overhaul of the test suite. For the sake of expediency I was going to add this test case in the telescope repo (like the test for the previous fix)\r\n \r\nLet me know what you think"}}
{"actor":{"display_login":"cruzer911"}}