{"action":"created","issue":{"url":"https://api.github.com/repos/ga4gh/server/issues/596","repository_url":"https://api.github.com/repos/ga4gh/server","labels_url":"https://api.github.com/repos/ga4gh/server/issues/596/labels{/name}","comments_url":"https://api.github.com/repos/ga4gh/server/issues/596/comments","events_url":"https://api.github.com/repos/ga4gh/server/issues/596/events","html_url":"https://github.com/ga4gh/server/issues/596","id":103794639,"number":596,"title":"SearchReads accepts only one ReadGroup ID, contrary to schema","user":{"login":"hjellinek","id":4968570,"avatar_url":"https://avatars.githubusercontent.com/u/4968570?v=3","gravatar_id":"","url":"https://api.github.com/users/hjellinek","html_url":"https://github.com/hjellinek","followers_url":"https://api.github.com/users/hjellinek/followers","following_url":"https://api.github.com/users/hjellinek/following{/other_user}","gists_url":"https://api.github.com/users/hjellinek/gists{/gist_id}","starred_url":"https://api.github.com/users/hjellinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjellinek/subscriptions","organizations_url":"https://api.github.com/users/hjellinek/orgs","repos_url":"https://api.github.com/users/hjellinek/repos","events_url":"https://api.github.com/users/hjellinek/events{/privacy}","received_events_url":"https://api.github.com/users/hjellinek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dcolligan","id":7422120,"avatar_url":"https://avatars.githubusercontent.com/u/7422120?v=3","gravatar_id":"","url":"https://api.github.com/users/dcolligan","html_url":"https://github.com/dcolligan","followers_url":"https://api.github.com/users/dcolligan/followers","following_url":"https://api.github.com/users/dcolligan/following{/other_user}","gists_url":"https://api.github.com/users/dcolligan/gists{/gist_id}","starred_url":"https://api.github.com/users/dcolligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcolligan/subscriptions","organizations_url":"https://api.github.com/users/dcolligan/orgs","repos_url":"https://api.github.com/users/dcolligan/repos","events_url":"https://api.github.com/users/dcolligan/events{/privacy}","received_events_url":"https://api.github.com/users/dcolligan/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ga4gh/server/milestones/9","html_url":"https://github.com/ga4gh/server/milestones/Reference%20server%20demo%20with%201000%20genome%20data","labels_url":"https://api.github.com/repos/ga4gh/server/milestones/9/labels","id":1643701,"number":9,"title":"Reference server demo with 1000 genome data","description":"The focus of this milestone is to bring together the functionality already present in the reference server with the features that are almost complete, and then serve up the data from the 1000 genome project. We need to fix a few problems as well as add support for some file types to successfully server up that data set. This milestone will act as a good proof of concept to motivate future applications that will leverage the GA4GH API.","creator":{"login":"kozbo","id":17557555,"avatar_url":"https://avatars.githubusercontent.com/u/17557555?v=3","gravatar_id":"","url":"https://api.github.com/users/kozbo","html_url":"https://github.com/kozbo","followers_url":"https://api.github.com/users/kozbo/followers","following_url":"https://api.github.com/users/kozbo/following{/other_user}","gists_url":"https://api.github.com/users/kozbo/gists{/gist_id}","starred_url":"https://api.github.com/users/kozbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozbo/subscriptions","organizations_url":"https://api.github.com/users/kozbo/orgs","repos_url":"https://api.github.com/users/kozbo/repos","events_url":"https://api.github.com/users/kozbo/events{/privacy}","received_events_url":"https://api.github.com/users/kozbo/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":16,"state":"open","created_at":"2016-03-14T17:17:15Z","updated_at":"2016-04-06T21:47:38Z","due_on":"2016-04-25T07:00:00Z","closed_at":null},"comments":34,"created_at":"2015-08-28T20:58:36Z","updated_at":"2016-04-06T22:15:34Z","closed_at":null,"body":"The schemas say that `SearchReadsRequest` accepts *at least* one ReadGroup ID, but the ref server accepts *at most* one.\r\n\r\n```avro\r\nrecord SearchReadsRequest {\r\n   /**\r\n   The ReadGroups to search. At least one readGroupId must be specified.\r\n   */\r\n   array<string> readGroupIds;\r\n   ...\r\n}\r\n```\r\n\r\nThis test case is from a forthcoming compliance test, `ReadsSearchIT.searchReadsWithAllIdsReturnsReadsForEach`:\r\n\r\n```java\r\nthreeReadGroupIds = getThreeReadGroupIdsSomehow(); // details omitted (obviously :-))\r\nSearchReadsRequest request =\r\n                SearchReadsRequest.newBuilder()\r\n                                  .setReadGroupIds(threeReadGroupIds)\r\n                                  .setStart(0L)\r\n                                  .setEnd(150L)\r\n                                  .setReferenceId(refId)\r\n                                  .build();\r\nSearchReadsResponse response = client.reads.searchReads(request);\r\n```\r\n\r\nThe call to `searchReads` throws a `GAException`:\r\n\r\n`{\"errorCode\":1151425451,\"message\":\"Exactly one read group id must be specified\"}`\r\n\r\nwith HTTP status `501` (`NOT_IMPLEMENTED`).\r\n\r\nThis is contrary to the comments in the schema, not to mention that the declaration of the `readGroupIds` field is `array<string>`, not a single `string`."},"comment":{"url":"https://api.github.com/repos/ga4gh/server/issues/comments/206593172","html_url":"https://github.com/ga4gh/server/issues/596#issuecomment-206593172","issue_url":"https://api.github.com/repos/ga4gh/server/issues/596","id":206593172,"user":{"login":"dcolligan","id":7422120,"avatar_url":"https://avatars.githubusercontent.com/u/7422120?v=3","gravatar_id":"","url":"https://api.github.com/users/dcolligan","html_url":"https://github.com/dcolligan","followers_url":"https://api.github.com/users/dcolligan/followers","following_url":"https://api.github.com/users/dcolligan/following{/other_user}","gists_url":"https://api.github.com/users/dcolligan/gists{/gist_id}","starred_url":"https://api.github.com/users/dcolligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcolligan/subscriptions","organizations_url":"https://api.github.com/users/dcolligan/orgs","repos_url":"https://api.github.com/users/dcolligan/repos","events_url":"https://api.github.com/users/dcolligan/events{/privacy}","received_events_url":"https://api.github.com/users/dcolligan/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T22:15:34Z","updated_at":"2016-04-06T22:15:34Z","body":"@kozbo sometimes GitHub automatically closes issues when they are referenced in a PR that is merged... but it always seems to happen to the ones you don't want closed... I agree that this issue should remain open"}}