{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/58945703","id":58945703,"diff_hunk":"@@ -2,23 +2,20 @@\n // for details. All rights reserved. Use of this source code is governed by a\n // BSD-style license that can be found in the LICENSE file.\n \n+import 'dart:convert';\n import 'dart:typed_data';\n \n /// An HTTP response where the entire response body is known in advance.\n class Response {\n   /// Creates a [Response] object with the given fields.\n   ///\n   /// If [bodyBytes] is non-null, it is used to populate [body].\n-  Response({\n-    Uint8List bodyBytes,\n-    this.statusCode\n-  }) : body = bodyBytes != null ? new String.fromCharCodes(bodyBytes) : null,\n-       bodyBytes = bodyBytes;\n+  Response.bytes(this.bodyBytes, this.statusCode, { this.headers: const {} });\n \n   /// The result of decoding [bodyBytes] using ISO-8859-1.\n   ///\n   /// If [bodyBytes] is null, this will also be null.\n-  final String body;\n+  String get body => _encodingForHeaders(headers).decode(bodyBytes);","path":"packages/flutter/lib/src/http/response.dart","position":23,"original_position":23,"commit_id":"0240a1a052894529c266637d97193354030ac439","original_commit_id":"0240a1a052894529c266637d97193354030ac439","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"this should be a function, not a getter, since it is expensive","created_at":"2016-04-07T21:09:57Z","updated_at":"2016-04-07T21:09:57Z","html_url":"https://github.com/flutter/flutter/pull/3182#discussion_r58945703","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/3182","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/58945703"},"html":{"href":"https://github.com/flutter/flutter/pull/3182#discussion_r58945703"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3182"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/3182","id":65694000,"html_url":"https://github.com/flutter/flutter/pull/3182","diff_url":"https://github.com/flutter/flutter/pull/3182.diff","patch_url":"https://github.com/flutter/flutter/pull/3182.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/3182","number":3182,"state":"closed","locked":false,"title":"Use the proper charset for decoding HTTP responses","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"Previously we always used Latin-1.","created_at":"2016-04-07T20:27:35Z","updated_at":"2016-04-07T21:09:58Z","closed_at":"2016-04-07T20:40:36Z","merged_at":"2016-04-07T20:40:36Z","merge_commit_sha":"99718794b39f5b8b4f97e6fd9df268fe46ff9743","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/3182/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/3182/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/3182/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/0240a1a052894529c266637d97193354030ac439","head":{"label":"abarth:http_response","ref":"http_response","sha":"0240a1a052894529c266637d97193354030ac439","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"repo":{"id":45444193,"name":"flutter","full_name":"abarth/flutter","owner":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abarth/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/abarth/flutter","forks_url":"https://api.github.com/repos/abarth/flutter/forks","keys_url":"https://api.github.com/repos/abarth/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abarth/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abarth/flutter/teams","hooks_url":"https://api.github.com/repos/abarth/flutter/hooks","issue_events_url":"https://api.github.com/repos/abarth/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/abarth/flutter/events","assignees_url":"https://api.github.com/repos/abarth/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/abarth/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/abarth/flutter/tags","blobs_url":"https://api.github.com/repos/abarth/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abarth/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abarth/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/abarth/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abarth/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/abarth/flutter/languages","stargazers_url":"https://api.github.com/repos/abarth/flutter/stargazers","contributors_url":"https://api.github.com/repos/abarth/flutter/contributors","subscribers_url":"https://api.github.com/repos/abarth/flutter/subscribers","subscription_url":"https://api.github.com/repos/abarth/flutter/subscription","commits_url":"https://api.github.com/repos/abarth/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/abarth/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/abarth/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/abarth/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/abarth/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/abarth/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abarth/flutter/merges","archive_url":"https://api.github.com/repos/abarth/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abarth/flutter/downloads","issues_url":"https://api.github.com/repos/abarth/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/abarth/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/abarth/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/abarth/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abarth/flutter/labels{/name}","releases_url":"https://api.github.com/repos/abarth/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/abarth/flutter/deployments","created_at":"2015-11-03T05:34:45Z","updated_at":"2015-11-05T07:43:35Z","pushed_at":"2016-04-07T20:40:38Z","git_url":"git://github.com/abarth/flutter.git","ssh_url":"git@github.com:abarth/flutter.git","clone_url":"https://github.com/abarth/flutter.git","svn_url":"https://github.com/abarth/flutter","homepage":"http://flutter.io","size":13703,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"b9e121a5fa2d73de8326bb51109e5411cd9019fe","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-04-07T15:55:42Z","pushed_at":"2016-04-07T21:07:42Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"http://flutter.io","size":109025,"stargazers_count":2740,"watchers_count":2740,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":274,"mirror_url":null,"open_issues_count":766,"forks":274,"open_issues":766,"watchers":2740,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3182"},"html":{"href":"https://github.com/flutter/flutter/pull/3182"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/3182"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/3182/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3182/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3182/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/0240a1a052894529c266637d97193354030ac439"}}}}