{"action":"created","issue":{"url":"https://api.github.com/repos/joukevandermaas/saule/issues/127","repository_url":"https://api.github.com/repos/joukevandermaas/saule","labels_url":"https://api.github.com/repos/joukevandermaas/saule/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/joukevandermaas/saule/issues/127/comments","events_url":"https://api.github.com/repos/joukevandermaas/saule/issues/127/events","html_url":"https://github.com/joukevandermaas/saule/issues/127","id":170496595,"number":127,"title":"\"Last\" key missing for pagination links","user":{"login":"bxh","id":3732224,"avatar_url":"https://avatars.githubusercontent.com/u/3732224?v=3","gravatar_id":"","url":"https://api.github.com/users/bxh","html_url":"https://github.com/bxh","followers_url":"https://api.github.com/users/bxh/followers","following_url":"https://api.github.com/users/bxh/following{/other_user}","gists_url":"https://api.github.com/users/bxh/gists{/gist_id}","starred_url":"https://api.github.com/users/bxh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bxh/subscriptions","organizations_url":"https://api.github.com/users/bxh/orgs","repos_url":"https://api.github.com/users/bxh/repos","events_url":"https://api.github.com/users/bxh/events{/privacy}","received_events_url":"https://api.github.com/users/bxh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-10T19:18:50Z","updated_at":"2016-08-11T07:16:16Z","closed_at":null,"body":"While [JSON spec](http://jsonapi.org/format/#fetching-pagination) states that all `first`, `last`, `prev` and `next` keys must exist for pagination links, the current version of Saule does not support it."},"comment":{"url":"https://api.github.com/repos/joukevandermaas/saule/issues/comments/239089150","html_url":"https://github.com/joukevandermaas/saule/issues/127#issuecomment-239089150","issue_url":"https://api.github.com/repos/joukevandermaas/saule/issues/127","id":239089150,"user":{"login":"joukevandermaas","id":1257578,"avatar_url":"https://avatars.githubusercontent.com/u/1257578?v=3","gravatar_id":"","url":"https://api.github.com/users/joukevandermaas","html_url":"https://github.com/joukevandermaas","followers_url":"https://api.github.com/users/joukevandermaas/followers","following_url":"https://api.github.com/users/joukevandermaas/following{/other_user}","gists_url":"https://api.github.com/users/joukevandermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/joukevandermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joukevandermaas/subscriptions","organizations_url":"https://api.github.com/users/joukevandermaas/orgs","repos_url":"https://api.github.com/users/joukevandermaas/repos","events_url":"https://api.github.com/users/joukevandermaas/events{/privacy}","received_events_url":"https://api.github.com/users/joukevandermaas/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T07:16:16Z","updated_at":"2016-08-11T07:16:16Z","body":"The relevant part of the spec says:\r\n\r\n>The following keys *MUST* be used for pagination links:\r\n> - `first`: the first page of data\r\n> - `last`: the last page of data\r\n> - `prev`: the previous page of data\r\n> - `next`: the next page of data\r\n>\r\n> Keys *MUST* either be omitted or have a null value to indicate that a particular link is unavailable.\r\n\r\nThis should be interpreted as: \"if you do pagination, do not generate links *other than the above*\". Saule omits links it cannot generate (particularly `last`, sometimes `next` and `prev`) without potential performance problems, which is in accordance with the spec.\r\n\r\nI'm not opposed to generating those links anyway under certain conditions (maybe based on a flag in the attribute). This would be a performance trade-off that an app developer can decide, but Saule cannot."}}
{"actor":{"display_login":"joukevandermaas"}}