{"action":"created","comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments/79674094","id":79674094,"diff_hunk":"@@ -459,15 +474,35 @@ def fd_decompress(amp, phase, sample_frequencies, out=None, df=None,\n         If out was provided, writes to that array. Otherwise, a new\n         FrequencySeries with the decompressed waveform.\n     \"\"\"\n-    precision = _precision_map[sample_frequencies.dtype.name]\n-    if _precision_map[amp.dtype.name] != precision or \\\n-            _precision_map[phase.dtype.name] != precision:\n-        raise ValueError(\"amp, phase, and sample_points must all have the \"\n-            \"same precision\")\n+    precision = _precision_map[phase_freq.dtype.name]\n+    if interpolation == \"linear\":\n+        if amp_freq != None:\n+            raise ValueError(\"for inline_linear_single_freq decompression\"\n+                     \"amp_freq should be set to None as it should be the\"\n+                     \" same as phase_freq\")\n+        sample_frequencies = phase_freq\n+        if _precision_map[amp.dtype.name] != precision or \\\n+               _precision_map[phase.dtype.name] != precision:\n+           raise ValueError(\"amp, phase, and phase_freq must\"\n+                             \" all have the same precision\")","path":"pycbc/waveform/compress.py","position":101,"original_position":101,"commit_id":"4034f3e38d625027b1eb42e310d020cb307b6502","original_commit_id":"4034f3e38d625027b1eb42e310d020cb307b6502","user":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"body":"__[flake8]__\n* [E127] continuation line over-indented for visual indent\n\n<!-- Comment by [SideCI](https://sideci.com) -->","created_at":"2016-09-20T18:01:16Z","updated_at":"2016-09-20T18:01:16Z","html_url":"https://github.com/ligo-cbc/pycbc/pull/1083#discussion_r79674094","pull_request_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083","_links":{"self":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments/79674094"},"html":{"href":"https://github.com/ligo-cbc/pycbc/pull/1083#discussion_r79674094"},"pull_request":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083"}}},"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083","id":85123762,"html_url":"https://github.com/ligo-cbc/pycbc/pull/1083","diff_url":"https://github.com/ligo-cbc/pycbc/pull/1083.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/1083.patch","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1083","number":1083,"state":"open","locked":false,"title":"Allow different frequency samples for interpolants","user":{"login":"duncan-brown","id":11262902,"avatar_url":"https://avatars.githubusercontent.com/u/11262902?v=3","gravatar_id":"","url":"https://api.github.com/users/duncan-brown","html_url":"https://github.com/duncan-brown","followers_url":"https://api.github.com/users/duncan-brown/followers","following_url":"https://api.github.com/users/duncan-brown/following{/other_user}","gists_url":"https://api.github.com/users/duncan-brown/gists{/gist_id}","starred_url":"https://api.github.com/users/duncan-brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncan-brown/subscriptions","organizations_url":"https://api.github.com/users/duncan-brown/orgs","repos_url":"https://api.github.com/users/duncan-brown/repos","events_url":"https://api.github.com/users/duncan-brown/events{/privacy}","received_events_url":"https://api.github.com/users/duncan-brown/received_events","type":"User","site_admin":false},"body":"Currently the ``CompressedWaveform`` class is hard wired so that the frequency samples of the interpolants for amplitude and phase must be the same. This makes sense for the way that the current compression algorithm is implemented. However, there is no a priori reason why they should be sampled at the same points (in fact most of the A and phi interpolants for ROM models are sampled at *different* frequencies in amplitude and phase).\r\n\r\nThis patch extends the class to allow the interpolant frequencies to be stored separately, but keeps the overall behavior the same for the current compression method and the linear decompression method.","created_at":"2016-09-13T20:56:55Z","updated_at":"2016-09-20T18:01:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"300c15c4e344697a06e3a98103152f9692a227fc","assignee":{"login":"cdcapano","id":8258446,"avatar_url":"https://avatars.githubusercontent.com/u/8258446?v=3","gravatar_id":"","url":"https://api.github.com/users/cdcapano","html_url":"https://github.com/cdcapano","followers_url":"https://api.github.com/users/cdcapano/followers","following_url":"https://api.github.com/users/cdcapano/following{/other_user}","gists_url":"https://api.github.com/users/cdcapano/gists{/gist_id}","starred_url":"https://api.github.com/users/cdcapano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdcapano/subscriptions","organizations_url":"https://api.github.com/users/cdcapano/orgs","repos_url":"https://api.github.com/users/cdcapano/repos","events_url":"https://api.github.com/users/cdcapano/events{/privacy}","received_events_url":"https://api.github.com/users/cdcapano/received_events","type":"User","site_admin":false},"assignees":[{"login":"cdcapano","id":8258446,"avatar_url":"https://avatars.githubusercontent.com/u/8258446?v=3","gravatar_id":"","url":"https://api.github.com/users/cdcapano","html_url":"https://github.com/cdcapano","followers_url":"https://api.github.com/users/cdcapano/followers","following_url":"https://api.github.com/users/cdcapano/following{/other_user}","gists_url":"https://api.github.com/users/cdcapano/gists{/gist_id}","starred_url":"https://api.github.com/users/cdcapano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdcapano/subscriptions","organizations_url":"https://api.github.com/users/cdcapano/orgs","repos_url":"https://api.github.com/users/cdcapano/repos","events_url":"https://api.github.com/users/cdcapano/events{/privacy}","received_events_url":"https://api.github.com/users/cdcapano/received_events","type":"User","site_admin":false},{"login":"soumide1102","id":14112415,"avatar_url":"https://avatars.githubusercontent.com/u/14112415?v=3","gravatar_id":"","url":"https://api.github.com/users/soumide1102","html_url":"https://github.com/soumide1102","followers_url":"https://api.github.com/users/soumide1102/followers","following_url":"https://api.github.com/users/soumide1102/following{/other_user}","gists_url":"https://api.github.com/users/soumide1102/gists{/gist_id}","starred_url":"https://api.github.com/users/soumide1102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumide1102/subscriptions","organizations_url":"https://api.github.com/users/soumide1102/orgs","repos_url":"https://api.github.com/users/soumide1102/repos","events_url":"https://api.github.com/users/soumide1102/events{/privacy}","received_events_url":"https://api.github.com/users/soumide1102/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083/commits","review_comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083/comments","review_comment_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1083/comments","statuses_url":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/4034f3e38d625027b1eb42e310d020cb307b6502","head":{"label":"duncan-brown:two_freq_compress","ref":"two_freq_compress","sha":"4034f3e38d625027b1eb42e310d020cb307b6502","user":{"login":"duncan-brown","id":11262902,"avatar_url":"https://avatars.githubusercontent.com/u/11262902?v=3","gravatar_id":"","url":"https://api.github.com/users/duncan-brown","html_url":"https://github.com/duncan-brown","followers_url":"https://api.github.com/users/duncan-brown/followers","following_url":"https://api.github.com/users/duncan-brown/following{/other_user}","gists_url":"https://api.github.com/users/duncan-brown/gists{/gist_id}","starred_url":"https://api.github.com/users/duncan-brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncan-brown/subscriptions","organizations_url":"https://api.github.com/users/duncan-brown/orgs","repos_url":"https://api.github.com/users/duncan-brown/repos","events_url":"https://api.github.com/users/duncan-brown/events{/privacy}","received_events_url":"https://api.github.com/users/duncan-brown/received_events","type":"User","site_admin":false},"repo":{"id":35169124,"name":"pycbc","full_name":"duncan-brown/pycbc","owner":{"login":"duncan-brown","id":11262902,"avatar_url":"https://avatars.githubusercontent.com/u/11262902?v=3","gravatar_id":"","url":"https://api.github.com/users/duncan-brown","html_url":"https://github.com/duncan-brown","followers_url":"https://api.github.com/users/duncan-brown/followers","following_url":"https://api.github.com/users/duncan-brown/following{/other_user}","gists_url":"https://api.github.com/users/duncan-brown/gists{/gist_id}","starred_url":"https://api.github.com/users/duncan-brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncan-brown/subscriptions","organizations_url":"https://api.github.com/users/duncan-brown/orgs","repos_url":"https://api.github.com/users/duncan-brown/repos","events_url":"https://api.github.com/users/duncan-brown/events{/privacy}","received_events_url":"https://api.github.com/users/duncan-brown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duncan-brown/pycbc","description":"Python CBC Tools","fork":true,"url":"https://api.github.com/repos/duncan-brown/pycbc","forks_url":"https://api.github.com/repos/duncan-brown/pycbc/forks","keys_url":"https://api.github.com/repos/duncan-brown/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duncan-brown/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duncan-brown/pycbc/teams","hooks_url":"https://api.github.com/repos/duncan-brown/pycbc/hooks","issue_events_url":"https://api.github.com/repos/duncan-brown/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/duncan-brown/pycbc/events","assignees_url":"https://api.github.com/repos/duncan-brown/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/duncan-brown/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/duncan-brown/pycbc/tags","blobs_url":"https://api.github.com/repos/duncan-brown/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duncan-brown/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duncan-brown/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/duncan-brown/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duncan-brown/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/duncan-brown/pycbc/languages","stargazers_url":"https://api.github.com/repos/duncan-brown/pycbc/stargazers","contributors_url":"https://api.github.com/repos/duncan-brown/pycbc/contributors","subscribers_url":"https://api.github.com/repos/duncan-brown/pycbc/subscribers","subscription_url":"https://api.github.com/repos/duncan-brown/pycbc/subscription","commits_url":"https://api.github.com/repos/duncan-brown/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/duncan-brown/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/duncan-brown/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/duncan-brown/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/duncan-brown/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/duncan-brown/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duncan-brown/pycbc/merges","archive_url":"https://api.github.com/repos/duncan-brown/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duncan-brown/pycbc/downloads","issues_url":"https://api.github.com/repos/duncan-brown/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/duncan-brown/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/duncan-brown/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/duncan-brown/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duncan-brown/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/duncan-brown/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/duncan-brown/pycbc/deployments","created_at":"2015-05-06T16:07:21Z","updated_at":"2016-01-25T23:14:32Z","pushed_at":"2016-09-20T18:00:58Z","git_url":"git://github.com/duncan-brown/pycbc.git","ssh_url":"git@github.com:duncan-brown/pycbc.git","clone_url":"https://github.com/duncan-brown/pycbc.git","svn_url":"https://github.com/duncan-brown/pycbc","homepage":null,"size":27179,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ligo-cbc:master","ref":"master","sha":"c2493e434aabc3d1cc808b54d7c61ddbe71c3879","user":{"login":"ligo-cbc","id":11262917,"avatar_url":"https://avatars.githubusercontent.com/u/11262917?v=3","gravatar_id":"","url":"https://api.github.com/users/ligo-cbc","html_url":"https://github.com/ligo-cbc","followers_url":"https://api.github.com/users/ligo-cbc/followers","following_url":"https://api.github.com/users/ligo-cbc/following{/other_user}","gists_url":"https://api.github.com/users/ligo-cbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ligo-cbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligo-cbc/subscriptions","organizations_url":"https://api.github.com/users/ligo-cbc/orgs","repos_url":"https://api.github.com/users/ligo-cbc/repos","events_url":"https://api.github.com/users/ligo-cbc/events{/privacy}","received_events_url":"https://api.github.com/users/ligo-cbc/received_events","type":"Organization","site_admin":false},"repo":{"id":31596861,"name":"pycbc","full_name":"ligo-cbc/pycbc","owner":{"login":"ligo-cbc","id":11262917,"avatar_url":"https://avatars.githubusercontent.com/u/11262917?v=3","gravatar_id":"","url":"https://api.github.com/users/ligo-cbc","html_url":"https://github.com/ligo-cbc","followers_url":"https://api.github.com/users/ligo-cbc/followers","following_url":"https://api.github.com/users/ligo-cbc/following{/other_user}","gists_url":"https://api.github.com/users/ligo-cbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ligo-cbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligo-cbc/subscriptions","organizations_url":"https://api.github.com/users/ligo-cbc/orgs","repos_url":"https://api.github.com/users/ligo-cbc/repos","events_url":"https://api.github.com/users/ligo-cbc/events{/privacy}","received_events_url":"https://api.github.com/users/ligo-cbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ligo-cbc/pycbc","description":"Python CBC Tools","fork":false,"url":"https://api.github.com/repos/ligo-cbc/pycbc","forks_url":"https://api.github.com/repos/ligo-cbc/pycbc/forks","keys_url":"https://api.github.com/repos/ligo-cbc/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligo-cbc/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligo-cbc/pycbc/teams","hooks_url":"https://api.github.com/repos/ligo-cbc/pycbc/hooks","issue_events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/events","assignees_url":"https://api.github.com/repos/ligo-cbc/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/ligo-cbc/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/ligo-cbc/pycbc/tags","blobs_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/ligo-cbc/pycbc/languages","stargazers_url":"https://api.github.com/repos/ligo-cbc/pycbc/stargazers","contributors_url":"https://api.github.com/repos/ligo-cbc/pycbc/contributors","subscribers_url":"https://api.github.com/repos/ligo-cbc/pycbc/subscribers","subscription_url":"https://api.github.com/repos/ligo-cbc/pycbc/subscription","commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligo-cbc/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/ligo-cbc/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligo-cbc/pycbc/merges","archive_url":"https://api.github.com/repos/ligo-cbc/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligo-cbc/pycbc/downloads","issues_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/ligo-cbc/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/ligo-cbc/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/ligo-cbc/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/ligo-cbc/pycbc/deployments","created_at":"2015-03-03T12:19:19Z","updated_at":"2016-08-18T14:09:58Z","pushed_at":"2016-09-20T18:00:58Z","git_url":"git://github.com/ligo-cbc/pycbc.git","ssh_url":"git@github.com:ligo-cbc/pycbc.git","clone_url":"https://github.com/ligo-cbc/pycbc.git","svn_url":"https://github.com/ligo-cbc/pycbc","homepage":null,"size":176743,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":37,"forks":84,"open_issues":37,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083"},"html":{"href":"https://github.com/ligo-cbc/pycbc/pull/1083"},"issue":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1083"},"comments":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1083/comments"},"review_comments":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083/comments"},"review_comment":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1083/commits"},"statuses":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/4034f3e38d625027b1eb42e310d020cb307b6502"}}}}
{"actor":{"display_login":"ahnitz"}}