{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack/issues/418","repository_url":"https://api.github.com/repos/webpack/webpack","labels_url":"https://api.github.com/repos/webpack/webpack/issues/418/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/418/comments","events_url":"https://api.github.com/repos/webpack/webpack/issues/418/events","html_url":"https://github.com/webpack/webpack/issues/418","id":40801293,"number":418,"title":"Opt-in to disable page reload when using HMR","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":50,"created_at":"2014-08-21T12:56:24Z","updated_at":"2016-10-15T19:20:44Z","closed_at":"2014-08-29T13:52:51Z","body":"When HMR update fails, it forces a page reload.\r\n\r\nThis may be desirable for consistency, but most of the time this is caused by a simple syntax error, and I'd like to error to just appear in console. When I fix the error, another HMR update will come and \"fix\" the system anyway.\r\n\r\nWhen [react-hot-loader](https://github.com/gaearon/react-hot-loader) used a pitch loader, it just [put HMR-updated require inside a try-catch](https://github.com/gaearon/react-hot-loader/blob/37edb096e0570491a7cbebcbe35add9b64010bf2/index.js#L24).\r\n\r\nNow that I [refactored it](https://github.com/gaearon/react-hot-loader/blob/02c971305360b81e23d43170162f59b8658113e3/index.js#L20) to be a simple loader (no pitching), I no longer have the ability to `catch` syntax errors in the breaking module.\r\n\r\nCan we have a way to disable page reloads altogether? I guess making it opt-in and logging something like \"The system is in inconsistent state\" is fine with me.\r\n\r\ncc @syranide "},"comment":{"url":"https://api.github.com/repos/webpack/webpack/issues/comments/254005206","html_url":"https://github.com/webpack/webpack/issues/418#issuecomment-254005206","issue_url":"https://api.github.com/repos/webpack/webpack/issues/418","id":254005206,"user":{"login":"koddo","id":2563454,"avatar_url":"https://avatars.githubusercontent.com/u/2563454?v=3","gravatar_id":"","url":"https://api.github.com/users/koddo","html_url":"https://github.com/koddo","followers_url":"https://api.github.com/users/koddo/followers","following_url":"https://api.github.com/users/koddo/following{/other_user}","gists_url":"https://api.github.com/users/koddo/gists{/gist_id}","starred_url":"https://api.github.com/users/koddo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koddo/subscriptions","organizations_url":"https://api.github.com/users/koddo/orgs","repos_url":"https://api.github.com/users/koddo/repos","events_url":"https://api.github.com/users/koddo/events{/privacy}","received_events_url":"https://api.github.com/users/koddo/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T19:20:44Z","updated_at":"2016-10-15T19:20:44Z","body":"I'm not alone having the issue with the noErrorsPlugin: https://github.com/webpack/webpack-dev-server/issues/655\r\n\r\nWhen using the noErrorsPlugin, after making an error and then fixing it, module.hot.status() returns \"check\", when it should return \"idle\". So, basically it gets stuck somewhere, I can't figure out."}}
{"actor":{"display_login":"koddo"}}