{"action":"created","issue":{"url":"https://api.github.com/repos/Cantera/cantera/issues/351","repository_url":"https://api.github.com/repos/Cantera/cantera","labels_url":"https://api.github.com/repos/Cantera/cantera/issues/351/labels{/name}","comments_url":"https://api.github.com/repos/Cantera/cantera/issues/351/comments","events_url":"https://api.github.com/repos/Cantera/cantera/issues/351/events","html_url":"https://github.com/Cantera/cantera/issues/351","id":164112971,"number":351,"title":"VCS tests failed on Fedora 24","user":{"login":"sagitter","id":5006433,"avatar_url":"https://avatars.githubusercontent.com/u/5006433?v=3","gravatar_id":"","url":"https://api.github.com/users/sagitter","html_url":"https://github.com/sagitter","followers_url":"https://api.github.com/users/sagitter/followers","following_url":"https://api.github.com/users/sagitter/following{/other_user}","gists_url":"https://api.github.com/users/sagitter/gists{/gist_id}","starred_url":"https://api.github.com/users/sagitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagitter/subscriptions","organizations_url":"https://api.github.com/users/sagitter/orgs","repos_url":"https://api.github.com/users/sagitter/repos","events_url":"https://api.github.com/users/sagitter/events{/privacy}","received_events_url":"https://api.github.com/users/sagitter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-06T16:03:51Z","updated_at":"2016-07-26T17:27:28Z","closed_at":null,"body":"Hi.\r\n\r\nWe are near to complete the RPM packaging of Cantera. There are some tests failed:\r\n\r\n```\r\n* Running test 'VCS-NaCl'...\r\nComparing 'good_out.txt' with 'test_output.txt'\r\nFound differences between /home/sagitter/rpmbuild/BUILD/cantera-d4ddabc76c2bdfd54d61f76de6bfe477912325eb/test_problems/VCSnonideal/NaCl_equil/good_out.txt and /home/sagitter/rpmbuild/BUILD/cantera-d4ddabc76c2bdfd54d61f76de6bfe477912325eb/test_problems/VCSnonideal/NaCl_equil/test_output.txt:\r\n>>>\r\n--- \r\n\r\n+++ \r\n\r\n@@ -276,16 +276,16 @@\r\n\r\n \r\n \r\n Counters:         Iterations          Time (seconds)\r\n-    vcs_basopt:       2                 NA\r\n-    vcs_TP:          18                 NA\r\n+    vcs_basopt:       2             2.70000E-05\r\n+    vcs_TP:          18             5.26100E-03\r\n --------------------------------------------------------------------------------\r\n --------------------------------------------------------------------------------\r\n \r\n TCounters:   Num_Calls   Total_Its       Total_Time (seconds)\r\n-    vcs_basopt:       2          2             NA\r\n-    vcs_TP:           1         18             NA\r\n-    vcs_inest:        1                        NA\r\n-    vcs_TotalTime:                             NA\r\n+    vcs_basopt:       2          2         2.70000E-05\r\n+    vcs_TP:           1         18         5.26100E-03\r\n+    vcs_inest:        1                    1.55000E-04\r\n+    vcs_TotalTime:                         6.23300E-03\r\n \r\n  Results from vcs:\r\n \r\n<<<\r\nFAILED\r\ng++ -o test_problems/VCSnonideal/LatticeSolid_LiSi/latsol.o -c -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic --std=c++14 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -pthread -DNDEBUG -DNDEBUG -Iinclude -Isrc -Itest_problems/shared -I/usr/include/eigen3 -I/usr/include test_problems/VCSnonideal/LatticeSolid_LiSi/latsol.cpp\r\ng++ -o test_problems/VCSnonideal/LatticeSolid_LiSi/latsol -pthread -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld test_problems/VCSnonideal/LatticeSolid_LiSi/latsol.o -Lbuild/lib -lcantera -lsundials_cvodes -lsundials_ida -lsundials_nvecserial -lfmt\r\n* Running test 'VCS-LiSi'...\r\nComparing 'output_blessed.txt' with 'output_output.txt'\r\nFound differences between /home/sagitter/rpmbuild/BUILD/cantera-d4ddabc76c2bdfd54d61f76de6bfe477912325eb/test_problems/VCSnonideal/LatticeSolid_LiSi/output_blessed.txt and /home/sagitter/rpmbuild/BUILD/cantera-d4ddabc76c2bdfd54d61f76de6bfe477912325eb/test_problems/VCSnonideal/LatticeSolid_LiSi/output_output.txt:\r\n>>>\r\n--- \r\n\r\n+++ \r\n\r\n@@ -210,16 +210,16 @@\r\n\r\n \r\n \r\n Counters:         Iterations          Time (seconds)\r\n-    vcs_basopt:       1                 NA\r\n-    vcs_TP:           3                 NA\r\n+    vcs_basopt:       1             1.70000E-05\r\n+    vcs_TP:           3             2.07000E-04\r\n --------------------------------------------------------------------------------\r\n --------------------------------------------------------------------------------\r\n \r\n TCounters:   Num_Calls   Total_Its       Total_Time (seconds)\r\n-    vcs_basopt:       1          1             NA\r\n-    vcs_TP:           1          3             NA\r\n-    vcs_inest:        0                        NA\r\n-    vcs_TotalTime:                             NA\r\n+    vcs_basopt:       1          1         1.70000E-05\r\n+    vcs_TP:           1          3         2.07000E-04\r\n+    vcs_inest:        0                    0.00000E+00\r\n+    vcs_TotalTime:                         6.38000E-04\r\n \r\n  Results from vcs:\r\n \r\n<<<\r\nFAILED\r\n* Running test 'VCS-LiSi-verbose'...\r\nComparing 'verbose_blessed.txt' with 'verbose_output.txt'\r\nValues differ:         101325         625.15; rel. err = 1.975e+00; abs. err = 1.007e+05\r\nValues differ:         2475.9    -7.3846e+06; rel. err = 2.001e+00; abs. err = 7.387e+06\r\nValues differ:    -8.9323e+06         2475.9; rel. err = 2.001e+00; abs. err = 8.935e+06\r\nValues differ:         1331.6    -8.9323e+06; rel. err = 2.001e+00; abs. err = 8.934e+06\r\nValues differ:         1171.8         1331.6; rel. err = 1.277e-01; abs. err = 1.598e+02\r\nValues differ:            0.3            0.7; rel. err = 8.000e-01; abs. err = 4.000e-01\r\nValues differ:         101325         625.15; rel. err = 1.975e+00; abs. err = 1.007e+05\r\nValues differ:    -2.5009e+06    -2.5006e+06; rel. err = 1.200e-04; abs. err = 3.000e+02\r\nValues differ:           6116    -2.5009e+06; rel. err = 2.010e+00; abs. err = 2.507e+06\r\nValues differ:     -6.324e+06           6116; rel. err = 2.004e+00; abs. err = 6.330e+06\r\nValues differ:         4196.8     -6.324e+06; rel. err = 2.003e+00; abs. err = 6.328e+06\r\nValues differ:            0.5    1.39772e-13; rel. err = 2.000e+00; abs. err = 5.000e-01\r\nValues differ:         101325         625.15; rel. err = 1.975e+00; abs. err = 1.007e+05\r\nValues differ:    -1.2398e+14    -2.3852e+07; rel. err = 2.000e+00; abs. err = 1.240e+14\r\nValues differ:              0    -1.2398e+14; rel. err = 2.000e+00; abs. err = 1.240e+14\r\nValues differ:    -2.3852e+07              0; rel. err = 2.000e+00; abs. err = 2.385e+07\r\nValues differ:              0    -2.3852e+07; rel. err = 2.000e+00; abs. err = 2.385e+07\r\nFound differences between /home/sagitter/rpmbuild/BUILD/cantera-d4ddabc76c2bdfd54d61f76de6bfe477912325eb/test_problems/VCSnonideal/LatticeSolid_LiSi/verbose_blessed.txt and /home/sagitter/rpmbuild/BUILD/cantera-d4ddabc76c2bdfd54d61f76de6bfe477912325eb/test_problems/VCSnonideal/LatticeSolid_LiSi/verbose_output.txt:\r\n>>>\r\n--- \r\n\r\n+++ \r\n\r\n@@ -449,16 +449,16 @@\r\n\r\n \r\n \r\n Counters:         Iterations          Time (seconds)\r\n-    vcs_basopt:       1                 NA\r\n-    vcs_TP:           3                 NA\r\n+    vcs_basopt:       1             1.36000E-04\r\n+    vcs_TP:           3             1.06900E-03\r\n --------------------------------------------------------------------------------\r\n --------------------------------------------------------------------------------\r\n \r\n TCounters:   Num_Calls   Total_Its       Total_Time (seconds)\r\n-    vcs_basopt:       1          1             NA\r\n-    vcs_TP:           1          3             NA\r\n-    vcs_inest:        0                        NA\r\n-    vcs_TotalTime:                             NA\r\n+    vcs_basopt:       1          1         1.36000E-04\r\n+    vcs_TP:           1          3         1.06900E-03\r\n+    vcs_inest:        0                    0.00000E+00\r\n+    vcs_TotalTime:                         1.62300E-03\r\n \r\n  Results from vcs:\r\n \r\n@@ -475,11 +475,12 @@\r\n\r\n V(i)                5.000e-01         5.000e-01       -3.513e+06\r\n LiFixed             1.000e+02         1.000e+00       -1.656e+08\r\n -------------------------------------------------------------\r\n-VCS solver succeeded\r\n+Total time = 1.845000e-03 seconds\r\n+*************** MoltenSalt_electrolyte *****************\r\n *************** MoltenSalt_electrolyte *****************\r\n Moles: 10\r\n-\r\n   MoltenSalt_electrolyte:\r\n+\r\n \r\n        temperature          625.15  K\r\n           pressure          101325  Pa\r\n@@ -488,14 +489,14 @@\r\n\r\n \r\n                           1 kg            1 kmol\r\n                        -----------      ------------\r\n-          enthalpy     -7.3846e+06       -3.843e+08     J\r\n+   internal energy     -7.3846e+06       -3.843e+08     J\r\n    internal energy     -7.3846e+06       -3.843e+08     J\r\n            entropy          2475.9        1.288e+05     J/K\r\n     Gibbs function     -8.9323e+06       -4.648e+08     J\r\n  heat capacity c_p          1331.6         6.93e+04     J/K\r\n  heat capacity c_v          1171.8        6.098e+04     J/K\r\n-\r\n                            X                 Y          Chem. Pot. / RT\r\n+                     -------------     ------------     ------------\r\n                      -------------     ------------     ------------\r\n            LiCl(L)            0.7         0.570236         -86.6013\r\n             KCl(L)            0.3         0.429764         -96.0362\r\n@@ -516,19 +517,19 @@\r\n\r\n    internal energy     -2.5009e+06       -1.661e+08     J\r\n            entropy            6116        4.062e+05     J/K\r\n     Gibbs function      -6.324e+06       -4.201e+08     J\r\n- heat capacity c_p          4196.8        2.788e+05     J/K\r\n  heat capacity c_v          4196.8        2.788e+05     J/K\r\n-\r\n+ heat capacity c_v          4196.8        2.788e+05     J/K\r\n                            X                 Y          Chem. Pot. / RT\r\n+                     -------------     ------------     ------------\r\n                      -------------     ------------     ------------\r\n          Li7Si3(S)            0.5                1         -80.8307\r\n              Li(i)    1.39772e-13       1.4606e-14         -31.8338\r\n               V(i)            0.5      7.52765e-23        0.0172766\r\n-\r\n+*************** LiFixed *****************\r\n *************** LiFixed *****************\r\n Moles: 100.005\r\n-\r\n   LiFixed:\r\n+\r\n \r\n        temperature          625.15  K\r\n           pressure          101325  Pa\r\n@@ -541,11 +542,11 @@\r\n\r\n    internal energy     -1.2398e+14       -8.605e+14     J\r\n            entropy               0                0     J/K\r\n     Gibbs function     -2.3852e+07       -1.656e+08     J\r\n- heat capacity c_p               0                0     J/K\r\n  heat capacity c_v               0                0     J/K\r\n-\r\n+ heat capacity c_v               0                0     J/K\r\n                            X                 Y          Chem. Pot. / RT\r\n                      -------------     ------------     ------------\r\n+                     -------------     ------------     ------------\r\n            LiFixed              1                1         -31.8511\r\n \r\n \r\n<<<\r\nFAILED\r\ng++ -o test_problems/VPsilane_test/silane_equil.o -c -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic --std=c++14 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -pthread -DNDEBUG -DNDEBUG -Iinclude -Isrc -Itest_problems/shared -I/usr/include/eigen3 -I/usr/include test_problems/VPsilane_test/silane_equil.cpp\r\ng++ -o test_problems/VPsilane_test/VPsilane_test -pthread -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld test_problems/VPsilane_test/silane_equil.o -Lbuild/lib -lcantera -lsundials_cvodes -lsundials_ida -lsundials_nvecserial -lfmt\r\n* Running test 'VPsilane_test'...\r\nComparing 'output_blessed.txt' with 'output_output.txt'\r\nPASSED\r\nprintReport([\"test_results\"], [])\r\n\r\n*****************************\r\n***    Testing Summary    ***\r\n*****************************\r\n\r\nTests passed: 1113\r\nUp-to-date tests skipped: 0\r\nTests failed: 3\r\nFailed tests:\r\n    - VCS-LiSi\r\n    - VCS-NaCl\r\n    - VCS-LiSi-verbose\r\n\r\n*****************************\r\nscons: *** [test_results] One or more tests failed.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/Cantera/cantera/issues/comments/235342279","html_url":"https://github.com/Cantera/cantera/issues/351#issuecomment-235342279","issue_url":"https://api.github.com/repos/Cantera/cantera/issues/351","id":235342279,"user":{"login":"speth","id":644977,"avatar_url":"https://avatars.githubusercontent.com/u/644977?v=3","gravatar_id":"","url":"https://api.github.com/users/speth","html_url":"https://github.com/speth","followers_url":"https://api.github.com/users/speth/followers","following_url":"https://api.github.com/users/speth/following{/other_user}","gists_url":"https://api.github.com/users/speth/gists{/gist_id}","starred_url":"https://api.github.com/users/speth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speth/subscriptions","organizations_url":"https://api.github.com/users/speth/orgs","repos_url":"https://api.github.com/users/speth/repos","events_url":"https://api.github.com/users/speth/events{/privacy}","received_events_url":"https://api.github.com/users/speth/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T17:27:28Z","updated_at":"2016-07-26T17:27:28Z","body":"I meant the branch of which 791c9d1 is the tip, not just that one commit. 791c9d1 is a one-line change that clearly only affects the `Polyfit.exact_fit` test. \r\n\r\nMore generally, I don't think it's productive for me to work on fixing things on some unpublished fork of yours where you're cherry-picking a handful of changes. Please use the current master branch as the reference point for any bug reports."}}
{"actor":{"display_login":"speth"}}