{"action":"created","issue":{"url":"https://api.github.com/repos/simulationcraft/simc/issues/2870","repository_url":"https://api.github.com/repos/simulationcraft/simc","labels_url":"https://api.github.com/repos/simulationcraft/simc/issues/2870/labels{/name}","comments_url":"https://api.github.com/repos/simulationcraft/simc/issues/2870/comments","events_url":"https://api.github.com/repos/simulationcraft/simc/issues/2870/events","html_url":"https://github.com/simulationcraft/simc/issues/2870","id":178147873,"number":2870,"title":"[Shadow Priest] APL Bug/Improvement","user":{"login":"PhiNikM","id":9466217,"avatar_url":"https://avatars.githubusercontent.com/u/9466217?v=3","gravatar_id":"","url":"https://api.github.com/users/PhiNikM","html_url":"https://github.com/PhiNikM","followers_url":"https://api.github.com/users/PhiNikM/followers","following_url":"https://api.github.com/users/PhiNikM/following{/other_user}","gists_url":"https://api.github.com/users/PhiNikM/gists{/gist_id}","starred_url":"https://api.github.com/users/PhiNikM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhiNikM/subscriptions","organizations_url":"https://api.github.com/users/PhiNikM/orgs","repos_url":"https://api.github.com/users/PhiNikM/repos","events_url":"https://api.github.com/users/PhiNikM/events{/privacy}","received_events_url":"https://api.github.com/users/PhiNikM/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-20T19:06:36Z","updated_at":"2016-09-28T12:42:51Z","closed_at":null,"body":"The current SP APL cancels mind flay early to schedule a wait event for void bolt:\r\nactions.s2m+=/wait,sec=action.void_bolt.usable_in,if=action.void_bolt.usable|action.void_bolt.usable_in<gcd.max*0.8\r\n[...]\r\nactions.s2m+=/mind_flay,if=!talent.mind_spike.enabled,chain=1,interrupt_immediate=1,interrupt_if=action.void_bolt.usable_in<gcd.max*0.8\r\n\r\nThis results in a fairly significant amount of mind flay ticks being lost for no reason.\r\n\r\nReplacing the last line with the following to only cancel if VB is actually ready improves default T19P S2M DPS over 450 seconds from ~287k to ~296k by significantly reducing the amount of early deaths (see DPS distribution):\r\nactions.s2m+=/mind_flay,if=!talent.mind_spike.enabled,chain=1,interrupt_immediate=1,interrupt_if=action.void_bolt.usable\r\n\r\nIf you do the same change for outside of void form, i.e. replacing the line\r\nctions.vf+=/mind_flay,if=!talent.mind_spike.enabled,chain=1,interrupt_immediate=1,interrupt_if=action.void_bolt.usable_in<gcd.max*0.8\r\nby the line\r\nactions.vf+=/mind_flay,if=!talent.mind_spike.enabled,chain=1,interrupt_immediate=1,interrupt_if=action.void_bolt.usable\r\nyou can increase DPS even further to ~298k for the default S2M profile.\r\n\r\nThe latter change also increases the DPS of the default LotV profile by ~2.2k."},"comment":{"url":"https://api.github.com/repos/simulationcraft/simc/issues/comments/250155471","html_url":"https://github.com/simulationcraft/simc/issues/2870#issuecomment-250155471","issue_url":"https://api.github.com/repos/simulationcraft/simc/issues/2870","id":250155471,"user":{"login":"PhiNikM","id":9466217,"avatar_url":"https://avatars.githubusercontent.com/u/9466217?v=3","gravatar_id":"","url":"https://api.github.com/users/PhiNikM","html_url":"https://github.com/PhiNikM","followers_url":"https://api.github.com/users/PhiNikM/followers","following_url":"https://api.github.com/users/PhiNikM/following{/other_user}","gists_url":"https://api.github.com/users/PhiNikM/gists{/gist_id}","starred_url":"https://api.github.com/users/PhiNikM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhiNikM/subscriptions","organizations_url":"https://api.github.com/users/PhiNikM/orgs","repos_url":"https://api.github.com/users/PhiNikM/repos","events_url":"https://api.github.com/users/PhiNikM/events{/privacy}","received_events_url":"https://api.github.com/users/PhiNikM/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T12:42:51Z","updated_at":"2016-09-28T12:42:51Z","body":"Still not fixed even though it's literally changing two lines in the default APL?"}}
{"actor":{"display_login":"PhiNikM"}}