{"action":"created","issue":{"url":"https://api.github.com/repos/Temasys/AdapterJS/issues/211","repository_url":"https://api.github.com/repos/Temasys/AdapterJS","labels_url":"https://api.github.com/repos/Temasys/AdapterJS/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/Temasys/AdapterJS/issues/211/comments","events_url":"https://api.github.com/repos/Temasys/AdapterJS/issues/211/events","html_url":"https://github.com/Temasys/AdapterJS/pull/211","id":168941954,"number":211,"title":"Allow for pluginInfo overrides","user":{"login":"PetroccoCo","id":419926,"avatar_url":"https://avatars.githubusercontent.com/u/419926?v=3","gravatar_id":"","url":"https://api.github.com/users/PetroccoCo","html_url":"https://github.com/PetroccoCo","followers_url":"https://api.github.com/users/PetroccoCo/followers","following_url":"https://api.github.com/users/PetroccoCo/following{/other_user}","gists_url":"https://api.github.com/users/PetroccoCo/gists{/gist_id}","starred_url":"https://api.github.com/users/PetroccoCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetroccoCo/subscriptions","organizations_url":"https://api.github.com/users/PetroccoCo/orgs","repos_url":"https://api.github.com/users/PetroccoCo/repos","events_url":"https://api.github.com/users/PetroccoCo/events{/privacy}","received_events_url":"https://api.github.com/users/PetroccoCo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-02T17:26:47Z","updated_at":"2016-08-03T03:23:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Temasys/AdapterJS/pulls/211","html_url":"https://github.com/Temasys/AdapterJS/pull/211","diff_url":"https://github.com/Temasys/AdapterJS/pull/211.diff","patch_url":"https://github.com/Temasys/AdapterJS/pull/211.patch"},"body":"This changes allows the AdapterJS.WebRTCPlugin.pluginInfo object to be set externally via a shim.\r\nMaking it easier for organizations that have purchased a Temasys plugin to pull the latest AdapterJS without needed to maintain custom copies.\r\n\r\nFor those of you who are interested we are setting this information via a SystemJS shim like so,\r\nin the package.json overrides section:\r\n```javascript\r\n\"meta\": {\r\n  \"<path/to/adapter/file/inside/of/module>/adapter.js\": {\r\n    \"globals\": {\r\n      \"AdapterJS\": \"<path/to/your/shim/file>/adapterGlobalShim.js\"\r\n     },\r\n     \"format\": \"cjs\"\r\n   }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/Temasys/AdapterJS/issues/comments/237124606","html_url":"https://github.com/Temasys/AdapterJS/pull/211#issuecomment-237124606","issue_url":"https://api.github.com/repos/Temasys/AdapterJS/issues/211","id":237124606,"user":{"login":"johache","id":3684583,"avatar_url":"https://avatars.githubusercontent.com/u/3684583?v=3","gravatar_id":"","url":"https://api.github.com/users/johache","html_url":"https://github.com/johache","followers_url":"https://api.github.com/users/johache/followers","following_url":"https://api.github.com/users/johache/following{/other_user}","gists_url":"https://api.github.com/users/johache/gists{/gist_id}","starred_url":"https://api.github.com/users/johache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johache/subscriptions","organizations_url":"https://api.github.com/users/johache/orgs","repos_url":"https://api.github.com/users/johache/repos","events_url":"https://api.github.com/users/johache/events{/privacy}","received_events_url":"https://api.github.com/users/johache/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T03:23:09Z","updated_at":"2016-08-03T03:23:09Z","body":"Hi, first of, thanks for the pull request, always appreciated.\r\n\r\nPlease note that here is already a way of building custom AdapterJS. You can use : \r\ngrunt publish --pluginInfoRoot=pathToFolderContainingConfig --pluginInfoFile=configFileName.\r\nThe arguments respectively default to './source', and 'pluginInfo.js'\r\n\r\nI don't know if that removed the need for this feature for you. \r\nIf not, I have nothing against the idea, but here are a few changes that I need first: \r\n- please make PR to dev, not master,\r\n- AdapterJS.WebRTCPlugin.pluginInfo.downloadLink is optional. Just fill it with AdapterJS.WebRTCPlugin.pluginInfo.downloadLinks.mac/win, or leave it undefined.\r\n\r\nCheers,\r\nJ-O"}}
{"actor":{"display_login":"johache"}}