{"action":"opened","number":1259,"pull_request":{"url":"https://api.github.com/repos/emberjs/guides/pulls/1259","id":59257943,"html_url":"https://github.com/emberjs/guides/pull/1259","diff_url":"https://github.com/emberjs/guides/pull/1259.diff","patch_url":"https://github.com/emberjs/guides/pull/1259.patch","issue_url":"https://api.github.com/repos/emberjs/guides/issues/1259","number":1259,"state":"open","locked":false,"title":"a11y related tweaks to Templates -> Actions page","user":{"login":"noopkat","id":1411284,"avatar_url":"https://avatars.githubusercontent.com/u/1411284?v=3","gravatar_id":"","url":"https://api.github.com/users/noopkat","html_url":"https://github.com/noopkat","followers_url":"https://api.github.com/users/noopkat/followers","following_url":"https://api.github.com/users/noopkat/following{/other_user}","gists_url":"https://api.github.com/users/noopkat/gists{/gist_id}","starred_url":"https://api.github.com/users/noopkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noopkat/subscriptions","organizations_url":"https://api.github.com/users/noopkat/orgs","repos_url":"https://api.github.com/users/noopkat/repos","events_url":"https://api.github.com/users/noopkat/events{/privacy}","received_events_url":"https://api.github.com/users/noopkat/received_events","type":"User","site_admin":false},"body":"Hello! :wave: \r\n\r\nThe first example on the Actions page contains an accessibility anti-pattern. Specifically, placing the `action` on the `<h3>`. While the example is really effective at communicating \"you can place an action on any DOM element\" (which is powerful), I'd love to see the code snippet set a better example for good accessibility standards. It also doesn't strictly work as intended.\r\n\r\n**So what's the accessibility problem, anyway?**\r\n\r\nA couple of things: \r\n\r\n1. The heading on its own is not focusable without adding a `tabindex` property. \r\n\r\n2. Even when focusable, essentially only users utilizing a mouse can activate the `click` event and subsequent `toggleBody` action, whereas keyboard equivalents that normally also trigger the same `click` event will not work. \r\n\r\nThe above issues break the default browser behaviour, which is why sticking to 'clickable' elements is best for a correctly working example. See this [additional information](http://webaim.org/techniques/javascript/eventhandlers#onclick) if curious to know more.\r\n\r\nI created a [jsbin prototype](http://jsbin.com/riyoyo/edit?html,js,console,output) to illustrate exactly what I mean.\r\n\r\nI also proposed a clarification warning of this within the \"'Non-Clickable' Elements\" section at the bottom.\r\n\r\nThanks! :grin: ","created_at":"2016-02-13T04:09:43Z","updated_at":"2016-02-13T04:09:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db304053d3ec8bd51a80fd6c2b12e34897f94d1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/guides/pulls/1259/commits","review_comments_url":"https://api.github.com/repos/emberjs/guides/pulls/1259/comments","review_comment_url":"https://api.github.com/repos/emberjs/guides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/guides/issues/1259/comments","statuses_url":"https://api.github.com/repos/emberjs/guides/statuses/ddfb7a9f7446f5d32246b2e0cc12dff0490b8983","head":{"label":"noopkat:a11y-templates-actions-tweak","ref":"a11y-templates-actions-tweak","sha":"ddfb7a9f7446f5d32246b2e0cc12dff0490b8983","user":{"login":"noopkat","id":1411284,"avatar_url":"https://avatars.githubusercontent.com/u/1411284?v=3","gravatar_id":"","url":"https://api.github.com/users/noopkat","html_url":"https://github.com/noopkat","followers_url":"https://api.github.com/users/noopkat/followers","following_url":"https://api.github.com/users/noopkat/following{/other_user}","gists_url":"https://api.github.com/users/noopkat/gists{/gist_id}","starred_url":"https://api.github.com/users/noopkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noopkat/subscriptions","organizations_url":"https://api.github.com/users/noopkat/orgs","repos_url":"https://api.github.com/users/noopkat/repos","events_url":"https://api.github.com/users/noopkat/events{/privacy}","received_events_url":"https://api.github.com/users/noopkat/received_events","type":"User","site_admin":false},"repo":{"id":51625887,"name":"guides","full_name":"noopkat/guides","owner":{"login":"noopkat","id":1411284,"avatar_url":"https://avatars.githubusercontent.com/u/1411284?v=3","gravatar_id":"","url":"https://api.github.com/users/noopkat","html_url":"https://github.com/noopkat","followers_url":"https://api.github.com/users/noopkat/followers","following_url":"https://api.github.com/users/noopkat/following{/other_user}","gists_url":"https://api.github.com/users/noopkat/gists{/gist_id}","starred_url":"https://api.github.com/users/noopkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noopkat/subscriptions","organizations_url":"https://api.github.com/users/noopkat/orgs","repos_url":"https://api.github.com/users/noopkat/repos","events_url":"https://api.github.com/users/noopkat/events{/privacy}","received_events_url":"https://api.github.com/users/noopkat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noopkat/guides","description":"The source for http://guides.emberjs.com","fork":true,"url":"https://api.github.com/repos/noopkat/guides","forks_url":"https://api.github.com/repos/noopkat/guides/forks","keys_url":"https://api.github.com/repos/noopkat/guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noopkat/guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noopkat/guides/teams","hooks_url":"https://api.github.com/repos/noopkat/guides/hooks","issue_events_url":"https://api.github.com/repos/noopkat/guides/issues/events{/number}","events_url":"https://api.github.com/repos/noopkat/guides/events","assignees_url":"https://api.github.com/repos/noopkat/guides/assignees{/user}","branches_url":"https://api.github.com/repos/noopkat/guides/branches{/branch}","tags_url":"https://api.github.com/repos/noopkat/guides/tags","blobs_url":"https://api.github.com/repos/noopkat/guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noopkat/guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noopkat/guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/noopkat/guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noopkat/guides/statuses/{sha}","languages_url":"https://api.github.com/repos/noopkat/guides/languages","stargazers_url":"https://api.github.com/repos/noopkat/guides/stargazers","contributors_url":"https://api.github.com/repos/noopkat/guides/contributors","subscribers_url":"https://api.github.com/repos/noopkat/guides/subscribers","subscription_url":"https://api.github.com/repos/noopkat/guides/subscription","commits_url":"https://api.github.com/repos/noopkat/guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/noopkat/guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/noopkat/guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/noopkat/guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/noopkat/guides/contents/{+path}","compare_url":"https://api.github.com/repos/noopkat/guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noopkat/guides/merges","archive_url":"https://api.github.com/repos/noopkat/guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noopkat/guides/downloads","issues_url":"https://api.github.com/repos/noopkat/guides/issues{/number}","pulls_url":"https://api.github.com/repos/noopkat/guides/pulls{/number}","milestones_url":"https://api.github.com/repos/noopkat/guides/milestones{/number}","notifications_url":"https://api.github.com/repos/noopkat/guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noopkat/guides/labels{/name}","releases_url":"https://api.github.com/repos/noopkat/guides/releases{/id}","deployments_url":"https://api.github.com/repos/noopkat/guides/deployments","created_at":"2016-02-13T00:50:44Z","updated_at":"2016-02-13T00:50:46Z","pushed_at":"2016-02-13T03:29:21Z","git_url":"git://github.com/noopkat/guides.git","ssh_url":"git@github.com:noopkat/guides.git","clone_url":"https://github.com/noopkat/guides.git","svn_url":"https://github.com/noopkat/guides","homepage":null,"size":27497,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"8fc11acb9057dfa47f41ca315f537be95aa17a41","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":22767401,"name":"guides","full_name":"emberjs/guides","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/guides","description":"The source for http://guides.emberjs.com","fork":false,"url":"https://api.github.com/repos/emberjs/guides","forks_url":"https://api.github.com/repos/emberjs/guides/forks","keys_url":"https://api.github.com/repos/emberjs/guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/guides/teams","hooks_url":"https://api.github.com/repos/emberjs/guides/hooks","issue_events_url":"https://api.github.com/repos/emberjs/guides/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/guides/events","assignees_url":"https://api.github.com/repos/emberjs/guides/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/guides/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/guides/tags","blobs_url":"https://api.github.com/repos/emberjs/guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/guides/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/guides/languages","stargazers_url":"https://api.github.com/repos/emberjs/guides/stargazers","contributors_url":"https://api.github.com/repos/emberjs/guides/contributors","subscribers_url":"https://api.github.com/repos/emberjs/guides/subscribers","subscription_url":"https://api.github.com/repos/emberjs/guides/subscription","commits_url":"https://api.github.com/repos/emberjs/guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/guides/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/guides/merges","archive_url":"https://api.github.com/repos/emberjs/guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/guides/downloads","issues_url":"https://api.github.com/repos/emberjs/guides/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/guides/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/guides/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/guides/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/guides/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/guides/deployments","created_at":"2014-08-08T18:25:02Z","updated_at":"2016-02-12T19:40:20Z","pushed_at":"2016-02-13T04:09:45Z","git_url":"git://github.com/emberjs/guides.git","ssh_url":"git@github.com:emberjs/guides.git","clone_url":"https://github.com/emberjs/guides.git","svn_url":"https://github.com/emberjs/guides","homepage":null,"size":28422,"stargazers_count":179,"watchers_count":179,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":48,"forks":588,"open_issues":48,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/guides/pulls/1259"},"html":{"href":"https://github.com/emberjs/guides/pull/1259"},"issue":{"href":"https://api.github.com/repos/emberjs/guides/issues/1259"},"comments":{"href":"https://api.github.com/repos/emberjs/guides/issues/1259/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/guides/pulls/1259/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/guides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/guides/pulls/1259/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/guides/statuses/ddfb7a9f7446f5d32246b2e0cc12dff0490b8983"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":1}}