{"push_id":1361558577,"size":2,"distinct_size":0,"ref":"refs/heads/master","head":"776a1d9cacdd929e9ef6189bfffc9513e57b76ce","before":"e3ebbd0fcdc78901c214d00cd11743a8fcf2d320","commits":[{"sha":"4f0ffbd1f6908818e06538797b30f86ffef13602","author":{"name":"Jesse Kipp","email":"5b470556e0054ac9cfa3918693bfafd5ecfa8304@gmail.com"},"message":"Issue 13363 - Step 1.2 of compiling event handler\n\nWhen compiling event handlers, check whether scripting is enabled\nand early return None/null if not.\n\nhttps://html.spec.whatwg.org/multipage/\nwebappapis.html#getting-the-current-value-of-the-event-handler\n\nIssue 13363 - Fix spec for disabled scripting\n\nThe original spec for this PR was bad because it depended on the\nDOM without scripting enabled to use Javascript to signal the test's\nfailure, so it could never fail.\n\nUse an onerror handler on `window` where scripting is enabled, and\nuse an invalid string of JavaScript for the handler, to detect\nwhether or not the event handler is *really* being compiled or not.\n\nCondense tests into a single HTML file\n\nYup, didn't even realize I could do that at the time.\n\nRemove an unnecessary test","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/4f0ffbd1f6908818e06538797b30f86ffef13602"},{"sha":"776a1d9cacdd929e9ef6189bfffc9513e57b76ce","author":{"name":"bors-servo","email":"b09d4f4a3e19bc290c035b624e2133ac70195a90@mozilla.com"},"message":"Auto merge of #13784 - TooManyBees:13363-check-script-enabled, r=Ms2ger\n\nIssue 13363 - Step 1.2 of compiling event handler\n\n<!-- Please describe your changes on the following line: -->\nAdds the conditional to test that scripting is enabled in `EventTarget#get_compiled_event_handler`, and return `None` early if not.\n\nAdds tests for \"scripting enabled\" and \"scripting disabled\" cases.\n\n---\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\n- [x] `./mach build -d` does not report any errors\n- [x] `./mach test-tidy` does not report any errors\n- [x] These changes fix #13363 (github issue number if applicable).\n\n<!-- Either: -->\n- [x] There are tests for these changes\n\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13784)\n<!-- Reviewable:end -->","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/776a1d9cacdd929e9ef6189bfffc9513e57b76ce"}]}
{"actor":{"display_login":"bors-servo"}}