{"action":"created","issue":{"url":"https://api.github.com/repos/lerna/lerna/issues/229","repository_url":"https://api.github.com/repos/lerna/lerna","labels_url":"https://api.github.com/repos/lerna/lerna/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/lerna/lerna/issues/229/comments","events_url":"https://api.github.com/repos/lerna/lerna/issues/229/events","html_url":"https://github.com/lerna/lerna/issues/229","id":160943808,"number":229,"title":"Not passing a value for `--repo-version` sets the package.json version to `true`","user":{"login":"jeffdavidgreen","id":1170853,"avatar_url":"https://avatars.githubusercontent.com/u/1170853?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdavidgreen","html_url":"https://github.com/jeffdavidgreen","followers_url":"https://api.github.com/users/jeffdavidgreen/followers","following_url":"https://api.github.com/users/jeffdavidgreen/following{/other_user}","gists_url":"https://api.github.com/users/jeffdavidgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdavidgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdavidgreen/subscriptions","organizations_url":"https://api.github.com/users/jeffdavidgreen/orgs","repos_url":"https://api.github.com/users/jeffdavidgreen/repos","events_url":"https://api.github.com/users/jeffdavidgreen/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdavidgreen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-17T18:05:09Z","updated_at":"2016-06-20T22:12:07Z","closed_at":null,"body":"In `PublishCommand.js`, when setting the flag for `--repo-version`, if you don't set a value for the version, it changes all the updated packages version numbers to true.\r\n\r\nThe code I'm referring to is here:\r\n```javascript\r\nif (this.flags.repoVersion) {\r\n    return callback(null, {\r\n        version: this.flags.repoVersion\r\n    });\r\n}\r\n```\r\nThe command I ran is `lerna publish --repo-version`. I was thinking about this and I assumed that if I did not specify a version, then maybe the code could use the version found in each `package.json` file for the individual packages in the repo. For our workflow, we cannot have the prompts for the deployment scripts, so we were thinking about having developers increment the versions manually using `lerna publish --skip-npm` and then running on the build and deployment server `lerna bootstrap && lerna publish --skip-git --yes --repo-version`, but then we ran across this problem.\r\n\r\nOne solution I thought of is to include logic where if you don't add a version number as a value for `--repo-version`, then it will use the package.json version for each package.\r\n\r\nThe other solution is to include a new flag like `--package-version` that will do what I'm hoping to accomplish. "},"comment":{"url":"https://api.github.com/repos/lerna/lerna/issues/comments/227285761","html_url":"https://github.com/lerna/lerna/issues/229#issuecomment-227285761","issue_url":"https://api.github.com/repos/lerna/lerna/issues/229","id":227285761,"user":{"login":"davidfateh","id":4086109,"avatar_url":"https://avatars.githubusercontent.com/u/4086109?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfateh","html_url":"https://github.com/davidfateh","followers_url":"https://api.github.com/users/davidfateh/followers","following_url":"https://api.github.com/users/davidfateh/following{/other_user}","gists_url":"https://api.github.com/users/davidfateh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfateh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfateh/subscriptions","organizations_url":"https://api.github.com/users/davidfateh/orgs","repos_url":"https://api.github.com/users/davidfateh/repos","events_url":"https://api.github.com/users/davidfateh/events{/privacy}","received_events_url":"https://api.github.com/users/davidfateh/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T22:12:07Z","updated_at":"2016-06-20T22:12:07Z","body":"A commit prefix might be helpful for when a user wants to update a version but doesn't want to use the prompt... Let's say the dev makes a PR, updates a package version and simply wants to use Lerna to then publish that package after the PR (with version number) has been approved."}}
{"actor":{"display_login":"davidfateh"}}