{"action":"created","comment":{"url":"https://api.github.com/repos/respoke/chan_respoke/pulls/comments/51942019","id":51942019,"diff_hunk":"@@ -680,12 +680,17 @@ static struct ast_json *sdp_media_rtp_to_json(\n \tint payload, struct ast_format *format)\n {\n \tconst char *codec = ast_rtp_lookup_mime_subtype2(1, format, 0, 0);\n+\tstruct ast_str *rate = ast_str_create(128);\n+\n+\tast_str_set(&rate, 128, \"%i%s\", ast_rtp_lookup_sample_rate2(1, format, -1), (strcmp(codec, \"opus\")) ? \"\" : \"/2\" );\n \n \treturn ast_json_pack(\n-\t\t\"{s:i,s:s,s:i}\",\n+\t\t\"{s:i,s:s,s:s}\",\n \t\t\"payload\", payload,\n \t\t\"codec\", codec,\n-\t\t\"rate\", ast_rtp_lookup_sample_rate2(1, format, 0));\n+\t\t\"rate\", ast_str_buffer(rate));","path":"res/res_respoke/respoke_message_json.c","position":14,"original_position":14,"commit_id":"1f3a81bbae52c367ca8770965213f62528d837a4","original_commit_id":"1f3a81bbae52c367ca8770965213f62528d837a4","user":{"login":"kharwell","id":6953356,"avatar_url":"https://avatars.githubusercontent.com/u/6953356?v=3","gravatar_id":"","url":"https://api.github.com/users/kharwell","html_url":"https://github.com/kharwell","followers_url":"https://api.github.com/users/kharwell/followers","following_url":"https://api.github.com/users/kharwell/following{/other_user}","gists_url":"https://api.github.com/users/kharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/kharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kharwell/subscriptions","organizations_url":"https://api.github.com/users/kharwell/orgs","repos_url":"https://api.github.com/users/kharwell/repos","events_url":"https://api.github.com/users/kharwell/events{/privacy}","received_events_url":"https://api.github.com/users/kharwell/received_events","type":"User","site_admin":false},"body":"Note, someone more familiar with the latest version of the signaling protocol should validate my assumption.","created_at":"2016-02-04T21:40:47Z","updated_at":"2016-02-04T21:40:47Z","html_url":"https://github.com/respoke/chan_respoke/pull/19#discussion_r51942019","pull_request_url":"https://api.github.com/repos/respoke/chan_respoke/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/respoke/chan_respoke/pulls/comments/51942019"},"html":{"href":"https://github.com/respoke/chan_respoke/pull/19#discussion_r51942019"},"pull_request":{"href":"https://api.github.com/repos/respoke/chan_respoke/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/respoke/chan_respoke/pulls/19","id":56149779,"html_url":"https://github.com/respoke/chan_respoke/pull/19","diff_url":"https://github.com/respoke/chan_respoke/pull/19.diff","patch_url":"https://github.com/respoke/chan_respoke/pull/19.patch","issue_url":"https://api.github.com/repos/respoke/chan_respoke/issues/19","number":19,"state":"open","locked":false,"title":"Chrome and Firefox require that Opus rtpmap has rate 48000/2.","user":{"login":"elbow","id":107606,"avatar_url":"https://avatars.githubusercontent.com/u/107606?v=3","gravatar_id":"","url":"https://api.github.com/users/elbow","html_url":"https://github.com/elbow","followers_url":"https://api.github.com/users/elbow/followers","following_url":"https://api.github.com/users/elbow/following{/other_user}","gists_url":"https://api.github.com/users/elbow/gists{/gist_id}","starred_url":"https://api.github.com/users/elbow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elbow/subscriptions","organizations_url":"https://api.github.com/users/elbow/orgs","repos_url":"https://api.github.com/users/elbow/repos","events_url":"https://api.github.com/users/elbow/events{/privacy}","received_events_url":"https://api.github.com/users/elbow/received_events","type":"User","site_admin":false},"body":"chan_respoke could not successfully negotiate Opus with Chrome or Firefox.\r\nTurns out that Chrome/Firefox require that the rtpmap line for Opus states 48000/2\r\n","created_at":"2016-01-15T09:58:00Z","updated_at":"2016-02-04T21:40:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb9fae66c6c667a1059ce20bb258c93544f9d358","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/respoke/chan_respoke/pulls/19/commits","review_comments_url":"https://api.github.com/repos/respoke/chan_respoke/pulls/19/comments","review_comment_url":"https://api.github.com/repos/respoke/chan_respoke/pulls/comments{/number}","comments_url":"https://api.github.com/repos/respoke/chan_respoke/issues/19/comments","statuses_url":"https://api.github.com/repos/respoke/chan_respoke/statuses/1f3a81bbae52c367ca8770965213f62528d837a4","head":{"label":"Connection-Telecom:master","ref":"master","sha":"1f3a81bbae52c367ca8770965213f62528d837a4","user":{"login":"Connection-Telecom","id":736152,"avatar_url":"https://avatars.githubusercontent.com/u/736152?v=3","gravatar_id":"","url":"https://api.github.com/users/Connection-Telecom","html_url":"https://github.com/Connection-Telecom","followers_url":"https://api.github.com/users/Connection-Telecom/followers","following_url":"https://api.github.com/users/Connection-Telecom/following{/other_user}","gists_url":"https://api.github.com/users/Connection-Telecom/gists{/gist_id}","starred_url":"https://api.github.com/users/Connection-Telecom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connection-Telecom/subscriptions","organizations_url":"https://api.github.com/users/Connection-Telecom/orgs","repos_url":"https://api.github.com/users/Connection-Telecom/repos","events_url":"https://api.github.com/users/Connection-Telecom/events{/privacy}","received_events_url":"https://api.github.com/users/Connection-Telecom/received_events","type":"Organization","site_admin":false},"repo":{"id":49709615,"name":"chan_respoke","full_name":"Connection-Telecom/chan_respoke","owner":{"login":"Connection-Telecom","id":736152,"avatar_url":"https://avatars.githubusercontent.com/u/736152?v=3","gravatar_id":"","url":"https://api.github.com/users/Connection-Telecom","html_url":"https://github.com/Connection-Telecom","followers_url":"https://api.github.com/users/Connection-Telecom/followers","following_url":"https://api.github.com/users/Connection-Telecom/following{/other_user}","gists_url":"https://api.github.com/users/Connection-Telecom/gists{/gist_id}","starred_url":"https://api.github.com/users/Connection-Telecom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connection-Telecom/subscriptions","organizations_url":"https://api.github.com/users/Connection-Telecom/orgs","repos_url":"https://api.github.com/users/Connection-Telecom/repos","events_url":"https://api.github.com/users/Connection-Telecom/events{/privacy}","received_events_url":"https://api.github.com/users/Connection-Telecom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Connection-Telecom/chan_respoke","description":"Asterisk Channel Driver for Respoke","fork":true,"url":"https://api.github.com/repos/Connection-Telecom/chan_respoke","forks_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/forks","keys_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/teams","hooks_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/hooks","issue_events_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/issues/events{/number}","events_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/events","assignees_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/assignees{/user}","branches_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/branches{/branch}","tags_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/tags","blobs_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/git/refs{/sha}","trees_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/statuses/{sha}","languages_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/languages","stargazers_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/stargazers","contributors_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/contributors","subscribers_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/subscribers","subscription_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/subscription","commits_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/commits{/sha}","git_commits_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/git/commits{/sha}","comments_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/comments{/number}","issue_comment_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/issues/comments{/number}","contents_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/contents/{+path}","compare_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/merges","archive_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/downloads","issues_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/issues{/number}","pulls_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/pulls{/number}","milestones_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/milestones{/number}","notifications_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/labels{/name}","releases_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/releases{/id}","deployments_url":"https://api.github.com/repos/Connection-Telecom/chan_respoke/deployments","created_at":"2016-01-15T09:30:50Z","updated_at":"2016-01-15T09:30:50Z","pushed_at":"2016-01-15T09:41:01Z","git_url":"git://github.com/Connection-Telecom/chan_respoke.git","ssh_url":"git@github.com:Connection-Telecom/chan_respoke.git","clone_url":"https://github.com/Connection-Telecom/chan_respoke.git","svn_url":"https://github.com/Connection-Telecom/chan_respoke","homepage":"","size":684,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"respoke:master","ref":"master","sha":"e89fd769f196a0b641c5e53752b2b311231fdd87","user":{"login":"respoke","id":7663021,"avatar_url":"https://avatars.githubusercontent.com/u/7663021?v=3","gravatar_id":"","url":"https://api.github.com/users/respoke","html_url":"https://github.com/respoke","followers_url":"https://api.github.com/users/respoke/followers","following_url":"https://api.github.com/users/respoke/following{/other_user}","gists_url":"https://api.github.com/users/respoke/gists{/gist_id}","starred_url":"https://api.github.com/users/respoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/respoke/subscriptions","organizations_url":"https://api.github.com/users/respoke/orgs","repos_url":"https://api.github.com/users/respoke/repos","events_url":"https://api.github.com/users/respoke/events{/privacy}","received_events_url":"https://api.github.com/users/respoke/received_events","type":"Organization","site_admin":false},"repo":{"id":25363696,"name":"chan_respoke","full_name":"respoke/chan_respoke","owner":{"login":"respoke","id":7663021,"avatar_url":"https://avatars.githubusercontent.com/u/7663021?v=3","gravatar_id":"","url":"https://api.github.com/users/respoke","html_url":"https://github.com/respoke","followers_url":"https://api.github.com/users/respoke/followers","following_url":"https://api.github.com/users/respoke/following{/other_user}","gists_url":"https://api.github.com/users/respoke/gists{/gist_id}","starred_url":"https://api.github.com/users/respoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/respoke/subscriptions","organizations_url":"https://api.github.com/users/respoke/orgs","repos_url":"https://api.github.com/users/respoke/repos","events_url":"https://api.github.com/users/respoke/events{/privacy}","received_events_url":"https://api.github.com/users/respoke/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/respoke/chan_respoke","description":"Asterisk Channel Driver for Respoke","fork":false,"url":"https://api.github.com/repos/respoke/chan_respoke","forks_url":"https://api.github.com/repos/respoke/chan_respoke/forks","keys_url":"https://api.github.com/repos/respoke/chan_respoke/keys{/key_id}","collaborators_url":"https://api.github.com/repos/respoke/chan_respoke/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/respoke/chan_respoke/teams","hooks_url":"https://api.github.com/repos/respoke/chan_respoke/hooks","issue_events_url":"https://api.github.com/repos/respoke/chan_respoke/issues/events{/number}","events_url":"https://api.github.com/repos/respoke/chan_respoke/events","assignees_url":"https://api.github.com/repos/respoke/chan_respoke/assignees{/user}","branches_url":"https://api.github.com/repos/respoke/chan_respoke/branches{/branch}","tags_url":"https://api.github.com/repos/respoke/chan_respoke/tags","blobs_url":"https://api.github.com/repos/respoke/chan_respoke/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/respoke/chan_respoke/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/respoke/chan_respoke/git/refs{/sha}","trees_url":"https://api.github.com/repos/respoke/chan_respoke/git/trees{/sha}","statuses_url":"https://api.github.com/repos/respoke/chan_respoke/statuses/{sha}","languages_url":"https://api.github.com/repos/respoke/chan_respoke/languages","stargazers_url":"https://api.github.com/repos/respoke/chan_respoke/stargazers","contributors_url":"https://api.github.com/repos/respoke/chan_respoke/contributors","subscribers_url":"https://api.github.com/repos/respoke/chan_respoke/subscribers","subscription_url":"https://api.github.com/repos/respoke/chan_respoke/subscription","commits_url":"https://api.github.com/repos/respoke/chan_respoke/commits{/sha}","git_commits_url":"https://api.github.com/repos/respoke/chan_respoke/git/commits{/sha}","comments_url":"https://api.github.com/repos/respoke/chan_respoke/comments{/number}","issue_comment_url":"https://api.github.com/repos/respoke/chan_respoke/issues/comments{/number}","contents_url":"https://api.github.com/repos/respoke/chan_respoke/contents/{+path}","compare_url":"https://api.github.com/repos/respoke/chan_respoke/compare/{base}...{head}","merges_url":"https://api.github.com/repos/respoke/chan_respoke/merges","archive_url":"https://api.github.com/repos/respoke/chan_respoke/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/respoke/chan_respoke/downloads","issues_url":"https://api.github.com/repos/respoke/chan_respoke/issues{/number}","pulls_url":"https://api.github.com/repos/respoke/chan_respoke/pulls{/number}","milestones_url":"https://api.github.com/repos/respoke/chan_respoke/milestones{/number}","notifications_url":"https://api.github.com/repos/respoke/chan_respoke/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/respoke/chan_respoke/labels{/name}","releases_url":"https://api.github.com/repos/respoke/chan_respoke/releases{/id}","deployments_url":"https://api.github.com/repos/respoke/chan_respoke/deployments","created_at":"2014-10-17T15:11:01Z","updated_at":"2015-10-16T20:55:24Z","pushed_at":"2016-01-15T09:58:00Z","git_url":"git://github.com/respoke/chan_respoke.git","ssh_url":"git@github.com:respoke/chan_respoke.git","clone_url":"https://github.com/respoke/chan_respoke.git","svn_url":"https://github.com/respoke/chan_respoke","homepage":"","size":701,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/respoke/chan_respoke/pulls/19"},"html":{"href":"https://github.com/respoke/chan_respoke/pull/19"},"issue":{"href":"https://api.github.com/repos/respoke/chan_respoke/issues/19"},"comments":{"href":"https://api.github.com/repos/respoke/chan_respoke/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/respoke/chan_respoke/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/respoke/chan_respoke/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/respoke/chan_respoke/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/respoke/chan_respoke/statuses/1f3a81bbae52c367ca8770965213f62528d837a4"}}}}