{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4156","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4156/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4156/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4156/events","html_url":"https://github.com/RobotLocomotion/drake/pull/4156","id":190170660,"number":4156,"title":"Fix BUILD file to track master","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-17T21:33:49Z","updated_at":"2016-11-18T14:10:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4156","html_url":"https://github.com/RobotLocomotion/drake/pull/4156","diff_url":"https://github.com/RobotLocomotion/drake/pull/4156.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/4156.patch"},"body":"The Symbolic changes to build system needed an update in Bazel.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/4156)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/261540054","html_url":"https://github.com/RobotLocomotion/drake/pull/4156#issuecomment-261540054","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4156","id":261540054,"user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T14:10:29Z","updated_at":"2016-11-18T14:10:29Z","body":"PTAL.\n\n---\n\nReview status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[drake/common/BUILD, line 31 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/4156#-KWoIB0ENDw6S4X7oS9S:-KWrlGAsfo-RX_C_cmDH:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/ccb06627fb91b8d86bd05035a786fa0897133472/drake/common/BUILD#L31)):*\n<details><summary><i>Previously, david-german-tri (David German) wrote…</i></summary>\n> I don't understand what this comment is trying to say.\n</details>\nDone.\n\n---\n\n*[drake/common/BUILD, line 36 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/4156#-KWoINjke6EPiXoVoNQH:-KWrlHLXc_8CNjv0e8dq:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/ccb06627fb91b8d86bd05035a786fa0897133472/drake/common/BUILD#L36)):*\n<details><summary><i>Previously, david-german-tri (David German) wrote…</i></summary>\n> These two things seem only loosely related to each other; why not two separate targets?\n</details>\nDone.\n\n---\n\n*[drake/common/BUILD, line 43 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/4156#-KWoHoKTjrphFEfLecZV:-KWrlI8k92oxBsNcxRxa:b-damazd) ([raw file](https://github.com/robotlocomotion/drake/blob/ccb06627fb91b8d86bd05035a786fa0897133472/drake/common/BUILD#L43)):*\n<details><summary><i>Previously, david-german-tri (David German) wrote…</i></summary>\n> The evolving-DEPS paradigm is kind of hard to read.  Consider naming this SCALARTYPE_DEPS or similar.\n</details>\nYeah.  For `common/` I think the DEPS pattern is net-negative value.  Removed entirely.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/4156#-:-KWrlWJ8J0Y7xVeXDqxD:b-83330m)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jwnimmer-tri"}}