{"action":"closed","number":1955,"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1955","id":75219799,"html_url":"https://github.com/php/php-src/pull/1955","diff_url":"https://github.com/php/php-src/pull/1955.diff","patch_url":"https://github.com/php/php-src/pull/1955.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/1955","number":1955,"state":"closed","locked":false,"title":"Fix Bug # 72021 - Make LDAP_ESCAPE_DN compliant with RFC 4514","user":{"login":"ChadSikorra","id":388229,"avatar_url":"https://avatars.githubusercontent.com/u/388229?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadSikorra","html_url":"https://github.com/ChadSikorra","followers_url":"https://api.github.com/users/ChadSikorra/followers","following_url":"https://api.github.com/users/ChadSikorra/following{/other_user}","gists_url":"https://api.github.com/users/ChadSikorra/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadSikorra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadSikorra/subscriptions","organizations_url":"https://api.github.com/users/ChadSikorra/orgs","repos_url":"https://api.github.com/users/ChadSikorra/repos","events_url":"https://api.github.com/users/ChadSikorra/events{/privacy}","received_events_url":"https://api.github.com/users/ChadSikorra/received_events","type":"User","site_admin":false},"body":"This fixes `ldap_escape` when used with `LDAP_ESCAPE_DN`. The current version does not escape carriage returns or leading/trailing spaces, which are both mentioned in RFC 4514:\r\n\r\nhttps://www.ietf.org/rfc/rfc4514.txt\r\n\r\nOne caveat to this is that it will not ignore escaping the leading/trailing spaces even if specified by the second argument for `ldap_escape` (as the escaping is conditional depending on the position of the space character).\r\n\r\nI also mentioned this to @DaveRandom who it seems wrote the original `ldap_escape` function, though I'm not sure if he is still active with PHP anymore.\r\n\r\nhttp://stackoverflow.com/a/8561604/2242593\r\n\r\nI also wasn't sure what branch to target this at, and I'm not really a C programmer, just interested in fixing some of the LDAP related bugs/features.","created_at":"2016-06-26T02:40:39Z","updated_at":"2016-07-07T03:54:33Z","closed_at":"2016-07-07T03:54:33Z","merged_at":"2016-07-07T03:54:33Z","merge_commit_sha":"b1d82607e6ce3ec30525a49844e914f7194f8b40","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/1955/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/1955/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/1955/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/b1d82607e6ce3ec30525a49844e914f7194f8b40","head":{"label":"ChadSikorra:fix-ldap-escape","ref":"fix-ldap-escape","sha":"b1d82607e6ce3ec30525a49844e914f7194f8b40","user":{"login":"ChadSikorra","id":388229,"avatar_url":"https://avatars.githubusercontent.com/u/388229?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadSikorra","html_url":"https://github.com/ChadSikorra","followers_url":"https://api.github.com/users/ChadSikorra/followers","following_url":"https://api.github.com/users/ChadSikorra/following{/other_user}","gists_url":"https://api.github.com/users/ChadSikorra/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadSikorra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadSikorra/subscriptions","organizations_url":"https://api.github.com/users/ChadSikorra/orgs","repos_url":"https://api.github.com/users/ChadSikorra/repos","events_url":"https://api.github.com/users/ChadSikorra/events{/privacy}","received_events_url":"https://api.github.com/users/ChadSikorra/received_events","type":"User","site_admin":false},"repo":{"id":56191973,"name":"php-src","full_name":"ChadSikorra/php-src","owner":{"login":"ChadSikorra","id":388229,"avatar_url":"https://avatars.githubusercontent.com/u/388229?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadSikorra","html_url":"https://github.com/ChadSikorra","followers_url":"https://api.github.com/users/ChadSikorra/followers","following_url":"https://api.github.com/users/ChadSikorra/following{/other_user}","gists_url":"https://api.github.com/users/ChadSikorra/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadSikorra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadSikorra/subscriptions","organizations_url":"https://api.github.com/users/ChadSikorra/orgs","repos_url":"https://api.github.com/users/ChadSikorra/repos","events_url":"https://api.github.com/users/ChadSikorra/events{/privacy}","received_events_url":"https://api.github.com/users/ChadSikorra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChadSikorra/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/ChadSikorra/php-src","forks_url":"https://api.github.com/repos/ChadSikorra/php-src/forks","keys_url":"https://api.github.com/repos/ChadSikorra/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChadSikorra/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChadSikorra/php-src/teams","hooks_url":"https://api.github.com/repos/ChadSikorra/php-src/hooks","issue_events_url":"https://api.github.com/repos/ChadSikorra/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/ChadSikorra/php-src/events","assignees_url":"https://api.github.com/repos/ChadSikorra/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/ChadSikorra/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/ChadSikorra/php-src/tags","blobs_url":"https://api.github.com/repos/ChadSikorra/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChadSikorra/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChadSikorra/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChadSikorra/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChadSikorra/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/ChadSikorra/php-src/languages","stargazers_url":"https://api.github.com/repos/ChadSikorra/php-src/stargazers","contributors_url":"https://api.github.com/repos/ChadSikorra/php-src/contributors","subscribers_url":"https://api.github.com/repos/ChadSikorra/php-src/subscribers","subscription_url":"https://api.github.com/repos/ChadSikorra/php-src/subscription","commits_url":"https://api.github.com/repos/ChadSikorra/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChadSikorra/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChadSikorra/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChadSikorra/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChadSikorra/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/ChadSikorra/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChadSikorra/php-src/merges","archive_url":"https://api.github.com/repos/ChadSikorra/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChadSikorra/php-src/downloads","issues_url":"https://api.github.com/repos/ChadSikorra/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/ChadSikorra/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/ChadSikorra/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/ChadSikorra/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChadSikorra/php-src/labels{/name}","releases_url":"https://api.github.com/repos/ChadSikorra/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/ChadSikorra/php-src/deployments","created_at":"2016-04-13T23:09:31Z","updated_at":"2016-04-13T23:10:25Z","pushed_at":"2016-06-29T12:38:00Z","git_url":"git://github.com/ChadSikorra/php-src.git","ssh_url":"git@github.com:ChadSikorra/php-src.git","clone_url":"https://github.com/ChadSikorra/php-src.git","svn_url":"https://github.com/ChadSikorra/php-src","homepage":"http://www.php.net","size":253498,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"8de8636a2b6dc331486284f1f037259bb7347768","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2016-07-06T23:28:20Z","pushed_at":"2016-07-07T03:53:59Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":399552,"stargazers_count":9474,"watchers_count":9474,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3313,"mirror_url":null,"open_issues_count":333,"forks":3313,"open_issues":333,"watchers":9474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/1955"},"html":{"href":"https://github.com/php/php-src/pull/1955"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/1955"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/1955/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/1955/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/1955/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/b1d82607e6ce3ec30525a49844e914f7194f8b40"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"php-pulls","id":1406938,"avatar_url":"https://avatars.githubusercontent.com/u/1406938?v=3","gravatar_id":"","url":"https://api.github.com/users/php-pulls","html_url":"https://github.com/php-pulls","followers_url":"https://api.github.com/users/php-pulls/followers","following_url":"https://api.github.com/users/php-pulls/following{/other_user}","gists_url":"https://api.github.com/users/php-pulls/gists{/gist_id}","starred_url":"https://api.github.com/users/php-pulls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-pulls/subscriptions","organizations_url":"https://api.github.com/users/php-pulls/orgs","repos_url":"https://api.github.com/users/php-pulls/repos","events_url":"https://api.github.com/users/php-pulls/events{/privacy}","received_events_url":"https://api.github.com/users/php-pulls/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":5,"additions":25,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"php-pulls"}}