{"action":"created","comment":{"url":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/comments/85885288","pull_request_review_id":6572421,"id":85885288,"diff_hunk":"@@ -329,6 +351,160 @@ transformCypherMatchClause(ParseState *pstate, CypherClause *clause)\n \treturn qry;\n }\n \n+/* See transformFromClauseItem() */\n+static RangeTblEntry *\n+transformOptionalClause(ParseState *pstate, CypherClause *clause)\n+{\n+\tCypherMatchClause *detail = (CypherMatchClause *) clause->detail;\n+\tJoinExpr   *j = makeNode(JoinExpr);\n+\tAlias\t   *l_alias;\n+\tRangeTblEntry *l_rte;\n+\tParseNamespaceItem *l_nsitem;\n+\tNode\t   *prevclause;\n+\tAlias\t   *r_alias;\n+\tRangeTblEntry *r_rte;\n+\tParseNamespaceItem *r_nsitem;\n+\tList\t   *res_colnames = NIL;\n+\tList\t   *res_colvars = NIL;\n+\tRangeTblEntry *rte;\n+\tParseNamespaceItem *nsitem;\n+\tint\t\t\ti;\n+\n+\tj->jointype = JOIN_LEFT;\n+\n+\t/* transform LEFT */\n+\tl_alias = makeAliasNoDup(CYPHER_OPTLEFT_ALIAS, NIL);\n+\tj->larg = transformClauseJoin(pstate, clause->prev, l_alias, &l_rte,\n+\t\t\t\t\t\t\t\t  &l_nsitem);\n+\n+\t/* temporal namespace for RIGHT */\n+\tAssert(pstate->p_namespace == NIL);\n+\tpstate->p_namespace = lappend(pstate->p_namespace, l_nsitem);\n+\n+\t/* Transform RIGHT. Prevent `claus`e from being transformed infinitely. */","path":"src/backend/parser/parse_graph.c","position":182,"original_position":182,"commit_id":"09206f5a4856052258c23d977580e2b07087877e","original_commit_id":"09206f5a4856052258c23d977580e2b07087877e","user":{"login":"htlim","id":13131869,"avatar_url":"https://avatars.githubusercontent.com/u/13131869?v=3","gravatar_id":"","url":"https://api.github.com/users/htlim","html_url":"https://github.com/htlim","followers_url":"https://api.github.com/users/htlim/followers","following_url":"https://api.github.com/users/htlim/following{/other_user}","gists_url":"https://api.github.com/users/htlim/gists{/gist_id}","starred_url":"https://api.github.com/users/htlim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htlim/subscriptions","organizations_url":"https://api.github.com/users/htlim/orgs","repos_url":"https://api.github.com/users/htlim/repos","events_url":"https://api.github.com/users/htlim/events{/privacy}","received_events_url":"https://api.github.com/users/htlim/received_events","type":"User","site_admin":false},"body":"typo?","created_at":"2016-11-01T07:32:17Z","updated_at":"2016-11-01T07:32:17Z","html_url":"https://github.com/bitnine-oss/agens-graph/pull/91#discussion_r85885288","pull_request_url":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/comments/85885288"},"html":{"href":"https://github.com/bitnine-oss/agens-graph/pull/91#discussion_r85885288"},"pull_request":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91","id":91423045,"html_url":"https://github.com/bitnine-oss/agens-graph/pull/91","diff_url":"https://github.com/bitnine-oss/agens-graph/pull/91.diff","patch_url":"https://github.com/bitnine-oss/agens-graph/pull/91.patch","issue_url":"https://api.github.com/repos/bitnine-oss/agens-graph/issues/91","number":91,"state":"open","locked":false,"title":"feat: Support OPTIONAL MATCH clause","user":{"login":"protodef","id":11454718,"avatar_url":"https://avatars.githubusercontent.com/u/11454718?v=3","gravatar_id":"","url":"https://api.github.com/users/protodef","html_url":"https://github.com/protodef","followers_url":"https://api.github.com/users/protodef/followers","following_url":"https://api.github.com/users/protodef/following{/other_user}","gists_url":"https://api.github.com/users/protodef/gists{/gist_id}","starred_url":"https://api.github.com/users/protodef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protodef/subscriptions","organizations_url":"https://api.github.com/users/protodef/orgs","repos_url":"https://api.github.com/users/protodef/repos","events_url":"https://api.github.com/users/protodef/events{/privacy}","received_events_url":"https://api.github.com/users/protodef/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-28T17:49:18Z","updated_at":"2016-11-01T07:32:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54113419d8bef8bef17079c68a3c444b2bf7bb87","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91/commits","review_comments_url":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91/comments","review_comment_url":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitnine-oss/agens-graph/issues/91/comments","statuses_url":"https://api.github.com/repos/bitnine-oss/agens-graph/statuses/09206f5a4856052258c23d977580e2b07087877e","head":{"label":"protodef:opt-match","ref":"opt-match","sha":"09206f5a4856052258c23d977580e2b07087877e","user":{"login":"protodef","id":11454718,"avatar_url":"https://avatars.githubusercontent.com/u/11454718?v=3","gravatar_id":"","url":"https://api.github.com/users/protodef","html_url":"https://github.com/protodef","followers_url":"https://api.github.com/users/protodef/followers","following_url":"https://api.github.com/users/protodef/following{/other_user}","gists_url":"https://api.github.com/users/protodef/gists{/gist_id}","starred_url":"https://api.github.com/users/protodef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protodef/subscriptions","organizations_url":"https://api.github.com/users/protodef/orgs","repos_url":"https://api.github.com/users/protodef/repos","events_url":"https://api.github.com/users/protodef/events{/privacy}","received_events_url":"https://api.github.com/users/protodef/received_events","type":"User","site_admin":false},"repo":{"id":57409708,"name":"agens-graph","full_name":"protodef/agens-graph","owner":{"login":"protodef","id":11454718,"avatar_url":"https://avatars.githubusercontent.com/u/11454718?v=3","gravatar_id":"","url":"https://api.github.com/users/protodef","html_url":"https://github.com/protodef","followers_url":"https://api.github.com/users/protodef/followers","following_url":"https://api.github.com/users/protodef/following{/other_user}","gists_url":"https://api.github.com/users/protodef/gists{/gist_id}","starred_url":"https://api.github.com/users/protodef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protodef/subscriptions","organizations_url":"https://api.github.com/users/protodef/orgs","repos_url":"https://api.github.com/users/protodef/repos","events_url":"https://api.github.com/users/protodef/events{/privacy}","received_events_url":"https://api.github.com/users/protodef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/protodef/agens-graph","description":"Agens Graph, a transactional graph database based on PostgreSQL","fork":true,"url":"https://api.github.com/repos/protodef/agens-graph","forks_url":"https://api.github.com/repos/protodef/agens-graph/forks","keys_url":"https://api.github.com/repos/protodef/agens-graph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/protodef/agens-graph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/protodef/agens-graph/teams","hooks_url":"https://api.github.com/repos/protodef/agens-graph/hooks","issue_events_url":"https://api.github.com/repos/protodef/agens-graph/issues/events{/number}","events_url":"https://api.github.com/repos/protodef/agens-graph/events","assignees_url":"https://api.github.com/repos/protodef/agens-graph/assignees{/user}","branches_url":"https://api.github.com/repos/protodef/agens-graph/branches{/branch}","tags_url":"https://api.github.com/repos/protodef/agens-graph/tags","blobs_url":"https://api.github.com/repos/protodef/agens-graph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/protodef/agens-graph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/protodef/agens-graph/git/refs{/sha}","trees_url":"https://api.github.com/repos/protodef/agens-graph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/protodef/agens-graph/statuses/{sha}","languages_url":"https://api.github.com/repos/protodef/agens-graph/languages","stargazers_url":"https://api.github.com/repos/protodef/agens-graph/stargazers","contributors_url":"https://api.github.com/repos/protodef/agens-graph/contributors","subscribers_url":"https://api.github.com/repos/protodef/agens-graph/subscribers","subscription_url":"https://api.github.com/repos/protodef/agens-graph/subscription","commits_url":"https://api.github.com/repos/protodef/agens-graph/commits{/sha}","git_commits_url":"https://api.github.com/repos/protodef/agens-graph/git/commits{/sha}","comments_url":"https://api.github.com/repos/protodef/agens-graph/comments{/number}","issue_comment_url":"https://api.github.com/repos/protodef/agens-graph/issues/comments{/number}","contents_url":"https://api.github.com/repos/protodef/agens-graph/contents/{+path}","compare_url":"https://api.github.com/repos/protodef/agens-graph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/protodef/agens-graph/merges","archive_url":"https://api.github.com/repos/protodef/agens-graph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/protodef/agens-graph/downloads","issues_url":"https://api.github.com/repos/protodef/agens-graph/issues{/number}","pulls_url":"https://api.github.com/repos/protodef/agens-graph/pulls{/number}","milestones_url":"https://api.github.com/repos/protodef/agens-graph/milestones{/number}","notifications_url":"https://api.github.com/repos/protodef/agens-graph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/protodef/agens-graph/labels{/name}","releases_url":"https://api.github.com/repos/protodef/agens-graph/releases{/id}","deployments_url":"https://api.github.com/repos/protodef/agens-graph/deployments","created_at":"2016-04-29T20:01:44Z","updated_at":"2016-10-28T16:50:30Z","pushed_at":"2016-10-28T17:49:07Z","git_url":"git://github.com/protodef/agens-graph.git","ssh_url":"git@github.com:protodef/agens-graph.git","clone_url":"https://github.com/protodef/agens-graph.git","svn_url":"https://github.com/protodef/agens-graph","homepage":"","size":24284,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitnine-oss:master","ref":"master","sha":"a48e1f9f54e45910c5240bf2d784dcc1f390ac9a","user":{"login":"bitnine-oss","id":11768100,"avatar_url":"https://avatars.githubusercontent.com/u/11768100?v=3","gravatar_id":"","url":"https://api.github.com/users/bitnine-oss","html_url":"https://github.com/bitnine-oss","followers_url":"https://api.github.com/users/bitnine-oss/followers","following_url":"https://api.github.com/users/bitnine-oss/following{/other_user}","gists_url":"https://api.github.com/users/bitnine-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/bitnine-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitnine-oss/subscriptions","organizations_url":"https://api.github.com/users/bitnine-oss/orgs","repos_url":"https://api.github.com/users/bitnine-oss/repos","events_url":"https://api.github.com/users/bitnine-oss/events{/privacy}","received_events_url":"https://api.github.com/users/bitnine-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":57401138,"name":"agens-graph","full_name":"bitnine-oss/agens-graph","owner":{"login":"bitnine-oss","id":11768100,"avatar_url":"https://avatars.githubusercontent.com/u/11768100?v=3","gravatar_id":"","url":"https://api.github.com/users/bitnine-oss","html_url":"https://github.com/bitnine-oss","followers_url":"https://api.github.com/users/bitnine-oss/followers","following_url":"https://api.github.com/users/bitnine-oss/following{/other_user}","gists_url":"https://api.github.com/users/bitnine-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/bitnine-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitnine-oss/subscriptions","organizations_url":"https://api.github.com/users/bitnine-oss/orgs","repos_url":"https://api.github.com/users/bitnine-oss/repos","events_url":"https://api.github.com/users/bitnine-oss/events{/privacy}","received_events_url":"https://api.github.com/users/bitnine-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitnine-oss/agens-graph","description":"Agens Graph, a transactional graph database based on PostgreSQL","fork":false,"url":"https://api.github.com/repos/bitnine-oss/agens-graph","forks_url":"https://api.github.com/repos/bitnine-oss/agens-graph/forks","keys_url":"https://api.github.com/repos/bitnine-oss/agens-graph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitnine-oss/agens-graph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitnine-oss/agens-graph/teams","hooks_url":"https://api.github.com/repos/bitnine-oss/agens-graph/hooks","issue_events_url":"https://api.github.com/repos/bitnine-oss/agens-graph/issues/events{/number}","events_url":"https://api.github.com/repos/bitnine-oss/agens-graph/events","assignees_url":"https://api.github.com/repos/bitnine-oss/agens-graph/assignees{/user}","branches_url":"https://api.github.com/repos/bitnine-oss/agens-graph/branches{/branch}","tags_url":"https://api.github.com/repos/bitnine-oss/agens-graph/tags","blobs_url":"https://api.github.com/repos/bitnine-oss/agens-graph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitnine-oss/agens-graph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitnine-oss/agens-graph/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitnine-oss/agens-graph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitnine-oss/agens-graph/statuses/{sha}","languages_url":"https://api.github.com/repos/bitnine-oss/agens-graph/languages","stargazers_url":"https://api.github.com/repos/bitnine-oss/agens-graph/stargazers","contributors_url":"https://api.github.com/repos/bitnine-oss/agens-graph/contributors","subscribers_url":"https://api.github.com/repos/bitnine-oss/agens-graph/subscribers","subscription_url":"https://api.github.com/repos/bitnine-oss/agens-graph/subscription","commits_url":"https://api.github.com/repos/bitnine-oss/agens-graph/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitnine-oss/agens-graph/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitnine-oss/agens-graph/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitnine-oss/agens-graph/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitnine-oss/agens-graph/contents/{+path}","compare_url":"https://api.github.com/repos/bitnine-oss/agens-graph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitnine-oss/agens-graph/merges","archive_url":"https://api.github.com/repos/bitnine-oss/agens-graph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitnine-oss/agens-graph/downloads","issues_url":"https://api.github.com/repos/bitnine-oss/agens-graph/issues{/number}","pulls_url":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls{/number}","milestones_url":"https://api.github.com/repos/bitnine-oss/agens-graph/milestones{/number}","notifications_url":"https://api.github.com/repos/bitnine-oss/agens-graph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitnine-oss/agens-graph/labels{/name}","releases_url":"https://api.github.com/repos/bitnine-oss/agens-graph/releases{/id}","deployments_url":"https://api.github.com/repos/bitnine-oss/agens-graph/deployments","created_at":"2016-04-29T17:19:07Z","updated_at":"2016-10-24T22:46:50Z","pushed_at":"2016-10-28T17:49:19Z","git_url":"git://github.com/bitnine-oss/agens-graph.git","ssh_url":"git@github.com:bitnine-oss/agens-graph.git","clone_url":"https://github.com/bitnine-oss/agens-graph.git","svn_url":"https://github.com/bitnine-oss/agens-graph","homepage":"","size":24915,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91"},"html":{"href":"https://github.com/bitnine-oss/agens-graph/pull/91"},"issue":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/issues/91"},"comments":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/bitnine-oss/agens-graph/statuses/09206f5a4856052258c23d977580e2b07087877e"}}}}
{"actor":{"display_login":"htlim"}}