{"action":"created","comment":{"url":"https://api.github.com/repos/libuv/libuv/pulls/comments/80154000","id":80154000,"diff_hunk":"@@ -48,3 +48,23 @@ TEST_IMPL(error_message) {\n \n   return 0;\n }\n+\n+\n+TEST_IMPL(sys_error) {\n+\n+#if defined(_WIN32)\n+\n+  ASSERT(uv_translate_sys_error(ERROR_NOACCESS) == UV_EACCES);\n+  ASSERT(uv_translate_sys_error(WSAEADDRINUSE) == UV_EADDRINUSE);\n+  ASSERT(uv_translate_sys_error(ERROR_BAD_PIPE) == UV_EPIPE);\n+\n+#else\n+\n+  ASSERT(uv_translate_sys_error(EPERM) == UV_EPERM);","path":"test/test-error.c","position":16,"original_position":16,"commit_id":"f26fb8c947be24ef31b114e3bab71a567ee9870a","original_commit_id":"f26fb8c947be24ef31b114e3bab71a567ee9870a","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"Can you test passing in existing `UV_` errors and 0 to verify that they come back.","created_at":"2016-09-22T22:56:27Z","updated_at":"2016-09-22T22:56:35Z","html_url":"https://github.com/libuv/libuv/pull/1060#discussion_r80154000","pull_request_url":"https://api.github.com/repos/libuv/libuv/pulls/1060","_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments/80154000"},"html":{"href":"https://github.com/libuv/libuv/pull/1060#discussion_r80154000"},"pull_request":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1060"}}},"pull_request":{"url":"https://api.github.com/repos/libuv/libuv/pulls/1060","id":85725894,"html_url":"https://github.com/libuv/libuv/pull/1060","diff_url":"https://github.com/libuv/libuv/pull/1060.diff","patch_url":"https://github.com/libuv/libuv/pull/1060.patch","issue_url":"https://api.github.com/repos/libuv/libuv/issues/1060","number":1060,"state":"open","locked":false,"title":"make uv_translate_sys_error public","user":{"login":"plafer","id":5769562,"avatar_url":"https://avatars.githubusercontent.com/u/5769562?v=3","gravatar_id":"","url":"https://api.github.com/users/plafer","html_url":"https://github.com/plafer","followers_url":"https://api.github.com/users/plafer/followers","following_url":"https://api.github.com/users/plafer/following{/other_user}","gists_url":"https://api.github.com/users/plafer/gists{/gist_id}","starred_url":"https://api.github.com/users/plafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plafer/subscriptions","organizations_url":"https://api.github.com/users/plafer/orgs","repos_url":"https://api.github.com/users/plafer/repos","events_url":"https://api.github.com/users/plafer/events{/privacy}","received_events_url":"https://api.github.com/users/plafer/received_events","type":"User","site_admin":false},"body":"References #79.","created_at":"2016-09-18T22:50:59Z","updated_at":"2016-09-22T22:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fec422e61874548cc0b7d912eed7d6fbf9c3f924","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libuv/libuv/pulls/1060/commits","review_comments_url":"https://api.github.com/repos/libuv/libuv/pulls/1060/comments","review_comment_url":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/1060/comments","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/f26fb8c947be24ef31b114e3bab71a567ee9870a","head":{"label":"plafer:uv_translate_posix_error","ref":"uv_translate_posix_error","sha":"f26fb8c947be24ef31b114e3bab71a567ee9870a","user":{"login":"plafer","id":5769562,"avatar_url":"https://avatars.githubusercontent.com/u/5769562?v=3","gravatar_id":"","url":"https://api.github.com/users/plafer","html_url":"https://github.com/plafer","followers_url":"https://api.github.com/users/plafer/followers","following_url":"https://api.github.com/users/plafer/following{/other_user}","gists_url":"https://api.github.com/users/plafer/gists{/gist_id}","starred_url":"https://api.github.com/users/plafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plafer/subscriptions","organizations_url":"https://api.github.com/users/plafer/orgs","repos_url":"https://api.github.com/users/plafer/repos","events_url":"https://api.github.com/users/plafer/events{/privacy}","received_events_url":"https://api.github.com/users/plafer/received_events","type":"User","site_admin":false},"repo":{"id":68541740,"name":"libuv","full_name":"plafer/libuv","owner":{"login":"plafer","id":5769562,"avatar_url":"https://avatars.githubusercontent.com/u/5769562?v=3","gravatar_id":"","url":"https://api.github.com/users/plafer","html_url":"https://github.com/plafer","followers_url":"https://api.github.com/users/plafer/followers","following_url":"https://api.github.com/users/plafer/following{/other_user}","gists_url":"https://api.github.com/users/plafer/gists{/gist_id}","starred_url":"https://api.github.com/users/plafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plafer/subscriptions","organizations_url":"https://api.github.com/users/plafer/orgs","repos_url":"https://api.github.com/users/plafer/repos","events_url":"https://api.github.com/users/plafer/events{/privacy}","received_events_url":"https://api.github.com/users/plafer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plafer/libuv","description":"Cross-platform asynchronous I/O","fork":true,"url":"https://api.github.com/repos/plafer/libuv","forks_url":"https://api.github.com/repos/plafer/libuv/forks","keys_url":"https://api.github.com/repos/plafer/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plafer/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plafer/libuv/teams","hooks_url":"https://api.github.com/repos/plafer/libuv/hooks","issue_events_url":"https://api.github.com/repos/plafer/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/plafer/libuv/events","assignees_url":"https://api.github.com/repos/plafer/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/plafer/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/plafer/libuv/tags","blobs_url":"https://api.github.com/repos/plafer/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plafer/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plafer/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/plafer/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plafer/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/plafer/libuv/languages","stargazers_url":"https://api.github.com/repos/plafer/libuv/stargazers","contributors_url":"https://api.github.com/repos/plafer/libuv/contributors","subscribers_url":"https://api.github.com/repos/plafer/libuv/subscribers","subscription_url":"https://api.github.com/repos/plafer/libuv/subscription","commits_url":"https://api.github.com/repos/plafer/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/plafer/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/plafer/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/plafer/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/plafer/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/plafer/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plafer/libuv/merges","archive_url":"https://api.github.com/repos/plafer/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plafer/libuv/downloads","issues_url":"https://api.github.com/repos/plafer/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/plafer/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/plafer/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/plafer/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plafer/libuv/labels{/name}","releases_url":"https://api.github.com/repos/plafer/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/plafer/libuv/deployments","created_at":"2016-09-18T19:11:39Z","updated_at":"2016-09-18T19:11:42Z","pushed_at":"2016-09-22T16:24:35Z","git_url":"git://github.com/plafer/libuv.git","ssh_url":"git@github.com:plafer/libuv.git","clone_url":"https://github.com/plafer/libuv.git","svn_url":"https://github.com/plafer/libuv","homepage":"http://libuv.org/","size":11182,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"libuv:master","ref":"master","sha":"daf8a45d44bed63fec14a68d798786d76c73f4d4","user":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"repo":{"id":14812739,"name":"libuv","full_name":"libuv/libuv","owner":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libuv/libuv","description":"Cross-platform asynchronous I/O","fork":false,"url":"https://api.github.com/repos/libuv/libuv","forks_url":"https://api.github.com/repos/libuv/libuv/forks","keys_url":"https://api.github.com/repos/libuv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libuv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libuv/libuv/teams","hooks_url":"https://api.github.com/repos/libuv/libuv/hooks","issue_events_url":"https://api.github.com/repos/libuv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/libuv/libuv/events","assignees_url":"https://api.github.com/repos/libuv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/libuv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/libuv/libuv/tags","blobs_url":"https://api.github.com/repos/libuv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libuv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libuv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/libuv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/libuv/libuv/languages","stargazers_url":"https://api.github.com/repos/libuv/libuv/stargazers","contributors_url":"https://api.github.com/repos/libuv/libuv/contributors","subscribers_url":"https://api.github.com/repos/libuv/libuv/subscribers","subscription_url":"https://api.github.com/repos/libuv/libuv/subscription","commits_url":"https://api.github.com/repos/libuv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/libuv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/libuv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/libuv/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/libuv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/libuv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libuv/libuv/merges","archive_url":"https://api.github.com/repos/libuv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libuv/libuv/downloads","issues_url":"https://api.github.com/repos/libuv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/libuv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/libuv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/libuv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libuv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/libuv/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/libuv/libuv/deployments","created_at":"2013-11-30T00:29:56Z","updated_at":"2016-09-22T18:50:25Z","pushed_at":"2016-09-22T16:49:09Z","git_url":"git://github.com/libuv/libuv.git","ssh_url":"git@github.com:libuv/libuv.git","clone_url":"https://github.com/libuv/libuv.git","svn_url":"https://github.com/libuv/libuv","homepage":"http://libuv.org/","size":18095,"stargazers_count":4766,"watchers_count":4766,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":821,"mirror_url":null,"open_issues_count":104,"forks":821,"open_issues":104,"watchers":4766,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1060"},"html":{"href":"https://github.com/libuv/libuv/pull/1060"},"issue":{"href":"https://api.github.com/repos/libuv/libuv/issues/1060"},"comments":{"href":"https://api.github.com/repos/libuv/libuv/issues/1060/comments"},"review_comments":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1060/comments"},"review_comment":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1060/commits"},"statuses":{"href":"https://api.github.com/repos/libuv/libuv/statuses/f26fb8c947be24ef31b114e3bab71a567ee9870a"}}}}
{"actor":{"display_login":"cjihrig"}}