{"action":"created","issue":{"url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/48","repository_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2","labels_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/48/comments","events_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/48/events","html_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/48","id":172801303,"number":48,"title":"Feature/parking","user":{"login":"poolguy","id":17598928,"avatar_url":"https://avatars.githubusercontent.com/u/17598928?v=3","gravatar_id":"","url":"https://api.github.com/users/poolguy","html_url":"https://github.com/poolguy","followers_url":"https://api.github.com/users/poolguy/followers","following_url":"https://api.github.com/users/poolguy/following{/other_user}","gists_url":"https://api.github.com/users/poolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/poolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolguy/subscriptions","organizations_url":"https://api.github.com/users/poolguy/orgs","repos_url":"https://api.github.com/users/poolguy/repos","events_url":"https://api.github.com/users/poolguy/events{/privacy}","received_events_url":"https://api.github.com/users/poolguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-23T20:41:04Z","updated_at":"2016-09-13T23:24:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/pulls/48","html_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/48","diff_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/48.diff","patch_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/48.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/byu-oit-appdev/android-byu-suite-v2/48)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/comments/246857789","html_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/48#issuecomment-246857789","issue_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/48","id":246857789,"user":{"login":"romrell4","id":15692420,"avatar_url":"https://avatars.githubusercontent.com/u/15692420?v=3","gravatar_id":"","url":"https://api.github.com/users/romrell4","html_url":"https://github.com/romrell4","followers_url":"https://api.github.com/users/romrell4/followers","following_url":"https://api.github.com/users/romrell4/following{/other_user}","gists_url":"https://api.github.com/users/romrell4/gists{/gist_id}","starred_url":"https://api.github.com/users/romrell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romrell4/subscriptions","organizations_url":"https://api.github.com/users/romrell4/orgs","repos_url":"https://api.github.com/users/romrell4/repos","events_url":"https://api.github.com/users/romrell4/events{/privacy}","received_events_url":"https://api.github.com/users/romrell4/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T23:24:25Z","updated_at":"2016-09-13T23:24:25Z","body":"\n\n\n\nReviewed 59 of 59 files at r1.\nReview status: all files reviewed at latest revision, 34 unresolved discussions.\n\n---\n\n*[app/src/main/AndroidManifest.xml, line 291 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_gLLnGbMtzEuTQ2QX:-KR_gLLnGbMtzEuTQ2QY:b-5f6bc0) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/AndroidManifest.xml#L291)):*\n> ```XML\n>             <meta-data\n>                 android:name=\"description\"\n>                 android:value=\"Pay for parking, view parking privileges\"/>\n> ```\n\nPut in the actual description from the iOS feature\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/CompletePaymentActivity.java, line 56 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_h7iR6D8AlmHaQJbE:-KR_h7iS9gV9SPPj4JSY:b-artl46) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/CompletePaymentActivity.java#L56)):*\n> ```Java\n> \t\t\t\t\tnew AlertDialog.Builder(CompletePaymentActivity.this)\n> \t\t\t\t\t\t\t.setTitle(\"Payment Success!\")\n> \t\t\t\t\t\t\t.setMessage(\"Your payment has been successfully processed. It may take up to 30 minutes for your privileges to be updated. Please wait until your privileges reflect this payment before parking in the paid lots.\")\n> ```\n\nSave this as a psf\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/MyLotsActivity.java, line 195 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_hcuWxX1rkD0MGhBs:-KR_hcuWxX1rkD0MGhBt:bb6xb9l) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/MyLotsActivity.java#L195)):*\n> ```Java\n> \n> \t\t//Checks to see if there are any empty strings at the end of the list\n> \t\tif (holderList.size() % 2 != 0) {\n> ```\n\nHuh?\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/MyLotsActivity.java, line 199 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_hYh9VKNB03-h7ON_:-KR_hYh9VKNB03-h7ONa:bpxpe9k) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/MyLotsActivity.java#L199)):*\n> ```Java\n> \t\t}\n> \n> \t\tfor (int i = 0; i < holderList.size(); i += 2) {\n> ```\n\nWhat is up with the += 2?\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/MyLotsActivity.java, line 238 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_hzA6288EATNN6kIw:-KR_hzA6288EATNN6kIx:b-p11acr) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/MyLotsActivity.java#L238)):*\n> ```Java\n> \tprivate int getTypeIdFromPrivilege(String currentSemesterPrivilegeText, ParkingLotType[] parkingLotTypes) {\n> \t\tint defaultId = 0;\n> \t\tfor (ParkingLotType parkingLotType : parkingLotTypes) {\n> ```\n\nAdd a comment before this for loop explaining what it's doing\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/ParkingMainActivity.java, line 114 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_iF-orzyNdnDW2c7y:-KR_iF-orzyNdnDW2c7z:b-fblrud) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/ParkingMainActivity.java#L114)):*\n> ```Java\n> \t\t\tif (!userEligibility.isCanRegisterPerm() && !userEligibility.isCanRegisterTemp()) {\n> \t\t\t\tAlertDialog.Builder dialogBuilder = new AlertDialog.Builder(ParkingMainActivity.this);\n> \t\t\t\tdialogBuilder.setMessage(\"You have reached your vehicle limit\")\n> ```\n\nDouble check that this is the same phrase used in iOS. Then save it as a psf\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/ParkingMainActivity.java, line 139 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_iOC04bdgfcGAxqmE:-KR_iOC04bdgfcGAxqmF:baiqhqc) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/ParkingMainActivity.java#L139)):*\n> ```Java\n> \t\t\t} else {\n> \t\t\t\tAlertDialog.Builder dialogBuilder = new AlertDialog.Builder(ParkingMainActivity.this);\n> \t\t\t\tdialogBuilder.setTitle(\"Not eligible for payment\")\n> ```\n\nCheck that the spelling of this is the same as iOS (capitals, etc)\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/PreviousVehiclesActivity.java, line 113 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_iprjcKSINu79x95p:-KR_iprlRbdA9BildAxl:b9919wg) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/PreviousVehiclesActivity.java#L113)):*\n> ```Java\n> \t\t\tpublic final TextView vehicleMake;\n> \t\t\tpublic final TextView licensePlate;\n> \t\t\tpublic final AppCompatImageView indicator;\n> ```\n\nWhy do you need to save the indicator here?\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/StartPaymentActivity.java, line 40 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_j99XMwrCMzLMc_eu:-KR_j99XMwrCMzLMc_ev:b1b5eim) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/StartPaymentActivity.java#L40)):*\n> ```Java\n> \tpublic static final String PAYMENT_TYPE = \"paymentType\";\n> \tpublic static final String TERMS_AND_CONDITIONS = \"termsAndConditions\";\n> \tpublic static final String PAYMENT_TYPE_ID = \"paymentTypeId\";\n> ```\n\nMove these to ByuConstants (per Corey's request). Use ByuConstants for anytime you are passing something through an intent\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/StartPaymentActivity.java, line 85 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_jSs3tBtw_Z3l8t7M:-KR_jSs3tBtw_Z3l8t7N:b-4zphb2) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/StartPaymentActivity.java#L85)):*\n> ```Java\n> \t\t\t\tAlertDialog.Builder alertBuilder = new AlertDialog.Builder(StartPaymentActivity.this);\n> \t\t\t\talertBuilder.setMessage(byuError.getReadableMessage())\n> \t\t\t\t\t\t.setPositiveButton(\"OK\", (dialog, which) -> onBackPressed());\n> ```\n\nneutral\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/VehicleActivity.java, line 79 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_jkdUnalXTbUUT0Ah:-KR_jkdUnalXTbUUT0Ai:bsisoh2) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/VehicleActivity.java#L79)):*\n> ```Java\n> \t\t\tvehicleIsPerm = false;\n> \t\t}\n> \t\tvehicleInformation.add(new Pair<>(getResources().getString(R.string.vehicle_type), permTempType));\n> ```\n\nComment describing what Pair object is doing\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/VehicleActivity.java, line 228 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_kJYxDCXI4g0LfcPr:-KR_kJYxDCXI4g0LfcPs:bujpd4t) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/VehicleActivity.java#L228)):*\n> ```Java\n> \t\t\t\t.setView(editVehicleDialogView)\n> \t\t\t\t.setTitle(\"Edit Vehicle\")\n> \t\t\t\t.setPositiveButton(\"Save\", (dialog, which) -> {\n> ```\n\nShow me this on a phone and explain all of the checking that we do\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/activity/VehicleActivity.java, line 334 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_nFJUFL4yQH98HF3X:-KR_nFJUFL4yQH98HF3Y:b-mforc7) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/activity/VehicleActivity.java#L334)):*\n> ```Java\n> \t}\n> \n> \tprivate void removeDeprecatedStateCodesFromList(List<ParkingCode> stateCodesFromService) {\n> ```\n\nI thought we replaced this with the ParkingUtils stuff...\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/client/ParkingLotClient.java, line 16 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_megbUpPeZodKHjZN:-KR_megbUpPeZodKHjZO:b-hz2ptq) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/client/ParkingLotClient.java#L16)):*\n> ```Java\n> \t@Override\n> \tpublic String getBaseUrl() {\n> \t\treturn \"http://map.byu.edu/tours/services/MapService.svc/ajax/\";\n> ```\n\nWe should be using a different URL for this one. Something behind WSO2\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/client/ParkingLotClient.java, line 21 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_mkqWcouqw1hhj54I:-KR_mkqWcouqw1hhj54J:biyxli8) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/client/ParkingLotClient.java#L21)):*\n> ```Java\n> \t@Override\n> \tpublic ByuApiGenerator.AuthType getAuthType() {\n> \t\treturn ByuApiGenerator.AuthType.NONE;\n> ```\n\nThis will change as well then\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/model/ParkingLotTypeWrapper.java, line 7 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_n5NTi8MH2Ouzn69J:-KR_n5NTi8MH2Ouzn69K:b-imk7k0) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/model/ParkingLotTypeWrapper.java#L7)):*\n> ```Java\n>  */\n> public class ParkingLotTypeWrapper {\n> \tprivate ParkingLotType[] d;\n> ```\n\nTry using @SerializedName here. Then you can call the variable something better :-/\n\n---\n\n*[app/src/main/java/edu/byu/suite/features/parking/model/PaymentType.java, line 54 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_ncRm9NR2hEmSVpIB:-KR_ncRm9NR2hEmSVpIC:bfheptf) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/features/parking/model/PaymentType.java#L54)):*\n> ```Java\n> \tpublic String getFormattedMungedAccountNum() {\n> \t\tString formattedMungedAccountNum = mungedAccountNum;\n> \t\tfor (int i = 4; i < formattedMungedAccountNum.length(); i += 4) {\n> ```\n\nWhat is this doing? Is there a simpler way? If not. Definitely a comment\n\n---\n\n*[app/src/main/java/edu/byu/suite/mainScreen/FeatureRecyclerAdapter.java, line 3 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_oDkBinJIDjjwmEDY:-KR_oDkCEWlEw6nawigy:b-mfoilg) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/java/edu/byu/suite/mainScreen/FeatureRecyclerAdapter.java#L3)):*\n> ```Java\n> package edu.byu.suite.mainScreen;\n> \n> import android.content.Intent;\n> ```\n\nWhy did we have to add these?\n\n---\n\n*[app/src/main/res/layout/activity_edit_vehicle.xml, line 12 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_oPfED9NOTL6-Mw6A:-KR_oPfED9NOTL6-Mw6B:b96ab1d) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/activity_edit_vehicle.xml#L12)):*\n> ```XML\n> \tandroid:paddingTop=\"@dimen/activity_vertical_margin\"\n> \ttools:context=\".features.parking.activity.EditVehicleActivity\">\n> ```\n\nIs there really nothing in this?\n\n---\n\n*[app/src/main/res/layout/parking_activity_legalese.xml, line 168 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_offpz2ZeZ7YoYSDC:-KR_offpz2ZeZ7YoYSDD:bqjzcwe) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_activity_legalese.xml#L168)):*\n> ```XML\n>                 android:layout_width=\"0dp\"\n>                 android:layout_height=\"wrap_content\"\n>                 android:layout_weight=\"1\"\n> ```\n\nWhy layout weight?\n\n---\n\n*[app/src/main/res/layout/parking_activity_legalese.xml, line 176 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_ogtMY6Y5RoztQNxz:-KR_ogtNK2YeJ1-Djlgi:bqo5gec) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_activity_legalese.xml#L176)):*\n> ```XML\n>                 android:layout_width=\"0dp\"\n>                 android:layout_height=\"wrap_content\"\n>                 android:layout_weight=\"1\"\n> ```\n\nAgain?\n\n---\n\n*[app/src/main/res/layout/parking_activity_my_lots.xml, line 32 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_olI4wZyOVKRWCaVk:-KR_olI4wZyOVKRWCaVl:b-jzqsif) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_activity_my_lots.xml#L32)):*\n> ```XML\n>         android:paddingBottom=\"1dp\"\n>         android:paddingTop=\"1dp\"\n>         android:textColor=\"#ffffff\"\n> ```\n\nThis should be in colors somewhere already\n\n---\n\n*[app/src/main/res/layout/parking_activity_vehicle_layout.xml, line 2 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_ouF_Oi_XgV0q0qjv:-KR_ouF_Oi_XgV0q0qjw:bnw4gi6) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_activity_vehicle_layout.xml#L2)):*\n> ```XML\n> <?xml version=\"1.0\" encoding=\"utf-8\"?>\n> <RelativeLayout\n> ```\n\nLook through all of your xml files and try to see what you can clean up. It's been a while since you wrote them, and you probably know cleaner/better ways to do them now. :)\n\n---\n\n*[app/src/main/res/layout/parking_list_item_edit_text.xml, line 23 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_puv_6L_b0Dx6tdug:-KR_puv_6L_b0Dx6tduh:b5ph7x7) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_list_item_edit_text.xml#L23)):*\n> ```XML\n>         android:id=\"@+id/editText\"\n>         style=\"@style/Support.Text.Light.Medium\"\n>         android:layout_width=\"150dp\"\n> ```\n\nWhy a hard coded width?\n\n---\n\n*[app/src/main/res/layout/parking_payment_type_list_item.xml, line 13 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_q06Oxv6N2MulLgCe:-KR_q06Oxv6N2MulLgCf:bmmgu1t) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_payment_type_list_item.xml#L13)):*\n> ```XML\n>     <ImageView\n>         android:id=\"@+id/accountTypeImage\"\n>         android:layout_width=\"50dp\"\n> ```\n\nPut into a dimens file. Might be reused\n\n---\n\n*[app/src/main/res/layout/parking_spinner_dropdown_textview.xml, line 8 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_q9suJhYoNCu5mzDX:-KR_q9suJhYoNCu5mzDY:b-uvk3ae) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_spinner_dropdown_textview.xml#L8)):*\n> ```XML\n>     android:layout_height=\"wrap_content\"\n>     android:background=\"@drawable/custom_ripple\"\n>     android:ellipsize=\"marquee\"\n> ```\n\nWhy marquee?\n\n---\n\n*[app/src/main/res/layout/parking_spinner_textview.xml, line 9 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_qBwBKO8MMagMSzZx:-KR_qBwBKO8MMagMSzZy:b-tl21z2) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/app/src/main/res/layout/parking_spinner_textview.xml#L9)):*\n> ```XML\n>     android:layout_gravity=\"end\"\n>     android:background=\"@drawable/custom_ripple\"\n>     android:ellipsize=\"marquee\"\n> ```\n\nMarquee?\n\n---\n\n*[support/src/main/java/edu/byu/support/activity/ByuActivity.java, line 34 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_qm2B5vFyMUD7jbDy:-KR_qm2B5vFyMUD7jbDz:b2s2ria) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/support/src/main/java/edu/byu/support/activity/ByuActivity.java#L34)):*\n> ```Java\n> \t}\n> \n> \t@Override\n> ```\n\nWhat is this?\n\n---\n\n*[support/src/main/java/edu/byu/support/dialog/ByuProgressDialog.java, line 5 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_qngX_1QRM4fFHY_h:-KR_qngX_1QRM4fFHY_i:byquu61) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/support/src/main/java/edu/byu/support/dialog/ByuProgressDialog.java#L5)):*\n> ```Java\n> import android.app.ProgressDialog;\n> import android.content.Context;\n> import android.content.res.Resources;\n> ```\n\nDo we need this?\n\n---\n\n*[support/src/main/java/edu/byu/support/login/internal/authenticator/providers/ByuAccountAuthenticator.java, line 131 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_qr9P97bScfkSHyIX:-KR_qr9P97bScfkSHyIY:b-s3opj1) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/support/src/main/java/edu/byu/support/login/internal/authenticator/providers/ByuAccountAuthenticator.java#L131)):*\n> ```Java\n> \t\t\t\t\tcred = ((Wso2Client.Wso2Api) ByuApiGenerator.createApi(context, new Wso2Client()))\n> \t\t\t\t\t\t\t// Add client credentials here to use your own wso2 app. Use getWso2AuthSandbox to hit a sandbox endpoint.\n> \t\t\t\t\t\t\t.getWso2AuthSandbox(new Wso2Client.AccountWrapper(account.name, accountManager.getPassword(account), null, null))\n> ```\n\nRemember to remove this\n\n---\n\n*[support/src/main/res/layout/default_list_item.xml, line 15 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_r09qJ7X5xfnMh9of:-KR_r09qJ7X5xfnMh9og:bc46tra) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/support/src/main/res/layout/default_list_item.xml#L15)):*\n> ```XML\n>         android:layout_alignParentStart=\"true\"\n>         android:layout_alignParentEnd=\"true\"\n>         style=\"@style/Support.Text.Large\"\n> ```\n\nChanging the default list item?\n\n---\n\n*[support/src/main/res/layout/default_list_item_detail_indicator.xml, line 1 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_r4wLFpnMRQZuv73F:-KR_r4wLFpnMRQZuv73G:baeowtg) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/support/src/main/res/layout/default_list_item_detail_indicator.xml#L1)):*\n> ```XML\n> <?xml version=\"1.0\" encoding=\"utf-8\"?>\n> ```\n\nNo changes needed here\n\n---\n\n*[support/src/main/res/layout/default_list_item_edit_text.xml, line 23 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_rAFdoA71l-Gbs138:-KR_rAFdoA71l-Gbs139:b-z6p4ou) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/support/src/main/res/layout/default_list_item_edit_text.xml#L23)):*\n> ```XML\n>         android:id=\"@+id/editText\"\n>         style=\"@style/Support.Text.Light.Medium\"\n>         android:layout_width=\"150dp\"\n> ```\n\nDidn't I already see this somewhere else?\n\n---\n\n*[support/src/main/res/layout/default_simple_list_item_centered.xml, line 12 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48#-KR_rDfa3_PS5tpP8qB4:-KR_rDfa3_PS5tpP8qB5:b32wk1) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/b27f93a4b71e8fb961f416fa4fb5ccd3db752196/support/src/main/res/layout/default_simple_list_item_centered.xml#L12)):*\n> ```XML\n> \tandroid:gravity=\"center\"\n> \tandroid:layout_gravity=\"center_horizontal\"\n> \tandroid:paddingEnd=\"8dip\"\n> ```\n\ndp\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/48)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"romrell4"}}