{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/comments/70160787","id":70160787,"diff_hunk":"@@ -371,6 +373,55 @@ namespace appx {\n     }\n \n     template <typename TSink>\n+    ZIPFileEntry\n+    WriteAppxBundleManifestZIPFileEntry(TSink &sink, off_t offset,\n+                                        const std::string &inputFileName,\n+                                        const std::string &archiveFileName,\n+                                        const std::vector<ZIPFileEntry> &otherEntries)\n+    {\n+        std::ifstream manifestInput(inputFileName);\n+        std::string manifestText((std::istreambuf_iterator<char>(manifestInput)),\n+                                  std::istreambuf_iterator<char>());\n+\n+       std::cout << \"\\n\\n ABOUT TO GO OVER OTHERENTRIES\" << \"\\n\\n\";\n+       std::cout << \"\\n\\n\" << manifestText << \"\\n\\n\";\n+\n+        for (const ZIPFileEntry &entry : otherEntries) {\n+            std::string fileName = entry.fileName;\n+            std::string offsetTemplateName = entry.fileName + \"-offset\";\n+            std::cout << \"\\n\\n\" << offsetTemplateName;\n+            size_t pos = 0;\n+            size_t entryDataOffset = entry.fileRecordHeaderOffset + entry.FileRecordHeaderSize();\n+            while ((pos = manifestText.find(offsetTemplateName, pos)) != std::string::npos) {\n+                std::cout << \"replacing something\" << std::endl;\n+                manifestText.replace(pos, offsetTemplateName.length(), std::to_string(entryDataOffset));\n+            }\n+        }","path":"PrivateHeaders/APPX/ZIP.h","position":62,"original_position":36,"commit_id":"1fc78655763a11bfd809cca44d955258fd9250dd","original_commit_id":"6acbe70985bd98311bc373b2a06e87fd72d3eee7","user":{"login":"strager","id":48666,"avatar_url":"https://avatars.githubusercontent.com/u/48666?v=3","gravatar_id":"","url":"https://api.github.com/users/strager","html_url":"https://github.com/strager","followers_url":"https://api.github.com/users/strager/followers","following_url":"https://api.github.com/users/strager/following{/other_user}","gists_url":"https://api.github.com/users/strager/gists{/gist_id}","starred_url":"https://api.github.com/users/strager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strager/subscriptions","organizations_url":"https://api.github.com/users/strager/orgs","repos_url":"https://api.github.com/users/strager/repos","events_url":"https://api.github.com/users/strager/events{/privacy}","received_events_url":"https://api.github.com/users/strager/received_events","type":"User","site_admin":false},"body":"Nit: put this transformation code in a separate function.","created_at":"2016-07-09T02:24:25Z","updated_at":"2016-07-09T02:24:25Z","html_url":"https://github.com/facebook/fb-util-for-appx/pull/3#discussion_r70160787","pull_request_url":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/comments/70160787"},"html":{"href":"https://github.com/facebook/fb-util-for-appx/pull/3#discussion_r70160787"},"pull_request":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3","id":76682119,"html_url":"https://github.com/facebook/fb-util-for-appx/pull/3","diff_url":"https://github.com/facebook/fb-util-for-appx/pull/3.diff","patch_url":"https://github.com/facebook/fb-util-for-appx/pull/3.patch","issue_url":"https://api.github.com/repos/facebook/fb-util-for-appx/issues/3","number":3,"state":"open","locked":false,"title":"Appxbundle functionality","user":{"login":"mnovakovic","id":527936,"avatar_url":"https://avatars.githubusercontent.com/u/527936?v=3","gravatar_id":"","url":"https://api.github.com/users/mnovakovic","html_url":"https://github.com/mnovakovic","followers_url":"https://api.github.com/users/mnovakovic/followers","following_url":"https://api.github.com/users/mnovakovic/following{/other_user}","gists_url":"https://api.github.com/users/mnovakovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mnovakovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnovakovic/subscriptions","organizations_url":"https://api.github.com/users/mnovakovic/orgs","repos_url":"https://api.github.com/users/mnovakovic/repos","events_url":"https://api.github.com/users/mnovakovic/events{/privacy}","received_events_url":"https://api.github.com/users/mnovakovic/received_events","type":"User","site_admin":false},"body":"Pull request for appxbundle functionality","created_at":"2016-07-07T23:33:34Z","updated_at":"2016-07-09T02:24:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b26d03c5e132e550f098268849a278894852e90","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3/commits","review_comments_url":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3/comments","review_comment_url":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/fb-util-for-appx/issues/3/comments","statuses_url":"https://api.github.com/repos/facebook/fb-util-for-appx/statuses/1fc78655763a11bfd809cca44d955258fd9250dd","head":{"label":"mnovakovic:appxbundle_functionality","ref":"appxbundle_functionality","sha":"1fc78655763a11bfd809cca44d955258fd9250dd","user":{"login":"mnovakovic","id":527936,"avatar_url":"https://avatars.githubusercontent.com/u/527936?v=3","gravatar_id":"","url":"https://api.github.com/users/mnovakovic","html_url":"https://github.com/mnovakovic","followers_url":"https://api.github.com/users/mnovakovic/followers","following_url":"https://api.github.com/users/mnovakovic/following{/other_user}","gists_url":"https://api.github.com/users/mnovakovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mnovakovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnovakovic/subscriptions","organizations_url":"https://api.github.com/users/mnovakovic/orgs","repos_url":"https://api.github.com/users/mnovakovic/repos","events_url":"https://api.github.com/users/mnovakovic/events{/privacy}","received_events_url":"https://api.github.com/users/mnovakovic/received_events","type":"User","site_admin":false},"repo":{"id":62843746,"name":"fb-util-for-appx","full_name":"mnovakovic/fb-util-for-appx","owner":{"login":"mnovakovic","id":527936,"avatar_url":"https://avatars.githubusercontent.com/u/527936?v=3","gravatar_id":"","url":"https://api.github.com/users/mnovakovic","html_url":"https://github.com/mnovakovic","followers_url":"https://api.github.com/users/mnovakovic/followers","following_url":"https://api.github.com/users/mnovakovic/following{/other_user}","gists_url":"https://api.github.com/users/mnovakovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mnovakovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnovakovic/subscriptions","organizations_url":"https://api.github.com/users/mnovakovic/orgs","repos_url":"https://api.github.com/users/mnovakovic/repos","events_url":"https://api.github.com/users/mnovakovic/events{/privacy}","received_events_url":"https://api.github.com/users/mnovakovic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnovakovic/fb-util-for-appx","description":"Create .appx files.","fork":true,"url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx","forks_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/forks","keys_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/teams","hooks_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/hooks","issue_events_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/issues/events{/number}","events_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/events","assignees_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/assignees{/user}","branches_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/branches{/branch}","tags_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/tags","blobs_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/statuses/{sha}","languages_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/languages","stargazers_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/stargazers","contributors_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/contributors","subscribers_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/subscribers","subscription_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/subscription","commits_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/contents/{+path}","compare_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/merges","archive_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/downloads","issues_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/issues{/number}","pulls_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/pulls{/number}","milestones_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/milestones{/number}","notifications_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/labels{/name}","releases_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/releases{/id}","deployments_url":"https://api.github.com/repos/mnovakovic/fb-util-for-appx/deployments","created_at":"2016-07-07T23:11:41Z","updated_at":"2016-07-07T23:11:42Z","pushed_at":"2016-07-07T23:31:35Z","git_url":"git://github.com/mnovakovic/fb-util-for-appx.git","ssh_url":"git@github.com:mnovakovic/fb-util-for-appx.git","clone_url":"https://github.com/mnovakovic/fb-util-for-appx.git","svn_url":"https://github.com/mnovakovic/fb-util-for-appx","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"036b5a34e3b540e4d27105ee2006c1993b316ad0","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":52390038,"name":"fb-util-for-appx","full_name":"facebook/fb-util-for-appx","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/fb-util-for-appx","description":"Create .appx files.","fork":false,"url":"https://api.github.com/repos/facebook/fb-util-for-appx","forks_url":"https://api.github.com/repos/facebook/fb-util-for-appx/forks","keys_url":"https://api.github.com/repos/facebook/fb-util-for-appx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/fb-util-for-appx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/fb-util-for-appx/teams","hooks_url":"https://api.github.com/repos/facebook/fb-util-for-appx/hooks","issue_events_url":"https://api.github.com/repos/facebook/fb-util-for-appx/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/fb-util-for-appx/events","assignees_url":"https://api.github.com/repos/facebook/fb-util-for-appx/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/fb-util-for-appx/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/fb-util-for-appx/tags","blobs_url":"https://api.github.com/repos/facebook/fb-util-for-appx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/fb-util-for-appx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/fb-util-for-appx/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/fb-util-for-appx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/fb-util-for-appx/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/fb-util-for-appx/languages","stargazers_url":"https://api.github.com/repos/facebook/fb-util-for-appx/stargazers","contributors_url":"https://api.github.com/repos/facebook/fb-util-for-appx/contributors","subscribers_url":"https://api.github.com/repos/facebook/fb-util-for-appx/subscribers","subscription_url":"https://api.github.com/repos/facebook/fb-util-for-appx/subscription","commits_url":"https://api.github.com/repos/facebook/fb-util-for-appx/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/fb-util-for-appx/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/fb-util-for-appx/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/fb-util-for-appx/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/fb-util-for-appx/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/fb-util-for-appx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/fb-util-for-appx/merges","archive_url":"https://api.github.com/repos/facebook/fb-util-for-appx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/fb-util-for-appx/downloads","issues_url":"https://api.github.com/repos/facebook/fb-util-for-appx/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/fb-util-for-appx/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/fb-util-for-appx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/fb-util-for-appx/labels{/name}","releases_url":"https://api.github.com/repos/facebook/fb-util-for-appx/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/fb-util-for-appx/deployments","created_at":"2016-02-23T20:40:07Z","updated_at":"2016-07-07T22:27:44Z","pushed_at":"2016-07-07T23:33:34Z","git_url":"git://github.com/facebook/fb-util-for-appx.git","ssh_url":"git@github.com:facebook/fb-util-for-appx.git","clone_url":"https://github.com/facebook/fb-util-for-appx.git","svn_url":"https://github.com/facebook/fb-util-for-appx","homepage":null,"size":37,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3"},"html":{"href":"https://github.com/facebook/fb-util-for-appx/pull/3"},"issue":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/issues/3"},"comments":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/fb-util-for-appx/statuses/1fc78655763a11bfd809cca44d955258fd9250dd"}}}}
{"actor":{"display_login":"strager"}}