{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090","repository_url":"https://api.github.com/repos/jenkinsci/jenkins","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090/comments","events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090/events","html_url":"https://github.com/jenkinsci/jenkins/pull/2090","id":139225995,"number":2090,"title":"Revert \"Jenkins.getInstance() should be non-null\"","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-08T09:37:54Z","updated_at":"2016-03-08T10:41:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2090","html_url":"https://github.com/jenkinsci/jenkins/pull/2090","diff_url":"https://github.com/jenkinsci/jenkins/pull/2090.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2090.patch"},"body":"This reverts commit bb7c8fcedbcc9b51c5b1bb5b32810af5ac6b1ffb, which has been submitted without a pull request. This is a breaking change, so I propose to revert it. If the submitter feels strongly, he can create a pull request as other Jenkins contributors do.\r\n\r\nhttps://github.com/jenkinsci/jenkins/commit/bb7c8fcedbcc9b51c5b1bb5b32810af5ac6b1ffb\r\nSee the discussion there.\r\n\r\n@jenkinsci/code-reviewers @reviewbybees"},"comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/193717629","html_url":"https://github.com/jenkinsci/jenkins/pull/2090#issuecomment-193717629","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090","id":193717629,"user":{"login":"andresrc","id":500424,"avatar_url":"https://avatars.githubusercontent.com/u/500424?v=3","gravatar_id":"","url":"https://api.github.com/users/andresrc","html_url":"https://github.com/andresrc","followers_url":"https://api.github.com/users/andresrc/followers","following_url":"https://api.github.com/users/andresrc/following{/other_user}","gists_url":"https://api.github.com/users/andresrc/gists{/gist_id}","starred_url":"https://api.github.com/users/andresrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresrc/subscriptions","organizations_url":"https://api.github.com/users/andresrc/orgs","repos_url":"https://api.github.com/users/andresrc/repos","events_url":"https://api.github.com/users/andresrc/events{/privacy}","received_events_url":"https://api.github.com/users/andresrc/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T10:41:29Z","updated_at":"2016-03-08T10:41:29Z","body":"@stephenc I agree with your reasoning. However, the concern I have is:\r\n\r\n- We should aim for all plugins to build cleanly against their baseline version and against the last (or at least last LTS version).\r\n- For all plugins with a baseline between https://github.com/jenkinsci/jenkins/commit/fa496c7bf228ecb243acf0135106f18f27132c6f and https://github.com/jenkinsci/jenkins/commit/bb7c8fcedbcc9b51c5b1bb5b32810af5ac6b1ffb and findbugs enabled (which should be an increasing number) we are going to introduce much boilerplate just to have clean builds in the described scenarios.\r\n\r\nIs the change worth it?"}}