{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/ui-virtualization/issues/72","repository_url":"https://api.github.com/repos/aurelia/ui-virtualization","labels_url":"https://api.github.com/repos/aurelia/ui-virtualization/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/ui-virtualization/issues/72/comments","events_url":"https://api.github.com/repos/aurelia/ui-virtualization/issues/72/events","html_url":"https://github.com/aurelia/ui-virtualization/pull/72","id":165806781,"number":72,"title":"feat(virtual-repeat): allow 'next' function defined from sub properties","user":{"login":"AStoker","id":2907279,"avatar_url":"https://avatars.githubusercontent.com/u/2907279?v=3","gravatar_id":"","url":"https://api.github.com/users/AStoker","html_url":"https://github.com/AStoker","followers_url":"https://api.github.com/users/AStoker/followers","following_url":"https://api.github.com/users/AStoker/following{/other_user}","gists_url":"https://api.github.com/users/AStoker/gists{/gist_id}","starred_url":"https://api.github.com/users/AStoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AStoker/subscriptions","organizations_url":"https://api.github.com/users/AStoker/orgs","repos_url":"https://api.github.com/users/AStoker/repos","events_url":"https://api.github.com/users/AStoker/events{/privacy}","received_events_url":"https://api.github.com/users/AStoker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-07-15T14:58:43Z","updated_at":"2016-08-10T14:47:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aurelia/ui-virtualization/pulls/72","html_url":"https://github.com/aurelia/ui-virtualization/pull/72","diff_url":"https://github.com/aurelia/ui-virtualization/pull/72.diff","patch_url":"https://github.com/aurelia/ui-virtualization/pull/72.patch"},"body":"Allow ‘virtual-repeat-next' function to allow sub properties, i.e.\r\n`virtual-repeat-next=“foo.bar.getNext”`\r\n\r\nFixes an issue where if you were using `virtual-repeat` inside a custom element, and your function for getting more existed on the parent, you couldn't directly reference the function.\r\nExample:\r\nPreviously broken due to inability to parse `$parent.getMore`\r\n``` html\r\n<li virtual-repeat.for='item of items' virtual-repeat-next='$parent.getMore'>${item}</li>\r\n```\r\nNow fixed. Same syntax, but can parse the bindable property to find the correct function.\r\n``` html\r\n<li virtual-repeat.for='item of items' virtual-repeat-next='$parent.getMore'>${item}</li>\r\n```"},"comment":{"url":"https://api.github.com/repos/aurelia/ui-virtualization/issues/comments/238890303","html_url":"https://github.com/aurelia/ui-virtualization/pull/72#issuecomment-238890303","issue_url":"https://api.github.com/repos/aurelia/ui-virtualization/issues/72","id":238890303,"user":{"login":"AStoker","id":2907279,"avatar_url":"https://avatars.githubusercontent.com/u/2907279?v=3","gravatar_id":"","url":"https://api.github.com/users/AStoker","html_url":"https://github.com/AStoker","followers_url":"https://api.github.com/users/AStoker/followers","following_url":"https://api.github.com/users/AStoker/following{/other_user}","gists_url":"https://api.github.com/users/AStoker/gists{/gist_id}","starred_url":"https://api.github.com/users/AStoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AStoker/subscriptions","organizations_url":"https://api.github.com/users/AStoker/orgs","repos_url":"https://api.github.com/users/AStoker/repos","events_url":"https://api.github.com/users/AStoker/events{/privacy}","received_events_url":"https://api.github.com/users/AStoker/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T14:47:44Z","updated_at":"2016-08-10T14:47:44Z","body":"One of the ways I tried to do this, but seems kind of hacky, is just adding those parameters directly to the `overrideContext`. However I'm not sure how proper that is, or if there's a proper naming scheme for this, @EisenbergEffect.\r\n``` javascript\r\nlet topIndex = this._first;\r\nlet isAtBottom = this._bottomBufferHeight === 0;\r\nlet isAtTop = this._isAtTop;\r\n\r\nthis.scope.overrideContext.topIndex = topIndex;\r\nthis.scope.overrideContext.isAtBottom = isAtBottom;\r\nthis.scope.overrideContext.isAtTop = isAtTop;\r\n```"}}
{"actor":{"display_login":"AStoker"}}