{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/91389524","pull_request_review_id":11897962,"id":91389524,"diff_hunk":"@@ -1,6 +1,5 @@\n <kbn-timepicker\n-  from=\"timefilter.time.from\"\n-  to=\"timefilter.time.to\"\n+  time=\"timefilter.time\"\n   mode=\"timefilter.time.mode\"","path":"src/ui/public/chrome/config/filter.html","position":5,"original_position":5,"commit_id":"d536ee1c9700ae198b956df23fdaf5a26b680c70","original_commit_id":"d536ee1c9700ae198b956df23fdaf5a26b680c70","user":{"login":"Bargs","id":6239176,"avatar_url":"https://avatars.githubusercontent.com/u/6239176?v=3","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false},"body":"Any reason you removed `from` and `to` but not `mode`?","created_at":"2016-12-07T21:18:22Z","updated_at":"2016-12-07T21:24:06Z","html_url":"https://github.com/elastic/kibana/pull/9218#discussion_r91389524","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/9218","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/91389524"},"html":{"href":"https://github.com/elastic/kibana/pull/9218#discussion_r91389524"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/9218"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/9218","id":95101462,"html_url":"https://github.com/elastic/kibana/pull/9218","diff_url":"https://github.com/elastic/kibana/pull/9218.diff","patch_url":"https://github.com/elastic/kibana/pull/9218.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/9218","number":9218,"state":"open","locked":false,"title":"Automatically close timepicker upon quick selection","user":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars.githubusercontent.com/u/1178348?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"body":"This PR automatically closes the timepicker when you select a time window using the \"quick\" time selection.\r\n\r\nThe first stab at this just added a call to `kbnTopNav.toggle('filter')` at the end of the `setQuick` method, but this was problematic because the timepicker would disappear before the `$scope` variable changes propagated to the actual time filter. Wrapping the `toggle` call in a `$timeout` seemed to solve the problem, but I didn't like this solution.\r\n\r\nInstead, I decided to change the way we reference the `from` and `to` values in the timepicker. Instead of having a local `from` and `to` in the timepicker's `$scope`, I decided to directly reference the time filter's `time` (which has its own `from` and `to`) and directly modify them. This way, I don't have to wrap the call to `toggle` in a `$timeout` and the changes still propagate. \r\n\r\nCloses https://github.com/elastic/kibana/issues/9188.","created_at":"2016-11-24T00:48:20Z","updated_at":"2016-12-07T21:24:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4a5b67891cba8869756cc0e98dadc2ea8a2746f","assignee":{"login":"weltenwort","id":973741,"avatar_url":"https://avatars.githubusercontent.com/u/973741?v=3","gravatar_id":"","url":"https://api.github.com/users/weltenwort","html_url":"https://github.com/weltenwort","followers_url":"https://api.github.com/users/weltenwort/followers","following_url":"https://api.github.com/users/weltenwort/following{/other_user}","gists_url":"https://api.github.com/users/weltenwort/gists{/gist_id}","starred_url":"https://api.github.com/users/weltenwort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltenwort/subscriptions","organizations_url":"https://api.github.com/users/weltenwort/orgs","repos_url":"https://api.github.com/users/weltenwort/repos","events_url":"https://api.github.com/users/weltenwort/events{/privacy}","received_events_url":"https://api.github.com/users/weltenwort/received_events","type":"User","site_admin":false},"assignees":[{"login":"weltenwort","id":973741,"avatar_url":"https://avatars.githubusercontent.com/u/973741?v=3","gravatar_id":"","url":"https://api.github.com/users/weltenwort","html_url":"https://github.com/weltenwort","followers_url":"https://api.github.com/users/weltenwort/followers","following_url":"https://api.github.com/users/weltenwort/following{/other_user}","gists_url":"https://api.github.com/users/weltenwort/gists{/gist_id}","starred_url":"https://api.github.com/users/weltenwort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltenwort/subscriptions","organizations_url":"https://api.github.com/users/weltenwort/orgs","repos_url":"https://api.github.com/users/weltenwort/repos","events_url":"https://api.github.com/users/weltenwort/events{/privacy}","received_events_url":"https://api.github.com/users/weltenwort/received_events","type":"User","site_admin":false},{"login":"Bargs","id":6239176,"avatar_url":"https://avatars.githubusercontent.com/u/6239176?v=3","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/9218/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/9218/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/9218/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/d536ee1c9700ae198b956df23fdaf5a26b680c70","head":{"label":"lukasolson:timepicker/auto-close","ref":"timepicker/auto-close","sha":"d536ee1c9700ae198b956df23fdaf5a26b680c70","user":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars.githubusercontent.com/u/1178348?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"repo":{"id":26142062,"name":"kibana","full_name":"lukasolson/kibana","owner":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars.githubusercontent.com/u/1178348?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukasolson/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/lukasolson/kibana","forks_url":"https://api.github.com/repos/lukasolson/kibana/forks","keys_url":"https://api.github.com/repos/lukasolson/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukasolson/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukasolson/kibana/teams","hooks_url":"https://api.github.com/repos/lukasolson/kibana/hooks","issue_events_url":"https://api.github.com/repos/lukasolson/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/lukasolson/kibana/events","assignees_url":"https://api.github.com/repos/lukasolson/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/lukasolson/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/lukasolson/kibana/tags","blobs_url":"https://api.github.com/repos/lukasolson/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukasolson/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukasolson/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukasolson/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukasolson/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/lukasolson/kibana/languages","stargazers_url":"https://api.github.com/repos/lukasolson/kibana/stargazers","contributors_url":"https://api.github.com/repos/lukasolson/kibana/contributors","subscribers_url":"https://api.github.com/repos/lukasolson/kibana/subscribers","subscription_url":"https://api.github.com/repos/lukasolson/kibana/subscription","commits_url":"https://api.github.com/repos/lukasolson/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukasolson/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukasolson/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukasolson/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukasolson/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/lukasolson/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukasolson/kibana/merges","archive_url":"https://api.github.com/repos/lukasolson/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukasolson/kibana/downloads","issues_url":"https://api.github.com/repos/lukasolson/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/lukasolson/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/lukasolson/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/lukasolson/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukasolson/kibana/labels{/name}","releases_url":"https://api.github.com/repos/lukasolson/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/lukasolson/kibana/deployments","created_at":"2014-11-03T22:34:05Z","updated_at":"2016-01-12T17:24:57Z","pushed_at":"2016-12-07T18:46:12Z","git_url":"git://github.com/lukasolson/kibana.git","ssh_url":"git@github.com:lukasolson/kibana.git","clone_url":"https://github.com/lukasolson/kibana.git","svn_url":"https://github.com/lukasolson/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":221982,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"e1428f72892e39a27d08941015e54cbba9d05347","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2016-12-07T19:39:32Z","pushed_at":"2016-12-07T21:23:36Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":272802,"stargazers_count":6435,"watchers_count":6435,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2382,"mirror_url":null,"open_issues_count":1356,"forks":2382,"open_issues":1356,"watchers":6435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/9218"},"html":{"href":"https://github.com/elastic/kibana/pull/9218"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/9218"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/9218/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/9218/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/9218/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/d536ee1c9700ae198b956df23fdaf5a26b680c70"}}}}
{"actor":{"display_login":"Bargs"}}