{"action":"created","comment":{"url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments/63575376","id":63575376,"diff_hunk":"@@ -15,41 +15,50 @@ limitations under the License.\n */\n package markets.actors.participants\n \n-import markets.orders.Order\n+\n+import markets.actors.participants.strategies.OrderIssuingStrategy\n+import markets.orders.{AskOrder, BidOrder}\n import markets.orders.limit.{LimitAskOrder, LimitBidOrder}\n import markets.orders.market.{MarketAskOrder, MarketBidOrder}\n-import markets.actors.participants.strategies.TradingStrategy\n import markets.tradables.Tradable\n \n \n trait OrderIssuer {\n   this: MarketParticipant =>\n \n-  def tradingStrategy: TradingStrategy\n+  def askOrderIssuingStrategy: OrderIssuingStrategy[AskOrder]\n+\n+  def bidOrderIssuingStrategy: OrderIssuingStrategy[BidOrder]\n \n   def orderIssuerBehavior: Receive = {","path":"src/main/scala-2.11/markets/actors/participants/OrderIssuer.scala","position":22,"original_position":22,"commit_id":"2980b357b413c9a5462ddcd343225f244f0757cf","original_commit_id":"2980b357b413c9a5462ddcd343225f244f0757cf","user":{"login":"davidrpugh","id":2219562,"avatar_url":"https://avatars.githubusercontent.com/u/2219562?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrpugh","html_url":"https://github.com/davidrpugh","followers_url":"https://api.github.com/users/davidrpugh/followers","following_url":"https://api.github.com/users/davidrpugh/following{/other_user}","gists_url":"https://api.github.com/users/davidrpugh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrpugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrpugh/subscriptions","organizations_url":"https://api.github.com/users/davidrpugh/orgs","repos_url":"https://api.github.com/users/davidrpugh/repos","events_url":"https://api.github.com/users/davidrpugh/events{/privacy}","received_events_url":"https://api.github.com/users/davidrpugh/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Cyclomatic complexity of 11 exceeds max of 10](https://www.codacy.com/app/davidrpugh/markets-sandbox/file/2585568218/issues/source?bid=2921361&fileBranchId=3304063#l33)","created_at":"2016-05-17T18:15:12Z","updated_at":"2016-05-17T18:15:12Z","html_url":"https://github.com/ScalABM/markets-sandbox/pull/144#discussion_r63575376","pull_request_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments/63575376"},"html":{"href":"https://github.com/ScalABM/markets-sandbox/pull/144#discussion_r63575376"},"pull_request":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144","id":70395438,"html_url":"https://github.com/ScalABM/markets-sandbox/pull/144","diff_url":"https://github.com/ScalABM/markets-sandbox/pull/144.diff","patch_url":"https://github.com/ScalABM/markets-sandbox/pull/144.patch","issue_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/144","number":144,"state":"open","locked":false,"title":"Add random trading strategy","user":{"login":"davidrpugh","id":2219562,"avatar_url":"https://avatars.githubusercontent.com/u/2219562?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrpugh","html_url":"https://github.com/davidrpugh","followers_url":"https://api.github.com/users/davidrpugh/followers","following_url":"https://api.github.com/users/davidrpugh/following{/other_user}","gists_url":"https://api.github.com/users/davidrpugh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrpugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrpugh/subscriptions","organizations_url":"https://api.github.com/users/davidrpugh/orgs","repos_url":"https://api.github.com/users/davidrpugh/repos","events_url":"https://api.github.com/users/davidrpugh/events{/privacy}","received_events_url":"https://api.github.com/users/davidrpugh/received_events","type":"User","site_admin":false},"body":"This PR adds support for random trading strategies using distributions from `org.apache.commons.math3` packages.","created_at":"2016-05-17T17:15:06Z","updated_at":"2016-05-17T18:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a7cc8c2e642a6e4022000c82219834ad2aeb889","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144/commits","review_comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144/comments","review_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/144/comments","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/2980b357b413c9a5462ddcd343225f244f0757cf","head":{"label":"ScalABM:add-random-trading-strategy","ref":"add-random-trading-strategy","sha":"2980b357b413c9a5462ddcd343225f244f0757cf","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"markets-sandbox","full_name":"ScalABM/markets-sandbox","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/markets-sandbox","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/markets-sandbox","forks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/forks","keys_url":"https://api.github.com/repos/ScalABM/markets-sandbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/markets-sandbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/markets-sandbox/teams","hooks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/events","assignees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/markets-sandbox/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/tags","blobs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/markets-sandbox/languages","stargazers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscription","commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/markets-sandbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/markets-sandbox/merges","archive_url":"https://api.github.com/repos/ScalABM/markets-sandbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/markets-sandbox/downloads","issues_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/markets-sandbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/markets-sandbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/markets-sandbox/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/markets-sandbox/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-02-12T14:49:56Z","pushed_at":"2016-05-17T18:13:21Z","git_url":"git://github.com/ScalABM/markets-sandbox.git","ssh_url":"git@github.com:ScalABM/markets-sandbox.git","clone_url":"https://github.com/ScalABM/markets-sandbox.git","svn_url":"https://github.com/ScalABM/markets-sandbox","homepage":null,"size":785,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"ScalABM:develop","ref":"develop","sha":"702f5f5b125688d0fc324ea443f0b2e2e85a5df1","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"markets-sandbox","full_name":"ScalABM/markets-sandbox","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/markets-sandbox","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/markets-sandbox","forks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/forks","keys_url":"https://api.github.com/repos/ScalABM/markets-sandbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/markets-sandbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/markets-sandbox/teams","hooks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/events","assignees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/markets-sandbox/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/tags","blobs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/markets-sandbox/languages","stargazers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscription","commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/markets-sandbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/markets-sandbox/merges","archive_url":"https://api.github.com/repos/ScalABM/markets-sandbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/markets-sandbox/downloads","issues_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/markets-sandbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/markets-sandbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/markets-sandbox/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/markets-sandbox/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-02-12T14:49:56Z","pushed_at":"2016-05-17T18:13:21Z","git_url":"git://github.com/ScalABM/markets-sandbox.git","ssh_url":"git@github.com:ScalABM/markets-sandbox.git","clone_url":"https://github.com/ScalABM/markets-sandbox.git","svn_url":"https://github.com/ScalABM/markets-sandbox","homepage":null,"size":785,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144"},"html":{"href":"https://github.com/ScalABM/markets-sandbox/pull/144"},"issue":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/144"},"comments":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/2980b357b413c9a5462ddcd343225f244f0757cf"}}}}