{"action":"closed","number":266,"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit/pulls/266","id":87378545,"html_url":"https://github.com/ros-planning/moveit/pull/266","diff_url":"https://github.com/ros-planning/moveit/pull/266.diff","patch_url":"https://github.com/ros-planning/moveit/pull/266.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit/issues/266","number":266,"state":"closed","locked":false,"title":"Move URDF and SRDF loading helper functions into rdf_loader","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"body":"Moves @ipa-mdl's URDF loading helper class (based on my code from the MSA)  from the Setup Assistant into the more generic ``rdf_loader.h`` file. This allows more code-reuse, both in the MSA and for other locations throughout MoveIt! (TODO) including some tests I'm writing.\r\n\r\nI also created a new function ``loadPkgFileToString()`` that instead of taking a fully resolved package path inputs a package name (``baxter_description``) and a relative path (``urdf/baxter.urdf``)\r\n\r\nThe changes in the MSA also allow SRDFs to be loaded using xacro now.\r\n\r\nFinally, I name-spaced the error messages in the rdf_loader\r\n\r\nThis could be backported, but there is a small chance someone is depending on the include file exported from the setup assistant. This is not the intended use-case, but it is possible.","created_at":"2016-09-29T19:33:09Z","updated_at":"2016-10-01T18:01:31Z","closed_at":"2016-10-01T18:01:31Z","merged_at":"2016-10-01T18:01:31Z","merge_commit_sha":"e20da8fd56ab158f8f174990ea4b6a2ffdc48ec0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit/pulls/266/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit/pulls/266/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit/issues/266/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/9f8784bfdb80618cb7b658616676cfe6360ef695","head":{"label":"davetcoleman:kinetic-rdf-loader","ref":"kinetic-rdf-loader","sha":"9f8784bfdb80618cb7b658616676cfe6360ef695","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"repo":{"id":65497759,"name":"moveit","full_name":"davetcoleman/moveit","owner":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davetcoleman/moveit","description":"The MoveIt! motion planning framework","fork":true,"url":"https://api.github.com/repos/davetcoleman/moveit","forks_url":"https://api.github.com/repos/davetcoleman/moveit/forks","keys_url":"https://api.github.com/repos/davetcoleman/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davetcoleman/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davetcoleman/moveit/teams","hooks_url":"https://api.github.com/repos/davetcoleman/moveit/hooks","issue_events_url":"https://api.github.com/repos/davetcoleman/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/davetcoleman/moveit/events","assignees_url":"https://api.github.com/repos/davetcoleman/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/davetcoleman/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/davetcoleman/moveit/tags","blobs_url":"https://api.github.com/repos/davetcoleman/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davetcoleman/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davetcoleman/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/davetcoleman/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davetcoleman/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/davetcoleman/moveit/languages","stargazers_url":"https://api.github.com/repos/davetcoleman/moveit/stargazers","contributors_url":"https://api.github.com/repos/davetcoleman/moveit/contributors","subscribers_url":"https://api.github.com/repos/davetcoleman/moveit/subscribers","subscription_url":"https://api.github.com/repos/davetcoleman/moveit/subscription","commits_url":"https://api.github.com/repos/davetcoleman/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/davetcoleman/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/davetcoleman/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/davetcoleman/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/davetcoleman/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/davetcoleman/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davetcoleman/moveit/merges","archive_url":"https://api.github.com/repos/davetcoleman/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davetcoleman/moveit/downloads","issues_url":"https://api.github.com/repos/davetcoleman/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/davetcoleman/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/davetcoleman/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/davetcoleman/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davetcoleman/moveit/labels{/name}","releases_url":"https://api.github.com/repos/davetcoleman/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/davetcoleman/moveit/deployments","created_at":"2016-08-11T19:59:36Z","updated_at":"2016-08-11T19:59:41Z","pushed_at":"2016-09-30T22:04:14Z","git_url":"git://github.com/davetcoleman/moveit.git","ssh_url":"git@github.com:davetcoleman/moveit.git","clone_url":"https://github.com/davetcoleman/moveit.git","svn_url":"https://github.com/davetcoleman/moveit","homepage":"http://moveit.ros.org/","size":51334,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros-planning:kinetic-devel","ref":"kinetic-devel","sha":"d39548cb4c94baa03e7ac47ee50b584b1e2b4fb6","user":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":64340188,"name":"moveit","full_name":"ros-planning/moveit","owner":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-planning/moveit","description":"The MoveIt! motion planning framework","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit","forks_url":"https://api.github.com/repos/ros-planning/moveit/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit/deployments","created_at":"2016-07-27T20:38:09Z","updated_at":"2016-09-29T03:08:13Z","pushed_at":"2016-10-01T18:01:31Z","git_url":"git://github.com/ros-planning/moveit.git","ssh_url":"git@github.com:ros-planning/moveit.git","clone_url":"https://github.com/ros-planning/moveit.git","svn_url":"https://github.com/ros-planning/moveit","homepage":"http://moveit.ros.org/","size":54465,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":77,"forks":35,"open_issues":77,"watchers":26,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/266"},"html":{"href":"https://github.com/ros-planning/moveit/pull/266"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/266"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit/statuses/9f8784bfdb80618cb7b658616676cfe6360ef695"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"comments":2,"review_comments":12,"commits":1,"additions":161,"deletions":232,"changed_files":7}}
{"actor":{"display_login":"v4hn"}}