{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/55257433","id":55257433,"diff_hunk":"@@ -174,7 +175,7 @@ func (d *AllocDir) Build(tasks []*structs.Task) error {\n // their intended, relative location within the task directory. Embed attempts\n // hardlink and then defaults to copying. If the path exists on the host and\n // can't be embeded an error is returned.\n-func (d *AllocDir) Embed(task string, entries map[string]string) error {\n+func (d *AllocDir) Embed(task string, entries map[string]string, roots map[string]string) error {","path":"client/allocdir/alloc_dir.go","position":13,"original_position":13,"commit_id":"85421361ea5300acaf163e6b23477684b594b775","original_commit_id":"85421361ea5300acaf163e6b23477684b594b775","user":{"login":"dadgar","id":1047914,"avatar_url":"https://avatars.githubusercontent.com/u/1047914?v=3","gravatar_id":"","url":"https://api.github.com/users/dadgar","html_url":"https://github.com/dadgar","followers_url":"https://api.github.com/users/dadgar/followers","following_url":"https://api.github.com/users/dadgar/following{/other_user}","gists_url":"https://api.github.com/users/dadgar/gists{/gist_id}","starred_url":"https://api.github.com/users/dadgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadgar/subscriptions","organizations_url":"https://api.github.com/users/dadgar/orgs","repos_url":"https://api.github.com/users/dadgar/repos","events_url":"https://api.github.com/users/dadgar/events{/privacy}","received_events_url":"https://api.github.com/users/dadgar/received_events","type":"User","site_admin":false},"body":"Could you create an `embedImpl` method that takes the roots and keep the API of embed the same. `Embed` and then call `embedImpl(entries, entries)`","created_at":"2016-03-07T19:29:25Z","updated_at":"2016-03-07T19:29:25Z","html_url":"https://github.com/hashicorp/nomad/pull/881#discussion_r55257433","pull_request_url":"https://api.github.com/repos/hashicorp/nomad/pulls/881","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/55257433"},"html":{"href":"https://github.com/hashicorp/nomad/pull/881#discussion_r55257433"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/881"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/881","id":61665746,"html_url":"https://github.com/hashicorp/nomad/pull/881","diff_url":"https://github.com/hashicorp/nomad/pull/881.diff","patch_url":"https://github.com/hashicorp/nomad/pull/881.patch","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/881","number":881,"state":"open","locked":false,"title":"Gracefully handle unreachable symlinks in chroot","user":{"login":"parasyte","id":456942,"avatar_url":"https://avatars.githubusercontent.com/u/456942?v=3","gravatar_id":"","url":"https://api.github.com/users/parasyte","html_url":"https://github.com/parasyte","followers_url":"https://api.github.com/users/parasyte/followers","following_url":"https://api.github.com/users/parasyte/following{/other_user}","gists_url":"https://api.github.com/users/parasyte/gists{/gist_id}","starred_url":"https://api.github.com/users/parasyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parasyte/subscriptions","organizations_url":"https://api.github.com/users/parasyte/orgs","repos_url":"https://api.github.com/users/parasyte/repos","events_url":"https://api.github.com/users/parasyte/events{/privacy}","received_events_url":"https://api.github.com/users/parasyte/received_events","type":"User","site_admin":false},"body":"- Fixes a bug on Ubuntu 14.04, where /etc/resolv.conf is a symlink to /run/resolvconf/resolv.conf\r\n- Notice /run is not included in the chroot. The net effect is that DNS resolutions are not possible from the chroot\r\n- During recursive chroot copy, resolve symlinks to absolute paths for comparison againt chroot directories\r\n- Use symlinks for reachable files, or hardlink/copy unreachable files","created_at":"2016-03-04T04:25:17Z","updated_at":"2016-03-07T19:29:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c481766eed70b46cc697a315ebfc046cdffab358","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/nomad/pulls/881/commits","review_comments_url":"https://api.github.com/repos/hashicorp/nomad/pulls/881/comments","review_comment_url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/881/comments","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/85421361ea5300acaf163e6b23477684b594b775","head":{"label":"pubnub:bug/resolve-unreachable-symlinks","ref":"bug/resolve-unreachable-symlinks","sha":"85421361ea5300acaf163e6b23477684b594b775","user":{"login":"pubnub","id":297109,"avatar_url":"https://avatars.githubusercontent.com/u/297109?v=3","gravatar_id":"","url":"https://api.github.com/users/pubnub","html_url":"https://github.com/pubnub","followers_url":"https://api.github.com/users/pubnub/followers","following_url":"https://api.github.com/users/pubnub/following{/other_user}","gists_url":"https://api.github.com/users/pubnub/gists{/gist_id}","starred_url":"https://api.github.com/users/pubnub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubnub/subscriptions","organizations_url":"https://api.github.com/users/pubnub/orgs","repos_url":"https://api.github.com/users/pubnub/repos","events_url":"https://api.github.com/users/pubnub/events{/privacy}","received_events_url":"https://api.github.com/users/pubnub/received_events","type":"Organization","site_admin":false},"repo":{"id":53107157,"name":"nomad","full_name":"pubnub/nomad","owner":{"login":"pubnub","id":297109,"avatar_url":"https://avatars.githubusercontent.com/u/297109?v=3","gravatar_id":"","url":"https://api.github.com/users/pubnub","html_url":"https://github.com/pubnub","followers_url":"https://api.github.com/users/pubnub/followers","following_url":"https://api.github.com/users/pubnub/following{/other_user}","gists_url":"https://api.github.com/users/pubnub/gists{/gist_id}","starred_url":"https://api.github.com/users/pubnub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubnub/subscriptions","organizations_url":"https://api.github.com/users/pubnub/orgs","repos_url":"https://api.github.com/users/pubnub/repos","events_url":"https://api.github.com/users/pubnub/events{/privacy}","received_events_url":"https://api.github.com/users/pubnub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pubnub/nomad","description":"A Distributed, Highly Available, Datacenter-Aware Scheduler","fork":true,"url":"https://api.github.com/repos/pubnub/nomad","forks_url":"https://api.github.com/repos/pubnub/nomad/forks","keys_url":"https://api.github.com/repos/pubnub/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pubnub/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pubnub/nomad/teams","hooks_url":"https://api.github.com/repos/pubnub/nomad/hooks","issue_events_url":"https://api.github.com/repos/pubnub/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/pubnub/nomad/events","assignees_url":"https://api.github.com/repos/pubnub/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/pubnub/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/pubnub/nomad/tags","blobs_url":"https://api.github.com/repos/pubnub/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pubnub/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pubnub/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/pubnub/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pubnub/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/pubnub/nomad/languages","stargazers_url":"https://api.github.com/repos/pubnub/nomad/stargazers","contributors_url":"https://api.github.com/repos/pubnub/nomad/contributors","subscribers_url":"https://api.github.com/repos/pubnub/nomad/subscribers","subscription_url":"https://api.github.com/repos/pubnub/nomad/subscription","commits_url":"https://api.github.com/repos/pubnub/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/pubnub/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/pubnub/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/pubnub/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/pubnub/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/pubnub/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pubnub/nomad/merges","archive_url":"https://api.github.com/repos/pubnub/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pubnub/nomad/downloads","issues_url":"https://api.github.com/repos/pubnub/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/pubnub/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/pubnub/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/pubnub/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pubnub/nomad/labels{/name}","releases_url":"https://api.github.com/repos/pubnub/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/pubnub/nomad/deployments","created_at":"2016-03-04T04:23:41Z","updated_at":"2016-03-04T04:29:26Z","pushed_at":"2016-03-04T04:24:57Z","git_url":"git://github.com/pubnub/nomad.git","ssh_url":"git@github.com:pubnub/nomad.git","clone_url":"https://github.com/pubnub/nomad.git","svn_url":"https://github.com/pubnub/nomad","homepage":"https://www.nomadproject.io/","size":20690,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"0e1ca4b2ce8668be27f9837860bdb191bbe04b92","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"name":"nomad","full_name":"hashicorp/nomad","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/nomad","description":"A Distributed, Highly Available, Datacenter-Aware Scheduler","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2016-03-07T09:18:35Z","pushed_at":"2016-03-07T19:27:26Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":22529,"stargazers_count":1364,"watchers_count":1364,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":114,"forks":157,"open_issues":114,"watchers":1364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/881"},"html":{"href":"https://github.com/hashicorp/nomad/pull/881"},"issue":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/881"},"comments":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/881/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/881/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/881/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/nomad/statuses/85421361ea5300acaf163e6b23477684b594b775"}}}}