{"action":"closed","number":12563,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/12563","id":42148596,"html_url":"https://github.com/JuliaLang/julia/pull/12563","diff_url":"https://github.com/JuliaLang/julia/pull/12563.diff","patch_url":"https://github.com/JuliaLang/julia/pull/12563.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/12563","number":12563,"state":"closed","locked":false,"title":"max and min of NaN return NaN","user":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"body":"As an experiment, this patch changes `max` and `min` (and related functions) to propagate `NaN` values, as discussed in #7866.  (I'm not sure whether #7866 was resolved in favor of this or not, but I thought I would see what it looked like.)\r\n\r\nWhile I agree with Kahan that, in principle, it makes some sense for `max(NaN,Inf)` to return `Inf`, I agree with @danluu that it's not worth adding an extra branch to an inner-loop function like this for a \"corner case of a corner case\" in which the correct behavior is ambiguous.\r\n\r\nAs a side-effect, this fixes #12552, although #12564 fixes that anyway.","created_at":"2015-08-11T16:23:31Z","updated_at":"2016-09-16T16:11:26Z","closed_at":"2016-09-16T16:11:26Z","merged_at":"2016-09-16T16:11:26Z","merge_commit_sha":"628d0e4bdaccd190e53ca0cb77deb13174b55834","assignee":{"login":"StefanKarpinski","id":153596,"avatar_url":"https://avatars.githubusercontent.com/u/153596?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKarpinski","html_url":"https://github.com/StefanKarpinski","followers_url":"https://api.github.com/users/StefanKarpinski/followers","following_url":"https://api.github.com/users/StefanKarpinski/following{/other_user}","gists_url":"https://api.github.com/users/StefanKarpinski/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKarpinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKarpinski/subscriptions","organizations_url":"https://api.github.com/users/StefanKarpinski/orgs","repos_url":"https://api.github.com/users/StefanKarpinski/repos","events_url":"https://api.github.com/users/StefanKarpinski/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKarpinski/received_events","type":"User","site_admin":false},"assignees":[{"login":"StefanKarpinski","id":153596,"avatar_url":"https://avatars.githubusercontent.com/u/153596?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKarpinski","html_url":"https://github.com/StefanKarpinski","followers_url":"https://api.github.com/users/StefanKarpinski/followers","following_url":"https://api.github.com/users/StefanKarpinski/following{/other_user}","gists_url":"https://api.github.com/users/StefanKarpinski/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKarpinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKarpinski/subscriptions","organizations_url":"https://api.github.com/users/StefanKarpinski/orgs","repos_url":"https://api.github.com/users/StefanKarpinski/repos","events_url":"https://api.github.com/users/StefanKarpinski/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKarpinski/received_events","type":"User","site_admin":false},{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/20","html_url":"https://github.com/JuliaLang/julia/milestones/0.6.0","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/20/labels","id":1298021,"number":20,"title":"0.6.0","description":"","creator":{"login":"JeffBezanson","id":744556,"avatar_url":"https://avatars.githubusercontent.com/u/744556?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffBezanson","html_url":"https://github.com/JeffBezanson","followers_url":"https://api.github.com/users/JeffBezanson/followers","following_url":"https://api.github.com/users/JeffBezanson/following{/other_user}","gists_url":"https://api.github.com/users/JeffBezanson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBezanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBezanson/subscriptions","organizations_url":"https://api.github.com/users/JeffBezanson/orgs","repos_url":"https://api.github.com/users/JeffBezanson/repos","events_url":"https://api.github.com/users/JeffBezanson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBezanson/received_events","type":"User","site_admin":false},"open_issues":205,"closed_issues":20,"state":"open","created_at":"2015-09-09T16:35:16Z","updated_at":"2016-09-16T16:11:26Z","due_on":"2016-10-01T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12563/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12563/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/12563/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/b1ecd5622eedc20e99e8bc70a45a1c7df17badd4","head":{"label":"stevengj:maxnan","ref":"maxnan","sha":"b1ecd5622eedc20e99e8bc70a45a1c7df17badd4","user":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"repo":{"id":7264997,"name":"julia","full_name":"stevengj/julia","owner":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevengj/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/stevengj/julia","forks_url":"https://api.github.com/repos/stevengj/julia/forks","keys_url":"https://api.github.com/repos/stevengj/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevengj/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevengj/julia/teams","hooks_url":"https://api.github.com/repos/stevengj/julia/hooks","issue_events_url":"https://api.github.com/repos/stevengj/julia/issues/events{/number}","events_url":"https://api.github.com/repos/stevengj/julia/events","assignees_url":"https://api.github.com/repos/stevengj/julia/assignees{/user}","branches_url":"https://api.github.com/repos/stevengj/julia/branches{/branch}","tags_url":"https://api.github.com/repos/stevengj/julia/tags","blobs_url":"https://api.github.com/repos/stevengj/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevengj/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevengj/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevengj/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevengj/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/stevengj/julia/languages","stargazers_url":"https://api.github.com/repos/stevengj/julia/stargazers","contributors_url":"https://api.github.com/repos/stevengj/julia/contributors","subscribers_url":"https://api.github.com/repos/stevengj/julia/subscribers","subscription_url":"https://api.github.com/repos/stevengj/julia/subscription","commits_url":"https://api.github.com/repos/stevengj/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevengj/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevengj/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevengj/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevengj/julia/contents/{+path}","compare_url":"https://api.github.com/repos/stevengj/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevengj/julia/merges","archive_url":"https://api.github.com/repos/stevengj/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevengj/julia/downloads","issues_url":"https://api.github.com/repos/stevengj/julia/issues{/number}","pulls_url":"https://api.github.com/repos/stevengj/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/stevengj/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/stevengj/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevengj/julia/labels{/name}","releases_url":"https://api.github.com/repos/stevengj/julia/releases{/id}","deployments_url":"https://api.github.com/repos/stevengj/julia/deployments","created_at":"2012-12-20T21:59:35Z","updated_at":"2015-11-06T22:23:44Z","pushed_at":"2016-09-14T02:10:40Z","git_url":"git://github.com/stevengj/julia.git","ssh_url":"git@github.com:stevengj/julia.git","clone_url":"https://github.com/stevengj/julia.git","svn_url":"https://github.com/stevengj/julia","homepage":"http://julialang.org/","size":90065,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"fb503a0f6420d2443b90e4584f58aa1baec1868e","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-09-16T11:38:20Z","pushed_at":"2016-09-16T16:11:26Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":422185,"stargazers_count":7504,"watchers_count":7504,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1757,"mirror_url":null,"open_issues_count":1978,"forks":1757,"open_issues":1978,"watchers":7504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12563"},"html":{"href":"https://github.com/JuliaLang/julia/pull/12563"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/12563"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/12563/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12563/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12563/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/b1ecd5622eedc20e99e8bc70a45a1c7df17badd4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"StefanKarpinski","id":153596,"avatar_url":"https://avatars.githubusercontent.com/u/153596?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKarpinski","html_url":"https://github.com/StefanKarpinski","followers_url":"https://api.github.com/users/StefanKarpinski/followers","following_url":"https://api.github.com/users/StefanKarpinski/following{/other_user}","gists_url":"https://api.github.com/users/StefanKarpinski/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKarpinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKarpinski/subscriptions","organizations_url":"https://api.github.com/users/StefanKarpinski/orgs","repos_url":"https://api.github.com/users/StefanKarpinski/repos","events_url":"https://api.github.com/users/StefanKarpinski/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKarpinski/received_events","type":"User","site_admin":false},"comments":23,"review_comments":0,"commits":1,"additions":41,"deletions":37,"changed_files":7}}
{"actor":{"display_login":"StefanKarpinski"}}