{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219","repository_url":"https://api.github.com/repos/Microsoft/vcpkg","labels_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219/comments","events_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219/events","html_url":"https://github.com/Microsoft/vcpkg/pull/219","id":185276114,"number":219,"title":"Qt5 add","user":{"login":"Barath-Kannan","id":3630546,"avatar_url":"https://avatars.githubusercontent.com/u/3630546?v=3","gravatar_id":"","url":"https://api.github.com/users/Barath-Kannan","html_url":"https://github.com/Barath-Kannan","followers_url":"https://api.github.com/users/Barath-Kannan/followers","following_url":"https://api.github.com/users/Barath-Kannan/following{/other_user}","gists_url":"https://api.github.com/users/Barath-Kannan/gists{/gist_id}","starred_url":"https://api.github.com/users/Barath-Kannan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barath-Kannan/subscriptions","organizations_url":"https://api.github.com/users/Barath-Kannan/orgs","repos_url":"https://api.github.com/users/Barath-Kannan/repos","events_url":"https://api.github.com/users/Barath-Kannan/events{/privacy}","received_events_url":"https://api.github.com/users/Barath-Kannan/received_events","type":"User","site_admin":false},"labels":[{"id":446354983,"url":"https://api.github.com/repos/Microsoft/vcpkg/labels/cla-signed","name":"cla-signed","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-10-26T01:41:41Z","updated_at":"2016-11-01T22:19:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vcpkg/pulls/219","html_url":"https://github.com/Microsoft/vcpkg/pull/219","diff_url":"https://github.com/Microsoft/vcpkg/pull/219.diff","patch_url":"https://github.com/Microsoft/vcpkg/pull/219.patch"},"body":"Added Qt5.7 application framework. The webengine, tests, and examples have been excluded as they would significantly increase the build time and storage requirements (it already needs like ~3GB for a dynamic build, and ~7GB for a static build). These can be added later in separate package. The webengine is also known to be very fickle during builds. I had to add in another function (vcpkg_execute_required_process_repeat) which will repeatedly try to build up to a certain number of failures, as the build can sometimes fail when performing a static build and just needs to be re-run to continue. I also added the jom tool; Qt's version of nmake which supports parallel builds. Without it, the build time would increase by several orders of magnitude. Qt already takes an hour or 2 to build and install so this would be very undesirable. Also of note, this package builds the open source version of Qt, which is LGPLv3. If needed, another package can be added for the commercial version. \n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/comments/257716211","html_url":"https://github.com/Microsoft/vcpkg/pull/219#issuecomment-257716211","issue_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/219","id":257716211,"user":{"login":"ras0219-msft","id":12301622,"avatar_url":"https://avatars.githubusercontent.com/u/12301622?v=3","gravatar_id":"","url":"https://api.github.com/users/ras0219-msft","html_url":"https://github.com/ras0219-msft","followers_url":"https://api.github.com/users/ras0219-msft/followers","following_url":"https://api.github.com/users/ras0219-msft/following{/other_user}","gists_url":"https://api.github.com/users/ras0219-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/ras0219-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ras0219-msft/subscriptions","organizations_url":"https://api.github.com/users/ras0219-msft/orgs","repos_url":"https://api.github.com/users/ras0219-msft/repos","events_url":"https://api.github.com/users/ras0219-msft/events{/privacy}","received_events_url":"https://api.github.com/users/ras0219-msft/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T22:19:00Z","updated_at":"2016-11-01T22:19:00Z","body":"The only circumstance where it would be preferable in the longer term to depend on the checked-in dependencies is if Qt has fully forked the libraries (made breaking changes, moved all the symbols into a namespace, etc). In this case, we effectively have `qt-zlib` alongside `zlib` and they don't conflict with each other. If Qt has _not_ renamed all the symbols (which I suspect they have not), then in order to make static linking work correctly and ensure user sanity, we must use the system libs.\r\n\r\nNote that the above argument only applies to the runtimes that will be linked with the user's application. The tools can very well link whatever they want for robustness; this is an advantage of downloading the prebuilt and pre-tested executables and placing those directly into `tools\\` directory.\r\n\r\nWhat do you mean by \"if we depend on the platform libs then they won't be installed along side outputs\"?"}}
{"actor":{"display_login":"ras0219-msft"}}