{"action":"opened","number":1876,"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1876","id":77298548,"html_url":"https://github.com/KhronosGroup/WebGL/pull/1876","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1876.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1876.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1876","number":1876,"state":"open","locked":false,"title":"Add a lint tool for catching common mistakes in test files","user":{"login":"renchenglei","id":13829262,"avatar_url":"https://avatars.githubusercontent.com/u/13829262?v=3","gravatar_id":"","url":"https://api.github.com/users/renchenglei","html_url":"https://github.com/renchenglei","followers_url":"https://api.github.com/users/renchenglei/followers","following_url":"https://api.github.com/users/renchenglei/following{/other_user}","gists_url":"https://api.github.com/users/renchenglei/gists{/gist_id}","starred_url":"https://api.github.com/users/renchenglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renchenglei/subscriptions","organizations_url":"https://api.github.com/users/renchenglei/orgs","repos_url":"https://api.github.com/users/renchenglei/repos","events_url":"https://api.github.com/users/renchenglei/events{/privacy}","received_events_url":"https://api.github.com/users/renchenglei/received_events","type":"User","site_admin":false},"body":"@kenrussell @zhenyao @Honry I modified the lint tool to make it more suitable for WebGL. In WebGL conformance tests, most of lint errors are TRAILING WHITESPACE, INDENT TABS and CR AT EOL. So we removed non-existent lint error scansion and ran the tool without installing libraries. Since there are many *.js *.frag and *.vert files in WebGL tests, we also scanned this three file formats in our new tool. You can try the tool from the root of your local WebGL/sdk/tests working directory as follow:\r\n**If you want to check your pull request:**\r\n`./py/lint/lint.py -p`\r\n**If check specified folder, the specified folder must be relative path of WebGL/sdk/tests:**\r\n`./py/lint/lint.py -d conformance/attribs`\r\n**If check other repos, you can specify the repo name with `-r`, default is WebGL/sdk/tests:**\r\n`./py/lint/lint.py -r demo-express`\r\nLooking forward to your suggestion, thanks a lot!","created_at":"2016-07-13T14:27:33Z","updated_at":"2016-07-13T14:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1876/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1876/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1876/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/76efea3edfc5a98becb45060edbd1572f067e9db","head":{"label":"renchenglei:addlinttool","ref":"addlinttool","sha":"76efea3edfc5a98becb45060edbd1572f067e9db","user":{"login":"renchenglei","id":13829262,"avatar_url":"https://avatars.githubusercontent.com/u/13829262?v=3","gravatar_id":"","url":"https://api.github.com/users/renchenglei","html_url":"https://github.com/renchenglei","followers_url":"https://api.github.com/users/renchenglei/followers","following_url":"https://api.github.com/users/renchenglei/following{/other_user}","gists_url":"https://api.github.com/users/renchenglei/gists{/gist_id}","starred_url":"https://api.github.com/users/renchenglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renchenglei/subscriptions","organizations_url":"https://api.github.com/users/renchenglei/orgs","repos_url":"https://api.github.com/users/renchenglei/repos","events_url":"https://api.github.com/users/renchenglei/events{/privacy}","received_events_url":"https://api.github.com/users/renchenglei/received_events","type":"User","site_admin":false},"repo":{"id":61951213,"name":"WebGL","full_name":"renchenglei/WebGL","owner":{"login":"renchenglei","id":13829262,"avatar_url":"https://avatars.githubusercontent.com/u/13829262?v=3","gravatar_id":"","url":"https://api.github.com/users/renchenglei","html_url":"https://github.com/renchenglei","followers_url":"https://api.github.com/users/renchenglei/followers","following_url":"https://api.github.com/users/renchenglei/following{/other_user}","gists_url":"https://api.github.com/users/renchenglei/gists{/gist_id}","starred_url":"https://api.github.com/users/renchenglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renchenglei/subscriptions","organizations_url":"https://api.github.com/users/renchenglei/orgs","repos_url":"https://api.github.com/users/renchenglei/repos","events_url":"https://api.github.com/users/renchenglei/events{/privacy}","received_events_url":"https://api.github.com/users/renchenglei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renchenglei/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/renchenglei/WebGL","forks_url":"https://api.github.com/repos/renchenglei/WebGL/forks","keys_url":"https://api.github.com/repos/renchenglei/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renchenglei/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renchenglei/WebGL/teams","hooks_url":"https://api.github.com/repos/renchenglei/WebGL/hooks","issue_events_url":"https://api.github.com/repos/renchenglei/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/renchenglei/WebGL/events","assignees_url":"https://api.github.com/repos/renchenglei/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/renchenglei/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/renchenglei/WebGL/tags","blobs_url":"https://api.github.com/repos/renchenglei/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renchenglei/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renchenglei/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/renchenglei/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renchenglei/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/renchenglei/WebGL/languages","stargazers_url":"https://api.github.com/repos/renchenglei/WebGL/stargazers","contributors_url":"https://api.github.com/repos/renchenglei/WebGL/contributors","subscribers_url":"https://api.github.com/repos/renchenglei/WebGL/subscribers","subscription_url":"https://api.github.com/repos/renchenglei/WebGL/subscription","commits_url":"https://api.github.com/repos/renchenglei/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/renchenglei/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/renchenglei/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/renchenglei/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/renchenglei/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/renchenglei/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renchenglei/WebGL/merges","archive_url":"https://api.github.com/repos/renchenglei/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renchenglei/WebGL/downloads","issues_url":"https://api.github.com/repos/renchenglei/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/renchenglei/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/renchenglei/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/renchenglei/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renchenglei/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/renchenglei/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/renchenglei/WebGL/deployments","created_at":"2016-06-25T16:13:21Z","updated_at":"2016-06-25T16:13:45Z","pushed_at":"2016-07-13T10:59:47Z","git_url":"git://github.com/renchenglei/WebGL.git","ssh_url":"git@github.com:renchenglei/WebGL.git","clone_url":"https://github.com/renchenglei/WebGL.git","svn_url":"https://github.com/renchenglei/WebGL","homepage":null,"size":22271,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"ab4246da036084d42f004b65400d6486363057e2","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2016-07-09T03:03:54Z","pushed_at":"2016-07-13T14:27:33Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29175,"stargazers_count":637,"watchers_count":637,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":315,"mirror_url":null,"open_issues_count":67,"forks":315,"open_issues":67,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1876"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1876"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1876"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1876/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1876/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1876/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/76efea3edfc5a98becb45060edbd1572f067e9db"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":365,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"renchenglei"}}