{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/54524026","id":54524026,"diff_hunk":"@@ -783,7 +812,7 @@ describe('ReactCompositeComponent', function() {\n \n       render: function() {\n         var output = <Child />;\n-        if (!this.state.flag) {\n+        if (this.state.flag) {","path":"src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js","position":41,"original_position":41,"commit_id":"1b8b939a5009d5fdb7d864068a0416e46ae4e714","original_commit_id":"1b8b939a5009d5fdb7d864068a0416e46ae4e714","user":{"login":"raineroviir","id":10455065,"avatar_url":"https://avatars.githubusercontent.com/u/10455065?v=3","gravatar_id":"","url":"https://api.github.com/users/raineroviir","html_url":"https://github.com/raineroviir","followers_url":"https://api.github.com/users/raineroviir/followers","following_url":"https://api.github.com/users/raineroviir/following{/other_user}","gists_url":"https://api.github.com/users/raineroviir/gists{/gist_id}","starred_url":"https://api.github.com/users/raineroviir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raineroviir/subscriptions","organizations_url":"https://api.github.com/users/raineroviir/orgs","repos_url":"https://api.github.com/users/raineroviir/repos","events_url":"https://api.github.com/users/raineroviir/events{/privacy}","received_events_url":"https://api.github.com/users/raineroviir/received_events","type":"User","site_admin":false},"body":"I wanted to see why the test was throwing the warning \r\n1. in the original test we rendered `<Parent> <Child /> <Parent>`, and on `setState` we change the render to `<Parent><span>Child</span></Parent>`\r\n2. in the changed test which doesn't create a warning we go from `<P><span>Child</span> </P>` to `<P><Child /><P>`","created_at":"2016-03-01T05:18:30Z","updated_at":"2016-03-01T05:18:30Z","html_url":"https://github.com/facebook/react/pull/6121#discussion_r54524026","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/6121","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/54524026"},"html":{"href":"https://github.com/facebook/react/pull/6121#discussion_r54524026"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/6121"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/6121","id":60730947,"html_url":"https://github.com/facebook/react/pull/6121","diff_url":"https://github.com/facebook/react/pull/6121.diff","patch_url":"https://github.com/facebook/react/pull/6121.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/6121","number":6121,"state":"open","locked":false,"title":"Fix #6114 - Calling setState inside getChildContext should warn","user":{"login":"raineroviir","id":10455065,"avatar_url":"https://avatars.githubusercontent.com/u/10455065?v=3","gravatar_id":"","url":"https://api.github.com/users/raineroviir","html_url":"https://github.com/raineroviir","followers_url":"https://api.github.com/users/raineroviir/followers","following_url":"https://api.github.com/users/raineroviir/following{/other_user}","gists_url":"https://api.github.com/users/raineroviir/gists{/gist_id}","starred_url":"https://api.github.com/users/raineroviir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raineroviir/subscriptions","organizations_url":"https://api.github.com/users/raineroviir/orgs","repos_url":"https://api.github.com/users/raineroviir/repos","events_url":"https://api.github.com/users/raineroviir/events{/privacy}","received_events_url":"https://api.github.com/users/raineroviir/received_events","type":"User","site_admin":false},"body":"It doesn't pass one of the tests, but I'm curious if this is the right direction or not.","created_at":"2016-02-25T19:13:19Z","updated_at":"2016-03-01T05:18:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf702d04e4a31e66a23de562ff1efbd352d14466","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/6121/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/6121/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/6121/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/1b8b939a5009d5fdb7d864068a0416e46ae4e714","head":{"label":"raineroviir:rainer","ref":"rainer","sha":"1b8b939a5009d5fdb7d864068a0416e46ae4e714","user":{"login":"raineroviir","id":10455065,"avatar_url":"https://avatars.githubusercontent.com/u/10455065?v=3","gravatar_id":"","url":"https://api.github.com/users/raineroviir","html_url":"https://github.com/raineroviir","followers_url":"https://api.github.com/users/raineroviir/followers","following_url":"https://api.github.com/users/raineroviir/following{/other_user}","gists_url":"https://api.github.com/users/raineroviir/gists{/gist_id}","starred_url":"https://api.github.com/users/raineroviir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raineroviir/subscriptions","organizations_url":"https://api.github.com/users/raineroviir/orgs","repos_url":"https://api.github.com/users/raineroviir/repos","events_url":"https://api.github.com/users/raineroviir/events{/privacy}","received_events_url":"https://api.github.com/users/raineroviir/received_events","type":"User","site_admin":false},"repo":{"id":52482518,"name":"react","full_name":"raineroviir/react","owner":{"login":"raineroviir","id":10455065,"avatar_url":"https://avatars.githubusercontent.com/u/10455065?v=3","gravatar_id":"","url":"https://api.github.com/users/raineroviir","html_url":"https://github.com/raineroviir","followers_url":"https://api.github.com/users/raineroviir/followers","following_url":"https://api.github.com/users/raineroviir/following{/other_user}","gists_url":"https://api.github.com/users/raineroviir/gists{/gist_id}","starred_url":"https://api.github.com/users/raineroviir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raineroviir/subscriptions","organizations_url":"https://api.github.com/users/raineroviir/orgs","repos_url":"https://api.github.com/users/raineroviir/repos","events_url":"https://api.github.com/users/raineroviir/events{/privacy}","received_events_url":"https://api.github.com/users/raineroviir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raineroviir/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/raineroviir/react","forks_url":"https://api.github.com/repos/raineroviir/react/forks","keys_url":"https://api.github.com/repos/raineroviir/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raineroviir/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raineroviir/react/teams","hooks_url":"https://api.github.com/repos/raineroviir/react/hooks","issue_events_url":"https://api.github.com/repos/raineroviir/react/issues/events{/number}","events_url":"https://api.github.com/repos/raineroviir/react/events","assignees_url":"https://api.github.com/repos/raineroviir/react/assignees{/user}","branches_url":"https://api.github.com/repos/raineroviir/react/branches{/branch}","tags_url":"https://api.github.com/repos/raineroviir/react/tags","blobs_url":"https://api.github.com/repos/raineroviir/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raineroviir/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raineroviir/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/raineroviir/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raineroviir/react/statuses/{sha}","languages_url":"https://api.github.com/repos/raineroviir/react/languages","stargazers_url":"https://api.github.com/repos/raineroviir/react/stargazers","contributors_url":"https://api.github.com/repos/raineroviir/react/contributors","subscribers_url":"https://api.github.com/repos/raineroviir/react/subscribers","subscription_url":"https://api.github.com/repos/raineroviir/react/subscription","commits_url":"https://api.github.com/repos/raineroviir/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/raineroviir/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/raineroviir/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/raineroviir/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/raineroviir/react/contents/{+path}","compare_url":"https://api.github.com/repos/raineroviir/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raineroviir/react/merges","archive_url":"https://api.github.com/repos/raineroviir/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raineroviir/react/downloads","issues_url":"https://api.github.com/repos/raineroviir/react/issues{/number}","pulls_url":"https://api.github.com/repos/raineroviir/react/pulls{/number}","milestones_url":"https://api.github.com/repos/raineroviir/react/milestones{/number}","notifications_url":"https://api.github.com/repos/raineroviir/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raineroviir/react/labels{/name}","releases_url":"https://api.github.com/repos/raineroviir/react/releases{/id}","deployments_url":"https://api.github.com/repos/raineroviir/react/deployments","created_at":"2016-02-24T23:38:37Z","updated_at":"2016-02-24T23:38:40Z","pushed_at":"2016-03-01T05:05:29Z","git_url":"git://github.com/raineroviir/react.git","ssh_url":"git@github.com:raineroviir/react.git","clone_url":"https://github.com/raineroviir/react.git","svn_url":"https://github.com/raineroviir/react","homepage":"https://facebook.github.io/react/","size":80198,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"5696ccfcd72189f4fea13d8b0f084a0e3c9b8147","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-03-01T05:01:56Z","pushed_at":"2016-03-01T05:05:30Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":96882,"stargazers_count":37232,"watchers_count":37232,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6114,"mirror_url":null,"open_issues_count":544,"forks":6114,"open_issues":544,"watchers":37232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/6121"},"html":{"href":"https://github.com/facebook/react/pull/6121"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/6121"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/6121/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/6121/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/6121/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/1b8b939a5009d5fdb7d864068a0416e46ae4e714"}}}}