{"action":"closed","number":1081,"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-select/pulls/1081","id":39752401,"html_url":"https://github.com/angular-ui/ui-select/pull/1081","diff_url":"https://github.com/angular-ui/ui-select/pull/1081.diff","patch_url":"https://github.com/angular-ui/ui-select/pull/1081.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-select/issues/1081","number":1081,"state":"closed","locked":false,"title":"Fix tagging with group-by (and unit-tests)","user":{"login":"lukaw3d","id":3758846,"avatar_url":"https://avatars.githubusercontent.com/u/3758846?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaw3d","html_url":"https://github.com/lukaw3d","followers_url":"https://api.github.com/users/lukaw3d/followers","following_url":"https://api.github.com/users/lukaw3d/following{/other_user}","gists_url":"https://api.github.com/users/lukaw3d/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaw3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaw3d/subscriptions","organizations_url":"https://api.github.com/users/lukaw3d/orgs","repos_url":"https://api.github.com/users/lukaw3d/repos","events_url":"https://api.github.com/users/lukaw3d/events{/privacy}","received_events_url":"https://api.github.com/users/lukaw3d/received_events","type":"User","site_admin":false},"body":"This pull-request includes:\r\n* Fixed tagging to work with group-by (and added a unit test) (fixes https://github.com/angular-ui/ui-select/issues/577)\r\n* Fixed a unit test `should allow decline tags when tagging function returns null` to catch an error and fixed that error (`Cannot set property 'isTag' of null`)\r\n* Removed needlessly calling the tagging function (and added a unit test)\r\n* Fixed a console error in [demo-tagging example](http://rawgit.com/angular-ui/ui-select/master/examples/demo-tagging.html). When entering `a` into Object Tags input, highlight filter replaced `<small>` with `<sm<span class=\"ui-select-highlight\">a</span>ll>`","created_at":"2015-07-11T21:15:23Z","updated_at":"2016-03-29T11:57:09Z","closed_at":"2016-03-29T11:57:09Z","merged_at":"2016-03-29T11:57:08Z","merge_commit_sha":"0d47821d484e24fb08ddbe99471fa2769278c722","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/ui-select/pulls/1081/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-select/pulls/1081/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-select/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-select/issues/1081/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-select/statuses/7963684e1ceb8824062e075f6cdd6314aebb1ccf","head":{"label":"lukaw3d:fix-tagging","ref":"fix-tagging","sha":"7963684e1ceb8824062e075f6cdd6314aebb1ccf","user":{"login":"lukaw3d","id":3758846,"avatar_url":"https://avatars.githubusercontent.com/u/3758846?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaw3d","html_url":"https://github.com/lukaw3d","followers_url":"https://api.github.com/users/lukaw3d/followers","following_url":"https://api.github.com/users/lukaw3d/following{/other_user}","gists_url":"https://api.github.com/users/lukaw3d/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaw3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaw3d/subscriptions","organizations_url":"https://api.github.com/users/lukaw3d/orgs","repos_url":"https://api.github.com/users/lukaw3d/repos","events_url":"https://api.github.com/users/lukaw3d/events{/privacy}","received_events_url":"https://api.github.com/users/lukaw3d/received_events","type":"User","site_admin":false},"repo":{"id":38939179,"name":"ui-select","full_name":"lukaw3d/ui-select","owner":{"login":"lukaw3d","id":3758846,"avatar_url":"https://avatars.githubusercontent.com/u/3758846?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaw3d","html_url":"https://github.com/lukaw3d","followers_url":"https://api.github.com/users/lukaw3d/followers","following_url":"https://api.github.com/users/lukaw3d/following{/other_user}","gists_url":"https://api.github.com/users/lukaw3d/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaw3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaw3d/subscriptions","organizations_url":"https://api.github.com/users/lukaw3d/orgs","repos_url":"https://api.github.com/users/lukaw3d/repos","events_url":"https://api.github.com/users/lukaw3d/events{/privacy}","received_events_url":"https://api.github.com/users/lukaw3d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukaw3d/ui-select","description":"AngularJS-native version of Select2 and Selectize","fork":true,"url":"https://api.github.com/repos/lukaw3d/ui-select","forks_url":"https://api.github.com/repos/lukaw3d/ui-select/forks","keys_url":"https://api.github.com/repos/lukaw3d/ui-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukaw3d/ui-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukaw3d/ui-select/teams","hooks_url":"https://api.github.com/repos/lukaw3d/ui-select/hooks","issue_events_url":"https://api.github.com/repos/lukaw3d/ui-select/issues/events{/number}","events_url":"https://api.github.com/repos/lukaw3d/ui-select/events","assignees_url":"https://api.github.com/repos/lukaw3d/ui-select/assignees{/user}","branches_url":"https://api.github.com/repos/lukaw3d/ui-select/branches{/branch}","tags_url":"https://api.github.com/repos/lukaw3d/ui-select/tags","blobs_url":"https://api.github.com/repos/lukaw3d/ui-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukaw3d/ui-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukaw3d/ui-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukaw3d/ui-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukaw3d/ui-select/statuses/{sha}","languages_url":"https://api.github.com/repos/lukaw3d/ui-select/languages","stargazers_url":"https://api.github.com/repos/lukaw3d/ui-select/stargazers","contributors_url":"https://api.github.com/repos/lukaw3d/ui-select/contributors","subscribers_url":"https://api.github.com/repos/lukaw3d/ui-select/subscribers","subscription_url":"https://api.github.com/repos/lukaw3d/ui-select/subscription","commits_url":"https://api.github.com/repos/lukaw3d/ui-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukaw3d/ui-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukaw3d/ui-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukaw3d/ui-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukaw3d/ui-select/contents/{+path}","compare_url":"https://api.github.com/repos/lukaw3d/ui-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukaw3d/ui-select/merges","archive_url":"https://api.github.com/repos/lukaw3d/ui-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukaw3d/ui-select/downloads","issues_url":"https://api.github.com/repos/lukaw3d/ui-select/issues{/number}","pulls_url":"https://api.github.com/repos/lukaw3d/ui-select/pulls{/number}","milestones_url":"https://api.github.com/repos/lukaw3d/ui-select/milestones{/number}","notifications_url":"https://api.github.com/repos/lukaw3d/ui-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukaw3d/ui-select/labels{/name}","releases_url":"https://api.github.com/repos/lukaw3d/ui-select/releases{/id}","deployments_url":"https://api.github.com/repos/lukaw3d/ui-select/deployments","created_at":"2015-07-11T20:18:34Z","updated_at":"2015-07-11T20:18:35Z","pushed_at":"2016-03-29T09:24:59Z","git_url":"git://github.com/lukaw3d/ui-select.git","ssh_url":"git@github.com:lukaw3d/ui-select.git","clone_url":"https://github.com/lukaw3d/ui-select.git","svn_url":"https://github.com/lukaw3d/ui-select","homepage":"","size":1562,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"ce6a554cba12a53994f810772a36227ae784e42e","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":12962729,"name":"ui-select","full_name":"angular-ui/ui-select","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-select","description":"AngularJS-native version of Select2 and Selectize","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-select","forks_url":"https://api.github.com/repos/angular-ui/ui-select/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-select/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-select/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-select/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-select/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-select/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-select/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-select/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-select/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-select/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-select/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-select/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-select/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-select/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-select/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-select/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-select/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-select/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-select/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-select/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-select/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-select/releases{/id}","deployments_url":"https://api.github.com/repos/angular-ui/ui-select/deployments","created_at":"2013-09-20T00:38:35Z","updated_at":"2016-03-28T16:14:36Z","pushed_at":"2016-03-29T11:57:09Z","git_url":"git://github.com/angular-ui/ui-select.git","ssh_url":"git@github.com:angular-ui/ui-select.git","clone_url":"https://github.com/angular-ui/ui-select.git","svn_url":"https://github.com/angular-ui/ui-select","homepage":"","size":4486,"stargazers_count":2316,"watchers_count":2316,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1276,"mirror_url":null,"open_issues_count":437,"forks":1276,"open_issues":437,"watchers":2316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-select/pulls/1081"},"html":{"href":"https://github.com/angular-ui/ui-select/pull/1081"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-select/issues/1081"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-select/issues/1081/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-select/pulls/1081/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-select/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-select/pulls/1081/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-select/statuses/7963684e1ceb8824062e075f6cdd6314aebb1ccf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"user378230","id":16818823,"avatar_url":"https://avatars.githubusercontent.com/u/16818823?v=3","gravatar_id":"","url":"https://api.github.com/users/user378230","html_url":"https://github.com/user378230","followers_url":"https://api.github.com/users/user378230/followers","following_url":"https://api.github.com/users/user378230/following{/other_user}","gists_url":"https://api.github.com/users/user378230/gists{/gist_id}","starred_url":"https://api.github.com/users/user378230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/user378230/subscriptions","organizations_url":"https://api.github.com/users/user378230/orgs","repos_url":"https://api.github.com/users/user378230/repos","events_url":"https://api.github.com/users/user378230/events{/privacy}","received_events_url":"https://api.github.com/users/user378230/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":4,"additions":92,"deletions":10,"changed_files":3}}