{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/557","repository_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/557/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/557/comments","events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/557/events","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/557","id":181573528,"number":557,"title":"Task/jenkins 37667 Adopt Bismuth API to build pipeline node DAG","user":{"login":"vivek","id":38139,"avatar_url":"https://avatars.githubusercontent.com/u/38139?v=3","gravatar_id":"","url":"https://api.github.com/users/vivek","html_url":"https://github.com/vivek","followers_url":"https://api.github.com/users/vivek/followers","following_url":"https://api.github.com/users/vivek/following{/other_user}","gists_url":"https://api.github.com/users/vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivek/subscriptions","organizations_url":"https://api.github.com/users/vivek/orgs","repos_url":"https://api.github.com/users/vivek/repos","events_url":"https://api.github.com/users/vivek/events{/privacy}","received_events_url":"https://api.github.com/users/vivek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels/needs-review","name":"needs-review","color":"eb6420"},{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels/work-in-progress","name":"work-in-progress","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-10-07T02:39:24Z","updated_at":"2016-10-19T00:36:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/557","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/557","diff_url":"https://github.com/jenkinsci/blueocean-plugin/pull/557.diff","patch_url":"https://github.com/jenkinsci/blueocean-plugin/pull/557.patch"},"body":"# Description\r\n\r\nSee https://issues.jenkins-ci.org/browse/JENKINS-37667\r\n\r\nTo test manually try different pipeline jobs and see if there is any regressions. \r\n\r\n# Submitter checklist\r\n- [x] Link to JIRA ticket in description, if appropriate.\r\n- [x] Change is code complete and matches issue description\r\n- [x] Appropriate unit or acceptance tests or explanation to why this change has no tests\r\n- [x] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.\r\n- [x] Ran Acceptance Test Harness against PR changes.\r\n\r\nTried running ATH locally but get this error: \r\n\r\n`2016-10-07 07:52:37,057 [Thread-4] ERROR  (InputStreamHandler.java:60) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - Error retrieving a new session from the selenium server\r\n2016-10-07 07:52:37,058 [Thread-4] ERROR  (InputStreamHandler.java:60) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - \r\n2016-10-07 07:52:37,058 [Thread-4] ERROR  (InputStreamHandler.java:60) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - Connection refused! Is selenium server started?\r\n2016-10-07 07:52:37,058 [Thread-4] ERROR  (InputStreamHandler.java:60) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - { Error: connect ECONNREFUSED 192.168.1.104:4444\r\n`\r\n# Reviewer checklist\r\n- [ ] Run the changes and verified the change matches the issue description\r\n- [ ] Reviewed the code\r\n- [ ] Verified that the appropriate tests have been written or valid explanation given\r\n\r\n@jenkinsci/code-reviewers @reviewbybees \r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/comments/254678719","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/557#issuecomment-254678719","issue_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/557","id":254678719,"user":{"login":"vivek","id":38139,"avatar_url":"https://avatars.githubusercontent.com/u/38139?v=3","gravatar_id":"","url":"https://api.github.com/users/vivek","html_url":"https://github.com/vivek","followers_url":"https://api.github.com/users/vivek/followers","following_url":"https://api.github.com/users/vivek/following{/other_user}","gists_url":"https://api.github.com/users/vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivek/subscriptions","organizations_url":"https://api.github.com/users/vivek/orgs","repos_url":"https://api.github.com/users/vivek/repos","events_url":"https://api.github.com/users/vivek/events{/privacy}","received_events_url":"https://api.github.com/users/vivek/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T00:36:51Z","updated_at":"2016-10-19T00:36:51Z","body":"@svanoort @michaelneale I think its functionally complete, has more features in terms of parity with existing implementation. these functionalities have been implemented:\r\n\r\n- branches are returned sorted by name\r\n- nested stages within stage is ignored in DAG\r\n- Added tests to test above\r\n\r\nWho knows there might be edge cases, since its better than parity with existing implementation, probably we can merge if all looks good and if there are edge cases identified we open separate ticket for those?"}}
{"actor":{"display_login":"vivek"}}