{"action":"created","issue":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/59","repository_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/59/comments","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/59/events","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/59","id":161945742,"number":59,"title":"Always fetch all courses","user":{"login":"ryantmer","id":6231623,"avatar_url":"https://avatars.githubusercontent.com/u/6231623?v=3","gravatar_id":"","url":"https://api.github.com/users/ryantmer","html_url":"https://github.com/ryantmer","followers_url":"https://api.github.com/users/ryantmer/followers","following_url":"https://api.github.com/users/ryantmer/following{/other_user}","gists_url":"https://api.github.com/users/ryantmer/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantmer/subscriptions","organizations_url":"https://api.github.com/users/ryantmer/orgs","repos_url":"https://api.github.com/users/ryantmer/repos","events_url":"https://api.github.com/users/ryantmer/events{/privacy}","received_events_url":"https://api.github.com/users/ryantmer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels/code%20review","name":"code review","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"apalaniuk","id":17710124,"avatar_url":"https://avatars.githubusercontent.com/u/17710124?v=3","gravatar_id":"","url":"https://api.github.com/users/apalaniuk","html_url":"https://github.com/apalaniuk","followers_url":"https://api.github.com/users/apalaniuk/followers","following_url":"https://api.github.com/users/apalaniuk/following{/other_user}","gists_url":"https://api.github.com/users/apalaniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/apalaniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apalaniuk/subscriptions","organizations_url":"https://api.github.com/users/apalaniuk/orgs","repos_url":"https://api.github.com/users/apalaniuk/repos","events_url":"https://api.github.com/users/apalaniuk/events{/privacy}","received_events_url":"https://api.github.com/users/apalaniuk/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-06-23T15:03:28Z","updated_at":"2016-06-23T19:38:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/59","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/59","diff_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/59.diff","patch_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/59.patch"},"body":"There are a few possibilities for the enrollments we can get back from an enrollments call:\r\n\r\n1. The user has a small number of enrollments (pinned + unpinned)\r\n2. The user has a lot of enrollments, many of them pinned\r\n3. The user has a lot of enrollments, and a few pinned ones\r\n\r\nIn case 1, fetching all enrollments right away just makes sense - the reply isn't huge, and we avoid one network call overhead.\r\n\r\nFor 2 and 3, we can't actually sort by pin state on Valence, which means even though we're asking for pinned only from the UIS, there's no guarantee that the first set of enrollments coming back from Valence has all the pinned ones anyway. So, might as well just get them all. This will obviously change once we're on the new APIs."},"comment":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments/228160803","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/59#issuecomment-228160803","issue_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/59","id":228160803,"user":{"login":"ryantmer","id":6231623,"avatar_url":"https://avatars.githubusercontent.com/u/6231623?v=3","gravatar_id":"","url":"https://api.github.com/users/ryantmer","html_url":"https://github.com/ryantmer","followers_url":"https://api.github.com/users/ryantmer/followers","following_url":"https://api.github.com/users/ryantmer/following{/other_user}","gists_url":"https://api.github.com/users/ryantmer/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantmer/subscriptions","organizations_url":"https://api.github.com/users/ryantmer/orgs","repos_url":"https://api.github.com/users/ryantmer/repos","events_url":"https://api.github.com/users/ryantmer/events{/privacy}","received_events_url":"https://api.github.com/users/ryantmer/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T19:38:57Z","updated_at":"2016-06-23T19:38:57Z","body":"Ah, and `enrollmentsUrl` too, good call."}}
{"actor":{"display_login":"ryantmer"}}