{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/70505005","id":70505005,"diff_hunk":"@@ -170,35 +172,27 @@ public void start(StartContext context) throws StartException {\n             initializer.setRootResourceDefinitionDelegate();\n         }\n         super.start(context);\n+        //todo super hack\n+        if (type == TestModelType.STANDALONE){\n+            ServerEnvironmentService.addService(((ServerInitializer)initializer).environment, context.getChildTarget());\n+        }\n+\n     }\n \n     @Override\n     protected void initCoreModel(ManagementModel managementModel, Resource modelControllerResource) {\n-        super.initCoreModel(managementModel, modelControllerResource);\n+        //super.initCoreModel(managementModel, modelControllerResource);\n         if (modelInitializer != null) {\n             modelInitializer.populateModel(managementModel);\n         }\n-    }\n-\n-    @Override\n-    protected void initCoreModel(Resource rootResource, ManagementResourceRegistration rootRegistration, Resource modelControllerResource) {\n-        //See server HttpManagementAddHandler\n-        System.setProperty(\"jboss.as.test.disable.runtime\", \"1\");\n-        if (type == TestModelType.STANDALONE) {\n-            initializer.initCoreModel(rootResource, rootRegistration, modelControllerResource);\n-\n-        } else if (type == TestModelType.HOST){\n-            initializer.initCoreModel(rootResource, rootRegistration, modelControllerResource);\n-\n-        } else if (type == TestModelType.DOMAIN){\n-            initializer.initCoreModel(rootResource, rootRegistration, modelControllerResource);\n-        }\n+        System.setProperty(\"wildfly.test.boot.disable.rollback\", \"1\");","path":"core-model-test/framework/src/main/java/org/jboss/as/core/model/test/TestModelControllerService.java","position":89,"original_position":89,"commit_id":"f1aa47fbe8dbf755dee3dacb9dbb9e5f5d03c624","original_commit_id":"f1aa47fbe8dbf755dee3dacb9dbb9e5f5d03c624","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=3","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"This got out of sync when I reverted the WFCORE-307 fix. The property is \"jboss.as.test.disable.runtime\".","created_at":"2016-07-12T19:25:34Z","updated_at":"2016-07-12T19:25:34Z","html_url":"https://github.com/wildfly/wildfly-core/pull/1656#discussion_r70505005","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/70505005"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1656#discussion_r70505005"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656","id":76297629,"html_url":"https://github.com/wildfly/wildfly-core/pull/1656","diff_url":"https://github.com/wildfly/wildfly-core/pull/1656.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/1656.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1656","number":1656,"state":"open","locked":false,"title":"Add legacy controllers 2.0.0.CR1 - support for EAP7 target","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"body":"- improve maven downloader, now pareses settings.xml and uses that for configuration\r\n- remove all deprecated versions from ModelTestControllerVersion\r\n- ModelTestControllerVersion now also has core version available and its maven coordinates\r\n- some cleanup of old and no longer used methods / constructors in legacy controllers\r\n- add core model testing against eap7\r\n- add core transformers to pass against EAP7\r\n","created_at":"2016-07-05T15:49:51Z","updated_at":"2016-07-12T19:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f64a00aa2c63124cd1ba92fa9b3e4fe738b7af33","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1656/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/f1aa47fbe8dbf755dee3dacb9dbb9e5f5d03c624","head":{"label":"ctomc:legacy-testing","ref":"legacy-testing","sha":"f1aa47fbe8dbf755dee3dacb9dbb9e5f5d03c624","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"repo":{"id":21428688,"name":"wildfly-core","full_name":"ctomc/wildfly-core","owner":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctomc/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/ctomc/wildfly-core","forks_url":"https://api.github.com/repos/ctomc/wildfly-core/forks","keys_url":"https://api.github.com/repos/ctomc/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctomc/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctomc/wildfly-core/teams","hooks_url":"https://api.github.com/repos/ctomc/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/ctomc/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/ctomc/wildfly-core/events","assignees_url":"https://api.github.com/repos/ctomc/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/ctomc/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/ctomc/wildfly-core/tags","blobs_url":"https://api.github.com/repos/ctomc/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctomc/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctomc/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctomc/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctomc/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ctomc/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/ctomc/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/ctomc/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/ctomc/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/ctomc/wildfly-core/subscription","commits_url":"https://api.github.com/repos/ctomc/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctomc/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctomc/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctomc/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctomc/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/ctomc/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctomc/wildfly-core/merges","archive_url":"https://api.github.com/repos/ctomc/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctomc/wildfly-core/downloads","issues_url":"https://api.github.com/repos/ctomc/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/ctomc/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ctomc/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ctomc/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctomc/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/ctomc/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/ctomc/wildfly-core/deployments","created_at":"2014-07-02T15:06:51Z","updated_at":"2016-04-14T17:10:25Z","pushed_at":"2016-07-12T15:50:59Z","git_url":"git://github.com/ctomc/wildfly-core.git","ssh_url":"git@github.com:ctomc/wildfly-core.git","clone_url":"https://github.com/ctomc/wildfly-core.git","svn_url":"https://github.com/ctomc/wildfly-core","homepage":null,"size":49643,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"da7bc284c116a6a038c59fbe1e3bd70069d22f29","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2016-07-10T23:30:24Z","pushed_at":"2016-07-12T15:50:59Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":57487,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":207,"mirror_url":null,"open_issues_count":29,"forks":207,"open_issues":29,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1656"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1656"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1656/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1656/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/f1aa47fbe8dbf755dee3dacb9dbb9e5f5d03c624"}}}}
{"actor":{"display_login":"bstansberry"}}