{"action":"created","comment":{"url":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/comments/88569853","pull_request_review_id":9141069,"id":88569853,"diff_hunk":"@@ -186,6 +193,18 @@ def _rstrip_backslash(l):\n             return l\n \n         instructions = []\n+        # Handle inherited parent envs\n+        for key, val in self.parent_env.items():\n+            instructions.append(","path":"dockerfile_parse/parser.py","position":33,"original_position":33,"commit_id":"0ba962df0c30eddd6c3198da23e6f0729d338166","original_commit_id":"0ba962df0c30eddd6c3198da23e6f0729d338166","user":{"login":"twaugh","id":6985468,"avatar_url":"https://avatars.githubusercontent.com/u/6985468?v=3","gravatar_id":"","url":"https://api.github.com/users/twaugh","html_url":"https://github.com/twaugh","followers_url":"https://api.github.com/users/twaugh/followers","following_url":"https://api.github.com/users/twaugh/following{/other_user}","gists_url":"https://api.github.com/users/twaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/twaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twaugh/subscriptions","organizations_url":"https://api.github.com/users/twaugh/orgs","repos_url":"https://api.github.com/users/twaugh/repos","events_url":"https://api.github.com/users/twaugh/events{/privacy}","received_events_url":"https://api.github.com/users/twaugh/received_events","type":"User","site_admin":false},"body":"I don't think this is right. The ENV instruction does not appear in the Dockerfile we are parsing. The point of the `structure` attribute is to be able to understand the syntax of the Dockerfile.\r\n\r\nThe only reason we care about inherited environment variables at all is to be able to know correct values for instructions.","created_at":"2016-11-17T23:20:42Z","updated_at":"2016-11-17T23:20:42Z","html_url":"https://github.com/DBuildService/dockerfile-parse/pull/21#discussion_r88569853","pull_request_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/comments/88569853"},"html":{"href":"https://github.com/DBuildService/dockerfile-parse/pull/21#discussion_r88569853"},"pull_request":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21","id":94062304,"html_url":"https://github.com/DBuildService/dockerfile-parse/pull/21","diff_url":"https://github.com/DBuildService/dockerfile-parse/pull/21.diff","patch_url":"https://github.com/DBuildService/dockerfile-parse/pull/21.patch","issue_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/issues/21","number":21,"state":"open","locked":false,"title":"add parent_env handling","user":{"login":"maxamillion","id":839000,"avatar_url":"https://avatars.githubusercontent.com/u/839000?v=3","gravatar_id":"","url":"https://api.github.com/users/maxamillion","html_url":"https://github.com/maxamillion","followers_url":"https://api.github.com/users/maxamillion/followers","following_url":"https://api.github.com/users/maxamillion/following{/other_user}","gists_url":"https://api.github.com/users/maxamillion/gists{/gist_id}","starred_url":"https://api.github.com/users/maxamillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxamillion/subscriptions","organizations_url":"https://api.github.com/users/maxamillion/orgs","repos_url":"https://api.github.com/users/maxamillion/repos","events_url":"https://api.github.com/users/maxamillion/events{/privacy}","received_events_url":"https://api.github.com/users/maxamillion/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>","created_at":"2016-11-16T22:17:48Z","updated_at":"2016-11-17T23:22:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e6b335e9714e0446728619f657cb6b84d6e71d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21/commits","review_comments_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21/comments","review_comment_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/issues/21/comments","statuses_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/statuses/0ba962df0c30eddd6c3198da23e6f0729d338166","head":{"label":"maxamillion:parent_env","ref":"parent_env","sha":"0ba962df0c30eddd6c3198da23e6f0729d338166","user":{"login":"maxamillion","id":839000,"avatar_url":"https://avatars.githubusercontent.com/u/839000?v=3","gravatar_id":"","url":"https://api.github.com/users/maxamillion","html_url":"https://github.com/maxamillion","followers_url":"https://api.github.com/users/maxamillion/followers","following_url":"https://api.github.com/users/maxamillion/following{/other_user}","gists_url":"https://api.github.com/users/maxamillion/gists{/gist_id}","starred_url":"https://api.github.com/users/maxamillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxamillion/subscriptions","organizations_url":"https://api.github.com/users/maxamillion/orgs","repos_url":"https://api.github.com/users/maxamillion/repos","events_url":"https://api.github.com/users/maxamillion/events{/privacy}","received_events_url":"https://api.github.com/users/maxamillion/received_events","type":"User","site_admin":false},"repo":{"id":73750994,"name":"dockerfile-parse","full_name":"maxamillion/dockerfile-parse","owner":{"login":"maxamillion","id":839000,"avatar_url":"https://avatars.githubusercontent.com/u/839000?v=3","gravatar_id":"","url":"https://api.github.com/users/maxamillion","html_url":"https://github.com/maxamillion","followers_url":"https://api.github.com/users/maxamillion/followers","following_url":"https://api.github.com/users/maxamillion/following{/other_user}","gists_url":"https://api.github.com/users/maxamillion/gists{/gist_id}","starred_url":"https://api.github.com/users/maxamillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxamillion/subscriptions","organizations_url":"https://api.github.com/users/maxamillion/orgs","repos_url":"https://api.github.com/users/maxamillion/repos","events_url":"https://api.github.com/users/maxamillion/events{/privacy}","received_events_url":"https://api.github.com/users/maxamillion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxamillion/dockerfile-parse","description":"Python library for parsing Dockerfile files.","fork":true,"url":"https://api.github.com/repos/maxamillion/dockerfile-parse","forks_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/forks","keys_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/teams","hooks_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/hooks","issue_events_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/issues/events{/number}","events_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/events","assignees_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/assignees{/user}","branches_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/branches{/branch}","tags_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/tags","blobs_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/statuses/{sha}","languages_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/languages","stargazers_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/stargazers","contributors_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/contributors","subscribers_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/subscribers","subscription_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/subscription","commits_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/contents/{+path}","compare_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/merges","archive_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/downloads","issues_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/issues{/number}","pulls_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/pulls{/number}","milestones_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/milestones{/number}","notifications_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/labels{/name}","releases_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/releases{/id}","deployments_url":"https://api.github.com/repos/maxamillion/dockerfile-parse/deployments","created_at":"2016-11-14T22:03:45Z","updated_at":"2016-11-14T22:03:47Z","pushed_at":"2016-11-17T23:00:12Z","git_url":"git://github.com/maxamillion/dockerfile-parse.git","ssh_url":"git@github.com:maxamillion/dockerfile-parse.git","clone_url":"https://github.com/maxamillion/dockerfile-parse.git","svn_url":"https://github.com/maxamillion/dockerfile-parse","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DBuildService:master","ref":"master","sha":"1ebe85309be1e0713cebf66e71a68c5dbe40d235","user":{"login":"DBuildService","id":9337743,"avatar_url":"https://avatars.githubusercontent.com/u/9337743?v=3","gravatar_id":"","url":"https://api.github.com/users/DBuildService","html_url":"https://github.com/DBuildService","followers_url":"https://api.github.com/users/DBuildService/followers","following_url":"https://api.github.com/users/DBuildService/following{/other_user}","gists_url":"https://api.github.com/users/DBuildService/gists{/gist_id}","starred_url":"https://api.github.com/users/DBuildService/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBuildService/subscriptions","organizations_url":"https://api.github.com/users/DBuildService/orgs","repos_url":"https://api.github.com/users/DBuildService/repos","events_url":"https://api.github.com/users/DBuildService/events{/privacy}","received_events_url":"https://api.github.com/users/DBuildService/received_events","type":"Organization","site_admin":false},"repo":{"id":37669690,"name":"dockerfile-parse","full_name":"DBuildService/dockerfile-parse","owner":{"login":"DBuildService","id":9337743,"avatar_url":"https://avatars.githubusercontent.com/u/9337743?v=3","gravatar_id":"","url":"https://api.github.com/users/DBuildService","html_url":"https://github.com/DBuildService","followers_url":"https://api.github.com/users/DBuildService/followers","following_url":"https://api.github.com/users/DBuildService/following{/other_user}","gists_url":"https://api.github.com/users/DBuildService/gists{/gist_id}","starred_url":"https://api.github.com/users/DBuildService/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBuildService/subscriptions","organizations_url":"https://api.github.com/users/DBuildService/orgs","repos_url":"https://api.github.com/users/DBuildService/repos","events_url":"https://api.github.com/users/DBuildService/events{/privacy}","received_events_url":"https://api.github.com/users/DBuildService/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DBuildService/dockerfile-parse","description":"Python library for parsing Dockerfile files.","fork":false,"url":"https://api.github.com/repos/DBuildService/dockerfile-parse","forks_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/forks","keys_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/teams","hooks_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/hooks","issue_events_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/issues/events{/number}","events_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/events","assignees_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/assignees{/user}","branches_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/branches{/branch}","tags_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/tags","blobs_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/git/refs{/sha}","trees_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/statuses/{sha}","languages_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/languages","stargazers_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/stargazers","contributors_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/contributors","subscribers_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/subscribers","subscription_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/subscription","commits_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/commits{/sha}","git_commits_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/git/commits{/sha}","comments_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/comments{/number}","issue_comment_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/issues/comments{/number}","contents_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/contents/{+path}","compare_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/merges","archive_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/downloads","issues_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/issues{/number}","pulls_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls{/number}","milestones_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/milestones{/number}","notifications_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/labels{/name}","releases_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/releases{/id}","deployments_url":"https://api.github.com/repos/DBuildService/dockerfile-parse/deployments","created_at":"2015-06-18T15:59:46Z","updated_at":"2016-11-15T06:01:11Z","pushed_at":"2016-11-17T23:00:13Z","git_url":"git://github.com/DBuildService/dockerfile-parse.git","ssh_url":"git@github.com:DBuildService/dockerfile-parse.git","clone_url":"https://github.com/DBuildService/dockerfile-parse.git","svn_url":"https://github.com/DBuildService/dockerfile-parse","homepage":null,"size":51,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21"},"html":{"href":"https://github.com/DBuildService/dockerfile-parse/pull/21"},"issue":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/issues/21"},"comments":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/DBuildService/dockerfile-parse/statuses/0ba962df0c30eddd6c3198da23e6f0729d338166"}}}}
{"actor":{"display_login":"twaugh"}}