{"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/77216092","id":77216092,"diff_hunk":"@@ -1362,9 +1362,22 @@ OO.plugin(\"Html5Skin\", function (OO, _, $, W) {\n \n     showVolumeSliderBar: function() {\n       this.state.volumeState.volumeSliderVisible = true;\n+      if (Utils.isAndroid()) {\n+        this.startHideVolumeSliderTimer();\n+      }\n       this.renderSkin();\n     },\n \n+    startHideVolumeSliderTimer: function() {\n+        this.cancelTimer();\n+        var timer = setTimeout(function() {","path":"js/controller.js","position":12,"original_position":12,"commit_id":"c4bba5e0ac0de8f1f8891c7d6f47e4cf2f3899e6","original_commit_id":"c4bba5e0ac0de8f1f8891c7d6f47e4cf2f3899e6","user":{"login":"brianfwong","id":3573261,"avatar_url":"https://avatars.githubusercontent.com/u/3573261?v=3","gravatar_id":"","url":"https://api.github.com/users/brianfwong","html_url":"https://github.com/brianfwong","followers_url":"https://api.github.com/users/brianfwong/followers","following_url":"https://api.github.com/users/brianfwong/following{/other_user}","gists_url":"https://api.github.com/users/brianfwong/gists{/gist_id}","starred_url":"https://api.github.com/users/brianfwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianfwong/subscriptions","organizations_url":"https://api.github.com/users/brianfwong/orgs","repos_url":"https://api.github.com/users/brianfwong/repos","events_url":"https://api.github.com/users/brianfwong/events{/privacy}","received_events_url":"https://api.github.com/users/brianfwong/received_events","type":"User","site_admin":false},"body":"@pilievOoyala The timer here will be cancelled anytime the user hits the volume button, which triggers show, cancels 'this' timer, and then starts the hide timer.\r\n- Is that the timeout you are referring to?","created_at":"2016-09-01T17:19:37Z","updated_at":"2016-09-01T17:19:37Z","html_url":"https://github.com/ooyala/html5-skin/pull/648#discussion_r77216092","pull_request_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/648","_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/77216092"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/648#discussion_r77216092"},"pull_request":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/648"}}},"pull_request":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/648","id":83496342,"html_url":"https://github.com/ooyala/html5-skin/pull/648","diff_url":"https://github.com/ooyala/html5-skin/pull/648.diff","patch_url":"https://github.com/ooyala/html5-skin/pull/648.patch","issue_url":"https://api.github.com/repos/ooyala/html5-skin/issues/648","number":648,"state":"open","locked":false,"title":"[PBW-5804] Fix for making volume level disappear after some seconds i…","user":{"login":"nagavenivn","id":16229782,"avatar_url":"https://avatars.githubusercontent.com/u/16229782?v=3","gravatar_id":"","url":"https://api.github.com/users/nagavenivn","html_url":"https://github.com/nagavenivn","followers_url":"https://api.github.com/users/nagavenivn/followers","following_url":"https://api.github.com/users/nagavenivn/following{/other_user}","gists_url":"https://api.github.com/users/nagavenivn/gists{/gist_id}","starred_url":"https://api.github.com/users/nagavenivn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagavenivn/subscriptions","organizations_url":"https://api.github.com/users/nagavenivn/orgs","repos_url":"https://api.github.com/users/nagavenivn/repos","events_url":"https://api.github.com/users/nagavenivn/events{/privacy}","received_events_url":"https://api.github.com/users/nagavenivn/received_events","type":"User","site_admin":false},"body":"…n Android","created_at":"2016-08-31T17:35:59Z","updated_at":"2016-09-01T17:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2d24b7e39752c799fd38dc985f98c2bcbce3b0c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/648/commits","review_comments_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/648/comments","review_comment_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/issues/648/comments","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/c4bba5e0ac0de8f1f8891c7d6f47e4cf2f3899e6","head":{"label":"ooyala:PBW-5804","ref":"PBW-5804","sha":"c4bba5e0ac0de8f1f8891c7d6f47e4cf2f3899e6","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":"","fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2016-08-29T16:57:45Z","pushed_at":"2016-08-31T17:35:59Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":3720,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":4,"forks":18,"open_issues":4,"watchers":13,"default_branch":"stable"}},"base":{"label":"ooyala:master","ref":"master","sha":"6c391b915e6a397cdc19dfd0cbe18adf42824f39","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":"","fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2016-08-29T16:57:45Z","pushed_at":"2016-08-31T17:35:59Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":3720,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":4,"forks":18,"open_issues":4,"watchers":13,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/648"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/648"},"issue":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/648"},"comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/648/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/648/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/648/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/html5-skin/statuses/c4bba5e0ac0de8f1f8891c7d6f47e4cf2f3899e6"}}}}
{"actor":{"display_login":"brianfwong"}}