{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/10317","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/10317/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10317/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/10317/events","html_url":"https://github.com/nodejs/node/pull/10317","id":196221881,"number":10317,"title":"url: make WHATWG URL implementation more spec compliant","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21","default":false},{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"bfdadc","default":false},{"id":444372954,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v7.x","name":"dont-land-on-v7.x","color":"fbca04","default":false},{"id":155435992,"url":"https://api.github.com/repos/nodejs/node/labels/url","name":"url","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-12-17T13:23:01Z","updated_at":"2016-12-30T19:36:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10317","html_url":"https://github.com/nodejs/node/pull/10317","diff_url":"https://github.com/nodejs/node/pull/10317.diff","patch_url":"https://github.com/nodejs/node/pull/10317.patch"},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nurl\r\n\r\n##### Description of change\r\n\r\n* Return a long from ParseNumber to prevent overflow for valid big numbers\r\n* Don't throw when there are more than 4 parts (it cannot be an IP\r\naddress)\r\n* Correctly interpret the address and don't always throw when there are\r\nnumbers > 255\r\n\r\nRef: https://url.spec.whatwg.org/#concept-ipv4-parser\r\nFixes: https://github.com/nodejs/node/issues/10306\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/269812987","html_url":"https://github.com/nodejs/node/pull/10317#issuecomment-269812987","issue_url":"https://api.github.com/repos/nodejs/node/issues/10317","id":269812987,"user":{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T19:36:30Z","updated_at":"2016-12-30T19:36:30Z","body":"Rebased. PTAL."}}
{"actor":{"display_login":"targos"}}