{"action":"closed","number":331,"pull_request":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/331","id":64706857,"html_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/331","diff_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/331.diff","patch_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/331.patch","issue_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/331","number":331,"state":"closed","locked":false,"title":"Fix provider size lookup when calculating resource usage","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"body":"If you do not hit `api/v2/size?archived=true`, then you will only get\r\nthe _active_ sizes (tiny1, tiny2, small1, medium, etc) for a cloud\r\n(by the providers within a cloud).\r\n\r\nSo, if you are just looking at _active_ sizes, there is a possibility\r\nthat an instance's size is no longer available when fetching data to\r\nshow statistics or resource consumption, the number of that ilk.\r\n\r\nThis commit offers two improvements:\r\n- leverage the fact that Atmosphere API does *not* delete things, it\r\n  merely end-dates them\r\n- handle a situation when the 'size' for the Identity model is not\r\n  known (so be robust ... or dare I say _anti-fragile_)\r\n\r\nOne notion missing from this is the ability to communicate a statistic\r\nis \"uncertain\" because of the failure to find the associated CPU or\r\nmemory for an instance. If `size.get('cpu')` fails because `size` is\r\nfalse-y (null, undefined, etc) - there is not a way to say \"hey, this\r\nCPU count is *kind of* close, but _not_ exactly right\".\r\n\r\n- [ ] cherry-pick to `master`\r\n","created_at":"2016-03-30T22:20:00Z","updated_at":"2016-03-31T17:23:10Z","closed_at":"2016-03-31T17:23:10Z","merged_at":"2016-03-31T17:23:10Z","merge_commit_sha":"0cda3d1eda7632cc499449c09184d88cb47acecf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/331/commits","review_comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/331/comments","review_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/331/comments","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/statuses/8af58afcc75336ba7c6fd4a52193b716bd45eb27","head":{"label":"lenards:fix-provider-size-lookup","ref":"fix-provider-size-lookup","sha":"8af58afcc75336ba7c6fd4a52193b716bd45eb27","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"repo":{"id":42893619,"name":"troposphere","full_name":"lenards/troposphere","owner":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lenards/troposphere","description":"Atmosphere web client","fork":true,"url":"https://api.github.com/repos/lenards/troposphere","forks_url":"https://api.github.com/repos/lenards/troposphere/forks","keys_url":"https://api.github.com/repos/lenards/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lenards/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lenards/troposphere/teams","hooks_url":"https://api.github.com/repos/lenards/troposphere/hooks","issue_events_url":"https://api.github.com/repos/lenards/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/lenards/troposphere/events","assignees_url":"https://api.github.com/repos/lenards/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/lenards/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/lenards/troposphere/tags","blobs_url":"https://api.github.com/repos/lenards/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lenards/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lenards/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/lenards/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lenards/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/lenards/troposphere/languages","stargazers_url":"https://api.github.com/repos/lenards/troposphere/stargazers","contributors_url":"https://api.github.com/repos/lenards/troposphere/contributors","subscribers_url":"https://api.github.com/repos/lenards/troposphere/subscribers","subscription_url":"https://api.github.com/repos/lenards/troposphere/subscription","commits_url":"https://api.github.com/repos/lenards/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/lenards/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/lenards/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/lenards/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/lenards/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/lenards/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lenards/troposphere/merges","archive_url":"https://api.github.com/repos/lenards/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lenards/troposphere/downloads","issues_url":"https://api.github.com/repos/lenards/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/lenards/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/lenards/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/lenards/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lenards/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/lenards/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/lenards/troposphere/deployments","created_at":"2015-09-21T21:05:47Z","updated_at":"2016-03-22T20:17:51Z","pushed_at":"2016-03-31T15:46:14Z","git_url":"git://github.com/lenards/troposphere.git","ssh_url":"git@github.com:lenards/troposphere.git","clone_url":"https://github.com/lenards/troposphere.git","svn_url":"https://github.com/lenards/troposphere","homepage":null,"size":6698,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iPlantCollaborativeOpenSource:jetstream","ref":"jetstream","sha":"61b884bc96cf6033b81ffc6c48f35567fe7e3327","user":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"repo":{"id":17913633,"name":"troposphere","full_name":"iPlantCollaborativeOpenSource/troposphere","owner":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere","description":"Atmosphere web client","fork":false,"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere","forks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/forks","keys_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/teams","hooks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/hooks","issue_events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/events","assignees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/tags","blobs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/languages","stargazers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/stargazers","contributors_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/contributors","subscribers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/subscribers","subscription_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/subscription","commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/merges","archive_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/downloads","issues_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/deployments","created_at":"2014-03-19T17:26:44Z","updated_at":"2016-02-29T03:26:01Z","pushed_at":"2016-03-31T17:23:10Z","git_url":"git://github.com/iPlantCollaborativeOpenSource/troposphere.git","ssh_url":"git@github.com:iPlantCollaborativeOpenSource/troposphere.git","clone_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere.git","svn_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere","homepage":null,"size":6600,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/331"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/331"},"issue":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/331"},"comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/statuses/8af58afcc75336ba7c6fd4a52193b716bd45eb27"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"comments":5,"review_comments":3,"commits":3,"additions":10,"deletions":6,"changed_files":4}}