{"action":"created","comment":{"url":"https://api.github.com/repos/http-interop/http-factory/pulls/comments/74829531","id":74829531,"diff_hunk":"@@ -1,6 +1,6 @@\n <?php\n \n-namespace Psr\\Http\\Factory;\n+namespace Psr\\Http\\Factory\\Request;","path":"src/Request/RequestFactoryInterface.php","position":4,"original_position":4,"commit_id":"8a15671e1c2a5e79b1ea13cc2e65c3e7b916a69d","original_commit_id":"aed1cdbb739f11881fbe612c5eedf9dfd3ef370b","user":{"login":"mindplay-dk","id":103348,"avatar_url":"https://avatars.githubusercontent.com/u/103348?v=3","gravatar_id":"","url":"https://api.github.com/users/mindplay-dk","html_url":"https://github.com/mindplay-dk","followers_url":"https://api.github.com/users/mindplay-dk/followers","following_url":"https://api.github.com/users/mindplay-dk/following{/other_user}","gists_url":"https://api.github.com/users/mindplay-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/mindplay-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindplay-dk/subscriptions","organizations_url":"https://api.github.com/users/mindplay-dk/orgs","repos_url":"https://api.github.com/users/mindplay-dk/repos","events_url":"https://api.github.com/users/mindplay-dk/events{/privacy}","received_events_url":"https://api.github.com/users/mindplay-dk/received_events","type":"User","site_admin":false},"body":"I don't see the need to \"group\" single classes, those extra namespaces are redundant. I would group together the Request factories, and leave the URI and uploaded file factories in the root namespace.\r\n\r\n```\r\nRequest/RequestFactoryInterface.php\r\nRequest/ServerRequestFactoryInterface.php\r\nRequest/GlobalServerRequestFactoryInterface.php\r\nResponse/ResponseFactoryInterface.php\r\nStream/CallbackStreamFactoryInterface.php\r\nStream/ResourceStreamFactoryInterface.php\r\nStream/StreamFactoryInterface.php\r\nStream/StringStreamFactoryInterface.php\r\nUploadedFileFactoryInterface.php\r\nUriFactoryInterface.php\r\n```\r\n\r\nOr even just group the streams and leave everything else.\r\n\r\n```\r\nRequestFactoryInterface.php\r\nServerRequestFactoryInterface.php\r\nGlobalServerRequestFactoryInterface.php\r\nResponseFactoryInterface.php\r\nUploadedFileFactoryInterface.php\r\nUriFactoryInterface.php\r\nStream/CallbackStreamFactoryInterface.php\r\nStream/ResourceStreamFactoryInterface.php\r\nStream/StreamFactoryInterface.php\r\nStream/StringStreamFactoryInterface.php\r\n```\r\n\r\nDedicated namespaces for individual factories seems a little overkill.","created_at":"2016-08-15T20:32:42Z","updated_at":"2016-08-15T20:32:42Z","html_url":"https://github.com/http-interop/http-factory/pull/1#discussion_r74829531","pull_request_url":"https://api.github.com/repos/http-interop/http-factory/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/http-interop/http-factory/pulls/comments/74829531"},"html":{"href":"https://github.com/http-interop/http-factory/pull/1#discussion_r74829531"},"pull_request":{"href":"https://api.github.com/repos/http-interop/http-factory/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/http-interop/http-factory/pulls/1","id":81246582,"html_url":"https://github.com/http-interop/http-factory/pull/1","diff_url":"https://github.com/http-interop/http-factory/pull/1.diff","patch_url":"https://github.com/http-interop/http-factory/pull/1.patch","issue_url":"https://api.github.com/repos/http-interop/http-factory/issues/1","number":1,"state":"open","locked":false,"title":"Single factory interfaces","user":{"login":"shadowhand","id":38203,"avatar_url":"https://avatars.githubusercontent.com/u/38203?v=3","gravatar_id":"","url":"https://api.github.com/users/shadowhand","html_url":"https://github.com/shadowhand","followers_url":"https://api.github.com/users/shadowhand/followers","following_url":"https://api.github.com/users/shadowhand/following{/other_user}","gists_url":"https://api.github.com/users/shadowhand/gists{/gist_id}","starred_url":"https://api.github.com/users/shadowhand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadowhand/subscriptions","organizations_url":"https://api.github.com/users/shadowhand/orgs","repos_url":"https://api.github.com/users/shadowhand/repos","events_url":"https://api.github.com/users/shadowhand/events{/privacy}","received_events_url":"https://api.github.com/users/shadowhand/received_events","type":"User","site_admin":false},"body":"As per https://github.com/php-fig/fig-standards/pull/759#issuecomment-238969730","created_at":"2016-08-14T15:31:59Z","updated_at":"2016-08-15T20:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f6f3a010d1cbd6db5fcc4e58c16511bb9ac37f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/http-interop/http-factory/pulls/1/commits","review_comments_url":"https://api.github.com/repos/http-interop/http-factory/pulls/1/comments","review_comment_url":"https://api.github.com/repos/http-interop/http-factory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/http-interop/http-factory/issues/1/comments","statuses_url":"https://api.github.com/repos/http-interop/http-factory/statuses/8a15671e1c2a5e79b1ea13cc2e65c3e7b916a69d","head":{"label":"http-interop:single-factory-interfaces","ref":"single-factory-interfaces","sha":"8a15671e1c2a5e79b1ea13cc2e65c3e7b916a69d","user":{"login":"http-interop","id":21023081,"avatar_url":"https://avatars.githubusercontent.com/u/21023081?v=3","gravatar_id":"","url":"https://api.github.com/users/http-interop","html_url":"https://github.com/http-interop","followers_url":"https://api.github.com/users/http-interop/followers","following_url":"https://api.github.com/users/http-interop/following{/other_user}","gists_url":"https://api.github.com/users/http-interop/gists{/gist_id}","starred_url":"https://api.github.com/users/http-interop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http-interop/subscriptions","organizations_url":"https://api.github.com/users/http-interop/orgs","repos_url":"https://api.github.com/users/http-interop/repos","events_url":"https://api.github.com/users/http-interop/events{/privacy}","received_events_url":"https://api.github.com/users/http-interop/received_events","type":"Organization","site_admin":false},"repo":{"id":61202840,"name":"http-factory","full_name":"http-interop/http-factory","owner":{"login":"http-interop","id":21023081,"avatar_url":"https://avatars.githubusercontent.com/u/21023081?v=3","gravatar_id":"","url":"https://api.github.com/users/http-interop","html_url":"https://github.com/http-interop","followers_url":"https://api.github.com/users/http-interop/followers","following_url":"https://api.github.com/users/http-interop/following{/other_user}","gists_url":"https://api.github.com/users/http-interop/gists{/gist_id}","starred_url":"https://api.github.com/users/http-interop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http-interop/subscriptions","organizations_url":"https://api.github.com/users/http-interop/orgs","repos_url":"https://api.github.com/users/http-interop/repos","events_url":"https://api.github.com/users/http-interop/events{/privacy}","received_events_url":"https://api.github.com/users/http-interop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http-interop/http-factory","description":"PSR-17 interfaces for HTTP Factories","fork":false,"url":"https://api.github.com/repos/http-interop/http-factory","forks_url":"https://api.github.com/repos/http-interop/http-factory/forks","keys_url":"https://api.github.com/repos/http-interop/http-factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http-interop/http-factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http-interop/http-factory/teams","hooks_url":"https://api.github.com/repos/http-interop/http-factory/hooks","issue_events_url":"https://api.github.com/repos/http-interop/http-factory/issues/events{/number}","events_url":"https://api.github.com/repos/http-interop/http-factory/events","assignees_url":"https://api.github.com/repos/http-interop/http-factory/assignees{/user}","branches_url":"https://api.github.com/repos/http-interop/http-factory/branches{/branch}","tags_url":"https://api.github.com/repos/http-interop/http-factory/tags","blobs_url":"https://api.github.com/repos/http-interop/http-factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http-interop/http-factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http-interop/http-factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/http-interop/http-factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http-interop/http-factory/statuses/{sha}","languages_url":"https://api.github.com/repos/http-interop/http-factory/languages","stargazers_url":"https://api.github.com/repos/http-interop/http-factory/stargazers","contributors_url":"https://api.github.com/repos/http-interop/http-factory/contributors","subscribers_url":"https://api.github.com/repos/http-interop/http-factory/subscribers","subscription_url":"https://api.github.com/repos/http-interop/http-factory/subscription","commits_url":"https://api.github.com/repos/http-interop/http-factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/http-interop/http-factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/http-interop/http-factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/http-interop/http-factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/http-interop/http-factory/contents/{+path}","compare_url":"https://api.github.com/repos/http-interop/http-factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http-interop/http-factory/merges","archive_url":"https://api.github.com/repos/http-interop/http-factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http-interop/http-factory/downloads","issues_url":"https://api.github.com/repos/http-interop/http-factory/issues{/number}","pulls_url":"https://api.github.com/repos/http-interop/http-factory/pulls{/number}","milestones_url":"https://api.github.com/repos/http-interop/http-factory/milestones{/number}","notifications_url":"https://api.github.com/repos/http-interop/http-factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http-interop/http-factory/labels{/name}","releases_url":"https://api.github.com/repos/http-interop/http-factory/releases{/id}","deployments_url":"https://api.github.com/repos/http-interop/http-factory/deployments","created_at":"2016-06-15T11:27:49Z","updated_at":"2016-08-14T22:34:00Z","pushed_at":"2016-08-15T13:57:16Z","git_url":"git://github.com/http-interop/http-factory.git","ssh_url":"git@github.com:http-interop/http-factory.git","clone_url":"https://github.com/http-interop/http-factory.git","svn_url":"https://github.com/http-interop/http-factory","homepage":"","size":10,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"http-interop:master","ref":"master","sha":"4d13c3a8782ff0e4f753b9806cf4c640aff1042e","user":{"login":"http-interop","id":21023081,"avatar_url":"https://avatars.githubusercontent.com/u/21023081?v=3","gravatar_id":"","url":"https://api.github.com/users/http-interop","html_url":"https://github.com/http-interop","followers_url":"https://api.github.com/users/http-interop/followers","following_url":"https://api.github.com/users/http-interop/following{/other_user}","gists_url":"https://api.github.com/users/http-interop/gists{/gist_id}","starred_url":"https://api.github.com/users/http-interop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http-interop/subscriptions","organizations_url":"https://api.github.com/users/http-interop/orgs","repos_url":"https://api.github.com/users/http-interop/repos","events_url":"https://api.github.com/users/http-interop/events{/privacy}","received_events_url":"https://api.github.com/users/http-interop/received_events","type":"Organization","site_admin":false},"repo":{"id":61202840,"name":"http-factory","full_name":"http-interop/http-factory","owner":{"login":"http-interop","id":21023081,"avatar_url":"https://avatars.githubusercontent.com/u/21023081?v=3","gravatar_id":"","url":"https://api.github.com/users/http-interop","html_url":"https://github.com/http-interop","followers_url":"https://api.github.com/users/http-interop/followers","following_url":"https://api.github.com/users/http-interop/following{/other_user}","gists_url":"https://api.github.com/users/http-interop/gists{/gist_id}","starred_url":"https://api.github.com/users/http-interop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http-interop/subscriptions","organizations_url":"https://api.github.com/users/http-interop/orgs","repos_url":"https://api.github.com/users/http-interop/repos","events_url":"https://api.github.com/users/http-interop/events{/privacy}","received_events_url":"https://api.github.com/users/http-interop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http-interop/http-factory","description":"PSR-17 interfaces for HTTP Factories","fork":false,"url":"https://api.github.com/repos/http-interop/http-factory","forks_url":"https://api.github.com/repos/http-interop/http-factory/forks","keys_url":"https://api.github.com/repos/http-interop/http-factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http-interop/http-factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http-interop/http-factory/teams","hooks_url":"https://api.github.com/repos/http-interop/http-factory/hooks","issue_events_url":"https://api.github.com/repos/http-interop/http-factory/issues/events{/number}","events_url":"https://api.github.com/repos/http-interop/http-factory/events","assignees_url":"https://api.github.com/repos/http-interop/http-factory/assignees{/user}","branches_url":"https://api.github.com/repos/http-interop/http-factory/branches{/branch}","tags_url":"https://api.github.com/repos/http-interop/http-factory/tags","blobs_url":"https://api.github.com/repos/http-interop/http-factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http-interop/http-factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http-interop/http-factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/http-interop/http-factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http-interop/http-factory/statuses/{sha}","languages_url":"https://api.github.com/repos/http-interop/http-factory/languages","stargazers_url":"https://api.github.com/repos/http-interop/http-factory/stargazers","contributors_url":"https://api.github.com/repos/http-interop/http-factory/contributors","subscribers_url":"https://api.github.com/repos/http-interop/http-factory/subscribers","subscription_url":"https://api.github.com/repos/http-interop/http-factory/subscription","commits_url":"https://api.github.com/repos/http-interop/http-factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/http-interop/http-factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/http-interop/http-factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/http-interop/http-factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/http-interop/http-factory/contents/{+path}","compare_url":"https://api.github.com/repos/http-interop/http-factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http-interop/http-factory/merges","archive_url":"https://api.github.com/repos/http-interop/http-factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http-interop/http-factory/downloads","issues_url":"https://api.github.com/repos/http-interop/http-factory/issues{/number}","pulls_url":"https://api.github.com/repos/http-interop/http-factory/pulls{/number}","milestones_url":"https://api.github.com/repos/http-interop/http-factory/milestones{/number}","notifications_url":"https://api.github.com/repos/http-interop/http-factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http-interop/http-factory/labels{/name}","releases_url":"https://api.github.com/repos/http-interop/http-factory/releases{/id}","deployments_url":"https://api.github.com/repos/http-interop/http-factory/deployments","created_at":"2016-06-15T11:27:49Z","updated_at":"2016-08-14T22:34:00Z","pushed_at":"2016-08-15T13:57:16Z","git_url":"git://github.com/http-interop/http-factory.git","ssh_url":"git@github.com:http-interop/http-factory.git","clone_url":"https://github.com/http-interop/http-factory.git","svn_url":"https://github.com/http-interop/http-factory","homepage":"","size":10,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http-interop/http-factory/pulls/1"},"html":{"href":"https://github.com/http-interop/http-factory/pull/1"},"issue":{"href":"https://api.github.com/repos/http-interop/http-factory/issues/1"},"comments":{"href":"https://api.github.com/repos/http-interop/http-factory/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/http-interop/http-factory/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/http-interop/http-factory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/http-interop/http-factory/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/http-interop/http-factory/statuses/8a15671e1c2a5e79b1ea13cc2e65c3e7b916a69d"}}}}
{"actor":{"display_login":"mindplay-dk"}}