{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/sulu/pulls/comments/65047172","id":65047172,"diff_hunk":"@@ -82,7 +82,12 @@ public function load($resource, $type = 'page')\n         $schemaPath = __DIR__ . static::SCHEME_PATH;\n \n         // read file\n-        $xmlDocument = XmlUtils::loadFile($resource, $schemaPath);\n+        $xmlDocument = XmlUtils::loadFile($resource, function (\\DOMDocument $dom) use ($resource, $schemaPath) {\n+                $dom->documentURI = $resource;\n+                $dom->xinclude();\n+\n+                return @$dom->schemaValidate($schemaPath);","path":"src/Sulu/Component/Content/Metadata/Loader/XmlLegacyLoader.php","position":null,"original_position":9,"commit_id":"81b3488c85e4e3b9208ae44d909e35586cb26326","original_commit_id":"d23afb3e2bc4c45021d1861a2f306b356ae096f2","user":{"login":"gisostallenberg","id":11526270,"avatar_url":"https://avatars.githubusercontent.com/u/11526270?v=3","gravatar_id":"","url":"https://api.github.com/users/gisostallenberg","html_url":"https://github.com/gisostallenberg","followers_url":"https://api.github.com/users/gisostallenberg/followers","following_url":"https://api.github.com/users/gisostallenberg/following{/other_user}","gists_url":"https://api.github.com/users/gisostallenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/gisostallenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gisostallenberg/subscriptions","organizations_url":"https://api.github.com/users/gisostallenberg/orgs","repos_url":"https://api.github.com/users/gisostallenberg/repos","events_url":"https://api.github.com/users/gisostallenberg/events{/privacy}","received_events_url":"https://api.github.com/users/gisostallenberg/received_events","type":"User","site_admin":false},"body":"The errors get handled afterwards in XmlUtils::getXmlErrors, which are more detailed according to a [comment](http://php.net/manual/en/domdocument.schemavalidate.php#62032) on the php documentation.","created_at":"2016-05-30T09:30:35Z","updated_at":"2016-05-30T09:30:35Z","html_url":"https://github.com/sulu/sulu/pull/2424#discussion_r65047172","pull_request_url":"https://api.github.com/repos/sulu/sulu/pulls/2424","_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments/65047172"},"html":{"href":"https://github.com/sulu/sulu/pull/2424#discussion_r65047172"},"pull_request":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2424"}}},"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/2424","id":71831450,"html_url":"https://github.com/sulu/sulu/pull/2424","diff_url":"https://github.com/sulu/sulu/pull/2424.diff","patch_url":"https://github.com/sulu/sulu/pull/2424.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/2424","number":2424,"state":"open","locked":false,"title":"Add support for XInclude","user":{"login":"gisostallenberg","id":11526270,"avatar_url":"https://avatars.githubusercontent.com/u/11526270?v=3","gravatar_id":"","url":"https://api.github.com/users/gisostallenberg","html_url":"https://github.com/gisostallenberg","followers_url":"https://api.github.com/users/gisostallenberg/followers","following_url":"https://api.github.com/users/gisostallenberg/following{/other_user}","gists_url":"https://api.github.com/users/gisostallenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/gisostallenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gisostallenberg/subscriptions","organizations_url":"https://api.github.com/users/gisostallenberg/orgs","repos_url":"https://api.github.com/users/gisostallenberg/repos","events_url":"https://api.github.com/users/gisostallenberg/events{/privacy}","received_events_url":"https://api.github.com/users/gisostallenberg/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | no\r\n| New feature? | yes\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | fixes #2417\r\n| License | MIT\r\n| Documentation PR | N/A\r\n\r\n#### What's in this PR?\r\n\r\nThis allows the creator of a template to use xinclude to include parts of xml\r\n\r\n#### Example Usage\r\n```xml\r\n<?xml version=\"1.0\" ?>\r\n<template xmlns=\"http://schemas.sulu.io/template/template\"\r\n          xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\r\n          xmlns:xi=\"http://www.w3.org/2001/XInclude\"\r\n          xsi:schemaLocation=\"http://schemas.sulu.io/template/template http://schemas.sulu.io/template/template-1.0.xsd\">\r\n\r\n    <key>mytemplate</key>\r\n\r\n<!--\r\n...\r\n-->\r\n    <xi:include href='parts/mytemplate-properties.xml'/>\r\n```\r\n#### To Do\r\n\r\n- [ ] Create a documentation PR\r\n","created_at":"2016-05-29T16:32:29Z","updated_at":"2016-05-30T09:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5c8ec0532414c64aec8856cda6a08c46350f23d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/2424/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/2424/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/2424/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/81b3488c85e4e3b9208ae44d909e35586cb26326","head":{"label":"gisostallenberg:xinclude","ref":"xinclude","sha":"81b3488c85e4e3b9208ae44d909e35586cb26326","user":{"login":"gisostallenberg","id":11526270,"avatar_url":"https://avatars.githubusercontent.com/u/11526270?v=3","gravatar_id":"","url":"https://api.github.com/users/gisostallenberg","html_url":"https://github.com/gisostallenberg","followers_url":"https://api.github.com/users/gisostallenberg/followers","following_url":"https://api.github.com/users/gisostallenberg/following{/other_user}","gists_url":"https://api.github.com/users/gisostallenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/gisostallenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gisostallenberg/subscriptions","organizations_url":"https://api.github.com/users/gisostallenberg/orgs","repos_url":"https://api.github.com/users/gisostallenberg/repos","events_url":"https://api.github.com/users/gisostallenberg/events{/privacy}","received_events_url":"https://api.github.com/users/gisostallenberg/received_events","type":"User","site_admin":false},"repo":{"id":57594231,"name":"sulu","full_name":"gisostallenberg/sulu","owner":{"login":"gisostallenberg","id":11526270,"avatar_url":"https://avatars.githubusercontent.com/u/11526270?v=3","gravatar_id":"","url":"https://api.github.com/users/gisostallenberg","html_url":"https://github.com/gisostallenberg","followers_url":"https://api.github.com/users/gisostallenberg/followers","following_url":"https://api.github.com/users/gisostallenberg/following{/other_user}","gists_url":"https://api.github.com/users/gisostallenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/gisostallenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gisostallenberg/subscriptions","organizations_url":"https://api.github.com/users/gisostallenberg/orgs","repos_url":"https://api.github.com/users/gisostallenberg/repos","events_url":"https://api.github.com/users/gisostallenberg/events{/privacy}","received_events_url":"https://api.github.com/users/gisostallenberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gisostallenberg/sulu","description":"Sulu core bundles & components","fork":true,"url":"https://api.github.com/repos/gisostallenberg/sulu","forks_url":"https://api.github.com/repos/gisostallenberg/sulu/forks","keys_url":"https://api.github.com/repos/gisostallenberg/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gisostallenberg/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gisostallenberg/sulu/teams","hooks_url":"https://api.github.com/repos/gisostallenberg/sulu/hooks","issue_events_url":"https://api.github.com/repos/gisostallenberg/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/gisostallenberg/sulu/events","assignees_url":"https://api.github.com/repos/gisostallenberg/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/gisostallenberg/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/gisostallenberg/sulu/tags","blobs_url":"https://api.github.com/repos/gisostallenberg/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gisostallenberg/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gisostallenberg/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/gisostallenberg/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gisostallenberg/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/gisostallenberg/sulu/languages","stargazers_url":"https://api.github.com/repos/gisostallenberg/sulu/stargazers","contributors_url":"https://api.github.com/repos/gisostallenberg/sulu/contributors","subscribers_url":"https://api.github.com/repos/gisostallenberg/sulu/subscribers","subscription_url":"https://api.github.com/repos/gisostallenberg/sulu/subscription","commits_url":"https://api.github.com/repos/gisostallenberg/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/gisostallenberg/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/gisostallenberg/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/gisostallenberg/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/gisostallenberg/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/gisostallenberg/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gisostallenberg/sulu/merges","archive_url":"https://api.github.com/repos/gisostallenberg/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gisostallenberg/sulu/downloads","issues_url":"https://api.github.com/repos/gisostallenberg/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/gisostallenberg/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/gisostallenberg/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/gisostallenberg/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gisostallenberg/sulu/labels{/name}","releases_url":"https://api.github.com/repos/gisostallenberg/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/gisostallenberg/sulu/deployments","created_at":"2016-05-01T10:28:15Z","updated_at":"2016-05-01T10:28:22Z","pushed_at":"2016-05-29T16:36:33Z","git_url":"git://github.com/gisostallenberg/sulu.git","ssh_url":"git@github.com:gisostallenberg/sulu.git","clone_url":"https://github.com/gisostallenberg/sulu.git","svn_url":"https://github.com/gisostallenberg/sulu","homepage":"sulu.io","size":67785,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:develop","ref":"develop","sha":"f59db336e1ea24353153e14341cbfdadd338bb74","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-05-24T11:18:57Z","pushed_at":"2016-05-30T08:00:34Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":78584,"stargazers_count":126,"watchers_count":126,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":380,"forks":35,"open_issues":380,"watchers":126,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2424"},"html":{"href":"https://github.com/sulu/sulu/pull/2424"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/2424"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/2424/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2424/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2424/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/81b3488c85e4e3b9208ae44d909e35586cb26326"}}}}
{"actor":{"display_login":"gisostallenberg"}}