{"action":"created","comment":{"url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/comments/67730035","id":67730035,"diff_hunk":"@@ -0,0 +1,178 @@\n+# Copyright 2015 F5 Networks Inc.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#    http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+import pytest\n+\n+from f5.bigip.resource import MissingRequiredCreationParameter\n+from f5.bigip.tm.gtm.rule import Rule\n+from requests.exceptions import HTTPError\n+\n+\n+RULE = '''when LB_SELECTED {\n+   set wipHost [LB::server addr]\n+}\n+'''\n+\n+\n+def delete_rule(bigip, name, partition):","path":"test/functional/tm/gtm/test_rule.py","position":29,"original_position":29,"commit_id":"35db857f7f011a01a84cc4a80c6676ab8c1c9960","original_commit_id":"35db857f7f011a01a84cc4a80c6676ab8c1c9960","user":{"login":"pjbreaux","id":14225800,"avatar_url":"https://avatars.githubusercontent.com/u/14225800?v=3","gravatar_id":"","url":"https://api.github.com/users/pjbreaux","html_url":"https://github.com/pjbreaux","followers_url":"https://api.github.com/users/pjbreaux/followers","following_url":"https://api.github.com/users/pjbreaux/following{/other_user}","gists_url":"https://api.github.com/users/pjbreaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbreaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbreaux/subscriptions","organizations_url":"https://api.github.com/users/pjbreaux/orgs","repos_url":"https://api.github.com/users/pjbreaux/repos","events_url":"https://api.github.com/users/pjbreaux/events{/privacy}","received_events_url":"https://api.github.com/users/pjbreaux/received_events","type":"User","site_admin":false},"body":"Could you also do me another small favor and create another fixture alongside the 'bigip', which is called 'management_root' or 'mgmt_root' which has the new path, and use that instead of the old root?\r\n\r\nThe new fixture would be in here: https://github.com/F5Networks/f5-common-python/blob/development/conftest.py","created_at":"2016-06-20T17:25:39Z","updated_at":"2016-06-20T17:25:39Z","html_url":"https://github.com/F5Networks/f5-common-python/pull/496#discussion_r67730035","pull_request_url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496","_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/comments/67730035"},"html":{"href":"https://github.com/F5Networks/f5-common-python/pull/496#discussion_r67730035"},"pull_request":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496"}}},"pull_request":{"url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496","id":74351294,"html_url":"https://github.com/F5Networks/f5-common-python/pull/496","diff_url":"https://github.com/F5Networks/f5-common-python/pull/496.diff","patch_url":"https://github.com/F5Networks/f5-common-python/pull/496.patch","issue_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/496","number":496,"state":"open","locked":false,"title":"Adds GTM iRule api support","user":{"login":"caphrim007","id":46956,"avatar_url":"https://avatars.githubusercontent.com/u/46956?v=3","gravatar_id":"","url":"https://api.github.com/users/caphrim007","html_url":"https://github.com/caphrim007","followers_url":"https://api.github.com/users/caphrim007/followers","following_url":"https://api.github.com/users/caphrim007/following{/other_user}","gists_url":"https://api.github.com/users/caphrim007/gists{/gist_id}","starred_url":"https://api.github.com/users/caphrim007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caphrim007/subscriptions","organizations_url":"https://api.github.com/users/caphrim007/orgs","repos_url":"https://api.github.com/users/caphrim007/repos","events_url":"https://api.github.com/users/caphrim007/events{/privacy}","received_events_url":"https://api.github.com/users/caphrim007/received_events","type":"User","site_admin":false},"body":"@wojtek0806 @zancas \r\n\r\nFixes #494 \r\n\r\n#### What's this change do?\r\nThis patch adds support and tests for to the SDK for the GTM iRule API\r\n\r\n#### Where should the reviewer start?\r\n  * test/functional/tm/gtm/test_rule.py\r\n  * f5/tm/gtm/test/test_rule.py\r\n\r\n#### Any background context?\r\nThe SDK currently does not support the GTM iRule API.","created_at":"2016-06-19T00:47:18Z","updated_at":"2016-06-20T17:25:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"804168ee5f22d1f14f308a705319f1d9b0521249","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496/commits","review_comments_url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496/comments","review_comment_url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/496/comments","statuses_url":"https://api.github.com/repos/F5Networks/f5-common-python/statuses/35db857f7f011a01a84cc4a80c6676ab8c1c9960","head":{"label":"caphrim007:add-gtm-irule-support","ref":"add-gtm-irule-support","sha":"35db857f7f011a01a84cc4a80c6676ab8c1c9960","user":{"login":"caphrim007","id":46956,"avatar_url":"https://avatars.githubusercontent.com/u/46956?v=3","gravatar_id":"","url":"https://api.github.com/users/caphrim007","html_url":"https://github.com/caphrim007","followers_url":"https://api.github.com/users/caphrim007/followers","following_url":"https://api.github.com/users/caphrim007/following{/other_user}","gists_url":"https://api.github.com/users/caphrim007/gists{/gist_id}","starred_url":"https://api.github.com/users/caphrim007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caphrim007/subscriptions","organizations_url":"https://api.github.com/users/caphrim007/orgs","repos_url":"https://api.github.com/users/caphrim007/repos","events_url":"https://api.github.com/users/caphrim007/events{/privacy}","received_events_url":"https://api.github.com/users/caphrim007/received_events","type":"User","site_admin":false},"repo":{"id":56890887,"name":"f5-common-python","full_name":"caphrim007/f5-common-python","owner":{"login":"caphrim007","id":46956,"avatar_url":"https://avatars.githubusercontent.com/u/46956?v=3","gravatar_id":"","url":"https://api.github.com/users/caphrim007","html_url":"https://github.com/caphrim007","followers_url":"https://api.github.com/users/caphrim007/followers","following_url":"https://api.github.com/users/caphrim007/following{/other_user}","gists_url":"https://api.github.com/users/caphrim007/gists{/gist_id}","starred_url":"https://api.github.com/users/caphrim007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caphrim007/subscriptions","organizations_url":"https://api.github.com/users/caphrim007/orgs","repos_url":"https://api.github.com/users/caphrim007/repos","events_url":"https://api.github.com/users/caphrim007/events{/privacy}","received_events_url":"https://api.github.com/users/caphrim007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caphrim007/f5-common-python","description":"Python SDK for configuration and monitoring of F5® BIG-IP® devices via the iControl® REST API.","fork":true,"url":"https://api.github.com/repos/caphrim007/f5-common-python","forks_url":"https://api.github.com/repos/caphrim007/f5-common-python/forks","keys_url":"https://api.github.com/repos/caphrim007/f5-common-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caphrim007/f5-common-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caphrim007/f5-common-python/teams","hooks_url":"https://api.github.com/repos/caphrim007/f5-common-python/hooks","issue_events_url":"https://api.github.com/repos/caphrim007/f5-common-python/issues/events{/number}","events_url":"https://api.github.com/repos/caphrim007/f5-common-python/events","assignees_url":"https://api.github.com/repos/caphrim007/f5-common-python/assignees{/user}","branches_url":"https://api.github.com/repos/caphrim007/f5-common-python/branches{/branch}","tags_url":"https://api.github.com/repos/caphrim007/f5-common-python/tags","blobs_url":"https://api.github.com/repos/caphrim007/f5-common-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caphrim007/f5-common-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caphrim007/f5-common-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/caphrim007/f5-common-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caphrim007/f5-common-python/statuses/{sha}","languages_url":"https://api.github.com/repos/caphrim007/f5-common-python/languages","stargazers_url":"https://api.github.com/repos/caphrim007/f5-common-python/stargazers","contributors_url":"https://api.github.com/repos/caphrim007/f5-common-python/contributors","subscribers_url":"https://api.github.com/repos/caphrim007/f5-common-python/subscribers","subscription_url":"https://api.github.com/repos/caphrim007/f5-common-python/subscription","commits_url":"https://api.github.com/repos/caphrim007/f5-common-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/caphrim007/f5-common-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/caphrim007/f5-common-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/caphrim007/f5-common-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/caphrim007/f5-common-python/contents/{+path}","compare_url":"https://api.github.com/repos/caphrim007/f5-common-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caphrim007/f5-common-python/merges","archive_url":"https://api.github.com/repos/caphrim007/f5-common-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caphrim007/f5-common-python/downloads","issues_url":"https://api.github.com/repos/caphrim007/f5-common-python/issues{/number}","pulls_url":"https://api.github.com/repos/caphrim007/f5-common-python/pulls{/number}","milestones_url":"https://api.github.com/repos/caphrim007/f5-common-python/milestones{/number}","notifications_url":"https://api.github.com/repos/caphrim007/f5-common-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caphrim007/f5-common-python/labels{/name}","releases_url":"https://api.github.com/repos/caphrim007/f5-common-python/releases{/id}","deployments_url":"https://api.github.com/repos/caphrim007/f5-common-python/deployments","created_at":"2016-04-22T23:33:55Z","updated_at":"2016-04-22T23:33:56Z","pushed_at":"2016-06-19T01:38:29Z","git_url":"git://github.com/caphrim007/f5-common-python.git","ssh_url":"git@github.com:caphrim007/f5-common-python.git","clone_url":"https://github.com/caphrim007/f5-common-python.git","svn_url":"https://github.com/caphrim007/f5-common-python","homepage":"https://f5-sdk.readthedocs.org","size":951,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.1"}},"base":{"label":"F5Networks:development","ref":"development","sha":"60abd57feb5b457e441f6d940430a50458866762","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":45062555,"name":"f5-common-python","full_name":"F5Networks/f5-common-python","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/f5-common-python","description":"Python SDK for configuration and monitoring of F5® BIG-IP® devices via the iControl® REST API.","fork":false,"url":"https://api.github.com/repos/F5Networks/f5-common-python","forks_url":"https://api.github.com/repos/F5Networks/f5-common-python/forks","keys_url":"https://api.github.com/repos/F5Networks/f5-common-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/f5-common-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/f5-common-python/teams","hooks_url":"https://api.github.com/repos/F5Networks/f5-common-python/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/f5-common-python/events","assignees_url":"https://api.github.com/repos/F5Networks/f5-common-python/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/f5-common-python/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/f5-common-python/tags","blobs_url":"https://api.github.com/repos/F5Networks/f5-common-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/f5-common-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/f5-common-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/f5-common-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/f5-common-python/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/f5-common-python/languages","stargazers_url":"https://api.github.com/repos/F5Networks/f5-common-python/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/f5-common-python/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/f5-common-python/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/f5-common-python/subscription","commits_url":"https://api.github.com/repos/F5Networks/f5-common-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/f5-common-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/f5-common-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/f5-common-python/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/f5-common-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/f5-common-python/merges","archive_url":"https://api.github.com/repos/F5Networks/f5-common-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/f5-common-python/downloads","issues_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/f5-common-python/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/f5-common-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/f5-common-python/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/f5-common-python/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/f5-common-python/deployments","created_at":"2015-10-27T18:48:06Z","updated_at":"2016-06-18T00:07:13Z","pushed_at":"2016-06-19T01:38:29Z","git_url":"git://github.com/F5Networks/f5-common-python.git","ssh_url":"git@github.com:F5Networks/f5-common-python.git","clone_url":"https://github.com/F5Networks/f5-common-python.git","svn_url":"https://github.com/F5Networks/f5-common-python","homepage":"https://f5-sdk.readthedocs.org","size":1076,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":36,"forks":15,"open_issues":36,"watchers":17,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496"},"html":{"href":"https://github.com/F5Networks/f5-common-python/pull/496"},"issue":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/issues/496"},"comments":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/f5-common-python/statuses/35db857f7f011a01a84cc4a80c6676ab8c1c9960"}}}}
{"actor":{"display_login":"pjbreaux"}}