{"action":"opened","number":5282,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5282","id":65561554,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5282","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/5282.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/5282.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5282","number":5282,"state":"open","locked":false,"title":"FIX for #5279 Addressing only a few PSR-2 items in one file, but primarily targeting Director::is_https() and invalid URL's.","user":{"login":"patricknelson","id":4269377,"avatar_url":"https://avatars.githubusercontent.com/u/4269377?v=3","gravatar_id":"","url":"https://api.github.com/users/patricknelson","html_url":"https://github.com/patricknelson","followers_url":"https://api.github.com/users/patricknelson/followers","following_url":"https://api.github.com/users/patricknelson/following{/other_user}","gists_url":"https://api.github.com/users/patricknelson/gists{/gist_id}","starred_url":"https://api.github.com/users/patricknelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricknelson/subscriptions","organizations_url":"https://api.github.com/users/patricknelson/orgs","repos_url":"https://api.github.com/users/patricknelson/repos","events_url":"https://api.github.com/users/patricknelson/events{/privacy}","received_events_url":"https://api.github.com/users/patricknelson/received_events","type":"User","site_admin":false},"body":"Addresses issue #5279 and supersedes PR #5280 (now it is on master, not 3.3).\r\n\r\nAlso @tractorcow in this revision, I tackled a ton of little spots where commas were strung together without spacing, so it should be much more readable now as well. The contents of `::makeRelative()` were particularly egregious.","created_at":"2016-04-07T01:29:49Z","updated_at":"2016-04-07T01:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5282/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5282/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5282/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/0aec89d0c8f0a6402122a3aec0f338cd84658dec","head":{"label":"patricknelson:issue-5279-director-code-quality-master","ref":"issue-5279-director-code-quality-master","sha":"0aec89d0c8f0a6402122a3aec0f338cd84658dec","user":{"login":"patricknelson","id":4269377,"avatar_url":"https://avatars.githubusercontent.com/u/4269377?v=3","gravatar_id":"","url":"https://api.github.com/users/patricknelson","html_url":"https://github.com/patricknelson","followers_url":"https://api.github.com/users/patricknelson/followers","following_url":"https://api.github.com/users/patricknelson/following{/other_user}","gists_url":"https://api.github.com/users/patricknelson/gists{/gist_id}","starred_url":"https://api.github.com/users/patricknelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricknelson/subscriptions","organizations_url":"https://api.github.com/users/patricknelson/orgs","repos_url":"https://api.github.com/users/patricknelson/repos","events_url":"https://api.github.com/users/patricknelson/events{/privacy}","received_events_url":"https://api.github.com/users/patricknelson/received_events","type":"User","site_admin":false},"repo":{"id":31024612,"name":"silverstripe-framework","full_name":"patricknelson/silverstripe-framework","owner":{"login":"patricknelson","id":4269377,"avatar_url":"https://avatars.githubusercontent.com/u/4269377?v=3","gravatar_id":"","url":"https://api.github.com/users/patricknelson","html_url":"https://github.com/patricknelson","followers_url":"https://api.github.com/users/patricknelson/followers","following_url":"https://api.github.com/users/patricknelson/following{/other_user}","gists_url":"https://api.github.com/users/patricknelson/gists{/gist_id}","starred_url":"https://api.github.com/users/patricknelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricknelson/subscriptions","organizations_url":"https://api.github.com/users/patricknelson/orgs","repos_url":"https://api.github.com/users/patricknelson/repos","events_url":"https://api.github.com/users/patricknelson/events{/privacy}","received_events_url":"https://api.github.com/users/patricknelson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patricknelson/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/patricknelson/silverstripe-framework","forks_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/patricknelson/silverstripe-framework/deployments","created_at":"2015-02-19T16:29:56Z","updated_at":"2015-04-29T14:06:01Z","pushed_at":"2016-04-07T01:27:06Z","git_url":"git://github.com/patricknelson/silverstripe-framework.git","ssh_url":"git@github.com:patricknelson/silverstripe-framework.git","clone_url":"https://github.com/patricknelson/silverstripe-framework.git","svn_url":"https://github.com/patricknelson/silverstripe-framework","homepage":"http://silverstripe.org/","size":63732,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.1"}},"base":{"label":"silverstripe:master","ref":"master","sha":"7ff646091e143d7910210a8c0b0282c159b33845","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2016-03-31T23:02:36Z","pushed_at":"2016-04-06T18:22:12Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":77828,"stargazers_count":501,"watchers_count":501,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":649,"forks":580,"open_issues":649,"watchers":501,"default_branch":"3"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5282"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/5282"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5282"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5282/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5282/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5282/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/0aec89d0c8f0a6402122a3aec0f338cd84658dec"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":113,"deletions":111,"changed_files":2}}