{"action":"created","comment":{"url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/comments/58236673","id":58236673,"diff_hunk":"@@ -0,0 +1,32 @@\n+\n+\n+from StockAnalysis.historical_bars import TickerData\n+from StockAnalysis.historical_bars import BarData\n+\n+data = TickerData('FB', 'D', 'NASDAQ')\n+gap_ups = []\n+\n+\n+def identify_gap_ups(percentage):\n+    i = 0\n+    for current_bar in data.candlesticks:\n+        # b.print_bar_data()\n+        if i > 1:\n+            last_bar = data.candlesticks[i-1]\n+            try:\n+                if current_bar.open > last_bar.close:\n+                    diff = float(current_bar.open) - float(last_bar.close)\n+                    calc_percent = diff / float(last_bar.close)\n+                    if calc_percent > .03:\n+                        print(current_bar.open + ' ' + last_bar.close + ' Date: '+current_bar.bar_datetime\n+                                + ' {0:.4f}'.format(calc_percent))\n+                        gap_ups.append(current_bar)\n+","path":"YahooStockData/Apps-Trading/gap_analysis.py","position":24,"original_position":24,"commit_id":"6db0735b4863d1f791cb582ee65429041fc58e0c","original_commit_id":"6db0735b4863d1f791cb582ee65429041fc58e0c","user":{"login":"kelahm","id":18126503,"avatar_url":"https://avatars.githubusercontent.com/u/18126503?v=3","gravatar_id":"","url":"https://api.github.com/users/kelahm","html_url":"https://github.com/kelahm","followers_url":"https://api.github.com/users/kelahm/followers","following_url":"https://api.github.com/users/kelahm/following{/other_user}","gists_url":"https://api.github.com/users/kelahm/gists{/gist_id}","starred_url":"https://api.github.com/users/kelahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelahm/subscriptions","organizations_url":"https://api.github.com/users/kelahm/orgs","repos_url":"https://api.github.com/users/kelahm/repos","events_url":"https://api.github.com/users/kelahm/events{/privacy}","received_events_url":"https://api.github.com/users/kelahm/received_events","type":"User","site_admin":false},"body":"No except block for the try block. ","created_at":"2016-04-01T17:16:53Z","updated_at":"2016-04-01T17:16:53Z","html_url":"https://github.com/toped/sw-testing-codereview/pull/5#discussion_r58236673","pull_request_url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/comments/58236673"},"html":{"href":"https://github.com/toped/sw-testing-codereview/pull/5#discussion_r58236673"},"pull_request":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5","id":64811930,"html_url":"https://github.com/toped/sw-testing-codereview/pull/5","diff_url":"https://github.com/toped/sw-testing-codereview/pull/5.diff","patch_url":"https://github.com/toped/sw-testing-codereview/pull/5.patch","issue_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues/5","number":5,"state":"open","locked":false,"title":"yahoostockdata commit","user":{"login":"toped","id":5192506,"avatar_url":"https://avatars.githubusercontent.com/u/5192506?v=3","gravatar_id":"","url":"https://api.github.com/users/toped","html_url":"https://github.com/toped","followers_url":"https://api.github.com/users/toped/followers","following_url":"https://api.github.com/users/toped/following{/other_user}","gists_url":"https://api.github.com/users/toped/gists{/gist_id}","starred_url":"https://api.github.com/users/toped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toped/subscriptions","organizations_url":"https://api.github.com/users/toped/orgs","repos_url":"https://api.github.com/users/toped/repos","events_url":"https://api.github.com/users/toped/events{/privacy}","received_events_url":"https://api.github.com/users/toped/received_events","type":"User","site_admin":false},"body":"please review\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/toped/sw-testing-codereview/5)\n<!-- Reviewable:end -->\n","created_at":"2016-03-31T15:41:39Z","updated_at":"2016-04-01T17:16:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53e475f930bf3c802a72e2e348aac7386e362ec5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5/commits","review_comments_url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5/comments","review_comment_url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues/5/comments","statuses_url":"https://api.github.com/repos/toped/sw-testing-codereview/statuses/6db0735b4863d1f791cb582ee65429041fc58e0c","head":{"label":"toped:yahoostockdata-package","ref":"yahoostockdata-package","sha":"6db0735b4863d1f791cb582ee65429041fc58e0c","user":{"login":"toped","id":5192506,"avatar_url":"https://avatars.githubusercontent.com/u/5192506?v=3","gravatar_id":"","url":"https://api.github.com/users/toped","html_url":"https://github.com/toped","followers_url":"https://api.github.com/users/toped/followers","following_url":"https://api.github.com/users/toped/following{/other_user}","gists_url":"https://api.github.com/users/toped/gists{/gist_id}","starred_url":"https://api.github.com/users/toped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toped/subscriptions","organizations_url":"https://api.github.com/users/toped/orgs","repos_url":"https://api.github.com/users/toped/repos","events_url":"https://api.github.com/users/toped/events{/privacy}","received_events_url":"https://api.github.com/users/toped/received_events","type":"User","site_admin":false},"repo":{"id":55160981,"name":"sw-testing-codereview","full_name":"toped/sw-testing-codereview","owner":{"login":"toped","id":5192506,"avatar_url":"https://avatars.githubusercontent.com/u/5192506?v=3","gravatar_id":"","url":"https://api.github.com/users/toped","html_url":"https://github.com/toped","followers_url":"https://api.github.com/users/toped/followers","following_url":"https://api.github.com/users/toped/following{/other_user}","gists_url":"https://api.github.com/users/toped/gists{/gist_id}","starred_url":"https://api.github.com/users/toped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toped/subscriptions","organizations_url":"https://api.github.com/users/toped/orgs","repos_url":"https://api.github.com/users/toped/repos","events_url":"https://api.github.com/users/toped/events{/privacy}","received_events_url":"https://api.github.com/users/toped/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toped/sw-testing-codereview","description":"repo for assignment 2","fork":false,"url":"https://api.github.com/repos/toped/sw-testing-codereview","forks_url":"https://api.github.com/repos/toped/sw-testing-codereview/forks","keys_url":"https://api.github.com/repos/toped/sw-testing-codereview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toped/sw-testing-codereview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toped/sw-testing-codereview/teams","hooks_url":"https://api.github.com/repos/toped/sw-testing-codereview/hooks","issue_events_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues/events{/number}","events_url":"https://api.github.com/repos/toped/sw-testing-codereview/events","assignees_url":"https://api.github.com/repos/toped/sw-testing-codereview/assignees{/user}","branches_url":"https://api.github.com/repos/toped/sw-testing-codereview/branches{/branch}","tags_url":"https://api.github.com/repos/toped/sw-testing-codereview/tags","blobs_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/refs{/sha}","trees_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toped/sw-testing-codereview/statuses/{sha}","languages_url":"https://api.github.com/repos/toped/sw-testing-codereview/languages","stargazers_url":"https://api.github.com/repos/toped/sw-testing-codereview/stargazers","contributors_url":"https://api.github.com/repos/toped/sw-testing-codereview/contributors","subscribers_url":"https://api.github.com/repos/toped/sw-testing-codereview/subscribers","subscription_url":"https://api.github.com/repos/toped/sw-testing-codereview/subscription","commits_url":"https://api.github.com/repos/toped/sw-testing-codereview/commits{/sha}","git_commits_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/commits{/sha}","comments_url":"https://api.github.com/repos/toped/sw-testing-codereview/comments{/number}","issue_comment_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues/comments{/number}","contents_url":"https://api.github.com/repos/toped/sw-testing-codereview/contents/{+path}","compare_url":"https://api.github.com/repos/toped/sw-testing-codereview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toped/sw-testing-codereview/merges","archive_url":"https://api.github.com/repos/toped/sw-testing-codereview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toped/sw-testing-codereview/downloads","issues_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues{/number}","pulls_url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls{/number}","milestones_url":"https://api.github.com/repos/toped/sw-testing-codereview/milestones{/number}","notifications_url":"https://api.github.com/repos/toped/sw-testing-codereview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toped/sw-testing-codereview/labels{/name}","releases_url":"https://api.github.com/repos/toped/sw-testing-codereview/releases{/id}","deployments_url":"https://api.github.com/repos/toped/sw-testing-codereview/deployments","created_at":"2016-03-31T15:22:10Z","updated_at":"2016-03-31T15:22:10Z","pushed_at":"2016-04-01T15:54:40Z","git_url":"git://github.com/toped/sw-testing-codereview.git","ssh_url":"git@github.com:toped/sw-testing-codereview.git","clone_url":"https://github.com/toped/sw-testing-codereview.git","svn_url":"https://github.com/toped/sw-testing-codereview","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"toped:master","ref":"master","sha":"f5166a4b8b56befa0781eb4f1b0689865298370a","user":{"login":"toped","id":5192506,"avatar_url":"https://avatars.githubusercontent.com/u/5192506?v=3","gravatar_id":"","url":"https://api.github.com/users/toped","html_url":"https://github.com/toped","followers_url":"https://api.github.com/users/toped/followers","following_url":"https://api.github.com/users/toped/following{/other_user}","gists_url":"https://api.github.com/users/toped/gists{/gist_id}","starred_url":"https://api.github.com/users/toped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toped/subscriptions","organizations_url":"https://api.github.com/users/toped/orgs","repos_url":"https://api.github.com/users/toped/repos","events_url":"https://api.github.com/users/toped/events{/privacy}","received_events_url":"https://api.github.com/users/toped/received_events","type":"User","site_admin":false},"repo":{"id":55160981,"name":"sw-testing-codereview","full_name":"toped/sw-testing-codereview","owner":{"login":"toped","id":5192506,"avatar_url":"https://avatars.githubusercontent.com/u/5192506?v=3","gravatar_id":"","url":"https://api.github.com/users/toped","html_url":"https://github.com/toped","followers_url":"https://api.github.com/users/toped/followers","following_url":"https://api.github.com/users/toped/following{/other_user}","gists_url":"https://api.github.com/users/toped/gists{/gist_id}","starred_url":"https://api.github.com/users/toped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toped/subscriptions","organizations_url":"https://api.github.com/users/toped/orgs","repos_url":"https://api.github.com/users/toped/repos","events_url":"https://api.github.com/users/toped/events{/privacy}","received_events_url":"https://api.github.com/users/toped/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toped/sw-testing-codereview","description":"repo for assignment 2","fork":false,"url":"https://api.github.com/repos/toped/sw-testing-codereview","forks_url":"https://api.github.com/repos/toped/sw-testing-codereview/forks","keys_url":"https://api.github.com/repos/toped/sw-testing-codereview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toped/sw-testing-codereview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toped/sw-testing-codereview/teams","hooks_url":"https://api.github.com/repos/toped/sw-testing-codereview/hooks","issue_events_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues/events{/number}","events_url":"https://api.github.com/repos/toped/sw-testing-codereview/events","assignees_url":"https://api.github.com/repos/toped/sw-testing-codereview/assignees{/user}","branches_url":"https://api.github.com/repos/toped/sw-testing-codereview/branches{/branch}","tags_url":"https://api.github.com/repos/toped/sw-testing-codereview/tags","blobs_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/refs{/sha}","trees_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toped/sw-testing-codereview/statuses/{sha}","languages_url":"https://api.github.com/repos/toped/sw-testing-codereview/languages","stargazers_url":"https://api.github.com/repos/toped/sw-testing-codereview/stargazers","contributors_url":"https://api.github.com/repos/toped/sw-testing-codereview/contributors","subscribers_url":"https://api.github.com/repos/toped/sw-testing-codereview/subscribers","subscription_url":"https://api.github.com/repos/toped/sw-testing-codereview/subscription","commits_url":"https://api.github.com/repos/toped/sw-testing-codereview/commits{/sha}","git_commits_url":"https://api.github.com/repos/toped/sw-testing-codereview/git/commits{/sha}","comments_url":"https://api.github.com/repos/toped/sw-testing-codereview/comments{/number}","issue_comment_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues/comments{/number}","contents_url":"https://api.github.com/repos/toped/sw-testing-codereview/contents/{+path}","compare_url":"https://api.github.com/repos/toped/sw-testing-codereview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toped/sw-testing-codereview/merges","archive_url":"https://api.github.com/repos/toped/sw-testing-codereview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toped/sw-testing-codereview/downloads","issues_url":"https://api.github.com/repos/toped/sw-testing-codereview/issues{/number}","pulls_url":"https://api.github.com/repos/toped/sw-testing-codereview/pulls{/number}","milestones_url":"https://api.github.com/repos/toped/sw-testing-codereview/milestones{/number}","notifications_url":"https://api.github.com/repos/toped/sw-testing-codereview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toped/sw-testing-codereview/labels{/name}","releases_url":"https://api.github.com/repos/toped/sw-testing-codereview/releases{/id}","deployments_url":"https://api.github.com/repos/toped/sw-testing-codereview/deployments","created_at":"2016-03-31T15:22:10Z","updated_at":"2016-03-31T15:22:10Z","pushed_at":"2016-04-01T15:54:40Z","git_url":"git://github.com/toped/sw-testing-codereview.git","ssh_url":"git@github.com:toped/sw-testing-codereview.git","clone_url":"https://github.com/toped/sw-testing-codereview.git","svn_url":"https://github.com/toped/sw-testing-codereview","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5"},"html":{"href":"https://github.com/toped/sw-testing-codereview/pull/5"},"issue":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/issues/5"},"comments":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/toped/sw-testing-codereview/statuses/6db0735b4863d1f791cb582ee65429041fc58e0c"}}}}