{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/54532510","id":54532510,"diff_hunk":"@@ -544,6 +555,95 @@ public int generation() {\n         return generation;\n     }\n \n+    @Override\n+    public synchronized void getConfigDef(final String connType, final Callback<ConfigDefInfo> callback) {","path":"connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java","position":48,"original_position":48,"commit_id":"d12c248c6f136c9f124104085c326e83f67bfd9a","original_commit_id":"d12c248c6f136c9f124104085c326e83f67bfd9a","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"These two methods don't look like they should differ between `StandaloneHerder` and `DistributedHerder`. Can we move the implementation to `AbstractHerder`?","created_at":"2016-03-01T07:52:28Z","updated_at":"2016-03-01T07:52:28Z","html_url":"https://github.com/apache/kafka/pull/964#discussion_r54532510","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/964","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/54532510"},"html":{"href":"https://github.com/apache/kafka/pull/964#discussion_r54532510"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/964"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/964","id":60479797,"html_url":"https://github.com/apache/kafka/pull/964","diff_url":"https://github.com/apache/kafka/pull/964.diff","patch_url":"https://github.com/apache/kafka/pull/964.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/964","number":964,"state":"open","locked":false,"title":"Add REST and Connector API to expose connector configuration","user":{"login":"Ishiihara","id":1189848,"avatar_url":"https://avatars.githubusercontent.com/u/1189848?v=3","gravatar_id":"","url":"https://api.github.com/users/Ishiihara","html_url":"https://github.com/Ishiihara","followers_url":"https://api.github.com/users/Ishiihara/followers","following_url":"https://api.github.com/users/Ishiihara/following{/other_user}","gists_url":"https://api.github.com/users/Ishiihara/gists{/gist_id}","starred_url":"https://api.github.com/users/Ishiihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ishiihara/subscriptions","organizations_url":"https://api.github.com/users/Ishiihara/orgs","repos_url":"https://api.github.com/users/Ishiihara/repos","events_url":"https://api.github.com/users/Ishiihara/events{/privacy}","received_events_url":"https://api.github.com/users/Ishiihara/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-24T09:33:28Z","updated_at":"2016-03-01T07:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8df56eeb3b93224ace10d2ed10c1adaf641e2b3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/964/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/964/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/964/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/d12c248c6f136c9f124104085c326e83f67bfd9a","head":{"label":"Ishiihara:expose-connector-config","ref":"expose-connector-config","sha":"d12c248c6f136c9f124104085c326e83f67bfd9a","user":{"login":"Ishiihara","id":1189848,"avatar_url":"https://avatars.githubusercontent.com/u/1189848?v=3","gravatar_id":"","url":"https://api.github.com/users/Ishiihara","html_url":"https://github.com/Ishiihara","followers_url":"https://api.github.com/users/Ishiihara/followers","following_url":"https://api.github.com/users/Ishiihara/following{/other_user}","gists_url":"https://api.github.com/users/Ishiihara/gists{/gist_id}","starred_url":"https://api.github.com/users/Ishiihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ishiihara/subscriptions","organizations_url":"https://api.github.com/users/Ishiihara/orgs","repos_url":"https://api.github.com/users/Ishiihara/repos","events_url":"https://api.github.com/users/Ishiihara/events{/privacy}","received_events_url":"https://api.github.com/users/Ishiihara/received_events","type":"User","site_admin":false},"repo":{"id":43983040,"name":"kafka","full_name":"Ishiihara/kafka","owner":{"login":"Ishiihara","id":1189848,"avatar_url":"https://avatars.githubusercontent.com/u/1189848?v=3","gravatar_id":"","url":"https://api.github.com/users/Ishiihara","html_url":"https://github.com/Ishiihara","followers_url":"https://api.github.com/users/Ishiihara/followers","following_url":"https://api.github.com/users/Ishiihara/following{/other_user}","gists_url":"https://api.github.com/users/Ishiihara/gists{/gist_id}","starred_url":"https://api.github.com/users/Ishiihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ishiihara/subscriptions","organizations_url":"https://api.github.com/users/Ishiihara/orgs","repos_url":"https://api.github.com/users/Ishiihara/repos","events_url":"https://api.github.com/users/Ishiihara/events{/privacy}","received_events_url":"https://api.github.com/users/Ishiihara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ishiihara/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/Ishiihara/kafka","forks_url":"https://api.github.com/repos/Ishiihara/kafka/forks","keys_url":"https://api.github.com/repos/Ishiihara/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ishiihara/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ishiihara/kafka/teams","hooks_url":"https://api.github.com/repos/Ishiihara/kafka/hooks","issue_events_url":"https://api.github.com/repos/Ishiihara/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/Ishiihara/kafka/events","assignees_url":"https://api.github.com/repos/Ishiihara/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/Ishiihara/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/Ishiihara/kafka/tags","blobs_url":"https://api.github.com/repos/Ishiihara/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ishiihara/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ishiihara/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ishiihara/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ishiihara/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/Ishiihara/kafka/languages","stargazers_url":"https://api.github.com/repos/Ishiihara/kafka/stargazers","contributors_url":"https://api.github.com/repos/Ishiihara/kafka/contributors","subscribers_url":"https://api.github.com/repos/Ishiihara/kafka/subscribers","subscription_url":"https://api.github.com/repos/Ishiihara/kafka/subscription","commits_url":"https://api.github.com/repos/Ishiihara/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ishiihara/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ishiihara/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ishiihara/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ishiihara/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/Ishiihara/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ishiihara/kafka/merges","archive_url":"https://api.github.com/repos/Ishiihara/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ishiihara/kafka/downloads","issues_url":"https://api.github.com/repos/Ishiihara/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/Ishiihara/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/Ishiihara/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/Ishiihara/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ishiihara/kafka/labels{/name}","releases_url":"https://api.github.com/repos/Ishiihara/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/Ishiihara/kafka/deployments","created_at":"2015-10-09T22:27:06Z","updated_at":"2016-02-14T17:22:03Z","pushed_at":"2016-02-24T09:33:04Z","git_url":"git://github.com/Ishiihara/kafka.git","ssh_url":"git@github.com:Ishiihara/kafka.git","clone_url":"https://github.com/Ishiihara/kafka.git","svn_url":"https://github.com/Ishiihara/kafka","homepage":null,"size":26393,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"f7d019ed408fa988129be9af3689bfa4878bc627","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-02-29T19:24:09Z","pushed_at":"2016-03-01T02:53:15Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":35086,"stargazers_count":2685,"watchers_count":2685,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1624,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":139,"forks":1624,"open_issues":139,"watchers":2685,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/964"},"html":{"href":"https://github.com/apache/kafka/pull/964"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/964"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/964/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/964/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/964/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/d12c248c6f136c9f124104085c326e83f67bfd9a"}}}}