{"action":"created","issue":{"url":"https://api.github.com/repos/driftyco/ionic-native/issues/646","repository_url":"https://api.github.com/repos/driftyco/ionic-native","labels_url":"https://api.github.com/repos/driftyco/ionic-native/issues/646/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic-native/issues/646/comments","events_url":"https://api.github.com/repos/driftyco/ionic-native/issues/646/events","html_url":"https://github.com/driftyco/ionic-native/pull/646","id":181301120,"number":646,"title":"fix Google maps setPadding not working issue","user":{"login":"ziggyJ","id":180623,"avatar_url":"https://avatars.githubusercontent.com/u/180623?v=3","gravatar_id":"","url":"https://api.github.com/users/ziggyJ","html_url":"https://github.com/ziggyJ","followers_url":"https://api.github.com/users/ziggyJ/followers","following_url":"https://api.github.com/users/ziggyJ/following{/other_user}","gists_url":"https://api.github.com/users/ziggyJ/gists{/gist_id}","starred_url":"https://api.github.com/users/ziggyJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziggyJ/subscriptions","organizations_url":"https://api.github.com/users/ziggyJ/orgs","repos_url":"https://api.github.com/users/ziggyJ/repos","events_url":"https://api.github.com/users/ziggyJ/events{/privacy}","received_events_url":"https://api.github.com/users/ziggyJ/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-06T00:52:49Z","updated_at":"2016-10-06T01:49:40Z","closed_at":"2016-10-06T01:46:12Z","pull_request":{"url":"https://api.github.com/repos/driftyco/ionic-native/pulls/646","html_url":"https://github.com/driftyco/ionic-native/pull/646","diff_url":"https://github.com/driftyco/ionic-native/pull/646.diff","patch_url":"https://github.com/driftyco/ionic-native/pull/646.patch"},"body":"fix the issue when  sync Cordova function calls add two extra null value on the end of the args that break a lot of Cordova plugins including Google maps setPadding function\r\n\r\nThat is my simple fix, just add resolve and reject to the args if either of them is not null.\r\nBut it seems that I am touching some core functions, I am not sure if it does not break other functions."},"comment":{"url":"https://api.github.com/repos/driftyco/ionic-native/issues/comments/251847671","html_url":"https://github.com/driftyco/ionic-native/pull/646#issuecomment-251847671","issue_url":"https://api.github.com/repos/driftyco/ionic-native/issues/646","id":251847671,"user":{"login":"ihadeed","id":13794420,"avatar_url":"https://avatars.githubusercontent.com/u/13794420?v=3","gravatar_id":"","url":"https://api.github.com/users/ihadeed","html_url":"https://github.com/ihadeed","followers_url":"https://api.github.com/users/ihadeed/followers","following_url":"https://api.github.com/users/ihadeed/following{/other_user}","gists_url":"https://api.github.com/users/ihadeed/gists{/gist_id}","starred_url":"https://api.github.com/users/ihadeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihadeed/subscriptions","organizations_url":"https://api.github.com/users/ihadeed/orgs","repos_url":"https://api.github.com/users/ihadeed/repos","events_url":"https://api.github.com/users/ihadeed/events{/privacy}","received_events_url":"https://api.github.com/users/ihadeed/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T01:49:40Z","updated_at":"2016-10-06T01:49:40Z","body":"Actually, we can do something like this instead:\r\n```\r\nif (!opts.sync) {\r\n  args.push(resolve);\r\n  args.push(reject);\r\n}\r\n```"}}
{"actor":{"display_login":"ihadeed"}}