{"action":"created","issue":{"url":"https://api.github.com/repos/neomutt/neomutt/issues/58","repository_url":"https://api.github.com/repos/neomutt/neomutt","labels_url":"https://api.github.com/repos/neomutt/neomutt/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/neomutt/neomutt/issues/58/comments","events_url":"https://api.github.com/repos/neomutt/neomutt/issues/58/events","html_url":"https://github.com/neomutt/neomutt/issues/58","id":161370896,"number":58,"title":"Clean up configure script","user":{"login":"darnir","id":1660085,"avatar_url":"https://avatars.githubusercontent.com/u/1660085?v=3","gravatar_id":"","url":"https://api.github.com/users/darnir","html_url":"https://github.com/darnir","followers_url":"https://api.github.com/users/darnir/followers","following_url":"https://api.github.com/users/darnir/following{/other_user}","gists_url":"https://api.github.com/users/darnir/gists{/gist_id}","starred_url":"https://api.github.com/users/darnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darnir/subscriptions","organizations_url":"https://api.github.com/users/darnir/orgs","repos_url":"https://api.github.com/users/darnir/repos","events_url":"https://api.github.com/users/darnir/events{/privacy}","received_events_url":"https://api.github.com/users/darnir/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neomutt/neomutt/labels/discussion","name":"discussion","color":"9f00bf"},{"url":"https://api.github.com/repos/neomutt/neomutt/labels/enhancement","name":"enhancement","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"darnir","id":1660085,"avatar_url":"https://avatars.githubusercontent.com/u/1660085?v=3","gravatar_id":"","url":"https://api.github.com/users/darnir","html_url":"https://github.com/darnir","followers_url":"https://api.github.com/users/darnir/followers","following_url":"https://api.github.com/users/darnir/following{/other_user}","gists_url":"https://api.github.com/users/darnir/gists{/gist_id}","starred_url":"https://api.github.com/users/darnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darnir/subscriptions","organizations_url":"https://api.github.com/users/darnir/orgs","repos_url":"https://api.github.com/users/darnir/repos","events_url":"https://api.github.com/users/darnir/events{/privacy}","received_events_url":"https://api.github.com/users/darnir/received_events","type":"User","site_admin":false},"assignees":[{"login":"darnir","id":1660085,"avatar_url":"https://avatars.githubusercontent.com/u/1660085?v=3","gravatar_id":"","url":"https://api.github.com/users/darnir","html_url":"https://github.com/darnir","followers_url":"https://api.github.com/users/darnir/followers","following_url":"https://api.github.com/users/darnir/following{/other_user}","gists_url":"https://api.github.com/users/darnir/gists{/gist_id}","starred_url":"https://api.github.com/users/darnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darnir/subscriptions","organizations_url":"https://api.github.com/users/darnir/orgs","repos_url":"https://api.github.com/users/darnir/repos","events_url":"https://api.github.com/users/darnir/events{/privacy}","received_events_url":"https://api.github.com/users/darnir/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2016-06-21T07:54:48Z","updated_at":"2016-07-21T13:15:03Z","closed_at":null,"body":"Taking a look at the build system, I saw lots of issues with the configure.ac script that can be cleaned up.\r\n\r\n1. The various configure options often use the wrong terminology. --enable options should enable features in the codebase while --with options should enable support using 3rd party libraries. Hence, it should be --with-gpgme and --with-pgp.\r\n2. There is no need to test for `x$enableval = yes` in the AC_ARG_ENABLE macros. In the 3rd argument, you can simply set the variable to the value of $enableval. Take a look at this configure script for ideas: https://github.com/rockdaboot/wget2/blob/master/configure.ac\r\nTim has spent considerable time making sure the configure.ac script is perfect and we've had enough long discussions about the entire autotools tree.\r\n3. We can have configure print a summary of build options at the end. This is often useful debug information, especially for devs. Again, take a look at the above cofngure script for what it does.\r\n\r\nI don't mind working on these points, but I'll do it only after discussion and if I know that the patches will be accepted. It would be nice to upstream these some of these patches as well for the cases where they are similar."},"comment":{"url":"https://api.github.com/repos/neomutt/neomutt/issues/comments/234249296","html_url":"https://github.com/neomutt/neomutt/issues/58#issuecomment-234249296","issue_url":"https://api.github.com/repos/neomutt/neomutt/issues/58","id":234249296,"user":{"login":"flatcap","id":76760,"avatar_url":"https://avatars.githubusercontent.com/u/76760?v=3","gravatar_id":"","url":"https://api.github.com/users/flatcap","html_url":"https://github.com/flatcap","followers_url":"https://api.github.com/users/flatcap/followers","following_url":"https://api.github.com/users/flatcap/following{/other_user}","gists_url":"https://api.github.com/users/flatcap/gists{/gist_id}","starred_url":"https://api.github.com/users/flatcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatcap/subscriptions","organizations_url":"https://api.github.com/users/flatcap/orgs","repos_url":"https://api.github.com/users/flatcap/repos","events_url":"https://api.github.com/users/flatcap/events{/privacy}","received_events_url":"https://api.github.com/users/flatcap/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T13:15:03Z","updated_at":"2016-07-21T13:15:03Z","body":"If you're happy the configure changes are solid, then please commit each one to the respective feature branch.  Any global changes, e.g. options summary, please create a devel branch from neomutt. "}}
{"actor":{"display_login":"flatcap"}}