{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/84942341","pull_request_review_id":5687791,"id":84942341,"diff_hunk":"@@ -1,6 +1,9 @@\n {\n   \"dependencies\": {\n-    \"System.Runtime\": \"4.4.0-beta-24625-01\"\n+    \"System.Runtime\": \"4.4.0-beta-24625-01\",\n+    \"System.Runtime.Extensions\": \"4.4.0-beta-24625-01\",\n+    \"System.Security.Principal\": \"4.4.0-beta-24625-01\",\n+    \"System.Threading\": \"4.4.0-beta-24625-01\"","path":"src/System.Threading.Thread/ref/project.json","position":7,"original_position":7,"commit_id":"bc732e0fecc3add26ee432ac6a3b877704a76981","original_commit_id":"bc732e0fecc3add26ee432ac6a3b877704a76981","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"> \"System.Threading\": \"4.4.0-beta-24625-01\" [](start = 3, length = 42)\r\n\r\n@ericstj I believe this won't actually introduce a dependency cycle because if I'm correct, System.Threading depends on System.Threading.Tasks and not on Threading.Thread, but I'm just curious if we have a way of catching dependency cycles with our CI, or if the only way to catch them is when we actually try to update the corefx dependencies that contain the cycle?","created_at":"2016-10-25T16:19:41Z","updated_at":"2016-10-25T16:19:41Z","html_url":"https://github.com/dotnet/corefx/pull/12827#discussion_r84942341","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/12827","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/84942341"},"html":{"href":"https://github.com/dotnet/corefx/pull/12827#discussion_r84942341"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12827"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/12827","id":90127769,"html_url":"https://github.com/dotnet/corefx/pull/12827","diff_url":"https://github.com/dotnet/corefx/pull/12827.diff","patch_url":"https://github.com/dotnet/corefx/pull/12827.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/12827","number":12827,"state":"open","locked":false,"title":"Expose some Thread members","user":{"login":"kouvel","id":13499639,"avatar_url":"https://avatars.githubusercontent.com/u/13499639?v=3","gravatar_id":"","url":"https://api.github.com/users/kouvel","html_url":"https://github.com/kouvel","followers_url":"https://api.github.com/users/kouvel/followers","following_url":"https://api.github.com/users/kouvel/following{/other_user}","gists_url":"https://api.github.com/users/kouvel/gists{/gist_id}","starred_url":"https://api.github.com/users/kouvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kouvel/subscriptions","organizations_url":"https://api.github.com/users/kouvel/orgs","repos_url":"https://api.github.com/users/kouvel/repos","events_url":"https://api.github.com/users/kouvel/events{/privacy}","received_events_url":"https://api.github.com/users/kouvel/received_events","type":"User","site_admin":false},"body":"- Implemented Thread type in CoreFX, so with this, Thread will no longer be type-forwarded to the runtime. It instead forwards selectively to the runtime through a RuntimeThread instance for functionality is currently strongly tied with the runtime. Some of this functionality may further be moved to CoreFX later.\r\n- S.Threading.Thread compiles against S.Private.CoreLib of the runtime for access to RuntimeThread, and due to type conflicts between CoreLib and CoreFX assemblies, uses project references to the CoreFX implementation projects and aliases where necessary to reference the intended public type\r\n\r\nRelated to #11632, #11638","created_at":"2016-10-20T03:30:27Z","updated_at":"2016-10-25T16:19:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a65c94c8f4dbfb0b91338cc8c4c2f60ebad66d9","assignee":{"login":"kouvel","id":13499639,"avatar_url":"https://avatars.githubusercontent.com/u/13499639?v=3","gravatar_id":"","url":"https://api.github.com/users/kouvel","html_url":"https://github.com/kouvel","followers_url":"https://api.github.com/users/kouvel/followers","following_url":"https://api.github.com/users/kouvel/following{/other_user}","gists_url":"https://api.github.com/users/kouvel/gists{/gist_id}","starred_url":"https://api.github.com/users/kouvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kouvel/subscriptions","organizations_url":"https://api.github.com/users/kouvel/orgs","repos_url":"https://api.github.com/users/kouvel/repos","events_url":"https://api.github.com/users/kouvel/events{/privacy}","received_events_url":"https://api.github.com/users/kouvel/received_events","type":"User","site_admin":false},"assignees":[{"login":"kouvel","id":13499639,"avatar_url":"https://avatars.githubusercontent.com/u/13499639?v=3","gravatar_id":"","url":"https://api.github.com/users/kouvel","html_url":"https://github.com/kouvel","followers_url":"https://api.github.com/users/kouvel/followers","following_url":"https://api.github.com/users/kouvel/following{/other_user}","gists_url":"https://api.github.com/users/kouvel/gists{/gist_id}","starred_url":"https://api.github.com/users/kouvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kouvel/subscriptions","organizations_url":"https://api.github.com/users/kouvel/orgs","repos_url":"https://api.github.com/users/kouvel/repos","events_url":"https://api.github.com/users/kouvel/events{/privacy}","received_events_url":"https://api.github.com/users/kouvel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/12827/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/12827/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12827/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/bc732e0fecc3add26ee432ac6a3b877704a76981","head":{"label":"kouvel:ApiThread","ref":"ApiThread","sha":"bc732e0fecc3add26ee432ac6a3b877704a76981","user":{"login":"kouvel","id":13499639,"avatar_url":"https://avatars.githubusercontent.com/u/13499639?v=3","gravatar_id":"","url":"https://api.github.com/users/kouvel","html_url":"https://github.com/kouvel","followers_url":"https://api.github.com/users/kouvel/followers","following_url":"https://api.github.com/users/kouvel/following{/other_user}","gists_url":"https://api.github.com/users/kouvel/gists{/gist_id}","starred_url":"https://api.github.com/users/kouvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kouvel/subscriptions","organizations_url":"https://api.github.com/users/kouvel/orgs","repos_url":"https://api.github.com/users/kouvel/repos","events_url":"https://api.github.com/users/kouvel/events{/privacy}","received_events_url":"https://api.github.com/users/kouvel/received_events","type":"User","site_admin":false},"repo":{"id":39798901,"name":"corefx","full_name":"kouvel/corefx","owner":{"login":"kouvel","id":13499639,"avatar_url":"https://avatars.githubusercontent.com/u/13499639?v=3","gravatar_id":"","url":"https://api.github.com/users/kouvel","html_url":"https://github.com/kouvel","followers_url":"https://api.github.com/users/kouvel/followers","following_url":"https://api.github.com/users/kouvel/following{/other_user}","gists_url":"https://api.github.com/users/kouvel/gists{/gist_id}","starred_url":"https://api.github.com/users/kouvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kouvel/subscriptions","organizations_url":"https://api.github.com/users/kouvel/orgs","repos_url":"https://api.github.com/users/kouvel/repos","events_url":"https://api.github.com/users/kouvel/events{/privacy}","received_events_url":"https://api.github.com/users/kouvel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kouvel/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/kouvel/corefx","forks_url":"https://api.github.com/repos/kouvel/corefx/forks","keys_url":"https://api.github.com/repos/kouvel/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kouvel/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kouvel/corefx/teams","hooks_url":"https://api.github.com/repos/kouvel/corefx/hooks","issue_events_url":"https://api.github.com/repos/kouvel/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/kouvel/corefx/events","assignees_url":"https://api.github.com/repos/kouvel/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/kouvel/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/kouvel/corefx/tags","blobs_url":"https://api.github.com/repos/kouvel/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kouvel/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kouvel/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kouvel/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kouvel/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/kouvel/corefx/languages","stargazers_url":"https://api.github.com/repos/kouvel/corefx/stargazers","contributors_url":"https://api.github.com/repos/kouvel/corefx/contributors","subscribers_url":"https://api.github.com/repos/kouvel/corefx/subscribers","subscription_url":"https://api.github.com/repos/kouvel/corefx/subscription","commits_url":"https://api.github.com/repos/kouvel/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kouvel/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kouvel/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kouvel/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kouvel/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/kouvel/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kouvel/corefx/merges","archive_url":"https://api.github.com/repos/kouvel/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kouvel/corefx/downloads","issues_url":"https://api.github.com/repos/kouvel/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/kouvel/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/kouvel/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/kouvel/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kouvel/corefx/labels{/name}","releases_url":"https://api.github.com/repos/kouvel/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/kouvel/corefx/deployments","created_at":"2015-07-27T21:30:34Z","updated_at":"2016-01-14T21:16:37Z","pushed_at":"2016-10-25T13:40:28Z","git_url":"git://github.com/kouvel/corefx.git","ssh_url":"git@github.com:kouvel/corefx.git","clone_url":"https://github.com/kouvel/corefx.git","svn_url":"https://github.com/kouvel/corefx","homepage":"http://dotnet.github.io/core/","size":107331,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1d8aac30cb9d5ba1814fbce1da6fecad5a8dbdaf","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-10-25T12:39:41Z","pushed_at":"2016-10-25T16:17:48Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":155195,"stargazers_count":10690,"watchers_count":10690,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2689,"mirror_url":null,"open_issues_count":1474,"forks":2689,"open_issues":1474,"watchers":10690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12827"},"html":{"href":"https://github.com/dotnet/corefx/pull/12827"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12827"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12827/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12827/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12827/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/bc732e0fecc3add26ee432ac6a3b877704a76981"}}}}
{"actor":{"display_login":"joperezr"}}