{"push_id":1125107227,"size":2,"distinct_size":2,"ref":"refs/heads/pmattis/batch-builder","head":"12c4d0705cbb011319733c159ca841b2a46c3517","before":"68ff06f4534bf240acc76ca510e1258cd7d32f14","commits":[{"sha":"b59c91eecca0984d63ee51ebc968dc122232d9de","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"storage: avoid tracking unique spans in 1pc txns\n\nIn 1pc txns, the TxnCoordSender knows if the spans are distinct. Pass\nthat information along in `BatchRequest.Header.DistinctSpans`.\n\nNo effect on performance, but a decent reduction in allocations and this\nwill be used in a future optimization to batches.\n\nname                           old allocs/op  new allocs/op  delta\nTrackChoices1_Cockroach-8           374 ± 0%       373 ± 0%    ~             (p=1.000 n=5+5)\nTrackChoices10_Cockroach-8          129 ± 0%       125 ± 0%  -3.10%          (p=0.008 n=5+5)\nTrackChoices100_Cockroach-8         101 ± 0%        97 ± 0%  -3.96%          (p=0.008 n=5+5)\nTrackChoices1000_Cockroach-8       98.0 ± 0%      94.0 ± 0%  -4.08%          (p=0.008 n=5+5)\nInsertDistinct1_Cockroach-8       1.75k ± 0%     1.70k ± 0%  -2.89%          (p=0.008 n=5+5)\nInsertDistinct10_Cockroach-8      1.84k ± 0%     1.78k ± 0%  -3.00%          (p=0.016 n=5+4)\nInsertDistinct100_Cockroach-8     3.18k ± 0%     3.13k ± 0%  -1.63%          (p=0.008 n=5+5)\nKVInsert1_SQL-8                     275 ± 0%       275 ± 0%    ~     (all samples are equal)\nKVInsert10_SQL-8                    617 ± 0%       596 ± 0%    ~             (p=0.079 n=4+5)\nKVInsert100_SQL-8                 3.72k ± 0%     3.52k ± 0%  -5.56%          (p=0.008 n=5+5)\nKVInsert1000_SQL-8                34.7k ± 0%     32.6k ± 0%  -5.85%          (p=0.008 n=5+5)\nKVInsert10000_SQL-8                362k ± 0%      338k ± 0%  -6.71%          (p=0.008 n=5+5)","distinct":true,"url":"https://api.github.com/repos/petermattis/cockroach/commits/b59c91eecca0984d63ee51ebc968dc122232d9de"},{"sha":"12c4d0705cbb011319733c159ca841b2a46c3517","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"storage/engine: add rocksDBBatchBuilder\n\nBuilding batches in Go is significantly faster than performing a cgo\ncall: ~55ns/op vs ~400ns/op. The Go batches do not support indexing, so\nflush to a C++ batch whenever a read of the batch is being performed. I\nexperimented with adding indexing to the Go side, but all attempts were\nsignificantly slower than flushing to C++.\n\nAdded an `engine.Batch` interface with a `FreezeFlushes` method which is\ncalled to avoid flushing a batch in order to write the raft applied\nindex and mvcc stats.\n\nFixes #6289.\nFixes #6739.","distinct":true,"url":"https://api.github.com/repos/petermattis/cockroach/commits/12c4d0705cbb011319733c159ca841b2a46c3517"}]}
{"actor":{"display_login":"petermattis"}}