{"action":"created","comment":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments/78621083","id":78621083,"diff_hunk":"@@ -39,6 +43,114 @@ def __init__(self, *args, **kwargs):\n \n         Tester.__init__(self, *args, **kwargs)\n \n+    def prepare(self, num_nodes=2):\n+        cluster = self.cluster\n+\n+        # Forcing cluster version on purpose\n+        cluster.set_install_dir(version=\"1.2.16\")\n+        if \"memtable_allocation_type\" in cluster._config_options:\n+            cluster._config_options.__delitem__(\"memtable_allocation_type\")\n+        cluster.populate(num_nodes).start()\n+\n+        return cluster.nodelist()\n+\n+    def connect_via_thrift(self, node):\n+        host, port = node.network_interfaces['thrift']\n+        client = get_thrift_client(host, port)\n+        client.transport.open()\n+        return client\n+\n+    def create_keyspace(self, client):\n+        ksdef = KsDef()\n+        ksdef.name = 'test'\n+        ksdef.strategy_class = 'SimpleStrategy'\n+        ksdef.strategy_options = {'replication_factor': '2'}\n+        ksdef.durable_writes = True\n+        ksdef.cf_defs = []\n+\n+        client.system_add_keyspace(ksdef)\n+\n+    def create_super_column_family(self, client, comparator_type, subcomparator_type, key_validation_class, default_validation_class):\n+        cfdef = CfDef()\n+        cfdef.keyspace = 'test'\n+        cfdef.name = 'sc_test'\n+        cfdef.column_type = 'Super'\n+        cfdef.comparator_type = comparator_type\n+        cfdef.subcomparator_type = subcomparator_type\n+        cfdef.key_validation_class = key_validation_class\n+        cfdef.default_validation_class = default_validation_class\n+        cfdef.caching = 'rows_only'\n+\n+        client.system_add_column_family(cfdef)\n+\n+    def add_super_column_data(self, client):\n+        for i in range(2):\n+            supercol_name = 'sc{}'.format(i)\n+            for j in range(2):\n+                col_name = 'c{}'.format(j)\n+                column = Column(name=col_name, value='v', timestamp=100)\n+                client.batch_mutate(\n+                    {'k0': {'sc_test': [Mutation(ColumnOrSuperColumn(super_column=SuperColumn(supercol_name, [column])))]}},\n+                    ThriftConsistencyLevel.ONE)\n+\n+    def restart_nodes(self, nodelist):\n+        for node in nodelist:\n+            node.flush()\n+            time.sleep(.5)\n+            node.stop(wait_other_notice=True)\n+            self.set_node_to_current_version(node)\n+            node.start(wait_other_notice=True, wait_for_binary_proto=True)\n+            time.sleep(.5)","path":"upgrade_supercolumns_test.py","position":74,"original_position":74,"commit_id":"ee64bc44a7295ec3b10bece8d8aebd330e6317f2","original_commit_id":"ee64bc44a7295ec3b10bece8d8aebd330e6317f2","user":{"login":"ptnapoleon","id":3408144,"avatar_url":"https://avatars.githubusercontent.com/u/3408144?v=3","gravatar_id":"","url":"https://api.github.com/users/ptnapoleon","html_url":"https://github.com/ptnapoleon","followers_url":"https://api.github.com/users/ptnapoleon/followers","following_url":"https://api.github.com/users/ptnapoleon/following{/other_user}","gists_url":"https://api.github.com/users/ptnapoleon/gists{/gist_id}","starred_url":"https://api.github.com/users/ptnapoleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptnapoleon/subscriptions","organizations_url":"https://api.github.com/users/ptnapoleon/orgs","repos_url":"https://api.github.com/users/ptnapoleon/repos","events_url":"https://api.github.com/users/ptnapoleon/events{/privacy}","received_events_url":"https://api.github.com/users/ptnapoleon/received_events","type":"User","site_admin":false},"body":"These `.5` sleeps are either unnecessary, or not long enough","created_at":"2016-09-13T18:51:10Z","updated_at":"2016-09-13T18:51:10Z","html_url":"https://github.com/riptano/cassandra-dtest/pull/1309#discussion_r78621083","pull_request_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309","_links":{"self":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments/78621083"},"html":{"href":"https://github.com/riptano/cassandra-dtest/pull/1309#discussion_r78621083"},"pull_request":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309"}}},"pull_request":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309","id":85053983,"html_url":"https://github.com/riptano/cassandra-dtest/pull/1309","diff_url":"https://github.com/riptano/cassandra-dtest/pull/1309.diff","patch_url":"https://github.com/riptano/cassandra-dtest/pull/1309.patch","issue_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1309","number":1309,"state":"open","locked":false,"title":"skeleton for additional supercolumn coverage","user":{"login":"smccarthy788","id":6601281,"avatar_url":"https://avatars.githubusercontent.com/u/6601281?v=3","gravatar_id":"","url":"https://api.github.com/users/smccarthy788","html_url":"https://github.com/smccarthy788","followers_url":"https://api.github.com/users/smccarthy788/followers","following_url":"https://api.github.com/users/smccarthy788/following{/other_user}","gists_url":"https://api.github.com/users/smccarthy788/gists{/gist_id}","starred_url":"https://api.github.com/users/smccarthy788/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smccarthy788/subscriptions","organizations_url":"https://api.github.com/users/smccarthy788/orgs","repos_url":"https://api.github.com/users/smccarthy788/repos","events_url":"https://api.github.com/users/smccarthy788/events{/privacy}","received_events_url":"https://api.github.com/users/smccarthy788/received_events","type":"User","site_admin":false},"body":"@ptnapoleon, @mambocab, @knifewine: I'm opening this PR to have a place to discuss implementing additional super column coverage.\r\n\r\nIn short, we’re adding coverage for:\r\n- Reading super columns in all supported C* versions via thrift & CQL\r\n- Upgrading clusters with pre-existing super columns through every version\r\n\r\nI think the best way to do this is some kind of `upgrade_through_versions` test:\r\n- Create supercolumns\r\n- Upgrade the cluster through versions:\r\n    - Verify & modify data at each version\r\n\r\nInitially I tried to implement this in `upgrade_through_versions_test.py`, but I was unsure how to start with a 1.2 C* cluster.\r\n\r\nThis follows the conventions established in `upgrade_supercolumns_test.py`, but is blocked on [CASSANDRA-12616](https://issues.apache.org/jira/browse/CASSANDRA-12616)","created_at":"2016-09-13T14:01:37Z","updated_at":"2016-09-13T18:51:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f479ef3b6c7ab75a2bff7ab98713a0359c76b48d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309/commits","review_comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309/comments","review_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1309/comments","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/ee64bc44a7295ec3b10bece8d8aebd330e6317f2","head":{"label":"riptano:supercolumn-coverage","ref":"supercolumn-coverage","sha":"ee64bc44a7295ec3b10bece8d8aebd330e6317f2","user":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"repo":{"id":2674774,"name":"cassandra-dtest","full_name":"riptano/cassandra-dtest","owner":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riptano/cassandra-dtest","description":"Cassandra Distributed Tests","fork":false,"url":"https://api.github.com/repos/riptano/cassandra-dtest","forks_url":"https://api.github.com/repos/riptano/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/riptano/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riptano/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riptano/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/riptano/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/riptano/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/riptano/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/riptano/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/riptano/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/riptano/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/riptano/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/riptano/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/riptano/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riptano/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/riptano/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riptano/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/riptano/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/riptano/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riptano/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/riptano/cassandra-dtest/releases{/id}","deployments_url":"https://api.github.com/repos/riptano/cassandra-dtest/deployments","created_at":"2011-10-30T11:15:44Z","updated_at":"2016-08-22T00:49:30Z","pushed_at":"2016-09-13T18:42:44Z","git_url":"git://github.com/riptano/cassandra-dtest.git","ssh_url":"git@github.com:riptano/cassandra-dtest.git","clone_url":"https://github.com/riptano/cassandra-dtest.git","svn_url":"https://github.com/riptano/cassandra-dtest","homepage":"","size":18018,"stargazers_count":78,"watchers_count":78,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":55,"forks":71,"open_issues":55,"watchers":78,"default_branch":"master"}},"base":{"label":"riptano:master","ref":"master","sha":"069ba812298281d6663b4679c90c301276eeb157","user":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"repo":{"id":2674774,"name":"cassandra-dtest","full_name":"riptano/cassandra-dtest","owner":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riptano/cassandra-dtest","description":"Cassandra Distributed Tests","fork":false,"url":"https://api.github.com/repos/riptano/cassandra-dtest","forks_url":"https://api.github.com/repos/riptano/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/riptano/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riptano/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riptano/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/riptano/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/riptano/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/riptano/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/riptano/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/riptano/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/riptano/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/riptano/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/riptano/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/riptano/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riptano/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/riptano/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riptano/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/riptano/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/riptano/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riptano/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/riptano/cassandra-dtest/releases{/id}","deployments_url":"https://api.github.com/repos/riptano/cassandra-dtest/deployments","created_at":"2011-10-30T11:15:44Z","updated_at":"2016-08-22T00:49:30Z","pushed_at":"2016-09-13T18:42:44Z","git_url":"git://github.com/riptano/cassandra-dtest.git","ssh_url":"git@github.com:riptano/cassandra-dtest.git","clone_url":"https://github.com/riptano/cassandra-dtest.git","svn_url":"https://github.com/riptano/cassandra-dtest","homepage":"","size":18018,"stargazers_count":78,"watchers_count":78,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":55,"forks":71,"open_issues":55,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309"},"html":{"href":"https://github.com/riptano/cassandra-dtest/pull/1309"},"issue":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1309"},"comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/1309/comments"},"review_comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309/comments"},"review_comment":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/1309/commits"},"statuses":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/ee64bc44a7295ec3b10bece8d8aebd330e6317f2"}}}}
{"actor":{"display_login":"ptnapoleon"}}