{"action":"created","issue":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1523","repository_url":"https://api.github.com/repos/PCSX2/pcsx2","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1523/labels{/name}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1523/comments","events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1523/events","html_url":"https://github.com/PCSX2/pcsx2/pull/1523","id":171832067,"number":1523,"title":"Make settings dialog usable with 1024x768 resolution","user":{"login":"nE0sIghT","id":3389586,"avatar_url":"https://avatars.githubusercontent.com/u/3389586?v=3","gravatar_id":"","url":"https://api.github.com/users/nE0sIghT","html_url":"https://github.com/nE0sIghT","followers_url":"https://api.github.com/users/nE0sIghT/followers","following_url":"https://api.github.com/users/nE0sIghT/following{/other_user}","gists_url":"https://api.github.com/users/nE0sIghT/gists{/gist_id}","starred_url":"https://api.github.com/users/nE0sIghT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nE0sIghT/subscriptions","organizations_url":"https://api.github.com/users/nE0sIghT/orgs","repos_url":"https://api.github.com/users/nE0sIghT/repos","events_url":"https://api.github.com/users/nE0sIghT/events{/privacy}","received_events_url":"https://api.github.com/users/nE0sIghT/received_events","type":"User","site_admin":false},"labels":[{"id":71791771,"url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":118765728,"url":"https://api.github.com/repos/PCSX2/pcsx2/labels/GUI/WX","name":"GUI/WX","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"turtleli","id":10976277,"avatar_url":"https://avatars.githubusercontent.com/u/10976277?v=3","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false},"assignees":[{"login":"turtleli","id":10976277,"avatar_url":"https://avatars.githubusercontent.com/u/10976277?v=3","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false}],"milestone":null,"comments":37,"created_at":"2016-08-18T07:07:10Z","updated_at":"2016-11-10T17:50:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1523","html_url":"https://github.com/PCSX2/pcsx2/pull/1523","diff_url":"https://github.com/PCSX2/pcsx2/pull/1523.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1523.patch"},"body":"Hi,\n\nCurrently PCSX2 settings dialog is not usable with 1024x768 resolution because Speedhacks and Gamefixes panels exceed 768 pixels height.\n\nWhile Gamefixes can be split in 2 columns, it's hard to pack Speedhacks panel properly to fit both 1024 pixel width and 768 pixel height.\n\nThis PR:\n1. Removes redundant vertical line and whitespace of slider messages from Speedhacks panel.\n2. Makes pxCheckboxes height smaller to remove redundant whitespace from Speedhacks and Gamefixes panels.\n3. Adds scrollbars to Speedhacks and Gamefixes panels.\n\nThis issue was originally [reported at Gentoo bugzilla](https://bugs.gentoo.org/show_bug.cgi?id=591316).\n"},"comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments/259759027","html_url":"https://github.com/PCSX2/pcsx2/pull/1523#issuecomment-259759027","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1523","id":259759027,"user":{"login":"gregory38","id":1569559,"avatar_url":"https://avatars.githubusercontent.com/u/1569559?v=3","gravatar_id":"","url":"https://api.github.com/users/gregory38","html_url":"https://github.com/gregory38","followers_url":"https://api.github.com/users/gregory38/followers","following_url":"https://api.github.com/users/gregory38/following{/other_user}","gists_url":"https://api.github.com/users/gregory38/gists{/gist_id}","starred_url":"https://api.github.com/users/gregory38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregory38/subscriptions","organizations_url":"https://api.github.com/users/gregory38/orgs","repos_url":"https://api.github.com/users/gregory38/repos","events_url":"https://api.github.com/users/gregory38/events{/privacy}","received_events_url":"https://api.github.com/users/gregory38/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T17:50:29Z","updated_at":"2016-11-10T17:50:29Z","body":"```\r\nThe height on the EE cyclerate and VU stealing can't be reduced though, otherwise the messages might be truncated on Windows (I don't remember whether it affects Linux too).\r\n```\r\n156f573842d730520a490b0d7d83cc50833e8f4e maybe 4 could work. Otherwise maybe reduce 1 size on the font. Hum, Hum. I don't know if you already notice it but Jake rewrote a couple of wx object behavior (px code). For example pxStaticText, maybe it doesn't work well with long line.\r\n```\r\n// This class's purpose is to overcome two fundamental annoyances in wxWidgets design:\r\n//\r\n//   * An inability to wrap text to conform to a fitted window (a limitation imposed by\r\n//     wxWidgets inability to fit individual directions, ie fit widths and then fit heights,\r\n//     which would allow a textbox to wrap text to a sizer-determined width, and then grow\r\n//     the sizers vertically to fit the calculated text-wrapped height).\r\n//\r\n//   * Textbox alignment requires aligning both the textbox contents, and aligning the text\r\n//     control within it's containing sizer.  If both alignment flags do not match the result\r\n//     is typically undesirable.\r\n//\r\n```\r\nTypically it used by \r\n```\r\npcsx2/gui/Panels/SpeedhacksPanel.cpp:\tm_msg_eecycle = new pxStaticHeading( m_eeSliderPanel );\r\npcsx2/gui/Panels/SpeedhacksPanel.cpp:\tm_msg_vustealer = new pxStaticHeading(m_vuSliderPanel);\r\npcsx2/gui/Dialogs/FirstTimeWizard.cpp:\tm_page_bios\t\t+= new pxStaticHeading( &m_page_bios,\r\n```\r\nAnd I'm pretty sure those 3 strings suffers of the cut off annoyance."}}
{"actor":{"display_login":"gregory38"}}