{"action":"created","issue":{"url":"https://api.github.com/repos/hw-cookbooks/chef-server-populator/issues/74","repository_url":"https://api.github.com/repos/hw-cookbooks/chef-server-populator","labels_url":"https://api.github.com/repos/hw-cookbooks/chef-server-populator/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/hw-cookbooks/chef-server-populator/issues/74/comments","events_url":"https://api.github.com/repos/hw-cookbooks/chef-server-populator/issues/74/events","html_url":"https://github.com/hw-cookbooks/chef-server-populator/issues/74","id":154277630,"number":74,"title":"Broken tests following merge of #69","user":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars.githubusercontent.com/u/148017?v=3","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-11T15:49:41Z","updated_at":"2016-05-11T15:50:14Z","closed_at":null,"body":"I broke the build by merging #69. I selfishly wanted to see Nellie run the tests. Unfortunately I think the build failed before it could report that the following unit tests are broken:\r\n\r\n```\r\nFailures:                                                                                                                                                                                                   [34/1797]\r\n\r\n  1) chef-server-populator::client a user is defined in the data bag the user is enabled creates the user\r\n     Failure/Error:\r\n       expect(chef_run).to run_execute(\"create user: #{test_user_name}\").with(\r\n         :command => \"chef-server-ctl user-create #{test_user_name} #{test_user_item['chef_server']['full_name'].split(' ').first} #{test_user_item['chef_server']['full_name'].split(' ').last} #{test_user_item['c$\r\nef_server']['email']} #{test_user_item['chef_server']['password']} > /dev/null 2>&1\"\r\n       )\r\n\r\n       expected \"execute[create user: murph]\" with action :run to be in Chef run. Other execute resources:\r\n\r\n         execute[create org: endeavor]\r\n         execute[add org validator key: endeavor]\r\n         execute[remove org default validator key: endeavor]\r\n         execute[create org: nasa]\r\n         execute[add org validator key: nasa]\r\n         execute[remove org default validator key: nasa]\r\n         execute[create client: case]\r\n         execute[set client key: case]\r\n         execute[delete default client key: case]\r\n         execute[create client: tars]\r\n         execute[set client key: tars]\r\n         execute[delete default client key: tars]\r\n\r\n     # ./test/unit/client_spec.rb:122:in `block (4 levels) in <top (required)>'\r\n\r\n  2) chef-server-populator::client a user is defined in the data bag the user is enabled the user has a client key specified creates the user's client key file\r\n     Failure/Error:\r\n       expect(chef_run).to create_file(test_user_pub_key_path).with(\r\n         :content => test_user_item['chef_server']['client_key']\r\n       )\r\n\r\n       expected \"file[/var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160511-49588-p3cehy/murph.pub]\" with action :create to be in Chef run. Other file resources:\r\n\r\n         file[/var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160511-49588-p3cehy/chef-server-core.firstrun]\r\n         file[/var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160511-49588-p3cehy/endeavor.pub]\r\n         file[/var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160511-49588-p3cehy/nasa.pub]\r\n         file[/var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160511-49588-p3cehy/case.pub]\r\n         file[/var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160511-49588-p3cehy/tars.pub]\r\n\r\n     # ./test/unit/client_spec.rb:130:in `block (5 levels) in <top (required)>'\r\n\r\n  3) chef-server-populator::client a user is defined in the data bag the user is enabled the user has a client key specified sets inserts the client key as the user's populator key\r\n     Failure/Error:\r\n       expect(chef_run).to run_execute(\"set user key: #{test_user_name}\").with(\r\n         :command => \"chef-server-ctl add-user-key #{test_user_name} --public-key-path #{test_user_pub_key_path} --key-name populator\"\r\n       )\r\n\r\n       expected \"execute[set user key: murph]\" with action :run to be in Chef run. Other execute resources:\r\n\r\n         execute[create org: endeavor]\r\n         execute[add org validator key: endeavor]\r\n         execute[remove org default validator key: endeavor]\r\n         execute[create org: nasa]\r\n         execute[add org validator key: nasa]\r\n         execute[remove org default validator key: nasa]\r\n         execute[create client: case]\r\n         execute[set client key: case]\r\n         execute[delete default client key: case]\r\n         execute[create client: tars]\r\n         execute[set client key: tars]\r\n         execute[delete default client key: tars]\r\n\r\n  4) chef-server-populator::client a user is defined in the data bag the user is enabled the user has a client key specified deletes the user's default key\r\n     Failure/Error: expect(chef_run).to run_execute(\"delete default user key: #{test_user_name}\")\r\n\r\n       expected \"execute[delete default user key: murph]\" with action :run to be in Chef run. Other execute resources:\r\n\r\n         execute[create org: endeavor]\r\n         execute[add org validator key: endeavor]\r\n         execute[remove org default validator key: endeavor]\r\n         execute[create org: nasa]\r\n         execute[add org validator key: nasa]\r\n         execute[remove org default validator key: nasa]\r\n         execute[create client: case]\r\n         execute[set client key: case]\r\n         execute[delete default client key: case]\r\n         execute[create client: tars]\r\n         execute[set client key: tars]\r\n         execute[delete default client key: tars]\r\n\r\n     # ./test/unit/client_spec.rb:142:in `block (5 levels) in <top (required)>'\r\n\r\nFinished in 59.01 seconds (files took 1.82 seconds to load)\r\n62 examples, 4 failures\r\n\r\nFailed examples:\r\n\r\nrspec ./test/unit/client_spec.rb:121 # chef-server-populator::client a user is defined in the data bag the user is enabled creates the user\r\nrspec ./test/unit/client_spec.rb:129 # chef-server-populator::client a user is defined in the data bag the user is enabled the user has a client key specified creates the user's client key file\r\nrspec ./test/unit/client_spec.rb:135 # chef-server-populator::client a user is defined in the data bag the user is enabled the user has a client key specified sets inserts the client key as the user's populator key\r\nrspec ./test/unit/client_spec.rb:141 # chef-server-populator::client a user is defined in the data bag the user is enabled the user has a client key specified deletes the user's default key\r\n\r\n``` \r\n\r\nAre the tests or fixtures in need of updating with this change?"},"comment":{"url":"https://api.github.com/repos/hw-cookbooks/chef-server-populator/issues/comments/218502213","html_url":"https://github.com/hw-cookbooks/chef-server-populator/issues/74#issuecomment-218502213","issue_url":"https://api.github.com/repos/hw-cookbooks/chef-server-populator/issues/74","id":218502213,"user":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars.githubusercontent.com/u/148017?v=3","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T15:50:14Z","updated_at":"2016-05-11T15:50:14Z","body":"cc @luckymike "}}