{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/728","repository_url":"https://api.github.com/repos/apache/incubator-zeppelin","labels_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/728/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/728/comments","events_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/728/events","html_url":"https://github.com/apache/incubator-zeppelin/pull/728","id":134810222,"number":728,"title":"Leaflet support, based on PR #152","user":{"login":"eddies","id":149985,"avatar_url":"https://avatars.githubusercontent.com/u/149985?v=3","gravatar_id":"","url":"https://api.github.com/users/eddies","html_url":"https://github.com/eddies","followers_url":"https://api.github.com/users/eddies/followers","following_url":"https://api.github.com/users/eddies/following{/other_user}","gists_url":"https://api.github.com/users/eddies/gists{/gist_id}","starred_url":"https://api.github.com/users/eddies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddies/subscriptions","organizations_url":"https://api.github.com/users/eddies/orgs","repos_url":"https://api.github.com/users/eddies/repos","events_url":"https://api.github.com/users/eddies/events{/privacy}","received_events_url":"https://api.github.com/users/eddies/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-19T09:07:55Z","updated_at":"2016-03-08T05:29:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/728","html_url":"https://github.com/apache/incubator-zeppelin/pull/728","diff_url":"https://github.com/apache/incubator-zeppelin/pull/728.diff","patch_url":"https://github.com/apache/incubator-zeppelin/pull/728.patch"},"body":"### What is this PR for?\r\nAn update/follow-on for PR 152 that is limited to Leaflet support. There doesn't appear to have been any new movement on PR 152 since August 2015, so this PR updates @Madhuka's work against master, but without any of the data validation or other non-Leaflet work.\r\n\r\n### What type of PR is it?\r\nFeature\r\n\r\n### Todos\r\nN/A\r\n\r\n### Is there a relevant Jira issue?\r\nZEPPELIN-157\r\n\r\n### How should this be tested?\r\nRecreate @Madhuka's example, e.g. use the following to populate a cell:\r\n  https://gist.github.com/eddies/f20241e161aa2bbbb788\r\n\r\nThen, in a new cell\r\n```\r\n%sql\r\nselect * from myMap\r\n```\r\nThere should a new chart selector rightmost that will render the data w/ leaflet. You may need to clean your browser cache initially.\r\n\r\n### Screenshots (if appropriate)\r\n![leaflet](https://cloud.githubusercontent.com/assets/149985/13422633/f72016ee-dfd0-11e5-979a-6454a72d9ef9.gif)\r\nAlso see Madhuka's original PR: https://github.com/apache/incubator-zeppelin/pull/152\r\n\r\n### Questions:\r\n* Does the licenses files need update? no\r\n* Is there breaking changes for older versions? no\r\n* Does this needs documentation? Probably. It wasn't clear to me if PR 152 was going to move ahead in a new, Leaflet-only incarnation as suggested in the comment thread. But I needed Leaflet support, so went ahead with my own fork. I'm happy to work on documentation for this, but not sure if a sample notebook tutorial is what's desired (e.g. maybe something under the Display System docs is preferable?). If so, I'd just stick with something like the sample notebook in PR 152."},"comment":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/comments/193616050","html_url":"https://github.com/apache/incubator-zeppelin/pull/728#issuecomment-193616050","issue_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/728","id":193616050,"user":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T05:29:33Z","updated_at":"2016-03-08T05:29:33Z","body":"@corneadoug : #765  is contain the basic map feature which is in #152. #765 all checks have passed and no build failures.\r\n@eddies : Heatmaps is nice addition for the basic map visualization, This PR ( #728 after fixing this build failure) can easily lay on top of #765"}}