{"push_id":960759879,"size":82,"distinct_size":82,"ref":"refs/heads/transient_stats","head":"a2fa54f16b64f573f2e5a0076109f05eff9adda4","before":"c199393c0471677622e4060b7c5de2a694278e19","commits":[{"sha":"6f1c176261e5e6e41906422dd29f4e58cd5bf8ef","author":{"email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com","name":"Matt Jibson"},"message":"sql: fix UPDATE with multiple tuples of DEFAULT\n\nWithout this, the new tests fail with:\n\npq: value type timestamp doesn't match type FLOAT of column \"c\"","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/6f1c176261e5e6e41906422dd29f4e58cd5bf8ef"},{"sha":"acc978eec211938a105587770884376d6d615197","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"gossip: Replace HTTP GET and JSON parsing in nodeLookupResolver with util function","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/acc978eec211938a105587770884376d6d615197"},{"sha":"9830f571c5e064e3ce33f919f394d717bc60c970","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"Merge pull request #4030 from cockroachdb/nvanbenschoten/lookup\n\ngossip: Replace HTTP GET and JSON parsing in nodeLookupResolver with util function","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/9830f571c5e064e3ce33f919f394d717bc60c970"},{"sha":"51ebfd14b66809590c58956f7c38d6999c171bad","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"Fix replica_test.go to call GoError() just before type check\n\nWe still convert roachpb.Error to error, but the conversion happens\njust before type check. This change helps when we simplify GoError() and make\nit just return errors.New(e.Message).","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/51ebfd14b66809590c58956f7c38d6999c171bad"},{"sha":"0e6fe8c23d68d3ed550c6dbf31eaf902b866fbb2","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"Merge pull request #4032 from cockroachdb/kaneda/less_go_error\n\nFix replica_test.go to call GoError() just before type check","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/0e6fe8c23d68d3ed550c6dbf31eaf902b866fbb2"},{"sha":"b6cb0be2b83e79eccb4f8a805f2b6b0f8f62b2b9","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"sql: Avoid calling GoError() by storing roachpb.Error in Result\n\nThis is yet another small fix to avoid calling GoError() at random places.","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/b6cb0be2b83e79eccb4f8a805f2b6b0f8f62b2b9"},{"sha":"fac0fd32e6ab103c28d4888d6ae0ce29c1c28d08","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"Remove the rpc.Options.N field.\n\nIt never had a value other than 1 in non-test code. This allowed\nsimplification of the rpc.Send() signature to only return a single\nresponse.","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/fac0fd32e6ab103c28d4888d6ae0ce29c1c28d08"},{"sha":"79917628e169daac0e0ffba88fee6a79a3ebeab9","author":{"email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com","name":"Matt Jibson"},"message":"Merge pull request #4023 from mjibson/sql-tuple-update-default\n\nsql: fix UPDATE with multiple tuples of DEFAULT","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/79917628e169daac0e0ffba88fee6a79a3ebeab9"},{"sha":"7227aa76bc71ce7bd013e550829657e8b8ee3bc7","author":{"email":"b00247e2d759197c8b2da85e3eb4533fb49f53f7@gmail.com","name":"Vivek Menezes"},"message":"refactor some of the critical sections in storage/replica.go","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/7227aa76bc71ce7bd013e550829657e8b8ee3bc7"},{"sha":"d9b1d1945fa5eeee7c21a3be981ce295df54661f","author":{"email":"e0cb593f5504fb19339078306a174cb6c8837801@users.noreply.github.com","name":"vivekmenezes"},"message":"Merge pull request #4028 from vivekmenezes/vivek/things\n\nrefactor some of the critical sections in storage/replica.go","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/d9b1d1945fa5eeee7c21a3be981ce295df54661f"},{"sha":"829305c3020a9d3e78877b5e4ebde617a5915628","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #4034 from petermattis/pmattis/rpc-opts-N\n\nRemove the rpc.Options.N field.","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/829305c3020a9d3e78877b5e4ebde617a5915628"},{"sha":"028387f5db0f708090ac0f5e4bfee9369876973d","author":{"email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com","name":"Matt Jibson"},"message":"sql: prepare support for INSERT, UPDATE, DELETE\n\nMake sure prepare statements are run in a transaction.\n\nUse a new boolean flag on the planner to indicate prepare. Statement\nimplementations will gain knowledge of work to omit during prepare. An\nalternative implementation would split up the prepare and exec portions of\nthe work. However, this would require passing around significant amounts\nof state and I think the best implementation is the one here.\n\nKeep a whitelist of statement types that support preparation instead of\nattempting to exec them during prepare.\n\nThis also functions as a refactor for prepare statements in\ngeneral. Previously, we called parser.InferArgs, which walked the statement\nand ran TypeCheck on all expressions. It turns out this is not needed,\nsince Select (and others) do this themselves. Thus, we can invoke those\nworker functions directly but teach them about prepareOnly so they can\nomit work once the val args have been populated and the type checks done.\n\nFixes #3819","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/028387f5db0f708090ac0f5e4bfee9369876973d"},{"sha":"50dd0a78cfe4a62f5bbd44a824374d2f5fee3db9","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"Remove import aliases for versioned gopkg deps","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/50dd0a78cfe4a62f5bbd44a824374d2f5fee3db9"},{"sha":"602470b374e0e8917664d877569e277db1c68662","author":{"email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com","name":"Raphael 'kena' Poss"},"message":"Add an RFC about typing.","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/602470b374e0e8917664d877569e277db1c68662"},{"sha":"1359655e8641b4ad15d0b99fcc226e43eaa6ca25","author":{"email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@thaumogen.net","name":"kena"},"message":"Give credit where credit is due.","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/1359655e8641b4ad15d0b99fcc226e43eaa6ca25"},{"sha":"1b1926cb4ce27184972149b86b9d9068676bc1a2","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"Merge pull request #4033 from cockroachdb/kaneda/sql_go\n\nsql: Avoid calling GoError() by storing roachpb.Error in Result","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/1b1926cb4ce27184972149b86b9d9068676bc1a2"},{"sha":"3d58bf2093afe2d6490202653e5d31cd9c4220d4","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"util/stop: Remove allocations from Stopper.Run{,Async}Task.\n\nname       old time/op    new time/op    delta\nStopper-8    1.40µs ± 1%    1.15µs ± 1%   -17.53%   (p=0.000 n=9+10)\n\nname       old alloc/op   new alloc/op   delta\nStopper-8     66.0B ± 0%      2.0B ± 0%   -96.97%  (p=0.000 n=10+10)\n\nname       old allocs/op  new allocs/op  delta\nStopper-8      3.00 ± 0%     0.00 ±NaN%  -100.00%  (p=0.000 n=10+10)\n\nThis gives ~1% speedup to various SQL benchmarks.","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/3d58bf2093afe2d6490202653e5d31cd9c4220d4"},{"sha":"796ee762c7efdb09618b9eb723df5e0e3aa63f69","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"util/tracer: Add DISABLE_TRACER env variable.\n\nTracing every operation has a very noticeable performance impact. This\nis a hammer to disble it. We need to either optimize tracing, or make it\nsample only a fraction of operations or both.\n\nname                   old time/op  new time/op  delta\nInsert1_Cockroach-8     584µs ± 1%   492µs ± 1%  -15.86%    (p=0.000 n=9+7)\nInsert10_Cockroach-8    965µs ± 1%   883µs ± 1%   -8.46%   (p=0.000 n=9+10)\nInsert100_Cockroach-8  4.61ms ± 1%  4.52ms ± 1%   -1.95%  (p=0.000 n=10+10)\nUpdate1_Cockroach-8    1.37ms ± 1%  1.19ms ± 1%  -13.63%  (p=0.000 n=10+10)\nUpdate10_Cockroach-8   8.48ms ± 1%  6.85ms ± 1%  -19.24%   (p=0.000 n=9+10)\nUpdate100_Cockroach-8  80.4ms ± 1%  64.8ms ± 0%  -19.39%   (p=0.000 n=10+9)\nDelete1_Cockroach-8    1.53ms ± 4%  1.51ms ± 1%   -1.85%  (p=0.004 n=10+10)\nDelete10_Cockroach-8   2.64ms ± 1%  2.39ms ± 1%   -9.65%   (p=0.000 n=9+10)\nDelete100_Cockroach-8  11.9ms ± 3%  11.8ms ± 1%   -1.27%   (p=0.028 n=10+9)\nScan1_Cockroach-8       375µs ± 2%   303µs ± 0%  -19.13%   (p=0.000 n=10+9)\nScan10_Cockroach-8      432µs ± 1%   356µs ± 1%  -17.48%  (p=0.000 n=10+10)\nScan100_Cockroach-8     866µs ± 1%   773µs ± 1%  -10.77%  (p=0.000 n=10+10)","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/796ee762c7efdb09618b9eb723df5e0e3aa63f69"},{"sha":"fb0e2adfd84508cd15ba7b50c69e040ce34dee0f","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"sql: [Tiny fix] Make encodeDTuple return roachpb.Error\n\nWe were calling GoError() and NewError() unnecessarily.","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/fb0e2adfd84508cd15ba7b50c69e040ce34dee0f"},{"sha":"da6d0bf7a1fdff4377989dc3a9f4ea9eec5d97ca","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"kv: [Tiny fix] Avoid calling GoError() in tests when possible","distinct":true,"url":"https://api.github.com/repos/cuongdo/cockroach/commits/da6d0bf7a1fdff4377989dc3a9f4ea9eec5d97ca"}]}