{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/27","id":84299652,"html_url":"https://github.com/Automattic/eslint-plugin-wpcalypso/pull/27","diff_url":"https://github.com/Automattic/eslint-plugin-wpcalypso/pull/27.diff","patch_url":"https://github.com/Automattic/eslint-plugin-wpcalypso/pull/27.patch","issue_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/27","number":27,"state":"closed","locked":false,"title":"jsx-classname-namespace: Validate non-root as containing only expected underscores","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars.githubusercontent.com/u/1779930?v=3","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"body":"Related: https://github.com/Automattic/wp-calypso/pull/7866/files/1cb3beb74615810026453bb6204a051489fad604#r77802780\r\n\r\nThis pull request seeks to resolve an issue where the following class name could be considered valid for a non-root element, when run against the `jsx-classname-namespace` rule:\r\n\r\n`foo__child__example`\r\n\r\nPreviously we were only verifying that the non-root element class name started with and was not equal to the folder name plus two underscores. We now test the rest of the class name to ensure that it consists only of lowercase letters, numbers, and dashes. \r\n\r\nWhile it is technically possible for CSS class name selectors to contain other characters ([reference](https://www.w3.org/TR/CSS21/syndata.html#characters)), the included pattern assumes we want to enforce `[a-z0-9-]` as the only valid characters after the namespaced prefix.\r\n\r\ncc @mtias ","created_at":"2016-09-07T13:26:54Z","updated_at":"2016-09-26T21:13:36Z","closed_at":"2016-09-26T21:13:36Z","merged_at":"2016-09-26T21:13:36Z","merge_commit_sha":"3775c655fcb4a405af39d6ae6da5e35e4f452847","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/27/commits","review_comments_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/27/comments","review_comment_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/27/comments","statuses_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/statuses/e6e26ee42670965b547262215045cbb15d4cf180","head":{"label":"Automattic:update/jsx-classname-namespace-dashes","ref":"update/jsx-classname-namespace-dashes","sha":"e6e26ee42670965b547262215045cbb15d4cf180","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":50957401,"name":"eslint-plugin-wpcalypso","full_name":"Automattic/eslint-plugin-wpcalypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/eslint-plugin-wpcalypso","description":"Custom ESLint rules for the WordPress.com Calypso project","fork":false,"url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso","forks_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/forks","keys_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/teams","hooks_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/events","assignees_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/tags","blobs_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/subscription","commits_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/merges","archive_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/downloads","issues_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/deployments","created_at":"2016-02-02T22:45:07Z","updated_at":"2016-07-06T21:17:40Z","pushed_at":"2016-09-26T21:13:36Z","git_url":"git://github.com/Automattic/eslint-plugin-wpcalypso.git","ssh_url":"git@github.com:Automattic/eslint-plugin-wpcalypso.git","clone_url":"https://github.com/Automattic/eslint-plugin-wpcalypso.git","svn_url":"https://github.com/Automattic/eslint-plugin-wpcalypso","homepage":null,"size":113,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"2eacc852afa97e8489ff62a45541b858ae912aba","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":50957401,"name":"eslint-plugin-wpcalypso","full_name":"Automattic/eslint-plugin-wpcalypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/eslint-plugin-wpcalypso","description":"Custom ESLint rules for the WordPress.com Calypso project","fork":false,"url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso","forks_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/forks","keys_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/teams","hooks_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/events","assignees_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/tags","blobs_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/subscription","commits_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/merges","archive_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/downloads","issues_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/deployments","created_at":"2016-02-02T22:45:07Z","updated_at":"2016-07-06T21:17:40Z","pushed_at":"2016-09-26T21:13:36Z","git_url":"git://github.com/Automattic/eslint-plugin-wpcalypso.git","ssh_url":"git@github.com:Automattic/eslint-plugin-wpcalypso.git","clone_url":"https://github.com/Automattic/eslint-plugin-wpcalypso.git","svn_url":"https://github.com/Automattic/eslint-plugin-wpcalypso","homepage":null,"size":113,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/27"},"html":{"href":"https://github.com/Automattic/eslint-plugin-wpcalypso/pull/27"},"issue":{"href":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/27"},"comments":{"href":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/eslint-plugin-wpcalypso/statuses/e6e26ee42670965b547262215045cbb15d4cf180"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aduth","id":1779930,"avatar_url":"https://avatars.githubusercontent.com/u/1779930?v=3","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":3,"additions":22,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"aduth"}}