{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/84788291","pull_request_review_id":5543536,"id":84788291,"diff_hunk":"@@ -63,6 +64,14 @@ void DialogsManager::indicateDomainConnectionFailure() {\n     OffscreenUi::information(\"No Connection\", \"Unable to connect to this domain. Click the 'GO TO' button on the toolbar to visit another domain.\");\n }","path":"interface/src/ui/DialogsManager.cpp","position":10,"original_position":10,"commit_id":"f3ef0cebedee2504c18d9e429436a2208e0beea2","original_commit_id":"f3ef0cebedee2504c18d9e429436a2208e0beea2","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"You can remove this function now.","created_at":"2016-10-24T21:31:06Z","updated_at":"2016-10-24T21:31:33Z","html_url":"https://github.com/highfidelity/hifi/pull/8891#discussion_r84788291","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8891","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/84788291"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8891#discussion_r84788291"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8891"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/8891","id":90661790,"html_url":"https://github.com/highfidelity/hifi/pull/8891","diff_url":"https://github.com/highfidelity/hifi/pull/8891.diff","patch_url":"https://github.com/highfidelity/hifi/pull/8891.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/8891","number":8891,"state":"open","locked":false,"title":"Fix several aspects of the \"disconnected\" dialog","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"Changes:\r\n\r\n 1. On first load, wait longer to show the disconnected dialog\r\n 1. If trying to go to a place that requires login, don't show the can't connect dialog\r\n 1. Make the can't connect dialog go away if you get connected to the domain\r\n\r\nNote: The disconnected dialog is the one that says \"No Connection\" at the top\r\n\r\nTo test:\r\n 1. Go to your home domain, ensure that the disconnected dialog does not show\r\n 1. Shut your local server down, ensure that the disconnected dialog comes up\r\n 1. Manually close the dialog, start the server back up\r\n 1. Shut your local server down, ensure that the disconnected dialog comes up\r\n 1. DO NOT close the dialog, start the server back up, ensure that the dialog goes away automatically\r\n 1. Shut your local server down, ensure that the disconnected dialog comes up\r\n 1. Restart interface, ensure that the disconnected dialog comes up after more than 10 seconds\r\n 1. Close the dialog\r\n 1. Ensure you are logged out. Go to `sport`\r\n 1. Ensure that the \"login\" dialog comes up but that the disconnected dialog does __not__\r\n 1. Go to a domain running a different protocol version (`welcome`, for instance)\r\n 1. Ensure the packet version mismatch pops up, but the disconnected dialog does __not__","created_at":"2016-10-24T17:58:57Z","updated_at":"2016-10-24T21:31:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"376db12dbc31fce0f691ad55994d09fb2f73a2c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8891/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8891/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/8891/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/f3ef0cebedee2504c18d9e429436a2208e0beea2","head":{"label":"huffman:fix/disconnected-dialog-updates","ref":"fix/disconnected-dialog-updates","sha":"f3ef0cebedee2504c18d9e429436a2208e0beea2","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"repo":{"id":16237479,"name":"hifi","full_name":"huffman/hifi","owner":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huffman/hifi","description":"Open, decentralized virtual world using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  You can also contribute by doing jobs listed at http://worklist.net/worklist.php","fork":true,"url":"https://api.github.com/repos/huffman/hifi","forks_url":"https://api.github.com/repos/huffman/hifi/forks","keys_url":"https://api.github.com/repos/huffman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huffman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huffman/hifi/teams","hooks_url":"https://api.github.com/repos/huffman/hifi/hooks","issue_events_url":"https://api.github.com/repos/huffman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/huffman/hifi/events","assignees_url":"https://api.github.com/repos/huffman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/huffman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/huffman/hifi/tags","blobs_url":"https://api.github.com/repos/huffman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huffman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huffman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/huffman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huffman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/huffman/hifi/languages","stargazers_url":"https://api.github.com/repos/huffman/hifi/stargazers","contributors_url":"https://api.github.com/repos/huffman/hifi/contributors","subscribers_url":"https://api.github.com/repos/huffman/hifi/subscribers","subscription_url":"https://api.github.com/repos/huffman/hifi/subscription","commits_url":"https://api.github.com/repos/huffman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/huffman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/huffman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/huffman/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/huffman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/huffman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huffman/hifi/merges","archive_url":"https://api.github.com/repos/huffman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huffman/hifi/downloads","issues_url":"https://api.github.com/repos/huffman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/huffman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/huffman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/huffman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huffman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/huffman/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/huffman/hifi/deployments","created_at":"2014-01-25T18:54:32Z","updated_at":"2015-03-25T17:45:58Z","pushed_at":"2016-10-24T21:27:40Z","git_url":"git://github.com/huffman/hifi.git","ssh_url":"git@github.com:huffman/hifi.git","clone_url":"https://github.com/huffman/hifi.git","svn_url":"https://github.com/huffman/hifi","homepage":"http://highfidelity.io","size":245677,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"b5881146df4499791023cbdfc5e9f38aaf85b3b8","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-10-24T15:15:19Z","pushed_at":"2016-10-24T21:29:30Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":287323,"stargazers_count":440,"watchers_count":440,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":46,"forks":256,"open_issues":46,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8891"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8891"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8891"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8891/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8891/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8891/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/f3ef0cebedee2504c18d9e429436a2208e0beea2"}}}}
{"actor":{"display_login":"Atlante45"}}