{"action":"closed","number":20427,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20427","id":93762968,"html_url":"https://github.com/NixOS/nixpkgs/pull/20427","diff_url":"https://github.com/NixOS/nixpkgs/pull/20427.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/20427.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20427","number":20427,"state":"closed","locked":false,"title":"networkmanager: multiple outputs","user":{"login":"ttuegel","id":563054,"avatar_url":"https://avatars.githubusercontent.com/u/563054?v=3","gravatar_id":"","url":"https://api.github.com/users/ttuegel","html_url":"https://github.com/ttuegel","followers_url":"https://api.github.com/users/ttuegel/followers","following_url":"https://api.github.com/users/ttuegel/following{/other_user}","gists_url":"https://api.github.com/users/ttuegel/gists{/gist_id}","starred_url":"https://api.github.com/users/ttuegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttuegel/subscriptions","organizations_url":"https://api.github.com/users/ttuegel/orgs","repos_url":"https://api.github.com/users/ttuegel/repos","events_url":"https://api.github.com/users/ttuegel/events{/privacy}","received_events_url":"https://api.github.com/users/ttuegel/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nUsing multiple outputs for NetworkManager reduces the closure size for the installation CD.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n","created_at":"2016-11-15T13:14:34Z","updated_at":"2016-11-17T12:34:58Z","closed_at":"2016-11-17T12:34:58Z","merged_at":"2016-11-17T12:34:58Z","merge_commit_sha":"3d5a033c9629dd1a460a82c5f6448ede283c328c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20427/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20427/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20427/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/520064e4b59ce5287cd3335f416995e520db3cd3","head":{"label":"ttuegel:multiple-outputs-networkmanager","ref":"multiple-outputs-networkmanager","sha":"520064e4b59ce5287cd3335f416995e520db3cd3","user":{"login":"ttuegel","id":563054,"avatar_url":"https://avatars.githubusercontent.com/u/563054?v=3","gravatar_id":"","url":"https://api.github.com/users/ttuegel","html_url":"https://github.com/ttuegel","followers_url":"https://api.github.com/users/ttuegel/followers","following_url":"https://api.github.com/users/ttuegel/following{/other_user}","gists_url":"https://api.github.com/users/ttuegel/gists{/gist_id}","starred_url":"https://api.github.com/users/ttuegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttuegel/subscriptions","organizations_url":"https://api.github.com/users/ttuegel/orgs","repos_url":"https://api.github.com/users/ttuegel/repos","events_url":"https://api.github.com/users/ttuegel/events{/privacy}","received_events_url":"https://api.github.com/users/ttuegel/received_events","type":"User","site_admin":false},"repo":{"id":11405692,"name":"nixpkgs","full_name":"ttuegel/nixpkgs","owner":{"login":"ttuegel","id":563054,"avatar_url":"https://avatars.githubusercontent.com/u/563054?v=3","gravatar_id":"","url":"https://api.github.com/users/ttuegel","html_url":"https://github.com/ttuegel","followers_url":"https://api.github.com/users/ttuegel/followers","following_url":"https://api.github.com/users/ttuegel/following{/other_user}","gists_url":"https://api.github.com/users/ttuegel/gists{/gist_id}","starred_url":"https://api.github.com/users/ttuegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttuegel/subscriptions","organizations_url":"https://api.github.com/users/ttuegel/orgs","repos_url":"https://api.github.com/users/ttuegel/repos","events_url":"https://api.github.com/users/ttuegel/events{/privacy}","received_events_url":"https://api.github.com/users/ttuegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttuegel/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/ttuegel/nixpkgs","forks_url":"https://api.github.com/repos/ttuegel/nixpkgs/forks","keys_url":"https://api.github.com/repos/ttuegel/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttuegel/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttuegel/nixpkgs/teams","hooks_url":"https://api.github.com/repos/ttuegel/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/ttuegel/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/ttuegel/nixpkgs/events","assignees_url":"https://api.github.com/repos/ttuegel/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/ttuegel/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/ttuegel/nixpkgs/tags","blobs_url":"https://api.github.com/repos/ttuegel/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttuegel/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttuegel/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttuegel/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttuegel/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/ttuegel/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/ttuegel/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/ttuegel/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/ttuegel/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/ttuegel/nixpkgs/subscription","commits_url":"https://api.github.com/repos/ttuegel/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttuegel/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttuegel/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttuegel/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ttuegel/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/ttuegel/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttuegel/nixpkgs/merges","archive_url":"https://api.github.com/repos/ttuegel/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttuegel/nixpkgs/downloads","issues_url":"https://api.github.com/repos/ttuegel/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/ttuegel/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/ttuegel/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/ttuegel/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttuegel/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/ttuegel/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/ttuegel/nixpkgs/deployments","created_at":"2013-07-14T16:31:06Z","updated_at":"2015-05-08T13:23:53Z","pushed_at":"2016-11-17T12:32:23Z","git_url":"git://github.com/ttuegel/nixpkgs.git","ssh_url":"git@github.com:ttuegel/nixpkgs.git","clone_url":"https://github.com/ttuegel/nixpkgs.git","svn_url":"https://github.com/ttuegel/nixpkgs","homepage":null,"size":410385,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"1958f07c63ab0e51ee81cbaec2678e617c8ebfab","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-11-15T21:33:38Z","pushed_at":"2016-11-17T12:34:58Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":641446,"stargazers_count":1384,"watchers_count":1384,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1715,"mirror_url":null,"open_issues_count":1658,"forks":1715,"open_issues":1658,"watchers":1384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20427"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/20427"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/20427"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/20427/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20427/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20427/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/520064e4b59ce5287cd3335f416995e520db3cd3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ttuegel","id":563054,"avatar_url":"https://avatars.githubusercontent.com/u/563054?v=3","gravatar_id":"","url":"https://api.github.com/users/ttuegel","html_url":"https://github.com/ttuegel","followers_url":"https://api.github.com/users/ttuegel/followers","following_url":"https://api.github.com/users/ttuegel/following{/other_user}","gists_url":"https://api.github.com/users/ttuegel/gists{/gist_id}","starred_url":"https://api.github.com/users/ttuegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttuegel/subscriptions","organizations_url":"https://api.github.com/users/ttuegel/orgs","repos_url":"https://api.github.com/users/ttuegel/repos","events_url":"https://api.github.com/users/ttuegel/events{/privacy}","received_events_url":"https://api.github.com/users/ttuegel/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"ttuegel"}}