{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/64463329","id":64463329,"diff_hunk":"@@ -0,0 +1,41 @@\n+require \"logstash/api/app_helpers\"\n+require \"logstash/api/command_factory\"\n+\n+module LogStash\n+  module Api\n+    module Modules\n+      class Base < ::Sinatra::Base","path":"logstash-core/lib/logstash/api/modules/base.rb","position":7,"original_position":7,"commit_id":"0dadf37ea2820b85a2f8103a21f492b09077e608","original_commit_id":"0dadf37ea2820b85a2f8103a21f492b09077e608","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"Well, I think its fairly common to have a 'base' class that's a sibling to the classes that inherit from it.\r\n\r\nIf we move it up a level it'd have to be renamed to `LogStash::Api::BaseModule` and moved to `api/base_module.rb`.\r\n\r\nI'm fine with either approach. I take it you prefer the latter? ","created_at":"2016-05-24T20:00:18Z","updated_at":"2016-05-24T20:00:19Z","html_url":"https://github.com/elastic/logstash/pull/5307#discussion_r64463329","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/5307","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/64463329"},"html":{"href":"https://github.com/elastic/logstash/pull/5307#discussion_r64463329"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5307"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/5307","id":70273545,"html_url":"https://github.com/elastic/logstash/pull/5307","diff_url":"https://github.com/elastic/logstash/pull/5307.diff","patch_url":"https://github.com/elastic/logstash/pull/5307.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5307","number":5307,"state":"open","locked":false,"title":"WebAPI refactor && JVM thread stats","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"WIP for adding the stats mentioned in #4923 \r\n\r\nFixes #5328 \r\n\r\nRefactors: \r\n\r\n1. All classes renamed to be consistent with their location on the FS path.\r\n1. Rack app changed to no longer use init.ru, but use direct class instantiation (as a result we don't need a nested 'lib' folder under logstash/api.\r\n1. Commands refactored to handle multiple responsibilities with multiple method names. (The #run method meant we needed tons of little classes that were 90% boilerplate. Check the new node_stats command).\r\n1. Intent is to refactor the commands directory to be a direct mirror of the web API. This will simplify automated stats shipping.\r\n\r\n### Node Stats\r\n\r\n* [x] stats.events.in | /_node/stats/events\r\n* [x] stats.events.filtered | /_node/stats/events |\r\n* [x] stats.events.out | /_node/stats/events |\r\n* [x] stats.jvm.threads.count | /_node/stats/jvm |\r\n* [x] stats.jvm.threads.peak_count | /_node/stats/jvm |\r\n* [x] stats.process.open_file_descriptors | /_node/stats/process |\r\n* [x] stats.process.peak_open_file_descriptors | /_node/stats/process |\r\n* [x] stats.process.max_file_descriptors | /_node/stats/process |\r\n* [x] stats.process.cpu.percent | /_node/stats/process/cpu |\r\n* [x] stats.process.cpu.total_in_millis | /_node/stats/process/cpu |\r\n* [x] stats.process.mem.total_virtual_in_bytes | /_node/stats/process/mem\r\n","created_at":"2016-05-16T22:38:32Z","updated_at":"2016-05-24T20:00:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b843f72edba842a9f9b5e393cbbb62cdc25a358","assignee":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/5307/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/5307/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5307/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/0dadf37ea2820b85a2f8103a21f492b09077e608","head":{"label":"andrewvc:stats-additions-4923","ref":"stats-additions-4923","sha":"0dadf37ea2820b85a2f8103a21f492b09077e608","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":37559198,"name":"logstash","full_name":"andrewvc/logstash","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/andrewvc/logstash","forks_url":"https://api.github.com/repos/andrewvc/logstash/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/andrewvc/logstash/deployments","created_at":"2015-06-16T22:23:09Z","updated_at":"2015-06-16T22:23:11Z","pushed_at":"2016-05-20T20:52:30Z","git_url":"git://github.com/andrewvc/logstash.git","ssh_url":"git@github.com:andrewvc/logstash.git","clone_url":"https://github.com/andrewvc/logstash.git","svn_url":"https://github.com/andrewvc/logstash","homepage":"https://www.elastic.co/products/logstash","size":77993,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"eaca2fd9bd8769fc239c1fa6650470ac6363a5ba","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-05-24T17:31:43Z","pushed_at":"2016-05-24T18:59:43Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":88338,"stargazers_count":5906,"watchers_count":5906,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1781,"mirror_url":null,"open_issues_count":733,"forks":1781,"open_issues":733,"watchers":5906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5307"},"html":{"href":"https://github.com/elastic/logstash/pull/5307"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/5307"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/5307/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5307/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5307/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/0dadf37ea2820b85a2f8103a21f492b09077e608"}}}}
{"actor":{"display_login":"andrewvc"}}