{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk_crawler_worker/issues/108","repository_url":"https://api.github.com/repos/alphagov/govuk_crawler_worker","labels_url":"https://api.github.com/repos/alphagov/govuk_crawler_worker/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk_crawler_worker/issues/108/comments","events_url":"https://api.github.com/repos/alphagov/govuk_crawler_worker/issues/108/events","html_url":"https://github.com/alphagov/govuk_crawler_worker/pull/108","id":166992310,"number":108,"title":"Upgrade to Go 1.7","user":{"login":"timblair","id":3360,"avatar_url":"https://avatars.githubusercontent.com/u/3360?v=3","gravatar_id":"","url":"https://api.github.com/users/timblair","html_url":"https://github.com/timblair","followers_url":"https://api.github.com/users/timblair/followers","following_url":"https://api.github.com/users/timblair/following{/other_user}","gists_url":"https://api.github.com/users/timblair/gists{/gist_id}","starred_url":"https://api.github.com/users/timblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timblair/subscriptions","organizations_url":"https://api.github.com/users/timblair/orgs","repos_url":"https://api.github.com/users/timblair/repos","events_url":"https://api.github.com/users/timblair/events{/privacy}","received_events_url":"https://api.github.com/users/timblair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-22T08:10:45Z","updated_at":"2016-08-31T09:47:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk_crawler_worker/pulls/108","html_url":"https://github.com/alphagov/govuk_crawler_worker/pull/108","diff_url":"https://github.com/alphagov/govuk_crawler_worker/pull/108.diff","patch_url":"https://github.com/alphagov/govuk_crawler_worker/pull/108.patch"},"body":"Version bump due to CVE-2016-5386 (or [\"httpoxy\"](https://httpoxy.org/)).\r\n\r\nNow Go 1.7 has been released, the 1.5.x branch is no longer receiving security patches as per the [Go release cycle](https://github.com/golang/go/wiki/Go-Release-Cycle#release-maintenance), so here we're upgrading to 1.7.\r\n\r\nSome tests were failing due to a change in behaviour on closed connection handling between 1.5 and 1.6+ (see [this PoC](https://gist.github.com/timblair/2578882d17b294b534a24bbd7c4e123e)): we were relying on unspecified behaviour in the runtime which has since changed.\r\n\r\nThe test now checks the memory address of the most recent connection in the underlying `ProxyTCP` value, which is now exposed via `ProxyTCP.Connections`, and should change when the connections are killed.\r\n\r\nI also want to move dependency management away from Gom and over to Godep as part of this."},"comment":{"url":"https://api.github.com/repos/alphagov/govuk_crawler_worker/issues/comments/243714340","html_url":"https://github.com/alphagov/govuk_crawler_worker/pull/108#issuecomment-243714340","issue_url":"https://api.github.com/repos/alphagov/govuk_crawler_worker/issues/108","id":243714340,"user":{"login":"gpeng","id":5216,"avatar_url":"https://avatars.githubusercontent.com/u/5216?v=3","gravatar_id":"","url":"https://api.github.com/users/gpeng","html_url":"https://github.com/gpeng","followers_url":"https://api.github.com/users/gpeng/followers","following_url":"https://api.github.com/users/gpeng/following{/other_user}","gists_url":"https://api.github.com/users/gpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/gpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpeng/subscriptions","organizations_url":"https://api.github.com/users/gpeng/orgs","repos_url":"https://api.github.com/users/gpeng/repos","events_url":"https://api.github.com/users/gpeng/events{/privacy}","received_events_url":"https://api.github.com/users/gpeng/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T09:47:29Z","updated_at":"2016-08-31T09:47:29Z","body":":+1: Nice workaround for that dodgy test too 💯 "}}
{"actor":{"display_login":"gpeng"}}