{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/17","id":58122012,"html_url":"https://github.com/frankmcsherry/timely-dataflow/pull/17","diff_url":"https://github.com/frankmcsherry/timely-dataflow/pull/17.diff","patch_url":"https://github.com/frankmcsherry/timely-dataflow/pull/17.patch","issue_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/issues/17","number":17,"state":"closed","locked":false,"title":"Capability-based api for operators","user":{"login":"utaal","id":791335,"avatar_url":"https://avatars.githubusercontent.com/u/791335?v=3","gravatar_id":"","url":"https://api.github.com/users/utaal","html_url":"https://github.com/utaal","followers_url":"https://api.github.com/users/utaal/followers","following_url":"https://api.github.com/users/utaal/following{/other_user}","gists_url":"https://api.github.com/users/utaal/gists{/gist_id}","starred_url":"https://api.github.com/users/utaal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utaal/subscriptions","organizations_url":"https://api.github.com/users/utaal/orgs","repos_url":"https://api.github.com/users/utaal/repos","events_url":"https://api.github.com/users/utaal/events{/privacy}","received_events_url":"https://api.github.com/users/utaal/received_events","type":"User","site_admin":false},"body":"Hi Frank,\r\nhere's a (mostly) cleaned up branch for my attempt at providing a capability-based API to enforce the operator contract.\r\n~~It still needs docstrings and possibly one final rebase to cleanup the history.~~\r\n\r\nA couple of things to note:\r\n\r\n* `InputHandle`, `OutputHandle` and `Capability` can only be constructed from within the \"operators\" module, this should make it impossible(?) for someone to mint a new `Capability` out of thin air or to `mem::replace` the `*Handle`s; moreover the field of the `*Handle`s are private, which should prevent the user from tampering with the underlying `Counter`s and `Buffer`s. (And yes, it seems like you cannot make `impl` member package-private, if they're `pub` they're always re-exported when exporting the corresponding trait/struct and if they aren't `pub` they're impl-local. From what I gathered from #rust yesterday night this is the idiomatic way of module-private apis, they're talking about adding module-level visibility modifiers but they're still a long ways off.)\r\n* ~~My approach to `Notificator` is hybrid, it's not relied upon for progress tracking anymore but it still retains most of the original logic.~~ (I changed my mind on this as I realized my \"optimization\" was in fact quite the opposite - I rewrote it, but I need to take another look at it.)\r\n\r\n~~Feel free to wait for me to add the docstrings before going through the code, I just wanted to let you know that I haven't fled to Hawaii or something :)~~","created_at":"2016-02-03T11:08:11Z","updated_at":"2016-02-11T07:10:57Z","closed_at":"2016-02-11T07:10:57Z","merged_at":"2016-02-11T07:10:57Z","merge_commit_sha":"227aaf5156e1b31601b86c1366acb085caf8401c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/17/commits","review_comments_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/17/comments","review_comment_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/issues/17/comments","statuses_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/statuses/b9e89d3e87f2736e81b2ad844985863dd26b40a8","head":{"label":"utaal:capabilities","ref":"capabilities","sha":"b9e89d3e87f2736e81b2ad844985863dd26b40a8","user":{"login":"utaal","id":791335,"avatar_url":"https://avatars.githubusercontent.com/u/791335?v=3","gravatar_id":"","url":"https://api.github.com/users/utaal","html_url":"https://github.com/utaal","followers_url":"https://api.github.com/users/utaal/followers","following_url":"https://api.github.com/users/utaal/following{/other_user}","gists_url":"https://api.github.com/users/utaal/gists{/gist_id}","starred_url":"https://api.github.com/users/utaal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utaal/subscriptions","organizations_url":"https://api.github.com/users/utaal/orgs","repos_url":"https://api.github.com/users/utaal/repos","events_url":"https://api.github.com/users/utaal/events{/privacy}","received_events_url":"https://api.github.com/users/utaal/received_events","type":"User","site_admin":false},"repo":{"id":42669257,"name":"timely-dataflow","full_name":"utaal/timely-dataflow","owner":{"login":"utaal","id":791335,"avatar_url":"https://avatars.githubusercontent.com/u/791335?v=3","gravatar_id":"","url":"https://api.github.com/users/utaal","html_url":"https://github.com/utaal","followers_url":"https://api.github.com/users/utaal/followers","following_url":"https://api.github.com/users/utaal/following{/other_user}","gists_url":"https://api.github.com/users/utaal/gists{/gist_id}","starred_url":"https://api.github.com/users/utaal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utaal/subscriptions","organizations_url":"https://api.github.com/users/utaal/orgs","repos_url":"https://api.github.com/users/utaal/repos","events_url":"https://api.github.com/users/utaal/events{/privacy}","received_events_url":"https://api.github.com/users/utaal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/utaal/timely-dataflow","description":"A modular implementation of timely dataflow in Rust","fork":true,"url":"https://api.github.com/repos/utaal/timely-dataflow","forks_url":"https://api.github.com/repos/utaal/timely-dataflow/forks","keys_url":"https://api.github.com/repos/utaal/timely-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/utaal/timely-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/utaal/timely-dataflow/teams","hooks_url":"https://api.github.com/repos/utaal/timely-dataflow/hooks","issue_events_url":"https://api.github.com/repos/utaal/timely-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/utaal/timely-dataflow/events","assignees_url":"https://api.github.com/repos/utaal/timely-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/utaal/timely-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/utaal/timely-dataflow/tags","blobs_url":"https://api.github.com/repos/utaal/timely-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/utaal/timely-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/utaal/timely-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/utaal/timely-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/utaal/timely-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/utaal/timely-dataflow/languages","stargazers_url":"https://api.github.com/repos/utaal/timely-dataflow/stargazers","contributors_url":"https://api.github.com/repos/utaal/timely-dataflow/contributors","subscribers_url":"https://api.github.com/repos/utaal/timely-dataflow/subscribers","subscription_url":"https://api.github.com/repos/utaal/timely-dataflow/subscription","commits_url":"https://api.github.com/repos/utaal/timely-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/utaal/timely-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/utaal/timely-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/utaal/timely-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/utaal/timely-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/utaal/timely-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/utaal/timely-dataflow/merges","archive_url":"https://api.github.com/repos/utaal/timely-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/utaal/timely-dataflow/downloads","issues_url":"https://api.github.com/repos/utaal/timely-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/utaal/timely-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/utaal/timely-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/utaal/timely-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/utaal/timely-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/utaal/timely-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/utaal/timely-dataflow/deployments","created_at":"2015-09-17T16:58:02Z","updated_at":"2016-02-03T10:26:53Z","pushed_at":"2016-02-09T10:53:06Z","git_url":"git://github.com/utaal/timely-dataflow.git","ssh_url":"git@github.com:utaal/timely-dataflow.git","clone_url":"https://github.com/utaal/timely-dataflow.git","svn_url":"https://github.com/utaal/timely-dataflow","homepage":"","size":5519,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"frankmcsherry:master","ref":"master","sha":"982b63e07736d8f2696db2555459861e5f2ebe00","user":{"login":"frankmcsherry","id":5741500,"avatar_url":"https://avatars.githubusercontent.com/u/5741500?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmcsherry","html_url":"https://github.com/frankmcsherry","followers_url":"https://api.github.com/users/frankmcsherry/followers","following_url":"https://api.github.com/users/frankmcsherry/following{/other_user}","gists_url":"https://api.github.com/users/frankmcsherry/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmcsherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmcsherry/subscriptions","organizations_url":"https://api.github.com/users/frankmcsherry/orgs","repos_url":"https://api.github.com/users/frankmcsherry/repos","events_url":"https://api.github.com/users/frankmcsherry/events{/privacy}","received_events_url":"https://api.github.com/users/frankmcsherry/received_events","type":"User","site_admin":false},"repo":{"id":27680789,"name":"timely-dataflow","full_name":"frankmcsherry/timely-dataflow","owner":{"login":"frankmcsherry","id":5741500,"avatar_url":"https://avatars.githubusercontent.com/u/5741500?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmcsherry","html_url":"https://github.com/frankmcsherry","followers_url":"https://api.github.com/users/frankmcsherry/followers","following_url":"https://api.github.com/users/frankmcsherry/following{/other_user}","gists_url":"https://api.github.com/users/frankmcsherry/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmcsherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmcsherry/subscriptions","organizations_url":"https://api.github.com/users/frankmcsherry/orgs","repos_url":"https://api.github.com/users/frankmcsherry/repos","events_url":"https://api.github.com/users/frankmcsherry/events{/privacy}","received_events_url":"https://api.github.com/users/frankmcsherry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frankmcsherry/timely-dataflow","description":"A modular implementation of timely dataflow in Rust","fork":false,"url":"https://api.github.com/repos/frankmcsherry/timely-dataflow","forks_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/forks","keys_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/teams","hooks_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/hooks","issue_events_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/events","assignees_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/tags","blobs_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/languages","stargazers_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/stargazers","contributors_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/contributors","subscribers_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/subscribers","subscription_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/subscription","commits_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/merges","archive_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/downloads","issues_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/frankmcsherry/timely-dataflow/deployments","created_at":"2014-12-07T18:54:59Z","updated_at":"2016-02-10T02:31:05Z","pushed_at":"2016-02-11T07:10:57Z","git_url":"git://github.com/frankmcsherry/timely-dataflow.git","ssh_url":"git@github.com:frankmcsherry/timely-dataflow.git","clone_url":"https://github.com/frankmcsherry/timely-dataflow.git","svn_url":"https://github.com/frankmcsherry/timely-dataflow","homepage":"","size":6017,"stargazers_count":246,"watchers_count":246,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":0,"forks":15,"open_issues":0,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/17"},"html":{"href":"https://github.com/frankmcsherry/timely-dataflow/pull/17"},"issue":{"href":"https://api.github.com/repos/frankmcsherry/timely-dataflow/issues/17"},"comments":{"href":"https://api.github.com/repos/frankmcsherry/timely-dataflow/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frankmcsherry/timely-dataflow/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/frankmcsherry/timely-dataflow/statuses/b9e89d3e87f2736e81b2ad844985863dd26b40a8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"frankmcsherry","id":5741500,"avatar_url":"https://avatars.githubusercontent.com/u/5741500?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmcsherry","html_url":"https://github.com/frankmcsherry","followers_url":"https://api.github.com/users/frankmcsherry/followers","following_url":"https://api.github.com/users/frankmcsherry/following{/other_user}","gists_url":"https://api.github.com/users/frankmcsherry/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmcsherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmcsherry/subscriptions","organizations_url":"https://api.github.com/users/frankmcsherry/orgs","repos_url":"https://api.github.com/users/frankmcsherry/repos","events_url":"https://api.github.com/users/frankmcsherry/events{/privacy}","received_events_url":"https://api.github.com/users/frankmcsherry/received_events","type":"User","site_admin":false},"comments":4,"review_comments":11,"commits":15,"additions":575,"deletions":235,"changed_files":20}}