{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/87594818","pull_request_review_id":8203217,"id":87594818,"diff_hunk":"@@ -39,13 +39,13 @@\n          </div>\n          <div class=\"form-group\">\n            <label class=\"col-sm-2 control-label\" for=\"type\">Type:</label>\n-           <div class=\"col-sm-10\">\n-            <select pf-select ng-model=\"type\" id=\"type\" ng-options=\"o as o for o in types\"></select>\n+           <div class=\"col-sm-4\">\n+            <div pf-bootstrap-select current-selection=\"type\" id=\"type\" selections=\"types\"></divselect>","path":"src/notification/inline-notification.directive.js","position":7,"original_position":7,"commit_id":"4512cc4d286f51bc55b3879846809ad5c20190f4","original_commit_id":"4512cc4d286f51bc55b3879846809ad5c20190f4","user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"body":"Nope. I will fix that. Thanks.","created_at":"2016-11-11T14:24:05Z","updated_at":"2016-11-11T14:24:05Z","html_url":"https://github.com/patternfly/angular-patternfly/pull/337#discussion_r87594818","pull_request_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/87594818"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/337#discussion_r87594818"},"pull_request":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337","id":92198792,"html_url":"https://github.com/patternfly/angular-patternfly/pull/337","diff_url":"https://github.com/patternfly/angular-patternfly/pull/337.diff","patch_url":"https://github.com/patternfly/angular-patternfly/pull/337.patch","issue_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/337","number":337,"state":"open","locked":false,"title":"Remove JQuery dependency from default modules","user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis PR removes the JQuery dependency from the default patternfly module. Two of the existing directives have been moved from the default module to patternfly.jquery: pfSelect and pfDatepicker. To use either of these directives add the patternfly.jquery module to your application module.\r\n\r\nAn additional directive, pfBootstrapSelect, has been added to achieve the same basic features of pfSelect but without the JQuery dependency.\r\n\r\nThe angular patternfly code has been adjusted to use the non-JQuery patternfly settings. To keep JQuery independence, include only patternfly-settings.js rather than patternfly.js.\r\n\r\n@dtaylor113 @dgutride @dlabrecq @bleathem ","created_at":"2016-11-03T17:10:53Z","updated_at":"2016-11-11T14:24:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1766c8332aca8e16bb68f627326eb69a12bdf44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337/commits","review_comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337/comments","review_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/337/comments","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/4512cc4d286f51bc55b3879846809ad5c20190f4","head":{"label":"jeff-phillips-18:no-jquery","ref":"no-jquery","sha":"4512cc4d286f51bc55b3879846809ad5c20190f4","user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"repo":{"id":40719634,"name":"angular-patternfly","full_name":"jeff-phillips-18/angular-patternfly","owner":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeff-phillips-18/angular-patternfly","description":null,"fork":true,"url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly","forks_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/forks","keys_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/events","assignees_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/merges","archive_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/deployments","created_at":"2015-08-14T14:38:46Z","updated_at":"2016-02-01T17:55:04Z","pushed_at":"2016-11-10T13:33:40Z","git_url":"git://github.com/jeff-phillips-18/angular-patternfly.git","ssh_url":"git@github.com:jeff-phillips-18/angular-patternfly.git","clone_url":"https://github.com/jeff-phillips-18/angular-patternfly.git","svn_url":"https://github.com/jeff-phillips-18/angular-patternfly","homepage":null,"size":3829,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"40f89b3833bad7bff1e6f1ac98f097ff7b48a22e","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":17672427,"name":"angular-patternfly","full_name":"patternfly/angular-patternfly","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/angular-patternfly","description":"A set of common AngularJS directives for use with the PatternFly reference implementation.","fork":false,"url":"https://api.github.com/repos/patternfly/angular-patternfly","forks_url":"https://api.github.com/repos/patternfly/angular-patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/angular-patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/angular-patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/angular-patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/angular-patternfly/deployments","created_at":"2014-03-12T15:43:51Z","updated_at":"2016-11-03T14:31:52Z","pushed_at":"2016-11-11T02:30:11Z","git_url":"git://github.com/patternfly/angular-patternfly.git","ssh_url":"git@github.com:patternfly/angular-patternfly.git","clone_url":"https://github.com/patternfly/angular-patternfly.git","svn_url":"https://github.com/patternfly/angular-patternfly","homepage":"http://angular-patternfly.rhcloud.com/#/api","size":7116,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":31,"forks":53,"open_issues":31,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/337"},"issue":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/337"},"comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/4512cc4d286f51bc55b3879846809ad5c20190f4"}}}}
{"actor":{"display_login":"jeff-phillips-18"}}