{"action":"created","comment":{"url":"https://api.github.com/repos/koldovsky/kids-room/pulls/comments/88507464","pull_request_review_id":9079829,"id":88507464,"diff_hunk":"@@ -0,0 +1,37 @@\n+/**\n+ * Created by Вова on 14.11.2016.\n+ */\n+$(document).ready(function() {\n+    $(function() {\n+        $.validator.addMethod(\"regexFirstName\", function(value, element, regexpr) {\n+            return regexpr.test(value);\n+        }, \"Все плохо\");\n+        $.validator.addMethod(\"regexLastName\", function(value, element, regexpr) {\n+            return regexpr.test(value);\n+        }, \"Все плохо\");\n+        $('#editkidform').validate({\n+            rules:{\n+\n+                firstName: {\n+                    required: true,\n+                    minlength: 2,\n+                    regexFirstName: /^[a-zA-ZАаБбВвГгҐґДдЕеЄєЖжЗзИиІіЇїЙйКкЛлМмНнОоПпРрСсТтУуФфХхЦцЧчШшЩщЬьЮюЯя]+$/\n+                },\n+                lastName: {\n+                    required: true,\n+                    minlength: 2,\n+                    regexLastName: /^[a-zA-ZАаБбВвГгҐґДдЕеЄєЖжЗзИиІіЇїЙйКкЛлМмНнОоПпРрСсТтУуФфХхЦцЧчШшЩщЬьЮюЯя]+$/\n+                }\n+\n+            }, messages: {\n+                firstName: {\n+                    required: \"Будь ласка введіть щонайменше 2 символи\"\n+\n+                },\n+                lastName: {\n+                    required: \"Будь ласка введіть щонайменше 2 символи\"\n+                }\n+            }\n+        });\n+    });\n+});","path":"src/main/webapp/resources/js/validation-edit-kid-ua.js","position":37,"original_position":37,"commit_id":"b177c04472e63d95e2554bd17b7e41e3eea897bb","original_commit_id":"b177c04472e63d95e2554bd17b7e41e3eea897bb","user":{"login":"merkan3k","id":19558533,"avatar_url":"https://avatars.githubusercontent.com/u/19558533?v=3","gravatar_id":"","url":"https://api.github.com/users/merkan3k","html_url":"https://github.com/merkan3k","followers_url":"https://api.github.com/users/merkan3k/followers","following_url":"https://api.github.com/users/merkan3k/following{/other_user}","gists_url":"https://api.github.com/users/merkan3k/gists{/gist_id}","starred_url":"https://api.github.com/users/merkan3k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merkan3k/subscriptions","organizations_url":"https://api.github.com/users/merkan3k/orgs","repos_url":"https://api.github.com/users/merkan3k/repos","events_url":"https://api.github.com/users/merkan3k/events{/privacy}","received_events_url":"https://api.github.com/users/merkan3k/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-11-17T17:50:09Z","updated_at":"2016-11-17T17:50:09Z","html_url":"https://github.com/koldovsky/kids-room/pull/24#discussion_r88507464","pull_request_url":"https://api.github.com/repos/koldovsky/kids-room/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/koldovsky/kids-room/pulls/comments/88507464"},"html":{"href":"https://github.com/koldovsky/kids-room/pull/24#discussion_r88507464"},"pull_request":{"href":"https://api.github.com/repos/koldovsky/kids-room/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/koldovsky/kids-room/pulls/24","id":94075602,"html_url":"https://github.com/koldovsky/kids-room/pull/24","diff_url":"https://github.com/koldovsky/kids-room/pull/24.diff","patch_url":"https://github.com/koldovsky/kids-room/pull/24.patch","issue_url":"https://api.github.com/repos/koldovsky/kids-room/issues/24","number":24,"state":"open","locked":false,"title":"edit kid - names must be > 1 character","user":{"login":"merkan3k","id":19558533,"avatar_url":"https://avatars.githubusercontent.com/u/19558533?v=3","gravatar_id":"","url":"https://api.github.com/users/merkan3k","html_url":"https://github.com/merkan3k","followers_url":"https://api.github.com/users/merkan3k/followers","following_url":"https://api.github.com/users/merkan3k/following{/other_user}","gists_url":"https://api.github.com/users/merkan3k/gists{/gist_id}","starred_url":"https://api.github.com/users/merkan3k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merkan3k/subscriptions","organizations_url":"https://api.github.com/users/merkan3k/orgs","repos_url":"https://api.github.com/users/merkan3k/repos","events_url":"https://api.github.com/users/merkan3k/events{/privacy}","received_events_url":"https://api.github.com/users/merkan3k/received_events","type":"User","site_admin":false},"body":"LVJAVS-458 - Error messages don't appear when enter too short name in ‘First name’ and ‘Last name’ fields.\r\n\r\nВалідація проходить як на фронтенді - до файлу edit-my-kid.jsp додано скріпти validation-edit-kid.js та validation-edit-kid - ua.js, що використовуються в залежності від локалізації;\r\nтак і на бекенді - у файлі ChildValidator.java","created_at":"2016-11-16T23:53:01Z","updated_at":"2016-11-17T17:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62d6477e570d88aee19097b4adcdbde191c63991","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/koldovsky/kids-room/pulls/24/commits","review_comments_url":"https://api.github.com/repos/koldovsky/kids-room/pulls/24/comments","review_comment_url":"https://api.github.com/repos/koldovsky/kids-room/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koldovsky/kids-room/issues/24/comments","statuses_url":"https://api.github.com/repos/koldovsky/kids-room/statuses/b177c04472e63d95e2554bd17b7e41e3eea897bb","head":{"label":"koldovsky:VolodymyrMescherjak","ref":"VolodymyrMescherjak","sha":"b177c04472e63d95e2554bd17b7e41e3eea897bb","user":{"login":"koldovsky","id":4018712,"avatar_url":"https://avatars.githubusercontent.com/u/4018712?v=3","gravatar_id":"","url":"https://api.github.com/users/koldovsky","html_url":"https://github.com/koldovsky","followers_url":"https://api.github.com/users/koldovsky/followers","following_url":"https://api.github.com/users/koldovsky/following{/other_user}","gists_url":"https://api.github.com/users/koldovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/koldovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldovsky/subscriptions","organizations_url":"https://api.github.com/users/koldovsky/orgs","repos_url":"https://api.github.com/users/koldovsky/repos","events_url":"https://api.github.com/users/koldovsky/events{/privacy}","received_events_url":"https://api.github.com/users/koldovsky/received_events","type":"User","site_admin":false},"repo":{"id":57019174,"name":"kids-room","full_name":"koldovsky/kids-room","owner":{"login":"koldovsky","id":4018712,"avatar_url":"https://avatars.githubusercontent.com/u/4018712?v=3","gravatar_id":"","url":"https://api.github.com/users/koldovsky","html_url":"https://github.com/koldovsky","followers_url":"https://api.github.com/users/koldovsky/followers","following_url":"https://api.github.com/users/koldovsky/following{/other_user}","gists_url":"https://api.github.com/users/koldovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/koldovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldovsky/subscriptions","organizations_url":"https://api.github.com/users/koldovsky/orgs","repos_url":"https://api.github.com/users/koldovsky/repos","events_url":"https://api.github.com/users/koldovsky/events{/privacy}","received_events_url":"https://api.github.com/users/koldovsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koldovsky/kids-room","description":null,"fork":false,"url":"https://api.github.com/repos/koldovsky/kids-room","forks_url":"https://api.github.com/repos/koldovsky/kids-room/forks","keys_url":"https://api.github.com/repos/koldovsky/kids-room/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koldovsky/kids-room/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koldovsky/kids-room/teams","hooks_url":"https://api.github.com/repos/koldovsky/kids-room/hooks","issue_events_url":"https://api.github.com/repos/koldovsky/kids-room/issues/events{/number}","events_url":"https://api.github.com/repos/koldovsky/kids-room/events","assignees_url":"https://api.github.com/repos/koldovsky/kids-room/assignees{/user}","branches_url":"https://api.github.com/repos/koldovsky/kids-room/branches{/branch}","tags_url":"https://api.github.com/repos/koldovsky/kids-room/tags","blobs_url":"https://api.github.com/repos/koldovsky/kids-room/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koldovsky/kids-room/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koldovsky/kids-room/git/refs{/sha}","trees_url":"https://api.github.com/repos/koldovsky/kids-room/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koldovsky/kids-room/statuses/{sha}","languages_url":"https://api.github.com/repos/koldovsky/kids-room/languages","stargazers_url":"https://api.github.com/repos/koldovsky/kids-room/stargazers","contributors_url":"https://api.github.com/repos/koldovsky/kids-room/contributors","subscribers_url":"https://api.github.com/repos/koldovsky/kids-room/subscribers","subscription_url":"https://api.github.com/repos/koldovsky/kids-room/subscription","commits_url":"https://api.github.com/repos/koldovsky/kids-room/commits{/sha}","git_commits_url":"https://api.github.com/repos/koldovsky/kids-room/git/commits{/sha}","comments_url":"https://api.github.com/repos/koldovsky/kids-room/comments{/number}","issue_comment_url":"https://api.github.com/repos/koldovsky/kids-room/issues/comments{/number}","contents_url":"https://api.github.com/repos/koldovsky/kids-room/contents/{+path}","compare_url":"https://api.github.com/repos/koldovsky/kids-room/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koldovsky/kids-room/merges","archive_url":"https://api.github.com/repos/koldovsky/kids-room/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koldovsky/kids-room/downloads","issues_url":"https://api.github.com/repos/koldovsky/kids-room/issues{/number}","pulls_url":"https://api.github.com/repos/koldovsky/kids-room/pulls{/number}","milestones_url":"https://api.github.com/repos/koldovsky/kids-room/milestones{/number}","notifications_url":"https://api.github.com/repos/koldovsky/kids-room/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koldovsky/kids-room/labels{/name}","releases_url":"https://api.github.com/repos/koldovsky/kids-room/releases{/id}","deployments_url":"https://api.github.com/repos/koldovsky/kids-room/deployments","created_at":"2016-04-25T07:04:56Z","updated_at":"2016-11-02T07:48:29Z","pushed_at":"2016-11-17T11:19:27Z","git_url":"git://github.com/koldovsky/kids-room.git","ssh_url":"git@github.com:koldovsky/kids-room.git","clone_url":"https://github.com/koldovsky/kids-room.git","svn_url":"https://github.com/koldovsky/kids-room","homepage":null,"size":4764,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"koldovsky:dev","ref":"dev","sha":"1e470e05a55696d71b8655692e1e265db9de5ec7","user":{"login":"koldovsky","id":4018712,"avatar_url":"https://avatars.githubusercontent.com/u/4018712?v=3","gravatar_id":"","url":"https://api.github.com/users/koldovsky","html_url":"https://github.com/koldovsky","followers_url":"https://api.github.com/users/koldovsky/followers","following_url":"https://api.github.com/users/koldovsky/following{/other_user}","gists_url":"https://api.github.com/users/koldovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/koldovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldovsky/subscriptions","organizations_url":"https://api.github.com/users/koldovsky/orgs","repos_url":"https://api.github.com/users/koldovsky/repos","events_url":"https://api.github.com/users/koldovsky/events{/privacy}","received_events_url":"https://api.github.com/users/koldovsky/received_events","type":"User","site_admin":false},"repo":{"id":57019174,"name":"kids-room","full_name":"koldovsky/kids-room","owner":{"login":"koldovsky","id":4018712,"avatar_url":"https://avatars.githubusercontent.com/u/4018712?v=3","gravatar_id":"","url":"https://api.github.com/users/koldovsky","html_url":"https://github.com/koldovsky","followers_url":"https://api.github.com/users/koldovsky/followers","following_url":"https://api.github.com/users/koldovsky/following{/other_user}","gists_url":"https://api.github.com/users/koldovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/koldovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldovsky/subscriptions","organizations_url":"https://api.github.com/users/koldovsky/orgs","repos_url":"https://api.github.com/users/koldovsky/repos","events_url":"https://api.github.com/users/koldovsky/events{/privacy}","received_events_url":"https://api.github.com/users/koldovsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koldovsky/kids-room","description":null,"fork":false,"url":"https://api.github.com/repos/koldovsky/kids-room","forks_url":"https://api.github.com/repos/koldovsky/kids-room/forks","keys_url":"https://api.github.com/repos/koldovsky/kids-room/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koldovsky/kids-room/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koldovsky/kids-room/teams","hooks_url":"https://api.github.com/repos/koldovsky/kids-room/hooks","issue_events_url":"https://api.github.com/repos/koldovsky/kids-room/issues/events{/number}","events_url":"https://api.github.com/repos/koldovsky/kids-room/events","assignees_url":"https://api.github.com/repos/koldovsky/kids-room/assignees{/user}","branches_url":"https://api.github.com/repos/koldovsky/kids-room/branches{/branch}","tags_url":"https://api.github.com/repos/koldovsky/kids-room/tags","blobs_url":"https://api.github.com/repos/koldovsky/kids-room/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koldovsky/kids-room/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koldovsky/kids-room/git/refs{/sha}","trees_url":"https://api.github.com/repos/koldovsky/kids-room/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koldovsky/kids-room/statuses/{sha}","languages_url":"https://api.github.com/repos/koldovsky/kids-room/languages","stargazers_url":"https://api.github.com/repos/koldovsky/kids-room/stargazers","contributors_url":"https://api.github.com/repos/koldovsky/kids-room/contributors","subscribers_url":"https://api.github.com/repos/koldovsky/kids-room/subscribers","subscription_url":"https://api.github.com/repos/koldovsky/kids-room/subscription","commits_url":"https://api.github.com/repos/koldovsky/kids-room/commits{/sha}","git_commits_url":"https://api.github.com/repos/koldovsky/kids-room/git/commits{/sha}","comments_url":"https://api.github.com/repos/koldovsky/kids-room/comments{/number}","issue_comment_url":"https://api.github.com/repos/koldovsky/kids-room/issues/comments{/number}","contents_url":"https://api.github.com/repos/koldovsky/kids-room/contents/{+path}","compare_url":"https://api.github.com/repos/koldovsky/kids-room/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koldovsky/kids-room/merges","archive_url":"https://api.github.com/repos/koldovsky/kids-room/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koldovsky/kids-room/downloads","issues_url":"https://api.github.com/repos/koldovsky/kids-room/issues{/number}","pulls_url":"https://api.github.com/repos/koldovsky/kids-room/pulls{/number}","milestones_url":"https://api.github.com/repos/koldovsky/kids-room/milestones{/number}","notifications_url":"https://api.github.com/repos/koldovsky/kids-room/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koldovsky/kids-room/labels{/name}","releases_url":"https://api.github.com/repos/koldovsky/kids-room/releases{/id}","deployments_url":"https://api.github.com/repos/koldovsky/kids-room/deployments","created_at":"2016-04-25T07:04:56Z","updated_at":"2016-11-02T07:48:29Z","pushed_at":"2016-11-17T11:19:27Z","git_url":"git://github.com/koldovsky/kids-room.git","ssh_url":"git@github.com:koldovsky/kids-room.git","clone_url":"https://github.com/koldovsky/kids-room.git","svn_url":"https://github.com/koldovsky/kids-room","homepage":null,"size":4764,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koldovsky/kids-room/pulls/24"},"html":{"href":"https://github.com/koldovsky/kids-room/pull/24"},"issue":{"href":"https://api.github.com/repos/koldovsky/kids-room/issues/24"},"comments":{"href":"https://api.github.com/repos/koldovsky/kids-room/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/koldovsky/kids-room/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/koldovsky/kids-room/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koldovsky/kids-room/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/koldovsky/kids-room/statuses/b177c04472e63d95e2554bd17b7e41e3eea897bb"}}}}
{"actor":{"display_login":"merkan3k"}}