{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/92878797","pull_request_review_id":13403658,"id":92878797,"diff_hunk":"@@ -48,7 +48,7 @@ Run the following commands:\n {% highlight bash %}\n cd samza-rest/build/distributions/\n mkdir -p deploy/samza-rest\n-tar -xvf ./samza-rest-0.10.1-SNAPSHOT.tgz -C deploy/samza-rest\n+tar -xvf ./samza-rest-0.11.0-SNAPSHOT.tgz -C deploy/samza-rest","path":"docs/learn/tutorials/versioned/samza-rest-getting-started.md","position":5,"original_position":5,"commit_id":"daa6a365dded20be6d1436dc30b0fc3bc653679e","original_commit_id":"daa6a365dded20be6d1436dc30b0fc3bc653679e","user":{"login":"shanthoosh","id":483745,"avatar_url":"https://avatars.githubusercontent.com/u/483745?v=3","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"body":"We've tested and validated this kafka patch with internal samza build at LinkedIn. This looks good.","created_at":"2016-12-16T20:15:19Z","updated_at":"2016-12-16T20:15:19Z","html_url":"https://github.com/apache/samza/pull/15#discussion_r92878797","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/92878797"},"html":{"href":"https://github.com/apache/samza/pull/15#discussion_r92878797"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/15","id":86359698,"html_url":"https://github.com/apache/samza/pull/15","diff_url":"https://github.com/apache/samza/pull/15.diff","patch_url":"https://github.com/apache/samza/pull/15.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/15","number":15,"state":"open","locked":false,"title":"Samza on Kafka 0.10","user":{"login":"ncolomer","id":941891,"avatar_url":"https://avatars.githubusercontent.com/u/941891?v=3","gravatar_id":"","url":"https://api.github.com/users/ncolomer","html_url":"https://github.com/ncolomer","followers_url":"https://api.github.com/users/ncolomer/followers","following_url":"https://api.github.com/users/ncolomer/following{/other_user}","gists_url":"https://api.github.com/users/ncolomer/gists{/gist_id}","starred_url":"https://api.github.com/users/ncolomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncolomer/subscriptions","organizations_url":"https://api.github.com/users/ncolomer/orgs","repos_url":"https://api.github.com/users/ncolomer/repos","events_url":"https://api.github.com/users/ncolomer/events{/privacy}","received_events_url":"https://api.github.com/users/ncolomer/received_events","type":"User","site_admin":false},"body":"This PR aims to make Samza run with Kafka 0.10.\n\nRelated material:\n- [SAMZA-855](https://issues.apache.org/jira/browse/SAMZA-855) - Upgrade Samza's Kafka client version to 0.10.0.0\n- [RB-49212](https://reviews.apache.org/r/49212) - RFC: SAMZA-855: Update kafka client to 0.10.0.0\n\nOrignal [patch](https://reviews.apache.org/r/49212/diff/1#4) submitted by Robert Crim was used and rebased on current Samza's master branch.\n\nNext steps:\n- [x] make unit tests pass using \n  \n  ``` bash\n  ./gradlew clean test\n  ```\n- [x] make integration tests pass using \n  See [Running Integration Tests Locally](http://samza.apache.org/contribute/tests.html) and [Setup passphraseless ssh to localhost on OS X](http://stackoverflow.com/a/7134542/739479)\n  \n  ``` bash\n  # Enable no-password self-login ssh\n  ssh-copy-id -i ~/.ssh/id_rsa.pub localhost\n  # Check JAVA_HOME is correctly set (if not and you run on zsh, edit ~/.zshenv and add it)\n  ssh localhost 'echo $JAVA_HOME'\n  # Run integration tests\n  ./bin/integration-tests.sh /tmp/samza-tests-$(date +%Y%m%d%H%M%S) --nopassword\n  # In case of failure, make sure all sytem ports are available on your hosts\n  ```\n  \n  ![image](https://lh3.googleusercontent.com/LN_hfGJ3R-DPsPjqJB4GFRFMa36CkmB_IU2ntW43doSZdR70O_5VnQOD627pSDo761V4Oi7qdw=w5760-h3600-rw-no)\n  \n  Here are tests logs.\n  \n  ```\n  2016-09-23 14:43:26 zopkio [INFO] Starting zopkio\n  2016-09-23 14:43:26 naarad [INFO] Available graphing modules:  \n  2016-09-23 14:43:26 zopkio.test_runner [INFO] Setting up configuration: single execution\n  2016-09-23 14:43:26 deployment [INFO] Current working directory: /private/tmp/samza-tests-20160923144307\n  2016-09-23 14:43:26 deployment [INFO] Downloading: https://archive.apache.org/dist/hadoop/common/hadoop-2.6.1/hadoop-2.6.1.tar.gz\n  2016-09-23 14:44:08 deployment [INFO] Downloading: http://archive.apache.org/dist/kafka/0.10.0.1/kafka_2.10-0.10.0.1.tgz\n  2016-09-23 14:44:15 deployment [INFO] Downloading: http://archive.apache.org/dist/zookeeper/zookeeper-3.4.6/zookeeper-3.4.6.tar.gz\n  2016-09-23 14:44:20 deployment [INFO] Deploying zookeeper_instance_0 on host: localhost\n  2016-09-23 14:44:22 deployment [INFO] Deploying yarn_rm_instance_0 on host: localhost\n  2016-09-23 14:44:27 deployment [INFO] Deploying yarn_nm_instance_0 on host: localhost\n  2016-09-23 14:44:33 deployment [INFO] Deploying kafka_instance_0 on host: localhost\n  2016-09-23 14:44:34 samza_job_yarn_deployer [INFO] Deploying tests on host: localhost\n  2016-09-23 14:44:37 samza_job_yarn_deployer [INFO] Installing yarn-site.xml to /private/tmp/samza-tests-20160923144307/tests/config/yarn-site.xml\n  2016-09-23 14:44:37 smoke_tests [INFO] Running test_samza_job\n  2016-09-23 14:44:37 kafka.client [ERROR] Error loading topic metadata for samza-test-topic: <class 'kafka.errors.LeaderNotAvailableError'> (5)\n  2016-09-23 14:44:38 util [INFO] Starting tests.negate_number\n  2016-09-23 14:44:41 util [INFO] Awaiting tests.negate_number\n  2016-09-23 14:44:58 util [INFO] Starting tests.container-performance\n  2016-09-23 14:45:02 util [INFO] Awaiting tests.container-performance\n  2016-09-23 14:46:13 performance_tests [INFO] Running test_kafka_read_write_performance\n  2016-09-23 14:46:13 kafka.client [ERROR] Error loading topic metadata for kafka-read-write-performance-input: <class 'kafka.errors.LeaderNotAvailableError'> (5)\n  2016-09-23 14:46:14 performance_tests [INFO] Loading 1000000 test messages.\n  2016-09-23 14:46:14 performance_tests [INFO] Loaded 0 messages.\n  2016-09-23 14:46:42 performance_tests [INFO] Loaded 100000 messages.\n  2016-09-23 14:47:10 performance_tests [INFO] Loaded 200000 messages.\n  2016-09-23 14:47:37 performance_tests [INFO] Loaded 300000 messages.\n  2016-09-23 14:48:04 performance_tests [INFO] Loaded 400000 messages.\n  2016-09-23 14:48:30 performance_tests [INFO] Loaded 500000 messages.\n  2016-09-23 14:48:57 performance_tests [INFO] Loaded 600000 messages.\n  2016-09-23 14:49:24 performance_tests [INFO] Loaded 700000 messages.\n  2016-09-23 14:49:53 performance_tests [INFO] Loaded 800000 messages.\n  2016-09-23 14:50:21 performance_tests [INFO] Loaded 900000 messages.\n  2016-09-23 14:50:46 util [INFO] Starting tests.kafka-read-write-performance\n  2016-09-23 14:50:50 util [INFO] Awaiting tests.kafka-read-write-performance\n  2016-09-23 14:51:33 zopkio.deployer [ERROR] Log file /tmp/samza-tests-20160923144307/deploy/kafka/log-cleaner.log does not exist on localhost\n  2016-09-23 14:51:33 naarad.utils [WARNING] /tmp/samza-tests-20160923144307/scripts/naarad.cfg : file does not exist.\n  2016-09-23 14:51:33 naarad.utils [WARNING] /tmp/samza-tests-20160923144307/scripts/naarad.cfg : file does not exist.\n  2016-09-23 14:51:33 naarad.utils [WARNING] /tmp/samza-tests-20160923144307/scripts/naarad.cfg : file does not exist.\n  2016-09-23 14:51:33 naarad.utils [WARNING] /tmp/samza-tests-20160923144307/scripts/naarad.cfg : file does not exist.\n  2016-09-23 14:51:33 smoke_tests [INFO] Running validate_samza_job\n  2016-09-23 14:51:33 performance_tests [INFO] Running validate_kafka_read_write_performance\n  2016-09-23 14:52:13 zopkio.remote_host_helper [INFO] stopping resourcemanager\n  2016-09-23 14:52:14 zopkio.remote_host_helper [INFO] Stopping zookeeper ... STOPPED\n  2016-09-23 14:52:20 zopkio.remote_host_helper [INFO] stopping nodemanager\n  nodemanager did not stop gracefully after 5 seconds: killing with kill -9\n  2016-09-23 14:52:21 zopkio.test_runner [INFO] Execution of configuration: single execution complete\n  2016-09-23 14:52:21 zopkio.test_runner [INFO] test_samza_job----passed\n  2016-09-23 14:52:21 zopkio.test_runner [INFO] test_container_performance----passed\n  2016-09-23 14:52:21 zopkio.test_runner [INFO] test_kafka_read_write_performance----passed\n  2016-09-23 14:52:21 zopkio [INFO] Exiting zopkio\n  ```\n- [x] deploy a job in staging on a Kafka 0.8.x cluster\n- [ ] deploy a job in production on a Kafka 0.8.x cluster\n- [ ] deploy a job in staging on a Kafka 0.10.x cluster\n- [ ] deploy a job in production on a Kafka 0.10.x cluster\n","created_at":"2016-09-22T15:25:33Z","updated_at":"2016-12-16T20:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f56d3bf2c9a7a8237a34d9b4b7f8f39763ee7e2a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/15/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/15/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/15/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/daa6a365dded20be6d1436dc30b0fc3bc653679e","head":{"label":"ncolomer:kafka10","ref":"kafka10","sha":"daa6a365dded20be6d1436dc30b0fc3bc653679e","user":{"login":"ncolomer","id":941891,"avatar_url":"https://avatars.githubusercontent.com/u/941891?v=3","gravatar_id":"","url":"https://api.github.com/users/ncolomer","html_url":"https://github.com/ncolomer","followers_url":"https://api.github.com/users/ncolomer/followers","following_url":"https://api.github.com/users/ncolomer/following{/other_user}","gists_url":"https://api.github.com/users/ncolomer/gists{/gist_id}","starred_url":"https://api.github.com/users/ncolomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncolomer/subscriptions","organizations_url":"https://api.github.com/users/ncolomer/orgs","repos_url":"https://api.github.com/users/ncolomer/repos","events_url":"https://api.github.com/users/ncolomer/events{/privacy}","received_events_url":"https://api.github.com/users/ncolomer/received_events","type":"User","site_admin":false},"repo":{"id":68930433,"name":"samza","full_name":"ncolomer/samza","owner":{"login":"ncolomer","id":941891,"avatar_url":"https://avatars.githubusercontent.com/u/941891?v=3","gravatar_id":"","url":"https://api.github.com/users/ncolomer","html_url":"https://github.com/ncolomer","followers_url":"https://api.github.com/users/ncolomer/followers","following_url":"https://api.github.com/users/ncolomer/following{/other_user}","gists_url":"https://api.github.com/users/ncolomer/gists{/gist_id}","starred_url":"https://api.github.com/users/ncolomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncolomer/subscriptions","organizations_url":"https://api.github.com/users/ncolomer/orgs","repos_url":"https://api.github.com/users/ncolomer/repos","events_url":"https://api.github.com/users/ncolomer/events{/privacy}","received_events_url":"https://api.github.com/users/ncolomer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncolomer/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/ncolomer/samza","forks_url":"https://api.github.com/repos/ncolomer/samza/forks","keys_url":"https://api.github.com/repos/ncolomer/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncolomer/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncolomer/samza/teams","hooks_url":"https://api.github.com/repos/ncolomer/samza/hooks","issue_events_url":"https://api.github.com/repos/ncolomer/samza/issues/events{/number}","events_url":"https://api.github.com/repos/ncolomer/samza/events","assignees_url":"https://api.github.com/repos/ncolomer/samza/assignees{/user}","branches_url":"https://api.github.com/repos/ncolomer/samza/branches{/branch}","tags_url":"https://api.github.com/repos/ncolomer/samza/tags","blobs_url":"https://api.github.com/repos/ncolomer/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncolomer/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncolomer/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncolomer/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncolomer/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/ncolomer/samza/languages","stargazers_url":"https://api.github.com/repos/ncolomer/samza/stargazers","contributors_url":"https://api.github.com/repos/ncolomer/samza/contributors","subscribers_url":"https://api.github.com/repos/ncolomer/samza/subscribers","subscription_url":"https://api.github.com/repos/ncolomer/samza/subscription","commits_url":"https://api.github.com/repos/ncolomer/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncolomer/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncolomer/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncolomer/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncolomer/samza/contents/{+path}","compare_url":"https://api.github.com/repos/ncolomer/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncolomer/samza/merges","archive_url":"https://api.github.com/repos/ncolomer/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncolomer/samza/downloads","issues_url":"https://api.github.com/repos/ncolomer/samza/issues{/number}","pulls_url":"https://api.github.com/repos/ncolomer/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/ncolomer/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/ncolomer/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncolomer/samza/labels{/name}","releases_url":"https://api.github.com/repos/ncolomer/samza/releases{/id}","deployments_url":"https://api.github.com/repos/ncolomer/samza/deployments","created_at":"2016-09-22T14:40:11Z","updated_at":"2016-09-22T14:40:14Z","pushed_at":"2016-10-12T14:14:44Z","git_url":"git://github.com/ncolomer/samza.git","ssh_url":"git@github.com:ncolomer/samza.git","clone_url":"https://github.com/ncolomer/samza.git","svn_url":"https://github.com/ncolomer/samza","homepage":null,"size":14522,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2216fe0b7b250e2edfc14d150e59f84884e8cba4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"name":"samza","full_name":"apache/samza","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2016-12-16T05:26:29Z","pushed_at":"2016-12-15T23:02:06Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":14814,"stargazers_count":273,"watchers_count":273,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":"git://git.apache.org/samza.git","open_issues_count":12,"forks":125,"open_issues":12,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/15"},"html":{"href":"https://github.com/apache/samza/pull/15"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/15"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/daa6a365dded20be6d1436dc30b0fc3bc653679e"}}}}
{"actor":{"display_login":"shanthoosh"}}