{"action":"created","issue":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/1248","repository_url":"https://api.github.com/repos/octokit/octokit.net","labels_url":"https://api.github.com/repos/octokit/octokit.net/issues/1248/labels{/name}","comments_url":"https://api.github.com/repos/octokit/octokit.net/issues/1248/comments","events_url":"https://api.github.com/repos/octokit/octokit.net/issues/1248/events","html_url":"https://github.com/octokit/octokit.net/pull/1248","id":146475879,"number":1248,"title":"Always Be Auditing Your Awaits","user":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-07T00:42:41Z","updated_at":"2016-04-08T16:46:48Z","closed_at":"2016-04-07T14:00:54Z","pull_request":{"url":"https://api.github.com/repos/octokit/octokit.net/pulls/1248","html_url":"https://github.com/octokit/octokit.net/pull/1248","diff_url":"https://github.com/octokit/octokit.net/pull/1248.diff","patch_url":"https://github.com/octokit/octokit.net/pull/1248.patch"},"body":"As discussed in #1111, there are some places where we use `await` but do not specify the context correctly.\r\n\r\nThis is me scanning the codebase and doing three things with each scenario I find:\r\n\r\n - if possible, drop the `async/await` usage completely\r\n - if not possible to remove, ensure `ConfigureAwait` is set\r\n - ensure that the `await` and `ConfigureAwait` are on the same line - to make finding and verifying these usages easier in the future\r\n\r\n<img width=\"1397\" src=\"https://cloud.githubusercontent.com/assets/359239/14336953/23a12f3c-fc37-11e5-864f-774167f93b4f.png\">\r\n\r\n - [x] integration tests passing\r\n\r\ncc @ryangribble as I found myself refactoring in some of the Enterprise API clients"},"comment":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/comments/207509037","html_url":"https://github.com/octokit/octokit.net/pull/1248#issuecomment-207509037","issue_url":"https://api.github.com/repos/octokit/octokit.net/issues/1248","id":207509037,"user":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"created_at":"2016-04-08T16:46:48Z","updated_at":"2016-04-08T16:46:48Z","body":"release_notes: added `ConfigureAwait(false)` to numerous locations to prevent deadlock scenarios for ASP.NET and WinForms users"}}