{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/swagger-router/pulls/comments/53050375","id":53050375,"diff_hunk":"@@ -138,7 +140,7 @@ function splitAndPrepareTAsseblyTemplate(templateSpec, options) {\n \n                 // TODO: Enable single brace structures outside of URI once\n                 // the specs are migrated to double brace.\n-                if (!inDoubleBrace && options.isURI) {\n+                if (!inDoubleBrace) {\n                     if (/^\\+/.test(currentTemplate)) {","path":"lib/reqTemplate.js","position":15,"original_position":15,"commit_id":"489cad2d34ee8e9eadf2e2a05bdb2ecda756f840","original_commit_id":"489cad2d34ee8e9eadf2e2a05bdb2ecda756f840","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars.githubusercontent.com/u/814754?v=3","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"body":"We can actually drop support for `+`, as it's equivalent to double braces. ","created_at":"2016-02-16T17:59:20Z","updated_at":"2016-02-16T17:59:20Z","html_url":"https://github.com/wikimedia/swagger-router/pull/38#discussion_r53050375","pull_request_url":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/swagger-router/pulls/comments/53050375"},"html":{"href":"https://github.com/wikimedia/swagger-router/pull/38#discussion_r53050375"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38","id":59248670,"html_url":"https://github.com/wikimedia/swagger-router/pull/38","diff_url":"https://github.com/wikimedia/swagger-router/pull/38.diff","patch_url":"https://github.com/wikimedia/swagger-router/pull/38.patch","issue_url":"https://api.github.com/repos/wikimedia/swagger-router/issues/38","number":38,"state":"open","locked":false,"title":"Clean up single vs. double brace handling","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"body":"- Consistently escape single brace expressions according to the rules of URI\r\n  templates. This lets us sanely support general path segment templating as\r\n  needed for https://phabricator.wikimedia.org/T126571.\r\n- Remove old-style $ prefixes from tests, but still support them.","created_at":"2016-02-13T00:02:01Z","updated_at":"2016-02-16T17:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48f9145c42b168af43d1eb70d70058ca8a7a89e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38/commits","review_comments_url":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38/comments","review_comment_url":"https://api.github.com/repos/wikimedia/swagger-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/swagger-router/issues/38/comments","statuses_url":"https://api.github.com/repos/wikimedia/swagger-router/statuses/489cad2d34ee8e9eadf2e2a05bdb2ecda756f840","head":{"label":"gwicke:single_brace_expression_cleanup","ref":"single_brace_expression_cleanup","sha":"489cad2d34ee8e9eadf2e2a05bdb2ecda756f840","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"repo":{"id":29213139,"name":"swagger-router","full_name":"gwicke/swagger-router","owner":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwicke/swagger-router","description":"A swagger 2 based router with support for assembling multiple APIs from swagger fragments. Developed in support of RESTBase.","fork":true,"url":"https://api.github.com/repos/gwicke/swagger-router","forks_url":"https://api.github.com/repos/gwicke/swagger-router/forks","keys_url":"https://api.github.com/repos/gwicke/swagger-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwicke/swagger-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwicke/swagger-router/teams","hooks_url":"https://api.github.com/repos/gwicke/swagger-router/hooks","issue_events_url":"https://api.github.com/repos/gwicke/swagger-router/issues/events{/number}","events_url":"https://api.github.com/repos/gwicke/swagger-router/events","assignees_url":"https://api.github.com/repos/gwicke/swagger-router/assignees{/user}","branches_url":"https://api.github.com/repos/gwicke/swagger-router/branches{/branch}","tags_url":"https://api.github.com/repos/gwicke/swagger-router/tags","blobs_url":"https://api.github.com/repos/gwicke/swagger-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwicke/swagger-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwicke/swagger-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwicke/swagger-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwicke/swagger-router/statuses/{sha}","languages_url":"https://api.github.com/repos/gwicke/swagger-router/languages","stargazers_url":"https://api.github.com/repos/gwicke/swagger-router/stargazers","contributors_url":"https://api.github.com/repos/gwicke/swagger-router/contributors","subscribers_url":"https://api.github.com/repos/gwicke/swagger-router/subscribers","subscription_url":"https://api.github.com/repos/gwicke/swagger-router/subscription","commits_url":"https://api.github.com/repos/gwicke/swagger-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwicke/swagger-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwicke/swagger-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwicke/swagger-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwicke/swagger-router/contents/{+path}","compare_url":"https://api.github.com/repos/gwicke/swagger-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwicke/swagger-router/merges","archive_url":"https://api.github.com/repos/gwicke/swagger-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwicke/swagger-router/downloads","issues_url":"https://api.github.com/repos/gwicke/swagger-router/issues{/number}","pulls_url":"https://api.github.com/repos/gwicke/swagger-router/pulls{/number}","milestones_url":"https://api.github.com/repos/gwicke/swagger-router/milestones{/number}","notifications_url":"https://api.github.com/repos/gwicke/swagger-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwicke/swagger-router/labels{/name}","releases_url":"https://api.github.com/repos/gwicke/swagger-router/releases{/id}","deployments_url":"https://api.github.com/repos/gwicke/swagger-router/deployments","created_at":"2015-01-13T21:53:26Z","updated_at":"2015-04-14T22:22:20Z","pushed_at":"2016-02-13T00:44:40Z","git_url":"git://github.com/gwicke/swagger-router.git","ssh_url":"git@github.com:gwicke/swagger-router.git","clone_url":"https://github.com/gwicke/swagger-router.git","svn_url":"https://github.com/gwicke/swagger-router","homepage":null,"size":119,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"6d1dbd5e8f5d6947ebd381e29cd7e964a240d204","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":28547115,"name":"swagger-router","full_name":"wikimedia/swagger-router","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/swagger-router","description":"A swagger 2 based router with support for assembling multiple APIs from swagger fragments. Developed in support of RESTBase.","fork":false,"url":"https://api.github.com/repos/wikimedia/swagger-router","forks_url":"https://api.github.com/repos/wikimedia/swagger-router/forks","keys_url":"https://api.github.com/repos/wikimedia/swagger-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/swagger-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/swagger-router/teams","hooks_url":"https://api.github.com/repos/wikimedia/swagger-router/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/swagger-router/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/swagger-router/events","assignees_url":"https://api.github.com/repos/wikimedia/swagger-router/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/swagger-router/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/swagger-router/tags","blobs_url":"https://api.github.com/repos/wikimedia/swagger-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/swagger-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/swagger-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/swagger-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/swagger-router/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/swagger-router/languages","stargazers_url":"https://api.github.com/repos/wikimedia/swagger-router/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/swagger-router/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/swagger-router/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/swagger-router/subscription","commits_url":"https://api.github.com/repos/wikimedia/swagger-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/swagger-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/swagger-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/swagger-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/swagger-router/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/swagger-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/swagger-router/merges","archive_url":"https://api.github.com/repos/wikimedia/swagger-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/swagger-router/downloads","issues_url":"https://api.github.com/repos/wikimedia/swagger-router/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/swagger-router/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/swagger-router/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/swagger-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/swagger-router/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/swagger-router/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/swagger-router/deployments","created_at":"2014-12-27T21:45:54Z","updated_at":"2016-01-19T23:23:27Z","pushed_at":"2016-02-13T01:01:17Z","git_url":"git://github.com/wikimedia/swagger-router.git","ssh_url":"git@github.com:wikimedia/swagger-router.git","clone_url":"https://github.com/wikimedia/swagger-router.git","svn_url":"https://github.com/wikimedia/swagger-router","homepage":null,"size":125,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38"},"html":{"href":"https://github.com/wikimedia/swagger-router/pull/38"},"issue":{"href":"https://api.github.com/repos/wikimedia/swagger-router/issues/38"},"comments":{"href":"https://api.github.com/repos/wikimedia/swagger-router/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/swagger-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/swagger-router/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/swagger-router/statuses/489cad2d34ee8e9eadf2e2a05bdb2ecda756f840"}}}}