{"action":"created","issue":{"url":"https://api.github.com/repos/casperjs/casperjs/issues/1736","repository_url":"https://api.github.com/repos/casperjs/casperjs","labels_url":"https://api.github.com/repos/casperjs/casperjs/issues/1736/labels{/name}","comments_url":"https://api.github.com/repos/casperjs/casperjs/issues/1736/comments","events_url":"https://api.github.com/repos/casperjs/casperjs/issues/1736/events","html_url":"https://github.com/casperjs/casperjs/issues/1736","id":195326235,"number":1736,"title":"Annoying failing visibility check issue with hidden ancestor","user":{"login":"amberv0","id":11645756,"avatar_url":"https://avatars.githubusercontent.com/u/11645756?v=3","gravatar_id":"","url":"https://api.github.com/users/amberv0","html_url":"https://github.com/amberv0","followers_url":"https://api.github.com/users/amberv0/followers","following_url":"https://api.github.com/users/amberv0/following{/other_user}","gists_url":"https://api.github.com/users/amberv0/gists{/gist_id}","starred_url":"https://api.github.com/users/amberv0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberv0/subscriptions","organizations_url":"https://api.github.com/users/amberv0/orgs","repos_url":"https://api.github.com/users/amberv0/repos","events_url":"https://api.github.com/users/amberv0/events{/privacy}","received_events_url":"https://api.github.com/users/amberv0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-13T18:06:46Z","updated_at":"2016-12-15T16:13:57Z","closed_at":null,"body":"Referencing #1222\r\nI'm wondering why it has been there for ages and nobody fixed that.\r\nSo in `clientutils.js` in the `this.elementVisible` part of the check is:\r\n```\r\n            var visibles = [\"inline\", \"inline-block\", \"flex\", \"inline-flex\"];\r\n            if (visibles.indexOf(style.display) !== -1) {\r\n                return true;\r\n            }\r\n```\r\n\r\nI really have no clue why it is done this way (but I suppose there should be a good reason) - but this obviously causes problems with hidden ancestors. E.g., imagine I have a button (inline-block) in a hidden div (my real case). This test will return automatically true, which is wrong. I checked computed styles in Chrome dev tools, it's indeed the case, my button has the `inline-block` display style.\r\n\r\nSo I tried to comment out this part. My own tests started running properly (which is good), but for some very strange reason quite a few selftests on casperjs failed. With the most widespread FAIL reason:\r\n`CasperError: evaluate() requires javascript to be enabled`. Which is very surprising - why on earth would the visibility check cause it?\r\n\r\nAlso I'm surprised by the last paragraph of this answer - http://stackoverflow.com/a/28011576/6018048 - it's definitely not my case. Maybe something has changed in the Chrome's engine?"},"comment":{"url":"https://api.github.com/repos/casperjs/casperjs/issues/comments/267368549","html_url":"https://github.com/casperjs/casperjs/issues/1736#issuecomment-267368549","issue_url":"https://api.github.com/repos/casperjs/casperjs/issues/1736","id":267368549,"user":{"login":"amberv0","id":11645756,"avatar_url":"https://avatars.githubusercontent.com/u/11645756?v=3","gravatar_id":"","url":"https://api.github.com/users/amberv0","html_url":"https://github.com/amberv0","followers_url":"https://api.github.com/users/amberv0/followers","following_url":"https://api.github.com/users/amberv0/following{/other_user}","gists_url":"https://api.github.com/users/amberv0/gists{/gist_id}","starred_url":"https://api.github.com/users/amberv0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberv0/subscriptions","organizations_url":"https://api.github.com/users/amberv0/orgs","repos_url":"https://api.github.com/users/amberv0/repos","events_url":"https://api.github.com/users/amberv0/events{/privacy}","received_events_url":"https://api.github.com/users/amberv0/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T16:13:57Z","updated_at":"2016-12-15T16:13:57Z","body":"@jefleponot , yep, of course you are right, for the svg case it wouldn't work. Thanks for noticing the missing `typeof`!"}}
{"actor":{"display_login":"amberv0"}}