{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/74691210","id":74691210,"diff_hunk":"@@ -1209,6 +1209,55 @@ public function testNamedRouteException()\n     }\n \n     /**\n+     * Test that using duplicate names causes exceptions.\n+     *\n+     * @expectedException \\Cake\\Routing\\Exception\\DuplicateNamedRouteException\n+     * @return void\n+     */\n+    public function testDuplicateNamedRouteException()\n+    {\n+        Router::connect(\n+            '/users/:name',\n+            ['controller' => 'users', 'action' => 'view'],\n+            ['_name' => 'test']\n+        );\n+\t\tRouter::connect(\n+            '/users/:name',\n+            ['controller' => 'users', 'action' => 'view'],\n+            ['_name' => 'otherName']\n+        );\n+\t\tRouter::connect(\n+            '/users/:name',\n+            ['controller' => 'users', 'action' => 'view'],\n+            ['_name' => 'test']\n+        );\n+    }\n+\n+    /**\n+     * Test that using defferent names not causes exceptions.\n+     *\n+     * @return void\n+     */\n+    public function testNoDuplicateNamedRouteException()\n+    {\n+        Router::connect(\n+            '/users/:name',\n+            ['controller' => 'users', 'action' => 'view'],\n+            ['_name' => 'test']\n+        );\n+\t\tRouter::connect(\n+            '/users/:name',\n+            ['controller' => 'users', 'action' => 'view'],\n+            ['_name' => 'test2']\n+        );\n+\t\tRouter::connect(","path":"tests/TestCase/Routing/RouterTest.php","position":45,"original_position":45,"commit_id":"34aa83e25217cbfb0d808d8a9d38a58b82554728","original_commit_id":"34aa83e25217cbfb0d808d8a9d38a58b82554728","user":{"login":"stickler-ci","id":16011037,"avatar_url":"https://avatars.githubusercontent.com/u/16011037?v=3","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"Spaces must be used to indent lines; tabs are not allowed","created_at":"2016-08-13T19:34:41Z","updated_at":"2016-08-13T19:34:41Z","html_url":"https://github.com/cakephp/cakephp/pull/9237#discussion_r74691210","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9237","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/74691210"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9237#discussion_r74691210"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9237"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/9237","id":80582795,"html_url":"https://github.com/cakephp/cakephp/pull/9237","diff_url":"https://github.com/cakephp/cakephp/pull/9237.diff","patch_url":"https://github.com/cakephp/cakephp/pull/9237.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/9237","number":9237,"state":"open","locked":false,"title":"Route names must be unique","user":{"login":"saeideng","id":8215801,"avatar_url":"https://avatars.githubusercontent.com/u/8215801?v=3","gravatar_id":"","url":"https://api.github.com/users/saeideng","html_url":"https://github.com/saeideng","followers_url":"https://api.github.com/users/saeideng/followers","following_url":"https://api.github.com/users/saeideng/following{/other_user}","gists_url":"https://api.github.com/users/saeideng/gists{/gist_id}","starred_url":"https://api.github.com/users/saeideng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeideng/subscriptions","organizations_url":"https://api.github.com/users/saeideng/orgs","repos_url":"https://api.github.com/users/saeideng/repos","events_url":"https://api.github.com/users/saeideng/events{/privacy}","received_events_url":"https://api.github.com/users/saeideng/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-09T08:49:17Z","updated_at":"2016-08-13T19:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b68f97377b031ad8a919316af0e9ab45e624749","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/98","html_url":"https://github.com/cakephp/cakephp/milestones/3.3.1","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/98/labels","id":1939998,"number":98,"title":"3.3.1","description":"Minor features and bugfixes for 3.3.x","creator":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":1,"state":"open","created_at":"2016-08-13T02:01:49Z","updated_at":"2016-08-13T18:03:26Z","due_on":"2016-08-26T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9237/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9237/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/9237/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/34aa83e25217cbfb0d808d8a9d38a58b82554728","head":{"label":"saeideng:patch-2","ref":"patch-2","sha":"34aa83e25217cbfb0d808d8a9d38a58b82554728","user":{"login":"saeideng","id":8215801,"avatar_url":"https://avatars.githubusercontent.com/u/8215801?v=3","gravatar_id":"","url":"https://api.github.com/users/saeideng","html_url":"https://github.com/saeideng","followers_url":"https://api.github.com/users/saeideng/followers","following_url":"https://api.github.com/users/saeideng/following{/other_user}","gists_url":"https://api.github.com/users/saeideng/gists{/gist_id}","starred_url":"https://api.github.com/users/saeideng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeideng/subscriptions","organizations_url":"https://api.github.com/users/saeideng/orgs","repos_url":"https://api.github.com/users/saeideng/repos","events_url":"https://api.github.com/users/saeideng/events{/privacy}","received_events_url":"https://api.github.com/users/saeideng/received_events","type":"User","site_admin":false},"repo":{"id":52345476,"name":"cakephp","full_name":"saeideng/cakephp","owner":{"login":"saeideng","id":8215801,"avatar_url":"https://avatars.githubusercontent.com/u/8215801?v=3","gravatar_id":"","url":"https://api.github.com/users/saeideng","html_url":"https://github.com/saeideng","followers_url":"https://api.github.com/users/saeideng/followers","following_url":"https://api.github.com/users/saeideng/following{/other_user}","gists_url":"https://api.github.com/users/saeideng/gists{/gist_id}","starred_url":"https://api.github.com/users/saeideng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeideng/subscriptions","organizations_url":"https://api.github.com/users/saeideng/orgs","repos_url":"https://api.github.com/users/saeideng/repos","events_url":"https://api.github.com/users/saeideng/events{/privacy}","received_events_url":"https://api.github.com/users/saeideng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saeideng/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/saeideng/cakephp","forks_url":"https://api.github.com/repos/saeideng/cakephp/forks","keys_url":"https://api.github.com/repos/saeideng/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saeideng/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saeideng/cakephp/teams","hooks_url":"https://api.github.com/repos/saeideng/cakephp/hooks","issue_events_url":"https://api.github.com/repos/saeideng/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/saeideng/cakephp/events","assignees_url":"https://api.github.com/repos/saeideng/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/saeideng/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/saeideng/cakephp/tags","blobs_url":"https://api.github.com/repos/saeideng/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saeideng/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saeideng/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/saeideng/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saeideng/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/saeideng/cakephp/languages","stargazers_url":"https://api.github.com/repos/saeideng/cakephp/stargazers","contributors_url":"https://api.github.com/repos/saeideng/cakephp/contributors","subscribers_url":"https://api.github.com/repos/saeideng/cakephp/subscribers","subscription_url":"https://api.github.com/repos/saeideng/cakephp/subscription","commits_url":"https://api.github.com/repos/saeideng/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/saeideng/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/saeideng/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/saeideng/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/saeideng/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/saeideng/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saeideng/cakephp/merges","archive_url":"https://api.github.com/repos/saeideng/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saeideng/cakephp/downloads","issues_url":"https://api.github.com/repos/saeideng/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/saeideng/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/saeideng/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/saeideng/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saeideng/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/saeideng/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/saeideng/cakephp/deployments","created_at":"2016-02-23T09:03:29Z","updated_at":"2016-02-23T09:03:37Z","pushed_at":"2016-08-13T19:34:08Z","git_url":"git://github.com/saeideng/cakephp.git","ssh_url":"git@github.com:saeideng/cakephp.git","clone_url":"https://github.com/saeideng/cakephp.git","svn_url":"https://github.com/saeideng/cakephp","homepage":"http://cakephp.org","size":63310,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"3d3e354a4cca7b6f43ef7aacb7263d049952a0d3","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2016-08-13T17:17:08Z","pushed_at":"2016-08-13T19:34:12Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":129673,"stargazers_count":6655,"watchers_count":6655,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3020,"mirror_url":null,"open_issues_count":198,"forks":3020,"open_issues":198,"watchers":6655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9237"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9237"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9237"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9237/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9237/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9237/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/34aa83e25217cbfb0d808d8a9d38a58b82554728"}}}}
{"actor":{"display_login":"stickler-ci"}}