{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/blok/issues/75","repository_url":"https://api.github.com/repos/mozilla/blok","labels_url":"https://api.github.com/repos/mozilla/blok/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/blok/issues/75/comments","events_url":"https://api.github.com/repos/mozilla/blok/issues/75/events","html_url":"https://github.com/mozilla/blok/pull/75","id":168361255,"number":75,"title":"for #26: refactor (some) filterRequest code into modules and test","user":{"login":"groovecoder","id":71928,"avatar_url":"https://avatars.githubusercontent.com/u/71928?v=3","gravatar_id":"","url":"https://api.github.com/users/groovecoder","html_url":"https://github.com/groovecoder","followers_url":"https://api.github.com/users/groovecoder/followers","following_url":"https://api.github.com/users/groovecoder/following{/other_user}","gists_url":"https://api.github.com/users/groovecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/groovecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groovecoder/subscriptions","organizations_url":"https://api.github.com/users/groovecoder/orgs","repos_url":"https://api.github.com/users/groovecoder/repos","events_url":"https://api.github.com/users/groovecoder/events{/privacy}","received_events_url":"https://api.github.com/users/groovecoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-29T16:18:07Z","updated_at":"2016-08-01T14:36:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/blok/pulls/75","html_url":"https://github.com/mozilla/blok/pull/75","diff_url":"https://github.com/mozilla/blok/pull/75.diff","patch_url":"https://github.com/mozilla/blok/pull/75.patch"},"body":"This doesn't do everything, but it helps ...\r\n\r\n* New `allowRequest` function in a new `requests` module covered by tests\r\n* New `hostInBlocklist` function in `lists` module covered by tests\r\n* New `hostInEntity` function in `lists` module covered by tests using new `entitylist-fixture.json`\r\n* New `initTestPilotPingChannel` function in `background.js` to reduce window/global abuse/dependency\r\n* Move `allHosts` function from `canonicalize` module to `lists` module where it's used more\r\n\r\nTotal of 8 new tests with 14 new assertions."},"comment":{"url":"https://api.github.com/repos/mozilla/blok/issues/comments/236598934","html_url":"https://github.com/mozilla/blok/pull/75#issuecomment-236598934","issue_url":"https://api.github.com/repos/mozilla/blok/issues/75","id":236598934,"user":{"login":"groovecoder","id":71928,"avatar_url":"https://avatars.githubusercontent.com/u/71928?v=3","gravatar_id":"","url":"https://api.github.com/users/groovecoder","html_url":"https://github.com/groovecoder","followers_url":"https://api.github.com/users/groovecoder/followers","following_url":"https://api.github.com/users/groovecoder/following{/other_user}","gists_url":"https://api.github.com/users/groovecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/groovecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groovecoder/subscriptions","organizations_url":"https://api.github.com/users/groovecoder/orgs","repos_url":"https://api.github.com/users/groovecoder/repos","events_url":"https://api.github.com/users/groovecoder/events{/privacy}","received_events_url":"https://api.github.com/users/groovecoder/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T14:36:01Z","updated_at":"2016-08-01T14:36:01Z","body":"Thanks @rpl. May test `BroadcastChannel` usage in the future, but for now I'm more interested in thoroughly testing the blocking logic. I've honestly forgotten why I (had to?) set the active tab ID to 1. Probably just something I did early before I had read much about the web extension events for doing so ..."}}
{"actor":{"display_login":"groovecoder"}}