{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/3887","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/3887/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/3887/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/3887/events","html_url":"https://github.com/qgis/QGIS/pull/3887","id":196359164,"number":3887,"title":"[raster] move pseudocolor renderer classification out of gui into core","user":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars.githubusercontent.com/u/1728657?v=3","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"labels":[{"id":330645596,"url":"https://api.github.com/repos/qgis/QGIS/labels/Feedback","name":"Feedback","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-19T08:46:29Z","updated_at":"2016-12-23T03:52:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/3887","html_url":"https://github.com/qgis/QGIS/pull/3887","diff_url":"https://github.com/qgis/QGIS/pull/3887.diff","patch_url":"https://github.com/qgis/QGIS/pull/3887.patch"},"body":"@rouault , @wonder-sk , this PR is a WIP, mostly looking for your feedbacks here. What it does is moving the classification code that creates the color ramp shader for the pseudocolor renderer away from gui into core so the classification can occur outside the context of the style dock / layer properties window.\r\n\r\nMoving the classification to be attached to the renderer allows for @rouault 's recently added \"updated extent\" mode to function with the pseudo color renderer. It also allows for the raster toolbar buttons to function with that renderer too."},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/268937077","html_url":"https://github.com/qgis/QGIS/pull/3887#issuecomment-268937077","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/3887","id":268937077,"user":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars.githubusercontent.com/u/1728657?v=3","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T03:52:40Z","updated_at":"2016-12-23T03:52:40Z","body":"@wonder-sk , ok, I've moved the classification into QgsColorRampShader as we discussed. It occured to me that it might be better to going through a classify function instead of a create function that would return a new QgsColorRampShader, to avoid creating a new object when you simply want to re-classify the shader.\r\n\r\nSatisfied? :)"}}
{"actor":{"display_login":"nirvn"}}