{"action":"created","issue":{"url":"https://api.github.com/repos/JarrodCTaylor/fauxjax/issues/29","repository_url":"https://api.github.com/repos/JarrodCTaylor/fauxjax","labels_url":"https://api.github.com/repos/JarrodCTaylor/fauxjax/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/JarrodCTaylor/fauxjax/issues/29/comments","events_url":"https://api.github.com/repos/JarrodCTaylor/fauxjax/issues/29/events","html_url":"https://github.com/JarrodCTaylor/fauxjax/pull/29","id":195038196,"number":29,"title":"[NEW API]: removeExisting to remove all fauxHandlers","user":{"login":"snewcomer","id":7374640,"avatar_url":"https://avatars.githubusercontent.com/u/7374640?v=3","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-12T17:39:33Z","updated_at":"2016-12-19T02:36:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JarrodCTaylor/fauxjax/pulls/29","html_url":"https://github.com/JarrodCTaylor/fauxjax/pull/29","diff_url":"https://github.com/JarrodCTaylor/fauxjax/pull/29.diff","patch_url":"https://github.com/JarrodCTaylor/fauxjax/pull/29.patch"},"body":"https://github.com/JarrodCTaylor/fauxjax/issues/26"},"comment":{"url":"https://api.github.com/repos/JarrodCTaylor/fauxjax/issues/comments/267869175","html_url":"https://github.com/JarrodCTaylor/fauxjax/pull/29#issuecomment-267869175","issue_url":"https://api.github.com/repos/JarrodCTaylor/fauxjax/issues/29","id":267869175,"user":{"login":"JarrodCTaylor","id":4416952,"avatar_url":"https://avatars.githubusercontent.com/u/4416952?v=3","gravatar_id":"","url":"https://api.github.com/users/JarrodCTaylor","html_url":"https://github.com/JarrodCTaylor","followers_url":"https://api.github.com/users/JarrodCTaylor/followers","following_url":"https://api.github.com/users/JarrodCTaylor/following{/other_user}","gists_url":"https://api.github.com/users/JarrodCTaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/JarrodCTaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarrodCTaylor/subscriptions","organizations_url":"https://api.github.com/users/JarrodCTaylor/orgs","repos_url":"https://api.github.com/users/JarrodCTaylor/repos","events_url":"https://api.github.com/users/JarrodCTaylor/events{/privacy}","received_events_url":"https://api.github.com/users/JarrodCTaylor/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T02:36:12Z","updated_at":"2016-12-19T02:36:12Z","body":"I appreciate the pull request and the enthusiasm for continuing to evolve the library. However, I need a little more convincing as I have reservations about including this method in the API. Just looking at the names knowing nothing about the library I would be confused as to what the difference is between `remove` and `removeExisting`. The only things being checked for equality in order to remove a handler by this proposed method are `url` and `method`. Which means there are other possible permutations of things that could be different between two handlers that get ignored leaving the door open to introduce some subtle and annoying errors. \r\n\r\nI am also still unclear on what scenario this is providing a solution for? Why is the index of the handler not available from when it was created?"}}
{"actor":{"display_login":"JarrodCTaylor"}}