{"action":"created","comment":{"url":"https://api.github.com/repos/ioam/holoviews/pulls/comments/78850527","id":78850527,"diff_hunk":"@@ -104,6 +113,13 @@ class ElementPlot(BokehPlot, GenericElementPlot):\n     tools = param.List(default=[], doc=\"\"\"\n         A list of plugin tools to use on the plot.\"\"\")\n \n+    toolbar = param.ObjectSelector(default='right',\n+                                   objects=[\"above\", \"below\",\n+                                            \"left\", \"right\", None],\n+                                   doc=\"\"\"\n+        The toolbar location, must be one of 'above', 'below',\n+        'left', 'right', None.\"\"\")","path":"holoviews/plotting/bokeh/element.py","position":34,"original_position":34,"commit_id":"c211f2a8c222c726584931bc0bc971538a5b4271","original_commit_id":"65c0d21cfa948add89e0df5689ace8211998211a","user":{"login":"philippjfr","id":1550771,"avatar_url":"https://avatars.githubusercontent.com/u/1550771?v=3","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"body":"It's just a convenient way to disable the toolbar altogether. I could either disable it, or warn ``tools`` or warn for ``tools`` and ``default_tools``.","created_at":"2016-09-14T21:54:51Z","updated_at":"2016-09-14T21:54:51Z","html_url":"https://github.com/ioam/holoviews/pull/861#discussion_r78850527","pull_request_url":"https://api.github.com/repos/ioam/holoviews/pulls/861","_links":{"self":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/comments/78850527"},"html":{"href":"https://github.com/ioam/holoviews/pull/861#discussion_r78850527"},"pull_request":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/ioam/holoviews/pulls/861","id":85146457,"html_url":"https://github.com/ioam/holoviews/pull/861","diff_url":"https://github.com/ioam/holoviews/pull/861.diff","patch_url":"https://github.com/ioam/holoviews/pull/861.patch","issue_url":"https://api.github.com/repos/ioam/holoviews/issues/861","number":861,"state":"open","locked":false,"title":"Bokeh colorbars","user":{"login":"philippjfr","id":1550771,"avatar_url":"https://avatars.githubusercontent.com/u/1550771?v=3","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"body":"Since version 0.12.2 bokeh finally support colorbars and client-side colormapping for all kinds of glyphs. This PR adds a ColorbarPlot mixin class which handles the creation of a Colorbar and a ColorMapper. Additionally it replaces the manual colormapping that was previously done in Python for various plot types. I have also moved the toolbar to the top so it does not overlap with a colorbar by default and because it is more consistent.\r\n\r\nTo Do:\r\n\r\n* [x] Test each changed Element in more detail\r\n* [x] Implement color_mapper range updating\r\n* [x] Update HeatMapPlot in #849 once this has been merged.\r\n* [x] Add some unit tests to ensure colorbars get instantiated correctly\r\n\r\nExamples:\r\n\r\nDifferent ``colorbar_position``s:\r\n\r\n<img width=\"641\" alt=\"screen shot 2016-09-14 at 12 54 54 am\" src=\"https://cloud.githubusercontent.com/assets/1550771/18495445/e57457ae-7a15-11e6-8d5d-3585e897e38d.png\">\r\n\r\nLog colormapping on points:\r\n\r\n<img width=\"266\" alt=\"screen shot 2016-09-14 at 12 45 16 am\" src=\"https://cloud.githubusercontent.com/assets/1550771/18495448/e9701aa0-7a15-11e6-9b15-00081fa4b6fc.png\">\r\n\r\nQuadMesh:\r\n\r\n<img width=\"279\" alt=\"screen shot 2016-09-14 at 12 45 48 am\" src=\"https://cloud.githubusercontent.com/assets/1550771/18495449/ec7f2704-7a15-11e6-8d59-9dd9b3ef1f9b.png\">\r\n\r\nPolygons (more sensible on a Choropleth):\r\n\r\n<img width=\"287\" alt=\"screen shot 2016-09-14 at 12 43 54 am\" src=\"https://cloud.githubusercontent.com/assets/1550771/18495456/f6d0dd6a-7a15-11e6-94a5-24d0efafd7f1.png\">","created_at":"2016-09-13T23:58:24Z","updated_at":"2016-09-14T21:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c09b0cb382171db32e42cdde661fe510eba1811f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ioam/holoviews/pulls/861/commits","review_comments_url":"https://api.github.com/repos/ioam/holoviews/pulls/861/comments","review_comment_url":"https://api.github.com/repos/ioam/holoviews/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ioam/holoviews/issues/861/comments","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/c211f2a8c222c726584931bc0bc971538a5b4271","head":{"label":"ioam:bokeh_colorbars","ref":"bokeh_colorbars","sha":"c211f2a8c222c726584931bc0bc971538a5b4271","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":19542768,"name":"holoviews","full_name":"ioam/holoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/holoviews","description":"Stop plotting your data - annotate your data and let it visualize itself","fork":false,"url":"https://api.github.com/repos/ioam/holoviews","forks_url":"https://api.github.com/repos/ioam/holoviews/forks","keys_url":"https://api.github.com/repos/ioam/holoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/holoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/holoviews/teams","hooks_url":"https://api.github.com/repos/ioam/holoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/holoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/holoviews/events","assignees_url":"https://api.github.com/repos/ioam/holoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/holoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/holoviews/tags","blobs_url":"https://api.github.com/repos/ioam/holoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/holoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/holoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/holoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/holoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/holoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/holoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/holoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/holoviews/subscription","commits_url":"https://api.github.com/repos/ioam/holoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/holoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/holoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/holoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/holoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/holoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/holoviews/merges","archive_url":"https://api.github.com/repos/ioam/holoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/holoviews/downloads","issues_url":"https://api.github.com/repos/ioam/holoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/holoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/holoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/holoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/holoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/holoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/holoviews/deployments","created_at":"2014-05-07T16:59:22Z","updated_at":"2016-09-13T22:14:01Z","pushed_at":"2016-09-14T21:42:52Z","git_url":"git://github.com/ioam/holoviews.git","ssh_url":"git@github.com:ioam/holoviews.git","clone_url":"https://github.com/ioam/holoviews.git","svn_url":"https://github.com/ioam/holoviews","homepage":"http://holoviews.org","size":9887,"stargazers_count":288,"watchers_count":288,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":193,"forks":38,"open_issues":193,"watchers":288,"default_branch":"master"}},"base":{"label":"ioam:master","ref":"master","sha":"4664863904e19c9df6978149bb698459dcdcfd29","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":19542768,"name":"holoviews","full_name":"ioam/holoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/holoviews","description":"Stop plotting your data - annotate your data and let it visualize itself","fork":false,"url":"https://api.github.com/repos/ioam/holoviews","forks_url":"https://api.github.com/repos/ioam/holoviews/forks","keys_url":"https://api.github.com/repos/ioam/holoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/holoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/holoviews/teams","hooks_url":"https://api.github.com/repos/ioam/holoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/holoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/holoviews/events","assignees_url":"https://api.github.com/repos/ioam/holoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/holoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/holoviews/tags","blobs_url":"https://api.github.com/repos/ioam/holoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/holoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/holoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/holoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/holoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/holoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/holoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/holoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/holoviews/subscription","commits_url":"https://api.github.com/repos/ioam/holoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/holoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/holoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/holoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/holoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/holoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/holoviews/merges","archive_url":"https://api.github.com/repos/ioam/holoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/holoviews/downloads","issues_url":"https://api.github.com/repos/ioam/holoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/holoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/holoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/holoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/holoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/holoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/holoviews/deployments","created_at":"2014-05-07T16:59:22Z","updated_at":"2016-09-13T22:14:01Z","pushed_at":"2016-09-14T21:42:52Z","git_url":"git://github.com/ioam/holoviews.git","ssh_url":"git@github.com:ioam/holoviews.git","clone_url":"https://github.com/ioam/holoviews.git","svn_url":"https://github.com/ioam/holoviews","homepage":"http://holoviews.org","size":9887,"stargazers_count":288,"watchers_count":288,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":193,"forks":38,"open_issues":193,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/861"},"html":{"href":"https://github.com/ioam/holoviews/pull/861"},"issue":{"href":"https://api.github.com/repos/ioam/holoviews/issues/861"},"comments":{"href":"https://api.github.com/repos/ioam/holoviews/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/ioam/holoviews/statuses/c211f2a8c222c726584931bc0bc971538a5b4271"}}}}
{"actor":{"display_login":"philippjfr"}}