{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/3166","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/3166/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/3166/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/3166/events","html_url":"https://github.com/qgis/QGIS/pull/3166","id":158096990,"number":3166,"title":"[processing] fix missing quotes to field name in refactor fields","user":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars.githubusercontent.com/u/1728657?v=3","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-02T09:30:26Z","updated_at":"2016-06-03T01:54:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/3166","html_url":"https://github.com/qgis/QGIS/pull/3166","diff_url":"https://github.com/qgis/QGIS/pull/3166.diff","patch_url":"https://github.com/qgis/QGIS/pull/3166.patch"},"body":"ATM, the refactor fields' field mapping panel is broken for field names that are expression functions (for e.g. a field named year is a duplicate of the expression function year()).\r\n\r\nThis PR fixes the issue by making sure that fields are enclosed in \"quotes\". \r\n\r\n@volaya , @nyalldawson , does this look good? Works over here."},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/223471896","html_url":"https://github.com/qgis/QGIS/pull/3166#issuecomment-223471896","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/3166","id":223471896,"user":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars.githubusercontent.com/u/1728657?v=3","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T01:54:28Z","updated_at":"2016-06-03T01:54:28Z","body":"@nyalldawson , I've looked into creating a test case for this, however it actually can't be done. The qgis:refactorfield algorithm takes a FIELDS_MAPPING input parameter that already has fields turned into expression-compatible quoted fields (that is, with this PR applied), we can't test the actually creation of FIELDS_MAPPING parameter string."}}
{"actor":{"display_login":"nirvn"}}