{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1279","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1279/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1279/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1279/events","html_url":"https://github.com/greenplum-db/gpdb/pull/1279","id":187259440,"number":1279,"title":"Fix wrong virtual tuple check in codegened slot_getattr","user":{"login":"armenatzoglou","id":9626616,"avatar_url":"https://avatars.githubusercontent.com/u/9626616?v=3","gravatar_id":"","url":"https://api.github.com/users/armenatzoglou","html_url":"https://github.com/armenatzoglou","followers_url":"https://api.github.com/users/armenatzoglou/followers","following_url":"https://api.github.com/users/armenatzoglou/following{/other_user}","gists_url":"https://api.github.com/users/armenatzoglou/gists{/gist_id}","starred_url":"https://api.github.com/users/armenatzoglou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armenatzoglou/subscriptions","organizations_url":"https://api.github.com/users/armenatzoglou/orgs","repos_url":"https://api.github.com/users/armenatzoglou/repos","events_url":"https://api.github.com/users/armenatzoglou/events{/privacy}","received_events_url":"https://api.github.com/users/armenatzoglou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-04T05:56:26Z","updated_at":"2016-11-04T05:56:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1279","html_url":"https://github.com/greenplum-db/gpdb/pull/1279","diff_url":"https://github.com/greenplum-db/gpdb/pull/1279.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1279.patch"},"body":"The code that we generate for `slot_getattr` is not correct. In particular, to check if a tuple is virtual, we have to implement the code below: \r\n`if (TupHasVirtualTuple(slot) && slot->PRIVATE_tts_nvalid >= attnum)`\r\n\r\nIn the code generated `slot_getattr` we had not implemented the second condition, i.e., `slot->PRIVATE_tts_nvalid >= attnum`. \r\n\r\nIn this PR, we generate code for the second condition.\r\n "},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/258350893","html_url":"https://github.com/greenplum-db/gpdb/pull/1279#issuecomment-258350893","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1279","id":258350893,"user":{"login":"gpdbdreddbot","id":15618396,"avatar_url":"https://avatars.githubusercontent.com/u/15618396?v=3","gravatar_id":"","url":"https://api.github.com/users/gpdbdreddbot","html_url":"https://github.com/gpdbdreddbot","followers_url":"https://api.github.com/users/gpdbdreddbot/followers","following_url":"https://api.github.com/users/gpdbdreddbot/following{/other_user}","gists_url":"https://api.github.com/users/gpdbdreddbot/gists{/gist_id}","starred_url":"https://api.github.com/users/gpdbdreddbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpdbdreddbot/subscriptions","organizations_url":"https://api.github.com/users/gpdbdreddbot/orgs","repos_url":"https://api.github.com/users/gpdbdreddbot/repos","events_url":"https://api.github.com/users/gpdbdreddbot/events{/privacy}","received_events_url":"https://api.github.com/users/gpdbdreddbot/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T05:56:27Z","updated_at":"2016-11-04T05:56:27Z","body":"Hello armenatzoglou!\n\nThanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.\n"}}
{"actor":{"display_login":"gpdbdreddbot"}}