{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/85957727","pull_request_review_id":6641203,"id":85957727,"diff_hunk":"@@ -1828,6 +1827,24 @@ mono_assembly_load_friends (MonoAssembly* ass)\n \tmono_assemblies_unlock ();\n }\n \n+struct HasReferenceAssemblyAttributeIterData {\n+\tgboolean has_attr;\n+};\n+\n+static gboolean\n+has_reference_assembly_attribute_iterator (MonoImage *image, const MonoAssemblyName *aname, const char *nspace, const char *name, gpointer user_data)","path":"mono/metadata/assembly.c","position":26,"original_position":26,"commit_id":"0fd48356c509a04aedd5568741b5b99ddb72147b","original_commit_id":"0fd48356c509a04aedd5568741b5b99ddb72147b","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"body":"I'll change it to just get the typeref scope token.\r\n\r\nI'm still holding out hope of making this into a general-purpose API in which case it seems like the iterator ought to get:\r\n  1. enough info to construct the assembly-qualified type name\r\n  2. the method token\r\n  3. (not sure if this is needed) enough info so that the iterator can decode the arguments blob if it wants to.\r\n","created_at":"2016-11-01T15:53:50Z","updated_at":"2016-11-01T15:53:50Z","html_url":"https://github.com/mono/mono/pull/3863#discussion_r85957727","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/3863","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/85957727"},"html":{"href":"https://github.com/mono/mono/pull/3863#discussion_r85957727"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/3863"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/3863","id":91707614,"html_url":"https://github.com/mono/mono/pull/3863","diff_url":"https://github.com/mono/mono/pull/3863.diff","patch_url":"https://github.com/mono/mono/pull/3863.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/3863","number":3863,"state":"open","locked":false,"title":"[custom-attrs] Add a low level iterator for custom attributes on assemblies","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"body":"And use it to check for the reference assembly attribute.\r\n\r\nUsing the low level APIs means we don't trigger load of referenced\r\nassemblies and we don't need to take locks, so it is safe to call this\r\nduring assembly loading.","created_at":"2016-10-31T23:05:47Z","updated_at":"2016-11-01T15:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9236e10944bfa3a11a7fe40a7171698cd1807e4f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/3863/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/3863/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/3863/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/0fd48356c509a04aedd5568741b5b99ddb72147b","head":{"label":"lambdageek:dev-42584-take4","ref":"dev-42584-take4","sha":"0fd48356c509a04aedd5568741b5b99ddb72147b","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"repo":{"id":40153659,"name":"mono","full_name":"lambdageek/mono","owner":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lambdageek/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/lambdageek/mono","forks_url":"https://api.github.com/repos/lambdageek/mono/forks","keys_url":"https://api.github.com/repos/lambdageek/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lambdageek/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lambdageek/mono/teams","hooks_url":"https://api.github.com/repos/lambdageek/mono/hooks","issue_events_url":"https://api.github.com/repos/lambdageek/mono/issues/events{/number}","events_url":"https://api.github.com/repos/lambdageek/mono/events","assignees_url":"https://api.github.com/repos/lambdageek/mono/assignees{/user}","branches_url":"https://api.github.com/repos/lambdageek/mono/branches{/branch}","tags_url":"https://api.github.com/repos/lambdageek/mono/tags","blobs_url":"https://api.github.com/repos/lambdageek/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lambdageek/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lambdageek/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/lambdageek/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lambdageek/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/lambdageek/mono/languages","stargazers_url":"https://api.github.com/repos/lambdageek/mono/stargazers","contributors_url":"https://api.github.com/repos/lambdageek/mono/contributors","subscribers_url":"https://api.github.com/repos/lambdageek/mono/subscribers","subscription_url":"https://api.github.com/repos/lambdageek/mono/subscription","commits_url":"https://api.github.com/repos/lambdageek/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/lambdageek/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/lambdageek/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/lambdageek/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/lambdageek/mono/contents/{+path}","compare_url":"https://api.github.com/repos/lambdageek/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lambdageek/mono/merges","archive_url":"https://api.github.com/repos/lambdageek/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lambdageek/mono/downloads","issues_url":"https://api.github.com/repos/lambdageek/mono/issues{/number}","pulls_url":"https://api.github.com/repos/lambdageek/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/lambdageek/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/lambdageek/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lambdageek/mono/labels{/name}","releases_url":"https://api.github.com/repos/lambdageek/mono/releases{/id}","deployments_url":"https://api.github.com/repos/lambdageek/mono/deployments","created_at":"2015-08-03T23:55:25Z","updated_at":"2016-06-09T01:07:23Z","pushed_at":"2016-11-01T15:28:04Z","git_url":"git://github.com/lambdageek/mono.git","ssh_url":"git@github.com:lambdageek/mono.git","clone_url":"https://github.com/lambdageek/mono.git","svn_url":"https://github.com/lambdageek/mono","homepage":"http://www.mono-project.com/","size":411113,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"758b80e35c027dcba36cefea46cbc7e878e0fe4b","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-11-01T12:55:47Z","pushed_at":"2016-11-01T15:28:08Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":509476,"stargazers_count":5007,"watchers_count":5007,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2393,"mirror_url":null,"open_issues_count":148,"forks":2393,"open_issues":148,"watchers":5007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/3863"},"html":{"href":"https://github.com/mono/mono/pull/3863"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/3863"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/3863/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/3863/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/3863/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/0fd48356c509a04aedd5568741b5b99ddb72147b"}}}}
{"actor":{"display_login":"lambdageek"}}