{"action":"created","comment":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/90738323","pull_request_review_id":11259388,"id":90738323,"diff_hunk":"@@ -1061,7 +1061,7 @@ struct ReplaceStringImpl\n \t\t\tbool can_finish_current_string = false;\n \n \t\t\t/// Проверяем, что вхождение не переходит через границы строк.\n-\t\t\tif (match + needle.size() < begin + n * (i + 1))\n+\t\t\tif (match + needle.size() - 1 < begin + n * (i + 1))","path":"dbms/include/DB/Functions/FunctionsStringSearch.h","position":14,"original_position":14,"commit_id":"f344c85cb78fef2bfbac9b07d4a95c10dbc25a7f","original_commit_id":"261645326392066c61e1d51cead0a777cc413895","user":{"login":"artpaul","id":1533100,"avatar_url":"https://avatars.githubusercontent.com/u/1533100?v=3","gravatar_id":"","url":"https://api.github.com/users/artpaul","html_url":"https://github.com/artpaul","followers_url":"https://api.github.com/users/artpaul/followers","following_url":"https://api.github.com/users/artpaul/following{/other_user}","gists_url":"https://api.github.com/users/artpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/artpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpaul/subscriptions","organizations_url":"https://api.github.com/users/artpaul/orgs","repos_url":"https://api.github.com/users/artpaul/repos","events_url":"https://api.github.com/users/artpaul/events{/privacy}","received_events_url":"https://api.github.com/users/artpaul/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-12-02T23:31:05Z","updated_at":"2016-12-02T23:31:05Z","html_url":"https://github.com/yandex/ClickHouse/pull/225#discussion_r90738323","pull_request_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/90738323"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/225#discussion_r90738323"},"pull_request":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/225","id":96354760,"html_url":"https://github.com/yandex/ClickHouse/pull/225","diff_url":"https://github.com/yandex/ClickHouse/pull/225.diff","patch_url":"https://github.com/yandex/ClickHouse/pull/225.patch","issue_url":"https://api.github.com/repos/yandex/ClickHouse/issues/225","number":225,"state":"open","locked":false,"title":"#214 fix offsets assigments","user":{"login":"artpaul","id":1533100,"avatar_url":"https://avatars.githubusercontent.com/u/1533100?v=3","gravatar_id":"","url":"https://api.github.com/users/artpaul","html_url":"https://github.com/artpaul","followers_url":"https://api.github.com/users/artpaul/followers","following_url":"https://api.github.com/users/artpaul/following{/other_user}","gists_url":"https://api.github.com/users/artpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/artpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpaul/subscriptions","organizations_url":"https://api.github.com/users/artpaul/orgs","repos_url":"https://api.github.com/users/artpaul/repos","events_url":"https://api.github.com/users/artpaul/events{/privacy}","received_events_url":"https://api.github.com/users/artpaul/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-02T21:21:09Z","updated_at":"2016-12-02T23:31:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2be9fe552100d3f638d58fc61d4b6360faf939f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/225/commits","review_comments_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/225/comments","review_comment_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/issues/225/comments","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/f344c85cb78fef2bfbac9b07d4a95c10dbc25a7f","head":{"label":"artpaul:master","ref":"master","sha":"f344c85cb78fef2bfbac9b07d4a95c10dbc25a7f","user":{"login":"artpaul","id":1533100,"avatar_url":"https://avatars.githubusercontent.com/u/1533100?v=3","gravatar_id":"","url":"https://api.github.com/users/artpaul","html_url":"https://github.com/artpaul","followers_url":"https://api.github.com/users/artpaul/followers","following_url":"https://api.github.com/users/artpaul/following{/other_user}","gists_url":"https://api.github.com/users/artpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/artpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpaul/subscriptions","organizations_url":"https://api.github.com/users/artpaul/orgs","repos_url":"https://api.github.com/users/artpaul/repos","events_url":"https://api.github.com/users/artpaul/events{/privacy}","received_events_url":"https://api.github.com/users/artpaul/received_events","type":"User","site_admin":false},"repo":{"id":72551566,"name":"ClickHouse","full_name":"artpaul/ClickHouse","owner":{"login":"artpaul","id":1533100,"avatar_url":"https://avatars.githubusercontent.com/u/1533100?v=3","gravatar_id":"","url":"https://api.github.com/users/artpaul","html_url":"https://github.com/artpaul","followers_url":"https://api.github.com/users/artpaul/followers","following_url":"https://api.github.com/users/artpaul/following{/other_user}","gists_url":"https://api.github.com/users/artpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/artpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpaul/subscriptions","organizations_url":"https://api.github.com/users/artpaul/orgs","repos_url":"https://api.github.com/users/artpaul/repos","events_url":"https://api.github.com/users/artpaul/events{/privacy}","received_events_url":"https://api.github.com/users/artpaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artpaul/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":true,"url":"https://api.github.com/repos/artpaul/ClickHouse","forks_url":"https://api.github.com/repos/artpaul/ClickHouse/forks","keys_url":"https://api.github.com/repos/artpaul/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artpaul/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artpaul/ClickHouse/teams","hooks_url":"https://api.github.com/repos/artpaul/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/artpaul/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/artpaul/ClickHouse/events","assignees_url":"https://api.github.com/repos/artpaul/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/artpaul/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/artpaul/ClickHouse/tags","blobs_url":"https://api.github.com/repos/artpaul/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artpaul/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artpaul/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/artpaul/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artpaul/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/artpaul/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/artpaul/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/artpaul/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/artpaul/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/artpaul/ClickHouse/subscription","commits_url":"https://api.github.com/repos/artpaul/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/artpaul/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/artpaul/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/artpaul/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/artpaul/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/artpaul/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artpaul/ClickHouse/merges","archive_url":"https://api.github.com/repos/artpaul/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artpaul/ClickHouse/downloads","issues_url":"https://api.github.com/repos/artpaul/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/artpaul/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/artpaul/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/artpaul/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artpaul/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/artpaul/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/artpaul/ClickHouse/deployments","created_at":"2016-11-01T15:51:28Z","updated_at":"2016-11-01T15:51:34Z","pushed_at":"2016-12-02T23:30:23Z","git_url":"git://github.com/artpaul/ClickHouse.git","ssh_url":"git@github.com:artpaul/ClickHouse.git","clone_url":"https://github.com/artpaul/ClickHouse.git","svn_url":"https://github.com/artpaul/ClickHouse","homepage":null,"size":32172,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yandex:master","ref":"master","sha":"2def6778e77b368658fd73577d01afbcdd82674a","user":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"repo":{"id":60246359,"name":"ClickHouse","full_name":"yandex/ClickHouse","owner":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":false,"url":"https://api.github.com/repos/yandex/ClickHouse","forks_url":"https://api.github.com/repos/yandex/ClickHouse/forks","keys_url":"https://api.github.com/repos/yandex/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex/ClickHouse/teams","hooks_url":"https://api.github.com/repos/yandex/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/yandex/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/yandex/ClickHouse/events","assignees_url":"https://api.github.com/repos/yandex/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/yandex/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/yandex/ClickHouse/tags","blobs_url":"https://api.github.com/repos/yandex/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/yandex/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/yandex/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/yandex/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/yandex/ClickHouse/subscription","commits_url":"https://api.github.com/repos/yandex/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/yandex/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/yandex/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex/ClickHouse/merges","archive_url":"https://api.github.com/repos/yandex/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex/ClickHouse/downloads","issues_url":"https://api.github.com/repos/yandex/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/yandex/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/yandex/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/yandex/ClickHouse/deployments","created_at":"2016-06-02T08:28:18Z","updated_at":"2016-12-02T19:56:30Z","pushed_at":"2016-12-02T23:30:23Z","git_url":"git://github.com/yandex/ClickHouse.git","ssh_url":"git@github.com:yandex/ClickHouse.git","clone_url":"https://github.com/yandex/ClickHouse.git","svn_url":"https://github.com/yandex/ClickHouse","homepage":null,"size":35740,"stargazers_count":1805,"watchers_count":1805,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":66,"forks":202,"open_issues":66,"watchers":1805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/225"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/225"},"issue":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/225"},"comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/yandex/ClickHouse/statuses/f344c85cb78fef2bfbac9b07d4a95c10dbc25a7f"}}}}
{"actor":{"display_login":"artpaul"}}