{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/110","repository_url":"https://api.github.com/repos/cfpb/college-costs","labels_url":"https://api.github.com/repos/cfpb/college-costs/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/college-costs/issues/110/comments","events_url":"https://api.github.com/repos/cfpb/college-costs/issues/110/events","html_url":"https://github.com/cfpb/college-costs/pull/110","id":134991505,"number":110,"title":"Fix to correct monthly loan payment and lifetime loan payment values","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-19T22:29:16Z","updated_at":"2016-02-22T16:12:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/college-costs/pulls/110","html_url":"https://github.com/cfpb/college-costs/pull/110","diff_url":"https://github.com/cfpb/college-costs/pull/110.diff","patch_url":"https://github.com/cfpb/college-costs/pull/110.patch"},"body":"The numbers for \"Total cost of repayment with interest\" are supposed to represent the total cost of the loans over the repayment period. After a few updates to `student-debt-calc`, I have the values working and live in `college-costs`.\r\n\r\n## Additions\r\n- Lifetime loan cost is rounded after calculation, before the view is updated.\r\n\r\n## Changes\r\n- Changed the DOM so that the correct variable (`loanLifetime`) is used for total cost of repayment.\r\n- Updated version of `student-debt-calc`\r\n- Updated functional tests to sleep 750 ms (up from 600 ms). This seemed to help with some false positives (or negatives?) where functional tests would fail occasionally for no apparent reason. I assume sometimes the sleep wasn't enough for the calculations to be done and the view updated.\r\n- Updated functional tests to check for correct lifetime loan values.\r\n\r\n## Testing\r\n- Pull it down, be sure to run `npm install` to get updates to `student-debt-calc`, and then feel free to try it and run functional tests.\r\n- Six functional tests for Step 2 are failing (as expected)\r\n\r\n## Review\r\n- @niqjohnson @marteki @higs4281 \r\n\r\n## Checklist\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices \r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n\r\n## Animated GIF\r\nPutting out fires is like...\r\n\r\n![moss-fire](https://cloud.githubusercontent.com/assets/1490703/13190919/405f62ca-d72e-11e5-98e8-c321c609f8c4.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/comments/187248352","html_url":"https://github.com/cfpb/college-costs/pull/110#issuecomment-187248352","issue_url":"https://api.github.com/repos/cfpb/college-costs/issues/110","id":187248352,"user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T16:12:11Z","updated_at":"2016-02-22T16:12:11Z","body":"Merging, then addressing that test."}}