{"action":"closed","number":47,"pull_request":{"url":"https://api.github.com/repos/openstax/accounts-rails/pulls/47","id":65661071,"html_url":"https://github.com/openstax/accounts-rails/pull/47","diff_url":"https://github.com/openstax/accounts-rails/pull/47.diff","patch_url":"https://github.com/openstax/accounts-rails/pull/47.patch","issue_url":"https://api.github.com/repos/openstax/accounts-rails/issues/47","number":47,"state":"closed","locked":false,"title":"Fix/invalid format redirect","user":{"login":"nathanstitt","id":79566,"avatar_url":"https://avatars.githubusercontent.com/u/79566?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanstitt","html_url":"https://github.com/nathanstitt","followers_url":"https://api.github.com/users/nathanstitt/followers","following_url":"https://api.github.com/users/nathanstitt/following{/other_user}","gists_url":"https://api.github.com/users/nathanstitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanstitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanstitt/subscriptions","organizations_url":"https://api.github.com/users/nathanstitt/orgs","repos_url":"https://api.github.com/users/nathanstitt/repos","events_url":"https://api.github.com/users/nathanstitt/events{/privacy}","received_events_url":"https://api.github.com/users/nathanstitt/received_events","type":"User","site_admin":false},"body":"Tutor needs to deal with format-less urls like `/qa/94/section/7.1`\r\n\r\nRails parses that to mean format `1` which isn't matched by a responder block.  It then raises an `ActionController::UnknownFormat` exception\r\n\r\nSince it's impossible to guess all possible url endings, match and redirect `.any`\r\n\r\nI'm having trouble writing a spec for this, I tried adding it to the sessions_controller_spec, but that doesn't seem to include base, or at least doesn't call `authenticate_user!`","created_at":"2016-04-07T16:36:43Z","updated_at":"2016-04-19T17:28:51Z","closed_at":"2016-04-19T17:28:51Z","merged_at":"2016-04-19T17:28:51Z","merge_commit_sha":"916f23caaeaf60a20904d7e6eae427372c290204","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openstax/accounts-rails/pulls/47/commits","review_comments_url":"https://api.github.com/repos/openstax/accounts-rails/pulls/47/comments","review_comment_url":"https://api.github.com/repos/openstax/accounts-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstax/accounts-rails/issues/47/comments","statuses_url":"https://api.github.com/repos/openstax/accounts-rails/statuses/30fe949c57e57e2ee8cd11ca37c8016ae8a785c8","head":{"label":"openstax:fix/invalid-format-redirect","ref":"fix/invalid-format-redirect","sha":"30fe949c57e57e2ee8cd11ca37c8016ae8a785c8","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":18779311,"name":"accounts-rails","full_name":"openstax/accounts-rails","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/accounts-rails","description":"Library for connecting to OpenStax Accounts from Rails","fork":false,"url":"https://api.github.com/repos/openstax/accounts-rails","forks_url":"https://api.github.com/repos/openstax/accounts-rails/forks","keys_url":"https://api.github.com/repos/openstax/accounts-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/accounts-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/accounts-rails/teams","hooks_url":"https://api.github.com/repos/openstax/accounts-rails/hooks","issue_events_url":"https://api.github.com/repos/openstax/accounts-rails/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/accounts-rails/events","assignees_url":"https://api.github.com/repos/openstax/accounts-rails/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/accounts-rails/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/accounts-rails/tags","blobs_url":"https://api.github.com/repos/openstax/accounts-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/accounts-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/accounts-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/accounts-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/accounts-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/accounts-rails/languages","stargazers_url":"https://api.github.com/repos/openstax/accounts-rails/stargazers","contributors_url":"https://api.github.com/repos/openstax/accounts-rails/contributors","subscribers_url":"https://api.github.com/repos/openstax/accounts-rails/subscribers","subscription_url":"https://api.github.com/repos/openstax/accounts-rails/subscription","commits_url":"https://api.github.com/repos/openstax/accounts-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/accounts-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/accounts-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/accounts-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/accounts-rails/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/accounts-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/accounts-rails/merges","archive_url":"https://api.github.com/repos/openstax/accounts-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/accounts-rails/downloads","issues_url":"https://api.github.com/repos/openstax/accounts-rails/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/accounts-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/accounts-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/accounts-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/accounts-rails/labels{/name}","releases_url":"https://api.github.com/repos/openstax/accounts-rails/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/accounts-rails/deployments","created_at":"2014-04-14T22:39:06Z","updated_at":"2016-01-11T02:02:23Z","pushed_at":"2016-04-19T17:28:51Z","git_url":"git://github.com/openstax/accounts-rails.git","ssh_url":"git@github.com:openstax/accounts-rails.git","clone_url":"https://github.com/openstax/accounts-rails.git","svn_url":"https://github.com/openstax/accounts-rails","homepage":null,"size":372,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"openstax:master","ref":"master","sha":"cdc88e2e3e1b2243cabd06fca31ed4231a84a83e","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":18779311,"name":"accounts-rails","full_name":"openstax/accounts-rails","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/accounts-rails","description":"Library for connecting to OpenStax Accounts from Rails","fork":false,"url":"https://api.github.com/repos/openstax/accounts-rails","forks_url":"https://api.github.com/repos/openstax/accounts-rails/forks","keys_url":"https://api.github.com/repos/openstax/accounts-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/accounts-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/accounts-rails/teams","hooks_url":"https://api.github.com/repos/openstax/accounts-rails/hooks","issue_events_url":"https://api.github.com/repos/openstax/accounts-rails/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/accounts-rails/events","assignees_url":"https://api.github.com/repos/openstax/accounts-rails/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/accounts-rails/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/accounts-rails/tags","blobs_url":"https://api.github.com/repos/openstax/accounts-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/accounts-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/accounts-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/accounts-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/accounts-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/accounts-rails/languages","stargazers_url":"https://api.github.com/repos/openstax/accounts-rails/stargazers","contributors_url":"https://api.github.com/repos/openstax/accounts-rails/contributors","subscribers_url":"https://api.github.com/repos/openstax/accounts-rails/subscribers","subscription_url":"https://api.github.com/repos/openstax/accounts-rails/subscription","commits_url":"https://api.github.com/repos/openstax/accounts-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/accounts-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/accounts-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/accounts-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/accounts-rails/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/accounts-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/accounts-rails/merges","archive_url":"https://api.github.com/repos/openstax/accounts-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/accounts-rails/downloads","issues_url":"https://api.github.com/repos/openstax/accounts-rails/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/accounts-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/accounts-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/accounts-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/accounts-rails/labels{/name}","releases_url":"https://api.github.com/repos/openstax/accounts-rails/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/accounts-rails/deployments","created_at":"2014-04-14T22:39:06Z","updated_at":"2016-01-11T02:02:23Z","pushed_at":"2016-04-19T17:28:51Z","git_url":"git://github.com/openstax/accounts-rails.git","ssh_url":"git@github.com:openstax/accounts-rails.git","clone_url":"https://github.com/openstax/accounts-rails.git","svn_url":"https://github.com/openstax/accounts-rails","homepage":null,"size":372,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstax/accounts-rails/pulls/47"},"html":{"href":"https://github.com/openstax/accounts-rails/pull/47"},"issue":{"href":"https://api.github.com/repos/openstax/accounts-rails/issues/47"},"comments":{"href":"https://api.github.com/repos/openstax/accounts-rails/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/openstax/accounts-rails/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/openstax/accounts-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstax/accounts-rails/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/openstax/accounts-rails/statuses/30fe949c57e57e2ee8cd11ca37c8016ae8a785c8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jpslav","id":1001691,"avatar_url":"https://avatars.githubusercontent.com/u/1001691?v=3","gravatar_id":"","url":"https://api.github.com/users/jpslav","html_url":"https://github.com/jpslav","followers_url":"https://api.github.com/users/jpslav/followers","following_url":"https://api.github.com/users/jpslav/following{/other_user}","gists_url":"https://api.github.com/users/jpslav/gists{/gist_id}","starred_url":"https://api.github.com/users/jpslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpslav/subscriptions","organizations_url":"https://api.github.com/users/jpslav/orgs","repos_url":"https://api.github.com/users/jpslav/repos","events_url":"https://api.github.com/users/jpslav/events{/privacy}","received_events_url":"https://api.github.com/users/jpslav/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":28,"deletions":4,"changed_files":4}}