{"action":"created","issue":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5748","repository_url":"https://api.github.com/repos/CenterForOpenScience/osf.io","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5748/labels{/name}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5748/comments","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5748/events","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5748","id":156851093,"number":5748,"title":"[Feature/versions] Surface Versions on files [OSF-6026]","user":{"login":"SSJohns","id":8713195,"avatar_url":"https://avatars.githubusercontent.com/u/8713195?v=3","gravatar_id":"","url":"https://api.github.com/users/SSJohns","html_url":"https://github.com/SSJohns","followers_url":"https://api.github.com/users/SSJohns/followers","following_url":"https://api.github.com/users/SSJohns/following{/other_user}","gists_url":"https://api.github.com/users/SSJohns/gists{/gist_id}","starred_url":"https://api.github.com/users/SSJohns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSJohns/subscriptions","organizations_url":"https://api.github.com/users/SSJohns/orgs","repos_url":"https://api.github.com/users/SSJohns/repos","events_url":"https://api.github.com/users/SSJohns/events{/privacy}","received_events_url":"https://api.github.com/users/SSJohns/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-05-25T21:09:46Z","updated_at":"2016-07-18T16:50:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5748","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5748","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/5748.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/5748.patch"},"body":"<!-- Before submit your Pull Request, make sure you picked\r\n     the right branch:\r\n\r\n     - For hotfixes, select \"master\" as the target branch\r\n     - For new features, select \"develop\" as the target branch\r\n     - For release feature fixes, select the relevant release branch (release/X.Y.Z) as the target branch -->\r\n\r\n## Purpose\r\n\r\nThe changes introduced a feature that would let users see what version of the file they were looking at on the files page. In addition when they clicked that version they would be taken to the files-view page on the Revisions tab, and be able to see what version of the file they would be looking at. Clicking the \"Version #\" at the top of the page would take them to the Revisions tab and further clicking of it would keep them on that page.\r\n\r\n## Changes\r\n\r\nI made changes to a lot of files, on the front end I made a versions column on the files tab and in the files view page the version number is displayed alongside the name of the file. \r\n\r\nI was not able to check for dropbox or any other addons, however the workings should be similar. A problem with my machine prevented local testing of those functions. \r\n\r\nAll of the features are purely front end changes so it would be hard to implement unit test for them. \r\n\r\n## Images\r\n\r\n### Before\r\n![Before Uno](http://imgur.com/JUMBdmE.png)\r\n\r\n![Before Dos](http://imgur.com/SJKt4wW.png)\r\n\r\n### After\r\n![After One](http://imgur.com/O4LKVjS.png)\r\n\r\n![After Two](http://imgur.com/XJIacqe.png)\r\n\r\n## Side effects\r\n\r\nIf the fangorn files are used as a template in any other places the the default columns could be initialized as Name and Version. This behavior might be  undesirable. \r\n\r\nEditied a few inhouse functions that are used in other places. Mainly -fangornTitleColumn to be host to a helper function. This should still work in the way the previous one did in all other places in the code that it is used.\r\n\r\n## Ticket\r\n\r\nhttps://openscience.atlassian.net/browse/OSF-6026"},"comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments/233387760","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5748#issuecomment-233387760","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5748","id":233387760,"user":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T16:50:17Z","updated_at":"2016-07-18T16:50:17Z","body":"Pinging @pattisdr to make her aware of this feature, since she is working on porting the file detail page."}}
{"actor":{"display_login":"sloria"}}