{"action":"created","issue":{"url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/719","repository_url":"https://api.github.com/repos/azavea/cac-tripplanner","labels_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/719/labels{/name}","comments_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/719/comments","events_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/719/events","html_url":"https://github.com/azavea/cac-tripplanner/pull/719","id":196814500,"number":719,"title":"Feature/time to places","user":{"login":"flibbertigibbet","id":960264,"avatar_url":"https://avatars.githubusercontent.com/u/960264?v=3","gravatar_id":"","url":"https://api.github.com/users/flibbertigibbet","html_url":"https://github.com/flibbertigibbet","followers_url":"https://api.github.com/users/flibbertigibbet/followers","following_url":"https://api.github.com/users/flibbertigibbet/following{/other_user}","gists_url":"https://api.github.com/users/flibbertigibbet/gists{/gist_id}","starred_url":"https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibbertigibbet/subscriptions","organizations_url":"https://api.github.com/users/flibbertigibbet/orgs","repos_url":"https://api.github.com/users/flibbertigibbet/repos","events_url":"https://api.github.com/users/flibbertigibbet/events{/privacy}","received_events_url":"https://api.github.com/users/flibbertigibbet/received_events","type":"User","site_admin":false},"labels":[{"id":456286445,"url":"https://api.github.com/repos/azavea/cac-tripplanner/labels/redesign","name":"redesign","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"KlaasH","id":6598836,"avatar_url":"https://avatars.githubusercontent.com/u/6598836?v=3","gravatar_id":"","url":"https://api.github.com/users/KlaasH","html_url":"https://github.com/KlaasH","followers_url":"https://api.github.com/users/KlaasH/followers","following_url":"https://api.github.com/users/KlaasH/following{/other_user}","gists_url":"https://api.github.com/users/KlaasH/gists{/gist_id}","starred_url":"https://api.github.com/users/KlaasH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlaasH/subscriptions","organizations_url":"https://api.github.com/users/KlaasH/orgs","repos_url":"https://api.github.com/users/KlaasH/repos","events_url":"https://api.github.com/users/KlaasH/events{/privacy}","received_events_url":"https://api.github.com/users/KlaasH/received_events","type":"User","site_admin":false},"assignees":[{"login":"KlaasH","id":6598836,"avatar_url":"https://avatars.githubusercontent.com/u/6598836?v=3","gravatar_id":"","url":"https://api.github.com/users/KlaasH","html_url":"https://github.com/KlaasH","followers_url":"https://api.github.com/users/KlaasH/followers","following_url":"https://api.github.com/users/KlaasH/following{/other_user}","gists_url":"https://api.github.com/users/KlaasH/gists{/gist_id}","starred_url":"https://api.github.com/users/KlaasH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlaasH/subscriptions","organizations_url":"https://api.github.com/users/KlaasH/orgs","repos_url":"https://api.github.com/users/KlaasH/repos","events_url":"https://api.github.com/users/KlaasH/events{/privacy}","received_events_url":"https://api.github.com/users/KlaasH/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-21T00:14:08Z","updated_at":"2016-12-23T18:09:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/719","html_url":"https://github.com/azavea/cac-tripplanner/pull/719","diff_url":"https://github.com/azavea/cac-tripplanner/pull/719.diff","patch_url":"https://github.com/azavea/cac-tripplanner/pull/719.patch"},"body":"Closes #557.\r\n\r\nDisplay travel time to each destination in its card when a origin is set.\r\n\r\nRecalculates on change to origin or to any trip options. Displays on home page and in explore tab.\r\n\r\nIsochrone requests go to a special endpoint that bundles up OTP's response with a list of destinations filtered to be within the isochrone; however, we're no longer using those filtered locations, so if we're not bringing them back, we should remove that Django endpoint and just query OTP directly.\r\n\r\nFor efficiency and simplicity, I think that would be a good way to go. Otherwise we'd end up having to requery the travel times to each location and/or set up origin+destination distance caching to use whenever the isochrone scrubber moves.\r\n"},"comment":{"url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/comments/269026375","html_url":"https://github.com/azavea/cac-tripplanner/pull/719#issuecomment-269026375","issue_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/719","id":269026375,"user":{"login":"KlaasH","id":6598836,"avatar_url":"https://avatars.githubusercontent.com/u/6598836?v=3","gravatar_id":"","url":"https://api.github.com/users/KlaasH","html_url":"https://github.com/KlaasH","followers_url":"https://api.github.com/users/KlaasH/followers","following_url":"https://api.github.com/users/KlaasH/following{/other_user}","gists_url":"https://api.github.com/users/KlaasH/gists{/gist_id}","starred_url":"https://api.github.com/users/KlaasH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlaasH/subscriptions","organizations_url":"https://api.github.com/users/KlaasH/orgs","repos_url":"https://api.github.com/users/KlaasH/repos","events_url":"https://api.github.com/users/KlaasH/events{/privacy}","received_events_url":"https://api.github.com/users/KlaasH/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T18:09:01Z","updated_at":"2016-12-23T18:09:01Z","body":"Re where to put it: the OTP options setup in Explore looks to be the same as that in Directions except for waypoints, which aren't relevant to place times.  Probably the best thing would be for that to be factored out into some shared resource.  Maybe `CAC.Routing.Plans`?  Directions would have to have its own version that adds waypoints, but the rest looks to be common.\r\n\r\nA separate controller maybe makes the most sense.  It would mean more lines of code overall, to create the new controller and set it up with the listeners and such that it needs, rather than having it piggyback on either of the existing ones.  But it would probably be cleaner and easier to deal with.\r\n\r\nThat being said, I also did a proof-of-concept version of putting it in Explore, which I put in a branch and PRed against this branch: https://github.com/flibbertigibbet/cac-tripplanner/pull/1"}}
{"actor":{"display_login":"KlaasH"}}