{"action":"created","comment":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/comments/72455941","id":72455941,"diff_hunk":"@@ -5,390 +5,6 @@\n include Features::ActiveJobHelper\n \n describe Users::RegistrationsController, devise: true do\n-  describe '#update' do\n-    let(:user) { create(:user, :signed_up, email: 'old_email@example.com') }\n-    let(:second_user) do\n-      create(:user, :signed_up, email: 'mobile@example.com', mobile: '+1 (202) 555-1213')\n-    end\n-    let(:new_email) { 'new_email@example.com' }\n-    let!(:old_encrypted_password) { user.encrypted_password }\n-\n-    let(:attrs_with_already_taken_mobile) do\n-      {\n-        email: user.email,\n-        mobile: second_user.mobile,\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_with_new_email_and_mobile) do\n-      {\n-        email: new_email,\n-        mobile: '555-555-5555',\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_for_new_mobile) do\n-      {\n-        email: second_user.email,\n-        mobile: '555-555-5555',\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_with_blank_mobile) do\n-      {\n-        email: second_user.email,\n-        mobile: '',\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_with_mobile) do\n-      {\n-        email: second_user.email,\n-        mobile: second_user.mobile,\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_with_new_email) do\n-      {\n-        email: new_email,\n-        mobile: user.mobile,\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_without_current_password) do\n-      {\n-        email: user.email,\n-        mobile: second_user.mobile,\n-        current_password: '',\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_with_invalid_current_password) do\n-      {\n-        email: user.email,\n-        mobile: user.mobile,\n-        current_password: 'foo',\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_with_blank_email) do\n-      {\n-        email: '',\n-        mobile: user.mobile,\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    let(:attrs_with_new_valid_password) do\n-      {\n-        email: user.email,\n-        mobile: user.mobile,\n-        current_password: '!1aZ' * 32,\n-        password: '@Aaaaaa1'\n-      }\n-    end\n-\n-    let(:attrs_with_new_invalid_password) do\n-      {\n-        email: user.email,\n-        mobile: user.mobile,\n-        current_password: '!1aZ' * 32,\n-        password: '123'\n-      }\n-    end\n-\n-    let(:attrs_with_blank_new_password) do\n-      {\n-        email: user.email,\n-        mobile: user.mobile,\n-        current_password: '!1aZ' * 32,\n-        password: ''\n-      }\n-    end\n-\n-    shared_examples 'adding_mobile' do\n-      it 'redirects to phone confirmation page with message', sms: true do\n-        expect(flash[:notice]).\n-          to eq t('devise.registrations.mobile_update_needs_confirmation')\n-\n-        expect(response).to redirect_to phone_confirmation_send_path\n-\n-        expect(user.reload.mobile).to_not eq '+1 (555) 555-5555'\n-\n-        expect(enqueued_jobs.size).to eq 1\n-      end\n-    end\n-\n-    shared_examples 'updating_profile' do\n-      it 'redirects to user edit page with flash notice' do\n-        expect(response).to redirect_to(edit_user_registration_path)\n-\n-        expect(flash[:notice]).to eq t('devise.registrations.updated')\n-      end\n-    end\n-\n-    shared_examples 'updating_mobile' do\n-      it 'redirects to phone confirmation page with success message' do\n-        expect(response).to redirect_to(phone_confirmation_send_path)\n-\n-        expect(flash[:notice]).to eq t('devise.registrations.mobile_update_needs_confirmation')\n-\n-        expect(test_user.reload.mobile).to_not eq '+1 (555) 555-5555'\n-      end\n-    end\n-\n-    shared_examples 'updating_both_email_and_mobile' do\n-      it 'redirects to phone confirmation page with success message' do\n-        expect(response).to redirect_to(phone_confirmation_send_path)\n-\n-        expect(flash[:notice]).\n-          to eq t('devise.registrations.email_and_mobile_need_confirmation')\n-\n-        expect(test_user.reload.mobile).to_not eq '+1 (555) 555-5555'\n-      end\n-    end\n-\n-    context 'user updates existing mobile number' do\n-      before do\n-        sign_in(second_user)\n-        reset_job_queues\n-        patch :update, update_user_profile_form: attrs_for_new_mobile\n-      end\n-\n-      it_behaves_like 'updating_mobile' do\n-        let(:test_user) { second_user }\n-      end\n-\n-      it 'allows the user to abandon confirmation' do\n-        get :edit\n-\n-        expect(response).to render_template(:edit)\n-      end\n-    end\n-\n-    it 'tracks the phone number update event' do\n-      sign_in(second_user)\n-\n-      stub_analytics(second_user)\n-      expect(@analytics).to receive(:track_event).\n-        with('User asked to update their phone number')\n-\n-      patch :update, update_user_profile_form: attrs_for_new_mobile\n-    end","path":"spec/controllers/users/registrations_controller_spec.rb","position":188,"original_position":188,"commit_id":"2da2af28b51a693898515fcbd4b185adf405336e","original_commit_id":"2da2af28b51a693898515fcbd4b185adf405336e","user":{"login":"monfresh","id":811150,"avatar_url":"https://avatars.githubusercontent.com/u/811150?v=3","gravatar_id":"","url":"https://api.github.com/users/monfresh","html_url":"https://github.com/monfresh","followers_url":"https://api.github.com/users/monfresh/followers","following_url":"https://api.github.com/users/monfresh/following{/other_user}","gists_url":"https://api.github.com/users/monfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/monfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monfresh/subscriptions","organizations_url":"https://api.github.com/users/monfresh/orgs","repos_url":"https://api.github.com/users/monfresh/repos","events_url":"https://api.github.com/users/monfresh/events{/privacy}","received_events_url":"https://api.github.com/users/monfresh/received_events","type":"User","site_admin":false},"body":"Please make sure we have a test for this event tracking.","created_at":"2016-07-27T14:59:19Z","updated_at":"2016-07-27T14:59:19Z","html_url":"https://github.com/18F/identity-idp/pull/303#discussion_r72455941","pull_request_url":"https://api.github.com/repos/18F/identity-idp/pulls/303","_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments/72455941"},"html":{"href":"https://github.com/18F/identity-idp/pull/303#discussion_r72455941"},"pull_request":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/303","id":78527696,"html_url":"https://github.com/18F/identity-idp/pull/303","diff_url":"https://github.com/18F/identity-idp/pull/303.diff","patch_url":"https://github.com/18F/identity-idp/pull/303.patch","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/303","number":303,"state":"closed","locked":false,"title":"Remove #edit and #update from registrations_controller","user":{"login":"sbc100","id":515813,"avatar_url":"https://avatars.githubusercontent.com/u/515813?v=3","gravatar_id":"","url":"https://api.github.com/users/sbc100","html_url":"https://github.com/sbc100","followers_url":"https://api.github.com/users/sbc100/followers","following_url":"https://api.github.com/users/sbc100/following{/other_user}","gists_url":"https://api.github.com/users/sbc100/gists{/gist_id}","starred_url":"https://api.github.com/users/sbc100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbc100/subscriptions","organizations_url":"https://api.github.com/users/sbc100/orgs","repos_url":"https://api.github.com/users/sbc100/repos","events_url":"https://api.github.com/users/sbc100/events{/privacy}","received_events_url":"https://api.github.com/users/sbc100/received_events","type":"User","site_admin":false},"body":"User profile editing is now done by a seperate\r\ncontroller.","created_at":"2016-07-22T19:26:31Z","updated_at":"2016-07-27T14:59:19Z","closed_at":"2016-07-26T22:35:13Z","merged_at":"2016-07-26T22:35:13Z","merge_commit_sha":"4ee002e426f490db4adbb88a9d0ee795c5348ccb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/identity-idp/pulls/303/commits","review_comments_url":"https://api.github.com/repos/18F/identity-idp/pulls/303/comments","review_comment_url":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/303/comments","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/2da2af28b51a693898515fcbd4b185adf405336e","head":{"label":"18F:remove_devise_edit","ref":"remove_devise_edit","sha":"2da2af28b51a693898515fcbd4b185adf405336e","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18f PoC Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2016-07-24T01:13:40Z","pushed_at":"2016-07-26T22:35:17Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://upaya-idp-dev.18f.gov/","size":8459,"stargazers_count":16,"watchers_count":16,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":16,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"27432b4ab7299286e153f95b6153b8d3ae6c417b","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18f PoC Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2016-07-24T01:13:40Z","pushed_at":"2016-07-26T22:35:17Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://upaya-idp-dev.18f.gov/","size":8459,"stargazers_count":16,"watchers_count":16,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/303"},"html":{"href":"https://github.com/18F/identity-idp/pull/303"},"issue":{"href":"https://api.github.com/repos/18F/identity-idp/issues/303"},"comments":{"href":"https://api.github.com/repos/18F/identity-idp/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/18F/identity-idp/statuses/2da2af28b51a693898515fcbd4b185adf405336e"}}}}
{"actor":{"display_login":"monfresh"}}