{"action":"created","issue":{"url":"https://api.github.com/repos/graphql-java/graphql-java/issues/57","repository_url":"https://api.github.com/repos/graphql-java/graphql-java","labels_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/57/comments","events_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/57/events","html_url":"https://github.com/graphql-java/graphql-java/issues/57","id":123275233,"number":57,"title":"DataFetchingEnvironment creation","user":{"login":"FernsPaanakker","id":5843128,"avatar_url":"https://avatars.githubusercontent.com/u/5843128?v=3","gravatar_id":"","url":"https://api.github.com/users/FernsPaanakker","html_url":"https://github.com/FernsPaanakker","followers_url":"https://api.github.com/users/FernsPaanakker/followers","following_url":"https://api.github.com/users/FernsPaanakker/following{/other_user}","gists_url":"https://api.github.com/users/FernsPaanakker/gists{/gist_id}","starred_url":"https://api.github.com/users/FernsPaanakker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernsPaanakker/subscriptions","organizations_url":"https://api.github.com/users/FernsPaanakker/orgs","repos_url":"https://api.github.com/users/FernsPaanakker/repos","events_url":"https://api.github.com/users/FernsPaanakker/events{/privacy}","received_events_url":"https://api.github.com/users/FernsPaanakker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2015-12-21T13:00:43Z","updated_at":"2016-12-19T00:22:12Z","closed_at":null,"body":"The DataFetchingEnvironment which is created in the ExecutionStrategy.java uses executionContext.getRoot() (line 37) but in the DataFetchingEnvironment itself, the parameter is named context. Shouldn't the executionContext.getRoot() be replaced with executionContext? That way, the whole executionContext is available within the DataFetcher.\n\nI changed this in my fork to be able to add errors from within the DataFetcher (I use this for server-side input validation in mutations).  \n"},"comment":{"url":"https://api.github.com/repos/graphql-java/graphql-java/issues/comments/267858157","html_url":"https://github.com/graphql-java/graphql-java/issues/57#issuecomment-267858157","issue_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/57","id":267858157,"user":{"login":"dminkovsky","id":218725,"avatar_url":"https://avatars.githubusercontent.com/u/218725?v=3","gravatar_id":"","url":"https://api.github.com/users/dminkovsky","html_url":"https://github.com/dminkovsky","followers_url":"https://api.github.com/users/dminkovsky/followers","following_url":"https://api.github.com/users/dminkovsky/following{/other_user}","gists_url":"https://api.github.com/users/dminkovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dminkovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dminkovsky/subscriptions","organizations_url":"https://api.github.com/users/dminkovsky/orgs","repos_url":"https://api.github.com/users/dminkovsky/repos","events_url":"https://api.github.com/users/dminkovsky/events{/privacy}","received_events_url":"https://api.github.com/users/dminkovsky/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T00:22:12Z","updated_at":"2016-12-19T00:22:12Z","body":"Hi, thank you for posting. I believe this issue is related to a misunderstanding of how GraphQL execution works and confusion around the root (passed to `GraphQL#execute()`) and \"source\" from `DataFetchingEnvironment#source()` in the DataFetcher, and even the \"execution context\" which is an API. We should improve documentation, but I am closing this as this is not a big/not something we'll change. Thanks."}}
{"actor":{"display_login":"dminkovsky"}}