{"action":"created","comment":{"url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/comments/67925704","id":67925704,"diff_hunk":"@@ -90,22 +90,34 @@ def read_blkio_stats(container, dimensions, stats, t):\n         # numbers). We need to group and report the stats of each block\n         # device independently.\n         blkio_stats = {}\n+        blkio_major_stats = {}\n+        blkio_minor_stats = {}\n+\n         for value in values:\n+\n             k = '{key}-{major}-{minor}'.format(key=key,","path":"dockerplugin.py","position":9,"original_position":9,"commit_id":"174ac7517ce01b8589285f0025da200f8aa0f207","original_commit_id":"174ac7517ce01b8589285f0025da200f8aa0f207","user":{"login":"mpetazzoni","id":879507,"avatar_url":"https://avatars.githubusercontent.com/u/879507?v=3","gravatar_id":"","url":"https://api.github.com/users/mpetazzoni","html_url":"https://github.com/mpetazzoni","followers_url":"https://api.github.com/users/mpetazzoni/followers","following_url":"https://api.github.com/users/mpetazzoni/following{/other_user}","gists_url":"https://api.github.com/users/mpetazzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mpetazzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpetazzoni/subscriptions","organizations_url":"https://api.github.com/users/mpetazzoni/orgs","repos_url":"https://api.github.com/users/mpetazzoni/repos","events_url":"https://api.github.com/users/mpetazzoni/events{/privacy}","received_events_url":"https://api.github.com/users/mpetazzoni/received_events","type":"User","site_admin":false},"body":"You need to change this too then","created_at":"2016-06-21T18:32:23Z","updated_at":"2016-06-21T18:32:23Z","html_url":"https://github.com/signalfx/docker-collectd-plugin/pull/6#discussion_r67925704","pull_request_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/comments/67925704"},"html":{"href":"https://github.com/signalfx/docker-collectd-plugin/pull/6#discussion_r67925704"},"pull_request":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6","id":74619232,"html_url":"https://github.com/signalfx/docker-collectd-plugin/pull/6","diff_url":"https://github.com/signalfx/docker-collectd-plugin/pull/6.diff","patch_url":"https://github.com/signalfx/docker-collectd-plugin/pull/6.patch","issue_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/6","number":6,"state":"open","locked":false,"title":"move cpucore and device major minor from part of metric name to dimen…","user":{"login":"dgriff-tools","id":8363187,"avatar_url":"https://avatars.githubusercontent.com/u/8363187?v=3","gravatar_id":"","url":"https://api.github.com/users/dgriff-tools","html_url":"https://github.com/dgriff-tools","followers_url":"https://api.github.com/users/dgriff-tools/followers","following_url":"https://api.github.com/users/dgriff-tools/following{/other_user}","gists_url":"https://api.github.com/users/dgriff-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/dgriff-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgriff-tools/subscriptions","organizations_url":"https://api.github.com/users/dgriff-tools/orgs","repos_url":"https://api.github.com/users/dgriff-tools/repos","events_url":"https://api.github.com/users/dgriff-tools/events{/privacy}","received_events_url":"https://api.github.com/users/dgriff-tools/received_events","type":"User","site_admin":false},"body":"…sions\r\n\r\nThis is an enhancement based on https://signalfuse.atlassian.net/browse/FUSE-9263?filter=-1\r\n","created_at":"2016-06-21T14:13:29Z","updated_at":"2016-06-21T18:32:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dcee3181e796f71abca57d64f5994ed09c68b87","assignee":{"login":"mpetazzoni","id":879507,"avatar_url":"https://avatars.githubusercontent.com/u/879507?v=3","gravatar_id":"","url":"https://api.github.com/users/mpetazzoni","html_url":"https://github.com/mpetazzoni","followers_url":"https://api.github.com/users/mpetazzoni/followers","following_url":"https://api.github.com/users/mpetazzoni/following{/other_user}","gists_url":"https://api.github.com/users/mpetazzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mpetazzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpetazzoni/subscriptions","organizations_url":"https://api.github.com/users/mpetazzoni/orgs","repos_url":"https://api.github.com/users/mpetazzoni/repos","events_url":"https://api.github.com/users/mpetazzoni/events{/privacy}","received_events_url":"https://api.github.com/users/mpetazzoni/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6/commits","review_comments_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6/comments","review_comment_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/6/comments","statuses_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/statuses/174ac7517ce01b8589285f0025da200f8aa0f207","head":{"label":"signalfx:mv_metric_namepart_to_dim","ref":"mv_metric_namepart_to_dim","sha":"174ac7517ce01b8589285f0025da200f8aa0f207","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":34009973,"name":"docker-collectd-plugin","full_name":"signalfx/docker-collectd-plugin","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/docker-collectd-plugin","description":"CollectD plugin for Docker container statistics","fork":true,"url":"https://api.github.com/repos/signalfx/docker-collectd-plugin","forks_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/forks","keys_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/teams","hooks_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/hooks","issue_events_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/events","assignees_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/tags","blobs_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/languages","stargazers_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/stargazers","contributors_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/contributors","subscribers_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/subscribers","subscription_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/subscription","commits_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/merges","archive_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/downloads","issues_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/deployments","created_at":"2015-04-15T18:01:20Z","updated_at":"2016-03-25T16:19:34Z","pushed_at":"2016-06-21T14:13:29Z","git_url":"git://github.com/signalfx/docker-collectd-plugin.git","ssh_url":"git@github.com:signalfx/docker-collectd-plugin.git","clone_url":"https://github.com/signalfx/docker-collectd-plugin.git","svn_url":"https://github.com/signalfx/docker-collectd-plugin","homepage":"","size":46,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"signalfx:master","ref":"master","sha":"1e4ada70a52ca374b82d8c5222c8919c297e69fb","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":34009973,"name":"docker-collectd-plugin","full_name":"signalfx/docker-collectd-plugin","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/docker-collectd-plugin","description":"CollectD plugin for Docker container statistics","fork":true,"url":"https://api.github.com/repos/signalfx/docker-collectd-plugin","forks_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/forks","keys_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/teams","hooks_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/hooks","issue_events_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/events","assignees_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/tags","blobs_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/languages","stargazers_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/stargazers","contributors_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/contributors","subscribers_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/subscribers","subscription_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/subscription","commits_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/merges","archive_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/downloads","issues_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/docker-collectd-plugin/deployments","created_at":"2015-04-15T18:01:20Z","updated_at":"2016-03-25T16:19:34Z","pushed_at":"2016-06-21T14:13:29Z","git_url":"git://github.com/signalfx/docker-collectd-plugin.git","ssh_url":"git@github.com:signalfx/docker-collectd-plugin.git","clone_url":"https://github.com/signalfx/docker-collectd-plugin.git","svn_url":"https://github.com/signalfx/docker-collectd-plugin","homepage":"","size":46,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6"},"html":{"href":"https://github.com/signalfx/docker-collectd-plugin/pull/6"},"issue":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/6"},"comments":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/signalfx/docker-collectd-plugin/statuses/174ac7517ce01b8589285f0025da200f8aa0f207"}}}}
{"actor":{"display_login":"mpetazzoni"}}