{"action":"created","issue":{"url":"https://api.github.com/repos/flosell/lambdacd-cctray/issues/9","repository_url":"https://api.github.com/repos/flosell/lambdacd-cctray","labels_url":"https://api.github.com/repos/flosell/lambdacd-cctray/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/flosell/lambdacd-cctray/issues/9/comments","events_url":"https://api.github.com/repos/flosell/lambdacd-cctray/issues/9/events","html_url":"https://github.com/flosell/lambdacd-cctray/issues/9","id":162662197,"number":9,"title":"Make using prefix configurable","user":{"login":"SimonMonecke","id":4587790,"avatar_url":"https://avatars.githubusercontent.com/u/4587790?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonMonecke","html_url":"https://github.com/SimonMonecke","followers_url":"https://api.github.com/users/SimonMonecke/followers","following_url":"https://api.github.com/users/SimonMonecke/following{/other_user}","gists_url":"https://api.github.com/users/SimonMonecke/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonMonecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonMonecke/subscriptions","organizations_url":"https://api.github.com/users/SimonMonecke/orgs","repos_url":"https://api.github.com/users/SimonMonecke/repos","events_url":"https://api.github.com/users/SimonMonecke/events{/privacy}","received_events_url":"https://api.github.com/users/SimonMonecke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/flosell/lambdacd-cctray/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/flosell/lambdacd-cctray/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-28T11:22:03Z","updated_at":"2016-06-29T06:35:18Z","closed_at":null,"body":"Hi Flosell,\r\n\r\nwe don't need the new prefix feature because we have separate cctrays for our pipelines.\r\nIt would be nice if we could disable the use of prefixes. \r\n\r\n```\r\nuse-prefix (... config)\r\nname (if (and use-prefix pipeline-name)\r\n    (str pipeline-name \" :: \" step-name)\r\n    step-name)\r\n```\r\n\r\nRegards,\r\n  Miriam & Simon"},"comment":{"url":"https://api.github.com/repos/flosell/lambdacd-cctray/issues/comments/229268998","html_url":"https://github.com/flosell/lambdacd-cctray/issues/9#issuecomment-229268998","issue_url":"https://api.github.com/repos/flosell/lambdacd-cctray/issues/9","id":229268998,"user":{"login":"flosell","id":540525,"avatar_url":"https://avatars.githubusercontent.com/u/540525?v=3","gravatar_id":"","url":"https://api.github.com/users/flosell","html_url":"https://github.com/flosell","followers_url":"https://api.github.com/users/flosell/followers","following_url":"https://api.github.com/users/flosell/following{/other_user}","gists_url":"https://api.github.com/users/flosell/gists{/gist_id}","starred_url":"https://api.github.com/users/flosell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosell/subscriptions","organizations_url":"https://api.github.com/users/flosell/orgs","repos_url":"https://api.github.com/users/flosell/repos","events_url":"https://api.github.com/users/flosell/events{/privacy}","received_events_url":"https://api.github.com/users/flosell/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T06:35:18Z","updated_at":"2016-06-29T06:35:18Z","body":"I would just use the config map of the LambdaCD pipeline, like we already\ndo for the `:ui-url` config. Makes it easier to add config parameters\nwithout a breaking api change and to work with multiple pipelines.\nOn Jun 29, 2016 08:27, \"Simon Monecke\" <notifications@github.com> wrote:\n\n> We did not send you a PR because we do not know how to configure\n> LambdaCD-CCtray.\n> We could add a optional parameter to provide a config-map:\n>\n> (defn cctray-handler-for\n>   ([pipeline]\n>    (cctray-handler-for pipeline {:fallback-base-url nil}))\n>   ([pipeline {fallback-base-url :fallback-base-url :as config}]\n>\n> If this is okay for you we will send you a PR.\n>\n> Regards,\n> Simon\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/flosell/lambdacd-cctray/issues/9#issuecomment-229267906>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AAg_bSiDipe9JZJL7-K3ZKfCLHGkJ2bKks5qQhBZgaJpZM4I__0n>\n> .\n>\n"}}
{"actor":{"display_login":"flosell"}}