{"action":"created","comment":{"url":"https://api.github.com/repos/ibm-js/deliteful/pulls/comments/67491367","id":67491367,"diff_hunk":"@@ -315,8 +221,87 @@ define([\n \t\t\t};\n \t\t}),\n \n+\t\t/*jshint maxcomplexity:14*/\n+\t\tcomputeProperties: function (props) {\n+\t\t\tif (this.pageLength > 0) {\n+\t\t\t\tif (\"_busy\" in props || \"hideOnPageLoad\" in props || \"autoPaging\" in props || \"showNoItems\" in props) {\n+\t\t\t\t\tthis._updateListView();\n+\t\t\t\t}\n+\n+\t\t\t\tif (\"loadPreviousMessage\" in props || \"loadingMessage\" in props || \"_showPreviousPageLoader\" in props) {\n+\t\t\t\t\tif (this.previousPageLoader && this.previousPageLoader.deliver) {\n+\t\t\t\t\t\tthis.previousPageLoader.labels = {\n+\t\t\t\t\t\t\tloadMessage: string.substitute(this.loadPreviousMessage, this),\n+\t\t\t\t\t\t\tloadingMessage: this.loadingMessage\n+\t\t\t\t\t\t};\n+\t\t\t\t\t\tthis.previousPageLoader.deliver();","path":"list/PageableList.js","position":260,"original_position":260,"commit_id":"54787617998e9a3993f6d59071f0e0ce8c82262c","original_commit_id":"54787617998e9a3993f6d59071f0e0ce8c82262c","user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"body":"`string.substitute(this.loadPreviousMessage, this)` means that loadMessage could change as a response to any property change at all.\r\n\r\nSo I think probably you should move this logic outside of all the `if()` statements and just say something like:\r\n\r\n```\r\nthis.previousPageLoader.label = this.previousPageLoader.loading ?\r\n   this.loadingMessage : string.substitute(this.loadPreviousMessage, this);\r\n```","created_at":"2016-06-17T10:36:47Z","updated_at":"2016-06-17T10:36:47Z","html_url":"https://github.com/ibm-js/deliteful/pull/630#discussion_r67491367","pull_request_url":"https://api.github.com/repos/ibm-js/deliteful/pulls/630","_links":{"self":{"href":"https://api.github.com/repos/ibm-js/deliteful/pulls/comments/67491367"},"html":{"href":"https://github.com/ibm-js/deliteful/pull/630#discussion_r67491367"},"pull_request":{"href":"https://api.github.com/repos/ibm-js/deliteful/pulls/630"}}},"pull_request":{"url":"https://api.github.com/repos/ibm-js/deliteful/pulls/630","id":74086734,"html_url":"https://github.com/ibm-js/deliteful/pull/630","diff_url":"https://github.com/ibm-js/deliteful/pull/630.diff","patch_url":"https://github.com/ibm-js/deliteful/pull/630.patch","issue_url":"https://api.github.com/repos/ibm-js/deliteful/issues/630","number":630,"state":"open","locked":false,"title":"List/PageableList: refactor. Fixes #626. Fixes #595","user":{"login":"brunano21","id":4410485,"avatar_url":"https://avatars.githubusercontent.com/u/4410485?v=3","gravatar_id":"","url":"https://api.github.com/users/brunano21","html_url":"https://github.com/brunano21","followers_url":"https://api.github.com/users/brunano21/followers","following_url":"https://api.github.com/users/brunano21/following{/other_user}","gists_url":"https://api.github.com/users/brunano21/gists{/gist_id}","starred_url":"https://api.github.com/users/brunano21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunano21/subscriptions","organizations_url":"https://api.github.com/users/brunano21/orgs","repos_url":"https://api.github.com/users/brunano21/repos","events_url":"https://api.github.com/users/brunano21/events{/privacy}","received_events_url":"https://api.github.com/users/brunano21/received_events","type":"User","site_admin":false},"body":"- List and PageableList now have their own templates.\r\n- Add a customizable no-items node feature\r\n- Hide list containerNode when the list's source is empty.\r\n- Add new loader helper widget for PageableList.\r\n- A11y fixes.\r\n- List and PagebeableList's role can be now set through the `type` property.\r\n- Test fix in order to match the new widgets.\r\n- Update List/PageableList documentation.\r\n- Fixes #626. \r\n- Fixes #595","created_at":"2016-06-16T14:06:14Z","updated_at":"2016-06-17T10:36:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a334224ad015b6c2a40dd8ff7d04633b19c55542","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ibm-js/deliteful/pulls/630/commits","review_comments_url":"https://api.github.com/repos/ibm-js/deliteful/pulls/630/comments","review_comment_url":"https://api.github.com/repos/ibm-js/deliteful/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ibm-js/deliteful/issues/630/comments","statuses_url":"https://api.github.com/repos/ibm-js/deliteful/statuses/54787617998e9a3993f6d59071f0e0ce8c82262c","head":{"label":"brunano21:list2","ref":"list2","sha":"54787617998e9a3993f6d59071f0e0ce8c82262c","user":{"login":"brunano21","id":4410485,"avatar_url":"https://avatars.githubusercontent.com/u/4410485?v=3","gravatar_id":"","url":"https://api.github.com/users/brunano21","html_url":"https://github.com/brunano21","followers_url":"https://api.github.com/users/brunano21/followers","following_url":"https://api.github.com/users/brunano21/following{/other_user}","gists_url":"https://api.github.com/users/brunano21/gists{/gist_id}","starred_url":"https://api.github.com/users/brunano21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunano21/subscriptions","organizations_url":"https://api.github.com/users/brunano21/orgs","repos_url":"https://api.github.com/users/brunano21/repos","events_url":"https://api.github.com/users/brunano21/events{/privacy}","received_events_url":"https://api.github.com/users/brunano21/received_events","type":"User","site_admin":false},"repo":{"id":59582488,"name":"deliteful","full_name":"brunano21/deliteful","owner":{"login":"brunano21","id":4410485,"avatar_url":"https://avatars.githubusercontent.com/u/4410485?v=3","gravatar_id":"","url":"https://api.github.com/users/brunano21","html_url":"https://github.com/brunano21","followers_url":"https://api.github.com/users/brunano21/followers","following_url":"https://api.github.com/users/brunano21/following{/other_user}","gists_url":"https://api.github.com/users/brunano21/gists{/gist_id}","starred_url":"https://api.github.com/users/brunano21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunano21/subscriptions","organizations_url":"https://api.github.com/users/brunano21/orgs","repos_url":"https://api.github.com/users/brunano21/repos","events_url":"https://api.github.com/users/brunano21/events{/privacy}","received_events_url":"https://api.github.com/users/brunano21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brunano21/deliteful","description":"Multichannel (desktop/mobile) UI Custom Elements Library","fork":true,"url":"https://api.github.com/repos/brunano21/deliteful","forks_url":"https://api.github.com/repos/brunano21/deliteful/forks","keys_url":"https://api.github.com/repos/brunano21/deliteful/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brunano21/deliteful/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brunano21/deliteful/teams","hooks_url":"https://api.github.com/repos/brunano21/deliteful/hooks","issue_events_url":"https://api.github.com/repos/brunano21/deliteful/issues/events{/number}","events_url":"https://api.github.com/repos/brunano21/deliteful/events","assignees_url":"https://api.github.com/repos/brunano21/deliteful/assignees{/user}","branches_url":"https://api.github.com/repos/brunano21/deliteful/branches{/branch}","tags_url":"https://api.github.com/repos/brunano21/deliteful/tags","blobs_url":"https://api.github.com/repos/brunano21/deliteful/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brunano21/deliteful/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brunano21/deliteful/git/refs{/sha}","trees_url":"https://api.github.com/repos/brunano21/deliteful/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brunano21/deliteful/statuses/{sha}","languages_url":"https://api.github.com/repos/brunano21/deliteful/languages","stargazers_url":"https://api.github.com/repos/brunano21/deliteful/stargazers","contributors_url":"https://api.github.com/repos/brunano21/deliteful/contributors","subscribers_url":"https://api.github.com/repos/brunano21/deliteful/subscribers","subscription_url":"https://api.github.com/repos/brunano21/deliteful/subscription","commits_url":"https://api.github.com/repos/brunano21/deliteful/commits{/sha}","git_commits_url":"https://api.github.com/repos/brunano21/deliteful/git/commits{/sha}","comments_url":"https://api.github.com/repos/brunano21/deliteful/comments{/number}","issue_comment_url":"https://api.github.com/repos/brunano21/deliteful/issues/comments{/number}","contents_url":"https://api.github.com/repos/brunano21/deliteful/contents/{+path}","compare_url":"https://api.github.com/repos/brunano21/deliteful/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brunano21/deliteful/merges","archive_url":"https://api.github.com/repos/brunano21/deliteful/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brunano21/deliteful/downloads","issues_url":"https://api.github.com/repos/brunano21/deliteful/issues{/number}","pulls_url":"https://api.github.com/repos/brunano21/deliteful/pulls{/number}","milestones_url":"https://api.github.com/repos/brunano21/deliteful/milestones{/number}","notifications_url":"https://api.github.com/repos/brunano21/deliteful/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brunano21/deliteful/labels{/name}","releases_url":"https://api.github.com/repos/brunano21/deliteful/releases{/id}","deployments_url":"https://api.github.com/repos/brunano21/deliteful/deployments","created_at":"2016-05-24T14:54:50Z","updated_at":"2016-05-24T14:54:51Z","pushed_at":"2016-06-16T14:04:48Z","git_url":"git://github.com/brunano21/deliteful.git","ssh_url":"git@github.com:brunano21/deliteful.git","clone_url":"https://github.com/brunano21/deliteful.git","svn_url":"https://github.com/brunano21/deliteful","homepage":"http://ibm-js.github.io/deliteful","size":7418,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ibm-js:master","ref":"master","sha":"7658c93b3ad61a793265adb14c086cee23de1023","user":{"login":"ibm-js","id":3503805,"avatar_url":"https://avatars.githubusercontent.com/u/3503805?v=3","gravatar_id":"","url":"https://api.github.com/users/ibm-js","html_url":"https://github.com/ibm-js","followers_url":"https://api.github.com/users/ibm-js/followers","following_url":"https://api.github.com/users/ibm-js/following{/other_user}","gists_url":"https://api.github.com/users/ibm-js/gists{/gist_id}","starred_url":"https://api.github.com/users/ibm-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibm-js/subscriptions","organizations_url":"https://api.github.com/users/ibm-js/orgs","repos_url":"https://api.github.com/users/ibm-js/repos","events_url":"https://api.github.com/users/ibm-js/events{/privacy}","received_events_url":"https://api.github.com/users/ibm-js/received_events","type":"Organization","site_admin":false},"repo":{"id":15434799,"name":"deliteful","full_name":"ibm-js/deliteful","owner":{"login":"ibm-js","id":3503805,"avatar_url":"https://avatars.githubusercontent.com/u/3503805?v=3","gravatar_id":"","url":"https://api.github.com/users/ibm-js","html_url":"https://github.com/ibm-js","followers_url":"https://api.github.com/users/ibm-js/followers","following_url":"https://api.github.com/users/ibm-js/following{/other_user}","gists_url":"https://api.github.com/users/ibm-js/gists{/gist_id}","starred_url":"https://api.github.com/users/ibm-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibm-js/subscriptions","organizations_url":"https://api.github.com/users/ibm-js/orgs","repos_url":"https://api.github.com/users/ibm-js/repos","events_url":"https://api.github.com/users/ibm-js/events{/privacy}","received_events_url":"https://api.github.com/users/ibm-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ibm-js/deliteful","description":"Multichannel (desktop/mobile) UI Custom Elements Library","fork":false,"url":"https://api.github.com/repos/ibm-js/deliteful","forks_url":"https://api.github.com/repos/ibm-js/deliteful/forks","keys_url":"https://api.github.com/repos/ibm-js/deliteful/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibm-js/deliteful/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibm-js/deliteful/teams","hooks_url":"https://api.github.com/repos/ibm-js/deliteful/hooks","issue_events_url":"https://api.github.com/repos/ibm-js/deliteful/issues/events{/number}","events_url":"https://api.github.com/repos/ibm-js/deliteful/events","assignees_url":"https://api.github.com/repos/ibm-js/deliteful/assignees{/user}","branches_url":"https://api.github.com/repos/ibm-js/deliteful/branches{/branch}","tags_url":"https://api.github.com/repos/ibm-js/deliteful/tags","blobs_url":"https://api.github.com/repos/ibm-js/deliteful/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibm-js/deliteful/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibm-js/deliteful/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibm-js/deliteful/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibm-js/deliteful/statuses/{sha}","languages_url":"https://api.github.com/repos/ibm-js/deliteful/languages","stargazers_url":"https://api.github.com/repos/ibm-js/deliteful/stargazers","contributors_url":"https://api.github.com/repos/ibm-js/deliteful/contributors","subscribers_url":"https://api.github.com/repos/ibm-js/deliteful/subscribers","subscription_url":"https://api.github.com/repos/ibm-js/deliteful/subscription","commits_url":"https://api.github.com/repos/ibm-js/deliteful/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibm-js/deliteful/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibm-js/deliteful/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibm-js/deliteful/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibm-js/deliteful/contents/{+path}","compare_url":"https://api.github.com/repos/ibm-js/deliteful/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibm-js/deliteful/merges","archive_url":"https://api.github.com/repos/ibm-js/deliteful/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibm-js/deliteful/downloads","issues_url":"https://api.github.com/repos/ibm-js/deliteful/issues{/number}","pulls_url":"https://api.github.com/repos/ibm-js/deliteful/pulls{/number}","milestones_url":"https://api.github.com/repos/ibm-js/deliteful/milestones{/number}","notifications_url":"https://api.github.com/repos/ibm-js/deliteful/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibm-js/deliteful/labels{/name}","releases_url":"https://api.github.com/repos/ibm-js/deliteful/releases{/id}","deployments_url":"https://api.github.com/repos/ibm-js/deliteful/deployments","created_at":"2013-12-25T12:25:24Z","updated_at":"2016-02-15T01:55:21Z","pushed_at":"2016-06-16T14:06:14Z","git_url":"git://github.com/ibm-js/deliteful.git","ssh_url":"git@github.com:ibm-js/deliteful.git","clone_url":"https://github.com/ibm-js/deliteful.git","svn_url":"https://github.com/ibm-js/deliteful","homepage":"http://ibm-js.github.io/deliteful","size":61740,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":101,"forks":38,"open_issues":101,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ibm-js/deliteful/pulls/630"},"html":{"href":"https://github.com/ibm-js/deliteful/pull/630"},"issue":{"href":"https://api.github.com/repos/ibm-js/deliteful/issues/630"},"comments":{"href":"https://api.github.com/repos/ibm-js/deliteful/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/ibm-js/deliteful/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/ibm-js/deliteful/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ibm-js/deliteful/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/ibm-js/deliteful/statuses/54787617998e9a3993f6d59071f0e0ce8c82262c"}}}}
{"actor":{"display_login":"wkeese"}}