{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/84355408","pull_request_review_id":5138585,"id":84355408,"diff_hunk":"@@ -101,23 +109,33 @@ LeastSquaresFit::execute()\n     mooseError(\"In LeastSquresFit size of data in x_values and y_values must be equal\");\n   if (_x_values.size() == 0)\n     mooseError(\"In LeastSquresFit size of data in x_values and y_values must be > 0\");\n-  PolynomialFit pf(_x_values, _y_values, _order, true);\n-  pf.generate();\n \n+  //Create a copy of _x_values that we can modify.\n+  std::vector<Real> x_values(_x_values.begin(), _x_values.end());\n+  std::vector<Real> y_values(_y_values.begin(), _y_values.end());\n+\n+  for (unsigned int i = 0; i < _x_values.size(); ++i)","path":"framework/src/vectorpostprocessors/LeastSquaresFit.C","position":33,"original_position":33,"commit_id":"ded9df3234cbde2d28a5902b3bacd6315e019eb7","original_commit_id":"ded9df3234cbde2d28a5902b3bacd6315e019eb7","user":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"body":"```\r\nfor (auto i = beginIndex(_x_values); ; i < _x_values.size(); ++i)\r\n```","created_at":"2016-10-20T19:10:10Z","updated_at":"2016-10-20T19:10:53Z","html_url":"https://github.com/idaholab/moose/pull/7915#discussion_r84355408","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/7915","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/84355408"},"html":{"href":"https://github.com/idaholab/moose/pull/7915#discussion_r84355408"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7915"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/7915","id":90259379,"html_url":"https://github.com/idaholab/moose/pull/7915","diff_url":"https://github.com/idaholab/moose/pull/7915.diff","patch_url":"https://github.com/idaholab/moose/pull/7915.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/7915","number":7915,"state":"open","locked":false,"title":"Added shift scale capabilities to least squares fit ","user":{"login":"hoffwm","id":13870356,"avatar_url":"https://avatars.githubusercontent.com/u/13870356?v=3","gravatar_id":"","url":"https://api.github.com/users/hoffwm","html_url":"https://github.com/hoffwm","followers_url":"https://api.github.com/users/hoffwm/followers","following_url":"https://api.github.com/users/hoffwm/following{/other_user}","gists_url":"https://api.github.com/users/hoffwm/gists{/gist_id}","starred_url":"https://api.github.com/users/hoffwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoffwm/subscriptions","organizations_url":"https://api.github.com/users/hoffwm/orgs","repos_url":"https://api.github.com/users/hoffwm/repos","events_url":"https://api.github.com/users/hoffwm/events{/privacy}","received_events_url":"https://api.github.com/users/hoffwm/received_events","type":"User","site_admin":false},"body":"closes #7907","created_at":"2016-10-20T18:52:04Z","updated_at":"2016-10-20T19:10:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a69f8fe47a26f858706db358b6d60b68c9fd76f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/7915/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/7915/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/7915/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/ded9df3234cbde2d28a5902b3bacd6315e019eb7","head":{"label":"hoffwm:vpp_changes","ref":"vpp_changes","sha":"ded9df3234cbde2d28a5902b3bacd6315e019eb7","user":{"login":"hoffwm","id":13870356,"avatar_url":"https://avatars.githubusercontent.com/u/13870356?v=3","gravatar_id":"","url":"https://api.github.com/users/hoffwm","html_url":"https://github.com/hoffwm","followers_url":"https://api.github.com/users/hoffwm/followers","following_url":"https://api.github.com/users/hoffwm/following{/other_user}","gists_url":"https://api.github.com/users/hoffwm/gists{/gist_id}","starred_url":"https://api.github.com/users/hoffwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoffwm/subscriptions","organizations_url":"https://api.github.com/users/hoffwm/orgs","repos_url":"https://api.github.com/users/hoffwm/repos","events_url":"https://api.github.com/users/hoffwm/events{/privacy}","received_events_url":"https://api.github.com/users/hoffwm/received_events","type":"User","site_admin":false},"repo":{"id":41036193,"name":"moose","full_name":"hoffwm/moose","owner":{"login":"hoffwm","id":13870356,"avatar_url":"https://avatars.githubusercontent.com/u/13870356?v=3","gravatar_id":"","url":"https://api.github.com/users/hoffwm","html_url":"https://github.com/hoffwm","followers_url":"https://api.github.com/users/hoffwm/followers","following_url":"https://api.github.com/users/hoffwm/following{/other_user}","gists_url":"https://api.github.com/users/hoffwm/gists{/gist_id}","starred_url":"https://api.github.com/users/hoffwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoffwm/subscriptions","organizations_url":"https://api.github.com/users/hoffwm/orgs","repos_url":"https://api.github.com/users/hoffwm/repos","events_url":"https://api.github.com/users/hoffwm/events{/privacy}","received_events_url":"https://api.github.com/users/hoffwm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoffwm/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/hoffwm/moose","forks_url":"https://api.github.com/repos/hoffwm/moose/forks","keys_url":"https://api.github.com/repos/hoffwm/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoffwm/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoffwm/moose/teams","hooks_url":"https://api.github.com/repos/hoffwm/moose/hooks","issue_events_url":"https://api.github.com/repos/hoffwm/moose/issues/events{/number}","events_url":"https://api.github.com/repos/hoffwm/moose/events","assignees_url":"https://api.github.com/repos/hoffwm/moose/assignees{/user}","branches_url":"https://api.github.com/repos/hoffwm/moose/branches{/branch}","tags_url":"https://api.github.com/repos/hoffwm/moose/tags","blobs_url":"https://api.github.com/repos/hoffwm/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoffwm/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoffwm/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoffwm/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoffwm/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/hoffwm/moose/languages","stargazers_url":"https://api.github.com/repos/hoffwm/moose/stargazers","contributors_url":"https://api.github.com/repos/hoffwm/moose/contributors","subscribers_url":"https://api.github.com/repos/hoffwm/moose/subscribers","subscription_url":"https://api.github.com/repos/hoffwm/moose/subscription","commits_url":"https://api.github.com/repos/hoffwm/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoffwm/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoffwm/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoffwm/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoffwm/moose/contents/{+path}","compare_url":"https://api.github.com/repos/hoffwm/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoffwm/moose/merges","archive_url":"https://api.github.com/repos/hoffwm/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoffwm/moose/downloads","issues_url":"https://api.github.com/repos/hoffwm/moose/issues{/number}","pulls_url":"https://api.github.com/repos/hoffwm/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/hoffwm/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/hoffwm/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoffwm/moose/labels{/name}","releases_url":"https://api.github.com/repos/hoffwm/moose/releases{/id}","deployments_url":"https://api.github.com/repos/hoffwm/moose/deployments","created_at":"2015-08-19T13:37:14Z","updated_at":"2015-08-19T13:37:26Z","pushed_at":"2016-10-20T18:51:22Z","git_url":"git://github.com/hoffwm/moose.git","ssh_url":"git@github.com:hoffwm/moose.git","clone_url":"https://github.com/hoffwm/moose.git","svn_url":"https://github.com/hoffwm/moose","homepage":"http://www.mooseframework.org","size":113531,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"0fc2aee882dbfeb20d3779f59c620e6f6d12a81f","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2016-10-18T19:15:30Z","pushed_at":"2016-10-20T18:52:04Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":166083,"stargazers_count":173,"watchers_count":173,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":701,"forks":285,"open_issues":701,"watchers":173,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7915"},"html":{"href":"https://github.com/idaholab/moose/pull/7915"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/7915"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/7915/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7915/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7915/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/ded9df3234cbde2d28a5902b3bacd6315e019eb7"}}}}
{"actor":{"display_login":"dschwen"}}