{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/1812","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/1812/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/1812/comments","events_url":"https://api.github.com/repos/apple/swift/issues/1812/events","html_url":"https://github.com/apple/swift/pull/1812","id":143090563,"number":1812,"title":"[Parser] Cleans up parsing of function parameter attributes","user":{"login":"manavgabhawala","id":8603246,"avatar_url":"https://avatars.githubusercontent.com/u/8603246?v=3","gravatar_id":"","url":"https://api.github.com/users/manavgabhawala","html_url":"https://github.com/manavgabhawala","followers_url":"https://api.github.com/users/manavgabhawala/followers","following_url":"https://api.github.com/users/manavgabhawala/following{/other_user}","gists_url":"https://api.github.com/users/manavgabhawala/gists{/gist_id}","starred_url":"https://api.github.com/users/manavgabhawala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manavgabhawala/subscriptions","organizations_url":"https://api.github.com/users/manavgabhawala/orgs","repos_url":"https://api.github.com/users/manavgabhawala/repos","events_url":"https://api.github.com/users/manavgabhawala/events{/privacy}","received_events_url":"https://api.github.com/users/manavgabhawala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lattner","id":15152540,"avatar_url":"https://avatars.githubusercontent.com/u/15152540?v=3","gravatar_id":"","url":"https://api.github.com/users/lattner","html_url":"https://github.com/lattner","followers_url":"https://api.github.com/users/lattner/followers","following_url":"https://api.github.com/users/lattner/following{/other_user}","gists_url":"https://api.github.com/users/lattner/gists{/gist_id}","starred_url":"https://api.github.com/users/lattner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lattner/subscriptions","organizations_url":"https://api.github.com/users/lattner/orgs","repos_url":"https://api.github.com/users/lattner/repos","events_url":"https://api.github.com/users/lattner/events{/privacy}","received_events_url":"https://api.github.com/users/lattner/received_events","type":"User","site_admin":false},"milestone":null,"comments":21,"created_at":"2016-03-23T21:56:58Z","updated_at":"2016-03-29T16:38:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/1812","html_url":"https://github.com/apple/swift/pull/1812","diff_url":"https://github.com/apple/swift/pull/1812.diff","patch_url":"https://github.com/apple/swift/pull/1812.patch"},"body":"#### What's in this pull request?\r\nThis pull request cleans up parsing of parameter attributes by parsing the inout, let and var tokens better. It cleans up the implementation to work better with SE-0003 by giving better fix-its and diagnostics for var as parameter attributes. It implements SE-0053 to disallow `let` as an attribute. It provides better fixits for `inout` that are either duplicated or misplaced to better implement SE-0031. \r\n\r\n#### Resolved bug number: \r\n- [SR-979](https://bugs.swift.org/browse/SR-979)\r\n- [SR-1020](https://bugs.swift.org/browse/SR-1020)\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n **Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/202988734","html_url":"https://github.com/apple/swift/pull/1812#issuecomment-202988734","issue_url":"https://api.github.com/repos/apple/swift/issues/1812","id":202988734,"user":{"login":"lattner","id":15152540,"avatar_url":"https://avatars.githubusercontent.com/u/15152540?v=3","gravatar_id":"","url":"https://api.github.com/users/lattner","html_url":"https://github.com/lattner","followers_url":"https://api.github.com/users/lattner/followers","following_url":"https://api.github.com/users/lattner/following{/other_user}","gists_url":"https://api.github.com/users/lattner/gists{/gist_id}","starred_url":"https://api.github.com/users/lattner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lattner/subscriptions","organizations_url":"https://api.github.com/users/lattner/orgs","repos_url":"https://api.github.com/users/lattner/repos","events_url":"https://api.github.com/users/lattner/events{/privacy}","received_events_url":"https://api.github.com/users/lattner/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T16:38:02Z","updated_at":"2016-03-29T16:38:02Z","body":">If I'm not mistaken, fixItRemove already handles this. In fact the comments there talk about this issue to (quoted below):\r\n\r\nAh, you're right, thanks!"}}