{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/786","repository_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/786/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/786/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/786/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/786","id":159937554,"number":786,"title":"Revert results function to accept multiple types","user":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=3","gravatar_id":"","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-06-13T12:21:18Z","updated_at":"2016-06-16T13:01:41Z","closed_at":"2016-06-15T00:01:29Z","pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/786","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/786","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/786.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/786.patch"},"body":" - `results` collects attributes from an object and creates a DataFrame.\r\n   This object could be a Calculator, in which case it must look for the\r\n   attributes in other objects. Otherwise, just collect them, create the\r\n   DataFrame and return."},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/226478074","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/786#issuecomment-226478074","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/786","id":226478074,"user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T13:01:41Z","updated_at":"2016-06-16T13:01:41Z","body":"@talumbau said:\r\n> I think the specific sequence of events was: created a dropq version of create_distribution_table (along with its own version of the results function), then realized the usage was identical to that in Tax-Calculator, deleted dropq version and switched to Tax-Calculator version, left in the results function which now has no callers. Does that answer the question?\r\n\r\nYes, thank you."}}
{"actor":{"display_login":"martinholmer"}}