{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-notifications/pulls/comments/77648133","id":77648133,"diff_hunk":"@@ -8,78 +8,51 @@\n     DictField\n )\n \n-from edx_notifications.data import (\n-    NotificationMessage,\n-    NotificationType,\n-    UserNotification\n-)\n-\n \n-class DictFieldSerializer(serializers.WritableField):\n+class DictFieldSerializer(serializers.Field):\n     \"\"\"\n     A specialized serializer for a dictionary field\n     \"\"\"\n \n-    def to_native(self, obj):\n+    def to_representation(self, obj):\n         \"\"\"\n         to json format\n         \"\"\"\n         return DictField.to_json(obj)\n \n-    def from_native(self, data):\n+    def to_internal_value(self, data):\n         \"\"\"\n         from json format\n         \"\"\"\n         return DictField.from_json(data)\n \n \n-class NotificationTypeSerializer(serializers.Serializer):\n+class NotificationTypeSerializer(serializers.Serializer):  # pylint: disable=abstract-method\n     \"\"\"\n     DRF Serializer definition for NotificationType\n     \"\"\"\n \n     name = serializers.CharField(max_length=255)\n     renderer = serializers.CharField(max_length=255)\n \n-    def restore_object(self, attrs, instance=None):\n-        \"\"\"\n-        Instantiate a new object from the deserialized data\n-        \"\"\"\n-\n-        if instance is not None:\n-            raise NotImplementedError()\n \n-        return NotificationType(**attrs)  # pylint: disable=star-args\n-\n-\n-class NotificationMessageSerializer(serializers.Serializer):\n+class NotificationMessageSerializer(serializers.Serializer):  # pylint: disable=abstract-method\n     \"\"\"\n     DRF Serializer definition for NotificationMessage\n     \"\"\"\n \n     id = serializers.IntegerField()\n     msg_type = NotificationTypeSerializer()\n     namespace = serializers.CharField(max_length=128, required=False)","path":"edx_notifications/serializers.py","position":60,"original_position":60,"commit_id":"49f95e2d77f7a48e58725a4e9d75c8d833295ba0","original_commit_id":"49f95e2d77f7a48e58725a4e9d75c8d833295ba0","user":{"login":"mattdrayer","id":4520595,"avatar_url":"https://avatars.githubusercontent.com/u/4520595?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdrayer","html_url":"https://github.com/mattdrayer","followers_url":"https://api.github.com/users/mattdrayer/followers","following_url":"https://api.github.com/users/mattdrayer/following{/other_user}","gists_url":"https://api.github.com/users/mattdrayer/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdrayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdrayer/subscriptions","organizations_url":"https://api.github.com/users/mattdrayer/orgs","repos_url":"https://api.github.com/users/mattdrayer/repos","events_url":"https://api.github.com/users/mattdrayer/events{/privacy}","received_events_url":"https://api.github.com/users/mattdrayer/received_events","type":"User","site_admin":false},"body":"Is this field already nullable?","created_at":"2016-09-06T14:39:41Z","updated_at":"2016-09-06T14:39:41Z","html_url":"https://github.com/edx/edx-notifications/pull/165#discussion_r77648133","pull_request_url":"https://api.github.com/repos/edx/edx-notifications/pulls/165","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/comments/77648133"},"html":{"href":"https://github.com/edx/edx-notifications/pull/165#discussion_r77648133"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-notifications/pulls/165","id":84059873,"html_url":"https://github.com/edx/edx-notifications/pull/165","diff_url":"https://github.com/edx/edx-notifications/pull/165.diff","patch_url":"https://github.com/edx/edx-notifications/pull/165.patch","issue_url":"https://api.github.com/repos/edx/edx-notifications/issues/165","number":165,"state":"open","locked":false,"title":"YONK-386: upgrade edx notifications app to django 1.8","user":{"login":"msaqib52","id":3198290,"avatar_url":"https://avatars.githubusercontent.com/u/3198290?v=3","gravatar_id":"","url":"https://api.github.com/users/msaqib52","html_url":"https://github.com/msaqib52","followers_url":"https://api.github.com/users/msaqib52/followers","following_url":"https://api.github.com/users/msaqib52/following{/other_user}","gists_url":"https://api.github.com/users/msaqib52/gists{/gist_id}","starred_url":"https://api.github.com/users/msaqib52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msaqib52/subscriptions","organizations_url":"https://api.github.com/users/msaqib52/orgs","repos_url":"https://api.github.com/users/msaqib52/repos","events_url":"https://api.github.com/users/msaqib52/events{/privacy}","received_events_url":"https://api.github.com/users/msaqib52/received_events","type":"User","site_admin":false},"body":"We are using edx notification in solutions fork of edx-platform. Since we are upgrading solutions fork to Eucalyptus which requires django 1.8, we need to upgrade edx notifications app to django 1.8 also. This PR upgrades edx notifications app to django 1.8.\r\n\r\n@ziafazal would please review?","created_at":"2016-09-06T04:45:53Z","updated_at":"2016-09-06T14:39:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e848d0e66f7e9a03eec21cdedabb1988a3308e98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-notifications/pulls/165/commits","review_comments_url":"https://api.github.com/repos/edx/edx-notifications/pulls/165/comments","review_comment_url":"https://api.github.com/repos/edx/edx-notifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-notifications/issues/165/comments","statuses_url":"https://api.github.com/repos/edx/edx-notifications/statuses/49f95e2d77f7a48e58725a4e9d75c8d833295ba0","head":{"label":"edx:msaqib52/YONK-386","ref":"msaqib52/YONK-386","sha":"49f95e2d77f7a48e58725a4e9d75c8d833295ba0","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29154572,"name":"edx-notifications","full_name":"edx/edx-notifications","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-notifications","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-notifications","forks_url":"https://api.github.com/repos/edx/edx-notifications/forks","keys_url":"https://api.github.com/repos/edx/edx-notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-notifications/teams","hooks_url":"https://api.github.com/repos/edx/edx-notifications/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-notifications/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-notifications/events","assignees_url":"https://api.github.com/repos/edx/edx-notifications/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-notifications/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-notifications/tags","blobs_url":"https://api.github.com/repos/edx/edx-notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-notifications/languages","stargazers_url":"https://api.github.com/repos/edx/edx-notifications/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-notifications/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-notifications/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-notifications/subscription","commits_url":"https://api.github.com/repos/edx/edx-notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-notifications/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-notifications/merges","archive_url":"https://api.github.com/repos/edx/edx-notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-notifications/downloads","issues_url":"https://api.github.com/repos/edx/edx-notifications/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-notifications/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-notifications/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-notifications/deployments","created_at":"2015-01-12T20:11:02Z","updated_at":"2016-02-10T12:04:44Z","pushed_at":"2016-09-06T13:07:49Z","git_url":"git://github.com/edx/edx-notifications.git","ssh_url":"git@github.com:edx/edx-notifications.git","clone_url":"https://github.com/edx/edx-notifications.git","svn_url":"https://github.com/edx/edx-notifications","homepage":null,"size":1152,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"484014cc87278a5c474e6cc1bca14c417fb35599","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29154572,"name":"edx-notifications","full_name":"edx/edx-notifications","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-notifications","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-notifications","forks_url":"https://api.github.com/repos/edx/edx-notifications/forks","keys_url":"https://api.github.com/repos/edx/edx-notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-notifications/teams","hooks_url":"https://api.github.com/repos/edx/edx-notifications/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-notifications/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-notifications/events","assignees_url":"https://api.github.com/repos/edx/edx-notifications/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-notifications/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-notifications/tags","blobs_url":"https://api.github.com/repos/edx/edx-notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-notifications/languages","stargazers_url":"https://api.github.com/repos/edx/edx-notifications/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-notifications/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-notifications/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-notifications/subscription","commits_url":"https://api.github.com/repos/edx/edx-notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-notifications/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-notifications/merges","archive_url":"https://api.github.com/repos/edx/edx-notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-notifications/downloads","issues_url":"https://api.github.com/repos/edx/edx-notifications/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-notifications/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-notifications/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-notifications/deployments","created_at":"2015-01-12T20:11:02Z","updated_at":"2016-02-10T12:04:44Z","pushed_at":"2016-09-06T13:07:49Z","git_url":"git://github.com/edx/edx-notifications.git","ssh_url":"git@github.com:edx/edx-notifications.git","clone_url":"https://github.com/edx/edx-notifications.git","svn_url":"https://github.com/edx/edx-notifications","homepage":null,"size":1152,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/165"},"html":{"href":"https://github.com/edx/edx-notifications/pull/165"},"issue":{"href":"https://api.github.com/repos/edx/edx-notifications/issues/165"},"comments":{"href":"https://api.github.com/repos/edx/edx-notifications/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-notifications/statuses/49f95e2d77f7a48e58725a4e9d75c8d833295ba0"}}}}
{"actor":{"display_login":"mattdrayer"}}