{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/5512","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/5512/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/5512/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/5512/events","html_url":"https://github.com/brave/browser-laptop/issues/5512","id":188317874,"number":5512,"title":"Brave should restore session gracefully after a crash","user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"labels":[{"id":377923957,"url":"https://api.github.com/repos/brave/browser-laptop/labels/parity","name":"parity","color":"0052cc","default":false},{"id":450712969,"url":"https://api.github.com/repos/brave/browser-laptop/labels/priority/high","name":"priority/high","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/24","html_url":"https://github.com/brave/browser-laptop/milestone/24","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/24/labels","id":1865602,"number":24,"title":"1.0.0","description":"Freeze Oct 24","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":0,"state":"open","created_at":"2016-07-05T17:42:46Z","updated_at":"2016-12-12T18:10:19Z","due_on":"2017-01-18T00:00:00Z","closed_at":null},"comments":4,"created_at":"2016-11-09T18:26:59Z","updated_at":"2016-12-12T23:27:56Z","closed_at":null,"body":"**Did you search for similar issues before submitting this one?**\r\nYes\r\n\r\n**Describe the issue you encountered:**\r\nBrave is not aware during re-launch that it had a crash during the last run. In some cases, it doesn't properly save the session file (leaving them with an empty session).\r\n\r\n**Expected behavior:**\r\nIf there is no valid session file, Brave should try to search for a last known good session to restore. Usually, the session is named with a \".tmp\" or similar extension before it gets renamed to the final \"session-store-1\". \r\n\r\nIf the session is not restorable, we should let the user know what happened.\r\n\r\nIf the session is fine, Brave should save a \"clean shutdown\" flag of some sort when saving.  Doing so would mean that this session file would need to be saved without that flag on startup, so that we can detect the condition.\r\n\r\nIn those cases, regardless of what the \"start brave with\" setting has, we should show an alert letting the user know:\r\n- Brave crashed and it was unexpected\r\n- We can try to restore the sites that were open, if they'd like us to\r\n\r\n- Steps to reproduce:\r\n    1. Launch Brave and open some tabs, each to a different site\r\n    2. On Windows, open up task manager. On Linux/Mac, use `ps -ef | grep brave`\r\n    3. Kill the main Brave process (end task or w/ kill command)\r\n\r\n- Screenshot if needed:\r\n\r\n- Any related issues:\r\n"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/266587013","html_url":"https://github.com/brave/browser-laptop/issues/5512#issuecomment-266587013","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/5512","id":266587013,"user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T23:27:56Z","updated_at":"2016-12-12T23:27:56Z","body":"@ktd99 apologies- maybe I responded to your other issue too quickly. Did you lose your data? or did you only lose the open tabs for one session?"}}
{"actor":{"display_login":"bsclifton"}}