{"action":"created","comment":{"url":"https://api.github.com/repos/apollostack/react-apollo/pulls/comments/87921957","pull_request_review_id":8513205,"id":87921957,"diff_hunk":"@@ -320,18 +316,15 @@ export default function graphql(\n       }\n \n       setInitialProps() {\n-        if (this.type === DocumentType.Mutation) return this.createWrappedMutation(this.props);\n+        if (this.type === DocumentType.Mutation) {\n+          return;\n+        }\n \n         // Create the observable but don't subscribe yet. The query won't\n         // fire until we do.\n         const opts: QueryOptions = this.calculateOptions(this.props);\n \n-        if (opts.skip) {\n-          this.data = assign({}, skippedQueryData) as any;\n-        } else {\n-          this.data = assign({}, defaultQueryData) as any;\n-          this.createQuery(opts);\n-        }\n+        this.createQuery(opts);","path":"src/graphql.tsx","position":127,"original_position":127,"commit_id":"bd2f887a559c2fe1ba7b3b89e9b337e3223a9402","original_commit_id":"bd2f887a559c2fe1ba7b3b89e9b337e3223a9402","user":{"login":"tmeasday","id":132554,"avatar_url":"https://avatars.githubusercontent.com/u/132554?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeasday","html_url":"https://github.com/tmeasday","followers_url":"https://api.github.com/users/tmeasday/followers","following_url":"https://api.github.com/users/tmeasday/following{/other_user}","gists_url":"https://api.github.com/users/tmeasday/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeasday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeasday/subscriptions","organizations_url":"https://api.github.com/users/tmeasday/orgs","repos_url":"https://api.github.com/users/tmeasday/repos","events_url":"https://api.github.com/users/tmeasday/events{/privacy}","received_events_url":"https://api.github.com/users/tmeasday/received_events","type":"User","site_admin":false},"body":"I think we are OK now because we don't even get to `setInitialProps` if we are skipping: https://github.com/apollostack/react-apollo/blob/bd2f887a559c2fe1ba7b3b89e9b337e3223a9402/src/graphql.tsx#L261","created_at":"2016-11-15T00:01:44Z","updated_at":"2016-11-15T00:01:44Z","html_url":"https://github.com/apollostack/react-apollo/pull/265#discussion_r87921957","pull_request_url":"https://api.github.com/repos/apollostack/react-apollo/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/apollostack/react-apollo/pulls/comments/87921957"},"html":{"href":"https://github.com/apollostack/react-apollo/pull/265#discussion_r87921957"},"pull_request":{"href":"https://api.github.com/repos/apollostack/react-apollo/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/apollostack/react-apollo/pulls/265","id":88946811,"html_url":"https://github.com/apollostack/react-apollo/pull/265","diff_url":"https://github.com/apollostack/react-apollo/pull/265.diff","patch_url":"https://github.com/apollostack/react-apollo/pull/265.patch","issue_url":"https://api.github.com/repos/apollostack/react-apollo/issues/265","number":265,"state":"closed","locked":false,"title":"Refactor to calculate data at render time","user":{"login":"tmeasday","id":132554,"avatar_url":"https://avatars.githubusercontent.com/u/132554?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeasday","html_url":"https://github.com/tmeasday","followers_url":"https://api.github.com/users/tmeasday/followers","following_url":"https://api.github.com/users/tmeasday/following{/other_user}","gists_url":"https://api.github.com/users/tmeasday/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeasday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeasday/subscriptions","organizations_url":"https://api.github.com/users/tmeasday/orgs","repos_url":"https://api.github.com/users/tmeasday/repos","events_url":"https://api.github.com/users/tmeasday/events{/privacy}","received_events_url":"https://api.github.com/users/tmeasday/received_events","type":"User","site_admin":false},"body":"WIP for #264 \n\nIssues outstanding\n1. I think `observableQuery.currentResult()` should return `errors` also. Need to PR AC for that.\n2. Slight weirdness with needing to store `previousData`. Moving forward we should just be able to blindly pass `currentResult` through; perhaps AC should cache `previousData`. But hopefully what I'm doing works for now.\n3. A bunch of tests failing, some due to the above, need to investigate more.\n","created_at":"2016-10-12T03:12:00Z","updated_at":"2016-11-15T00:01:52Z","closed_at":"2016-11-14T01:14:13Z","merged_at":"2016-11-14T01:14:13Z","merge_commit_sha":"1c85c07996c529d17d6c04859717a5017aa8a246","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollostack/react-apollo/pulls/265/commits","review_comments_url":"https://api.github.com/repos/apollostack/react-apollo/pulls/265/comments","review_comment_url":"https://api.github.com/repos/apollostack/react-apollo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollostack/react-apollo/issues/265/comments","statuses_url":"https://api.github.com/repos/apollostack/react-apollo/statuses/bd2f887a559c2fe1ba7b3b89e9b337e3223a9402","head":{"label":"apollostack:264-data-at-render-time","ref":"264-data-at-render-time","sha":"bd2f887a559c2fe1ba7b3b89e9b337e3223a9402","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":56192185,"name":"react-apollo","full_name":"apollostack/react-apollo","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/react-apollo","description":":recycle: React data container for the Apollo Client","fork":false,"url":"https://api.github.com/repos/apollostack/react-apollo","forks_url":"https://api.github.com/repos/apollostack/react-apollo/forks","keys_url":"https://api.github.com/repos/apollostack/react-apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/react-apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/react-apollo/teams","hooks_url":"https://api.github.com/repos/apollostack/react-apollo/hooks","issue_events_url":"https://api.github.com/repos/apollostack/react-apollo/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/react-apollo/events","assignees_url":"https://api.github.com/repos/apollostack/react-apollo/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/react-apollo/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/react-apollo/tags","blobs_url":"https://api.github.com/repos/apollostack/react-apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/react-apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/react-apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/react-apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/react-apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/react-apollo/languages","stargazers_url":"https://api.github.com/repos/apollostack/react-apollo/stargazers","contributors_url":"https://api.github.com/repos/apollostack/react-apollo/contributors","subscribers_url":"https://api.github.com/repos/apollostack/react-apollo/subscribers","subscription_url":"https://api.github.com/repos/apollostack/react-apollo/subscription","commits_url":"https://api.github.com/repos/apollostack/react-apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/react-apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/react-apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/react-apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/react-apollo/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/react-apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/react-apollo/merges","archive_url":"https://api.github.com/repos/apollostack/react-apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/react-apollo/downloads","issues_url":"https://api.github.com/repos/apollostack/react-apollo/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/react-apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/react-apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/react-apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/react-apollo/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/react-apollo/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/react-apollo/deployments","created_at":"2016-04-13T23:14:51Z","updated_at":"2016-11-14T23:26:51Z","pushed_at":"2016-11-14T01:48:03Z","git_url":"git://github.com/apollostack/react-apollo.git","ssh_url":"git@github.com:apollostack/react-apollo.git","clone_url":"https://github.com/apollostack/react-apollo.git","svn_url":"https://github.com/apollostack/react-apollo","homepage":"http://dev.apollodata.com/react/","size":1231,"stargazers_count":301,"watchers_count":301,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":29,"forks":45,"open_issues":29,"watchers":301,"default_branch":"master"}},"base":{"label":"apollostack:master","ref":"master","sha":"4bc975fea4950345b990dcce9dd1ef94652ff5b3","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":56192185,"name":"react-apollo","full_name":"apollostack/react-apollo","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/react-apollo","description":":recycle: React data container for the Apollo Client","fork":false,"url":"https://api.github.com/repos/apollostack/react-apollo","forks_url":"https://api.github.com/repos/apollostack/react-apollo/forks","keys_url":"https://api.github.com/repos/apollostack/react-apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/react-apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/react-apollo/teams","hooks_url":"https://api.github.com/repos/apollostack/react-apollo/hooks","issue_events_url":"https://api.github.com/repos/apollostack/react-apollo/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/react-apollo/events","assignees_url":"https://api.github.com/repos/apollostack/react-apollo/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/react-apollo/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/react-apollo/tags","blobs_url":"https://api.github.com/repos/apollostack/react-apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/react-apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/react-apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/react-apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/react-apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/react-apollo/languages","stargazers_url":"https://api.github.com/repos/apollostack/react-apollo/stargazers","contributors_url":"https://api.github.com/repos/apollostack/react-apollo/contributors","subscribers_url":"https://api.github.com/repos/apollostack/react-apollo/subscribers","subscription_url":"https://api.github.com/repos/apollostack/react-apollo/subscription","commits_url":"https://api.github.com/repos/apollostack/react-apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/react-apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/react-apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/react-apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/react-apollo/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/react-apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/react-apollo/merges","archive_url":"https://api.github.com/repos/apollostack/react-apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/react-apollo/downloads","issues_url":"https://api.github.com/repos/apollostack/react-apollo/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/react-apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/react-apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/react-apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/react-apollo/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/react-apollo/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/react-apollo/deployments","created_at":"2016-04-13T23:14:51Z","updated_at":"2016-11-14T23:26:51Z","pushed_at":"2016-11-14T01:48:03Z","git_url":"git://github.com/apollostack/react-apollo.git","ssh_url":"git@github.com:apollostack/react-apollo.git","clone_url":"https://github.com/apollostack/react-apollo.git","svn_url":"https://github.com/apollostack/react-apollo","homepage":"http://dev.apollodata.com/react/","size":1231,"stargazers_count":301,"watchers_count":301,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":29,"forks":45,"open_issues":29,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollostack/react-apollo/pulls/265"},"html":{"href":"https://github.com/apollostack/react-apollo/pull/265"},"issue":{"href":"https://api.github.com/repos/apollostack/react-apollo/issues/265"},"comments":{"href":"https://api.github.com/repos/apollostack/react-apollo/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/apollostack/react-apollo/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/apollostack/react-apollo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollostack/react-apollo/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/apollostack/react-apollo/statuses/bd2f887a559c2fe1ba7b3b89e9b337e3223a9402"}}}}
{"actor":{"display_login":"tmeasday"}}