{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/66762071","id":66762071,"diff_hunk":"@@ -325,7 +325,8 @@ end\n \n function digits!{T<:Integer}(a::AbstractArray{T,1}, n::Integer, base::Integer=10)\n     2 <= base || throw(ArgumentError(\"base must be ≥ 2, got $base\"))\n-    base - 1 <= typemax(T) || throw(ArgumentError(\"type $T too small for base $base\"))\n+    !applicable(typemax, T) ||","path":"base/intfuncs.jl","position":5,"original_position":5,"commit_id":"250f9bedf5e546a9a095b32636bfde9be85b2eb2","original_commit_id":"250f9bedf5e546a9a095b32636bfde9be85b2eb2","user":{"login":"simonbyrne","id":1692009,"avatar_url":"https://avatars.githubusercontent.com/u/1692009?v=3","gravatar_id":"","url":"https://api.github.com/users/simonbyrne","html_url":"https://github.com/simonbyrne","followers_url":"https://api.github.com/users/simonbyrne/followers","following_url":"https://api.github.com/users/simonbyrne/following{/other_user}","gists_url":"https://api.github.com/users/simonbyrne/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbyrne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbyrne/subscriptions","organizations_url":"https://api.github.com/users/simonbyrne/orgs","repos_url":"https://api.github.com/users/simonbyrne/repos","events_url":"https://api.github.com/users/simonbyrne/events{/privacy}","received_events_url":"https://api.github.com/users/simonbyrne/received_events","type":"User","site_admin":false},"body":"I'm not sure we really want to call `applicable` here: based on the `@code_llvm` it doesn't seem to be evaluated only at compile time. Unless anyone can think of something better, it might be better to just have `T == BigInt || base-1 <= typemax(T) || ... `","created_at":"2016-06-13T09:22:39Z","updated_at":"2016-06-13T09:22:39Z","html_url":"https://github.com/JuliaLang/julia/pull/16844#discussion_r66762071","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/16844","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/66762071"},"html":{"href":"https://github.com/JuliaLang/julia/pull/16844#discussion_r66762071"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16844"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/16844","id":73233550,"html_url":"https://github.com/JuliaLang/julia/pull/16844","diff_url":"https://github.com/JuliaLang/julia/pull/16844.diff","patch_url":"https://github.com/JuliaLang/julia/pull/16844.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/16844","number":16844,"state":"open","locked":false,"title":"digits!: check for typemax only when applicable","user":{"login":"rfourquet","id":8462914,"avatar_url":"https://avatars.githubusercontent.com/u/8462914?v=3","gravatar_id":"","url":"https://api.github.com/users/rfourquet","html_url":"https://github.com/rfourquet","followers_url":"https://api.github.com/users/rfourquet/followers","following_url":"https://api.github.com/users/rfourquet/following{/other_user}","gists_url":"https://api.github.com/users/rfourquet/gists{/gist_id}","starred_url":"https://api.github.com/users/rfourquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfourquet/subscriptions","organizations_url":"https://api.github.com/users/rfourquet/orgs","repos_url":"https://api.github.com/users/rfourquet/repos","events_url":"https://api.github.com/users/rfourquet/events{/privacy}","received_events_url":"https://api.github.com/users/rfourquet/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-09T15:20:46Z","updated_at":"2016-06-13T09:22:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afe218e0d94c5a314ec59026a985011f4b3084b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/16844/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/16844/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/16844/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/250f9bedf5e546a9a095b32636bfde9be85b2eb2","head":{"label":"rfourquet:rf/digits-big","ref":"rf/digits-big","sha":"250f9bedf5e546a9a095b32636bfde9be85b2eb2","user":{"login":"rfourquet","id":8462914,"avatar_url":"https://avatars.githubusercontent.com/u/8462914?v=3","gravatar_id":"","url":"https://api.github.com/users/rfourquet","html_url":"https://github.com/rfourquet","followers_url":"https://api.github.com/users/rfourquet/followers","following_url":"https://api.github.com/users/rfourquet/following{/other_user}","gists_url":"https://api.github.com/users/rfourquet/gists{/gist_id}","starred_url":"https://api.github.com/users/rfourquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfourquet/subscriptions","organizations_url":"https://api.github.com/users/rfourquet/orgs","repos_url":"https://api.github.com/users/rfourquet/repos","events_url":"https://api.github.com/users/rfourquet/events{/privacy}","received_events_url":"https://api.github.com/users/rfourquet/received_events","type":"User","site_admin":false},"repo":{"id":23011839,"name":"julia","full_name":"rfourquet/julia","owner":{"login":"rfourquet","id":8462914,"avatar_url":"https://avatars.githubusercontent.com/u/8462914?v=3","gravatar_id":"","url":"https://api.github.com/users/rfourquet","html_url":"https://github.com/rfourquet","followers_url":"https://api.github.com/users/rfourquet/followers","following_url":"https://api.github.com/users/rfourquet/following{/other_user}","gists_url":"https://api.github.com/users/rfourquet/gists{/gist_id}","starred_url":"https://api.github.com/users/rfourquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfourquet/subscriptions","organizations_url":"https://api.github.com/users/rfourquet/orgs","repos_url":"https://api.github.com/users/rfourquet/repos","events_url":"https://api.github.com/users/rfourquet/events{/privacy}","received_events_url":"https://api.github.com/users/rfourquet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfourquet/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/rfourquet/julia","forks_url":"https://api.github.com/repos/rfourquet/julia/forks","keys_url":"https://api.github.com/repos/rfourquet/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfourquet/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfourquet/julia/teams","hooks_url":"https://api.github.com/repos/rfourquet/julia/hooks","issue_events_url":"https://api.github.com/repos/rfourquet/julia/issues/events{/number}","events_url":"https://api.github.com/repos/rfourquet/julia/events","assignees_url":"https://api.github.com/repos/rfourquet/julia/assignees{/user}","branches_url":"https://api.github.com/repos/rfourquet/julia/branches{/branch}","tags_url":"https://api.github.com/repos/rfourquet/julia/tags","blobs_url":"https://api.github.com/repos/rfourquet/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfourquet/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfourquet/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfourquet/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfourquet/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/rfourquet/julia/languages","stargazers_url":"https://api.github.com/repos/rfourquet/julia/stargazers","contributors_url":"https://api.github.com/repos/rfourquet/julia/contributors","subscribers_url":"https://api.github.com/repos/rfourquet/julia/subscribers","subscription_url":"https://api.github.com/repos/rfourquet/julia/subscription","commits_url":"https://api.github.com/repos/rfourquet/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfourquet/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfourquet/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfourquet/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfourquet/julia/contents/{+path}","compare_url":"https://api.github.com/repos/rfourquet/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfourquet/julia/merges","archive_url":"https://api.github.com/repos/rfourquet/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfourquet/julia/downloads","issues_url":"https://api.github.com/repos/rfourquet/julia/issues{/number}","pulls_url":"https://api.github.com/repos/rfourquet/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/rfourquet/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/rfourquet/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfourquet/julia/labels{/name}","releases_url":"https://api.github.com/repos/rfourquet/julia/releases{/id}","deployments_url":"https://api.github.com/repos/rfourquet/julia/deployments","created_at":"2014-08-16T05:58:18Z","updated_at":"2016-06-08T08:52:23Z","pushed_at":"2016-06-13T07:16:00Z","git_url":"git://github.com/rfourquet/julia.git","ssh_url":"git@github.com:rfourquet/julia.git","clone_url":"https://github.com/rfourquet/julia.git","svn_url":"https://github.com/rfourquet/julia","homepage":"http://julialang.org/","size":84918,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"8479012e081e95b3c07b8b5449a77eef306864ad","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-06-13T08:01:20Z","pushed_at":"2016-06-13T09:21:23Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":394149,"stargazers_count":7127,"watchers_count":7127,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1645,"mirror_url":null,"open_issues_count":1812,"forks":1645,"open_issues":1812,"watchers":7127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16844"},"html":{"href":"https://github.com/JuliaLang/julia/pull/16844"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/16844"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/16844/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16844/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16844/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/250f9bedf5e546a9a095b32636bfde9be85b2eb2"}}}}
{"actor":{"display_login":"simonbyrne"}}