{"action":"created","comment":{"url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/comments/68367933","id":68367933,"diff_hunk":"@@ -84,29 +84,36 @@ Configure SingleSignOnServiceProvider bundle:\n ``` yaml\n # app/config/config.yml\n krtv_single_sign_on_service_provider:\n-    host:                 idp.example.com\n+    host:                 consumer1.com\n     host_scheme:          http\n \n     login_path:           /sso/login/\n \n     # Configuration for OTP managers\n     otp_manager:\n-        name:       http\n+        name: http\n         managers:\n             http:\n-                provider:    service # Active provider for HTTP OTP manager\n+                provider: guzzle     # Active provider for HTTP OTP manager\n                 providers:           # Available HTTP providers\n                     service:\n-                        id: acme_bundle.your_own_fetch_service.id\n+                        # the service must implement Krtv\\SingleSignOn\\Manager\\Http\\Provider\\ProviderInterface\n+                        id: krtv_single_sign_on_service_provider.security.authentication.otp_manager.http.provider.guzzle\n \n                     guzzle:\n-                        client:   acme_bundle.guzzle_service.id\n+                        # in case you don't have a guzzle client, you must create one\n+                        client:   acme_bundle.guzzle_service\n+                        # the route that was created in the IdP bundle\n                         resource: http://idp.example.com/internal/v1/sso\n \n     otp_parameter:        _otp\n     secret_parameter:     secret\n ```\n \n-If you use `service` as a provider to fetch/invalidate OTP tokens, your service must implement the `Krtv\\SingleSignOn\\Manager\\Http\\Provider\\ProviderInterface` interface.\n+Public API of this bundle\n+-------------------------\n+\n+This bundle registers several services into service container. This services will help you customize SSO flow in the you application:\n \n-That's it for Service Provider.\n\\ No newline at end of file\n+- [sso_service_provider.otp_manager](https://github.com/korotovsky/SingleSignOnLibrary/blob/0.3.x/src/Krtv/SingleSignOn/Manager/OneTimePasswordManagerInterface.php) – Manager for working with OTP-tokens. Checking and receiving.","path":"README.md","position":52,"original_position":52,"commit_id":"8569e6eafc2c988bd59bc9e5db0257aac8b36cf7","original_commit_id":"8569e6eafc2c988bd59bc9e5db0257aac8b36cf7","user":{"login":"korotovsky","id":104727,"avatar_url":"https://avatars.githubusercontent.com/u/104727?v=3","gravatar_id":"","url":"https://api.github.com/users/korotovsky","html_url":"https://github.com/korotovsky","followers_url":"https://api.github.com/users/korotovsky/followers","following_url":"https://api.github.com/users/korotovsky/following{/other_user}","gists_url":"https://api.github.com/users/korotovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/korotovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korotovsky/subscriptions","organizations_url":"https://api.github.com/users/korotovsky/orgs","repos_url":"https://api.github.com/users/korotovsky/repos","events_url":"https://api.github.com/users/korotovsky/events{/privacy}","received_events_url":"https://api.github.com/users/korotovsky/received_events","type":"User","site_admin":false},"body":"Use relative links like `src/Krtv/SingleSignOn/Manager/OneTimePasswordManagerInterface.php`. It will work, and does not hold the current package version in the docs explicitly","created_at":"2016-06-24T08:26:57Z","updated_at":"2016-06-24T08:26:57Z","html_url":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle/pull/4#discussion_r68367933","pull_request_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/comments/68367933"},"html":{"href":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle/pull/4#discussion_r68367933"},"pull_request":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4","id":75075955,"html_url":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle/pull/4","diff_url":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle/pull/4.diff","patch_url":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle/pull/4.patch","issue_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/issues/4","number":4,"state":"open","locked":false,"title":"Updated documentation","user":{"login":"adnedelcu","id":1168310,"avatar_url":"https://avatars.githubusercontent.com/u/1168310?v=3","gravatar_id":"","url":"https://api.github.com/users/adnedelcu","html_url":"https://github.com/adnedelcu","followers_url":"https://api.github.com/users/adnedelcu/followers","following_url":"https://api.github.com/users/adnedelcu/following{/other_user}","gists_url":"https://api.github.com/users/adnedelcu/gists{/gist_id}","starred_url":"https://api.github.com/users/adnedelcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnedelcu/subscriptions","organizations_url":"https://api.github.com/users/adnedelcu/orgs","repos_url":"https://api.github.com/users/adnedelcu/repos","events_url":"https://api.github.com/users/adnedelcu/events{/privacy}","received_events_url":"https://api.github.com/users/adnedelcu/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-24T07:42:59Z","updated_at":"2016-06-24T08:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b51b1147ebc788e96447eebc9331c89909c3440","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4/commits","review_comments_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4/comments","review_comment_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/issues/4/comments","statuses_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/statuses/8569e6eafc2c988bd59bc9e5db0257aac8b36cf7","head":{"label":"adnedelcu:0.3.x","ref":"0.3.x","sha":"8569e6eafc2c988bd59bc9e5db0257aac8b36cf7","user":{"login":"adnedelcu","id":1168310,"avatar_url":"https://avatars.githubusercontent.com/u/1168310?v=3","gravatar_id":"","url":"https://api.github.com/users/adnedelcu","html_url":"https://github.com/adnedelcu","followers_url":"https://api.github.com/users/adnedelcu/followers","following_url":"https://api.github.com/users/adnedelcu/following{/other_user}","gists_url":"https://api.github.com/users/adnedelcu/gists{/gist_id}","starred_url":"https://api.github.com/users/adnedelcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnedelcu/subscriptions","organizations_url":"https://api.github.com/users/adnedelcu/orgs","repos_url":"https://api.github.com/users/adnedelcu/repos","events_url":"https://api.github.com/users/adnedelcu/events{/privacy}","received_events_url":"https://api.github.com/users/adnedelcu/received_events","type":"User","site_admin":false},"repo":{"id":61865085,"name":"SingleSignOnServiceProviderBundle","full_name":"adnedelcu/SingleSignOnServiceProviderBundle","owner":{"login":"adnedelcu","id":1168310,"avatar_url":"https://avatars.githubusercontent.com/u/1168310?v=3","gravatar_id":"","url":"https://api.github.com/users/adnedelcu","html_url":"https://github.com/adnedelcu","followers_url":"https://api.github.com/users/adnedelcu/followers","following_url":"https://api.github.com/users/adnedelcu/following{/other_user}","gists_url":"https://api.github.com/users/adnedelcu/gists{/gist_id}","starred_url":"https://api.github.com/users/adnedelcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnedelcu/subscriptions","organizations_url":"https://api.github.com/users/adnedelcu/orgs","repos_url":"https://api.github.com/users/adnedelcu/repos","events_url":"https://api.github.com/users/adnedelcu/events{/privacy}","received_events_url":"https://api.github.com/users/adnedelcu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adnedelcu/SingleSignOnServiceProviderBundle","description":"Single Sign On bundle for Symfony2 projects. SP part.","fork":true,"url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle","forks_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/forks","keys_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/teams","hooks_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/hooks","issue_events_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/issues/events{/number}","events_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/events","assignees_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/assignees{/user}","branches_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/branches{/branch}","tags_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/tags","blobs_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/languages","stargazers_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/stargazers","contributors_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/contributors","subscribers_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/subscribers","subscription_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/subscription","commits_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/contents/{+path}","compare_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/merges","archive_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/downloads","issues_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/issues{/number}","pulls_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/labels{/name}","releases_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/releases{/id}","deployments_url":"https://api.github.com/repos/adnedelcu/SingleSignOnServiceProviderBundle/deployments","created_at":"2016-06-24T07:21:18Z","updated_at":"2016-06-24T07:21:19Z","pushed_at":"2016-06-24T07:41:37Z","git_url":"git://github.com/adnedelcu/SingleSignOnServiceProviderBundle.git","ssh_url":"git@github.com:adnedelcu/SingleSignOnServiceProviderBundle.git","clone_url":"https://github.com/adnedelcu/SingleSignOnServiceProviderBundle.git","svn_url":"https://github.com/adnedelcu/SingleSignOnServiceProviderBundle","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.3.x"}},"base":{"label":"korotovsky:0.3.x","ref":"0.3.x","sha":"2e400456b6894c4451c5095bd5bbb3e64133c382","user":{"login":"korotovsky","id":104727,"avatar_url":"https://avatars.githubusercontent.com/u/104727?v=3","gravatar_id":"","url":"https://api.github.com/users/korotovsky","html_url":"https://github.com/korotovsky","followers_url":"https://api.github.com/users/korotovsky/followers","following_url":"https://api.github.com/users/korotovsky/following{/other_user}","gists_url":"https://api.github.com/users/korotovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/korotovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korotovsky/subscriptions","organizations_url":"https://api.github.com/users/korotovsky/orgs","repos_url":"https://api.github.com/users/korotovsky/repos","events_url":"https://api.github.com/users/korotovsky/events{/privacy}","received_events_url":"https://api.github.com/users/korotovsky/received_events","type":"User","site_admin":false},"repo":{"id":27070378,"name":"SingleSignOnServiceProviderBundle","full_name":"korotovsky/SingleSignOnServiceProviderBundle","owner":{"login":"korotovsky","id":104727,"avatar_url":"https://avatars.githubusercontent.com/u/104727?v=3","gravatar_id":"","url":"https://api.github.com/users/korotovsky","html_url":"https://github.com/korotovsky","followers_url":"https://api.github.com/users/korotovsky/followers","following_url":"https://api.github.com/users/korotovsky/following{/other_user}","gists_url":"https://api.github.com/users/korotovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/korotovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korotovsky/subscriptions","organizations_url":"https://api.github.com/users/korotovsky/orgs","repos_url":"https://api.github.com/users/korotovsky/repos","events_url":"https://api.github.com/users/korotovsky/events{/privacy}","received_events_url":"https://api.github.com/users/korotovsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle","description":"Single Sign On bundle for Symfony2 projects. SP part.","fork":false,"url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle","forks_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/forks","keys_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/teams","hooks_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/hooks","issue_events_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/issues/events{/number}","events_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/events","assignees_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/assignees{/user}","branches_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/branches{/branch}","tags_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/tags","blobs_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/languages","stargazers_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/stargazers","contributors_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/contributors","subscribers_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/subscribers","subscription_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/subscription","commits_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/contents/{+path}","compare_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/merges","archive_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/downloads","issues_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/issues{/number}","pulls_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/labels{/name}","releases_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/releases{/id}","deployments_url":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/deployments","created_at":"2014-11-24T10:07:18Z","updated_at":"2016-06-23T10:19:06Z","pushed_at":"2016-06-24T07:43:01Z","git_url":"git://github.com/korotovsky/SingleSignOnServiceProviderBundle.git","ssh_url":"git@github.com:korotovsky/SingleSignOnServiceProviderBundle.git","clone_url":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle.git","svn_url":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle","homepage":null,"size":57,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":13,"default_branch":"0.3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4"},"html":{"href":"https://github.com/korotovsky/SingleSignOnServiceProviderBundle/pull/4"},"issue":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/issues/4"},"comments":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/korotovsky/SingleSignOnServiceProviderBundle/statuses/8569e6eafc2c988bd59bc9e5db0257aac8b36cf7"}}}}
{"actor":{"display_login":"korotovsky"}}