{"action":"closed","number":2266,"pull_request":{"url":"https://api.github.com/repos/acquaman/acquaman/pulls/2266","id":67776040,"html_url":"https://github.com/acquaman/acquaman/pull/2266","diff_url":"https://github.com/acquaman/acquaman/pull/2266.diff","patch_url":"https://github.com/acquaman/acquaman/pull/2266.patch","issue_url":"https://api.github.com/repos/acquaman/acquaman/issues/2266","number":2266,"state":"closed","locked":false,"title":"Pull Request for Issue2264: Adding limits to select motors on Side","user":{"login":"helfrij","id":5216607,"avatar_url":"https://avatars.githubusercontent.com/u/5216607?v=3","gravatar_id":"","url":"https://api.github.com/users/helfrij","html_url":"https://github.com/helfrij","followers_url":"https://api.github.com/users/helfrij/followers","following_url":"https://api.github.com/users/helfrij/following{/other_user}","gists_url":"https://api.github.com/users/helfrij/gists{/gist_id}","starred_url":"https://api.github.com/users/helfrij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfrij/subscriptions","organizations_url":"https://api.github.com/users/helfrij/orgs","repos_url":"https://api.github.com/users/helfrij/repos","events_url":"https://api.github.com/users/helfrij/events{/privacy}","received_events_url":"https://api.github.com/users/helfrij/received_events","type":"User","site_admin":false},"body":"Changes:\r\n- Moved `AMPseudoMotorControl::setMinimum(...)` and `setMaximum(...)` methods to public slots, from protected slots.\r\n- Added `AMReadOnlyPVControl::setMinimum(...)` and `setMaximum(...)` methods. These call the existing protected `setLowLimitValue(...)/setHighLimitValue(...)` slots, and additionally set a flag that causes limit updates from PVs to be rejected.\r\n- Added limits.\r\n\r\nTesting involved attempting to input values inside and outside the value ranges using editors. Control editors should reject input for values outside the desired range.\r\n- [x] M1 mirror PV controls\r\n- [x] M1 mirror pseudomotors\r\n- [x] Mono PV controls\r\n- [x] M2 mirror PV controls\r\n- [x] M2 mirror pseudomotors","created_at":"2016-04-25T19:40:42Z","updated_at":"2016-05-11T21:38:32Z","closed_at":"2016-05-11T21:38:32Z","merged_at":"2016-05-11T21:38:31Z","merge_commit_sha":"2a84866f7f1aa76b2eb5eb1edb174a10dd7e1030","assignee":{"login":"iainworkman","id":7461599,"avatar_url":"https://avatars.githubusercontent.com/u/7461599?v=3","gravatar_id":"","url":"https://api.github.com/users/iainworkman","html_url":"https://github.com/iainworkman","followers_url":"https://api.github.com/users/iainworkman/followers","following_url":"https://api.github.com/users/iainworkman/following{/other_user}","gists_url":"https://api.github.com/users/iainworkman/gists{/gist_id}","starred_url":"https://api.github.com/users/iainworkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iainworkman/subscriptions","organizations_url":"https://api.github.com/users/iainworkman/orgs","repos_url":"https://api.github.com/users/iainworkman/repos","events_url":"https://api.github.com/users/iainworkman/events{/privacy}","received_events_url":"https://api.github.com/users/iainworkman/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2266/commits","review_comments_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2266/comments","review_comment_url":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquaman/acquaman/issues/2266/comments","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/a7ac52ecc859d285a3dbbccc0597e954d9110984","head":{"label":"acquaman:Issue2264","ref":"Issue2264","sha":"a7ac52ecc859d285a3dbbccc0597e954d9110984","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","deployments_url":"https://api.github.com/repos/acquaman/acquaman/deployments","created_at":"2011-02-06T02:19:01Z","updated_at":"2016-05-02T21:52:12Z","pushed_at":"2016-05-11T21:38:31Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":144196,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":211,"forks":2,"open_issues":211,"watchers":10,"default_branch":"master"}},"base":{"label":"acquaman:master","ref":"master","sha":"43f0c1e4645a363b8b9aa0bfc54dc9aeab273f9e","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","deployments_url":"https://api.github.com/repos/acquaman/acquaman/deployments","created_at":"2011-02-06T02:19:01Z","updated_at":"2016-05-02T21:52:12Z","pushed_at":"2016-05-11T21:38:31Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":144196,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":211,"forks":2,"open_issues":211,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2266"},"html":{"href":"https://github.com/acquaman/acquaman/pull/2266"},"issue":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/2266"},"comments":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/2266/comments"},"review_comments":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2266/comments"},"review_comment":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2266/commits"},"statuses":{"href":"https://api.github.com/repos/acquaman/acquaman/statuses/a7ac52ecc859d285a3dbbccc0597e954d9110984"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dretrex","id":602741,"avatar_url":"https://avatars.githubusercontent.com/u/602741?v=3","gravatar_id":"","url":"https://api.github.com/users/dretrex","html_url":"https://github.com/dretrex","followers_url":"https://api.github.com/users/dretrex/followers","following_url":"https://api.github.com/users/dretrex/following{/other_user}","gists_url":"https://api.github.com/users/dretrex/gists{/gist_id}","starred_url":"https://api.github.com/users/dretrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dretrex/subscriptions","organizations_url":"https://api.github.com/users/dretrex/orgs","repos_url":"https://api.github.com/users/dretrex/repos","events_url":"https://api.github.com/users/dretrex/events{/privacy}","received_events_url":"https://api.github.com/users/dretrex/received_events","type":"User","site_admin":false},"comments":3,"review_comments":6,"commits":12,"additions":183,"deletions":69,"changed_files":10}}