{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/84195806","pull_request_review_id":4987804,"id":84195806,"diff_hunk":"@@ -493,6 +493,15 @@ class HotRunner extends ResidentRunner {\n       printError('Hot reload failed:\\ncode = $errorCode\\nmessage = $errorMessage\\n$st');\n       return false;\n     }\n+    // Reload the isolate.\n+    await currentView.uiIsolate.reload();\n+    // Check if the isolate is paused.\n+    final ServiceEvent pauseEvent = currentView.uiIsolate.pauseEvent;\n+    if ((pauseEvent != null) && (pauseEvent.isPauseEvent)) {\n+      // Isolate is paused. Stop here.\n+      printStatus('Skipping reassemble because isolate is paused.');","path":"packages/flutter_tools/lib/src/hot.dart","position":10,"original_position":10,"commit_id":"e8d24252e80cbc6259c7358c06d8a61bf62a0acc","original_commit_id":"e8d24252e80cbc6259c7358c06d8a61bf62a0acc","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars.githubusercontent.com/u/1269969?v=3","gravatar_id":"","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"This should probably be a printTrace to match the `Reassembling application` message below. If this should be user-facing, we may want to update the message to make it clearer to the user what's happening.","created_at":"2016-10-20T00:40:52Z","updated_at":"2016-10-20T00:40:52Z","html_url":"https://github.com/flutter/flutter/pull/6370#discussion_r84195806","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/6370","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/84195806"},"html":{"href":"https://github.com/flutter/flutter/pull/6370#discussion_r84195806"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6370"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/6370","id":89849518,"html_url":"https://github.com/flutter/flutter/pull/6370","diff_url":"https://github.com/flutter/flutter/pull/6370.diff","patch_url":"https://github.com/flutter/flutter/pull/6370.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/6370","number":6370,"state":"open","locked":false,"title":"Do not reassemble the application after a hot reload if the isolate is paused","user":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"body":"- [x] add `pauseEvent` to `Isolate`.\r\n- [x] add `PausePostRequest` pause kind.\r\n- [x] Do not reassemble the application if the isolate is paused after a reload. \r\n\r\nNow when the isolate is paused after a hot reload, we do not invoke any Dart code in the isolate and leave control in the debug clients. This allows for debug clients to set breakpoints, etc after a reload. ","created_at":"2016-10-18T16:14:33Z","updated_at":"2016-10-20T00:40:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"533b208a82b036bf85ebdcae594ee257640fe405","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/6370/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/6370/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/6370/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/e8d24252e80cbc6259c7358c06d8a61bf62a0acc","head":{"label":"johnmccutchan:dont_reassemble_when_paused","ref":"dont_reassemble_when_paused","sha":"e8d24252e80cbc6259c7358c06d8a61bf62a0acc","user":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"repo":{"id":46145254,"name":"flutter","full_name":"johnmccutchan/flutter","owner":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnmccutchan/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/johnmccutchan/flutter","forks_url":"https://api.github.com/repos/johnmccutchan/flutter/forks","keys_url":"https://api.github.com/repos/johnmccutchan/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnmccutchan/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnmccutchan/flutter/teams","hooks_url":"https://api.github.com/repos/johnmccutchan/flutter/hooks","issue_events_url":"https://api.github.com/repos/johnmccutchan/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/johnmccutchan/flutter/events","assignees_url":"https://api.github.com/repos/johnmccutchan/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/johnmccutchan/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/johnmccutchan/flutter/tags","blobs_url":"https://api.github.com/repos/johnmccutchan/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnmccutchan/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnmccutchan/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnmccutchan/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnmccutchan/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/johnmccutchan/flutter/languages","stargazers_url":"https://api.github.com/repos/johnmccutchan/flutter/stargazers","contributors_url":"https://api.github.com/repos/johnmccutchan/flutter/contributors","subscribers_url":"https://api.github.com/repos/johnmccutchan/flutter/subscribers","subscription_url":"https://api.github.com/repos/johnmccutchan/flutter/subscription","commits_url":"https://api.github.com/repos/johnmccutchan/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnmccutchan/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnmccutchan/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnmccutchan/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnmccutchan/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/johnmccutchan/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnmccutchan/flutter/merges","archive_url":"https://api.github.com/repos/johnmccutchan/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnmccutchan/flutter/downloads","issues_url":"https://api.github.com/repos/johnmccutchan/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/johnmccutchan/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/johnmccutchan/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/johnmccutchan/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnmccutchan/flutter/labels{/name}","releases_url":"https://api.github.com/repos/johnmccutchan/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/johnmccutchan/flutter/deployments","created_at":"2015-11-13T20:21:52Z","updated_at":"2016-10-11T18:59:39Z","pushed_at":"2016-10-18T16:10:50Z","git_url":"git://github.com/johnmccutchan/flutter.git","ssh_url":"git@github.com:johnmccutchan/flutter.git","clone_url":"https://github.com/johnmccutchan/flutter.git","svn_url":"https://github.com/johnmccutchan/flutter","homepage":"http://flutter.io","size":22332,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"50ebcd1dff38293307f2e0368a7e2c2ab2e835bf","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-10-19T18:10:55Z","pushed_at":"2016-10-20T00:03:53Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":117316,"stargazers_count":3349,"watchers_count":3349,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":358,"mirror_url":null,"open_issues_count":1328,"forks":358,"open_issues":1328,"watchers":3349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6370"},"html":{"href":"https://github.com/flutter/flutter/pull/6370"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/6370"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/6370/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6370/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6370/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/e8d24252e80cbc6259c7358c06d8a61bf62a0acc"}}}}
{"actor":{"display_login":"devoncarew"}}