{"action":"created","comment":{"url":"https://api.github.com/repos/holdenk/spark/pulls/comments/84746340","pull_request_review_id":5503898,"id":84746340,"diff_hunk":"@@ -33,6 +33,11 @@ set PYTHONPATH=%SPARK_HOME%\\python;%PYTHONPATH%\n set PYTHONPATH=%SPARK_HOME%\\python\\lib\\py4j-0.10.4-src.zip;%PYTHONPATH%\n \n set OLD_PYTHONSTARTUP=%PYTHONSTARTUP%\n+rem Check if we are pip installed or not\n+IF EXIST %SPARK_HOME%\\python\\pyspark\\shell.py (","path":"bin/pyspark2.cmd","position":5,"original_position":5,"commit_id":"555d4437f32f658e673b060c84c260f18d6376ec","original_commit_id":"555d4437f32f658e673b060c84c260f18d6376ec","user":{"login":"jhlch","id":1074683,"avatar_url":"https://avatars.githubusercontent.com/u/1074683?v=3","gravatar_id":"","url":"https://api.github.com/users/jhlch","html_url":"https://github.com/jhlch","followers_url":"https://api.github.com/users/jhlch/followers","following_url":"https://api.github.com/users/jhlch/following{/other_user}","gists_url":"https://api.github.com/users/jhlch/gists{/gist_id}","starred_url":"https://api.github.com/users/jhlch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhlch/subscriptions","organizations_url":"https://api.github.com/users/jhlch/orgs","repos_url":"https://api.github.com/users/jhlch/repos","events_url":"https://api.github.com/users/jhlch/events{/privacy}","received_events_url":"https://api.github.com/users/jhlch/received_events","type":"User","site_admin":false},"body":"again with the double code path. This seems messy and hard to maintain. ","created_at":"2016-10-24T18:02:09Z","updated_at":"2016-10-24T18:04:39Z","html_url":"https://github.com/holdenk/spark/pull/4#discussion_r84746340","pull_request_url":"https://api.github.com/repos/holdenk/spark/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/holdenk/spark/pulls/comments/84746340"},"html":{"href":"https://github.com/holdenk/spark/pull/4#discussion_r84746340"},"pull_request":{"href":"https://api.github.com/repos/holdenk/spark/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/holdenk/spark/pulls/4","id":90583153,"html_url":"https://github.com/holdenk/spark/pull/4","diff_url":"https://github.com/holdenk/spark/pull/4.diff","patch_url":"https://github.com/holdenk/spark/pull/4.patch","issue_url":"https://api.github.com/repos/holdenk/spark/issues/4","number":4,"state":"open","locked":false,"title":"[WIP][DRAFT] Pip installable PySpark","user":{"login":"holdenk","id":59893,"avatar_url":"https://avatars.githubusercontent.com/u/59893?v=3","gravatar_id":"","url":"https://api.github.com/users/holdenk","html_url":"https://github.com/holdenk","followers_url":"https://api.github.com/users/holdenk/followers","following_url":"https://api.github.com/users/holdenk/following{/other_user}","gists_url":"https://api.github.com/users/holdenk/gists{/gist_id}","starred_url":"https://api.github.com/users/holdenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holdenk/subscriptions","organizations_url":"https://api.github.com/users/holdenk/orgs","repos_url":"https://api.github.com/users/holdenk/repos","events_url":"https://api.github.com/users/holdenk/events{/privacy}","received_events_url":"https://api.github.com/users/holdenk/received_events","type":"User","site_admin":false},"body":"Draft pip installable PySpark package. This does a bunch of hacks to copy the jars over.\r\nDone:\r\n* pip installable on conda [manual tested]\r\n* setup.py installed on a non-pip managed system (RHEL) with YARN [manual tested]\r\n\r\n\r\nStill TODO:\r\n* Automated testing of this (virtualenv)\r\n* Windows? idk","created_at":"2016-10-24T10:09:29Z","updated_at":"2016-10-24T18:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b39ed887d81f936c4295b5201c121c16850e2656","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/holdenk/spark/pulls/4/commits","review_comments_url":"https://api.github.com/repos/holdenk/spark/pulls/4/comments","review_comment_url":"https://api.github.com/repos/holdenk/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holdenk/spark/issues/4/comments","statuses_url":"https://api.github.com/repos/holdenk/spark/statuses/555d4437f32f658e673b060c84c260f18d6376ec","head":{"label":"holdenk:SPARK-1267-pip-install-pyspark","ref":"SPARK-1267-pip-install-pyspark","sha":"555d4437f32f658e673b060c84c260f18d6376ec","user":{"login":"holdenk","id":59893,"avatar_url":"https://avatars.githubusercontent.com/u/59893?v=3","gravatar_id":"","url":"https://api.github.com/users/holdenk","html_url":"https://github.com/holdenk","followers_url":"https://api.github.com/users/holdenk/followers","following_url":"https://api.github.com/users/holdenk/following{/other_user}","gists_url":"https://api.github.com/users/holdenk/gists{/gist_id}","starred_url":"https://api.github.com/users/holdenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holdenk/subscriptions","organizations_url":"https://api.github.com/users/holdenk/orgs","repos_url":"https://api.github.com/users/holdenk/repos","events_url":"https://api.github.com/users/holdenk/events{/privacy}","received_events_url":"https://api.github.com/users/holdenk/received_events","type":"User","site_admin":false},"repo":{"id":17235154,"name":"spark","full_name":"holdenk/spark","owner":{"login":"holdenk","id":59893,"avatar_url":"https://avatars.githubusercontent.com/u/59893?v=3","gravatar_id":"","url":"https://api.github.com/users/holdenk","html_url":"https://github.com/holdenk","followers_url":"https://api.github.com/users/holdenk/followers","following_url":"https://api.github.com/users/holdenk/following{/other_user}","gists_url":"https://api.github.com/users/holdenk/gists{/gist_id}","starred_url":"https://api.github.com/users/holdenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holdenk/subscriptions","organizations_url":"https://api.github.com/users/holdenk/orgs","repos_url":"https://api.github.com/users/holdenk/repos","events_url":"https://api.github.com/users/holdenk/events{/privacy}","received_events_url":"https://api.github.com/users/holdenk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/holdenk/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/holdenk/spark","forks_url":"https://api.github.com/repos/holdenk/spark/forks","keys_url":"https://api.github.com/repos/holdenk/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holdenk/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holdenk/spark/teams","hooks_url":"https://api.github.com/repos/holdenk/spark/hooks","issue_events_url":"https://api.github.com/repos/holdenk/spark/issues/events{/number}","events_url":"https://api.github.com/repos/holdenk/spark/events","assignees_url":"https://api.github.com/repos/holdenk/spark/assignees{/user}","branches_url":"https://api.github.com/repos/holdenk/spark/branches{/branch}","tags_url":"https://api.github.com/repos/holdenk/spark/tags","blobs_url":"https://api.github.com/repos/holdenk/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holdenk/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holdenk/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/holdenk/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holdenk/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/holdenk/spark/languages","stargazers_url":"https://api.github.com/repos/holdenk/spark/stargazers","contributors_url":"https://api.github.com/repos/holdenk/spark/contributors","subscribers_url":"https://api.github.com/repos/holdenk/spark/subscribers","subscription_url":"https://api.github.com/repos/holdenk/spark/subscription","commits_url":"https://api.github.com/repos/holdenk/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/holdenk/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/holdenk/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/holdenk/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/holdenk/spark/contents/{+path}","compare_url":"https://api.github.com/repos/holdenk/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holdenk/spark/merges","archive_url":"https://api.github.com/repos/holdenk/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holdenk/spark/downloads","issues_url":"https://api.github.com/repos/holdenk/spark/issues{/number}","pulls_url":"https://api.github.com/repos/holdenk/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/holdenk/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/holdenk/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holdenk/spark/labels{/name}","releases_url":"https://api.github.com/repos/holdenk/spark/releases{/id}","deployments_url":"https://api.github.com/repos/holdenk/spark/deployments","created_at":"2014-02-27T03:28:28Z","updated_at":"2016-10-23T15:53:36Z","pushed_at":"2016-10-24T15:02:43Z","git_url":"git://github.com/holdenk/spark.git","ssh_url":"git@github.com:holdenk/spark.git","clone_url":"https://github.com/holdenk/spark.git","svn_url":"https://github.com/holdenk/spark","homepage":null,"size":237856,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"holdenk:master","ref":"master","sha":"4ecbe1b92f4c4c5b2d734895c09d8ded0ed48d4d","user":{"login":"holdenk","id":59893,"avatar_url":"https://avatars.githubusercontent.com/u/59893?v=3","gravatar_id":"","url":"https://api.github.com/users/holdenk","html_url":"https://github.com/holdenk","followers_url":"https://api.github.com/users/holdenk/followers","following_url":"https://api.github.com/users/holdenk/following{/other_user}","gists_url":"https://api.github.com/users/holdenk/gists{/gist_id}","starred_url":"https://api.github.com/users/holdenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holdenk/subscriptions","organizations_url":"https://api.github.com/users/holdenk/orgs","repos_url":"https://api.github.com/users/holdenk/repos","events_url":"https://api.github.com/users/holdenk/events{/privacy}","received_events_url":"https://api.github.com/users/holdenk/received_events","type":"User","site_admin":false},"repo":{"id":17235154,"name":"spark","full_name":"holdenk/spark","owner":{"login":"holdenk","id":59893,"avatar_url":"https://avatars.githubusercontent.com/u/59893?v=3","gravatar_id":"","url":"https://api.github.com/users/holdenk","html_url":"https://github.com/holdenk","followers_url":"https://api.github.com/users/holdenk/followers","following_url":"https://api.github.com/users/holdenk/following{/other_user}","gists_url":"https://api.github.com/users/holdenk/gists{/gist_id}","starred_url":"https://api.github.com/users/holdenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holdenk/subscriptions","organizations_url":"https://api.github.com/users/holdenk/orgs","repos_url":"https://api.github.com/users/holdenk/repos","events_url":"https://api.github.com/users/holdenk/events{/privacy}","received_events_url":"https://api.github.com/users/holdenk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/holdenk/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/holdenk/spark","forks_url":"https://api.github.com/repos/holdenk/spark/forks","keys_url":"https://api.github.com/repos/holdenk/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holdenk/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holdenk/spark/teams","hooks_url":"https://api.github.com/repos/holdenk/spark/hooks","issue_events_url":"https://api.github.com/repos/holdenk/spark/issues/events{/number}","events_url":"https://api.github.com/repos/holdenk/spark/events","assignees_url":"https://api.github.com/repos/holdenk/spark/assignees{/user}","branches_url":"https://api.github.com/repos/holdenk/spark/branches{/branch}","tags_url":"https://api.github.com/repos/holdenk/spark/tags","blobs_url":"https://api.github.com/repos/holdenk/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holdenk/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holdenk/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/holdenk/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holdenk/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/holdenk/spark/languages","stargazers_url":"https://api.github.com/repos/holdenk/spark/stargazers","contributors_url":"https://api.github.com/repos/holdenk/spark/contributors","subscribers_url":"https://api.github.com/repos/holdenk/spark/subscribers","subscription_url":"https://api.github.com/repos/holdenk/spark/subscription","commits_url":"https://api.github.com/repos/holdenk/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/holdenk/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/holdenk/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/holdenk/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/holdenk/spark/contents/{+path}","compare_url":"https://api.github.com/repos/holdenk/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holdenk/spark/merges","archive_url":"https://api.github.com/repos/holdenk/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holdenk/spark/downloads","issues_url":"https://api.github.com/repos/holdenk/spark/issues{/number}","pulls_url":"https://api.github.com/repos/holdenk/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/holdenk/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/holdenk/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holdenk/spark/labels{/name}","releases_url":"https://api.github.com/repos/holdenk/spark/releases{/id}","deployments_url":"https://api.github.com/repos/holdenk/spark/deployments","created_at":"2014-02-27T03:28:28Z","updated_at":"2016-10-23T15:53:36Z","pushed_at":"2016-10-24T15:02:43Z","git_url":"git://github.com/holdenk/spark.git","ssh_url":"git@github.com:holdenk/spark.git","clone_url":"https://github.com/holdenk/spark.git","svn_url":"https://github.com/holdenk/spark","homepage":null,"size":237856,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holdenk/spark/pulls/4"},"html":{"href":"https://github.com/holdenk/spark/pull/4"},"issue":{"href":"https://api.github.com/repos/holdenk/spark/issues/4"},"comments":{"href":"https://api.github.com/repos/holdenk/spark/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/holdenk/spark/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/holdenk/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holdenk/spark/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/holdenk/spark/statuses/555d4437f32f658e673b060c84c260f18d6376ec"}}}}
{"actor":{"display_login":"jhlch"}}