{"action":"created","comment":{"url":"https://api.github.com/repos/cozy-labs/konnectors/pulls/comments/87846397","pull_request_review_id":8441013,"id":87846397,"diff_hunk":"@@ -18,14 +24,100 @@\n                         svg: use(:xlink:href=\"require('./assets/sprites/icon-connected.svg')\")\n                         | {{ 'my_accounts connected title' | t }}\n \n-        router-view\n+        router-view(v-on:open-dialog='onOpenDialog')\n+\n </template>\n \n \n+<script>\n+    const dialogs = [{\n+        id: 'dialog-1',\n+        hidden: false,\n+        headerImage: 'test0.png',\n+        success: {\n+            route: { name: 'create-account-success' }\n+        }\n+    }]\n+\n+\n+    export default {\n+      data() {\n+          return {\n+              'dialogs': []\n+          }\n+      },\n+\n+      created () {\n+          const query = this.$router.currentRoute.query\n+\n+          // Show Dialogs\n+          if (query.dialog) {\n+              const values = query.dialog.split(',')\n+              values.forEach((value) => {\n+                  this.onOpenDialog(value)\n+              })\n+          }\n+      },\n+\n+      methods: {\n+          onError (err) {\n+","path":"client/app/app.vue","position":53,"original_position":54,"commit_id":"b553ed8a72518f6e0a218a8c71e62ef62d1dcd79","original_commit_id":"939037a410f84393fe1ce8a1391fcd571300b5dc","user":{"login":"m4dz","id":471486,"avatar_url":"https://avatars.githubusercontent.com/u/471486?v=3","gravatar_id":"","url":"https://api.github.com/users/m4dz","html_url":"https://github.com/m4dz","followers_url":"https://api.github.com/users/m4dz/followers","following_url":"https://api.github.com/users/m4dz/following{/other_user}","gists_url":"https://api.github.com/users/m4dz/gists{/gist_id}","starred_url":"https://api.github.com/users/m4dz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4dz/subscriptions","organizations_url":"https://api.github.com/users/m4dz/orgs","repos_url":"https://api.github.com/users/m4dz/repos","events_url":"https://api.github.com/users/m4dz/events{/privacy}","received_events_url":"https://api.github.com/users/m4dz/received_events","type":"User","site_admin":false},"body":"My thoughs about the use of `Vue.config.errorHandler`: it's a smart and clever way to handle and log errors in the stack v2 logging system (poke @nono) when something goes wrong in the app. But to catch some feedback errors (like a misfilled field in a form) I think it's not the best way to do this. Probably having an `$emit` from the component, catched by `app.vue` that pop a notification is a better idea (which can be cumulated with the logging system)","created_at":"2016-11-14T17:11:46Z","updated_at":"2016-11-14T17:11:51Z","html_url":"https://github.com/cozy-labs/konnectors/pull/580#discussion_r87846397","pull_request_url":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580","_links":{"self":{"href":"https://api.github.com/repos/cozy-labs/konnectors/pulls/comments/87846397"},"html":{"href":"https://github.com/cozy-labs/konnectors/pull/580#discussion_r87846397"},"pull_request":{"href":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580"}}},"pull_request":{"url":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580","id":92749728,"html_url":"https://github.com/cozy-labs/konnectors/pull/580","diff_url":"https://github.com/cozy-labs/konnectors/pull/580.diff","patch_url":"https://github.com/cozy-labs/konnectors/pull/580.patch","issue_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/580","number":580,"state":"open","locked":false,"title":"Add dynamic dialog component","user":{"login":"misstick","id":1177627,"avatar_url":"https://avatars.githubusercontent.com/u/1177627?v=3","gravatar_id":"","url":"https://api.github.com/users/misstick","html_url":"https://github.com/misstick","followers_url":"https://api.github.com/users/misstick/followers","following_url":"https://api.github.com/users/misstick/following{/other_user}","gists_url":"https://api.github.com/users/misstick/gists{/gist_id}","starred_url":"https://api.github.com/users/misstick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misstick/subscriptions","organizations_url":"https://api.github.com/users/misstick/orgs","repos_url":"https://api.github.com/users/misstick/repos","events_url":"https://api.github.com/users/misstick/events{/privacy}","received_events_url":"https://api.github.com/users/misstick/received_events","type":"User","site_admin":false},"body":"- [x] Add basic markup for dialog window,\r\n- [x] Add styles,\r\n- [x] Add close behavior on `closeButton`,\r\n- [x] Add `default` close behavior,\r\n- [ ] create a generic component,\r\n- [ ] create API (success, error, content etc.),\r\n- [ ] Add test on this component.","created_at":"2016-11-08T10:18:10Z","updated_at":"2016-11-14T17:11:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a98a2e981561baf7d60227e56e1ca14a19e2116","assignee":{"login":"m4dz","id":471486,"avatar_url":"https://avatars.githubusercontent.com/u/471486?v=3","gravatar_id":"","url":"https://api.github.com/users/m4dz","html_url":"https://github.com/m4dz","followers_url":"https://api.github.com/users/m4dz/followers","following_url":"https://api.github.com/users/m4dz/following{/other_user}","gists_url":"https://api.github.com/users/m4dz/gists{/gist_id}","starred_url":"https://api.github.com/users/m4dz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4dz/subscriptions","organizations_url":"https://api.github.com/users/m4dz/orgs","repos_url":"https://api.github.com/users/m4dz/repos","events_url":"https://api.github.com/users/m4dz/events{/privacy}","received_events_url":"https://api.github.com/users/m4dz/received_events","type":"User","site_admin":false},"assignees":[{"login":"m4dz","id":471486,"avatar_url":"https://avatars.githubusercontent.com/u/471486?v=3","gravatar_id":"","url":"https://api.github.com/users/m4dz","html_url":"https://github.com/m4dz","followers_url":"https://api.github.com/users/m4dz/followers","following_url":"https://api.github.com/users/m4dz/following{/other_user}","gists_url":"https://api.github.com/users/m4dz/gists{/gist_id}","starred_url":"https://api.github.com/users/m4dz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4dz/subscriptions","organizations_url":"https://api.github.com/users/m4dz/orgs","repos_url":"https://api.github.com/users/m4dz/repos","events_url":"https://api.github.com/users/m4dz/events{/privacy}","received_events_url":"https://api.github.com/users/m4dz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580/commits","review_comments_url":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580/comments","review_comment_url":"https://api.github.com/repos/cozy-labs/konnectors/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/580/comments","statuses_url":"https://api.github.com/repos/cozy-labs/konnectors/statuses/b553ed8a72518f6e0a218a8c71e62ef62d1dcd79","head":{"label":"misstick:feature/dynamic-dialog","ref":"feature/dynamic-dialog","sha":"b553ed8a72518f6e0a218a8c71e62ef62d1dcd79","user":{"login":"misstick","id":1177627,"avatar_url":"https://avatars.githubusercontent.com/u/1177627?v=3","gravatar_id":"","url":"https://api.github.com/users/misstick","html_url":"https://github.com/misstick","followers_url":"https://api.github.com/users/misstick/followers","following_url":"https://api.github.com/users/misstick/following{/other_user}","gists_url":"https://api.github.com/users/misstick/gists{/gist_id}","starred_url":"https://api.github.com/users/misstick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misstick/subscriptions","organizations_url":"https://api.github.com/users/misstick/orgs","repos_url":"https://api.github.com/users/misstick/repos","events_url":"https://api.github.com/users/misstick/events{/privacy}","received_events_url":"https://api.github.com/users/misstick/received_events","type":"User","site_admin":false},"repo":{"id":73173615,"name":"konnectors","full_name":"misstick/konnectors","owner":{"login":"misstick","id":1177627,"avatar_url":"https://avatars.githubusercontent.com/u/1177627?v=3","gravatar_id":"","url":"https://api.github.com/users/misstick","html_url":"https://github.com/misstick","followers_url":"https://api.github.com/users/misstick/followers","following_url":"https://api.github.com/users/misstick/following{/other_user}","gists_url":"https://api.github.com/users/misstick/gists{/gist_id}","starred_url":"https://api.github.com/users/misstick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misstick/subscriptions","organizations_url":"https://api.github.com/users/misstick/orgs","repos_url":"https://api.github.com/users/misstick/repos","events_url":"https://api.github.com/users/misstick/events{/privacy}","received_events_url":"https://api.github.com/users/misstick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misstick/konnectors","description":"Import data in your Cozy","fork":true,"url":"https://api.github.com/repos/misstick/konnectors","forks_url":"https://api.github.com/repos/misstick/konnectors/forks","keys_url":"https://api.github.com/repos/misstick/konnectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misstick/konnectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misstick/konnectors/teams","hooks_url":"https://api.github.com/repos/misstick/konnectors/hooks","issue_events_url":"https://api.github.com/repos/misstick/konnectors/issues/events{/number}","events_url":"https://api.github.com/repos/misstick/konnectors/events","assignees_url":"https://api.github.com/repos/misstick/konnectors/assignees{/user}","branches_url":"https://api.github.com/repos/misstick/konnectors/branches{/branch}","tags_url":"https://api.github.com/repos/misstick/konnectors/tags","blobs_url":"https://api.github.com/repos/misstick/konnectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misstick/konnectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misstick/konnectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/misstick/konnectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misstick/konnectors/statuses/{sha}","languages_url":"https://api.github.com/repos/misstick/konnectors/languages","stargazers_url":"https://api.github.com/repos/misstick/konnectors/stargazers","contributors_url":"https://api.github.com/repos/misstick/konnectors/contributors","subscribers_url":"https://api.github.com/repos/misstick/konnectors/subscribers","subscription_url":"https://api.github.com/repos/misstick/konnectors/subscription","commits_url":"https://api.github.com/repos/misstick/konnectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/misstick/konnectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/misstick/konnectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/misstick/konnectors/issues/comments{/number}","contents_url":"https://api.github.com/repos/misstick/konnectors/contents/{+path}","compare_url":"https://api.github.com/repos/misstick/konnectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misstick/konnectors/merges","archive_url":"https://api.github.com/repos/misstick/konnectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misstick/konnectors/downloads","issues_url":"https://api.github.com/repos/misstick/konnectors/issues{/number}","pulls_url":"https://api.github.com/repos/misstick/konnectors/pulls{/number}","milestones_url":"https://api.github.com/repos/misstick/konnectors/milestones{/number}","notifications_url":"https://api.github.com/repos/misstick/konnectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misstick/konnectors/labels{/name}","releases_url":"https://api.github.com/repos/misstick/konnectors/releases{/id}","deployments_url":"https://api.github.com/repos/misstick/konnectors/deployments","created_at":"2016-11-08T10:09:40Z","updated_at":"2016-11-08T10:09:42Z","pushed_at":"2016-11-14T15:57:06Z","git_url":"git://github.com/misstick/konnectors.git","ssh_url":"git@github.com:misstick/konnectors.git","clone_url":"https://github.com/misstick/konnectors.git","svn_url":"https://github.com/misstick/konnectors","homepage":null,"size":6643,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cozy-labs:development","ref":"development","sha":"2b38c766fba475beb06fb4db6b21488186789e64","user":{"login":"cozy-labs","id":8415593,"avatar_url":"https://avatars.githubusercontent.com/u/8415593?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy-labs","html_url":"https://github.com/cozy-labs","followers_url":"https://api.github.com/users/cozy-labs/followers","following_url":"https://api.github.com/users/cozy-labs/following{/other_user}","gists_url":"https://api.github.com/users/cozy-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy-labs/subscriptions","organizations_url":"https://api.github.com/users/cozy-labs/orgs","repos_url":"https://api.github.com/users/cozy-labs/repos","events_url":"https://api.github.com/users/cozy-labs/events{/privacy}","received_events_url":"https://api.github.com/users/cozy-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":15378288,"name":"konnectors","full_name":"cozy-labs/konnectors","owner":{"login":"cozy-labs","id":8415593,"avatar_url":"https://avatars.githubusercontent.com/u/8415593?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy-labs","html_url":"https://github.com/cozy-labs","followers_url":"https://api.github.com/users/cozy-labs/followers","following_url":"https://api.github.com/users/cozy-labs/following{/other_user}","gists_url":"https://api.github.com/users/cozy-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy-labs/subscriptions","organizations_url":"https://api.github.com/users/cozy-labs/orgs","repos_url":"https://api.github.com/users/cozy-labs/repos","events_url":"https://api.github.com/users/cozy-labs/events{/privacy}","received_events_url":"https://api.github.com/users/cozy-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cozy-labs/konnectors","description":"Import data in your Cozy","fork":false,"url":"https://api.github.com/repos/cozy-labs/konnectors","forks_url":"https://api.github.com/repos/cozy-labs/konnectors/forks","keys_url":"https://api.github.com/repos/cozy-labs/konnectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cozy-labs/konnectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cozy-labs/konnectors/teams","hooks_url":"https://api.github.com/repos/cozy-labs/konnectors/hooks","issue_events_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/events{/number}","events_url":"https://api.github.com/repos/cozy-labs/konnectors/events","assignees_url":"https://api.github.com/repos/cozy-labs/konnectors/assignees{/user}","branches_url":"https://api.github.com/repos/cozy-labs/konnectors/branches{/branch}","tags_url":"https://api.github.com/repos/cozy-labs/konnectors/tags","blobs_url":"https://api.github.com/repos/cozy-labs/konnectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cozy-labs/konnectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cozy-labs/konnectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/cozy-labs/konnectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cozy-labs/konnectors/statuses/{sha}","languages_url":"https://api.github.com/repos/cozy-labs/konnectors/languages","stargazers_url":"https://api.github.com/repos/cozy-labs/konnectors/stargazers","contributors_url":"https://api.github.com/repos/cozy-labs/konnectors/contributors","subscribers_url":"https://api.github.com/repos/cozy-labs/konnectors/subscribers","subscription_url":"https://api.github.com/repos/cozy-labs/konnectors/subscription","commits_url":"https://api.github.com/repos/cozy-labs/konnectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/cozy-labs/konnectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/cozy-labs/konnectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/comments{/number}","contents_url":"https://api.github.com/repos/cozy-labs/konnectors/contents/{+path}","compare_url":"https://api.github.com/repos/cozy-labs/konnectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cozy-labs/konnectors/merges","archive_url":"https://api.github.com/repos/cozy-labs/konnectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cozy-labs/konnectors/downloads","issues_url":"https://api.github.com/repos/cozy-labs/konnectors/issues{/number}","pulls_url":"https://api.github.com/repos/cozy-labs/konnectors/pulls{/number}","milestones_url":"https://api.github.com/repos/cozy-labs/konnectors/milestones{/number}","notifications_url":"https://api.github.com/repos/cozy-labs/konnectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cozy-labs/konnectors/labels{/name}","releases_url":"https://api.github.com/repos/cozy-labs/konnectors/releases{/id}","deployments_url":"https://api.github.com/repos/cozy-labs/konnectors/deployments","created_at":"2013-12-22T16:24:12Z","updated_at":"2016-11-09T22:26:02Z","pushed_at":"2016-11-14T16:30:57Z","git_url":"git://github.com/cozy-labs/konnectors.git","ssh_url":"git@github.com:cozy-labs/konnectors.git","clone_url":"https://github.com/cozy-labs/konnectors.git","svn_url":"https://github.com/cozy-labs/konnectors","homepage":null,"size":7397,"stargazers_count":23,"watchers_count":23,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":106,"forks":41,"open_issues":106,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580"},"html":{"href":"https://github.com/cozy-labs/konnectors/pull/580"},"issue":{"href":"https://api.github.com/repos/cozy-labs/konnectors/issues/580"},"comments":{"href":"https://api.github.com/repos/cozy-labs/konnectors/issues/580/comments"},"review_comments":{"href":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580/comments"},"review_comment":{"href":"https://api.github.com/repos/cozy-labs/konnectors/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cozy-labs/konnectors/pulls/580/commits"},"statuses":{"href":"https://api.github.com/repos/cozy-labs/konnectors/statuses/b553ed8a72518f6e0a218a8c71e62ef62d1dcd79"}}}}
{"actor":{"display_login":"m4dz"}}