{"action":"created","comment":{"url":"https://api.github.com/repos/ltb-project/self-service-password/pulls/comments/80633389","pull_request_review_id":1677510,"id":80633389,"diff_hunk":"@@ -84,11 +84,7 @@ function make_md4_password($password) {\n # Create AD password (Microsoft Active Directory password format)\n function make_ad_password($password) {\n     $password = \"\\\"\" . $password . \"\\\"\";\n-    $len = strlen(utf8_decode($password));\n-    $adpassword = \"\";\n-    for ($i = 0; $i < $len; $i++){\n-        $adpassword .= \"{$password{$i}}\\000\";\n-    }\n+    $adpassword=mb_convert_encoding($password, \"UTF-16LE\",\"UTF-8\");","path":"lib/functions.inc.php","position":9,"original_position":9,"commit_id":"fc850931986a9734778ab1cd0d9a6af1b4a5508e","original_commit_id":"fc850931986a9734778ab1cd0d9a6af1b4a5508e","user":{"login":"coudot","id":883396,"avatar_url":"https://avatars.githubusercontent.com/u/883396?v=3","gravatar_id":"","url":"https://api.github.com/users/coudot","html_url":"https://github.com/coudot","followers_url":"https://api.github.com/users/coudot/followers","following_url":"https://api.github.com/users/coudot/following{/other_user}","gists_url":"https://api.github.com/users/coudot/gists{/gist_id}","starred_url":"https://api.github.com/users/coudot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coudot/subscriptions","organizations_url":"https://api.github.com/users/coudot/orgs","repos_url":"https://api.github.com/users/coudot/repos","events_url":"https://api.github.com/users/coudot/events{/privacy}","received_events_url":"https://api.github.com/users/coudot/received_events","type":"User","site_admin":false},"body":"Ok with the patch, but please respect some coding rules by adding some spaces:\r\n`$adpassword = mb_convert_encoding($password, \"UTF-16LE\", \"UTF-8\");`\r\n\r\nPlease resubmit after this little change so I can merge your code.","created_at":"2016-09-27T07:23:44Z","updated_at":"2016-09-27T07:23:44Z","html_url":"https://github.com/ltb-project/self-service-password/pull/28#discussion_r80633389","pull_request_url":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/ltb-project/self-service-password/pulls/comments/80633389"},"html":{"href":"https://github.com/ltb-project/self-service-password/pull/28#discussion_r80633389"},"pull_request":{"href":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28","id":86816162,"html_url":"https://github.com/ltb-project/self-service-password/pull/28","diff_url":"https://github.com/ltb-project/self-service-password/pull/28.diff","patch_url":"https://github.com/ltb-project/self-service-password/pull/28.patch","issue_url":"https://api.github.com/repos/ltb-project/self-service-password/issues/28","number":28,"state":"open","locked":false,"title":"Updated make_ad_password","user":{"login":"med-amine-21","id":19674721,"avatar_url":"https://avatars.githubusercontent.com/u/19674721?v=3","gravatar_id":"","url":"https://api.github.com/users/med-amine-21","html_url":"https://github.com/med-amine-21","followers_url":"https://api.github.com/users/med-amine-21/followers","following_url":"https://api.github.com/users/med-amine-21/following{/other_user}","gists_url":"https://api.github.com/users/med-amine-21/gists{/gist_id}","starred_url":"https://api.github.com/users/med-amine-21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/med-amine-21/subscriptions","organizations_url":"https://api.github.com/users/med-amine-21/orgs","repos_url":"https://api.github.com/users/med-amine-21/repos","events_url":"https://api.github.com/users/med-amine-21/events{/privacy}","received_events_url":"https://api.github.com/users/med-amine-21/received_events","type":"User","site_admin":false},"body":"Modified make_ad_password so that it now accepts accentued characters. \r\nThe modification uses mbstring which is already used in other functions so there is no problem with additional dependecies.","created_at":"2016-09-26T20:49:42Z","updated_at":"2016-09-27T07:23:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d253ad6ed9b70ee76d95a459d7b95538dd736a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28/commits","review_comments_url":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28/comments","review_comment_url":"https://api.github.com/repos/ltb-project/self-service-password/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ltb-project/self-service-password/issues/28/comments","statuses_url":"https://api.github.com/repos/ltb-project/self-service-password/statuses/fc850931986a9734778ab1cd0d9a6af1b4a5508e","head":{"label":"med-amine-21:patch-1","ref":"patch-1","sha":"fc850931986a9734778ab1cd0d9a6af1b4a5508e","user":{"login":"med-amine-21","id":19674721,"avatar_url":"https://avatars.githubusercontent.com/u/19674721?v=3","gravatar_id":"","url":"https://api.github.com/users/med-amine-21","html_url":"https://github.com/med-amine-21","followers_url":"https://api.github.com/users/med-amine-21/followers","following_url":"https://api.github.com/users/med-amine-21/following{/other_user}","gists_url":"https://api.github.com/users/med-amine-21/gists{/gist_id}","starred_url":"https://api.github.com/users/med-amine-21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/med-amine-21/subscriptions","organizations_url":"https://api.github.com/users/med-amine-21/orgs","repos_url":"https://api.github.com/users/med-amine-21/repos","events_url":"https://api.github.com/users/med-amine-21/events{/privacy}","received_events_url":"https://api.github.com/users/med-amine-21/received_events","type":"User","site_admin":false},"repo":{"id":69291178,"name":"self-service-password","full_name":"med-amine-21/self-service-password","owner":{"login":"med-amine-21","id":19674721,"avatar_url":"https://avatars.githubusercontent.com/u/19674721?v=3","gravatar_id":"","url":"https://api.github.com/users/med-amine-21","html_url":"https://github.com/med-amine-21","followers_url":"https://api.github.com/users/med-amine-21/followers","following_url":"https://api.github.com/users/med-amine-21/following{/other_user}","gists_url":"https://api.github.com/users/med-amine-21/gists{/gist_id}","starred_url":"https://api.github.com/users/med-amine-21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/med-amine-21/subscriptions","organizations_url":"https://api.github.com/users/med-amine-21/orgs","repos_url":"https://api.github.com/users/med-amine-21/repos","events_url":"https://api.github.com/users/med-amine-21/events{/privacy}","received_events_url":"https://api.github.com/users/med-amine-21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/med-amine-21/self-service-password","description":"Web interface to change and reset password in an LDAP directory","fork":true,"url":"https://api.github.com/repos/med-amine-21/self-service-password","forks_url":"https://api.github.com/repos/med-amine-21/self-service-password/forks","keys_url":"https://api.github.com/repos/med-amine-21/self-service-password/keys{/key_id}","collaborators_url":"https://api.github.com/repos/med-amine-21/self-service-password/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/med-amine-21/self-service-password/teams","hooks_url":"https://api.github.com/repos/med-amine-21/self-service-password/hooks","issue_events_url":"https://api.github.com/repos/med-amine-21/self-service-password/issues/events{/number}","events_url":"https://api.github.com/repos/med-amine-21/self-service-password/events","assignees_url":"https://api.github.com/repos/med-amine-21/self-service-password/assignees{/user}","branches_url":"https://api.github.com/repos/med-amine-21/self-service-password/branches{/branch}","tags_url":"https://api.github.com/repos/med-amine-21/self-service-password/tags","blobs_url":"https://api.github.com/repos/med-amine-21/self-service-password/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/med-amine-21/self-service-password/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/med-amine-21/self-service-password/git/refs{/sha}","trees_url":"https://api.github.com/repos/med-amine-21/self-service-password/git/trees{/sha}","statuses_url":"https://api.github.com/repos/med-amine-21/self-service-password/statuses/{sha}","languages_url":"https://api.github.com/repos/med-amine-21/self-service-password/languages","stargazers_url":"https://api.github.com/repos/med-amine-21/self-service-password/stargazers","contributors_url":"https://api.github.com/repos/med-amine-21/self-service-password/contributors","subscribers_url":"https://api.github.com/repos/med-amine-21/self-service-password/subscribers","subscription_url":"https://api.github.com/repos/med-amine-21/self-service-password/subscription","commits_url":"https://api.github.com/repos/med-amine-21/self-service-password/commits{/sha}","git_commits_url":"https://api.github.com/repos/med-amine-21/self-service-password/git/commits{/sha}","comments_url":"https://api.github.com/repos/med-amine-21/self-service-password/comments{/number}","issue_comment_url":"https://api.github.com/repos/med-amine-21/self-service-password/issues/comments{/number}","contents_url":"https://api.github.com/repos/med-amine-21/self-service-password/contents/{+path}","compare_url":"https://api.github.com/repos/med-amine-21/self-service-password/compare/{base}...{head}","merges_url":"https://api.github.com/repos/med-amine-21/self-service-password/merges","archive_url":"https://api.github.com/repos/med-amine-21/self-service-password/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/med-amine-21/self-service-password/downloads","issues_url":"https://api.github.com/repos/med-amine-21/self-service-password/issues{/number}","pulls_url":"https://api.github.com/repos/med-amine-21/self-service-password/pulls{/number}","milestones_url":"https://api.github.com/repos/med-amine-21/self-service-password/milestones{/number}","notifications_url":"https://api.github.com/repos/med-amine-21/self-service-password/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/med-amine-21/self-service-password/labels{/name}","releases_url":"https://api.github.com/repos/med-amine-21/self-service-password/releases{/id}","deployments_url":"https://api.github.com/repos/med-amine-21/self-service-password/deployments","created_at":"2016-09-26T20:44:19Z","updated_at":"2016-09-26T20:44:20Z","pushed_at":"2016-09-26T20:49:24Z","git_url":"git://github.com/med-amine-21/self-service-password.git","ssh_url":"git@github.com:med-amine-21/self-service-password.git","clone_url":"https://github.com/med-amine-21/self-service-password.git","svn_url":"https://github.com/med-amine-21/self-service-password","homepage":null,"size":1815,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ltb-project:master","ref":"master","sha":"e3176579b60a39a80f7181d7e8b1d9edf470ea54","user":{"login":"ltb-project","id":1528672,"avatar_url":"https://avatars.githubusercontent.com/u/1528672?v=3","gravatar_id":"","url":"https://api.github.com/users/ltb-project","html_url":"https://github.com/ltb-project","followers_url":"https://api.github.com/users/ltb-project/followers","following_url":"https://api.github.com/users/ltb-project/following{/other_user}","gists_url":"https://api.github.com/users/ltb-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ltb-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltb-project/subscriptions","organizations_url":"https://api.github.com/users/ltb-project/orgs","repos_url":"https://api.github.com/users/ltb-project/repos","events_url":"https://api.github.com/users/ltb-project/events{/privacy}","received_events_url":"https://api.github.com/users/ltb-project/received_events","type":"Organization","site_admin":false},"repo":{"id":65830160,"name":"self-service-password","full_name":"ltb-project/self-service-password","owner":{"login":"ltb-project","id":1528672,"avatar_url":"https://avatars.githubusercontent.com/u/1528672?v=3","gravatar_id":"","url":"https://api.github.com/users/ltb-project","html_url":"https://github.com/ltb-project","followers_url":"https://api.github.com/users/ltb-project/followers","following_url":"https://api.github.com/users/ltb-project/following{/other_user}","gists_url":"https://api.github.com/users/ltb-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ltb-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltb-project/subscriptions","organizations_url":"https://api.github.com/users/ltb-project/orgs","repos_url":"https://api.github.com/users/ltb-project/repos","events_url":"https://api.github.com/users/ltb-project/events{/privacy}","received_events_url":"https://api.github.com/users/ltb-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ltb-project/self-service-password","description":"Web interface to change and reset password in an LDAP directory","fork":false,"url":"https://api.github.com/repos/ltb-project/self-service-password","forks_url":"https://api.github.com/repos/ltb-project/self-service-password/forks","keys_url":"https://api.github.com/repos/ltb-project/self-service-password/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ltb-project/self-service-password/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ltb-project/self-service-password/teams","hooks_url":"https://api.github.com/repos/ltb-project/self-service-password/hooks","issue_events_url":"https://api.github.com/repos/ltb-project/self-service-password/issues/events{/number}","events_url":"https://api.github.com/repos/ltb-project/self-service-password/events","assignees_url":"https://api.github.com/repos/ltb-project/self-service-password/assignees{/user}","branches_url":"https://api.github.com/repos/ltb-project/self-service-password/branches{/branch}","tags_url":"https://api.github.com/repos/ltb-project/self-service-password/tags","blobs_url":"https://api.github.com/repos/ltb-project/self-service-password/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ltb-project/self-service-password/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ltb-project/self-service-password/git/refs{/sha}","trees_url":"https://api.github.com/repos/ltb-project/self-service-password/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ltb-project/self-service-password/statuses/{sha}","languages_url":"https://api.github.com/repos/ltb-project/self-service-password/languages","stargazers_url":"https://api.github.com/repos/ltb-project/self-service-password/stargazers","contributors_url":"https://api.github.com/repos/ltb-project/self-service-password/contributors","subscribers_url":"https://api.github.com/repos/ltb-project/self-service-password/subscribers","subscription_url":"https://api.github.com/repos/ltb-project/self-service-password/subscription","commits_url":"https://api.github.com/repos/ltb-project/self-service-password/commits{/sha}","git_commits_url":"https://api.github.com/repos/ltb-project/self-service-password/git/commits{/sha}","comments_url":"https://api.github.com/repos/ltb-project/self-service-password/comments{/number}","issue_comment_url":"https://api.github.com/repos/ltb-project/self-service-password/issues/comments{/number}","contents_url":"https://api.github.com/repos/ltb-project/self-service-password/contents/{+path}","compare_url":"https://api.github.com/repos/ltb-project/self-service-password/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ltb-project/self-service-password/merges","archive_url":"https://api.github.com/repos/ltb-project/self-service-password/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ltb-project/self-service-password/downloads","issues_url":"https://api.github.com/repos/ltb-project/self-service-password/issues{/number}","pulls_url":"https://api.github.com/repos/ltb-project/self-service-password/pulls{/number}","milestones_url":"https://api.github.com/repos/ltb-project/self-service-password/milestones{/number}","notifications_url":"https://api.github.com/repos/ltb-project/self-service-password/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ltb-project/self-service-password/labels{/name}","releases_url":"https://api.github.com/repos/ltb-project/self-service-password/releases{/id}","deployments_url":"https://api.github.com/repos/ltb-project/self-service-password/deployments","created_at":"2016-08-16T15:09:33Z","updated_at":"2016-09-25T05:36:17Z","pushed_at":"2016-09-26T20:49:43Z","git_url":"git://github.com/ltb-project/self-service-password.git","ssh_url":"git@github.com:ltb-project/self-service-password.git","clone_url":"https://github.com/ltb-project/self-service-password.git","svn_url":"https://github.com/ltb-project/self-service-password","homepage":null,"size":1814,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28"},"html":{"href":"https://github.com/ltb-project/self-service-password/pull/28"},"issue":{"href":"https://api.github.com/repos/ltb-project/self-service-password/issues/28"},"comments":{"href":"https://api.github.com/repos/ltb-project/self-service-password/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/ltb-project/self-service-password/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ltb-project/self-service-password/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/ltb-project/self-service-password/statuses/fc850931986a9734778ab1cd0d9a6af1b4a5508e"}}}}
{"actor":{"display_login":"coudot"}}