{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/shim/issues/36","repository_url":"https://api.github.com/repos/dojo/shim","labels_url":"https://api.github.com/repos/dojo/shim/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/dojo/shim/issues/36/comments","events_url":"https://api.github.com/repos/dojo/shim/issues/36/events","html_url":"https://github.com/dojo/shim/pull/36","id":182616237,"number":36,"title":"WeakMaps should handle undefined,null now, fixes #18","user":{"login":"rorticus","id":2008858,"avatar_url":"https://avatars.githubusercontent.com/u/2008858?v=3","gravatar_id":"","url":"https://api.github.com/users/rorticus","html_url":"https://github.com/rorticus","followers_url":"https://api.github.com/users/rorticus/followers","following_url":"https://api.github.com/users/rorticus/following{/other_user}","gists_url":"https://api.github.com/users/rorticus/gists{/gist_id}","starred_url":"https://api.github.com/users/rorticus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rorticus/subscriptions","organizations_url":"https://api.github.com/users/rorticus/orgs","repos_url":"https://api.github.com/users/rorticus/repos","events_url":"https://api.github.com/users/rorticus/events{/privacy}","received_events_url":"https://api.github.com/users/rorticus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dojo/shim/milestones/4","html_url":"https://github.com/dojo/shim/milestones/2016.10","labels_url":"https://api.github.com/repos/dojo/shim/milestones/4/labels","id":1880521,"number":4,"title":"2016.10","description":"","creator":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":5,"state":"open","created_at":"2016-07-13T09:48:05Z","updated_at":"2016-10-25T08:23:22Z","due_on":"2016-10-31T00:00:00Z","closed_at":null},"comments":5,"created_at":"2016-10-12T19:45:26Z","updated_at":"2016-10-25T08:24:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dojo/shim/pulls/36","html_url":"https://github.com/dojo/shim/pull/36","diff_url":"https://github.com/dojo/shim/pull/36.diff","patch_url":"https://github.com/dojo/shim/pull/36.patch"},"body":"<!--\r\nThank you for Contributing to Dojo 2.\r\n\r\nPlease make sure you have read our Contributing Guidelines\r\navailable at: https://github.com/dojo/meta/blob/master/CONTRIBUTING.md\r\nbefore submitting a PR.\r\n\r\n-->\r\n\r\n**Type:** bug\r\n\r\n**Description:** \r\n\r\nCurrently, doing _anything_ with `undefined` or `null` as a key will result in an exception. The native version of `WeakMap` returns `undefined`/`false` in these cases.  This PR should make the shim more consistent with the native `WeakMap`.\r\n\r\n**Related Issue:** #18 \r\n\r\nPlease review this checklist before submitting your PR:\r\n\r\n* [x] There is a related issue\r\n* [x] All contributors have signed a CLA\r\n* [x] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [x] The code passes the CI tests\r\n* [x] Unit or Functional tests are included in the PR\r\n* [x] The PR increases or maintains the overall unit test coverage percentage\r\n* [x] The code is ready to be merged\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dojo/shim/issues/comments/255969921","html_url":"https://github.com/dojo/shim/pull/36#issuecomment-255969921","issue_url":"https://api.github.com/repos/dojo/shim/issues/36","id":255969921,"user":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T08:24:10Z","updated_at":"2016-10-25T08:24:10Z","body":"Sorry, master now is passing CI.  One more rebase please and then we should be good."}}
{"actor":{"display_login":"kitsonk"}}