{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/comments/78151294","id":78151294,"diff_hunk":"@@ -57,12 +58,12 @@ protected override void OnClose(TimeSpan timeout)\n \n         protected override IAsyncResult OnBeginClose(TimeSpan timeout, AsyncCallback callback, object state)\n         {\n-            return _innerChannel.BeginClose(timeout, callback, state);\n+            throw ExceptionHelper.PlatformNotSupported();","path":"src/System.Private.ServiceModel/src/System/ServiceModel/Channels/LayeredChannel.cs","position":13,"original_position":13,"commit_id":"b765b754c19c8142a6a07fd10fc35369622afccf","original_commit_id":"945c703d2c9edee34e3917bf3f3114643dac3168","user":{"login":"iamjasonp","id":1616847,"avatar_url":"https://avatars.githubusercontent.com/u/1616847?v=3","gravatar_id":"","url":"https://api.github.com/users/iamjasonp","html_url":"https://github.com/iamjasonp","followers_url":"https://api.github.com/users/iamjasonp/followers","following_url":"https://api.github.com/users/iamjasonp/following{/other_user}","gists_url":"https://api.github.com/users/iamjasonp/gists{/gist_id}","starred_url":"https://api.github.com/users/iamjasonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamjasonp/subscriptions","organizations_url":"https://api.github.com/users/iamjasonp/orgs","repos_url":"https://api.github.com/users/iamjasonp/repos","events_url":"https://api.github.com/users/iamjasonp/events{/privacy}","received_events_url":"https://api.github.com/users/iamjasonp/received_events","type":"User","site_admin":false},"body":"Sounds like a plan. Wondering if a Contract.Requires would help with static analysis as well? \r\n\r\n---\r\nIn reply to: [78079821](https://github.com/dotnet/wcf/pull/1515#discussion_r78079821) [](ancestors = 78079821)","created_at":"2016-09-09T09:19:08Z","updated_at":"2016-09-09T09:19:08Z","html_url":"https://github.com/dotnet/wcf/pull/1515#discussion_r78151294","pull_request_url":"https://api.github.com/repos/dotnet/wcf/pulls/1515","_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments/78151294"},"html":{"href":"https://github.com/dotnet/wcf/pull/1515#discussion_r78151294"},"pull_request":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1515"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/1515","id":84489728,"html_url":"https://github.com/dotnet/wcf/pull/1515","diff_url":"https://github.com/dotnet/wcf/pull/1515.diff","patch_url":"https://github.com/dotnet/wcf/pull/1515.patch","issue_url":"https://api.github.com/repos/dotnet/wcf/issues/1515","number":1515,"state":"open","locked":false,"title":"Enable SecurityBindingElement.CreateUserNameOverTransportBindingElement","user":{"login":"roncain","id":3913124,"avatar_url":"https://avatars.githubusercontent.com/u/3913124?v=3","gravatar_id":"","url":"https://api.github.com/users/roncain","html_url":"https://github.com/roncain","followers_url":"https://api.github.com/users/roncain/followers","following_url":"https://api.github.com/users/roncain/following{/other_user}","gists_url":"https://api.github.com/users/roncain/gists{/gist_id}","starred_url":"https://api.github.com/users/roncain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roncain/subscriptions","organizations_url":"https://api.github.com/users/roncain/orgs","repos_url":"https://api.github.com/users/roncain/repos","events_url":"https://api.github.com/users/roncain/events{/privacy}","received_events_url":"https://api.github.com/users/roncain/received_events","type":"User","site_admin":false},"body":"Add initial support for the simple-case use of SecurityBindingElement.CreateUserNameOverTransportBindingElement.  This entails bringing in a significant number of files from the full framework and new tests to ensure the simple default case works for synchronous operations.  It is the first step to handle issue #1257, but not enough to consider that issue fixed.\r\n\r\nOther PR's will enable the async paths and expand testing of these new layers.","created_at":"2016-09-08T14:35:56Z","updated_at":"2016-09-09T09:19:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c25dc5404f8c77b756d6b94ed74b3b1d2184d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/wcf/pulls/1515/commits","review_comments_url":"https://api.github.com/repos/dotnet/wcf/pulls/1515/comments","review_comment_url":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/wcf/issues/1515/comments","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/b765b754c19c8142a6a07fd10fc35369622afccf","head":{"label":"roncain:wstrust","ref":"wstrust","sha":"b765b754c19c8142a6a07fd10fc35369622afccf","user":{"login":"roncain","id":3913124,"avatar_url":"https://avatars.githubusercontent.com/u/3913124?v=3","gravatar_id":"","url":"https://api.github.com/users/roncain","html_url":"https://github.com/roncain","followers_url":"https://api.github.com/users/roncain/followers","following_url":"https://api.github.com/users/roncain/following{/other_user}","gists_url":"https://api.github.com/users/roncain/gists{/gist_id}","starred_url":"https://api.github.com/users/roncain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roncain/subscriptions","organizations_url":"https://api.github.com/users/roncain/orgs","repos_url":"https://api.github.com/users/roncain/repos","events_url":"https://api.github.com/users/roncain/events{/privacy}","received_events_url":"https://api.github.com/users/roncain/received_events","type":"User","site_admin":false},"repo":{"id":39504510,"name":"wcf","full_name":"roncain/wcf","owner":{"login":"roncain","id":3913124,"avatar_url":"https://avatars.githubusercontent.com/u/3913124?v=3","gravatar_id":"","url":"https://api.github.com/users/roncain","html_url":"https://github.com/roncain","followers_url":"https://api.github.com/users/roncain/followers","following_url":"https://api.github.com/users/roncain/following{/other_user}","gists_url":"https://api.github.com/users/roncain/gists{/gist_id}","starred_url":"https://api.github.com/users/roncain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roncain/subscriptions","organizations_url":"https://api.github.com/users/roncain/orgs","repos_url":"https://api.github.com/users/roncain/repos","events_url":"https://api.github.com/users/roncain/events{/privacy}","received_events_url":"https://api.github.com/users/roncain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roncain/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":true,"url":"https://api.github.com/repos/roncain/wcf","forks_url":"https://api.github.com/repos/roncain/wcf/forks","keys_url":"https://api.github.com/repos/roncain/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roncain/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roncain/wcf/teams","hooks_url":"https://api.github.com/repos/roncain/wcf/hooks","issue_events_url":"https://api.github.com/repos/roncain/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/roncain/wcf/events","assignees_url":"https://api.github.com/repos/roncain/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/roncain/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/roncain/wcf/tags","blobs_url":"https://api.github.com/repos/roncain/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roncain/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roncain/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/roncain/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roncain/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/roncain/wcf/languages","stargazers_url":"https://api.github.com/repos/roncain/wcf/stargazers","contributors_url":"https://api.github.com/repos/roncain/wcf/contributors","subscribers_url":"https://api.github.com/repos/roncain/wcf/subscribers","subscription_url":"https://api.github.com/repos/roncain/wcf/subscription","commits_url":"https://api.github.com/repos/roncain/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/roncain/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/roncain/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/roncain/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/roncain/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/roncain/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roncain/wcf/merges","archive_url":"https://api.github.com/repos/roncain/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roncain/wcf/downloads","issues_url":"https://api.github.com/repos/roncain/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/roncain/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/roncain/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/roncain/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roncain/wcf/labels{/name}","releases_url":"https://api.github.com/repos/roncain/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/roncain/wcf/deployments","created_at":"2015-07-22T12:21:54Z","updated_at":"2016-01-12T17:24:47Z","pushed_at":"2016-09-08T19:04:13Z","git_url":"git://github.com/roncain/wcf.git","ssh_url":"git@github.com:roncain/wcf.git","clone_url":"https://github.com/roncain/wcf.git","svn_url":"https://github.com/roncain/wcf","homepage":"","size":7077,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c7e8694c8a810bc996ba0ddaaf199a06983cf9e9","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35562993,"name":"wcf","full_name":"dotnet/wcf","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":false,"url":"https://api.github.com/repos/dotnet/wcf","forks_url":"https://api.github.com/repos/dotnet/wcf/forks","keys_url":"https://api.github.com/repos/dotnet/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/wcf/teams","hooks_url":"https://api.github.com/repos/dotnet/wcf/hooks","issue_events_url":"https://api.github.com/repos/dotnet/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/wcf/events","assignees_url":"https://api.github.com/repos/dotnet/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/wcf/tags","blobs_url":"https://api.github.com/repos/dotnet/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/wcf/languages","stargazers_url":"https://api.github.com/repos/dotnet/wcf/stargazers","contributors_url":"https://api.github.com/repos/dotnet/wcf/contributors","subscribers_url":"https://api.github.com/repos/dotnet/wcf/subscribers","subscription_url":"https://api.github.com/repos/dotnet/wcf/subscription","commits_url":"https://api.github.com/repos/dotnet/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/wcf/merges","archive_url":"https://api.github.com/repos/dotnet/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/wcf/downloads","issues_url":"https://api.github.com/repos/dotnet/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/wcf/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/wcf/deployments","created_at":"2015-05-13T17:17:03Z","updated_at":"2016-09-07T22:09:45Z","pushed_at":"2016-09-09T02:11:31Z","git_url":"git://github.com/dotnet/wcf.git","ssh_url":"git@github.com:dotnet/wcf.git","clone_url":"https://github.com/dotnet/wcf.git","svn_url":"https://github.com/dotnet/wcf","homepage":"","size":8754,"stargazers_count":689,"watchers_count":689,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":183,"forks":243,"open_issues":183,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1515"},"html":{"href":"https://github.com/dotnet/wcf/pull/1515"},"issue":{"href":"https://api.github.com/repos/dotnet/wcf/issues/1515"},"comments":{"href":"https://api.github.com/repos/dotnet/wcf/issues/1515/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1515/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1515/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/wcf/statuses/b765b754c19c8142a6a07fd10fc35369622afccf"}}}}
{"actor":{"display_login":"iamjasonp"}}