{"action":"created","issue":{"url":"https://api.github.com/repos/mperham/sidekiq/issues/2978","repository_url":"https://api.github.com/repos/mperham/sidekiq","labels_url":"https://api.github.com/repos/mperham/sidekiq/issues/2978/labels{/name}","comments_url":"https://api.github.com/repos/mperham/sidekiq/issues/2978/comments","events_url":"https://api.github.com/repos/mperham/sidekiq/issues/2978/events","html_url":"https://github.com/mperham/sidekiq/pull/2978","id":155594912,"number":2978,"title":"Set kill timeout to 15 sec. in upstart config","user":{"login":"vicentllongo","id":1669674,"avatar_url":"https://avatars.githubusercontent.com/u/1669674?v=3","gravatar_id":"","url":"https://api.github.com/users/vicentllongo","html_url":"https://github.com/vicentllongo","followers_url":"https://api.github.com/users/vicentllongo/followers","following_url":"https://api.github.com/users/vicentllongo/following{/other_user}","gists_url":"https://api.github.com/users/vicentllongo/gists{/gist_id}","starred_url":"https://api.github.com/users/vicentllongo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicentllongo/subscriptions","organizations_url":"https://api.github.com/users/vicentllongo/orgs","repos_url":"https://api.github.com/users/vicentllongo/repos","events_url":"https://api.github.com/users/vicentllongo/events{/privacy}","received_events_url":"https://api.github.com/users/vicentllongo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-18T20:33:24Z","updated_at":"2016-05-18T21:36:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mperham/sidekiq/pulls/2978","html_url":"https://github.com/mperham/sidekiq/pull/2978","diff_url":"https://github.com/mperham/sidekiq/pull/2978.diff","patch_url":"https://github.com/mperham/sidekiq/pull/2978.patch"},"body":"Upstart \"kill timeout\" is 5 seconds by default (http://upstart.ubuntu.com/cookbook/#kill-timeout). \r\n\r\nThis will cause that when using the provided upstart/sidekiq.conf, upstart will kill the sidekiq process while is waiting for any running workers to end, and even before the process enqueue them into the retries queue, losing any running jobs.\r\n\r\nThis PR sets a higher timeout that should be safe to use with the default sidekiq \"kill_timeout\" which is 10 seconds."},"comment":{"url":"https://api.github.com/repos/mperham/sidekiq/issues/comments/220165687","html_url":"https://github.com/mperham/sidekiq/pull/2978#issuecomment-220165687","issue_url":"https://api.github.com/repos/mperham/sidekiq/issues/2978","id":220165687,"user":{"login":"vicentllongo","id":1669674,"avatar_url":"https://avatars.githubusercontent.com/u/1669674?v=3","gravatar_id":"","url":"https://api.github.com/users/vicentllongo","html_url":"https://github.com/vicentllongo","followers_url":"https://api.github.com/users/vicentllongo/followers","following_url":"https://api.github.com/users/vicentllongo/following{/other_user}","gists_url":"https://api.github.com/users/vicentllongo/gists{/gist_id}","starred_url":"https://api.github.com/users/vicentllongo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicentllongo/subscriptions","organizations_url":"https://api.github.com/users/vicentllongo/orgs","repos_url":"https://api.github.com/users/vicentllongo/repos","events_url":"https://api.github.com/users/vicentllongo/events{/privacy}","received_events_url":"https://api.github.com/users/vicentllongo/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T21:36:34Z","updated_at":"2016-05-18T21:36:34Z","body":"It seems the setting has been around for a while (there's no mention it has been added in a recent version): http://upstart.ubuntu.com/cookbook/#stanzas-by-category\r\n\r\nI have tested this with Ubuntu 14.04 which uses upstart 1.12.1. CentOS 6 seems to use v0.6.5, and by the changelog it seems is supported for that version, but maybe someone else using CentOS can confirm it."}}