{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments/79474330","id":79474330,"diff_hunk":"@@ -17,6 +17,7 @@\n // --------------------\n html {\n   height: 100%;\n+  font-size: 14px;","path":"analytics_dashboard/static/sass/_base.scss","position":4,"original_position":4,"commit_id":"afcdb3d9bf91d4a21997b2d6a0115e8c30ccf168","original_commit_id":"afcdb3d9bf91d4a21997b2d6a0115e8c30ccf168","user":{"login":"thallada","id":1505923,"avatar_url":"https://avatars.githubusercontent.com/u/1505923?v=3","gravatar_id":"","url":"https://api.github.com/users/thallada","html_url":"https://github.com/thallada","followers_url":"https://api.github.com/users/thallada/followers","following_url":"https://api.github.com/users/thallada/following{/other_user}","gists_url":"https://api.github.com/users/thallada/gists{/gist_id}","starred_url":"https://api.github.com/users/thallada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallada/subscriptions","organizations_url":"https://api.github.com/users/thallada/orgs","repos_url":"https://api.github.com/users/thallada/repos","events_url":"https://api.github.com/users/thallada/events{/privacy}","received_events_url":"https://api.github.com/users/thallada/received_events","type":"User","site_admin":false},"body":"++","created_at":"2016-09-19T19:51:45Z","updated_at":"2016-09-19T19:51:45Z","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/555#discussion_r79474330","pull_request_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments/79474330"},"html":{"href":"https://github.com/edx/edx-analytics-dashboard/pull/555#discussion_r79474330"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555","id":85614188,"html_url":"https://github.com/edx/edx-analytics-dashboard/pull/555","diff_url":"https://github.com/edx/edx-analytics-dashboard/pull/555.diff","patch_url":"https://github.com/edx/edx-analytics-dashboard/pull/555.patch","issue_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/555","number":555,"state":"open","locked":false,"title":"AN-7640 Begin using the edX Pattern Library","user":{"login":"thallada","id":1505923,"avatar_url":"https://avatars.githubusercontent.com/u/1505923?v=3","gravatar_id":"","url":"https://api.github.com/users/thallada","html_url":"https://github.com/thallada","followers_url":"https://api.github.com/users/thallada/followers","following_url":"https://api.github.com/users/thallada/following{/other_user}","gists_url":"https://api.github.com/users/thallada/gists{/gist_id}","starred_url":"https://api.github.com/users/thallada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallada/subscriptions","organizations_url":"https://api.github.com/users/thallada/orgs","repos_url":"https://api.github.com/users/thallada/repos","events_url":"https://api.github.com/users/thallada/events{/privacy}","received_events_url":"https://api.github.com/users/thallada/received_events","type":"User","site_admin":false},"body":"[AN-7640](https://openedx.atlassian.net/browse/AN-7640) | [edX Pattern Library](http://ux.edx.org/)\r\n\r\nSince the pattern library is still a work in progress, we are only using it in certain areas of the application:\r\n\r\n- Colors\r\n- Grid system\r\n- Alerts\r\n- Icons\r\n- Default headings, copy, and lists styling\r\n\r\nWe did not use the pattern library and are still using bootstrap components for:\r\n\r\n- Navbar\r\n- Tables\r\n- Tooltips\r\n- Dropdowns\r\n- Pagination\r\n\r\nUnfortunately, the susy sass compilation in the pattern library is very slow (see: [FEDX-240](https://openedx.atlassian.net/browse/FEDX-240)), so we are importing the entire pattern library as compiled css and then importing only the settings and functions sass modules afterwards for use in our sass. We are creating tech debt tickets to resolve this hacky situation once the pattern library is more matured.\r\n\r\n**Improvements**\r\n\r\n- More accessible (higher contrast) font color and background color combinations.\r\n- More responsive UI (e.g. the engagement geography world map now scales with the viewport)\r\n- More consistent styling: closer to the styling in other edX applications.","created_at":"2016-09-16T17:56:43Z","updated_at":"2016-09-19T19:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a64cd0e0054a2409c3132ffabfe3366c5c03e9","assignee":{"login":"dsjen","id":5265058,"avatar_url":"https://avatars.githubusercontent.com/u/5265058?v=3","gravatar_id":"","url":"https://api.github.com/users/dsjen","html_url":"https://github.com/dsjen","followers_url":"https://api.github.com/users/dsjen/followers","following_url":"https://api.github.com/users/dsjen/following{/other_user}","gists_url":"https://api.github.com/users/dsjen/gists{/gist_id}","starred_url":"https://api.github.com/users/dsjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsjen/subscriptions","organizations_url":"https://api.github.com/users/dsjen/orgs","repos_url":"https://api.github.com/users/dsjen/repos","events_url":"https://api.github.com/users/dsjen/events{/privacy}","received_events_url":"https://api.github.com/users/dsjen/received_events","type":"User","site_admin":false},"assignees":[{"login":"dsjen","id":5265058,"avatar_url":"https://avatars.githubusercontent.com/u/5265058?v=3","gravatar_id":"","url":"https://api.github.com/users/dsjen","html_url":"https://github.com/dsjen","followers_url":"https://api.github.com/users/dsjen/followers","following_url":"https://api.github.com/users/dsjen/following{/other_user}","gists_url":"https://api.github.com/users/dsjen/gists{/gist_id}","starred_url":"https://api.github.com/users/dsjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsjen/subscriptions","organizations_url":"https://api.github.com/users/dsjen/orgs","repos_url":"https://api.github.com/users/dsjen/repos","events_url":"https://api.github.com/users/dsjen/events{/privacy}","received_events_url":"https://api.github.com/users/dsjen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555/commits","review_comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555/comments","review_comment_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/555/comments","statuses_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/afcdb3d9bf91d4a21997b2d6a0115e8c30ccf168","head":{"label":"edx:pattern-library","ref":"pattern-library","sha":"afcdb3d9bf91d4a21997b2d6a0115e8c30ccf168","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":20941273,"name":"edx-analytics-dashboard","full_name":"edx/edx-analytics-dashboard","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-analytics-dashboard","description":"Dashboard to display course analytics to course teams","fork":false,"url":"https://api.github.com/repos/edx/edx-analytics-dashboard","forks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/forks","keys_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/teams","hooks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/events","assignees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/tags","blobs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/languages","stargazers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscription","commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/merges","archive_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/downloads","issues_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/deployments","created_at":"2014-06-17T22:14:33Z","updated_at":"2016-08-05T15:36:51Z","pushed_at":"2016-09-19T15:42:22Z","git_url":"git://github.com/edx/edx-analytics-dashboard.git","ssh_url":"git@github.com:edx/edx-analytics-dashboard.git","clone_url":"https://github.com/edx/edx-analytics-dashboard.git","svn_url":"https://github.com/edx/edx-analytics-dashboard","homepage":null,"size":19531,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":4,"forks":47,"open_issues":4,"watchers":27,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"e7c827237278969725ebe89e45f11e39460f5161","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":20941273,"name":"edx-analytics-dashboard","full_name":"edx/edx-analytics-dashboard","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-analytics-dashboard","description":"Dashboard to display course analytics to course teams","fork":false,"url":"https://api.github.com/repos/edx/edx-analytics-dashboard","forks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/forks","keys_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/teams","hooks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/events","assignees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/tags","blobs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/languages","stargazers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscription","commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/merges","archive_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/downloads","issues_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/deployments","created_at":"2014-06-17T22:14:33Z","updated_at":"2016-08-05T15:36:51Z","pushed_at":"2016-09-19T15:42:22Z","git_url":"git://github.com/edx/edx-analytics-dashboard.git","ssh_url":"git@github.com:edx/edx-analytics-dashboard.git","clone_url":"https://github.com/edx/edx-analytics-dashboard.git","svn_url":"https://github.com/edx/edx-analytics-dashboard","homepage":null,"size":19531,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":4,"forks":47,"open_issues":4,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555"},"html":{"href":"https://github.com/edx/edx-analytics-dashboard/pull/555"},"issue":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/555"},"comments":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/555/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/555/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/afcdb3d9bf91d4a21997b2d6a0115e8c30ccf168"}}}}
{"actor":{"display_login":"thallada"}}