{"action":"created","issue":{"url":"https://api.github.com/repos/blueman-project/blueman/issues/466","repository_url":"https://api.github.com/repos/blueman-project/blueman","labels_url":"https://api.github.com/repos/blueman-project/blueman/issues/466/labels{/name}","comments_url":"https://api.github.com/repos/blueman-project/blueman/issues/466/comments","events_url":"https://api.github.com/repos/blueman-project/blueman/issues/466/events","html_url":"https://github.com/blueman-project/blueman/pull/466","id":134724889,"number":466,"title":"Big cleanup and rework of Adapter menu in ManagerMenu class","user":{"login":"infirit","id":3465730,"avatar_url":"https://avatars.githubusercontent.com/u/3465730?v=3","gravatar_id":"","url":"https://api.github.com/users/infirit","html_url":"https://github.com/infirit","followers_url":"https://api.github.com/users/infirit/followers","following_url":"https://api.github.com/users/infirit/following{/other_user}","gists_url":"https://api.github.com/users/infirit/gists{/gist_id}","starred_url":"https://api.github.com/users/infirit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infirit/subscriptions","organizations_url":"https://api.github.com/users/infirit/orgs","repos_url":"https://api.github.com/users/infirit/repos","events_url":"https://api.github.com/users/infirit/events{/privacy}","received_events_url":"https://api.github.com/users/infirit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-18T23:04:27Z","updated_at":"2016-02-19T15:16:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/blueman-project/blueman/pulls/466","html_url":"https://github.com/blueman-project/blueman/pull/466","diff_url":"https://github.com/blueman-project/blueman/pull/466.diff","patch_url":"https://github.com/blueman-project/blueman/pull/466.patch"},"body":"These commits change the way we create and update the Adapter menu. The major changes are,\r\n\r\n * No more regenerating the __complete__ Adapter menu on every change (add/remove/select etc).\r\n * Use a bluez.Manager object to add and remove adapter menu entries\r\n * Move the creation of the adapter menu items to on_adapter_added/removed\r\n * Connect and disconnect the ``property-changed`` signal on the bluez.Adapter objects when added/removed. We do not rely on the DeviceList for this any-more.\r\n\r\nThere should be no functional or visual changes so let me know if you run into any of them.\r\n\r\nWhy all this work you may ask, well it came about my idea to have different sorting options (by time added, alias, ascending/decending) for the DeviceList (and the current one is horrendous). And when one starts poking at things one finds lots of things that probably made sense in the past but are now getting in the way :smile:.\r\n\r\nWhat I like to do next is do more work on the ManagerDeviceList and change the way we use the strore and display the view. The idea is to have a single list with __all__ devices from __all__ adapters and then have a filter function to only project the rows that are relevant to the currently selected adapter the view.\r\n\r\nps: i'll also finish things up on #464 in the next couple of days."},"comment":{"url":"https://api.github.com/repos/blueman-project/blueman/issues/comments/186255635","html_url":"https://github.com/blueman-project/blueman/pull/466#issuecomment-186255635","issue_url":"https://api.github.com/repos/blueman-project/blueman/issues/466","id":186255635,"user":{"login":"infirit","id":3465730,"avatar_url":"https://avatars.githubusercontent.com/u/3465730?v=3","gravatar_id":"","url":"https://api.github.com/users/infirit","html_url":"https://github.com/infirit","followers_url":"https://api.github.com/users/infirit/followers","following_url":"https://api.github.com/users/infirit/following{/other_user}","gists_url":"https://api.github.com/users/infirit/gists{/gist_id}","starred_url":"https://api.github.com/users/infirit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infirit/subscriptions","organizations_url":"https://api.github.com/users/infirit/orgs","repos_url":"https://api.github.com/users/infirit/repos","events_url":"https://api.github.com/users/infirit/events{/privacy}","received_events_url":"https://api.github.com/users/infirit/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T15:16:45Z","updated_at":"2016-02-19T15:16:45Z","body":"Ok, pushed a couple commits per discussion, if nothing else is left I'll push this later today :smile: ."}}