{"push_id":1014769554,"size":109,"distinct_size":32,"ref":"refs/heads/issue-17537","head":"e9f5e71f8f4f6af212c07fdbe21bde365dea4756","before":"7bdb4038867c5a19c2149ba3036dc84235657b1e","commits":[{"sha":"d3fe07b1600f50c0b0f926317c3bb01cab21cdfb","author":{"email":"b774c9c4f4df5b71b3badf3fd8d97c6375f45d57@gmail.com","name":"Roy Van Ginneken"},"message":"[TwigBundle] fixed Include file locations in \"Template could not be found\" exception","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/d3fe07b1600f50c0b0f926317c3bb01cab21cdfb"},{"sha":"e9d951a8821df4df3fcce48ec79806cca97dbae7","author":{"email":"b774c9c4f4df5b71b3badf3fd8d97c6375f45d57@gmail.com","name":"Roy Van Ginneken"},"message":"[CodingStandards] Conformed to coding standards","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/e9d951a8821df4df3fcce48ec79806cca97dbae7"},{"sha":"968476b707c75caf517519a47d8385d4dc23ec05","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Improved the error message when a template is not found","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/968476b707c75caf517519a47d8385d4dc23ec05"},{"sha":"35f082f6ef954b78af20e36f8b1bae7d32dda83d","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Fixed a syntax issue","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/35f082f6ef954b78af20e36f8b1bae7d32dda83d"},{"sha":"88b913b0c465dd805d679a0642aba4fd17a20241","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Fixed the problem in an easier way","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/88b913b0c465dd805d679a0642aba4fd17a20241"},{"sha":"19bfa2ed8c4c216ed827670ed53e1aa408a3a00d","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Added a test","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/19bfa2ed8c4c216ed827670ed53e1aa408a3a00d"},{"sha":"0134d7678516f6c9ec56059e0596685c501724b4","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Simplified everything","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/0134d7678516f6c9ec56059e0596685c501724b4"},{"sha":"f904a2ba99fac5e6421ada535831ebf4444a56cf","author":{"email":"25c6d4f6b0084d813f4c6a002bb1a7a2e29bc9a3@gmail.com","name":"Fred Cox"},"message":"Add a Controller function to make it easy to return json\n\nIf the serializer component is enabled it is used to generate the json\ndata, if not the standard `json_encode`  function is used","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/f904a2ba99fac5e6421ada535831ebf4444a56cf"},{"sha":"c3744202f60aa617135238acc51232c98dcbb6e4","author":{"email":"90d16dd295c161de7410734b825653cc813129ff@novatexsolutions.com","name":"Craig Menning"},"message":"Remove _path from query parameters when fragment is a subrequest and request attributes are already set\nAdded tests for _path removal in FragmentListener","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/c3744202f60aa617135238acc51232c98dcbb6e4"},{"sha":"bd22c8618a5adba3cc61475da85ae237d650f9df","author":{"email":"08a93cfa6c4adf861cc27fdfb8215e55e28d23f4@heahprod.com","name":"Jules Pietri"},"message":"minor [Form] fix tests added by #16886","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/bd22c8618a5adba3cc61475da85ae237d650f9df"},{"sha":"97c5d27c598c678de8d56770e58fafdd05688fd3","author":{"email":"db0c3324cb9cc63e8ba793f39c1052050aeaa82f@gmail.com","name":"Ener-Getick"},"message":"Allow to normalize \\Traversable","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/97c5d27c598c678de8d56770e58fafdd05688fd3"},{"sha":"d8c493f0761bc472309b7ac24468962e8a4ffc73","author":{"email":"1d3764b91b902f6b45836e2498da81fe35caf6d6@zalas.pl","name":"Jakub Zalas"},"message":"[FrameworkBundle] Fix a regression in handling absolute and namespaced template paths","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/d8c493f0761bc472309b7ac24468962e8a4ffc73"},{"sha":"154eac7733e27a61621729ad2786ced825ce95d3","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #17595 [HttpKernel] Remove _path from query parameters when fragment is a subrequest (cmenning)\n\nThis PR was merged into the 2.3 branch.\n\nDiscussion\n----------\n\n[HttpKernel] Remove _path from query parameters when fragment is a subrequest\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | Yes\n| New feature?  | No\n| BC breaks?    | No\n| Deprecations? | No\n| Tests pass?   | Yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nPrior to 2.3.29, all requests to the ESI fragment path (\"/_fragment\" by default) would have the \"_path\" query parameter removed. This held true whether an external proxy (such as Varnish) handled the request as true ESI, or whether the Symfony kernel was mocking ESI behavior and inlining the subrequest.\n\nOnce the \"_controller\" check was added in 2.3.29, the \"_path\" query parameter was only removed on master requests (such as those coming from an external proxy) and not subrequests, leading to differing behavior in production and development settings.\n\nCommits\n-------\n\nc374420 Remove _path from query parameters when fragment is a subrequest and request attributes are already set Added tests for _path removal in FragmentListener","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/154eac7733e27a61621729ad2786ced825ce95d3"},{"sha":"5b796499806f1b7996f200c083ed90573e215f25","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #17988 [Form] fix tests added by #16886 (HeahDude)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[Form] fix tests added by #16886\n\n| Q             | A\n| ------------- | ---\n| Branch        | 2.7+\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #16886\n| License       | MIT\n| Doc PR        | -\n\nCommits\n-------\n\nbd22c86 minor [Form] fix tests added by #16886","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/5b796499806f1b7996f200c083ed90573e215f25"},{"sha":"64c80a679148cd6d4f11d326fc1b0d4144772420","author":{"email":"cd369708c18ef5717de6c7beb8a569b7ec799d85@lrqdo.fr","name":"Kim Laï Trinh"},"message":"[DoctrineBridge][Form] Fix performance regression in EntityType","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/64c80a679148cd6d4f11d326fc1b0d4144772420"},{"sha":"46d1d2407af0f3320a663e89f74e528278549c40","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #17990 [DoctrineBridge][Form] Fix performance regression in EntityType (kimlai)\n\nThis PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17990).\n\nDiscussion\n----------\n\n[DoctrineBridge][Form] Fix performance regression in EntityType\n\n| Q             | A\n| ------------- | ---\n| Branch        | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nA performance regression was introduced in https://github.com/symfony/symfony/commit/2336d5c466325c41b3992d8d3eb0e26d2c4230fa\n\nBefore, the default behaviour of the `DoctrineLoader` was to only fetch the entities selected in the submitted form.\n\nAfter, the optimization was only performed when the `choice_value` option was set to `null`.\nHowever, the `DoctrineType` sets a non-null default value to `choice_value`, which means that the default behaviour was not using the optimization anymore.\n\nThis commit restores the default behaviour (while keeping the previous commit intent).\n\nReferences:\n- https://github.com/symfony/symfony/blob/v2.7.10/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php#L149\n- https://github.com/symfony/symfony/blob/v2.7.10/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L216\n\nCommits\n-------\n\n64c80a6 [DoctrineBridge][Form] Fix performance regression in EntityType","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/46d1d2407af0f3320a663e89f74e528278549c40"},{"sha":"eee9bfbef630903f78a6c586656921f758f0b714","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #17894 [FrameworkBundle] Fix a regression in handling absolute template paths (jakzal)\n\nThis PR was merged into the 2.3 branch.\n\nDiscussion\n----------\n\n[FrameworkBundle] Fix a regression in handling absolute template paths\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #17777 #17683\n| License       | MIT\n| Doc PR        | -\n\nRegression introduced by #15272.\n\nCommits\n-------\n\nd8c493f [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/eee9bfbef630903f78a6c586656921f758f0b714"},{"sha":"10015546b050942baa6f8c8b424195279a9b41b7","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Improve error reporting in router panel of web profiler","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/10015546b050942baa6f8c8b424195279a9b41b7"},{"sha":"9d58ad92fecff8e09b1d827563769f12d1e0b7f1","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #17744 Improve error reporting in router panel of web profiler (javiereguiluz)\n\nThis PR was squashed before being merged into the 2.7 branch (closes #17744).\n\nDiscussion\n----------\n\nImprove error reporting in router panel of web profiler\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #17342\n| License       | MIT\n| Doc PR        | -\n\n### Problem\n\nIf you define a route condition like this:\n\n```yaml\napp:\n    resource: '@AppBundle/Controller/'\n    type:     annotation\n    condition: \"request.server.get('HTTP_HOST') matches '/.*\\.dev/'\"\n```\n\nWhen browsing the Routing panel in the web profiler, you see an exception:\n\n![problem](https://cloud.githubusercontent.com/assets/73419/12930027/553eeb08-cf76-11e5-90b1-ab0de6175d4e.png)\n\n#### Why?\n\nBecause the route condition uses the `request` object, but the special `TraceableUrlMatcher` class doesn't get access to the real `request` object but to the special object obtained via:\n\n```php\n$request = $profile->getCollector('request');\n```\n\nThese are the contents of this pseudo-request:\n\n![cause](https://cloud.githubusercontent.com/assets/73419/12930052/804ea248-cf76-11e5-9c38-2e43e1654065.png)\n\n`request.server.get(...)` condition fails because `request.server` is `null`. The full exception message shows this:\n\n![exception](https://cloud.githubusercontent.com/assets/73419/12930079/9c7d6058-cf76-11e5-8eeb-45f5059c824c.png)\n\n### Solution\n\nI propose to catch all exceptions in `TraceableUrlMatcher` and display an error message with some details of the exception:\n\n![error_message](https://cloud.githubusercontent.com/assets/73419/12930106/b29e31d2-cf76-11e5-868c-98d8b0cc4e5b.png)\n\nCommits\n-------\n\n1001554 Improve error reporting in router panel of web profiler","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/9d58ad92fecff8e09b1d827563769f12d1e0b7f1"},{"sha":"e7690ba5c453b0264a7c9199240a1959e92ad8b9","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Improved the error message when using \"@\" in a decorated service","distinct":false,"url":"https://api.github.com/repos/xabbuh/symfony/commits/e7690ba5c453b0264a7c9199240a1959e92ad8b9"}]}