{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/dCache/dcache-view/pulls/2","id":79702816,"html_url":"https://github.com/dCache/dcache-view/pull/2","diff_url":"https://github.com/dCache/dcache-view/pull/2.diff","patch_url":"https://github.com/dCache/dcache-view/pull/2.patch","issue_url":"https://api.github.com/repos/dCache/dcache-view/issues/2","number":2,"state":"closed","locked":false,"title":"dcache-view: move username+password logic in view-file and file-metadata element","user":{"login":"femiadeyemi","id":2529297,"avatar_url":"https://avatars.githubusercontent.com/u/2529297?v=3","gravatar_id":"","url":"https://api.github.com/users/femiadeyemi","html_url":"https://github.com/femiadeyemi","followers_url":"https://api.github.com/users/femiadeyemi/followers","following_url":"https://api.github.com/users/femiadeyemi/following{/other_user}","gists_url":"https://api.github.com/users/femiadeyemi/gists{/gist_id}","starred_url":"https://api.github.com/users/femiadeyemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femiadeyemi/subscriptions","organizations_url":"https://api.github.com/users/femiadeyemi/orgs","repos_url":"https://api.github.com/users/femiadeyemi/repos","events_url":"https://api.github.com/users/femiadeyemi/events{/privacy}","received_events_url":"https://api.github.com/users/femiadeyemi/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nThe attached function in Polymer is called whenever an element is attached\r\nto the document. The view-file and file-metadata element (these are custom\r\ndcache-view elements) makes use of this attached function to setup username\r\nand password.\r\n\r\nUnfornately, some browsers seem not to call the attached function when\r\nattaching the view-file and file-metadata element to the DOM. This can be\r\ntraced down to the fact that those browsers seem not to catch-up with\r\nmutiple creation and deletion of element (especially view-file) dynamically.\r\nThe side-effect of this is that user is never authenticated by dcache-view.\r\n\r\nModification:\r\n\r\nRemoved attached function and used the computed function to set the value\r\nof the upw property for view-file and file-metadata element.\r\n\r\nResult:\r\n\r\nAll browsers are happy\r\n\r\nTarget: trunk\r\nTarget: 1.0\r\nRequire-note: no\r\nRequire-book: no\r\nAcked-by: Paul Millar<paul.millar@desy.de>\r\n\r\nReviewed at https://rb.dcache.org/r/9550/\r\n\r\n(cherry picked from commit 4b7a56c43b7581674cce41289c3eee2e0da43721)","created_at":"2016-08-02T09:28:19Z","updated_at":"2016-08-02T09:28:26Z","closed_at":"2016-08-02T09:28:26Z","merged_at":"2016-08-02T09:28:26Z","merge_commit_sha":"0c515beadea2f8ce9a4969ec3d8ef12135739c4a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dCache/dcache-view/pulls/2/commits","review_comments_url":"https://api.github.com/repos/dCache/dcache-view/pulls/2/comments","review_comment_url":"https://api.github.com/repos/dCache/dcache-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dCache/dcache-view/issues/2/comments","statuses_url":"https://api.github.com/repos/dCache/dcache-view/statuses/09c714294cff23fc4395963cd3772f8450091197","head":{"label":"dCache:1.0","ref":"1.0","sha":"09c714294cff23fc4395963cd3772f8450091197","user":{"login":"dCache","id":1384620,"avatar_url":"https://avatars.githubusercontent.com/u/1384620?v=3","gravatar_id":"","url":"https://api.github.com/users/dCache","html_url":"https://github.com/dCache","followers_url":"https://api.github.com/users/dCache/followers","following_url":"https://api.github.com/users/dCache/following{/other_user}","gists_url":"https://api.github.com/users/dCache/gists{/gist_id}","starred_url":"https://api.github.com/users/dCache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dCache/subscriptions","organizations_url":"https://api.github.com/users/dCache/orgs","repos_url":"https://api.github.com/users/dCache/repos","events_url":"https://api.github.com/users/dCache/events{/privacy}","received_events_url":"https://api.github.com/users/dCache/received_events","type":"Organization","site_admin":false},"repo":{"id":60751122,"name":"dcache-view","full_name":"dCache/dcache-view","owner":{"login":"dCache","id":1384620,"avatar_url":"https://avatars.githubusercontent.com/u/1384620?v=3","gravatar_id":"","url":"https://api.github.com/users/dCache","html_url":"https://github.com/dCache","followers_url":"https://api.github.com/users/dCache/followers","following_url":"https://api.github.com/users/dCache/following{/other_user}","gists_url":"https://api.github.com/users/dCache/gists{/gist_id}","starred_url":"https://api.github.com/users/dCache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dCache/subscriptions","organizations_url":"https://api.github.com/users/dCache/orgs","repos_url":"https://api.github.com/users/dCache/repos","events_url":"https://api.github.com/users/dCache/events{/privacy}","received_events_url":"https://api.github.com/users/dCache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dCache/dcache-view","description":"A Web application that provide an easy to use User Interface for dCache System.","fork":false,"url":"https://api.github.com/repos/dCache/dcache-view","forks_url":"https://api.github.com/repos/dCache/dcache-view/forks","keys_url":"https://api.github.com/repos/dCache/dcache-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dCache/dcache-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dCache/dcache-view/teams","hooks_url":"https://api.github.com/repos/dCache/dcache-view/hooks","issue_events_url":"https://api.github.com/repos/dCache/dcache-view/issues/events{/number}","events_url":"https://api.github.com/repos/dCache/dcache-view/events","assignees_url":"https://api.github.com/repos/dCache/dcache-view/assignees{/user}","branches_url":"https://api.github.com/repos/dCache/dcache-view/branches{/branch}","tags_url":"https://api.github.com/repos/dCache/dcache-view/tags","blobs_url":"https://api.github.com/repos/dCache/dcache-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dCache/dcache-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dCache/dcache-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/dCache/dcache-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dCache/dcache-view/statuses/{sha}","languages_url":"https://api.github.com/repos/dCache/dcache-view/languages","stargazers_url":"https://api.github.com/repos/dCache/dcache-view/stargazers","contributors_url":"https://api.github.com/repos/dCache/dcache-view/contributors","subscribers_url":"https://api.github.com/repos/dCache/dcache-view/subscribers","subscription_url":"https://api.github.com/repos/dCache/dcache-view/subscription","commits_url":"https://api.github.com/repos/dCache/dcache-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/dCache/dcache-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/dCache/dcache-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/dCache/dcache-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/dCache/dcache-view/contents/{+path}","compare_url":"https://api.github.com/repos/dCache/dcache-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dCache/dcache-view/merges","archive_url":"https://api.github.com/repos/dCache/dcache-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dCache/dcache-view/downloads","issues_url":"https://api.github.com/repos/dCache/dcache-view/issues{/number}","pulls_url":"https://api.github.com/repos/dCache/dcache-view/pulls{/number}","milestones_url":"https://api.github.com/repos/dCache/dcache-view/milestones{/number}","notifications_url":"https://api.github.com/repos/dCache/dcache-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dCache/dcache-view/labels{/name}","releases_url":"https://api.github.com/repos/dCache/dcache-view/releases{/id}","deployments_url":"https://api.github.com/repos/dCache/dcache-view/deployments","created_at":"2016-06-09T05:05:10Z","updated_at":"2016-07-14T10:35:06Z","pushed_at":"2016-08-02T09:28:26Z","git_url":"git://github.com/dCache/dcache-view.git","ssh_url":"git@github.com:dCache/dcache-view.git","clone_url":"https://github.com/dCache/dcache-view.git","svn_url":"https://github.com/dCache/dcache-view","homepage":"","size":30,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dCache:master","ref":"master","sha":"4b7a56c43b7581674cce41289c3eee2e0da43721","user":{"login":"dCache","id":1384620,"avatar_url":"https://avatars.githubusercontent.com/u/1384620?v=3","gravatar_id":"","url":"https://api.github.com/users/dCache","html_url":"https://github.com/dCache","followers_url":"https://api.github.com/users/dCache/followers","following_url":"https://api.github.com/users/dCache/following{/other_user}","gists_url":"https://api.github.com/users/dCache/gists{/gist_id}","starred_url":"https://api.github.com/users/dCache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dCache/subscriptions","organizations_url":"https://api.github.com/users/dCache/orgs","repos_url":"https://api.github.com/users/dCache/repos","events_url":"https://api.github.com/users/dCache/events{/privacy}","received_events_url":"https://api.github.com/users/dCache/received_events","type":"Organization","site_admin":false},"repo":{"id":60751122,"name":"dcache-view","full_name":"dCache/dcache-view","owner":{"login":"dCache","id":1384620,"avatar_url":"https://avatars.githubusercontent.com/u/1384620?v=3","gravatar_id":"","url":"https://api.github.com/users/dCache","html_url":"https://github.com/dCache","followers_url":"https://api.github.com/users/dCache/followers","following_url":"https://api.github.com/users/dCache/following{/other_user}","gists_url":"https://api.github.com/users/dCache/gists{/gist_id}","starred_url":"https://api.github.com/users/dCache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dCache/subscriptions","organizations_url":"https://api.github.com/users/dCache/orgs","repos_url":"https://api.github.com/users/dCache/repos","events_url":"https://api.github.com/users/dCache/events{/privacy}","received_events_url":"https://api.github.com/users/dCache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dCache/dcache-view","description":"A Web application that provide an easy to use User Interface for dCache System.","fork":false,"url":"https://api.github.com/repos/dCache/dcache-view","forks_url":"https://api.github.com/repos/dCache/dcache-view/forks","keys_url":"https://api.github.com/repos/dCache/dcache-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dCache/dcache-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dCache/dcache-view/teams","hooks_url":"https://api.github.com/repos/dCache/dcache-view/hooks","issue_events_url":"https://api.github.com/repos/dCache/dcache-view/issues/events{/number}","events_url":"https://api.github.com/repos/dCache/dcache-view/events","assignees_url":"https://api.github.com/repos/dCache/dcache-view/assignees{/user}","branches_url":"https://api.github.com/repos/dCache/dcache-view/branches{/branch}","tags_url":"https://api.github.com/repos/dCache/dcache-view/tags","blobs_url":"https://api.github.com/repos/dCache/dcache-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dCache/dcache-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dCache/dcache-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/dCache/dcache-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dCache/dcache-view/statuses/{sha}","languages_url":"https://api.github.com/repos/dCache/dcache-view/languages","stargazers_url":"https://api.github.com/repos/dCache/dcache-view/stargazers","contributors_url":"https://api.github.com/repos/dCache/dcache-view/contributors","subscribers_url":"https://api.github.com/repos/dCache/dcache-view/subscribers","subscription_url":"https://api.github.com/repos/dCache/dcache-view/subscription","commits_url":"https://api.github.com/repos/dCache/dcache-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/dCache/dcache-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/dCache/dcache-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/dCache/dcache-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/dCache/dcache-view/contents/{+path}","compare_url":"https://api.github.com/repos/dCache/dcache-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dCache/dcache-view/merges","archive_url":"https://api.github.com/repos/dCache/dcache-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dCache/dcache-view/downloads","issues_url":"https://api.github.com/repos/dCache/dcache-view/issues{/number}","pulls_url":"https://api.github.com/repos/dCache/dcache-view/pulls{/number}","milestones_url":"https://api.github.com/repos/dCache/dcache-view/milestones{/number}","notifications_url":"https://api.github.com/repos/dCache/dcache-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dCache/dcache-view/labels{/name}","releases_url":"https://api.github.com/repos/dCache/dcache-view/releases{/id}","deployments_url":"https://api.github.com/repos/dCache/dcache-view/deployments","created_at":"2016-06-09T05:05:10Z","updated_at":"2016-07-14T10:35:06Z","pushed_at":"2016-08-02T09:28:26Z","git_url":"git://github.com/dCache/dcache-view.git","ssh_url":"git@github.com:dCache/dcache-view.git","clone_url":"https://github.com/dCache/dcache-view.git","svn_url":"https://github.com/dCache/dcache-view","homepage":"","size":30,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dCache/dcache-view/pulls/2"},"html":{"href":"https://github.com/dCache/dcache-view/pull/2"},"issue":{"href":"https://api.github.com/repos/dCache/dcache-view/issues/2"},"comments":{"href":"https://api.github.com/repos/dCache/dcache-view/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/dCache/dcache-view/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/dCache/dcache-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dCache/dcache-view/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/dCache/dcache-view/statuses/09c714294cff23fc4395963cd3772f8450091197"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"femiadeyemi","id":2529297,"avatar_url":"https://avatars.githubusercontent.com/u/2529297?v=3","gravatar_id":"","url":"https://api.github.com/users/femiadeyemi","html_url":"https://github.com/femiadeyemi","followers_url":"https://api.github.com/users/femiadeyemi/followers","following_url":"https://api.github.com/users/femiadeyemi/following{/other_user}","gists_url":"https://api.github.com/users/femiadeyemi/gists{/gist_id}","starred_url":"https://api.github.com/users/femiadeyemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femiadeyemi/subscriptions","organizations_url":"https://api.github.com/users/femiadeyemi/orgs","repos_url":"https://api.github.com/users/femiadeyemi/repos","events_url":"https://api.github.com/users/femiadeyemi/events{/privacy}","received_events_url":"https://api.github.com/users/femiadeyemi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"femiadeyemi"}}