{"action":"created","comment":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/84603944","pull_request_review_id":5371520,"id":84603944,"diff_hunk":"@@ -1392,7 +1392,7 @@ class ObjectPanel : public GG::Control {\n \n         for (std::size_t i = 1; i < m_controls.size(); ++i) {\n             right = left + GetColumnWidth(static_cast<int>(i));\n-            if (ctrl = m_controls[i])\n+            if ((ctrl = m_controls[i]))","path":"UI/ObjectListWnd.cpp","position":5,"original_position":5,"commit_id":"06385d15ef128c7ed75f25be693c6543e0936f38","original_commit_id":"06385d15ef128c7ed75f25be693c6543e0936f38","user":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"body":"The changes in this PR should not generate different code.  They only make the spurious compiler warnings go away.\r\n\r\nThe compiler wants the two operations, assignment to `ctrl` and testing of the boolean clause in separately bracketed clauses.  Hence the extra set of brackets.    ","created_at":"2016-10-23T20:31:41Z","updated_at":"2016-10-23T20:31:41Z","html_url":"https://github.com/freeorion/freeorion/pull/1043#discussion_r84603944","pull_request_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1043","_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/84603944"},"html":{"href":"https://github.com/freeorion/freeorion/pull/1043#discussion_r84603944"},"pull_request":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1043"}}},"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/1043","id":88556730,"html_url":"https://github.com/freeorion/freeorion/pull/1043","diff_url":"https://github.com/freeorion/freeorion/pull/1043.diff","patch_url":"https://github.com/freeorion/freeorion/pull/1043.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/1043","number":1043,"state":"open","locked":false,"title":"Housekeeping fix brackets","user":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"body":"This PR fixes all of the warnings exposed by -Wparentheses by adding the requested brackets.","created_at":"2016-10-08T19:39:13Z","updated_at":"2016-10-23T20:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f8d73dbfbbdd379270b90a5478aa9a06cb29808","assignee":{"login":"adrianbroher","id":84891,"avatar_url":"https://avatars.githubusercontent.com/u/84891?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianbroher","html_url":"https://github.com/adrianbroher","followers_url":"https://api.github.com/users/adrianbroher/followers","following_url":"https://api.github.com/users/adrianbroher/following{/other_user}","gists_url":"https://api.github.com/users/adrianbroher/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbroher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbroher/subscriptions","organizations_url":"https://api.github.com/users/adrianbroher/orgs","repos_url":"https://api.github.com/users/adrianbroher/repos","events_url":"https://api.github.com/users/adrianbroher/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbroher/received_events","type":"User","site_admin":false},"assignees":[{"login":"adrianbroher","id":84891,"avatar_url":"https://avatars.githubusercontent.com/u/84891?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianbroher","html_url":"https://github.com/adrianbroher","followers_url":"https://api.github.com/users/adrianbroher/followers","following_url":"https://api.github.com/users/adrianbroher/following{/other_user}","gists_url":"https://api.github.com/users/adrianbroher/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbroher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbroher/subscriptions","organizations_url":"https://api.github.com/users/adrianbroher/orgs","repos_url":"https://api.github.com/users/adrianbroher/repos","events_url":"https://api.github.com/users/adrianbroher/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbroher/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/freeorion/freeorion/milestones/16","html_url":"https://github.com/freeorion/freeorion/milestones/Next%20Release","labels_url":"https://api.github.com/repos/freeorion/freeorion/milestones/16/labels","id":1712247,"number":16,"title":"Next Release","description":"Bugs, features and pull requests that need to be fixed/finalized for the next release.","creator":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars.githubusercontent.com/u/10279417?v=3","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"open_issues":130,"closed_issues":64,"state":"open","created_at":"2016-04-17T15:47:26Z","updated_at":"2016-10-22T08:39:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1043/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1043/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/1043/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/06385d15ef128c7ed75f25be693c6543e0936f38","head":{"label":"LGM-Doyle:housekeeping_fix_brackets","ref":"housekeeping_fix_brackets","sha":"06385d15ef128c7ed75f25be693c6543e0936f38","user":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"repo":{"id":51704490,"name":"freeorion","full_name":"LGM-Doyle/freeorion","owner":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LGM-Doyle/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/LGM-Doyle/freeorion","forks_url":"https://api.github.com/repos/LGM-Doyle/freeorion/forks","keys_url":"https://api.github.com/repos/LGM-Doyle/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LGM-Doyle/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LGM-Doyle/freeorion/teams","hooks_url":"https://api.github.com/repos/LGM-Doyle/freeorion/hooks","issue_events_url":"https://api.github.com/repos/LGM-Doyle/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/LGM-Doyle/freeorion/events","assignees_url":"https://api.github.com/repos/LGM-Doyle/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/LGM-Doyle/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/LGM-Doyle/freeorion/tags","blobs_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LGM-Doyle/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/LGM-Doyle/freeorion/languages","stargazers_url":"https://api.github.com/repos/LGM-Doyle/freeorion/stargazers","contributors_url":"https://api.github.com/repos/LGM-Doyle/freeorion/contributors","subscribers_url":"https://api.github.com/repos/LGM-Doyle/freeorion/subscribers","subscription_url":"https://api.github.com/repos/LGM-Doyle/freeorion/subscription","commits_url":"https://api.github.com/repos/LGM-Doyle/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/LGM-Doyle/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/LGM-Doyle/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/LGM-Doyle/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/LGM-Doyle/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LGM-Doyle/freeorion/merges","archive_url":"https://api.github.com/repos/LGM-Doyle/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LGM-Doyle/freeorion/downloads","issues_url":"https://api.github.com/repos/LGM-Doyle/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/LGM-Doyle/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/LGM-Doyle/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/LGM-Doyle/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LGM-Doyle/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/LGM-Doyle/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/LGM-Doyle/freeorion/deployments","created_at":"2016-02-14T17:21:56Z","updated_at":"2016-02-14T17:22:02Z","pushed_at":"2016-10-15T20:20:13Z","git_url":"git://github.com/LGM-Doyle/freeorion.git","ssh_url":"git@github.com:LGM-Doyle/freeorion.git","clone_url":"https://github.com/LGM-Doyle/freeorion.git","svn_url":"https://github.com/LGM-Doyle/freeorion","homepage":"http://www.freeorion.org/","size":522180,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"78f02c32a273a98ced115fd2230fd5911d24531b","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2016-10-22T08:11:22Z","pushed_at":"2016-10-23T18:14:46Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":541275,"stargazers_count":174,"watchers_count":174,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":143,"forks":67,"open_issues":143,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1043"},"html":{"href":"https://github.com/freeorion/freeorion/pull/1043"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/1043"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/1043/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1043/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1043/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/06385d15ef128c7ed75f25be693c6543e0936f38"}}}}
{"actor":{"display_login":"LGM-Doyle"}}