{"action":"created","issue":{"url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/3","repository_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software","labels_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/3/comments","events_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/3/events","html_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/3","id":183213801,"number":3,"title":"Lights Board Code","user":{"login":"enochtsang","id":9893396,"avatar_url":"https://avatars.githubusercontent.com/u/9893396?v=3","gravatar_id":"","url":"https://api.github.com/users/enochtsang","html_url":"https://github.com/enochtsang","followers_url":"https://api.github.com/users/enochtsang/followers","following_url":"https://api.github.com/users/enochtsang/following{/other_user}","gists_url":"https://api.github.com/users/enochtsang/gists{/gist_id}","starred_url":"https://api.github.com/users/enochtsang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enochtsang/subscriptions","organizations_url":"https://api.github.com/users/enochtsang/orgs","repos_url":"https://api.github.com/users/enochtsang/repos","events_url":"https://api.github.com/users/enochtsang/events{/privacy}","received_events_url":"https://api.github.com/users/enochtsang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"JordanHeinrichs","id":9473925,"avatar_url":"https://avatars.githubusercontent.com/u/9473925?v=3","gravatar_id":"","url":"https://api.github.com/users/JordanHeinrichs","html_url":"https://github.com/JordanHeinrichs","followers_url":"https://api.github.com/users/JordanHeinrichs/followers","following_url":"https://api.github.com/users/JordanHeinrichs/following{/other_user}","gists_url":"https://api.github.com/users/JordanHeinrichs/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanHeinrichs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanHeinrichs/subscriptions","organizations_url":"https://api.github.com/users/JordanHeinrichs/orgs","repos_url":"https://api.github.com/users/JordanHeinrichs/repos","events_url":"https://api.github.com/users/JordanHeinrichs/events{/privacy}","received_events_url":"https://api.github.com/users/JordanHeinrichs/received_events","type":"User","site_admin":false},"assignees":[{"login":"JordanHeinrichs","id":9473925,"avatar_url":"https://avatars.githubusercontent.com/u/9473925?v=3","gravatar_id":"","url":"https://api.github.com/users/JordanHeinrichs","html_url":"https://github.com/JordanHeinrichs","followers_url":"https://api.github.com/users/JordanHeinrichs/followers","following_url":"https://api.github.com/users/JordanHeinrichs/following{/other_user}","gists_url":"https://api.github.com/users/JordanHeinrichs/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanHeinrichs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanHeinrichs/subscriptions","organizations_url":"https://api.github.com/users/JordanHeinrichs/orgs","repos_url":"https://api.github.com/users/JordanHeinrichs/repos","events_url":"https://api.github.com/users/JordanHeinrichs/events{/privacy}","received_events_url":"https://api.github.com/users/JordanHeinrichs/received_events","type":"User","site_admin":false},{"login":"bill-luu","id":15304203,"avatar_url":"https://avatars.githubusercontent.com/u/15304203?v=3","gravatar_id":"","url":"https://api.github.com/users/bill-luu","html_url":"https://github.com/bill-luu","followers_url":"https://api.github.com/users/bill-luu/followers","following_url":"https://api.github.com/users/bill-luu/following{/other_user}","gists_url":"https://api.github.com/users/bill-luu/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-luu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-luu/subscriptions","organizations_url":"https://api.github.com/users/bill-luu/orgs","repos_url":"https://api.github.com/users/bill-luu/repos","events_url":"https://api.github.com/users/bill-luu/events{/privacy}","received_events_url":"https://api.github.com/users/bill-luu/received_events","type":"User","site_admin":false},{"login":"lahunter","id":16144978,"avatar_url":"https://avatars.githubusercontent.com/u/16144978?v=3","gravatar_id":"","url":"https://api.github.com/users/lahunter","html_url":"https://github.com/lahunter","followers_url":"https://api.github.com/users/lahunter/followers","following_url":"https://api.github.com/users/lahunter/following{/other_user}","gists_url":"https://api.github.com/users/lahunter/gists{/gist_id}","starred_url":"https://api.github.com/users/lahunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lahunter/subscriptions","organizations_url":"https://api.github.com/users/lahunter/orgs","repos_url":"https://api.github.com/users/lahunter/repos","events_url":"https://api.github.com/users/lahunter/events{/privacy}","received_events_url":"https://api.github.com/users/lahunter/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-10-15T14:57:48Z","updated_at":"2016-10-17T02:01:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/3","html_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/3","diff_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/3.diff","patch_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/3.patch"},"body":"This is my first embedded systems project, please be gentle :)\r\nOverall I've opted for verbosity over efficiency.\r\n\r\nMost of the files contain initialization code which have been generated by STM32CubeMX, for the most part I did not edit these files. Only `main.c` was heavily edited by me. \r\n\r\nI did have to make one change to library files:\r\n`stm32f4xx_hal_can.h` lines 412 and 416 were added by me. They were missing a define for an interrupt flag `CAN_FLAG_FMP0` and `CAN_FLAG_FMP1`. I use this define in `HAL_CAN_RxCpltCallback` in `Lights.c`.\r\n\r\nCAN is all tested via loopback mode. So the receiving filter works, and sending also works. Updating lights is not tested at all, awaiting test board completion.\r\n\r\n**Only `main.c`, `Lights.h,` and `Lights.c` need to be reviewed**  \r\n\r\nNOTE: For `main.c`, the functions `SystemClock_Config()` and `MX_GPIO_Init()` are completely generated, I wouldn't review those, otherwise the rest of `main.c` is good to review.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/ucsolarcarteam/epsilon-embedded-software/3)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/comments/254095697","html_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/3#issuecomment-254095697","issue_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/3","id":254095697,"user":{"login":"bill-luu","id":15304203,"avatar_url":"https://avatars.githubusercontent.com/u/15304203?v=3","gravatar_id":"","url":"https://api.github.com/users/bill-luu","html_url":"https://github.com/bill-luu","followers_url":"https://api.github.com/users/bill-luu/followers","following_url":"https://api.github.com/users/bill-luu/following{/other_user}","gists_url":"https://api.github.com/users/bill-luu/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-luu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-luu/subscriptions","organizations_url":"https://api.github.com/users/bill-luu/orgs","repos_url":"https://api.github.com/users/bill-luu/repos","events_url":"https://api.github.com/users/bill-luu/events{/privacy}","received_events_url":"https://api.github.com/users/bill-luu/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T02:01:01Z","updated_at":"2016-10-17T02:01:01Z","body":"\n\n\n\nReviewed 1 of 1 files at r6.\nReview status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.\n\n---\n\n*[EpsilonLights/Src/Lights.c, line 95 at r6](https://reviewable.io:443/reviews/ucsolarcarteam/epsilon-embedded-software/3#-KUFLft4Y6bwRCnH6gPY:-KUFLftBFpG7gEG4FOXj:bripnrm) ([raw file](https://github.com/ucsolarcarteam/epsilon-embedded-software/blob/e7726cd0e8c0fd52dbfd45c19ae94f6da0164325/EpsilonLights/Src/Lights.c#L95)):*\n> ```C\n>         osDelayUntil(&prevWakeTime, LIGHTS_UPDATE_FREQ);\n> \n>         // Check if both signa lights inputs are DISABLED\n> ```\n\nTypo on signal\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/ucsolarcarteam/epsilon-embedded-software/3)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"bill-luu"}}