{"action":"closed","number":461,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/461","id":54287701,"html_url":"https://github.com/puppetlabs/puppet-agent/pull/461","diff_url":"https://github.com/puppetlabs/puppet-agent/pull/461.diff","patch_url":"https://github.com/puppetlabs/puppet-agent/pull/461.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/461","number":461,"state":"closed","locked":false,"title":"(RE-5733, RE-5734) Build ruby and rubygems on windows","user":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"body":"This PR mainly updates the windows feature branch to build ruby and individually manage all required rubygems.\r\n\r\nThis PR also fixes a few assumptions that were incorrect prior to this.\r\n\r\n1) Ruby expects the ca cert pem file to be in the openssl prefix directory. There may be a way to specify a custom location during the configure, but I have yet to figure out what that is.\r\n2) We should be defaulting to cygwin make rather than mingw make. We call out to shell in a few places in the makefile, and if we're running the makefile with mingw make, these shell calls don't really do anything, or they just spin. It's also simpler to default to cygwin make and override with mingw make if the need arrises.","created_at":"2015-12-21T18:31:34Z","updated_at":"2016-01-04T19:37:30Z","closed_at":"2016-01-04T19:37:30Z","merged_at":"2016-01-04T19:37:30Z","merge_commit_sha":"2f1c48c4470b8669d25feb6d0b52d6ef8c3f1d4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/461/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/461/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/461/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/279534522f3b254aa7807edd33bb284ef376b469","head":{"label":"melissa:ticket/vanagon_for_the_win/RE-5733-build-ruby-on-windows","ref":"ticket/vanagon_for_the_win/RE-5733-build-ruby-on-windows","sha":"279534522f3b254aa7807edd33bb284ef376b469","user":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"repo":{"id":48144163,"name":"puppet-agent","full_name":"melissa/puppet-agent","owner":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melissa/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":true,"url":"https://api.github.com/repos/melissa/puppet-agent","forks_url":"https://api.github.com/repos/melissa/puppet-agent/forks","keys_url":"https://api.github.com/repos/melissa/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melissa/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melissa/puppet-agent/teams","hooks_url":"https://api.github.com/repos/melissa/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/melissa/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/melissa/puppet-agent/events","assignees_url":"https://api.github.com/repos/melissa/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/melissa/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/melissa/puppet-agent/tags","blobs_url":"https://api.github.com/repos/melissa/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melissa/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melissa/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/melissa/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melissa/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/melissa/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/melissa/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/melissa/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/melissa/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/melissa/puppet-agent/subscription","commits_url":"https://api.github.com/repos/melissa/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/melissa/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/melissa/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/melissa/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/melissa/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/melissa/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melissa/puppet-agent/merges","archive_url":"https://api.github.com/repos/melissa/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melissa/puppet-agent/downloads","issues_url":"https://api.github.com/repos/melissa/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/melissa/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/melissa/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/melissa/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melissa/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/melissa/puppet-agent/releases{/id}","created_at":"2015-12-17T01:07:40Z","updated_at":"2015-12-17T01:07:41Z","pushed_at":"2016-01-04T18:46:59Z","git_url":"git://github.com/melissa/puppet-agent.git","ssh_url":"git@github.com:melissa/puppet-agent.git","clone_url":"https://github.com/melissa/puppet-agent.git","svn_url":"https://github.com/melissa/puppet-agent","homepage":null,"size":3199,"stargazers_count":0,"watchers_count":0,"language":"Groff","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:feature/master/windows-vanagon-development","ref":"feature/master/windows-vanagon-development","sha":"30828cf0afeb520c4d7f448fb3ecc63c6f35b57a","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":26777895,"name":"puppet-agent","full_name":"puppetlabs/puppet-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-agent","forks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-agent/releases{/id}","created_at":"2014-11-17T21:23:08Z","updated_at":"2015-12-17T06:42:14Z","pushed_at":"2016-01-04T19:37:30Z","git_url":"git://github.com/puppetlabs/puppet-agent.git","ssh_url":"git@github.com:puppetlabs/puppet-agent.git","clone_url":"https://github.com/puppetlabs/puppet-agent.git","svn_url":"https://github.com/puppetlabs/puppet-agent","homepage":null,"size":3357,"stargazers_count":3,"watchers_count":3,"language":"Groff","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":2,"forks":18,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/461"},"html":{"href":"https://github.com/puppetlabs/puppet-agent/pull/461"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/461"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/279534522f3b254aa7807edd33bb284ef376b469"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stahnma","id":6961,"avatar_url":"https://avatars.githubusercontent.com/u/6961?v=3","gravatar_id":"","url":"https://api.github.com/users/stahnma","html_url":"https://github.com/stahnma","followers_url":"https://api.github.com/users/stahnma/followers","following_url":"https://api.github.com/users/stahnma/following{/other_user}","gists_url":"https://api.github.com/users/stahnma/gists{/gist_id}","starred_url":"https://api.github.com/users/stahnma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahnma/subscriptions","organizations_url":"https://api.github.com/users/stahnma/orgs","repos_url":"https://api.github.com/users/stahnma/repos","events_url":"https://api.github.com/users/stahnma/events{/privacy}","received_events_url":"https://api.github.com/users/stahnma/received_events","type":"User","site_admin":false},"comments":6,"review_comments":10,"commits":5,"additions":13724,"deletions":27,"changed_files":23}}