{"action":"closed","issue":{"url":"https://api.github.com/repos/peter-gribanov/sphinx-php-client/issues/1","repository_url":"https://api.github.com/repos/peter-gribanov/sphinx-php-client","labels_url":"https://api.github.com/repos/peter-gribanov/sphinx-php-client/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/peter-gribanov/sphinx-php-client/issues/1/comments","events_url":"https://api.github.com/repos/peter-gribanov/sphinx-php-client/issues/1/events","html_url":"https://github.com/peter-gribanov/sphinx-php-client/issues/1","id":145732457,"number":1,"title":"[Insight] Global variable or function should never be used - in src/SphinxClient.php, line 141","user":{"login":"peter-gribanov","id":1954436,"avatar_url":"https://avatars.githubusercontent.com/u/1954436?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-gribanov","html_url":"https://github.com/peter-gribanov","followers_url":"https://api.github.com/users/peter-gribanov/followers","following_url":"https://api.github.com/users/peter-gribanov/following{/other_user}","gists_url":"https://api.github.com/users/peter-gribanov/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gribanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gribanov/subscriptions","organizations_url":"https://api.github.com/users/peter-gribanov/orgs","repos_url":"https://api.github.com/users/peter-gribanov/repos","events_url":"https://api.github.com/users/peter-gribanov/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gribanov/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-04-04T16:18:04Z","updated_at":"2016-04-05T11:17:17Z","closed_at":"2016-04-05T11:17:17Z","body":"**[in src/SphinxClient.php, line 141](https://github.com/peter-gribanov/sphinx-php-client/blob/0dda59f267a90007c5ecc9978f9168b24ce1bfc9/src/SphinxClient.php#L141)**\r\n\r\n> `sphPackI64()` adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.\r\n\r\n```php\r\n// unpacking routines are pretty much the same.\r\n//  - return ints if we can\r\n//  - otherwise format number into a string\r\n\r\n/// pack 64-bit signed\r\nfunction sphPackI64($v)\r\n{\r\n    assert(is_numeric($v));\r\n\r\n    // x64\r\n    if (PHP_INT_SIZE >= 8) {\r\n```\r\n\r\n---------------------\r\n\r\n_Posted from [SensioLabsInsight](https://insight.sensiolabs.com/projects/b370b11f-f70f-421c-b2d8-e7411b74bb33/analyses/8)_"}}