{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/85749333","pull_request_review_id":6446150,"id":85749333,"diff_hunk":"@@ -23,9 +23,30 @@ import groovy.transform.EqualsAndHashCode\n @EqualsAndHashCode(excludes=\"backends\")\n class GoogleBackendService {\n   String name\n+  String region\n+\n+  /**\n+   * Specifies the GCP endpoint 'family' this backend service originated from.\n+   *\n+   * There are currently two different sets of backend service endpoints:\n+   * 1. /{project}/global/backendServices/{backendServiceName}\n+   * 2. /{project}/regions/{region}/backendServices/{backendServiceName}\n+   *\n+   * Since we cache BackendService objects from both endpoints, we need to distinguish\n+   * between the two 'kinds'. That's what this field does.\n+   */\n+  BackendServiceKind kind\n+  String healthCheckLink\n   GoogleHealthCheck healthCheck\n   List<GoogleLoadBalancedBackend> backends\n   GoogleSessionAffinity sessionAffinity\n   Integer affinityCookieTtlSec\n   GoogleLoadBalancingScheme loadBalancingScheme\n+\n+  // Note: This enum has non-standard style constants because we use these constants as strings directly\n+  // in the redis cache keys for backend services, where we want to avoid underscores and camelcase is the norm.\n+  static enum BackendServiceKind {\n+    backendService,","path":"clouddriver-google/src/main/groovy/com/netflix/spinnaker/clouddriver/google/model/loadbalancing/GoogleBackendService.groovy","position":27,"original_position":27,"commit_id":"f6adff9bc918521247e317b44fe12a6cd6a44e54","original_commit_id":"f6adff9bc918521247e317b44fe12a6cd6a44e54","user":{"login":"duftler","id":8437718,"avatar_url":"https://avatars.githubusercontent.com/u/8437718?v=3","gravatar_id":"","url":"https://api.github.com/users/duftler","html_url":"https://github.com/duftler","followers_url":"https://api.github.com/users/duftler/followers","following_url":"https://api.github.com/users/duftler/following{/other_user}","gists_url":"https://api.github.com/users/duftler/gists{/gist_id}","starred_url":"https://api.github.com/users/duftler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duftler/subscriptions","organizations_url":"https://api.github.com/users/duftler/orgs","repos_url":"https://api.github.com/users/duftler/repos","events_url":"https://api.github.com/users/duftler/events{/privacy}","received_events_url":"https://api.github.com/users/duftler/received_events","type":"User","site_admin":false},"body":"Would these be better-named as `globalBackendService` and `regionalBackendService`? I know the platform api uses `regionBackendService`, but it still sounds funny.","created_at":"2016-10-31T14:30:35Z","updated_at":"2016-10-31T14:30:44Z","html_url":"https://github.com/spinnaker/clouddriver/pull/1179#discussion_r85749333","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/85749333"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/1179#discussion_r85749333"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179","id":91429333,"html_url":"https://github.com/spinnaker/clouddriver/pull/1179","diff_url":"https://github.com/spinnaker/clouddriver/pull/1179.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/1179.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/1179","number":1179,"state":"open","locked":false,"title":"provider/google: Separate Redis keyspaces for backendServices and reg…","user":{"login":"jtk54","id":5456773,"avatar_url":"https://avatars.githubusercontent.com/u/5456773?v=3","gravatar_id":"","url":"https://api.github.com/users/jtk54","html_url":"https://github.com/jtk54","followers_url":"https://api.github.com/users/jtk54/followers","following_url":"https://api.github.com/users/jtk54/following{/other_user}","gists_url":"https://api.github.com/users/jtk54/gists{/gist_id}","starred_url":"https://api.github.com/users/jtk54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtk54/subscriptions","organizations_url":"https://api.github.com/users/jtk54/orgs","repos_url":"https://api.github.com/users/jtk54/repos","events_url":"https://api.github.com/users/jtk54/events{/privacy}","received_events_url":"https://api.github.com/users/jtk54/received_events","type":"User","site_admin":false},"body":"…ionBackendServices.\n\nAlso added a 'kind' attribute to GoogleBackendService to distinguish between the API families. @duftler @danielpeach please review.\n","created_at":"2016-10-28T18:31:04Z","updated_at":"2016-10-31T14:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7c482c36f355681e433404e9ed8bfbe0bb6ad8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/1179/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/f6adff9bc918521247e317b44fe12a6cd6a44e54","head":{"label":"jtk54:bs-keyspace","ref":"bs-keyspace","sha":"f6adff9bc918521247e317b44fe12a6cd6a44e54","user":{"login":"jtk54","id":5456773,"avatar_url":"https://avatars.githubusercontent.com/u/5456773?v=3","gravatar_id":"","url":"https://api.github.com/users/jtk54","html_url":"https://github.com/jtk54","followers_url":"https://api.github.com/users/jtk54/followers","following_url":"https://api.github.com/users/jtk54/following{/other_user}","gists_url":"https://api.github.com/users/jtk54/gists{/gist_id}","starred_url":"https://api.github.com/users/jtk54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtk54/subscriptions","organizations_url":"https://api.github.com/users/jtk54/orgs","repos_url":"https://api.github.com/users/jtk54/repos","events_url":"https://api.github.com/users/jtk54/events{/privacy}","received_events_url":"https://api.github.com/users/jtk54/received_events","type":"User","site_admin":false},"repo":{"id":54126367,"name":"clouddriver","full_name":"jtk54/clouddriver","owner":{"login":"jtk54","id":5456773,"avatar_url":"https://avatars.githubusercontent.com/u/5456773?v=3","gravatar_id":"","url":"https://api.github.com/users/jtk54","html_url":"https://github.com/jtk54","followers_url":"https://api.github.com/users/jtk54/followers","following_url":"https://api.github.com/users/jtk54/following{/other_user}","gists_url":"https://api.github.com/users/jtk54/gists{/gist_id}","starred_url":"https://api.github.com/users/jtk54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtk54/subscriptions","organizations_url":"https://api.github.com/users/jtk54/orgs","repos_url":"https://api.github.com/users/jtk54/repos","events_url":"https://api.github.com/users/jtk54/events{/privacy}","received_events_url":"https://api.github.com/users/jtk54/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtk54/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/jtk54/clouddriver","forks_url":"https://api.github.com/repos/jtk54/clouddriver/forks","keys_url":"https://api.github.com/repos/jtk54/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtk54/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtk54/clouddriver/teams","hooks_url":"https://api.github.com/repos/jtk54/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/jtk54/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/jtk54/clouddriver/events","assignees_url":"https://api.github.com/repos/jtk54/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/jtk54/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/jtk54/clouddriver/tags","blobs_url":"https://api.github.com/repos/jtk54/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtk54/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtk54/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtk54/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtk54/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/jtk54/clouddriver/languages","stargazers_url":"https://api.github.com/repos/jtk54/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/jtk54/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/jtk54/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/jtk54/clouddriver/subscription","commits_url":"https://api.github.com/repos/jtk54/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtk54/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtk54/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtk54/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtk54/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/jtk54/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtk54/clouddriver/merges","archive_url":"https://api.github.com/repos/jtk54/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtk54/clouddriver/downloads","issues_url":"https://api.github.com/repos/jtk54/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/jtk54/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/jtk54/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/jtk54/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtk54/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/jtk54/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/jtk54/clouddriver/deployments","created_at":"2016-03-17T14:52:27Z","updated_at":"2016-03-17T14:52:32Z","pushed_at":"2016-10-31T13:02:09Z","git_url":"git://github.com/jtk54/clouddriver.git","ssh_url":"git@github.com:jtk54/clouddriver.git","clone_url":"https://github.com/jtk54/clouddriver.git","svn_url":"https://github.com/jtk54/clouddriver","homepage":null,"size":29313,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"b5c7b6c02cb7a98ff04972188d1c18bf057a5630","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2016-10-27T02:55:52Z","pushed_at":"2016-10-31T13:53:18Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":31722,"stargazers_count":68,"watchers_count":68,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":11,"forks":113,"open_issues":11,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/1179"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/1179"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/1179/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/1179/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/f6adff9bc918521247e317b44fe12a6cd6a44e54"}}}}
{"actor":{"display_login":"duftler"}}