{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/dex/issues/758","repository_url":"https://api.github.com/repos/coreos/dex","labels_url":"https://api.github.com/repos/coreos/dex/issues/758/labels{/name}","comments_url":"https://api.github.com/repos/coreos/dex/issues/758/comments","events_url":"https://api.github.com/repos/coreos/dex/issues/758/events","html_url":"https://github.com/coreos/dex/pull/758","id":197304005,"number":758,"title":"connector/ldap: don't query for groups if no base DN is provided","user":{"login":"ericchiang","id":2342749,"avatar_url":"https://avatars.githubusercontent.com/u/2342749?v=3","gravatar_id":"","url":"https://api.github.com/users/ericchiang","html_url":"https://github.com/ericchiang","followers_url":"https://api.github.com/users/ericchiang/followers","following_url":"https://api.github.com/users/ericchiang/following{/other_user}","gists_url":"https://api.github.com/users/ericchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchiang/subscriptions","organizations_url":"https://api.github.com/users/ericchiang/orgs","repos_url":"https://api.github.com/users/ericchiang/repos","events_url":"https://api.github.com/users/ericchiang/events{/privacy}","received_events_url":"https://api.github.com/users/ericchiang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-23T02:34:50Z","updated_at":"2016-12-27T15:46:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/dex/pulls/758","html_url":"https://github.com/coreos/dex/pull/758","diff_url":"https://github.com/coreos/dex/pull/758.diff","patch_url":"https://github.com/coreos/dex/pull/758.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/coreos/dex/issues/comments/269342754","html_url":"https://github.com/coreos/dex/pull/758#issuecomment-269342754","issue_url":"https://api.github.com/repos/coreos/dex/issues/758","id":269342754,"user":{"login":"ericchiang","id":2342749,"avatar_url":"https://avatars.githubusercontent.com/u/2342749?v=3","gravatar_id":"","url":"https://api.github.com/users/ericchiang","html_url":"https://github.com/ericchiang","followers_url":"https://api.github.com/users/ericchiang/followers","following_url":"https://api.github.com/users/ericchiang/following{/other_user}","gists_url":"https://api.github.com/users/ericchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchiang/subscriptions","organizations_url":"https://api.github.com/users/ericchiang/orgs","repos_url":"https://api.github.com/users/ericchiang/repos","events_url":"https://api.github.com/users/ericchiang/events{/privacy}","received_events_url":"https://api.github.com/users/ericchiang/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T15:46:00Z","updated_at":"2016-12-27T15:46:00Z","body":"You're right, we should probably bump the level to debug and print the\nuser's email. @rithujohn191 want to open a PR  with that? (Sonce I'm out)\n\nOn Dec 27, 2016 4:26 PM, \"Brandon Philips\" <notifications@github.com> wrote:\n\n> *@philips* commented on this pull request.\n> ------------------------------\n>\n> In connector/ldap/ldap.go\n> <https://github.com/coreos/dex/pull/758#pullrequestreview-14472477>:\n>\n> > @@ -445,6 +445,11 @@ func (c *ldapConnector) Refresh(ctx context.Context, s connector.Scopes, ident c\n>  }\n>\n>  func (c *ldapConnector) groups(ctx context.Context, user ldap.Entry) ([]string, error) {\n> +\tif c.GroupSearch.BaseDN == \"\" {\n> +\t\tc.logger.Infof(\"groups requested but no baseDN provided\")\n>\n> What would a support person or user do with this information and how they\n> would find information to rectify if this is not their desired\n> configuration? Perhaps:\n>\n> \"No groups returned for ${username} because no groups baseDN has been\n> configured\"\n>\n> Plus, how often will this log line be printed out? On every login?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/coreos/dex/pull/758#pullrequestreview-14472477>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/ACO_XbHGbDFzXupg-LqIlzUIJEVud2I6ks5rMS44gaJpZM4LUiRv>\n> .\n>\n"}}
{"actor":{"display_login":"ericchiang"}}