{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-app-ios/issues/848","repository_url":"https://api.github.com/repos/edx/edx-app-ios","labels_url":"https://api.github.com/repos/edx/edx-app-ios/issues/848/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/issues/848/comments","events_url":"https://api.github.com/repos/edx/edx-app-ios/issues/848/events","html_url":"https://github.com/edx/edx-app-ios/pull/848","id":186743420,"number":848,"title":"Proposal to add filledSecondaryButtonStyle","user":{"login":"jagonzalr","id":3858265,"avatar_url":"https://avatars.githubusercontent.com/u/3858265?v=3","gravatar_id":"","url":"https://api.github.com/users/jagonzalr","html_url":"https://github.com/jagonzalr","followers_url":"https://api.github.com/users/jagonzalr/followers","following_url":"https://api.github.com/users/jagonzalr/following{/other_user}","gists_url":"https://api.github.com/users/jagonzalr/gists{/gist_id}","starred_url":"https://api.github.com/users/jagonzalr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagonzalr/subscriptions","organizations_url":"https://api.github.com/users/jagonzalr/orgs","repos_url":"https://api.github.com/users/jagonzalr/repos","events_url":"https://api.github.com/users/jagonzalr/events{/privacy}","received_events_url":"https://api.github.com/users/jagonzalr/received_events","type":"User","site_admin":false},"labels":[{"id":252538896,"url":"https://api.github.com/repos/edx/edx-app-ios/labels/awaiting%20prioritization","name":"awaiting prioritization","color":"fad8c7","default":false},{"id":252538929,"url":"https://api.github.com/repos/edx/edx-app-ios/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-02T08:55:56Z","updated_at":"2016-11-04T04:17:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-ios/pulls/848","html_url":"https://github.com/edx/edx-app-ios/pull/848","diff_url":"https://github.com/edx/edx-app-ios/pull/848.diff","patch_url":"https://github.com/edx/edx-app-ios/pull/848.patch"},"body":"### Description\r\n\r\n[OSPR-1552](https://openedx.atlassian.net/browse/OSPR-1552)\r\n\r\nThis has already been close in this [PR](https://github.com/edx/edx-app-ios/pull/833). But maybe think about it after seeing the attach images.\r\n\r\n![screenshot 2016-11-02 10 04 59](https://cloud.githubusercontent.com/assets/3858265/19922122/db43203a-a0e9-11e6-943d-6b099495777d.png)\r\n\r\n![screenshot 2016-11-02 09 41 39](https://cloud.githubusercontent.com/assets/3858265/19922123/dcd706aa-a0e9-11e6-8dc5-219ac560bc98.png)\r\n\r\nI don't know about you guys but for me it looks better in the second image using filledSecondaryButtonStyle. This is only a convenience method but it can help make some UI changes quicker.\r\n\r\nHope you guys give it some thought (and don't close it because ¯(ツ)/¯).\r\n\r\n### Reviewers\r\n\r\nIf you've been tagged for review, please check your corresponding box once you've given the 👍\r\n- [ ] Code review: @danialzahid94 \r\n- [ ] Code review: @BenjiLee \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-app-ios/issues/comments/258341651","html_url":"https://github.com/edx/edx-app-ios/pull/848#issuecomment-258341651","issue_url":"https://api.github.com/repos/edx/edx-app-ios/issues/848","id":258341651,"user":{"login":"saeedbashir","id":5606473,"avatar_url":"https://avatars.githubusercontent.com/u/5606473?v=3","gravatar_id":"","url":"https://api.github.com/users/saeedbashir","html_url":"https://github.com/saeedbashir","followers_url":"https://api.github.com/users/saeedbashir/followers","following_url":"https://api.github.com/users/saeedbashir/following{/other_user}","gists_url":"https://api.github.com/users/saeedbashir/gists{/gist_id}","starred_url":"https://api.github.com/users/saeedbashir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeedbashir/subscriptions","organizations_url":"https://api.github.com/users/saeedbashir/orgs","repos_url":"https://api.github.com/users/saeedbashir/repos","events_url":"https://api.github.com/users/saeedbashir/events{/privacy}","received_events_url":"https://api.github.com/users/saeedbashir/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T04:17:57Z","updated_at":"2016-11-04T04:17:57Z","body":"@marcotuts In that case, instead of writing down a method for each color we can take color as param and use that as filler color. "}}
{"actor":{"display_login":"saeedbashir"}}