{"action":"created","issue":{"url":"https://api.github.com/repos/bleroy/minecraft.client/issues/16","repository_url":"https://api.github.com/repos/bleroy/minecraft.client","labels_url":"https://api.github.com/repos/bleroy/minecraft.client/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/bleroy/minecraft.client/issues/16/comments","events_url":"https://api.github.com/repos/bleroy/minecraft.client/issues/16/events","html_url":"https://github.com/bleroy/minecraft.client/issues/16","id":191802802,"number":16,"title":"BlockType, enums, IDs and mods.","user":{"login":"Flosus","id":4223452,"avatar_url":"https://avatars.githubusercontent.com/u/4223452?v=3","gravatar_id":"","url":"https://api.github.com/users/Flosus","html_url":"https://github.com/Flosus","followers_url":"https://api.github.com/users/Flosus/followers","following_url":"https://api.github.com/users/Flosus/following{/other_user}","gists_url":"https://api.github.com/users/Flosus/gists{/gist_id}","starred_url":"https://api.github.com/users/Flosus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flosus/subscriptions","organizations_url":"https://api.github.com/users/Flosus/orgs","repos_url":"https://api.github.com/users/Flosus/repos","events_url":"https://api.github.com/users/Flosus/events{/privacy}","received_events_url":"https://api.github.com/users/Flosus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-26T12:04:42Z","updated_at":"2016-11-27T01:40:19Z","closed_at":null,"body":"Let's talk about enums first.\r\n\r\nThe current implementation uses an enum for differentiate block types. This prevents adding new Blocks added from mods. While the current implementation supports modded blocks by declaring them as UnknownBlocks it will stop working if the server uses to many mods, because the IDs get parsed as byte. \r\n\r\n\r\nLet's talk about IDs next\r\n\r\nI know that the use of BlockIDs comes from the way the raspberryjammod is [made](https://github.com/arpruss/raspberryjammod/blob/master/src/main/java/mobi/omegacentauri/raspberryjammod/APIHandler.java#L255). I want to raise the attention to the fact that this is not the way minecraft (and forge) are handling block (and item) registration. They use unique item and block names to register them. The problem with IDs is, that they can change from gameworld to gameworld. IDs have to get handled out separately for every connection. On one server an ID can be a IronChest, on an other server it could be a BuildCraft pipe.\r\n\r\nI hope i could show my concerns. I'm currently thinking about a ways to solve this problem. I wanted to raise attention to this problem now, because we are in an early state and I want to avoid having a big problem later on."},"comment":{"url":"https://api.github.com/repos/bleroy/minecraft.client/issues/comments/263096848","html_url":"https://github.com/bleroy/minecraft.client/issues/16#issuecomment-263096848","issue_url":"https://api.github.com/repos/bleroy/minecraft.client/issues/16","id":263096848,"user":{"login":"bleroy","id":1165609,"avatar_url":"https://avatars.githubusercontent.com/u/1165609?v=3","gravatar_id":"","url":"https://api.github.com/users/bleroy","html_url":"https://github.com/bleroy","followers_url":"https://api.github.com/users/bleroy/followers","following_url":"https://api.github.com/users/bleroy/following{/other_user}","gists_url":"https://api.github.com/users/bleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/bleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleroy/subscriptions","organizations_url":"https://api.github.com/users/bleroy/orgs","repos_url":"https://api.github.com/users/bleroy/repos","events_url":"https://api.github.com/users/bleroy/events{/privacy}","received_events_url":"https://api.github.com/users/bleroy/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T01:40:19Z","updated_at":"2016-11-27T01:40:19Z","body":"OK, sounds like this will be better done early, yes."}}
{"actor":{"display_login":"bleroy"}}