{"action":"created","issue":{"url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/315","repository_url":"https://api.github.com/repos/backdrop/backdrop-issues","labels_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/315/comments","events_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/315/events","html_url":"https://github.com/backdrop/backdrop-issues/issues/315","id":41345881,"number":315,"title":"Add the \"Entity view mode\" module to core","user":{"login":"jenlampton","id":397895,"avatar_url":"https://avatars.githubusercontent.com/u/397895?v=3","gravatar_id":"","url":"https://api.github.com/users/jenlampton","html_url":"https://github.com/jenlampton","followers_url":"https://api.github.com/users/jenlampton/followers","following_url":"https://api.github.com/users/jenlampton/following{/other_user}","gists_url":"https://api.github.com/users/jenlampton/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlampton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlampton/subscriptions","organizations_url":"https://api.github.com/users/jenlampton/orgs","repos_url":"https://api.github.com/users/jenlampton/repos","events_url":"https://api.github.com/users/jenlampton/events{/privacy}","received_events_url":"https://api.github.com/users/jenlampton/received_events","type":"User","site_admin":false},"labels":[{"id":159653605,"url":"https://api.github.com/repos/backdrop/backdrop-issues/labels/pr%20-%20needs%20review","name":"pr - needs review","color":"FFFFDD","default":false},{"id":56068268,"url":"https://api.github.com/repos/backdrop/backdrop-issues/labels/status%20-%20has%20pull%20request","name":"status - has pull request","color":"d4c5f9","default":false},{"id":54904569,"url":"https://api.github.com/repos/backdrop/backdrop-issues/labels/type%20-%20feature%20request","name":"type - feature request","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/backdrop/backdrop-issues/milestones/34","html_url":"https://github.com/backdrop/backdrop-issues/milestone/34","labels_url":"https://api.github.com/repos/backdrop/backdrop-issues/milestones/34/labels","id":1953287,"number":34,"title":"1.6.0","description":"","creator":{"login":"jenlampton","id":397895,"avatar_url":"https://avatars.githubusercontent.com/u/397895?v=3","gravatar_id":"","url":"https://api.github.com/users/jenlampton","html_url":"https://github.com/jenlampton","followers_url":"https://api.github.com/users/jenlampton/followers","following_url":"https://api.github.com/users/jenlampton/following{/other_user}","gists_url":"https://api.github.com/users/jenlampton/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlampton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlampton/subscriptions","organizations_url":"https://api.github.com/users/jenlampton/orgs","repos_url":"https://api.github.com/users/jenlampton/repos","events_url":"https://api.github.com/users/jenlampton/events{/privacy}","received_events_url":"https://api.github.com/users/jenlampton/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":5,"state":"open","created_at":"2016-08-21T00:44:06Z","updated_at":"2016-12-23T04:20:56Z","due_on":"2017-01-15T08:00:00Z","closed_at":null},"comments":117,"created_at":"2014-08-28T00:49:19Z","updated_at":"2016-12-23T17:31:32Z","closed_at":null,"body":"This simple module provides a lightweight UI for adding additional view modes, and provides expected template suggestion hooks.  [https://www.drupal.org/project/entity_view_mode](https://www.drupal.org/project/entity_view_mode)\r\n\r\n---\r\n~~PR by @docwilmot: https://github.com/backdrop/backdrop/pull/1645 initial port~~\r\nPR by @jenlampton https://github.com/backdrop/backdrop/pull/1670 remove view-mode tabs\r\nLatest PR by @jenlampton https://github.com/backdrop/backdrop/pull/1689 moves  customize to Add view mode form"},"comment":{"url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/comments/269021963","html_url":"https://github.com/backdrop/backdrop-issues/issues/315#issuecomment-269021963","issue_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/315","id":269021963,"user":{"login":"jenlampton","id":397895,"avatar_url":"https://avatars.githubusercontent.com/u/397895?v=3","gravatar_id":"","url":"https://api.github.com/users/jenlampton","html_url":"https://github.com/jenlampton","followers_url":"https://api.github.com/users/jenlampton/followers","following_url":"https://api.github.com/users/jenlampton/following{/other_user}","gists_url":"https://api.github.com/users/jenlampton/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlampton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlampton/subscriptions","organizations_url":"https://api.github.com/users/jenlampton/orgs","repos_url":"https://api.github.com/users/jenlampton/repos","events_url":"https://api.github.com/users/jenlampton/events{/privacy}","received_events_url":"https://api.github.com/users/jenlampton/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T17:31:31Z","updated_at":"2016-12-23T17:31:31Z","body":"> I'd prefer however to return to the approach of @docwilmot and @klonos with two different tables similar to Layouts: #315 (comment). \r\n\r\nThere's never been an approach with two tables. Both layouts and the earlier PR used one table with multiple header rows.\r\n\r\n> The only objection to this approach was against the second header row, but we knew then that it is a common pattern.\r\n\r\nThe REAL objection to that problem is that it shows the `Full content` view mode to users who do not need to use it (but will use it mistakenly if they can see it). This is a UX regression from before this PR - we will be creating an interface that naturally drives users to do the wrong thing.\r\n\r\nThe duplicate headers is not really an issue, just an oddity. :)\r\n\r\n> In yesterday's video meeting, it was also mentioned that if you add like 86 view modes to your blog content type, it's really strange to also see those (disabled) in other content types.\r\n\r\n👍   I forgot about this, thanks @MrHaroldA \r\n\r\n> I don't like hiding the existing View modes either; this would only serve to reinforce the impression that they are disabled or dont exist, which is an error most people make already.\r\n\r\nThis certainly isn't great - but it is a problem we already have today. We at least would not be introducing a UX regression, just maintaining an existing problem (and something people already know to work around).  I'd rather stick to UX problems people know than introduce new UX problems people need to learn :)\r\n\r\n> It would also be strange to create a new View mode, as uncustomized and have it not show anywhere in the UI. \r\n\r\nThis is not the case. When you create a new view mode, after you you hit \"save\" the new view mode immediately appears (ready to `Manage display`) on the following page. \r\n\r\n> If we choose that approach, we should at least rename the action link to something like \"Add or customize view mode\".\r\n\r\nLet me make this change and see if you like it better :)"}}
{"actor":{"display_login":"jenlampton"}}