{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/13019","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13019/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13019/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13019/events","html_url":"https://github.com/joomla/joomla-cms/pull/13019","id":191767523,"number":13019,"title":"Refactoring com_fields to no longer use com_categories","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.7.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14/labels","id":1750036,"number":14,"title":"Joomla 3.7.0","description":"","creator":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":370,"state":"open","created_at":"2016-05-05T16:42:34Z","updated_at":"2016-11-25T21:38:41Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-11-25T21:38:23Z","updated_at":"2016-11-25T22:22:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13019","html_url":"https://github.com/joomla/joomla-cms/pull/13019","diff_url":"https://github.com/joomla/joomla-cms/pull/13019.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13019.patch"},"body":"This is a bigger refactoring of com_fields to get rid of the use of com_categories for its field groups (fieldset) feature.\r\n\r\nDuring the rewrite I found also several code pieces which are unused or were copy-pasted from com_categories but don't make sense in the context of fields.\r\nI also replaced the useage of some deprecated methods.\r\n\r\nSo forgive me that it become a bit bigger than initially planned 😄 \r\n\r\n### Summary of Changes\r\n* Main thing is that the field groups are now handled in com_fields using own views.\r\n* ACL **should** work now at least better than before.\r\n\r\n### Testing Instructions\r\n* Make sure managing the fields and groups works\r\n* Also test that the fields appear as expected. You don't have to test the indivual field types as I haven't changed anything there.\r\n* Please also test ACL. It **should** inherit permissions from component to field group to field. I haven't had the time yet to test that myself but in theory the code should work.\r\n\r\n### Documentation Changes Required\r\nIf there already is documentation how to implement com_fields into an extension, that will need to be adjusted.\r\n* Needs a helper method which returns possible contexts.\r\n* Needs added permission sections in the access.xml file."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/263028125","html_url":"https://github.com/joomla/joomla-cms/pull/13019#issuecomment-263028125","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13019","id":263028125,"user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T22:22:04Z","updated_at":"2016-11-25T22:22:04Z","body":"Actually that is intented behaviour, but something which can be discussed if we want it or not.\r\nThe dropdown would allow to switch between the extensions that support custom fields. It takes the contexts from the extensions helper method. The sidebar automatically adjusts to the selected extension.\r\n\r\nThe URL doesn't need the context/extension anymore after it is initially set. So if you click the link in the sidebar, you see the extension/context in the URL. It will then set the userstate and from there on it's not needed anymore. If you use the dropdown, the extension/context will be sent in the form (POST) and not in the URL (GET). So that is fine."}}
{"actor":{"display_login":"Bakual"}}