{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/comments/86668865","pull_request_review_id":7317772,"id":86668865,"diff_hunk":"@@ -0,0 +1,100 @@\n+# -*- coding: utf-8 -*-\n+# Copyright 2016 LasLabs Inc.\n+# Copyright 2015 Serv. Tec. Avanzados - Pedro M. Baeza\n+# Copyright 2015 AvanzOsc\n+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).\n+\n+from openerp import api, fields, models\n+from openerp.addons import decimal_precision as dp\n+\n+\n+class ProductPackagingTemplate(models.Model):\n+    _name = 'product.packaging.template'\n+    _description = 'Product Packaging Template'\n+    _rec_name = 'packaging_template_name'\n+\n+    packaging_template_name = fields.Char(required=True)\n+    type = fields.Selection([","path":"stock_picking_package_info/models/product_packaging_template.py","position":17,"original_position":17,"commit_id":"2b6572f37cd01410b560573e13825137af9d8278","original_commit_id":"2b6572f37cd01410b560573e13825137af9d8278","user":{"login":"lasley","id":7397578,"avatar_url":"https://avatars.githubusercontent.com/u/7397578?v=3","gravatar_id":"","url":"https://api.github.com/users/lasley","html_url":"https://github.com/lasley","followers_url":"https://api.github.com/users/lasley/followers","following_url":"https://api.github.com/users/lasley/following{/other_user}","gists_url":"https://api.github.com/users/lasley/gists{/gist_id}","starred_url":"https://api.github.com/users/lasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasley/subscriptions","organizations_url":"https://api.github.com/users/lasley/orgs","repos_url":"https://api.github.com/users/lasley/repos","events_url":"https://api.github.com/users/lasley/events{/privacy}","received_events_url":"https://api.github.com/users/lasley/received_events","type":"User","site_admin":false},"body":"Builtin methods are technically a part of the `__builtins__` namespace though, so aren't reserved in all namespaces like keywords.\r\n'\r\nThat said, I'm good with the more descriptive term. I think `package_type` might fit better in the context though, but we can leave that to @t3ddftw to figure out 😛 ","created_at":"2016-11-05T16:43:29Z","updated_at":"2016-11-05T16:43:29Z","html_url":"https://github.com/OCA/stock-logistics-workflow/pull/247#discussion_r86668865","pull_request_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247","_links":{"self":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/comments/86668865"},"html":{"href":"https://github.com/OCA/stock-logistics-workflow/pull/247#discussion_r86668865"},"pull_request":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247","id":77885074,"html_url":"https://github.com/OCA/stock-logistics-workflow/pull/247","diff_url":"https://github.com/OCA/stock-logistics-workflow/pull/247.diff","patch_url":"https://github.com/OCA/stock-logistics-workflow/pull/247.patch","issue_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/issues/247","number":247,"state":"open","locked":false,"title":"[ADD][9.0] stock_picking_package_info","user":{"login":"lasley","id":7397578,"avatar_url":"https://avatars.githubusercontent.com/u/7397578?v=3","gravatar_id":"","url":"https://api.github.com/users/lasley","html_url":"https://github.com/lasley","followers_url":"https://api.github.com/users/lasley/followers","following_url":"https://api.github.com/users/lasley/following{/other_user}","gists_url":"https://api.github.com/users/lasley/gists{/gist_id}","starred_url":"https://api.github.com/users/lasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasley/subscriptions","organizations_url":"https://api.github.com/users/lasley/orgs","repos_url":"https://api.github.com/users/lasley/repos","events_url":"https://api.github.com/users/lasley/events{/privacy}","received_events_url":"https://api.github.com/users/lasley/received_events","type":"User","site_admin":false},"body":"This module displays in the picking_ids, all packages appearing in operations and\nthe package provides the following information:\n- Width\n- Height\n- Length\n- Total estimated weight\n- Total estimated net weight\n- Permitted volume\n- Total volume charge\n- Empty package weight\n- Real weight\n\nLogic was provided by @odoomrp, just upgraded to v9\n\nFew notes, making this a WIP if someone will please tag\n- Save for later method was removed & logic for `create_all_move_packages` was moved to the `process` method of the wizard. From that I can tell, this allows us to not need to save due to more streamlined v9 wizard, but I could be wrong and would love a comment from @pedrobaeza  on that 😉 \n- Tests are failing, and more need to be added\n","created_at":"2016-07-18T21:46:35Z","updated_at":"2016-11-05T16:43:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0941b6795307954836ad5d8ab340a25c6e455c3","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OCA/stock-logistics-workflow/milestones/1","html_url":"https://github.com/OCA/stock-logistics-workflow/milestones/9.0","labels_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/milestones/1/labels","id":1354407,"number":1,"title":"9.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2015-10-14T00:55:13Z","updated_at":"2016-10-19T08:51:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247/commits","review_comments_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247/comments","review_comment_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/issues/247/comments","statuses_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/statuses/2b6572f37cd01410b560573e13825137af9d8278","head":{"label":"laslabs:feature/9.0/LABS-193-migrate-stock_picking_package_info-to-9.0","ref":"feature/9.0/LABS-193-migrate-stock_picking_package_info-to-9.0","sha":"2b6572f37cd01410b560573e13825137af9d8278","user":{"login":"laslabs","id":13024740,"avatar_url":"https://avatars.githubusercontent.com/u/13024740?v=3","gravatar_id":"","url":"https://api.github.com/users/laslabs","html_url":"https://github.com/laslabs","followers_url":"https://api.github.com/users/laslabs/followers","following_url":"https://api.github.com/users/laslabs/following{/other_user}","gists_url":"https://api.github.com/users/laslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/laslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laslabs/subscriptions","organizations_url":"https://api.github.com/users/laslabs/orgs","repos_url":"https://api.github.com/users/laslabs/repos","events_url":"https://api.github.com/users/laslabs/events{/privacy}","received_events_url":"https://api.github.com/users/laslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":60886854,"name":"stock-logistics-workflow","full_name":"laslabs/stock-logistics-workflow","owner":{"login":"laslabs","id":13024740,"avatar_url":"https://avatars.githubusercontent.com/u/13024740?v=3","gravatar_id":"","url":"https://api.github.com/users/laslabs","html_url":"https://github.com/laslabs","followers_url":"https://api.github.com/users/laslabs/followers","following_url":"https://api.github.com/users/laslabs/following{/other_user}","gists_url":"https://api.github.com/users/laslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/laslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laslabs/subscriptions","organizations_url":"https://api.github.com/users/laslabs/orgs","repos_url":"https://api.github.com/users/laslabs/repos","events_url":"https://api.github.com/users/laslabs/events{/privacy}","received_events_url":"https://api.github.com/users/laslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laslabs/stock-logistics-workflow","description":"Odoo Stock, Workflow and Organization","fork":true,"url":"https://api.github.com/repos/laslabs/stock-logistics-workflow","forks_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/forks","keys_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/teams","hooks_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/hooks","issue_events_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/events","assignees_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/tags","blobs_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/languages","stargazers_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/stargazers","contributors_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/contributors","subscribers_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/subscribers","subscription_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/subscription","commits_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/merges","archive_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/downloads","issues_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/labels{/name}","releases_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/releases{/id}","deployments_url":"https://api.github.com/repos/laslabs/stock-logistics-workflow/deployments","created_at":"2016-06-11T02:11:45Z","updated_at":"2016-06-11T02:11:47Z","pushed_at":"2016-11-04T20:28:44Z","git_url":"git://github.com/laslabs/stock-logistics-workflow.git","ssh_url":"git@github.com:laslabs/stock-logistics-workflow.git","clone_url":"https://github.com/laslabs/stock-logistics-workflow.git","svn_url":"https://github.com/laslabs/stock-logistics-workflow","homepage":"","size":1943,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"OCA:9.0","ref":"9.0","sha":"4210357a97c57bd1a99209f497d801ab14c72298","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20891076,"name":"stock-logistics-workflow","full_name":"OCA/stock-logistics-workflow","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/stock-logistics-workflow","description":"Odoo Stock, Workflow and Organization","fork":false,"url":"https://api.github.com/repos/OCA/stock-logistics-workflow","forks_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/forks","keys_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/teams","hooks_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/hooks","issue_events_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/events","assignees_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/tags","blobs_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/languages","stargazers_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/stargazers","contributors_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/contributors","subscribers_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/subscribers","subscription_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/subscription","commits_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/merges","archive_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/downloads","issues_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/labels{/name}","releases_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/stock-logistics-workflow/deployments","created_at":"2014-06-16T16:00:29Z","updated_at":"2016-10-28T23:09:20Z","pushed_at":"2016-11-04T20:28:45Z","git_url":"git://github.com/OCA/stock-logistics-workflow.git","ssh_url":"git@github.com:OCA/stock-logistics-workflow.git","clone_url":"https://github.com/OCA/stock-logistics-workflow.git","svn_url":"https://github.com/OCA/stock-logistics-workflow","homepage":"","size":4734,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":55,"forks":130,"open_issues":55,"watchers":31,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247"},"html":{"href":"https://github.com/OCA/stock-logistics-workflow/pull/247"},"issue":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/issues/247"},"comments":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/stock-logistics-workflow/statuses/2b6572f37cd01410b560573e13825137af9d8278"}}}}
{"actor":{"display_login":"lasley"}}