{"action":"created","issue":{"url":"https://api.github.com/repos/bokmann/font-awesome-rails/issues/172","repository_url":"https://api.github.com/repos/bokmann/font-awesome-rails","labels_url":"https://api.github.com/repos/bokmann/font-awesome-rails/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/bokmann/font-awesome-rails/issues/172/comments","events_url":"https://api.github.com/repos/bokmann/font-awesome-rails/issues/172/events","html_url":"https://github.com/bokmann/font-awesome-rails/pull/172","id":157396201,"number":172,"title":"Added option 'size'","user":{"login":"kalashnikovisme","id":2001025,"avatar_url":"https://avatars.githubusercontent.com/u/2001025?v=3","gravatar_id":"","url":"https://api.github.com/users/kalashnikovisme","html_url":"https://github.com/kalashnikovisme","followers_url":"https://api.github.com/users/kalashnikovisme/followers","following_url":"https://api.github.com/users/kalashnikovisme/following{/other_user}","gists_url":"https://api.github.com/users/kalashnikovisme/gists{/gist_id}","starred_url":"https://api.github.com/users/kalashnikovisme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalashnikovisme/subscriptions","organizations_url":"https://api.github.com/users/kalashnikovisme/orgs","repos_url":"https://api.github.com/users/kalashnikovisme/repos","events_url":"https://api.github.com/users/kalashnikovisme/events{/privacy}","received_events_url":"https://api.github.com/users/kalashnikovisme/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-29T17:23:31Z","updated_at":"2016-05-29T18:07:47Z","closed_at":"2016-05-29T18:07:47Z","pull_request":{"url":"https://api.github.com/repos/bokmann/font-awesome-rails/pulls/172","html_url":"https://github.com/bokmann/font-awesome-rails/pull/172","diff_url":"https://github.com/bokmann/font-awesome-rails/pull/172.diff","patch_url":"https://github.com/bokmann/font-awesome-rails/pull/172.patch"},"body":"Now you can\r\n\r\n```\r\nfa_icon :facebook, size: 5\r\n```\r\n\r\n`fa_icon 'facebook 5x'` also available.\r\n\r\nShould I add this line\r\n\r\n```\r\nclasses.concat [\"fa-#{options.delete(:size)}x\"] if options[:size].present?\r\n```\r\n\r\nto `fa_stacked_icon` helper?"},"comment":{"url":"https://api.github.com/repos/bokmann/font-awesome-rails/issues/comments/222374180","html_url":"https://github.com/bokmann/font-awesome-rails/pull/172#issuecomment-222374180","issue_url":"https://api.github.com/repos/bokmann/font-awesome-rails/issues/172","id":222374180,"user":{"login":"rmm5t","id":740,"avatar_url":"https://avatars.githubusercontent.com/u/740?v=3","gravatar_id":"","url":"https://api.github.com/users/rmm5t","html_url":"https://github.com/rmm5t","followers_url":"https://api.github.com/users/rmm5t/followers","following_url":"https://api.github.com/users/rmm5t/following{/other_user}","gists_url":"https://api.github.com/users/rmm5t/gists{/gist_id}","starred_url":"https://api.github.com/users/rmm5t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmm5t/subscriptions","organizations_url":"https://api.github.com/users/rmm5t/orgs","repos_url":"https://api.github.com/users/rmm5t/repos","events_url":"https://api.github.com/users/rmm5t/events{/privacy}","received_events_url":"https://api.github.com/users/rmm5t/received_events","type":"User","site_admin":false},"created_at":"2016-05-29T18:07:47Z","updated_at":"2016-05-29T18:07:47Z","body":"I'm not sure I see a strong use-case for this extra option.\r\n\r\n```ruby\r\n# All of these existing options...\r\nfa_icon \"flag 5x\"\r\nfa_icon [\"flag\", \"5x\"]\r\nfa_icon %w(flag 5x)\r\n\r\n# ...are all more concise than this new :size new option\r\nfa_icon \"flag\", size: 5\r\n```\r\n\r\nIs there a use-case I'm not envisioning?\r\n\r\nAside, a pull-request like this for a new feature request requires new tests. Otherwise, it has about nil chance of getting pulled in.\r\n\r\nFurthermore, this fails to support the `fa-lg` size. http://fontawesome.io/examples/#larger"}}
{"actor":{"display_login":"rmm5t"}}