{"action":"created","issue":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/3219","repository_url":"https://api.github.com/repos/SeleniumHQ/selenium","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/3219/labels{/name}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/3219/comments","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/3219/events","html_url":"https://github.com/SeleniumHQ/selenium/pull/3219","id":194290050,"number":3219,"title":"Add support for net-http-persistent v3","user":{"login":"johnsyweb","id":39911,"avatar_url":"https://avatars.githubusercontent.com/u/39911?v=3","gravatar_id":"","url":"https://api.github.com/users/johnsyweb","html_url":"https://github.com/johnsyweb","followers_url":"https://api.github.com/users/johnsyweb/followers","following_url":"https://api.github.com/users/johnsyweb/following{/other_user}","gists_url":"https://api.github.com/users/johnsyweb/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsyweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsyweb/subscriptions","organizations_url":"https://api.github.com/users/johnsyweb/orgs","repos_url":"https://api.github.com/users/johnsyweb/repos","events_url":"https://api.github.com/users/johnsyweb/events{/privacy}","received_events_url":"https://api.github.com/users/johnsyweb/received_events","type":"User","site_admin":false},"labels":[{"id":182503883,"url":"https://api.github.com/repos/SeleniumHQ/selenium/labels/C-rb","name":"C-rb","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-08T09:48:30Z","updated_at":"2016-12-21T21:52:25Z","closed_at":"2016-12-21T20:58:33Z","pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/3219","html_url":"https://github.com/SeleniumHQ/selenium/pull/3219","diff_url":"https://github.com/SeleniumHQ/selenium/pull/3219.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/3219.patch"},"body":"- [x] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#step-6-sign-the-cla)\r\n\r\nContext\r\n-------\r\n\r\nWhen we did a routine `bundle update`, net-http-persistent jumped from\r\nv2.9.4 to v3.0.0. This major version change comes with a new\r\ninitializer with keyword arguments:\r\nhttps://github.com/drbrain/net-http-persistent/commit/5d4b76c22dd38d29b6fbc1ed700a2a1c78c5abc4#diff-9da42550715aa09be7174a0babadcad3R512\r\n\r\nThis results in errors like so:\r\n\r\n```\r\n     ArgumentError:\r\n       wrong number of arguments (2 for 0)\r\n     # ./vendor/bundle/ruby/2.2.0/gems/net-http-persistent-3.0.0/lib/net/http/persistent.rb:505:in `initialize'\r\n     # ./vendor/bundle/ruby/2.2.0/gems/selenium-webdriver-3.0.3/lib/selenium/webdriver/remote/http/persistent.rb:45:in `new'\r\n     # ./vendor/bundle/ruby/2.2.0/gems/selenium-webdriver-3.0.3/lib/selenium/webdriver/remote/http/persistent.rb:45:in `new_http_client'\r\n     # ./spec/support/selenium_custom_http_persisted_client.rb:37:in `new_http_client'\r\n     # ./vendor/bundle/ruby/2.2.0/gems/selenium-webdriver-3.0.3/lib/selenium/webdriver/remote/http/default.rb:35:in `http'\r\n     # ./vendor/bundle/ruby/2.2.0/gems/selenium-webdriver-3.0.3/lib/selenium/webdriver/remote/http/persistent.rb:49:in `response_for'\r\n     # ./vendor/bundle/ruby/2.2.0/gems/selenium-webdriver-3.0.3/lib/selenium/webdriver/remote/http/default.rb:57:in `request'\r\n     # ./spec/support/selenium_custom_http_persisted_client.rb:30:in `block in request'\r\n```\r\n\r\nChange\r\n------\r\n\r\nDetect the library version and choose the required initializer."},"comment":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments/268650609","html_url":"https://github.com/SeleniumHQ/selenium/pull/3219#issuecomment-268650609","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/3219","id":268650609,"user":{"login":"johnsyweb","id":39911,"avatar_url":"https://avatars.githubusercontent.com/u/39911?v=3","gravatar_id":"","url":"https://api.github.com/users/johnsyweb","html_url":"https://github.com/johnsyweb","followers_url":"https://api.github.com/users/johnsyweb/followers","following_url":"https://api.github.com/users/johnsyweb/following{/other_user}","gists_url":"https://api.github.com/users/johnsyweb/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsyweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsyweb/subscriptions","organizations_url":"https://api.github.com/users/johnsyweb/orgs","repos_url":"https://api.github.com/users/johnsyweb/repos","events_url":"https://api.github.com/users/johnsyweb/events{/privacy}","received_events_url":"https://api.github.com/users/johnsyweb/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T21:52:25Z","updated_at":"2016-12-21T21:52:25Z","body":"Thanks. "}}
{"actor":{"display_login":"johnsyweb"}}