{"action":"created","comment":{"url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/comments/82079823","pull_request_review_id":3011363,"id":82079823,"diff_hunk":"@@ -1,94 +1,110 @@\n ﻿using LeagueLib.Files;\n using System;\n+using System.Collections.Generic;\n+using System.IO;\n using System.Linq;\n using System.Text.RegularExpressions;\n+using Newtonsoft.Json;\n \n namespace LeagueSandbox.ContentSerializer\n {\n-    public class BaseContentConfiguration\n+    public class ContentConfiguration\n     {\n-        public virtual Regex[] ResourcePatterns { get; }\n-        public virtual string OutputDirectory { get; }\n-        public virtual string ConversionMapPath { get; }\n+        public Regex InputPattern { get; }\n+        public string OutputPattern { get; }\n+        public List<Regex> ResourcePatterns { get; }\n+        public FontConfigFile Localization { get; }\n+        public InibinConverter Converter { get; }\n \n-        public FontConfigFile Localization { get; private set; }\n-        public InibinConverter Converter { get; private set; }\n+        private List<Tuple<string, string>> NameFields = new List<Tuple<string,string>>","path":"ContentSerializer/ContentConfiguration.cs","position":25,"original_position":25,"commit_id":"2e09813bd47004619945e21b59abb0a26b5fb865","original_commit_id":"2e09813bd47004619945e21b59abb0a26b5fb865","user":{"login":"MythicManiac","id":8225825,"avatar_url":"https://avatars.githubusercontent.com/u/8225825?v=3","gravatar_id":"","url":"https://api.github.com/users/MythicManiac","html_url":"https://github.com/MythicManiac","followers_url":"https://api.github.com/users/MythicManiac/followers","following_url":"https://api.github.com/users/MythicManiac/following{/other_user}","gists_url":"https://api.github.com/users/MythicManiac/gists{/gist_id}","starred_url":"https://api.github.com/users/MythicManiac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MythicManiac/subscriptions","organizations_url":"https://api.github.com/users/MythicManiac/orgs","repos_url":"https://api.github.com/users/MythicManiac/repos","events_url":"https://api.github.com/users/MythicManiac/events{/privacy}","received_events_url":"https://api.github.com/users/MythicManiac/received_events","type":"User","site_admin":false},"body":"This can be a constant or static readonly","created_at":"2016-10-05T21:56:14Z","updated_at":"2016-10-05T22:02:16Z","html_url":"https://github.com/LeagueSandbox/ContentSerializer/pull/18#discussion_r82079823","pull_request_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/comments/82079823"},"html":{"href":"https://github.com/LeagueSandbox/ContentSerializer/pull/18#discussion_r82079823"},"pull_request":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18","id":87649360,"html_url":"https://github.com/LeagueSandbox/ContentSerializer/pull/18","diff_url":"https://github.com/LeagueSandbox/ContentSerializer/pull/18.diff","patch_url":"https://github.com/LeagueSandbox/ContentSerializer/pull/18.patch","issue_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/issues/18","number":18,"state":"open","locked":false,"title":"Conversion","user":{"login":"moonshadow565","id":7480230,"avatar_url":"https://avatars.githubusercontent.com/u/7480230?v=3","gravatar_id":"","url":"https://api.github.com/users/moonshadow565","html_url":"https://github.com/moonshadow565","followers_url":"https://api.github.com/users/moonshadow565/followers","following_url":"https://api.github.com/users/moonshadow565/following{/other_user}","gists_url":"https://api.github.com/users/moonshadow565/gists{/gist_id}","starred_url":"https://api.github.com/users/moonshadow565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonshadow565/subscriptions","organizations_url":"https://api.github.com/users/moonshadow565/orgs","repos_url":"https://api.github.com/users/moonshadow565/repos","events_url":"https://api.github.com/users/moonshadow565/events{/privacy}","received_events_url":"https://api.github.com/users/moonshadow565/received_events","type":"User","site_admin":false},"body":"Configurable data exporting.\r\nTried hard to uphold the standards (capped lines at 120 etc...)\r\nThat display name \"tupple\" coulde be moved to ConversionConf json posibly ??","created_at":"2016-10-02T22:38:03Z","updated_at":"2016-10-05T22:02:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe8434fded78ddfe081232ae1b3f062c6b3c77b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18/commits","review_comments_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18/comments","review_comment_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/issues/18/comments","statuses_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/statuses/2e09813bd47004619945e21b59abb0a26b5fb865","head":{"label":"moonshadow565:conversion","ref":"conversion","sha":"2e09813bd47004619945e21b59abb0a26b5fb865","user":{"login":"moonshadow565","id":7480230,"avatar_url":"https://avatars.githubusercontent.com/u/7480230?v=3","gravatar_id":"","url":"https://api.github.com/users/moonshadow565","html_url":"https://github.com/moonshadow565","followers_url":"https://api.github.com/users/moonshadow565/followers","following_url":"https://api.github.com/users/moonshadow565/following{/other_user}","gists_url":"https://api.github.com/users/moonshadow565/gists{/gist_id}","starred_url":"https://api.github.com/users/moonshadow565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonshadow565/subscriptions","organizations_url":"https://api.github.com/users/moonshadow565/orgs","repos_url":"https://api.github.com/users/moonshadow565/repos","events_url":"https://api.github.com/users/moonshadow565/events{/privacy}","received_events_url":"https://api.github.com/users/moonshadow565/received_events","type":"User","site_admin":false},"repo":{"id":68465307,"name":"ContentSerializer","full_name":"moonshadow565/ContentSerializer","owner":{"login":"moonshadow565","id":7480230,"avatar_url":"https://avatars.githubusercontent.com/u/7480230?v=3","gravatar_id":"","url":"https://api.github.com/users/moonshadow565","html_url":"https://github.com/moonshadow565","followers_url":"https://api.github.com/users/moonshadow565/followers","following_url":"https://api.github.com/users/moonshadow565/following{/other_user}","gists_url":"https://api.github.com/users/moonshadow565/gists{/gist_id}","starred_url":"https://api.github.com/users/moonshadow565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonshadow565/subscriptions","organizations_url":"https://api.github.com/users/moonshadow565/orgs","repos_url":"https://api.github.com/users/moonshadow565/repos","events_url":"https://api.github.com/users/moonshadow565/events{/privacy}","received_events_url":"https://api.github.com/users/moonshadow565/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moonshadow565/ContentSerializer","description":"League Sandbox's Content Serializer","fork":true,"url":"https://api.github.com/repos/moonshadow565/ContentSerializer","forks_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/forks","keys_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/teams","hooks_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/hooks","issue_events_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/issues/events{/number}","events_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/events","assignees_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/assignees{/user}","branches_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/branches{/branch}","tags_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/tags","blobs_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/git/refs{/sha}","trees_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/statuses/{sha}","languages_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/languages","stargazers_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/stargazers","contributors_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/contributors","subscribers_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/subscribers","subscription_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/subscription","commits_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/commits{/sha}","git_commits_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/git/commits{/sha}","comments_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/comments{/number}","issue_comment_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/issues/comments{/number}","contents_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/contents/{+path}","compare_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/merges","archive_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/downloads","issues_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/issues{/number}","pulls_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/pulls{/number}","milestones_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/milestones{/number}","notifications_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/labels{/name}","releases_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/releases{/id}","deployments_url":"https://api.github.com/repos/moonshadow565/ContentSerializer/deployments","created_at":"2016-09-17T16:53:22Z","updated_at":"2016-09-17T16:53:23Z","pushed_at":"2016-10-04T00:12:51Z","git_url":"git://github.com/moonshadow565/ContentSerializer.git","ssh_url":"git@github.com:moonshadow565/ContentSerializer.git","clone_url":"https://github.com/moonshadow565/ContentSerializer.git","svn_url":"https://github.com/moonshadow565/ContentSerializer","homepage":null,"size":325,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LeagueSandbox:master","ref":"master","sha":"4fa65c558276e9bdd812b4061371777ea83da681","user":{"login":"LeagueSandbox","id":18346087,"avatar_url":"https://avatars.githubusercontent.com/u/18346087?v=3","gravatar_id":"","url":"https://api.github.com/users/LeagueSandbox","html_url":"https://github.com/LeagueSandbox","followers_url":"https://api.github.com/users/LeagueSandbox/followers","following_url":"https://api.github.com/users/LeagueSandbox/following{/other_user}","gists_url":"https://api.github.com/users/LeagueSandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/LeagueSandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeagueSandbox/subscriptions","organizations_url":"https://api.github.com/users/LeagueSandbox/orgs","repos_url":"https://api.github.com/users/LeagueSandbox/repos","events_url":"https://api.github.com/users/LeagueSandbox/events{/privacy}","received_events_url":"https://api.github.com/users/LeagueSandbox/received_events","type":"Organization","site_admin":false},"repo":{"id":55843981,"name":"ContentSerializer","full_name":"LeagueSandbox/ContentSerializer","owner":{"login":"LeagueSandbox","id":18346087,"avatar_url":"https://avatars.githubusercontent.com/u/18346087?v=3","gravatar_id":"","url":"https://api.github.com/users/LeagueSandbox","html_url":"https://github.com/LeagueSandbox","followers_url":"https://api.github.com/users/LeagueSandbox/followers","following_url":"https://api.github.com/users/LeagueSandbox/following{/other_user}","gists_url":"https://api.github.com/users/LeagueSandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/LeagueSandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeagueSandbox/subscriptions","organizations_url":"https://api.github.com/users/LeagueSandbox/orgs","repos_url":"https://api.github.com/users/LeagueSandbox/repos","events_url":"https://api.github.com/users/LeagueSandbox/events{/privacy}","received_events_url":"https://api.github.com/users/LeagueSandbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LeagueSandbox/ContentSerializer","description":"League Sandbox's Content Serializer","fork":false,"url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer","forks_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/forks","keys_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/teams","hooks_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/hooks","issue_events_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/issues/events{/number}","events_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/events","assignees_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/assignees{/user}","branches_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/branches{/branch}","tags_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/tags","blobs_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/statuses/{sha}","languages_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/languages","stargazers_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/stargazers","contributors_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/contributors","subscribers_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/subscribers","subscription_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/subscription","commits_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/contents/{+path}","compare_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/merges","archive_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/downloads","issues_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/issues{/number}","pulls_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls{/number}","milestones_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/milestones{/number}","notifications_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/labels{/name}","releases_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/releases{/id}","deployments_url":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/deployments","created_at":"2016-04-09T12:49:08Z","updated_at":"2016-04-09T21:03:30Z","pushed_at":"2016-10-02T22:38:03Z","git_url":"git://github.com/LeagueSandbox/ContentSerializer.git","ssh_url":"git@github.com:LeagueSandbox/ContentSerializer.git","clone_url":"https://github.com/LeagueSandbox/ContentSerializer.git","svn_url":"https://github.com/LeagueSandbox/ContentSerializer","homepage":null,"size":312,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18"},"html":{"href":"https://github.com/LeagueSandbox/ContentSerializer/pull/18"},"issue":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/issues/18"},"comments":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/LeagueSandbox/ContentSerializer/statuses/2e09813bd47004619945e21b59abb0a26b5fb865"}}}}
{"actor":{"display_login":"MythicManiac"}}