{"action":"created","comment":{"url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments/90288736","pull_request_review_id":10810253,"id":90288736,"diff_hunk":"@@ -117,14 +120,18 @@ function FunnelController (kuzzle) {\n \n     if (this.cachedRequests >= kuzzle.config.server.maxRetainedRequests) {\n       error = new ServiceUnavailableError('Request discarded: Kuzzle Server is temporarily overloaded');\n+\n       kuzzle.pluginsManager.trigger('log:error', error);\n-      callback(error, new ResponseObject(requestObject, error));\n+\n+      request.setError(error);\n+\n+      callback(error, request.response);","path":"lib/api/controllers/funnelController.js","position":96,"original_position":96,"commit_id":"72526568e981ebe5ac0ad9f346da7be5a6cad1b9","original_commit_id":"72526568e981ebe5ac0ad9f346da7be5a6cad1b9","user":{"login":"ballinette","id":1447135,"avatar_url":"https://avatars.githubusercontent.com/u/1447135?v=3","gravatar_id":"","url":"https://api.github.com/users/ballinette","html_url":"https://github.com/ballinette","followers_url":"https://api.github.com/users/ballinette/followers","following_url":"https://api.github.com/users/ballinette/following{/other_user}","gists_url":"https://api.github.com/users/ballinette/gists{/gist_id}","starred_url":"https://api.github.com/users/ballinette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballinette/subscriptions","organizations_url":"https://api.github.com/users/ballinette/orgs","repos_url":"https://api.github.com/users/ballinette/repos","events_url":"https://api.github.com/users/ballinette/events{/privacy}","received_events_url":"https://api.github.com/users/ballinette/received_events","type":"User","site_admin":false},"body":"isn't it `callback(error, request)` ?","created_at":"2016-11-30T17:53:59Z","updated_at":"2016-11-30T17:53:59Z","html_url":"https://github.com/kuzzleio/kuzzle/pull/559#discussion_r90288736","pull_request_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559","_links":{"self":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments/90288736"},"html":{"href":"https://github.com/kuzzleio/kuzzle/pull/559#discussion_r90288736"},"pull_request":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559"}}},"pull_request":{"url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559","id":95904358,"html_url":"https://github.com/kuzzleio/kuzzle/pull/559","diff_url":"https://github.com/kuzzleio/kuzzle/pull/559.diff","patch_url":"https://github.com/kuzzleio/kuzzle/pull/559.patch","issue_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/559","number":559,"state":"open","locked":false,"title":"Harmonization of the Request and result handling","user":{"login":"dbengsch","id":16542512,"avatar_url":"https://avatars.githubusercontent.com/u/16542512?v=3","gravatar_id":"","url":"https://api.github.com/users/dbengsch","html_url":"https://github.com/dbengsch","followers_url":"https://api.github.com/users/dbengsch/followers","following_url":"https://api.github.com/users/dbengsch/following{/other_user}","gists_url":"https://api.github.com/users/dbengsch/gists{/gist_id}","starred_url":"https://api.github.com/users/dbengsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbengsch/subscriptions","organizations_url":"https://api.github.com/users/dbengsch/orgs","repos_url":"https://api.github.com/users/dbengsch/repos","events_url":"https://api.github.com/users/dbengsch/events{/privacy}","received_events_url":"https://api.github.com/users/dbengsch/received_events","type":"User","site_admin":false},"body":"- Every controllers have been refactored;\r\n- `before` and `after` events are now triggered by the funnel with an argument `request` of type `Request`;\r\n- Most methods that were requiring a `RequestObject` now require a `Request`;\r\n- Methods that were requiring a `context` now require either a `RequestContext` or a `Request`;\r\n- `['from', 'size', 'scroll', 'scrollId', 'refresh', 'type']` previously integrated to the `body` have to be provided as arguments (either in the root of the incoming request or in `query_string` / `headers` for Http).\r\n- Added primary checks on the `Request` structure to all controllers;\r\n- The `funnel`, the `routeController` and the `routeHandler` have been refactored accordingly.","created_at":"2016-11-30T14:45:46Z","updated_at":"2016-11-30T17:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b77b93bcc688a32c665f7ce44aa3e6763db41f53","assignee":{"login":"dbengsch","id":16542512,"avatar_url":"https://avatars.githubusercontent.com/u/16542512?v=3","gravatar_id":"","url":"https://api.github.com/users/dbengsch","html_url":"https://github.com/dbengsch","followers_url":"https://api.github.com/users/dbengsch/followers","following_url":"https://api.github.com/users/dbengsch/following{/other_user}","gists_url":"https://api.github.com/users/dbengsch/gists{/gist_id}","starred_url":"https://api.github.com/users/dbengsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbengsch/subscriptions","organizations_url":"https://api.github.com/users/dbengsch/orgs","repos_url":"https://api.github.com/users/dbengsch/repos","events_url":"https://api.github.com/users/dbengsch/events{/privacy}","received_events_url":"https://api.github.com/users/dbengsch/received_events","type":"User","site_admin":false},"assignees":[{"login":"dbengsch","id":16542512,"avatar_url":"https://avatars.githubusercontent.com/u/16542512?v=3","gravatar_id":"","url":"https://api.github.com/users/dbengsch","html_url":"https://github.com/dbengsch","followers_url":"https://api.github.com/users/dbengsch/followers","following_url":"https://api.github.com/users/dbengsch/following{/other_user}","gists_url":"https://api.github.com/users/dbengsch/gists{/gist_id}","starred_url":"https://api.github.com/users/dbengsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbengsch/subscriptions","organizations_url":"https://api.github.com/users/dbengsch/orgs","repos_url":"https://api.github.com/users/dbengsch/repos","events_url":"https://api.github.com/users/dbengsch/events{/privacy}","received_events_url":"https://api.github.com/users/dbengsch/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559/commits","review_comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559/comments","review_comment_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/559/comments","statuses_url":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/72526568e981ebe5ac0ad9f346da7be5a6cad1b9","head":{"label":"kuzzleio:feature-556-harmony","ref":"feature-556-harmony","sha":"72526568e981ebe5ac0ad9f346da7be5a6cad1b9","user":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":41084349,"name":"kuzzle","full_name":"kuzzleio/kuzzle","owner":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuzzleio/kuzzle","description":"Open-source Back-end, self-hostable & ready to use - Real-time, storage, advanced search - Web, Apps, Mobile, IoT -","fork":false,"url":"https://api.github.com/repos/kuzzleio/kuzzle","forks_url":"https://api.github.com/repos/kuzzleio/kuzzle/forks","keys_url":"https://api.github.com/repos/kuzzleio/kuzzle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/kuzzle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/kuzzle/teams","hooks_url":"https://api.github.com/repos/kuzzleio/kuzzle/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/kuzzle/events","assignees_url":"https://api.github.com/repos/kuzzleio/kuzzle/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/kuzzle/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/tags","blobs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/kuzzle/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/kuzzle/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/kuzzle/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscription","commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/kuzzle/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/kuzzle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/kuzzle/merges","archive_url":"https://api.github.com/repos/kuzzleio/kuzzle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/kuzzle/downloads","issues_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/kuzzle/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/kuzzle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/kuzzle/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/kuzzle/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/kuzzle/deployments","created_at":"2015-08-20T08:26:57Z","updated_at":"2016-11-29T19:38:51Z","pushed_at":"2016-11-30T14:47:08Z","git_url":"git://github.com/kuzzleio/kuzzle.git","ssh_url":"git@github.com:kuzzleio/kuzzle.git","clone_url":"https://github.com/kuzzleio/kuzzle.git","svn_url":"https://github.com/kuzzleio/kuzzle","homepage":"http://kuzzle.io","size":9586,"stargazers_count":363,"watchers_count":363,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":62,"forks":22,"open_issues":62,"watchers":363,"default_branch":"master"}},"base":{"label":"kuzzleio:develop","ref":"develop","sha":"2379d117cf0d1075262ed15d76f203f3ee8ff89b","user":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":41084349,"name":"kuzzle","full_name":"kuzzleio/kuzzle","owner":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuzzleio/kuzzle","description":"Open-source Back-end, self-hostable & ready to use - Real-time, storage, advanced search - Web, Apps, Mobile, IoT -","fork":false,"url":"https://api.github.com/repos/kuzzleio/kuzzle","forks_url":"https://api.github.com/repos/kuzzleio/kuzzle/forks","keys_url":"https://api.github.com/repos/kuzzleio/kuzzle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/kuzzle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/kuzzle/teams","hooks_url":"https://api.github.com/repos/kuzzleio/kuzzle/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/kuzzle/events","assignees_url":"https://api.github.com/repos/kuzzleio/kuzzle/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/kuzzle/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/tags","blobs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/kuzzle/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/kuzzle/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/kuzzle/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscription","commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/kuzzle/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/kuzzle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/kuzzle/merges","archive_url":"https://api.github.com/repos/kuzzleio/kuzzle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/kuzzle/downloads","issues_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/kuzzle/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/kuzzle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/kuzzle/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/kuzzle/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/kuzzle/deployments","created_at":"2015-08-20T08:26:57Z","updated_at":"2016-11-29T19:38:51Z","pushed_at":"2016-11-30T14:47:08Z","git_url":"git://github.com/kuzzleio/kuzzle.git","ssh_url":"git@github.com:kuzzleio/kuzzle.git","clone_url":"https://github.com/kuzzleio/kuzzle.git","svn_url":"https://github.com/kuzzleio/kuzzle","homepage":"http://kuzzle.io","size":9586,"stargazers_count":363,"watchers_count":363,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":62,"forks":22,"open_issues":62,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559"},"html":{"href":"https://github.com/kuzzleio/kuzzle/pull/559"},"issue":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/issues/559"},"comments":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/issues/559/comments"},"review_comments":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559/comments"},"review_comment":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/559/commits"},"statuses":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/72526568e981ebe5ac0ad9f346da7be5a6cad1b9"}}}}
{"actor":{"display_login":"ballinette"}}