{"action":"created","issue":{"url":"https://api.github.com/repos/crossbario/autobahn-js/issues/238","repository_url":"https://api.github.com/repos/crossbario/autobahn-js","labels_url":"https://api.github.com/repos/crossbario/autobahn-js/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/crossbario/autobahn-js/issues/238/comments","events_url":"https://api.github.com/repos/crossbario/autobahn-js/issues/238/events","html_url":"https://github.com/crossbario/autobahn-js/pull/238","id":183537889,"number":238,"title":"Fix for msgpack serialization support","user":{"login":"MKirchen","id":7448619,"avatar_url":"https://avatars.githubusercontent.com/u/7448619?v=3","gravatar_id":"","url":"https://api.github.com/users/MKirchen","html_url":"https://github.com/MKirchen","followers_url":"https://api.github.com/users/MKirchen/followers","following_url":"https://api.github.com/users/MKirchen/following{/other_user}","gists_url":"https://api.github.com/users/MKirchen/gists{/gist_id}","starred_url":"https://api.github.com/users/MKirchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MKirchen/subscriptions","organizations_url":"https://api.github.com/users/MKirchen/orgs","repos_url":"https://api.github.com/users/MKirchen/repos","events_url":"https://api.github.com/users/MKirchen/events{/privacy}","received_events_url":"https://api.github.com/users/MKirchen/received_events","type":"User","site_admin":false},"labels":[{"id":1041510,"url":"https://api.github.com/repos/crossbario/autobahn-js/labels/bug","name":"bug","color":"fc2929","default":true},{"id":126852157,"url":"https://api.github.com/repos/crossbario/autobahn-js/labels/needs-review","name":"needs-review","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-17T21:52:22Z","updated_at":"2016-11-15T14:14:14Z","closed_at":"2016-11-15T14:14:14Z","pull_request":{"url":"https://api.github.com/repos/crossbario/autobahn-js/pulls/238","html_url":"https://github.com/crossbario/autobahn-js/pull/238","diff_url":"https://github.com/crossbario/autobahn-js/pull/238.diff","patch_url":"https://github.com/crossbario/autobahn-js/pull/238.patch"},"body":"- removed WAMP ID monkey patch\n- use Uint64BE for WAMP ID (depends on int64-buffer)\n- fixed bug when decoding ArrayBuffer (see https://github.com/kawanet/msgpack-lite/issues/44)\n- (reactivated msgpack tests)\n\nThis PR fixes msgpack-lite serialization and removes the previously needed monkey patch.\n\nsee:\n- https://github.com/crossbario/autobahn-js/issues/236\n- https://github.com/crossbario/autobahn-js/issues/197\n\nprobably also related to:\n- https://github.com/crossbario/autobahn-js/issues/231\n- https://github.com/crossbario/autobahn-js/issues/67 (latest entry)\n\nRequires msgpack-lite >= 0.1.18 (currently 0.1.17)\nRequires int64-buffer (currently not required)\n\nAll tests passed with msgpack-lite@0.1.18 & int64-buffer@0.1.5.\n\nAlso tested with real-world example of sending binary data with Autobahn Python using msgpack serialization to web-browser Autobahn JS client.\n"},"comment":{"url":"https://api.github.com/repos/crossbario/autobahn-js/issues/comments/260651604","html_url":"https://github.com/crossbario/autobahn-js/pull/238#issuecomment-260651604","issue_url":"https://api.github.com/repos/crossbario/autobahn-js/issues/238","id":260651604,"user":{"login":"oberstet","id":233340,"avatar_url":"https://avatars.githubusercontent.com/u/233340?v=3","gravatar_id":"","url":"https://api.github.com/users/oberstet","html_url":"https://github.com/oberstet","followers_url":"https://api.github.com/users/oberstet/followers","following_url":"https://api.github.com/users/oberstet/following{/other_user}","gists_url":"https://api.github.com/users/oberstet/gists{/gist_id}","starred_url":"https://api.github.com/users/oberstet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oberstet/subscriptions","organizations_url":"https://api.github.com/users/oberstet/orgs","repos_url":"https://api.github.com/users/oberstet/repos","events_url":"https://api.github.com/users/oberstet/events{/privacy}","received_events_url":"https://api.github.com/users/oberstet/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T14:14:14Z","updated_at":"2016-11-15T14:14:14Z","body":"Alright, these changes are now on release v0.11.0 - I couldn't merge it \"as is\", because I restructured the repo. Sorry. But thanks for tracking this down!\r\n\r\nNote: there are likely issues left. But I lack the time now to really fix it. Please see here https://github.com/crossbario/autobahn-js/issues/241"}}
{"actor":{"display_login":"oberstet"}}