{"action":"created","issue":{"url":"https://api.github.com/repos/inducer/pudb/issues/208","repository_url":"https://api.github.com/repos/inducer/pudb","labels_url":"https://api.github.com/repos/inducer/pudb/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/inducer/pudb/issues/208/comments","events_url":"https://api.github.com/repos/inducer/pudb/issues/208/events","html_url":"https://github.com/inducer/pudb/pull/208","id":194896480,"number":208,"title":"Monokai","user":{"login":"epmoyer","id":136718,"avatar_url":"https://avatars.githubusercontent.com/u/136718?v=3","gravatar_id":"","url":"https://api.github.com/users/epmoyer","html_url":"https://github.com/epmoyer","followers_url":"https://api.github.com/users/epmoyer/followers","following_url":"https://api.github.com/users/epmoyer/following{/other_user}","gists_url":"https://api.github.com/users/epmoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/epmoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epmoyer/subscriptions","organizations_url":"https://api.github.com/users/epmoyer/orgs","repos_url":"https://api.github.com/users/epmoyer/repos","events_url":"https://api.github.com/users/epmoyer/events{/privacy}","received_events_url":"https://api.github.com/users/epmoyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-12T05:58:34Z","updated_at":"2016-12-14T01:33:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/inducer/pudb/pulls/208","html_url":"https://github.com/inducer/pudb/pull/208","diff_url":"https://github.com/inducer/pudb/pull/208.diff","patch_url":"https://github.com/inducer/pudb/pull/208.patch"},"body":"This change adds \"monokai\" and \"monokai-256\" to the built-in Themes. It faithfully reproduces all Monokai styling except for coloring optional argument names orange in function calls (implementing that would have required a two-pass parser to go backwards and change the token type of the argument name after encountering the \"=\" which follows it.)\r\n\r\nThis implementation adds several new palette items: \"namespace\", \"operator\", \"argument\", \"builtin\", \"pseudo\", \"dunder\", \"exception\", and \"keyword2\".  Their meaning is documented near the top of theme.py\r\n\r\nAll legacy Themes have been updated to assign colors to the new palette items such that the legacy themes appear identical before and after this change.  The addition of the new palette items makes it possible, if you like, to expand the colorization of the legacy themes in the future. I thought it was cleanest for me to keep this pull request focussed on the new theme and not muddy the waters by making any changes to the appearance of the legacy ones.\r\n\r\nI have tested on Python 3.5 and 2.7, and raw/curses (though both appear identical on my platform).\r\n\r\n**monokai-256 vs Sublime**\r\n<img width=\"941\" alt=\"monokai-256\" src=\"https://cloud.githubusercontent.com/assets/136718/21089341/23d53790-bfec-11e6-985b-97d5b4691238.png\">\r\n\r\n**monokai vs Sublime**\r\n<img width=\"921\" alt=\"monokai\" src=\"https://cloud.githubusercontent.com/assets/136718/21089343/29260ddc-bfec-11e6-8452-2153948ddd41.png\">\r\n\r\n**Legacy themes with Monokai build (left) and trunk build (right)**\r\n<img width=\"1439\" alt=\"classic_compare\" src=\"https://cloud.githubusercontent.com/assets/136718/21089359/43dcf078-bfec-11e6-9580-dc2ab6205552.png\">\r\n\r\n<img width=\"1435\" alt=\"vim_compare\" src=\"https://cloud.githubusercontent.com/assets/136718/21089365/574e5c78-bfec-11e6-808c-21aabf266ac4.png\">\r\n\r\n<img width=\"1437\" alt=\"dark_vim_compare\" src=\"https://cloud.githubusercontent.com/assets/136718/21089370/6879634e-bfec-11e6-8a27-555e23be0401.png\">\r\n\r\n<img width=\"1439\" alt=\"midnight_compare\" src=\"https://cloud.githubusercontent.com/assets/136718/21089381/7b30e14c-bfec-11e6-91b8-c52611a17223.png\">\r\n\r\n<img width=\"1437\" alt=\"solarized_compare\" src=\"https://cloud.githubusercontent.com/assets/136718/21089396/926bfc52-bfec-11e6-8704-b9da78212ecb.png\">\r\n\r\n<img width=\"1436\" alt=\"agr-256_compare\" src=\"https://cloud.githubusercontent.com/assets/136718/21089412/b3d8873e-bfec-11e6-8c4d-8df3505044d5.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/inducer/pudb/issues/comments/266916409","html_url":"https://github.com/inducer/pudb/pull/208#issuecomment-266916409","issue_url":"https://api.github.com/repos/inducer/pudb/issues/208","id":266916409,"user":{"login":"epmoyer","id":136718,"avatar_url":"https://avatars.githubusercontent.com/u/136718?v=3","gravatar_id":"","url":"https://api.github.com/users/epmoyer","html_url":"https://github.com/epmoyer","followers_url":"https://api.github.com/users/epmoyer/followers","following_url":"https://api.github.com/users/epmoyer/following{/other_user}","gists_url":"https://api.github.com/users/epmoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/epmoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epmoyer/subscriptions","organizations_url":"https://api.github.com/users/epmoyer/orgs","repos_url":"https://api.github.com/users/epmoyer/repos","events_url":"https://api.github.com/users/epmoyer/events{/privacy}","received_events_url":"https://api.github.com/users/epmoyer/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T01:33:24Z","updated_at":"2016-12-14T01:33:24Z","body":"Added an inheritance mapping which assigns each new added style to the value of it's corresponding legacy style if a Theme does not assign that style explicitly.  With that in place, I regressed all the legacy themes to their original code (and they work properly).  The inheritance is applied after custom Themes are loaded, so custom Themes produce identical visual behavior without modification.\r\n\r\nI also updated \"monokai\" to use a dark style for the side panels (like \"monokai-256\" does).\r\n\r\n**monokai**\r\n<img width=\"699\" alt=\"monokai\" src=\"https://cloud.githubusercontent.com/assets/136718/21166199/d8f193cc-c158-11e6-8acf-f1cc62d991ae.png\">\r\n\r\n**monokai-256**\r\n<img width=\"698\" alt=\"monokai-256\" src=\"https://cloud.githubusercontent.com/assets/136718/21166205/e8d82166-c158-11e6-8fed-63a9483cd054.png\">\r\n\r\n**monokai build (left) vs master build (right) with an (ugly :) unmodified legacy custom theme**\r\n<img width=\"1426\" alt=\"compare_custom\" src=\"https://cloud.githubusercontent.com/assets/136718/21166249/1619777e-c159-11e6-90de-ad930e1128f0.png\">\r\n\r\n**monokai build (left) vs master build (right) with legacy themes**\r\n<img width=\"1423\" alt=\"compare_classic\" src=\"https://cloud.githubusercontent.com/assets/136718/21166283/53df2202-c159-11e6-9761-889a7acc34f4.png\">\r\n\r\n<img width=\"1422\" alt=\"compare_vim\" src=\"https://cloud.githubusercontent.com/assets/136718/21166288/5cd30784-c159-11e6-958d-8726baca60f4.png\">\r\n\r\n<img width=\"1421\" alt=\"compare_dark_vim\" src=\"https://cloud.githubusercontent.com/assets/136718/21166293/62e80c82-c159-11e6-8c12-57119fbbd537.png\">\r\n\r\n<img width=\"1427\" alt=\"comare_midnight\" src=\"https://cloud.githubusercontent.com/assets/136718/21166297/69b806fc-c159-11e6-86a5-f6b2102c19ac.png\">\r\n\r\n<img width=\"1427\" alt=\"compare_solarized\" src=\"https://cloud.githubusercontent.com/assets/136718/21166298/6e751c16-c159-11e6-8baa-cbd65e9dce07.png\">\r\n\r\n<img width=\"1425\" alt=\"compare_agr-256\" src=\"https://cloud.githubusercontent.com/assets/136718/21166303/767de1cc-c159-11e6-9f98-dd9ba026df00.png\">\r\n\r\n"}}
{"actor":{"display_login":"epmoyer"}}