{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/68502254","id":68502254,"diff_hunk":"@@ -864,6 +864,19 @@ defmodule Kernel.Typespec do\n     {:op, line(meta), op, {:integer, line(meta), integer}}\n   end\n \n+  # Handle remote calls in the form of @module_attribute.type.","path":"lib/elixir/lib/kernel/typespec.ex","position":4,"original_position":4,"commit_id":"e0bc40a9b266d5d394d3ee8d09228f5aec1b97cb","original_commit_id":"e0bc40a9b266d5d394d3ee8d09228f5aec1b97cb","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"body":"`can we use backticks? Since its touching a \".\" @module_attribute.type`","created_at":"2016-06-26T12:25:21Z","updated_at":"2016-06-26T12:25:21Z","html_url":"https://github.com/elixir-lang/elixir/pull/4891#discussion_r68502254","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/68502254"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/4891#discussion_r68502254"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891","id":75227420,"html_url":"https://github.com/elixir-lang/elixir/pull/4891","diff_url":"https://github.com/elixir-lang/elixir/pull/4891.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/4891.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4891","number":4891,"state":"open","locked":false,"title":"Support module attributes in remote types","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"body":"For example, `@for.t` in protocols or similar use cases. This PR closes #4874.\r\n\r\nI'm open to feedback on the error message we should give if the module attribute doesn't expand to a module :)\r\n\r\nFor the record, this was broken in https://github.com/elixir-lang/elixir/commit/a3c429f9b9a476f995b23328430a1dcca55d1799, when we stopped expanding module attributes in `Macro.expand_once/2`.","created_at":"2016-06-26T11:18:44Z","updated_at":"2016-06-26T12:25:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9753c4995cd477b44f4ae3be18463d47c55d71b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4891/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/e0bc40a9b266d5d394d3ee8d09228f5aec1b97cb","head":{"label":"whatyouhide:module-attrs-remote-typespecs","ref":"module-attrs-remote-typespecs","sha":"e0bc40a9b266d5d394d3ee8d09228f5aec1b97cb","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"repo":{"id":27794017,"name":"elixir","full_name":"whatyouhide/elixir","owner":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whatyouhide/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/whatyouhide/elixir","forks_url":"https://api.github.com/repos/whatyouhide/elixir/forks","keys_url":"https://api.github.com/repos/whatyouhide/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatyouhide/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatyouhide/elixir/teams","hooks_url":"https://api.github.com/repos/whatyouhide/elixir/hooks","issue_events_url":"https://api.github.com/repos/whatyouhide/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/whatyouhide/elixir/events","assignees_url":"https://api.github.com/repos/whatyouhide/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/whatyouhide/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/whatyouhide/elixir/tags","blobs_url":"https://api.github.com/repos/whatyouhide/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatyouhide/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatyouhide/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatyouhide/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatyouhide/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/whatyouhide/elixir/languages","stargazers_url":"https://api.github.com/repos/whatyouhide/elixir/stargazers","contributors_url":"https://api.github.com/repos/whatyouhide/elixir/contributors","subscribers_url":"https://api.github.com/repos/whatyouhide/elixir/subscribers","subscription_url":"https://api.github.com/repos/whatyouhide/elixir/subscription","commits_url":"https://api.github.com/repos/whatyouhide/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatyouhide/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatyouhide/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatyouhide/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatyouhide/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/whatyouhide/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatyouhide/elixir/merges","archive_url":"https://api.github.com/repos/whatyouhide/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatyouhide/elixir/downloads","issues_url":"https://api.github.com/repos/whatyouhide/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/whatyouhide/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/whatyouhide/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/whatyouhide/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatyouhide/elixir/labels{/name}","releases_url":"https://api.github.com/repos/whatyouhide/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/whatyouhide/elixir/deployments","created_at":"2014-12-10T00:12:42Z","updated_at":"2015-02-14T09:28:19Z","pushed_at":"2016-06-26T11:17:49Z","git_url":"git://github.com/whatyouhide/elixir.git","ssh_url":"git@github.com:whatyouhide/elixir.git","clone_url":"https://github.com/whatyouhide/elixir.git","svn_url":"https://github.com/whatyouhide/elixir","homepage":"http://elixir-lang.org/","size":34607,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"60ed20effaece3ab5da40e2b51145331f882c521","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2016-06-25T19:18:57Z","pushed_at":"2016-06-26T11:18:44Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":43521,"stargazers_count":7392,"watchers_count":7392,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1016,"mirror_url":null,"open_issues_count":17,"forks":1016,"open_issues":17,"watchers":7392,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/4891"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4891"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4891/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4891/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/e0bc40a9b266d5d394d3ee8d09228f5aec1b97cb"}}}}
{"actor":{"display_login":"eksperimental"}}