{"action":"created","issue":{"url":"https://api.github.com/repos/bfirsh/needle/issues/49","repository_url":"https://api.github.com/repos/bfirsh/needle","labels_url":"https://api.github.com/repos/bfirsh/needle/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/bfirsh/needle/issues/49/comments","events_url":"https://api.github.com/repos/bfirsh/needle/issues/49/events","html_url":"https://github.com/bfirsh/needle/pull/49","id":157516092,"number":49,"title":"added whitelist","user":{"login":"abioneperhobby","id":2149815,"avatar_url":"https://avatars.githubusercontent.com/u/2149815?v=3","gravatar_id":"","url":"https://api.github.com/users/abioneperhobby","html_url":"https://github.com/abioneperhobby","followers_url":"https://api.github.com/users/abioneperhobby/followers","following_url":"https://api.github.com/users/abioneperhobby/following{/other_user}","gists_url":"https://api.github.com/users/abioneperhobby/gists{/gist_id}","starred_url":"https://api.github.com/users/abioneperhobby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abioneperhobby/subscriptions","organizations_url":"https://api.github.com/users/abioneperhobby/orgs","repos_url":"https://api.github.com/users/abioneperhobby/repos","events_url":"https://api.github.com/users/abioneperhobby/events{/privacy}","received_events_url":"https://api.github.com/users/abioneperhobby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-30T14:44:45Z","updated_at":"2016-05-30T15:57:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bfirsh/needle/pulls/49","html_url":"https://github.com/bfirsh/needle/pull/49","diff_url":"https://github.com/bfirsh/needle/pull/49.diff","patch_url":"https://github.com/bfirsh/needle/pull/49.patch"},"body":"Now you can pass a whitelist of css selector.\r\nIf css selectors matches somethings, those elements visibility will be set to \"hidden\" in order to avoid screenshot comparison failures on elements that can, by nature, change."},"comment":{"url":"https://api.github.com/repos/bfirsh/needle/issues/comments/222519924","html_url":"https://github.com/bfirsh/needle/pull/49#issuecomment-222519924","issue_url":"https://api.github.com/repos/bfirsh/needle/issues/49","id":222519924,"user":{"login":"jphalip","id":68544,"avatar_url":"https://avatars.githubusercontent.com/u/68544?v=3","gravatar_id":"","url":"https://api.github.com/users/jphalip","html_url":"https://github.com/jphalip","followers_url":"https://api.github.com/users/jphalip/followers","following_url":"https://api.github.com/users/jphalip/following{/other_user}","gists_url":"https://api.github.com/users/jphalip/gists{/gist_id}","starred_url":"https://api.github.com/users/jphalip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jphalip/subscriptions","organizations_url":"https://api.github.com/users/jphalip/orgs","repos_url":"https://api.github.com/users/jphalip/repos","events_url":"https://api.github.com/users/jphalip/events{/privacy}","received_events_url":"https://api.github.com/users/jphalip/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T15:57:29Z","updated_at":"2016-05-30T15:57:29Z","body":"Nice, I really like this feature. Thanks for the suggestion.\r\n\r\nHere are a few comments:\r\n\r\n- Could the parameter be named \"ignore\" instead of \"whitelist\". I think that would make the intent a bit clearer.\r\n- Could you make that parameter follow the same type as `element_or_selector`, i.e. in this case be a \"list of NeedleWebElement objects or of CSS selectors\"?\r\n- It'd be best to make use of the Selenium API and use `find_elements_by_css_selector()` instead of executing the `querySelector()` Javascript call, in order to make it compatible across more browsers.\r\n- Could you add a unit test for this?\r\n\r\nThanks!\r\n"}}
{"actor":{"display_login":"jphalip"}}