{"action":"created","issue":{"url":"https://api.github.com/repos/mumble-voip/mumble-pahelper/issues/1","repository_url":"https://api.github.com/repos/mumble-voip/mumble-pahelper","labels_url":"https://api.github.com/repos/mumble-voip/mumble-pahelper/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/mumble-voip/mumble-pahelper/issues/1/comments","events_url":"https://api.github.com/repos/mumble-voip/mumble-pahelper/issues/1/events","html_url":"https://github.com/mumble-voip/mumble-pahelper/pull/1","id":160670633,"number":1,"title":"Custom plugins location and other improvements","user":{"login":"davidebeatrici","id":5897523,"avatar_url":"https://avatars.githubusercontent.com/u/5897523?v=3","gravatar_id":"","url":"https://api.github.com/users/davidebeatrici","html_url":"https://github.com/davidebeatrici","followers_url":"https://api.github.com/users/davidebeatrici/followers","following_url":"https://api.github.com/users/davidebeatrici/following{/other_user}","gists_url":"https://api.github.com/users/davidebeatrici/gists{/gist_id}","starred_url":"https://api.github.com/users/davidebeatrici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidebeatrici/subscriptions","organizations_url":"https://api.github.com/users/davidebeatrici/orgs","repos_url":"https://api.github.com/users/davidebeatrici/repos","events_url":"https://api.github.com/users/davidebeatrici/events{/privacy}","received_events_url":"https://api.github.com/users/davidebeatrici/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hacst","id":237537,"avatar_url":"https://avatars.githubusercontent.com/u/237537?v=3","gravatar_id":"","url":"https://api.github.com/users/hacst","html_url":"https://github.com/hacst","followers_url":"https://api.github.com/users/hacst/followers","following_url":"https://api.github.com/users/hacst/following{/other_user}","gists_url":"https://api.github.com/users/hacst/gists{/gist_id}","starred_url":"https://api.github.com/users/hacst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hacst/subscriptions","organizations_url":"https://api.github.com/users/hacst/orgs","repos_url":"https://api.github.com/users/hacst/repos","events_url":"https://api.github.com/users/hacst/events{/privacy}","received_events_url":"https://api.github.com/users/hacst/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-06-16T14:07:13Z","updated_at":"2016-06-21T22:02:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mumble-voip/mumble-pahelper/pulls/1","html_url":"https://github.com/mumble-voip/mumble-pahelper/pull/1","diff_url":"https://github.com/mumble-voip/mumble-pahelper/pull/1.diff","patch_url":"https://github.com/mumble-voip/mumble-pahelper/pull/1.patch"},"body":"Feature to change the system and user plugins location\r\nFeature to disable/enable system or user plugins\r\nChanged the default system plugins directory to\r\n\"%AppData/Roaming/Mumble/Plugins\" and the user plugins one to \"Plugins\"\r\nSwapped Front and Top locations\r\nRemoved arrow buttons from every QSpinBox\r\nChanged the labels names according to the related QSpinBox"},"comment":{"url":"https://api.github.com/repos/mumble-voip/mumble-pahelper/issues/comments/227586123","html_url":"https://github.com/mumble-voip/mumble-pahelper/pull/1#issuecomment-227586123","issue_url":"https://api.github.com/repos/mumble-voip/mumble-pahelper/issues/1","id":227586123,"user":{"login":"hacst","id":237537,"avatar_url":"https://avatars.githubusercontent.com/u/237537?v=3","gravatar_id":"","url":"https://api.github.com/users/hacst","html_url":"https://github.com/hacst","followers_url":"https://api.github.com/users/hacst/followers","following_url":"https://api.github.com/users/hacst/following{/other_user}","gists_url":"https://api.github.com/users/hacst/gists{/gist_id}","starred_url":"https://api.github.com/users/hacst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hacst/subscriptions","organizations_url":"https://api.github.com/users/hacst/orgs","repos_url":"https://api.github.com/users/hacst/repos","events_url":"https://api.github.com/users/hacst/events{/privacy}","received_events_url":"https://api.github.com/users/hacst/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T22:02:42Z","updated_at":"2016-06-21T22:02:42Z","body":"@mkrautz Turns out mumble-pahelper doesn't compiler under Linux as is (I assume the same was true before this PR). Probably something we should fix.\r\n\r\n@davidebeatrici While I had no Windows box handy to compile test this I don't think this would compile as is. For the standard plugin folder I the hack with faking the application name I mentioned above ought to work. For the Mumble install folder I don't see an easy way to auto-detect this. pa-helper was meant to be placed right next to the mumble.exe to circumvent this issue (back when it also dependent on the libraries Mumble shipped with but with the static build that reason went away). I think being able to select an alternative path manually ought to be sufficient.\r\n\r\nFor the PR idea itself: Overall nice enhancements (especially getting the normal plugin path right is pretty useful^^). Not sure why top and front ought to be swapped but I'm not attached to the old order...\r\n"}}
{"actor":{"display_login":"hacst"}}