{"action":"created","comment":{"url":"https://api.github.com/repos/node-modules/urllib/pulls/comments/73673622","id":73673622,"diff_hunk":"@@ -35,7 +35,7 @@ exports.httpsAgent.maxSockets = 1000;\n  * @const\n  */\n \n-exports.TIMEOUT = ms('5s');\n+exports.TIMEOUT = [ms('5s'), ms('5s')];","path":"lib/urllib.js","position":5,"original_position":5,"commit_id":"a0f14dfb5b98cffdc9a977209bd393a14674d420","original_commit_id":"a0f14dfb5b98cffdc9a977209bd393a14674d420","user":{"login":"fengmk2","id":156269,"avatar_url":"https://avatars.githubusercontent.com/u/156269?v=3","gravatar_id":"","url":"https://api.github.com/users/fengmk2","html_url":"https://github.com/fengmk2","followers_url":"https://api.github.com/users/fengmk2/followers","following_url":"https://api.github.com/users/fengmk2/following{/other_user}","gists_url":"https://api.github.com/users/fengmk2/gists{/gist_id}","starred_url":"https://api.github.com/users/fengmk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengmk2/subscriptions","organizations_url":"https://api.github.com/users/fengmk2/orgs","repos_url":"https://api.github.com/users/fengmk2/repos","events_url":"https://api.github.com/users/fengmk2/events{/privacy}","received_events_url":"https://api.github.com/users/fengmk2/received_events","type":"User","site_admin":false},"body":"这个不要变化，是暴露的接口，增加一个 `exports.TIMEOUTS` 吧","created_at":"2016-08-05T10:37:57Z","updated_at":"2016-08-05T10:37:57Z","html_url":"https://github.com/node-modules/urllib/pull/201#discussion_r73673622","pull_request_url":"https://api.github.com/repos/node-modules/urllib/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/node-modules/urllib/pulls/comments/73673622"},"html":{"href":"https://github.com/node-modules/urllib/pull/201#discussion_r73673622"},"pull_request":{"href":"https://api.github.com/repos/node-modules/urllib/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/node-modules/urllib/pulls/201","id":80109833,"html_url":"https://github.com/node-modules/urllib/pull/201","diff_url":"https://github.com/node-modules/urllib/pull/201.diff","patch_url":"https://github.com/node-modules/urllib/pull/201.patch","issue_url":"https://api.github.com/repos/node-modules/urllib/issues/201","number":201,"state":"open","locked":false,"title":"feat: timeout option","user":{"login":"ibigbug","id":543405,"avatar_url":"https://avatars.githubusercontent.com/u/543405?v=3","gravatar_id":"","url":"https://api.github.com/users/ibigbug","html_url":"https://github.com/ibigbug","followers_url":"https://api.github.com/users/ibigbug/followers","following_url":"https://api.github.com/users/ibigbug/following{/other_user}","gists_url":"https://api.github.com/users/ibigbug/gists{/gist_id}","starred_url":"https://api.github.com/users/ibigbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibigbug/subscriptions","organizations_url":"https://api.github.com/users/ibigbug/orgs","repos_url":"https://api.github.com/users/ibigbug/repos","events_url":"https://api.github.com/users/ibigbug/events{/privacy}","received_events_url":"https://api.github.com/users/ibigbug/received_events","type":"User","site_admin":false},"body":"can set connect timeout and response timeout seperately.","created_at":"2016-08-04T16:33:00Z","updated_at":"2016-08-05T10:37:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1783219e177dae8dcc8e5d8a27cc70948bc95e0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/node-modules/urllib/pulls/201/commits","review_comments_url":"https://api.github.com/repos/node-modules/urllib/pulls/201/comments","review_comment_url":"https://api.github.com/repos/node-modules/urllib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/node-modules/urllib/issues/201/comments","statuses_url":"https://api.github.com/repos/node-modules/urllib/statuses/a0f14dfb5b98cffdc9a977209bd393a14674d420","head":{"label":"ibigbug:feat/timeout","ref":"feat/timeout","sha":"a0f14dfb5b98cffdc9a977209bd393a14674d420","user":{"login":"ibigbug","id":543405,"avatar_url":"https://avatars.githubusercontent.com/u/543405?v=3","gravatar_id":"","url":"https://api.github.com/users/ibigbug","html_url":"https://github.com/ibigbug","followers_url":"https://api.github.com/users/ibigbug/followers","following_url":"https://api.github.com/users/ibigbug/following{/other_user}","gists_url":"https://api.github.com/users/ibigbug/gists{/gist_id}","starred_url":"https://api.github.com/users/ibigbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibigbug/subscriptions","organizations_url":"https://api.github.com/users/ibigbug/orgs","repos_url":"https://api.github.com/users/ibigbug/repos","events_url":"https://api.github.com/users/ibigbug/events{/privacy}","received_events_url":"https://api.github.com/users/ibigbug/received_events","type":"User","site_admin":false},"repo":{"id":12024054,"name":"urllib","full_name":"ibigbug/urllib","owner":{"login":"ibigbug","id":543405,"avatar_url":"https://avatars.githubusercontent.com/u/543405?v=3","gravatar_id":"","url":"https://api.github.com/users/ibigbug","html_url":"https://github.com/ibigbug","followers_url":"https://api.github.com/users/ibigbug/followers","following_url":"https://api.github.com/users/ibigbug/following{/other_user}","gists_url":"https://api.github.com/users/ibigbug/gists{/gist_id}","starred_url":"https://api.github.com/users/ibigbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibigbug/subscriptions","organizations_url":"https://api.github.com/users/ibigbug/orgs","repos_url":"https://api.github.com/users/ibigbug/repos","events_url":"https://api.github.com/users/ibigbug/events{/privacy}","received_events_url":"https://api.github.com/users/ibigbug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibigbug/urllib","description":"Help in opening URLs (mostly HTTP) in a complex world — basic and digest authentication, redirections, cookies and more. Like python's _urllib_ module.","fork":true,"url":"https://api.github.com/repos/ibigbug/urllib","forks_url":"https://api.github.com/repos/ibigbug/urllib/forks","keys_url":"https://api.github.com/repos/ibigbug/urllib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibigbug/urllib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibigbug/urllib/teams","hooks_url":"https://api.github.com/repos/ibigbug/urllib/hooks","issue_events_url":"https://api.github.com/repos/ibigbug/urllib/issues/events{/number}","events_url":"https://api.github.com/repos/ibigbug/urllib/events","assignees_url":"https://api.github.com/repos/ibigbug/urllib/assignees{/user}","branches_url":"https://api.github.com/repos/ibigbug/urllib/branches{/branch}","tags_url":"https://api.github.com/repos/ibigbug/urllib/tags","blobs_url":"https://api.github.com/repos/ibigbug/urllib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibigbug/urllib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibigbug/urllib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibigbug/urllib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibigbug/urllib/statuses/{sha}","languages_url":"https://api.github.com/repos/ibigbug/urllib/languages","stargazers_url":"https://api.github.com/repos/ibigbug/urllib/stargazers","contributors_url":"https://api.github.com/repos/ibigbug/urllib/contributors","subscribers_url":"https://api.github.com/repos/ibigbug/urllib/subscribers","subscription_url":"https://api.github.com/repos/ibigbug/urllib/subscription","commits_url":"https://api.github.com/repos/ibigbug/urllib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibigbug/urllib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibigbug/urllib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibigbug/urllib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibigbug/urllib/contents/{+path}","compare_url":"https://api.github.com/repos/ibigbug/urllib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibigbug/urllib/merges","archive_url":"https://api.github.com/repos/ibigbug/urllib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibigbug/urllib/downloads","issues_url":"https://api.github.com/repos/ibigbug/urllib/issues{/number}","pulls_url":"https://api.github.com/repos/ibigbug/urllib/pulls{/number}","milestones_url":"https://api.github.com/repos/ibigbug/urllib/milestones{/number}","notifications_url":"https://api.github.com/repos/ibigbug/urllib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibigbug/urllib/labels{/name}","releases_url":"https://api.github.com/repos/ibigbug/urllib/releases{/id}","deployments_url":"https://api.github.com/repos/ibigbug/urllib/deployments","created_at":"2013-08-10T17:19:32Z","updated_at":"2014-01-15T02:12:51Z","pushed_at":"2016-08-05T07:01:37Z","git_url":"git://github.com/ibigbug/urllib.git","ssh_url":"git@github.com:ibigbug/urllib.git","clone_url":"https://github.com/ibigbug/urllib.git","svn_url":"https://github.com/ibigbug/urllib","homepage":"","size":709,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"node-modules:master","ref":"master","sha":"d88b63b1308014511bc297bf2b5a780e14fc1e48","user":{"login":"node-modules","id":7125868,"avatar_url":"https://avatars.githubusercontent.com/u/7125868?v=3","gravatar_id":"","url":"https://api.github.com/users/node-modules","html_url":"https://github.com/node-modules","followers_url":"https://api.github.com/users/node-modules/followers","following_url":"https://api.github.com/users/node-modules/following{/other_user}","gists_url":"https://api.github.com/users/node-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/node-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-modules/subscriptions","organizations_url":"https://api.github.com/users/node-modules/orgs","repos_url":"https://api.github.com/users/node-modules/repos","events_url":"https://api.github.com/users/node-modules/events{/privacy}","received_events_url":"https://api.github.com/users/node-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":1753353,"name":"urllib","full_name":"node-modules/urllib","owner":{"login":"node-modules","id":7125868,"avatar_url":"https://avatars.githubusercontent.com/u/7125868?v=3","gravatar_id":"","url":"https://api.github.com/users/node-modules","html_url":"https://github.com/node-modules","followers_url":"https://api.github.com/users/node-modules/followers","following_url":"https://api.github.com/users/node-modules/following{/other_user}","gists_url":"https://api.github.com/users/node-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/node-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-modules/subscriptions","organizations_url":"https://api.github.com/users/node-modules/orgs","repos_url":"https://api.github.com/users/node-modules/repos","events_url":"https://api.github.com/users/node-modules/events{/privacy}","received_events_url":"https://api.github.com/users/node-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/node-modules/urllib","description":"Request HTTP(s) URLs in a complex world","fork":false,"url":"https://api.github.com/repos/node-modules/urllib","forks_url":"https://api.github.com/repos/node-modules/urllib/forks","keys_url":"https://api.github.com/repos/node-modules/urllib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-modules/urllib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-modules/urllib/teams","hooks_url":"https://api.github.com/repos/node-modules/urllib/hooks","issue_events_url":"https://api.github.com/repos/node-modules/urllib/issues/events{/number}","events_url":"https://api.github.com/repos/node-modules/urllib/events","assignees_url":"https://api.github.com/repos/node-modules/urllib/assignees{/user}","branches_url":"https://api.github.com/repos/node-modules/urllib/branches{/branch}","tags_url":"https://api.github.com/repos/node-modules/urllib/tags","blobs_url":"https://api.github.com/repos/node-modules/urllib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-modules/urllib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-modules/urllib/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-modules/urllib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-modules/urllib/statuses/{sha}","languages_url":"https://api.github.com/repos/node-modules/urllib/languages","stargazers_url":"https://api.github.com/repos/node-modules/urllib/stargazers","contributors_url":"https://api.github.com/repos/node-modules/urllib/contributors","subscribers_url":"https://api.github.com/repos/node-modules/urllib/subscribers","subscription_url":"https://api.github.com/repos/node-modules/urllib/subscription","commits_url":"https://api.github.com/repos/node-modules/urllib/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-modules/urllib/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-modules/urllib/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-modules/urllib/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-modules/urllib/contents/{+path}","compare_url":"https://api.github.com/repos/node-modules/urllib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-modules/urllib/merges","archive_url":"https://api.github.com/repos/node-modules/urllib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-modules/urllib/downloads","issues_url":"https://api.github.com/repos/node-modules/urllib/issues{/number}","pulls_url":"https://api.github.com/repos/node-modules/urllib/pulls{/number}","milestones_url":"https://api.github.com/repos/node-modules/urllib/milestones{/number}","notifications_url":"https://api.github.com/repos/node-modules/urllib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-modules/urllib/labels{/name}","releases_url":"https://api.github.com/repos/node-modules/urllib/releases{/id}","deployments_url":"https://api.github.com/repos/node-modules/urllib/deployments","created_at":"2011-05-16T02:04:01Z","updated_at":"2016-07-25T08:25:28Z","pushed_at":"2016-08-05T07:01:38Z","git_url":"git://github.com/node-modules/urllib.git","ssh_url":"git@github.com:node-modules/urllib.git","clone_url":"https://github.com/node-modules/urllib.git","svn_url":"https://github.com/node-modules/urllib","homepage":"","size":812,"stargazers_count":149,"watchers_count":149,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":3,"forks":43,"open_issues":3,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/node-modules/urllib/pulls/201"},"html":{"href":"https://github.com/node-modules/urllib/pull/201"},"issue":{"href":"https://api.github.com/repos/node-modules/urllib/issues/201"},"comments":{"href":"https://api.github.com/repos/node-modules/urllib/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/node-modules/urllib/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/node-modules/urllib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/node-modules/urllib/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/node-modules/urllib/statuses/a0f14dfb5b98cffdc9a977209bd393a14674d420"}}}}
{"actor":{"display_login":"fengmk2"}}