{"action":"created","issue":{"url":"https://api.github.com/repos/pixijs/pixi.js/issues/2936","repository_url":"https://api.github.com/repos/pixijs/pixi.js","labels_url":"https://api.github.com/repos/pixijs/pixi.js/issues/2936/labels{/name}","comments_url":"https://api.github.com/repos/pixijs/pixi.js/issues/2936/comments","events_url":"https://api.github.com/repos/pixijs/pixi.js/issues/2936/events","html_url":"https://github.com/pixijs/pixi.js/pull/2936","id":176080325,"number":2936,"title":"Implementing classes using the new ES6 syntax","user":{"login":"leonardo-silva","id":7905740,"avatar_url":"https://avatars.githubusercontent.com/u/7905740?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardo-silva","html_url":"https://github.com/leonardo-silva","followers_url":"https://api.github.com/users/leonardo-silva/followers","following_url":"https://api.github.com/users/leonardo-silva/following{/other_user}","gists_url":"https://api.github.com/users/leonardo-silva/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardo-silva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardo-silva/subscriptions","organizations_url":"https://api.github.com/users/leonardo-silva/orgs","repos_url":"https://api.github.com/users/leonardo-silva/repos","events_url":"https://api.github.com/users/leonardo-silva/events{/privacy}","received_events_url":"https://api.github.com/users/leonardo-silva/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-09T18:44:39Z","updated_at":"2016-09-12T18:45:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pixijs/pixi.js/pulls/2936","html_url":"https://github.com/pixijs/pixi.js/pull/2936","diff_url":"https://github.com/pixijs/pixi.js/pull/2936.diff","patch_url":"https://github.com/pixijs/pixi.js/pull/2936.patch"},"body":"Hi,\r\n\r\nIn my PhD research, I am using ``pixi.js`` in some experiments.\r\n\r\nAs a result, I identified the existence of several \"classes\" in the current codebase (Container, Shader, CanvasPrepare, WebGLManager, etc)\r\n\r\nSo, I decided to rewrite the classes to follow the new syntax provided by ECMAScript 2016, which I think is much more readable. All changes are just syntactical. I was also very careful to preserve the code style.\r\nFinally, the tests are green in the migrated code.\r\n\r\nDo you think it is worth to integrate these changes to the project?\r\n\r\nThank you"},"comment":{"url":"https://api.github.com/repos/pixijs/pixi.js/issues/comments/246449642","html_url":"https://github.com/pixijs/pixi.js/pull/2936#issuecomment-246449642","issue_url":"https://api.github.com/repos/pixijs/pixi.js/issues/2936","id":246449642,"user":{"login":"bigtimebuddy","id":864393,"avatar_url":"https://avatars.githubusercontent.com/u/864393?v=3","gravatar_id":"","url":"https://api.github.com/users/bigtimebuddy","html_url":"https://github.com/bigtimebuddy","followers_url":"https://api.github.com/users/bigtimebuddy/followers","following_url":"https://api.github.com/users/bigtimebuddy/following{/other_user}","gists_url":"https://api.github.com/users/bigtimebuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bigtimebuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigtimebuddy/subscriptions","organizations_url":"https://api.github.com/users/bigtimebuddy/orgs","repos_url":"https://api.github.com/users/bigtimebuddy/repos","events_url":"https://api.github.com/users/bigtimebuddy/events{/privacy}","received_events_url":"https://api.github.com/users/bigtimebuddy/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T18:45:07Z","updated_at":"2016-09-12T18:45:07Z","body":"@leonardo-silva Could you please close and make this PR against the newly-created branch, **dev-es6**? We would like to do some longer-term development migrating to ES6 that involves more work beyond this single PR. Thanks for kicking this off!"}}
{"actor":{"display_login":"bigtimebuddy"}}