{"action":"created","issue":{"url":"https://api.github.com/repos/azavea/raster-foundry/issues/780","repository_url":"https://api.github.com/repos/azavea/raster-foundry","labels_url":"https://api.github.com/repos/azavea/raster-foundry/issues/780/labels{/name}","comments_url":"https://api.github.com/repos/azavea/raster-foundry/issues/780/comments","events_url":"https://api.github.com/repos/azavea/raster-foundry/issues/780/events","html_url":"https://github.com/azavea/raster-foundry/pull/780","id":195667180,"number":780,"title":"Allow selecting scenes to color correct by grid","user":{"login":"ddohler","id":447977,"avatar_url":"https://avatars.githubusercontent.com/u/447977?v=3","gravatar_id":"","url":"https://api.github.com/users/ddohler","html_url":"https://github.com/ddohler","followers_url":"https://api.github.com/users/ddohler/followers","following_url":"https://api.github.com/users/ddohler/following{/other_user}","gists_url":"https://api.github.com/users/ddohler/gists{/gist_id}","starred_url":"https://api.github.com/users/ddohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddohler/subscriptions","organizations_url":"https://api.github.com/users/ddohler/orgs","repos_url":"https://api.github.com/users/ddohler/repos","events_url":"https://api.github.com/users/ddohler/events{/privacy}","received_events_url":"https://api.github.com/users/ddohler/received_events","type":"User","site_admin":false},"labels":[{"id":241545522,"url":"https://api.github.com/repos/azavea/raster-foundry/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-14T22:43:25Z","updated_at":"2016-12-15T22:04:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/azavea/raster-foundry/pulls/780","html_url":"https://github.com/azavea/raster-foundry/pull/780","diff_url":"https://github.com/azavea/raster-foundry/pull/780.diff","patch_url":"https://github.com/azavea/raster-foundry/pull/780.patch"},"body":"## Overview\r\n\r\nThis implements part of the color correction wireframes which show an interface for selecting scenes by clicking grid cells displayed on the map. Because we don't need to show a count of scenes like we do on the browse page, I was able to get away with generating the grid by drawing a border around the Leaflet tiles.\r\n\r\nThere is also some general cleanup, including removing an unused hook from the `colorCorrectScenes` component, moving the logic for getting all of a Project's Scenes into the Project service, and fixing an incorrect query parameter in the `getProjectSceneCount` method that was causing it to unnecessarily return a full page of results. \r\n\r\n### Checklist\r\n\r\n- [ ] ~Styleguide updated, if necessary~\r\n- [ ] ~Swagger specification updated, if necessary~\r\n\r\n### Demo\r\n\r\n![gridselect](https://cloud.githubusercontent.com/assets/447977/21204234/5f1ac466-c224-11e6-904d-1ef97bc0c9c2.png)\r\n\r\n## Testing Instructions\r\n\r\n * Navigate to the color correction interface for a project containing the Egypt scenes.\r\n * Zoom in until the scenes are spread across more than one grid cell.\r\n * Click on a grid cell, verify that some scenes are selected.\r\n * Switch into color correction mode and verify that the selected scenes overlap with the clicked grid cell.\r\n\r\nCloses #727 "},"comment":{"url":"https://api.github.com/repos/azavea/raster-foundry/issues/comments/267457949","html_url":"https://github.com/azavea/raster-foundry/pull/780#issuecomment-267457949","issue_url":"https://api.github.com/repos/azavea/raster-foundry/issues/780","id":267457949,"user":{"login":"ddohler","id":447977,"avatar_url":"https://avatars.githubusercontent.com/u/447977?v=3","gravatar_id":"","url":"https://api.github.com/users/ddohler","html_url":"https://github.com/ddohler","followers_url":"https://api.github.com/users/ddohler/followers","following_url":"https://api.github.com/users/ddohler/following{/other_user}","gists_url":"https://api.github.com/users/ddohler/gists{/gist_id}","starred_url":"https://api.github.com/users/ddohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddohler/subscriptions","organizations_url":"https://api.github.com/users/ddohler/orgs","repos_url":"https://api.github.com/users/ddohler/repos","events_url":"https://api.github.com/users/ddohler/events{/privacy}","received_events_url":"https://api.github.com/users/ddohler/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T22:04:43Z","updated_at":"2016-12-15T22:04:43Z","body":"I've updated this to show a highlight when a grid cell is clicked, and to allow toggling the selection by clicking in the same grid cell again. I've also fixed up a race condition where you could click between two grid cells really quickly and end up with the scenes from the first-clicked grid cell rather than the second-clicked one.\r\n![gridselecthighlight](https://cloud.githubusercontent.com/assets/447977/21243117/6551d8d0-c2e5-11e6-9388-9b674895a45d.png)\r\n\r\nI think it would be best to hold off on making the grid cells smaller for now; I think the best way to do it would be to create a custom `GridLayer` with a smaller tile size, but that would require a deeper level of interaction with the map than we can easily support with the current structure. The current cell sizes are the same as what we're using on the browse page (i.e. quad-tree tiles) so they're consistent at least."}}
{"actor":{"display_login":"ddohler"}}