{"action":"created","issue":{"url":"https://api.github.com/repos/mgechev/angular2-seed/issues/629","repository_url":"https://api.github.com/repos/mgechev/angular2-seed","labels_url":"https://api.github.com/repos/mgechev/angular2-seed/issues/629/labels{/name}","comments_url":"https://api.github.com/repos/mgechev/angular2-seed/issues/629/comments","events_url":"https://api.github.com/repos/mgechev/angular2-seed/issues/629/events","html_url":"https://github.com/mgechev/angular2-seed/issues/629","id":140635740,"number":629,"title":"Merge DEV_NPM_DEPENDENCIES and PROD_NPM_DEPENDENCIES","user":{"login":"mgechev","id":455023,"avatar_url":"https://avatars.githubusercontent.com/u/455023?v=3","gravatar_id":"","url":"https://api.github.com/users/mgechev","html_url":"https://github.com/mgechev","followers_url":"https://api.github.com/users/mgechev/followers","following_url":"https://api.github.com/users/mgechev/following{/other_user}","gists_url":"https://api.github.com/users/mgechev/gists{/gist_id}","starred_url":"https://api.github.com/users/mgechev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgechev/subscriptions","organizations_url":"https://api.github.com/users/mgechev/orgs","repos_url":"https://api.github.com/users/mgechev/repos","events_url":"https://api.github.com/users/mgechev/events{/privacy}","received_events_url":"https://api.github.com/users/mgechev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mgechev/angular2-seed/labels/discuss","name":"discuss","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-14T10:36:27Z","updated_at":"2016-03-14T16:26:25Z","closed_at":null,"body":"It is confusing and redundant to have two different arrays of injectable dependencies.\r\n\r\nThe biggest current benefits of these two configuration options are:\r\n\r\n- Faster loading of the development build (we're able to inject bundles instead of load the individual dependencies one by one, what the prod build does).\r\n- We're able to use pre-minified version of some of the dependencies for the production build. This can eventually save some bandwidth if the files are minified in a special way (using Closure Compiler or uglifyjs wth mangling).\r\n\r\nGenerally only a single array of dependencies will be enough, and the difference in the treatment of the files could come from the configuration of the SystemJS builder that we use.\r\n\r\nFor some advanced builds it could be better to preserve both configuration options. My suggestion is to keep `PROD_DEPENDENCIES` with value `null` by default. If the user of the seed needs more custom behavior she can define `PROD_DEPENDENCIES` array and get the current behavior.\r\n\r\n// cc @ludohenin @d3viant0ne "},"comment":{"url":"https://api.github.com/repos/mgechev/angular2-seed/issues/comments/196397713","html_url":"https://github.com/mgechev/angular2-seed/issues/629#issuecomment-196397713","issue_url":"https://api.github.com/repos/mgechev/angular2-seed/issues/629","id":196397713,"user":{"login":"ludohenin","id":1011516,"avatar_url":"https://avatars.githubusercontent.com/u/1011516?v=3","gravatar_id":"","url":"https://api.github.com/users/ludohenin","html_url":"https://github.com/ludohenin","followers_url":"https://api.github.com/users/ludohenin/followers","following_url":"https://api.github.com/users/ludohenin/following{/other_user}","gists_url":"https://api.github.com/users/ludohenin/gists{/gist_id}","starred_url":"https://api.github.com/users/ludohenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludohenin/subscriptions","organizations_url":"https://api.github.com/users/ludohenin/orgs","repos_url":"https://api.github.com/users/ludohenin/repos","events_url":"https://api.github.com/users/ludohenin/events{/privacy}","received_events_url":"https://api.github.com/users/ludohenin/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T16:26:25Z","updated_at":"2016-03-14T16:26:25Z","body":"Another `InjectableDependencies` option :) `env: 'dev | prod | both'` ?\r\nWe keep both (DEV_DEP & PROD_DEP) for backward compatibility. We could also turn them into getters so we can compute whatever's needed here."}}