{"action":"closed","number":42,"pull_request":{"url":"https://api.github.com/repos/zachahn/munge/pulls/42","id":62852456,"html_url":"https://github.com/zachahn/munge/pull/42","diff_url":"https://github.com/zachahn/munge/pull/42.diff","patch_url":"https://github.com/zachahn/munge/pull/42.patch","issue_url":"https://api.github.com/repos/zachahn/munge/issues/42","number":42,"state":"closed","locked":false,"title":"Breaking API","user":{"login":"zachahn","id":93058,"avatar_url":"https://avatars.githubusercontent.com/u/93058?v=3","gravatar_id":"","url":"https://api.github.com/users/zachahn","html_url":"https://github.com/zachahn","followers_url":"https://api.github.com/users/zachahn/followers","following_url":"https://api.github.com/users/zachahn/following{/other_user}","gists_url":"https://api.github.com/users/zachahn/gists{/gist_id}","starred_url":"https://api.github.com/users/zachahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachahn/subscriptions","organizations_url":"https://api.github.com/users/zachahn/orgs","repos_url":"https://api.github.com/users/zachahn/repos","events_url":"https://api.github.com/users/zachahn/events{/privacy}","received_events_url":"https://api.github.com/users/zachahn/received_events","type":"User","site_admin":false},"body":"- Rename `app.source` to `app.items`\r\n  - This results in better consistency in the `rules.rb` file when iterating\r\n  - This makes it obvious that we're just iterating through an array of items\r\n- Add `app.nonrouted` for items without routes\r\n- Add `app.routed` for items with routes\r\n\r\nI was considering following the pattern of `Module#instance_methods(include_super=true)`. But the problem with that is that I always need to look up documentation whether I need to pass true or false.\r\n\r\nAnother possibility would be `app.items(:routed)` and `app.items(:nonrouted)`, but that can be confusing if someone makes a typo","created_at":"2016-03-15T04:00:44Z","updated_at":"2016-03-20T00:02:40Z","closed_at":"2016-03-20T00:02:40Z","merged_at":"2016-03-20T00:02:40Z","merge_commit_sha":"abb76b74408e56a15424bb151af4efea78b4c37f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zachahn/munge/pulls/42/commits","review_comments_url":"https://api.github.com/repos/zachahn/munge/pulls/42/comments","review_comment_url":"https://api.github.com/repos/zachahn/munge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zachahn/munge/issues/42/comments","statuses_url":"https://api.github.com/repos/zachahn/munge/statuses/2e6305bba0f1998c652b59038efc61468cee9cd9","head":{"label":"zachahn:breaking-api","ref":"breaking-api","sha":"2e6305bba0f1998c652b59038efc61468cee9cd9","user":{"login":"zachahn","id":93058,"avatar_url":"https://avatars.githubusercontent.com/u/93058?v=3","gravatar_id":"","url":"https://api.github.com/users/zachahn","html_url":"https://github.com/zachahn","followers_url":"https://api.github.com/users/zachahn/followers","following_url":"https://api.github.com/users/zachahn/following{/other_user}","gists_url":"https://api.github.com/users/zachahn/gists{/gist_id}","starred_url":"https://api.github.com/users/zachahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachahn/subscriptions","organizations_url":"https://api.github.com/users/zachahn/orgs","repos_url":"https://api.github.com/users/zachahn/repos","events_url":"https://api.github.com/users/zachahn/events{/privacy}","received_events_url":"https://api.github.com/users/zachahn/received_events","type":"User","site_admin":false},"repo":{"id":42533660,"name":"munge","full_name":"zachahn/munge","owner":{"login":"zachahn","id":93058,"avatar_url":"https://avatars.githubusercontent.com/u/93058?v=3","gravatar_id":"","url":"https://api.github.com/users/zachahn","html_url":"https://github.com/zachahn","followers_url":"https://api.github.com/users/zachahn/followers","following_url":"https://api.github.com/users/zachahn/following{/other_user}","gists_url":"https://api.github.com/users/zachahn/gists{/gist_id}","starred_url":"https://api.github.com/users/zachahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachahn/subscriptions","organizations_url":"https://api.github.com/users/zachahn/orgs","repos_url":"https://api.github.com/users/zachahn/repos","events_url":"https://api.github.com/users/zachahn/events{/privacy}","received_events_url":"https://api.github.com/users/zachahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zachahn/munge","description":"Static site generator aiming to simplify complex build rules","fork":false,"url":"https://api.github.com/repos/zachahn/munge","forks_url":"https://api.github.com/repos/zachahn/munge/forks","keys_url":"https://api.github.com/repos/zachahn/munge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zachahn/munge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zachahn/munge/teams","hooks_url":"https://api.github.com/repos/zachahn/munge/hooks","issue_events_url":"https://api.github.com/repos/zachahn/munge/issues/events{/number}","events_url":"https://api.github.com/repos/zachahn/munge/events","assignees_url":"https://api.github.com/repos/zachahn/munge/assignees{/user}","branches_url":"https://api.github.com/repos/zachahn/munge/branches{/branch}","tags_url":"https://api.github.com/repos/zachahn/munge/tags","blobs_url":"https://api.github.com/repos/zachahn/munge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zachahn/munge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zachahn/munge/git/refs{/sha}","trees_url":"https://api.github.com/repos/zachahn/munge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zachahn/munge/statuses/{sha}","languages_url":"https://api.github.com/repos/zachahn/munge/languages","stargazers_url":"https://api.github.com/repos/zachahn/munge/stargazers","contributors_url":"https://api.github.com/repos/zachahn/munge/contributors","subscribers_url":"https://api.github.com/repos/zachahn/munge/subscribers","subscription_url":"https://api.github.com/repos/zachahn/munge/subscription","commits_url":"https://api.github.com/repos/zachahn/munge/commits{/sha}","git_commits_url":"https://api.github.com/repos/zachahn/munge/git/commits{/sha}","comments_url":"https://api.github.com/repos/zachahn/munge/comments{/number}","issue_comment_url":"https://api.github.com/repos/zachahn/munge/issues/comments{/number}","contents_url":"https://api.github.com/repos/zachahn/munge/contents/{+path}","compare_url":"https://api.github.com/repos/zachahn/munge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zachahn/munge/merges","archive_url":"https://api.github.com/repos/zachahn/munge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zachahn/munge/downloads","issues_url":"https://api.github.com/repos/zachahn/munge/issues{/number}","pulls_url":"https://api.github.com/repos/zachahn/munge/pulls{/number}","milestones_url":"https://api.github.com/repos/zachahn/munge/milestones{/number}","notifications_url":"https://api.github.com/repos/zachahn/munge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zachahn/munge/labels{/name}","releases_url":"https://api.github.com/repos/zachahn/munge/releases{/id}","deployments_url":"https://api.github.com/repos/zachahn/munge/deployments","created_at":"2015-09-15T17:01:41Z","updated_at":"2016-01-14T19:59:06Z","pushed_at":"2016-03-20T00:02:40Z","git_url":"git://github.com/zachahn/munge.git","ssh_url":"git@github.com:zachahn/munge.git","clone_url":"https://github.com/zachahn/munge.git","svn_url":"https://github.com/zachahn/munge","homepage":"https://rubygems.org/gems/munge","size":333,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"zachahn:master","ref":"master","sha":"b581857f11d40cbcdbc22c959c405384d44c337e","user":{"login":"zachahn","id":93058,"avatar_url":"https://avatars.githubusercontent.com/u/93058?v=3","gravatar_id":"","url":"https://api.github.com/users/zachahn","html_url":"https://github.com/zachahn","followers_url":"https://api.github.com/users/zachahn/followers","following_url":"https://api.github.com/users/zachahn/following{/other_user}","gists_url":"https://api.github.com/users/zachahn/gists{/gist_id}","starred_url":"https://api.github.com/users/zachahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachahn/subscriptions","organizations_url":"https://api.github.com/users/zachahn/orgs","repos_url":"https://api.github.com/users/zachahn/repos","events_url":"https://api.github.com/users/zachahn/events{/privacy}","received_events_url":"https://api.github.com/users/zachahn/received_events","type":"User","site_admin":false},"repo":{"id":42533660,"name":"munge","full_name":"zachahn/munge","owner":{"login":"zachahn","id":93058,"avatar_url":"https://avatars.githubusercontent.com/u/93058?v=3","gravatar_id":"","url":"https://api.github.com/users/zachahn","html_url":"https://github.com/zachahn","followers_url":"https://api.github.com/users/zachahn/followers","following_url":"https://api.github.com/users/zachahn/following{/other_user}","gists_url":"https://api.github.com/users/zachahn/gists{/gist_id}","starred_url":"https://api.github.com/users/zachahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachahn/subscriptions","organizations_url":"https://api.github.com/users/zachahn/orgs","repos_url":"https://api.github.com/users/zachahn/repos","events_url":"https://api.github.com/users/zachahn/events{/privacy}","received_events_url":"https://api.github.com/users/zachahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zachahn/munge","description":"Static site generator aiming to simplify complex build rules","fork":false,"url":"https://api.github.com/repos/zachahn/munge","forks_url":"https://api.github.com/repos/zachahn/munge/forks","keys_url":"https://api.github.com/repos/zachahn/munge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zachahn/munge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zachahn/munge/teams","hooks_url":"https://api.github.com/repos/zachahn/munge/hooks","issue_events_url":"https://api.github.com/repos/zachahn/munge/issues/events{/number}","events_url":"https://api.github.com/repos/zachahn/munge/events","assignees_url":"https://api.github.com/repos/zachahn/munge/assignees{/user}","branches_url":"https://api.github.com/repos/zachahn/munge/branches{/branch}","tags_url":"https://api.github.com/repos/zachahn/munge/tags","blobs_url":"https://api.github.com/repos/zachahn/munge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zachahn/munge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zachahn/munge/git/refs{/sha}","trees_url":"https://api.github.com/repos/zachahn/munge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zachahn/munge/statuses/{sha}","languages_url":"https://api.github.com/repos/zachahn/munge/languages","stargazers_url":"https://api.github.com/repos/zachahn/munge/stargazers","contributors_url":"https://api.github.com/repos/zachahn/munge/contributors","subscribers_url":"https://api.github.com/repos/zachahn/munge/subscribers","subscription_url":"https://api.github.com/repos/zachahn/munge/subscription","commits_url":"https://api.github.com/repos/zachahn/munge/commits{/sha}","git_commits_url":"https://api.github.com/repos/zachahn/munge/git/commits{/sha}","comments_url":"https://api.github.com/repos/zachahn/munge/comments{/number}","issue_comment_url":"https://api.github.com/repos/zachahn/munge/issues/comments{/number}","contents_url":"https://api.github.com/repos/zachahn/munge/contents/{+path}","compare_url":"https://api.github.com/repos/zachahn/munge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zachahn/munge/merges","archive_url":"https://api.github.com/repos/zachahn/munge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zachahn/munge/downloads","issues_url":"https://api.github.com/repos/zachahn/munge/issues{/number}","pulls_url":"https://api.github.com/repos/zachahn/munge/pulls{/number}","milestones_url":"https://api.github.com/repos/zachahn/munge/milestones{/number}","notifications_url":"https://api.github.com/repos/zachahn/munge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zachahn/munge/labels{/name}","releases_url":"https://api.github.com/repos/zachahn/munge/releases{/id}","deployments_url":"https://api.github.com/repos/zachahn/munge/deployments","created_at":"2015-09-15T17:01:41Z","updated_at":"2016-01-14T19:59:06Z","pushed_at":"2016-03-20T00:02:40Z","git_url":"git://github.com/zachahn/munge.git","ssh_url":"git@github.com:zachahn/munge.git","clone_url":"https://github.com/zachahn/munge.git","svn_url":"https://github.com/zachahn/munge","homepage":"https://rubygems.org/gems/munge","size":333,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zachahn/munge/pulls/42"},"html":{"href":"https://github.com/zachahn/munge/pull/42"},"issue":{"href":"https://api.github.com/repos/zachahn/munge/issues/42"},"comments":{"href":"https://api.github.com/repos/zachahn/munge/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/zachahn/munge/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/zachahn/munge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zachahn/munge/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/zachahn/munge/statuses/2e6305bba0f1998c652b59038efc61468cee9cd9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zachahn","id":93058,"avatar_url":"https://avatars.githubusercontent.com/u/93058?v=3","gravatar_id":"","url":"https://api.github.com/users/zachahn","html_url":"https://github.com/zachahn","followers_url":"https://api.github.com/users/zachahn/followers","following_url":"https://api.github.com/users/zachahn/following{/other_user}","gists_url":"https://api.github.com/users/zachahn/gists{/gist_id}","starred_url":"https://api.github.com/users/zachahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachahn/subscriptions","organizations_url":"https://api.github.com/users/zachahn/orgs","repos_url":"https://api.github.com/users/zachahn/repos","events_url":"https://api.github.com/users/zachahn/events{/privacy}","received_events_url":"https://api.github.com/users/zachahn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":9,"additions":59,"deletions":51,"changed_files":13}}