{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/slobdell/Finisher/pulls/1","id":49935107,"html_url":"https://github.com/slobdell/Finisher/pull/1","diff_url":"https://github.com/slobdell/Finisher/pull/1.diff","patch_url":"https://github.com/slobdell/Finisher/pull/1.patch","issue_url":"https://api.github.com/repos/slobdell/Finisher/issues/1","number":1,"state":"closed","locked":false,"title":"Python 3 support","user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"body":"I've also added travis, test output: https://travis-ci.org/hayd/Finisher/jobs/89611171\r\n\r\nAs you can see there is a testing failure in test_train_multiple, not sure why that is... Perhaps something with dict ordering not being well-defined in python 3? It is reproducable (maybe 1 in 3 times):\r\n\r\n```\r\n======================================================================\r\nFAIL: Verifies that training updates a model rather than re-trains it.\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/andy/projects/Finisher/finisher/test_autocompleter.py\", line 232, in test_train_multiple_redis\r\n    self.assertEqual(guessed_phrases, ['octopus', 'rabbit'])\r\nAssertionError: Lists differ: ['rabbit', 'octopus'] != ['octopus', 'rabbit']\r\n\r\nFirst differing element 0:\r\nrabbit\r\noctopus\r\n\r\n- ['rabbit', 'octopus']\r\n+ ['octopus', 'rabbit']\r\n```\r\n\r\nI tested py2.6 just because, but that requires removing set-comprehensions.\r\n\r\nThe bytes <-> str story needs some care...","created_at":"2015-11-06T10:02:07Z","updated_at":"2016-01-10T05:55:20Z","closed_at":"2016-01-10T05:55:20Z","merged_at":"2016-01-10T05:55:20Z","merge_commit_sha":"b5c45e4279051cf0b70418457ce633a6138abb47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slobdell/Finisher/pulls/1/commits","review_comments_url":"https://api.github.com/repos/slobdell/Finisher/pulls/1/comments","review_comment_url":"https://api.github.com/repos/slobdell/Finisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slobdell/Finisher/issues/1/comments","statuses_url":"https://api.github.com/repos/slobdell/Finisher/statuses/13d41f0a68df45fd15cf600164321dee2e990e42","head":{"label":"hayd:py3","ref":"py3","sha":"13d41f0a68df45fd15cf600164321dee2e990e42","user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"repo":{"id":45673628,"name":"Finisher","full_name":"hayd/Finisher","owner":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hayd/Finisher","description":"","fork":true,"url":"https://api.github.com/repos/hayd/Finisher","forks_url":"https://api.github.com/repos/hayd/Finisher/forks","keys_url":"https://api.github.com/repos/hayd/Finisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hayd/Finisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hayd/Finisher/teams","hooks_url":"https://api.github.com/repos/hayd/Finisher/hooks","issue_events_url":"https://api.github.com/repos/hayd/Finisher/issues/events{/number}","events_url":"https://api.github.com/repos/hayd/Finisher/events","assignees_url":"https://api.github.com/repos/hayd/Finisher/assignees{/user}","branches_url":"https://api.github.com/repos/hayd/Finisher/branches{/branch}","tags_url":"https://api.github.com/repos/hayd/Finisher/tags","blobs_url":"https://api.github.com/repos/hayd/Finisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hayd/Finisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hayd/Finisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/hayd/Finisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hayd/Finisher/statuses/{sha}","languages_url":"https://api.github.com/repos/hayd/Finisher/languages","stargazers_url":"https://api.github.com/repos/hayd/Finisher/stargazers","contributors_url":"https://api.github.com/repos/hayd/Finisher/contributors","subscribers_url":"https://api.github.com/repos/hayd/Finisher/subscribers","subscription_url":"https://api.github.com/repos/hayd/Finisher/subscription","commits_url":"https://api.github.com/repos/hayd/Finisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/hayd/Finisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/hayd/Finisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/hayd/Finisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/hayd/Finisher/contents/{+path}","compare_url":"https://api.github.com/repos/hayd/Finisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hayd/Finisher/merges","archive_url":"https://api.github.com/repos/hayd/Finisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hayd/Finisher/downloads","issues_url":"https://api.github.com/repos/hayd/Finisher/issues{/number}","pulls_url":"https://api.github.com/repos/hayd/Finisher/pulls{/number}","milestones_url":"https://api.github.com/repos/hayd/Finisher/milestones{/number}","notifications_url":"https://api.github.com/repos/hayd/Finisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hayd/Finisher/labels{/name}","releases_url":"https://api.github.com/repos/hayd/Finisher/releases{/id}","created_at":"2015-11-06T09:50:19Z","updated_at":"2015-11-06T09:50:20Z","pushed_at":"2015-11-06T09:53:38Z","git_url":"git://github.com/hayd/Finisher.git","ssh_url":"git@github.com:hayd/Finisher.git","clone_url":"https://github.com/hayd/Finisher.git","svn_url":"https://github.com/hayd/Finisher","homepage":null,"size":3451,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slobdell:master","ref":"master","sha":"fda23b12ce72bff402a6696dc22753c0a68bc5ac","user":{"login":"slobdell","id":2179660,"avatar_url":"https://avatars.githubusercontent.com/u/2179660?v=3","gravatar_id":"","url":"https://api.github.com/users/slobdell","html_url":"https://github.com/slobdell","followers_url":"https://api.github.com/users/slobdell/followers","following_url":"https://api.github.com/users/slobdell/following{/other_user}","gists_url":"https://api.github.com/users/slobdell/gists{/gist_id}","starred_url":"https://api.github.com/users/slobdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slobdell/subscriptions","organizations_url":"https://api.github.com/users/slobdell/orgs","repos_url":"https://api.github.com/users/slobdell/repos","events_url":"https://api.github.com/users/slobdell/events{/privacy}","received_events_url":"https://api.github.com/users/slobdell/received_events","type":"User","site_admin":false},"repo":{"id":43039317,"name":"Finisher","full_name":"slobdell/Finisher","owner":{"login":"slobdell","id":2179660,"avatar_url":"https://avatars.githubusercontent.com/u/2179660?v=3","gravatar_id":"","url":"https://api.github.com/users/slobdell","html_url":"https://github.com/slobdell","followers_url":"https://api.github.com/users/slobdell/followers","following_url":"https://api.github.com/users/slobdell/following{/other_user}","gists_url":"https://api.github.com/users/slobdell/gists{/gist_id}","starred_url":"https://api.github.com/users/slobdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slobdell/subscriptions","organizations_url":"https://api.github.com/users/slobdell/orgs","repos_url":"https://api.github.com/users/slobdell/repos","events_url":"https://api.github.com/users/slobdell/events{/privacy}","received_events_url":"https://api.github.com/users/slobdell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slobdell/Finisher","description":"","fork":false,"url":"https://api.github.com/repos/slobdell/Finisher","forks_url":"https://api.github.com/repos/slobdell/Finisher/forks","keys_url":"https://api.github.com/repos/slobdell/Finisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slobdell/Finisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slobdell/Finisher/teams","hooks_url":"https://api.github.com/repos/slobdell/Finisher/hooks","issue_events_url":"https://api.github.com/repos/slobdell/Finisher/issues/events{/number}","events_url":"https://api.github.com/repos/slobdell/Finisher/events","assignees_url":"https://api.github.com/repos/slobdell/Finisher/assignees{/user}","branches_url":"https://api.github.com/repos/slobdell/Finisher/branches{/branch}","tags_url":"https://api.github.com/repos/slobdell/Finisher/tags","blobs_url":"https://api.github.com/repos/slobdell/Finisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slobdell/Finisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slobdell/Finisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/slobdell/Finisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slobdell/Finisher/statuses/{sha}","languages_url":"https://api.github.com/repos/slobdell/Finisher/languages","stargazers_url":"https://api.github.com/repos/slobdell/Finisher/stargazers","contributors_url":"https://api.github.com/repos/slobdell/Finisher/contributors","subscribers_url":"https://api.github.com/repos/slobdell/Finisher/subscribers","subscription_url":"https://api.github.com/repos/slobdell/Finisher/subscription","commits_url":"https://api.github.com/repos/slobdell/Finisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/slobdell/Finisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/slobdell/Finisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/slobdell/Finisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/slobdell/Finisher/contents/{+path}","compare_url":"https://api.github.com/repos/slobdell/Finisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slobdell/Finisher/merges","archive_url":"https://api.github.com/repos/slobdell/Finisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slobdell/Finisher/downloads","issues_url":"https://api.github.com/repos/slobdell/Finisher/issues{/number}","pulls_url":"https://api.github.com/repos/slobdell/Finisher/pulls{/number}","milestones_url":"https://api.github.com/repos/slobdell/Finisher/milestones{/number}","notifications_url":"https://api.github.com/repos/slobdell/Finisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slobdell/Finisher/labels{/name}","releases_url":"https://api.github.com/repos/slobdell/Finisher/releases{/id}","created_at":"2015-09-24T02:14:20Z","updated_at":"2015-11-05T03:17:29Z","pushed_at":"2016-01-10T05:55:20Z","git_url":"git://github.com/slobdell/Finisher.git","ssh_url":"git@github.com:slobdell/Finisher.git","clone_url":"https://github.com/slobdell/Finisher.git","svn_url":"https://github.com/slobdell/Finisher","homepage":null,"size":3524,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slobdell/Finisher/pulls/1"},"html":{"href":"https://github.com/slobdell/Finisher/pull/1"},"issue":{"href":"https://api.github.com/repos/slobdell/Finisher/issues/1"},"comments":{"href":"https://api.github.com/repos/slobdell/Finisher/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/slobdell/Finisher/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/slobdell/Finisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slobdell/Finisher/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/slobdell/Finisher/statuses/13d41f0a68df45fd15cf600164321dee2e990e42"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"slobdell","id":2179660,"avatar_url":"https://avatars.githubusercontent.com/u/2179660?v=3","gravatar_id":"","url":"https://api.github.com/users/slobdell","html_url":"https://github.com/slobdell","followers_url":"https://api.github.com/users/slobdell/followers","following_url":"https://api.github.com/users/slobdell/following{/other_user}","gists_url":"https://api.github.com/users/slobdell/gists{/gist_id}","starred_url":"https://api.github.com/users/slobdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slobdell/subscriptions","organizations_url":"https://api.github.com/users/slobdell/orgs","repos_url":"https://api.github.com/users/slobdell/repos","events_url":"https://api.github.com/users/slobdell/events{/privacy}","received_events_url":"https://api.github.com/users/slobdell/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":53,"deletions":24,"changed_files":4}}