{"action":"created","issue":{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/issues/44","repository_url":"https://api.github.com/repos/Unidata/netcdf-fortran","labels_url":"https://api.github.com/repos/Unidata/netcdf-fortran/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/Unidata/netcdf-fortran/issues/44/comments","events_url":"https://api.github.com/repos/Unidata/netcdf-fortran/issues/44/events","html_url":"https://github.com/Unidata/netcdf-fortran/pull/44","id":136737323,"number":44,"title":"USE_LOGGING not propagated to LOGGING preprocessor macro","user":{"login":"nncarlson","id":7231327,"avatar_url":"https://avatars.githubusercontent.com/u/7231327?v=3","gravatar_id":"","url":"https://api.github.com/users/nncarlson","html_url":"https://github.com/nncarlson","followers_url":"https://api.github.com/users/nncarlson/followers","following_url":"https://api.github.com/users/nncarlson/following{/other_user}","gists_url":"https://api.github.com/users/nncarlson/gists{/gist_id}","starred_url":"https://api.github.com/users/nncarlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nncarlson/subscriptions","organizations_url":"https://api.github.com/users/nncarlson/orgs","repos_url":"https://api.github.com/users/nncarlson/repos","events_url":"https://api.github.com/users/nncarlson/events{/privacy}","received_events_url":"https://api.github.com/users/nncarlson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/labels/area/build/cmake","name":"area/build/cmake","color":"fad8c7"},{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/labels/resolution/patch%20welcome","name":"resolution/patch welcome","color":"bfe5bf"},{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/labels/status/under%20review","name":"status/under review","color":"bfdadc"},{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/labels/type/bug","name":"type/bug","color":"f7c6c7"},{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/labels/type/enhancement","name":"type/enhancement","color":"f7c6c7"}],"state":"closed","locked":false,"assignee":{"login":"WardF","id":4324946,"avatar_url":"https://avatars.githubusercontent.com/u/4324946?v=3","gravatar_id":"","url":"https://api.github.com/users/WardF","html_url":"https://github.com/WardF","followers_url":"https://api.github.com/users/WardF/followers","following_url":"https://api.github.com/users/WardF/following{/other_user}","gists_url":"https://api.github.com/users/WardF/gists{/gist_id}","starred_url":"https://api.github.com/users/WardF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WardF/subscriptions","organizations_url":"https://api.github.com/users/WardF/orgs","repos_url":"https://api.github.com/users/WardF/repos","events_url":"https://api.github.com/users/WardF/events{/privacy}","received_events_url":"https://api.github.com/users/WardF/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/milestones/6","html_url":"https://github.com/Unidata/netcdf-fortran/milestones/4.4.4","labels_url":"https://api.github.com/repos/Unidata/netcdf-fortran/milestones/6/labels","id":1578501,"number":6,"title":"4.4.4","description":"netCDF-Fortran 4.4.4 Release","creator":{"login":"WardF","id":4324946,"avatar_url":"https://avatars.githubusercontent.com/u/4324946?v=3","gravatar_id":"","url":"https://api.github.com/users/WardF","html_url":"https://github.com/WardF","followers_url":"https://api.github.com/users/WardF/followers","following_url":"https://api.github.com/users/WardF/following{/other_user}","gists_url":"https://api.github.com/users/WardF/gists{/gist_id}","starred_url":"https://api.github.com/users/WardF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WardF/subscriptions","organizations_url":"https://api.github.com/users/WardF/orgs","repos_url":"https://api.github.com/users/WardF/repos","events_url":"https://api.github.com/users/WardF/events{/privacy}","received_events_url":"https://api.github.com/users/WardF/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2016-02-11T20:54:46Z","updated_at":"2016-02-26T22:35:45Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-02-26T16:04:31Z","updated_at":"2016-02-26T22:58:28Z","closed_at":"2016-02-26T19:54:17Z","pull_request":{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/pulls/44","html_url":"https://github.com/Unidata/netcdf-fortran/pull/44","diff_url":"https://github.com/Unidata/netcdf-fortran/pull/44.diff","patch_url":"https://github.com/Unidata/netcdf-fortran/pull/44.patch"},"body":"If USE_LOGGING=ON this is not propagated to a -DLOGGING compile line definition, which always results in an empty nf_logging.F90 file. (The NAG compiler refuses to accept an empty file.)  This commit addresses this by simply removing the #ifdef from nf_logging.F90; it seems to be unnecessary because both the cmake and autoconf configurations seem to be very careful about only including this source file when USE_LOGGING is ON.\r\n"},"comment":{"url":"https://api.github.com/repos/Unidata/netcdf-fortran/issues/comments/189517436","html_url":"https://github.com/Unidata/netcdf-fortran/pull/44#issuecomment-189517436","issue_url":"https://api.github.com/repos/Unidata/netcdf-fortran/issues/44","id":189517436,"user":{"login":"WardF","id":4324946,"avatar_url":"https://avatars.githubusercontent.com/u/4324946?v=3","gravatar_id":"","url":"https://api.github.com/users/WardF","html_url":"https://github.com/WardF","followers_url":"https://api.github.com/users/WardF/followers","following_url":"https://api.github.com/users/WardF/following{/other_user}","gists_url":"https://api.github.com/users/WardF/gists{/gist_id}","starred_url":"https://api.github.com/users/WardF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WardF/subscriptions","organizations_url":"https://api.github.com/users/WardF/orgs","repos_url":"https://api.github.com/users/WardF/repos","events_url":"https://api.github.com/users/WardF/events{/privacy}","received_events_url":"https://api.github.com/users/WardF/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T22:58:28Z","updated_at":"2016-02-26T22:58:28Z","body":"Ok, reverting this change after a fashion; it turns out the previous logic was correct.  `USE_LOGGING` is set if `nc_set_log_level` is found in the netCDF C library.  If it's not, then logging is not available.\r\n\r\nI'm adding a message to the configuration summary to make it more clear whether logging is available or not."}}