{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/remix/pulls/comments/89327334","pull_request_review_id":9871495,"id":89327334,"diff_hunk":"@@ -7,7 +9,30 @@ function DynamicByteArray () {\n }\n \n DynamicByteArray.prototype.decodeFromStorage = function (location, storageContent) {\n-  return '<not implemented yet>'\n+  var value = util.extractValue(location, storageContent, this.storageBytes)\n+  if (!value) {\n+    return '0x'\n+  }\n+  var key = util.dynamicTypePointer(location.slot)\n+  if (storageContent[key] && storageContent[key] !== '0x') {\n+    var ret = ''\n+    var length = parseInt(value) - 1\n+    var slots = Math.ceil(length / 64)","path":"src/solidity/types/DynamicByteArray.js","position":20,"original_position":20,"commit_id":"28a7fb8dd97fb748c4dbd55fcf40c1537641bcda","original_commit_id":"28a7fb8dd97fb748c4dbd55fcf40c1537641bcda","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Should be 32","created_at":"2016-11-23T14:35:44Z","updated_at":"2016-11-23T14:35:44Z","html_url":"https://github.com/ethereum/remix/pull/143#discussion_r89327334","pull_request_url":"https://api.github.com/repos/ethereum/remix/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments/89327334"},"html":{"href":"https://github.com/ethereum/remix/pull/143#discussion_r89327334"},"pull_request":{"href":"https://api.github.com/repos/ethereum/remix/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/remix/pulls/143","id":94213471,"html_url":"https://github.com/ethereum/remix/pull/143","diff_url":"https://github.com/ethereum/remix/pull/143.diff","patch_url":"https://github.com/ethereum/remix/pull/143.patch","issue_url":"https://api.github.com/repos/ethereum/remix/issues/143","number":143,"state":"open","locked":false,"title":"Decode Array/Struct [WIP]","user":{"login":"yann300","id":6940742,"avatar_url":"https://avatars.githubusercontent.com/u/6940742?v=3","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-17T17:30:16Z","updated_at":"2016-11-23T14:39:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7487020f90871686c7abeb632145978ce06eae8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/remix/pulls/143/commits","review_comments_url":"https://api.github.com/repos/ethereum/remix/pulls/143/comments","review_comment_url":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/remix/issues/143/comments","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/28a7fb8dd97fb748c4dbd55fcf40c1537641bcda","head":{"label":"ethereum:decodeArrayStruct","ref":"decodeArrayStruct","sha":"28a7fb8dd97fb748c4dbd55fcf40c1537641bcda","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2016-11-22T14:29:42Z","pushed_at":"2016-11-23T12:53:34Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"git@github.com:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":1096,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":26,"forks":27,"open_issues":26,"watchers":67,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"0261c3abc632578bf42dbe17311dee8ffbf188bf","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2016-11-22T14:29:42Z","pushed_at":"2016-11-23T12:53:34Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"git@github.com:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":1096,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":26,"forks":27,"open_issues":26,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/143"},"html":{"href":"https://github.com/ethereum/remix/pull/143"},"issue":{"href":"https://api.github.com/repos/ethereum/remix/issues/143"},"comments":{"href":"https://api.github.com/repos/ethereum/remix/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/remix/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/remix/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/remix/statuses/28a7fb8dd97fb748c4dbd55fcf40c1537641bcda"}}}}
{"actor":{"display_login":"chriseth"}}