{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8960","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8960/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8960/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8960/events","html_url":"https://github.com/cockroachdb/cockroach/pull/8960","id":174108504,"number":8960,"title":"server: expose more/all of Raft's status","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-30T19:49:39Z","updated_at":"2016-08-31T17:18:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8960","html_url":"https://github.com/cockroachdb/cockroach/pull/8960","diff_url":"https://github.com/cockroachdb/cockroach/pull/8960.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8960.patch"},"body":"\r\n![screen shot 2016-08-30 at 10 54 19 pm](https://cloud.githubusercontent.com/assets/5076964/18114376/a34a32d4-6f04-11e6-910e-c3f0c0c082df.png)\r\nSee #8111 for an instance of this being helpful. This exposes all the available\r\ndetail to the endpoint (and excerpts of it to the ui) and, together with freely\r\nchanging the logging verbosity, should leave little of Raft's internal state in\r\nthe dark.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8960)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/243835489","html_url":"https://github.com/cockroachdb/cockroach/pull/8960#issuecomment-243835489","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8960","id":243835489,"user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T17:18:16Z","updated_at":"2016-08-31T17:18:16Z","body":"\n\n\n\nReview status: 1 of 11 files reviewed at latest revision, 5 unresolved discussions, some commit checks pending.\n\n---\n\n*[server/status.go, line 658 \\[r2\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8960#-KQUAEMR69e2tV5jFj5h:-KQWYyMpaT6PAyxpigcz:b-896fix) ([raw file](https://github.com/cockroachdb/cockroach/blob/6b257c7931a51a90aa1adcc3da57edd318d85b25/server/status.go#L658)):*\n<details><summary><i>Previously, tamird (Tamir Duberstein) wrote…</i></summary>\n> https://github.com/cockroachdb/cockroach/pull/8984\n</details>\nDone.\n\n---\n\n*[server/status.go, line 691 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8960#-KQWWVcE04eXwJcvmfii:-KQWYxXvIY-_zKZLcP1O:b-896fix) ([raw file](https://github.com/cockroachdb/cockroach/blob/328b8bbea4a8c77ab21955a25f6b1f9163704bea/server/status.go#L691)):*\n<details><summary><i>Previously, tamird (Tamir Duberstein) wrote…</i></summary>\n> this can go inline below, right? ditto with `state` below.\n</details>\nDone.\n\n---\n\n*[ui/app/containers/raftRanges.tsx, line 177 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8960#-KQWUlGkheIzJ_ukiJPi:-KQWaUTn-8c7djPTZMEi:bufbjsm) ([raw file](https://github.com/cockroachdb/cockroach/blob/328b8bbea4a8c77ab21955a25f6b1f9163704bea/ui/app/containers/raftRanges.tsx#L177)):*\n<details><summary><i>Previously, tamird (Tamir Duberstein) wrote…</i></summary>\n> nit: avoid the getters since surrounding code doesn't use them\n</details>\nIf I don't use the getters, I call `toString()` on undefined objects (confirmed with @mrtracy).\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/8960)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tschottdorf"}}