{"push_id":1453945396,"size":104,"distinct_size":104,"ref":"refs/heads/amp-ooyala2","head":"82fc1306ba5c63670f33a02642abc12969840632","before":"4b1970761d58e93f7cde547746968e7e0d140684","commits":[{"sha":"627cdffa138a996647d9ad29424bb1efddf0afcf","author":{"name":"keithwrightbos","email":"0c07feb58e4e917b6458454156797618de9e6387@users.noreply.github.com"},"message":"Move all creative rendering for A4A to layoutcallback (#6249)\n\n* Initial modifications to move all creative rendering into layoutCallback; tests TBD\r\n\r\n* Fix merge issues\r\n\r\n* Test fixes\r\n\r\n* Fix tests\r\n\r\n* revert a4a examples\r\n\r\n* PR review\r\n\r\n* PR feedback\r\n\r\n* PR review\r\n\r\n* fix presubmit errors\r\n\r\n* fix test failure","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/627cdffa138a996647d9ad29424bb1efddf0afcf"},{"sha":"07648dfc35ff28e2ed3b8112aea033a75aad3d88","author":{"name":"honeybadgerdontcare","email":"6a039ded6e984a200317181c211413fd5e3e5598@users.noreply.github.com"},"message":"Remove background page persistence (#6381)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/07648dfc35ff28e2ed3b8112aea033a75aad3d88"},{"sha":"87207c271a9183317eef849e01a0f6a3783008db","author":{"name":"Justin Ridgewell","email":"eed2bcb50b307b84ffae47fb7f0b80508b902de9@ridgewell.name"},"message":"Move the iframe's box, not the wrapping AMP Element's (#6248)\n\n* Move the iframe's box, not the wrapping AMP Element's\r\n\r\nImagine the iframe's box is smaller. If we moved the AMP Element's\r\n`box`, we would have the wrong `width`/`height`, because the iframe is\r\nsmaller. So avoiding the allocation is the exact wrong thing to do.\r\n\r\n* Use CustomElement#getLayoutBox\r\n\r\n#getIntersectionElementLayoutBox isn’t appropriate to get the bounding\r\nbox.\r\n\r\n* Add test cases\r\n\r\n* Assert that the intersection is not the amp-iframe's size, but the iframe's\r\n\r\n* Comments\r\n\r\n* Fix assertion\r\n\r\n* Assert truthiness to pass type check\r\n\r\nThese will both pass, since we're measuring the box just before.\r\n\r\n* Fix presubmit error\r\n\r\n* Move Ad3p test into 3p tests","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/87207c271a9183317eef849e01a0f6a3783008db"},{"sha":"4edeae38a74f2ce674ae24d2471f66aa36dedb42","author":{"name":"Mohammad Khatib","email":"e3f649806135ab9932f4aacc1a779e7c0e73440c@gmail.com"},"message":"Allow variable substitutions in hidden fields. (#6130)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/4edeae38a74f2ce674ae24d2471f66aa36dedb42"},{"sha":"db14a74615023f0b997735dcab7765d0851fc29f","author":{"name":"Yuxuan Zhou","email":"609a0113f3eb2149eeca5ae90b83ffa7e8980c6a@users.noreply.github.com"},"message":"observe/unobserve multi elements in IntersectionObserver (#6403)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/db14a74615023f0b997735dcab7765d0851fc29f"},{"sha":"d0f26f6ee8b49adc5364af3c4214e0f982a48b32","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@google.com"},"message":"Add #amp=1 fragment to iframe URLs (#6418)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/d0f26f6ee8b49adc5364af3c4214e0f982a48b32"},{"sha":"99a372e61fb3a904992eb90097b9c169389034de","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@google.com"},"message":"Disable Visibility V2 tests due to saucelabs/integration problems (#6430)\n\n* Disable Visibility V2 tests due to saucelabs problems\r\n\r\n* tests fixed","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/99a372e61fb3a904992eb90097b9c169389034de"},{"sha":"139f5f2f000cf99399786fa8ac30113d4a333ca9","author":{"name":"Yuxuan Zhou","email":"609a0113f3eb2149eeca5ae90b83ffa7e8980c6a@users.noreply.github.com"},"message":"fix amp-anim placeholder toggle to false before `layoutCallback` (#6404)\n\n* git diff HEAD~1\r\n\r\n* fix anim placeholder\r\n\r\n* fix typo\r\n\r\n* address comment\r\n\r\n* more change\r\n\r\n* fix","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/139f5f2f000cf99399786fa8ac30113d4a333ca9"},{"sha":"08332db69531155268c55aa4696393402faa4ed0","author":{"name":"William Chou","email":"f7104039f15cbb0c3ebd55dacf81ba2ac6f2c807@google.com"},"message":"travis java workaround (#6445)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/08332db69531155268c55aa4696393402faa4ed0"},{"sha":"ff76c611b2fbcad71c5b8d9a9e850846bac6f378","author":{"name":"Terran Lane","email":"ccff1e66d00528ae98d66da979baa613a1b16803@google.com"},"message":"A4a bugfix for #6423 (#6438)\n\n* Fixed the race condition, but revealed a whole new problem.  *headdesk*\r\n\r\n* Removed extra test code to unblock AMP project testing.\r\n\r\n* Reverted .only; removed unnecessary return.","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/ff76c611b2fbcad71c5b8d9a9e850846bac6f378"},{"sha":"8e1a042ed888b8d3f1c5ab0cbaec6fdc07ac2975","author":{"name":"Mohammad Khatib","email":"e3f649806135ab9932f4aacc1a779e7c0e73440c@gmail.com"},"message":"Polyfill classList.toggle on IE (#6400)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/8e1a042ed888b8d3f1c5ab0cbaec6fdc07ac2975"},{"sha":"5e8085488498fad53a76308f8039b5d050854911","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@google.com"},"message":"Removing Unknown Error (#6428)\n\n* Removing Unknown Error\r\n\r\n* fixes","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/5e8085488498fad53a76308f8039b5d050854911"},{"sha":"17e51eeb0707f4af6f3cd57601d9f8b8b2a46680","author":{"name":"Mohammad Khatib","email":"e3f649806135ab9932f4aacc1a779e7c0e73440c@gmail.com"},"message":"Protect against undefined checkValidity (#6419)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/17e51eeb0707f4af6f3cd57601d9f8b8b2a46680"},{"sha":"81d7f96c35438367b52ab1c650e3804348588181","author":{"name":"William Chou","email":"f7104039f15cbb0c3ebd55dacf81ba2ac6f2c807@google.com"},"message":"Bind expressions (#6201)\n\n* initial bind expressions commit\r\n\r\n* fix unary op bug, started unit tests\r\n\r\n* bug fixes, unit tests for arrays\r\n\r\n* more array tests\r\n\r\n* add unary plus, fix !=, add a lot more tests\r\n\r\n* remove useless comments\r\n\r\n* initial bind expressions commit\r\n\r\n* fix unary op bug, started unit tests\r\n\r\n* bug fixes, unit tests for arrays\r\n\r\n* more array tests\r\n\r\n* add unary plus, fix !=, add a lot more tests\r\n\r\n* remove useless comments\r\n\r\n* throw error for non-whitelisted functions, return null for nested undefined member access\r\n\r\n* more unit tests\r\n\r\n* minor formatting fixes\r\n\r\n* ignore compiled bind-expr-impl.js during lint\r\n\r\n* fix lint errors in test-bind-expr.js\r\n\r\n* fix presubmit: remove ES6 startsWith/endsWith and whitelist test file\r\n\r\n* add type check for function args and unit test\r\n\r\n* expect specific error for unsupported function tests\r\n\r\n* address PR comments\r\n\r\n* more PR comments\r\n\r\n* add test for prototype fns, fix other tests\r\n\r\n* fix broken string templating in parse errors\r\n\r\n* use const/let instead of var\r\n\r\n* use a function to create whitelist map\r\n\r\n* fix lint errors\r\n\r\n* add test for ternary op","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/81d7f96c35438367b52ab1c650e3804348588181"},{"sha":"3e4be9ab530314c3d89a91557ce1590c23e486d2","author":{"name":"Ali Ghassemi","email":"028792cf7948a792d475057fc884867e01167da2@google.com"},"message":"Fix the build. Sinon can't stub methods that don't exist. (#6426)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/3e4be9ab530314c3d89a91557ce1590c23e486d2"},{"sha":"52c033391feb42f18f27278b961ce1e40cc7e662","author":{"name":"erwin mombay","email":"23b600e005da61d56b5a893bb5feebde51e1fe09@users.noreply.github.com"},"message":"Fix dev channel check (#6451)\n\n* coerce into boolean\r\n\r\n* remove files that actually dont need to be whitelisted for isDevChannel method","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/52c033391feb42f18f27278b961ce1e40cc7e662"},{"sha":"9f6eac5818116c47f82c818ae47850b40230e7ee","author":{"name":"William Chou","email":"f7104039f15cbb0c3ebd55dacf81ba2ac6f2c807@google.com"},"message":"Bind documentation (#6457)\n\n* initial commit for amp-bind documentation\r\n\r\n* PR comments\r\n\r\n* use <code> instead of backticks in html","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/9f6eac5818116c47f82c818ae47850b40230e7ee"},{"sha":"f462925ac2583538641406d8b68fee0a60c2e830","author":{"name":"bradfrizzell","email":"a4a7dbab3ccf4d9cc5f511c95e358478afb7293b@users.noreply.github.com"},"message":"Cleaned up AmpContext and IframeMessagingClient. (#6441)\n\n* Cleaned up AmpContext and IframeMessagingClient.\r\n\r\n* Made generateWindow private\r\n\r\n* Made getSentinel use a generator\r\n\r\n* Broke out messaging to separate func, fixed lint","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/f462925ac2583538641406d8b68fee0a60c2e830"},{"sha":"becc1bdecfcdb83f25ae545a3aed8f00c8af1883","author":{"name":"Ali Ghassemi","email":"028792cf7948a792d475057fc884867e01167da2@google.com"},"message":"[amp-bind]: Remove (relatively) newer functions from the whitelist. (#6459)","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/becc1bdecfcdb83f25ae545a3aed8f00c8af1883"},{"sha":"a4a2cbdbd20141bfd077ff8a8aaa2cea1bdd2a00","author":{"name":"honeybadgerdontcare","email":"6a039ded6e984a200317181c211413fd5e3e5598@users.noreply.github.com"},"message":"Remove unused `animate` attribute on `amp-accordion` (#6450)\n\n* Remove unused `animate` attribute on `amp-accordion`\r\n\r\n* Update validator-main.protoascii","distinct":true,"url":"https://api.github.com/repos/ooyala/amphtml/commits/a4a2cbdbd20141bfd077ff8a8aaa2cea1bdd2a00"}]}
{"actor":{"display_login":"aghassemi"}}