{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/80619188","pull_request_review_id":1664772,"id":80619188,"diff_hunk":"@@ -66,6 +66,9 @@ func ObjectReaction(tracker ObjectTracker, mapper meta.RESTMapper) ReactionFunc\n \treturn func(action Action) (bool, runtime.Object, error) {\n \t\tns := action.GetNamespace()\n \t\tgvr := action.GetResource()\n+\t\tif action.GetSubresource() == \"scale\" {","path":"pkg/client/testing/core/fixture.go","position":4,"original_position":4,"commit_id":"275366882f7d3823e11ea21212cda7b733ddd9e8","original_commit_id":"275366882f7d3823e11ea21212cda7b733ddd9e8","user":{"login":"fraenkel","id":929377,"avatar_url":"https://avatars.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false},"body":"I struggled with a clean way. If I treat all subresources the same, things go poorly. It seems subresources are all treated equal throughout which is why I ended up with the special case for scale. I am open to suggestions.","created_at":"2016-09-27T04:39:35Z","updated_at":"2016-09-27T04:39:35Z","html_url":"https://github.com/kubernetes/kubernetes/pull/32523#discussion_r80619188","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/80619188"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32523#discussion_r80619188"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523","id":84948228,"html_url":"https://github.com/kubernetes/kubernetes/pull/32523","diff_url":"https://github.com/kubernetes/kubernetes/pull/32523.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/32523.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523","number":32523,"state":"open","locked":false,"title":"Use scale subresource","user":{"login":"fraenkel","id":929377,"avatar_url":"https://avatars.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false},"body":"fixes #29698\r\n\r\nThis has one additional fix from the previous change which is to return the new version after the scale.\r\nSince I cannot see the actual error from the failure it is hard to say what went wrong.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/32523)\n<!-- Reviewable:end -->\n","created_at":"2016-09-12T21:29:24Z","updated_at":"2016-09-27T04:39:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f3c5cac3b745132798d063da5dea841c544d7f9","assignee":{"login":"jlowdermilk","id":2101035,"avatar_url":"https://avatars.githubusercontent.com/u/2101035?v=3","gravatar_id":"","url":"https://api.github.com/users/jlowdermilk","html_url":"https://github.com/jlowdermilk","followers_url":"https://api.github.com/users/jlowdermilk/followers","following_url":"https://api.github.com/users/jlowdermilk/following{/other_user}","gists_url":"https://api.github.com/users/jlowdermilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jlowdermilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlowdermilk/subscriptions","organizations_url":"https://api.github.com/users/jlowdermilk/orgs","repos_url":"https://api.github.com/users/jlowdermilk/repos","events_url":"https://api.github.com/users/jlowdermilk/events{/privacy}","received_events_url":"https://api.github.com/users/jlowdermilk/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlowdermilk","id":2101035,"avatar_url":"https://avatars.githubusercontent.com/u/2101035?v=3","gravatar_id":"","url":"https://api.github.com/users/jlowdermilk","html_url":"https://github.com/jlowdermilk","followers_url":"https://api.github.com/users/jlowdermilk/followers","following_url":"https://api.github.com/users/jlowdermilk/following{/other_user}","gists_url":"https://api.github.com/users/jlowdermilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jlowdermilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlowdermilk/subscriptions","organizations_url":"https://api.github.com/users/jlowdermilk/orgs","repos_url":"https://api.github.com/users/jlowdermilk/repos","events_url":"https://api.github.com/users/jlowdermilk/events{/privacy}","received_events_url":"https://api.github.com/users/jlowdermilk/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/275366882f7d3823e11ea21212cda7b733ddd9e8","head":{"label":"fraenkel:scale_subresource","ref":"scale_subresource","sha":"275366882f7d3823e11ea21212cda7b733ddd9e8","user":{"login":"fraenkel","id":929377,"avatar_url":"https://avatars.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false},"repo":{"id":64075452,"name":"kubernetes","full_name":"fraenkel/kubernetes","owner":{"login":"fraenkel","id":929377,"avatar_url":"https://avatars.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fraenkel/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/fraenkel/kubernetes","forks_url":"https://api.github.com/repos/fraenkel/kubernetes/forks","keys_url":"https://api.github.com/repos/fraenkel/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fraenkel/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fraenkel/kubernetes/teams","hooks_url":"https://api.github.com/repos/fraenkel/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/fraenkel/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/fraenkel/kubernetes/events","assignees_url":"https://api.github.com/repos/fraenkel/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/fraenkel/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/fraenkel/kubernetes/tags","blobs_url":"https://api.github.com/repos/fraenkel/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fraenkel/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fraenkel/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/fraenkel/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fraenkel/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/fraenkel/kubernetes/languages","stargazers_url":"https://api.github.com/repos/fraenkel/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/fraenkel/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/fraenkel/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/fraenkel/kubernetes/subscription","commits_url":"https://api.github.com/repos/fraenkel/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/fraenkel/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/fraenkel/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/fraenkel/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/fraenkel/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/fraenkel/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fraenkel/kubernetes/merges","archive_url":"https://api.github.com/repos/fraenkel/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fraenkel/kubernetes/downloads","issues_url":"https://api.github.com/repos/fraenkel/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/fraenkel/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/fraenkel/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/fraenkel/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fraenkel/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/fraenkel/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/fraenkel/kubernetes/deployments","created_at":"2016-07-24T16:44:21Z","updated_at":"2016-07-24T16:44:43Z","pushed_at":"2016-09-20T05:32:33Z","git_url":"git://github.com/fraenkel/kubernetes.git","ssh_url":"git@github.com:fraenkel/kubernetes.git","clone_url":"https://github.com/fraenkel/kubernetes.git","svn_url":"https://github.com/fraenkel/kubernetes","homepage":"http://kubernetes.io","size":323389,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ac8aae584d3fd1f14398e1ede499b568e9993068","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-27T04:13:47Z","pushed_at":"2016-09-27T04:13:16Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":570719,"stargazers_count":17079,"watchers_count":17079,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5535,"mirror_url":null,"open_issues_count":4619,"forks":5535,"open_issues":4619,"watchers":17079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32523"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/275366882f7d3823e11ea21212cda7b733ddd9e8"}}}}
{"actor":{"display_login":"fraenkel"}}