{"push_id":1087198054,"size":8,"distinct_size":8,"ref":"refs/heads/nvanbenschoten/typeCheck","head":"c3eb7d264926316c5fb871549a79dd285fb8fafd","before":"e8da1a6c0db941d379f4874ae6252057ee1c5c1f","commits":[{"sha":"19205f7d3097f752a528dc8ff042705b178acc32","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Implement downward type preference during type checking\n\nThis is one of the cornerstones of the Summer typing algorithm.\nType checking now takes a \"desired\" type, which is a hint to `Expr`s to\nresolve themselves as the type, if possible. It it up to the caller to\nassert that the type returned if correct, if it is actually required.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/19205f7d3097f752a528dc8ff042705b178acc32"},{"sha":"d5e2871cd5c23141ab1d96c0cadf82a6122294d4","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Split notion of pre and post-type checked expression trees\n\nThis commit adds a `TypedExpr` interface which is a superset of Expr but\ncan also perform expression evaluation and can return type annotations.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/d5e2871cd5c23141ab1d96c0cadf82a6122294d4"},{"sha":"5a01bc6dd14be3ded27fef2a2360aca069d38366","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Pull out Constant literal interface and add string-like constants\n\nThis change creates the types `NumVal` and `StrVal`, which both\nimplement the new `Constant` interface. The interface is a super-set of\n`Expr`, but includes extra methods for literal values.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/5a01bc6dd14be3ded27fef2a2360aca069d38366"},{"sha":"90b73e9e82b6b8de6ae703226db6947407fbfb8b","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Create unexpectedTypeError and define a few error situations\n\nThis commit creates a new error type to hold commonly seen errors. It\nthen uses this error in a few previously ambiguous situations.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/90b73e9e82b6b8de6ae703226db6947407fbfb8b"},{"sha":"24dc30ca496ef739d369c1442fac9dcfce5a0b6c","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Numeric constant folding now folds parentheses\n\nPreviously `(1) + 2` would not have folded to `3`, now it does.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/24dc30ca496ef739d369c1442fac9dcfce5a0b6c"},{"sha":"9805853de499a8015d2e4bf9e658e441426b519b","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Improve testing and documentation for constantFolderVisitor\n\nThis change pulls the constant related visitors into constant.go and\ncleans up a few tests.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/9805853de499a8015d2e4bf9e658e441426b519b"},{"sha":"c79250052f0832927c2eb8c6121b2c958db8837d","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Pull out operator overload sets and add lookup method\n\nThis change creates the types `unaryOpOverload`, `binOpOverload`, and\n`cmpOpOverload`, each with a lookup method for an overload\nimplementation for a given set of argument types. It also changes\n`ComparisonOp` to `ComparisonOperator` to stay consistent.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/c79250052f0832927c2eb8c6121b2c958db8837d"},{"sha":"c3eb7d264926316c5fb871549a79dd285fb8fafd","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Clean up code within the new typing system\n\nThis commit cleans up a number of uses of the new `TypedExpr` interface,\nimproves the type checking system, added new test cases, and adds in a few\nTODOs for future work.","distinct":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits/c3eb7d264926316c5fb871549a79dd285fb8fafd"}]}