{"action":"closed","number":845,"pull_request":{"url":"https://api.github.com/repos/facebook/immutable-js/pulls/845","id":66843999,"html_url":"https://github.com/facebook/immutable-js/pull/845","diff_url":"https://github.com/facebook/immutable-js/pull/845.diff","patch_url":"https://github.com/facebook/immutable-js/pull/845.patch","issue_url":"https://api.github.com/repos/facebook/immutable-js/issues/845","number":845,"state":"closed","locked":false,"title":"Improve Flow libdefs","user":{"login":"marudor","id":1881725,"avatar_url":"https://avatars.githubusercontent.com/u/1881725?v=3","gravatar_id":"","url":"https://api.github.com/users/marudor","html_url":"https://github.com/marudor","followers_url":"https://api.github.com/users/marudor/followers","following_url":"https://api.github.com/users/marudor/following{/other_user}","gists_url":"https://api.github.com/users/marudor/gists{/gist_id}","starred_url":"https://api.github.com/users/marudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marudor/subscriptions","organizations_url":"https://api.github.com/users/marudor/orgs","repos_url":"https://api.github.com/users/marudor/repos","events_url":"https://api.github.com/users/marudor/events{/privacy}","received_events_url":"https://api.github.com/users/marudor/received_events","type":"User","site_admin":false},"body":"filter is no longer declared on Iterable.\r\nThis is to degrade the Type of a Iterable to any. Mainly to allow following:\r\n```javascript\r\nfunction foo(): List<number> {\r\n   return List([undefined, 1, 2]).filter(i => i); //List no longer contains undefined. Without degrade to generic List it would error.\r\n}\r\n```\r\nflatten is also declared on each Class to return the \"correct\" type. Before Iterable was returned. This results in missing chaining.\r\n```javascript\r\nList().flatten().map() // Errored before as map is not defined on Iterable\r\n```\r\nget no longer returns ?T but T.\r\nTechnically it is not correct, but it allows common use cases and is in sync with the typescript libdef.\r\n\r\nAlso fixed bugs with get introducing undefined into the Type of a Iterable. (Ordering of overloaded function declarations is important)","created_at":"2016-04-18T12:23:03Z","updated_at":"2016-04-18T13:40:05Z","closed_at":"2016-04-18T13:40:05Z","merged_at":"2016-04-18T13:40:05Z","merge_commit_sha":"09e049b583330235773340f0ea554463b16a98e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/immutable-js/pulls/845/commits","review_comments_url":"https://api.github.com/repos/facebook/immutable-js/pulls/845/comments","review_comment_url":"https://api.github.com/repos/facebook/immutable-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/immutable-js/issues/845/comments","statuses_url":"https://api.github.com/repos/facebook/immutable-js/statuses/8902ca21182951e3a678f0845271b55ce12eef36","head":{"label":"marudor:flowTypes","ref":"flowTypes","sha":"8902ca21182951e3a678f0845271b55ce12eef36","user":{"login":"marudor","id":1881725,"avatar_url":"https://avatars.githubusercontent.com/u/1881725?v=3","gravatar_id":"","url":"https://api.github.com/users/marudor","html_url":"https://github.com/marudor","followers_url":"https://api.github.com/users/marudor/followers","following_url":"https://api.github.com/users/marudor/following{/other_user}","gists_url":"https://api.github.com/users/marudor/gists{/gist_id}","starred_url":"https://api.github.com/users/marudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marudor/subscriptions","organizations_url":"https://api.github.com/users/marudor/orgs","repos_url":"https://api.github.com/users/marudor/repos","events_url":"https://api.github.com/users/marudor/events{/privacy}","received_events_url":"https://api.github.com/users/marudor/received_events","type":"User","site_admin":false},"repo":{"id":56407138,"name":"immutable-js","full_name":"marudor/immutable-js","owner":{"login":"marudor","id":1881725,"avatar_url":"https://avatars.githubusercontent.com/u/1881725?v=3","gravatar_id":"","url":"https://api.github.com/users/marudor","html_url":"https://github.com/marudor","followers_url":"https://api.github.com/users/marudor/followers","following_url":"https://api.github.com/users/marudor/following{/other_user}","gists_url":"https://api.github.com/users/marudor/gists{/gist_id}","starred_url":"https://api.github.com/users/marudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marudor/subscriptions","organizations_url":"https://api.github.com/users/marudor/orgs","repos_url":"https://api.github.com/users/marudor/repos","events_url":"https://api.github.com/users/marudor/events{/privacy}","received_events_url":"https://api.github.com/users/marudor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marudor/immutable-js","description":"Immutable persistent data collections for Javascript which increase efficiency and simplicity.","fork":true,"url":"https://api.github.com/repos/marudor/immutable-js","forks_url":"https://api.github.com/repos/marudor/immutable-js/forks","keys_url":"https://api.github.com/repos/marudor/immutable-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marudor/immutable-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marudor/immutable-js/teams","hooks_url":"https://api.github.com/repos/marudor/immutable-js/hooks","issue_events_url":"https://api.github.com/repos/marudor/immutable-js/issues/events{/number}","events_url":"https://api.github.com/repos/marudor/immutable-js/events","assignees_url":"https://api.github.com/repos/marudor/immutable-js/assignees{/user}","branches_url":"https://api.github.com/repos/marudor/immutable-js/branches{/branch}","tags_url":"https://api.github.com/repos/marudor/immutable-js/tags","blobs_url":"https://api.github.com/repos/marudor/immutable-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marudor/immutable-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marudor/immutable-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/marudor/immutable-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marudor/immutable-js/statuses/{sha}","languages_url":"https://api.github.com/repos/marudor/immutable-js/languages","stargazers_url":"https://api.github.com/repos/marudor/immutable-js/stargazers","contributors_url":"https://api.github.com/repos/marudor/immutable-js/contributors","subscribers_url":"https://api.github.com/repos/marudor/immutable-js/subscribers","subscription_url":"https://api.github.com/repos/marudor/immutable-js/subscription","commits_url":"https://api.github.com/repos/marudor/immutable-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/marudor/immutable-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/marudor/immutable-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/marudor/immutable-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/marudor/immutable-js/contents/{+path}","compare_url":"https://api.github.com/repos/marudor/immutable-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marudor/immutable-js/merges","archive_url":"https://api.github.com/repos/marudor/immutable-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marudor/immutable-js/downloads","issues_url":"https://api.github.com/repos/marudor/immutable-js/issues{/number}","pulls_url":"https://api.github.com/repos/marudor/immutable-js/pulls{/number}","milestones_url":"https://api.github.com/repos/marudor/immutable-js/milestones{/number}","notifications_url":"https://api.github.com/repos/marudor/immutable-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marudor/immutable-js/labels{/name}","releases_url":"https://api.github.com/repos/marudor/immutable-js/releases{/id}","deployments_url":"https://api.github.com/repos/marudor/immutable-js/deployments","created_at":"2016-04-16T21:48:51Z","updated_at":"2016-04-16T21:48:53Z","pushed_at":"2016-04-18T13:16:48Z","git_url":"git://github.com/marudor/immutable-js.git","ssh_url":"git@github.com:marudor/immutable-js.git","clone_url":"https://github.com/marudor/immutable-js.git","svn_url":"https://github.com/marudor/immutable-js","homepage":"http://facebook.github.io/immutable-js/","size":17717,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"7492c7a1b42dcd5dfb3d8e4247271095880be974","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21413198,"name":"immutable-js","full_name":"facebook/immutable-js","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/immutable-js","description":"Immutable persistent data collections for Javascript which increase efficiency and simplicity.","fork":false,"url":"https://api.github.com/repos/facebook/immutable-js","forks_url":"https://api.github.com/repos/facebook/immutable-js/forks","keys_url":"https://api.github.com/repos/facebook/immutable-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/immutable-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/immutable-js/teams","hooks_url":"https://api.github.com/repos/facebook/immutable-js/hooks","issue_events_url":"https://api.github.com/repos/facebook/immutable-js/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/immutable-js/events","assignees_url":"https://api.github.com/repos/facebook/immutable-js/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/immutable-js/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/immutable-js/tags","blobs_url":"https://api.github.com/repos/facebook/immutable-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/immutable-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/immutable-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/immutable-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/immutable-js/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/immutable-js/languages","stargazers_url":"https://api.github.com/repos/facebook/immutable-js/stargazers","contributors_url":"https://api.github.com/repos/facebook/immutable-js/contributors","subscribers_url":"https://api.github.com/repos/facebook/immutable-js/subscribers","subscription_url":"https://api.github.com/repos/facebook/immutable-js/subscription","commits_url":"https://api.github.com/repos/facebook/immutable-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/immutable-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/immutable-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/immutable-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/immutable-js/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/immutable-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/immutable-js/merges","archive_url":"https://api.github.com/repos/facebook/immutable-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/immutable-js/downloads","issues_url":"https://api.github.com/repos/facebook/immutable-js/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/immutable-js/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/immutable-js/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/immutable-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/immutable-js/labels{/name}","releases_url":"https://api.github.com/repos/facebook/immutable-js/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/immutable-js/deployments","created_at":"2014-07-02T06:02:29Z","updated_at":"2016-04-18T13:03:28Z","pushed_at":"2016-04-18T13:40:05Z","git_url":"git://github.com/facebook/immutable-js.git","ssh_url":"git@github.com:facebook/immutable-js.git","clone_url":"https://github.com/facebook/immutable-js.git","svn_url":"https://github.com/facebook/immutable-js","homepage":"http://facebook.github.io/immutable-js/","size":23460,"stargazers_count":12467,"watchers_count":12467,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":616,"mirror_url":null,"open_issues_count":192,"forks":616,"open_issues":192,"watchers":12467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/845"},"html":{"href":"https://github.com/facebook/immutable-js/pull/845"},"issue":{"href":"https://api.github.com/repos/facebook/immutable-js/issues/845"},"comments":{"href":"https://api.github.com/repos/facebook/immutable-js/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/immutable-js/statuses/8902ca21182951e3a678f0845271b55ce12eef36"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leebyron","id":50130,"avatar_url":"https://avatars.githubusercontent.com/u/50130?v=3","gravatar_id":"","url":"https://api.github.com/users/leebyron","html_url":"https://github.com/leebyron","followers_url":"https://api.github.com/users/leebyron/followers","following_url":"https://api.github.com/users/leebyron/following{/other_user}","gists_url":"https://api.github.com/users/leebyron/gists{/gist_id}","starred_url":"https://api.github.com/users/leebyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leebyron/subscriptions","organizations_url":"https://api.github.com/users/leebyron/orgs","repos_url":"https://api.github.com/users/leebyron/repos","events_url":"https://api.github.com/users/leebyron/events{/privacy}","received_events_url":"https://api.github.com/users/leebyron/received_events","type":"User","site_admin":false},"comments":7,"review_comments":10,"commits":4,"additions":46,"deletions":24,"changed_files":1}}