{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/55369747","id":55369747,"diff_hunk":"@@ -75,4 +76,22 @@ describe('src/geo/leaflet/leaflet-cartodb-vector-layer-group-view.js', function\n       done();\n     });\n   });\n+  it('should call setUrl when all named map styles have been added', function () {\n+    var cartoDBLayer1 = new CartoDBLayer();\n+    var cartoDBLayer2 = new CartoDBLayer();\n+    L.CartoDBd3Layer.prototype.setUrl = jasmine.createSpy();\n+    LeafletCartoDBVectorLayerGroupView.prototype._onTileJSONChanged = function () {\n+      this.options.styles = [undefined, undefined];\n+    };\n+    this.layerGroupModel.layers = new Backbone.Collection([\n+      cartoDBLayer1,\n+      cartoDBLayer2\n+    ]);\n+    var view = new LeafletCartoDBVectorLayerGroupView(this.layerGroupModel, this.leafletMap); // eslint-disable-line\n+    this.layerGroupModel.set('type', 'namedmap');","path":"test/spec/geo/leaflet/leaflet-cartodb-vector-layer-group-view.spec.js","position":24,"original_position":24,"commit_id":"07c4aa3ca8fe32985207f54ac44490543c195f33","original_commit_id":"07c4aa3ca8fe32985207f54ac44490543c195f33","user":{"login":"alonsogarciapablo","id":390398,"avatar_url":"https://avatars.githubusercontent.com/u/390398?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsogarciapablo","html_url":"https://github.com/alonsogarciapablo","followers_url":"https://api.github.com/users/alonsogarciapablo/followers","following_url":"https://api.github.com/users/alonsogarciapablo/following{/other_user}","gists_url":"https://api.github.com/users/alonsogarciapablo/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsogarciapablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsogarciapablo/subscriptions","organizations_url":"https://api.github.com/users/alonsogarciapablo/orgs","repos_url":"https://api.github.com/users/alonsogarciapablo/repos","events_url":"https://api.github.com/users/alonsogarciapablo/events{/privacy}","received_events_url":"https://api.github.com/users/alonsogarciapablo/received_events","type":"User","site_admin":false},"body":"I don't think we need this anymore, so we can probably :fire: it.","created_at":"2016-03-08T14:58:14Z","updated_at":"2016-03-08T14:58:14Z","html_url":"https://github.com/CartoDB/cartodb.js/pull/1177#discussion_r55369747","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/55369747"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/1177#discussion_r55369747"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177","id":61744491,"html_url":"https://github.com/CartoDB/cartodb.js/pull/1177","diff_url":"https://github.com/CartoDB/cartodb.js/pull/1177.diff","patch_url":"https://github.com/CartoDB/cartodb.js/pull/1177.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1177","number":1177,"state":"closed","locked":false,"title":"[vector] Gets style from meta when map is named","user":{"login":"fdansv","id":3707222,"avatar_url":"https://avatars.githubusercontent.com/u/3707222?v=3","gravatar_id":"","url":"https://api.github.com/users/fdansv","html_url":"https://github.com/fdansv","followers_url":"https://api.github.com/users/fdansv/followers","following_url":"https://api.github.com/users/fdansv/following{/other_user}","gists_url":"https://api.github.com/users/fdansv/gists{/gist_id}","starred_url":"https://api.github.com/users/fdansv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdansv/subscriptions","organizations_url":"https://api.github.com/users/fdansv/orgs","repos_url":"https://api.github.com/users/fdansv/repos","events_url":"https://api.github.com/users/fdansv/events{/privacy}","received_events_url":"https://api.github.com/users/fdansv/received_events","type":"User","site_admin":false},"body":"Fixes #1176 \r\n\r\nNeeds merge of https://github.com/CartoDB/Windshaft/pull/457 for it to work. Merging won't break non-named maps though.","created_at":"2016-03-04T17:32:16Z","updated_at":"2016-03-08T14:58:14Z","closed_at":"2016-03-08T13:08:00Z","merged_at":"2016-03-08T13:08:00Z","merge_commit_sha":"262ffc0eb1bbddd19b09181a22f7b1535558b28e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1177/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/07c4aa3ca8fe32985207f54ac44490543c195f33","head":{"label":"CartoDB:vector-namedmaps","ref":"vector-namedmaps","sha":"07c4aa3ca8fe32985207f54ac44490543c195f33","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb.js/deployments","created_at":"2012-07-03T11:44:29Z","updated_at":"2016-02-17T22:12:42Z","pushed_at":"2016-03-08T13:08:02Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":31206,"stargazers_count":250,"watchers_count":250,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":171,"mirror_url":null,"open_issues_count":177,"forks":171,"open_issues":177,"watchers":250,"default_branch":"develop"}},"base":{"label":"CartoDB:v4","ref":"v4","sha":"9c9ce9c713be50bbd48df3586d1fdddb04c4eab7","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb.js/deployments","created_at":"2012-07-03T11:44:29Z","updated_at":"2016-02-17T22:12:42Z","pushed_at":"2016-03-08T13:08:02Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":31206,"stargazers_count":250,"watchers_count":250,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":171,"mirror_url":null,"open_issues_count":177,"forks":171,"open_issues":177,"watchers":250,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/1177"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1177"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1177/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1177/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/07c4aa3ca8fe32985207f54ac44490543c195f33"}}}}