{"action":"created","issue":{"url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1872","repository_url":"https://api.github.com/repos/africanmathsinitiative/Instat","labels_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1872/labels{/name}","comments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1872/comments","events_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1872/events","html_url":"https://github.com/africanmathsinitiative/Instat/pull/1872","id":182031940,"number":1872,"title":"Changes on the specify origin option","user":{"login":"stevenndungu","id":20383893,"avatar_url":"https://avatars.githubusercontent.com/u/20383893?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenndungu","html_url":"https://github.com/stevenndungu","followers_url":"https://api.github.com/users/stevenndungu/followers","following_url":"https://api.github.com/users/stevenndungu/following{/other_user}","gists_url":"https://api.github.com/users/stevenndungu/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenndungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenndungu/subscriptions","organizations_url":"https://api.github.com/users/stevenndungu/orgs","repos_url":"https://api.github.com/users/stevenndungu/repos","events_url":"https://api.github.com/users/stevenndungu/events{/privacy}","received_events_url":"https://api.github.com/users/stevenndungu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-10T14:39:50Z","updated_at":"2016-10-10T16:39:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1872","html_url":"https://github.com/africanmathsinitiative/Instat/pull/1872","diff_url":"https://github.com/africanmathsinitiative/Instat/pull/1872.diff","patch_url":"https://github.com/africanmathsinitiative/Instat/pull/1872.patch"},"body":"I have changed the format of origin from \"30-12-1899\" to \"1899-12-30\" for both excel and Gregorian... after noticing an anomaly in the output given.\r\ni.e\r\n\r\nas.Date(42034,origin=\"30-12-1899 (Excel)\")\r\n[1] \"0146-01-18\"\r\n> as.Date(42034,origin=\"1899-12-30(Excel)\")\r\n[1] \"2015-01-30\"\r\n\r\n \r\nAnd too put a constrain on the Single column (when specify origin is checked) to only accept numeric variables to avoid error message in case a different datatype is provided for conversion."},"comment":{"url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/comments/252674215","html_url":"https://github.com/africanmathsinitiative/Instat/pull/1872#issuecomment-252674215","issue_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1872","id":252674215,"user":{"login":"stevenndungu","id":20383893,"avatar_url":"https://avatars.githubusercontent.com/u/20383893?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenndungu","html_url":"https://github.com/stevenndungu","followers_url":"https://api.github.com/users/stevenndungu/followers","following_url":"https://api.github.com/users/stevenndungu/following{/other_user}","gists_url":"https://api.github.com/users/stevenndungu/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenndungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenndungu/subscriptions","organizations_url":"https://api.github.com/users/stevenndungu/orgs","repos_url":"https://api.github.com/users/stevenndungu/repos","events_url":"https://api.github.com/users/stevenndungu/events{/privacy}","received_events_url":"https://api.github.com/users/stevenndungu/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T16:39:06Z","updated_at":"2016-10-10T16:39:06Z","body":"Nice, will check on that with Lunalo tomorrow. Thanks.\n\nOn Mon, Oct 10, 2016 at 6:36 PM, Danny Parsons <notifications@github.com>\nwrote:\n\n> @stevenndungu <https://github.com/stevenndungu> Yes, you are right that\n> is giving the correct dates.\n> However, we would still like the combo box to display \"30-12-1899 (Excel)\"\n> because that's helpful to the user, but it should pass in origin =\n> \"1899-12-30\" to as.Date because that's the correct format for R.\n> (Although origin=\"1899-12-30(Excel) works, it's really the way origin is\n> meant to be used)\n> @Lunalo <https://github.com/Lunalo> has done this in other dialog so can\n> help with this if you need it.\n>\n> About having the receiver only as numeric when origin is specified, that's\n> a great idea to avoid the error.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/africanmathsinitiative/Instat/pull/1872#issuecomment-252658658>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ATcIlfCyARHY99vwsWOUmHMe34TBXP87ks5qyluSgaJpZM4KSoz0>\n> .\n>\n"}}
{"actor":{"display_login":"stevenndungu"}}