{"action":"created","issue":{"url":"https://api.github.com/repos/airbnb/caravel/issues/1333","repository_url":"https://api.github.com/repos/airbnb/caravel","labels_url":"https://api.github.com/repos/airbnb/caravel/issues/1333/labels{/name}","comments_url":"https://api.github.com/repos/airbnb/caravel/issues/1333/comments","events_url":"https://api.github.com/repos/airbnb/caravel/issues/1333/events","html_url":"https://github.com/airbnb/caravel/pull/1333","id":182672616,"number":1333,"title":"WIP -- [explore-v2] make chart container work with nvd3_vis.js","user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-10-13T01:23:17Z","updated_at":"2016-10-13T21:56:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/airbnb/caravel/pulls/1333","html_url":"https://github.com/airbnb/caravel/pull/1333","diff_url":"https://github.com/airbnb/caravel/pull/1333.diff","patch_url":"https://github.com/airbnb/caravel/pull/1333.patch"},"body":"this PR is a work in progress...\r\n\r\n- makes `<ChartContainer />` use existing `nvd3_vis.js` module to render charts.\r\n\r\ntodo:\r\n- [x] use vizMap object to map chart type to vis module\r\nhttps://github.com/ascott/caravel/blob/master/caravel/assets/visualizations/main.js#L3\r\n- [ ] figure out if other vis modules have other different dependencies than than the `nvd3_vis` module\r\n\r\n\r\n/exploreV2/ with line, bar, area, pie, bubble, box_plot\r\n\r\n![screenshot 2016-10-12 18 15 36](https://cloud.githubusercontent.com/assets/130878/19333228/e0a250a6-90a8-11e6-8c73-09314b98871c.png)\r\n![screenshot 2016-10-12 18 15 57](https://cloud.githubusercontent.com/assets/130878/19333232/e0a4f2fc-90a8-11e6-84e0-e16aafcd7dac.png)\r\n![screenshot 2016-10-12 18 16 21](https://cloud.githubusercontent.com/assets/130878/19333230/e0a40f4a-90a8-11e6-9eb7-f658103e4a7a.png)\r\n![screenshot 2016-10-12 18 17 06](https://cloud.githubusercontent.com/assets/130878/19333229/e0a393da-90a8-11e6-9fd9-02c12c7d7729.png)\r\n![screenshot 2016-10-12 18 17 34](https://cloud.githubusercontent.com/assets/130878/19333233/e0a6c92e-90a8-11e6-90de-86f3da9b0d91.png)\r\n![screenshot 2016-10-12 18 18 08](https://cloud.githubusercontent.com/assets/130878/19333231/e0a4b86e-90a8-11e6-94c9-c0b7beaac81a.png)\r\n\r\ncc @mistercrunch @vera-liu "},"comment":{"url":"https://api.github.com/repos/airbnb/caravel/issues/comments/253650676","html_url":"https://github.com/airbnb/caravel/pull/1333#issuecomment-253650676","issue_url":"https://api.github.com/repos/airbnb/caravel/issues/1333","id":253650676,"user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T21:56:48Z","updated_at":"2016-10-13T21:56:48Z","body":"sunburst has layout/visual issues in V2:\r\n![screenshot 2016-10-13 14 55 16](https://cloud.githubusercontent.com/assets/130878/19368525/39994c12-9155-11e6-98a4-22d096b89632.png)\r\n![screenshot 2016-10-13 14 55 59](https://cloud.githubusercontent.com/assets/130878/19368526/3999c1e2-9155-11e6-8d7b-29986dab8bb3.png)\r\n"}}
{"actor":{"display_login":"ascott"}}