{"action":"created","comment":{"url":"https://api.github.com/repos/mozillahispano/openwapp/pulls/comments/49280414","id":49280414,"diff_hunk":"@@ -366,42 +383,56 @@\n       function onMessageReceived(messageId, senderJID, content,\n                                  timestamp, wantsReceipt, senderName,\n                                  isBroadcast, authorJID) {\n-        fire('message', pub,\n-             newTextMessage(messageId, senderJID, content,\n-                            senderName, authorJID));\n+        fire('message', pub, newTextMessage(\n+          messageId,\n+          senderJID,\n+          content,\n+          timestamp,\n+          senderName,\n+          authorJID\n+        ));\n         methods.call('message_ack', [senderJID, messageId]);\n         // TODO: The pub should be the client, we need to refactor this\n         // module in order to provide the `singleton` module in a smarter way.\n       }\n \n       function onAudioReceived(messageId, senderJID, url, size,\n-                               receiptRequested, isBroadcast) {\n+                               receiptRequested, isBroadcast,\n+                               pushName, timestamp) {","path":"app/scripts/vendor/coseme-client/client.js","position":95,"original_position":95,"commit_id":"aa25fd8d8b7217572d96eea81b11f48a8587ab20","original_commit_id":"aa25fd8d8b7217572d96eea81b11f48a8587ab20","user":{"login":"naitsirch","id":1118790,"avatar_url":"https://avatars.githubusercontent.com/u/1118790?v=3","gravatar_id":"","url":"https://api.github.com/users/naitsirch","html_url":"https://github.com/naitsirch","followers_url":"https://api.github.com/users/naitsirch/followers","following_url":"https://api.github.com/users/naitsirch/following{/other_user}","gists_url":"https://api.github.com/users/naitsirch/gists{/gist_id}","starred_url":"https://api.github.com/users/naitsirch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naitsirch/subscriptions","organizations_url":"https://api.github.com/users/naitsirch/orgs","repos_url":"https://api.github.com/users/naitsirch/repos","events_url":"https://api.github.com/users/naitsirch/events{/privacy}","received_events_url":"https://api.github.com/users/naitsirch/received_events","type":"User","site_admin":false},"body":"In this quotation, `timestamp` is already the last parameter, isn't it?","created_at":"2016-01-10T19:46:01Z","updated_at":"2016-01-10T19:46:01Z","html_url":"https://github.com/mozillahispano/openwapp/pull/187#discussion_r49280414","pull_request_url":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/mozillahispano/openwapp/pulls/comments/49280414"},"html":{"href":"https://github.com/mozillahispano/openwapp/pull/187#discussion_r49280414"},"pull_request":{"href":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187","id":53901083,"html_url":"https://github.com/mozillahispano/openwapp/pull/187","diff_url":"https://github.com/mozillahispano/openwapp/pull/187.diff","patch_url":"https://github.com/mozillahispano/openwapp/pull/187.patch","issue_url":"https://api.github.com/repos/mozillahispano/openwapp/issues/187","number":187,"state":"open","locked":false,"title":"Showing and sorting by sent date instead of received date (fixes #72)","user":{"login":"naitsirch","id":1118790,"avatar_url":"https://avatars.githubusercontent.com/u/1118790?v=3","gravatar_id":"","url":"https://api.github.com/users/naitsirch","html_url":"https://github.com/naitsirch","followers_url":"https://api.github.com/users/naitsirch/followers","following_url":"https://api.github.com/users/naitsirch/following{/other_user}","gists_url":"https://api.github.com/users/naitsirch/gists{/gist_id}","starred_url":"https://api.github.com/users/naitsirch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naitsirch/subscriptions","organizations_url":"https://api.github.com/users/naitsirch/orgs","repos_url":"https://api.github.com/users/naitsirch/repos","events_url":"https://api.github.com/users/naitsirch/events{/privacy}","received_events_url":"https://api.github.com/users/naitsirch/received_events","type":"User","site_admin":false},"body":"Until now, OpenWapp displays and sorts by the date/time when messages are received. This usually unpractical if you are not always connected to the internet.\r\n\r\nThis issue was reported in #72, which this PR addresses. Instead of using the receiving date/time the sent date/time transmitted from WhatsApp will be used.\r\n\r\nThis PR depends on mozillahispano/coseme#34 and I would be happy if you could merge them both. I have tested this patch with text, image, video and audio messages. I have not tested location messages.\r\nI'd be happy if this could be tested, once again, before merging.","created_at":"2015-12-16T21:29:10Z","updated_at":"2016-01-10T19:46:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd381ebedd7428dc68b4a68aab873fa8e445f29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187/commits","review_comments_url":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187/comments","review_comment_url":"https://api.github.com/repos/mozillahispano/openwapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozillahispano/openwapp/issues/187/comments","statuses_url":"https://api.github.com/repos/mozillahispano/openwapp/statuses/aa25fd8d8b7217572d96eea81b11f48a8587ab20","head":{"label":"naitsirch:issue72_send_time","ref":"issue72_send_time","sha":"aa25fd8d8b7217572d96eea81b11f48a8587ab20","user":{"login":"naitsirch","id":1118790,"avatar_url":"https://avatars.githubusercontent.com/u/1118790?v=3","gravatar_id":"","url":"https://api.github.com/users/naitsirch","html_url":"https://github.com/naitsirch","followers_url":"https://api.github.com/users/naitsirch/followers","following_url":"https://api.github.com/users/naitsirch/following{/other_user}","gists_url":"https://api.github.com/users/naitsirch/gists{/gist_id}","starred_url":"https://api.github.com/users/naitsirch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naitsirch/subscriptions","organizations_url":"https://api.github.com/users/naitsirch/orgs","repos_url":"https://api.github.com/users/naitsirch/repos","events_url":"https://api.github.com/users/naitsirch/events{/privacy}","received_events_url":"https://api.github.com/users/naitsirch/received_events","type":"User","site_admin":false},"repo":{"id":37193556,"name":"openwapp","full_name":"naitsirch/openwapp","owner":{"login":"naitsirch","id":1118790,"avatar_url":"https://avatars.githubusercontent.com/u/1118790?v=3","gravatar_id":"","url":"https://api.github.com/users/naitsirch","html_url":"https://github.com/naitsirch","followers_url":"https://api.github.com/users/naitsirch/followers","following_url":"https://api.github.com/users/naitsirch/following{/other_user}","gists_url":"https://api.github.com/users/naitsirch/gists{/gist_id}","starred_url":"https://api.github.com/users/naitsirch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naitsirch/subscriptions","organizations_url":"https://api.github.com/users/naitsirch/orgs","repos_url":"https://api.github.com/users/naitsirch/repos","events_url":"https://api.github.com/users/naitsirch/events{/privacy}","received_events_url":"https://api.github.com/users/naitsirch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naitsirch/openwapp","description":"OpenWapp is a open client for a well-known mobile IM service","fork":true,"url":"https://api.github.com/repos/naitsirch/openwapp","forks_url":"https://api.github.com/repos/naitsirch/openwapp/forks","keys_url":"https://api.github.com/repos/naitsirch/openwapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naitsirch/openwapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naitsirch/openwapp/teams","hooks_url":"https://api.github.com/repos/naitsirch/openwapp/hooks","issue_events_url":"https://api.github.com/repos/naitsirch/openwapp/issues/events{/number}","events_url":"https://api.github.com/repos/naitsirch/openwapp/events","assignees_url":"https://api.github.com/repos/naitsirch/openwapp/assignees{/user}","branches_url":"https://api.github.com/repos/naitsirch/openwapp/branches{/branch}","tags_url":"https://api.github.com/repos/naitsirch/openwapp/tags","blobs_url":"https://api.github.com/repos/naitsirch/openwapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naitsirch/openwapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naitsirch/openwapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/naitsirch/openwapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naitsirch/openwapp/statuses/{sha}","languages_url":"https://api.github.com/repos/naitsirch/openwapp/languages","stargazers_url":"https://api.github.com/repos/naitsirch/openwapp/stargazers","contributors_url":"https://api.github.com/repos/naitsirch/openwapp/contributors","subscribers_url":"https://api.github.com/repos/naitsirch/openwapp/subscribers","subscription_url":"https://api.github.com/repos/naitsirch/openwapp/subscription","commits_url":"https://api.github.com/repos/naitsirch/openwapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/naitsirch/openwapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/naitsirch/openwapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/naitsirch/openwapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/naitsirch/openwapp/contents/{+path}","compare_url":"https://api.github.com/repos/naitsirch/openwapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naitsirch/openwapp/merges","archive_url":"https://api.github.com/repos/naitsirch/openwapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naitsirch/openwapp/downloads","issues_url":"https://api.github.com/repos/naitsirch/openwapp/issues{/number}","pulls_url":"https://api.github.com/repos/naitsirch/openwapp/pulls{/number}","milestones_url":"https://api.github.com/repos/naitsirch/openwapp/milestones{/number}","notifications_url":"https://api.github.com/repos/naitsirch/openwapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naitsirch/openwapp/labels{/name}","releases_url":"https://api.github.com/repos/naitsirch/openwapp/releases{/id}","created_at":"2015-06-10T11:38:06Z","updated_at":"2015-06-10T11:38:07Z","pushed_at":"2015-12-26T10:40:46Z","git_url":"git://github.com/naitsirch/openwapp.git","ssh_url":"git@github.com:naitsirch/openwapp.git","clone_url":"https://github.com/naitsirch/openwapp.git","svn_url":"https://github.com/naitsirch/openwapp","homepage":null,"size":1823,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozillahispano:master","ref":"master","sha":"c879e51d2609cb698e488c5fa74e90c6241b9d09","user":{"login":"mozillahispano","id":1511160,"avatar_url":"https://avatars.githubusercontent.com/u/1511160?v=3","gravatar_id":"","url":"https://api.github.com/users/mozillahispano","html_url":"https://github.com/mozillahispano","followers_url":"https://api.github.com/users/mozillahispano/followers","following_url":"https://api.github.com/users/mozillahispano/following{/other_user}","gists_url":"https://api.github.com/users/mozillahispano/gists{/gist_id}","starred_url":"https://api.github.com/users/mozillahispano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozillahispano/subscriptions","organizations_url":"https://api.github.com/users/mozillahispano/orgs","repos_url":"https://api.github.com/users/mozillahispano/repos","events_url":"https://api.github.com/users/mozillahispano/events{/privacy}","received_events_url":"https://api.github.com/users/mozillahispano/received_events","type":"Organization","site_admin":false},"repo":{"id":26063680,"name":"openwapp","full_name":"mozillahispano/openwapp","owner":{"login":"mozillahispano","id":1511160,"avatar_url":"https://avatars.githubusercontent.com/u/1511160?v=3","gravatar_id":"","url":"https://api.github.com/users/mozillahispano","html_url":"https://github.com/mozillahispano","followers_url":"https://api.github.com/users/mozillahispano/followers","following_url":"https://api.github.com/users/mozillahispano/following{/other_user}","gists_url":"https://api.github.com/users/mozillahispano/gists{/gist_id}","starred_url":"https://api.github.com/users/mozillahispano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozillahispano/subscriptions","organizations_url":"https://api.github.com/users/mozillahispano/orgs","repos_url":"https://api.github.com/users/mozillahispano/repos","events_url":"https://api.github.com/users/mozillahispano/events{/privacy}","received_events_url":"https://api.github.com/users/mozillahispano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozillahispano/openwapp","description":"OpenWapp is a open client for a well-known mobile IM service","fork":false,"url":"https://api.github.com/repos/mozillahispano/openwapp","forks_url":"https://api.github.com/repos/mozillahispano/openwapp/forks","keys_url":"https://api.github.com/repos/mozillahispano/openwapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozillahispano/openwapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozillahispano/openwapp/teams","hooks_url":"https://api.github.com/repos/mozillahispano/openwapp/hooks","issue_events_url":"https://api.github.com/repos/mozillahispano/openwapp/issues/events{/number}","events_url":"https://api.github.com/repos/mozillahispano/openwapp/events","assignees_url":"https://api.github.com/repos/mozillahispano/openwapp/assignees{/user}","branches_url":"https://api.github.com/repos/mozillahispano/openwapp/branches{/branch}","tags_url":"https://api.github.com/repos/mozillahispano/openwapp/tags","blobs_url":"https://api.github.com/repos/mozillahispano/openwapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozillahispano/openwapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozillahispano/openwapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozillahispano/openwapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozillahispano/openwapp/statuses/{sha}","languages_url":"https://api.github.com/repos/mozillahispano/openwapp/languages","stargazers_url":"https://api.github.com/repos/mozillahispano/openwapp/stargazers","contributors_url":"https://api.github.com/repos/mozillahispano/openwapp/contributors","subscribers_url":"https://api.github.com/repos/mozillahispano/openwapp/subscribers","subscription_url":"https://api.github.com/repos/mozillahispano/openwapp/subscription","commits_url":"https://api.github.com/repos/mozillahispano/openwapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozillahispano/openwapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozillahispano/openwapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozillahispano/openwapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozillahispano/openwapp/contents/{+path}","compare_url":"https://api.github.com/repos/mozillahispano/openwapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozillahispano/openwapp/merges","archive_url":"https://api.github.com/repos/mozillahispano/openwapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozillahispano/openwapp/downloads","issues_url":"https://api.github.com/repos/mozillahispano/openwapp/issues{/number}","pulls_url":"https://api.github.com/repos/mozillahispano/openwapp/pulls{/number}","milestones_url":"https://api.github.com/repos/mozillahispano/openwapp/milestones{/number}","notifications_url":"https://api.github.com/repos/mozillahispano/openwapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozillahispano/openwapp/labels{/name}","releases_url":"https://api.github.com/repos/mozillahispano/openwapp/releases{/id}","created_at":"2014-11-01T21:21:02Z","updated_at":"2015-12-10T21:13:04Z","pushed_at":"2016-01-09T12:38:03Z","git_url":"git://github.com/mozillahispano/openwapp.git","ssh_url":"git@github.com:mozillahispano/openwapp.git","clone_url":"https://github.com/mozillahispano/openwapp.git","svn_url":"https://github.com/mozillahispano/openwapp","homepage":null,"size":2086,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":47,"forks":40,"open_issues":47,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187"},"html":{"href":"https://github.com/mozillahispano/openwapp/pull/187"},"issue":{"href":"https://api.github.com/repos/mozillahispano/openwapp/issues/187"},"comments":{"href":"https://api.github.com/repos/mozillahispano/openwapp/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/mozillahispano/openwapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozillahispano/openwapp/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/mozillahispano/openwapp/statuses/aa25fd8d8b7217572d96eea81b11f48a8587ab20"}}}}