{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/928","repository_url":"https://api.github.com/repos/minetest/minetest_game","labels_url":"https://api.github.com/repos/minetest/minetest_game/issues/928/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/928/comments","events_url":"https://api.github.com/repos/minetest/minetest_game/issues/928/events","html_url":"https://github.com/minetest/minetest_game/pull/928","id":140883890,"number":928,"title":"Doors: Allow falling nodes to fall onto doors.","user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/minetest/minetest_game/labels/One%20approval","name":"One approval","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/minetest/minetest_game/milestones/1","html_url":"https://github.com/minetest/minetest_game/milestones/0.4.14","labels_url":"https://api.github.com/repos/minetest/minetest_game/milestones/1/labels","id":1618907,"number":1,"title":"0.4.14","description":"","creator":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":30,"state":"open","created_at":"2016-03-02T21:48:39Z","updated_at":"2016-03-18T02:58:07Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-03-15T06:09:40Z","updated_at":"2016-03-18T17:52:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/928","html_url":"https://github.com/minetest/minetest_game/pull/928","diff_url":"https://github.com/minetest/minetest_game/pull/928.diff","patch_url":"https://github.com/minetest/minetest_game/pull/928.patch"},"body":"We were cleverly attempting to use an airlike node as the\r\ntop half of the doors, but as airlike nodes are not walkable,\r\nfalling nodes would not stop falling and thus remain an entity\r\nstuck on top of a door.\r\n\r\nAfter inspecting the builtin/game/falling.lua code, I considered\r\nthe remaining options: (a) revert doors such that the top part is\r\nactually the door, (b) play with nodedef fields and see if other\r\nflags may work, or (c) modify the hidden door part to another\r\ndrawtype that properly prevents this issue.\r\n\r\n(a) seemed way over the top for now, although it would solve the\r\nissue, it would cause a rewrite of most of the code including the\r\nold-door-conversion.\r\n\r\n(b) turned up nothing.\r\n\r\n(c) turned out to be relatively simple.\r\n\r\nSo, here's the implementation where I turn the hidden door top\r\ninto a tiny, non-targetable but walkable nodebox that is entirely\r\ninside the door hinge. It's entirely transparent, so you still\r\ncan't see it, can't hit it, nor can you place anything in it or\r\nmake liquids flow through it. The top part is placed in the right\r\nposition on placement and not touched further.\r\n\r\nFalling nodes will properly stop on top of these doors. I've\r\nadjusted the door conversion code to properly account for the\r\nissue as well, so the only thing remaining is people who have\r\nbeen running a git branch - those can upgrade by re-placing the\r\ndoor."},"comment":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/comments/198469636","html_url":"https://github.com/minetest/minetest_game/pull/928#issuecomment-198469636","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/928","id":198469636,"user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T17:52:28Z","updated_at":"2016-03-18T17:52:28Z","body":"@rui914 without more information, I have no idea"}}