{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/39","id":59621150,"html_url":"https://github.com/strongloop/strong-control-channel/pull/39","diff_url":"https://github.com/strongloop/strong-control-channel/pull/39.diff","patch_url":"https://github.com/strongloop/strong-control-channel/pull/39.patch","issue_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues/39","number":39,"state":"closed","locked":false,"title":"Don't unref TLS sockets on v0.10 (2)","user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"body":"This is a follow-up for 956c4010a1 that fixes more places where `unref()` is called. The problem was discovered by https://github.com/strongloop/apiconnect-collective-member/pull/94.\r\n\r\n@sam-github I am going to land this without a review so that https://github.com/strongloop/apiconnect-collective-member/pull/94 can be finally landed. Let me know if you would like to make any improvements (extract shared method, add unit-tests, whatever), I can make them in a new PR.","created_at":"2016-02-17T10:08:26Z","updated_at":"2016-02-17T10:30:08Z","closed_at":"2016-02-17T10:30:08Z","merged_at":"2016-02-17T10:30:08Z","merge_commit_sha":"0010afc8a882e452ab344b7383c79d5f0d3cda87","assignee":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/39/commits","review_comments_url":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/39/comments","review_comment_url":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues/39/comments","statuses_url":"https://api.github.com/repos/strongloop/strong-control-channel/statuses/72f96583ffea196a8278d935c0fedc9eba50d2f4","head":{"label":"strongloop:fix/unref-not-defined","ref":"fix/unref-not-defined","sha":"72f96583ffea196a8278d935c0fedc9eba50d2f4","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":21912119,"name":"strong-control-channel","full_name":"strongloop/strong-control-channel","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-control-channel","description":"Run-time control channel for node applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-control-channel","forks_url":"https://api.github.com/repos/strongloop/strong-control-channel/forks","keys_url":"https://api.github.com/repos/strongloop/strong-control-channel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-control-channel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-control-channel/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-control-channel/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-control-channel/events","assignees_url":"https://api.github.com/repos/strongloop/strong-control-channel/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-control-channel/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-control-channel/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-control-channel/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-control-channel/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-control-channel/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-control-channel/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-control-channel/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-control-channel/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-control-channel/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-control-channel/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/strong-control-channel/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-control-channel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-control-channel/merges","archive_url":"https://api.github.com/repos/strongloop/strong-control-channel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-control-channel/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-control-channel/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-control-channel/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-control-channel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-control-channel/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-control-channel/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/strong-control-channel/deployments","created_at":"2014-07-16T18:26:13Z","updated_at":"2016-02-16T15:56:46Z","pushed_at":"2016-02-17T10:30:08Z","git_url":"git://github.com/strongloop/strong-control-channel.git","ssh_url":"git@github.com:strongloop/strong-control-channel.git","clone_url":"https://github.com/strongloop/strong-control-channel.git","svn_url":"https://github.com/strongloop/strong-control-channel","homepage":null,"size":147,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"fbbd60fc0a7fbbfa21b856ebc3d503b2ed4fc0e8","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":21912119,"name":"strong-control-channel","full_name":"strongloop/strong-control-channel","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-control-channel","description":"Run-time control channel for node applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-control-channel","forks_url":"https://api.github.com/repos/strongloop/strong-control-channel/forks","keys_url":"https://api.github.com/repos/strongloop/strong-control-channel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-control-channel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-control-channel/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-control-channel/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-control-channel/events","assignees_url":"https://api.github.com/repos/strongloop/strong-control-channel/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-control-channel/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-control-channel/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-control-channel/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-control-channel/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-control-channel/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-control-channel/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-control-channel/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-control-channel/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-control-channel/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-control-channel/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-control-channel/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/strong-control-channel/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-control-channel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-control-channel/merges","archive_url":"https://api.github.com/repos/strongloop/strong-control-channel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-control-channel/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-control-channel/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-control-channel/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-control-channel/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-control-channel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-control-channel/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-control-channel/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/strong-control-channel/deployments","created_at":"2014-07-16T18:26:13Z","updated_at":"2016-02-16T15:56:46Z","pushed_at":"2016-02-17T10:30:08Z","git_url":"git://github.com/strongloop/strong-control-channel.git","ssh_url":"git@github.com:strongloop/strong-control-channel.git","clone_url":"https://github.com/strongloop/strong-control-channel.git","svn_url":"https://github.com/strongloop/strong-control-channel","homepage":null,"size":147,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/39"},"html":{"href":"https://github.com/strongloop/strong-control-channel/pull/39"},"issue":{"href":"https://api.github.com/repos/strongloop/strong-control-channel/issues/39"},"comments":{"href":"https://api.github.com/repos/strongloop/strong-control-channel/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/strong-control-channel/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/strong-control-channel/statuses/72f96583ffea196a8278d935c0fedc9eba50d2f4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":1}}