{"action":"created","issue":{"url":"https://api.github.com/repos/InterruptedLobster/findAR/issues/77","repository_url":"https://api.github.com/repos/InterruptedLobster/findAR","labels_url":"https://api.github.com/repos/InterruptedLobster/findAR/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/InterruptedLobster/findAR/issues/77/comments","events_url":"https://api.github.com/repos/InterruptedLobster/findAR/issues/77/events","html_url":"https://github.com/InterruptedLobster/findAR/pull/77","id":143223707,"number":77,"title":"Feat/routing","user":{"login":"bignell","id":106692,"avatar_url":"https://avatars.githubusercontent.com/u/106692?v=3","gravatar_id":"","url":"https://api.github.com/users/bignell","html_url":"https://github.com/bignell","followers_url":"https://api.github.com/users/bignell/followers","following_url":"https://api.github.com/users/bignell/following{/other_user}","gists_url":"https://api.github.com/users/bignell/gists{/gist_id}","starred_url":"https://api.github.com/users/bignell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignell/subscriptions","organizations_url":"https://api.github.com/users/bignell/orgs","repos_url":"https://api.github.com/users/bignell/repos","events_url":"https://api.github.com/users/bignell/events{/privacy}","received_events_url":"https://api.github.com/users/bignell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/InterruptedLobster/findAR/labels/review%20me","name":"review me","color":"ff0000"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-24T11:36:48Z","updated_at":"2016-03-25T03:32:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/InterruptedLobster/findAR/pulls/77","html_url":"https://github.com/InterruptedLobster/findAR/pull/77","diff_url":"https://github.com/InterruptedLobster/findAR/pull/77.diff","patch_url":"https://github.com/InterruptedLobster/findAR/pull/77.patch"},"body":":grin: :tada: :dancer: \r\n\r\n_Changes unrelated to routing:_\r\n- [x] Removed Android-related files for now, to simplify the repo (in retrospect, I should have done this later, because it clutters the PR with about 15 deleted files. But that's what those are.)\r\n- [x] Removed unused `.flowconfig`, `.watchmanconfig` and `.travis.yml`\r\n- [x] Misc. cleanup\r\n\r\nHappy to squash these commits post-review, just wanted to keep the steps clear.\r\n\r\nResolves #35."},"comment":{"url":"https://api.github.com/repos/InterruptedLobster/findAR/issues/comments/201121714","html_url":"https://github.com/InterruptedLobster/findAR/pull/77#issuecomment-201121714","issue_url":"https://api.github.com/repos/InterruptedLobster/findAR/issues/77","id":201121714,"user":{"login":"bignell","id":106692,"avatar_url":"https://avatars.githubusercontent.com/u/106692?v=3","gravatar_id":"","url":"https://api.github.com/users/bignell","html_url":"https://github.com/bignell","followers_url":"https://api.github.com/users/bignell/followers","following_url":"https://api.github.com/users/bignell/following{/other_user}","gists_url":"https://api.github.com/users/bignell/gists{/gist_id}","starred_url":"https://api.github.com/users/bignell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignell/subscriptions","organizations_url":"https://api.github.com/users/bignell/orgs","repos_url":"https://api.github.com/users/bignell/repos","events_url":"https://api.github.com/users/bignell/events{/privacy}","received_events_url":"https://api.github.com/users/bignell/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T03:32:25Z","updated_at":"2016-03-25T03:32:25Z","body":"#### Discussion notes:\r\n1. Root-level routing with `react-native-router-flux` (this PR's implementation)\r\n    - **Pros**: built-in NavigationAnimations, external routing actions, fairly idiomatic\r\n    - **Cons**: code repetition, rendering performance questions with camera feed\r\n2. Conditional rendering inside `ViewContainer` by state\r\n    - **Pros**: DRYness & simplicity, SoC from non-pin-view screens\r\n    - **Cons**: DIY animation, less presentational control, less idiomatic\r\n\r\n#### Plan of action:\r\n\r\n- Use presentational components like `screens/MapView.js` to compose render-views\r\n- Play with conditional rendering in one standard `ViewContainer`-type file, using either a custom solution or a nested `react-native-router-flux` `Router`\r\n\r\nIn light of the new approach, I'm closing this in favor of a new PR."}}