{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/recipeasy/issues/50","repository_url":"https://api.github.com/repos/guardian/recipeasy","labels_url":"https://api.github.com/repos/guardian/recipeasy/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/guardian/recipeasy/issues/50/comments","events_url":"https://api.github.com/repos/guardian/recipeasy/issues/50/events","html_url":"https://github.com/guardian/recipeasy/pull/50","id":181464349,"number":50,"title":"Styling","user":{"login":"tsop14","id":8484757,"avatar_url":"https://avatars.githubusercontent.com/u/8484757?v=3","gravatar_id":"","url":"https://api.github.com/users/tsop14","html_url":"https://github.com/tsop14","followers_url":"https://api.github.com/users/tsop14/followers","following_url":"https://api.github.com/users/tsop14/following{/other_user}","gists_url":"https://api.github.com/users/tsop14/gists{/gist_id}","starred_url":"https://api.github.com/users/tsop14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsop14/subscriptions","organizations_url":"https://api.github.com/users/tsop14/orgs","repos_url":"https://api.github.com/users/tsop14/repos","events_url":"https://api.github.com/users/tsop14/events{/privacy}","received_events_url":"https://api.github.com/users/tsop14/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-06T16:30:33Z","updated_at":"2016-10-06T16:34:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/recipeasy/pulls/50","html_url":"https://github.com/guardian/recipeasy/pull/50","diff_url":"https://github.com/guardian/recipeasy/pull/50.diff","patch_url":"https://github.com/guardian/recipeasy/pull/50.patch"},"body":"This PR makes styling changes as per AJ's design and writes logic for using keyboard shortcuts to add ingredients/ steps. \r\n\r\n- upgrades to bootstrap 4\r\n- renames directory 'bootstrap3' to 'helper', which had made all helper html templates look like new code\r\n- replaces glyphicon (not supported in bootstrap 4) with font-awesome\r\n\r\n- corrects hard coded html in editForm.js so buttons to add/remove fields work with styling changes\r\n- uses mousetrap to add keyboard short cuts\r\n- uses jquery selection to add highlighted text to form\r\n\r\nCurrent keyboard shortcuts\r\n'i' adds a single ingredient to end of first list and tries to parse\r\n'I' - adds a list of ingredients to last list and tries to parse\r\n's' - adds a step\r\n\r\nKNOWN BUGS\r\nThis will be fixed but don't want to block PR\r\n- keyboard shortcuts do not remove empty fields\r\n- 'i' and 'I' add to different lists\r\n- styling broken on tag select\r\n\r\n\r\n\r\nINGREDIENTS\r\n![ingredient](https://cloud.githubusercontent.com/assets/8484757/19160682/ba03c336-8be8-11e6-8644-20fd69b80b91.gif)\r\n- the auto parsed ingredients\r\n- adding blank ingredient and ingredient list\r\n- removing ingredient and ingredient list\r\n- adding a list of ingredients (keyboard shortcut I)\r\n- adding an ingredient (keyboard shortcut i)\r\n\r\n\r\nSTEPS\r\n![steps](https://cloud.githubusercontent.com/assets/8484757/19160689/beaf21e6-8be8-11e6-9c19-3d8dec479b98.gif)\r\n- adding / removing steps\r\n- adding step (keyboard shortcut s)\r\n\r\n\r\nIMAGES\r\n![add-images](https://cloud.githubusercontent.com/assets/8484757/19160742/f34a6730-8be8-11e6-9e64-43e2890fd95a.gif)\r\n- adding / removing images\r\n- NB my LOCAL `image` DB table has duplicate images so in videos images are duplicated, this should not happen in PROD\r\n\r\n\r\nSOME MODERN ART I MADE WHILE TRYING TO RECORD MY SCREEN\r\n![ingredients](https://cloud.githubusercontent.com/assets/8484757/19160701/ce1b8624-8be8-11e6-9398-1514bcc25fb5.gif)\r\n- wow\r\n- poignant\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/recipeasy/issues/comments/252017633","html_url":"https://github.com/guardian/recipeasy/pull/50#issuecomment-252017633","issue_url":"https://api.github.com/repos/guardian/recipeasy/issues/50","id":252017633,"user":{"login":"alastairjardine","id":4292469,"avatar_url":"https://avatars.githubusercontent.com/u/4292469?v=3","gravatar_id":"","url":"https://api.github.com/users/alastairjardine","html_url":"https://github.com/alastairjardine","followers_url":"https://api.github.com/users/alastairjardine/followers","following_url":"https://api.github.com/users/alastairjardine/following{/other_user}","gists_url":"https://api.github.com/users/alastairjardine/gists{/gist_id}","starred_url":"https://api.github.com/users/alastairjardine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alastairjardine/subscriptions","organizations_url":"https://api.github.com/users/alastairjardine/orgs","repos_url":"https://api.github.com/users/alastairjardine/repos","events_url":"https://api.github.com/users/alastairjardine/events{/privacy}","received_events_url":"https://api.github.com/users/alastairjardine/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T16:34:20Z","updated_at":"2016-10-06T16:34:20Z","body":"Rest of the PR looks great! Anywhere I can have a play?"}}
{"actor":{"display_login":"alastairjardine"}}