{"action":"created","issue":{"url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/277","repository_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins","labels_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/277/labels{/name}","comments_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/277/comments","events_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/277/events","html_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/277","id":156436873,"number":277,"title":"[wysiwyg:toolbar] keep tooltip visible within window","user":{"login":"jl-","id":6291986,"avatar_url":"https://avatars.githubusercontent.com/u/6291986?v=3","gravatar_id":"","url":"https://api.github.com/users/jl-","html_url":"https://github.com/jl-","followers_url":"https://api.github.com/users/jl-/followers","following_url":"https://api.github.com/users/jl-/following{/other_user}","gists_url":"https://api.github.com/users/jl-/gists{/gist_id}","starred_url":"https://api.github.com/users/jl-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jl-/subscriptions","organizations_url":"https://api.github.com/users/jl-/orgs","repos_url":"https://api.github.com/users/jl-/repos","events_url":"https://api.github.com/users/jl-/events{/privacy}","received_events_url":"https://api.github.com/users/jl-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-24T07:23:54Z","updated_at":"2016-05-26T02:08:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/pulls/277","html_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/277","diff_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/277.diff","patch_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/277.patch"},"body":"when tooltip get too wide for vertical-align to the target, it would overflow to the left of window, some parts of it become invisible. this patch sets state.left = 0\r\n![qq20160524-2 2x](https://cloud.githubusercontent.com/assets/6291986/15495468/b7587130-21c2-11e6-9528-45a25d4d65fe.png)\r\n"},"comment":{"url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/comments/221759364","html_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/277#issuecomment-221759364","issue_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/277","id":221759364,"user":{"login":"jl-","id":6291986,"avatar_url":"https://avatars.githubusercontent.com/u/6291986?v=3","gravatar_id":"","url":"https://api.github.com/users/jl-","html_url":"https://github.com/jl-","followers_url":"https://api.github.com/users/jl-/followers","following_url":"https://api.github.com/users/jl-/following{/other_user}","gists_url":"https://api.github.com/users/jl-/gists{/gist_id}","starred_url":"https://api.github.com/users/jl-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jl-/subscriptions","organizations_url":"https://api.github.com/users/jl-/orgs","repos_url":"https://api.github.com/users/jl-/repos","events_url":"https://api.github.com/users/jl-/events{/privacy}","received_events_url":"https://api.github.com/users/jl-/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T02:08:33Z","updated_at":"2016-05-26T02:08:33Z","body":"![qq20160526-0 2x](https://cloud.githubusercontent.com/assets/6291986/15561008/2d2b2af8-2324-11e6-811e-d56276bf362d.png)\r\nThe `toolbar-item` is left-floated, and their containing block `toolbar` has no `width` set, so the width of `toolbar` is the same as its containing block `data[react-root]`, which is `absolute` positioned, then its containing block is either the initial containing block or `body`(if positioned). So there should be no such case that the width of `data[react-root]` would exceed the width of viewport, instead, the `toolbar-item` would float in the second line, as shown in the picture, therefore, with `left` set to `0`, that should be enough. (correct me if I'm wrong 😄 )\r\n"}}
{"actor":{"display_login":"jl-"}}