{"action":"created","issue":{"url":"https://api.github.com/repos/apigee-labs/transicator/issues/26","repository_url":"https://api.github.com/repos/apigee-labs/transicator","labels_url":"https://api.github.com/repos/apigee-labs/transicator/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/apigee-labs/transicator/issues/26/comments","events_url":"https://api.github.com/repos/apigee-labs/transicator/issues/26/events","html_url":"https://github.com/apigee-labs/transicator/pull/26","id":190119152,"number":26,"title":"Feature/viper config","user":{"login":"davent","id":1391336,"avatar_url":"https://avatars.githubusercontent.com/u/1391336?v=3","gravatar_id":"","url":"https://api.github.com/users/davent","html_url":"https://github.com/davent","followers_url":"https://api.github.com/users/davent/followers","following_url":"https://api.github.com/users/davent/following{/other_user}","gists_url":"https://api.github.com/users/davent/gists{/gist_id}","starred_url":"https://api.github.com/users/davent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davent/subscriptions","organizations_url":"https://api.github.com/users/davent/orgs","repos_url":"https://api.github.com/users/davent/repos","events_url":"https://api.github.com/users/davent/events{/privacy}","received_events_url":"https://api.github.com/users/davent/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-17T17:59:36Z","updated_at":"2016-11-18T06:44:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apigee-labs/transicator/pulls/26","html_url":"https://github.com/apigee-labs/transicator/pull/26","diff_url":"https://github.com/apigee-labs/transicator/pull/26.diff","patch_url":"https://github.com/apigee-labs/transicator/pull/26.patch"},"body":"This PR relates to: https://github.com/apigee-labs/transicator/issues/19\r\n\r\nAdds support for `spf13/viper` while maintaining backwards compatibility with the existing `flags` options.\r\n\r\n#### Examples\r\n```\r\n$ ./changeserver\r\nport => -1\r\n\r\n$ ./changeserver -p 1234\r\nport => 1234 \r\n```\r\nYou can now create either a `.json`, `.yaml`, `.toml` etc file (anything supported by Viper) called `changeserver` in either `/etc/transicator`, `~/.transicator` or `./`\r\n```\r\n$ vi /etc/transicator/changeserver.json\r\n{\r\n  \"port\": 11223\r\n}\r\n$ ./changeserver -C\r\nport => 11223\r\n```\r\nOr set an Environment Variable prefixed with `TCS_` to override all of the above\r\n```\r\n$ TCS_PORT=33221 ./changeserver -p 1234\r\nport => 33221\r\n```"},"comment":{"url":"https://api.github.com/repos/apigee-labs/transicator/issues/comments/261461000","html_url":"https://github.com/apigee-labs/transicator/pull/26#issuecomment-261461000","issue_url":"https://api.github.com/repos/apigee-labs/transicator/issues/26","id":261461000,"user":{"login":"gbrail","id":521323,"avatar_url":"https://avatars.githubusercontent.com/u/521323?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrail","html_url":"https://github.com/gbrail","followers_url":"https://api.github.com/users/gbrail/followers","following_url":"https://api.github.com/users/gbrail/following{/other_user}","gists_url":"https://api.github.com/users/gbrail/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrail/subscriptions","organizations_url":"https://api.github.com/users/gbrail/orgs","repos_url":"https://api.github.com/users/gbrail/repos","events_url":"https://api.github.com/users/gbrail/events{/privacy}","received_events_url":"https://api.github.com/users/gbrail/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T06:44:49Z","updated_at":"2016-11-18T06:44:49Z","body":"Thanks for this -- it'll be nice although I still wish Viper weren't so big.\r\n\r\nI merged the changes (there were some conflicts), updated Glide and the LICENSE file, and checked in the vendor dependencies (I'm doing this for this project because glide is too flaky to ensure a repeatable build.)\r\n\r\nI'm having two problems. Could you work on fixing them in the updated branch below (you should be able to pull and fork that, if not then there must be some other git thing that we can do)?\r\n\r\nhttps://github.com/apigee-labs/transicator/tree/seatme-viper_config\r\n\r\nTwo issues:\r\n\r\nFirst, \"make dockerTests\" doesn't pass. That's because the command-line options have changed. I don't have a problem with the changes (they're more in line with the standard) but I'd like the dockerTests to pass before we ship. (And to run those tests, you need docker...)\r\n\r\nSecond, in trying to fix the tests, I found that the \"usage\" output, as well as the output from the \"-h\" command, don't match what the options seem to be. I think that Viper must have nice ways to fix that. \r\n\r\nSo can you take a look at those two in the branch referenced above and change this PR? Thanks!"}}
{"actor":{"display_login":"gbrail"}}