{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/86983792","pull_request_review_id":7613405,"id":86983792,"diff_hunk":"@@ -172,6 +172,7 @@ module.exports = {\n         slug: {type: 'string', maxlength: 150, nullable: false, unique: true},\n         secret: {type: 'string', maxlength: 150, nullable: false},\n         redirection_uri: {type: 'string', maxlength: 2000, nullable: true},\n+        blog_uri: {type: 'string', maxlength: 2000, nullable: true},","path":"core/server/data/schema/schema.js","position":4,"original_position":4,"commit_id":"78a9501450bf8cd9bfb3e1753f87e666a3ca5ecc","original_commit_id":"b66efa91de3c72745f53898d111e388d3031f98f","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"Ok understand. Good idea.\r\nI looked at some references.\r\n\r\nhttps://developers.google.com/identity/protocols/OAuth2UserAgent\r\nhttps://developer.github.com/v3/oauth/\r\nhttps://developers.facebook.com/docs/facebook-login/manually-build-a-login-flow\r\n\r\nNobody uses or defines more then the default oauth2 spec parameters (redirect_uri, scope, client_id, client_secret, state). \r\n\r\nThen i looked into the RFC spec again\r\nhttps://tools.ietf.org/html/rfc7591\r\n\r\nThis is an example request to register a client (https://tools.ietf.org/html/rfc7591#page-16)\r\n```\r\n     POST /register HTTP/1.1\r\n     Content-Type: application/json\r\n     Accept: application/json\r\n     Host: server.example.com\r\n\r\n     {\r\n      \"redirect_uris\": [\r\n        \"https://client.example.org/callback\",\r\n        \"https://client.example.org/callback2\"],\r\n      \"client_name\": \"My Example Client\",\r\n      \"client_name#ja-Jpan-JP\":\r\n         \"\\u30AF\\u30E9\\u30A4\\u30A2\\u30F3\\u30C8\\u540D\",\r\n      \"token_endpoint_auth_method\": \"client_secret_basic\",\r\n      \"logo_uri\": \"https://client.example.org/logo.png\",\r\n      \"jwks_uri\": \"https://client.example.org/my_public_keys.jwks\",\r\n      \"example_extension_parameter\": \"example_value\"\r\n     }\r\n```\r\n^ BTW: they suggest using `client_name` and not `name`.\r\n\r\nAnd they have listed more attributes here https://tools.ietf.org/html/rfc7591#page-9\r\n\r\n```\r\n   client_uri\r\n      URL string of a web page providing information about the client.\r\n      If present, the server SHOULD display this URL to the end-user in\r\n      a clickable fashion.  It is RECOMMENDED that clients always send\r\n      this field.  The value of this field MUST point to a valid web\r\n      page.  The value of this field MAY be internationalized, as\r\n      described in Section 2.2.\r\n```\r\n\r\nSo i would change it to `client_uri` if you agree 👍 ","created_at":"2016-11-08T13:07:00Z","updated_at":"2016-11-08T13:07:00Z","html_url":"https://github.com/TryGhost/Ghost/pull/7690#discussion_r86983792","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/86983792"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/7690#discussion_r86983792"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690"}}},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690","id":92587945,"html_url":"https://github.com/TryGhost/Ghost/pull/7690","diff_url":"https://github.com/TryGhost/Ghost/pull/7690.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/7690.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7690","number":7690,"state":"open","locked":false,"title":"🎨  public client registration updates","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"refs #7654 \r\n\r\nWe have to adapt some changes to the public client registration.\r\nEspecially: updating data like blog title or urls.\r\n\r\nIn this PR i will push each change (each issue of the referred issues) into a separate commit.","created_at":"2016-11-07T14:01:03Z","updated_at":"2016-11-08T13:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65d38a114851cd5805dfb36809ed1b1f06ab7a0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7690/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/78a9501450bf8cd9bfb3e1753f87e666a3ca5ecc","head":{"label":"kirrg001:1.0.0-dev/public-client-registration-updates","ref":"1.0.0-dev/public-client-registration-updates","sha":"78a9501450bf8cd9bfb3e1753f87e666a3ca5ecc","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"repo":{"id":55587930,"name":"Ghost","full_name":"kirrg001/Ghost","owner":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirrg001/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/kirrg001/Ghost","forks_url":"https://api.github.com/repos/kirrg001/Ghost/forks","keys_url":"https://api.github.com/repos/kirrg001/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirrg001/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirrg001/Ghost/teams","hooks_url":"https://api.github.com/repos/kirrg001/Ghost/hooks","issue_events_url":"https://api.github.com/repos/kirrg001/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/kirrg001/Ghost/events","assignees_url":"https://api.github.com/repos/kirrg001/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/kirrg001/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/kirrg001/Ghost/tags","blobs_url":"https://api.github.com/repos/kirrg001/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirrg001/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirrg001/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirrg001/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirrg001/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/kirrg001/Ghost/languages","stargazers_url":"https://api.github.com/repos/kirrg001/Ghost/stargazers","contributors_url":"https://api.github.com/repos/kirrg001/Ghost/contributors","subscribers_url":"https://api.github.com/repos/kirrg001/Ghost/subscribers","subscription_url":"https://api.github.com/repos/kirrg001/Ghost/subscription","commits_url":"https://api.github.com/repos/kirrg001/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirrg001/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirrg001/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirrg001/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirrg001/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/kirrg001/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirrg001/Ghost/merges","archive_url":"https://api.github.com/repos/kirrg001/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirrg001/Ghost/downloads","issues_url":"https://api.github.com/repos/kirrg001/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/kirrg001/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/kirrg001/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/kirrg001/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirrg001/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/kirrg001/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/kirrg001/Ghost/deployments","created_at":"2016-04-06T08:16:39Z","updated_at":"2016-04-06T08:16:43Z","pushed_at":"2016-11-08T11:26:08Z","git_url":"git://github.com/kirrg001/Ghost.git","ssh_url":"git@github.com:kirrg001/Ghost.git","clone_url":"https://github.com/kirrg001/Ghost.git","svn_url":"https://github.com/kirrg001/Ghost","homepage":"https://ghost.org","size":24050,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"b3f09347e45361f87bd97076d2b57e590459bf0f","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"A simple, powerful publishing platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2016-11-08T10:09:54Z","pushed_at":"2016-11-08T11:33:20Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":72367,"stargazers_count":21100,"watchers_count":21100,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5091,"mirror_url":null,"open_issues_count":193,"forks":5091,"open_issues":193,"watchers":21100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/7690"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/7690"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/7690/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7690/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/78a9501450bf8cd9bfb3e1753f87e666a3ca5ecc"}}}}
{"actor":{"display_login":"kirrg001"}}