{"action":"closed","number":1447,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1447","id":71859377,"html_url":"https://github.com/apache/kafka/pull/1447","diff_url":"https://github.com/apache/kafka/pull/1447.diff","patch_url":"https://github.com/apache/kafka/pull/1447.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1447","number":1447,"state":"closed","locked":false,"title":"KAFKA-3769 - KStream job spending 60% of time writing metrics","user":{"login":"gfodor","id":220020,"avatar_url":"https://avatars.githubusercontent.com/u/220020?v=3","gravatar_id":"","url":"https://api.github.com/users/gfodor","html_url":"https://github.com/gfodor","followers_url":"https://api.github.com/users/gfodor/followers","following_url":"https://api.github.com/users/gfodor/following{/other_user}","gists_url":"https://api.github.com/users/gfodor/gists{/gist_id}","starred_url":"https://api.github.com/users/gfodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfodor/subscriptions","organizations_url":"https://api.github.com/users/gfodor/orgs","repos_url":"https://api.github.com/users/gfodor/repos","events_url":"https://api.github.com/users/gfodor/events{/privacy}","received_events_url":"https://api.github.com/users/gfodor/received_events","type":"User","site_admin":false},"body":"In profiling a complex Kafka Streaming job:\r\n\r\n- 50% of CPU time was found to be spent writing the metrics for process time to the process time Sensor.\r\n- 7-8% of CPU time was spent doing various unnecessary work in Fetcher.\r\n\r\nThis PR addresses the first by rolling up the process time per iteration into a single metric, and addresses the second point directly (see patch.) I think this PR is incomplete because the metric itself has changed in meaning. Additionally, the latency metrics recorded during writes to rocksdb also incur significant cost. If there is a better fix in mind, please advise.","created_at":"2016-05-30T06:51:57Z","updated_at":"2016-06-03T00:14:29Z","closed_at":"2016-06-03T00:14:29Z","merged_at":null,"merge_commit_sha":"544a24d9074d237cad387a732968c91922802b86","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1447/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1447/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1447/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/36bd9d070f1ee00ac300906de9ea02d3b56cbc12","head":{"label":"AltspaceVR:gfodor/kafka-3769","ref":"gfodor/kafka-3769","sha":"36bd9d070f1ee00ac300906de9ea02d3b56cbc12","user":{"login":"AltspaceVR","id":7229981,"avatar_url":"https://avatars.githubusercontent.com/u/7229981?v=3","gravatar_id":"","url":"https://api.github.com/users/AltspaceVR","html_url":"https://github.com/AltspaceVR","followers_url":"https://api.github.com/users/AltspaceVR/followers","following_url":"https://api.github.com/users/AltspaceVR/following{/other_user}","gists_url":"https://api.github.com/users/AltspaceVR/gists{/gist_id}","starred_url":"https://api.github.com/users/AltspaceVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AltspaceVR/subscriptions","organizations_url":"https://api.github.com/users/AltspaceVR/orgs","repos_url":"https://api.github.com/users/AltspaceVR/repos","events_url":"https://api.github.com/users/AltspaceVR/events{/privacy}","received_events_url":"https://api.github.com/users/AltspaceVR/received_events","type":"Organization","site_admin":false},"repo":{"id":57018513,"name":"kafka","full_name":"AltspaceVR/kafka","owner":{"login":"AltspaceVR","id":7229981,"avatar_url":"https://avatars.githubusercontent.com/u/7229981?v=3","gravatar_id":"","url":"https://api.github.com/users/AltspaceVR","html_url":"https://github.com/AltspaceVR","followers_url":"https://api.github.com/users/AltspaceVR/followers","following_url":"https://api.github.com/users/AltspaceVR/following{/other_user}","gists_url":"https://api.github.com/users/AltspaceVR/gists{/gist_id}","starred_url":"https://api.github.com/users/AltspaceVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AltspaceVR/subscriptions","organizations_url":"https://api.github.com/users/AltspaceVR/orgs","repos_url":"https://api.github.com/users/AltspaceVR/repos","events_url":"https://api.github.com/users/AltspaceVR/events{/privacy}","received_events_url":"https://api.github.com/users/AltspaceVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AltspaceVR/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/AltspaceVR/kafka","forks_url":"https://api.github.com/repos/AltspaceVR/kafka/forks","keys_url":"https://api.github.com/repos/AltspaceVR/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AltspaceVR/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AltspaceVR/kafka/teams","hooks_url":"https://api.github.com/repos/AltspaceVR/kafka/hooks","issue_events_url":"https://api.github.com/repos/AltspaceVR/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/AltspaceVR/kafka/events","assignees_url":"https://api.github.com/repos/AltspaceVR/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/AltspaceVR/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/AltspaceVR/kafka/tags","blobs_url":"https://api.github.com/repos/AltspaceVR/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AltspaceVR/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AltspaceVR/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/AltspaceVR/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AltspaceVR/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/AltspaceVR/kafka/languages","stargazers_url":"https://api.github.com/repos/AltspaceVR/kafka/stargazers","contributors_url":"https://api.github.com/repos/AltspaceVR/kafka/contributors","subscribers_url":"https://api.github.com/repos/AltspaceVR/kafka/subscribers","subscription_url":"https://api.github.com/repos/AltspaceVR/kafka/subscription","commits_url":"https://api.github.com/repos/AltspaceVR/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/AltspaceVR/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/AltspaceVR/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/AltspaceVR/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/AltspaceVR/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/AltspaceVR/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AltspaceVR/kafka/merges","archive_url":"https://api.github.com/repos/AltspaceVR/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AltspaceVR/kafka/downloads","issues_url":"https://api.github.com/repos/AltspaceVR/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/AltspaceVR/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/AltspaceVR/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/AltspaceVR/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AltspaceVR/kafka/labels{/name}","releases_url":"https://api.github.com/repos/AltspaceVR/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/AltspaceVR/kafka/deployments","created_at":"2016-04-25T06:53:46Z","updated_at":"2016-04-25T06:53:50Z","pushed_at":"2016-05-30T07:59:45Z","git_url":"git://github.com/AltspaceVR/kafka.git","ssh_url":"git@github.com:AltspaceVR/kafka.git","clone_url":"https://github.com/AltspaceVR/kafka.git","svn_url":"https://github.com/AltspaceVR/kafka","homepage":null,"size":30577,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"404b696bea58aca17fbe528aed03cb3c94516c39","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-06-02T18:10:55Z","pushed_at":"2016-06-03T00:14:10Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":43106,"stargazers_count":3194,"watchers_count":3194,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1954,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":189,"forks":1954,"open_issues":189,"watchers":3194,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1447"},"html":{"href":"https://github.com/apache/kafka/pull/1447"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1447"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1447/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1447/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1447/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/36bd9d070f1ee00ac300906de9ea02d3b56cbc12"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":11,"review_comments":7,"commits":1,"additions":14,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"gfodor"}}