{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/spectator/pulls/comments/77812099","id":77812099,"diff_hunk":"@@ -0,0 +1,25 @@\n+/*\n+ * Copyright 2016 Google, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\")\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.netflix.spectator.controllers.filter;\n+\n+import com.netflix.spectator.api.Measurement;\n+import com.netflix.spectator.api.Meter;\n+\n+public interface MeasurementFilter {\n+  public boolean keep(Meter meter, Measurement measurement);","path":"spectator-web/src/main/java/com/netflix/spectator/controllers/filter/MeasurementFilter.java","position":23,"original_position":23,"commit_id":"03f5031e1011e3d1374891be803ac6bb60a8355f","original_commit_id":"03f5031e1011e3d1374891be803ac6bb60a8355f","user":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"body":"Why are both needed as part of the filter?","created_at":"2016-09-07T12:32:25Z","updated_at":"2016-09-07T12:32:25Z","html_url":"https://github.com/Netflix/spectator/pull/318#discussion_r77812099","pull_request_url":"https://api.github.com/repos/Netflix/spectator/pulls/318","_links":{"self":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/comments/77812099"},"html":{"href":"https://github.com/Netflix/spectator/pull/318#discussion_r77812099"},"pull_request":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/318"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/spectator/pulls/318","id":84130659,"html_url":"https://github.com/Netflix/spectator/pull/318","diff_url":"https://github.com/Netflix/spectator/pull/318.diff","patch_url":"https://github.com/Netflix/spectator/pull/318.patch","issue_url":"https://api.github.com/repos/Netflix/spectator/issues/318","number":318,"state":"open","locked":false,"title":"Added spectator-web","user":{"login":"ewiseblatt","id":4367384,"avatar_url":"https://avatars.githubusercontent.com/u/4367384?v=3","gravatar_id":"","url":"https://api.github.com/users/ewiseblatt","html_url":"https://github.com/ewiseblatt","followers_url":"https://api.github.com/users/ewiseblatt/followers","following_url":"https://api.github.com/users/ewiseblatt/following{/other_user}","gists_url":"https://api.github.com/users/ewiseblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ewiseblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewiseblatt/subscriptions","organizations_url":"https://api.github.com/users/ewiseblatt/orgs","repos_url":"https://api.github.com/users/ewiseblatt/repos","events_url":"https://api.github.com/users/ewiseblatt/events{/privacy}","received_events_url":"https://api.github.com/users/ewiseblatt/received_events","type":"User","site_admin":false},"body":"This module adds a /spectator/metrics HTTP endpoint that returns a different\r\nJSON encoding than spring boot's /metrics endpoint. The JSON encoding contains\r\na richer representation of the registry to enlighten external observers.\r\n\r\nThe endpoint supports some filtering mechanisms to restrict the domain of\r\nmetrics exposed if the caller is only interested in particular metrics.\r\n\r\n@brharrington please review.\r\nNote the runtime is in java as everything else here, but the tests are in groovy which nothing else seems to be. I presume that is ok.\r\n\r\n@cfieber FYI","created_at":"2016-09-06T14:17:41Z","updated_at":"2016-09-07T12:32:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2aee4fc81202e6e498359df453c130f3d6e01e01","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/spectator/pulls/318/commits","review_comments_url":"https://api.github.com/repos/Netflix/spectator/pulls/318/comments","review_comment_url":"https://api.github.com/repos/Netflix/spectator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/spectator/issues/318/comments","statuses_url":"https://api.github.com/repos/Netflix/spectator/statuses/03f5031e1011e3d1374891be803ac6bb60a8355f","head":{"label":"ewiseblatt:spectator-web","ref":"spectator-web","sha":"03f5031e1011e3d1374891be803ac6bb60a8355f","user":{"login":"ewiseblatt","id":4367384,"avatar_url":"https://avatars.githubusercontent.com/u/4367384?v=3","gravatar_id":"","url":"https://api.github.com/users/ewiseblatt","html_url":"https://github.com/ewiseblatt","followers_url":"https://api.github.com/users/ewiseblatt/followers","following_url":"https://api.github.com/users/ewiseblatt/following{/other_user}","gists_url":"https://api.github.com/users/ewiseblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ewiseblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewiseblatt/subscriptions","organizations_url":"https://api.github.com/users/ewiseblatt/orgs","repos_url":"https://api.github.com/users/ewiseblatt/repos","events_url":"https://api.github.com/users/ewiseblatt/events{/privacy}","received_events_url":"https://api.github.com/users/ewiseblatt/received_events","type":"User","site_admin":false},"repo":{"id":56634485,"name":"spectator","full_name":"ewiseblatt/spectator","owner":{"login":"ewiseblatt","id":4367384,"avatar_url":"https://avatars.githubusercontent.com/u/4367384?v=3","gravatar_id":"","url":"https://api.github.com/users/ewiseblatt","html_url":"https://github.com/ewiseblatt","followers_url":"https://api.github.com/users/ewiseblatt/followers","following_url":"https://api.github.com/users/ewiseblatt/following{/other_user}","gists_url":"https://api.github.com/users/ewiseblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ewiseblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewiseblatt/subscriptions","organizations_url":"https://api.github.com/users/ewiseblatt/orgs","repos_url":"https://api.github.com/users/ewiseblatt/repos","events_url":"https://api.github.com/users/ewiseblatt/events{/privacy}","received_events_url":"https://api.github.com/users/ewiseblatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewiseblatt/spectator","description":"","fork":true,"url":"https://api.github.com/repos/ewiseblatt/spectator","forks_url":"https://api.github.com/repos/ewiseblatt/spectator/forks","keys_url":"https://api.github.com/repos/ewiseblatt/spectator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewiseblatt/spectator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewiseblatt/spectator/teams","hooks_url":"https://api.github.com/repos/ewiseblatt/spectator/hooks","issue_events_url":"https://api.github.com/repos/ewiseblatt/spectator/issues/events{/number}","events_url":"https://api.github.com/repos/ewiseblatt/spectator/events","assignees_url":"https://api.github.com/repos/ewiseblatt/spectator/assignees{/user}","branches_url":"https://api.github.com/repos/ewiseblatt/spectator/branches{/branch}","tags_url":"https://api.github.com/repos/ewiseblatt/spectator/tags","blobs_url":"https://api.github.com/repos/ewiseblatt/spectator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewiseblatt/spectator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewiseblatt/spectator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewiseblatt/spectator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewiseblatt/spectator/statuses/{sha}","languages_url":"https://api.github.com/repos/ewiseblatt/spectator/languages","stargazers_url":"https://api.github.com/repos/ewiseblatt/spectator/stargazers","contributors_url":"https://api.github.com/repos/ewiseblatt/spectator/contributors","subscribers_url":"https://api.github.com/repos/ewiseblatt/spectator/subscribers","subscription_url":"https://api.github.com/repos/ewiseblatt/spectator/subscription","commits_url":"https://api.github.com/repos/ewiseblatt/spectator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewiseblatt/spectator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewiseblatt/spectator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewiseblatt/spectator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewiseblatt/spectator/contents/{+path}","compare_url":"https://api.github.com/repos/ewiseblatt/spectator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewiseblatt/spectator/merges","archive_url":"https://api.github.com/repos/ewiseblatt/spectator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewiseblatt/spectator/downloads","issues_url":"https://api.github.com/repos/ewiseblatt/spectator/issues{/number}","pulls_url":"https://api.github.com/repos/ewiseblatt/spectator/pulls{/number}","milestones_url":"https://api.github.com/repos/ewiseblatt/spectator/milestones{/number}","notifications_url":"https://api.github.com/repos/ewiseblatt/spectator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewiseblatt/spectator/labels{/name}","releases_url":"https://api.github.com/repos/ewiseblatt/spectator/releases{/id}","deployments_url":"https://api.github.com/repos/ewiseblatt/spectator/deployments","created_at":"2016-04-19T21:48:29Z","updated_at":"2016-04-19T21:48:30Z","pushed_at":"2016-09-06T14:12:19Z","git_url":"git://github.com/ewiseblatt/spectator.git","ssh_url":"git@github.com:ewiseblatt/spectator.git","clone_url":"https://github.com/ewiseblatt/spectator.git","svn_url":"https://github.com/ewiseblatt/spectator","homepage":"","size":7768,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"7176aa153ceb035aeea82e6813b03e7af6373161","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":21993347,"name":"spectator","full_name":"Netflix/spectator","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/spectator","description":"","fork":false,"url":"https://api.github.com/repos/Netflix/spectator","forks_url":"https://api.github.com/repos/Netflix/spectator/forks","keys_url":"https://api.github.com/repos/Netflix/spectator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/spectator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/spectator/teams","hooks_url":"https://api.github.com/repos/Netflix/spectator/hooks","issue_events_url":"https://api.github.com/repos/Netflix/spectator/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/spectator/events","assignees_url":"https://api.github.com/repos/Netflix/spectator/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/spectator/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/spectator/tags","blobs_url":"https://api.github.com/repos/Netflix/spectator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/spectator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/spectator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/spectator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/spectator/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/spectator/languages","stargazers_url":"https://api.github.com/repos/Netflix/spectator/stargazers","contributors_url":"https://api.github.com/repos/Netflix/spectator/contributors","subscribers_url":"https://api.github.com/repos/Netflix/spectator/subscribers","subscription_url":"https://api.github.com/repos/Netflix/spectator/subscription","commits_url":"https://api.github.com/repos/Netflix/spectator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/spectator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/spectator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/spectator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/spectator/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/spectator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/spectator/merges","archive_url":"https://api.github.com/repos/Netflix/spectator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/spectator/downloads","issues_url":"https://api.github.com/repos/Netflix/spectator/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/spectator/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/spectator/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/spectator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/spectator/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/spectator/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/spectator/deployments","created_at":"2014-07-18T20:22:53Z","updated_at":"2016-09-07T09:52:20Z","pushed_at":"2016-09-06T14:17:41Z","git_url":"git://github.com/Netflix/spectator.git","ssh_url":"git@github.com:Netflix/spectator.git","clone_url":"https://github.com/Netflix/spectator.git","svn_url":"https://github.com/Netflix/spectator","homepage":"","size":8609,"stargazers_count":89,"watchers_count":89,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":13,"forks":30,"open_issues":13,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/318"},"html":{"href":"https://github.com/Netflix/spectator/pull/318"},"issue":{"href":"https://api.github.com/repos/Netflix/spectator/issues/318"},"comments":{"href":"https://api.github.com/repos/Netflix/spectator/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/spectator/statuses/03f5031e1011e3d1374891be803ac6bb60a8355f"}}}}
{"actor":{"display_login":"brharrington"}}