{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/70877759","id":70877759,"diff_hunk":"@@ -26,26 +26,22 @@ import org.gradle.api.tasks.OutputFile\n import org.gradle.api.tasks.ParallelizableTask\n import org.gradle.initialization.BuildCancellationToken\n import org.gradle.internal.nativeintegration.filesystem.FileSystem\n+import org.gradle.test.fixtures.AbstractProjectBuilderSpec\n import org.gradle.test.fixtures.ConcurrentTestUtil\n import org.gradle.test.fixtures.file.TestFile\n-import org.gradle.test.fixtures.file.TestNameTestDirectoryProvider\n import org.gradle.testfixtures.internal.NativeServicesTestFixture\n import org.gradle.util.Requires\n import org.gradle.util.TestPrecondition\n-import org.junit.Rule\n-import spock.lang.Specification\n \n import static org.gradle.util.TestUtil.createChildProject\n import static org.gradle.util.TestUtil.createRootProject\n \n-class DefaultTaskExecutionPlanParallelTaskHandlingTest extends Specification {\n+class DefaultTaskExecutionPlanParallelTaskHandlingTest extends AbstractProjectBuilderSpec {\n \n-    @Rule\n-    TestNameTestDirectoryProvider tmp = new TestNameTestDirectoryProvider()\n     FileSystem fs = NativeServicesTestFixture.instance.get(FileSystem)\n \n     DefaultTaskExecutionPlan executionPlan = new DefaultTaskExecutionPlan(Stub(BuildCancellationToken), true)\n-    ProjectInternal root = createRootProject()\n+    ProjectInternal root = createRootProject(temporaryFolder.testDirectory)","path":"subprojects/core/src/test/groovy/org/gradle/execution/taskgraph/DefaultTaskExecutionPlanParallelTaskHandlingTest.groovy","position":26,"original_position":26,"commit_id":"c1372880215b0f4524deac79a837b94b83a9afe5","original_commit_id":"c1372880215b0f4524deac79a837b94b83a9afe5","user":{"login":"wolfs","id":423186,"avatar_url":"https://avatars.githubusercontent.com/u/423186?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfs","html_url":"https://github.com/wolfs","followers_url":"https://api.github.com/users/wolfs/followers","following_url":"https://api.github.com/users/wolfs/following{/other_user}","gists_url":"https://api.github.com/users/wolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfs/subscriptions","organizations_url":"https://api.github.com/users/wolfs/orgs","repos_url":"https://api.github.com/users/wolfs/repos","events_url":"https://api.github.com/users/wolfs/events{/privacy}","received_events_url":"https://api.github.com/users/wolfs/received_events","type":"User","site_admin":false},"body":"Not yet initialized, this happens only in `setup`.","created_at":"2016-07-14T20:29:23Z","updated_at":"2016-07-14T20:29:23Z","html_url":"https://github.com/gradle/gradle/pull/672#discussion_r70877759","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/70877759"},"html":{"href":"https://github.com/gradle/gradle/pull/672#discussion_r70877759"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/672","id":77094313,"html_url":"https://github.com/gradle/gradle/pull/672","diff_url":"https://github.com/gradle/gradle/pull/672.diff","patch_url":"https://github.com/gradle/gradle/pull/672.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/672","number":672,"state":"open","locked":false,"title":"Remove deprecated methods on TestUtil","user":{"login":"wolfs","id":423186,"avatar_url":"https://avatars.githubusercontent.com/u/423186?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfs","html_url":"https://github.com/wolfs","followers_url":"https://api.github.com/users/wolfs/followers","following_url":"https://api.github.com/users/wolfs/following{/other_user}","gists_url":"https://api.github.com/users/wolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfs/subscriptions","organizations_url":"https://api.github.com/users/wolfs/orgs","repos_url":"https://api.github.com/users/wolfs/repos","events_url":"https://api.github.com/users/wolfs/events{/privacy}","received_events_url":"https://api.github.com/users/wolfs/received_events","type":"User","site_admin":false},"body":"Any of the checked boxes below indicate that I took action:\r\n\r\n- [ ] Reviewed the [Contribution Guidelines](https://github.com/gradle/gradle/blob/master/CONTRIBUTING.md#contribution-workflow).\r\n- [ ] Signed the [Gradle CLA](http://gradle.org/contributor-license-agreement/).\r\n- [ ] Ensured that basic checks pass: `./gradlew quickCheck`\r\n\r\nFor all non-trivial changes that modify the behavior or public API:\r\n\r\n- [ ] Before submitting a pull request, I started a discussion on the\r\n[Gradle developer list](https://groups.google.com/forum/#!forum/gradle-dev)\r\nor can reference a [JIRA issue](https://issues.gradle.org/secure/Dashboard.jspa).\r\n- [ ] I wrote a design document. A design document can be\r\nbrief but explains the use case or problem you are trying to solve,\r\ntouches on the planned implementation approach as well as the test cases\r\nthat verify the behavior. Optimally, design documents should be submitted\r\nas a separate pull request. [Samples](https://github.com/gradle/gradle/tree/master/design-docs)\r\ncan be found in the Gradle GitHub repository. Please let us know if you need help with\r\ncreating the design document. We are happy to help!\r\n- [ ] The pull request contains an appropriate level of unit and integration\r\ntest coverage to verify the behavior. Before submitting the pull request\r\nI ran a build on your local machine via the command\r\n`./gradlew quickCheck <impacted-subproject>:check`.\r\n- [ ] The pull request updates the Gradle documentation like user guide,\r\nDSL reference and Javadocs where applicable.\r\n\r\nIn order to use project builder correctly without having\r\nleaking files on windows it is necessary to initialize\r\nthe test fixture for NativeServices and clean up\r\nthe test directory after building.\r\nAbstractProjectBuilderSpec provides a nice base class\r\nfor Groovy tests.\r\n\r\nI remove the deprecated methods since using them leads\r\nto files lying around. Migrating all the usages to the \"new\"\r\nway ensures it is used correctly.","created_at":"2016-07-12T10:14:14Z","updated_at":"2016-07-14T20:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c74834b2d94839ab4afbb8759f68daa28c107fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/672/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/672/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/672/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/c1372880215b0f4524deac79a837b94b83a9afe5","head":{"label":"wolfs:testutil-remove-deprecated","ref":"testutil-remove-deprecated","sha":"c1372880215b0f4524deac79a837b94b83a9afe5","user":{"login":"wolfs","id":423186,"avatar_url":"https://avatars.githubusercontent.com/u/423186?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfs","html_url":"https://github.com/wolfs","followers_url":"https://api.github.com/users/wolfs/followers","following_url":"https://api.github.com/users/wolfs/following{/other_user}","gists_url":"https://api.github.com/users/wolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfs/subscriptions","organizations_url":"https://api.github.com/users/wolfs/orgs","repos_url":"https://api.github.com/users/wolfs/repos","events_url":"https://api.github.com/users/wolfs/events{/privacy}","received_events_url":"https://api.github.com/users/wolfs/received_events","type":"User","site_admin":false},"repo":{"id":1838247,"name":"gradle","full_name":"wolfs/gradle","owner":{"login":"wolfs","id":423186,"avatar_url":"https://avatars.githubusercontent.com/u/423186?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfs","html_url":"https://github.com/wolfs","followers_url":"https://api.github.com/users/wolfs/followers","following_url":"https://api.github.com/users/wolfs/following{/other_user}","gists_url":"https://api.github.com/users/wolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfs/subscriptions","organizations_url":"https://api.github.com/users/wolfs/orgs","repos_url":"https://api.github.com/users/wolfs/repos","events_url":"https://api.github.com/users/wolfs/events{/privacy}","received_events_url":"https://api.github.com/users/wolfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wolfs/gradle","description":"A powerful build system for the JVM","fork":true,"url":"https://api.github.com/repos/wolfs/gradle","forks_url":"https://api.github.com/repos/wolfs/gradle/forks","keys_url":"https://api.github.com/repos/wolfs/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfs/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfs/gradle/teams","hooks_url":"https://api.github.com/repos/wolfs/gradle/hooks","issue_events_url":"https://api.github.com/repos/wolfs/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/wolfs/gradle/events","assignees_url":"https://api.github.com/repos/wolfs/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/wolfs/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/wolfs/gradle/tags","blobs_url":"https://api.github.com/repos/wolfs/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfs/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfs/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfs/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfs/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfs/gradle/languages","stargazers_url":"https://api.github.com/repos/wolfs/gradle/stargazers","contributors_url":"https://api.github.com/repos/wolfs/gradle/contributors","subscribers_url":"https://api.github.com/repos/wolfs/gradle/subscribers","subscription_url":"https://api.github.com/repos/wolfs/gradle/subscription","commits_url":"https://api.github.com/repos/wolfs/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfs/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfs/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfs/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfs/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/wolfs/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfs/gradle/merges","archive_url":"https://api.github.com/repos/wolfs/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfs/gradle/downloads","issues_url":"https://api.github.com/repos/wolfs/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/wolfs/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfs/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfs/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfs/gradle/labels{/name}","releases_url":"https://api.github.com/repos/wolfs/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/wolfs/gradle/deployments","created_at":"2011-06-02T16:59:33Z","updated_at":"2013-08-01T07:16:00Z","pushed_at":"2016-07-12T10:01:02Z","git_url":"git://github.com/wolfs/gradle.git","ssh_url":"git@github.com:wolfs/gradle.git","clone_url":"https://github.com/wolfs/gradle.git","svn_url":"https://github.com/wolfs/gradle","homepage":"www.gradle.org","size":140889,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"b809c02f19e68fdee7a47dc0da3eef76aa6bc8c7","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"A powerful build system for the JVM","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2016-07-14T07:49:16Z","pushed_at":"2016-07-14T18:47:22Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"gradle.org","size":189114,"stargazers_count":3680,"watchers_count":3680,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1440,"mirror_url":null,"open_issues_count":22,"forks":1440,"open_issues":22,"watchers":3680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/672"},"html":{"href":"https://github.com/gradle/gradle/pull/672"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/672"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/c1372880215b0f4524deac79a837b94b83a9afe5"}}}}
{"actor":{"display_login":"wolfs"}}