{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/52110716","id":52110716,"diff_hunk":"@@ -172,31 +171,25 @@ item::item(const std::string new_type, int turn, bool rand)\n     }\n }\n \n-void item::make_corpse( const mtype_id& mt, unsigned int turn )\n+item item::make_corpse( const mtype_id& mt, int turn, const std::string &name )\n {\n     if( !mt.is_valid() ) {\n         debugmsg( \"tried to make a corpse with an invalid mtype id\" );\n     }\n-    const bool isReviveSpecial = one_in( 20 );\n-    init();\n-    make( \"corpse\" );\n-    corpse = &mt.obj();\n-    active = corpse->has_flag( MF_REVIVES );\n-    if( active && isReviveSpecial ) {\n-        item_tags.insert( \"REVIVE_SPECIAL\" );\n+\n+    item result( \"corpse\", turn >= 0 ? turn : int( calendar::turn ) );\n+    result.corpse = &mt.obj();\n+\n+    result.active = result.corpse->has_flag( MF_REVIVES );\n+    if( result.active && one_in( 20 ) ) {\n+        result.item_tags.insert( \"REVIVE_SPECIAL\" );\n     }\n-    bday = turn;\n-}\n \n-void item::make_corpse( const mtype_id& mt, unsigned int turn, const std::string &name )\n-{\n-    make_corpse( mt, turn );\n-    this->name = name;","path":"src/item.cpp","position":45,"original_position":45,"commit_id":"6019f00da745e85008d13c56838bdaba94fde34a","original_commit_id":"9869e8242d6c50135bb779693b9b10e883465531","user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"body":"BTW, this is where it was being reset before.","created_at":"2016-02-07T01:19:40Z","updated_at":"2016-02-07T01:19:40Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15197#discussion_r52110716","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/52110716"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15197#discussion_r52110716"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197","id":58039056,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15197","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15197.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15197.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15197","number":15197,"state":"open","locked":false,"title":"Refactor item class [CR]","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"body":"This PR starts work on refactoring the `item` class\r\n\r\n* Converts `item::make_corpse` into static member function\r\n* Drop `item::init` in favor of C++11 member initialization\r\n* Drop the union (`poision`, `bigness`, `frequency`, `note`, `irridation`)","created_at":"2016-02-02T19:43:07Z","updated_at":"2016-02-07T01:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47f89bfb36897c88ddaf3ab092c450a0eabf2837","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15197/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/6019f00da745e85008d13c56838bdaba94fde34a","head":{"label":"mugling:item1","ref":"item1","sha":"6019f00da745e85008d13c56838bdaba94fde34a","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"repo":{"id":35048130,"name":"Cataclysm-DDA","full_name":"mugling/Cataclysm-DDA","owner":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mugling/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/mugling/Cataclysm-DDA","forks_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/deployments","created_at":"2015-05-04T17:12:42Z","updated_at":"2016-01-12T23:34:36Z","pushed_at":"2016-02-07T01:05:47Z","git_url":"git://github.com/mugling/Cataclysm-DDA.git","ssh_url":"git@github.com:mugling/Cataclysm-DDA.git","clone_url":"https://github.com/mugling/Cataclysm-DDA.git","svn_url":"https://github.com/mugling/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":692427,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"935039ef05fbd018d44bfc8fdbaa7d37e03acc33","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-02-06T23:10:22Z","pushed_at":"2016-02-07T01:19:12Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":941977,"stargazers_count":866,"watchers_count":866,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":853,"mirror_url":null,"open_issues_count":1295,"forks":853,"open_issues":1295,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15197"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15197"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15197/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15197/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/6019f00da745e85008d13c56838bdaba94fde34a"}}}}