{"action":"opened","issue":{"url":"https://api.github.com/repos/tecbot/gorocksdb/issues/51","repository_url":"https://api.github.com/repos/tecbot/gorocksdb","labels_url":"https://api.github.com/repos/tecbot/gorocksdb/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/tecbot/gorocksdb/issues/51/comments","events_url":"https://api.github.com/repos/tecbot/gorocksdb/issues/51/events","html_url":"https://github.com/tecbot/gorocksdb/issues/51","id":157931881,"number":51,"title":"panic from (*Options) Destroy()","user":{"login":"mschoch","id":298143,"avatar_url":"https://avatars.githubusercontent.com/u/298143?v=3","gravatar_id":"","url":"https://api.github.com/users/mschoch","html_url":"https://github.com/mschoch","followers_url":"https://api.github.com/users/mschoch/followers","following_url":"https://api.github.com/users/mschoch/following{/other_user}","gists_url":"https://api.github.com/users/mschoch/gists{/gist_id}","starred_url":"https://api.github.com/users/mschoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschoch/subscriptions","organizations_url":"https://api.github.com/users/mschoch/orgs","repos_url":"https://api.github.com/users/mschoch/repos","events_url":"https://api.github.com/users/mschoch/events{/privacy}","received_events_url":"https://api.github.com/users/mschoch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-01T15:09:23Z","updated_at":"2016-06-01T15:09:23Z","closed_at":null,"body":"In bleve we use gorocksdb with a merge operator.   Everything works fine until shutdown/cleanup time when we invoke Destroy() on the options object.\r\n\r\nThe related bleve issue is here: https://github.com/blevesearch/bleve/issues/332\r\n\r\nIt comes from this line in gorocksdb: https://github.com/tecbot/gorocksdb/blob/master/options.go#L991\r\n\r\nI have looked into this issue on the rocksdb side, and learned that `rocksdb_mergeoperator_destroy()` is not intended to be called on a merge operators that have been passed to `rocksdb_options_set_merge_operator()`.\r\n\r\nYou can find a facebook developer stating this in this thread: https://github.com/facebook/rocksdb/issues/343\r\n\r\nWe've worked around the issue temporarily by skipping Destroy(), but I feel the correct fix is in gorocksdb itself."}}
{"actor":{"display_login":"mschoch"}}