{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-eagle/pulls/comments/92778592","pull_request_review_id":13299105,"id":92778592,"diff_hunk":"@@ -35,7 +40,16 @@ public MRHistoryJobApplication getApplication() {\n     }\r\n \r\n     @Override\r\n-    public Optional<HealthCheck> getAppHealthCheck(Config config) {\r\n+    public Optional<HealthCheck> getManagedHealthCheck(Config config) {\r\n         return Optional.of(new MRHistoryJobApplicationHealthCheck(config));\r\n     }\r\n+\r\n+    @Override\r\n+    public Optional<List<Service>> getSharedServices(Config envConfig) {\r","path":"eagle-jpm/eagle-jpm-mr-history/src/main/java/org/apache/eagle/jpm/mr/history/MRHistoryJobApplicationProvider.java","position":26,"original_position":26,"commit_id":"ff8243b74f1474a7bbbc11e40922d7be9822de42","original_commit_id":"ff8243b74f1474a7bbbc11e40922d7be9822de42","user":{"login":"haoch","id":1282617,"avatar_url":"https://avatars.githubusercontent.com/u/1282617?v=3","gravatar_id":"","url":"https://api.github.com/users/haoch","html_url":"https://github.com/haoch","followers_url":"https://api.github.com/users/haoch/followers","following_url":"https://api.github.com/users/haoch/following{/other_user}","gists_url":"https://api.github.com/users/haoch/gists{/gist_id}","starred_url":"https://api.github.com/users/haoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoch/subscriptions","organizations_url":"https://api.github.com/users/haoch/orgs","repos_url":"https://api.github.com/users/haoch/repos","events_url":"https://api.github.com/users/haoch/events{/privacy}","received_events_url":"https://api.github.com/users/haoch/received_events","type":"User","site_admin":false},"body":"Change#2: move `MRHistoryJobDailyReporter ` registry to `MRHistoryJobApplicationProvider` from `ServerApplication` \r\n\r\n@qingwen220 @wujinhu ","created_at":"2016-12-16T09:35:02Z","updated_at":"2016-12-16T09:35:02Z","html_url":"https://github.com/apache/incubator-eagle/pull/750#discussion_r92778592","pull_request_url":"https://api.github.com/repos/apache/incubator-eagle/pulls/750","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-eagle/pulls/comments/92778592"},"html":{"href":"https://github.com/apache/incubator-eagle/pull/750#discussion_r92778592"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-eagle/pulls/750"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-eagle/pulls/750","id":98302810,"html_url":"https://github.com/apache/incubator-eagle/pull/750","diff_url":"https://github.com/apache/incubator-eagle/pull/750.diff","patch_url":"https://github.com/apache/incubator-eagle/pull/750.patch","issue_url":"https://api.github.com/repos/apache/incubator-eagle/issues/750","number":750,"state":"open","locked":false,"title":"[EAGLE-843] Refactor application shared service registry framework","user":{"login":"haoch","id":1282617,"avatar_url":"https://avatars.githubusercontent.com/u/1282617?v=3","gravatar_id":"","url":"https://api.github.com/users/haoch","html_url":"https://github.com/haoch","followers_url":"https://api.github.com/users/haoch/followers","following_url":"https://api.github.com/users/haoch/following{/other_user}","gists_url":"https://api.github.com/users/haoch/gists{/gist_id}","starred_url":"https://api.github.com/users/haoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoch/subscriptions","organizations_url":"https://api.github.com/users/haoch/orgs","repos_url":"https://api.github.com/users/haoch/repos","events_url":"https://api.github.com/users/haoch/events{/privacy}","received_events_url":"https://api.github.com/users/haoch/received_events","type":"User","site_admin":false},"body":"Refactor application shared service registry framework\r\n\r\nhttps://issues.apache.org/jira/browse/EAGLE-843","created_at":"2016-12-16T09:31:50Z","updated_at":"2016-12-16T09:36:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fc5f7a68b2369d33095f4edca7f981e96d208d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-eagle/pulls/750/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-eagle/pulls/750/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-eagle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-eagle/issues/750/comments","statuses_url":"https://api.github.com/repos/apache/incubator-eagle/statuses/ff8243b74f1474a7bbbc11e40922d7be9822de42","head":{"label":"haoch:RefactorAppServicesFramework","ref":"RefactorAppServicesFramework","sha":"ff8243b74f1474a7bbbc11e40922d7be9822de42","user":{"login":"haoch","id":1282617,"avatar_url":"https://avatars.githubusercontent.com/u/1282617?v=3","gravatar_id":"","url":"https://api.github.com/users/haoch","html_url":"https://github.com/haoch","followers_url":"https://api.github.com/users/haoch/followers","following_url":"https://api.github.com/users/haoch/following{/other_user}","gists_url":"https://api.github.com/users/haoch/gists{/gist_id}","starred_url":"https://api.github.com/users/haoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoch/subscriptions","organizations_url":"https://api.github.com/users/haoch/orgs","repos_url":"https://api.github.com/users/haoch/repos","events_url":"https://api.github.com/users/haoch/events{/privacy}","received_events_url":"https://api.github.com/users/haoch/received_events","type":"User","site_admin":false},"repo":{"id":49483360,"name":"incubator-eagle","full_name":"haoch/incubator-eagle","owner":{"login":"haoch","id":1282617,"avatar_url":"https://avatars.githubusercontent.com/u/1282617?v=3","gravatar_id":"","url":"https://api.github.com/users/haoch","html_url":"https://github.com/haoch","followers_url":"https://api.github.com/users/haoch/followers","following_url":"https://api.github.com/users/haoch/following{/other_user}","gists_url":"https://api.github.com/users/haoch/gists{/gist_id}","starred_url":"https://api.github.com/users/haoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoch/subscriptions","organizations_url":"https://api.github.com/users/haoch/orgs","repos_url":"https://api.github.com/users/haoch/repos","events_url":"https://api.github.com/users/haoch/events{/privacy}","received_events_url":"https://api.github.com/users/haoch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haoch/incubator-eagle","description":"Mirror of Apache Eagle (Incubating)","fork":true,"url":"https://api.github.com/repos/haoch/incubator-eagle","forks_url":"https://api.github.com/repos/haoch/incubator-eagle/forks","keys_url":"https://api.github.com/repos/haoch/incubator-eagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haoch/incubator-eagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haoch/incubator-eagle/teams","hooks_url":"https://api.github.com/repos/haoch/incubator-eagle/hooks","issue_events_url":"https://api.github.com/repos/haoch/incubator-eagle/issues/events{/number}","events_url":"https://api.github.com/repos/haoch/incubator-eagle/events","assignees_url":"https://api.github.com/repos/haoch/incubator-eagle/assignees{/user}","branches_url":"https://api.github.com/repos/haoch/incubator-eagle/branches{/branch}","tags_url":"https://api.github.com/repos/haoch/incubator-eagle/tags","blobs_url":"https://api.github.com/repos/haoch/incubator-eagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haoch/incubator-eagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haoch/incubator-eagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/haoch/incubator-eagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haoch/incubator-eagle/statuses/{sha}","languages_url":"https://api.github.com/repos/haoch/incubator-eagle/languages","stargazers_url":"https://api.github.com/repos/haoch/incubator-eagle/stargazers","contributors_url":"https://api.github.com/repos/haoch/incubator-eagle/contributors","subscribers_url":"https://api.github.com/repos/haoch/incubator-eagle/subscribers","subscription_url":"https://api.github.com/repos/haoch/incubator-eagle/subscription","commits_url":"https://api.github.com/repos/haoch/incubator-eagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/haoch/incubator-eagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/haoch/incubator-eagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/haoch/incubator-eagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/haoch/incubator-eagle/contents/{+path}","compare_url":"https://api.github.com/repos/haoch/incubator-eagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haoch/incubator-eagle/merges","archive_url":"https://api.github.com/repos/haoch/incubator-eagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haoch/incubator-eagle/downloads","issues_url":"https://api.github.com/repos/haoch/incubator-eagle/issues{/number}","pulls_url":"https://api.github.com/repos/haoch/incubator-eagle/pulls{/number}","milestones_url":"https://api.github.com/repos/haoch/incubator-eagle/milestones{/number}","notifications_url":"https://api.github.com/repos/haoch/incubator-eagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haoch/incubator-eagle/labels{/name}","releases_url":"https://api.github.com/repos/haoch/incubator-eagle/releases{/id}","deployments_url":"https://api.github.com/repos/haoch/incubator-eagle/deployments","created_at":"2016-01-12T07:36:58Z","updated_at":"2016-01-12T07:37:02Z","pushed_at":"2016-12-16T09:26:11Z","git_url":"git://github.com/haoch/incubator-eagle.git","ssh_url":"git@github.com:haoch/incubator-eagle.git","clone_url":"https://github.com/haoch/incubator-eagle.git","svn_url":"https://github.com/haoch/incubator-eagle","homepage":null,"size":26581,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a89275bfc86c4db63688e28ff12196ee97a78207","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":46404009,"name":"incubator-eagle","full_name":"apache/incubator-eagle","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-eagle","description":"Mirror of Apache Eagle (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-eagle","forks_url":"https://api.github.com/repos/apache/incubator-eagle/forks","keys_url":"https://api.github.com/repos/apache/incubator-eagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-eagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-eagle/teams","hooks_url":"https://api.github.com/repos/apache/incubator-eagle/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-eagle/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-eagle/events","assignees_url":"https://api.github.com/repos/apache/incubator-eagle/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-eagle/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-eagle/tags","blobs_url":"https://api.github.com/repos/apache/incubator-eagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-eagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-eagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-eagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-eagle/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-eagle/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-eagle/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-eagle/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-eagle/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-eagle/subscription","commits_url":"https://api.github.com/repos/apache/incubator-eagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-eagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-eagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-eagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-eagle/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-eagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-eagle/merges","archive_url":"https://api.github.com/repos/apache/incubator-eagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-eagle/downloads","issues_url":"https://api.github.com/repos/apache/incubator-eagle/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-eagle/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-eagle/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-eagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-eagle/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-eagle/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-eagle/deployments","created_at":"2015-11-18T08:00:06Z","updated_at":"2016-12-13T02:42:06Z","pushed_at":"2016-12-16T09:31:50Z","git_url":"git://github.com/apache/incubator-eagle.git","ssh_url":"git@github.com:apache/incubator-eagle.git","clone_url":"https://github.com/apache/incubator-eagle.git","svn_url":"https://github.com/apache/incubator-eagle","homepage":null,"size":25191,"stargazers_count":135,"watchers_count":135,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":"git://git.apache.org/incubator-eagle.git","open_issues_count":6,"forks":95,"open_issues":6,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-eagle/pulls/750"},"html":{"href":"https://github.com/apache/incubator-eagle/pull/750"},"issue":{"href":"https://api.github.com/repos/apache/incubator-eagle/issues/750"},"comments":{"href":"https://api.github.com/repos/apache/incubator-eagle/issues/750/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-eagle/pulls/750/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-eagle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-eagle/pulls/750/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-eagle/statuses/ff8243b74f1474a7bbbc11e40922d7be9822de42"}}}}
{"actor":{"display_login":"haoch"}}