{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9598","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9598/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9598/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9598/events","html_url":"https://github.com/ManageIQ/manageiq/pull/9598","id":163679499,"number":9598,"title":"[WIP] Convert ExprorerPresenter to JSON","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-04T13:41:56Z","updated_at":"2016-07-04T13:54:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9598","html_url":"https://github.com/ManageIQ/manageiq/pull/9598","diff_url":"https://github.com/ManageIQ/manageiq/pull/9598.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9598.patch"},"body":"Purpose or Intent\r\n-----------------\r\nWe want to get rid of RJS (and javascript eval). This PR converts all the actions that go through ExplorerPresenter to JSON. This is surely not as good as using some nice JSON/REST API or converting the stuff in question to Angular. Implements a more restricted interface and removes the need to call `eval` in many situations.\r\n\r\nSteps for Testing/QA\r\n--------------------\r\nEvery screen that uses explorer (trees on the left) is affected by this change. And some more. I expect bugs. Actually if there would be no bugs found, I would be pretty scared."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/230296060","html_url":"https://github.com/ManageIQ/manageiq/pull/9598#issuecomment-230296060","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9598","id":230296060,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-07-04T13:54:25Z","updated_at":"2016-07-04T13:54:25Z","body":"<rubocop />Checked commits https://github.com/martinpovolny/manageiq/compare/1d6abc9e1b5a2378c3e38b2b5a5d2c0b808cb4d9~...77ca786891a194c12f8cc61cbf19847935977c14 with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1\n15 files checked, 13 offenses detected\n\n**app/presenters/explorer_presenter.rb**\n- [ ] :exclamation: - [Line 128](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L128), Col 13 - [Style/SpaceInsideHashLiteralBraces](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceInsideHashLiteralBraces) - Space inside { detected.\n- [ ] :exclamation: - [Line 128](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L128), Col 31 - [Style/SpaceInsideHashLiteralBraces](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceInsideHashLiteralBraces) - Space inside } detected.\n- [ ] :exclamation: - [Line 149](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L149), Col 22 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :exclamation: - [Line 167](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L167), Col 28 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :exclamation: - [Line 169](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L169), Col 31 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :exclamation: - [Line 173](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L173), Col 81 - [Style/SpaceAroundBlockParameters](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAroundBlockParameters) - Space before first block parameter detected.\n- [ ] :exclamation: - [Line 194](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L194), Col 27 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :exclamation: - [Line 195](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L195), Col 28 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :exclamation: - [Line 196](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L196), Col 25 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :grey_exclamation: - [Line 127](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L127), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for to_json is too high. [95.32/15]\n- [ ] :grey_exclamation: - [Line 127](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L127), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for to_json is too high. [17/6]\n- [ ] :grey_exclamation: - [Line 127](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L127), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [55/25]\n- [ ] :grey_exclamation: - [Line 127](https://github.com/martinpovolny/manageiq/blob/77ca786891a194c12f8cc61cbf19847935977c14/app/presenters/explorer_presenter.rb#L127), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for to_json is too high. [17/7]\n"}}
{"actor":{"display_login":"miq-bot"}}