{"action":"created","comment":{"url":"https://api.github.com/repos/plone/documentation/pulls/comments/58392523","id":58392523,"diff_hunk":"@@ -235,10 +235,10 @@ Registration changes\n Prior to Plone 5, JavaScript files were added to the registry by using a `Generic Setup Profile <http://docs.plone.org/develop/addons/components/genericsetup.html>`_ and including a jsregistry.xml file to it.\n This would add your JavaScript to the registry, with some options and potentially set ordering.\n \n-In Plone 5.0, Plone will still recognize these jsregistry.xml files.\n-Plone tries to provide a shim for those that are stubborn to migrate.\n-How it does this is by adding all jsregistry.xml JavaScripts into a \"plone-legacy\" Resource Registry bundle.\n-This bundle simply includes a global jQuery object and includes the resources in sequential order after it.\n+In Plone 5.0, Plone will still recognize these jsregistry.xml files. Plone tries to provide a shim for them. It does this is by adding all jsregistry.xml JavaScripts into the \"plone-legacy\" Resource Registry bundle. This bundle simply includes a global jQuery object and includes the resources in sequential order after it.","path":"manage/upgrading/version_specific_migration/p4x_to_p5x_upgrade.rst","position":75,"original_position":75,"commit_id":"218f28feb471fe785b36b88b371b4be99cf42571","original_commit_id":"218f28feb471fe785b36b88b371b4be99cf42571","user":{"login":"rnixx","id":246021,"avatar_url":"https://avatars.githubusercontent.com/u/246021?v=3","gravatar_id":"","url":"https://api.github.com/users/rnixx","html_url":"https://github.com/rnixx","followers_url":"https://api.github.com/users/rnixx/followers","following_url":"https://api.github.com/users/rnixx/following{/other_user}","gists_url":"https://api.github.com/users/rnixx/gists{/gist_id}","starred_url":"https://api.github.com/users/rnixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnixx/subscriptions","organizations_url":"https://api.github.com/users/rnixx/orgs","repos_url":"https://api.github.com/users/rnixx/repos","events_url":"https://api.github.com/users/rnixx/events{/privacy}","received_events_url":"https://api.github.com/users/rnixx/received_events","type":"User","site_admin":false},"body":"It does this is\r\n\r\nPlease remove \"is\"","created_at":"2016-04-04T15:15:09Z","updated_at":"2016-04-04T15:15:09Z","html_url":"https://github.com/plone/documentation/pull/584#discussion_r58392523","pull_request_url":"https://api.github.com/repos/plone/documentation/pulls/584","_links":{"self":{"href":"https://api.github.com/repos/plone/documentation/pulls/comments/58392523"},"html":{"href":"https://github.com/plone/documentation/pull/584#discussion_r58392523"},"pull_request":{"href":"https://api.github.com/repos/plone/documentation/pulls/584"}}},"pull_request":{"url":"https://api.github.com/repos/plone/documentation/pulls/584","id":65161590,"html_url":"https://github.com/plone/documentation/pull/584","diff_url":"https://github.com/plone/documentation/pull/584.diff","patch_url":"https://github.com/plone/documentation/pull/584.patch","issue_url":"https://api.github.com/repos/plone/documentation/issues/584","number":584,"state":"open","locked":false,"title":"Fix #579 follow styleguide fix typos","user":{"login":"svx","id":358860,"avatar_url":"https://avatars.githubusercontent.com/u/358860?v=3","gravatar_id":"","url":"https://api.github.com/users/svx","html_url":"https://github.com/svx","followers_url":"https://api.github.com/users/svx/followers","following_url":"https://api.github.com/users/svx/following{/other_user}","gists_url":"https://api.github.com/users/svx/gists{/gist_id}","starred_url":"https://api.github.com/users/svx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svx/subscriptions","organizations_url":"https://api.github.com/users/svx/orgs","repos_url":"https://api.github.com/users/svx/repos","events_url":"https://api.github.com/users/svx/events{/privacy}","received_events_url":"https://api.github.com/users/svx/received_events","type":"User","site_admin":false},"body":"Fixes: #579\r\n\r\nImproves: Fix for #579\r\n\r\nChanges proposed in this pull request:\r\n\r\n- re-phrase wording\r\n\r\n- fix typos\r\n\r\n- follow wording style-guide for words like Plone and JavaScript\r\n\r\n\r\n\r\n","created_at":"2016-04-04T15:12:20Z","updated_at":"2016-04-04T15:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d19b64633e97426ed8ddfe53801220c286d964b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plone/documentation/pulls/584/commits","review_comments_url":"https://api.github.com/repos/plone/documentation/pulls/584/comments","review_comment_url":"https://api.github.com/repos/plone/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plone/documentation/issues/584/comments","statuses_url":"https://api.github.com/repos/plone/documentation/statuses/218f28feb471fe785b36b88b371b4be99cf42571","head":{"label":"plone:fix_#579","ref":"fix_#579","sha":"218f28feb471fe785b36b88b371b4be99cf42571","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":16646125,"name":"documentation","full_name":"plone/documentation","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/documentation","description":"Plone Documentation","fork":false,"url":"https://api.github.com/repos/plone/documentation","forks_url":"https://api.github.com/repos/plone/documentation/forks","keys_url":"https://api.github.com/repos/plone/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/documentation/teams","hooks_url":"https://api.github.com/repos/plone/documentation/hooks","issue_events_url":"https://api.github.com/repos/plone/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/plone/documentation/events","assignees_url":"https://api.github.com/repos/plone/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/plone/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/plone/documentation/tags","blobs_url":"https://api.github.com/repos/plone/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/documentation/languages","stargazers_url":"https://api.github.com/repos/plone/documentation/stargazers","contributors_url":"https://api.github.com/repos/plone/documentation/contributors","subscribers_url":"https://api.github.com/repos/plone/documentation/subscribers","subscription_url":"https://api.github.com/repos/plone/documentation/subscription","commits_url":"https://api.github.com/repos/plone/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/plone/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/documentation/merges","archive_url":"https://api.github.com/repos/plone/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/documentation/downloads","issues_url":"https://api.github.com/repos/plone/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/plone/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/documentation/labels{/name}","releases_url":"https://api.github.com/repos/plone/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/plone/documentation/deployments","created_at":"2014-02-08T15:33:54Z","updated_at":"2016-03-05T10:58:42Z","pushed_at":"2016-04-04T15:12:21Z","git_url":"git://github.com/plone/documentation.git","ssh_url":"git@github.com:plone/documentation.git","clone_url":"https://github.com/plone/documentation.git","svn_url":"https://github.com/plone/documentation","homepage":"http://docs.plone.org","size":24275,"stargazers_count":14,"watchers_count":14,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":98,"forks":68,"open_issues":98,"watchers":14,"default_branch":"5.0"}},"base":{"label":"plone:5.0","ref":"5.0","sha":"ce8736f9bcbd1ee77c367c7a88b9dadd0beb67c3","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":16646125,"name":"documentation","full_name":"plone/documentation","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/documentation","description":"Plone Documentation","fork":false,"url":"https://api.github.com/repos/plone/documentation","forks_url":"https://api.github.com/repos/plone/documentation/forks","keys_url":"https://api.github.com/repos/plone/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/documentation/teams","hooks_url":"https://api.github.com/repos/plone/documentation/hooks","issue_events_url":"https://api.github.com/repos/plone/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/plone/documentation/events","assignees_url":"https://api.github.com/repos/plone/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/plone/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/plone/documentation/tags","blobs_url":"https://api.github.com/repos/plone/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/documentation/languages","stargazers_url":"https://api.github.com/repos/plone/documentation/stargazers","contributors_url":"https://api.github.com/repos/plone/documentation/contributors","subscribers_url":"https://api.github.com/repos/plone/documentation/subscribers","subscription_url":"https://api.github.com/repos/plone/documentation/subscription","commits_url":"https://api.github.com/repos/plone/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/plone/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/documentation/merges","archive_url":"https://api.github.com/repos/plone/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/documentation/downloads","issues_url":"https://api.github.com/repos/plone/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/plone/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/documentation/labels{/name}","releases_url":"https://api.github.com/repos/plone/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/plone/documentation/deployments","created_at":"2014-02-08T15:33:54Z","updated_at":"2016-03-05T10:58:42Z","pushed_at":"2016-04-04T15:12:21Z","git_url":"git://github.com/plone/documentation.git","ssh_url":"git@github.com:plone/documentation.git","clone_url":"https://github.com/plone/documentation.git","svn_url":"https://github.com/plone/documentation","homepage":"http://docs.plone.org","size":24275,"stargazers_count":14,"watchers_count":14,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":98,"forks":68,"open_issues":98,"watchers":14,"default_branch":"5.0"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/documentation/pulls/584"},"html":{"href":"https://github.com/plone/documentation/pull/584"},"issue":{"href":"https://api.github.com/repos/plone/documentation/issues/584"},"comments":{"href":"https://api.github.com/repos/plone/documentation/issues/584/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/documentation/pulls/584/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plone/documentation/pulls/584/commits"},"statuses":{"href":"https://api.github.com/repos/plone/documentation/statuses/218f28feb471fe785b36b88b371b4be99cf42571"}}}}