{"action":"created","issue":{"url":"https://api.github.com/repos/cakesolutions/scala-kafka-client/issues/78","repository_url":"https://api.github.com/repos/cakesolutions/scala-kafka-client","labels_url":"https://api.github.com/repos/cakesolutions/scala-kafka-client/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/cakesolutions/scala-kafka-client/issues/78/comments","events_url":"https://api.github.com/repos/cakesolutions/scala-kafka-client/issues/78/events","html_url":"https://github.com/cakesolutions/scala-kafka-client/pull/78","id":197485955,"number":78,"title":"Catch exceptions thrown by the send and turn into failed future","user":{"login":"conniec","id":458937,"avatar_url":"https://avatars.githubusercontent.com/u/458937?v=3","gravatar_id":"","url":"https://api.github.com/users/conniec","html_url":"https://github.com/conniec","followers_url":"https://api.github.com/users/conniec/followers","following_url":"https://api.github.com/users/conniec/following{/other_user}","gists_url":"https://api.github.com/users/conniec/gists{/gist_id}","starred_url":"https://api.github.com/users/conniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conniec/subscriptions","organizations_url":"https://api.github.com/users/conniec/orgs","repos_url":"https://api.github.com/users/conniec/repos","events_url":"https://api.github.com/users/conniec/events{/privacy}","received_events_url":"https://api.github.com/users/conniec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-25T03:33:23Z","updated_at":"2016-12-26T07:32:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cakesolutions/scala-kafka-client/pulls/78","html_url":"https://github.com/cakesolutions/scala-kafka-client/pull/78","diff_url":"https://github.com/cakesolutions/scala-kafka-client/pull/78.diff","patch_url":"https://github.com/cakesolutions/scala-kafka-client/pull/78.patch"},"body":"While working with the java `KafkaProducer`, I encountered an error where an `Exception` could be thrown within the `send`. This would cause the callback not to get called and the failed `Future` to not be created. I thought the fix might be useful here as well, let me know your thoughts. "},"comment":{"url":"https://api.github.com/repos/cakesolutions/scala-kafka-client/issues/comments/269176905","html_url":"https://github.com/cakesolutions/scala-kafka-client/pull/78#issuecomment-269176905","issue_url":"https://api.github.com/repos/cakesolutions/scala-kafka-client/issues/78","id":269176905,"user":{"login":"jkpl","id":1027947,"avatar_url":"https://avatars.githubusercontent.com/u/1027947?v=3","gravatar_id":"","url":"https://api.github.com/users/jkpl","html_url":"https://github.com/jkpl","followers_url":"https://api.github.com/users/jkpl/followers","following_url":"https://api.github.com/users/jkpl/following{/other_user}","gists_url":"https://api.github.com/users/jkpl/gists{/gist_id}","starred_url":"https://api.github.com/users/jkpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkpl/subscriptions","organizations_url":"https://api.github.com/users/jkpl/orgs","repos_url":"https://api.github.com/users/jkpl/repos","events_url":"https://api.github.com/users/jkpl/events{/privacy}","received_events_url":"https://api.github.com/users/jkpl/received_events","type":"User","site_admin":false},"created_at":"2016-12-26T07:32:17Z","updated_at":"2016-12-26T07:32:17Z","body":"Good catch! It seems the underlying Java driver has two channels for errors: one in the callback and one thrown immediately on call. Makes sense to join them under the same `Future` value."}}
{"actor":{"display_login":"jkpl"}}