{"push_id":1236710656,"size":13,"distinct_size":0,"ref":"refs/heads/master","head":"0fc0db67c64bf8ab4593d1f84b8d1be517fa1b74","before":"1086df67e04ce97fed080ba7c79ed8e1615202eb","commits":[{"sha":"2580c1dc6ea3fbec337a31a38ab1a3abf6d2a90c","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Add InsetRect, move BorderRadius to basic_shape.rs","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/2580c1dc6ea3fbec337a31a38ab1a3abf6d2a90c"},{"sha":"88c1a67d89a3bbab93d77a6db222810dc337bce1","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Add ShapeRadius to basic_shape.rs","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/88c1a67d89a3bbab93d77a6db222810dc337bce1"},{"sha":"44e33bcdc593bb3e5a8d4833e506ff135c082419","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Move Position into its own values module","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/44e33bcdc593bb3e5a8d4833e506ff135c082419"},{"sha":"77f345476f480fe1b7e2e74cfffd4510725d866b","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Add Circle to basic_shape.rs","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/77f345476f480fe1b7e2e74cfffd4510725d866b"},{"sha":"78ce65d5a8e04939717b1cb455b79440e71f8ef9","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Add Ellipse to basic_shape.rs","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/78ce65d5a8e04939717b1cb455b79440e71f8ef9"},{"sha":"eb82cc25efab89d34f15c47568a8a21234be492b","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Add Polygon to basic_shape.rs","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/eb82cc25efab89d34f15c47568a8a21234be492b"},{"sha":"1e7973263f55d4d101284a97ab5e9c87a8d35a22","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Fix tidy","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/1e7973263f55d4d101284a97ab5e9c87a8d35a22"},{"sha":"e69f6396e264378c9e61f5384c822377c2811e8d","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Remove unused imports","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/e69f6396e264378c9e61f5384c822377c2811e8d"},{"sha":"973796b989c49620b90adc97a57e1e2bff4dff76","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Various fixes in basic-shape parsing/serialization found by unit tests","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/973796b989c49620b90adc97a57e1e2bff4dff76"},{"sha":"c6feae3c5ce2a25dfd809699eb0b8d2a96c1816e","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Add roundtrip parsing tests for basic_shape/position","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/c6feae3c5ce2a25dfd809699eb0b8d2a96c1816e"},{"sha":"d1e45f78afaba96d55034e59befe32d6445e7148","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Add serialize_four_sides, use for serializing BorderRadius","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/d1e45f78afaba96d55034e59befe32d6445e7148"},{"sha":"234219cd842f1593c1eef3f39c91c5438f9f425e","author":{"name":"Manish Goregaokar","email":"d2b7b149d2f9468b572924624a3b5a5bb122f1e8@gmail.com"},"message":"Address review comments","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/234219cd842f1593c1eef3f39c91c5438f9f425e"},{"sha":"0fc0db67c64bf8ab4593d1f84b8d1be517fa1b74","author":{"name":"bors-servo","email":"b09d4f4a3e19bc290c035b624e2133ac70195a90@mozilla.com"},"message":"Auto merge of #12680 - Manishearth:basic-shape, r=SimonSapin\n\nstyle: Add support for parsing and serialization of <basic-shape>s\n\nStill WIP: I still need to use this somewhere and make serialization minimal. I'm not sure if I should do either in this PR.\nThe only other browser that handles basic shapes doesn't serialize correctly either (https://bugzilla.mozilla.org/show_bug.cgi?id=1290864), so that's not something we need to get done now.\n\nAs far as using this somewhere, I have the following options:\n\n - Merge this now, work on using it in stylo in a followup.\n - Just write extensive unit tests for parsing/serialization for now (stylo in a followup)\n - Use this for clip-path in stylo only (which I intend to do anyway, just not sure if I should do it in this PR)\n - Use this for clip-path in Servo (I'd rather not do this; this would be a huge change requiring a lot more layout knowledge than I currently have)\n\nThoughts? Review? @SimonSapin @bholley\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12680)\n<!-- Reviewable:end -->","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/0fc0db67c64bf8ab4593d1f84b8d1be517fa1b74"}]}
{"actor":{"display_login":"bors-servo"}}