{"action":"created","comment":{"url":"https://api.github.com/repos/coveo/search-ui/pulls/comments/65778187","id":65778187,"diff_hunk":"@@ -71,19 +71,19 @@ $default-border: 1px solid $color-light-grey;\n }\n \n @mixin iconWithHoverState($iconBase, $float:'left', $inactive : 'coveo-disabled') {\n-  $iconActive: #{$iconBase} + '-active';\n+  $iconActive: '#{$iconBase}-active';\n   .coveo-icon {\n-    @extend #{$iconBase};\n+    @extend #{$iconBase} !optional;\n     float: #{$float};\n   }\n   &:hover {\n     .coveo-icon {\n-      @extend #{$iconActive};\n+      @extend #{$iconActive} !optional;","path":"sass/_Variables.scss","position":14,"original_position":14,"commit_id":"5f878a83cb64216212f71c0509695b70b061be6f","original_commit_id":"5f878a83cb64216212f71c0509695b70b061be6f","user":{"login":"olamothe","id":1591893,"avatar_url":"https://avatars.githubusercontent.com/u/1591893?v=3","gravatar_id":"","url":"https://api.github.com/users/olamothe","html_url":"https://github.com/olamothe","followers_url":"https://api.github.com/users/olamothe/followers","following_url":"https://api.github.com/users/olamothe/following{/other_user}","gists_url":"https://api.github.com/users/olamothe/gists{/gist_id}","starred_url":"https://api.github.com/users/olamothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olamothe/subscriptions","organizations_url":"https://api.github.com/users/olamothe/orgs","repos_url":"https://api.github.com/users/olamothe/repos","events_url":"https://api.github.com/users/olamothe/events{/privacy}","received_events_url":"https://api.github.com/users/olamothe/received_events","type":"User","site_admin":false},"body":"And this does not break the icon with an hover state ? If not ... great I guess :)","created_at":"2016-06-03T21:26:41Z","updated_at":"2016-06-03T21:26:41Z","html_url":"https://github.com/coveo/search-ui/pull/15#discussion_r65778187","pull_request_url":"https://api.github.com/repos/coveo/search-ui/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/comments/65778187"},"html":{"href":"https://github.com/coveo/search-ui/pull/15#discussion_r65778187"},"pull_request":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/coveo/search-ui/pulls/15","id":72382384,"html_url":"https://github.com/coveo/search-ui/pull/15","diff_url":"https://github.com/coveo/search-ui/pull/15.diff","patch_url":"https://github.com/coveo/search-ui/pull/15.patch","issue_url":"https://api.github.com/repos/coveo/search-ui/issues/15","number":15,"state":"open","locked":false,"title":"Webpack compile sass","user":{"login":"dms1lva","id":6422665,"avatar_url":"https://avatars.githubusercontent.com/u/6422665?v=3","gravatar_id":"","url":"https://api.github.com/users/dms1lva","html_url":"https://github.com/dms1lva","followers_url":"https://api.github.com/users/dms1lva/followers","following_url":"https://api.github.com/users/dms1lva/following{/other_user}","gists_url":"https://api.github.com/users/dms1lva/gists{/gist_id}","starred_url":"https://api.github.com/users/dms1lva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dms1lva/subscriptions","organizations_url":"https://api.github.com/users/dms1lva/orgs","repos_url":"https://api.github.com/users/dms1lva/repos","events_url":"https://api.github.com/users/dms1lva/events{/privacy}","received_events_url":"https://api.github.com/users/dms1lva/received_events","type":"User","site_admin":false},"body":"When using the webpack dev server, a sass file modification will trigger a page refresh and the modification will be applied. In order for the sass file to be considered, it needs to be imported using the `import` statement, ie: `import '_EpicSwagStyle.scss'`. When using the `import` statement, the style is applied using the [style-loader](https://github.com/webpack/style-loader). What this loader does is apply the loaded style using a html `style` or `link` tag. The usual css file will be overridden because the `style` tag will be inserted after it. \r\n\r\nIf in the future all our sass files are imported in their corresponding component, we could use the [extract-loader](https://github.com/peerigon/extract-loader) to produce the css bundle that contains all our style. This means that we wouldn't need a huge sass file that imports all our component styles to build the bundle. There is also the [extract-text-webpack-plugin](https://github.com/webpack/extract-text-webpack-plugin) that is more complex than the extract-loader but can accomplish more and is not specific to the css loader output.\r\n\r\nWhen using an imported sass file, there is three things to consider:\r\n\r\n- The sass context is isolated. This means that you need to import any definition that comes from another sass file. For example, in most cases, you will probably need to do:\r\n`@import \"_Variables.scss\";`.\r\n\r\n- The sass file order is not guaranteed, so you cannot rely on it to override styles. You should use more  specific sass classes in order to do that.\r\n\r\n- For now, since we don't have imports for all our css, we are still using the css bundle file while in the dev server. That means that some changes cant be take into account. For example, if a class is deleted, it will be deleted from the style tag, but it won't be deleted from the css bundle.","created_at":"2016-06-02T17:04:24Z","updated_at":"2016-06-03T21:26:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d97260d29accd955312636cb91b133e56db4070","assignee":{"login":"olamothe","id":1591893,"avatar_url":"https://avatars.githubusercontent.com/u/1591893?v=3","gravatar_id":"","url":"https://api.github.com/users/olamothe","html_url":"https://github.com/olamothe","followers_url":"https://api.github.com/users/olamothe/followers","following_url":"https://api.github.com/users/olamothe/following{/other_user}","gists_url":"https://api.github.com/users/olamothe/gists{/gist_id}","starred_url":"https://api.github.com/users/olamothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olamothe/subscriptions","organizations_url":"https://api.github.com/users/olamothe/orgs","repos_url":"https://api.github.com/users/olamothe/repos","events_url":"https://api.github.com/users/olamothe/events{/privacy}","received_events_url":"https://api.github.com/users/olamothe/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/coveo/search-ui/pulls/15/commits","review_comments_url":"https://api.github.com/repos/coveo/search-ui/pulls/15/comments","review_comment_url":"https://api.github.com/repos/coveo/search-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coveo/search-ui/issues/15/comments","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/5f878a83cb64216212f71c0509695b70b061be6f","head":{"label":"coveo:webpack-compile-sass","ref":"webpack-compile-sass","sha":"5f878a83cb64216212f71c0509695b70b061be6f","user":{"login":"coveo","id":8632328,"avatar_url":"https://avatars.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":58133471,"name":"search-ui","full_name":"coveo/search-ui","owner":{"login":"coveo","id":8632328,"avatar_url":"https://avatars.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/search-ui","description":"Coveo Search UI framework","fork":false,"url":"https://api.github.com/repos/coveo/search-ui","forks_url":"https://api.github.com/repos/coveo/search-ui/forks","keys_url":"https://api.github.com/repos/coveo/search-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/search-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/search-ui/teams","hooks_url":"https://api.github.com/repos/coveo/search-ui/hooks","issue_events_url":"https://api.github.com/repos/coveo/search-ui/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/search-ui/events","assignees_url":"https://api.github.com/repos/coveo/search-ui/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/search-ui/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/search-ui/tags","blobs_url":"https://api.github.com/repos/coveo/search-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/search-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/search-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/search-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/search-ui/languages","stargazers_url":"https://api.github.com/repos/coveo/search-ui/stargazers","contributors_url":"https://api.github.com/repos/coveo/search-ui/contributors","subscribers_url":"https://api.github.com/repos/coveo/search-ui/subscribers","subscription_url":"https://api.github.com/repos/coveo/search-ui/subscription","commits_url":"https://api.github.com/repos/coveo/search-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/search-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/search-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/search-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/search-ui/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/search-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/search-ui/merges","archive_url":"https://api.github.com/repos/coveo/search-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/search-ui/downloads","issues_url":"https://api.github.com/repos/coveo/search-ui/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/search-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/search-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/search-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/search-ui/labels{/name}","releases_url":"https://api.github.com/repos/coveo/search-ui/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/search-ui/deployments","created_at":"2016-05-05T13:41:09Z","updated_at":"2016-06-03T09:45:10Z","pushed_at":"2016-06-03T20:33:46Z","git_url":"git://github.com/coveo/search-ui.git","ssh_url":"git@github.com:coveo/search-ui.git","clone_url":"https://github.com/coveo/search-ui.git","svn_url":"https://github.com/coveo/search-ui","homepage":null,"size":3571,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"coveo:master","ref":"master","sha":"6c2fbb7548e8f0ed698baf18f8d635663901df67","user":{"login":"coveo","id":8632328,"avatar_url":"https://avatars.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":58133471,"name":"search-ui","full_name":"coveo/search-ui","owner":{"login":"coveo","id":8632328,"avatar_url":"https://avatars.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/search-ui","description":"Coveo Search UI framework","fork":false,"url":"https://api.github.com/repos/coveo/search-ui","forks_url":"https://api.github.com/repos/coveo/search-ui/forks","keys_url":"https://api.github.com/repos/coveo/search-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/search-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/search-ui/teams","hooks_url":"https://api.github.com/repos/coveo/search-ui/hooks","issue_events_url":"https://api.github.com/repos/coveo/search-ui/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/search-ui/events","assignees_url":"https://api.github.com/repos/coveo/search-ui/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/search-ui/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/search-ui/tags","blobs_url":"https://api.github.com/repos/coveo/search-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/search-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/search-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/search-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/search-ui/languages","stargazers_url":"https://api.github.com/repos/coveo/search-ui/stargazers","contributors_url":"https://api.github.com/repos/coveo/search-ui/contributors","subscribers_url":"https://api.github.com/repos/coveo/search-ui/subscribers","subscription_url":"https://api.github.com/repos/coveo/search-ui/subscription","commits_url":"https://api.github.com/repos/coveo/search-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/search-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/search-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/search-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/search-ui/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/search-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/search-ui/merges","archive_url":"https://api.github.com/repos/coveo/search-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/search-ui/downloads","issues_url":"https://api.github.com/repos/coveo/search-ui/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/search-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/search-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/search-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/search-ui/labels{/name}","releases_url":"https://api.github.com/repos/coveo/search-ui/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/search-ui/deployments","created_at":"2016-05-05T13:41:09Z","updated_at":"2016-06-03T09:45:10Z","pushed_at":"2016-06-03T20:33:46Z","git_url":"git://github.com/coveo/search-ui.git","ssh_url":"git@github.com:coveo/search-ui.git","clone_url":"https://github.com/coveo/search-ui.git","svn_url":"https://github.com/coveo/search-ui","homepage":null,"size":3571,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/15"},"html":{"href":"https://github.com/coveo/search-ui/pull/15"},"issue":{"href":"https://api.github.com/repos/coveo/search-ui/issues/15"},"comments":{"href":"https://api.github.com/repos/coveo/search-ui/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/coveo/search-ui/statuses/5f878a83cb64216212f71c0509695b70b061be6f"}}}}
{"actor":{"display_login":"olamothe"}}