{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/59739989","id":59739989,"diff_hunk":"@@ -261,39 +258,32 @@ bool CFile::Open(const CURL& file, const unsigned int flags)\n   try\n   {\n     bool bPathInCache;\n-\n-    CURL url(URIUtils::SubstitutePath(file)), url2(url);","path":"xbmc/filesystem/File.cpp","position":26,"original_position":26,"commit_id":"f09a5094d3c5d49e056fb15d0ab0c7b4121ba7db","original_commit_id":"f09a5094d3c5d49e056fb15d0ab0c7b4121ba7db","user":{"login":"mapfau","id":12764616,"avatar_url":"https://avatars.githubusercontent.com/u/12764616?v=3","gravatar_id":"","url":"https://api.github.com/users/mapfau","html_url":"https://github.com/mapfau","followers_url":"https://api.github.com/users/mapfau/followers","following_url":"https://api.github.com/users/mapfau/following{/other_user}","gists_url":"https://api.github.com/users/mapfau/gists{/gist_id}","starred_url":"https://api.github.com/users/mapfau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapfau/subscriptions","organizations_url":"https://api.github.com/users/mapfau/orgs","repos_url":"https://api.github.com/users/mapfau/repos","events_url":"https://api.github.com/users/mapfau/events{/privacy}","received_events_url":"https://api.github.com/users/mapfau/received_events","type":"User","site_admin":false},"body":"save resources, save time. There is no need to make 2 copies od URL (beside all the things happen in the constructor (Concatting strings from a, barsing this string in b)","created_at":"2016-04-14T15:38:47Z","updated_at":"2016-04-14T15:38:48Z","html_url":"https://github.com/xbmc/xbmc/pull/9621#discussion_r59739989","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9621","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/59739989"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9621#discussion_r59739989"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9621"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9621","id":66392652,"html_url":"https://github.com/xbmc/xbmc/pull/9621","diff_url":"https://github.com/xbmc/xbmc/pull/9621.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9621.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9621","number":9621,"state":"open","locked":false,"title":"Remove HTTPFile / CURLAddOption PostData added","user":{"login":"mapfau","id":12764616,"avatar_url":"https://avatars.githubusercontent.com/u/12764616?v=3","gravatar_id":"","url":"https://api.github.com/users/mapfau","html_url":"https://github.com/mapfau","followers_url":"https://api.github.com/users/mapfau/followers","following_url":"https://api.github.com/users/mapfau/following{/other_user}","gists_url":"https://api.github.com/users/mapfau/gists{/gist_id}","starred_url":"https://api.github.com/users/mapfau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapfau/subscriptions","organizations_url":"https://api.github.com/users/mapfau/orgs","repos_url":"https://api.github.com/users/mapfau/repos","events_url":"https://api.github.com/users/mapfau/events{/privacy}","received_events_url":"https://api.github.com/users/mapfau/received_events","type":"User","site_admin":false},"body":"see title","created_at":"2016-04-13T21:13:56Z","updated_at":"2016-04-14T15:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba87d6463e00113605eb1ede7994ce3f2d60f632","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9621/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9621/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9621/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/f09a5094d3c5d49e056fb15d0ab0c7b4121ba7db","head":{"label":"mapfau:postdata","ref":"postdata","sha":"f09a5094d3c5d49e056fb15d0ab0c7b4121ba7db","user":{"login":"mapfau","id":12764616,"avatar_url":"https://avatars.githubusercontent.com/u/12764616?v=3","gravatar_id":"","url":"https://api.github.com/users/mapfau","html_url":"https://github.com/mapfau","followers_url":"https://api.github.com/users/mapfau/followers","following_url":"https://api.github.com/users/mapfau/following{/other_user}","gists_url":"https://api.github.com/users/mapfau/gists{/gist_id}","starred_url":"https://api.github.com/users/mapfau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapfau/subscriptions","organizations_url":"https://api.github.com/users/mapfau/orgs","repos_url":"https://api.github.com/users/mapfau/repos","events_url":"https://api.github.com/users/mapfau/events{/privacy}","received_events_url":"https://api.github.com/users/mapfau/received_events","type":"User","site_admin":false},"repo":{"id":36955169,"name":"xbmc","full_name":"mapfau/xbmc","owner":{"login":"mapfau","id":12764616,"avatar_url":"https://avatars.githubusercontent.com/u/12764616?v=3","gravatar_id":"","url":"https://api.github.com/users/mapfau","html_url":"https://github.com/mapfau","followers_url":"https://api.github.com/users/mapfau/followers","following_url":"https://api.github.com/users/mapfau/following{/other_user}","gists_url":"https://api.github.com/users/mapfau/gists{/gist_id}","starred_url":"https://api.github.com/users/mapfau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapfau/subscriptions","organizations_url":"https://api.github.com/users/mapfau/orgs","repos_url":"https://api.github.com/users/mapfau/repos","events_url":"https://api.github.com/users/mapfau/events{/privacy}","received_events_url":"https://api.github.com/users/mapfau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mapfau/xbmc","description":"ODROID Modifed Kodi (except master)","fork":true,"url":"https://api.github.com/repos/mapfau/xbmc","forks_url":"https://api.github.com/repos/mapfau/xbmc/forks","keys_url":"https://api.github.com/repos/mapfau/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapfau/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapfau/xbmc/teams","hooks_url":"https://api.github.com/repos/mapfau/xbmc/hooks","issue_events_url":"https://api.github.com/repos/mapfau/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/mapfau/xbmc/events","assignees_url":"https://api.github.com/repos/mapfau/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/mapfau/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/mapfau/xbmc/tags","blobs_url":"https://api.github.com/repos/mapfau/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapfau/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapfau/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapfau/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapfau/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mapfau/xbmc/languages","stargazers_url":"https://api.github.com/repos/mapfau/xbmc/stargazers","contributors_url":"https://api.github.com/repos/mapfau/xbmc/contributors","subscribers_url":"https://api.github.com/repos/mapfau/xbmc/subscribers","subscription_url":"https://api.github.com/repos/mapfau/xbmc/subscription","commits_url":"https://api.github.com/repos/mapfau/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapfau/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapfau/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapfau/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapfau/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/mapfau/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapfau/xbmc/merges","archive_url":"https://api.github.com/repos/mapfau/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapfau/xbmc/downloads","issues_url":"https://api.github.com/repos/mapfau/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/mapfau/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mapfau/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mapfau/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapfau/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/mapfau/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/mapfau/xbmc/deployments","created_at":"2015-06-05T21:01:07Z","updated_at":"2015-06-19T18:59:34Z","pushed_at":"2016-04-14T12:53:47Z","git_url":"git://github.com/mapfau/xbmc.git","ssh_url":"git@github.com:mapfau/xbmc.git","clone_url":"https://github.com/mapfau/xbmc.git","svn_url":"https://github.com/mapfau/xbmc","homepage":"http://forum.odroid.com","size":546982,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"bda4a031291672457f16ef99412180078d2f439a","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-04-14T11:50:34Z","pushed_at":"2016-04-14T15:02:30Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1746920,"stargazers_count":4678,"watchers_count":4678,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3447,"mirror_url":null,"open_issues_count":228,"forks":3447,"open_issues":228,"watchers":4678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9621"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9621"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9621"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9621/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9621/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9621/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/f09a5094d3c5d49e056fb15d0ab0c7b4121ba7db"}}}}