{"action":"created","comment":{"url":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments/90754605","pull_request_review_id":11274849,"id":90754605,"diff_hunk":"@@ -301,3 +306,12 @@ def get_public_ip(protocol=4):\n         logger.debug('cannot retrieve public IPv%d' % protocol, exc_info=1)\n         raise MoulinetteError(errno.ENETUNREACH,\n                               m18n.n('no_internet_connection'))\n+\n+def _get_maindomain():\n+    with open('/etc/yunohost/current_host', 'r') as f:\n+        maindomain = f.readline().rstrip()","path":"src/yunohost/domain.py","position":null,"original_position":26,"commit_id":"9a66b3e9694f4184432195e3b15434128210da08","original_commit_id":"6bbfb9a4d045102950cab1cbd4a7d852acec2d46","user":{"login":"Psycojoker","id":41827,"avatar_url":"https://avatars.githubusercontent.com/u/41827?v=3","gravatar_id":"","url":"https://api.github.com/users/Psycojoker","html_url":"https://github.com/Psycojoker","followers_url":"https://api.github.com/users/Psycojoker/followers","following_url":"https://api.github.com/users/Psycojoker/following{/other_user}","gists_url":"https://api.github.com/users/Psycojoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Psycojoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Psycojoker/subscriptions","organizations_url":"https://api.github.com/users/Psycojoker/orgs","repos_url":"https://api.github.com/users/Psycojoker/repos","events_url":"https://api.github.com/users/Psycojoker/events{/privacy}","received_events_url":"https://api.github.com/users/Psycojoker/received_events","type":"User","site_admin":false},"body":"Ok, let's keep it that way then.","created_at":"2016-12-03T10:17:38Z","updated_at":"2016-12-03T10:17:38Z","html_url":"https://github.com/YunoHost/yunohost/pull/187#discussion_r90754605","pull_request_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments/90754605"},"html":{"href":"https://github.com/YunoHost/yunohost/pull/187#discussion_r90754605"},"pull_request":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/YunoHost/yunohost/pulls/187","id":95109464,"html_url":"https://github.com/YunoHost/yunohost/pull/187","diff_url":"https://github.com/YunoHost/yunohost/pull/187.diff","patch_url":"https://github.com/YunoHost/yunohost/pull/187.patch","issue_url":"https://api.github.com/repos/YunoHost/yunohost/issues/187","number":187,"state":"open","locked":false,"title":"[fix] Disable removal of main domain and clarify tools_maindomain","user":{"login":"alexAubin","id":4533074,"avatar_url":"https://avatars.githubusercontent.com/u/4533074?v=3","gravatar_id":"","url":"https://api.github.com/users/alexAubin","html_url":"https://github.com/alexAubin","followers_url":"https://api.github.com/users/alexAubin/followers","following_url":"https://api.github.com/users/alexAubin/following{/other_user}","gists_url":"https://api.github.com/users/alexAubin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexAubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexAubin/subscriptions","organizations_url":"https://api.github.com/users/alexAubin/orgs","repos_url":"https://api.github.com/users/alexAubin/repos","events_url":"https://api.github.com/users/alexAubin/events{/privacy}","received_events_url":"https://api.github.com/users/alexAubin/received_events","type":"User","site_admin":false},"body":"Attempt to fix [issue 639](https://dev.yunohost.org/issues/639).\r\n\r\nI refactorized `tools_maindomain()` in the same time, which had a lot of weird stuff (old_domain option not actually used ? dyndns option not documented, only used in postinstall ? duplicated and outdated code with domain_add ? automatically create the new main domain if it does not exist ?)\r\n\r\nI still need to check that this doesn't break postinstall.","created_at":"2016-11-24T02:46:26Z","updated_at":"2016-12-03T10:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d22585dc2cad6f7154c3d51aaf65fade8927b07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/187/commits","review_comments_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/187/comments","review_comment_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/issues/187/comments","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/9a66b3e9694f4184432195e3b15434128210da08","head":{"label":"alexAubin:fix-639-removing-main-domain","ref":"fix-639-removing-main-domain","sha":"9a66b3e9694f4184432195e3b15434128210da08","user":{"login":"alexAubin","id":4533074,"avatar_url":"https://avatars.githubusercontent.com/u/4533074?v=3","gravatar_id":"","url":"https://api.github.com/users/alexAubin","html_url":"https://github.com/alexAubin","followers_url":"https://api.github.com/users/alexAubin/followers","following_url":"https://api.github.com/users/alexAubin/following{/other_user}","gists_url":"https://api.github.com/users/alexAubin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexAubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexAubin/subscriptions","organizations_url":"https://api.github.com/users/alexAubin/orgs","repos_url":"https://api.github.com/users/alexAubin/repos","events_url":"https://api.github.com/users/alexAubin/events{/privacy}","received_events_url":"https://api.github.com/users/alexAubin/received_events","type":"User","site_admin":false},"repo":{"id":72230284,"name":"yunohost","full_name":"alexAubin/yunohost","owner":{"login":"alexAubin","id":4533074,"avatar_url":"https://avatars.githubusercontent.com/u/4533074?v=3","gravatar_id":"","url":"https://api.github.com/users/alexAubin","html_url":"https://github.com/alexAubin","followers_url":"https://api.github.com/users/alexAubin/followers","following_url":"https://api.github.com/users/alexAubin/following{/other_user}","gists_url":"https://api.github.com/users/alexAubin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexAubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexAubin/subscriptions","organizations_url":"https://api.github.com/users/alexAubin/orgs","repos_url":"https://api.github.com/users/alexAubin/repos","events_url":"https://api.github.com/users/alexAubin/events{/privacy}","received_events_url":"https://api.github.com/users/alexAubin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexAubin/yunohost","description":"YunoHost Python scripts core","fork":true,"url":"https://api.github.com/repos/alexAubin/yunohost","forks_url":"https://api.github.com/repos/alexAubin/yunohost/forks","keys_url":"https://api.github.com/repos/alexAubin/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexAubin/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexAubin/yunohost/teams","hooks_url":"https://api.github.com/repos/alexAubin/yunohost/hooks","issue_events_url":"https://api.github.com/repos/alexAubin/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/alexAubin/yunohost/events","assignees_url":"https://api.github.com/repos/alexAubin/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/alexAubin/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/alexAubin/yunohost/tags","blobs_url":"https://api.github.com/repos/alexAubin/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexAubin/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexAubin/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexAubin/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexAubin/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/alexAubin/yunohost/languages","stargazers_url":"https://api.github.com/repos/alexAubin/yunohost/stargazers","contributors_url":"https://api.github.com/repos/alexAubin/yunohost/contributors","subscribers_url":"https://api.github.com/repos/alexAubin/yunohost/subscribers","subscription_url":"https://api.github.com/repos/alexAubin/yunohost/subscription","commits_url":"https://api.github.com/repos/alexAubin/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexAubin/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexAubin/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexAubin/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexAubin/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/alexAubin/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexAubin/yunohost/merges","archive_url":"https://api.github.com/repos/alexAubin/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexAubin/yunohost/downloads","issues_url":"https://api.github.com/repos/alexAubin/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/alexAubin/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/alexAubin/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/alexAubin/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexAubin/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/alexAubin/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/alexAubin/yunohost/deployments","created_at":"2016-10-28T18:00:26Z","updated_at":"2016-10-28T18:00:28Z","pushed_at":"2016-12-02T22:50:31Z","git_url":"git://github.com/alexAubin/yunohost.git","ssh_url":"git@github.com:alexAubin/yunohost.git","clone_url":"https://github.com/alexAubin/yunohost.git","svn_url":"https://github.com/alexAubin/yunohost","homepage":"https://yunohost.org","size":1604,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"unstable"}},"base":{"label":"YunoHost:unstable","ref":"unstable","sha":"64fc8ed5dd9b9eab73effe3f7f927fe859e1aef2","user":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"repo":{"id":19854246,"name":"yunohost","full_name":"YunoHost/yunohost","owner":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YunoHost/yunohost","description":"YunoHost Python scripts core","fork":false,"url":"https://api.github.com/repos/YunoHost/yunohost","forks_url":"https://api.github.com/repos/YunoHost/yunohost/forks","keys_url":"https://api.github.com/repos/YunoHost/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost/yunohost/teams","hooks_url":"https://api.github.com/repos/YunoHost/yunohost/hooks","issue_events_url":"https://api.github.com/repos/YunoHost/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost/yunohost/events","assignees_url":"https://api.github.com/repos/YunoHost/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost/yunohost/tags","blobs_url":"https://api.github.com/repos/YunoHost/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost/yunohost/languages","stargazers_url":"https://api.github.com/repos/YunoHost/yunohost/stargazers","contributors_url":"https://api.github.com/repos/YunoHost/yunohost/contributors","subscribers_url":"https://api.github.com/repos/YunoHost/yunohost/subscribers","subscription_url":"https://api.github.com/repos/YunoHost/yunohost/subscription","commits_url":"https://api.github.com/repos/YunoHost/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost/yunohost/merges","archive_url":"https://api.github.com/repos/YunoHost/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost/yunohost/downloads","issues_url":"https://api.github.com/repos/YunoHost/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost/yunohost/deployments","created_at":"2014-05-16T11:29:11Z","updated_at":"2016-11-29T21:23:16Z","pushed_at":"2016-12-02T23:38:58Z","git_url":"git://github.com/YunoHost/yunohost.git","ssh_url":"git@github.com:YunoHost/yunohost.git","clone_url":"https://github.com/YunoHost/yunohost.git","svn_url":"https://github.com/YunoHost/yunohost","homepage":"https://yunohost.org","size":1801,"stargazers_count":71,"watchers_count":71,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":54,"forks":40,"open_issues":54,"watchers":71,"default_branch":"unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/187"},"html":{"href":"https://github.com/YunoHost/yunohost/pull/187"},"issue":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/187"},"comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/YunoHost/yunohost/statuses/9a66b3e9694f4184432195e3b15434128210da08"}}}}
{"actor":{"display_login":"Psycojoker"}}