{"action":"created","comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/90865571","pull_request_review_id":11377482,"id":90865571,"diff_hunk":"@@ -53,7 +53,7 @@ private boolean checkConditions() {\n     public void propertyChange(PropertyChangeEvent evt) {\n         boolean conditionsChanged = checkConditions();\n         if (conditionsChanged) {\n-            refreshTaskList(); // TODO: Think about `pending` mode for the nodes, for not refreshing task list more than once\n+            requestTaskListRefresh(); // TODO: Think about `pending` mode for the nodes, for not refreshing task list more than once","path":"engine/src/main/java/org/terasology/rendering/dag/ConditionDependentNode.java","position":5,"original_position":5,"commit_id":"211926b570c9d3288e215528c1d3f70728926034","original_commit_id":"211926b570c9d3288e215528c1d3f70728926034","user":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"body":"You can remove the comment now. \r\n\r\nOn the other hand, while AbstractNode no longer needs a WorldRenderer reference ConditionDependentNode now certainly does. But its subclasses won't, so you can keep some as they are in this PR.","created_at":"2016-12-05T13:41:38Z","updated_at":"2016-12-05T13:41:38Z","html_url":"https://github.com/MovingBlocks/Terasology/pull/2641#discussion_r90865571","pull_request_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641","_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/90865571"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2641#discussion_r90865571"},"pull_request":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641"}}},"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641","id":96432831,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2641","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2641.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2641.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2641","number":2641,"state":"open","locked":false,"title":"Refresh Render Task List only once every frame","user":{"login":"eviltak","id":8018181,"avatar_url":"https://avatars.githubusercontent.com/u/8018181?v=3","gravatar_id":"","url":"https://api.github.com/users/eviltak","html_url":"https://github.com/eviltak","followers_url":"https://api.github.com/users/eviltak/followers","following_url":"https://api.github.com/users/eviltak/following{/other_user}","gists_url":"https://api.github.com/users/eviltak/gists{/gist_id}","starred_url":"https://api.github.com/users/eviltak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviltak/subscriptions","organizations_url":"https://api.github.com/users/eviltak/orgs","repos_url":"https://api.github.com/users/eviltak/repos","events_url":"https://api.github.com/users/eviltak/events{/privacy}","received_events_url":"https://api.github.com/users/eviltak/received_events","type":"User","site_admin":false},"body":"Closes #2610. Shaves off a minimum of 1 ms from time taken for task list refreshes according to the logs before and after the change.\r\n\r\n### How to test\r\n\r\nIn debug mode (`F3`), enable and disable wireframe mode (`F9`) to trigger task list refreshes (I don't know of any other method). The speedup isn't noticeable, but on comparison between the logs before and after the change, in the worst case a minimum of 1 ms is shaved off the task list refresh time.\r\n\r\n### Details\r\n\r\n * Nodes now *request* refreshes (`RenderTaskListGenerator.requestRefresh()`). If requested, the task list will be refreshed in the next `preRenderUpdate`.\r\n * `WorldRendererImpl` stores a reference to `RenderTaskListGenerator` as a field. This has no performance implications since all nodes store the  same reference anyway.","created_at":"2016-12-04T13:39:58Z","updated_at":"2016-12-05T13:46:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"557b5decc2590f8cb3ab6663eb47f408f0661534","assignee":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"assignees":[{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2641/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/211926b570c9d3288e215528c1d3f70728926034","head":{"label":"eviltak:render-tasklist-refresh-queue","ref":"render-tasklist-refresh-queue","sha":"211926b570c9d3288e215528c1d3f70728926034","user":{"login":"eviltak","id":8018181,"avatar_url":"https://avatars.githubusercontent.com/u/8018181?v=3","gravatar_id":"","url":"https://api.github.com/users/eviltak","html_url":"https://github.com/eviltak","followers_url":"https://api.github.com/users/eviltak/followers","following_url":"https://api.github.com/users/eviltak/following{/other_user}","gists_url":"https://api.github.com/users/eviltak/gists{/gist_id}","starred_url":"https://api.github.com/users/eviltak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviltak/subscriptions","organizations_url":"https://api.github.com/users/eviltak/orgs","repos_url":"https://api.github.com/users/eviltak/repos","events_url":"https://api.github.com/users/eviltak/events{/privacy}","received_events_url":"https://api.github.com/users/eviltak/received_events","type":"User","site_admin":false},"repo":{"id":75466839,"name":"Terasology","full_name":"eviltak/Terasology","owner":{"login":"eviltak","id":8018181,"avatar_url":"https://avatars.githubusercontent.com/u/8018181?v=3","gravatar_id":"","url":"https://api.github.com/users/eviltak","html_url":"https://github.com/eviltak","followers_url":"https://api.github.com/users/eviltak/followers","following_url":"https://api.github.com/users/eviltak/following{/other_user}","gists_url":"https://api.github.com/users/eviltak/gists{/gist_id}","starred_url":"https://api.github.com/users/eviltak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviltak/subscriptions","organizations_url":"https://api.github.com/users/eviltak/orgs","repos_url":"https://api.github.com/users/eviltak/repos","events_url":"https://api.github.com/users/eviltak/events{/privacy}","received_events_url":"https://api.github.com/users/eviltak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eviltak/Terasology","description":"Terasology - open source voxel world","fork":true,"url":"https://api.github.com/repos/eviltak/Terasology","forks_url":"https://api.github.com/repos/eviltak/Terasology/forks","keys_url":"https://api.github.com/repos/eviltak/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eviltak/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eviltak/Terasology/teams","hooks_url":"https://api.github.com/repos/eviltak/Terasology/hooks","issue_events_url":"https://api.github.com/repos/eviltak/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/eviltak/Terasology/events","assignees_url":"https://api.github.com/repos/eviltak/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/eviltak/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/eviltak/Terasology/tags","blobs_url":"https://api.github.com/repos/eviltak/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eviltak/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eviltak/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/eviltak/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eviltak/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/eviltak/Terasology/languages","stargazers_url":"https://api.github.com/repos/eviltak/Terasology/stargazers","contributors_url":"https://api.github.com/repos/eviltak/Terasology/contributors","subscribers_url":"https://api.github.com/repos/eviltak/Terasology/subscribers","subscription_url":"https://api.github.com/repos/eviltak/Terasology/subscription","commits_url":"https://api.github.com/repos/eviltak/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/eviltak/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/eviltak/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/eviltak/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/eviltak/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/eviltak/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eviltak/Terasology/merges","archive_url":"https://api.github.com/repos/eviltak/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eviltak/Terasology/downloads","issues_url":"https://api.github.com/repos/eviltak/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/eviltak/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/eviltak/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/eviltak/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eviltak/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/eviltak/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/eviltak/Terasology/deployments","created_at":"2016-12-03T10:19:18Z","updated_at":"2016-12-03T10:19:29Z","pushed_at":"2016-12-05T07:22:07Z","git_url":"git://github.com/eviltak/Terasology.git","ssh_url":"git@github.com:eviltak/Terasology.git","clone_url":"https://github.com/eviltak/Terasology.git","svn_url":"https://github.com/eviltak/Terasology","homepage":"http://terasology.org","size":276707,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"691f5f0873c3ff0e48471b6b35feb21bdaf2c1ec","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2016-12-05T02:15:53Z","pushed_at":"2016-12-05T10:37:44Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":346033,"stargazers_count":1756,"watchers_count":1756,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":750,"mirror_url":null,"open_issues_count":323,"forks":750,"open_issues":323,"watchers":1756,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2641"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2641"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2641/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2641/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/211926b570c9d3288e215528c1d3f70728926034"}}}}
{"actor":{"display_login":"emanuele3d"}}