{"action":"created","issue":{"url":"https://api.github.com/repos/influxdata/influxdb/issues/7775","repository_url":"https://api.github.com/repos/influxdata/influxdb","labels_url":"https://api.github.com/repos/influxdata/influxdb/issues/7775/labels{/name}","comments_url":"https://api.github.com/repos/influxdata/influxdb/issues/7775/comments","events_url":"https://api.github.com/repos/influxdata/influxdb/issues/7775/events","html_url":"https://github.com/influxdata/influxdb/pull/7775","id":198057137,"number":7775,"title":"Removed ineffective assignments, and added checks for errors that pre…","user":{"login":"zegl","id":47952,"avatar_url":"https://avatars.githubusercontent.com/u/47952?v=3","gravatar_id":"","url":"https://api.github.com/users/zegl","html_url":"https://github.com/zegl","followers_url":"https://api.github.com/users/zegl/followers","following_url":"https://api.github.com/users/zegl/following{/other_user}","gists_url":"https://api.github.com/users/zegl/gists{/gist_id}","starred_url":"https://api.github.com/users/zegl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zegl/subscriptions","organizations_url":"https://api.github.com/users/zegl/orgs","repos_url":"https://api.github.com/users/zegl/repos","events_url":"https://api.github.com/users/zegl/events{/privacy}","received_events_url":"https://api.github.com/users/zegl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-29T19:32:11Z","updated_at":"2016-12-30T18:01:05Z","closed_at":"2016-12-30T18:00:53Z","pull_request":{"url":"https://api.github.com/repos/influxdata/influxdb/pulls/7775","html_url":"https://github.com/influxdata/influxdb/pull/7775","diff_url":"https://github.com/influxdata/influxdb/pull/7775.diff","patch_url":"https://github.com/influxdata/influxdb/pull/7775.patch"},"body":"This repository had a lot of ineffective assignments and unchecked error. I added err checks and changed so that there no longer are any ineffective assignments.\r\n\r\n```bash\r\ngustav@Kentauren ~/g/s/g/i/influxdb (master)> ineffassign .                                                                                                                        ✔\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/cmd/influx_inspect/dumptsm/dumptsm.go:117:9: ineffectual assignment to measurement\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/cmd/influx_inspect/dumptsm/dumptsm.go:117:22: ineffectual assignment to field\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/cmd/influx_tsm/tsdb/database.go:174:11: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/cmd/influxd/restore/restore.go:160:2: ineffectual assignment to length\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/coordinator/statement_executor_test.go:201:3: ineffectual assignment to out\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/influxql/functions.go:660:2: ineffectual assignment to sT\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/influxql/query_executor_test.go:146:2: ineffectual assignment to q\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/node.go:98:2: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/services/graphite/parser_test.go:681:25: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/services/snapshotter/client.go:47:2: ineffectual assignment to i\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/services/subscriber/http.go:25:13: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/stress/v2/stressql/statement/parser.go:611:2: ineffectual assignment to tok\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/stress/v2/stressql/statement/parser.go:614:2: ineffectual assignment to tok\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/bit_reader_test.go:19:5: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store.go:847:14: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:155:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:535:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:610:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:685:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:760:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:2072:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:2077:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/file_store_test.go:2084:10: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/reader_test.go:765:5: ineffectual assignment to err\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/tombstone_test.go:176:2: ineffectual assignment to entries\r\n/Users/gustav/go/src/github.com/influxdata/influxdb/tsdb/engine/tsm1/tombstone_test.go:223:2: ineffectual assignment to entries\r\n```\r\n\r\n###### Required for all non-trivial PRs\r\n- [x] Rebased/mergable\r\n- [x] Tests pass\r\n- [x] CHANGELOG.md updated\r\n- [x] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/influxdata/influxdb/issues/comments/269802204","html_url":"https://github.com/influxdata/influxdb/pull/7775#issuecomment-269802204","issue_url":"https://api.github.com/repos/influxdata/influxdb/issues/7775","id":269802204,"user":{"login":"mark-rushakoff","id":290647,"avatar_url":"https://avatars.githubusercontent.com/u/290647?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-rushakoff","html_url":"https://github.com/mark-rushakoff","followers_url":"https://api.github.com/users/mark-rushakoff/followers","following_url":"https://api.github.com/users/mark-rushakoff/following{/other_user}","gists_url":"https://api.github.com/users/mark-rushakoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-rushakoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-rushakoff/subscriptions","organizations_url":"https://api.github.com/users/mark-rushakoff/orgs","repos_url":"https://api.github.com/users/mark-rushakoff/repos","events_url":"https://api.github.com/users/mark-rushakoff/events{/privacy}","received_events_url":"https://api.github.com/users/mark-rushakoff/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T18:01:04Z","updated_at":"2016-12-30T18:01:04Z","body":"Thanks @zegl! "}}
{"actor":{"display_login":"mark-rushakoff"}}