{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/57673636","id":57673636,"diff_hunk":"@@ -7129,22 +7129,23 @@ public:\n                  *      // TypeIdentifier 'a', 'e', and 'v' should be TOKvar,\n                  *      // because getDsymbol() need to work in AliasDeclaration::semantic().\n                  */\n-                if (!v.type || !v.type.deco)\n+                if (!v.type ||\n+                    !v.type.deco && v.inuse)\n                 {\n                     if (v.inuse) // Bugzilla 9494\n-                    {\n-                        error(loc, \"circular reference to '%s'\", v.toPrettyChars());\n-                        *pe = new ErrorExp();\n-                        return;\n-                    }\n-                    if (v.sem < SemanticDone && v._scope)\n-                        v.semantic(null);\n+                        error(loc, \"circular reference to %s '%s'\", v.kind(), v.toPrettyChars());\n+                    else\n+                        error(loc, \"forward reference to %s '%s'\", v.kind(), v.toPrettyChars());\n+                    *pt = Type.terror;\n+                    return;\n                 }\n-                assert(v.type); // Bugzilla 14642\n                 if (v.type.ty == Terror)\n+                {\n                     *pt = Type.terror;\n-                else\n-                    *pe = new VarExp(loc, v);\n+                    return;","path":"src/mtype.d","position":37,"original_position":37,"commit_id":"9ef38d63e249588a94aab9e8eeb23805d8ca26ca","original_commit_id":"5d227e4faf62909ac76a9a90e6caf1caf692a051","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"body":"The diff shows there is no semantic difference.","created_at":"2016-03-29T05:32:48Z","updated_at":"2016-03-29T05:32:48Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/5588#discussion_r57673636","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/57673636"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/5588#discussion_r57673636"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588","id":64297229,"html_url":"https://github.com/D-Programming-Language/dmd/pull/5588","diff_url":"https://github.com/D-Programming-Language/dmd/pull/5588.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/5588.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5588","number":5588,"state":"open","locked":false,"title":"Consistent diagnostic & semantic process for forward/circular reference and circular initialization errors","user":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"body":"Share the logic.","created_at":"2016-03-28T07:31:34Z","updated_at":"2016-03-29T05:32:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd9cd8eb01c149346b4cab12dc63773d1626736","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5588/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/9ef38d63e249588a94aab9e8eeb23805d8ca26ca","head":{"label":"9rnsr:fix_circular_diag","ref":"fix_circular_diag","sha":"9ef38d63e249588a94aab9e8eeb23805d8ca26ca","user":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"repo":{"id":1434550,"name":"dmd","full_name":"9rnsr/dmd","owner":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/9rnsr/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/9rnsr/dmd","forks_url":"https://api.github.com/repos/9rnsr/dmd/forks","keys_url":"https://api.github.com/repos/9rnsr/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9rnsr/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9rnsr/dmd/teams","hooks_url":"https://api.github.com/repos/9rnsr/dmd/hooks","issue_events_url":"https://api.github.com/repos/9rnsr/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/9rnsr/dmd/events","assignees_url":"https://api.github.com/repos/9rnsr/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/9rnsr/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/9rnsr/dmd/tags","blobs_url":"https://api.github.com/repos/9rnsr/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9rnsr/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9rnsr/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/9rnsr/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9rnsr/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/9rnsr/dmd/languages","stargazers_url":"https://api.github.com/repos/9rnsr/dmd/stargazers","contributors_url":"https://api.github.com/repos/9rnsr/dmd/contributors","subscribers_url":"https://api.github.com/repos/9rnsr/dmd/subscribers","subscription_url":"https://api.github.com/repos/9rnsr/dmd/subscription","commits_url":"https://api.github.com/repos/9rnsr/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/9rnsr/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/9rnsr/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/9rnsr/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/9rnsr/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/9rnsr/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9rnsr/dmd/merges","archive_url":"https://api.github.com/repos/9rnsr/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9rnsr/dmd/downloads","issues_url":"https://api.github.com/repos/9rnsr/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/9rnsr/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/9rnsr/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/9rnsr/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9rnsr/dmd/labels{/name}","releases_url":"https://api.github.com/repos/9rnsr/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/9rnsr/dmd/deployments","created_at":"2011-03-03T10:24:37Z","updated_at":"2015-08-23T13:19:40Z","pushed_at":"2016-03-29T01:11:57Z","git_url":"git://github.com/9rnsr/dmd.git","ssh_url":"git@github.com:9rnsr/dmd.git","clone_url":"https://github.com/9rnsr/dmd.git","svn_url":"https://github.com/9rnsr/dmd","homepage":"d-programming-language.org","size":66087,"stargazers_count":2,"watchers_count":2,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"d7a46615f3849450979c8e5fa384bc7035db8c11","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/D-Programming-Language/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2016-03-28T13:22:00Z","pushed_at":"2016-03-29T03:05:12Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":87155,"stargazers_count":1203,"watchers_count":1203,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":361,"mirror_url":null,"open_issues_count":137,"forks":361,"open_issues":137,"watchers":1203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/5588"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5588"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5588/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5588/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/9ef38d63e249588a94aab9e8eeb23805d8ca26ca"}}}}