{"action":"created","comment":{"url":"https://api.github.com/repos/apache/reef/pulls/comments/62602933","id":62602933,"diff_hunk":"@@ -62,7 +62,11 @@ public void onNext(final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runt\n     if (evaluatorManager.isPresent()) {\n       evaluatorManager.get().onEvaluatorException(evaluatorException);\n     } else {\n-      LOG.log(Level.WARNING, \"Unknown evaluator runtime error: \" + error);\n+      if (this.evaluators.wasClosed(evaluatorId)) {\n+        LOG.log(Level.FINE, \"Evaluator [\" + evaluatorId + \"] has raised exception after it was closed.\");","path":"lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorResourceManagerErrorHandler.java","position":6,"original_position":6,"commit_id":"427e61f71d53ba94421bd32f3a7050b872c0a46a","original_commit_id":"427e61f71d53ba94421bd32f3a7050b872c0a46a","user":{"login":"jwang98052","id":5666504,"avatar_url":"https://avatars.githubusercontent.com/u/5666504?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang98052","html_url":"https://github.com/jwang98052","followers_url":"https://api.github.com/users/jwang98052/followers","following_url":"https://api.github.com/users/jwang98052/following{/other_user}","gists_url":"https://api.github.com/users/jwang98052/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang98052/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang98052/subscriptions","organizations_url":"https://api.github.com/users/jwang98052/orgs","repos_url":"https://api.github.com/users/jwang98052/repos","events_url":"https://api.github.com/users/jwang98052/events{/privacy}","received_events_url":"https://api.github.com/users/jwang98052/received_events","type":"User","site_admin":false},"body":"Should it still be a warning? ","created_at":"2016-05-10T02:05:19Z","updated_at":"2016-05-10T02:05:19Z","html_url":"https://github.com/apache/reef/pull/995#discussion_r62602933","pull_request_url":"https://api.github.com/repos/apache/reef/pulls/995","_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/comments/62602933"},"html":{"href":"https://github.com/apache/reef/pull/995#discussion_r62602933"},"pull_request":{"href":"https://api.github.com/repos/apache/reef/pulls/995"}}},"pull_request":{"url":"https://api.github.com/repos/apache/reef/pulls/995","id":69432475,"html_url":"https://github.com/apache/reef/pull/995","diff_url":"https://github.com/apache/reef/pull/995.diff","patch_url":"https://github.com/apache/reef/pull/995.patch","issue_url":"https://api.github.com/repos/apache/reef/issues/995","number":995,"state":"open","locked":false,"title":"[REEF-1250] Fix memory leak in Evaluators","user":{"login":"tcNickolas","id":10113024,"avatar_url":"https://avatars.githubusercontent.com/u/10113024?v=3","gravatar_id":"","url":"https://api.github.com/users/tcNickolas","html_url":"https://github.com/tcNickolas","followers_url":"https://api.github.com/users/tcNickolas/followers","following_url":"https://api.github.com/users/tcNickolas/following{/other_user}","gists_url":"https://api.github.com/users/tcNickolas/gists{/gist_id}","starred_url":"https://api.github.com/users/tcNickolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcNickolas/subscriptions","organizations_url":"https://api.github.com/users/tcNickolas/orgs","repos_url":"https://api.github.com/users/tcNickolas/repos","events_url":"https://api.github.com/users/tcNickolas/events{/privacy}","received_events_url":"https://api.github.com/users/tcNickolas/received_events","type":"User","site_admin":false},"body":"This change:\r\n * introduces a set of closed evaluator ids,\r\n * moves evaluator to this set whenever resource manager\r\n   sends resource status indicating that evaluator is closed.\r\n\r\nJIRA:\r\n  [REEF-1250](https://issues.apache.org/jira/browse/REEF-1250)\r\n\r\nPull request:\r\n  This closes #","created_at":"2016-05-10T00:27:47Z","updated_at":"2016-05-10T02:05:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"969f8bfdd3391e337f3ed4790827504c0c1c87d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/reef/pulls/995/commits","review_comments_url":"https://api.github.com/repos/apache/reef/pulls/995/comments","review_comment_url":"https://api.github.com/repos/apache/reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/reef/issues/995/comments","statuses_url":"https://api.github.com/repos/apache/reef/statuses/427e61f71d53ba94421bd32f3a7050b872c0a46a","head":{"label":"tcNickolas:REEF-1250","ref":"REEF-1250","sha":"427e61f71d53ba94421bd32f3a7050b872c0a46a","user":{"login":"tcNickolas","id":10113024,"avatar_url":"https://avatars.githubusercontent.com/u/10113024?v=3","gravatar_id":"","url":"https://api.github.com/users/tcNickolas","html_url":"https://github.com/tcNickolas","followers_url":"https://api.github.com/users/tcNickolas/followers","following_url":"https://api.github.com/users/tcNickolas/following{/other_user}","gists_url":"https://api.github.com/users/tcNickolas/gists{/gist_id}","starred_url":"https://api.github.com/users/tcNickolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcNickolas/subscriptions","organizations_url":"https://api.github.com/users/tcNickolas/orgs","repos_url":"https://api.github.com/users/tcNickolas/repos","events_url":"https://api.github.com/users/tcNickolas/events{/privacy}","received_events_url":"https://api.github.com/users/tcNickolas/received_events","type":"User","site_admin":false},"repo":{"id":36818251,"name":"reef","full_name":"tcNickolas/reef","owner":{"login":"tcNickolas","id":10113024,"avatar_url":"https://avatars.githubusercontent.com/u/10113024?v=3","gravatar_id":"","url":"https://api.github.com/users/tcNickolas","html_url":"https://github.com/tcNickolas","followers_url":"https://api.github.com/users/tcNickolas/followers","following_url":"https://api.github.com/users/tcNickolas/following{/other_user}","gists_url":"https://api.github.com/users/tcNickolas/gists{/gist_id}","starred_url":"https://api.github.com/users/tcNickolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcNickolas/subscriptions","organizations_url":"https://api.github.com/users/tcNickolas/orgs","repos_url":"https://api.github.com/users/tcNickolas/repos","events_url":"https://api.github.com/users/tcNickolas/events{/privacy}","received_events_url":"https://api.github.com/users/tcNickolas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tcNickolas/reef","description":"Mirror of Apache REEF","fork":true,"url":"https://api.github.com/repos/tcNickolas/reef","forks_url":"https://api.github.com/repos/tcNickolas/reef/forks","keys_url":"https://api.github.com/repos/tcNickolas/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcNickolas/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcNickolas/reef/teams","hooks_url":"https://api.github.com/repos/tcNickolas/reef/hooks","issue_events_url":"https://api.github.com/repos/tcNickolas/reef/issues/events{/number}","events_url":"https://api.github.com/repos/tcNickolas/reef/events","assignees_url":"https://api.github.com/repos/tcNickolas/reef/assignees{/user}","branches_url":"https://api.github.com/repos/tcNickolas/reef/branches{/branch}","tags_url":"https://api.github.com/repos/tcNickolas/reef/tags","blobs_url":"https://api.github.com/repos/tcNickolas/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcNickolas/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcNickolas/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcNickolas/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcNickolas/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/tcNickolas/reef/languages","stargazers_url":"https://api.github.com/repos/tcNickolas/reef/stargazers","contributors_url":"https://api.github.com/repos/tcNickolas/reef/contributors","subscribers_url":"https://api.github.com/repos/tcNickolas/reef/subscribers","subscription_url":"https://api.github.com/repos/tcNickolas/reef/subscription","commits_url":"https://api.github.com/repos/tcNickolas/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcNickolas/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcNickolas/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcNickolas/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcNickolas/reef/contents/{+path}","compare_url":"https://api.github.com/repos/tcNickolas/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcNickolas/reef/merges","archive_url":"https://api.github.com/repos/tcNickolas/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcNickolas/reef/downloads","issues_url":"https://api.github.com/repos/tcNickolas/reef/issues{/number}","pulls_url":"https://api.github.com/repos/tcNickolas/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/tcNickolas/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/tcNickolas/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcNickolas/reef/labels{/name}","releases_url":"https://api.github.com/repos/tcNickolas/reef/releases{/id}","deployments_url":"https://api.github.com/repos/tcNickolas/reef/deployments","created_at":"2015-06-03T17:08:00Z","updated_at":"2016-01-12T19:53:01Z","pushed_at":"2016-05-10T00:03:48Z","git_url":"git://github.com/tcNickolas/reef.git","ssh_url":"git@github.com:tcNickolas/reef.git","clone_url":"https://github.com/tcNickolas/reef.git","svn_url":"https://github.com/tcNickolas/reef","homepage":"","size":35127,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cafda7df5488a02f250379e2da7c445ecc324f82","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"reef","full_name":"apache/reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/reef","description":"Mirror of Apache REEF","fork":false,"url":"https://api.github.com/repos/apache/reef","forks_url":"https://api.github.com/repos/apache/reef/forks","keys_url":"https://api.github.com/repos/apache/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/reef/teams","hooks_url":"https://api.github.com/repos/apache/reef/hooks","issue_events_url":"https://api.github.com/repos/apache/reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/reef/events","assignees_url":"https://api.github.com/repos/apache/reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/reef/tags","blobs_url":"https://api.github.com/repos/apache/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/reef/languages","stargazers_url":"https://api.github.com/repos/apache/reef/stargazers","contributors_url":"https://api.github.com/repos/apache/reef/contributors","subscribers_url":"https://api.github.com/repos/apache/reef/subscribers","subscription_url":"https://api.github.com/repos/apache/reef/subscription","commits_url":"https://api.github.com/repos/apache/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/reef/merges","archive_url":"https://api.github.com/repos/apache/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/reef/downloads","issues_url":"https://api.github.com/repos/apache/reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/reef/releases{/id}","deployments_url":"https://api.github.com/repos/apache/reef/deployments","created_at":"2014-10-23T07:00:10Z","updated_at":"2016-04-23T12:24:09Z","pushed_at":"2016-05-10T00:27:47Z","git_url":"git://github.com/apache/reef.git","ssh_url":"git@github.com:apache/reef.git","clone_url":"https://github.com/apache/reef.git","svn_url":"https://github.com/apache/reef","homepage":"","size":48077,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":"git://git.apache.org/reef.git","open_issues_count":7,"forks":54,"open_issues":7,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/995"},"html":{"href":"https://github.com/apache/reef/pull/995"},"issue":{"href":"https://api.github.com/repos/apache/reef/issues/995"},"comments":{"href":"https://api.github.com/repos/apache/reef/issues/995/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/reef/pulls/995/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/reef/pulls/995/commits"},"statuses":{"href":"https://api.github.com/repos/apache/reef/statuses/427e61f71d53ba94421bd32f3a7050b872c0a46a"}}}}