{"action":"created","issue":{"url":"https://api.github.com/repos/electron/libchromiumcontent/issues/227","repository_url":"https://api.github.com/repos/electron/libchromiumcontent","labels_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/227/comments","events_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/227/events","html_url":"https://github.com/electron/libchromiumcontent/pull/227","id":174139344,"number":227,"title":"Fix for webviews using default (empty) BeginFrameSubscription implementation","user":{"login":"brenca","id":1690458,"avatar_url":"https://avatars.githubusercontent.com/u/1690458?v=3","gravatar_id":"","url":"https://api.github.com/users/brenca","html_url":"https://github.com/brenca","followers_url":"https://api.github.com/users/brenca/followers","following_url":"https://api.github.com/users/brenca/following{/other_user}","gists_url":"https://api.github.com/users/brenca/gists{/gist_id}","starred_url":"https://api.github.com/users/brenca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenca/subscriptions","organizations_url":"https://api.github.com/users/brenca/orgs","repos_url":"https://api.github.com/users/brenca/repos","events_url":"https://api.github.com/users/brenca/events{/privacy}","received_events_url":"https://api.github.com/users/brenca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-30T22:14:24Z","updated_at":"2016-08-30T22:41:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/227","html_url":"https://github.com/electron/libchromiumcontent/pull/227","diff_url":"https://github.com/electron/libchromiumcontent/pull/227.diff","patch_url":"https://github.com/electron/libchromiumcontent/pull/227.patch"},"body":"This PR adds a small patch to fix electron/electron#5665\r\n`RenderWidgetHostViewChildFrame` was missing some functions, I tried to keep the implementation as small as possible for easier maintenance."},"comment":{"url":"https://api.github.com/repos/electron/libchromiumcontent/issues/comments/243604611","html_url":"https://github.com/electron/libchromiumcontent/pull/227#issuecomment-243604611","issue_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/227","id":243604611,"user":{"login":"brenca","id":1690458,"avatar_url":"https://avatars.githubusercontent.com/u/1690458?v=3","gravatar_id":"","url":"https://api.github.com/users/brenca","html_url":"https://github.com/brenca","followers_url":"https://api.github.com/users/brenca/followers","following_url":"https://api.github.com/users/brenca/following{/other_user}","gists_url":"https://api.github.com/users/brenca/gists{/gist_id}","starred_url":"https://api.github.com/users/brenca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenca/subscriptions","organizations_url":"https://api.github.com/users/brenca/orgs","repos_url":"https://api.github.com/users/brenca/repos","events_url":"https://api.github.com/users/brenca/events{/privacy}","received_events_url":"https://api.github.com/users/brenca/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T22:41:09Z","updated_at":"2016-08-30T22:41:09Z","body":":) It was actually an issue with chromium's code, this is why I made a patch file to fix it. Also, you might want to wait until @zcbenz pulls this in (if he will :) ) and it gets included in the next electron release, since building a custom `libchromiumcontent` can easily take a full day (and most of it is just the building!), if you don't have machine specifically made for this kind of stuff. I couldn't test this out on Mac, but I did test it on Windows (the screenshot I added) and the subscription seems to be working perfectly now."}}
{"actor":{"display_login":"brenca"}}