{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/5042","repository_url":"https://api.github.com/repos/jekyll/jekyll","labels_url":"https://api.github.com/repos/jekyll/jekyll/issues/5042/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/5042/comments","events_url":"https://api.github.com/repos/jekyll/jekyll/issues/5042/events","html_url":"https://github.com/jekyll/jekyll/pull/5042","id":163038286,"number":5042,"title":"Fix more theme things","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jekyll/jekyll/milestones/33","html_url":"https://github.com/jekyll/jekyll/milestones/3.2","labels_url":"https://api.github.com/repos/jekyll/jekyll/milestones/33/labels","id":1483217,"number":33,"title":"3.2","description":null,"creator":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},"open_issues":14,"closed_issues":57,"state":"open","created_at":"2016-01-04T19:07:17Z","updated_at":"2016-07-13T02:50:32Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-06-29T22:08:41Z","updated_at":"2016-07-14T20:24:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/5042","html_url":"https://github.com/jekyll/jekyll/pull/5042","diff_url":"https://github.com/jekyll/jekyll/pull/5042.diff","patch_url":"https://github.com/jekyll/jekyll/pull/5042.patch"},"body":"Based on @benbalter's feedback at https://github.com/jekyll/jekyll/pull/4848#issuecomment-220862806\r\n\r\n> > `spec.files = %x{git ls-files -z}.split(\"\\x0\").reject { |f| f.match(%r{^(exe|_layouts|_includes|_sass|example|example/_posts)/}) }`\r\n>\r\n> Unless I'm misreading, we want to include layouts/includes/sass, the gemspec and exclude everything else (including exe). (A) I don't think this line accomplishes what we want right now, and (B) I'm wondering if we should default to a whitelist to encourage stronger defaults.\r\n\r\n@benbalter Yeah, we just want `_layouts`, `_includes`, and `_sass` to be shipped with the gem. The purpose of the line is to package up the theme for release.\r\n\r\n> > Rakefile... `example` dir\r\n>\r\n> This feels super heavyweight to me, and given that we have no way to e.g., distribute bug fixes to themes, I think we're setting ourselves up for heartbreak and failure \"To fix this issue, copy and paste this Gist into your theme's Rakefile\" `/headdesk`.\r\n\r\nYeah, that's totally a concern here. I just want an easy way to say \"run this, open your browser, and it'll all work\". Maybe it's a matter of saying: \"run `jekyll new-theme your-theme`, run `jekyll new testing-your-theme`, then modify `testing-your-theme/Gemfile` and `_config.yml` to set theme to `your-theme` and...\" man this is already feeling too complicated. I liked the idea of saying \"run `jekyll new-theme my-theme`, `cd my-theme`, `bundle install && bundle exec rake preview` and go!\" Maybe We need to create another Jekyll command...\r\n\r\n> we may not want to add a code of conduct by default\r\n\r\nGreat idea. I'll move this to a flag like `--coc` or `--code-of-conduct`."},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/232781434","html_url":"https://github.com/jekyll/jekyll/pull/5042#issuecomment-232781434","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/5042","id":232781434,"user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},"created_at":"2016-07-14T20:24:24Z","updated_at":"2016-07-14T20:24:24Z","body":"LGTM, too."}}
{"actor":{"display_login":"parkr"}}