{"action":"created","comment":{"url":"https://api.github.com/repos/scality/Arsenal/pulls/comments/79440524","id":79440524,"diff_hunk":"@@ -133,11 +133,17 @@ function meetConditions(requestContext, statementCondition, log) {\n             // reference_policies_multi-value-conditions.html)\n             const keyBasedOnRequestContext =\n                 findConditionKey(key, requestContext);\n-            // Handle IfExists\n+            // Handle IfExists and negation operators\n+            const operatorsWithNegation = ['StringNotEquals',","path":"lib/policyEvaluator/evaluator.js","position":null,"original_position":6,"commit_id":"c25121ed9aa2a6b46d59e2031f5966edfd9df023","original_commit_id":"18897cd2444f7daa4e9c3961513c99aab3b4b131","user":{"login":"nicolas2bert","id":7453636,"avatar_url":"https://avatars.githubusercontent.com/u/7453636?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas2bert","html_url":"https://github.com/nicolas2bert","followers_url":"https://api.github.com/users/nicolas2bert/followers","following_url":"https://api.github.com/users/nicolas2bert/following{/other_user}","gists_url":"https://api.github.com/users/nicolas2bert/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas2bert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas2bert/subscriptions","organizations_url":"https://api.github.com/users/nicolas2bert/orgs","repos_url":"https://api.github.com/users/nicolas2bert/repos","events_url":"https://api.github.com/users/nicolas2bert/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas2bert/received_events","type":"User","site_admin":false},"body":"I changed it.\r\n","created_at":"2016-09-19T17:12:45Z","updated_at":"2016-09-19T17:12:45Z","html_url":"https://github.com/scality/Arsenal/pull/143#discussion_r79440524","pull_request_url":"https://api.github.com/repos/scality/Arsenal/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/scality/Arsenal/pulls/comments/79440524"},"html":{"href":"https://github.com/scality/Arsenal/pull/143#discussion_r79440524"},"pull_request":{"href":"https://api.github.com/repos/scality/Arsenal/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/scality/Arsenal/pulls/143","id":81395812,"html_url":"https://github.com/scality/Arsenal/pull/143","diff_url":"https://github.com/scality/Arsenal/pull/143.diff","patch_url":"https://github.com/scality/Arsenal/pull/143.patch","issue_url":"https://api.github.com/repos/scality/Arsenal/issues/143","number":143,"state":"open","locked":false,"title":"FIX negation operator without request context","user":{"login":"nicolas2bert","id":7453636,"avatar_url":"https://avatars.githubusercontent.com/u/7453636?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas2bert","html_url":"https://github.com/nicolas2bert","followers_url":"https://api.github.com/users/nicolas2bert/followers","following_url":"https://api.github.com/users/nicolas2bert/following{/other_user}","gists_url":"https://api.github.com/users/nicolas2bert/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas2bert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas2bert/subscriptions","organizations_url":"https://api.github.com/users/nicolas2bert/orgs","repos_url":"https://api.github.com/users/nicolas2bert/repos","events_url":"https://api.github.com/users/nicolas2bert/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas2bert/received_events","type":"User","site_admin":false},"body":"This fix allows user to make an S3request not related to the negation condition operator. ","created_at":"2016-08-15T23:59:34Z","updated_at":"2016-09-19T17:12:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efbb711a44b697c668a51ee2bdbf7e633c16a12e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scality/Arsenal/pulls/143/commits","review_comments_url":"https://api.github.com/repos/scality/Arsenal/pulls/143/comments","review_comment_url":"https://api.github.com/repos/scality/Arsenal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/Arsenal/issues/143/comments","statuses_url":"https://api.github.com/repos/scality/Arsenal/statuses/c25121ed9aa2a6b46d59e2031f5966edfd9df023","head":{"label":"scality:bf/operators-with-negation","ref":"bf/operators-with-negation","sha":"c25121ed9aa2a6b46d59e2031f5966edfd9df023","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":42728835,"name":"Arsenal","full_name":"scality/Arsenal","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/Arsenal","description":"Common utilities for the open-source Scality S3 project components","fork":false,"url":"https://api.github.com/repos/scality/Arsenal","forks_url":"https://api.github.com/repos/scality/Arsenal/forks","keys_url":"https://api.github.com/repos/scality/Arsenal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/Arsenal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/Arsenal/teams","hooks_url":"https://api.github.com/repos/scality/Arsenal/hooks","issue_events_url":"https://api.github.com/repos/scality/Arsenal/issues/events{/number}","events_url":"https://api.github.com/repos/scality/Arsenal/events","assignees_url":"https://api.github.com/repos/scality/Arsenal/assignees{/user}","branches_url":"https://api.github.com/repos/scality/Arsenal/branches{/branch}","tags_url":"https://api.github.com/repos/scality/Arsenal/tags","blobs_url":"https://api.github.com/repos/scality/Arsenal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/Arsenal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/Arsenal/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/Arsenal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/Arsenal/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/Arsenal/languages","stargazers_url":"https://api.github.com/repos/scality/Arsenal/stargazers","contributors_url":"https://api.github.com/repos/scality/Arsenal/contributors","subscribers_url":"https://api.github.com/repos/scality/Arsenal/subscribers","subscription_url":"https://api.github.com/repos/scality/Arsenal/subscription","commits_url":"https://api.github.com/repos/scality/Arsenal/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/Arsenal/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/Arsenal/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/Arsenal/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/Arsenal/contents/{+path}","compare_url":"https://api.github.com/repos/scality/Arsenal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/Arsenal/merges","archive_url":"https://api.github.com/repos/scality/Arsenal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/Arsenal/downloads","issues_url":"https://api.github.com/repos/scality/Arsenal/issues{/number}","pulls_url":"https://api.github.com/repos/scality/Arsenal/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/Arsenal/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/Arsenal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/Arsenal/labels{/name}","releases_url":"https://api.github.com/repos/scality/Arsenal/releases{/id}","deployments_url":"https://api.github.com/repos/scality/Arsenal/deployments","created_at":"2015-09-18T14:58:21Z","updated_at":"2016-06-21T09:36:57Z","pushed_at":"2016-09-19T17:06:42Z","git_url":"git://github.com/scality/Arsenal.git","ssh_url":"git@github.com:scality/Arsenal.git","clone_url":"https://github.com/scality/Arsenal.git","svn_url":"https://github.com/scality/Arsenal","homepage":"","size":621,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":0,"default_branch":"master"}},"base":{"label":"scality:master","ref":"master","sha":"f2f00f436ad1465022666d0094bf5f4e86ab2d41","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":42728835,"name":"Arsenal","full_name":"scality/Arsenal","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/Arsenal","description":"Common utilities for the open-source Scality S3 project components","fork":false,"url":"https://api.github.com/repos/scality/Arsenal","forks_url":"https://api.github.com/repos/scality/Arsenal/forks","keys_url":"https://api.github.com/repos/scality/Arsenal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/Arsenal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/Arsenal/teams","hooks_url":"https://api.github.com/repos/scality/Arsenal/hooks","issue_events_url":"https://api.github.com/repos/scality/Arsenal/issues/events{/number}","events_url":"https://api.github.com/repos/scality/Arsenal/events","assignees_url":"https://api.github.com/repos/scality/Arsenal/assignees{/user}","branches_url":"https://api.github.com/repos/scality/Arsenal/branches{/branch}","tags_url":"https://api.github.com/repos/scality/Arsenal/tags","blobs_url":"https://api.github.com/repos/scality/Arsenal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/Arsenal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/Arsenal/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/Arsenal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/Arsenal/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/Arsenal/languages","stargazers_url":"https://api.github.com/repos/scality/Arsenal/stargazers","contributors_url":"https://api.github.com/repos/scality/Arsenal/contributors","subscribers_url":"https://api.github.com/repos/scality/Arsenal/subscribers","subscription_url":"https://api.github.com/repos/scality/Arsenal/subscription","commits_url":"https://api.github.com/repos/scality/Arsenal/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/Arsenal/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/Arsenal/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/Arsenal/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/Arsenal/contents/{+path}","compare_url":"https://api.github.com/repos/scality/Arsenal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/Arsenal/merges","archive_url":"https://api.github.com/repos/scality/Arsenal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/Arsenal/downloads","issues_url":"https://api.github.com/repos/scality/Arsenal/issues{/number}","pulls_url":"https://api.github.com/repos/scality/Arsenal/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/Arsenal/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/Arsenal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/Arsenal/labels{/name}","releases_url":"https://api.github.com/repos/scality/Arsenal/releases{/id}","deployments_url":"https://api.github.com/repos/scality/Arsenal/deployments","created_at":"2015-09-18T14:58:21Z","updated_at":"2016-06-21T09:36:57Z","pushed_at":"2016-09-19T17:06:42Z","git_url":"git://github.com/scality/Arsenal.git","ssh_url":"git@github.com:scality/Arsenal.git","clone_url":"https://github.com/scality/Arsenal.git","svn_url":"https://github.com/scality/Arsenal","homepage":"","size":621,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/Arsenal/pulls/143"},"html":{"href":"https://github.com/scality/Arsenal/pull/143"},"issue":{"href":"https://api.github.com/repos/scality/Arsenal/issues/143"},"comments":{"href":"https://api.github.com/repos/scality/Arsenal/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/Arsenal/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/Arsenal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/Arsenal/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/scality/Arsenal/statuses/c25121ed9aa2a6b46d59e2031f5966edfd9df023"}}}}
{"actor":{"display_login":"nicolas2bert"}}