{"action":"created","comment":{"url":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/comments/78679810","id":78679810,"diff_hunk":"@@ -20,7 +21,7 @@ function Connection(duplex, opts) {\n \n   opts = opts || {}\n \n-  var inStream  = generateStream()\n+  var inStream  = writeToStream()","path":"connection.js","position":15,"original_position":13,"commit_id":"535fa6fc5bfd5ba2438176852416bb88d3ada422","original_commit_id":"677232ad9a1f3b0642cb16e0cf32941a55b6023f","user":{"login":"jdiamond","id":110538,"avatar_url":"https://avatars.githubusercontent.com/u/110538?v=3","gravatar_id":"","url":"https://api.github.com/users/jdiamond","html_url":"https://github.com/jdiamond","followers_url":"https://api.github.com/users/jdiamond/followers","following_url":"https://api.github.com/users/jdiamond/following{/other_user}","gists_url":"https://api.github.com/users/jdiamond/gists{/gist_id}","starred_url":"https://api.github.com/users/jdiamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdiamond/subscriptions","organizations_url":"https://api.github.com/users/jdiamond/orgs","repos_url":"https://api.github.com/users/jdiamond/repos","events_url":"https://api.github.com/users/jdiamond/events{/privacy}","received_events_url":"https://api.github.com/users/jdiamond/received_events","type":"User","site_admin":false},"body":"No, `generateStream` isn't being used inside mqtt-connection anymore. It's part of the public API so I left it as is. Do you want me to remove it the whole file or just the reference to it from this file?","created_at":"2016-09-14T02:59:42Z","updated_at":"2016-09-14T02:59:42Z","html_url":"https://github.com/mqttjs/mqtt-connection/pull/4#discussion_r78679810","pull_request_url":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/comments/78679810"},"html":{"href":"https://github.com/mqttjs/mqtt-connection/pull/4#discussion_r78679810"},"pull_request":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4","id":83942091,"html_url":"https://github.com/mqttjs/mqtt-connection/pull/4","diff_url":"https://github.com/mqttjs/mqtt-connection/pull/4.diff","patch_url":"https://github.com/mqttjs/mqtt-connection/pull/4.patch","issue_url":"https://api.github.com/repos/mqttjs/mqtt-connection/issues/4","number":4,"state":"open","locked":false,"title":"fix tests to work with changes to mqtt-packet","user":{"login":"jdiamond","id":110538,"avatar_url":"https://avatars.githubusercontent.com/u/110538?v=3","gravatar_id":"","url":"https://api.github.com/users/jdiamond","html_url":"https://github.com/jdiamond","followers_url":"https://api.github.com/users/jdiamond/followers","following_url":"https://api.github.com/users/jdiamond/following{/other_user}","gists_url":"https://api.github.com/users/jdiamond/gists{/gist_id}","starred_url":"https://api.github.com/users/jdiamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdiamond/subscriptions","organizations_url":"https://api.github.com/users/jdiamond/orgs","repos_url":"https://api.github.com/users/jdiamond/repos","events_url":"https://api.github.com/users/jdiamond/events{/privacy}","received_events_url":"https://api.github.com/users/jdiamond/received_events","type":"User","site_admin":false},"body":"This fixes the tests that were failing due to various changes in mqtt-packet since the last time mqtt-connection was worked on.\r\n\r\nThat 2MB payload test that I had to increase the timeout for is taking 6-8 seconds to run on my Mac. Seems strange.\r\n\r\nMaybe it might also be worth updating the Travis file to include Node 4 and 6? I've never used Travis so I'll leave that to you.","created_at":"2016-09-05T02:02:59Z","updated_at":"2016-09-14T02:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"597e1da433f395cfba543a97b98ad703e97d0665","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4/commits","review_comments_url":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4/comments","review_comment_url":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mqttjs/mqtt-connection/issues/4/comments","statuses_url":"https://api.github.com/repos/mqttjs/mqtt-connection/statuses/535fa6fc5bfd5ba2438176852416bb88d3ada422","head":{"label":"jdiamond:fix-tests","ref":"fix-tests","sha":"535fa6fc5bfd5ba2438176852416bb88d3ada422","user":{"login":"jdiamond","id":110538,"avatar_url":"https://avatars.githubusercontent.com/u/110538?v=3","gravatar_id":"","url":"https://api.github.com/users/jdiamond","html_url":"https://github.com/jdiamond","followers_url":"https://api.github.com/users/jdiamond/followers","following_url":"https://api.github.com/users/jdiamond/following{/other_user}","gists_url":"https://api.github.com/users/jdiamond/gists{/gist_id}","starred_url":"https://api.github.com/users/jdiamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdiamond/subscriptions","organizations_url":"https://api.github.com/users/jdiamond/orgs","repos_url":"https://api.github.com/users/jdiamond/repos","events_url":"https://api.github.com/users/jdiamond/events{/privacy}","received_events_url":"https://api.github.com/users/jdiamond/received_events","type":"User","site_admin":false},"repo":{"id":67379629,"name":"mqtt-connection","full_name":"jdiamond/mqtt-connection","owner":{"login":"jdiamond","id":110538,"avatar_url":"https://avatars.githubusercontent.com/u/110538?v=3","gravatar_id":"","url":"https://api.github.com/users/jdiamond","html_url":"https://github.com/jdiamond","followers_url":"https://api.github.com/users/jdiamond/followers","following_url":"https://api.github.com/users/jdiamond/following{/other_user}","gists_url":"https://api.github.com/users/jdiamond/gists{/gist_id}","starred_url":"https://api.github.com/users/jdiamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdiamond/subscriptions","organizations_url":"https://api.github.com/users/jdiamond/orgs","repos_url":"https://api.github.com/users/jdiamond/repos","events_url":"https://api.github.com/users/jdiamond/events{/privacy}","received_events_url":"https://api.github.com/users/jdiamond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdiamond/mqtt-connection","description":"Barebone Connection object for MQTT in node.js","fork":true,"url":"https://api.github.com/repos/jdiamond/mqtt-connection","forks_url":"https://api.github.com/repos/jdiamond/mqtt-connection/forks","keys_url":"https://api.github.com/repos/jdiamond/mqtt-connection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdiamond/mqtt-connection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdiamond/mqtt-connection/teams","hooks_url":"https://api.github.com/repos/jdiamond/mqtt-connection/hooks","issue_events_url":"https://api.github.com/repos/jdiamond/mqtt-connection/issues/events{/number}","events_url":"https://api.github.com/repos/jdiamond/mqtt-connection/events","assignees_url":"https://api.github.com/repos/jdiamond/mqtt-connection/assignees{/user}","branches_url":"https://api.github.com/repos/jdiamond/mqtt-connection/branches{/branch}","tags_url":"https://api.github.com/repos/jdiamond/mqtt-connection/tags","blobs_url":"https://api.github.com/repos/jdiamond/mqtt-connection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdiamond/mqtt-connection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdiamond/mqtt-connection/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdiamond/mqtt-connection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdiamond/mqtt-connection/statuses/{sha}","languages_url":"https://api.github.com/repos/jdiamond/mqtt-connection/languages","stargazers_url":"https://api.github.com/repos/jdiamond/mqtt-connection/stargazers","contributors_url":"https://api.github.com/repos/jdiamond/mqtt-connection/contributors","subscribers_url":"https://api.github.com/repos/jdiamond/mqtt-connection/subscribers","subscription_url":"https://api.github.com/repos/jdiamond/mqtt-connection/subscription","commits_url":"https://api.github.com/repos/jdiamond/mqtt-connection/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdiamond/mqtt-connection/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdiamond/mqtt-connection/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdiamond/mqtt-connection/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdiamond/mqtt-connection/contents/{+path}","compare_url":"https://api.github.com/repos/jdiamond/mqtt-connection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdiamond/mqtt-connection/merges","archive_url":"https://api.github.com/repos/jdiamond/mqtt-connection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdiamond/mqtt-connection/downloads","issues_url":"https://api.github.com/repos/jdiamond/mqtt-connection/issues{/number}","pulls_url":"https://api.github.com/repos/jdiamond/mqtt-connection/pulls{/number}","milestones_url":"https://api.github.com/repos/jdiamond/mqtt-connection/milestones{/number}","notifications_url":"https://api.github.com/repos/jdiamond/mqtt-connection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdiamond/mqtt-connection/labels{/name}","releases_url":"https://api.github.com/repos/jdiamond/mqtt-connection/releases{/id}","deployments_url":"https://api.github.com/repos/jdiamond/mqtt-connection/deployments","created_at":"2016-09-05T01:55:59Z","updated_at":"2016-09-05T01:56:02Z","pushed_at":"2016-09-13T07:32:01Z","git_url":"git://github.com/jdiamond/mqtt-connection.git","ssh_url":"git@github.com:jdiamond/mqtt-connection.git","clone_url":"https://github.com/jdiamond/mqtt-connection.git","svn_url":"https://github.com/jdiamond/mqtt-connection","homepage":"","size":28,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mqttjs:master","ref":"master","sha":"6fbdd615293e47dfa011535757621aa8c16481cd","user":{"login":"mqttjs","id":10424911,"avatar_url":"https://avatars.githubusercontent.com/u/10424911?v=3","gravatar_id":"","url":"https://api.github.com/users/mqttjs","html_url":"https://github.com/mqttjs","followers_url":"https://api.github.com/users/mqttjs/followers","following_url":"https://api.github.com/users/mqttjs/following{/other_user}","gists_url":"https://api.github.com/users/mqttjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mqttjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqttjs/subscriptions","organizations_url":"https://api.github.com/users/mqttjs/orgs","repos_url":"https://api.github.com/users/mqttjs/repos","events_url":"https://api.github.com/users/mqttjs/events{/privacy}","received_events_url":"https://api.github.com/users/mqttjs/received_events","type":"Organization","site_admin":false},"repo":{"id":28049654,"name":"mqtt-connection","full_name":"mqttjs/mqtt-connection","owner":{"login":"mqttjs","id":10424911,"avatar_url":"https://avatars.githubusercontent.com/u/10424911?v=3","gravatar_id":"","url":"https://api.github.com/users/mqttjs","html_url":"https://github.com/mqttjs","followers_url":"https://api.github.com/users/mqttjs/followers","following_url":"https://api.github.com/users/mqttjs/following{/other_user}","gists_url":"https://api.github.com/users/mqttjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mqttjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqttjs/subscriptions","organizations_url":"https://api.github.com/users/mqttjs/orgs","repos_url":"https://api.github.com/users/mqttjs/repos","events_url":"https://api.github.com/users/mqttjs/events{/privacy}","received_events_url":"https://api.github.com/users/mqttjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mqttjs/mqtt-connection","description":"Barebone Connection object for MQTT in node.js","fork":false,"url":"https://api.github.com/repos/mqttjs/mqtt-connection","forks_url":"https://api.github.com/repos/mqttjs/mqtt-connection/forks","keys_url":"https://api.github.com/repos/mqttjs/mqtt-connection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mqttjs/mqtt-connection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mqttjs/mqtt-connection/teams","hooks_url":"https://api.github.com/repos/mqttjs/mqtt-connection/hooks","issue_events_url":"https://api.github.com/repos/mqttjs/mqtt-connection/issues/events{/number}","events_url":"https://api.github.com/repos/mqttjs/mqtt-connection/events","assignees_url":"https://api.github.com/repos/mqttjs/mqtt-connection/assignees{/user}","branches_url":"https://api.github.com/repos/mqttjs/mqtt-connection/branches{/branch}","tags_url":"https://api.github.com/repos/mqttjs/mqtt-connection/tags","blobs_url":"https://api.github.com/repos/mqttjs/mqtt-connection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mqttjs/mqtt-connection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mqttjs/mqtt-connection/git/refs{/sha}","trees_url":"https://api.github.com/repos/mqttjs/mqtt-connection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mqttjs/mqtt-connection/statuses/{sha}","languages_url":"https://api.github.com/repos/mqttjs/mqtt-connection/languages","stargazers_url":"https://api.github.com/repos/mqttjs/mqtt-connection/stargazers","contributors_url":"https://api.github.com/repos/mqttjs/mqtt-connection/contributors","subscribers_url":"https://api.github.com/repos/mqttjs/mqtt-connection/subscribers","subscription_url":"https://api.github.com/repos/mqttjs/mqtt-connection/subscription","commits_url":"https://api.github.com/repos/mqttjs/mqtt-connection/commits{/sha}","git_commits_url":"https://api.github.com/repos/mqttjs/mqtt-connection/git/commits{/sha}","comments_url":"https://api.github.com/repos/mqttjs/mqtt-connection/comments{/number}","issue_comment_url":"https://api.github.com/repos/mqttjs/mqtt-connection/issues/comments{/number}","contents_url":"https://api.github.com/repos/mqttjs/mqtt-connection/contents/{+path}","compare_url":"https://api.github.com/repos/mqttjs/mqtt-connection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mqttjs/mqtt-connection/merges","archive_url":"https://api.github.com/repos/mqttjs/mqtt-connection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mqttjs/mqtt-connection/downloads","issues_url":"https://api.github.com/repos/mqttjs/mqtt-connection/issues{/number}","pulls_url":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls{/number}","milestones_url":"https://api.github.com/repos/mqttjs/mqtt-connection/milestones{/number}","notifications_url":"https://api.github.com/repos/mqttjs/mqtt-connection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mqttjs/mqtt-connection/labels{/name}","releases_url":"https://api.github.com/repos/mqttjs/mqtt-connection/releases{/id}","deployments_url":"https://api.github.com/repos/mqttjs/mqtt-connection/deployments","created_at":"2014-12-15T18:17:14Z","updated_at":"2016-07-16T10:31:02Z","pushed_at":"2016-09-13T07:32:01Z","git_url":"git://github.com/mqttjs/mqtt-connection.git","ssh_url":"git@github.com:mqttjs/mqtt-connection.git","clone_url":"https://github.com/mqttjs/mqtt-connection.git","svn_url":"https://github.com/mqttjs/mqtt-connection","homepage":"","size":331,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4"},"html":{"href":"https://github.com/mqttjs/mqtt-connection/pull/4"},"issue":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/issues/4"},"comments":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/mqttjs/mqtt-connection/statuses/535fa6fc5bfd5ba2438176852416bb88d3ada422"}}}}
{"actor":{"display_login":"jdiamond"}}