{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/gax-python/pulls/comments/53391049","id":53391049,"diff_hunk":"@@ -42,5 +42,81 @@ class PageDescriptor(\n             ['request_page_token_field',\n              'response_page_token_field',\n              'resource_field'])):\n-    \"\"\"Describes the structure of a page-streaming call\"\"\"\n+    \"\"\"Describes the structure of a page-streaming call.\"\"\"\n     pass\n+\n+\n+class BundleDescriptor(\n+        collections.namedtuple(\n+            'BundleDescriptor',\n+            ['bundled_field',\n+             'request_descriminator_fields'])):\n+    \"\"\"Describes the structure of bundled call.\n+\n+    request_descriminator_fields may include '.' as a separator, which is used\n+    to indicate object traversal.  This allows fields in nested objects to be\n+    used to determine what requests to bundle.\n+\n+    Attributes:\n+      bundled_field: the repeated field in the request message that\n+        will have its messages aggregated by bundling\n+      request_descriminator_fields: a list of fields in the\n+        target request message class that are used to determine\n+        which messages should be bundled together.\n+    \"\"\"\n+    pass\n+\n+\n+class BundleOptions(\n+        collections.namedtuple(\n+            'BundleOptions',\n+            ['message_count_threshold',\n+             'message_bytesize_threshold',\n+             'delay_threshold'])):\n+    \"\"\"Holds values used to configure bundling.\n+\n+    The xxx_threshold attributes are used to configure when the bundled request\n+    should be made.\n+\n+    Attributes:\n+        message_count_threshold: the bundled request will be sent once\n+            the count of outstanding messages reaches this value\n+        message_bytesize_threshold: the bundled request will be sent once\n+            the count of bytes in the outstanding messages reaches this value\n+        delay_threshold: the bundled request will be sent this amount of\n+            time after the first message in the bundle was added to it.\n+\n+    \"\"\"\n+    # pylint: disable=too-few-public-methods\n+\n+    def __new__(cls,\n+                message_count_threshold=0,\n+                message_bytesize_threshold=0,\n+                delay_threshold=0):\n+        \"\"\"Invokes the base constructor with default values.\n+\n+        The default values are 1 for message_count_threshold and 0 for the other","path":"google/gax/__init__.py","position":67,"original_position":67,"commit_id":"71adf5305850cbe428828fd983d91cae1ad0461f","original_commit_id":"71adf5305850cbe428828fd983d91cae1ad0461f","user":{"login":"geigerj","id":14222439,"avatar_url":"https://avatars.githubusercontent.com/u/14222439?v=3","gravatar_id":"","url":"https://api.github.com/users/geigerj","html_url":"https://github.com/geigerj","followers_url":"https://api.github.com/users/geigerj/followers","following_url":"https://api.github.com/users/geigerj/following{/other_user}","gists_url":"https://api.github.com/users/geigerj/gists{/gist_id}","starred_url":"https://api.github.com/users/geigerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geigerj/subscriptions","organizations_url":"https://api.github.com/users/geigerj/orgs","repos_url":"https://api.github.com/users/geigerj/repos","events_url":"https://api.github.com/users/geigerj/events{/privacy}","received_events_url":"https://api.github.com/users/geigerj/received_events","type":"User","site_admin":false},"body":"Update this comment?","created_at":"2016-02-18T22:11:37Z","updated_at":"2016-02-18T22:11:37Z","html_url":"https://github.com/googleapis/gax-python/pull/17#discussion_r53391049","pull_request_url":"https://api.github.com/repos/googleapis/gax-python/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-python/pulls/comments/53391049"},"html":{"href":"https://github.com/googleapis/gax-python/pull/17#discussion_r53391049"},"pull_request":{"href":"https://api.github.com/repos/googleapis/gax-python/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/gax-python/pulls/17","id":59849157,"html_url":"https://github.com/googleapis/gax-python/pull/17","diff_url":"https://github.com/googleapis/gax-python/pull/17.diff","patch_url":"https://github.com/googleapis/gax-python/pull/17.patch","issue_url":"https://api.github.com/repos/googleapis/gax-python/issues/17","number":17,"state":"open","locked":false,"title":"Begins to provide support for bundling","user":{"login":"tbetbetbe","id":9272342,"avatar_url":"https://avatars.githubusercontent.com/u/9272342?v=3","gravatar_id":"","url":"https://api.github.com/users/tbetbetbe","html_url":"https://github.com/tbetbetbe","followers_url":"https://api.github.com/users/tbetbetbe/followers","following_url":"https://api.github.com/users/tbetbetbe/following{/other_user}","gists_url":"https://api.github.com/users/tbetbetbe/gists{/gist_id}","starred_url":"https://api.github.com/users/tbetbetbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbetbetbe/subscriptions","organizations_url":"https://api.github.com/users/tbetbetbe/orgs","repos_url":"https://api.github.com/users/tbetbetbe/repos","events_url":"https://api.github.com/users/tbetbetbe/events{/privacy}","received_events_url":"https://api.github.com/users/tbetbetbe/received_events","type":"User","site_admin":false},"body":"Status\r\n- this is not complete yet\r\n- additional features + unittests need to be added\r\n- however, there should be enough to allow code-gen to incorporate this\r\n\r\nThe missing behaviour will be added in follow-up PRs\r\n\r\nChange-Id: Ib6ab7db8a5947f6ea12ba6faa1202817f8dc6abc","created_at":"2016-02-18T19:22:02Z","updated_at":"2016-02-18T22:11:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"326bce0675855ff9c0133d689954bc2a7fcf5726","assignee":{"login":"geigerj","id":14222439,"avatar_url":"https://avatars.githubusercontent.com/u/14222439?v=3","gravatar_id":"","url":"https://api.github.com/users/geigerj","html_url":"https://github.com/geigerj","followers_url":"https://api.github.com/users/geigerj/followers","following_url":"https://api.github.com/users/geigerj/following{/other_user}","gists_url":"https://api.github.com/users/geigerj/gists{/gist_id}","starred_url":"https://api.github.com/users/geigerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geigerj/subscriptions","organizations_url":"https://api.github.com/users/geigerj/orgs","repos_url":"https://api.github.com/users/geigerj/repos","events_url":"https://api.github.com/users/geigerj/events{/privacy}","received_events_url":"https://api.github.com/users/geigerj/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/gax-python/pulls/17/commits","review_comments_url":"https://api.github.com/repos/googleapis/gax-python/pulls/17/comments","review_comment_url":"https://api.github.com/repos/googleapis/gax-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/gax-python/issues/17/comments","statuses_url":"https://api.github.com/repos/googleapis/gax-python/statuses/71adf5305850cbe428828fd983d91cae1ad0461f","head":{"label":"tbetbetbe:add-bundling-support","ref":"add-bundling-support","sha":"71adf5305850cbe428828fd983d91cae1ad0461f","user":{"login":"tbetbetbe","id":9272342,"avatar_url":"https://avatars.githubusercontent.com/u/9272342?v=3","gravatar_id":"","url":"https://api.github.com/users/tbetbetbe","html_url":"https://github.com/tbetbetbe","followers_url":"https://api.github.com/users/tbetbetbe/followers","following_url":"https://api.github.com/users/tbetbetbe/following{/other_user}","gists_url":"https://api.github.com/users/tbetbetbe/gists{/gist_id}","starred_url":"https://api.github.com/users/tbetbetbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbetbetbe/subscriptions","organizations_url":"https://api.github.com/users/tbetbetbe/orgs","repos_url":"https://api.github.com/users/tbetbetbe/repos","events_url":"https://api.github.com/users/tbetbetbe/events{/privacy}","received_events_url":"https://api.github.com/users/tbetbetbe/received_events","type":"User","site_admin":false},"repo":{"id":51486966,"name":"gax-python","full_name":"tbetbetbe/gax-python","owner":{"login":"tbetbetbe","id":9272342,"avatar_url":"https://avatars.githubusercontent.com/u/9272342?v=3","gravatar_id":"","url":"https://api.github.com/users/tbetbetbe","html_url":"https://github.com/tbetbetbe","followers_url":"https://api.github.com/users/tbetbetbe/followers","following_url":"https://api.github.com/users/tbetbetbe/following{/other_user}","gists_url":"https://api.github.com/users/tbetbetbe/gists{/gist_id}","starred_url":"https://api.github.com/users/tbetbetbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbetbetbe/subscriptions","organizations_url":"https://api.github.com/users/tbetbetbe/orgs","repos_url":"https://api.github.com/users/tbetbetbe/repos","events_url":"https://api.github.com/users/tbetbetbe/events{/privacy}","received_events_url":"https://api.github.com/users/tbetbetbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbetbetbe/gax-python","description":"","fork":true,"url":"https://api.github.com/repos/tbetbetbe/gax-python","forks_url":"https://api.github.com/repos/tbetbetbe/gax-python/forks","keys_url":"https://api.github.com/repos/tbetbetbe/gax-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbetbetbe/gax-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbetbetbe/gax-python/teams","hooks_url":"https://api.github.com/repos/tbetbetbe/gax-python/hooks","issue_events_url":"https://api.github.com/repos/tbetbetbe/gax-python/issues/events{/number}","events_url":"https://api.github.com/repos/tbetbetbe/gax-python/events","assignees_url":"https://api.github.com/repos/tbetbetbe/gax-python/assignees{/user}","branches_url":"https://api.github.com/repos/tbetbetbe/gax-python/branches{/branch}","tags_url":"https://api.github.com/repos/tbetbetbe/gax-python/tags","blobs_url":"https://api.github.com/repos/tbetbetbe/gax-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbetbetbe/gax-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbetbetbe/gax-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbetbetbe/gax-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbetbetbe/gax-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tbetbetbe/gax-python/languages","stargazers_url":"https://api.github.com/repos/tbetbetbe/gax-python/stargazers","contributors_url":"https://api.github.com/repos/tbetbetbe/gax-python/contributors","subscribers_url":"https://api.github.com/repos/tbetbetbe/gax-python/subscribers","subscription_url":"https://api.github.com/repos/tbetbetbe/gax-python/subscription","commits_url":"https://api.github.com/repos/tbetbetbe/gax-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbetbetbe/gax-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbetbetbe/gax-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbetbetbe/gax-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbetbetbe/gax-python/contents/{+path}","compare_url":"https://api.github.com/repos/tbetbetbe/gax-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbetbetbe/gax-python/merges","archive_url":"https://api.github.com/repos/tbetbetbe/gax-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbetbetbe/gax-python/downloads","issues_url":"https://api.github.com/repos/tbetbetbe/gax-python/issues{/number}","pulls_url":"https://api.github.com/repos/tbetbetbe/gax-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tbetbetbe/gax-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tbetbetbe/gax-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbetbetbe/gax-python/labels{/name}","releases_url":"https://api.github.com/repos/tbetbetbe/gax-python/releases{/id}","deployments_url":"https://api.github.com/repos/tbetbetbe/gax-python/deployments","created_at":"2016-02-11T01:28:42Z","updated_at":"2016-02-11T01:28:42Z","pushed_at":"2016-02-18T21:31:03Z","git_url":"git://github.com/tbetbetbe/gax-python.git","ssh_url":"git@github.com:tbetbetbe/gax-python.git","clone_url":"https://github.com/tbetbetbe/gax-python.git","svn_url":"https://github.com/tbetbetbe/gax-python","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"129214498faf5451d7b7195232cf519986022865","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":50878409,"name":"gax-python","full_name":"googleapis/gax-python","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/gax-python","description":"","fork":false,"url":"https://api.github.com/repos/googleapis/gax-python","forks_url":"https://api.github.com/repos/googleapis/gax-python/forks","keys_url":"https://api.github.com/repos/googleapis/gax-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/gax-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/gax-python/teams","hooks_url":"https://api.github.com/repos/googleapis/gax-python/hooks","issue_events_url":"https://api.github.com/repos/googleapis/gax-python/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/gax-python/events","assignees_url":"https://api.github.com/repos/googleapis/gax-python/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/gax-python/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/gax-python/tags","blobs_url":"https://api.github.com/repos/googleapis/gax-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/gax-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/gax-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/gax-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/gax-python/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/gax-python/languages","stargazers_url":"https://api.github.com/repos/googleapis/gax-python/stargazers","contributors_url":"https://api.github.com/repos/googleapis/gax-python/contributors","subscribers_url":"https://api.github.com/repos/googleapis/gax-python/subscribers","subscription_url":"https://api.github.com/repos/googleapis/gax-python/subscription","commits_url":"https://api.github.com/repos/googleapis/gax-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/gax-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/gax-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/gax-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/gax-python/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/gax-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/gax-python/merges","archive_url":"https://api.github.com/repos/googleapis/gax-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/gax-python/downloads","issues_url":"https://api.github.com/repos/googleapis/gax-python/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/gax-python/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/gax-python/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/gax-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/gax-python/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/gax-python/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/gax-python/deployments","created_at":"2016-02-01T23:13:08Z","updated_at":"2016-02-11T16:50:47Z","pushed_at":"2016-02-18T21:31:04Z","git_url":"git://github.com/googleapis/gax-python.git","ssh_url":"git@github.com:googleapis/gax-python.git","clone_url":"https://github.com/googleapis/gax-python.git","svn_url":"https://github.com/googleapis/gax-python","homepage":null,"size":86,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-python/pulls/17"},"html":{"href":"https://github.com/googleapis/gax-python/pull/17"},"issue":{"href":"https://api.github.com/repos/googleapis/gax-python/issues/17"},"comments":{"href":"https://api.github.com/repos/googleapis/gax-python/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/gax-python/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/gax-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/gax-python/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/gax-python/statuses/71adf5305850cbe428828fd983d91cae1ad0461f"}}}}