{"action":"created","comment":{"url":"https://api.github.com/repos/troessner/reek/pulls/comments/73670781","id":73670781,"diff_hunk":"@@ -271,6 +271,15 @@ def bad(fred)\n       expect(src).to reek_of(:NestedIterators, count: 2).with_config(config)\n     end\n   end\n+\n+  it 'should analyze safe-navigation-operator without error' do\n+    src = '\n+      def f\n+        x&.tap {|_| }\n+      end\n+    '\n+    expect(src).not_to reek_of(:NestedIterators, count: 2)","path":"spec/reek/smells/nested_iterators_spec.rb","position":11,"original_position":11,"commit_id":"77347c6b2c1dae8f48bfac8c1d719510c56e0003","original_commit_id":"77347c6b2c1dae8f48bfac8c1d719510c56e0003","user":{"login":"troessner","id":271109,"avatar_url":"https://avatars.githubusercontent.com/u/271109?v=3","gravatar_id":"","url":"https://api.github.com/users/troessner","html_url":"https://github.com/troessner","followers_url":"https://api.github.com/users/troessner/followers","following_url":"https://api.github.com/users/troessner/following{/other_user}","gists_url":"https://api.github.com/users/troessner/gists{/gist_id}","starred_url":"https://api.github.com/users/troessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troessner/subscriptions","organizations_url":"https://api.github.com/users/troessner/orgs","repos_url":"https://api.github.com/users/troessner/repos","events_url":"https://api.github.com/users/troessner/events{/privacy}","received_events_url":"https://api.github.com/users/troessner/received_events","type":"User","site_admin":false},"body":"I don't think this test makes much sense here. The error just happened there coincidentally. Having this test here is going to be super-confusing for us in 6 months.\r\n\r\nHow about:\r\n\r\n* creating a directory in the [samples](https://github.com/troessner/reek/tree/master/spec/samples) directory called \"super_smelly\"\r\n* put \"inline.rb\", \"optparse.rb\" and \"redcloth.rb\" in there\r\n* create a new file called \"syntax_checks.rb\"\r\n* Put the code above in it\r\n* Update our [samples feature](https://github.com/troessner/reek/blob/master/features/samples.feature) to include this as well\r\n\r\nWDYT? cc @mvz \r\n","created_at":"2016-08-05T10:12:07Z","updated_at":"2016-08-05T10:12:07Z","html_url":"https://github.com/troessner/reek/pull/1004#discussion_r73670781","pull_request_url":"https://api.github.com/repos/troessner/reek/pulls/1004","_links":{"self":{"href":"https://api.github.com/repos/troessner/reek/pulls/comments/73670781"},"html":{"href":"https://github.com/troessner/reek/pull/1004#discussion_r73670781"},"pull_request":{"href":"https://api.github.com/repos/troessner/reek/pulls/1004"}}},"pull_request":{"url":"https://api.github.com/repos/troessner/reek/pulls/1004","id":80070852,"html_url":"https://github.com/troessner/reek/pull/1004","diff_url":"https://github.com/troessner/reek/pull/1004.diff","patch_url":"https://github.com/troessner/reek/pull/1004.patch","issue_url":"https://api.github.com/repos/troessner/reek/issues/1004","number":1004,"state":"open","locked":false,"title":"Add SexpExtensions::CSendNode for safe navigation operator","user":{"login":"soutaro","id":139089,"avatar_url":"https://avatars.githubusercontent.com/u/139089?v=3","gravatar_id":"","url":"https://api.github.com/users/soutaro","html_url":"https://github.com/soutaro","followers_url":"https://api.github.com/users/soutaro/followers","following_url":"https://api.github.com/users/soutaro/following{/other_user}","gists_url":"https://api.github.com/users/soutaro/gists{/gist_id}","starred_url":"https://api.github.com/users/soutaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soutaro/subscriptions","organizations_url":"https://api.github.com/users/soutaro/orgs","repos_url":"https://api.github.com/users/soutaro/repos","events_url":"https://api.github.com/users/soutaro/events{/privacy}","received_events_url":"https://api.github.com/users/soutaro/received_events","type":"User","site_admin":false},"body":"Currently `:csend` node is not supported, and the following Ruby code may make reek crash:\r\n\r\n```rb\r\nfoo&.bar()\r\n```\r\n\r\nThis PR is to fix the issue by adding `CSendNode`.","created_at":"2016-08-04T12:38:47Z","updated_at":"2016-08-05T10:12:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d581c568697a41bd3ff6c1a045f8aaa01365a4a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/troessner/reek/pulls/1004/commits","review_comments_url":"https://api.github.com/repos/troessner/reek/pulls/1004/comments","review_comment_url":"https://api.github.com/repos/troessner/reek/pulls/comments{/number}","comments_url":"https://api.github.com/repos/troessner/reek/issues/1004/comments","statuses_url":"https://api.github.com/repos/troessner/reek/statuses/77347c6b2c1dae8f48bfac8c1d719510c56e0003","head":{"label":"soutaro:safe-navigation-operator","ref":"safe-navigation-operator","sha":"77347c6b2c1dae8f48bfac8c1d719510c56e0003","user":{"login":"soutaro","id":139089,"avatar_url":"https://avatars.githubusercontent.com/u/139089?v=3","gravatar_id":"","url":"https://api.github.com/users/soutaro","html_url":"https://github.com/soutaro","followers_url":"https://api.github.com/users/soutaro/followers","following_url":"https://api.github.com/users/soutaro/following{/other_user}","gists_url":"https://api.github.com/users/soutaro/gists{/gist_id}","starred_url":"https://api.github.com/users/soutaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soutaro/subscriptions","organizations_url":"https://api.github.com/users/soutaro/orgs","repos_url":"https://api.github.com/users/soutaro/repos","events_url":"https://api.github.com/users/soutaro/events{/privacy}","received_events_url":"https://api.github.com/users/soutaro/received_events","type":"User","site_admin":false},"repo":{"id":64728213,"name":"reek","full_name":"soutaro/reek","owner":{"login":"soutaro","id":139089,"avatar_url":"https://avatars.githubusercontent.com/u/139089?v=3","gravatar_id":"","url":"https://api.github.com/users/soutaro","html_url":"https://github.com/soutaro","followers_url":"https://api.github.com/users/soutaro/followers","following_url":"https://api.github.com/users/soutaro/following{/other_user}","gists_url":"https://api.github.com/users/soutaro/gists{/gist_id}","starred_url":"https://api.github.com/users/soutaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soutaro/subscriptions","organizations_url":"https://api.github.com/users/soutaro/orgs","repos_url":"https://api.github.com/users/soutaro/repos","events_url":"https://api.github.com/users/soutaro/events{/privacy}","received_events_url":"https://api.github.com/users/soutaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soutaro/reek","description":"Code smell detector for Ruby","fork":true,"url":"https://api.github.com/repos/soutaro/reek","forks_url":"https://api.github.com/repos/soutaro/reek/forks","keys_url":"https://api.github.com/repos/soutaro/reek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soutaro/reek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soutaro/reek/teams","hooks_url":"https://api.github.com/repos/soutaro/reek/hooks","issue_events_url":"https://api.github.com/repos/soutaro/reek/issues/events{/number}","events_url":"https://api.github.com/repos/soutaro/reek/events","assignees_url":"https://api.github.com/repos/soutaro/reek/assignees{/user}","branches_url":"https://api.github.com/repos/soutaro/reek/branches{/branch}","tags_url":"https://api.github.com/repos/soutaro/reek/tags","blobs_url":"https://api.github.com/repos/soutaro/reek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soutaro/reek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soutaro/reek/git/refs{/sha}","trees_url":"https://api.github.com/repos/soutaro/reek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soutaro/reek/statuses/{sha}","languages_url":"https://api.github.com/repos/soutaro/reek/languages","stargazers_url":"https://api.github.com/repos/soutaro/reek/stargazers","contributors_url":"https://api.github.com/repos/soutaro/reek/contributors","subscribers_url":"https://api.github.com/repos/soutaro/reek/subscribers","subscription_url":"https://api.github.com/repos/soutaro/reek/subscription","commits_url":"https://api.github.com/repos/soutaro/reek/commits{/sha}","git_commits_url":"https://api.github.com/repos/soutaro/reek/git/commits{/sha}","comments_url":"https://api.github.com/repos/soutaro/reek/comments{/number}","issue_comment_url":"https://api.github.com/repos/soutaro/reek/issues/comments{/number}","contents_url":"https://api.github.com/repos/soutaro/reek/contents/{+path}","compare_url":"https://api.github.com/repos/soutaro/reek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soutaro/reek/merges","archive_url":"https://api.github.com/repos/soutaro/reek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soutaro/reek/downloads","issues_url":"https://api.github.com/repos/soutaro/reek/issues{/number}","pulls_url":"https://api.github.com/repos/soutaro/reek/pulls{/number}","milestones_url":"https://api.github.com/repos/soutaro/reek/milestones{/number}","notifications_url":"https://api.github.com/repos/soutaro/reek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soutaro/reek/labels{/name}","releases_url":"https://api.github.com/repos/soutaro/reek/releases{/id}","deployments_url":"https://api.github.com/repos/soutaro/reek/deployments","created_at":"2016-08-02T05:54:43Z","updated_at":"2016-08-02T05:54:44Z","pushed_at":"2016-08-05T05:13:23Z","git_url":"git://github.com/soutaro/reek.git","ssh_url":"git@github.com:soutaro/reek.git","clone_url":"https://github.com/soutaro/reek.git","svn_url":"https://github.com/soutaro/reek","homepage":"https://github.com/troessner/reek/wiki","size":4423,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"troessner:master","ref":"master","sha":"39919a9514c4495b74e16080aaeb769f08506f07","user":{"login":"troessner","id":271109,"avatar_url":"https://avatars.githubusercontent.com/u/271109?v=3","gravatar_id":"","url":"https://api.github.com/users/troessner","html_url":"https://github.com/troessner","followers_url":"https://api.github.com/users/troessner/followers","following_url":"https://api.github.com/users/troessner/following{/other_user}","gists_url":"https://api.github.com/users/troessner/gists{/gist_id}","starred_url":"https://api.github.com/users/troessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troessner/subscriptions","organizations_url":"https://api.github.com/users/troessner/orgs","repos_url":"https://api.github.com/users/troessner/repos","events_url":"https://api.github.com/users/troessner/events{/privacy}","received_events_url":"https://api.github.com/users/troessner/received_events","type":"User","site_admin":false},"repo":{"id":49515,"name":"reek","full_name":"troessner/reek","owner":{"login":"troessner","id":271109,"avatar_url":"https://avatars.githubusercontent.com/u/271109?v=3","gravatar_id":"","url":"https://api.github.com/users/troessner","html_url":"https://github.com/troessner","followers_url":"https://api.github.com/users/troessner/followers","following_url":"https://api.github.com/users/troessner/following{/other_user}","gists_url":"https://api.github.com/users/troessner/gists{/gist_id}","starred_url":"https://api.github.com/users/troessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troessner/subscriptions","organizations_url":"https://api.github.com/users/troessner/orgs","repos_url":"https://api.github.com/users/troessner/repos","events_url":"https://api.github.com/users/troessner/events{/privacy}","received_events_url":"https://api.github.com/users/troessner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/troessner/reek","description":"Code smell detector for Ruby","fork":false,"url":"https://api.github.com/repos/troessner/reek","forks_url":"https://api.github.com/repos/troessner/reek/forks","keys_url":"https://api.github.com/repos/troessner/reek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/troessner/reek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/troessner/reek/teams","hooks_url":"https://api.github.com/repos/troessner/reek/hooks","issue_events_url":"https://api.github.com/repos/troessner/reek/issues/events{/number}","events_url":"https://api.github.com/repos/troessner/reek/events","assignees_url":"https://api.github.com/repos/troessner/reek/assignees{/user}","branches_url":"https://api.github.com/repos/troessner/reek/branches{/branch}","tags_url":"https://api.github.com/repos/troessner/reek/tags","blobs_url":"https://api.github.com/repos/troessner/reek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/troessner/reek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/troessner/reek/git/refs{/sha}","trees_url":"https://api.github.com/repos/troessner/reek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/troessner/reek/statuses/{sha}","languages_url":"https://api.github.com/repos/troessner/reek/languages","stargazers_url":"https://api.github.com/repos/troessner/reek/stargazers","contributors_url":"https://api.github.com/repos/troessner/reek/contributors","subscribers_url":"https://api.github.com/repos/troessner/reek/subscribers","subscription_url":"https://api.github.com/repos/troessner/reek/subscription","commits_url":"https://api.github.com/repos/troessner/reek/commits{/sha}","git_commits_url":"https://api.github.com/repos/troessner/reek/git/commits{/sha}","comments_url":"https://api.github.com/repos/troessner/reek/comments{/number}","issue_comment_url":"https://api.github.com/repos/troessner/reek/issues/comments{/number}","contents_url":"https://api.github.com/repos/troessner/reek/contents/{+path}","compare_url":"https://api.github.com/repos/troessner/reek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/troessner/reek/merges","archive_url":"https://api.github.com/repos/troessner/reek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/troessner/reek/downloads","issues_url":"https://api.github.com/repos/troessner/reek/issues{/number}","pulls_url":"https://api.github.com/repos/troessner/reek/pulls{/number}","milestones_url":"https://api.github.com/repos/troessner/reek/milestones{/number}","notifications_url":"https://api.github.com/repos/troessner/reek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/troessner/reek/labels{/name}","releases_url":"https://api.github.com/repos/troessner/reek/releases{/id}","deployments_url":"https://api.github.com/repos/troessner/reek/deployments","created_at":"2008-09-05T10:48:33Z","updated_at":"2016-08-03T21:28:09Z","pushed_at":"2016-08-05T05:13:24Z","git_url":"git://github.com/troessner/reek.git","ssh_url":"git@github.com:troessner/reek.git","clone_url":"https://github.com/troessner/reek.git","svn_url":"https://github.com/troessner/reek","homepage":"https://github.com/troessner/reek/wiki","size":5317,"stargazers_count":2029,"watchers_count":2029,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":42,"forks":132,"open_issues":42,"watchers":2029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/troessner/reek/pulls/1004"},"html":{"href":"https://github.com/troessner/reek/pull/1004"},"issue":{"href":"https://api.github.com/repos/troessner/reek/issues/1004"},"comments":{"href":"https://api.github.com/repos/troessner/reek/issues/1004/comments"},"review_comments":{"href":"https://api.github.com/repos/troessner/reek/pulls/1004/comments"},"review_comment":{"href":"https://api.github.com/repos/troessner/reek/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/troessner/reek/pulls/1004/commits"},"statuses":{"href":"https://api.github.com/repos/troessner/reek/statuses/77347c6b2c1dae8f48bfac8c1d719510c56e0003"}}}}
{"actor":{"display_login":"troessner"}}