{"action":"created","comment":{"url":"https://api.github.com/repos/kiddouk/letslambda/pulls/comments/66719790","id":66719790,"diff_hunk":"@@ -1,30 +1,25 @@\n # -*- coding: utf-8 -*-\n \n-import yaml\n-from Crypto.PublicKey import RSA\n-from boto import s3\n-from boto import iam\n-from boto import route53\n-from boto.s3.connection import OrdinaryCallingFormat\n-from boto.s3.key import Key\n-from boto.exception import S3ResponseError\n+import base64\n+import boto3\n+import hashlib\n import logging\n+import os\n+import requests\n+import yaml\n+from acme import challenges\n from acme import client\n+from acme import errors\n from acme import messages\n-from acme import challenges\n-import io\n-import requests\n-import base64\n-import hashlib\n-from time import sleep\n-from OpenSSL import crypto\n-from datetime import datetime\n-from boto.ec2 import elb\n from acme.jose.util import ComparableX509\n-import os\n-\n-# this is the AWS region in which the function runs in\n-exec_region = os.environ['AWS_DEFAULT_REGION']\n+from botocore.config import Config\n+from botocore.exceptions import ClientError\n+from Crypto import Random\n+from Crypto.Cipher import AES","path":"letslambda.py","position":39,"original_position":39,"commit_id":"e67f714a83b5f10c210bbae22690d166f2370e99","original_commit_id":"e67f714a83b5f10c210bbae22690d166f2370e99","user":{"login":"kiddouk","id":391998,"avatar_url":"https://avatars.githubusercontent.com/u/391998?v=3","gravatar_id":"","url":"https://api.github.com/users/kiddouk","html_url":"https://github.com/kiddouk","followers_url":"https://api.github.com/users/kiddouk/followers","following_url":"https://api.github.com/users/kiddouk/following{/other_user}","gists_url":"https://api.github.com/users/kiddouk/gists{/gist_id}","starred_url":"https://api.github.com/users/kiddouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiddouk/subscriptions","organizations_url":"https://api.github.com/users/kiddouk/orgs","repos_url":"https://api.github.com/users/kiddouk/repos","events_url":"https://api.github.com/users/kiddouk/events{/privacy}","received_events_url":"https://api.github.com/users/kiddouk/received_events","type":"User","site_admin":false},"body":"unused import.","created_at":"2016-06-12T11:43:42Z","updated_at":"2016-06-12T11:43:42Z","html_url":"https://github.com/kiddouk/letslambda/pull/7#discussion_r66719790","pull_request_url":"https://api.github.com/repos/kiddouk/letslambda/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/kiddouk/letslambda/pulls/comments/66719790"},"html":{"href":"https://github.com/kiddouk/letslambda/pull/7#discussion_r66719790"},"pull_request":{"href":"https://api.github.com/repos/kiddouk/letslambda/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/kiddouk/letslambda/pulls/7","id":73484735,"html_url":"https://github.com/kiddouk/letslambda/pull/7","diff_url":"https://github.com/kiddouk/letslambda/pull/7.diff","patch_url":"https://github.com/kiddouk/letslambda/pull/7.patch","issue_url":"https://api.github.com/repos/kiddouk/letslambda/issues/7","number":7,"state":"open","locked":false,"title":"Support for private key encryption (KMS) and other bug fixes","user":{"login":"aureq","id":1161681,"avatar_url":"https://avatars.githubusercontent.com/u/1161681?v=3","gravatar_id":"","url":"https://api.github.com/users/aureq","html_url":"https://github.com/aureq","followers_url":"https://api.github.com/users/aureq/followers","following_url":"https://api.github.com/users/aureq/following{/other_user}","gists_url":"https://api.github.com/users/aureq/gists{/gist_id}","starred_url":"https://api.github.com/users/aureq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aureq/subscriptions","organizations_url":"https://api.github.com/users/aureq/orgs","repos_url":"https://api.github.com/users/aureq/repos","events_url":"https://api.github.com/users/aureq/events{/privacy}","received_events_url":"https://api.github.com/users/aureq/received_events","type":"User","site_admin":false},"body":"Here is the main changelog\r\n\r\n- apply bucket policy to enforce encryption of private keys\r\n- split IAM managed roles for easier reuse\r\n- reworked of all AWS calls using boto3\r\n- do not guess r53 zone name, get it from configuration 'r53_zone'\r\n- added support for elb custom SSL port via 'elb_port'\r\n- save private keys (account and domain) using AES256 or KMS key via 'kmsKeyArn'\r\n- wait for new IAM server certificate to become available when loading into ELB\r\n- correctly handle missing chain certificate\r\n- a lot more debugs and informative messages\r\n- made function names more consistent\r\n- catching more errors and exceptions whenever possible","created_at":"2016-06-12T03:09:24Z","updated_at":"2016-06-12T11:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dcd15b6ee7aa4814bb9ef164e474b0e3070ed5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kiddouk/letslambda/pulls/7/commits","review_comments_url":"https://api.github.com/repos/kiddouk/letslambda/pulls/7/comments","review_comment_url":"https://api.github.com/repos/kiddouk/letslambda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiddouk/letslambda/issues/7/comments","statuses_url":"https://api.github.com/repos/kiddouk/letslambda/statuses/e67f714a83b5f10c210bbae22690d166f2370e99","head":{"label":"aureq:kms-dev","ref":"kms-dev","sha":"e67f714a83b5f10c210bbae22690d166f2370e99","user":{"login":"aureq","id":1161681,"avatar_url":"https://avatars.githubusercontent.com/u/1161681?v=3","gravatar_id":"","url":"https://api.github.com/users/aureq","html_url":"https://github.com/aureq","followers_url":"https://api.github.com/users/aureq/followers","following_url":"https://api.github.com/users/aureq/following{/other_user}","gists_url":"https://api.github.com/users/aureq/gists{/gist_id}","starred_url":"https://api.github.com/users/aureq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aureq/subscriptions","organizations_url":"https://api.github.com/users/aureq/orgs","repos_url":"https://api.github.com/users/aureq/repos","events_url":"https://api.github.com/users/aureq/events{/privacy}","received_events_url":"https://api.github.com/users/aureq/received_events","type":"User","site_admin":false},"repo":{"id":58333234,"name":"letslambda","full_name":"aureq/letslambda","owner":{"login":"aureq","id":1161681,"avatar_url":"https://avatars.githubusercontent.com/u/1161681?v=3","gravatar_id":"","url":"https://api.github.com/users/aureq","html_url":"https://github.com/aureq","followers_url":"https://api.github.com/users/aureq/followers","following_url":"https://api.github.com/users/aureq/following{/other_user}","gists_url":"https://api.github.com/users/aureq/gists{/gist_id}","starred_url":"https://api.github.com/users/aureq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aureq/subscriptions","organizations_url":"https://api.github.com/users/aureq/orgs","repos_url":"https://api.github.com/users/aureq/repos","events_url":"https://api.github.com/users/aureq/events{/privacy}","received_events_url":"https://api.github.com/users/aureq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aureq/letslambda","description":"","fork":true,"url":"https://api.github.com/repos/aureq/letslambda","forks_url":"https://api.github.com/repos/aureq/letslambda/forks","keys_url":"https://api.github.com/repos/aureq/letslambda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aureq/letslambda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aureq/letslambda/teams","hooks_url":"https://api.github.com/repos/aureq/letslambda/hooks","issue_events_url":"https://api.github.com/repos/aureq/letslambda/issues/events{/number}","events_url":"https://api.github.com/repos/aureq/letslambda/events","assignees_url":"https://api.github.com/repos/aureq/letslambda/assignees{/user}","branches_url":"https://api.github.com/repos/aureq/letslambda/branches{/branch}","tags_url":"https://api.github.com/repos/aureq/letslambda/tags","blobs_url":"https://api.github.com/repos/aureq/letslambda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aureq/letslambda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aureq/letslambda/git/refs{/sha}","trees_url":"https://api.github.com/repos/aureq/letslambda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aureq/letslambda/statuses/{sha}","languages_url":"https://api.github.com/repos/aureq/letslambda/languages","stargazers_url":"https://api.github.com/repos/aureq/letslambda/stargazers","contributors_url":"https://api.github.com/repos/aureq/letslambda/contributors","subscribers_url":"https://api.github.com/repos/aureq/letslambda/subscribers","subscription_url":"https://api.github.com/repos/aureq/letslambda/subscription","commits_url":"https://api.github.com/repos/aureq/letslambda/commits{/sha}","git_commits_url":"https://api.github.com/repos/aureq/letslambda/git/commits{/sha}","comments_url":"https://api.github.com/repos/aureq/letslambda/comments{/number}","issue_comment_url":"https://api.github.com/repos/aureq/letslambda/issues/comments{/number}","contents_url":"https://api.github.com/repos/aureq/letslambda/contents/{+path}","compare_url":"https://api.github.com/repos/aureq/letslambda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aureq/letslambda/merges","archive_url":"https://api.github.com/repos/aureq/letslambda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aureq/letslambda/downloads","issues_url":"https://api.github.com/repos/aureq/letslambda/issues{/number}","pulls_url":"https://api.github.com/repos/aureq/letslambda/pulls{/number}","milestones_url":"https://api.github.com/repos/aureq/letslambda/milestones{/number}","notifications_url":"https://api.github.com/repos/aureq/letslambda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aureq/letslambda/labels{/name}","releases_url":"https://api.github.com/repos/aureq/letslambda/releases{/id}","deployments_url":"https://api.github.com/repos/aureq/letslambda/deployments","created_at":"2016-05-08T21:55:33Z","updated_at":"2016-06-12T09:48:12Z","pushed_at":"2016-06-12T05:13:09Z","git_url":"git://github.com/aureq/letslambda.git","ssh_url":"git@github.com:aureq/letslambda.git","clone_url":"https://github.com/aureq/letslambda.git","svn_url":"https://github.com/aureq/letslambda","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiddouk:master","ref":"master","sha":"b2dfeff5537f51fecb90b071ba767195eced5098","user":{"login":"kiddouk","id":391998,"avatar_url":"https://avatars.githubusercontent.com/u/391998?v=3","gravatar_id":"","url":"https://api.github.com/users/kiddouk","html_url":"https://github.com/kiddouk","followers_url":"https://api.github.com/users/kiddouk/followers","following_url":"https://api.github.com/users/kiddouk/following{/other_user}","gists_url":"https://api.github.com/users/kiddouk/gists{/gist_id}","starred_url":"https://api.github.com/users/kiddouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiddouk/subscriptions","organizations_url":"https://api.github.com/users/kiddouk/orgs","repos_url":"https://api.github.com/users/kiddouk/repos","events_url":"https://api.github.com/users/kiddouk/events{/privacy}","received_events_url":"https://api.github.com/users/kiddouk/received_events","type":"User","site_admin":false},"repo":{"id":57042839,"name":"letslambda","full_name":"kiddouk/letslambda","owner":{"login":"kiddouk","id":391998,"avatar_url":"https://avatars.githubusercontent.com/u/391998?v=3","gravatar_id":"","url":"https://api.github.com/users/kiddouk","html_url":"https://github.com/kiddouk","followers_url":"https://api.github.com/users/kiddouk/followers","following_url":"https://api.github.com/users/kiddouk/following{/other_user}","gists_url":"https://api.github.com/users/kiddouk/gists{/gist_id}","starred_url":"https://api.github.com/users/kiddouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiddouk/subscriptions","organizations_url":"https://api.github.com/users/kiddouk/orgs","repos_url":"https://api.github.com/users/kiddouk/repos","events_url":"https://api.github.com/users/kiddouk/events{/privacy}","received_events_url":"https://api.github.com/users/kiddouk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kiddouk/letslambda","description":"An AWS Lambda function that creates, renew and install your Letsencrypt certificate in your ELB","fork":false,"url":"https://api.github.com/repos/kiddouk/letslambda","forks_url":"https://api.github.com/repos/kiddouk/letslambda/forks","keys_url":"https://api.github.com/repos/kiddouk/letslambda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiddouk/letslambda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiddouk/letslambda/teams","hooks_url":"https://api.github.com/repos/kiddouk/letslambda/hooks","issue_events_url":"https://api.github.com/repos/kiddouk/letslambda/issues/events{/number}","events_url":"https://api.github.com/repos/kiddouk/letslambda/events","assignees_url":"https://api.github.com/repos/kiddouk/letslambda/assignees{/user}","branches_url":"https://api.github.com/repos/kiddouk/letslambda/branches{/branch}","tags_url":"https://api.github.com/repos/kiddouk/letslambda/tags","blobs_url":"https://api.github.com/repos/kiddouk/letslambda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiddouk/letslambda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiddouk/letslambda/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiddouk/letslambda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiddouk/letslambda/statuses/{sha}","languages_url":"https://api.github.com/repos/kiddouk/letslambda/languages","stargazers_url":"https://api.github.com/repos/kiddouk/letslambda/stargazers","contributors_url":"https://api.github.com/repos/kiddouk/letslambda/contributors","subscribers_url":"https://api.github.com/repos/kiddouk/letslambda/subscribers","subscription_url":"https://api.github.com/repos/kiddouk/letslambda/subscription","commits_url":"https://api.github.com/repos/kiddouk/letslambda/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiddouk/letslambda/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiddouk/letslambda/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiddouk/letslambda/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiddouk/letslambda/contents/{+path}","compare_url":"https://api.github.com/repos/kiddouk/letslambda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiddouk/letslambda/merges","archive_url":"https://api.github.com/repos/kiddouk/letslambda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiddouk/letslambda/downloads","issues_url":"https://api.github.com/repos/kiddouk/letslambda/issues{/number}","pulls_url":"https://api.github.com/repos/kiddouk/letslambda/pulls{/number}","milestones_url":"https://api.github.com/repos/kiddouk/letslambda/milestones{/number}","notifications_url":"https://api.github.com/repos/kiddouk/letslambda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiddouk/letslambda/labels{/name}","releases_url":"https://api.github.com/repos/kiddouk/letslambda/releases{/id}","deployments_url":"https://api.github.com/repos/kiddouk/letslambda/deployments","created_at":"2016-04-25T13:14:21Z","updated_at":"2016-05-16T18:05:59Z","pushed_at":"2016-06-12T05:13:09Z","git_url":"git://github.com/kiddouk/letslambda.git","ssh_url":"git@github.com:kiddouk/letslambda.git","clone_url":"https://github.com/kiddouk/letslambda.git","svn_url":"https://github.com/kiddouk/letslambda","homepage":"","size":21,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiddouk/letslambda/pulls/7"},"html":{"href":"https://github.com/kiddouk/letslambda/pull/7"},"issue":{"href":"https://api.github.com/repos/kiddouk/letslambda/issues/7"},"comments":{"href":"https://api.github.com/repos/kiddouk/letslambda/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/kiddouk/letslambda/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/kiddouk/letslambda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiddouk/letslambda/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/kiddouk/letslambda/statuses/e67f714a83b5f10c210bbae22690d166f2370e99"}}}}
{"actor":{"display_login":"kiddouk"}}