{"action":"opened","number":38473,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/38473","id":98629123,"html_url":"https://github.com/rust-lang/rust/pull/38473","diff_url":"https://github.com/rust-lang/rust/pull/38473.diff","patch_url":"https://github.com/rust-lang/rust/pull/38473.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/38473","number":38473,"state":"open","locked":false,"title":"prefer hyphens in test files named after issue numbers","user":{"login":"zackmdavis","id":1076988,"avatar_url":"https://avatars.githubusercontent.com/u/1076988?v=3","gravatar_id":"","url":"https://api.github.com/users/zackmdavis","html_url":"https://github.com/zackmdavis","followers_url":"https://api.github.com/users/zackmdavis/followers","following_url":"https://api.github.com/users/zackmdavis/following{/other_user}","gists_url":"https://api.github.com/users/zackmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/zackmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackmdavis/subscriptions","organizations_url":"https://api.github.com/users/zackmdavis/orgs","repos_url":"https://api.github.com/users/zackmdavis/repos","events_url":"https://api.github.com/users/zackmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/zackmdavis/received_events","type":"User","site_admin":false},"body":"We have a lot of tests with filenames honoring particular issues by\r\nnumber. Typically, these are called issue-${issue_no}.rs (note the\r\nhyphen):\r\n\r\n```\r\n$ find . -regextype posix-egrep -regex '.*/issue-[0-9]*.rs' | wc\r\n   1289    1289   35935\r\n```\r\n\r\nWe also had a much smaller number of files that are like this, but don't\r\nhave a hyphen in between the substring `issue` and the number:\r\n\r\n```\r\n$ find . -regextype posix-egrep -regex '.*/issue[0-9]*.rs'\r\n./debuginfo/issue14411.rs\r\n./debuginfo/issue12886.rs\r\n./debuginfo/issue13213.rs\r\n./debuginfo/issue22656.rs\r\n./debuginfo/issue7712.rs\r\n./compile-fail/issue32829.rs\r\n./run-pass/issue24353.rs\r\n./run-pass/issue34796.rs\r\n./run-pass/issue18173.rs\r\n./run-pass/issue22346.rs\r\n./run-pass/auxiliary/issue13507.rs\r\n./run-pass/issue26127.rs\r\n./run-pass/issue22008.rs\r\n./run-pass/issue34569.rs\r\n./run-pass/issue29927.rs\r\n./run-pass/issue36260.rs\r\n```\r\n\r\nSome would argue that the inconsistency is æsthetically displeasing,\r\nhence this trivial patch. (Note that run-pass/auxiliary/issue13507.rs\r\nhas an excuse; it's `use`d in run-pass/issue-13507-2.rs; the matter of\r\nthere being two different compile-fail tests with different name\r\nconventions for issue no. 32829 is also neglected here for the sake of\r\nkeeping this trivial cleanup patch as trivial as possible for ease of\r\nreview.)","created_at":"2016-12-19T19:55:26Z","updated_at":"2016-12-19T19:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/38473/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/38473/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/38473/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/63cfedb73b5ebdc0d46f3fd8e8865306a590f826","head":{"label":"zackmdavis:issue_kebab","ref":"issue_kebab","sha":"63cfedb73b5ebdc0d46f3fd8e8865306a590f826","user":{"login":"zackmdavis","id":1076988,"avatar_url":"https://avatars.githubusercontent.com/u/1076988?v=3","gravatar_id":"","url":"https://api.github.com/users/zackmdavis","html_url":"https://github.com/zackmdavis","followers_url":"https://api.github.com/users/zackmdavis/followers","following_url":"https://api.github.com/users/zackmdavis/following{/other_user}","gists_url":"https://api.github.com/users/zackmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/zackmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackmdavis/subscriptions","organizations_url":"https://api.github.com/users/zackmdavis/orgs","repos_url":"https://api.github.com/users/zackmdavis/repos","events_url":"https://api.github.com/users/zackmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/zackmdavis/received_events","type":"User","site_admin":false},"repo":{"id":42497156,"name":"rust","full_name":"zackmdavis/rust","owner":{"login":"zackmdavis","id":1076988,"avatar_url":"https://avatars.githubusercontent.com/u/1076988?v=3","gravatar_id":"","url":"https://api.github.com/users/zackmdavis","html_url":"https://github.com/zackmdavis","followers_url":"https://api.github.com/users/zackmdavis/followers","following_url":"https://api.github.com/users/zackmdavis/following{/other_user}","gists_url":"https://api.github.com/users/zackmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/zackmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackmdavis/subscriptions","organizations_url":"https://api.github.com/users/zackmdavis/orgs","repos_url":"https://api.github.com/users/zackmdavis/repos","events_url":"https://api.github.com/users/zackmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/zackmdavis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zackmdavis/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/zackmdavis/rust","forks_url":"https://api.github.com/repos/zackmdavis/rust/forks","keys_url":"https://api.github.com/repos/zackmdavis/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zackmdavis/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zackmdavis/rust/teams","hooks_url":"https://api.github.com/repos/zackmdavis/rust/hooks","issue_events_url":"https://api.github.com/repos/zackmdavis/rust/issues/events{/number}","events_url":"https://api.github.com/repos/zackmdavis/rust/events","assignees_url":"https://api.github.com/repos/zackmdavis/rust/assignees{/user}","branches_url":"https://api.github.com/repos/zackmdavis/rust/branches{/branch}","tags_url":"https://api.github.com/repos/zackmdavis/rust/tags","blobs_url":"https://api.github.com/repos/zackmdavis/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zackmdavis/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zackmdavis/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/zackmdavis/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zackmdavis/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/zackmdavis/rust/languages","stargazers_url":"https://api.github.com/repos/zackmdavis/rust/stargazers","contributors_url":"https://api.github.com/repos/zackmdavis/rust/contributors","subscribers_url":"https://api.github.com/repos/zackmdavis/rust/subscribers","subscription_url":"https://api.github.com/repos/zackmdavis/rust/subscription","commits_url":"https://api.github.com/repos/zackmdavis/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/zackmdavis/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/zackmdavis/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/zackmdavis/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/zackmdavis/rust/contents/{+path}","compare_url":"https://api.github.com/repos/zackmdavis/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zackmdavis/rust/merges","archive_url":"https://api.github.com/repos/zackmdavis/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zackmdavis/rust/downloads","issues_url":"https://api.github.com/repos/zackmdavis/rust/issues{/number}","pulls_url":"https://api.github.com/repos/zackmdavis/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/zackmdavis/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/zackmdavis/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zackmdavis/rust/labels{/name}","releases_url":"https://api.github.com/repos/zackmdavis/rust/releases{/id}","deployments_url":"https://api.github.com/repos/zackmdavis/rust/deployments","created_at":"2015-09-15T05:24:26Z","updated_at":"2016-12-17T01:35:22Z","pushed_at":"2016-12-19T19:54:29Z","git_url":"git://github.com/zackmdavis/rust.git","ssh_url":"git@github.com:zackmdavis/rust.git","clone_url":"https://github.com/zackmdavis/rust.git","svn_url":"https://github.com/zackmdavis/rust","homepage":"http://www.rust-lang.org","size":315245,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"3f9823d5f53230e83b707b4876b5bb271a4c22ef","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-12-19T18:46:42Z","pushed_at":"2016-12-19T19:43:23Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":317145,"stargazers_count":19432,"watchers_count":19432,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3722,"mirror_url":null,"open_issues_count":2985,"forks":3722,"open_issues":2985,"watchers":19432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38473"},"html":{"href":"https://github.com/rust-lang/rust/pull/38473"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38473"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38473/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38473/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38473/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/63cfedb73b5ebdc0d46f3fd8e8865306a590f826"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":0,"changed_files":14}}
{"actor":{"display_login":"zackmdavis"}}