{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/73088765","id":73088765,"diff_hunk":"@@ -364,9 +369,27 @@ void RequestController::onTimer() {\n   SDL_AUTO_TRACE();\n   SDL_DEBUG(\n       \"ENTER Waiting fore response count: \" << waiting_for_response_.Size());\n-  RequestInfoPtr probably_expired =\n-      waiting_for_response_.FrontWithNotNullTimeout();\n-  while (probably_expired && probably_expired->isExpired()) {\n+  while(!stop_flag_) {","path":"src/components/application_manager/src/request_controller.cc","position":null,"original_position":27,"commit_id":"461e69fc7510ed435e71a6aa0e00242a128221ff","original_commit_id":"9647d0fe7cfc88e7fa1f82fe0921159c64390582","user":{"login":"BrandonHe","id":13449160,"avatar_url":"https://avatars.githubusercontent.com/u/13449160?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonHe","html_url":"https://github.com/BrandonHe","followers_url":"https://api.github.com/users/BrandonHe/followers","following_url":"https://api.github.com/users/BrandonHe/following{/other_user}","gists_url":"https://api.github.com/users/BrandonHe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonHe/subscriptions","organizations_url":"https://api.github.com/users/BrandonHe/orgs","repos_url":"https://api.github.com/users/BrandonHe/repos","events_url":"https://api.github.com/users/BrandonHe/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonHe/received_events","type":"User","site_admin":false},"body":"@LuxoftAKutsan Any other concerns do you have?","created_at":"2016-08-02T03:10:10Z","updated_at":"2016-08-02T03:10:10Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/660#discussion_r73088765","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/73088765"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/660#discussion_r73088765"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660","id":75923886,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/660","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/660.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/660.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/660","number":660,"state":"open","locked":false,"title":"Fix/resolve atf add sub menu known issues","user":{"login":"BrandonHe","id":13449160,"avatar_url":"https://avatars.githubusercontent.com/u/13449160?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonHe","html_url":"https://github.com/BrandonHe","followers_url":"https://api.github.com/users/BrandonHe/followers","following_url":"https://api.github.com/users/BrandonHe/following{/other_user}","gists_url":"https://api.github.com/users/BrandonHe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonHe/subscriptions","organizations_url":"https://api.github.com/users/BrandonHe/orgs","repos_url":"https://api.github.com/users/BrandonHe/repos","events_url":"https://api.github.com/users/BrandonHe/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonHe/received_events","type":"User","site_admin":false},"body":"Please help review @AByzhynar @pestOO @justinjdickow @anosach-luxoft \r\nReplace PR #654, change branch name from hotfix to fix\r\n\r\n### Code Update:\r\n- RequestController::UpdateTimer():<br>\r\n  Change the timer update logic from waiting until close and restart to unblock the waiting threads, avoid timeout issue\r\n- RequestController::OnTimer():<br>\r\n  Add Autolock and wait to process the condition of NOT probably_expired\r\n- SmartObject::cleanup_data():<br>\r\n  Set Smart Object clean up data to NULL after it's deleted\r\n\r\n### Verify Test:\r\n- PASSED: Both ATF_AddSubMenu and ATF_SetMediaClockTimer ATF tests, do the test several times\r\n- PASSED: SPT AddSubMenu function test(successfully add ten submenu)\r\n- PASSED: Unit test\r\n\r\n**Attached test result:**\r\n[unit_test_reuslt.txt](https://github.com/smartdevicelink/sdl_core/files/342775/unit_test_reuslt.txt)\r\n[ATF_AddSubMenu_fix_test_result.txt](https://github.com/smartdevicelink/sdl_core/files/342777/ATF_AddSubMenu_fix_test_result.txt)\r\n[ATF_SetMediaClockTimer_fix_test_result.txt](https://github.com/smartdevicelink/sdl_core/files/342778/ATF_SetMediaClockTimer_fix_test_result.txt)\r\n\r\n\r\n\r\n\r\n","created_at":"2016-07-01T03:49:30Z","updated_at":"2016-08-02T03:10:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d2dd05a4f0efaf6f8d7760ff762125f5b7640c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/660/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/461e69fc7510ed435e71a6aa0e00242a128221ff","head":{"label":"BrandonHe:fix/resolve_ATF_AddSubMenu_KnownIssues","ref":"fix/resolve_ATF_AddSubMenu_KnownIssues","sha":"461e69fc7510ed435e71a6aa0e00242a128221ff","user":{"login":"BrandonHe","id":13449160,"avatar_url":"https://avatars.githubusercontent.com/u/13449160?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonHe","html_url":"https://github.com/BrandonHe","followers_url":"https://api.github.com/users/BrandonHe/followers","following_url":"https://api.github.com/users/BrandonHe/following{/other_user}","gists_url":"https://api.github.com/users/BrandonHe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonHe/subscriptions","organizations_url":"https://api.github.com/users/BrandonHe/orgs","repos_url":"https://api.github.com/users/BrandonHe/repos","events_url":"https://api.github.com/users/BrandonHe/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonHe/received_events","type":"User","site_admin":false},"repo":{"id":43287100,"name":"sdl_core","full_name":"BrandonHe/sdl_core","owner":{"login":"BrandonHe","id":13449160,"avatar_url":"https://avatars.githubusercontent.com/u/13449160?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonHe","html_url":"https://github.com/BrandonHe","followers_url":"https://api.github.com/users/BrandonHe/followers","following_url":"https://api.github.com/users/BrandonHe/following{/other_user}","gists_url":"https://api.github.com/users/BrandonHe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonHe/subscriptions","organizations_url":"https://api.github.com/users/BrandonHe/orgs","repos_url":"https://api.github.com/users/BrandonHe/repos","events_url":"https://api.github.com/users/BrandonHe/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonHe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrandonHe/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/BrandonHe/sdl_core","forks_url":"https://api.github.com/repos/BrandonHe/sdl_core/forks","keys_url":"https://api.github.com/repos/BrandonHe/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrandonHe/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrandonHe/sdl_core/teams","hooks_url":"https://api.github.com/repos/BrandonHe/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/BrandonHe/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/BrandonHe/sdl_core/events","assignees_url":"https://api.github.com/repos/BrandonHe/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/BrandonHe/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/BrandonHe/sdl_core/tags","blobs_url":"https://api.github.com/repos/BrandonHe/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrandonHe/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrandonHe/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrandonHe/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrandonHe/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/BrandonHe/sdl_core/languages","stargazers_url":"https://api.github.com/repos/BrandonHe/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/BrandonHe/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/BrandonHe/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/BrandonHe/sdl_core/subscription","commits_url":"https://api.github.com/repos/BrandonHe/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrandonHe/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrandonHe/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrandonHe/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrandonHe/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/BrandonHe/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrandonHe/sdl_core/merges","archive_url":"https://api.github.com/repos/BrandonHe/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrandonHe/sdl_core/downloads","issues_url":"https://api.github.com/repos/BrandonHe/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/BrandonHe/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/BrandonHe/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/BrandonHe/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrandonHe/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/BrandonHe/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/BrandonHe/sdl_core/deployments","created_at":"2015-09-28T07:45:29Z","updated_at":"2016-03-07T09:15:07Z","pushed_at":"2016-07-06T03:00:00Z","git_url":"git://github.com/BrandonHe/sdl_core.git","ssh_url":"git@github.com:BrandonHe/sdl_core.git","clone_url":"https://github.com/BrandonHe/sdl_core.git","svn_url":"https://github.com/BrandonHe/sdl_core","homepage":"","size":56602,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"08be90e113d79af60d810d9f206f8e2f908c9e3b","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-07-21T11:12:22Z","pushed_at":"2016-08-01T14:51:59Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":309254,"stargazers_count":74,"watchers_count":74,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":91,"forks":90,"open_issues":91,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/660"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/660"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/660/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/660/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/461e69fc7510ed435e71a6aa0e00242a128221ff"}}}}
{"actor":{"display_login":"BrandonHe"}}