{"action":"created","issue":{"url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/issues/28","repository_url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto","labels_url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/issues/28/comments","events_url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/issues/28/events","html_url":"https://github.com/iosdevzone/IDZSwiftCommonCrypto/pull/28","id":162273058,"number":28,"title":"Disable GCC-style coverage instrumentation","user":{"login":"jakubvano","id":2094466,"avatar_url":"https://avatars.githubusercontent.com/u/2094466?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubvano","html_url":"https://github.com/jakubvano","followers_url":"https://api.github.com/users/jakubvano/followers","following_url":"https://api.github.com/users/jakubvano/following{/other_user}","gists_url":"https://api.github.com/users/jakubvano/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubvano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubvano/subscriptions","organizations_url":"https://api.github.com/users/jakubvano/orgs","repos_url":"https://api.github.com/users/jakubvano/repos","events_url":"https://api.github.com/users/jakubvano/events{/privacy}","received_events_url":"https://api.github.com/users/jakubvano/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"iosdevzone","id":3867014,"avatar_url":"https://avatars.githubusercontent.com/u/3867014?v=3","gravatar_id":"","url":"https://api.github.com/users/iosdevzone","html_url":"https://github.com/iosdevzone","followers_url":"https://api.github.com/users/iosdevzone/followers","following_url":"https://api.github.com/users/iosdevzone/following{/other_user}","gists_url":"https://api.github.com/users/iosdevzone/gists{/gist_id}","starred_url":"https://api.github.com/users/iosdevzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iosdevzone/subscriptions","organizations_url":"https://api.github.com/users/iosdevzone/orgs","repos_url":"https://api.github.com/users/iosdevzone/repos","events_url":"https://api.github.com/users/iosdevzone/events{/privacy}","received_events_url":"https://api.github.com/users/iosdevzone/received_events","type":"User","site_admin":false},"assignees":[{"login":"iosdevzone","id":3867014,"avatar_url":"https://avatars.githubusercontent.com/u/3867014?v=3","gravatar_id":"","url":"https://api.github.com/users/iosdevzone","html_url":"https://github.com/iosdevzone","followers_url":"https://api.github.com/users/iosdevzone/followers","following_url":"https://api.github.com/users/iosdevzone/following{/other_user}","gists_url":"https://api.github.com/users/iosdevzone/gists{/gist_id}","starred_url":"https://api.github.com/users/iosdevzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iosdevzone/subscriptions","organizations_url":"https://api.github.com/users/iosdevzone/orgs","repos_url":"https://api.github.com/users/iosdevzone/repos","events_url":"https://api.github.com/users/iosdevzone/events{/privacy}","received_events_url":"https://api.github.com/users/iosdevzone/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-06-25T09:37:20Z","updated_at":"2016-09-24T06:02:40Z","closed_at":"2016-09-24T06:02:40Z","pull_request":{"url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/pulls/28","html_url":"https://github.com/iosdevzone/IDZSwiftCommonCrypto/pull/28","diff_url":"https://github.com/iosdevzone/IDZSwiftCommonCrypto/pull/28.diff","patch_url":"https://github.com/iosdevzone/IDZSwiftCommonCrypto/pull/28.patch"},"body":"Our build of an app with `IDZSwiftCommonCrypto` integrated via carthage was rejected by appstore becasue of  \r\n\r\n>Invalid Bundle - Do not submit apps with GCC-style coverage instrumentation enabled. Specifically, the following Xcode build settings should be disabled: Instrument Program Flow Generate Test Coverage Files\r\n\r\nDisabling `GCC_GENERATE_TEST_COVERAGE_FILES` and `GCC_INSTRUMENT_PROGRAM_FLOW_ARCS` fixes that.\r\n\r\nAre these options somehow essential for `IDZSwiftCommonCrypto` or were they enabled due to  oversight?"},"comment":{"url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/issues/comments/249347699","html_url":"https://github.com/iosdevzone/IDZSwiftCommonCrypto/pull/28#issuecomment-249347699","issue_url":"https://api.github.com/repos/iosdevzone/IDZSwiftCommonCrypto/issues/28","id":249347699,"user":{"login":"iosdevzone","id":3867014,"avatar_url":"https://avatars.githubusercontent.com/u/3867014?v=3","gravatar_id":"","url":"https://api.github.com/users/iosdevzone","html_url":"https://github.com/iosdevzone","followers_url":"https://api.github.com/users/iosdevzone/followers","following_url":"https://api.github.com/users/iosdevzone/following{/other_user}","gists_url":"https://api.github.com/users/iosdevzone/gists{/gist_id}","starred_url":"https://api.github.com/users/iosdevzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iosdevzone/subscriptions","organizations_url":"https://api.github.com/users/iosdevzone/orgs","repos_url":"https://api.github.com/users/iosdevzone/repos","events_url":"https://api.github.com/users/iosdevzone/events{/privacy}","received_events_url":"https://api.github.com/users/iosdevzone/received_events","type":"User","site_admin":false},"created_at":"2016-09-24T06:02:40Z","updated_at":"2016-09-24T06:02:40Z","body":"I've just merged PR #35 and pushed out release 0.7.4. This release includes a slightly modified version of your proposed fix. In #35 coverage is turned off in `Release` builds but remains on in `Debug` builds. As long as you don't link with a debug build this problem should not occur again.\r\nThanks for your patience and sorry it took so long to get it merged into the master branch!"}}
{"actor":{"display_login":"iosdevzone"}}