{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/81411278","pull_request_review_id":2395817,"id":81411278,"diff_hunk":"@@ -87,6 +87,9 @@\n \tOFI_Q_READERR(prov, log, eq, \"eq\", fi_eq_readerr, \t\\\n \t\t\tfi_eq_strerror, ret, err_entry)\n \n+#define ofi_sin_addr(addr) (((struct sockaddr_in *)(addr))->sin_addr)\n+#define ofi_sin6_addr(addr) (((struct sockaddr_in6 *)(addr))->sin6_addr)","path":"include/fi_util.h","position":5,"original_position":5,"commit_id":"c4d4287c432e302ca1a25636c39ac2829092a3f3","original_commit_id":"c4d4287c432e302ca1a25636c39ac2829092a3f3","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"Okay - I completely missed where those were used.  If you want to include this patch in the other PR, that's fine too","created_at":"2016-09-30T20:22:39Z","updated_at":"2016-09-30T20:22:39Z","html_url":"https://github.com/ofiwg/libfabric/pull/2390#discussion_r81411278","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/81411278"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2390#discussion_r81411278"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390","id":86837649,"html_url":"https://github.com/ofiwg/libfabric/pull/2390","diff_url":"https://github.com/ofiwg/libfabric/pull/2390.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/2390.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2390","number":2390,"state":"open","locked":false,"title":"verbs: Bug fixes","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"body":"Contents:\r\n- [Util] Add macros for accessing fields in sockaddr_in* structs\r\n- Return all valid verbs interfaces on a system when user doesn't specify a node, or any addressing info and FI_SOURCE is passed.\r\n- Fix incorrect reporting cq_size.","created_at":"2016-09-26T23:27:04Z","updated_at":"2016-09-30T20:22:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee91e4765bcd9113799b9c218391efe35132aa32","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2390/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/c4d4287c432e302ca1a25636c39ac2829092a3f3","head":{"label":"a-ilango:dev","ref":"dev","sha":"c4d4287c432e302ca1a25636c39ac2829092a3f3","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"repo":{"id":24616163,"name":"libfabric","full_name":"a-ilango/libfabric","owner":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-ilango/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/a-ilango/libfabric","forks_url":"https://api.github.com/repos/a-ilango/libfabric/forks","keys_url":"https://api.github.com/repos/a-ilango/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-ilango/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-ilango/libfabric/teams","hooks_url":"https://api.github.com/repos/a-ilango/libfabric/hooks","issue_events_url":"https://api.github.com/repos/a-ilango/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/a-ilango/libfabric/events","assignees_url":"https://api.github.com/repos/a-ilango/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/a-ilango/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/a-ilango/libfabric/tags","blobs_url":"https://api.github.com/repos/a-ilango/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-ilango/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-ilango/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-ilango/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-ilango/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/a-ilango/libfabric/languages","stargazers_url":"https://api.github.com/repos/a-ilango/libfabric/stargazers","contributors_url":"https://api.github.com/repos/a-ilango/libfabric/contributors","subscribers_url":"https://api.github.com/repos/a-ilango/libfabric/subscribers","subscription_url":"https://api.github.com/repos/a-ilango/libfabric/subscription","commits_url":"https://api.github.com/repos/a-ilango/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-ilango/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-ilango/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-ilango/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-ilango/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/a-ilango/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-ilango/libfabric/merges","archive_url":"https://api.github.com/repos/a-ilango/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-ilango/libfabric/downloads","issues_url":"https://api.github.com/repos/a-ilango/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/a-ilango/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/a-ilango/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/a-ilango/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-ilango/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/a-ilango/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/a-ilango/libfabric/deployments","created_at":"2014-09-29T22:57:04Z","updated_at":"2016-02-23T18:28:22Z","pushed_at":"2016-09-29T22:10:08Z","git_url":"git://github.com/a-ilango/libfabric.git","ssh_url":"git@github.com:a-ilango/libfabric.git","clone_url":"https://github.com/a-ilango/libfabric.git","svn_url":"https://github.com/a-ilango/libfabric","homepage":null,"size":12079,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"d1517300c3bcbb8d06ce37e424484d944e8e55d1","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2016-09-20T18:35:39Z","pushed_at":"2016-09-30T19:13:12Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":14225,"stargazers_count":76,"watchers_count":76,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"open_issues_count":88,"forks":79,"open_issues":88,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2390"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2390"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2390/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2390/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/c4d4287c432e302ca1a25636c39ac2829092a3f3"}}}}
{"actor":{"display_login":"shefty"}}