{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/buck/issues/981","repository_url":"https://api.github.com/repos/facebook/buck","labels_url":"https://api.github.com/repos/facebook/buck/issues/981/labels{/name}","comments_url":"https://api.github.com/repos/facebook/buck/issues/981/comments","events_url":"https://api.github.com/repos/facebook/buck/issues/981/events","html_url":"https://github.com/facebook/buck/issues/981","id":186142223,"number":981,"title":"prebuilt_jar: gwt_jar attribute is undocumented and unused","user":{"login":"davido","id":347173,"avatar_url":"https://avatars.githubusercontent.com/u/347173?v=3","gravatar_id":"","url":"https://api.github.com/users/davido","html_url":"https://github.com/davido","followers_url":"https://api.github.com/users/davido/followers","following_url":"https://api.github.com/users/davido/following{/other_user}","gists_url":"https://api.github.com/users/davido/gists{/gist_id}","starred_url":"https://api.github.com/users/davido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davido/subscriptions","organizations_url":"https://api.github.com/users/davido/orgs","repos_url":"https://api.github.com/users/davido/repos","events_url":"https://api.github.com/users/davido/events{/privacy}","received_events_url":"https://api.github.com/users/davido/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-30T15:17:00Z","updated_at":"2016-10-31T13:29:32Z","closed_at":"2016-10-31T12:23:42Z","body":"Consider this rule:\n\n```\nprebuilt_jar(\n  name = '%s_gwtxml_lib' % gwt_name,\n  binary_jar = ':%s_gwtxml_gen' % gwt_name,\n  gwt_jar = ':%s_gwtxml_gen' % gwt_name,\n)\n```\n\nthe target description is:\n\n```\n$ buck targets --json //gerrit-gwtui:ui_safari_gwtxml_lib\n[\n{\n  \"binaryJar\" : \":ui_safari_gwtxml_gen\",\n  \"buck.base_path\" : \"gerrit-gwtui\",\n  \"buck.direct_dependencies\" : [ \"//gerrit-gwtui:ui_safari_gwtxml_gen\" ],\n  \"buck.type\" : \"prebuilt_jar\",\n  \"deps\" : [ ],\n  \"fully_qualified_name\" : \"//gerrit-gwtui:ui_safari_gwtxml_lib\",\n  \"gwtJar\" : \":ui_safari_gwtxml_gen\",\n  \"javadocUrl\" : null,\n  \"licenses\" : [ ],\n  \"mavenCoords\" : null,\n  \"name\" : \"ui_safari_gwtxml_lib\",\n  \"provided\" : null,\n  \"sourceJar\" : null,\n  \"visibility\" : [ ]\n}\n]\n```\n\nThe source code even has this suppress warning annotation:\n\n```\n@BuildsAnnotationProcessor\npublic class PrebuiltJar extends AbstractBuildRule\n    implements AndroidPackageable, ExportDependencies, HasClasspathEntries,\n    InitializableFromDisk<JavaLibrary.Data>, JavaLibrary, SupportsInputBasedRuleKey {\n\n  private static final BuildableProperties OUTPUT_TYPE = new BuildableProperties(LIBRARY);\n\n  @AddToRuleKey\n  private final SourcePath binaryJar;\n  private final SourcePath abiJar;\n  private final Path copiedBinaryJar;\n  @AddToRuleKey\n  private final Optional<SourcePath> sourceJar;\n  @SuppressWarnings(\"PMD.UnusedPrivateField\")\n  @AddToRuleKey\n  private final Optional<SourcePath> gwtJar;\n[...]\n```\n\nand can be removed?\n"},"comment":{"url":"https://api.github.com/repos/facebook/buck/issues/comments/257293521","html_url":"https://github.com/facebook/buck/issues/981#issuecomment-257293521","issue_url":"https://api.github.com/repos/facebook/buck/issues/981","id":257293521,"user":{"login":"davido","id":347173,"avatar_url":"https://avatars.githubusercontent.com/u/347173?v=3","gravatar_id":"","url":"https://api.github.com/users/davido","html_url":"https://github.com/davido","followers_url":"https://api.github.com/users/davido/followers","following_url":"https://api.github.com/users/davido/following{/other_user}","gists_url":"https://api.github.com/users/davido/gists{/gist_id}","starred_url":"https://api.github.com/users/davido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davido/subscriptions","organizations_url":"https://api.github.com/users/davido/orgs","repos_url":"https://api.github.com/users/davido/repos","events_url":"https://api.github.com/users/davido/events{/privacy}","received_events_url":"https://api.github.com/users/davido/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T13:29:32Z","updated_at":"2016-10-31T13:29:32Z","body":"Sorry missed it. The usage of `get_jar` was even documented in the original commit message:\r\n\r\n | This diff also introduces a `gwt_jar` argument to `prebuilt_jar`. This is useful for\r\n    defining Guava:\r\n\r\n```\r\n    prebuilt_jar(\r\n      name = 'guava',\r\n      binary_jar = 'guava-17.0.jar',\r\n      source_jar = 'guava-17.0-sources.jar',\r\n      gwt_jar = 'guava-gwt-17.0.jar',\r\n      visibility = [\r\n        'PUBLIC',\r\n      ],\r\n    )\r\n```"}}
{"actor":{"display_login":"davido"}}