{"action":"created","comment":{"url":"https://api.github.com/repos/google/citest/pulls/comments/66637973","id":66637973,"diff_hunk":"@@ -0,0 +1,56 @@\n+# Copyright 2016 Google Inc. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\n+\"\"\"Implementation of Netflix's Frigga naming convention\"\"\"\n+","path":"spinnaker/spinnaker_testing/frigga.py","position":17,"original_position":17,"commit_id":"5223587f354f162a4e557d68523d5243df6956b1","original_commit_id":"5223587f354f162a4e557d68523d5243df6956b1","user":{"login":"ewiseblatt","id":4367384,"avatar_url":"https://avatars.githubusercontent.com/u/4367384?v=3","gravatar_id":"","url":"https://api.github.com/users/ewiseblatt","html_url":"https://github.com/ewiseblatt","followers_url":"https://api.github.com/users/ewiseblatt/followers","following_url":"https://api.github.com/users/ewiseblatt/following{/other_user}","gists_url":"https://api.github.com/users/ewiseblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ewiseblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewiseblatt/subscriptions","organizations_url":"https://api.github.com/users/ewiseblatt/orgs","repos_url":"https://api.github.com/users/ewiseblatt/repos","events_url":"https://api.github.com/users/ewiseblatt/events{/privacy}","received_events_url":"https://api.github.com/users/ewiseblatt/received_events","type":"User","site_admin":false},"body":"Why have these as classes rather than functions that produce the names? You dont use the instances at all. You only stringify them.","created_at":"2016-06-10T15:58:35Z","updated_at":"2016-06-10T15:58:35Z","html_url":"https://github.com/google/citest/pull/163#discussion_r66637973","pull_request_url":"https://api.github.com/repos/google/citest/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/google/citest/pulls/comments/66637973"},"html":{"href":"https://github.com/google/citest/pull/163#discussion_r66637973"},"pull_request":{"href":"https://api.github.com/repos/google/citest/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/google/citest/pulls/163","id":73285950,"html_url":"https://github.com/google/citest/pull/163","diff_url":"https://github.com/google/citest/pull/163.diff","patch_url":"https://github.com/google/citest/pull/163.patch","issue_url":"https://api.github.com/repos/google/citest/issues/163","number":163,"state":"open","locked":false,"title":"Kubernetes find image test","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"@ewiseblatt PTAL","created_at":"2016-06-09T21:06:42Z","updated_at":"2016-06-10T15:58:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d46f2f4912d34b9858a2fd988735922a6188ae5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/citest/pulls/163/commits","review_comments_url":"https://api.github.com/repos/google/citest/pulls/163/comments","review_comment_url":"https://api.github.com/repos/google/citest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/citest/issues/163/comments","statuses_url":"https://api.github.com/repos/google/citest/statuses/5223587f354f162a4e557d68523d5243df6956b1","head":{"label":"lwander:kubernetes-find-image-test","ref":"kubernetes-find-image-test","sha":"5223587f354f162a4e557d68523d5243df6956b1","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"repo":{"id":60632949,"name":"citest","full_name":"lwander/citest","owner":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lwander/citest","description":null,"fork":true,"url":"https://api.github.com/repos/lwander/citest","forks_url":"https://api.github.com/repos/lwander/citest/forks","keys_url":"https://api.github.com/repos/lwander/citest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lwander/citest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lwander/citest/teams","hooks_url":"https://api.github.com/repos/lwander/citest/hooks","issue_events_url":"https://api.github.com/repos/lwander/citest/issues/events{/number}","events_url":"https://api.github.com/repos/lwander/citest/events","assignees_url":"https://api.github.com/repos/lwander/citest/assignees{/user}","branches_url":"https://api.github.com/repos/lwander/citest/branches{/branch}","tags_url":"https://api.github.com/repos/lwander/citest/tags","blobs_url":"https://api.github.com/repos/lwander/citest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lwander/citest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lwander/citest/git/refs{/sha}","trees_url":"https://api.github.com/repos/lwander/citest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lwander/citest/statuses/{sha}","languages_url":"https://api.github.com/repos/lwander/citest/languages","stargazers_url":"https://api.github.com/repos/lwander/citest/stargazers","contributors_url":"https://api.github.com/repos/lwander/citest/contributors","subscribers_url":"https://api.github.com/repos/lwander/citest/subscribers","subscription_url":"https://api.github.com/repos/lwander/citest/subscription","commits_url":"https://api.github.com/repos/lwander/citest/commits{/sha}","git_commits_url":"https://api.github.com/repos/lwander/citest/git/commits{/sha}","comments_url":"https://api.github.com/repos/lwander/citest/comments{/number}","issue_comment_url":"https://api.github.com/repos/lwander/citest/issues/comments{/number}","contents_url":"https://api.github.com/repos/lwander/citest/contents/{+path}","compare_url":"https://api.github.com/repos/lwander/citest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lwander/citest/merges","archive_url":"https://api.github.com/repos/lwander/citest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lwander/citest/downloads","issues_url":"https://api.github.com/repos/lwander/citest/issues{/number}","pulls_url":"https://api.github.com/repos/lwander/citest/pulls{/number}","milestones_url":"https://api.github.com/repos/lwander/citest/milestones{/number}","notifications_url":"https://api.github.com/repos/lwander/citest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lwander/citest/labels{/name}","releases_url":"https://api.github.com/repos/lwander/citest/releases{/id}","deployments_url":"https://api.github.com/repos/lwander/citest/deployments","created_at":"2016-06-07T17:29:22Z","updated_at":"2016-06-07T17:29:23Z","pushed_at":"2016-06-10T15:21:48Z","git_url":"git://github.com/lwander/citest.git","ssh_url":"git@github.com:lwander/citest.git","clone_url":"https://github.com/lwander/citest.git","svn_url":"https://github.com/lwander/citest","homepage":null,"size":719,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"bcac9840dfd1d8232ff6c6421011afa78c01f478","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":40497615,"name":"citest","full_name":"google/citest","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/citest","description":null,"fork":false,"url":"https://api.github.com/repos/google/citest","forks_url":"https://api.github.com/repos/google/citest/forks","keys_url":"https://api.github.com/repos/google/citest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/citest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/citest/teams","hooks_url":"https://api.github.com/repos/google/citest/hooks","issue_events_url":"https://api.github.com/repos/google/citest/issues/events{/number}","events_url":"https://api.github.com/repos/google/citest/events","assignees_url":"https://api.github.com/repos/google/citest/assignees{/user}","branches_url":"https://api.github.com/repos/google/citest/branches{/branch}","tags_url":"https://api.github.com/repos/google/citest/tags","blobs_url":"https://api.github.com/repos/google/citest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/citest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/citest/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/citest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/citest/statuses/{sha}","languages_url":"https://api.github.com/repos/google/citest/languages","stargazers_url":"https://api.github.com/repos/google/citest/stargazers","contributors_url":"https://api.github.com/repos/google/citest/contributors","subscribers_url":"https://api.github.com/repos/google/citest/subscribers","subscription_url":"https://api.github.com/repos/google/citest/subscription","commits_url":"https://api.github.com/repos/google/citest/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/citest/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/citest/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/citest/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/citest/contents/{+path}","compare_url":"https://api.github.com/repos/google/citest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/citest/merges","archive_url":"https://api.github.com/repos/google/citest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/citest/downloads","issues_url":"https://api.github.com/repos/google/citest/issues{/number}","pulls_url":"https://api.github.com/repos/google/citest/pulls{/number}","milestones_url":"https://api.github.com/repos/google/citest/milestones{/number}","notifications_url":"https://api.github.com/repos/google/citest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/citest/labels{/name}","releases_url":"https://api.github.com/repos/google/citest/releases{/id}","deployments_url":"https://api.github.com/repos/google/citest/deployments","created_at":"2015-08-10T18:04:21Z","updated_at":"2016-06-01T17:46:39Z","pushed_at":"2016-06-10T15:21:48Z","git_url":"git://github.com/google/citest.git","ssh_url":"git@github.com:google/citest.git","clone_url":"https://github.com/google/citest.git","svn_url":"https://github.com/google/citest","homepage":null,"size":734,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/citest/pulls/163"},"html":{"href":"https://github.com/google/citest/pull/163"},"issue":{"href":"https://api.github.com/repos/google/citest/issues/163"},"comments":{"href":"https://api.github.com/repos/google/citest/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/google/citest/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/google/citest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/citest/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/google/citest/statuses/5223587f354f162a4e557d68523d5243df6956b1"}}}}
{"actor":{"display_login":"ewiseblatt"}}