{"action":"created","issue":{"url":"https://api.github.com/repos/18F/micropurchase/issues/122","repository_url":"https://api.github.com/repos/18F/micropurchase","labels_url":"https://api.github.com/repos/18F/micropurchase/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/18F/micropurchase/issues/122/comments","events_url":"https://api.github.com/repos/18F/micropurchase/issues/122/events","html_url":"https://github.com/18F/micropurchase/issues/122","id":122164061,"number":122,"title":"Add hound or other style-checking CI?","user":{"login":"harrisj","id":2044,"avatar_url":"https://avatars.githubusercontent.com/u/2044?v=3","gravatar_id":"","url":"https://api.github.com/users/harrisj","html_url":"https://github.com/harrisj","followers_url":"https://api.github.com/users/harrisj/followers","following_url":"https://api.github.com/users/harrisj/following{/other_user}","gists_url":"https://api.github.com/users/harrisj/gists{/gist_id}","starred_url":"https://api.github.com/users/harrisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrisj/subscriptions","organizations_url":"https://api.github.com/users/harrisj/orgs","repos_url":"https://api.github.com/users/harrisj/repos","events_url":"https://api.github.com/users/harrisj/events{/privacy}","received_events_url":"https://api.github.com/users/harrisj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-15T00:27:50Z","updated_at":"2016-02-23T01:36:47Z","closed_at":null,"body":"I wanted to see if we felt comfortable adding [Rubocop](https://github.com/bbatsov/rubocop)-based style checking to this project. I've found it very useful, especially since I have a linter in my editor that reports on style violations. There are several options we could consider:\r\n\r\n- Use a service like [Hound](https://houndci.com/) which is a CI for code style-checking that will comment on individual style violations in any github PR/branch (this can lead to a bunch of emails, so it's sometimes really annoying)\r\n- Modify the rake task that is run by Travis to also run Rubocop and fail if it finds any style violations. This means far less emails/comments, but it sometimes means encapsulating sections of code with directives for Rubocop to ignore that part which isn't particularly elegant.\r\n- Leave the style compliance optional for now. Maybe add a rake task for running rubocop and a rubocop.yml config for specific issues, but don't mandate compliance.\r\n\r\nNote that the default rubocop.yml often has some settings we might want to tweak (those on maximum line length or method length or such). We should see if another project has a preferred one we can use already if we decide to do this."},"comment":{"url":"https://api.github.com/repos/18F/micropurchase/issues/comments/187466640","html_url":"https://github.com/18F/micropurchase/issues/122#issuecomment-187466640","issue_url":"https://api.github.com/repos/18F/micropurchase/issues/122","id":187466640,"user":{"login":"allalala","id":6518236,"avatar_url":"https://avatars.githubusercontent.com/u/6518236?v=3","gravatar_id":"","url":"https://api.github.com/users/allalala","html_url":"https://github.com/allalala","followers_url":"https://api.github.com/users/allalala/followers","following_url":"https://api.github.com/users/allalala/following{/other_user}","gists_url":"https://api.github.com/users/allalala/gists{/gist_id}","starred_url":"https://api.github.com/users/allalala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allalala/subscriptions","organizations_url":"https://api.github.com/users/allalala/orgs","repos_url":"https://api.github.com/users/allalala/repos","events_url":"https://api.github.com/users/allalala/events{/privacy}","received_events_url":"https://api.github.com/users/allalala/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T01:36:47Z","updated_at":"2016-02-23T01:36:47Z","body":"@harrisj this is OK to close, correct?"}}