{"action":"created","comment":{"url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/comments/77829697","id":77829697,"diff_hunk":"@@ -111,21 +111,24 @@ var Admin = (function(Promise) {\n    * @kind control element consturctor function\n    */\n   registerControl('editorWindow', function(self) {\n-    return self.createDomElement('textarea', {cols:100, rows:20, id: 'editor'});\n+    return self.createDomElement('textarea', {cols:100, rows:20, id: 'editor'});  // ezt a self patternt hol lattad?","path":"client/admin.js","position":23,"original_position":23,"commit_id":"703f252d8fec50332669ec8c3d9202d4a5b48ecf","original_commit_id":"731088295539b0ad0606ae785dfab8fc1bab58cb","user":{"login":"samson84","id":21317298,"avatar_url":"https://avatars.githubusercontent.com/u/21317298?v=3","gravatar_id":"","url":"https://api.github.com/users/samson84","html_url":"https://github.com/samson84","followers_url":"https://api.github.com/users/samson84/followers","following_url":"https://api.github.com/users/samson84/following{/other_user}","gists_url":"https://api.github.com/users/samson84/gists{/gist_id}","starred_url":"https://api.github.com/users/samson84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samson84/subscriptions","organizations_url":"https://api.github.com/users/samson84/orgs","repos_url":"https://api.github.com/users/samson84/repos","events_url":"https://api.github.com/users/samson84/events{/privacy}","received_events_url":"https://api.github.com/users/samson84/received_events","type":"User","site_admin":false},"body":"http://eloquentjavascript.net/07_elife.html#h_EoVtgPzygv\r\nAzért választottam ezt a patternt, mert jellemzően az eseménykezelőknél szükségem lesz az Admin panel belső objektumára, hogy elérjem a többi control elementet. De való igaz, itt még átgondolom kicsit a scope-t. De kipróbálom a call-al meg a bind-al is.","created_at":"2016-09-07T14:14:14Z","updated_at":"2016-09-07T14:14:14Z","html_url":"https://github.com/samson84/eloquent_javascript_admin_js/pull/1#discussion_r77829697","pull_request_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/comments/77829697"},"html":{"href":"https://github.com/samson84/eloquent_javascript_admin_js/pull/1#discussion_r77829697"},"pull_request":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1","id":84011060,"html_url":"https://github.com/samson84/eloquent_javascript_admin_js/pull/1","diff_url":"https://github.com/samson84/eloquent_javascript_admin_js/pull/1.diff","patch_url":"https://github.com/samson84/eloquent_javascript_admin_js/pull/1.patch","issue_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/issues/1","number":1,"state":"open","locked":false,"title":"Code review round 1","user":{"login":"symunona","id":5897104,"avatar_url":"https://avatars.githubusercontent.com/u/5897104?v=3","gravatar_id":"","url":"https://api.github.com/users/symunona","html_url":"https://github.com/symunona","followers_url":"https://api.github.com/users/symunona/followers","following_url":"https://api.github.com/users/symunona/following{/other_user}","gists_url":"https://api.github.com/users/symunona/gists{/gist_id}","starred_url":"https://api.github.com/users/symunona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symunona/subscriptions","organizations_url":"https://api.github.com/users/symunona/orgs","repos_url":"https://api.github.com/users/symunona/repos","events_url":"https://api.github.com/users/symunona/events{/privacy}","received_events_url":"https://api.github.com/users/symunona/received_events","type":"User","site_admin":false},"body":".gitignore - be van commitolva a node_modules!!! (ezt hívták anno halálfejes hibának :) )\r\nAmikor létrehozol egy repót, asszem be tudod állítani, hogy milyen projektre csináljon neked default gitignore-t, az egy igen hasznos fícsör. \r\n\r\nSelf pattern? - ezt hol láttad? Nagyon fura. \r\n\r\nPrototype? Miért így használod? Láttál rá valami példát, hogy miért jó így? (én még életemben talán kétszer használtam valami nagyon advanced esetben) \r\n\r\naddDomElement: miért nem inkább template engine? Ez olyan jsx-es hangulatúvá teszi.\r\n\r\ndev környezet - mit használsz? Van benne jshint? Az  MS Code pl tud ilyet, van hozzá jó kis plugin. (szerintem ez a legjobb lightweight editor windózra, sokkal jobb mint a np++, nekem a limeot és az atomot is veri)\r\n\r\nobject: Object.create(null) - sose láttam még, mi az előnye a {}-hez képest? \r\n\r\nNekem az admin.html nem jön be, így ki sem tudtam próbálni.\r\n\r\nhttp static-ot próbáltad? Lehet egyszerűbben ki tudod szolgálni a fájlokat. Csak hozzá kell még csapni a sima http-t\r\n\r\nNyelv:\r\n\r\nNagyon sokszor kevered angolul az egyes szám harmadik személy \"s\"-t a többesszámnál nem kell s.\r\n\r\nUgyanitt is able to egy viszonylag ritkán használt kifejezés a can-hez képest. Ha nem tudod, épp melyik, akkor inkább a can. \r\n\r\n","created_at":"2016-09-05T14:34:35Z","updated_at":"2016-09-07T14:14:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c2f5db9be870cc7fd4b3bae3de01b3877fc1776","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1/commits","review_comments_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1/comments","review_comment_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/issues/1/comments","statuses_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/statuses/703f252d8fec50332669ec8c3d9202d4a5b48ecf","head":{"label":"symunona:master","ref":"master","sha":"703f252d8fec50332669ec8c3d9202d4a5b48ecf","user":{"login":"symunona","id":5897104,"avatar_url":"https://avatars.githubusercontent.com/u/5897104?v=3","gravatar_id":"","url":"https://api.github.com/users/symunona","html_url":"https://github.com/symunona","followers_url":"https://api.github.com/users/symunona/followers","following_url":"https://api.github.com/users/symunona/following{/other_user}","gists_url":"https://api.github.com/users/symunona/gists{/gist_id}","starred_url":"https://api.github.com/users/symunona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symunona/subscriptions","organizations_url":"https://api.github.com/users/symunona/orgs","repos_url":"https://api.github.com/users/symunona/repos","events_url":"https://api.github.com/users/symunona/events{/privacy}","received_events_url":"https://api.github.com/users/symunona/received_events","type":"User","site_admin":false},"repo":{"id":67420333,"name":"eloquent_javascript_admin_js","full_name":"symunona/eloquent_javascript_admin_js","owner":{"login":"symunona","id":5897104,"avatar_url":"https://avatars.githubusercontent.com/u/5897104?v=3","gravatar_id":"","url":"https://api.github.com/users/symunona","html_url":"https://github.com/symunona","followers_url":"https://api.github.com/users/symunona/followers","following_url":"https://api.github.com/users/symunona/following{/other_user}","gists_url":"https://api.github.com/users/symunona/gists{/gist_id}","starred_url":"https://api.github.com/users/symunona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symunona/subscriptions","organizations_url":"https://api.github.com/users/symunona/orgs","repos_url":"https://api.github.com/users/symunona/repos","events_url":"https://api.github.com/users/symunona/events{/privacy}","received_events_url":"https://api.github.com/users/symunona/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/symunona/eloquent_javascript_admin_js","description":null,"fork":true,"url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js","forks_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/forks","keys_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/teams","hooks_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/hooks","issue_events_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/issues/events{/number}","events_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/events","assignees_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/assignees{/user}","branches_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/branches{/branch}","tags_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/tags","blobs_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/git/refs{/sha}","trees_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/statuses/{sha}","languages_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/languages","stargazers_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/stargazers","contributors_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/contributors","subscribers_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/subscribers","subscription_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/subscription","commits_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/commits{/sha}","git_commits_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/git/commits{/sha}","comments_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/comments{/number}","issue_comment_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/issues/comments{/number}","contents_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/contents/{+path}","compare_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/merges","archive_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/downloads","issues_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/issues{/number}","pulls_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/pulls{/number}","milestones_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/milestones{/number}","notifications_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/labels{/name}","releases_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/releases{/id}","deployments_url":"https://api.github.com/repos/symunona/eloquent_javascript_admin_js/deployments","created_at":"2016-09-05T12:48:13Z","updated_at":"2016-09-05T12:48:14Z","pushed_at":"2016-09-05T14:29:10Z","git_url":"git://github.com/symunona/eloquent_javascript_admin_js.git","ssh_url":"git@github.com:symunona/eloquent_javascript_admin_js.git","clone_url":"https://github.com/symunona/eloquent_javascript_admin_js.git","svn_url":"https://github.com/symunona/eloquent_javascript_admin_js","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samson84:master","ref":"master","sha":"d091b60318414e910d11d20cb64716bb4f79b76c","user":{"login":"samson84","id":21317298,"avatar_url":"https://avatars.githubusercontent.com/u/21317298?v=3","gravatar_id":"","url":"https://api.github.com/users/samson84","html_url":"https://github.com/samson84","followers_url":"https://api.github.com/users/samson84/followers","following_url":"https://api.github.com/users/samson84/following{/other_user}","gists_url":"https://api.github.com/users/samson84/gists{/gist_id}","starred_url":"https://api.github.com/users/samson84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samson84/subscriptions","organizations_url":"https://api.github.com/users/samson84/orgs","repos_url":"https://api.github.com/users/samson84/repos","events_url":"https://api.github.com/users/samson84/events{/privacy}","received_events_url":"https://api.github.com/users/samson84/received_events","type":"User","site_admin":false},"repo":{"id":66880095,"name":"eloquent_javascript_admin_js","full_name":"samson84/eloquent_javascript_admin_js","owner":{"login":"samson84","id":21317298,"avatar_url":"https://avatars.githubusercontent.com/u/21317298?v=3","gravatar_id":"","url":"https://api.github.com/users/samson84","html_url":"https://github.com/samson84","followers_url":"https://api.github.com/users/samson84/followers","following_url":"https://api.github.com/users/samson84/following{/other_user}","gists_url":"https://api.github.com/users/samson84/gists{/gist_id}","starred_url":"https://api.github.com/users/samson84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samson84/subscriptions","organizations_url":"https://api.github.com/users/samson84/orgs","repos_url":"https://api.github.com/users/samson84/repos","events_url":"https://api.github.com/users/samson84/events{/privacy}","received_events_url":"https://api.github.com/users/samson84/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samson84/eloquent_javascript_admin_js","description":"Small learning project for the book Eloquent Javascript","fork":false,"url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js","forks_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/forks","keys_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/teams","hooks_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/hooks","issue_events_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/issues/events{/number}","events_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/events","assignees_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/assignees{/user}","branches_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/branches{/branch}","tags_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/tags","blobs_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/git/refs{/sha}","trees_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/statuses/{sha}","languages_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/languages","stargazers_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/stargazers","contributors_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/contributors","subscribers_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/subscribers","subscription_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/subscription","commits_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/commits{/sha}","git_commits_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/git/commits{/sha}","comments_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/comments{/number}","issue_comment_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/issues/comments{/number}","contents_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/contents/{+path}","compare_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/merges","archive_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/downloads","issues_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/issues{/number}","pulls_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls{/number}","milestones_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/milestones{/number}","notifications_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/labels{/name}","releases_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/releases{/id}","deployments_url":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/deployments","created_at":"2016-08-29T20:58:35Z","updated_at":"2016-09-07T13:33:31Z","pushed_at":"2016-09-05T14:34:35Z","git_url":"git://github.com/samson84/eloquent_javascript_admin_js.git","ssh_url":"git@github.com:samson84/eloquent_javascript_admin_js.git","clone_url":"https://github.com/samson84/eloquent_javascript_admin_js.git","svn_url":"https://github.com/samson84/eloquent_javascript_admin_js","homepage":"","size":29,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1"},"html":{"href":"https://github.com/samson84/eloquent_javascript_admin_js/pull/1"},"issue":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/issues/1"},"comments":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/samson84/eloquent_javascript_admin_js/statuses/703f252d8fec50332669ec8c3d9202d4a5b48ecf"}}}}
{"actor":{"display_login":"samson84"}}