{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/77093117","id":77093117,"diff_hunk":"@@ -2460,7 +2460,7 @@ protected internal override Expression VisitLambda<T>(Expression<T> node)\n                 {\n                     return node;\n                 }\n-                return node.Update(b, node.Parameters);\n+                return Expression.Lambda<T>(b, node.Name, node.TailCall, node.Parameters);","path":"src/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/TypeOperations.cs","position":5,"original_position":5,"commit_id":"3054153f8a0ae7a20a0395ef56c117a42e03abcb","original_commit_id":"3054153f8a0ae7a20a0395ef56c117a42e03abcb","user":{"login":"bartdesmet","id":7324746,"avatar_url":"https://avatars.githubusercontent.com/u/7324746?v=3","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"body":"Same as `ExpressionQuoter` used by the compiler; we know the `Body` changed, so `Update` will call the factory anyway. I'm wondering whether there was any particular reason for this change here when the code was cloned? Any restrictions with .NET Native / AOT we're aware of? I can also converge both copies of the code by calling `Update` in both places; it'd be no big deal.","created_at":"2016-08-31T23:39:31Z","updated_at":"2016-08-31T23:39:31Z","html_url":"https://github.com/dotnet/corefx/pull/11314#discussion_r77093117","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/11314","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/77093117"},"html":{"href":"https://github.com/dotnet/corefx/pull/11314#discussion_r77093117"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11314"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/11314","id":83548006,"html_url":"https://github.com/dotnet/corefx/pull/11314","diff_url":"https://github.com/dotnet/corefx/pull/11314.diff","patch_url":"https://github.com/dotnet/corefx/pull/11314.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/11314","number":11314,"state":"open","locked":false,"title":"Reducing code duplication in ExpressionQuoter and converging the copies.","user":{"login":"bartdesmet","id":7324746,"avatar_url":"https://avatars.githubusercontent.com/u/7324746?v=3","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"body":"This contributes to #11097 by sharing `RuntimeVariables` and `MergedRuntimeVariables` types across interpreter and compiler. In addition, I'm simplifying some of the logic in the quoter used by the interpreter such that it converges with the one used by the compiler. In a separate step, I can work on sharing the common pieces through some base class (see comments in the PR).","created_at":"2016-08-31T23:37:13Z","updated_at":"2016-08-31T23:39:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b40c05a4d607fc654887e6f06f947e02361d475b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/11314/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/11314/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/11314/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/3054153f8a0ae7a20a0395ef56c117a42e03abcb","head":{"label":"bartdesmet:Issue-11097-Quoter","ref":"Issue-11097-Quoter","sha":"3054153f8a0ae7a20a0395ef56c117a42e03abcb","user":{"login":"bartdesmet","id":7324746,"avatar_url":"https://avatars.githubusercontent.com/u/7324746?v=3","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"repo":{"id":42419903,"name":"corefx","full_name":"bartdesmet/corefx","owner":{"login":"bartdesmet","id":7324746,"avatar_url":"https://avatars.githubusercontent.com/u/7324746?v=3","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartdesmet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/bartdesmet/corefx","forks_url":"https://api.github.com/repos/bartdesmet/corefx/forks","keys_url":"https://api.github.com/repos/bartdesmet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartdesmet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartdesmet/corefx/teams","hooks_url":"https://api.github.com/repos/bartdesmet/corefx/hooks","issue_events_url":"https://api.github.com/repos/bartdesmet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/bartdesmet/corefx/events","assignees_url":"https://api.github.com/repos/bartdesmet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/bartdesmet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/bartdesmet/corefx/tags","blobs_url":"https://api.github.com/repos/bartdesmet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartdesmet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartdesmet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartdesmet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartdesmet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/bartdesmet/corefx/languages","stargazers_url":"https://api.github.com/repos/bartdesmet/corefx/stargazers","contributors_url":"https://api.github.com/repos/bartdesmet/corefx/contributors","subscribers_url":"https://api.github.com/repos/bartdesmet/corefx/subscribers","subscription_url":"https://api.github.com/repos/bartdesmet/corefx/subscription","commits_url":"https://api.github.com/repos/bartdesmet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartdesmet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartdesmet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartdesmet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartdesmet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/bartdesmet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartdesmet/corefx/merges","archive_url":"https://api.github.com/repos/bartdesmet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartdesmet/corefx/downloads","issues_url":"https://api.github.com/repos/bartdesmet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/bartdesmet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/bartdesmet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/bartdesmet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartdesmet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/bartdesmet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/bartdesmet/corefx/deployments","created_at":"2015-09-14T01:23:19Z","updated_at":"2016-07-30T23:55:33Z","pushed_at":"2016-08-31T23:33:41Z","git_url":"git://github.com/bartdesmet/corefx.git","ssh_url":"git@github.com:bartdesmet/corefx.git","clone_url":"https://github.com/bartdesmet/corefx.git","svn_url":"https://github.com/bartdesmet/corefx","homepage":"http://dotnet.github.io/core/","size":84795,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a49ccdf80fb2a38ec748a526f60abc796b50045d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-08-31T23:18:09Z","pushed_at":"2016-08-31T23:37:13Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":133758,"stargazers_count":10465,"watchers_count":10465,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2582,"mirror_url":null,"open_issues_count":1437,"forks":2582,"open_issues":1437,"watchers":10465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11314"},"html":{"href":"https://github.com/dotnet/corefx/pull/11314"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11314"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11314/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11314/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11314/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/3054153f8a0ae7a20a0395ef56c117a42e03abcb"}}}}
{"actor":{"display_login":"bartdesmet"}}