{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments/77349716","id":77349716,"diff_hunk":"@@ -19,7 +19,7 @@\n # Red Hat Author(s): David Lehman <dlehman@redhat.com>\n #\n \n-from .lib import device_path_to_name, device_name_to_disk_by_path, ParentList\n+from .lib import device_path_to_name, device_name_to_disk_by_path, ParentList, Tags","path":"blivet/devices/__init__.py","position":5,"original_position":5,"commit_id":"4e3e91f429b0ad76e4b1129e814b2a19274f60f3","original_commit_id":"4e3e91f429b0ad76e4b1129e814b2a19274f60f3","user":{"login":"dwlehman","id":6605451,"avatar_url":"https://avatars.githubusercontent.com/u/6605451?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlehman","html_url":"https://github.com/dwlehman","followers_url":"https://api.github.com/users/dwlehman/followers","following_url":"https://api.github.com/users/dwlehman/following{/other_user}","gists_url":"https://api.github.com/users/dwlehman/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlehman/subscriptions","organizations_url":"https://api.github.com/users/dwlehman/orgs","repos_url":"https://api.github.com/users/dwlehman/repos","events_url":"https://api.github.com/users/dwlehman/events{/privacy}","received_events_url":"https://api.github.com/users/dwlehman/received_events","type":"User","site_admin":false},"body":"I'll remove it. I think I initially expected that it would be useful to have them importable from `devices`, but I can't remember why.","created_at":"2016-09-02T13:55:34Z","updated_at":"2016-09-02T13:55:34Z","html_url":"https://github.com/rhinstaller/blivet/pull/485#discussion_r77349716","pull_request_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/485","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments/77349716"},"html":{"href":"https://github.com/rhinstaller/blivet/pull/485#discussion_r77349716"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/485"}}},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/blivet/pulls/485","id":80311371,"html_url":"https://github.com/rhinstaller/blivet/pull/485","diff_url":"https://github.com/rhinstaller/blivet/pull/485.diff","patch_url":"https://github.com/rhinstaller/blivet/pull/485.patch","issue_url":"https://api.github.com/repos/rhinstaller/blivet/issues/485","number":485,"state":"open","locked":false,"title":"Device tags","user":{"login":"dwlehman","id":6605451,"avatar_url":"https://avatars.githubusercontent.com/u/6605451?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlehman","html_url":"https://github.com/dwlehman","followers_url":"https://api.github.com/users/dwlehman/followers","following_url":"https://api.github.com/users/dwlehman/following{/other_user}","gists_url":"https://api.github.com/users/dwlehman/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlehman/subscriptions","organizations_url":"https://api.github.com/users/dwlehman/orgs","repos_url":"https://api.github.com/users/dwlehman/repos","events_url":"https://api.github.com/users/dwlehman/events{/privacy}","received_events_url":"https://api.github.com/users/dwlehman/received_events","type":"User","site_admin":false},"body":"_I'm trying to sort out what the set of tags should be, so:\r\n1. the set of tags is still in flux\r\n2. the code doesn't currently match what I've written below_\r\n\r\n\r\nAdd a read/write property to `Device` containing a `set` of string tags. The primary use-case is disk selection, where users want to control which disks are used for various purposes. Ultimately, this could be exposed through `pykickstart` to add more powerful disk selection. The initial set of tags, which will be set automatically in the `Device` classes, is:\r\n\r\n- local\r\n    - rotational\r\n    - removable\r\n- remote\r\n    - multipath\r\n\r\nI had initially included basic device type tags, eg: `lvm`, `iscsi`, but I don't really see a use-case for them. Does anyone have use-cases in mind?\r\n\r\nI am undecided on several questions:\r\n1. should every tag have an inverse? (eg: local/remote, ssd/rotational)\r\n2. what about `raid`? (I don't know if we can even reliably determine this aside from easy cases like dmraid)","created_at":"2016-08-05T21:42:26Z","updated_at":"2016-09-02T13:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b758b1092e61ab9ba79d1d2964f88763bdde855f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/485/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/485/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/blivet/issues/485/comments","statuses_url":"https://api.github.com/repos/rhinstaller/blivet/statuses/4e3e91f429b0ad76e4b1129e814b2a19274f60f3","head":{"label":"dwlehman:device-tags","ref":"device-tags","sha":"4e3e91f429b0ad76e4b1129e814b2a19274f60f3","user":{"login":"dwlehman","id":6605451,"avatar_url":"https://avatars.githubusercontent.com/u/6605451?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlehman","html_url":"https://github.com/dwlehman","followers_url":"https://api.github.com/users/dwlehman/followers","following_url":"https://api.github.com/users/dwlehman/following{/other_user}","gists_url":"https://api.github.com/users/dwlehman/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlehman/subscriptions","organizations_url":"https://api.github.com/users/dwlehman/orgs","repos_url":"https://api.github.com/users/dwlehman/repos","events_url":"https://api.github.com/users/dwlehman/events{/privacy}","received_events_url":"https://api.github.com/users/dwlehman/received_events","type":"User","site_admin":false},"repo":{"id":31965131,"name":"blivet","full_name":"dwlehman/blivet","owner":{"login":"dwlehman","id":6605451,"avatar_url":"https://avatars.githubusercontent.com/u/6605451?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlehman","html_url":"https://github.com/dwlehman","followers_url":"https://api.github.com/users/dwlehman/followers","following_url":"https://api.github.com/users/dwlehman/following{/other_user}","gists_url":"https://api.github.com/users/dwlehman/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlehman/subscriptions","organizations_url":"https://api.github.com/users/dwlehman/orgs","repos_url":"https://api.github.com/users/dwlehman/repos","events_url":"https://api.github.com/users/dwlehman/events{/privacy}","received_events_url":"https://api.github.com/users/dwlehman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwlehman/blivet","description":"A python module for configuration of block devices","fork":true,"url":"https://api.github.com/repos/dwlehman/blivet","forks_url":"https://api.github.com/repos/dwlehman/blivet/forks","keys_url":"https://api.github.com/repos/dwlehman/blivet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwlehman/blivet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwlehman/blivet/teams","hooks_url":"https://api.github.com/repos/dwlehman/blivet/hooks","issue_events_url":"https://api.github.com/repos/dwlehman/blivet/issues/events{/number}","events_url":"https://api.github.com/repos/dwlehman/blivet/events","assignees_url":"https://api.github.com/repos/dwlehman/blivet/assignees{/user}","branches_url":"https://api.github.com/repos/dwlehman/blivet/branches{/branch}","tags_url":"https://api.github.com/repos/dwlehman/blivet/tags","blobs_url":"https://api.github.com/repos/dwlehman/blivet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwlehman/blivet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwlehman/blivet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwlehman/blivet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwlehman/blivet/statuses/{sha}","languages_url":"https://api.github.com/repos/dwlehman/blivet/languages","stargazers_url":"https://api.github.com/repos/dwlehman/blivet/stargazers","contributors_url":"https://api.github.com/repos/dwlehman/blivet/contributors","subscribers_url":"https://api.github.com/repos/dwlehman/blivet/subscribers","subscription_url":"https://api.github.com/repos/dwlehman/blivet/subscription","commits_url":"https://api.github.com/repos/dwlehman/blivet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwlehman/blivet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwlehman/blivet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwlehman/blivet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwlehman/blivet/contents/{+path}","compare_url":"https://api.github.com/repos/dwlehman/blivet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwlehman/blivet/merges","archive_url":"https://api.github.com/repos/dwlehman/blivet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwlehman/blivet/downloads","issues_url":"https://api.github.com/repos/dwlehman/blivet/issues{/number}","pulls_url":"https://api.github.com/repos/dwlehman/blivet/pulls{/number}","milestones_url":"https://api.github.com/repos/dwlehman/blivet/milestones{/number}","notifications_url":"https://api.github.com/repos/dwlehman/blivet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwlehman/blivet/labels{/name}","releases_url":"https://api.github.com/repos/dwlehman/blivet/releases{/id}","deployments_url":"https://api.github.com/repos/dwlehman/blivet/deployments","created_at":"2015-03-10T15:27:13Z","updated_at":"2016-01-20T20:05:23Z","pushed_at":"2016-09-01T20:08:10Z","git_url":"git://github.com/dwlehman/blivet.git","ssh_url":"git@github.com:dwlehman/blivet.git","clone_url":"https://github.com/dwlehman/blivet.git","svn_url":"https://github.com/dwlehman/blivet","homepage":null,"size":8646,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rhinstaller:2.1-devel","ref":"2.1-devel","sha":"e7e948e68ac9fb0a45ce8ddc5b23af7b6330e985","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":16584540,"name":"blivet","full_name":"rhinstaller/blivet","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/blivet","description":"A python module for configuration of block devices","fork":false,"url":"https://api.github.com/repos/rhinstaller/blivet","forks_url":"https://api.github.com/repos/rhinstaller/blivet/forks","keys_url":"https://api.github.com/repos/rhinstaller/blivet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/blivet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/blivet/teams","hooks_url":"https://api.github.com/repos/rhinstaller/blivet/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/blivet/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/blivet/events","assignees_url":"https://api.github.com/repos/rhinstaller/blivet/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/blivet/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/blivet/tags","blobs_url":"https://api.github.com/repos/rhinstaller/blivet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/blivet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/blivet/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/blivet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/blivet/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/blivet/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/blivet/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/blivet/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/blivet/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/blivet/subscription","commits_url":"https://api.github.com/repos/rhinstaller/blivet/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/blivet/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/blivet/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/blivet/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/blivet/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/blivet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/blivet/merges","archive_url":"https://api.github.com/repos/rhinstaller/blivet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/blivet/downloads","issues_url":"https://api.github.com/repos/rhinstaller/blivet/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/blivet/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/blivet/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/blivet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/blivet/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/blivet/releases{/id}","deployments_url":"https://api.github.com/repos/rhinstaller/blivet/deployments","created_at":"2014-02-06T16:02:44Z","updated_at":"2016-08-18T08:37:16Z","pushed_at":"2016-09-02T10:23:28Z","git_url":"git://github.com/rhinstaller/blivet.git","ssh_url":"git@github.com:rhinstaller/blivet.git","clone_url":"https://github.com/rhinstaller/blivet.git","svn_url":"https://github.com/rhinstaller/blivet","homepage":null,"size":11644,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"open_issues_count":38,"forks":35,"open_issues":38,"watchers":24,"default_branch":"2.0-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/485"},"html":{"href":"https://github.com/rhinstaller/blivet/pull/485"},"issue":{"href":"https://api.github.com/repos/rhinstaller/blivet/issues/485"},"comments":{"href":"https://api.github.com/repos/rhinstaller/blivet/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/blivet/statuses/4e3e91f429b0ad76e4b1129e814b2a19274f60f3"}}}}
{"actor":{"display_login":"dwlehman"}}