{"action":"created","issue":{"url":"https://api.github.com/repos/getlantern/lantern/issues/4422","repository_url":"https://api.github.com/repos/getlantern/lantern","labels_url":"https://api.github.com/repos/getlantern/lantern/issues/4422/labels{/name}","comments_url":"https://api.github.com/repos/getlantern/lantern/issues/4422/comments","events_url":"https://api.github.com/repos/getlantern/lantern/issues/4422/events","html_url":"https://github.com/getlantern/lantern/pull/4422","id":157546443,"number":4422,"title":"Ignore all test errors in official distributions (closes #4421)","user":{"login":"uaalto","id":12701448,"avatar_url":"https://avatars.githubusercontent.com/u/12701448?v=3","gravatar_id":"","url":"https://api.github.com/users/uaalto","html_url":"https://github.com/uaalto","followers_url":"https://api.github.com/users/uaalto/followers","following_url":"https://api.github.com/users/uaalto/following{/other_user}","gists_url":"https://api.github.com/users/uaalto/gists{/gist_id}","starred_url":"https://api.github.com/users/uaalto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uaalto/subscriptions","organizations_url":"https://api.github.com/users/uaalto/orgs","repos_url":"https://api.github.com/users/uaalto/repos","events_url":"https://api.github.com/users/uaalto/events{/privacy}","received_events_url":"https://api.github.com/users/uaalto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-30T19:13:02Z","updated_at":"2016-05-31T07:35:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getlantern/lantern/pulls/4422","html_url":"https://github.com/getlantern/lantern/pull/4422","diff_url":"https://github.com/getlantern/lantern/pull/4422.diff","patch_url":"https://github.com/getlantern/lantern/pull/4422.patch"},"body":"We were using a specific patch for bypassing one failing test. In Linux, there is another test that fails.\r\nFor this reason, I think we should just continue if any error is found in official releases, but still inform the user about it.  This way we avoid cluttering with patches, which don't actually provide any  additional correctness to the compiler.\r\n\r\nThe diff is against lantern-pro, is this ok or should it be against devel, @myleshorton ?"},"comment":{"url":"https://api.github.com/repos/getlantern/lantern/issues/comments/222613705","html_url":"https://github.com/getlantern/lantern/pull/4422#issuecomment-222613705","issue_url":"https://api.github.com/repos/getlantern/lantern/issues/4422","id":222613705,"user":{"login":"fffw","id":10410437,"avatar_url":"https://avatars.githubusercontent.com/u/10410437?v=3","gravatar_id":"","url":"https://api.github.com/users/fffw","html_url":"https://github.com/fffw","followers_url":"https://api.github.com/users/fffw/followers","following_url":"https://api.github.com/users/fffw/following{/other_user}","gists_url":"https://api.github.com/users/fffw/gists{/gist_id}","starred_url":"https://api.github.com/users/fffw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fffw/subscriptions","organizations_url":"https://api.github.com/users/fffw/orgs","repos_url":"https://api.github.com/users/fffw/repos","events_url":"https://api.github.com/users/fffw/events{/privacy}","received_events_url":"https://api.github.com/users/fffw/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T07:35:49Z","updated_at":"2016-05-31T07:35:49Z","body":"@uaalto `lantern-pro` branch is too old and I'll remove it to avoid confusing. PR to `devel` would be good IMO."}}
{"actor":{"display_login":"fffw"}}