{"push_id":1462124509,"size":201,"distinct_size":201,"ref":"refs/heads/master","head":"37690535b2ba477a5deeb421dab55f5344932db1","before":"b175647a64c3ef629a3f423d820068399a7736eb","commits":[{"sha":"47005692afd3305e7812e343304647ebb8973b76","author":{"name":"Phil Christensen","email":"b8062900257e763583581ffd2100badbc8371ed1@microsoft.com"},"message":"C++ conformance. (building with /permissive-)\n\nThese issues were found when building with the /permissive- flag in the latest version of MSVC.  No tests were added/modified because this does not change any behavior.\n\nThere are three types of language conformance issues fixed in this:\n\n1) Strict string conversion (this is also covered by the /Zc:strictStrings flag)\n\n  The 'const' is not implicitly dropped by string literals, which means the following is not allowed:\n\n  char *str = \"const string literal\"; //error: cannot convert a 'const char*' to a 'char*'\n\n  This fix to to make str 'const char*'.  (This can have a domino effect depending on where str is used)\n\n2) Fully qualified inline declarations members inside class\n\n   struct A {\n      void A::f() { } // Error: illegal qualified name in member declaration, remove redundant 'A::' to fix\n   };\n\n3) MSVC by default will allows name lookup in a dependent base.  This is disabled by /permissive-\n\n    template <class T> struct B {\n      void f();\n    };\n\n    template <class T> struct D\n        : public B<T> //B is a dependent base because its type depends on the type of T in D<T>.\n    {\n        //One possible fix is to uncomment the following line.  If this were a type we should have 'using typename'...\n        //using B<T>::f;\n\n        void g() {\n          f(); //Error: identifier not found, one possible fix is change it to 'this->f();'\n        }\n    };\n\n    void h()\n    {\n       D<int> d;\n       d.g();\n    }","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/47005692afd3305e7812e343304647ebb8973b76"},{"sha":"4116adb905417b63f2e9ae19c721e77c050d06b4","author":{"name":"Phil Christensen","email":"b8062900257e763583581ffd2100badbc8371ed1@microsoft.com"},"message":"remove extra 'typename'","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/4116adb905417b63f2e9ae19c721e77c050d06b4"},{"sha":"83917596c474dab492f61241370b8fbfc4b98b9a","author":{"name":"Ian Halliday","email":"44e6481929d2558931e76ad3b771027e9a992feb@microsoft.com"},"message":"xplat: don't use private heap\n\nDo not use private heap on xplat.  Currently with our static linking in\nnode-chakracore our overridden new/delete operators are picked up by\nnode itself.  Use of the private heap leads to instability on shutdown\ndue to the chance that HeapAllocator::Instance is disposed before other\nallocations.  Using alloc and free instead circumvents this problem.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/83917596c474dab492f61241370b8fbfc4b98b9a"},{"sha":"35226c9e58f3b33b3d461ba3422612d17b885220","author":{"name":"Ian Halliday","email":"44e6481929d2558931e76ad3b771027e9a992feb@microsoft.com"},"message":"[MERGE #2088 @ianwjhalliday] xplat: don't use private heap\n\nMerge pull request #2088 from ianwjhalliday:release/2.0-pre\n\nDo not use private heap on xplat.\n\nCurrently with our static linking in node-chakracore our overridden new/delete operators are picked up by node itself.  Use of the private heap leads to instability on shutdown due to the chance that HeapAllocator::Instance is disposed before other allocations.  Using alloc and free instead circumvents this problem.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/35226c9e58f3b33b3d461ba3422612d17b885220"},{"sha":"008963449cab03a882cd2d557a47d71c1f90c1c0","author":{"name":"Oguz Bastemur","email":"16dc18bfab94db42897450219ec4717f85783177@microsoft.com"},"message":"Remove libunwind dependency\n\nChakraCore no longer depends on libunwind on cross platform","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/008963449cab03a882cd2d557a47d71c1f90c1c0"},{"sha":"c8cf15a8e6fe667e2b1bd0d38c153036b0a29766","author":{"name":"Mark Marron","email":"cb54992cfb708e5d7dc961c3d0e4a456e2a51acc@microsoft.com"},"message":"Updated serialization for easier diagnostics.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/c8cf15a8e6fe667e2b1bd0d38c153036b0a29766"},{"sha":"12b0ae48990012db3a9ff91cc49d7f848caa3752","author":{"name":"Mark Marron","email":"cb54992cfb708e5d7dc961c3d0e4a456e2a51acc@microsoft.com"},"message":"[MERGE #2094 @mrkmarron] TTD -- Update for easier diagnostics.\n\nMerge pull request #2094 from mrkmarron:TTSnapSerialize\n\n- Use text serialization for debug & release builds.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/12b0ae48990012db3a9ff91cc49d7f848caa3752"},{"sha":"1873264399ddc7ebb0bf1c15792ff38af7cfdeef","author":{"name":"Oguz Bastemur","email":"16dc18bfab94db42897450219ec4717f85783177@microsoft.com"},"message":"[MERGE #2086 @obastemur] Remove libunwind dependency\n\nMerge pull request #2086 from obastemur:wind_free\n\nChakraCore no longer depends on libunwind on cross platform","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/1873264399ddc7ebb0bf1c15792ff38af7cfdeef"},{"sha":"85480c5870b75901b51f9b057fa5d5c2345530db","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"Update ChakraCore version to 2.0 in branch release/2.0-pre; also verify CI configuration.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/85480c5870b75901b51f9b057fa5d5c2345530db"},{"sha":"def2642a7d095988676248b05a0b627ba55e99c5","author":{"name":"Phil Christensen","email":"b8062900257e763583581ffd2100badbc8371ed1@microsoft.com"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/def2642a7d095988676248b05a0b627ba55e99c5"},{"sha":"ad9bc1f5ad53d85b901e9ba5991f9e5cb04f86cb","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"[MERGE #2104 @dilijev] Update ChakraCore version to 2.0 in branch release/2.0-pre; also verify CI configuration.\n\nMerge pull request #2104 from dilijev:v200","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/ad9bc1f5ad53d85b901e9ba5991f9e5cb04f86cb"},{"sha":"b4549ab006063f4d6275350e96ceb37c2aa4d3ab","author":{"name":"Michael Ferris","email":"626b08bb1972d1c053dabc34c01b571c79e94bb4@microsoft.com"},"message":"Do not crash when debugging with WebAssembly functions present\nCorrectly reset the entry points for the Wasm function when attaching the debugger","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/b4549ab006063f4d6275350e96ceb37c2aa4d3ab"},{"sha":"421e76637be6c95245422d1e86f27df21cc18368","author":{"name":"Phil Christensen","email":"b8062900257e763583581ffd2100badbc8371ed1@microsoft.com"},"message":"fix permissive C++ code (MSVC /permissive-)\n\nThese were found by the C++ compiler group when doing \"Real world code\"\nbuild tests using /permissive-.  We are sharing these with you to help you clean up\nyour code before the new version of the compiler comes out.  For more information on /permissive-\nsee https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/.\n\n----------------------------\nUnder /permissive-, skipping the initialization of a variable is not allowed.\nAs an extension the compiler allowed this when there was no destructor for the type.\n\n    void func(bool b)\n    {\n        if(b) goto END;\n\n        int value = 0; //error C2362: initialization of 'value' is skipped by 'goto END'\n    \tint array[10]; //Okay, not initialized.\n        //... value used here\n\n    END:\n        return;\n    }\n\nFix 1) Limit the scope of value:\n\n    {\n      int value = 0;\n      //... value used here\n    }\n    END:\n\nFix 2) Initialize/declare value before the 'goto'\n\n    int value = 0;\n    if(b) goto END;\n    //... value used here\n    END:\n\nFix 3) Don't initialize value in the variable declaration.\n\n    int value;\n    value = 0\n    //... value used here\n    END:\n---------------------------\nThere were also changes related to \"fully qualified inline declarations members inside class\"\nand \"MSVC by default will allows name lookup in a dependent base. This is disabled by /permissive-\"\nSee the /permissive- blog post or the previous commit for more information on those.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/421e76637be6c95245422d1e86f27df21cc18368"},{"sha":"ebbf1ce36c7bf4464423b1c4b504b1494fa57ddd","author":{"name":"Phil Christensen","email":"b8062900257e763583581ffd2100badbc8371ed1@microsoft.com"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/ebbf1ce36c7bf4464423b1c4b504b1494fa57ddd"},{"sha":"39c8f4814ecfdbd64612c989157134f5e72133e5","author":{"name":"Rajat Dua","email":"48bd834be3bab3d588f7d2ef3d92438a1bce7bf0@microsoft.com"},"message":"With redeferral, function types can point to a ProxyEntryPointInfo object too. Expand an assert for that.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/39c8f4814ecfdbd64612c989157134f5e72133e5"},{"sha":"979a9f3a4707c6a03a24edcfbbbf62314101f63e","author":{"name":"Joseph Coffland","email":"9b6e24a661c030e39d84e80f958c2d82d5dc3d65@cauldrondevelopment.com"},"message":"Fixes Jsrt API C99/C++98 compatability\n\nFixed abuse of JsTTDMoveMode enum in call to JsTTDGetSnapTimeTopLevelEventMove() so that JsTTDMoveMode does not need to be 64-bit and thus incompatible with C99/C++98\n\nDon't use nullptr at all, it's incompatible with C++98","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/979a9f3a4707c6a03a24edcfbbbf62314101f63e"},{"sha":"375ed38dfba9db4cf35fc32772141c4b54768382","author":{"name":"Rajat Dua","email":"48bd834be3bab3d588f7d2ef3d92438a1bce7bf0@microsoft.com"},"message":"[MERGE #2127 @rajatd] Expand an assert in FunctionEntryPointInfo::Expire\n\nMerge pull request #2127 from rajatd:assertFix\n\nWith redeferral, function types can point to a ProxyEntryPointInfo object too. Expand an assert for that.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/375ed38dfba9db4cf35fc32772141c4b54768382"},{"sha":"d9c759d3b606ba89af2675610e2c988891afd139","author":{"name":"Rajat Dua","email":"48bd834be3bab3d588f7d2ef3d92438a1bce7bf0@microsoft.com"},"message":"[1.4>master] [MERGE #2127 @rajatd] Expand an assert in FunctionEntryPointInfo::Expire\n\nMerge pull request #2127 from rajatd:assertFix\n\nWith redeferral, function types can point to a ProxyEntryPointInfo object too. Expand an assert for that.","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/d9c759d3b606ba89af2675610e2c988891afd139"},{"sha":"7c097b698de1e400286f9b957597b2a81fc6f80b","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"Removed U+180E MONGOLIAN VOWEL SEPARATOR from Whitespace classification.\n\nThis character was recategorized from Zs to Cf in Unicode 6.3, and remains categorized as such in Unicode 9.0 (current target version). The current version of ECMAScript requires that only characters classed as Zs in the target version of Unicode be recognized as Whitespace. This change is now reflected in Test262 so making this change will improve our Test262 score rather than regress it.\n\nAdditionally, update comments about location of UnicodeData.txt and about the definition of Whitespace characters.\n\nSee: https://github.com/tc39/ecma262/pull/300\n\nSee: https://github.com/tc39/test262/commit/3a5a09eba2adb6a8c24cf6e603aefe9bfa8d75b9\n\nSee: https://github.com/mathiasbynens/regexpu-core/commit/9b10d2a597d4e56b236cae0f9aa2f21a9c6d1122\n\nFixes #2120","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/7c097b698de1e400286f9b957597b2a81fc6f80b"},{"sha":"60c2eacb96fc4ad38b4eec44437ee86ff12aa170","author":{"name":"Michael Ferris","email":"626b08bb1972d1c053dabc34c01b571c79e94bb4@microsoft.com"},"message":"Generate a nonative tests\nFix bug in imports.wast generation","distinct":true,"url":"https://api.github.com/repos/navidR/ChakraCore/commits/60c2eacb96fc4ad38b4eec44437ee86ff12aa170"}]}
{"actor":{"display_login":"navidR"}}