{"action":"created","comment":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/71208899","id":71208899,"diff_hunk":"@@ -163,6 +163,17 @@ public int hashCode() {\n     }\n \n     /**\n+     * Calculates and returns a version hash for this entity. This method operates much like the\n+     * hashCode method, except that it is more accurate and should have fewer collisions.\n+     *\n+     * @return\n+     *  a version hash for this entity\n+     */\n+    public int getEntityVersion() {\n+        return this.hashCode();","path":"server/src/main/java/org/candlepin/model/ProductAttribute.java","position":11,"original_position":11,"commit_id":"33c44493d2a660473048c712141665ce89634b06","original_commit_id":"33c44493d2a660473048c712141665ce89634b06","user":{"login":"Ceiu","id":6061522,"avatar_url":"https://avatars.githubusercontent.com/u/6061522?v=3","gravatar_id":"","url":"https://api.github.com/users/Ceiu","html_url":"https://github.com/Ceiu","followers_url":"https://api.github.com/users/Ceiu/followers","following_url":"https://api.github.com/users/Ceiu/following{/other_user}","gists_url":"https://api.github.com/users/Ceiu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ceiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ceiu/subscriptions","organizations_url":"https://api.github.com/users/Ceiu/orgs","repos_url":"https://api.github.com/users/Ceiu/repos","events_url":"https://api.github.com/users/Ceiu/events{/privacy}","received_events_url":"https://api.github.com/users/Ceiu/received_events","type":"User","site_admin":false},"body":"This is a general statement that doesn't apply to every implementation. In the cases cited here, we're retrieving the hash codes for strings, integers, booleans and entity objects which themselves define a hashCode implementation which is derived from the afore mentioned hash code implementations.\r\n\r\nOur hash codes will be consistent from instance to instance, so long as the Java implementation itself remains consistent.","created_at":"2016-07-18T19:06:45Z","updated_at":"2016-07-18T19:06:45Z","html_url":"https://github.com/candlepin/candlepin/pull/1297#discussion_r71208899","pull_request_url":"https://api.github.com/repos/candlepin/candlepin/pulls/1297","_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/71208899"},"html":{"href":"https://github.com/candlepin/candlepin/pull/1297#discussion_r71208899"},"pull_request":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/1297"}}},"pull_request":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/1297","id":77837912,"html_url":"https://github.com/candlepin/candlepin/pull/1297","diff_url":"https://github.com/candlepin/candlepin/pull/1297.diff","patch_url":"https://github.com/candlepin/candlepin/pull/1297.patch","issue_url":"https://api.github.com/repos/candlepin/candlepin/issues/1297","number":1297,"state":"open","locked":false,"title":"Refactored hashCode implementations in certain high-traffic entities","user":{"login":"Ceiu","id":6061522,"avatar_url":"https://avatars.githubusercontent.com/u/6061522?v=3","gravatar_id":"","url":"https://api.github.com/users/Ceiu","html_url":"https://github.com/Ceiu","followers_url":"https://api.github.com/users/Ceiu/followers","following_url":"https://api.github.com/users/Ceiu/following{/other_user}","gists_url":"https://api.github.com/users/Ceiu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ceiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ceiu/subscriptions","organizations_url":"https://api.github.com/users/Ceiu/orgs","repos_url":"https://api.github.com/users/Ceiu/repos","events_url":"https://api.github.com/users/Ceiu/events{/privacy}","received_events_url":"https://api.github.com/users/Ceiu/received_events","type":"User","site_admin":false},"body":"- The existing hashCode implementations for Product and Content entities\r\n  (as well as related join- and sub-objects) has been moved to the new\r\n  getEntityVersion method\r\n- The new hashCode implementation for Product and Content now use the\r\n  Red Hat ID for the entity\r\n- Improved equality and hashcode testing in Product and Content","created_at":"2016-07-18T16:29:22Z","updated_at":"2016-07-18T19:06:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b0796913ae41eaa489b4ea58dc6713cac45de4f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/candlepin/pulls/1297/commits","review_comments_url":"https://api.github.com/repos/candlepin/candlepin/pulls/1297/comments","review_comment_url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candlepin/candlepin/issues/1297/comments","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/33c44493d2a660473048c712141665ce89634b06","head":{"label":"candlepin:crog/versioning_optimizations","ref":"crog/versioning_optimizations","sha":"33c44493d2a660473048c712141665ce89634b06","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/candlepin/deployments","created_at":"2012-06-07T14:58:35Z","updated_at":"2016-07-13T11:23:38Z","pushed_at":"2016-07-18T17:13:50Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":59921,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":10,"forks":28,"open_issues":10,"watchers":39,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"157930e3b58a16694ce1dcf138acbaa69f2f304b","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/candlepin/deployments","created_at":"2012-06-07T14:58:35Z","updated_at":"2016-07-13T11:23:38Z","pushed_at":"2016-07-18T17:13:50Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":59921,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":10,"forks":28,"open_issues":10,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/1297"},"html":{"href":"https://github.com/candlepin/candlepin/pull/1297"},"issue":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/1297"},"comments":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/1297/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/1297/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/1297/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/candlepin/statuses/33c44493d2a660473048c712141665ce89634b06"}}}}
{"actor":{"display_login":"Ceiu"}}