{"action":"created","issue":{"url":"https://api.github.com/repos/rdit-ch/itemframework/issues/22","repository_url":"https://api.github.com/repos/rdit-ch/itemframework","labels_url":"https://api.github.com/repos/rdit-ch/itemframework/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/rdit-ch/itemframework/issues/22/comments","events_url":"https://api.github.com/repos/rdit-ch/itemframework/issues/22/events","html_url":"https://github.com/rdit-ch/itemframework/pull/22","id":191795400,"number":22,"title":"Remove any calls to remove() before item is destructed","user":{"login":"Shadowigor","id":6695660,"avatar_url":"https://avatars.githubusercontent.com/u/6695660?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowigor","html_url":"https://github.com/Shadowigor","followers_url":"https://api.github.com/users/Shadowigor/followers","following_url":"https://api.github.com/users/Shadowigor/following{/other_user}","gists_url":"https://api.github.com/users/Shadowigor/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowigor/subscriptions","organizations_url":"https://api.github.com/users/Shadowigor/orgs","repos_url":"https://api.github.com/users/Shadowigor/repos","events_url":"https://api.github.com/users/Shadowigor/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowigor/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-26T08:59:47Z","updated_at":"2016-11-26T09:06:39Z","closed_at":"2016-11-26T09:06:39Z","pull_request":{"url":"https://api.github.com/repos/rdit-ch/itemframework/pulls/22","html_url":"https://github.com/rdit-ch/itemframework/pull/22","diff_url":"https://github.com/rdit-ch/itemframework/pull/22.diff","patch_url":"https://github.com/rdit-ch/itemframework/pull/22.patch"},"body":"During `AbstractItem::remove()` all `ItemInput`/`ItemOutput` objects of the item are deleted. If an item tries to access those between their destruction and it's own destruction, you get a segfault. Also, after each call to `remove()`, the item is immediately deleted afterwards and remove is called in the destructor again anyway, so we should be able to safely remove the calls before."},"comment":{"url":"https://api.github.com/repos/rdit-ch/itemframework/issues/comments/263052738","html_url":"https://github.com/rdit-ch/itemframework/pull/22#issuecomment-263052738","issue_url":"https://api.github.com/repos/rdit-ch/itemframework/issues/22","id":263052738,"user":{"login":"t-moe","id":11081135,"avatar_url":"https://avatars.githubusercontent.com/u/11081135?v=3","gravatar_id":"","url":"https://api.github.com/users/t-moe","html_url":"https://github.com/t-moe","followers_url":"https://api.github.com/users/t-moe/followers","following_url":"https://api.github.com/users/t-moe/following{/other_user}","gists_url":"https://api.github.com/users/t-moe/gists{/gist_id}","starred_url":"https://api.github.com/users/t-moe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-moe/subscriptions","organizations_url":"https://api.github.com/users/t-moe/orgs","repos_url":"https://api.github.com/users/t-moe/repos","events_url":"https://api.github.com/users/t-moe/events{/privacy}","received_events_url":"https://api.github.com/users/t-moe/received_events","type":"User","site_admin":false},"created_at":"2016-11-26T09:06:39Z","updated_at":"2016-11-26T09:06:39Z","body":"#20 fixes this already (merge pending)"}}
{"actor":{"display_login":"t-moe"}}