{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/921","repository_url":"https://api.github.com/repos/aspnet/KestrelHttpServer","labels_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/921/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/921/comments","events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/921/events","html_url":"https://github.com/aspnet/KestrelHttpServer/issues/921","id":159481640,"number":921,"title":"Consider changing the ThreadCount on OS X to 1","user":{"login":"halter73","id":54385,"avatar_url":"https://avatars.githubusercontent.com/u/54385?v=3","gravatar_id":"","url":"https://api.github.com/users/halter73","html_url":"https://github.com/halter73","followers_url":"https://api.github.com/users/halter73/followers","following_url":"https://api.github.com/users/halter73/following{/other_user}","gists_url":"https://api.github.com/users/halter73/gists{/gist_id}","starred_url":"https://api.github.com/users/halter73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halter73/subscriptions","organizations_url":"https://api.github.com/users/halter73/orgs","repos_url":"https://api.github.com/users/halter73/repos","events_url":"https://api.github.com/users/halter73/events{/privacy}","received_events_url":"https://api.github.com/users/halter73/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-09T18:52:53Z","updated_at":"2016-06-14T18:38:19Z","closed_at":null,"body":"`ThreadCountTests` have been [pretty](https://github.com/aspnet/KestrelHttpServer/pull/908) [flaky](https://github.com/aspnet/KestrelHttpServer/pull/913) on OS X. It now seems we are working around this issue by always running Kestrel tests with a `ThreadCount` of 1 on OS X.\r\n\r\nThe working assumption is that the test failures are caused by exceeding the file open limit, but output from `lsof` seems to contradict this.\r\n\r\nSince we have no fix for this issue other than changing the tests not use multiple thread, I really think we should consider not having Kestrel run in an untested configuration on OS X. I think this would mean disallowing `ThreadCount`s other than 1 on OS X or at least making 1 the default.\r\n\r\n@cesarbs @muratg  "},"comment":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/comments/225975934","html_url":"https://github.com/aspnet/KestrelHttpServer/issues/921#issuecomment-225975934","issue_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/921","id":225975934,"user":{"login":"cesarbs","id":924164,"avatar_url":"https://avatars.githubusercontent.com/u/924164?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarbs","html_url":"https://github.com/cesarbs","followers_url":"https://api.github.com/users/cesarbs/followers","following_url":"https://api.github.com/users/cesarbs/following{/other_user}","gists_url":"https://api.github.com/users/cesarbs/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarbs/subscriptions","organizations_url":"https://api.github.com/users/cesarbs/orgs","repos_url":"https://api.github.com/users/cesarbs/repos","events_url":"https://api.github.com/users/cesarbs/events{/privacy}","received_events_url":"https://api.github.com/users/cesarbs/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T18:38:19Z","updated_at":"2016-06-14T18:38:19Z","body":"@halter73 I did the following: I ran the sample app with 8 threads on a shell using the default ulimit (256). On another shell I issued 100 concurrent requests against the app and saw the errors we were seeing in the tests. Then I increased `ulimit -n` to 2048 in the shell where I was running the app, issues the requests again (multiple times) and never saw the errors again.\r\n\r\nRestricting thread count on OS X is too aggressive. If people hit issues we can tell them to 1) increase the ulimit or 2) set the thread count to 1 themselves."}}
{"actor":{"display_login":"cesarbs"}}