{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/63056179","id":63056179,"diff_hunk":"@@ -113,7 +149,9 @@ - (void)setAutomaticallyAdjustRangeModeBasedOnViewEvents:(BOOL)automaticallyAdju\n - (void)updateCurrentRangeModeWithModeIfPossible:(ASLayoutRangeMode)rangeMode","path":"AsyncDisplayKit/ASViewController.m","position":76,"original_position":76,"commit_id":"abfbf6234beabe14da033bd795de316c7e0497a5","original_commit_id":"abfbf6234beabe14da033bd795de316c7e0497a5","user":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"body":"How about updateCurrentRangeWithModeIfNeeded? It's pedantic, but updateCurrentRangeModeIfNeeded doesn't seem like it would take a parameter.","created_at":"2016-05-12T16:53:42Z","updated_at":"2016-05-12T16:53:42Z","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1653#discussion_r63056179","pull_request_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653","_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/63056179"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1653#discussion_r63056179"},"pull_request":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653","id":69761050,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1653","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1653.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1653.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1653","number":1653,"state":"open","locked":false,"title":"Visibility","user":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"body":"This adds support for the concept of visibility depth.\r\n\r\nVisibility essentially defines the number of user actions it would\r\ntake a user to have a view controller visible. Knowing a view controllers\r\nvisibility depth allows view controllers to take action such as clearing\r\nout memory that can be restored at a later date.\r\n\r\nThis patch also add two new view controller subclasses which adopt\r\nthe ASManagesChildVisibilityDepth protocol. Any view controller\r\nthat has child view controllers can adopt this protocol to indicate\r\nto the child what they're visibility is. For example, ASNavigationController\r\nwill return a visibility depth of it's own visibilityDepth + 1 for\r\na view controller that would be revealed by tapping the back button.","created_at":"2016-05-11T23:56:02Z","updated_at":"2016-05-12T16:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3c82e6ee6ba0fa466e2f9a34d0d43ca8f54e6e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1653/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/abfbf6234beabe14da033bd795de316c7e0497a5","head":{"label":"garrettmoon:visibility","ref":"visibility","sha":"abfbf6234beabe14da033bd795de316c7e0497a5","user":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"repo":{"id":37542421,"name":"AsyncDisplayKit","full_name":"garrettmoon/AsyncDisplayKit","owner":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garrettmoon/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit","forks_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/deployments","created_at":"2015-06-16T16:33:05Z","updated_at":"2016-05-03T22:48:40Z","pushed_at":"2016-05-12T00:29:52Z","git_url":"git://github.com/garrettmoon/AsyncDisplayKit.git","ssh_url":"git@github.com:garrettmoon/AsyncDisplayKit.git","clone_url":"https://github.com/garrettmoon/AsyncDisplayKit.git","svn_url":"https://github.com/garrettmoon/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":45033,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9aba0fb19d934c665dcaa3bd39f733f7e1432de6","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/deployments","created_at":"2014-06-27T05:29:02Z","updated_at":"2016-05-12T15:46:40Z","pushed_at":"2016-05-12T04:19:57Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":52312,"stargazers_count":8085,"watchers_count":8085,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1318,"mirror_url":null,"open_issues_count":138,"forks":1318,"open_issues":138,"watchers":8085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1653"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1653"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1653/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1653/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/abfbf6234beabe14da033bd795de316c7e0497a5"}}}}