{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/26","id":61324072,"html_url":"https://github.com/buildkite/buildkite-aws-stack/pull/26","diff_url":"https://github.com/buildkite/buildkite-aws-stack/pull/26.diff","patch_url":"https://github.com/buildkite/buildkite-aws-stack/pull/26.patch","issue_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/26","number":26,"state":"closed","locked":false,"title":"Allow empty secrets key","user":{"login":"lox","id":15758,"avatar_url":"https://avatars.githubusercontent.com/u/15758?v=3","gravatar_id":"","url":"https://api.github.com/users/lox","html_url":"https://github.com/lox","followers_url":"https://api.github.com/users/lox/followers","following_url":"https://api.github.com/users/lox/following{/other_user}","gists_url":"https://api.github.com/users/lox/gists{/gist_id}","starred_url":"https://api.github.com/users/lox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lox/subscriptions","organizations_url":"https://api.github.com/users/lox/orgs","repos_url":"https://api.github.com/users/lox/repos","events_url":"https://api.github.com/users/lox/events{/privacy}","received_events_url":"https://api.github.com/users/lox/received_events","type":"User","site_admin":false},"body":"For easier backwards compatibility with stacks that didn't have encrypted keys in a provision bucket, this allows `BUILDKITE_SECRETS_KEY` to be empty.\r\n\r\nIt also provides some extra configuration points via ENV:\r\n\r\n - `BUILDKITE_SECRETS_PREFIX` - This is a key prefix for the secrets bucket, by default it's the name of the pipeline\r\n - `SSH_KEY_NAME` - The name of the key file (under the above prefix), defaults to `id_rsa_github`\r\n\r\nThis change also sets the default url for env and the ssh key file to be under the above `BUILDKITE_SECRETS_PREFIX`, which is a breaking change. You can set an empty secrets prefix to emulate previous behaviour.\r\n\r\n\r\n","created_at":"2016-03-01T23:02:58Z","updated_at":"2016-03-02T00:34:29Z","closed_at":"2016-03-02T00:34:29Z","merged_at":"2016-03-02T00:34:29Z","merge_commit_sha":"342eac4f6925d9a217278c120979511cf53cb275","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/26/commits","review_comments_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/26/comments","review_comment_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/26/comments","statuses_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/statuses/e798b5dea2403679dce8de18db5026fb068931fb","head":{"label":"buildkite:allow-empty-secrets-key","ref":"allow-empty-secrets-key","sha":"e798b5dea2403679dce8de18db5026fb068931fb","user":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars.githubusercontent.com/u/5055988?v=3","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"repo":{"id":36488517,"name":"buildkite-aws-stack","full_name":"buildkite/buildkite-aws-stack","owner":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars.githubusercontent.com/u/5055988?v=3","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildkite/buildkite-aws-stack","description":"A Docker-enabled, auto-scaling cloud of Buildkite agents on AWS using EC2 and Cloud Formation","fork":false,"url":"https://api.github.com/repos/buildkite/buildkite-aws-stack","forks_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/forks","keys_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/teams","hooks_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/hooks","issue_events_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/events{/number}","events_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/events","assignees_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/assignees{/user}","branches_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/branches{/branch}","tags_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/tags","blobs_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/languages","stargazers_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/stargazers","contributors_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/contributors","subscribers_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/subscribers","subscription_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/subscription","commits_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/contents/{+path}","compare_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/merges","archive_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/downloads","issues_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues{/number}","pulls_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/labels{/name}","releases_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/releases{/id}","deployments_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/deployments","created_at":"2015-05-29T07:28:16Z","updated_at":"2016-02-26T21:44:29Z","pushed_at":"2016-03-02T00:34:29Z","git_url":"git://github.com/buildkite/buildkite-aws-stack.git","ssh_url":"git@github.com:buildkite/buildkite-aws-stack.git","clone_url":"https://github.com/buildkite/buildkite-aws-stack.git","svn_url":"https://github.com/buildkite/buildkite-aws-stack","homepage":"","size":154,"stargazers_count":10,"watchers_count":10,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":0,"forks":8,"open_issues":0,"watchers":10,"default_branch":"master"}},"base":{"label":"buildkite:master","ref":"master","sha":"25a8f887dd74b9a2568862f7fafe96f69e04200c","user":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars.githubusercontent.com/u/5055988?v=3","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"repo":{"id":36488517,"name":"buildkite-aws-stack","full_name":"buildkite/buildkite-aws-stack","owner":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars.githubusercontent.com/u/5055988?v=3","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildkite/buildkite-aws-stack","description":"A Docker-enabled, auto-scaling cloud of Buildkite agents on AWS using EC2 and Cloud Formation","fork":false,"url":"https://api.github.com/repos/buildkite/buildkite-aws-stack","forks_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/forks","keys_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/teams","hooks_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/hooks","issue_events_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/events{/number}","events_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/events","assignees_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/assignees{/user}","branches_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/branches{/branch}","tags_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/tags","blobs_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/languages","stargazers_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/stargazers","contributors_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/contributors","subscribers_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/subscribers","subscription_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/subscription","commits_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/contents/{+path}","compare_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/merges","archive_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/downloads","issues_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues{/number}","pulls_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/labels{/name}","releases_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/releases{/id}","deployments_url":"https://api.github.com/repos/buildkite/buildkite-aws-stack/deployments","created_at":"2015-05-29T07:28:16Z","updated_at":"2016-02-26T21:44:29Z","pushed_at":"2016-03-02T00:34:29Z","git_url":"git://github.com/buildkite/buildkite-aws-stack.git","ssh_url":"git@github.com:buildkite/buildkite-aws-stack.git","clone_url":"https://github.com/buildkite/buildkite-aws-stack.git","svn_url":"https://github.com/buildkite/buildkite-aws-stack","homepage":"","size":154,"stargazers_count":10,"watchers_count":10,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":0,"forks":8,"open_issues":0,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/26"},"html":{"href":"https://github.com/buildkite/buildkite-aws-stack/pull/26"},"issue":{"href":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/26"},"comments":{"href":"https://api.github.com/repos/buildkite/buildkite-aws-stack/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildkite/buildkite-aws-stack/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/buildkite/buildkite-aws-stack/statuses/e798b5dea2403679dce8de18db5026fb068931fb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lox","id":15758,"avatar_url":"https://avatars.githubusercontent.com/u/15758?v=3","gravatar_id":"","url":"https://api.github.com/users/lox","html_url":"https://github.com/lox","followers_url":"https://api.github.com/users/lox/followers","following_url":"https://api.github.com/users/lox/following{/other_user}","gists_url":"https://api.github.com/users/lox/gists{/gist_id}","starred_url":"https://api.github.com/users/lox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lox/subscriptions","organizations_url":"https://api.github.com/users/lox/orgs","repos_url":"https://api.github.com/users/lox/repos","events_url":"https://api.github.com/users/lox/events{/privacy}","received_events_url":"https://api.github.com/users/lox/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":5,"additions":31,"deletions":18,"changed_files":2}}