{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/5207","repository_url":"https://api.github.com/repos/hashicorp/terraform","labels_url":"https://api.github.com/repos/hashicorp/terraform/issues/5207/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/5207/comments","events_url":"https://api.github.com/repos/hashicorp/terraform/issues/5207/events","html_url":"https://github.com/hashicorp/terraform/pull/5207","id":134736031,"number":5207,"title":"[WIP] Better display for set diffs, drop unchanged elements","user":{"login":"Bowbaq","id":618381,"avatar_url":"https://avatars.githubusercontent.com/u/618381?v=3","gravatar_id":"","url":"https://api.github.com/users/Bowbaq","html_url":"https://github.com/Bowbaq","followers_url":"https://api.github.com/users/Bowbaq/followers","following_url":"https://api.github.com/users/Bowbaq/following{/other_user}","gists_url":"https://api.github.com/users/Bowbaq/gists{/gist_id}","starred_url":"https://api.github.com/users/Bowbaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bowbaq/subscriptions","organizations_url":"https://api.github.com/users/Bowbaq/orgs","repos_url":"https://api.github.com/users/Bowbaq/repos","events_url":"https://api.github.com/users/Bowbaq/events{/privacy}","received_events_url":"https://api.github.com/users/Bowbaq/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hashicorp/terraform/labels/core","name":"core","color":"cccccc"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/enhancement","name":"enhancement","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-19T00:14:05Z","updated_at":"2016-05-26T18:45:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/5207","html_url":"https://github.com/hashicorp/terraform/pull/5207","diff_url":"https://github.com/hashicorp/terraform/pull/5207.diff","patch_url":"https://github.com/hashicorp/terraform/pull/5207.patch"},"body":"@apparentlymart @phinze initial crack at the problem for #5179"},"comment":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/comments/221959360","html_url":"https://github.com/hashicorp/terraform/pull/5207#issuecomment-221959360","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/5207","id":221959360,"user":{"login":"apparentlymart","id":20180,"avatar_url":"https://avatars.githubusercontent.com/u/20180?v=3","gravatar_id":"","url":"https://api.github.com/users/apparentlymart","html_url":"https://github.com/apparentlymart","followers_url":"https://api.github.com/users/apparentlymart/followers","following_url":"https://api.github.com/users/apparentlymart/following{/other_user}","gists_url":"https://api.github.com/users/apparentlymart/gists{/gist_id}","starred_url":"https://api.github.com/users/apparentlymart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apparentlymart/subscriptions","organizations_url":"https://api.github.com/users/apparentlymart/orgs","repos_url":"https://api.github.com/users/apparentlymart/repos","events_url":"https://api.github.com/users/apparentlymart/events{/privacy}","received_events_url":"https://api.github.com/users/apparentlymart/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T18:45:32Z","updated_at":"2016-05-26T18:45:32Z","body":"Hi @Bowbaq! Thanks for posting this and sorry I took so long to get back to you about it.\r\n\r\nI tried to test this but couldn't figure out what sort of change I'd need to make to see the effect of this change.\r\n\r\nWould you mind posting the configuration you were using to test this change along with what output you saw when you ran `terraform plan` with that configuration? That'll help me understand the intent of this change.\r\n\r\nSo far I tried to test with an `aws_security_group`'s `ingress` set, but I couldn't see a difference compared to how it used to behave:\r\n\r\n```hcl\r\nresource \"aws_security_group\" \"foo\" {\r\n  name = \"matkins-baz-test\"\r\n  description = \"testing\"\r\n\r\n  ingress {\r\n    from_port = 22\r\n    to_port = 22\r\n    protocol = \"tcp\"\r\n    cidr_blocks = [\"0.0.0.0/0\"]\r\n  }\r\n  ingress {\r\n    from_port = 80\r\n    to_port = 80\r\n    protocol = \"tcp\"\r\n    cidr_blocks = [\"0.0.0.0/0\"]\r\n  }\r\n}\r\n```\r\n\r\nI created the above and then changed the `to_port` in the first block to `23`. This is what the plan looked like:\r\n\r\n```\r\n~ aws_security_group.foo\r\n    ingress.2152932494.cidr_blocks.#:     \"0\" => \"1\"\r\n    ingress.2152932494.cidr_blocks.0:     \"\" => \"0.0.0.0/0\"\r\n    ingress.2152932494.from_port:         \"\" => \"22\"\r\n    ingress.2152932494.protocol:          \"\" => \"tcp\"\r\n    ingress.2152932494.self:              \"\" => \"false\"\r\n    ingress.2152932494.to_port:           \"\" => \"23\"\r\n    ingress.2541437006.cidr_blocks.#:     \"1\" => \"0\"\r\n    ingress.2541437006.cidr_blocks.0:     \"0.0.0.0/0\" => \"\"\r\n    ingress.2541437006.from_port:         \"22\" => \"0\"\r\n    ingress.2541437006.protocol:          \"tcp\" => \"\"\r\n    ingress.2541437006.self:              \"false\" => \"false\"\r\n    ingress.2541437006.to_port:           \"22\" => \"0\"\r\n```\r\n\r\nAm I doing something wrong here, or am I just misunderstanding your goal?\r\n\r\n"}}
{"actor":{"display_login":"apparentlymart"}}