{"action":"created","issue":{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/257","repository_url":"https://api.github.com/repos/hydrogen-music/hydrogen","labels_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/257/comments","events_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/257/events","html_url":"https://github.com/hydrogen-music/hydrogen/issues/257","id":77501736,"number":257,"title":"Pattern display showing incorrect number of bars / beats","user":{"login":"Peregrino69","id":10165090,"avatar_url":"https://avatars.githubusercontent.com/u/10165090?v=3","gravatar_id":"","url":"https://api.github.com/users/Peregrino69","html_url":"https://github.com/Peregrino69","followers_url":"https://api.github.com/users/Peregrino69/followers","following_url":"https://api.github.com/users/Peregrino69/following{/other_user}","gists_url":"https://api.github.com/users/Peregrino69/gists{/gist_id}","starred_url":"https://api.github.com/users/Peregrino69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peregrino69/subscriptions","organizations_url":"https://api.github.com/users/Peregrino69/orgs","repos_url":"https://api.github.com/users/Peregrino69/repos","events_url":"https://api.github.com/users/Peregrino69/events{/privacy}","received_events_url":"https://api.github.com/users/Peregrino69/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/labels/severity%201","name":"severity 1","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/milestones/2","html_url":"https://github.com/hydrogen-music/hydrogen/milestones/0.9.7","labels_url":"https://api.github.com/repos/hydrogen-music/hydrogen/milestones/2/labels","id":105681,"number":2,"title":"0.9.7","description":"","creator":{"login":"mauser","id":202461,"avatar_url":"https://avatars.githubusercontent.com/u/202461?v=3","gravatar_id":"","url":"https://api.github.com/users/mauser","html_url":"https://github.com/mauser","followers_url":"https://api.github.com/users/mauser/followers","following_url":"https://api.github.com/users/mauser/following{/other_user}","gists_url":"https://api.github.com/users/mauser/gists{/gist_id}","starred_url":"https://api.github.com/users/mauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauser/subscriptions","organizations_url":"https://api.github.com/users/mauser/orgs","repos_url":"https://api.github.com/users/mauser/repos","events_url":"https://api.github.com/users/mauser/events{/privacy}","received_events_url":"https://api.github.com/users/mauser/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":60,"state":"open","created_at":"2012-04-09T08:27:51Z","updated_at":"2016-09-05T19:17:42Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2015-05-18T04:59:00Z","updated_at":"2016-09-20T00:41:37Z","closed_at":null,"body":"When I create a new pattern with size 4 and resolution 16 I get 2 bars with 4 beats each:\r\n![hydrogen_wrong](https://cloud.githubusercontent.com/assets/10165090/7670116/a185bfbc-fc97-11e4-9e81-8d6ccdaea8d8.png)\r\n\r\nWhat I expect to see is a pattern of 4 bars with 16 beats each:\r\n![hydrogen_correct](https://cloud.githubusercontent.com/assets/10165090/7670128/72865040-fc98-11e4-8c04-c9b77bbfc725.png)\r\n\r\nSame issue with 0.9.6 on Win 7 and 0.9.5/0.9.6 on Debian Wheezy.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/comments/248169992","html_url":"https://github.com/hydrogen-music/hydrogen/issues/257#issuecomment-248169992","issue_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/257","id":248169992,"user":{"login":"pvint","id":608740,"avatar_url":"https://avatars.githubusercontent.com/u/608740?v=3","gravatar_id":"","url":"https://api.github.com/users/pvint","html_url":"https://github.com/pvint","followers_url":"https://api.github.com/users/pvint/followers","following_url":"https://api.github.com/users/pvint/following{/other_user}","gists_url":"https://api.github.com/users/pvint/gists{/gist_id}","starred_url":"https://api.github.com/users/pvint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvint/subscriptions","organizations_url":"https://api.github.com/users/pvint/orgs","repos_url":"https://api.github.com/users/pvint/repos","events_url":"https://api.github.com/users/pvint/events{/privacy}","received_events_url":"https://api.github.com/users/pvint/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T00:41:37Z","updated_at":"2016-09-20T00:41:37Z","body":"> size would define the number of bars and the resolution would define the number of sub-division of the bar\r\n\r\nThis makes sense to me.\r\n\r\nAs for it \"just being a GUI change\" - I think technically this is true, however having looked at this in the past unless you are simply changing the labels on the GUI, it would be quite a substantial change. It has been a few months since I looked at this, but when I was looking at changing this I found that any change is likely going to require making many changes in different parts of the code. \r\n\r\nI think @Shaac expressed it well above, in that we need to define clearly what is *desired* for this, and to do that we should take a good look at how other applications handle this. If there is a standard, we should go with that, IMO. If they are all different, we need to decide on a system that makes sense for Hydrogen and its users. \r\n\r\nThis conversation has been going on for quite some time now, and one thing is jumping out at me: Nobody seems to understand why it is set up the way it is currently (or at least nobody has spoken up about it). I feel this is confusing for new and old users alike, and I would love to see this done. Winter is coming soon here, which gives me more free time for projects, so I may be able to take this, however we need a clear definition of what we want. as @thijz said above, this should not impact previous songs.\r\n\r\nSide note (trying to stay on topic!): @Peregrino69  The beat counter showing 3/4 or 4/4 etc is a great idea, and while it is related that likely should be handled in a separate request to keep things straight. (read: My suggestion is to make that request! :) )\r\n\r\nPaul"}}
{"actor":{"display_login":"pvint"}}