{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/jointcal/pulls/comments/89230215","pull_request_review_id":9778028,"id":89230215,"diff_hunk":"@@ -537,127 +536,127 @@ void Associations::CollectMCStars(int realization)\n //\n //      MeasuredStarIterator msII;\n //      for(msII=catalog.begin();msII!=catalog.end();msII++)\n-//      \t{\n-//      \t  MeasuredStar& ms = **msII;\n-//      \t  cout << \" *** >>> \"\n-//      \t       << ms.GetMCMeas() << \" \"\n-//      \t       << ms.GetMCTruth() << endl;\n-//      \t}\n+//          {\n+//            MeasuredStar& ms = **msII;\n+//            cout << \" *** >>> \"\n+//                 << ms.GetMCMeas() << \" \"\n+//                 << ms.GetMCTruth() << endl;\n+//          }\n //    }\n //}\n \n \n static double getflux(DicStar const& ds, string const& tag)\n {\n-  double rflux = ds.getval(tag);\n-  if(rflux<=0.) return -1.;\n-  return 1.E10 * pow(10., -0.4*rflux);\n+    double rflux = ds.getval(tag);\n+    if (rflux <= 0.) return -1.;\n+    return 1.E10 * pow(10., -0.4 * rflux);\n }\n \n void Associations::CollectPhotometricRefStars(string const& catalogname)\n {\n-  cout << \"[Associations::CollectPhotometricRefStars()] ... \";\n-  photRefStarList.clear();\n+    cout << \"[Associations::CollectPhotometricRefStars()] ... \";\n+    photRefStarList.clear();\n \n-  DicStarList dsl(catalogname);\n-  DicStarIterator I;\n+    DicStarList dsl(catalogname);\n+    DicStarIterator I;\n \n-  double rflux;\n-  vector<double> refflux;\n-  refflux.resize(10);\n+    double rflux;\n+    vector<double> refflux;\n+    refflux.resize(10);\n \n-  for(I=dsl.begin();I!=dsl.end();I++)\n+    for (I = dsl.begin(); I != dsl.end(); I++)\n     {\n-      DicStar& ds = **I;\n+        DicStar& ds = **I;\n \n-      // I am here (debugging the star positions)\n-      //       cout << \"[DEBUG] x,y=\"\n-      // \t   << ds.x << \" \" << ds.y\n-      // \t   << endl;\n+        // I am here (debugging the star positions)\n+        //       cout << \"[DEBUG] x,y=\"\n+        //       << ds.x << \" \" << ds.y\n+        //       << endl;\n \n-      refflux[0] = getflux(ds, \"mu\");\n-      refflux[1] = getflux(ds, \"mg\");\n-      refflux[2] = getflux(ds, \"mr\");\n-      refflux[3] = getflux(ds, \"mi\");\n-      refflux[4] = getflux(ds, \"mz\");\n+        refflux[0] = getflux(ds, \"mu\");\n+        refflux[1] = getflux(ds, \"mg\");\n+        refflux[2] = getflux(ds, \"mr\");\n+        refflux[3] = getflux(ds, \"mi\");\n+        refflux[4] = getflux(ds, \"mz\");\n \n-      refflux[5] = getflux(ds, \"U\");\n-      refflux[6] = getflux(ds, \"B\");\n-      refflux[7] = getflux(ds, \"V\");\n-      refflux[8] = getflux(ds, \"R\");\n-      refflux[9] = getflux(ds, \"I\");\n+        refflux[5] = getflux(ds, \"U\");\n+        refflux[6] = getflux(ds, \"B\");\n+        refflux[7] = getflux(ds, \"V\");\n+        refflux[8] = getflux(ds, \"R\");\n+        refflux[9] = getflux(ds, \"I\");\n \n-      RefStar* rs = new RefStar(ds, ds);\n-      rs->AssignRefFluxes(refflux);\n+        RefStar* rs = new RefStar(ds, ds);\n+        rs->AssignRefFluxes(refflux);\n \n-      unsigned int index = (unsigned int)ds.getval(\"index\");\n-      rs->Index() = index;\n+        unsigned int index = (unsigned int)ds.getval(\"index\");\n+        rs->Index() = index;\n \n-      photRefStarList.push_back(rs);\n+        photRefStarList.push_back(rs);\n     }\n \n-  cout << photRefStarList.size() << \" stars read\" << endl;\n+    cout << photRefStarList.size() << \" stars read\" << endl;\n \n-  // Now, If I understand well, all the FittedStar coordinates\n-  // are in CTP coordinates ==> we have to transform our\n-  // (RA,DEC) coordinates into CTP coords...\n-  GtransfoLin identity;\n-  TanRaDec2Pix RaDec2CTP(identity, commonTangentPoint);\n-  photRefStarList.ApplyTransfo(RaDec2CTP);\n+    // Now, If I understand well, all the FittedStar coordinates\n+    // are in CTP coordinates ==> we have to transform our\n+    // (RA,DEC) coordinates into CTP coords...\n+    GtransfoLin identity;\n+    TanRaDec2Pix RaDec2CTP(identity, commonTangentPoint);\n+    photRefStarList.ApplyTransfo(RaDec2CTP);\n \n-  cout << \"[DEBUG DEBUB DEBUG]\" << endl;\n-  RaDec2CTP.dump(cout);\n-  cout << \"[DEBUG DEBUB DEBUG]\" << endl;\n+    cout << \"[DEBUG DEBUB DEBUG]\" << endl;\n+    RaDec2CTP.dump(cout);\n+    cout << \"[DEBUG DEBUB DEBUG]\" << endl;\n }\n \n \n void Associations::AssociatePhotometricRefStars(double MatchCutInArcSec)\n {\n-  cout << \"[Associations::AssociatePhotometricRefStars]\" << endl;\n-  cout << \"[DEBUG]  -> nb fs=\" << fittedStarList.size()\n-       << \" nb refstars=\"  << photRefStarList.size() << endl;\n+    cout << \"[Associations::AssociatePhotometricRefStars]\" << endl;\n+    cout << \"[DEBUG]  -> nb fs=\" << fittedStarList.size()\n+         << \" nb refstars=\"  << photRefStarList.size() << endl;\n \n-  // clear previous associations\n-  RefStarIterator I;\n-  for(I=photRefStarList.begin();I!=photRefStarList.end();I++)\n+    // clear previous associations\n+    RefStarIterator I;\n+    for (I = photRefStarList.begin(); I != photRefStarList.end(); I++)\n     {\n-      (*I)->SetFittedStar( *(FittedStar*)NULL ); // mais c'est horrible (!)\n-      //      cout << \" XTP,YTP=\" << (*I)->x << \" \" << (*I)->y << endl;\n+        (*I)->SetFittedStar( *(FittedStar*)NULL ); // mais c'est horrible (!)\n+        //      cout << \" XTP,YTP=\" << (*I)->x << \" \" << (*I)->y << endl;\n     }\n \n-  GtransfoIdentity gtransfoIdentity;\n-  StarMatchList* smList = ListMatchCollect(Ref2Base(photRefStarList),\n-\t\t\t\t\t   Fitted2Base(fittedStarList),\n-\t\t\t\t\t   &gtransfoIdentity,\n-\t\t\t\t\t   MatchCutInArcSec/3600.);\n+    GtransfoIdentity gtransfoIdentity;\n+    StarMatchList* smList = ListMatchCollect(Ref2Base(photRefStarList),\n+                            Fitted2Base(fittedStarList),\n+                            &gtransfoIdentity,\n+                            MatchCutInArcSec / 3600.);","path":"src/Associations.cc","position":1018,"original_position":1018,"commit_id":"5149ff9070a12a2a1bad6aa56dfce2f94b785792","original_commit_id":"5149ff9070a12a2a1bad6aa56dfce2f94b785792","user":{"login":"parejkoj","id":1606089,"avatar_url":"https://avatars.githubusercontent.com/u/1606089?v=3","gravatar_id":"","url":"https://api.github.com/users/parejkoj","html_url":"https://github.com/parejkoj","followers_url":"https://api.github.com/users/parejkoj/followers","following_url":"https://api.github.com/users/parejkoj/following{/other_user}","gists_url":"https://api.github.com/users/parejkoj/gists{/gist_id}","starred_url":"https://api.github.com/users/parejkoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parejkoj/subscriptions","organizations_url":"https://api.github.com/users/parejkoj/orgs","repos_url":"https://api.github.com/users/parejkoj/repos","events_url":"https://api.github.com/users/parejkoj/events{/privacy}","received_events_url":"https://api.github.com/users/parejkoj/received_events","type":"User","site_admin":false},"body":"Ticket filed: https://jira.lsstcorp.org/browse/DM-8369","created_at":"2016-11-22T23:07:49Z","updated_at":"2016-11-22T23:07:49Z","html_url":"https://github.com/lsst/jointcal/pull/17#discussion_r89230215","pull_request_url":"https://api.github.com/repos/lsst/jointcal/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/comments/89230215"},"html":{"href":"https://github.com/lsst/jointcal/pull/17#discussion_r89230215"},"pull_request":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/jointcal/pulls/17","id":89908555,"html_url":"https://github.com/lsst/jointcal/pull/17","diff_url":"https://github.com/lsst/jointcal/pull/17.diff","patch_url":"https://github.com/lsst/jointcal/pull/17.patch","issue_url":"https://api.github.com/repos/lsst/jointcal/issues/17","number":17,"state":"open","locked":false,"title":"Updates to use visitInfo Tickets/dm 6625","user":{"login":"parejkoj","id":1606089,"avatar_url":"https://avatars.githubusercontent.com/u/1606089?v=3","gravatar_id":"","url":"https://api.github.com/users/parejkoj","html_url":"https://github.com/parejkoj","followers_url":"https://api.github.com/users/parejkoj/followers","following_url":"https://api.github.com/users/parejkoj/following{/other_user}","gists_url":"https://api.github.com/users/parejkoj/gists{/gist_id}","starred_url":"https://api.github.com/users/parejkoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parejkoj/subscriptions","organizations_url":"https://api.github.com/users/parejkoj/orgs","repos_url":"https://api.github.com/users/parejkoj/repos","events_url":"https://api.github.com/users/parejkoj/events{/privacy}","received_events_url":"https://api.github.com/users/parejkoj/received_events","type":"User","site_admin":false},"body":"Now that DM-5503 is done, it's time to get lsstSim to work without my FakeRef hack (and properly deal with all camera metadata) by using VisitInfo. This PR encompasses all of the work related to that.\n","created_at":"2016-10-18T22:12:29Z","updated_at":"2016-11-22T23:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"352e3f5f2b2b12710fb390e2ff550a87401671b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/jointcal/pulls/17/commits","review_comments_url":"https://api.github.com/repos/lsst/jointcal/pulls/17/comments","review_comment_url":"https://api.github.com/repos/lsst/jointcal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/jointcal/issues/17/comments","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/5149ff9070a12a2a1bad6aa56dfce2f94b785792","head":{"label":"lsst:tickets/DM-6625","ref":"tickets/DM-6625","sha":"5149ff9070a12a2a1bad6aa56dfce2f94b785792","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":52640673,"name":"jointcal","full_name":"lsst/jointcal","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/jointcal","description":"Simultaneous astrometry ","fork":false,"url":"https://api.github.com/repos/lsst/jointcal","forks_url":"https://api.github.com/repos/lsst/jointcal/forks","keys_url":"https://api.github.com/repos/lsst/jointcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/jointcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/jointcal/teams","hooks_url":"https://api.github.com/repos/lsst/jointcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/jointcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/jointcal/events","assignees_url":"https://api.github.com/repos/lsst/jointcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/jointcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/jointcal/tags","blobs_url":"https://api.github.com/repos/lsst/jointcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/jointcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/jointcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/jointcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/jointcal/languages","stargazers_url":"https://api.github.com/repos/lsst/jointcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/jointcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/jointcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/jointcal/subscription","commits_url":"https://api.github.com/repos/lsst/jointcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/jointcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/jointcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/jointcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/jointcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/jointcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/jointcal/merges","archive_url":"https://api.github.com/repos/lsst/jointcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/jointcal/downloads","issues_url":"https://api.github.com/repos/lsst/jointcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/jointcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/jointcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/jointcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/jointcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/jointcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/jointcal/deployments","created_at":"2016-02-26T23:56:59Z","updated_at":"2016-11-03T20:46:06Z","pushed_at":"2016-11-21T23:37:00Z","git_url":"git://github.com/lsst/jointcal.git","ssh_url":"git@github.com:lsst/jointcal.git","clone_url":"https://github.com/lsst/jointcal.git","svn_url":"https://github.com/lsst/jointcal","homepage":null,"size":1806,"stargazers_count":1,"watchers_count":1,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"6c69b1e945531236df60e2b90f771d3fb6c36efc","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":52640673,"name":"jointcal","full_name":"lsst/jointcal","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/jointcal","description":"Simultaneous astrometry ","fork":false,"url":"https://api.github.com/repos/lsst/jointcal","forks_url":"https://api.github.com/repos/lsst/jointcal/forks","keys_url":"https://api.github.com/repos/lsst/jointcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/jointcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/jointcal/teams","hooks_url":"https://api.github.com/repos/lsst/jointcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/jointcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/jointcal/events","assignees_url":"https://api.github.com/repos/lsst/jointcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/jointcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/jointcal/tags","blobs_url":"https://api.github.com/repos/lsst/jointcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/jointcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/jointcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/jointcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/jointcal/languages","stargazers_url":"https://api.github.com/repos/lsst/jointcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/jointcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/jointcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/jointcal/subscription","commits_url":"https://api.github.com/repos/lsst/jointcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/jointcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/jointcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/jointcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/jointcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/jointcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/jointcal/merges","archive_url":"https://api.github.com/repos/lsst/jointcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/jointcal/downloads","issues_url":"https://api.github.com/repos/lsst/jointcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/jointcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/jointcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/jointcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/jointcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/jointcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/jointcal/deployments","created_at":"2016-02-26T23:56:59Z","updated_at":"2016-11-03T20:46:06Z","pushed_at":"2016-11-21T23:37:00Z","git_url":"git://github.com/lsst/jointcal.git","ssh_url":"git@github.com:lsst/jointcal.git","clone_url":"https://github.com/lsst/jointcal.git","svn_url":"https://github.com/lsst/jointcal","homepage":null,"size":1806,"stargazers_count":1,"watchers_count":1,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/17"},"html":{"href":"https://github.com/lsst/jointcal/pull/17"},"issue":{"href":"https://api.github.com/repos/lsst/jointcal/issues/17"},"comments":{"href":"https://api.github.com/repos/lsst/jointcal/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/jointcal/statuses/5149ff9070a12a2a1bad6aa56dfce2f94b785792"}}}}
{"actor":{"display_login":"parejkoj"}}