{"action":"created","issue":{"url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/336","repository_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor","labels_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/336/labels{/name}","comments_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/336/comments","events_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/336/events","html_url":"https://github.com/divio/djangocms-text-ckeditor/issues/336","id":165944027,"number":336,"title":"sanitizer import error due to changes in html5lib","user":{"login":"saeed-222","id":17946171,"avatar_url":"https://avatars.githubusercontent.com/u/17946171?v=3","gravatar_id":"","url":"https://api.github.com/users/saeed-222","html_url":"https://github.com/saeed-222","followers_url":"https://api.github.com/users/saeed-222/followers","following_url":"https://api.github.com/users/saeed-222/following{/other_user}","gists_url":"https://api.github.com/users/saeed-222/gists{/gist_id}","starred_url":"https://api.github.com/users/saeed-222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeed-222/subscriptions","organizations_url":"https://api.github.com/users/saeed-222/orgs","repos_url":"https://api.github.com/users/saeed-222/repos","events_url":"https://api.github.com/users/saeed-222/events{/privacy}","received_events_url":"https://api.github.com/users/saeed-222/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-16T19:31:13Z","updated_at":"2016-09-30T15:22:04Z","closed_at":"2016-07-16T20:27:55Z","body":"I get the following import error when using djangocms-text-ckeditor with html5lib 0.999999999 installed. Please not that I did not specified any specific version for html5lib and it has been installed by default.\r\n```\r\n File \"....../lib/python3.4/site-packages/djangocms_text_ckeditor/models.py\", line 13, in <module>\r\n    from .html import clean_html, extract_images\r\n  File \"...../lib/python3.4/site-packages/djangocms_text_ckeditor/html.py\", line 8, in <module>\r\n\r\n    from html5lib import sanitizer, serializer, treebuilders, treewalkers\r\nImportError: cannot import name 'sanitizer'\r\n```\r\n\r\nSee also release notes for html5lib Released on July 14, 2016: [https://pypi.python.org/pypi/html5lib](https://pypi.python.org/pypi/html5lib)"},"comment":{"url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/comments/250773058","html_url":"https://github.com/divio/djangocms-text-ckeditor/issues/336#issuecomment-250773058","issue_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/336","id":250773058,"user":{"login":"Chronial","id":1321505,"avatar_url":"https://avatars.githubusercontent.com/u/1321505?v=3","gravatar_id":"","url":"https://api.github.com/users/Chronial","html_url":"https://github.com/Chronial","followers_url":"https://api.github.com/users/Chronial/followers","following_url":"https://api.github.com/users/Chronial/following{/other_user}","gists_url":"https://api.github.com/users/Chronial/gists{/gist_id}","starred_url":"https://api.github.com/users/Chronial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chronial/subscriptions","organizations_url":"https://api.github.com/users/Chronial/orgs","repos_url":"https://api.github.com/users/Chronial/repos","events_url":"https://api.github.com/users/Chronial/events{/privacy}","received_events_url":"https://api.github.com/users/Chronial/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T15:22:04Z","updated_at":"2016-09-30T15:22:04Z","body":"> We would really appreciate if someone has the time to contribute a backwards compatible patch that adds compatibility with the latest html5lib.\r\n\r\nIs it essential that it is backwards compatible? This adds a lot of complexity and the old implementation seems dangerous anyways, since it modifies global settings of html5lib: https://github.com/divio/djangocms-text-ckeditor/blob/6e0b6c2fb48984ee579cc3ca672b5064af1bf10d/djangocms_text_ckeditor/html.py#L23"}}
{"actor":{"display_login":"Chronial"}}