{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/74623113","id":74623113,"diff_hunk":"@@ -0,0 +1,68 @@\n+import validateHeaders from '../validate_headers';\n+import expect from 'expect.js';\n+\n+describe('validateHeaders', function () {\n+\n+  describe('simple validations', function () {\n+\n+    it('should return empty array if fields are valid', function () {\n+      var errors = validateHeaders(['aa', 'bb', 'cc', 'dd', 'ee']);","path":"src/core_plugins/kibana/public/management/sections/indices/add_data_steps/parse_csv_step/lib/__tests__/validate_headers.js","position":9,"original_position":9,"commit_id":"c5cb8d10672b3b3eb6d70a3b8ce7c4c165d45335","original_commit_id":"c5cb8d10672b3b3eb6d70a3b8ce7c4c165d45335","user":{"login":"Bargs","id":6239176,"avatar_url":"https://avatars.githubusercontent.com/u/6239176?v=3","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false},"body":"Use `const` here, and if you need mutability prefer `let` over `var`","created_at":"2016-08-12T16:49:52Z","updated_at":"2016-08-12T16:49:52Z","html_url":"https://github.com/elastic/kibana/pull/7950#discussion_r74623113","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/7950","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/74623113"},"html":{"href":"https://github.com/elastic/kibana/pull/7950#discussion_r74623113"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/7950"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/7950","id":80350733,"html_url":"https://github.com/elastic/kibana/pull/7950","diff_url":"https://github.com/elastic/kibana/pull/7950.diff","patch_url":"https://github.com/elastic/kibana/pull/7950.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/7950","number":7950,"state":"open","locked":false,"title":"Fix #7722 Improved header validation on CSV import","user":{"login":"ck-lee","id":5370495,"avatar_url":"https://avatars.githubusercontent.com/u/5370495?v=3","gravatar_id":"","url":"https://api.github.com/users/ck-lee","html_url":"https://github.com/ck-lee","followers_url":"https://api.github.com/users/ck-lee/followers","following_url":"https://api.github.com/users/ck-lee/following{/other_user}","gists_url":"https://api.github.com/users/ck-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/ck-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ck-lee/subscriptions","organizations_url":"https://api.github.com/users/ck-lee/orgs","repos_url":"https://api.github.com/users/ck-lee/repos","events_url":"https://api.github.com/users/ck-lee/events{/privacy}","received_events_url":"https://api.github.com/users/ck-lee/received_events","type":"User","site_admin":false},"body":"- Fix #7722 \r\n- Added positions and column name when CSV errors on duplicate header name\r\n- Added positions of columns when CSV errors on blank header name\r\n\r\n","created_at":"2016-08-06T21:04:24Z","updated_at":"2016-08-12T16:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ee22654a2557b098aebc1fa327e057ab6eef3df","assignee":{"login":"Bargs","id":6239176,"avatar_url":"https://avatars.githubusercontent.com/u/6239176?v=3","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false},"assignees":[{"login":"Bargs","id":6239176,"avatar_url":"https://avatars.githubusercontent.com/u/6239176?v=3","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/7950/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/7950/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/7950/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/c5cb8d10672b3b3eb6d70a3b8ce7c4c165d45335","head":{"label":"ck-lee:better-csv-import-errors-messages","ref":"better-csv-import-errors-messages","sha":"c5cb8d10672b3b3eb6d70a3b8ce7c4c165d45335","user":{"login":"ck-lee","id":5370495,"avatar_url":"https://avatars.githubusercontent.com/u/5370495?v=3","gravatar_id":"","url":"https://api.github.com/users/ck-lee","html_url":"https://github.com/ck-lee","followers_url":"https://api.github.com/users/ck-lee/followers","following_url":"https://api.github.com/users/ck-lee/following{/other_user}","gists_url":"https://api.github.com/users/ck-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/ck-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ck-lee/subscriptions","organizations_url":"https://api.github.com/users/ck-lee/orgs","repos_url":"https://api.github.com/users/ck-lee/repos","events_url":"https://api.github.com/users/ck-lee/events{/privacy}","received_events_url":"https://api.github.com/users/ck-lee/received_events","type":"User","site_admin":false},"repo":{"id":64571922,"name":"kibana","full_name":"ck-lee/kibana","owner":{"login":"ck-lee","id":5370495,"avatar_url":"https://avatars.githubusercontent.com/u/5370495?v=3","gravatar_id":"","url":"https://api.github.com/users/ck-lee","html_url":"https://github.com/ck-lee","followers_url":"https://api.github.com/users/ck-lee/followers","following_url":"https://api.github.com/users/ck-lee/following{/other_user}","gists_url":"https://api.github.com/users/ck-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/ck-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ck-lee/subscriptions","organizations_url":"https://api.github.com/users/ck-lee/orgs","repos_url":"https://api.github.com/users/ck-lee/repos","events_url":"https://api.github.com/users/ck-lee/events{/privacy}","received_events_url":"https://api.github.com/users/ck-lee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ck-lee/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/ck-lee/kibana","forks_url":"https://api.github.com/repos/ck-lee/kibana/forks","keys_url":"https://api.github.com/repos/ck-lee/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ck-lee/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ck-lee/kibana/teams","hooks_url":"https://api.github.com/repos/ck-lee/kibana/hooks","issue_events_url":"https://api.github.com/repos/ck-lee/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/ck-lee/kibana/events","assignees_url":"https://api.github.com/repos/ck-lee/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/ck-lee/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/ck-lee/kibana/tags","blobs_url":"https://api.github.com/repos/ck-lee/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ck-lee/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ck-lee/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/ck-lee/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ck-lee/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/ck-lee/kibana/languages","stargazers_url":"https://api.github.com/repos/ck-lee/kibana/stargazers","contributors_url":"https://api.github.com/repos/ck-lee/kibana/contributors","subscribers_url":"https://api.github.com/repos/ck-lee/kibana/subscribers","subscription_url":"https://api.github.com/repos/ck-lee/kibana/subscription","commits_url":"https://api.github.com/repos/ck-lee/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/ck-lee/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/ck-lee/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/ck-lee/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/ck-lee/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/ck-lee/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ck-lee/kibana/merges","archive_url":"https://api.github.com/repos/ck-lee/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ck-lee/kibana/downloads","issues_url":"https://api.github.com/repos/ck-lee/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/ck-lee/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/ck-lee/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/ck-lee/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ck-lee/kibana/labels{/name}","releases_url":"https://api.github.com/repos/ck-lee/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/ck-lee/kibana/deployments","created_at":"2016-07-31T01:47:21Z","updated_at":"2016-07-31T01:47:27Z","pushed_at":"2016-08-06T20:46:22Z","git_url":"git://github.com/ck-lee/kibana.git","ssh_url":"git@github.com:ck-lee/kibana.git","clone_url":"https://github.com/ck-lee/kibana.git","svn_url":"https://github.com/ck-lee/kibana","homepage":"https://www.elastic.co/products/kibana","size":182577,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"13bdc523a576be33e90648b18e08401c161555d1","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2016-08-12T16:35:22Z","pushed_at":"2016-08-12T16:48:14Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":235270,"stargazers_count":5805,"watchers_count":5805,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2130,"mirror_url":null,"open_issues_count":1150,"forks":2130,"open_issues":1150,"watchers":5805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/7950"},"html":{"href":"https://github.com/elastic/kibana/pull/7950"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/7950"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/7950/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/7950/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/7950/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/c5cb8d10672b3b3eb6d70a3b8ce7c4c165d45335"}}}}
{"actor":{"display_login":"Bargs"}}