{"action":"opened","number":184,"pull_request":{"url":"https://api.github.com/repos/opentoonz/opentoonz/pulls/184","id":66690410,"html_url":"https://github.com/opentoonz/opentoonz/pull/184","diff_url":"https://github.com/opentoonz/opentoonz/pull/184.diff","patch_url":"https://github.com/opentoonz/opentoonz/pull/184.patch","issue_url":"https://api.github.com/repos/opentoonz/opentoonz/issues/184","number":184,"state":"open","locked":false,"title":"Remove license and edition defines and code","user":{"login":"ss23","id":191510,"avatar_url":"https://avatars.githubusercontent.com/u/191510?v=3","gravatar_id":"","url":"https://api.github.com/users/ss23","html_url":"https://github.com/ss23","followers_url":"https://api.github.com/users/ss23/followers","following_url":"https://api.github.com/users/ss23/following{/other_user}","gists_url":"https://api.github.com/users/ss23/gists{/gist_id}","starred_url":"https://api.github.com/users/ss23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ss23/subscriptions","organizations_url":"https://api.github.com/users/ss23/orgs","repos_url":"https://api.github.com/users/ss23/repos","events_url":"https://api.github.com/users/ss23/events{/privacy}","received_events_url":"https://api.github.com/users/ss23/received_events","type":"User","site_admin":false},"body":"Previously, old code to support various editions of Toonz, as well as license activation code, was cluttering the repository.\r\n\r\nI'm not in a good position to determine whether this way of doing it is correct. While most of the code seems to *exclude* features based on the edition, there are a few places with different/new code relevant to only a specific version.\r\nThat being said, given these features are already disabled in the current opentoonz release, it won't be missed.\r\n\r\nI've checked compilation and running on Windows only.","created_at":"2016-04-15T19:10:18Z","updated_at":"2016-04-15T19:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentoonz/opentoonz/pulls/184/commits","review_comments_url":"https://api.github.com/repos/opentoonz/opentoonz/pulls/184/comments","review_comment_url":"https://api.github.com/repos/opentoonz/opentoonz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentoonz/opentoonz/issues/184/comments","statuses_url":"https://api.github.com/repos/opentoonz/opentoonz/statuses/82e47b3fe435076fd3a097302741f031dc3e452f","head":{"label":"ss23:remove_license","ref":"remove_license","sha":"82e47b3fe435076fd3a097302741f031dc3e452f","user":{"login":"ss23","id":191510,"avatar_url":"https://avatars.githubusercontent.com/u/191510?v=3","gravatar_id":"","url":"https://api.github.com/users/ss23","html_url":"https://github.com/ss23","followers_url":"https://api.github.com/users/ss23/followers","following_url":"https://api.github.com/users/ss23/following{/other_user}","gists_url":"https://api.github.com/users/ss23/gists{/gist_id}","starred_url":"https://api.github.com/users/ss23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ss23/subscriptions","organizations_url":"https://api.github.com/users/ss23/orgs","repos_url":"https://api.github.com/users/ss23/repos","events_url":"https://api.github.com/users/ss23/events{/privacy}","received_events_url":"https://api.github.com/users/ss23/received_events","type":"User","site_admin":false},"repo":{"id":56256630,"name":"opentoonz","full_name":"ss23/opentoonz","owner":{"login":"ss23","id":191510,"avatar_url":"https://avatars.githubusercontent.com/u/191510?v=3","gravatar_id":"","url":"https://api.github.com/users/ss23","html_url":"https://github.com/ss23","followers_url":"https://api.github.com/users/ss23/followers","following_url":"https://api.github.com/users/ss23/following{/other_user}","gists_url":"https://api.github.com/users/ss23/gists{/gist_id}","starred_url":"https://api.github.com/users/ss23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ss23/subscriptions","organizations_url":"https://api.github.com/users/ss23/orgs","repos_url":"https://api.github.com/users/ss23/repos","events_url":"https://api.github.com/users/ss23/events{/privacy}","received_events_url":"https://api.github.com/users/ss23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ss23/opentoonz","description":"OpenToonz - An open-source full-featured 2D animation creation software","fork":true,"url":"https://api.github.com/repos/ss23/opentoonz","forks_url":"https://api.github.com/repos/ss23/opentoonz/forks","keys_url":"https://api.github.com/repos/ss23/opentoonz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ss23/opentoonz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ss23/opentoonz/teams","hooks_url":"https://api.github.com/repos/ss23/opentoonz/hooks","issue_events_url":"https://api.github.com/repos/ss23/opentoonz/issues/events{/number}","events_url":"https://api.github.com/repos/ss23/opentoonz/events","assignees_url":"https://api.github.com/repos/ss23/opentoonz/assignees{/user}","branches_url":"https://api.github.com/repos/ss23/opentoonz/branches{/branch}","tags_url":"https://api.github.com/repos/ss23/opentoonz/tags","blobs_url":"https://api.github.com/repos/ss23/opentoonz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ss23/opentoonz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ss23/opentoonz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ss23/opentoonz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ss23/opentoonz/statuses/{sha}","languages_url":"https://api.github.com/repos/ss23/opentoonz/languages","stargazers_url":"https://api.github.com/repos/ss23/opentoonz/stargazers","contributors_url":"https://api.github.com/repos/ss23/opentoonz/contributors","subscribers_url":"https://api.github.com/repos/ss23/opentoonz/subscribers","subscription_url":"https://api.github.com/repos/ss23/opentoonz/subscription","commits_url":"https://api.github.com/repos/ss23/opentoonz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ss23/opentoonz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ss23/opentoonz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ss23/opentoonz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ss23/opentoonz/contents/{+path}","compare_url":"https://api.github.com/repos/ss23/opentoonz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ss23/opentoonz/merges","archive_url":"https://api.github.com/repos/ss23/opentoonz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ss23/opentoonz/downloads","issues_url":"https://api.github.com/repos/ss23/opentoonz/issues{/number}","pulls_url":"https://api.github.com/repos/ss23/opentoonz/pulls{/number}","milestones_url":"https://api.github.com/repos/ss23/opentoonz/milestones{/number}","notifications_url":"https://api.github.com/repos/ss23/opentoonz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ss23/opentoonz/labels{/name}","releases_url":"https://api.github.com/repos/ss23/opentoonz/releases{/id}","deployments_url":"https://api.github.com/repos/ss23/opentoonz/deployments","created_at":"2016-04-14T17:23:11Z","updated_at":"2016-04-14T17:23:18Z","pushed_at":"2016-04-15T18:58:52Z","git_url":"git://github.com/ss23/opentoonz.git","ssh_url":"git@github.com:ss23/opentoonz.git","clone_url":"https://github.com/ss23/opentoonz.git","svn_url":"https://github.com/ss23/opentoonz","homepage":"https://opentoonz.github.io/","size":56230,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentoonz:master","ref":"master","sha":"a09dc1b458777dbe9f1f75c927ed21165657ed2d","user":{"login":"opentoonz","id":15189838,"avatar_url":"https://avatars.githubusercontent.com/u/15189838?v=3","gravatar_id":"","url":"https://api.github.com/users/opentoonz","html_url":"https://github.com/opentoonz","followers_url":"https://api.github.com/users/opentoonz/followers","following_url":"https://api.github.com/users/opentoonz/following{/other_user}","gists_url":"https://api.github.com/users/opentoonz/gists{/gist_id}","starred_url":"https://api.github.com/users/opentoonz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentoonz/subscriptions","organizations_url":"https://api.github.com/users/opentoonz/orgs","repos_url":"https://api.github.com/users/opentoonz/repos","events_url":"https://api.github.com/users/opentoonz/events{/privacy}","received_events_url":"https://api.github.com/users/opentoonz/received_events","type":"Organization","site_admin":false},"repo":{"id":54221232,"name":"opentoonz","full_name":"opentoonz/opentoonz","owner":{"login":"opentoonz","id":15189838,"avatar_url":"https://avatars.githubusercontent.com/u/15189838?v=3","gravatar_id":"","url":"https://api.github.com/users/opentoonz","html_url":"https://github.com/opentoonz","followers_url":"https://api.github.com/users/opentoonz/followers","following_url":"https://api.github.com/users/opentoonz/following{/other_user}","gists_url":"https://api.github.com/users/opentoonz/gists{/gist_id}","starred_url":"https://api.github.com/users/opentoonz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentoonz/subscriptions","organizations_url":"https://api.github.com/users/opentoonz/orgs","repos_url":"https://api.github.com/users/opentoonz/repos","events_url":"https://api.github.com/users/opentoonz/events{/privacy}","received_events_url":"https://api.github.com/users/opentoonz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentoonz/opentoonz","description":"OpenToonz - An open-source full-featured 2D animation creation software","fork":false,"url":"https://api.github.com/repos/opentoonz/opentoonz","forks_url":"https://api.github.com/repos/opentoonz/opentoonz/forks","keys_url":"https://api.github.com/repos/opentoonz/opentoonz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentoonz/opentoonz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentoonz/opentoonz/teams","hooks_url":"https://api.github.com/repos/opentoonz/opentoonz/hooks","issue_events_url":"https://api.github.com/repos/opentoonz/opentoonz/issues/events{/number}","events_url":"https://api.github.com/repos/opentoonz/opentoonz/events","assignees_url":"https://api.github.com/repos/opentoonz/opentoonz/assignees{/user}","branches_url":"https://api.github.com/repos/opentoonz/opentoonz/branches{/branch}","tags_url":"https://api.github.com/repos/opentoonz/opentoonz/tags","blobs_url":"https://api.github.com/repos/opentoonz/opentoonz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentoonz/opentoonz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentoonz/opentoonz/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentoonz/opentoonz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentoonz/opentoonz/statuses/{sha}","languages_url":"https://api.github.com/repos/opentoonz/opentoonz/languages","stargazers_url":"https://api.github.com/repos/opentoonz/opentoonz/stargazers","contributors_url":"https://api.github.com/repos/opentoonz/opentoonz/contributors","subscribers_url":"https://api.github.com/repos/opentoonz/opentoonz/subscribers","subscription_url":"https://api.github.com/repos/opentoonz/opentoonz/subscription","commits_url":"https://api.github.com/repos/opentoonz/opentoonz/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentoonz/opentoonz/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentoonz/opentoonz/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentoonz/opentoonz/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentoonz/opentoonz/contents/{+path}","compare_url":"https://api.github.com/repos/opentoonz/opentoonz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentoonz/opentoonz/merges","archive_url":"https://api.github.com/repos/opentoonz/opentoonz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentoonz/opentoonz/downloads","issues_url":"https://api.github.com/repos/opentoonz/opentoonz/issues{/number}","pulls_url":"https://api.github.com/repos/opentoonz/opentoonz/pulls{/number}","milestones_url":"https://api.github.com/repos/opentoonz/opentoonz/milestones{/number}","notifications_url":"https://api.github.com/repos/opentoonz/opentoonz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentoonz/opentoonz/labels{/name}","releases_url":"https://api.github.com/repos/opentoonz/opentoonz/releases{/id}","deployments_url":"https://api.github.com/repos/opentoonz/opentoonz/deployments","created_at":"2016-03-18T17:55:48Z","updated_at":"2016-04-15T18:38:30Z","pushed_at":"2016-04-15T19:10:19Z","git_url":"git://github.com/opentoonz/opentoonz.git","ssh_url":"git@github.com:opentoonz/opentoonz.git","clone_url":"https://github.com/opentoonz/opentoonz.git","svn_url":"https://github.com/opentoonz/opentoonz","homepage":"https://opentoonz.github.io/","size":56522,"stargazers_count":1217,"watchers_count":1217,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":87,"forks":146,"open_issues":87,"watchers":1217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentoonz/opentoonz/pulls/184"},"html":{"href":"https://github.com/opentoonz/opentoonz/pull/184"},"issue":{"href":"https://api.github.com/repos/opentoonz/opentoonz/issues/184"},"comments":{"href":"https://api.github.com/repos/opentoonz/opentoonz/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/opentoonz/opentoonz/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/opentoonz/opentoonz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentoonz/opentoonz/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/opentoonz/opentoonz/statuses/82e47b3fe435076fd3a097302741f031dc3e452f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":7533,"changed_files":84}}