{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/94088978","pull_request_review_id":14619586,"id":94088978,"diff_hunk":"@@ -1558,7 +1566,13 @@ pub fn parse_crate_types_from_list(list_list: Vec<String>) -> Result<Vec<CrateTy\n                 \"cdylib\"    => CrateTypeCdylib,\n                 \"bin\"       => CrateTypeExecutable,\n                 \"proc-macro\" => CrateTypeProcMacro,\n-                \"metadata\"  => CrateTypeMetadata,\n+                // FIXME(#38640) remove this when Cargo is fixed.","path":"src/librustc/session/config.rs","position":102,"original_position":102,"commit_id":"bc4b42fa37b27f45443d35ecc301f2bc59ae02c2","original_commit_id":"bc4b42fa37b27f45443d35ecc301f2bc59ae02c2","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"Given our discussion today during triage, I think we can remove this entirely","created_at":"2016-12-28T23:37:00Z","updated_at":"2016-12-28T23:37:00Z","html_url":"https://github.com/rust-lang/rust/pull/38571#discussion_r94088978","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/38571","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/94088978"},"html":{"href":"https://github.com/rust-lang/rust/pull/38571#discussion_r94088978"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38571"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/38571","id":99208898,"html_url":"https://github.com/rust-lang/rust/pull/38571","diff_url":"https://github.com/rust-lang/rust/pull/38571.diff","patch_url":"https://github.com/rust-lang/rust/pull/38571.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/38571","number":38571,"state":"open","locked":false,"title":"Change --crate-type metadata to --emit=metadata","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"body":"WIP","created_at":"2016-12-23T06:59:04Z","updated_at":"2016-12-28T23:37:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"249b6451f1522d6abc10ae3f0e3defedc8bffb4b","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/38571/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/38571/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/38571/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/bc4b42fa37b27f45443d35ecc301f2bc59ae02c2","head":{"label":"nrc:emit-metadata-change","ref":"emit-metadata-change","sha":"bc4b42fa37b27f45443d35ecc301f2bc59ae02c2","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"repo":{"id":11998169,"name":"rust","full_name":"nrc/rust","owner":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nrc/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nrc/rust","forks_url":"https://api.github.com/repos/nrc/rust/forks","keys_url":"https://api.github.com/repos/nrc/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrc/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrc/rust/teams","hooks_url":"https://api.github.com/repos/nrc/rust/hooks","issue_events_url":"https://api.github.com/repos/nrc/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nrc/rust/events","assignees_url":"https://api.github.com/repos/nrc/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nrc/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nrc/rust/tags","blobs_url":"https://api.github.com/repos/nrc/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrc/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrc/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrc/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrc/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nrc/rust/languages","stargazers_url":"https://api.github.com/repos/nrc/rust/stargazers","contributors_url":"https://api.github.com/repos/nrc/rust/contributors","subscribers_url":"https://api.github.com/repos/nrc/rust/subscribers","subscription_url":"https://api.github.com/repos/nrc/rust/subscription","commits_url":"https://api.github.com/repos/nrc/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrc/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrc/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrc/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrc/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nrc/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrc/rust/merges","archive_url":"https://api.github.com/repos/nrc/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrc/rust/downloads","issues_url":"https://api.github.com/repos/nrc/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nrc/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nrc/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nrc/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrc/rust/labels{/name}","releases_url":"https://api.github.com/repos/nrc/rust/releases{/id}","deployments_url":"https://api.github.com/repos/nrc/rust/deployments","created_at":"2013-08-09T10:00:46Z","updated_at":"2015-04-23T20:46:35Z","pushed_at":"2016-12-28T01:21:11Z","git_url":"git://github.com/nrc/rust.git","ssh_url":"git@github.com:nrc/rust.git","clone_url":"https://github.com/nrc/rust.git","svn_url":"https://github.com/nrc/rust","homepage":"http://www.rust-lang.org","size":318402,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"314c28b729ae359b99586cc62c486c28e0d44424","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-12-28T22:44:28Z","pushed_at":"2016-12-28T23:30:15Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":318285,"stargazers_count":19559,"watchers_count":19559,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3738,"mirror_url":null,"open_issues_count":3031,"forks":3738,"open_issues":3031,"watchers":19559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38571"},"html":{"href":"https://github.com/rust-lang/rust/pull/38571"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38571"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38571/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38571/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38571/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/bc4b42fa37b27f45443d35ecc301f2bc59ae02c2"}}}}
{"actor":{"display_login":"alexcrichton"}}