{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/63113262","id":63113262,"diff_hunk":"@@ -124,10 +124,25 @@ class FlexibleSpaceDemoState extends State<FlexibleSpaceDemo> {\n           ],\n           flexibleSpace: new FlexibleSpaceBar(\n             title : new Text('Ali Connors'),\n-            background: new AssetImage(\n-              name: 'packages/flutter_gallery_assets/ali_connors.png',\n-              fit: ImageFit.cover,\n-              height: _appBarHeight\n+            background: new Stack(\n+              children: <Widget>[\n+                new AssetImage(\n+                  name: 'packages/flutter_gallery_assets/ali_connors.png',\n+                  fit: ImageFit.cover,\n+                  height: _appBarHeight\n+                ),\n+                // This gradient ensures that the toolbar icons are distinct\n+                // against the background image.\n+                new DecoratedBox(","path":"examples/flutter_gallery/lib/demo/flexible_space_demo.dart","position":17,"original_position":17,"commit_id":"26f860a9cbc285868e6a5775b1c5a5263ea8a0e3","original_commit_id":"26f860a9cbc285868e6a5775b1c5a5263ea8a0e3","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"shouldn't this be a feature of AppBar (or one of its related classes)?","created_at":"2016-05-12T23:20:40Z","updated_at":"2016-05-12T23:20:40Z","html_url":"https://github.com/flutter/flutter/pull/3890#discussion_r63113262","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/3890","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/63113262"},"html":{"href":"https://github.com/flutter/flutter/pull/3890#discussion_r63113262"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3890"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/3890","id":69919491,"html_url":"https://github.com/flutter/flutter/pull/3890","diff_url":"https://github.com/flutter/flutter/pull/3890.diff","patch_url":"https://github.com/flutter/flutter/pull/3890.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/3890","number":3890,"state":"open","locked":false,"title":"Flexible space bar demo needs to occupy more vertical space, etc","user":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"body":"- Added some content so that it's easier to scroll the appbar completely away.\r\n- Added a light gradient on top of the background image (as in the MD spec) so that the toolbar icons can be seen.\r\n","created_at":"2016-05-12T22:50:36Z","updated_at":"2016-05-12T23:20:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7792025974257d031786c8591e7cdc0651bf56e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/3890/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/3890/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/3890/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/26f860a9cbc285868e6a5775b1c5a5263ea8a0e3","head":{"label":"HansMuller:ali_connors","ref":"ali_connors","sha":"26f860a9cbc285868e6a5775b1c5a5263ea8a0e3","user":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"repo":{"id":45849791,"name":"flutter","full_name":"HansMuller/flutter","owner":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HansMuller/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/HansMuller/flutter","forks_url":"https://api.github.com/repos/HansMuller/flutter/forks","keys_url":"https://api.github.com/repos/HansMuller/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HansMuller/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HansMuller/flutter/teams","hooks_url":"https://api.github.com/repos/HansMuller/flutter/hooks","issue_events_url":"https://api.github.com/repos/HansMuller/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/HansMuller/flutter/events","assignees_url":"https://api.github.com/repos/HansMuller/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/HansMuller/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/HansMuller/flutter/tags","blobs_url":"https://api.github.com/repos/HansMuller/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HansMuller/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HansMuller/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/HansMuller/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HansMuller/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/HansMuller/flutter/languages","stargazers_url":"https://api.github.com/repos/HansMuller/flutter/stargazers","contributors_url":"https://api.github.com/repos/HansMuller/flutter/contributors","subscribers_url":"https://api.github.com/repos/HansMuller/flutter/subscribers","subscription_url":"https://api.github.com/repos/HansMuller/flutter/subscription","commits_url":"https://api.github.com/repos/HansMuller/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/HansMuller/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/HansMuller/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/HansMuller/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/HansMuller/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/HansMuller/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HansMuller/flutter/merges","archive_url":"https://api.github.com/repos/HansMuller/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HansMuller/flutter/downloads","issues_url":"https://api.github.com/repos/HansMuller/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/HansMuller/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/HansMuller/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/HansMuller/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HansMuller/flutter/labels{/name}","releases_url":"https://api.github.com/repos/HansMuller/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/HansMuller/flutter/deployments","created_at":"2015-11-09T16:11:46Z","updated_at":"2015-11-09T16:11:50Z","pushed_at":"2016-05-12T22:49:32Z","git_url":"git://github.com/HansMuller/flutter.git","ssh_url":"git@github.com:HansMuller/flutter.git","clone_url":"https://github.com/HansMuller/flutter.git","svn_url":"https://github.com/HansMuller/flutter","homepage":"http://flutter.io","size":17264,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"4220957520ced535fb14f9272907bf3d790d1815","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-05-12T21:57:07Z","pushed_at":"2016-05-12T22:54:37Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"http://flutter.io","size":111134,"stargazers_count":2771,"watchers_count":2771,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":936,"forks":286,"open_issues":936,"watchers":2771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3890"},"html":{"href":"https://github.com/flutter/flutter/pull/3890"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/3890"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/3890/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3890/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3890/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/26f860a9cbc285868e6a5775b1c5a5263ea8a0e3"}}}}