{"action":"created","comment":{"url":"https://api.github.com/repos/embox/embox/pulls/comments/69132426","id":69132426,"diff_hunk":"@@ -25,6 +25,8 @@ module core {\n \n \tdepends embox.kernel.cpu.common\n \tdepends embox.kernel.sched.current.api\n+\n+\tdepends stack_protect","path":"src/kernel/thread/Mybuild","position":5,"original_position":5,"commit_id":"bea0edcead5c4324ce65ffe0691cfc98ea12a40e","original_commit_id":"bea0edcead5c4324ce65ffe0691cfc98ea12a40e","user":{"login":"anton-bondarev","id":6949261,"avatar_url":"https://avatars.githubusercontent.com/u/6949261?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-bondarev","html_url":"https://github.com/anton-bondarev","followers_url":"https://api.github.com/users/anton-bondarev/followers","following_url":"https://api.github.com/users/anton-bondarev/following{/other_user}","gists_url":"https://api.github.com/users/anton-bondarev/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-bondarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-bondarev/subscriptions","organizations_url":"https://api.github.com/users/anton-bondarev/orgs","repos_url":"https://api.github.com/users/anton-bondarev/repos","events_url":"https://api.github.com/users/anton-bondarev/events{/privacy}","received_events_url":"https://api.github.com/users/anton-bondarev/received_events","type":"User","site_admin":false},"body":"Please create `abstract module` with `@DefaultImpl` wich be empty implementation of your API.\r\nEmbox support a lot of platforms. Some of them haven't support MMU and if we'll accept your PR we'll break all of ones.","created_at":"2016-06-30T13:35:19Z","updated_at":"2016-06-30T13:35:19Z","html_url":"https://github.com/embox/embox/pull/957#discussion_r69132426","pull_request_url":"https://api.github.com/repos/embox/embox/pulls/957","_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/comments/69132426"},"html":{"href":"https://github.com/embox/embox/pull/957#discussion_r69132426"},"pull_request":{"href":"https://api.github.com/repos/embox/embox/pulls/957"}}},"pull_request":{"url":"https://api.github.com/repos/embox/embox/pulls/957","id":75636018,"html_url":"https://github.com/embox/embox/pull/957","diff_url":"https://github.com/embox/embox/pull/957.diff","patch_url":"https://github.com/embox/embox/pull/957.patch","issue_url":"https://api.github.com/repos/embox/embox/issues/957","number":957,"state":"open","locked":false,"title":"basic stack protection implementation","user":{"login":"melentyev","id":5588993,"avatar_url":"https://avatars.githubusercontent.com/u/5588993?v=3","gravatar_id":"","url":"https://api.github.com/users/melentyev","html_url":"https://github.com/melentyev","followers_url":"https://api.github.com/users/melentyev/followers","following_url":"https://api.github.com/users/melentyev/following{/other_user}","gists_url":"https://api.github.com/users/melentyev/gists{/gist_id}","starred_url":"https://api.github.com/users/melentyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melentyev/subscriptions","organizations_url":"https://api.github.com/users/melentyev/orgs","repos_url":"https://api.github.com/users/melentyev/repos","events_url":"https://api.github.com/users/melentyev/events{/privacy}","received_events_url":"https://api.github.com/users/melentyev/received_events","type":"User","site_admin":false},"body":"Implemented simple thread stack protection using mmu on x86.","created_at":"2016-06-29T12:06:09Z","updated_at":"2016-06-30T13:35:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed0b19fb9de0607a20db9850b92d6b176a8bab80","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/embox/embox/pulls/957/commits","review_comments_url":"https://api.github.com/repos/embox/embox/pulls/957/comments","review_comment_url":"https://api.github.com/repos/embox/embox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/embox/embox/issues/957/comments","statuses_url":"https://api.github.com/repos/embox/embox/statuses/bea0edcead5c4324ce65ffe0691cfc98ea12a40e","head":{"label":"melentyev:master","ref":"master","sha":"bea0edcead5c4324ce65ffe0691cfc98ea12a40e","user":{"login":"melentyev","id":5588993,"avatar_url":"https://avatars.githubusercontent.com/u/5588993?v=3","gravatar_id":"","url":"https://api.github.com/users/melentyev","html_url":"https://github.com/melentyev","followers_url":"https://api.github.com/users/melentyev/followers","following_url":"https://api.github.com/users/melentyev/following{/other_user}","gists_url":"https://api.github.com/users/melentyev/gists{/gist_id}","starred_url":"https://api.github.com/users/melentyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melentyev/subscriptions","organizations_url":"https://api.github.com/users/melentyev/orgs","repos_url":"https://api.github.com/users/melentyev/repos","events_url":"https://api.github.com/users/melentyev/events{/privacy}","received_events_url":"https://api.github.com/users/melentyev/received_events","type":"User","site_admin":false},"repo":{"id":62090823,"name":"embox","full_name":"melentyev/embox","owner":{"login":"melentyev","id":5588993,"avatar_url":"https://avatars.githubusercontent.com/u/5588993?v=3","gravatar_id":"","url":"https://api.github.com/users/melentyev","html_url":"https://github.com/melentyev","followers_url":"https://api.github.com/users/melentyev/followers","following_url":"https://api.github.com/users/melentyev/following{/other_user}","gists_url":"https://api.github.com/users/melentyev/gists{/gist_id}","starred_url":"https://api.github.com/users/melentyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melentyev/subscriptions","organizations_url":"https://api.github.com/users/melentyev/orgs","repos_url":"https://api.github.com/users/melentyev/repos","events_url":"https://api.github.com/users/melentyev/events{/privacy}","received_events_url":"https://api.github.com/users/melentyev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melentyev/embox","description":"Modular and configurable OS kernel for embedded applications","fork":true,"url":"https://api.github.com/repos/melentyev/embox","forks_url":"https://api.github.com/repos/melentyev/embox/forks","keys_url":"https://api.github.com/repos/melentyev/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melentyev/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melentyev/embox/teams","hooks_url":"https://api.github.com/repos/melentyev/embox/hooks","issue_events_url":"https://api.github.com/repos/melentyev/embox/issues/events{/number}","events_url":"https://api.github.com/repos/melentyev/embox/events","assignees_url":"https://api.github.com/repos/melentyev/embox/assignees{/user}","branches_url":"https://api.github.com/repos/melentyev/embox/branches{/branch}","tags_url":"https://api.github.com/repos/melentyev/embox/tags","blobs_url":"https://api.github.com/repos/melentyev/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melentyev/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melentyev/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/melentyev/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melentyev/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/melentyev/embox/languages","stargazers_url":"https://api.github.com/repos/melentyev/embox/stargazers","contributors_url":"https://api.github.com/repos/melentyev/embox/contributors","subscribers_url":"https://api.github.com/repos/melentyev/embox/subscribers","subscription_url":"https://api.github.com/repos/melentyev/embox/subscription","commits_url":"https://api.github.com/repos/melentyev/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/melentyev/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/melentyev/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/melentyev/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/melentyev/embox/contents/{+path}","compare_url":"https://api.github.com/repos/melentyev/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melentyev/embox/merges","archive_url":"https://api.github.com/repos/melentyev/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melentyev/embox/downloads","issues_url":"https://api.github.com/repos/melentyev/embox/issues{/number}","pulls_url":"https://api.github.com/repos/melentyev/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/melentyev/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/melentyev/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melentyev/embox/labels{/name}","releases_url":"https://api.github.com/repos/melentyev/embox/releases{/id}","deployments_url":"https://api.github.com/repos/melentyev/embox/deployments","created_at":"2016-06-27T21:51:35Z","updated_at":"2016-06-27T21:51:41Z","pushed_at":"2016-06-29T13:25:01Z","git_url":"git://github.com/melentyev/embox.git","ssh_url":"git@github.com:melentyev/embox.git","clone_url":"https://github.com/melentyev/embox.git","svn_url":"https://github.com/melentyev/embox","homepage":"","size":23081,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"embox:master","ref":"master","sha":"6b64b374a987da34e0152266e365a45a8e033da2","user":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"repo":{"id":33078138,"name":"embox","full_name":"embox/embox","owner":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embox/embox","description":"Modular and configurable OS kernel for embedded applications","fork":false,"url":"https://api.github.com/repos/embox/embox","forks_url":"https://api.github.com/repos/embox/embox/forks","keys_url":"https://api.github.com/repos/embox/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embox/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embox/embox/teams","hooks_url":"https://api.github.com/repos/embox/embox/hooks","issue_events_url":"https://api.github.com/repos/embox/embox/issues/events{/number}","events_url":"https://api.github.com/repos/embox/embox/events","assignees_url":"https://api.github.com/repos/embox/embox/assignees{/user}","branches_url":"https://api.github.com/repos/embox/embox/branches{/branch}","tags_url":"https://api.github.com/repos/embox/embox/tags","blobs_url":"https://api.github.com/repos/embox/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embox/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embox/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/embox/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embox/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/embox/embox/languages","stargazers_url":"https://api.github.com/repos/embox/embox/stargazers","contributors_url":"https://api.github.com/repos/embox/embox/contributors","subscribers_url":"https://api.github.com/repos/embox/embox/subscribers","subscription_url":"https://api.github.com/repos/embox/embox/subscription","commits_url":"https://api.github.com/repos/embox/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/embox/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/embox/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/embox/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/embox/embox/contents/{+path}","compare_url":"https://api.github.com/repos/embox/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embox/embox/merges","archive_url":"https://api.github.com/repos/embox/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embox/embox/downloads","issues_url":"https://api.github.com/repos/embox/embox/issues{/number}","pulls_url":"https://api.github.com/repos/embox/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/embox/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/embox/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embox/embox/labels{/name}","releases_url":"https://api.github.com/repos/embox/embox/releases{/id}","deployments_url":"https://api.github.com/repos/embox/embox/deployments","created_at":"2015-03-29T15:27:48Z","updated_at":"2016-05-23T10:17:43Z","pushed_at":"2016-06-29T13:43:54Z","git_url":"git://github.com/embox/embox.git","ssh_url":"git@github.com:embox/embox.git","clone_url":"https://github.com/embox/embox.git","svn_url":"https://github.com/embox/embox","homepage":"","size":34966,"stargazers_count":104,"watchers_count":104,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":67,"forks":33,"open_issues":67,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/957"},"html":{"href":"https://github.com/embox/embox/pull/957"},"issue":{"href":"https://api.github.com/repos/embox/embox/issues/957"},"comments":{"href":"https://api.github.com/repos/embox/embox/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/embox/embox/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/embox/embox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/embox/embox/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/embox/embox/statuses/bea0edcead5c4324ce65ffe0691cfc98ea12a40e"}}}}
{"actor":{"display_login":"anton-bondarev"}}