{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-devtools/pulls/comments/70330864","id":70330864,"diff_hunk":"@@ -0,0 +1,94 @@\n+/**\n+ * Copyright (c) 2015-present, Facebook, Inc.\n+ * All rights reserved.\n+ *\n+ * This source code is licensed under the BSD-style license found in the\n+ * LICENSE file in the root directory of this source tree. An additional grant\n+ * of patent rights can be found in the PATENTS file in the same directory.\n+ *\n+ * @flow\n+ */\n+\n+'use strict';\n+\n+const React = require('react');\n+const immutable = require('immutable');\n+\n+import type {ControlState} from './types.js';\n+\n+type Props = {\n+  state: any,\n+  text: string,\n+  onChange: (v: ControlState) => void,\n+};\n+\n+type State = StateRecord;\n+\n+type DefaultProps = {};\n+\n+const StateRecord = immutable.Record({\n+  enabled: false,\n+});\n+\n+class SettingsCheckbox extends React.Component {\n+  props: Props;\n+  defaultProps: DefaultProps;\n+  state: State;\n+\n+  _defaultState: ControlState;\n+  _toggle: (b: boolean) => void;\n+\n+  constructor(props: Props) {\n+    super(props);\n+    this._toggle = this._toggle.bind(this);\n+    this._defaultState = new StateRecord();\n+  }\n+\n+  componentDidMount(): void {\n+    if (!this.props.state !== this._defaultState) {\n+      this.props.onChange(this._defaultState);\n+    }\n+  }\n+\n+  render() {\n+    var state = this.props.state || this._defaultState;\n+    return (\n+      <div style={styles.container} onClick={this._toggle} tabIndex={0}>\n+        <input\n+          style={styles.checkbox}\n+          type=\"checkbox\"\n+          checked={state.enabled}\n+          readOnly={true}","path":"frontend/SettingsCheckbox.js","position":61,"original_position":61,"commit_id":"9e89081287cf7679caa4ed3088b021124faa4e00","original_commit_id":"9e89081287cf7679caa4ed3088b021124faa4e00","user":{"login":"millermedeiros","id":155633,"avatar_url":"https://avatars.githubusercontent.com/u/155633?v=3","gravatar_id":"","url":"https://api.github.com/users/millermedeiros","html_url":"https://github.com/millermedeiros","followers_url":"https://api.github.com/users/millermedeiros/followers","following_url":"https://api.github.com/users/millermedeiros/following{/other_user}","gists_url":"https://api.github.com/users/millermedeiros/gists{/gist_id}","starred_url":"https://api.github.com/users/millermedeiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millermedeiros/subscriptions","organizations_url":"https://api.github.com/users/millermedeiros/orgs","repos_url":"https://api.github.com/users/millermedeiros/repos","events_url":"https://api.github.com/users/millermedeiros/events{/privacy}","received_events_url":"https://api.github.com/users/millermedeiros/received_events","type":"User","site_admin":false},"body":"nit: sort props.","created_at":"2016-07-11T20:31:31Z","updated_at":"2016-07-11T20:31:31Z","html_url":"https://github.com/facebook/react-devtools/pull/397#discussion_r70330864","pull_request_url":"https://api.github.com/repos/facebook/react-devtools/pulls/397","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-devtools/pulls/comments/70330864"},"html":{"href":"https://github.com/facebook/react-devtools/pull/397#discussion_r70330864"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-devtools/pulls/397"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-devtools/pulls/397","id":76512062,"html_url":"https://github.com/facebook/react-devtools/pull/397","diff_url":"https://github.com/facebook/react-devtools/pull/397.diff","patch_url":"https://github.com/facebook/react-devtools/pull/397.patch","issue_url":"https://api.github.com/repos/facebook/react-devtools/issues/397","number":397,"state":"open","locked":false,"title":"[WIP] Add option to highlight all searched components","user":{"login":"aolesky","id":6119851,"avatar_url":"https://avatars.githubusercontent.com/u/6119851?v=3","gravatar_id":"","url":"https://api.github.com/users/aolesky","html_url":"https://github.com/aolesky","followers_url":"https://api.github.com/users/aolesky/followers","following_url":"https://api.github.com/users/aolesky/following{/other_user}","gists_url":"https://api.github.com/users/aolesky/gists{/gist_id}","starred_url":"https://api.github.com/users/aolesky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aolesky/subscriptions","organizations_url":"https://api.github.com/users/aolesky/orgs","repos_url":"https://api.github.com/users/aolesky/repos","events_url":"https://api.github.com/users/aolesky/events{/privacy}","received_events_url":"https://api.github.com/users/aolesky/received_events","type":"User","site_admin":false},"body":"I added a simple checkbox in the settings pane for the colorizer. When this option is enabled, all of the components that fit the search are highlighted using the `MultiOverlay`. Also, I modified the `SearchPane`, so that the placeholder text changes as well to indicate the different options.\r\n\r\nI had to separate some of the event handling within the search panel. I double checked the _Trace React Updates_ option still works the same as before.\r\n\r\nSelecting the _Highlight Search_ option disables all individual component highlighting. Now hovering over any search option will not do anything while it is enabled.\r\n\r\nWithout Selection: \r\n![screen shot 2016-07-08 at 10 58 12 am](https://cloud.githubusercontent.com/assets/6119851/16696701/ed3a2ab8-44fa-11e6-8bad-b8e70b48a692.png)\r\n\r\nWith Selection (changed placeholder):\r\n![screen shot 2016-07-08 at 10 58 21 am](https://cloud.githubusercontent.com/assets/6119851/16696706/f2dbd75a-44fa-11e6-8a0e-81c3ad602dd0.png)\r\n\r\nHighlighting:\r\n![screen shot 2016-07-08 at 11 01 18 am](https://cloud.githubusercontent.com/assets/6119851/16696778/5842c676-44fb-11e6-8004-3a04214d9470.png)\r\n","created_at":"2016-07-06T22:23:35Z","updated_at":"2016-07-11T20:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e236bfaf0199fc8490c18ad946b6f95d6e9efdb3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-devtools/pulls/397/commits","review_comments_url":"https://api.github.com/repos/facebook/react-devtools/pulls/397/comments","review_comment_url":"https://api.github.com/repos/facebook/react-devtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-devtools/issues/397/comments","statuses_url":"https://api.github.com/repos/facebook/react-devtools/statuses/9e89081287cf7679caa4ed3088b021124faa4e00","head":{"label":"aolesky:colorizer","ref":"colorizer","sha":"9e89081287cf7679caa4ed3088b021124faa4e00","user":{"login":"aolesky","id":6119851,"avatar_url":"https://avatars.githubusercontent.com/u/6119851?v=3","gravatar_id":"","url":"https://api.github.com/users/aolesky","html_url":"https://github.com/aolesky","followers_url":"https://api.github.com/users/aolesky/followers","following_url":"https://api.github.com/users/aolesky/following{/other_user}","gists_url":"https://api.github.com/users/aolesky/gists{/gist_id}","starred_url":"https://api.github.com/users/aolesky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aolesky/subscriptions","organizations_url":"https://api.github.com/users/aolesky/orgs","repos_url":"https://api.github.com/users/aolesky/repos","events_url":"https://api.github.com/users/aolesky/events{/privacy}","received_events_url":"https://api.github.com/users/aolesky/received_events","type":"User","site_admin":false},"repo":{"id":62679785,"name":"react-devtools","full_name":"aolesky/react-devtools","owner":{"login":"aolesky","id":6119851,"avatar_url":"https://avatars.githubusercontent.com/u/6119851?v=3","gravatar_id":"","url":"https://api.github.com/users/aolesky","html_url":"https://github.com/aolesky","followers_url":"https://api.github.com/users/aolesky/followers","following_url":"https://api.github.com/users/aolesky/following{/other_user}","gists_url":"https://api.github.com/users/aolesky/gists{/gist_id}","starred_url":"https://api.github.com/users/aolesky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aolesky/subscriptions","organizations_url":"https://api.github.com/users/aolesky/orgs","repos_url":"https://api.github.com/users/aolesky/repos","events_url":"https://api.github.com/users/aolesky/events{/privacy}","received_events_url":"https://api.github.com/users/aolesky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aolesky/react-devtools","description":"An extension that allows inspection of React component hierarchy in Chrome Developer Tools.","fork":true,"url":"https://api.github.com/repos/aolesky/react-devtools","forks_url":"https://api.github.com/repos/aolesky/react-devtools/forks","keys_url":"https://api.github.com/repos/aolesky/react-devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aolesky/react-devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aolesky/react-devtools/teams","hooks_url":"https://api.github.com/repos/aolesky/react-devtools/hooks","issue_events_url":"https://api.github.com/repos/aolesky/react-devtools/issues/events{/number}","events_url":"https://api.github.com/repos/aolesky/react-devtools/events","assignees_url":"https://api.github.com/repos/aolesky/react-devtools/assignees{/user}","branches_url":"https://api.github.com/repos/aolesky/react-devtools/branches{/branch}","tags_url":"https://api.github.com/repos/aolesky/react-devtools/tags","blobs_url":"https://api.github.com/repos/aolesky/react-devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aolesky/react-devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aolesky/react-devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/aolesky/react-devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aolesky/react-devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/aolesky/react-devtools/languages","stargazers_url":"https://api.github.com/repos/aolesky/react-devtools/stargazers","contributors_url":"https://api.github.com/repos/aolesky/react-devtools/contributors","subscribers_url":"https://api.github.com/repos/aolesky/react-devtools/subscribers","subscription_url":"https://api.github.com/repos/aolesky/react-devtools/subscription","commits_url":"https://api.github.com/repos/aolesky/react-devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/aolesky/react-devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/aolesky/react-devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/aolesky/react-devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/aolesky/react-devtools/contents/{+path}","compare_url":"https://api.github.com/repos/aolesky/react-devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aolesky/react-devtools/merges","archive_url":"https://api.github.com/repos/aolesky/react-devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aolesky/react-devtools/downloads","issues_url":"https://api.github.com/repos/aolesky/react-devtools/issues{/number}","pulls_url":"https://api.github.com/repos/aolesky/react-devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/aolesky/react-devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/aolesky/react-devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aolesky/react-devtools/labels{/name}","releases_url":"https://api.github.com/repos/aolesky/react-devtools/releases{/id}","deployments_url":"https://api.github.com/repos/aolesky/react-devtools/deployments","created_at":"2016-07-06T00:56:20Z","updated_at":"2016-07-06T00:56:21Z","pushed_at":"2016-07-11T20:11:30Z","git_url":"git://github.com/aolesky/react-devtools.git","ssh_url":"git@github.com:aolesky/react-devtools.git","clone_url":"https://github.com/aolesky/react-devtools.git","svn_url":"https://github.com/aolesky/react-devtools","homepage":"","size":7842,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"96fcb41fea91c3a03219851512e3e305af9fa7f0","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":12601374,"name":"react-devtools","full_name":"facebook/react-devtools","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-devtools","description":"An extension that allows inspection of React component hierarchy in Chrome Developer Tools.","fork":false,"url":"https://api.github.com/repos/facebook/react-devtools","forks_url":"https://api.github.com/repos/facebook/react-devtools/forks","keys_url":"https://api.github.com/repos/facebook/react-devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-devtools/teams","hooks_url":"https://api.github.com/repos/facebook/react-devtools/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-devtools/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-devtools/events","assignees_url":"https://api.github.com/repos/facebook/react-devtools/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-devtools/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-devtools/tags","blobs_url":"https://api.github.com/repos/facebook/react-devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-devtools/languages","stargazers_url":"https://api.github.com/repos/facebook/react-devtools/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-devtools/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-devtools/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-devtools/subscription","commits_url":"https://api.github.com/repos/facebook/react-devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-devtools/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-devtools/merges","archive_url":"https://api.github.com/repos/facebook/react-devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-devtools/downloads","issues_url":"https://api.github.com/repos/facebook/react-devtools/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-devtools/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-devtools/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-devtools/deployments","created_at":"2013-09-04T20:28:43Z","updated_at":"2016-07-11T15:14:34Z","pushed_at":"2016-07-11T20:11:31Z","git_url":"git://github.com/facebook/react-devtools.git","ssh_url":"git@github.com:facebook/react-devtools.git","clone_url":"https://github.com/facebook/react-devtools.git","svn_url":"https://github.com/facebook/react-devtools","homepage":"","size":107230,"stargazers_count":2618,"watchers_count":2618,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":85,"forks":286,"open_issues":85,"watchers":2618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-devtools/pulls/397"},"html":{"href":"https://github.com/facebook/react-devtools/pull/397"},"issue":{"href":"https://api.github.com/repos/facebook/react-devtools/issues/397"},"comments":{"href":"https://api.github.com/repos/facebook/react-devtools/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-devtools/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-devtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-devtools/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-devtools/statuses/9e89081287cf7679caa4ed3088b021124faa4e00"}}}}
{"actor":{"display_login":"millermedeiros"}}