{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/35950","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/35950/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/35950/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/35950/events","html_url":"https://github.com/rust-lang/rust/issues/35950","id":172802149,"number":35950,"title":"TcpListener docs example contains an explicit drop that can never be reached","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/A-docs","name":"A-docs","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-23T20:45:00Z","updated_at":"2016-08-23T21:01:22Z","closed_at":null,"body":"The `incoming` iterator never returns `None`, so the `drop` at the end will never be reached. The explicit matching against the socket result also seems potentially nonconventional docs-wise?\r\n\r\nhttps://doc.rust-lang.org/std/net/struct.TcpListener.html#examples"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/241877181","html_url":"https://github.com/rust-lang/rust/issues/35950#issuecomment-241877181","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/35950","id":241877181,"user":{"login":"abonander","id":3198595,"avatar_url":"https://avatars.githubusercontent.com/u/3198595?v=3","gravatar_id":"","url":"https://api.github.com/users/abonander","html_url":"https://github.com/abonander","followers_url":"https://api.github.com/users/abonander/followers","following_url":"https://api.github.com/users/abonander/following{/other_user}","gists_url":"https://api.github.com/users/abonander/gists{/gist_id}","starred_url":"https://api.github.com/users/abonander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonander/subscriptions","organizations_url":"https://api.github.com/users/abonander/orgs","repos_url":"https://api.github.com/users/abonander/repos","events_url":"https://api.github.com/users/abonander/events{/privacy}","received_events_url":"https://api.github.com/users/abonander/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T21:01:22Z","updated_at":"2016-08-23T21:01:22Z","body":"Also, what are the semantics of this iterator when the listener is set to nonblocking mode? If it's equivalent to `accept()` it should run the loop with `WouldBlock` errors until a connection is made. "}}
{"actor":{"display_login":"abonander"}}