{"action":"created","issue":{"url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/issues/189","repository_url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation","labels_url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/issues/189/comments","events_url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/issues/189/events","html_url":"https://github.com/swcarpentry/r-novice-inflammation/pull/189","id":153879236,"number":189,"title":"Edit analyze_all function in lesson 04-cond.Rmd","user":{"login":"jrnold","id":123968,"avatar_url":"https://avatars.githubusercontent.com/u/123968?v=3","gravatar_id":"","url":"https://api.github.com/users/jrnold","html_url":"https://github.com/jrnold","followers_url":"https://api.github.com/users/jrnold/followers","following_url":"https://api.github.com/users/jrnold/following{/other_user}","gists_url":"https://api.github.com/users/jrnold/gists{/gist_id}","starred_url":"https://api.github.com/users/jrnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrnold/subscriptions","organizations_url":"https://api.github.com/users/jrnold/orgs","repos_url":"https://api.github.com/users/jrnold/repos","events_url":"https://api.github.com/users/jrnold/events{/privacy}","received_events_url":"https://api.github.com/users/jrnold/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/labels/instructor-training","name":"instructor-training","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"chendaniely","id":5782147,"avatar_url":"https://avatars.githubusercontent.com/u/5782147?v=3","gravatar_id":"","url":"https://api.github.com/users/chendaniely","html_url":"https://github.com/chendaniely","followers_url":"https://api.github.com/users/chendaniely/followers","following_url":"https://api.github.com/users/chendaniely/following{/other_user}","gists_url":"https://api.github.com/users/chendaniely/gists{/gist_id}","starred_url":"https://api.github.com/users/chendaniely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chendaniely/subscriptions","organizations_url":"https://api.github.com/users/chendaniely/orgs","repos_url":"https://api.github.com/users/chendaniely/repos","events_url":"https://api.github.com/users/chendaniely/events{/privacy}","received_events_url":"https://api.github.com/users/chendaniely/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/milestones/2","html_url":"https://github.com/swcarpentry/r-novice-inflammation/milestones/Version%205.4","labels_url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/milestones/2/labels","id":1159393,"number":2,"title":"Version 5.4","description":"Issues and PRs to resolve for Version 5.4 release.","creator":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":4,"state":"open","created_at":"2015-06-10T22:39:28Z","updated_at":"2016-06-14T15:38:11Z","due_on":"2016-06-14T04:00:00Z","closed_at":null},"comments":5,"created_at":"2016-05-09T21:56:23Z","updated_at":"2016-06-14T17:02:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/pulls/189","html_url":"https://github.com/swcarpentry/r-novice-inflammation/pull/189","diff_url":"https://github.com/swcarpentry/r-novice-inflammation/pull/189.diff","patch_url":"https://github.com/swcarpentry/r-novice-inflammation/pull/189.patch"},"body":"The analyze_all function would save files in the same directory as the data csv files.\r\nThis would cause problems on repeated runs without updating the pattern used to select files. Since using a pattern to only get csv files matching inflation.*\\\\.csv would require mentioning regular expressions, I opted to fix this by saving the figures to a different directory.\r\n\r\nI also used this as an opportunity to reference the good scienctific computing practice of separating data and output referenced in \"Good Enough Practices for Scientific Computing.\"\r\n\r\nThis fixes issue #169."},"comment":{"url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/issues/comments/225947575","html_url":"https://github.com/swcarpentry/r-novice-inflammation/pull/189#issuecomment-225947575","issue_url":"https://api.github.com/repos/swcarpentry/r-novice-inflammation/issues/189","id":225947575,"user":{"login":"jrnold","id":123968,"avatar_url":"https://avatars.githubusercontent.com/u/123968?v=3","gravatar_id":"","url":"https://api.github.com/users/jrnold","html_url":"https://github.com/jrnold","followers_url":"https://api.github.com/users/jrnold/followers","following_url":"https://api.github.com/users/jrnold/following{/other_user}","gists_url":"https://api.github.com/users/jrnold/gists{/gist_id}","starred_url":"https://api.github.com/users/jrnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrnold/subscriptions","organizations_url":"https://api.github.com/users/jrnold/orgs","repos_url":"https://api.github.com/users/jrnold/repos","events_url":"https://api.github.com/users/jrnold/events{/privacy}","received_events_url":"https://api.github.com/users/jrnold/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T17:02:38Z","updated_at":"2016-06-14T17:02:38Z","body":"I don't think it would be bad to introduce pattern-matching. However, since the purpose of doing so in this case would be to allow them to use an anti-pattern, I don't think it should be used here."}}
{"actor":{"display_login":"jrnold"}}