{"action":"created","issue":{"url":"https://api.github.com/repos/morepath/dectate/issues/20","repository_url":"https://api.github.com/repos/morepath/dectate","labels_url":"https://api.github.com/repos/morepath/dectate/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/morepath/dectate/issues/20/comments","events_url":"https://api.github.com/repos/morepath/dectate/issues/20/events","html_url":"https://github.com/morepath/dectate/issues/20","id":149850046,"number":20,"title":"make topological sort stable","user":{"login":"faassen","id":327472,"avatar_url":"https://avatars.githubusercontent.com/u/327472?v=3","gravatar_id":"","url":"https://api.github.com/users/faassen","html_url":"https://github.com/faassen","followers_url":"https://api.github.com/users/faassen/followers","following_url":"https://api.github.com/users/faassen/following{/other_user}","gists_url":"https://api.github.com/users/faassen/gists{/gist_id}","starred_url":"https://api.github.com/users/faassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faassen/subscriptions","organizations_url":"https://api.github.com/users/faassen/orgs","repos_url":"https://api.github.com/users/faassen/repos","events_url":"https://api.github.com/users/faassen/events{/privacy}","received_events_url":"https://api.github.com/users/faassen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/morepath/dectate/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-20T18:33:53Z","updated_at":"2016-04-25T11:42:21Z","closed_at":null,"body":"It would be nice if topological sort were stable. I don't think it is now entirely, and this can lead to different order of execution of directives and thus different order of execution of registries. This can lead to subtle bugs, see #3 \r\n\r\nWe should in this case also use this stable topological sort in Morepath itself.\r\n"},"comment":{"url":"https://api.github.com/repos/morepath/dectate/issues/comments/214277545","html_url":"https://github.com/morepath/dectate/issues/20#issuecomment-214277545","issue_url":"https://api.github.com/repos/morepath/dectate/issues/20","id":214277545,"user":{"login":"taschini","id":7879276,"avatar_url":"https://avatars.githubusercontent.com/u/7879276?v=3","gravatar_id":"","url":"https://api.github.com/users/taschini","html_url":"https://github.com/taschini","followers_url":"https://api.github.com/users/taschini/followers","following_url":"https://api.github.com/users/taschini/following{/other_user}","gists_url":"https://api.github.com/users/taschini/gists{/gist_id}","starred_url":"https://api.github.com/users/taschini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taschini/subscriptions","organizations_url":"https://api.github.com/users/taschini/orgs","repos_url":"https://api.github.com/users/taschini/repos","events_url":"https://api.github.com/users/taschini/events{/privacy}","received_events_url":"https://api.github.com/users/taschini/received_events","type":"User","site_admin":false},"created_at":"2016-04-25T11:42:21Z","updated_at":"2016-04-25T11:42:21Z","body":"> If that is a problem, it should be enough to enforce a canonical order on the input before passing to topological_sort.\r\n\r\nI just realized that no, that's not enough. There is a dependency also on the ordering of get_depend's output.\r\n"}}