{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/comments/53932663","id":53932663,"diff_hunk":"@@ -25,8 +25,8 @@ export class BaseProxy {\n         return deferred.promise;\n     }\n \n-    protected encodeInvokeOnKey<T>(codec: any, key: any, ...codecArguments: any[]): Q.Promise<T> {\n-        var partitionId: number = this.client.getPartitionService().getPartitionId(key);\n+    protected encodeInvokeOnKey<T>(codec: any, partitionKey: any, ...codecArguments: any[]): Q.Promise<T> {\n+        var partitionId: number = this.client.getPartitionService().getPartitionId(partitionKey);","path":"src/proxy/BaseProxy.ts","position":7,"original_position":7,"commit_id":"63b67c0a11149ee1f019cde9013069de498caf48","original_commit_id":"63b67c0a11149ee1f019cde9013069de498caf48","user":{"login":"mustafaiman","id":6582349,"avatar_url":"https://avatars.githubusercontent.com/u/6582349?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafaiman","html_url":"https://github.com/mustafaiman","followers_url":"https://api.github.com/users/mustafaiman/followers","following_url":"https://api.github.com/users/mustafaiman/following{/other_user}","gists_url":"https://api.github.com/users/mustafaiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafaiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafaiman/subscriptions","organizations_url":"https://api.github.com/users/mustafaiman/orgs","repos_url":"https://api.github.com/users/mustafaiman/repos","events_url":"https://api.github.com/users/mustafaiman/events{/privacy}","received_events_url":"https://api.github.com/users/mustafaiman/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2016-02-24T12:44:58Z","updated_at":"2016-02-24T12:44:58Z","html_url":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client/pull/35#discussion_r53932663","pull_request_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/comments/53932663"},"html":{"href":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client/pull/35#discussion_r53932663"},"pull_request":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35","id":60350759,"html_url":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client/pull/35","diff_url":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client/pull/35.diff","patch_url":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client/pull/35.patch","issue_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/issues/35","number":35,"state":"open","locked":false,"title":"Implemented smart routing","user":{"login":"GhostInAMachine","id":11163575,"avatar_url":"https://avatars.githubusercontent.com/u/11163575?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostInAMachine","html_url":"https://github.com/GhostInAMachine","followers_url":"https://api.github.com/users/GhostInAMachine/followers","following_url":"https://api.github.com/users/GhostInAMachine/following{/other_user}","gists_url":"https://api.github.com/users/GhostInAMachine/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostInAMachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostInAMachine/subscriptions","organizations_url":"https://api.github.com/users/GhostInAMachine/orgs","repos_url":"https://api.github.com/users/GhostInAMachine/repos","events_url":"https://api.github.com/users/GhostInAMachine/events{/privacy}","received_events_url":"https://api.github.com/users/GhostInAMachine/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-23T14:51:00Z","updated_at":"2016-02-24T12:44:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd0beed9e4d822eee177896b0723a23808297ee5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35/commits","review_comments_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35/comments","review_comment_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/issues/35/comments","statuses_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/statuses/63b67c0a11149ee1f019cde9013069de498caf48","head":{"label":"GhostInAMachine:smart_invocation","ref":"smart_invocation","sha":"63b67c0a11149ee1f019cde9013069de498caf48","user":{"login":"GhostInAMachine","id":11163575,"avatar_url":"https://avatars.githubusercontent.com/u/11163575?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostInAMachine","html_url":"https://github.com/GhostInAMachine","followers_url":"https://api.github.com/users/GhostInAMachine/followers","following_url":"https://api.github.com/users/GhostInAMachine/following{/other_user}","gists_url":"https://api.github.com/users/GhostInAMachine/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostInAMachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostInAMachine/subscriptions","organizations_url":"https://api.github.com/users/GhostInAMachine/orgs","repos_url":"https://api.github.com/users/GhostInAMachine/repos","events_url":"https://api.github.com/users/GhostInAMachine/events{/privacy}","received_events_url":"https://api.github.com/users/GhostInAMachine/received_events","type":"User","site_admin":false},"repo":{"id":47989854,"name":"hazelcast-nodejs-client","full_name":"GhostInAMachine/hazelcast-nodejs-client","owner":{"login":"GhostInAMachine","id":11163575,"avatar_url":"https://avatars.githubusercontent.com/u/11163575?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostInAMachine","html_url":"https://github.com/GhostInAMachine","followers_url":"https://api.github.com/users/GhostInAMachine/followers","following_url":"https://api.github.com/users/GhostInAMachine/following{/other_user}","gists_url":"https://api.github.com/users/GhostInAMachine/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostInAMachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostInAMachine/subscriptions","organizations_url":"https://api.github.com/users/GhostInAMachine/orgs","repos_url":"https://api.github.com/users/GhostInAMachine/repos","events_url":"https://api.github.com/users/GhostInAMachine/events{/privacy}","received_events_url":"https://api.github.com/users/GhostInAMachine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GhostInAMachine/hazelcast-nodejs-client","description":"NodeJS Client for Hazelcast, using Hazelcast Open Client Protocol 1.0 for Hazelcast 3.6 and higher","fork":true,"url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client","forks_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/forks","keys_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/teams","hooks_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/hooks","issue_events_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/issues/events{/number}","events_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/events","assignees_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/assignees{/user}","branches_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/branches{/branch}","tags_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/tags","blobs_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/statuses/{sha}","languages_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/languages","stargazers_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/stargazers","contributors_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/contributors","subscribers_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/subscribers","subscription_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/subscription","commits_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/contents/{+path}","compare_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/merges","archive_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/downloads","issues_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/issues{/number}","pulls_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/pulls{/number}","milestones_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/milestones{/number}","notifications_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/labels{/name}","releases_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/releases{/id}","deployments_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/deployments","created_at":"2015-12-14T17:15:57Z","updated_at":"2015-12-14T17:15:58Z","pushed_at":"2016-02-23T14:49:57Z","git_url":"git://github.com/GhostInAMachine/hazelcast-nodejs-client.git","ssh_url":"git@github.com:GhostInAMachine/hazelcast-nodejs-client.git","clone_url":"https://github.com/GhostInAMachine/hazelcast-nodejs-client.git","svn_url":"https://github.com/GhostInAMachine/hazelcast-nodejs-client","homepage":null,"size":85,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast-incubator:master","ref":"master","sha":"f74e2fcdf39655a044054eaed8a2e834e1a89523","user":{"login":"hazelcast-incubator","id":11215411,"avatar_url":"https://avatars.githubusercontent.com/u/11215411?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast-incubator","html_url":"https://github.com/hazelcast-incubator","followers_url":"https://api.github.com/users/hazelcast-incubator/followers","following_url":"https://api.github.com/users/hazelcast-incubator/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast-incubator/subscriptions","organizations_url":"https://api.github.com/users/hazelcast-incubator/orgs","repos_url":"https://api.github.com/users/hazelcast-incubator/repos","events_url":"https://api.github.com/users/hazelcast-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":45202495,"name":"hazelcast-nodejs-client","full_name":"hazelcast-incubator/hazelcast-nodejs-client","owner":{"login":"hazelcast-incubator","id":11215411,"avatar_url":"https://avatars.githubusercontent.com/u/11215411?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast-incubator","html_url":"https://github.com/hazelcast-incubator","followers_url":"https://api.github.com/users/hazelcast-incubator/followers","following_url":"https://api.github.com/users/hazelcast-incubator/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast-incubator/subscriptions","organizations_url":"https://api.github.com/users/hazelcast-incubator/orgs","repos_url":"https://api.github.com/users/hazelcast-incubator/repos","events_url":"https://api.github.com/users/hazelcast-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client","description":"NodeJS Client for Hazelcast, using Hazelcast Open Client Protocol 1.0 for Hazelcast 3.6 and higher","fork":false,"url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client","forks_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/forks","keys_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/teams","hooks_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/hooks","issue_events_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/events","assignees_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/tags","blobs_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/languages","stargazers_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/stargazers","contributors_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/contributors","subscribers_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/subscribers","subscription_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/subscription","commits_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/merges","archive_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/downloads","issues_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/deployments","created_at":"2015-10-29T18:24:48Z","updated_at":"2016-02-22T11:24:10Z","pushed_at":"2016-02-24T12:00:58Z","git_url":"git://github.com/hazelcast-incubator/hazelcast-nodejs-client.git","ssh_url":"git@github.com:hazelcast-incubator/hazelcast-nodejs-client.git","clone_url":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client.git","svn_url":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client","homepage":null,"size":160,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35"},"html":{"href":"https://github.com/hazelcast-incubator/hazelcast-nodejs-client/pull/35"},"issue":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/issues/35"},"comments":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast-incubator/hazelcast-nodejs-client/statuses/63b67c0a11149ee1f019cde9013069de498caf48"}}}}