{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1667","repository_url":"https://api.github.com/repos/facebook/AsyncDisplayKit","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1667/labels{/name}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1667/comments","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1667/events","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1667","id":155062604,"number":1667,"title":"[ASDataController] Small improvements","user":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/CLA%20Signed","name":"CLA Signed","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-16T16:07:46Z","updated_at":"2016-06-01T17:37:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1667","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1667","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1667.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1667.patch"},"body":"1. Use NSFastEnumeration directly instead of getting a NSEnumerator for iterating through completedNodes which should improve performance\r\n2. Use the sorted array in `reloadRowsAtIndexPaths:withAnimationOptions:`. Before we just sorted it, but didn't use it :/\r\n3. Remove FIXME about sorting index paths for deleting rows. @Adlai-Holler I saw you added the FIXME, why do you think we should order in descending order before deleting?\r\n\r\ncc @appleguy "},"comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments/223068454","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1667#issuecomment-223068454","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1667","id":223068454,"user":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T17:37:53Z","updated_at":"2016-06-01T17:37:53Z","body":"@appleguy Ok I made the changes.\r\n\r\nWe had a longer discussion about the fastest way to actually reverse sort the index path array. Let me know if you know a faster way as currently implemented. There is also the `sortedArrayUsingComparator:` method on NSArray, but based on the sorting benchmark and reverse benchmark in this two articles it should be faster to first use `sortedArrayUsingSelector:` and after that use `reverseObjectEnumerator` and `allObject`.\r\n\r\nhttps://www.objc.io/issues/7-foundation/collections/ and http://stackoverflow.com/questions/586370/how-can-i-reverse-a-nsarray-in-objective-c"}}
{"actor":{"display_login":"maicki"}}