{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/88785513","pull_request_review_id":9350749,"id":88785513,"diff_hunk":"@@ -35,11 +35,12 @@\n #elif defined(TARGET_LINUX) || defined(TARGET_FREEBSD)\n   #if defined(HAS_ALSA)\n     #include \"Sinks/AESinkALSA.h\"\n+  #else","path":"xbmc/cores/AudioEngine/AESinkFactory.cpp","position":4,"original_position":4,"commit_id":"1f9aa4f2618d12cdffd8fb5b32b0655591d50452","original_commit_id":"1f9aa4f2618d12cdffd8fb5b32b0655591d50452","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"OK to change the `else` to `#elif defined(TARGET_FREEBSD)` here and on other positions (to have OSS only on FreeBSD)?\r\n\r\nIf it becomes separated to a own `#elif defined(TARGET_FREEBSD)` must be the PulseAudio part inserted two times (also available on FreeBSD).","created_at":"2016-11-19T19:03:03Z","updated_at":"2016-11-19T19:03:03Z","html_url":"https://github.com/xbmc/xbmc/pull/10961#discussion_r88785513","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10961","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/88785513"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10961#discussion_r88785513"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10961"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10961","id":94486409,"html_url":"https://github.com/xbmc/xbmc/pull/10961","diff_url":"https://github.com/xbmc/xbmc/pull/10961.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10961.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10961","number":10961,"state":"open","locked":false,"title":"[audioengine] don't use OSS if ALSA is present","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"This prevent the use of OSS audio if ALSA is supported.\r\n\r\n## Description\r\nThis prevent also the compile fault related to https://github.com/xbmc/xbmc/pull/10670 \r\n\r\n## Motivation and Context\r\nWant to have compile working to continue work ;-)\r\n\r\n@FernetMenta is this way OK?\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n\r\n","created_at":"2016-11-19T16:21:00Z","updated_at":"2016-11-19T19:03:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28041ecb9adebc4653d2e9f78a7c83876fad8753","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/93","html_url":"https://github.com/xbmc/xbmc/milestones/Krypton%2017.0-beta6","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/93/labels","id":2099222,"number":93,"title":"Krypton 17.0-beta6","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":116,"state":"open","created_at":"2016-10-28T08:33:30Z","updated_at":"2016-11-19T18:27:03Z","due_on":"2016-11-21T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10961/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10961/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10961/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/1f9aa4f2618d12cdffd8fb5b32b0655591d50452","head":{"label":"AlwinEsch:prevent-oss","ref":"prevent-oss","sha":"1f9aa4f2618d12cdffd8fb5b32b0655591d50452","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"repo":{"id":17647639,"name":"kodi","full_name":"AlwinEsch/kodi","owner":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlwinEsch/kodi","description":"Fork of Kodi Main Repository","fork":true,"url":"https://api.github.com/repos/AlwinEsch/kodi","forks_url":"https://api.github.com/repos/AlwinEsch/kodi/forks","keys_url":"https://api.github.com/repos/AlwinEsch/kodi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlwinEsch/kodi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlwinEsch/kodi/teams","hooks_url":"https://api.github.com/repos/AlwinEsch/kodi/hooks","issue_events_url":"https://api.github.com/repos/AlwinEsch/kodi/issues/events{/number}","events_url":"https://api.github.com/repos/AlwinEsch/kodi/events","assignees_url":"https://api.github.com/repos/AlwinEsch/kodi/assignees{/user}","branches_url":"https://api.github.com/repos/AlwinEsch/kodi/branches{/branch}","tags_url":"https://api.github.com/repos/AlwinEsch/kodi/tags","blobs_url":"https://api.github.com/repos/AlwinEsch/kodi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlwinEsch/kodi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlwinEsch/kodi/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlwinEsch/kodi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlwinEsch/kodi/statuses/{sha}","languages_url":"https://api.github.com/repos/AlwinEsch/kodi/languages","stargazers_url":"https://api.github.com/repos/AlwinEsch/kodi/stargazers","contributors_url":"https://api.github.com/repos/AlwinEsch/kodi/contributors","subscribers_url":"https://api.github.com/repos/AlwinEsch/kodi/subscribers","subscription_url":"https://api.github.com/repos/AlwinEsch/kodi/subscription","commits_url":"https://api.github.com/repos/AlwinEsch/kodi/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlwinEsch/kodi/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlwinEsch/kodi/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlwinEsch/kodi/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlwinEsch/kodi/contents/{+path}","compare_url":"https://api.github.com/repos/AlwinEsch/kodi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlwinEsch/kodi/merges","archive_url":"https://api.github.com/repos/AlwinEsch/kodi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlwinEsch/kodi/downloads","issues_url":"https://api.github.com/repos/AlwinEsch/kodi/issues{/number}","pulls_url":"https://api.github.com/repos/AlwinEsch/kodi/pulls{/number}","milestones_url":"https://api.github.com/repos/AlwinEsch/kodi/milestones{/number}","notifications_url":"https://api.github.com/repos/AlwinEsch/kodi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlwinEsch/kodi/labels{/name}","releases_url":"https://api.github.com/repos/AlwinEsch/kodi/releases{/id}","deployments_url":"https://api.github.com/repos/AlwinEsch/kodi/deployments","created_at":"2014-03-11T22:34:10Z","updated_at":"2016-10-29T09:24:05Z","pushed_at":"2016-11-19T16:14:33Z","git_url":"git://github.com/AlwinEsch/kodi.git","ssh_url":"git@github.com:AlwinEsch/kodi.git","clone_url":"https://github.com/AlwinEsch/kodi.git","svn_url":"https://github.com/AlwinEsch/kodi","homepage":"http://kodi.tv","size":578266,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"18fc8aa5167e925889f89862ab3dc6b828b5578b","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-11-19T10:15:12Z","pushed_at":"2016-11-19T18:55:20Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1778563,"stargazers_count":5187,"watchers_count":5187,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3742,"mirror_url":null,"open_issues_count":215,"forks":3742,"open_issues":215,"watchers":5187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10961"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10961"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10961"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10961/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10961/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10961/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/1f9aa4f2618d12cdffd8fb5b32b0655591d50452"}}}}
{"actor":{"display_login":"AlwinEsch"}}