{"action":"created","comment":{"url":"https://api.github.com/repos/rwahs/providence/pulls/comments/72738525","id":72738525,"diff_hunk":"@@ -1437,7 +1408,7 @@ private function _indexAttribute($pt_subject, $pn_row_id, $pm_element_code_or_id\n \n \t\t\t\t\t\t$va_children_ids = $pt_subject->getHierarchyAsList($pn_row_id, array('idsOnly' => true, 'includeSelf' => false));\n \n-\t\t\t\t\t\tif (!$pb_reindex_mode && is_array($va_children_ids) && sizeof($va_children_ids) > 0) {","path":"app/lib/core/Search/SearchIndexer.php","position":168,"original_position":168,"commit_id":"043f722de9b7332670434699a3e9c24d1c146b08","original_commit_id":"043f722de9b7332670434699a3e9c24d1c146b08","user":{"login":"leftclickben","id":94266,"avatar_url":"https://avatars.githubusercontent.com/u/94266?v=3","gravatar_id":"","url":"https://api.github.com/users/leftclickben","html_url":"https://github.com/leftclickben","followers_url":"https://api.github.com/users/leftclickben/followers","following_url":"https://api.github.com/users/leftclickben/following{/other_user}","gists_url":"https://api.github.com/users/leftclickben/gists{/gist_id}","starred_url":"https://api.github.com/users/leftclickben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leftclickben/subscriptions","organizations_url":"https://api.github.com/users/leftclickben/orgs","repos_url":"https://api.github.com/users/leftclickben/repos","events_url":"https://api.github.com/users/leftclickben/events{/privacy}","received_events_url":"https://api.github.com/users/leftclickben/received_events","type":"User","site_admin":false},"body":"`$pb_reindex_mode` was undefined, which is falsy, so `!$pb_reindex_mode` is always going to be true, therefore this check can be removed.  Good pick up though :-)","created_at":"2016-07-29T03:47:26Z","updated_at":"2016-07-29T03:47:26Z","html_url":"https://github.com/rwahs/providence/pull/32#discussion_r72738525","pull_request_url":"https://api.github.com/repos/rwahs/providence/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/rwahs/providence/pulls/comments/72738525"},"html":{"href":"https://github.com/rwahs/providence/pull/32#discussion_r72738525"},"pull_request":{"href":"https://api.github.com/repos/rwahs/providence/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/rwahs/providence/pulls/32","id":79171268,"html_url":"https://github.com/rwahs/providence/pull/32","diff_url":"https://github.com/rwahs/providence/pull/32.diff","patch_url":"https://github.com/rwahs/providence/pull/32.patch","issue_url":"https://api.github.com/repos/rwahs/providence/issues/32","number":32,"state":"open","locked":false,"title":"RWAHS-502 Search within containers","user":{"login":"leftclickben","id":94266,"avatar_url":"https://avatars.githubusercontent.com/u/94266?v=3","gravatar_id":"","url":"https://api.github.com/users/leftclickben","html_url":"https://github.com/leftclickben","followers_url":"https://api.github.com/users/leftclickben/followers","following_url":"https://api.github.com/users/leftclickben/following{/other_user}","gists_url":"https://api.github.com/users/leftclickben/gists{/gist_id}","starred_url":"https://api.github.com/users/leftclickben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leftclickben/subscriptions","organizations_url":"https://api.github.com/users/leftclickben/orgs","repos_url":"https://api.github.com/users/leftclickben/repos","events_url":"https://api.github.com/users/leftclickben/events{/privacy}","received_events_url":"https://api.github.com/users/leftclickben/received_events","type":"User","site_admin":false},"body":"Fixes both issues relating to searching elements within containers:\r\n\r\n* The query builder only lists containers themselves, not their children, which is where the actual data is.\r\n* CA only indexes the ID for list elements nested under containers, not the text values.  (For \"top-level\" list elements, i.e. not in a container, the text value is indexed).\r\n","created_at":"2016-07-28T10:23:13Z","updated_at":"2016-07-29T03:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3ce7662c003dfb001d2459fe340ff5a0f369c73","assignee":{"login":"kehh","id":12571,"avatar_url":"https://avatars.githubusercontent.com/u/12571?v=3","gravatar_id":"","url":"https://api.github.com/users/kehh","html_url":"https://github.com/kehh","followers_url":"https://api.github.com/users/kehh/followers","following_url":"https://api.github.com/users/kehh/following{/other_user}","gists_url":"https://api.github.com/users/kehh/gists{/gist_id}","starred_url":"https://api.github.com/users/kehh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kehh/subscriptions","organizations_url":"https://api.github.com/users/kehh/orgs","repos_url":"https://api.github.com/users/kehh/repos","events_url":"https://api.github.com/users/kehh/events{/privacy}","received_events_url":"https://api.github.com/users/kehh/received_events","type":"User","site_admin":false},"assignees":[{"login":"kehh","id":12571,"avatar_url":"https://avatars.githubusercontent.com/u/12571?v=3","gravatar_id":"","url":"https://api.github.com/users/kehh","html_url":"https://github.com/kehh","followers_url":"https://api.github.com/users/kehh/followers","following_url":"https://api.github.com/users/kehh/following{/other_user}","gists_url":"https://api.github.com/users/kehh/gists{/gist_id}","starred_url":"https://api.github.com/users/kehh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kehh/subscriptions","organizations_url":"https://api.github.com/users/kehh/orgs","repos_url":"https://api.github.com/users/kehh/repos","events_url":"https://api.github.com/users/kehh/events{/privacy}","received_events_url":"https://api.github.com/users/kehh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rwahs/providence/pulls/32/commits","review_comments_url":"https://api.github.com/repos/rwahs/providence/pulls/32/comments","review_comment_url":"https://api.github.com/repos/rwahs/providence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rwahs/providence/issues/32/comments","statuses_url":"https://api.github.com/repos/rwahs/providence/statuses/043f722de9b7332670434699a3e9c24d1c146b08","head":{"label":"leftclickben:RWAHS-502/QueryBuilderSearchWithinContainers","ref":"RWAHS-502/QueryBuilderSearchWithinContainers","sha":"043f722de9b7332670434699a3e9c24d1c146b08","user":{"login":"leftclickben","id":94266,"avatar_url":"https://avatars.githubusercontent.com/u/94266?v=3","gravatar_id":"","url":"https://api.github.com/users/leftclickben","html_url":"https://github.com/leftclickben","followers_url":"https://api.github.com/users/leftclickben/followers","following_url":"https://api.github.com/users/leftclickben/following{/other_user}","gists_url":"https://api.github.com/users/leftclickben/gists{/gist_id}","starred_url":"https://api.github.com/users/leftclickben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leftclickben/subscriptions","organizations_url":"https://api.github.com/users/leftclickben/orgs","repos_url":"https://api.github.com/users/leftclickben/repos","events_url":"https://api.github.com/users/leftclickben/events{/privacy}","received_events_url":"https://api.github.com/users/leftclickben/received_events","type":"User","site_admin":false},"repo":{"id":51350309,"name":"providence","full_name":"leftclickben/providence","owner":{"login":"leftclickben","id":94266,"avatar_url":"https://avatars.githubusercontent.com/u/94266?v=3","gravatar_id":"","url":"https://api.github.com/users/leftclickben","html_url":"https://github.com/leftclickben","followers_url":"https://api.github.com/users/leftclickben/followers","following_url":"https://api.github.com/users/leftclickben/following{/other_user}","gists_url":"https://api.github.com/users/leftclickben/gists{/gist_id}","starred_url":"https://api.github.com/users/leftclickben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leftclickben/subscriptions","organizations_url":"https://api.github.com/users/leftclickben/orgs","repos_url":"https://api.github.com/users/leftclickben/repos","events_url":"https://api.github.com/users/leftclickben/events{/privacy}","received_events_url":"https://api.github.com/users/leftclickben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leftclickben/providence","description":"Cataloguing and data/media management application","fork":true,"url":"https://api.github.com/repos/leftclickben/providence","forks_url":"https://api.github.com/repos/leftclickben/providence/forks","keys_url":"https://api.github.com/repos/leftclickben/providence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leftclickben/providence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leftclickben/providence/teams","hooks_url":"https://api.github.com/repos/leftclickben/providence/hooks","issue_events_url":"https://api.github.com/repos/leftclickben/providence/issues/events{/number}","events_url":"https://api.github.com/repos/leftclickben/providence/events","assignees_url":"https://api.github.com/repos/leftclickben/providence/assignees{/user}","branches_url":"https://api.github.com/repos/leftclickben/providence/branches{/branch}","tags_url":"https://api.github.com/repos/leftclickben/providence/tags","blobs_url":"https://api.github.com/repos/leftclickben/providence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leftclickben/providence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leftclickben/providence/git/refs{/sha}","trees_url":"https://api.github.com/repos/leftclickben/providence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leftclickben/providence/statuses/{sha}","languages_url":"https://api.github.com/repos/leftclickben/providence/languages","stargazers_url":"https://api.github.com/repos/leftclickben/providence/stargazers","contributors_url":"https://api.github.com/repos/leftclickben/providence/contributors","subscribers_url":"https://api.github.com/repos/leftclickben/providence/subscribers","subscription_url":"https://api.github.com/repos/leftclickben/providence/subscription","commits_url":"https://api.github.com/repos/leftclickben/providence/commits{/sha}","git_commits_url":"https://api.github.com/repos/leftclickben/providence/git/commits{/sha}","comments_url":"https://api.github.com/repos/leftclickben/providence/comments{/number}","issue_comment_url":"https://api.github.com/repos/leftclickben/providence/issues/comments{/number}","contents_url":"https://api.github.com/repos/leftclickben/providence/contents/{+path}","compare_url":"https://api.github.com/repos/leftclickben/providence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leftclickben/providence/merges","archive_url":"https://api.github.com/repos/leftclickben/providence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leftclickben/providence/downloads","issues_url":"https://api.github.com/repos/leftclickben/providence/issues{/number}","pulls_url":"https://api.github.com/repos/leftclickben/providence/pulls{/number}","milestones_url":"https://api.github.com/repos/leftclickben/providence/milestones{/number}","notifications_url":"https://api.github.com/repos/leftclickben/providence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leftclickben/providence/labels{/name}","releases_url":"https://api.github.com/repos/leftclickben/providence/releases{/id}","deployments_url":"https://api.github.com/repos/leftclickben/providence/deployments","created_at":"2016-02-09T06:22:03Z","updated_at":"2016-02-09T06:22:27Z","pushed_at":"2016-07-28T10:21:12Z","git_url":"git://github.com/leftclickben/providence.git","ssh_url":"git@github.com:leftclickben/providence.git","clone_url":"https://github.com/leftclickben/providence.git","svn_url":"https://github.com/leftclickben/providence","homepage":"","size":100575,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwahs:master-fix","ref":"master-fix","sha":"44999cdc6b865ae56b46b955a6ef63cc07ca1b27","user":{"login":"rwahs","id":16794641,"avatar_url":"https://avatars.githubusercontent.com/u/16794641?v=3","gravatar_id":"","url":"https://api.github.com/users/rwahs","html_url":"https://github.com/rwahs","followers_url":"https://api.github.com/users/rwahs/followers","following_url":"https://api.github.com/users/rwahs/following{/other_user}","gists_url":"https://api.github.com/users/rwahs/gists{/gist_id}","starred_url":"https://api.github.com/users/rwahs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwahs/subscriptions","organizations_url":"https://api.github.com/users/rwahs/orgs","repos_url":"https://api.github.com/users/rwahs/repos","events_url":"https://api.github.com/users/rwahs/events{/privacy}","received_events_url":"https://api.github.com/users/rwahs/received_events","type":"Organization","site_admin":false},"repo":{"id":50017236,"name":"providence","full_name":"rwahs/providence","owner":{"login":"rwahs","id":16794641,"avatar_url":"https://avatars.githubusercontent.com/u/16794641?v=3","gravatar_id":"","url":"https://api.github.com/users/rwahs","html_url":"https://github.com/rwahs","followers_url":"https://api.github.com/users/rwahs/followers","following_url":"https://api.github.com/users/rwahs/following{/other_user}","gists_url":"https://api.github.com/users/rwahs/gists{/gist_id}","starred_url":"https://api.github.com/users/rwahs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwahs/subscriptions","organizations_url":"https://api.github.com/users/rwahs/orgs","repos_url":"https://api.github.com/users/rwahs/repos","events_url":"https://api.github.com/users/rwahs/events{/privacy}","received_events_url":"https://api.github.com/users/rwahs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rwahs/providence","description":"Cataloguing and data/media management application","fork":true,"url":"https://api.github.com/repos/rwahs/providence","forks_url":"https://api.github.com/repos/rwahs/providence/forks","keys_url":"https://api.github.com/repos/rwahs/providence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwahs/providence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwahs/providence/teams","hooks_url":"https://api.github.com/repos/rwahs/providence/hooks","issue_events_url":"https://api.github.com/repos/rwahs/providence/issues/events{/number}","events_url":"https://api.github.com/repos/rwahs/providence/events","assignees_url":"https://api.github.com/repos/rwahs/providence/assignees{/user}","branches_url":"https://api.github.com/repos/rwahs/providence/branches{/branch}","tags_url":"https://api.github.com/repos/rwahs/providence/tags","blobs_url":"https://api.github.com/repos/rwahs/providence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwahs/providence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwahs/providence/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwahs/providence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwahs/providence/statuses/{sha}","languages_url":"https://api.github.com/repos/rwahs/providence/languages","stargazers_url":"https://api.github.com/repos/rwahs/providence/stargazers","contributors_url":"https://api.github.com/repos/rwahs/providence/contributors","subscribers_url":"https://api.github.com/repos/rwahs/providence/subscribers","subscription_url":"https://api.github.com/repos/rwahs/providence/subscription","commits_url":"https://api.github.com/repos/rwahs/providence/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwahs/providence/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwahs/providence/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwahs/providence/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwahs/providence/contents/{+path}","compare_url":"https://api.github.com/repos/rwahs/providence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwahs/providence/merges","archive_url":"https://api.github.com/repos/rwahs/providence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwahs/providence/downloads","issues_url":"https://api.github.com/repos/rwahs/providence/issues{/number}","pulls_url":"https://api.github.com/repos/rwahs/providence/pulls{/number}","milestones_url":"https://api.github.com/repos/rwahs/providence/milestones{/number}","notifications_url":"https://api.github.com/repos/rwahs/providence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwahs/providence/labels{/name}","releases_url":"https://api.github.com/repos/rwahs/providence/releases{/id}","deployments_url":"https://api.github.com/repos/rwahs/providence/deployments","created_at":"2016-01-20T08:51:51Z","updated_at":"2016-01-20T11:25:24Z","pushed_at":"2016-07-28T10:23:13Z","git_url":"git://github.com/rwahs/providence.git","ssh_url":"git@github.com:rwahs/providence.git","clone_url":"https://github.com/rwahs/providence.git","svn_url":"https://github.com/rwahs/providence","homepage":"","size":100208,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master-fix"}},"_links":{"self":{"href":"https://api.github.com/repos/rwahs/providence/pulls/32"},"html":{"href":"https://github.com/rwahs/providence/pull/32"},"issue":{"href":"https://api.github.com/repos/rwahs/providence/issues/32"},"comments":{"href":"https://api.github.com/repos/rwahs/providence/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/rwahs/providence/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/rwahs/providence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rwahs/providence/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/rwahs/providence/statuses/043f722de9b7332670434699a3e9c24d1c146b08"}}}}
{"actor":{"display_login":"leftclickben"}}