{"action":"created","comment":{"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments/87773301","pull_request_review_id":8369455,"id":87773301,"diff_hunk":"@@ -1,21 +1,29 @@\n .grid--dividers {\n   .grid__cell {\n-    border-left: 1px solid color('accessible-grey-2');\n-    padding-left: map-get($gutter-width, 'small')/2;\n-    margin-left: map-get($gutter-width, 'small')/2 - 1;\n+    position: relative;\n \n-    @include respond-to('medium') {\n-      padding-left: map-get($gutter-width, 'medium')/2;\n-      margin-left: map-get($gutter-width, 'medium')/2 - 1;\n-    }\n+    &:before {\n+      position: absolute;\n+      content: '';\n+      top: 0;\n+      bottom: 0;\n+      width: 1px;\n+      background: color('keyline-grey');","path":"client/scss/grids/_grid_dividers.scss","position":18,"original_position":18,"commit_id":"123f20c6efb75968067a7baf3b489aae972fe588","original_commit_id":"123f20c6efb75968067a7baf3b489aae972fe588","user":{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars.githubusercontent.com/u/31692?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"body":"Isn't this just adding a border?\r\nAre we lso sure we want borders on all `grid__cell`s?","created_at":"2016-11-14T10:29:57Z","updated_at":"2016-11-14T10:33:21Z","html_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/77#discussion_r87773301","pull_request_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments/87773301"},"html":{"href":"https://github.com/wellcometrust/wellcomecollection.org/pull/77#discussion_r87773301"},"pull_request":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77","id":93364616,"html_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/77","diff_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/77.diff","patch_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/77.patch","issue_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/77","number":77,"state":"open","locked":false,"title":"Header","user":{"login":"davidpmccormick","id":1394592,"avatar_url":"https://avatars.githubusercontent.com/u/1394592?v=3","gravatar_id":"","url":"https://api.github.com/users/davidpmccormick","html_url":"https://github.com/davidpmccormick","followers_url":"https://api.github.com/users/davidpmccormick/followers","following_url":"https://api.github.com/users/davidpmccormick/following{/other_user}","gists_url":"https://api.github.com/users/davidpmccormick/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpmccormick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpmccormick/subscriptions","organizations_url":"https://api.github.com/users/davidpmccormick/orgs","repos_url":"https://api.github.com/users/davidpmccormick/repos","events_url":"https://api.github.com/users/davidpmccormick/events{/privacy}","received_events_url":"https://api.github.com/users/davidpmccormick/received_events","type":"User","site_admin":false},"body":"This is a first run at the header area with keyboard and screenreader a11y.\r\n\r\nQuestions remain around:\r\n\r\n- hover states for touch devices\r\n- what opening-time/clock/upcoming event/login info should live in the header\r\n- where the search box should appear on mobile\r\n- how a user accesses content within the dropdown from a narrow-screened device\r\n\r\nTODOs include:\r\n\r\n- [ ] swapping out CSS shapes and the Wellcome Logo for items in the svg-sprite\r\n- [ ] swapping out placeholder components in the dropdown for e.g. cards\r\n- [ ] throttle/debouncing a window resizing event\r\n- [ ] ensuring the mobile burger appears before other page elements in the tab-order (I thought this could be a rare occurrence of where `tabindex=\"1\"` might be a good idea, but if we add skip-links, this wouldn't be the case (need to research the data on skip-links – a cursory glance indicates guardian and ft don't seem to have them anymore but gov.uk and BBC news do).\r\n- [ ] allow components that handle their own layout on the page to be previewed without being contained in a `.container` div (because e.g. they contain their own `.container` elements).\r\n- [ ] decide on how to support the sticky header on scroll (native `position:sticky` + polyfill vs. JS vs. `position:fixed`).\r\n- [ ] Add translucent page overlay when dropdown visible.\r\n\r\n![small_header](https://cloud.githubusercontent.com/assets/1394592/20222726/5602007a-a82e-11e6-8c4b-1a7bfae71651.png)\r\n![large_header](https://cloud.githubusercontent.com/assets/1394592/20222727/5613b928-a82e-11e6-9b54-d2f46976b728.png)\r\n","created_at":"2016-11-11T17:03:55Z","updated_at":"2016-11-14T10:33:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2267b4150befb66983bdc52e0ec052887f5df3d","assignee":{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars.githubusercontent.com/u/31692?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars.githubusercontent.com/u/31692?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},{"login":"gestchild","id":6051896,"avatar_url":"https://avatars.githubusercontent.com/u/6051896?v=3","gravatar_id":"","url":"https://api.github.com/users/gestchild","html_url":"https://github.com/gestchild","followers_url":"https://api.github.com/users/gestchild/followers","following_url":"https://api.github.com/users/gestchild/following{/other_user}","gists_url":"https://api.github.com/users/gestchild/gists{/gist_id}","starred_url":"https://api.github.com/users/gestchild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gestchild/subscriptions","organizations_url":"https://api.github.com/users/gestchild/orgs","repos_url":"https://api.github.com/users/gestchild/repos","events_url":"https://api.github.com/users/gestchild/events{/privacy}","received_events_url":"https://api.github.com/users/gestchild/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77/commits","review_comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77/comments","review_comment_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/77/comments","statuses_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/123f20c6efb75968067a7baf3b489aae972fe588","head":{"label":"wellcometrust:header","ref":"header","sha":"123f20c6efb75968067a7baf3b489aae972fe588","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":69954837,"name":"wellcomecollection.org","full_name":"wellcometrust/wellcomecollection.org","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/wellcomecollection.org","description":"Soon to be wellcomecollection.org","fork":false,"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org","forks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/forks","keys_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/teams","hooks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/events","assignees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/tags","blobs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscription","commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/merges","archive_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/downloads","issues_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/deployments","created_at":"2016-10-04T10:29:50Z","updated_at":"2016-11-02T10:25:07Z","pushed_at":"2016-11-11T17:14:52Z","git_url":"git://github.com/wellcometrust/wellcomecollection.org.git","ssh_url":"git@github.com:wellcometrust/wellcomecollection.org.git","clone_url":"https://github.com/wellcometrust/wellcomecollection.org.git","svn_url":"https://github.com/wellcometrust/wellcomecollection.org","homepage":"https://wellcomecollection.org","size":604,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"wellcometrust:master","ref":"master","sha":"d9fd50d561b5c5eefac57ffd60be9dd895d80645","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":69954837,"name":"wellcomecollection.org","full_name":"wellcometrust/wellcomecollection.org","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/wellcomecollection.org","description":"Soon to be wellcomecollection.org","fork":false,"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org","forks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/forks","keys_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/teams","hooks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/events","assignees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/tags","blobs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscription","commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/merges","archive_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/downloads","issues_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/deployments","created_at":"2016-10-04T10:29:50Z","updated_at":"2016-11-02T10:25:07Z","pushed_at":"2016-11-11T17:14:52Z","git_url":"git://github.com/wellcometrust/wellcomecollection.org.git","ssh_url":"git@github.com:wellcometrust/wellcomecollection.org.git","clone_url":"https://github.com/wellcometrust/wellcomecollection.org.git","svn_url":"https://github.com/wellcometrust/wellcomecollection.org","homepage":"https://wellcomecollection.org","size":604,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77"},"html":{"href":"https://github.com/wellcometrust/wellcomecollection.org/pull/77"},"issue":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/77"},"comments":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/123f20c6efb75968067a7baf3b489aae972fe588"}}}}
{"actor":{"display_login":"jamesgorrie"}}