{"action":"closed","issue":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/1009","repository_url":"https://api.github.com/repos/danielgindi/Charts","labels_url":"https://api.github.com/repos/danielgindi/Charts/issues/1009/labels{/name}","comments_url":"https://api.github.com/repos/danielgindi/Charts/issues/1009/comments","events_url":"https://api.github.com/repos/danielgindi/Charts/issues/1009/events","html_url":"https://github.com/danielgindi/Charts/issues/1009","id":153350530,"number":1009,"title":"Override with Wrong Argument Label?","user":{"login":"Redoubts","id":2435101,"avatar_url":"https://avatars.githubusercontent.com/u/2435101?v=3","gravatar_id":"","url":"https://api.github.com/users/Redoubts","html_url":"https://github.com/Redoubts","followers_url":"https://api.github.com/users/Redoubts/followers","following_url":"https://api.github.com/users/Redoubts/following{/other_user}","gists_url":"https://api.github.com/users/Redoubts/gists{/gist_id}","starred_url":"https://api.github.com/users/Redoubts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Redoubts/subscriptions","organizations_url":"https://api.github.com/users/Redoubts/orgs","repos_url":"https://api.github.com/users/Redoubts/repos","events_url":"https://api.github.com/users/Redoubts/events{/privacy}","received_events_url":"https://api.github.com/users/Redoubts/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-05T23:45:16Z","updated_at":"2016-05-08T07:01:35Z","closed_at":"2016-05-08T07:01:35Z","body":"I have a question about `Classes/Highlight/HorizontalBarChartHighlighter.swift`\r\n\r\nIn it, you try to override\r\n`public func getBase(x: Double) -> Double` from `BarChartHighlighter` [(link)](https://github.com/danielgindi/Charts/blob/master/Charts/Classes/Highlight/BarChartHighlighter.swift#L176)\r\nwith\r\n`public override func getBase(y: Double) -> Double` [(link)](https://github.com/danielgindi/Charts/blob/master/Charts/Classes/Highlight/HorizontalBarChartHighlighter.swift#L93)\r\n\r\nis it right to use `y` as the argument label, both semantically and as an override? Later you [use it on an x value](https://github.com/danielgindi/Charts/blob/master/Charts/Classes/Highlight/BarChartHighlighter.swift#L59) which makes me suspicious if this is a bug or not."}}