{"action":"created","comment":{"url":"https://api.github.com/repos/lumol-org/lumol/pulls/comments/92494415","pull_request_review_id":13010837,"id":92494415,"diff_hunk":"@@ -185,6 +185,20 @@ impl Interactions {\n         }\n     }\n \n+    /// Get all pair interactions\n+    ///\n+    /// Using this function, you lose information\n+    /// about which interaction belongs to which pair of particles.\n+    pub fn all_pairs(&self) -> Vec<&PairInteraction> {\n+        let res: Vec<&PairInteraction> = self.pairs\n+            .values() // value is a Vec<&PairInteraction>\n+            // flatten the vector -> return an iterator over\n+            // Vec<&PairInteraction>\n+            .flat_map(|i| i)\n+            .collect();\n+        res","path":"src/core/src/sys/interactions.rs","position":15,"original_position":15,"commit_id":"34712690cce406c172fd3d0cd0664816e2505d6b","original_commit_id":"34712690cce406c172fd3d0cd0664816e2505d6b","user":{"login":"Luthaf","id":6141587,"avatar_url":"https://avatars.githubusercontent.com/u/6141587?v=3","gravatar_id":"","url":"https://api.github.com/users/Luthaf","html_url":"https://github.com/Luthaf","followers_url":"https://api.github.com/users/Luthaf/followers","following_url":"https://api.github.com/users/Luthaf/following{/other_user}","gists_url":"https://api.github.com/users/Luthaf/gists{/gist_id}","starred_url":"https://api.github.com/users/Luthaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luthaf/subscriptions","organizations_url":"https://api.github.com/users/Luthaf/orgs","repos_url":"https://api.github.com/users/Luthaf/repos","events_url":"https://api.github.com/users/Luthaf/events{/privacy}","received_events_url":"https://api.github.com/users/Luthaf/received_events","type":"User","site_admin":false},"body":"I believe this could be written\r\n\r\n```rust\r\npub fn all_pairs(&self) -> Vec<&PairInteraction> {\r\n    self.pairs.values() // value is a Vec<Vec<&PairInteraction>>\r\n                        // flatten the vector -> return an iterator over\r\n                        // Vec<&PairInteraction>\r\n              .flat_map(|i| i)\r\n              .collect()\r\n}\r\n```","created_at":"2016-12-14T21:36:06Z","updated_at":"2016-12-14T21:40:08Z","html_url":"https://github.com/lumol-org/lumol/pull/71#discussion_r92494415","pull_request_url":"https://api.github.com/repos/lumol-org/lumol/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/lumol-org/lumol/pulls/comments/92494415"},"html":{"href":"https://github.com/lumol-org/lumol/pull/71#discussion_r92494415"},"pull_request":{"href":"https://api.github.com/repos/lumol-org/lumol/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/lumol-org/lumol/pulls/71","id":98021712,"html_url":"https://github.com/lumol-org/lumol/pull/71","diff_url":"https://github.com/lumol-org/lumol/pull/71.diff","patch_url":"https://github.com/lumol-org/lumol/pull/71.patch","issue_url":"https://api.github.com/repos/lumol-org/lumol/issues/71","number":71,"state":"open","locked":false,"title":"Add function to get the largest cutoff radius","user":{"login":"g-bauer","id":7261278,"avatar_url":"https://avatars.githubusercontent.com/u/7261278?v=3","gravatar_id":"","url":"https://api.github.com/users/g-bauer","html_url":"https://github.com/g-bauer","followers_url":"https://api.github.com/users/g-bauer/followers","following_url":"https://api.github.com/users/g-bauer/following{/other_user}","gists_url":"https://api.github.com/users/g-bauer/gists{/gist_id}","starred_url":"https://api.github.com/users/g-bauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-bauer/subscriptions","organizations_url":"https://api.github.com/users/g-bauer/orgs","repos_url":"https://api.github.com/users/g-bauer/repos","events_url":"https://api.github.com/users/g-bauer/events{/privacy}","received_events_url":"https://api.github.com/users/g-bauer/received_events","type":"User","site_admin":false},"body":"This PR adds functionality to access the largest cutoff from all `pairs`. This is useful to get the limit of the smallest simulation cell.\r\n\r\nCurrently, only pair interactions are considered, no electrostatics.","created_at":"2016-12-14T19:43:31Z","updated_at":"2016-12-14T21:40:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1271c3029e104b0a25eff32a87baddd621f048f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lumol-org/lumol/pulls/71/commits","review_comments_url":"https://api.github.com/repos/lumol-org/lumol/pulls/71/comments","review_comment_url":"https://api.github.com/repos/lumol-org/lumol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lumol-org/lumol/issues/71/comments","statuses_url":"https://api.github.com/repos/lumol-org/lumol/statuses/34712690cce406c172fd3d0cd0664816e2505d6b","head":{"label":"g-bauer:largest_cutoff","ref":"largest_cutoff","sha":"34712690cce406c172fd3d0cd0664816e2505d6b","user":{"login":"g-bauer","id":7261278,"avatar_url":"https://avatars.githubusercontent.com/u/7261278?v=3","gravatar_id":"","url":"https://api.github.com/users/g-bauer","html_url":"https://github.com/g-bauer","followers_url":"https://api.github.com/users/g-bauer/followers","following_url":"https://api.github.com/users/g-bauer/following{/other_user}","gists_url":"https://api.github.com/users/g-bauer/gists{/gist_id}","starred_url":"https://api.github.com/users/g-bauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-bauer/subscriptions","organizations_url":"https://api.github.com/users/g-bauer/orgs","repos_url":"https://api.github.com/users/g-bauer/repos","events_url":"https://api.github.com/users/g-bauer/events{/privacy}","received_events_url":"https://api.github.com/users/g-bauer/received_events","type":"User","site_admin":false},"repo":{"id":70499339,"name":"lumol","full_name":"g-bauer/lumol","owner":{"login":"g-bauer","id":7261278,"avatar_url":"https://avatars.githubusercontent.com/u/7261278?v=3","gravatar_id":"","url":"https://api.github.com/users/g-bauer","html_url":"https://github.com/g-bauer","followers_url":"https://api.github.com/users/g-bauer/followers","following_url":"https://api.github.com/users/g-bauer/following{/other_user}","gists_url":"https://api.github.com/users/g-bauer/gists{/gist_id}","starred_url":"https://api.github.com/users/g-bauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-bauer/subscriptions","organizations_url":"https://api.github.com/users/g-bauer/orgs","repos_url":"https://api.github.com/users/g-bauer/repos","events_url":"https://api.github.com/users/g-bauer/events{/privacy}","received_events_url":"https://api.github.com/users/g-bauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/g-bauer/lumol","description":"Extensible molecular simulation engine","fork":true,"url":"https://api.github.com/repos/g-bauer/lumol","forks_url":"https://api.github.com/repos/g-bauer/lumol/forks","keys_url":"https://api.github.com/repos/g-bauer/lumol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/g-bauer/lumol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/g-bauer/lumol/teams","hooks_url":"https://api.github.com/repos/g-bauer/lumol/hooks","issue_events_url":"https://api.github.com/repos/g-bauer/lumol/issues/events{/number}","events_url":"https://api.github.com/repos/g-bauer/lumol/events","assignees_url":"https://api.github.com/repos/g-bauer/lumol/assignees{/user}","branches_url":"https://api.github.com/repos/g-bauer/lumol/branches{/branch}","tags_url":"https://api.github.com/repos/g-bauer/lumol/tags","blobs_url":"https://api.github.com/repos/g-bauer/lumol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/g-bauer/lumol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/g-bauer/lumol/git/refs{/sha}","trees_url":"https://api.github.com/repos/g-bauer/lumol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/g-bauer/lumol/statuses/{sha}","languages_url":"https://api.github.com/repos/g-bauer/lumol/languages","stargazers_url":"https://api.github.com/repos/g-bauer/lumol/stargazers","contributors_url":"https://api.github.com/repos/g-bauer/lumol/contributors","subscribers_url":"https://api.github.com/repos/g-bauer/lumol/subscribers","subscription_url":"https://api.github.com/repos/g-bauer/lumol/subscription","commits_url":"https://api.github.com/repos/g-bauer/lumol/commits{/sha}","git_commits_url":"https://api.github.com/repos/g-bauer/lumol/git/commits{/sha}","comments_url":"https://api.github.com/repos/g-bauer/lumol/comments{/number}","issue_comment_url":"https://api.github.com/repos/g-bauer/lumol/issues/comments{/number}","contents_url":"https://api.github.com/repos/g-bauer/lumol/contents/{+path}","compare_url":"https://api.github.com/repos/g-bauer/lumol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/g-bauer/lumol/merges","archive_url":"https://api.github.com/repos/g-bauer/lumol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/g-bauer/lumol/downloads","issues_url":"https://api.github.com/repos/g-bauer/lumol/issues{/number}","pulls_url":"https://api.github.com/repos/g-bauer/lumol/pulls{/number}","milestones_url":"https://api.github.com/repos/g-bauer/lumol/milestones{/number}","notifications_url":"https://api.github.com/repos/g-bauer/lumol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/g-bauer/lumol/labels{/name}","releases_url":"https://api.github.com/repos/g-bauer/lumol/releases{/id}","deployments_url":"https://api.github.com/repos/g-bauer/lumol/deployments","created_at":"2016-10-10T15:03:50Z","updated_at":"2016-10-10T15:03:52Z","pushed_at":"2016-12-14T19:40:27Z","git_url":"git://github.com/g-bauer/lumol.git","ssh_url":"git@github.com:g-bauer/lumol.git","clone_url":"https://github.com/g-bauer/lumol.git","svn_url":"https://github.com/g-bauer/lumol","homepage":"http://lumol-org.github.io/lumol","size":9236,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lumol-org:master","ref":"master","sha":"75723f66e6b57ddb98856353d1536d5d4d2fc517","user":{"login":"lumol-org","id":22148160,"avatar_url":"https://avatars.githubusercontent.com/u/22148160?v=3","gravatar_id":"","url":"https://api.github.com/users/lumol-org","html_url":"https://github.com/lumol-org","followers_url":"https://api.github.com/users/lumol-org/followers","following_url":"https://api.github.com/users/lumol-org/following{/other_user}","gists_url":"https://api.github.com/users/lumol-org/gists{/gist_id}","starred_url":"https://api.github.com/users/lumol-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumol-org/subscriptions","organizations_url":"https://api.github.com/users/lumol-org/orgs","repos_url":"https://api.github.com/users/lumol-org/repos","events_url":"https://api.github.com/users/lumol-org/events{/privacy}","received_events_url":"https://api.github.com/users/lumol-org/received_events","type":"Organization","site_admin":false},"repo":{"id":36255509,"name":"lumol","full_name":"lumol-org/lumol","owner":{"login":"lumol-org","id":22148160,"avatar_url":"https://avatars.githubusercontent.com/u/22148160?v=3","gravatar_id":"","url":"https://api.github.com/users/lumol-org","html_url":"https://github.com/lumol-org","followers_url":"https://api.github.com/users/lumol-org/followers","following_url":"https://api.github.com/users/lumol-org/following{/other_user}","gists_url":"https://api.github.com/users/lumol-org/gists{/gist_id}","starred_url":"https://api.github.com/users/lumol-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumol-org/subscriptions","organizations_url":"https://api.github.com/users/lumol-org/orgs","repos_url":"https://api.github.com/users/lumol-org/repos","events_url":"https://api.github.com/users/lumol-org/events{/privacy}","received_events_url":"https://api.github.com/users/lumol-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lumol-org/lumol","description":"Extensible molecular simulation engine","fork":false,"url":"https://api.github.com/repos/lumol-org/lumol","forks_url":"https://api.github.com/repos/lumol-org/lumol/forks","keys_url":"https://api.github.com/repos/lumol-org/lumol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumol-org/lumol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumol-org/lumol/teams","hooks_url":"https://api.github.com/repos/lumol-org/lumol/hooks","issue_events_url":"https://api.github.com/repos/lumol-org/lumol/issues/events{/number}","events_url":"https://api.github.com/repos/lumol-org/lumol/events","assignees_url":"https://api.github.com/repos/lumol-org/lumol/assignees{/user}","branches_url":"https://api.github.com/repos/lumol-org/lumol/branches{/branch}","tags_url":"https://api.github.com/repos/lumol-org/lumol/tags","blobs_url":"https://api.github.com/repos/lumol-org/lumol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumol-org/lumol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumol-org/lumol/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumol-org/lumol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumol-org/lumol/statuses/{sha}","languages_url":"https://api.github.com/repos/lumol-org/lumol/languages","stargazers_url":"https://api.github.com/repos/lumol-org/lumol/stargazers","contributors_url":"https://api.github.com/repos/lumol-org/lumol/contributors","subscribers_url":"https://api.github.com/repos/lumol-org/lumol/subscribers","subscription_url":"https://api.github.com/repos/lumol-org/lumol/subscription","commits_url":"https://api.github.com/repos/lumol-org/lumol/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumol-org/lumol/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumol-org/lumol/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumol-org/lumol/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumol-org/lumol/contents/{+path}","compare_url":"https://api.github.com/repos/lumol-org/lumol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumol-org/lumol/merges","archive_url":"https://api.github.com/repos/lumol-org/lumol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumol-org/lumol/downloads","issues_url":"https://api.github.com/repos/lumol-org/lumol/issues{/number}","pulls_url":"https://api.github.com/repos/lumol-org/lumol/pulls{/number}","milestones_url":"https://api.github.com/repos/lumol-org/lumol/milestones{/number}","notifications_url":"https://api.github.com/repos/lumol-org/lumol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumol-org/lumol/labels{/name}","releases_url":"https://api.github.com/repos/lumol-org/lumol/releases{/id}","deployments_url":"https://api.github.com/repos/lumol-org/lumol/deployments","created_at":"2015-05-25T21:28:53Z","updated_at":"2016-11-28T17:59:05Z","pushed_at":"2016-12-14T19:43:31Z","git_url":"git://github.com/lumol-org/lumol.git","ssh_url":"git@github.com:lumol-org/lumol.git","clone_url":"https://github.com/lumol-org/lumol.git","svn_url":"https://github.com/lumol-org/lumol","homepage":"http://lumol-org.github.io/lumol","size":11756,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":43,"forks":2,"open_issues":43,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lumol-org/lumol/pulls/71"},"html":{"href":"https://github.com/lumol-org/lumol/pull/71"},"issue":{"href":"https://api.github.com/repos/lumol-org/lumol/issues/71"},"comments":{"href":"https://api.github.com/repos/lumol-org/lumol/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/lumol-org/lumol/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/lumol-org/lumol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lumol-org/lumol/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/lumol-org/lumol/statuses/34712690cce406c172fd3d0cd0664816e2505d6b"}}}}
{"actor":{"display_login":"Luthaf"}}