{"action":"created","comment":{"url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/comments/66141203","id":66141203,"diff_hunk":"@@ -0,0 +1,74 @@\n+//= require jquery\n+//= require countdown\n+\n+describe(\"Coundown\", function() {\n+\n+\n+  describe(\"auction is on going\", function() {\n+    beforeEach(function (){\n+      this.auctionEndTime = Date.now() + 237300000;\n+      fixture.set('<p id=\"auction_end_time\">' + new Date(this.auctionEndTime) + '</p> <p id=\"days\">days</p> </p>' +\n+          '<p id=\"hours\">hours</p>' + '<p id=\"minutes\">minutes</p>' + '<p id=\"seconds\">seconds</p>' + '<button id=\"buy_now_button\">' + '<p id=\"bid_now_form\"></p>');\n+      this.trackingElements = {\n+        days: $(\"#days\"),\n+        hours: $(\"#hours\"),\n+        minutes: $(\"#minutes\"),\n+        seconds: $(\"#seconds\"),\n+        auction_end_time: $(\"#auction_end_time\"),\n+        buy_now_button: $(\"#buy_now_button\"),\n+        bid_now_form: $(\"#bid_now_form\")\n+      };\n+      this.countdown = new Countdown(this.trackingElements);\n+      this.countdown.start();\n+    });\n+\n+    it(\"updates countdown in the dom\", function() {\n+\n+      expect($(\"#days\", fixture.el).text()).toBe(\"2\");\n+      expect($(\"#hours\", fixture.el).text()).toBe(\"17\");\n+      expect($(\"#minutes\", fixture.el).text()).toBe(\"54\");\n+      expect($(\"#seconds\", fixture.el).text()).toBe(\"59\");\n+      expect($(\"#auction_end_time\", fixture.el).text()).toEqual(new Date(this.auctionEndTime).toString());\n+    });\n+\n+    it(\"does not hide the auction end time and buy now buttons\", function() {\n+\n+      expect($('#buy_now_button').is(':visible')).toBe(true);\n+      expect($('#bid_now_form').is(':visible')).toBe(true);\n+    });\n+  });\n+\n+  describe(\"auction is closed\", function() {","path":"spec/javascripts/countdown_spec.js","position":41,"original_position":41,"commit_id":"6fc9a7a0eb080848db044efe1370783413c34847","original_commit_id":"6fc9a7a0eb080848db044efe1370783413c34847","user":{"login":"kevinbuch","id":4039018,"avatar_url":"https://avatars.githubusercontent.com/u/4039018?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinbuch","html_url":"https://github.com/kevinbuch","followers_url":"https://api.github.com/users/kevinbuch/followers","following_url":"https://api.github.com/users/kevinbuch/following{/other_user}","gists_url":"https://api.github.com/users/kevinbuch/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbuch/subscriptions","organizations_url":"https://api.github.com/users/kevinbuch/orgs","repos_url":"https://api.github.com/users/kevinbuch/repos","events_url":"https://api.github.com/users/kevinbuch/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbuch/received_events","type":"User","site_admin":false},"body":"It would be nicer if these tests weren't auction-specific, in order to demonstrate some reuse of your Countdown object.","created_at":"2016-06-07T19:58:28Z","updated_at":"2016-06-07T19:58:28Z","html_url":"https://github.com/andarcabrera/ebay_clone/pull/5#discussion_r66141203","pull_request_url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/comments/66141203"},"html":{"href":"https://github.com/andarcabrera/ebay_clone/pull/5#discussion_r66141203"},"pull_request":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5","id":72428403,"html_url":"https://github.com/andarcabrera/ebay_clone/pull/5","diff_url":"https://github.com/andarcabrera/ebay_clone/pull/5.diff","patch_url":"https://github.com/andarcabrera/ebay_clone/pull/5.patch","issue_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/5","number":5,"state":"open","locked":false,"title":"Bidding","user":{"login":"andarcabrera","id":11791558,"avatar_url":"https://avatars.githubusercontent.com/u/11791558?v=3","gravatar_id":"","url":"https://api.github.com/users/andarcabrera","html_url":"https://github.com/andarcabrera","followers_url":"https://api.github.com/users/andarcabrera/followers","following_url":"https://api.github.com/users/andarcabrera/following{/other_user}","gists_url":"https://api.github.com/users/andarcabrera/gists{/gist_id}","starred_url":"https://api.github.com/users/andarcabrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andarcabrera/subscriptions","organizations_url":"https://api.github.com/users/andarcabrera/orgs","repos_url":"https://api.github.com/users/andarcabrera/repos","events_url":"https://api.github.com/users/andarcabrera/events{/privacy}","received_events_url":"https://api.github.com/users/andarcabrera/received_events","type":"User","site_admin":false},"body":"Hi Alex and Kevin,\r\n\r\nHere is our pull request for the bidding story:\r\n\r\nWhen I create an item I can:\r\n- Input a starting bid amount\r\n- Input an auction end time\r\n\r\nIf I create an item with a buy it now price:\r\n- Users can buy it now at that price.\r\n\r\nIf I create an item with a starting bid amount and auction end time:\r\n- Users can place bids on the item\r\n- Bids must be higher than the current bid\r\n- The web page should show the amount of time left to bid on the item\r\n-- The time should be up to the second, and the seconds should update live\r\n- When the auction ends at the end time\r\n-- the item is marked as sold to the highest bidder\r\n-- the bidder and seller receive a notice.\r\nItems can be both buy it now, and up for auction.\r\n\r\nNOTES\r\n\r\nWe are submitting this for feedback, with a few to do's left:\r\n- testing and refactoring our javascript countdown timer\r\n- writing the rake task for the migration\r\n- UI improvements\r\n- we will continue on the above tomorrow morning but Kevin suggested making the pull request now to give you time to leave feedback. The main functionality of our story is done.","created_at":"2016-06-02T22:31:53Z","updated_at":"2016-06-07T19:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d367c44b0c8ab4ed5b1a190c0d3781335b9b14e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5/commits","review_comments_url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5/comments","review_comment_url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/5/comments","statuses_url":"https://api.github.com/repos/andarcabrera/ebay_clone/statuses/6fc9a7a0eb080848db044efe1370783413c34847","head":{"label":"andarcabrera:bidding","ref":"bidding","sha":"6fc9a7a0eb080848db044efe1370783413c34847","user":{"login":"andarcabrera","id":11791558,"avatar_url":"https://avatars.githubusercontent.com/u/11791558?v=3","gravatar_id":"","url":"https://api.github.com/users/andarcabrera","html_url":"https://github.com/andarcabrera","followers_url":"https://api.github.com/users/andarcabrera/followers","following_url":"https://api.github.com/users/andarcabrera/following{/other_user}","gists_url":"https://api.github.com/users/andarcabrera/gists{/gist_id}","starred_url":"https://api.github.com/users/andarcabrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andarcabrera/subscriptions","organizations_url":"https://api.github.com/users/andarcabrera/orgs","repos_url":"https://api.github.com/users/andarcabrera/repos","events_url":"https://api.github.com/users/andarcabrera/events{/privacy}","received_events_url":"https://api.github.com/users/andarcabrera/received_events","type":"User","site_admin":false},"repo":{"id":58469468,"name":"ebay_clone","full_name":"andarcabrera/ebay_clone","owner":{"login":"andarcabrera","id":11791558,"avatar_url":"https://avatars.githubusercontent.com/u/11791558?v=3","gravatar_id":"","url":"https://api.github.com/users/andarcabrera","html_url":"https://github.com/andarcabrera","followers_url":"https://api.github.com/users/andarcabrera/followers","following_url":"https://api.github.com/users/andarcabrera/following{/other_user}","gists_url":"https://api.github.com/users/andarcabrera/gists{/gist_id}","starred_url":"https://api.github.com/users/andarcabrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andarcabrera/subscriptions","organizations_url":"https://api.github.com/users/andarcabrera/orgs","repos_url":"https://api.github.com/users/andarcabrera/repos","events_url":"https://api.github.com/users/andarcabrera/events{/privacy}","received_events_url":"https://api.github.com/users/andarcabrera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andarcabrera/ebay_clone","description":"A Rails Ebay clone project","fork":false,"url":"https://api.github.com/repos/andarcabrera/ebay_clone","forks_url":"https://api.github.com/repos/andarcabrera/ebay_clone/forks","keys_url":"https://api.github.com/repos/andarcabrera/ebay_clone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andarcabrera/ebay_clone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andarcabrera/ebay_clone/teams","hooks_url":"https://api.github.com/repos/andarcabrera/ebay_clone/hooks","issue_events_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/events{/number}","events_url":"https://api.github.com/repos/andarcabrera/ebay_clone/events","assignees_url":"https://api.github.com/repos/andarcabrera/ebay_clone/assignees{/user}","branches_url":"https://api.github.com/repos/andarcabrera/ebay_clone/branches{/branch}","tags_url":"https://api.github.com/repos/andarcabrera/ebay_clone/tags","blobs_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/refs{/sha}","trees_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andarcabrera/ebay_clone/statuses/{sha}","languages_url":"https://api.github.com/repos/andarcabrera/ebay_clone/languages","stargazers_url":"https://api.github.com/repos/andarcabrera/ebay_clone/stargazers","contributors_url":"https://api.github.com/repos/andarcabrera/ebay_clone/contributors","subscribers_url":"https://api.github.com/repos/andarcabrera/ebay_clone/subscribers","subscription_url":"https://api.github.com/repos/andarcabrera/ebay_clone/subscription","commits_url":"https://api.github.com/repos/andarcabrera/ebay_clone/commits{/sha}","git_commits_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/commits{/sha}","comments_url":"https://api.github.com/repos/andarcabrera/ebay_clone/comments{/number}","issue_comment_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/comments{/number}","contents_url":"https://api.github.com/repos/andarcabrera/ebay_clone/contents/{+path}","compare_url":"https://api.github.com/repos/andarcabrera/ebay_clone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andarcabrera/ebay_clone/merges","archive_url":"https://api.github.com/repos/andarcabrera/ebay_clone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andarcabrera/ebay_clone/downloads","issues_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues{/number}","pulls_url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls{/number}","milestones_url":"https://api.github.com/repos/andarcabrera/ebay_clone/milestones{/number}","notifications_url":"https://api.github.com/repos/andarcabrera/ebay_clone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andarcabrera/ebay_clone/labels{/name}","releases_url":"https://api.github.com/repos/andarcabrera/ebay_clone/releases{/id}","deployments_url":"https://api.github.com/repos/andarcabrera/ebay_clone/deployments","created_at":"2016-05-10T14:44:00Z","updated_at":"2016-05-10T14:47:08Z","pushed_at":"2016-06-07T18:26:06Z","git_url":"git://github.com/andarcabrera/ebay_clone.git","ssh_url":"git@github.com:andarcabrera/ebay_clone.git","clone_url":"https://github.com/andarcabrera/ebay_clone.git","svn_url":"https://github.com/andarcabrera/ebay_clone","homepage":null,"size":1773,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"andarcabrera:master","ref":"master","sha":"8404823e250593caa2f536684d435d839a5341b4","user":{"login":"andarcabrera","id":11791558,"avatar_url":"https://avatars.githubusercontent.com/u/11791558?v=3","gravatar_id":"","url":"https://api.github.com/users/andarcabrera","html_url":"https://github.com/andarcabrera","followers_url":"https://api.github.com/users/andarcabrera/followers","following_url":"https://api.github.com/users/andarcabrera/following{/other_user}","gists_url":"https://api.github.com/users/andarcabrera/gists{/gist_id}","starred_url":"https://api.github.com/users/andarcabrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andarcabrera/subscriptions","organizations_url":"https://api.github.com/users/andarcabrera/orgs","repos_url":"https://api.github.com/users/andarcabrera/repos","events_url":"https://api.github.com/users/andarcabrera/events{/privacy}","received_events_url":"https://api.github.com/users/andarcabrera/received_events","type":"User","site_admin":false},"repo":{"id":58469468,"name":"ebay_clone","full_name":"andarcabrera/ebay_clone","owner":{"login":"andarcabrera","id":11791558,"avatar_url":"https://avatars.githubusercontent.com/u/11791558?v=3","gravatar_id":"","url":"https://api.github.com/users/andarcabrera","html_url":"https://github.com/andarcabrera","followers_url":"https://api.github.com/users/andarcabrera/followers","following_url":"https://api.github.com/users/andarcabrera/following{/other_user}","gists_url":"https://api.github.com/users/andarcabrera/gists{/gist_id}","starred_url":"https://api.github.com/users/andarcabrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andarcabrera/subscriptions","organizations_url":"https://api.github.com/users/andarcabrera/orgs","repos_url":"https://api.github.com/users/andarcabrera/repos","events_url":"https://api.github.com/users/andarcabrera/events{/privacy}","received_events_url":"https://api.github.com/users/andarcabrera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andarcabrera/ebay_clone","description":"A Rails Ebay clone project","fork":false,"url":"https://api.github.com/repos/andarcabrera/ebay_clone","forks_url":"https://api.github.com/repos/andarcabrera/ebay_clone/forks","keys_url":"https://api.github.com/repos/andarcabrera/ebay_clone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andarcabrera/ebay_clone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andarcabrera/ebay_clone/teams","hooks_url":"https://api.github.com/repos/andarcabrera/ebay_clone/hooks","issue_events_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/events{/number}","events_url":"https://api.github.com/repos/andarcabrera/ebay_clone/events","assignees_url":"https://api.github.com/repos/andarcabrera/ebay_clone/assignees{/user}","branches_url":"https://api.github.com/repos/andarcabrera/ebay_clone/branches{/branch}","tags_url":"https://api.github.com/repos/andarcabrera/ebay_clone/tags","blobs_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/refs{/sha}","trees_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andarcabrera/ebay_clone/statuses/{sha}","languages_url":"https://api.github.com/repos/andarcabrera/ebay_clone/languages","stargazers_url":"https://api.github.com/repos/andarcabrera/ebay_clone/stargazers","contributors_url":"https://api.github.com/repos/andarcabrera/ebay_clone/contributors","subscribers_url":"https://api.github.com/repos/andarcabrera/ebay_clone/subscribers","subscription_url":"https://api.github.com/repos/andarcabrera/ebay_clone/subscription","commits_url":"https://api.github.com/repos/andarcabrera/ebay_clone/commits{/sha}","git_commits_url":"https://api.github.com/repos/andarcabrera/ebay_clone/git/commits{/sha}","comments_url":"https://api.github.com/repos/andarcabrera/ebay_clone/comments{/number}","issue_comment_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/comments{/number}","contents_url":"https://api.github.com/repos/andarcabrera/ebay_clone/contents/{+path}","compare_url":"https://api.github.com/repos/andarcabrera/ebay_clone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andarcabrera/ebay_clone/merges","archive_url":"https://api.github.com/repos/andarcabrera/ebay_clone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andarcabrera/ebay_clone/downloads","issues_url":"https://api.github.com/repos/andarcabrera/ebay_clone/issues{/number}","pulls_url":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls{/number}","milestones_url":"https://api.github.com/repos/andarcabrera/ebay_clone/milestones{/number}","notifications_url":"https://api.github.com/repos/andarcabrera/ebay_clone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andarcabrera/ebay_clone/labels{/name}","releases_url":"https://api.github.com/repos/andarcabrera/ebay_clone/releases{/id}","deployments_url":"https://api.github.com/repos/andarcabrera/ebay_clone/deployments","created_at":"2016-05-10T14:44:00Z","updated_at":"2016-05-10T14:47:08Z","pushed_at":"2016-06-07T18:26:06Z","git_url":"git://github.com/andarcabrera/ebay_clone.git","ssh_url":"git@github.com:andarcabrera/ebay_clone.git","clone_url":"https://github.com/andarcabrera/ebay_clone.git","svn_url":"https://github.com/andarcabrera/ebay_clone","homepage":null,"size":1773,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5"},"html":{"href":"https://github.com/andarcabrera/ebay_clone/pull/5"},"issue":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/5"},"comments":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/andarcabrera/ebay_clone/statuses/6fc9a7a0eb080848db044efe1370783413c34847"}}}}
{"actor":{"display_login":"kevinbuch"}}