{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/748","repository_url":"https://api.github.com/repos/wikimedia/wikipedia-ios","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/748/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/748/comments","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/748/events","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/748","id":162607931,"number":748,"title":"Remove MWKTitle and MWKSite","user":{"login":"coreyfloyd","id":64771,"avatar_url":"https://avatars.githubusercontent.com/u/64771?v=3","gravatar_id":"","url":"https://api.github.com/users/coreyfloyd","html_url":"https://github.com/coreyfloyd","followers_url":"https://api.github.com/users/coreyfloyd/followers","following_url":"https://api.github.com/users/coreyfloyd/following{/other_user}","gists_url":"https://api.github.com/users/coreyfloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyfloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyfloyd/subscriptions","organizations_url":"https://api.github.com/users/coreyfloyd/orgs","repos_url":"https://api.github.com/users/coreyfloyd/repos","events_url":"https://api.github.com/users/coreyfloyd/events{/privacy}","received_events_url":"https://api.github.com/users/coreyfloyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-06-28T05:53:00Z","updated_at":"2016-07-26T17:49:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/748","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/748","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/748.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/748.patch"},"body":"This pr removes all references to MWKSite and MWKTitle in favor of the new NSURL methods. \r\n\r\n- [x] Replace all references to MWKTitle and MWKSite\r\n- [x] Handle deserialization of Saved pages\r\n- [x] Handle deserialization of history\r\n- [x] Update Unit Tests\r\n- [x] Update and verify deserialization of all former persisted classes\r\n- [x] Rename all \"domainURL\" references to \"siteURL\"\r\n- [x] File separate ticket to re-enable saved page fetcher tests\r\n\r\n\r\nOut of scope for this PR:\r\n- Any refactoring of logic that is now duplicative due to NSURLs being used for both title and site (refactoring such as this should be performed while boyscouting during normal development)\r\n- Preserving the persisted feed data (The feed model will be completely changed during the feed refactor)"},"comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments/235349027","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/748#issuecomment-235349027","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/748","id":235349027,"user":{"login":"joewalsh","id":741327,"avatar_url":"https://avatars.githubusercontent.com/u/741327?v=3","gravatar_id":"","url":"https://api.github.com/users/joewalsh","html_url":"https://github.com/joewalsh","followers_url":"https://api.github.com/users/joewalsh/followers","following_url":"https://api.github.com/users/joewalsh/following{/other_user}","gists_url":"https://api.github.com/users/joewalsh/gists{/gist_id}","starred_url":"https://api.github.com/users/joewalsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewalsh/subscriptions","organizations_url":"https://api.github.com/users/joewalsh/orgs","repos_url":"https://api.github.com/users/joewalsh/repos","events_url":"https://api.github.com/users/joewalsh/events{/privacy}","received_events_url":"https://api.github.com/users/joewalsh/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T17:49:46Z","updated_at":"2016-07-26T17:49:46Z","body":"@coreyfloyd I understand that it will be fixed before release, but my concern was having compiler warnings on develop that make it harder to discern when new warnings are added. I made some commits that fixed the easier warnings and changed the others to WMF_TECH_DEBT_TODO. Let me know if this works for you"}}
{"actor":{"display_login":"joewalsh"}}