{"action":"created","comment":{"url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/comments/55239133","id":55239133,"diff_hunk":"@@ -86,6 +86,7 @@ class F5LTMPool(resource.Resource, F5BigIPMixin):\n         )\n     }\n \n+    @f5_common_resources","path":"f5_heat/resources/f5_ltm_pool.py","position":4,"original_position":4,"commit_id":"4d1ae85ed0de53bdf036d6451605981d4486948c","original_commit_id":"4d1ae85ed0de53bdf036d6451605981d4486948c","user":{"login":"zancas","id":640955,"avatar_url":"https://avatars.githubusercontent.com/u/640955?v=3","gravatar_id":"","url":"https://api.github.com/users/zancas","html_url":"https://github.com/zancas","followers_url":"https://api.github.com/users/zancas/followers","following_url":"https://api.github.com/users/zancas/following{/other_user}","gists_url":"https://api.github.com/users/zancas/gists{/gist_id}","starred_url":"https://api.github.com/users/zancas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zancas/subscriptions","organizations_url":"https://api.github.com/users/zancas/orgs","repos_url":"https://api.github.com/users/zancas/repos","events_url":"https://api.github.com/users/zancas/events{/privacy}","received_events_url":"https://api.github.com/users/zancas/received_events","type":"User","site_admin":false},"body":"Consider moving the definition of '`f5_common_resources`' into '`F5BigIPMixin`', and calling it as an instance method inside the method it is currently decorating, e.g.:\r\n`self._f5_common_resources`.\r\n\r\nAlso, its name should probably start with '_'.","created_at":"2016-03-07T17:33:28Z","updated_at":"2016-03-07T17:33:28Z","html_url":"https://github.com/F5Networks/f5-openstack-heat-plugins/pull/8#discussion_r55239133","pull_request_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/comments/55239133"},"html":{"href":"https://github.com/F5Networks/f5-openstack-heat-plugins/pull/8#discussion_r55239133"},"pull_request":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8","id":61859322,"html_url":"https://github.com/F5Networks/f5-openstack-heat-plugins/pull/8","diff_url":"https://github.com/F5Networks/f5-openstack-heat-plugins/pull/8.diff","patch_url":"https://github.com/F5Networks/f5-openstack-heat-plugins/pull/8.patch","issue_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/issues/8","number":8,"state":"open","locked":false,"title":"Split iapp_template into two plugins","user":{"login":"pjbreaux","id":14225800,"avatar_url":"https://avatars.githubusercontent.com/u/14225800?v=3","gravatar_id":"","url":"https://api.github.com/users/pjbreaux","html_url":"https://github.com/pjbreaux","followers_url":"https://api.github.com/users/pjbreaux/followers","following_url":"https://api.github.com/users/pjbreaux/following{/other_user}","gists_url":"https://api.github.com/users/pjbreaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbreaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbreaux/subscriptions","organizations_url":"https://api.github.com/users/pjbreaux/orgs","repos_url":"https://api.github.com/users/pjbreaux/repos","events_url":"https://api.github.com/users/pjbreaux/events{/privacy}","received_events_url":"https://api.github.com/users/pjbreaux/received_events","type":"User","site_admin":false},"body":"@zancas \r\n\r\n#### What's this change do?\r\nThe f5_sys_iapptemplate plugin needs to be split into two plugins: one for a full template upload, and the other for a composite template.\r\n\r\nThere's a great deal of changes in the yaml templates. Mostly copy paste and changing file names. The other fixups are to migrate from one plugin to two.\r\n\r\n#### Any background context?\r\nThis is to be done for usability and readability, as they are two different starting points that reach the same end (creating an iapp template on the bigip). When these two plugins were squashed into one plugin, there was extra logic to facilitate both types of input. This was becoming cumbersome and difficult to read.\r\n\r\n@swormke: Wondering about how docs should be handled for this new plugin?\r\n\r\n#### Where should the reviewer start?\r\nStart at the unit tests","created_at":"2016-03-06T23:26:41Z","updated_at":"2016-03-07T17:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"621aef31e926c46981ed08763abbf40a8050ec29","assignee":{"login":"zancas","id":640955,"avatar_url":"https://avatars.githubusercontent.com/u/640955?v=3","gravatar_id":"","url":"https://api.github.com/users/zancas","html_url":"https://github.com/zancas","followers_url":"https://api.github.com/users/zancas/followers","following_url":"https://api.github.com/users/zancas/following{/other_user}","gists_url":"https://api.github.com/users/zancas/gists{/gist_id}","starred_url":"https://api.github.com/users/zancas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zancas/subscriptions","organizations_url":"https://api.github.com/users/zancas/orgs","repos_url":"https://api.github.com/users/zancas/repos","events_url":"https://api.github.com/users/zancas/events{/privacy}","received_events_url":"https://api.github.com/users/zancas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8/commits","review_comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8/comments","review_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/issues/8/comments","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/statuses/4d1ae85ed0de53bdf036d6451605981d4486948c","head":{"label":"pjbreaux:feature.split_iapp_template_3","ref":"feature.split_iapp_template_3","sha":"4d1ae85ed0de53bdf036d6451605981d4486948c","user":{"login":"pjbreaux","id":14225800,"avatar_url":"https://avatars.githubusercontent.com/u/14225800?v=3","gravatar_id":"","url":"https://api.github.com/users/pjbreaux","html_url":"https://github.com/pjbreaux","followers_url":"https://api.github.com/users/pjbreaux/followers","following_url":"https://api.github.com/users/pjbreaux/following{/other_user}","gists_url":"https://api.github.com/users/pjbreaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbreaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbreaux/subscriptions","organizations_url":"https://api.github.com/users/pjbreaux/orgs","repos_url":"https://api.github.com/users/pjbreaux/repos","events_url":"https://api.github.com/users/pjbreaux/events{/privacy}","received_events_url":"https://api.github.com/users/pjbreaux/received_events","type":"User","site_admin":false},"repo":{"id":52285876,"name":"f5-openstack-heat-plugins-1","full_name":"pjbreaux/f5-openstack-heat-plugins-1","owner":{"login":"pjbreaux","id":14225800,"avatar_url":"https://avatars.githubusercontent.com/u/14225800?v=3","gravatar_id":"","url":"https://api.github.com/users/pjbreaux","html_url":"https://github.com/pjbreaux","followers_url":"https://api.github.com/users/pjbreaux/followers","following_url":"https://api.github.com/users/pjbreaux/following{/other_user}","gists_url":"https://api.github.com/users/pjbreaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbreaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbreaux/subscriptions","organizations_url":"https://api.github.com/users/pjbreaux/orgs","repos_url":"https://api.github.com/users/pjbreaux/repos","events_url":"https://api.github.com/users/pjbreaux/events{/privacy}","received_events_url":"https://api.github.com/users/pjbreaux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjbreaux/f5-openstack-heat-plugins-1","description":"F5 Networks OpenStack Heat Plugin Library","fork":true,"url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1","forks_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/forks","keys_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/teams","hooks_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/hooks","issue_events_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/issues/events{/number}","events_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/events","assignees_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/assignees{/user}","branches_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/branches{/branch}","tags_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/tags","blobs_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/statuses/{sha}","languages_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/languages","stargazers_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/stargazers","contributors_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/contributors","subscribers_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/subscribers","subscription_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/subscription","commits_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/contents/{+path}","compare_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/merges","archive_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/downloads","issues_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/issues{/number}","pulls_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/pulls{/number}","milestones_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/milestones{/number}","notifications_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/labels{/name}","releases_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/releases{/id}","deployments_url":"https://api.github.com/repos/pjbreaux/f5-openstack-heat-plugins-1/deployments","created_at":"2016-02-22T16:07:15Z","updated_at":"2016-02-22T16:07:17Z","pushed_at":"2016-03-07T16:42:08Z","git_url":"git://github.com/pjbreaux/f5-openstack-heat-plugins-1.git","ssh_url":"git@github.com:pjbreaux/f5-openstack-heat-plugins-1.git","clone_url":"https://github.com/pjbreaux/f5-openstack-heat-plugins-1.git","svn_url":"https://github.com/pjbreaux/f5-openstack-heat-plugins-1","homepage":"","size":151,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kilo"}},"base":{"label":"F5Networks:kilo","ref":"kilo","sha":"27555a75c390a4ff4c2f0f8a479f57ffe04d336e","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":52217006,"name":"f5-openstack-heat-plugins","full_name":"F5Networks/f5-openstack-heat-plugins","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/f5-openstack-heat-plugins","description":"F5 Networks OpenStack Heat Plugin Library","fork":false,"url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins","forks_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/forks","keys_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/teams","hooks_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/events","assignees_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/tags","blobs_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/languages","stargazers_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/subscription","commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/merges","archive_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/downloads","issues_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/deployments","created_at":"2016-02-21T16:57:03Z","updated_at":"2016-02-21T17:00:21Z","pushed_at":"2016-03-07T16:42:09Z","git_url":"git://github.com/F5Networks/f5-openstack-heat-plugins.git","ssh_url":"git@github.com:F5Networks/f5-openstack-heat-plugins.git","clone_url":"https://github.com/F5Networks/f5-openstack-heat-plugins.git","svn_url":"https://github.com/F5Networks/f5-openstack-heat-plugins","homepage":"","size":119,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":0,"default_branch":"kilo"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8"},"html":{"href":"https://github.com/F5Networks/f5-openstack-heat-plugins/pull/8"},"issue":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/issues/8"},"comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-heat-plugins/statuses/4d1ae85ed0de53bdf036d6451605981d4486948c"}}}}