{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/74241182","id":74241182,"diff_hunk":"@@ -21,15 +26,36 @@ class RedisQueueIntegrationTest extends PHPUnit_Framework_TestCase\n     public function setUp()\n     {\n         parent::setUp();\n+\n+        $host = getenv('REDIS_HOST') ?: '127.0.0.1';\n+        $port = getenv('REDIS_PORT') ?: 6379;\n+\n+        if (static::$connectionFailedOnceWithDefaultsSkip) {\n+            $this->markTestSkipped('Trying default host/port failed, please set environment variable REDIS_HOST & REDIS_PORT to enable '.__CLASS__);\n+\n+            return;\n+        }\n+\n         $this->redis = new Database([\n             'cluster' => false,\n             'default' => [\n-                'host' => '127.0.0.1',\n-                'port' => 6379,\n+                'host' => $host,\n+                'port' => $port,\n                 'database' => 5,\n+                'timeout' => 0.5,","path":"tests/Queue/RedisQueueIntegrationTest.php","position":34,"original_position":34,"commit_id":"2e40d68f4e5d1573e7196e0543a731abcef25da3","original_commit_id":"2e40d68f4e5d1573e7196e0543a731abcef25da3","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"Probably too low.","created_at":"2016-08-10T13:16:59Z","updated_at":"2016-08-10T13:16:59Z","html_url":"https://github.com/laravel/framework/pull/14696#discussion_r74241182","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/14696","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/74241182"},"html":{"href":"https://github.com/laravel/framework/pull/14696#discussion_r74241182"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/14696"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/14696","id":80479274,"html_url":"https://github.com/laravel/framework/pull/14696","diff_url":"https://github.com/laravel/framework/pull/14696.diff","patch_url":"https://github.com/laravel/framework/pull/14696.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/14696","number":14696,"state":"open","locked":false,"title":"[5.3] Fail-safing Queue's Predis/Redis Unit Tests & Move to phpunit.xml.dist","user":{"login":"ralphschindler","id":76674,"avatar_url":"https://avatars.githubusercontent.com/u/76674?v=3","gravatar_id":"","url":"https://api.github.com/users/ralphschindler","html_url":"https://github.com/ralphschindler","followers_url":"https://api.github.com/users/ralphschindler/followers","following_url":"https://api.github.com/users/ralphschindler/following{/other_user}","gists_url":"https://api.github.com/users/ralphschindler/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphschindler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphschindler/subscriptions","organizations_url":"https://api.github.com/users/ralphschindler/orgs","repos_url":"https://api.github.com/users/ralphschindler/repos","events_url":"https://api.github.com/users/ralphschindler/events{/privacy}","received_events_url":"https://api.github.com/users/ralphschindler/received_events","type":"User","site_admin":false},"body":"First, if there is anything in this PR that goes against project philosophy, I won't feel bad if you close it without further consideration.  That said:\r\n\r\nIt would be nice if out-the-box the framework's unit tests passed without errors, instead using test skipping with an appropriate skip message.  Test skips are currently used for Cache Memcached tests when Memcache is not currently available, so I think it might be appropriate to do the same thing for Predis/Redis.  It would also be nice to use the phpunit supported methodology for allowing developers to have custom configurations (project commits phpunit.xml.dist, and ignores phpunit.xml which is used locally).\r\n\r\nThis PR:\r\n- moves phpunit.xml -> phpunit.xml.dist (fully phpunit supported)\r\n- adds Redis environment variables to phpunit.xml.dist which are commented out by default\r\n- adds a one-time connection check to the Queue Redis integration check when default values are used (remainder of connection attempts will be skipped\r\n- adds a 0.5 timeout to Predis client (tests should be fast-ish)","created_at":"2016-08-08T16:16:17Z","updated_at":"2016-08-10T13:16:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b552d4ce7f41aa1d5e9b9ccf56781e76a10cfe0c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/14696/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/14696/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/14696/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/2e40d68f4e5d1573e7196e0543a731abcef25da3","head":{"label":"ralphschindler:feature/testing-environment-variables","ref":"feature/testing-environment-variables","sha":"2e40d68f4e5d1573e7196e0543a731abcef25da3","user":{"login":"ralphschindler","id":76674,"avatar_url":"https://avatars.githubusercontent.com/u/76674?v=3","gravatar_id":"","url":"https://api.github.com/users/ralphschindler","html_url":"https://github.com/ralphschindler","followers_url":"https://api.github.com/users/ralphschindler/followers","following_url":"https://api.github.com/users/ralphschindler/following{/other_user}","gists_url":"https://api.github.com/users/ralphschindler/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphschindler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphschindler/subscriptions","organizations_url":"https://api.github.com/users/ralphschindler/orgs","repos_url":"https://api.github.com/users/ralphschindler/repos","events_url":"https://api.github.com/users/ralphschindler/events{/privacy}","received_events_url":"https://api.github.com/users/ralphschindler/received_events","type":"User","site_admin":false},"repo":{"id":65099015,"name":"laravel-framework","full_name":"ralphschindler/laravel-framework","owner":{"login":"ralphschindler","id":76674,"avatar_url":"https://avatars.githubusercontent.com/u/76674?v=3","gravatar_id":"","url":"https://api.github.com/users/ralphschindler","html_url":"https://github.com/ralphschindler","followers_url":"https://api.github.com/users/ralphschindler/followers","following_url":"https://api.github.com/users/ralphschindler/following{/other_user}","gists_url":"https://api.github.com/users/ralphschindler/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphschindler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphschindler/subscriptions","organizations_url":"https://api.github.com/users/ralphschindler/orgs","repos_url":"https://api.github.com/users/ralphschindler/repos","events_url":"https://api.github.com/users/ralphschindler/events{/privacy}","received_events_url":"https://api.github.com/users/ralphschindler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ralphschindler/laravel-framework","description":null,"fork":true,"url":"https://api.github.com/repos/ralphschindler/laravel-framework","forks_url":"https://api.github.com/repos/ralphschindler/laravel-framework/forks","keys_url":"https://api.github.com/repos/ralphschindler/laravel-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ralphschindler/laravel-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ralphschindler/laravel-framework/teams","hooks_url":"https://api.github.com/repos/ralphschindler/laravel-framework/hooks","issue_events_url":"https://api.github.com/repos/ralphschindler/laravel-framework/issues/events{/number}","events_url":"https://api.github.com/repos/ralphschindler/laravel-framework/events","assignees_url":"https://api.github.com/repos/ralphschindler/laravel-framework/assignees{/user}","branches_url":"https://api.github.com/repos/ralphschindler/laravel-framework/branches{/branch}","tags_url":"https://api.github.com/repos/ralphschindler/laravel-framework/tags","blobs_url":"https://api.github.com/repos/ralphschindler/laravel-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ralphschindler/laravel-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ralphschindler/laravel-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ralphschindler/laravel-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ralphschindler/laravel-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ralphschindler/laravel-framework/languages","stargazers_url":"https://api.github.com/repos/ralphschindler/laravel-framework/stargazers","contributors_url":"https://api.github.com/repos/ralphschindler/laravel-framework/contributors","subscribers_url":"https://api.github.com/repos/ralphschindler/laravel-framework/subscribers","subscription_url":"https://api.github.com/repos/ralphschindler/laravel-framework/subscription","commits_url":"https://api.github.com/repos/ralphschindler/laravel-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ralphschindler/laravel-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ralphschindler/laravel-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ralphschindler/laravel-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ralphschindler/laravel-framework/contents/{+path}","compare_url":"https://api.github.com/repos/ralphschindler/laravel-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ralphschindler/laravel-framework/merges","archive_url":"https://api.github.com/repos/ralphschindler/laravel-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ralphschindler/laravel-framework/downloads","issues_url":"https://api.github.com/repos/ralphschindler/laravel-framework/issues{/number}","pulls_url":"https://api.github.com/repos/ralphschindler/laravel-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ralphschindler/laravel-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ralphschindler/laravel-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ralphschindler/laravel-framework/labels{/name}","releases_url":"https://api.github.com/repos/ralphschindler/laravel-framework/releases{/id}","deployments_url":"https://api.github.com/repos/ralphschindler/laravel-framework/deployments","created_at":"2016-08-06T19:40:12Z","updated_at":"2016-08-06T19:47:23Z","pushed_at":"2016-08-08T16:19:49Z","git_url":"git://github.com/ralphschindler/laravel-framework.git","ssh_url":"git@github.com:ralphschindler/laravel-framework.git","clone_url":"https://github.com/ralphschindler/laravel-framework.git","svn_url":"https://github.com/ralphschindler/laravel-framework","homepage":"http://laravel.com","size":23278,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"laravel:5.3","ref":"5.3","sha":"e5f9b5d23d6dd42272b0481ef9fb07d2583d1163","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2016-08-10T12:58:33Z","pushed_at":"2016-08-10T13:15:32Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":49536,"stargazers_count":5703,"watchers_count":5703,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3312,"mirror_url":null,"open_issues_count":187,"forks":3312,"open_issues":187,"watchers":5703,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/14696"},"html":{"href":"https://github.com/laravel/framework/pull/14696"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/14696"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/14696/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/14696/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/14696/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/2e40d68f4e5d1573e7196e0543a731abcef25da3"}}}}
{"actor":{"display_login":"GrahamCampbell"}}