{"action":"created","issue":{"url":"https://api.github.com/repos/mitodl/micromasters/issues/504","repository_url":"https://api.github.com/repos/mitodl/micromasters","labels_url":"https://api.github.com/repos/mitodl/micromasters/issues/504/labels{/name}","comments_url":"https://api.github.com/repos/mitodl/micromasters/issues/504/comments","events_url":"https://api.github.com/repos/mitodl/micromasters/issues/504/events","html_url":"https://github.com/mitodl/micromasters/pull/504","id":159037095,"number":504,"title":"Added validation for employment and education switches","user":{"login":"noisecapella","id":863262,"avatar_url":"https://avatars.githubusercontent.com/u/863262?v=3","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mitodl/micromasters/labels/Needs%20Review","name":"Needs Review","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"aliceriot","id":6207644,"avatar_url":"https://avatars.githubusercontent.com/u/6207644?v=3","gravatar_id":"","url":"https://api.github.com/users/aliceriot","html_url":"https://github.com/aliceriot","followers_url":"https://api.github.com/users/aliceriot/followers","following_url":"https://api.github.com/users/aliceriot/following{/other_user}","gists_url":"https://api.github.com/users/aliceriot/gists{/gist_id}","starred_url":"https://api.github.com/users/aliceriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliceriot/subscriptions","organizations_url":"https://api.github.com/users/aliceriot/orgs","repos_url":"https://api.github.com/users/aliceriot/repos","events_url":"https://api.github.com/users/aliceriot/events{/privacy}","received_events_url":"https://api.github.com/users/aliceriot/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-06-07T22:12:39Z","updated_at":"2016-06-10T14:50:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mitodl/micromasters/pulls/504","html_url":"https://github.com/mitodl/micromasters/pull/504","diff_url":"https://github.com/mitodl/micromasters/pull/504.diff","patch_url":"https://github.com/mitodl/micromasters/pull/504.patch"},"body":"#### What are the relevant tickets?\r\nFixes #433 \r\nRebased on #508 \r\n\r\n#### What's this PR do?\r\nAdds validation for switches for education and employment, so that a validation error will be produced if:\r\n - the switch is on but there is nothing in the card\r\n - the switch is off but there's something in the card\r\n\r\n#### Where should the reviewer start?\r\nstatic/js/util/validation.js\r\n\r\n#### How should this be manually tested?\r\nIn the profile pages, start at personal and go forward to the education tab. You should not get a validation error on the personal page. In the education page leave some cards blank and go forward. For all cards which are blank you should see a red validation error which has the label of the card within it. If you turn off a card or add an item to another card and continue, the validation error should go away.\r\n\r\nGo back to the education page and add an item to one of the cards if necessary. Close the tab and click 'Save and Continue'. You should see a validation error.\r\n\r\nFor the employment tab, make it blank but have the switch turned on. When you proceed you should see a validation error. Add an item, turn the switch off, and click 'Save and Continue'. You should see a different validation error.\r\n\r\nAlso check that the user page functions exactly as it did before.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mitodl/micromasters/issues/comments/225203550","html_url":"https://github.com/mitodl/micromasters/pull/504#issuecomment-225203550","issue_url":"https://api.github.com/repos/mitodl/micromasters/issues/504","id":225203550,"user":{"login":"noisecapella","id":863262,"avatar_url":"https://avatars.githubusercontent.com/u/863262?v=3","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T14:50:29Z","updated_at":"2016-06-10T14:50:29Z","body":"FYI this PR is rebased on the other PR #508, not sure if it's easier to view them together or separately"}}
{"actor":{"display_login":"noisecapella"}}