{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/76706423","id":76706423,"diff_hunk":"@@ -0,0 +1,354 @@\n+#!/bin/bash\n+#\n+# Starts an OpenShift master for compatibility testing\n+\n+\n+# Launches a server for OpenShift compatibility testing\n+# PREVIOUS_CONTROLLER=1 launches with previous version controllers\n+# PREVIOUS_API=1        launches with previous version API server\n+\n+# Sets up a current master server with previous controllers\n+function os::test::extended::setup_compatibility {\n+  # os::log::stacktrace::install\n+\n+  # build binaries\n+  if [[ -z $(os::build::find-binary ginkgo) ]]; then\n+    hack/build-go.sh vendor/github.com/onsi/ginkgo/ginkgo\n+  fi\n+  if [[ -z $(os::build::find-binary extended.test) ]]; then\n+    hack/build-go.sh test/extended/extended.test\n+  fi\n+  if [[ -z $(os::build::find-binary openshift) ]]; then\n+    hack/build-go.sh\n+  fi\n+  if [[ -z \"${PREVIOUS_VERSION:-}\" ]]; then\n+    if [[ -z $(os::build::find-binary previousversion) ]]; then\n+      hack/build-go.sh tools/previousversion\n+    fi\n+    openshift_binary=$(os::build::find-binary openshift)\n+    previous_version=$(os::build::find-binary previousversion)\n+    export PREVIOUS_VERSION=\"$(${previous_version} ${openshift_binary})\"\n+  fi\n+  if [[ -z \"${API_SERVER_VERSION:-}\" ]] && [[ -n \"${PREVIOUS_API:-}\" ]]; then\n+    API_SERVER_VERSION=\"${PREVIOUS_VERSION}\"\n+  fi\n+  if [[ -z \"${CONTROLLER_VERSION:-}\" ]] && [[ -n \"${PREVIOUS_CONTROLLER:-}\" ]]; then\n+    CONTROLLER_VERSION=\"${PREVIOUS_VERSION}\"\n+  fi\n+\n+  os::util::environment::setup_time_vars\n+\n+  # ensure proper relative directories are set\n+  export GINKGO=\"$(os::build::find-binary ginkgo)\"\n+  export EXTENDEDTEST=\"$(os::build::find-binary extended.test)\"\n+  export TMPDIR=${BASETMPDIR:-/tmp}\n+  export EXTENDED_TEST_PATH=\"$(pwd)/test/extended\"\n+  export KUBE_REPO_ROOT=\"$(pwd)/vendor/k8s.io/kubernetes\"\n+\n+  # output tests instead of running\n+  if [[ -n \"${SHOW_ALL:-}\" ]]; then\n+    TEST_OUTPUT_QUIET=true ${EXTENDEDTEST} --ginkgo.dryRun --ginkgo.noColor | grep ok | grep -v skip | cut -c 20- | sort\n+    exit 0\n+  fi\n+\n+  # ensure_iptables_or_die\n+\n+  function cleanup()\n+  {\n+    out=$?\n+    cleanup_openshift\n+    echo \"[INFO] Exiting\"\n+    return $out\n+  }\n+\n+  trap \"exit\" INT TERM\n+  trap \"cleanup\" EXIT\n+  echo \"[INFO] Starting server\"\n+\n+  os::util::environment::setup_all_server_vars \"test-extended/compatibility\"\n+  os::util::environment::use_sudo\n+  os::util::environment::setup_images_vars\n+  reset_tmp_dir\n+\n+  # If the current system has the XFS volume dir mount point we configure\n+  # in the test images, assume to use it which will allow the local storage\n+  # quota tests to pass.\n+  if [ -d \"/mnt/openshift-xfs-vol-dir\" ]; then","path":"test/extended/setup_compat.sh","position":76,"original_position":76,"commit_id":"628e6745f803788daf7e6f300d180ea740f54008","original_commit_id":"628e6745f803788daf7e6f300d180ea740f54008","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"body":"prefer `[[` over `[`","created_at":"2016-08-29T23:24:24Z","updated_at":"2016-08-29T23:24:24Z","html_url":"https://github.com/openshift/origin/pull/10707#discussion_r76706423","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/10707","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/76706423"},"html":{"href":"https://github.com/openshift/origin/pull/10707#discussion_r76706423"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/10707"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10707","id":83156309,"html_url":"https://github.com/openshift/origin/pull/10707","diff_url":"https://github.com/openshift/origin/pull/10707.diff","patch_url":"https://github.com/openshift/origin/pull/10707.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/10707","number":10707,"state":"open","locked":false,"title":"Extended previous version compatibility tests for builds","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"body":"Adds tests (tagged with [Compatibility]) that can be run with:\r\n- current version API server + current version Controllers,\r\n- current version API server + previous version Controllers,\r\n- previous version API server + previous version Controllers (current\r\n  client)\r\n\r\nInitially adding tests that call controller integration tests","created_at":"2016-08-29T19:49:19Z","updated_at":"2016-08-29T23:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"376b03e96db9004bf668bc3893369fc45c9e2706","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/10707/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/10707/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10707/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/628e6745f803788daf7e6f300d180ea740f54008","head":{"label":"csrwng:compat_ext_tests","ref":"compat_ext_tests","sha":"628e6745f803788daf7e6f300d180ea740f54008","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"repo":{"id":23592505,"name":"origin","full_name":"csrwng/origin","owner":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csrwng/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/csrwng/origin","forks_url":"https://api.github.com/repos/csrwng/origin/forks","keys_url":"https://api.github.com/repos/csrwng/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csrwng/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csrwng/origin/teams","hooks_url":"https://api.github.com/repos/csrwng/origin/hooks","issue_events_url":"https://api.github.com/repos/csrwng/origin/issues/events{/number}","events_url":"https://api.github.com/repos/csrwng/origin/events","assignees_url":"https://api.github.com/repos/csrwng/origin/assignees{/user}","branches_url":"https://api.github.com/repos/csrwng/origin/branches{/branch}","tags_url":"https://api.github.com/repos/csrwng/origin/tags","blobs_url":"https://api.github.com/repos/csrwng/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csrwng/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csrwng/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/csrwng/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csrwng/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/csrwng/origin/languages","stargazers_url":"https://api.github.com/repos/csrwng/origin/stargazers","contributors_url":"https://api.github.com/repos/csrwng/origin/contributors","subscribers_url":"https://api.github.com/repos/csrwng/origin/subscribers","subscription_url":"https://api.github.com/repos/csrwng/origin/subscription","commits_url":"https://api.github.com/repos/csrwng/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/csrwng/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/csrwng/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/csrwng/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/csrwng/origin/contents/{+path}","compare_url":"https://api.github.com/repos/csrwng/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csrwng/origin/merges","archive_url":"https://api.github.com/repos/csrwng/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csrwng/origin/downloads","issues_url":"https://api.github.com/repos/csrwng/origin/issues{/number}","pulls_url":"https://api.github.com/repos/csrwng/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/csrwng/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/csrwng/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csrwng/origin/labels{/name}","releases_url":"https://api.github.com/repos/csrwng/origin/releases{/id}","deployments_url":"https://api.github.com/repos/csrwng/origin/deployments","created_at":"2014-09-02T19:29:25Z","updated_at":"2016-01-11T13:43:26Z","pushed_at":"2016-08-29T19:16:52Z","git_url":"git://github.com/csrwng/origin.git","ssh_url":"git@github.com:csrwng/origin.git","clone_url":"https://github.com/csrwng/origin.git","svn_url":"https://github.com/csrwng/origin","homepage":"https://openshift.github.io","size":331066,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"d8c9694d65fcd3fe85a830252f6fc1962e6c65b7","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-08-29T20:50:24Z","pushed_at":"2016-08-29T22:56:28Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":578399,"stargazers_count":1644,"watchers_count":1644,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1041,"mirror_url":null,"open_issues_count":1100,"forks":1041,"open_issues":1100,"watchers":1644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/10707"},"html":{"href":"https://github.com/openshift/origin/pull/10707"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/10707"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/10707/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/10707/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/10707/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/628e6745f803788daf7e6f300d180ea740f54008"}}}}
{"actor":{"display_login":"stevekuznetsov"}}