{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/58191368","id":58191368,"diff_hunk":"@@ -544,7 +546,8 @@ func runContainerTar(opts RunContainerOptions, imageMetadata *docker.Image) (cmd\n \treturn cmd, tarDestination\n }\n \n-// this funtion simply abstracts out the running of the newly produced image when the --run=true option is provided\n+// runContainerDockerRun funtion simply abstracts out the running of the newly produced image when the --run=true option is provided\n+// This function runs forever, ensure a sig handler is installed elsewhere to handle cntrl-c.\n func runContainerDockerRun(container *docker.Container, d *stiDocker, image string) {","path":"pkg/docker/docker.go","position":17,"original_position":17,"commit_id":"7c3aeb752fb82b3002800315666fb9f2c039e56c","original_commit_id":"7c3aeb752fb82b3002800315666fb9f2c039e56c","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"This has historically been a hard to understand function, at least for me :smile: \r\n\r\nIt looks like it does nothing apart from calling `glog.Info`. One has to read and spend some time on the caller to figure out how this can possibly work.\r\n\r\nThe function name and documentation comment is sort of misleading, or at least we need to talk about it :ok_hand: ","created_at":"2016-04-01T11:06:51Z","updated_at":"2016-04-01T11:06:51Z","html_url":"https://github.com/openshift/source-to-image/pull/452#discussion_r58191368","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/452","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/58191368"},"html":{"href":"https://github.com/openshift/source-to-image/pull/452#discussion_r58191368"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/452"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/452","id":64684006,"html_url":"https://github.com/openshift/source-to-image/pull/452","diff_url":"https://github.com/openshift/source-to-image/pull/452.diff","patch_url":"https://github.com/openshift/source-to-image/pull/452.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/452","number":452,"state":"open","locked":false,"title":"remove running containers in case of a sigterm","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-03-30T19:35:10Z","updated_at":"2016-04-01T11:06:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a76830731b1b82a5c77ca2771b12ac7af03bf97","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/452/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/452/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/452/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/7c3aeb752fb82b3002800315666fb9f2c039e56c","head":{"label":"bparees:sigterm","ref":"sigterm","sha":"7c3aeb752fb82b3002800315666fb9f2c039e56c","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"repo":{"id":26235612,"name":"source-to-image","full_name":"bparees/source-to-image","owner":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bparees/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/bparees/source-to-image","forks_url":"https://api.github.com/repos/bparees/source-to-image/forks","keys_url":"https://api.github.com/repos/bparees/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bparees/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bparees/source-to-image/teams","hooks_url":"https://api.github.com/repos/bparees/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/bparees/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/bparees/source-to-image/events","assignees_url":"https://api.github.com/repos/bparees/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/bparees/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/bparees/source-to-image/tags","blobs_url":"https://api.github.com/repos/bparees/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bparees/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bparees/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/bparees/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bparees/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/bparees/source-to-image/languages","stargazers_url":"https://api.github.com/repos/bparees/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/bparees/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/bparees/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/bparees/source-to-image/subscription","commits_url":"https://api.github.com/repos/bparees/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/bparees/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/bparees/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/bparees/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/bparees/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/bparees/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bparees/source-to-image/merges","archive_url":"https://api.github.com/repos/bparees/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bparees/source-to-image/downloads","issues_url":"https://api.github.com/repos/bparees/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/bparees/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/bparees/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/bparees/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bparees/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/bparees/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/bparees/source-to-image/deployments","created_at":"2014-11-05T19:23:26Z","updated_at":"2016-01-17T16:46:06Z","pushed_at":"2016-04-01T03:35:21Z","git_url":"git://github.com/bparees/source-to-image.git","ssh_url":"git@github.com:bparees/source-to-image.git","clone_url":"https://github.com/bparees/source-to-image.git","svn_url":"https://github.com/bparees/source-to-image","homepage":"","size":2279,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"fb6df26bef9876c1274132e34f4bc3006a219aca","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/source-to-image/deployments","created_at":"2014-01-28T19:32:40Z","updated_at":"2016-03-28T10:31:30Z","pushed_at":"2016-04-01T03:35:21Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":2368,"stargazers_count":210,"watchers_count":210,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":23,"forks":97,"open_issues":23,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/452"},"html":{"href":"https://github.com/openshift/source-to-image/pull/452"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/452"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/7c3aeb752fb82b3002800315666fb9f2c039e56c"}}}}