{"action":"created","comment":{"url":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments/56356215","id":56356215,"diff_hunk":"@@ -604,5 +572,160 @@\n                 <matches pattern=\"(TableGenerator|TableHiLoGenerator|SequenceGenerator|SequenceIdentityGenerator|SequenceHiLoGenerator)\" />\n             </where>\n         </rule>\n+        <rule id=\"hibernate4-00029\">\n+            <when>\n+                <javaclass references=\"org.hibernate.type.descriptor.sql.SqlTypeDescriptor\">\n+<!--                     <location>INHERITANCE</location> -->\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <hint title=\"Class org.hibernate.type.descriptor.sql.SqlTypeDescriptor change in Hibernate 5\" effort=\"1\" severity=\"mandatory\">\n+                    <message>Built-in `org.hibernate.type.descriptor.sql.SqlTypeDescriptor` implementations no longer auto-register themselves with `org.hibernate.type.descriptor.sql.SqlTypeDescriptorRegistry`.\n+                     Applications using custom `SqlTypeDescriptor` implementations extending the built-in ones and relying on that behavior\n+                      should be updated to call `SqlTypeDescriptorRegistry#addDescriptor` themselves.</message>\n+                    <link\n+                        href=\"https://github.com/hibernate/hibernate-orm/blob/5.0/migration-guide.adoc#type-handling\"\n+                        title=\"Hibernate 5 Type Handling\" />\n+                    <tag>hibernate</tag>\n+                </hint>\n+            </perform>\n+        </rule>\n+        <rule id=\"hibernate4-00030\">\n+            <when>\n+                <javaclass references=\"org.hibernate.hql.spi.{type}\" />\n+            </when>\n+            <perform>\n+                <hint title=\"Class org.hibernate.hql.spi.{type} were moved in Hibernate 5\" effort=\"1\" severity=\"mandatory\">\n+                    <message>Hibernate 5 moved `org.hibernate.hql.spi.{type}` class to new `org.hibernate.hql.spi.id` package.</message>\n+                    <link\n+                        href=\"https://github.com/hibernate/hibernate-orm/blob/5.0/migration-guide.adoc#misc\"\n+                        title=\"Hibernate 5 Misc changes\" />\n+                    <tag>hibernate</tag>\n+                </hint>\n+            </perform>\n+            <where param=\"type\">\n+                <matches pattern=\"(MultiTableBulkIdStrategy|MultiTableBulkIdStrategy.DeleteHandler|MultiTableBulkIdStrategy.UpdateHandler|AbstractTableBasedBulkIdHandler|AbstractTableBasedBulkIdHandler.ProcessedWhereClause|TableBasedDeleteHandlerImpl|TableBasedUpdateHandlerImpl)\" />\n+            </where>\n+        </rule>\n+        <rule id=\"hibernate4-00031\">\n+            <when>\n+                <javaclass references=\"org.hibernate.hql.spi.PersistentTableBulkIdStrategy\" />\n+            </when>\n+            <perform>\n+                <hint title=\"Class org.hibernate.hql.spi.PersistentTableBulkIdStrategy were moved in Hibernate 5\" effort=\"1\" severity=\"mandatory\">\n+                    <message>Hibernate 5 moved `org.hibernate.hql.spi.PersistentTableBulkIdStrategy` class to new `org.hibernate.hql.spi.id.persistent` package.</message>\n+                    <link\n+                        href=\"https://github.com/hibernate/hibernate-orm/blob/5.0/migration-guide.adoc#misc\"\n+                        title=\"Hibernate 5 Misc changes\" />\n+                    <tag>hibernate</tag>\n+                </hint>\n+            </perform>\n+        </rule>\n+        <rule id=\"hibernate4-00032\">\n+            <when>\n+                <javaclass references=\"org.hibernate.hql.spi.TemporaryTableBulkIdStrategy\" />\n+            </when>\n+            <perform>\n+                <hint title=\"Class org.hibernate.hql.spi.TemporaryTableBulkIdStrategy were replaced in Hibernate 5\" effort=\"1\" severity=\"mandatory\">","path":"rules-reviewed/eap7/eap6/hibernate4.windup.xml","position":143,"original_position":143,"commit_id":"3c47e6003cdc8ea2e452f0b4af0f77965ac5a7db","original_commit_id":"3c47e6003cdc8ea2e452f0b4af0f77965ac5a7db","user":{"login":"Ladicek","id":480590,"avatar_url":"https://avatars.githubusercontent.com/u/480590?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladicek","html_url":"https://github.com/Ladicek","followers_url":"https://api.github.com/users/Ladicek/followers","following_url":"https://api.github.com/users/Ladicek/following{/other_user}","gists_url":"https://api.github.com/users/Ladicek/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladicek/subscriptions","organizations_url":"https://api.github.com/users/Ladicek/orgs","repos_url":"https://api.github.com/users/Ladicek/repos","events_url":"https://api.github.com/users/Ladicek/events{/privacy}","received_events_url":"https://api.github.com/users/Ladicek/received_events","type":"User","site_admin":false},"body":"_was_ replaced","created_at":"2016-03-16T15:37:08Z","updated_at":"2016-03-16T15:37:08Z","html_url":"https://github.com/windup/windup-rulesets/pull/126#discussion_r56356215","pull_request_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments/56356215"},"html":{"href":"https://github.com/windup/windup-rulesets/pull/126#discussion_r56356215"},"pull_request":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/windup/windup-rulesets/pulls/126","id":62546793,"html_url":"https://github.com/windup/windup-rulesets/pull/126","diff_url":"https://github.com/windup/windup-rulesets/pull/126.diff","patch_url":"https://github.com/windup/windup-rulesets/pull/126.patch","issue_url":"https://api.github.com/repos/windup/windup-rulesets/issues/126","number":126,"state":"open","locked":false,"title":"WINDUPRULE-132 fixing issues for Hibernate 5 rules","user":{"login":"mareknovotny","id":177257,"avatar_url":"https://avatars.githubusercontent.com/u/177257?v=3","gravatar_id":"","url":"https://api.github.com/users/mareknovotny","html_url":"https://github.com/mareknovotny","followers_url":"https://api.github.com/users/mareknovotny/followers","following_url":"https://api.github.com/users/mareknovotny/following{/other_user}","gists_url":"https://api.github.com/users/mareknovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/mareknovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareknovotny/subscriptions","organizations_url":"https://api.github.com/users/mareknovotny/orgs","repos_url":"https://api.github.com/users/mareknovotny/repos","events_url":"https://api.github.com/users/mareknovotny/events{/privacy}","received_events_url":"https://api.github.com/users/mareknovotny/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/WINDUPRULE-132","created_at":"2016-03-11T14:03:44Z","updated_at":"2016-03-16T15:37:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"479b28115f0aea0c3aed856ea2b1da3a5c35811e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/126/commits","review_comments_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/126/comments","review_comment_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/issues/126/comments","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/3c47e6003cdc8ea2e452f0b4af0f77965ac5a7db","head":{"label":"mareknovotny:WINDUPRULE-132","ref":"WINDUPRULE-132","sha":"3c47e6003cdc8ea2e452f0b4af0f77965ac5a7db","user":{"login":"mareknovotny","id":177257,"avatar_url":"https://avatars.githubusercontent.com/u/177257?v=3","gravatar_id":"","url":"https://api.github.com/users/mareknovotny","html_url":"https://github.com/mareknovotny","followers_url":"https://api.github.com/users/mareknovotny/followers","following_url":"https://api.github.com/users/mareknovotny/following{/other_user}","gists_url":"https://api.github.com/users/mareknovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/mareknovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareknovotny/subscriptions","organizations_url":"https://api.github.com/users/mareknovotny/orgs","repos_url":"https://api.github.com/users/mareknovotny/repos","events_url":"https://api.github.com/users/mareknovotny/events{/privacy}","received_events_url":"https://api.github.com/users/mareknovotny/received_events","type":"User","site_admin":false},"repo":{"id":33657896,"name":"windup-rulesets","full_name":"mareknovotny/windup-rulesets","owner":{"login":"mareknovotny","id":177257,"avatar_url":"https://avatars.githubusercontent.com/u/177257?v=3","gravatar_id":"","url":"https://api.github.com/users/mareknovotny","html_url":"https://github.com/mareknovotny","followers_url":"https://api.github.com/users/mareknovotny/followers","following_url":"https://api.github.com/users/mareknovotny/following{/other_user}","gists_url":"https://api.github.com/users/mareknovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/mareknovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareknovotny/subscriptions","organizations_url":"https://api.github.com/users/mareknovotny/orgs","repos_url":"https://api.github.com/users/mareknovotny/repos","events_url":"https://api.github.com/users/mareknovotny/events{/privacy}","received_events_url":"https://api.github.com/users/mareknovotny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mareknovotny/windup-rulesets","description":"Rules and rulesets contributed by community.","fork":true,"url":"https://api.github.com/repos/mareknovotny/windup-rulesets","forks_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/forks","keys_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/events","assignees_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/merges","archive_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/releases{/id}","deployments_url":"https://api.github.com/repos/mareknovotny/windup-rulesets/deployments","created_at":"2015-04-09T08:36:16Z","updated_at":"2015-05-05T14:45:06Z","pushed_at":"2016-03-15T14:12:48Z","git_url":"git://github.com/mareknovotny/windup-rulesets.git","ssh_url":"git@github.com:mareknovotny/windup-rulesets.git","clone_url":"https://github.com/mareknovotny/windup-rulesets.git","svn_url":"https://github.com/mareknovotny/windup-rulesets","homepage":null,"size":18297,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"dee8ed9c434957df00b542191e3ef74184335b6d","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":23937058,"name":"windup-rulesets","full_name":"windup/windup-rulesets","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup-rulesets","description":"Windup rules and rulesets contributed by community.","fork":false,"url":"https://api.github.com/repos/windup/windup-rulesets","forks_url":"https://api.github.com/repos/windup/windup-rulesets/forks","keys_url":"https://api.github.com/repos/windup/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/windup/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/windup/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup-rulesets/events","assignees_url":"https://api.github.com/repos/windup/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/windup/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/windup/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/windup/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/windup/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/windup/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/windup/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup-rulesets/merges","archive_url":"https://api.github.com/repos/windup/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/windup/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup-rulesets/releases{/id}","deployments_url":"https://api.github.com/repos/windup/windup-rulesets/deployments","created_at":"2014-09-11T21:51:19Z","updated_at":"2016-01-11T18:10:52Z","pushed_at":"2016-03-15T14:12:49Z","git_url":"git://github.com/windup/windup-rulesets.git","ssh_url":"git@github.com:windup/windup-rulesets.git","clone_url":"https://github.com/windup/windup-rulesets.git","svn_url":"https://github.com/windup/windup-rulesets","homepage":"http://windup.jboss.org","size":18529,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":2,"forks":17,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/126"},"html":{"href":"https://github.com/windup/windup-rulesets/pull/126"},"issue":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/126"},"comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup-rulesets/statuses/3c47e6003cdc8ea2e452f0b4af0f77965ac5a7db"}}}}