{"action":"created","comment":{"url":"https://api.github.com/repos/18F/domain-scan/pulls/comments/94054213","pull_request_review_id":14584804,"id":94054213,"diff_hunk":"@@ -82,9 +82,10 @@ def scan(domain, options):\n     yield row\n \n headers = [\n-    \"Canonical URL\", \"Live\", \"Redirect\", \"Redirect To\",\n+    \"Domain\", \"Base Domain\", \"Canonical URL\", \"Live\", \"Redirect\", \"Redirect To\",","path":"scanners/pshtt.py","position":5,"original_position":5,"commit_id":"6ab845531fb5fb4894ddadee5a7f3bad7553fd0e","original_commit_id":"6ab845531fb5fb4894ddadee5a7f3bad7553fd0e","user":{"login":"konklone","id":4592,"avatar_url":"https://avatars.githubusercontent.com/u/4592?v=3","gravatar_id":"","url":"https://api.github.com/users/konklone","html_url":"https://github.com/konklone","followers_url":"https://api.github.com/users/konklone/followers","following_url":"https://api.github.com/users/konklone/following{/other_user}","gists_url":"https://api.github.com/users/konklone/gists{/gist_id}","starred_url":"https://api.github.com/users/konklone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konklone/subscriptions","organizations_url":"https://api.github.com/users/konklone/orgs","repos_url":"https://api.github.com/users/konklone/repos","events_url":"https://api.github.com/users/konklone/events{/privacy}","received_events_url":"https://api.github.com/users/konklone/received_events","type":"User","site_admin":false},"body":"These two - `Domain` and `Base Domain` - should not be added to individual scanners. They are added for *all* reports by `domain-scan` automatically.","created_at":"2016-12-28T16:59:00Z","updated_at":"2016-12-28T16:59:17Z","html_url":"https://github.com/18F/domain-scan/pull/105#discussion_r94054213","pull_request_url":"https://api.github.com/repos/18F/domain-scan/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/comments/94054213"},"html":{"href":"https://github.com/18F/domain-scan/pull/105#discussion_r94054213"},"pull_request":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/18F/domain-scan/pulls/105","id":99461571,"html_url":"https://github.com/18F/domain-scan/pull/105","diff_url":"https://github.com/18F/domain-scan/pull/105.diff","patch_url":"https://github.com/18F/domain-scan/pull/105.patch","issue_url":"https://api.github.com/repos/18F/domain-scan/issues/105","number":105,"state":"open","locked":false,"title":"Bring headers in line with pshtt","user":{"login":"h-m-f-t","id":603901,"avatar_url":"https://avatars.githubusercontent.com/u/603901?v=3","gravatar_id":"","url":"https://api.github.com/users/h-m-f-t","html_url":"https://github.com/h-m-f-t","followers_url":"https://api.github.com/users/h-m-f-t/followers","following_url":"https://api.github.com/users/h-m-f-t/following{/other_user}","gists_url":"https://api.github.com/users/h-m-f-t/gists{/gist_id}","starred_url":"https://api.github.com/users/h-m-f-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-m-f-t/subscriptions","organizations_url":"https://api.github.com/users/h-m-f-t/orgs","repos_url":"https://api.github.com/users/h-m-f-t/repos","events_url":"https://api.github.com/users/h-m-f-t/events{/privacy}","received_events_url":"https://api.github.com/users/h-m-f-t/received_events","type":"User","site_admin":false},"body":"This change brings the headers in  line with present-day pshtt.","created_at":"2016-12-27T16:31:11Z","updated_at":"2016-12-28T16:59:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4abbefafd4fe77c859bb1e548277ebbe61a85bf7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/domain-scan/pulls/105/commits","review_comments_url":"https://api.github.com/repos/18F/domain-scan/pulls/105/comments","review_comment_url":"https://api.github.com/repos/18F/domain-scan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/domain-scan/issues/105/comments","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/6ab845531fb5fb4894ddadee5a7f3bad7553fd0e","head":{"label":"18F:pshtt-headers","ref":"pshtt-headers","sha":"6ab845531fb5fb4894ddadee5a7f3bad7553fd0e","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27473797,"name":"domain-scan","full_name":"18F/domain-scan","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/domain-scan","description":"A standard pipeline for running open source scanning tools on domains to measure things like speed, accessibiity, and HTTPS.","fork":false,"url":"https://api.github.com/repos/18F/domain-scan","forks_url":"https://api.github.com/repos/18F/domain-scan/forks","keys_url":"https://api.github.com/repos/18F/domain-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/domain-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/domain-scan/teams","hooks_url":"https://api.github.com/repos/18F/domain-scan/hooks","issue_events_url":"https://api.github.com/repos/18F/domain-scan/issues/events{/number}","events_url":"https://api.github.com/repos/18F/domain-scan/events","assignees_url":"https://api.github.com/repos/18F/domain-scan/assignees{/user}","branches_url":"https://api.github.com/repos/18F/domain-scan/branches{/branch}","tags_url":"https://api.github.com/repos/18F/domain-scan/tags","blobs_url":"https://api.github.com/repos/18F/domain-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/domain-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/domain-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/domain-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/domain-scan/languages","stargazers_url":"https://api.github.com/repos/18F/domain-scan/stargazers","contributors_url":"https://api.github.com/repos/18F/domain-scan/contributors","subscribers_url":"https://api.github.com/repos/18F/domain-scan/subscribers","subscription_url":"https://api.github.com/repos/18F/domain-scan/subscription","commits_url":"https://api.github.com/repos/18F/domain-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/domain-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/domain-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/domain-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/domain-scan/contents/{+path}","compare_url":"https://api.github.com/repos/18F/domain-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/domain-scan/merges","archive_url":"https://api.github.com/repos/18F/domain-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/domain-scan/downloads","issues_url":"https://api.github.com/repos/18F/domain-scan/issues{/number}","pulls_url":"https://api.github.com/repos/18F/domain-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/domain-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/domain-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/domain-scan/labels{/name}","releases_url":"https://api.github.com/repos/18F/domain-scan/releases{/id}","deployments_url":"https://api.github.com/repos/18F/domain-scan/deployments","created_at":"2014-12-03T06:52:17Z","updated_at":"2016-12-28T15:31:17Z","pushed_at":"2016-12-27T16:31:12Z","git_url":"git://github.com/18F/domain-scan.git","ssh_url":"git@github.com:18F/domain-scan.git","clone_url":"https://github.com/18F/domain-scan.git","svn_url":"https://github.com/18F/domain-scan","homepage":"","size":6808,"stargazers_count":79,"watchers_count":79,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":26,"forks":35,"open_issues":26,"watchers":79,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"dc3a037ab7d6e6fc28eefbb367ccd95344b7d79a","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27473797,"name":"domain-scan","full_name":"18F/domain-scan","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/domain-scan","description":"A standard pipeline for running open source scanning tools on domains to measure things like speed, accessibiity, and HTTPS.","fork":false,"url":"https://api.github.com/repos/18F/domain-scan","forks_url":"https://api.github.com/repos/18F/domain-scan/forks","keys_url":"https://api.github.com/repos/18F/domain-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/domain-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/domain-scan/teams","hooks_url":"https://api.github.com/repos/18F/domain-scan/hooks","issue_events_url":"https://api.github.com/repos/18F/domain-scan/issues/events{/number}","events_url":"https://api.github.com/repos/18F/domain-scan/events","assignees_url":"https://api.github.com/repos/18F/domain-scan/assignees{/user}","branches_url":"https://api.github.com/repos/18F/domain-scan/branches{/branch}","tags_url":"https://api.github.com/repos/18F/domain-scan/tags","blobs_url":"https://api.github.com/repos/18F/domain-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/domain-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/domain-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/domain-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/domain-scan/languages","stargazers_url":"https://api.github.com/repos/18F/domain-scan/stargazers","contributors_url":"https://api.github.com/repos/18F/domain-scan/contributors","subscribers_url":"https://api.github.com/repos/18F/domain-scan/subscribers","subscription_url":"https://api.github.com/repos/18F/domain-scan/subscription","commits_url":"https://api.github.com/repos/18F/domain-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/domain-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/domain-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/domain-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/domain-scan/contents/{+path}","compare_url":"https://api.github.com/repos/18F/domain-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/domain-scan/merges","archive_url":"https://api.github.com/repos/18F/domain-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/domain-scan/downloads","issues_url":"https://api.github.com/repos/18F/domain-scan/issues{/number}","pulls_url":"https://api.github.com/repos/18F/domain-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/domain-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/domain-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/domain-scan/labels{/name}","releases_url":"https://api.github.com/repos/18F/domain-scan/releases{/id}","deployments_url":"https://api.github.com/repos/18F/domain-scan/deployments","created_at":"2014-12-03T06:52:17Z","updated_at":"2016-12-28T15:31:17Z","pushed_at":"2016-12-27T16:31:12Z","git_url":"git://github.com/18F/domain-scan.git","ssh_url":"git@github.com:18F/domain-scan.git","clone_url":"https://github.com/18F/domain-scan.git","svn_url":"https://github.com/18F/domain-scan","homepage":"","size":6808,"stargazers_count":79,"watchers_count":79,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":26,"forks":35,"open_issues":26,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/105"},"html":{"href":"https://github.com/18F/domain-scan/pull/105"},"issue":{"href":"https://api.github.com/repos/18F/domain-scan/issues/105"},"comments":{"href":"https://api.github.com/repos/18F/domain-scan/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/18F/domain-scan/statuses/6ab845531fb5fb4894ddadee5a7f3bad7553fd0e"}}}}
{"actor":{"display_login":"konklone"}}