{"action":"created","comment":{"url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/comments/92518412","pull_request_review_id":13035470,"id":92518412,"diff_hunk":"@@ -77,10 +77,6 @@ export default class Dropdown extends Component {\n     options: PropTypes.arrayOf((propValue, key, componentName) => {\n       const { value, label } = propValue[key];\n \n-      if (typeof value !== 'string') {\n-        return new Error(`Invalid prop \\`options[${key}].value\\` of type \\`${typeof value}\\` supplied to \\`${componentName}\\`, expected \\`string\\`.`);\n-      }\n-","path":"react/fields/Dropdown/Dropdown.js","position":7,"original_position":7,"commit_id":"199d4b4f59303c1b1369cc63f139b47a9ad21df3","original_commit_id":"199d4b4f59303c1b1369cc63f139b47a9ad21df3","user":{"login":"mjt01","id":912060,"avatar_url":"https://avatars.githubusercontent.com/u/912060?v=3","gravatar_id":"","url":"https://api.github.com/users/mjt01","html_url":"https://github.com/mjt01","followers_url":"https://api.github.com/users/mjt01/followers","following_url":"https://api.github.com/users/mjt01/following{/other_user}","gists_url":"https://api.github.com/users/mjt01/gists{/gist_id}","starred_url":"https://api.github.com/users/mjt01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjt01/subscriptions","organizations_url":"https://api.github.com/users/mjt01/orgs","repos_url":"https://api.github.com/users/mjt01/repos","events_url":"https://api.github.com/users/mjt01/events{/privacy}","received_events_url":"https://api.github.com/users/mjt01/received_events","type":"User","site_admin":false},"body":"Rather than removing this check we should redefine our expectations here to something like:\r\n```js\r\noptions: PropTypes.arrayOf(\r\n  PropTypes.shape({\r\n    value: PropTypes.oneOfType([\r\n      PropTypes.arrayOf(PropTypes.object),\r\n      PropTypes.string\r\n    ]).isRequired,\r\n    label: PropTypes.string\r\n  })\r\n)\r\n```","created_at":"2016-12-14T23:59:20Z","updated_at":"2016-12-14T23:59:20Z","html_url":"https://github.com/SEEK-Jobs/seek-style-guide/pull/72#discussion_r92518412","pull_request_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/comments/92518412"},"html":{"href":"https://github.com/SEEK-Jobs/seek-style-guide/pull/72#discussion_r92518412"},"pull_request":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72","id":97858735,"html_url":"https://github.com/SEEK-Jobs/seek-style-guide/pull/72","diff_url":"https://github.com/SEEK-Jobs/seek-style-guide/pull/72.diff","patch_url":"https://github.com/SEEK-Jobs/seek-style-guide/pull/72.patch","issue_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/72","number":72,"state":"open","locked":false,"title":"dropdown supports hierarchy","user":{"login":"LeviSeek","id":16127935,"avatar_url":"https://avatars.githubusercontent.com/u/16127935?v=3","gravatar_id":"","url":"https://api.github.com/users/LeviSeek","html_url":"https://github.com/LeviSeek","followers_url":"https://api.github.com/users/LeviSeek/followers","following_url":"https://api.github.com/users/LeviSeek/following{/other_user}","gists_url":"https://api.github.com/users/LeviSeek/gists{/gist_id}","starred_url":"https://api.github.com/users/LeviSeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeviSeek/subscriptions","organizations_url":"https://api.github.com/users/LeviSeek/orgs","repos_url":"https://api.github.com/users/LeviSeek/repos","events_url":"https://api.github.com/users/LeviSeek/events{/privacy}","received_events_url":"https://api.github.com/users/LeviSeek/received_events","type":"User","site_admin":false},"body":"this feature would enable the dropdown to display nested information.\r\noptionProps supports hierarchy structure, here is one example of options:\r\n```\r\nconst options = [\r\n      {\r\n        label: 'Really really long job title that is not gonna fit',\r\n        value: '3'\r\n      },\r\n      {\r\n        label: 'Major Cities',\r\n        value: [\r\n          {\r\n            label: 'Melbourne',\r\n            value: '3004'\r\n          },\r\n          {\r\n            label: 'Sydney',\r\n            value: '3002'\r\n          }\r\n        ]\r\n      },\r\n      {\r\n        label: 'Balarat',\r\n        value: '3005'\r\n      }\r\n    ]\r\n```\r\n<img width=\"973\" alt=\"screen shot 2016-12-14 at 11 10 32 am\" src=\"https://cloud.githubusercontent.com/assets/16127935/21164646/93f046f6-c1ee-11e6-8190-33b32b5649c7.png\">\r\n\r\n","created_at":"2016-12-13T23:35:11Z","updated_at":"2016-12-14T23:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"326c4028dcaf8b92d67192a0de3f3e37093c7607","assignee":{"login":"shawn-dsz","id":4195551,"avatar_url":"https://avatars.githubusercontent.com/u/4195551?v=3","gravatar_id":"","url":"https://api.github.com/users/shawn-dsz","html_url":"https://github.com/shawn-dsz","followers_url":"https://api.github.com/users/shawn-dsz/followers","following_url":"https://api.github.com/users/shawn-dsz/following{/other_user}","gists_url":"https://api.github.com/users/shawn-dsz/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-dsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-dsz/subscriptions","organizations_url":"https://api.github.com/users/shawn-dsz/orgs","repos_url":"https://api.github.com/users/shawn-dsz/repos","events_url":"https://api.github.com/users/shawn-dsz/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-dsz/received_events","type":"User","site_admin":false},"assignees":[{"login":"shawn-dsz","id":4195551,"avatar_url":"https://avatars.githubusercontent.com/u/4195551?v=3","gravatar_id":"","url":"https://api.github.com/users/shawn-dsz","html_url":"https://github.com/shawn-dsz","followers_url":"https://api.github.com/users/shawn-dsz/followers","following_url":"https://api.github.com/users/shawn-dsz/following{/other_user}","gists_url":"https://api.github.com/users/shawn-dsz/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-dsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-dsz/subscriptions","organizations_url":"https://api.github.com/users/shawn-dsz/orgs","repos_url":"https://api.github.com/users/shawn-dsz/repos","events_url":"https://api.github.com/users/shawn-dsz/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-dsz/received_events","type":"User","site_admin":false},{"login":"mattsjones","id":8802980,"avatar_url":"https://avatars.githubusercontent.com/u/8802980?v=3","gravatar_id":"","url":"https://api.github.com/users/mattsjones","html_url":"https://github.com/mattsjones","followers_url":"https://api.github.com/users/mattsjones/followers","following_url":"https://api.github.com/users/mattsjones/following{/other_user}","gists_url":"https://api.github.com/users/mattsjones/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsjones/subscriptions","organizations_url":"https://api.github.com/users/mattsjones/orgs","repos_url":"https://api.github.com/users/mattsjones/repos","events_url":"https://api.github.com/users/mattsjones/events{/privacy}","received_events_url":"https://api.github.com/users/mattsjones/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72/commits","review_comments_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72/comments","review_comment_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/72/comments","statuses_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/statuses/199d4b4f59303c1b1369cc63f139b47a9ad21df3","head":{"label":"SEEK-Jobs:feature/dropdown","ref":"feature/dropdown","sha":"199d4b4f59303c1b1369cc63f139b47a9ad21df3","user":{"login":"SEEK-Jobs","id":1829110,"avatar_url":"https://avatars.githubusercontent.com/u/1829110?v=3","gravatar_id":"","url":"https://api.github.com/users/SEEK-Jobs","html_url":"https://github.com/SEEK-Jobs","followers_url":"https://api.github.com/users/SEEK-Jobs/followers","following_url":"https://api.github.com/users/SEEK-Jobs/following{/other_user}","gists_url":"https://api.github.com/users/SEEK-Jobs/gists{/gist_id}","starred_url":"https://api.github.com/users/SEEK-Jobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEEK-Jobs/subscriptions","organizations_url":"https://api.github.com/users/SEEK-Jobs/orgs","repos_url":"https://api.github.com/users/SEEK-Jobs/repos","events_url":"https://api.github.com/users/SEEK-Jobs/events{/privacy}","received_events_url":"https://api.github.com/users/SEEK-Jobs/received_events","type":"Organization","site_admin":false},"repo":{"id":56475150,"name":"seek-style-guide","full_name":"SEEK-Jobs/seek-style-guide","owner":{"login":"SEEK-Jobs","id":1829110,"avatar_url":"https://avatars.githubusercontent.com/u/1829110?v=3","gravatar_id":"","url":"https://api.github.com/users/SEEK-Jobs","html_url":"https://github.com/SEEK-Jobs","followers_url":"https://api.github.com/users/SEEK-Jobs/followers","following_url":"https://api.github.com/users/SEEK-Jobs/following{/other_user}","gists_url":"https://api.github.com/users/SEEK-Jobs/gists{/gist_id}","starred_url":"https://api.github.com/users/SEEK-Jobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEEK-Jobs/subscriptions","organizations_url":"https://api.github.com/users/SEEK-Jobs/orgs","repos_url":"https://api.github.com/users/SEEK-Jobs/repos","events_url":"https://api.github.com/users/SEEK-Jobs/events{/privacy}","received_events_url":"https://api.github.com/users/SEEK-Jobs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SEEK-Jobs/seek-style-guide","description":"Living style guide containing the building blocks and design principles for SEEK web apps","fork":false,"url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide","forks_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/forks","keys_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/teams","hooks_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/hooks","issue_events_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/events","assignees_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/tags","blobs_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/languages","stargazers_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/stargazers","contributors_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/contributors","subscribers_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/subscribers","subscription_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/subscription","commits_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/merges","archive_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/downloads","issues_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/releases{/id}","deployments_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/deployments","created_at":"2016-04-18T03:47:28Z","updated_at":"2016-12-08T23:29:42Z","pushed_at":"2016-12-13T23:35:11Z","git_url":"git://github.com/SEEK-Jobs/seek-style-guide.git","ssh_url":"git@github.com:SEEK-Jobs/seek-style-guide.git","clone_url":"https://github.com/SEEK-Jobs/seek-style-guide.git","svn_url":"https://github.com/SEEK-Jobs/seek-style-guide","homepage":"http://seek-jobs.github.io/seek-style-guide","size":1662,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":10,"default_branch":"master"}},"base":{"label":"SEEK-Jobs:master","ref":"master","sha":"11237e0303932b33068ebe434aba2df0b0a7e1a9","user":{"login":"SEEK-Jobs","id":1829110,"avatar_url":"https://avatars.githubusercontent.com/u/1829110?v=3","gravatar_id":"","url":"https://api.github.com/users/SEEK-Jobs","html_url":"https://github.com/SEEK-Jobs","followers_url":"https://api.github.com/users/SEEK-Jobs/followers","following_url":"https://api.github.com/users/SEEK-Jobs/following{/other_user}","gists_url":"https://api.github.com/users/SEEK-Jobs/gists{/gist_id}","starred_url":"https://api.github.com/users/SEEK-Jobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEEK-Jobs/subscriptions","organizations_url":"https://api.github.com/users/SEEK-Jobs/orgs","repos_url":"https://api.github.com/users/SEEK-Jobs/repos","events_url":"https://api.github.com/users/SEEK-Jobs/events{/privacy}","received_events_url":"https://api.github.com/users/SEEK-Jobs/received_events","type":"Organization","site_admin":false},"repo":{"id":56475150,"name":"seek-style-guide","full_name":"SEEK-Jobs/seek-style-guide","owner":{"login":"SEEK-Jobs","id":1829110,"avatar_url":"https://avatars.githubusercontent.com/u/1829110?v=3","gravatar_id":"","url":"https://api.github.com/users/SEEK-Jobs","html_url":"https://github.com/SEEK-Jobs","followers_url":"https://api.github.com/users/SEEK-Jobs/followers","following_url":"https://api.github.com/users/SEEK-Jobs/following{/other_user}","gists_url":"https://api.github.com/users/SEEK-Jobs/gists{/gist_id}","starred_url":"https://api.github.com/users/SEEK-Jobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEEK-Jobs/subscriptions","organizations_url":"https://api.github.com/users/SEEK-Jobs/orgs","repos_url":"https://api.github.com/users/SEEK-Jobs/repos","events_url":"https://api.github.com/users/SEEK-Jobs/events{/privacy}","received_events_url":"https://api.github.com/users/SEEK-Jobs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SEEK-Jobs/seek-style-guide","description":"Living style guide containing the building blocks and design principles for SEEK web apps","fork":false,"url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide","forks_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/forks","keys_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/teams","hooks_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/hooks","issue_events_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/events","assignees_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/tags","blobs_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/languages","stargazers_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/stargazers","contributors_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/contributors","subscribers_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/subscribers","subscription_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/subscription","commits_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/merges","archive_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/downloads","issues_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/releases{/id}","deployments_url":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/deployments","created_at":"2016-04-18T03:47:28Z","updated_at":"2016-12-08T23:29:42Z","pushed_at":"2016-12-13T23:35:11Z","git_url":"git://github.com/SEEK-Jobs/seek-style-guide.git","ssh_url":"git@github.com:SEEK-Jobs/seek-style-guide.git","clone_url":"https://github.com/SEEK-Jobs/seek-style-guide.git","svn_url":"https://github.com/SEEK-Jobs/seek-style-guide","homepage":"http://seek-jobs.github.io/seek-style-guide","size":1662,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72"},"html":{"href":"https://github.com/SEEK-Jobs/seek-style-guide/pull/72"},"issue":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/72"},"comments":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/SEEK-Jobs/seek-style-guide/statuses/199d4b4f59303c1b1369cc63f139b47a9ad21df3"}}}}
{"actor":{"display_login":"mjt01"}}