{"action":"closed","number":2342,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2342","id":80587357,"html_url":"https://github.com/apache/flink/pull/2342","diff_url":"https://github.com/apache/flink/pull/2342.diff","patch_url":"https://github.com/apache/flink/pull/2342.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/2342","number":2342,"state":"closed","locked":false,"title":"FLINK-4253 - Rename \"recovery.mode\" config key to \"high-availability\" (Ram)","user":{"login":"ramkrish86","id":3690658,"avatar_url":"https://avatars.githubusercontent.com/u/3690658?v=3","gravatar_id":"","url":"https://api.github.com/users/ramkrish86","html_url":"https://github.com/ramkrish86","followers_url":"https://api.github.com/users/ramkrish86/followers","following_url":"https://api.github.com/users/ramkrish86/following{/other_user}","gists_url":"https://api.github.com/users/ramkrish86/gists{/gist_id}","starred_url":"https://api.github.com/users/ramkrish86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramkrish86/subscriptions","organizations_url":"https://api.github.com/users/ramkrish86/orgs","repos_url":"https://api.github.com/users/ramkrish86/repos","events_url":"https://api.github.com/users/ramkrish86/events{/privacy}","received_events_url":"https://api.github.com/users/ramkrish86/received_events","type":"User","site_admin":false},"body":"Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.\r\nIf your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).\r\nIn addition to going through the list, please provide a meaningful description of your changes.\r\n\r\n- [ ] General\r\n  - The pull request references the related JIRA issue (\"[FLINK-XXX] Jira title text\")\r\n  - The pull request addresses only one issue\r\n  - Each commit in the PR has a meaningful commit message (including the JIRA id)\r\n\r\n- [ ] Documentation\r\n  - Documentation has been added for new functionality\r\n  - Old documentation affected by the pull request has been updated\r\n  - JavaDoc for public methods has been added\r\n\r\n- [ ] Tests & Build\r\n  - Functionality added by the pull request is covered by tests\r\n  - `mvn clean verify` has been executed successfully locally or a Travis build has passed\r\n\r\nI ran `mvn clean verify` - all the tests in flink-runtime passed and this test failed \r\n`\r\nFailed tests:\r\n  BlobServerDeleteTest.testDeleteAll:157 DELETE operation failed: Server side error: Unable to delete directory C:\\Users\\rsvasude\\AppData\\Local\\Temp\\blobStore-18502f30-ee19-4c4c-9cb7-7b51c9bdeffb\\job_801e21ed42b26de3c813cfe4917d029d.\r\n  LeaderChangeStateCleanupTest.testReelectionOfSameJobManager:244 TaskManager should not be able to register at JobManager.\r\n`\r\nI think it is an environment issue. Ran other tests changed as part of this PR and they all seems to pass.\r\nHandled backward compatability if the config file has the older config `recover.mode`. The same has been handled in the `config.sh` script also. \r\n\r\nSuggestions/feedback welcome. ","created_at":"2016-08-09T09:21:36Z","updated_at":"2016-08-24T10:12:44Z","closed_at":"2016-08-24T10:12:44Z","merged_at":null,"merge_commit_sha":"5f2ad78870c340421657a4d504e74bb49064bfad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/2342/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/2342/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/2342/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/5777318189c42dd539f8915911c64336980b3426","head":{"label":"ramkrish86:FLINK-4253","ref":"FLINK-4253","sha":"5777318189c42dd539f8915911c64336980b3426","user":{"login":"ramkrish86","id":3690658,"avatar_url":"https://avatars.githubusercontent.com/u/3690658?v=3","gravatar_id":"","url":"https://api.github.com/users/ramkrish86","html_url":"https://github.com/ramkrish86","followers_url":"https://api.github.com/users/ramkrish86/followers","following_url":"https://api.github.com/users/ramkrish86/following{/other_user}","gists_url":"https://api.github.com/users/ramkrish86/gists{/gist_id}","starred_url":"https://api.github.com/users/ramkrish86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramkrish86/subscriptions","organizations_url":"https://api.github.com/users/ramkrish86/orgs","repos_url":"https://api.github.com/users/ramkrish86/repos","events_url":"https://api.github.com/users/ramkrish86/events{/privacy}","received_events_url":"https://api.github.com/users/ramkrish86/received_events","type":"User","site_admin":false},"repo":{"id":50035316,"name":"flink","full_name":"ramkrish86/flink","owner":{"login":"ramkrish86","id":3690658,"avatar_url":"https://avatars.githubusercontent.com/u/3690658?v=3","gravatar_id":"","url":"https://api.github.com/users/ramkrish86","html_url":"https://github.com/ramkrish86","followers_url":"https://api.github.com/users/ramkrish86/followers","following_url":"https://api.github.com/users/ramkrish86/following{/other_user}","gists_url":"https://api.github.com/users/ramkrish86/gists{/gist_id}","starred_url":"https://api.github.com/users/ramkrish86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramkrish86/subscriptions","organizations_url":"https://api.github.com/users/ramkrish86/orgs","repos_url":"https://api.github.com/users/ramkrish86/repos","events_url":"https://api.github.com/users/ramkrish86/events{/privacy}","received_events_url":"https://api.github.com/users/ramkrish86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramkrish86/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/ramkrish86/flink","forks_url":"https://api.github.com/repos/ramkrish86/flink/forks","keys_url":"https://api.github.com/repos/ramkrish86/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramkrish86/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramkrish86/flink/teams","hooks_url":"https://api.github.com/repos/ramkrish86/flink/hooks","issue_events_url":"https://api.github.com/repos/ramkrish86/flink/issues/events{/number}","events_url":"https://api.github.com/repos/ramkrish86/flink/events","assignees_url":"https://api.github.com/repos/ramkrish86/flink/assignees{/user}","branches_url":"https://api.github.com/repos/ramkrish86/flink/branches{/branch}","tags_url":"https://api.github.com/repos/ramkrish86/flink/tags","blobs_url":"https://api.github.com/repos/ramkrish86/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramkrish86/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramkrish86/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramkrish86/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramkrish86/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/ramkrish86/flink/languages","stargazers_url":"https://api.github.com/repos/ramkrish86/flink/stargazers","contributors_url":"https://api.github.com/repos/ramkrish86/flink/contributors","subscribers_url":"https://api.github.com/repos/ramkrish86/flink/subscribers","subscription_url":"https://api.github.com/repos/ramkrish86/flink/subscription","commits_url":"https://api.github.com/repos/ramkrish86/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramkrish86/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramkrish86/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramkrish86/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramkrish86/flink/contents/{+path}","compare_url":"https://api.github.com/repos/ramkrish86/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramkrish86/flink/merges","archive_url":"https://api.github.com/repos/ramkrish86/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramkrish86/flink/downloads","issues_url":"https://api.github.com/repos/ramkrish86/flink/issues{/number}","pulls_url":"https://api.github.com/repos/ramkrish86/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/ramkrish86/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/ramkrish86/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramkrish86/flink/labels{/name}","releases_url":"https://api.github.com/repos/ramkrish86/flink/releases{/id}","deployments_url":"https://api.github.com/repos/ramkrish86/flink/deployments","created_at":"2016-01-20T14:27:43Z","updated_at":"2016-01-20T14:27:55Z","pushed_at":"2016-08-24T07:39:21Z","git_url":"git://github.com/ramkrish86/flink.git","ssh_url":"git@github.com:ramkrish86/flink.git","clone_url":"https://github.com/ramkrish86/flink.git","svn_url":"https://github.com/ramkrish86/flink","homepage":null,"size":90029,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"47acdeadf3ccd326578306453dd10ed3c147a4e6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-08-24T06:11:24Z","pushed_at":"2016-08-24T10:12:16Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":121936,"stargazers_count":1529,"watchers_count":1529,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1008,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":128,"forks":1008,"open_issues":128,"watchers":1529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/2342"},"html":{"href":"https://github.com/apache/flink/pull/2342"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/2342"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/2342/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/2342/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/2342/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/5777318189c42dd539f8915911c64336980b3426"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":21,"review_comments":5,"commits":4,"additions":429,"deletions":235,"changed_files":45}}
{"actor":{"display_login":"asfgit"}}