{"action":"closed","issue":{"url":"https://api.github.com/repos/DanielSlater/PyGamePlayer/issues/6","repository_url":"https://api.github.com/repos/DanielSlater/PyGamePlayer","labels_url":"https://api.github.com/repos/DanielSlater/PyGamePlayer/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/DanielSlater/PyGamePlayer/issues/6/comments","events_url":"https://api.github.com/repos/DanielSlater/PyGamePlayer/issues/6/events","html_url":"https://github.com/DanielSlater/PyGamePlayer/issues/6","id":161078842,"number":6,"title":"is append working right here?","user":{"login":"flobotics","id":11964445,"avatar_url":"https://avatars.githubusercontent.com/u/11964445?v=3","gravatar_id":"","url":"https://api.github.com/users/flobotics","html_url":"https://github.com/flobotics","followers_url":"https://api.github.com/users/flobotics/followers","following_url":"https://api.github.com/users/flobotics/following{/other_user}","gists_url":"https://api.github.com/users/flobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/flobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flobotics/subscriptions","organizations_url":"https://api.github.com/users/flobotics/orgs","repos_url":"https://api.github.com/users/flobotics/repos","events_url":"https://api.github.com/users/flobotics/events{/privacy}","received_events_url":"https://api.github.com/users/flobotics/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-19T15:49:32Z","updated_at":"2016-06-19T15:54:39Z","closed_at":"2016-06-19T15:54:39Z","body":"hi,\r\nwhen i look at line 100 at  https://github.com/DanielSlater/PyGamePlayer/blob/master/examples/deep_q_pong_player.py#L100 i see\r\n\r\n- current_state = np.append(self._last_state[:, :, 1:], screen_resized_binary, axis=2)\r\n\r\nwhen i use this test code:\r\n```\r\n\r\nimport numpy as np\r\n\r\na = np.array([[1,2,3],[4,5,6]])\r\nprint a.shape\r\nprint a\r\nb = np.stack(tuple(a for _ in range(4)), axis=2)\r\nprint b.shape\r\nprint b\r\nc = np.array([[7,8,9], [10,11,12]])\r\nprint c.shape\r\nprint c\r\nd = np.reshape(c, (2,3,1))\r\nprint d.shape\r\ne = np.append(b[:,:,1:], d, axis=2)\r\nprint e.shape\r\nprint e\r\nf = np.array([[13,14,15],[16,17,18]])\r\ng = np.reshape(f, (2,3,1))\r\nh = np.append(b[:,:,1:], g, axis=2)\r\nprint h.shape\r\nprint h\r\n```\r\nit prints:\r\n```\r\n\r\n(2, 3)\r\n[[1 2 3]\r\n [4 5 6]]\r\n(2, 3, 4)\r\n[[[1 1 1 1]\r\n  [2 2 2 2]\r\n  [3 3 3 3]]\r\n\r\n [[4 4 4 4]\r\n  [5 5 5 5]\r\n  [6 6 6 6]]]\r\n(2, 3)\r\n[[ 7  8  9]\r\n [10 11 12]]\r\n(2, 3, 1)\r\n(2, 3, 4)\r\n[[[ 1  1  1  7]\r\n  [ 2  2  2  8]\r\n  [ 3  3  3  9]]\r\n\r\n [[ 4  4  4 10]\r\n  [ 5  5  5 11]\r\n  [ 6  6  6 12]]]\r\n(2, 3, 4)\r\n[[[ 1  1  1 13]\r\n  [ 2  2  2 14]\r\n  [ 3  3  3 15]]\r\n\r\n [[ 4  4  4 16]\r\n  [ 5  5  5 17]\r\n  [ 6  6  6 18]]]\r\n\r\n```\r\n\r\nbut should it not be shifted-like inserted, so that the old values (frames) will all get lost after time ? or do i think wrong ?"}}
{"actor":{"display_login":"flobotics"}}