{"push_id":1319373129,"size":3,"distinct_size":1,"ref":"refs/heads/master","head":"2af7340afdfae2ea97be05884014296d6446ec5c","before":"6298d1ca1b73aa467377daaf727e59ba8b2c633b","commits":[{"sha":"e9a655b49393e1302bf75aa759b11969545c986a","author":{"name":"Daniel Owen","email":"8a57d28ff614254d5f5384c898c5f403b046677e@couchbase.com"},"message":"MB-20943: Set state to dead when deleting vbucket\n\nWhen executing the VBucketMemoryDeletionTask the vbucket state is\nunchanged.  notifyAllPendingConnsFailed is called in the run\nfunction of VBucketMemoryDeletionTask.  This inturn calls fireAllOps,\nwhich ensures all pending ops are cleared if the vbucket is in an\nactive state.\n\nHowever if the vbucket is in a pending state is does nothing and\ntherefore the pending operations remain.  This results in connections\nnot being closed down.\n\nThe solution provided is to set the vbucket state to dead in\ndeleteVBucket, prior to calling scheduleVBDeletion.\n\nA corresponding test has been added, which without the fix will hang.\n\nChange-Id: I09cd4597b26576dd4b99d26f3a60c031e1b5f41d\nReviewed-on: http://review.couchbase.org/67873\nWell-Formed: buildbot <build@couchbase.com>\nTested-by: buildbot <build@couchbase.com>\nReviewed-by: Dave Rigby <daver@couchbase.com>\nReviewed-by: Jim Walker <jim@couchbase.com>","distinct":false,"url":"https://api.github.com/repos/couchbase/ep-engine/commits/e9a655b49393e1302bf75aa759b11969545c986a"},{"sha":"dba7ccecf032d82b7b47948d376c64a56593a1b5","author":{"name":"Dave Rigby","email":"f1dabaf34419d2352350e740ada40ded900019c4@couchbase.com"},"message":"Merge remote-tracking branch 'couchbase/4.5.1' into watson\n\n* couchbase/4.5.1:\n  MB-20943: Set state to dead when deleting vbucket\n\nChange-Id: I79ef4c2d0e66cf18e08f884ad7fecf2afe3b5578","distinct":false,"url":"https://api.github.com/repos/couchbase/ep-engine/commits/dba7ccecf032d82b7b47948d376c64a56593a1b5"},{"sha":"2af7340afdfae2ea97be05884014296d6446ec5c","author":{"name":"Dave Rigby","email":"f1dabaf34419d2352350e740ada40ded900019c4@couchbase.com"},"message":"Merge remote-tracking branch 'couchbase/watson'\n\n* couchbase/watson:\n  MB-20943: Set state to dead when deleting vbucket\n\nChange-Id: Icf9e2556de202a73d9022fa95772e266bdab7e65","distinct":true,"url":"https://api.github.com/repos/couchbase/ep-engine/commits/2af7340afdfae2ea97be05884014296d6446ec5c"}]}
{"actor":{"display_login":"ns-codereview"}}