{"action":"created","comment":{"url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/comments/84808398","pull_request_review_id":5562531,"id":84808398,"diff_hunk":"@@ -1,3 +1,6 @@\n FROM gcr.io/kubeadm/ci-xenial-systemd:bare\n ADD ./build-debian.sh /tmp/build.sh\n+ADD ./dind /usr/local/bin/dind\n RUN /tmp/build.sh\n+\n+ENTRYPOINT [\"/usr/local/bin/dind\"]","path":"images/xenial-systemd-base.dkr","position":6,"original_position":6,"commit_id":"785627b808b02580725f20506844e56b810990d7","original_commit_id":"785627b808b02580725f20506844e56b810990d7","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"body":"IS it suppose to wrapp `/sbin/init`?","created_at":"2016-10-24T23:59:16Z","updated_at":"2016-10-24T23:59:16Z","html_url":"https://github.com/errordeveloper/kubeadm-ci-dind/pull/1#discussion_r84808398","pull_request_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/comments/84808398"},"html":{"href":"https://github.com/errordeveloper/kubeadm-ci-dind/pull/1#discussion_r84808398"},"pull_request":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1","id":90633848,"html_url":"https://github.com/errordeveloper/kubeadm-ci-dind/pull/1","diff_url":"https://github.com/errordeveloper/kubeadm-ci-dind/pull/1.diff","patch_url":"https://github.com/errordeveloper/kubeadm-ci-dind/pull/1.patch","issue_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/issues/1","number":1,"state":"open","locked":false,"title":"Fix DIND to make the images more reusable","user":{"login":"ivan4th","id":190448,"avatar_url":"https://avatars.githubusercontent.com/u/190448?v=3","gravatar_id":"","url":"https://api.github.com/users/ivan4th","html_url":"https://github.com/ivan4th","followers_url":"https://api.github.com/users/ivan4th/followers","following_url":"https://api.github.com/users/ivan4th/following{/other_user}","gists_url":"https://api.github.com/users/ivan4th/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan4th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan4th/subscriptions","organizations_url":"https://api.github.com/users/ivan4th/orgs","repos_url":"https://api.github.com/users/ivan4th/repos","events_url":"https://api.github.com/users/ivan4th/events{/privacy}","received_events_url":"https://api.github.com/users/ivan4th/received_events","type":"User","site_admin":false},"body":"1. Add a comment about `STOPSIGNAL SIGRTMIN+3` in xenial-systemd-bare.dkr\r\n2. Force Docker to use VFS driver. It'll default to devicemapper otherwise which doesn't always work & may cause problems with loop device exhaustion\r\n3. Add dind script based on Docker's own dind setup. Added `mount --make-shared /` there because otherwise there may be problems with volume mounts [according](https://github.com/marun/dkr-systemd-dind/blob/25702cf7a4a73bcc355a492f4e5ca96cc562a5a5/dind-setup.sh#L46) to @marun","created_at":"2016-10-24T15:18:51Z","updated_at":"2016-10-24T23:59:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24bb23c40e7611927eee7a02a94c16d85b599a7b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1/commits","review_comments_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1/comments","review_comment_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/issues/1/comments","statuses_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/statuses/785627b808b02580725f20506844e56b810990d7","head":{"label":"ivan4th:fix-dind","ref":"fix-dind","sha":"785627b808b02580725f20506844e56b810990d7","user":{"login":"ivan4th","id":190448,"avatar_url":"https://avatars.githubusercontent.com/u/190448?v=3","gravatar_id":"","url":"https://api.github.com/users/ivan4th","html_url":"https://github.com/ivan4th","followers_url":"https://api.github.com/users/ivan4th/followers","following_url":"https://api.github.com/users/ivan4th/following{/other_user}","gists_url":"https://api.github.com/users/ivan4th/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan4th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan4th/subscriptions","organizations_url":"https://api.github.com/users/ivan4th/orgs","repos_url":"https://api.github.com/users/ivan4th/repos","events_url":"https://api.github.com/users/ivan4th/events{/privacy}","received_events_url":"https://api.github.com/users/ivan4th/received_events","type":"User","site_admin":false},"repo":{"id":71801220,"name":"kubeadm-ci-dind","full_name":"ivan4th/kubeadm-ci-dind","owner":{"login":"ivan4th","id":190448,"avatar_url":"https://avatars.githubusercontent.com/u/190448?v=3","gravatar_id":"","url":"https://api.github.com/users/ivan4th","html_url":"https://github.com/ivan4th","followers_url":"https://api.github.com/users/ivan4th/followers","following_url":"https://api.github.com/users/ivan4th/following{/other_user}","gists_url":"https://api.github.com/users/ivan4th/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan4th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan4th/subscriptions","organizations_url":"https://api.github.com/users/ivan4th/orgs","repos_url":"https://api.github.com/users/ivan4th/repos","events_url":"https://api.github.com/users/ivan4th/events{/privacy}","received_events_url":"https://api.github.com/users/ivan4th/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivan4th/kubeadm-ci-dind","description":null,"fork":true,"url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind","forks_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/forks","keys_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/teams","hooks_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/hooks","issue_events_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/issues/events{/number}","events_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/events","assignees_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/assignees{/user}","branches_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/branches{/branch}","tags_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/tags","blobs_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/statuses/{sha}","languages_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/languages","stargazers_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/stargazers","contributors_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/contributors","subscribers_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/subscribers","subscription_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/subscription","commits_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/contents/{+path}","compare_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/merges","archive_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/downloads","issues_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/issues{/number}","pulls_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/pulls{/number}","milestones_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/milestones{/number}","notifications_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/labels{/name}","releases_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/releases{/id}","deployments_url":"https://api.github.com/repos/ivan4th/kubeadm-ci-dind/deployments","created_at":"2016-10-24T15:08:24Z","updated_at":"2016-10-24T15:08:25Z","pushed_at":"2016-10-24T19:30:36Z","git_url":"git://github.com/ivan4th/kubeadm-ci-dind.git","ssh_url":"git@github.com:ivan4th/kubeadm-ci-dind.git","clone_url":"https://github.com/ivan4th/kubeadm-ci-dind.git","svn_url":"https://github.com/ivan4th/kubeadm-ci-dind","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"errordeveloper:master","ref":"master","sha":"00b963431a2bf3a99c3d8132bbd731a11c8d8a03","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"repo":{"id":69240420,"name":"kubeadm-ci-dind","full_name":"errordeveloper/kubeadm-ci-dind","owner":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/errordeveloper/kubeadm-ci-dind","description":null,"fork":false,"url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind","forks_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/forks","keys_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/teams","hooks_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/hooks","issue_events_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/issues/events{/number}","events_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/events","assignees_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/assignees{/user}","branches_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/branches{/branch}","tags_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/tags","blobs_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/git/refs{/sha}","trees_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/statuses/{sha}","languages_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/languages","stargazers_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/stargazers","contributors_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/contributors","subscribers_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/subscribers","subscription_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/subscription","commits_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/commits{/sha}","git_commits_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/git/commits{/sha}","comments_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/comments{/number}","issue_comment_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/issues/comments{/number}","contents_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/contents/{+path}","compare_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/merges","archive_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/downloads","issues_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/issues{/number}","pulls_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls{/number}","milestones_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/milestones{/number}","notifications_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/labels{/name}","releases_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/releases{/id}","deployments_url":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/deployments","created_at":"2016-09-26T10:46:00Z","updated_at":"2016-09-30T17:51:11Z","pushed_at":"2016-10-24T19:30:36Z","git_url":"git://github.com/errordeveloper/kubeadm-ci-dind.git","ssh_url":"git@github.com:errordeveloper/kubeadm-ci-dind.git","clone_url":"https://github.com/errordeveloper/kubeadm-ci-dind.git","svn_url":"https://github.com/errordeveloper/kubeadm-ci-dind","homepage":null,"size":12,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1"},"html":{"href":"https://github.com/errordeveloper/kubeadm-ci-dind/pull/1"},"issue":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/issues/1"},"comments":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/errordeveloper/kubeadm-ci-dind/statuses/785627b808b02580725f20506844e56b810990d7"}}}}
{"actor":{"display_login":"errordeveloper"}}