{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/benchmarking/pulls/comments/66842102","id":66842102,"diff_hunk":"@@ -0,0 +1,13 @@\n+FROM ubuntu:14.04\n+MAINTAINER Gareth Ellis <gareth.ellis@uk.ibm.com>\n+RUN apt-get update && apt-get install git openjdk-7-jdk mongodb zip unzip numactl bc wget -y\n+RUN mkdir /node \n+RUN date\n+WORKDIR /node\n+RUN mkdir Jmeter node_undertest node_baseline\n+RUN git clone http://github.com/gareth-ellis/benchmarking \n+RUN bash /node/benchmarking/experimental/benchmarks/acmeair/setupJmeter.sh\n+RUN numactl --hardware","path":"experimental/benchmarks/acmeair/Dockerfile","position":10,"original_position":10,"commit_id":"86043b850f87bf02bb12099884b6dd8696385d0f","original_commit_id":"86043b850f87bf02bb12099884b6dd8696385d0f","user":{"login":"retrohacker","id":1081565,"avatar_url":"https://avatars.githubusercontent.com/u/1081565?v=3","gravatar_id":"","url":"https://api.github.com/users/retrohacker","html_url":"https://github.com/retrohacker","followers_url":"https://api.github.com/users/retrohacker/followers","following_url":"https://api.github.com/users/retrohacker/following{/other_user}","gists_url":"https://api.github.com/users/retrohacker/gists{/gist_id}","starred_url":"https://api.github.com/users/retrohacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retrohacker/subscriptions","organizations_url":"https://api.github.com/users/retrohacker/orgs","repos_url":"https://api.github.com/users/retrohacker/repos","events_url":"https://api.github.com/users/retrohacker/events{/privacy}","received_events_url":"https://api.github.com/users/retrohacker/received_events","type":"User","site_admin":false},"body":"Ah, I think I may understand what is going on here. Does this output the specs of the machine running the tests?\r\n\r\nIf so, this should be moved into `run_acmeair_docker.sh`. There is no guarantee that the machine running this layer will be the same machine running the run script. Also, Docker will cache this layer and it will not be run every invocation of `docker build`.","created_at":"2016-06-13T18:24:32Z","updated_at":"2016-06-13T18:24:32Z","html_url":"https://github.com/nodejs/benchmarking/pull/49#discussion_r66842102","pull_request_url":"https://api.github.com/repos/nodejs/benchmarking/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/nodejs/benchmarking/pulls/comments/66842102"},"html":{"href":"https://github.com/nodejs/benchmarking/pull/49#discussion_r66842102"},"pull_request":{"href":"https://api.github.com/repos/nodejs/benchmarking/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/benchmarking/pulls/49","id":73186464,"html_url":"https://github.com/nodejs/benchmarking/pull/49","diff_url":"https://github.com/nodejs/benchmarking/pull/49.diff","patch_url":"https://github.com/nodejs/benchmarking/pull/49.patch","issue_url":"https://api.github.com/repos/nodejs/benchmarking/issues/49","number":49,"state":"open","locked":false,"title":"Adding Docker on AcmeAir to repo.","user":{"login":"gareth-ellis","id":14981026,"avatar_url":"https://avatars.githubusercontent.com/u/14981026?v=3","gravatar_id":"","url":"https://api.github.com/users/gareth-ellis","html_url":"https://github.com/gareth-ellis","followers_url":"https://api.github.com/users/gareth-ellis/followers","following_url":"https://api.github.com/users/gareth-ellis/following{/other_user}","gists_url":"https://api.github.com/users/gareth-ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/gareth-ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gareth-ellis/subscriptions","organizations_url":"https://api.github.com/users/gareth-ellis/orgs","repos_url":"https://api.github.com/users/gareth-ellis/repos","events_url":"https://api.github.com/users/gareth-ellis/events{/privacy}","received_events_url":"https://api.github.com/users/gareth-ellis/received_events","type":"User","site_admin":false},"body":"This is the work for running AcmeAIr on docker as requested in #47 \r\n\r\nYou need the Dockerfile, plus two folders - each containing copies of node.\r\n\r\nnode_undertest/bin/node -> this is the copy of node you're wanting to test\r\nnode_baseline/bin/node -> this is the copy of node you're using as a baseline - typically this will be the same as node_undertest but without a change that's potentially risky to performance.\r\n\r\nI've tested it locally and the I'm getting fairly consistent numbers. By default it will run three iterations of copy of node interleaved, and then report a percentage at the end of the test along with the individual scores.\r\n\r\nA percentage above 100% is good, below 100% is bad.\r\n\r\ne.g.\r\n\r\n`docker build -t gareth/acmeair:test .`\r\n\r\nwe then get \r\nRESULTS:\r\nBUILD results:\r\n2144.56 2139.11 2136.03\r\nAverage : 2139\r\nBASELINE results:\r\n1871.63 1914.1 1900.93\r\nAverage: 1895\r\nPercentage of build vs baseline - above 100% is good, less than is bad\r\nPercentage : 112.8700%\r\n\r\nI'll leave this for a day or so and then merge it in - i haven't changed any other files, so it won't effect the current acmeair tests.\r\n","created_at":"2016-06-09T09:58:26Z","updated_at":"2016-06-13T18:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56531320718ef2bae162eac7896abcf43a349cda","assignee":{"login":"gareth-ellis","id":14981026,"avatar_url":"https://avatars.githubusercontent.com/u/14981026?v=3","gravatar_id":"","url":"https://api.github.com/users/gareth-ellis","html_url":"https://github.com/gareth-ellis","followers_url":"https://api.github.com/users/gareth-ellis/followers","following_url":"https://api.github.com/users/gareth-ellis/following{/other_user}","gists_url":"https://api.github.com/users/gareth-ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/gareth-ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gareth-ellis/subscriptions","organizations_url":"https://api.github.com/users/gareth-ellis/orgs","repos_url":"https://api.github.com/users/gareth-ellis/repos","events_url":"https://api.github.com/users/gareth-ellis/events{/privacy}","received_events_url":"https://api.github.com/users/gareth-ellis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/benchmarking/pulls/49/commits","review_comments_url":"https://api.github.com/repos/nodejs/benchmarking/pulls/49/comments","review_comment_url":"https://api.github.com/repos/nodejs/benchmarking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/benchmarking/issues/49/comments","statuses_url":"https://api.github.com/repos/nodejs/benchmarking/statuses/86043b850f87bf02bb12099884b6dd8696385d0f","head":{"label":"gareth-ellis:master","ref":"master","sha":"86043b850f87bf02bb12099884b6dd8696385d0f","user":{"login":"gareth-ellis","id":14981026,"avatar_url":"https://avatars.githubusercontent.com/u/14981026?v=3","gravatar_id":"","url":"https://api.github.com/users/gareth-ellis","html_url":"https://github.com/gareth-ellis","followers_url":"https://api.github.com/users/gareth-ellis/followers","following_url":"https://api.github.com/users/gareth-ellis/following{/other_user}","gists_url":"https://api.github.com/users/gareth-ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/gareth-ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gareth-ellis/subscriptions","organizations_url":"https://api.github.com/users/gareth-ellis/orgs","repos_url":"https://api.github.com/users/gareth-ellis/repos","events_url":"https://api.github.com/users/gareth-ellis/events{/privacy}","received_events_url":"https://api.github.com/users/gareth-ellis/received_events","type":"User","site_admin":false},"repo":{"id":60759291,"name":"benchmarking","full_name":"gareth-ellis/benchmarking","owner":{"login":"gareth-ellis","id":14981026,"avatar_url":"https://avatars.githubusercontent.com/u/14981026?v=3","gravatar_id":"","url":"https://api.github.com/users/gareth-ellis","html_url":"https://github.com/gareth-ellis","followers_url":"https://api.github.com/users/gareth-ellis/followers","following_url":"https://api.github.com/users/gareth-ellis/following{/other_user}","gists_url":"https://api.github.com/users/gareth-ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/gareth-ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gareth-ellis/subscriptions","organizations_url":"https://api.github.com/users/gareth-ellis/orgs","repos_url":"https://api.github.com/users/gareth-ellis/repos","events_url":"https://api.github.com/users/gareth-ellis/events{/privacy}","received_events_url":"https://api.github.com/users/gareth-ellis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gareth-ellis/benchmarking","description":"Node.js Benchmarking Working Group","fork":true,"url":"https://api.github.com/repos/gareth-ellis/benchmarking","forks_url":"https://api.github.com/repos/gareth-ellis/benchmarking/forks","keys_url":"https://api.github.com/repos/gareth-ellis/benchmarking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gareth-ellis/benchmarking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gareth-ellis/benchmarking/teams","hooks_url":"https://api.github.com/repos/gareth-ellis/benchmarking/hooks","issue_events_url":"https://api.github.com/repos/gareth-ellis/benchmarking/issues/events{/number}","events_url":"https://api.github.com/repos/gareth-ellis/benchmarking/events","assignees_url":"https://api.github.com/repos/gareth-ellis/benchmarking/assignees{/user}","branches_url":"https://api.github.com/repos/gareth-ellis/benchmarking/branches{/branch}","tags_url":"https://api.github.com/repos/gareth-ellis/benchmarking/tags","blobs_url":"https://api.github.com/repos/gareth-ellis/benchmarking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gareth-ellis/benchmarking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gareth-ellis/benchmarking/git/refs{/sha}","trees_url":"https://api.github.com/repos/gareth-ellis/benchmarking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gareth-ellis/benchmarking/statuses/{sha}","languages_url":"https://api.github.com/repos/gareth-ellis/benchmarking/languages","stargazers_url":"https://api.github.com/repos/gareth-ellis/benchmarking/stargazers","contributors_url":"https://api.github.com/repos/gareth-ellis/benchmarking/contributors","subscribers_url":"https://api.github.com/repos/gareth-ellis/benchmarking/subscribers","subscription_url":"https://api.github.com/repos/gareth-ellis/benchmarking/subscription","commits_url":"https://api.github.com/repos/gareth-ellis/benchmarking/commits{/sha}","git_commits_url":"https://api.github.com/repos/gareth-ellis/benchmarking/git/commits{/sha}","comments_url":"https://api.github.com/repos/gareth-ellis/benchmarking/comments{/number}","issue_comment_url":"https://api.github.com/repos/gareth-ellis/benchmarking/issues/comments{/number}","contents_url":"https://api.github.com/repos/gareth-ellis/benchmarking/contents/{+path}","compare_url":"https://api.github.com/repos/gareth-ellis/benchmarking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gareth-ellis/benchmarking/merges","archive_url":"https://api.github.com/repos/gareth-ellis/benchmarking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gareth-ellis/benchmarking/downloads","issues_url":"https://api.github.com/repos/gareth-ellis/benchmarking/issues{/number}","pulls_url":"https://api.github.com/repos/gareth-ellis/benchmarking/pulls{/number}","milestones_url":"https://api.github.com/repos/gareth-ellis/benchmarking/milestones{/number}","notifications_url":"https://api.github.com/repos/gareth-ellis/benchmarking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gareth-ellis/benchmarking/labels{/name}","releases_url":"https://api.github.com/repos/gareth-ellis/benchmarking/releases{/id}","deployments_url":"https://api.github.com/repos/gareth-ellis/benchmarking/deployments","created_at":"2016-06-09T08:12:53Z","updated_at":"2016-06-09T08:12:54Z","pushed_at":"2016-06-09T08:15:15Z","git_url":"git://github.com/gareth-ellis/benchmarking.git","ssh_url":"git@github.com:gareth-ellis/benchmarking.git","clone_url":"https://github.com/gareth-ellis/benchmarking.git","svn_url":"https://github.com/gareth-ellis/benchmarking","homepage":"https://benchmarking.nodejs.org","size":5261,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"db6cedb0811a702a10dda643ba8c254e7f8f3e53","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":36107715,"name":"benchmarking","full_name":"nodejs/benchmarking","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/benchmarking","description":"Node.js Benchmarking Working Group","fork":false,"url":"https://api.github.com/repos/nodejs/benchmarking","forks_url":"https://api.github.com/repos/nodejs/benchmarking/forks","keys_url":"https://api.github.com/repos/nodejs/benchmarking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/benchmarking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/benchmarking/teams","hooks_url":"https://api.github.com/repos/nodejs/benchmarking/hooks","issue_events_url":"https://api.github.com/repos/nodejs/benchmarking/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/benchmarking/events","assignees_url":"https://api.github.com/repos/nodejs/benchmarking/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/benchmarking/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/benchmarking/tags","blobs_url":"https://api.github.com/repos/nodejs/benchmarking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/benchmarking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/benchmarking/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/benchmarking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/benchmarking/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/benchmarking/languages","stargazers_url":"https://api.github.com/repos/nodejs/benchmarking/stargazers","contributors_url":"https://api.github.com/repos/nodejs/benchmarking/contributors","subscribers_url":"https://api.github.com/repos/nodejs/benchmarking/subscribers","subscription_url":"https://api.github.com/repos/nodejs/benchmarking/subscription","commits_url":"https://api.github.com/repos/nodejs/benchmarking/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/benchmarking/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/benchmarking/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/benchmarking/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/benchmarking/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/benchmarking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/benchmarking/merges","archive_url":"https://api.github.com/repos/nodejs/benchmarking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/benchmarking/downloads","issues_url":"https://api.github.com/repos/nodejs/benchmarking/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/benchmarking/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/benchmarking/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/benchmarking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/benchmarking/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/benchmarking/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/benchmarking/deployments","created_at":"2015-05-23T05:08:03Z","updated_at":"2016-06-01T06:31:01Z","pushed_at":"2016-06-09T09:58:26Z","git_url":"git://github.com/nodejs/benchmarking.git","ssh_url":"git@github.com:nodejs/benchmarking.git","clone_url":"https://github.com/nodejs/benchmarking.git","svn_url":"https://github.com/nodejs/benchmarking","homepage":"https://benchmarking.nodejs.org","size":5267,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":15,"forks":12,"open_issues":15,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/benchmarking/pulls/49"},"html":{"href":"https://github.com/nodejs/benchmarking/pull/49"},"issue":{"href":"https://api.github.com/repos/nodejs/benchmarking/issues/49"},"comments":{"href":"https://api.github.com/repos/nodejs/benchmarking/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/benchmarking/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/benchmarking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/benchmarking/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/benchmarking/statuses/86043b850f87bf02bb12099884b6dd8696385d0f"}}}}
{"actor":{"display_login":"retrohacker"}}