{"action":"created","issue":{"url":"https://api.github.com/repos/AtomLinter/linter-rust/issues/59","repository_url":"https://api.github.com/repos/AtomLinter/linter-rust","labels_url":"https://api.github.com/repos/AtomLinter/linter-rust/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/AtomLinter/linter-rust/issues/59/comments","events_url":"https://api.github.com/repos/AtomLinter/linter-rust/issues/59/events","html_url":"https://github.com/AtomLinter/linter-rust/issues/59","id":153165406,"number":59,"title":"options.PATH ignored by BufferedProcess","user":{"login":"saghm","id":5875560,"avatar_url":"https://avatars.githubusercontent.com/u/5875560?v=3","gravatar_id":"","url":"https://api.github.com/users/saghm","html_url":"https://github.com/saghm","followers_url":"https://api.github.com/users/saghm/followers","following_url":"https://api.github.com/users/saghm/following{/other_user}","gists_url":"https://api.github.com/users/saghm/gists{/gist_id}","starred_url":"https://api.github.com/users/saghm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghm/subscriptions","organizations_url":"https://api.github.com/users/saghm/orgs","repos_url":"https://api.github.com/users/saghm/repos","events_url":"https://api.github.com/users/saghm/events{/privacy}","received_events_url":"https://api.github.com/users/saghm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AtomLinter/linter-rust/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-05-05T04:21:02Z","updated_at":"2016-07-10T22:13:48Z","closed_at":null,"body":"I've been experiencing a bug after upgrading to version 0.4.6 where I'm not getting any error messages from Cargo. After delving into the code and eventually (accidentally) realizing that the issue disappears when Atom is run directly from the command line, I tracked down the issue to [this](https://github.com/AtomLinter/linter-rust/blob/master/lib/linter-rust.coffee#L22). While making a copy rather than modifying global state definitely seems like a better idea, it seems to be preventing Cargo from being properly run for me because `BufferedProcess` actually uses the global state—it doesn't even look at `options.PATH`! The documentation [here](https://github.com/atom/atom/blob/master/src/buffered-process.coffee#L26-L78) indicates that the options it uses don't include the path, and in the function definition it calls [`getCmdPath`](https://github.com/atom/atom/blob/master/src/buffered-process.coffee#L176-L182), which looks directly at `process.env`. I'm not sure when this change occurred in Atom (I looked back a few commits on the file without seeing anything about the path), but it appears that `BufferedProcess` has been ignoring the custom path for a while, and using custom paths only worked before due to the fluke of modifying the global state.\r\n\r\nGiven that this bug will only occur in very specific setups (i.e. not running Atom from the command line and having `cargo`/`rustc` installed in non-standard path locations) and that the issue seems to be more with the `BufferedReader` and not with the package (forcing people to modify global state just seems like bad practice), I can understand if you'd prefer not to change it back to modifying the global state. However, I figured it would still be worth reporting the issue just so you'd be aware that the custom path was being ignored (and due to the off chance that someone else ends up having the same issue as me and wants to know what causes it)."},"comment":{"url":"https://api.github.com/repos/AtomLinter/linter-rust/issues/comments/231614034","html_url":"https://github.com/AtomLinter/linter-rust/issues/59#issuecomment-231614034","issue_url":"https://api.github.com/repos/AtomLinter/linter-rust/issues/59","id":231614034,"user":{"login":"dikaiosune","id":6812281,"avatar_url":"https://avatars.githubusercontent.com/u/6812281?v=3","gravatar_id":"","url":"https://api.github.com/users/dikaiosune","html_url":"https://github.com/dikaiosune","followers_url":"https://api.github.com/users/dikaiosune/followers","following_url":"https://api.github.com/users/dikaiosune/following{/other_user}","gists_url":"https://api.github.com/users/dikaiosune/gists{/gist_id}","starred_url":"https://api.github.com/users/dikaiosune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dikaiosune/subscriptions","organizations_url":"https://api.github.com/users/dikaiosune/orgs","repos_url":"https://api.github.com/users/dikaiosune/repos","events_url":"https://api.github.com/users/dikaiosune/events{/privacy}","received_events_url":"https://api.github.com/users/dikaiosune/received_events","type":"User","site_admin":false},"created_at":"2016-07-10T22:13:48Z","updated_at":"2016-07-10T22:13:48Z","body":"I'm running into an issue that seems very much like this after switching from multirust to rustup.rs."}}
{"actor":{"display_login":"dikaiosune"}}