{"action":"created","comment":{"url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/comments/90772283","pull_request_review_id":11289679,"id":90772283,"diff_hunk":"@@ -1490,6 +1457,80 @@ xrdp_wm_key(struct xrdp_wm *self, int device_flags, int scan_code)\n }\n \n /*****************************************************************************/\n+int APP_CC\n+xrdp_wm_key_unicode(struct xrdp_wm *self, int device_flags, int unicode)\n+{\n+    int index;\n+\n+    for (index = 8; index < 256; index++)\n+    {\n+        if (unicode == self->keymap.keys_noshift[index].chr)\n+        {\n+            xrdp_wm_key(self, device_flags, index - 8);\n+            return 0;\n+        }\n+    }\n+\n+    for (index = 8; index < 256; index++)\n+    {\n+        if (unicode == self->keymap.keys_shift[index].chr)\n+        {\n+            if (device_flags & KBD_FLAG_UP)\n+            {\n+                xrdp_wm_key(self, device_flags, index - 8);\n+                xrdp_wm_key(self, KBD_FLAG_UP, 42);","path":"xrdp/xrdp_wm.c","position":104,"original_position":104,"commit_id":"116cb3661b1f94716c7510c37ee4aedaf418d9bb","original_commit_id":"116cb3661b1f94716c7510c37ee4aedaf418d9bb","user":{"login":"proski","id":1317472,"avatar_url":"https://avatars.githubusercontent.com/u/1317472?v=3","gravatar_id":"","url":"https://api.github.com/users/proski","html_url":"https://github.com/proski","followers_url":"https://api.github.com/users/proski/followers","following_url":"https://api.github.com/users/proski/following{/other_user}","gists_url":"https://api.github.com/users/proski/gists{/gist_id}","starred_url":"https://api.github.com/users/proski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proski/subscriptions","organizations_url":"https://api.github.com/users/proski/orgs","repos_url":"https://api.github.com/users/proski/repos","events_url":"https://api.github.com/users/proski/events{/privacy}","received_events_url":"https://api.github.com/users/proski/received_events","type":"User","site_admin":false},"body":"Magic number 42 ;)","created_at":"2016-12-04T07:31:37Z","updated_at":"2016-12-04T07:32:56Z","html_url":"https://github.com/neutrinolabs/xrdp/pull/522#discussion_r90772283","pull_request_url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522","_links":{"self":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/comments/90772283"},"html":{"href":"https://github.com/neutrinolabs/xrdp/pull/522#discussion_r90772283"},"pull_request":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522"}}},"pull_request":{"url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522","id":96388495,"html_url":"https://github.com/neutrinolabs/xrdp/pull/522","diff_url":"https://github.com/neutrinolabs/xrdp/pull/522.diff","patch_url":"https://github.com/neutrinolabs/xrdp/pull/522.patch","issue_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/522","number":522,"state":"open","locked":false,"title":"[Review only] noorders","user":{"login":"proski","id":1317472,"avatar_url":"https://avatars.githubusercontent.com/u/1317472?v=3","gravatar_id":"","url":"https://api.github.com/users/proski","html_url":"https://github.com/proski","followers_url":"https://api.github.com/users/proski/followers","following_url":"https://api.github.com/users/proski/following{/other_user}","gists_url":"https://api.github.com/users/proski/gists{/gist_id}","starred_url":"https://api.github.com/users/proski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proski/subscriptions","organizations_url":"https://api.github.com/users/proski/orgs","repos_url":"https://api.github.com/users/proski/repos","events_url":"https://api.github.com/users/proski/events{/privacy}","received_events_url":"https://api.github.com/users/proski/received_events","type":"User","site_admin":false},"body":"This is not my code. I'm submitting this branch so that we have an option to examine the changes and comment on them now. It's a big change that requires careful review.\r\n\r\nI want to make sure everybody is fine with the subpackage approach. It means that xrdp will be distributed with the libpainter code. There would be an option to distribute libpainter separately as well.","created_at":"2016-12-03T06:18:25Z","updated_at":"2016-12-04T07:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c35d1d808641e764598fdd721554dc05823b389e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522/commits","review_comments_url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522/comments","review_comment_url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/522/comments","statuses_url":"https://api.github.com/repos/neutrinolabs/xrdp/statuses/116cb3661b1f94716c7510c37ee4aedaf418d9bb","head":{"label":"proski:noorders","ref":"noorders","sha":"116cb3661b1f94716c7510c37ee4aedaf418d9bb","user":{"login":"proski","id":1317472,"avatar_url":"https://avatars.githubusercontent.com/u/1317472?v=3","gravatar_id":"","url":"https://api.github.com/users/proski","html_url":"https://github.com/proski","followers_url":"https://api.github.com/users/proski/followers","following_url":"https://api.github.com/users/proski/following{/other_user}","gists_url":"https://api.github.com/users/proski/gists{/gist_id}","starred_url":"https://api.github.com/users/proski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proski/subscriptions","organizations_url":"https://api.github.com/users/proski/orgs","repos_url":"https://api.github.com/users/proski/repos","events_url":"https://api.github.com/users/proski/events{/privacy}","received_events_url":"https://api.github.com/users/proski/received_events","type":"User","site_admin":false},"repo":{"id":49557491,"name":"xrdp","full_name":"proski/xrdp","owner":{"login":"proski","id":1317472,"avatar_url":"https://avatars.githubusercontent.com/u/1317472?v=3","gravatar_id":"","url":"https://api.github.com/users/proski","html_url":"https://github.com/proski","followers_url":"https://api.github.com/users/proski/followers","following_url":"https://api.github.com/users/proski/following{/other_user}","gists_url":"https://api.github.com/users/proski/gists{/gist_id}","starred_url":"https://api.github.com/users/proski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proski/subscriptions","organizations_url":"https://api.github.com/users/proski/orgs","repos_url":"https://api.github.com/users/proski/repos","events_url":"https://api.github.com/users/proski/events{/privacy}","received_events_url":"https://api.github.com/users/proski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/proski/xrdp","description":"xrdp: an open source RDP server","fork":true,"url":"https://api.github.com/repos/proski/xrdp","forks_url":"https://api.github.com/repos/proski/xrdp/forks","keys_url":"https://api.github.com/repos/proski/xrdp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proski/xrdp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proski/xrdp/teams","hooks_url":"https://api.github.com/repos/proski/xrdp/hooks","issue_events_url":"https://api.github.com/repos/proski/xrdp/issues/events{/number}","events_url":"https://api.github.com/repos/proski/xrdp/events","assignees_url":"https://api.github.com/repos/proski/xrdp/assignees{/user}","branches_url":"https://api.github.com/repos/proski/xrdp/branches{/branch}","tags_url":"https://api.github.com/repos/proski/xrdp/tags","blobs_url":"https://api.github.com/repos/proski/xrdp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proski/xrdp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proski/xrdp/git/refs{/sha}","trees_url":"https://api.github.com/repos/proski/xrdp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proski/xrdp/statuses/{sha}","languages_url":"https://api.github.com/repos/proski/xrdp/languages","stargazers_url":"https://api.github.com/repos/proski/xrdp/stargazers","contributors_url":"https://api.github.com/repos/proski/xrdp/contributors","subscribers_url":"https://api.github.com/repos/proski/xrdp/subscribers","subscription_url":"https://api.github.com/repos/proski/xrdp/subscription","commits_url":"https://api.github.com/repos/proski/xrdp/commits{/sha}","git_commits_url":"https://api.github.com/repos/proski/xrdp/git/commits{/sha}","comments_url":"https://api.github.com/repos/proski/xrdp/comments{/number}","issue_comment_url":"https://api.github.com/repos/proski/xrdp/issues/comments{/number}","contents_url":"https://api.github.com/repos/proski/xrdp/contents/{+path}","compare_url":"https://api.github.com/repos/proski/xrdp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proski/xrdp/merges","archive_url":"https://api.github.com/repos/proski/xrdp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proski/xrdp/downloads","issues_url":"https://api.github.com/repos/proski/xrdp/issues{/number}","pulls_url":"https://api.github.com/repos/proski/xrdp/pulls{/number}","milestones_url":"https://api.github.com/repos/proski/xrdp/milestones{/number}","notifications_url":"https://api.github.com/repos/proski/xrdp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proski/xrdp/labels{/name}","releases_url":"https://api.github.com/repos/proski/xrdp/releases{/id}","deployments_url":"https://api.github.com/repos/proski/xrdp/deployments","created_at":"2016-01-13T07:31:16Z","updated_at":"2016-01-13T07:31:18Z","pushed_at":"2016-12-04T06:35:21Z","git_url":"git://github.com/proski/xrdp.git","ssh_url":"git@github.com:proski/xrdp.git","clone_url":"https://github.com/proski/xrdp.git","svn_url":"https://github.com/proski/xrdp","homepage":"http://www.xrdp.org/","size":10702,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"neutrinolabs:devel","ref":"devel","sha":"42d370fcddcbf131618b2a9b741203952a3242db","user":{"login":"neutrinolabs","id":2615587,"avatar_url":"https://avatars.githubusercontent.com/u/2615587?v=3","gravatar_id":"","url":"https://api.github.com/users/neutrinolabs","html_url":"https://github.com/neutrinolabs","followers_url":"https://api.github.com/users/neutrinolabs/followers","following_url":"https://api.github.com/users/neutrinolabs/following{/other_user}","gists_url":"https://api.github.com/users/neutrinolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/neutrinolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neutrinolabs/subscriptions","organizations_url":"https://api.github.com/users/neutrinolabs/orgs","repos_url":"https://api.github.com/users/neutrinolabs/repos","events_url":"https://api.github.com/users/neutrinolabs/events{/privacy}","received_events_url":"https://api.github.com/users/neutrinolabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1660127,"name":"xrdp","full_name":"neutrinolabs/xrdp","owner":{"login":"neutrinolabs","id":2615587,"avatar_url":"https://avatars.githubusercontent.com/u/2615587?v=3","gravatar_id":"","url":"https://api.github.com/users/neutrinolabs","html_url":"https://github.com/neutrinolabs","followers_url":"https://api.github.com/users/neutrinolabs/followers","following_url":"https://api.github.com/users/neutrinolabs/following{/other_user}","gists_url":"https://api.github.com/users/neutrinolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/neutrinolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neutrinolabs/subscriptions","organizations_url":"https://api.github.com/users/neutrinolabs/orgs","repos_url":"https://api.github.com/users/neutrinolabs/repos","events_url":"https://api.github.com/users/neutrinolabs/events{/privacy}","received_events_url":"https://api.github.com/users/neutrinolabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neutrinolabs/xrdp","description":"xrdp: an open source RDP server","fork":false,"url":"https://api.github.com/repos/neutrinolabs/xrdp","forks_url":"https://api.github.com/repos/neutrinolabs/xrdp/forks","keys_url":"https://api.github.com/repos/neutrinolabs/xrdp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neutrinolabs/xrdp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neutrinolabs/xrdp/teams","hooks_url":"https://api.github.com/repos/neutrinolabs/xrdp/hooks","issue_events_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/events{/number}","events_url":"https://api.github.com/repos/neutrinolabs/xrdp/events","assignees_url":"https://api.github.com/repos/neutrinolabs/xrdp/assignees{/user}","branches_url":"https://api.github.com/repos/neutrinolabs/xrdp/branches{/branch}","tags_url":"https://api.github.com/repos/neutrinolabs/xrdp/tags","blobs_url":"https://api.github.com/repos/neutrinolabs/xrdp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neutrinolabs/xrdp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neutrinolabs/xrdp/git/refs{/sha}","trees_url":"https://api.github.com/repos/neutrinolabs/xrdp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neutrinolabs/xrdp/statuses/{sha}","languages_url":"https://api.github.com/repos/neutrinolabs/xrdp/languages","stargazers_url":"https://api.github.com/repos/neutrinolabs/xrdp/stargazers","contributors_url":"https://api.github.com/repos/neutrinolabs/xrdp/contributors","subscribers_url":"https://api.github.com/repos/neutrinolabs/xrdp/subscribers","subscription_url":"https://api.github.com/repos/neutrinolabs/xrdp/subscription","commits_url":"https://api.github.com/repos/neutrinolabs/xrdp/commits{/sha}","git_commits_url":"https://api.github.com/repos/neutrinolabs/xrdp/git/commits{/sha}","comments_url":"https://api.github.com/repos/neutrinolabs/xrdp/comments{/number}","issue_comment_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/comments{/number}","contents_url":"https://api.github.com/repos/neutrinolabs/xrdp/contents/{+path}","compare_url":"https://api.github.com/repos/neutrinolabs/xrdp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neutrinolabs/xrdp/merges","archive_url":"https://api.github.com/repos/neutrinolabs/xrdp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neutrinolabs/xrdp/downloads","issues_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues{/number}","pulls_url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls{/number}","milestones_url":"https://api.github.com/repos/neutrinolabs/xrdp/milestones{/number}","notifications_url":"https://api.github.com/repos/neutrinolabs/xrdp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neutrinolabs/xrdp/labels{/name}","releases_url":"https://api.github.com/repos/neutrinolabs/xrdp/releases{/id}","deployments_url":"https://api.github.com/repos/neutrinolabs/xrdp/deployments","created_at":"2011-04-25T14:31:17Z","updated_at":"2016-12-03T09:30:37Z","pushed_at":"2016-12-04T06:35:22Z","git_url":"git://github.com/neutrinolabs/xrdp.git","ssh_url":"git@github.com:neutrinolabs/xrdp.git","clone_url":"https://github.com/neutrinolabs/xrdp.git","svn_url":"https://github.com/neutrinolabs/xrdp","homepage":"http://www.xrdp.org/","size":13807,"stargazers_count":396,"watchers_count":396,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"open_issues_count":145,"forks":197,"open_issues":145,"watchers":396,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522"},"html":{"href":"https://github.com/neutrinolabs/xrdp/pull/522"},"issue":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/issues/522"},"comments":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/issues/522/comments"},"review_comments":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522/comments"},"review_comment":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/522/commits"},"statuses":{"href":"https://api.github.com/repos/neutrinolabs/xrdp/statuses/116cb3661b1f94716c7510c37ee4aedaf418d9bb"}}}}
{"actor":{"display_login":"proski"}}