{"action":"created","comment":{"url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/comments/78499501","id":78499501,"diff_hunk":"@@ -185,12 +185,25 @@ def build_nginx_conf(self):\n         public_ssl = self.public_ssl_cert != ''\n         api_ssl = self.api_ssl_cert != ''\n \n+        # '' means 'listen on all interfaces' in python / nodejs\n+        # So we take it in to be compatible\n+        # FIXME: check what this does for ipv6\n+        if self.public_ip = '':","path":"nchp/app.py","position":7,"original_position":7,"commit_id":"e3b944ea53cd7c591a0b0218db6cf8aaf0fb04b8","original_commit_id":"e3b944ea53cd7c591a0b0218db6cf8aaf0fb04b8","user":{"login":"ryanlovett","id":10248125,"avatar_url":"https://avatars.githubusercontent.com/u/10248125?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanlovett","html_url":"https://github.com/ryanlovett","followers_url":"https://api.github.com/users/ryanlovett/followers","following_url":"https://api.github.com/users/ryanlovett/following{/other_user}","gists_url":"https://api.github.com/users/ryanlovett/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlovett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlovett/subscriptions","organizations_url":"https://api.github.com/users/ryanlovett/orgs","repos_url":"https://api.github.com/users/ryanlovett/repos","events_url":"https://api.github.com/users/ryanlovett/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlovett/received_events","type":"User","site_admin":false},"body":"s/=/==/","created_at":"2016-09-13T05:46:25Z","updated_at":"2016-09-13T05:46:25Z","html_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp/pull/8#discussion_r78499501","pull_request_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/comments/78499501"},"html":{"href":"https://github.com/yuvipanda/jupyterhub-nginx-chp/pull/8#discussion_r78499501"},"pull_request":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8","id":84964185,"html_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp/pull/8","diff_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp/pull/8.diff","patch_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp/pull/8.patch","issue_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/8","number":8,"state":"open","locked":false,"title":"Accept empty ip to mean 'all interfaces'","user":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"body":"For consistency with python/node\r\n\r\nSee discussion on https://github.com/jupyterhub/jupyterhub/pull/740","created_at":"2016-09-12T23:47:54Z","updated_at":"2016-09-13T05:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bfdff086054391aad8c16f658c21656ce0a7dfa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8/commits","review_comments_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8/comments","review_comment_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/8/comments","statuses_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/statuses/e3b944ea53cd7c591a0b0218db6cf8aaf0fb04b8","head":{"label":"yuvipanda:empty_ip","ref":"empty_ip","sha":"e3b944ea53cd7c591a0b0218db6cf8aaf0fb04b8","user":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"repo":{"id":50231851,"name":"jupyterhub-nginx-chp","full_name":"yuvipanda/jupyterhub-nginx-chp","owner":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp","description":"configurable-http-proxy for use with JupyterHub written in nginx + lua","fork":false,"url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp","forks_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/forks","keys_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/teams","hooks_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/hooks","issue_events_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/events{/number}","events_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/events","assignees_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/assignees{/user}","branches_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/branches{/branch}","tags_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/tags","blobs_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/statuses/{sha}","languages_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/languages","stargazers_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/stargazers","contributors_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/contributors","subscribers_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/subscribers","subscription_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/subscription","commits_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/contents/{+path}","compare_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/merges","archive_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/downloads","issues_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues{/number}","pulls_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls{/number}","milestones_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/milestones{/number}","notifications_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/labels{/name}","releases_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/releases{/id}","deployments_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/deployments","created_at":"2016-01-23T09:18:30Z","updated_at":"2016-02-13T21:35:12Z","pushed_at":"2016-09-12T23:47:54Z","git_url":"git://github.com/yuvipanda/jupyterhub-nginx-chp.git","ssh_url":"git@github.com:yuvipanda/jupyterhub-nginx-chp.git","clone_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp.git","svn_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp","homepage":null,"size":28,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"yuvipanda:master","ref":"master","sha":"3ddd040092976161e8b0d28ac53943ec1247eac3","user":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"repo":{"id":50231851,"name":"jupyterhub-nginx-chp","full_name":"yuvipanda/jupyterhub-nginx-chp","owner":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp","description":"configurable-http-proxy for use with JupyterHub written in nginx + lua","fork":false,"url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp","forks_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/forks","keys_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/teams","hooks_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/hooks","issue_events_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/events{/number}","events_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/events","assignees_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/assignees{/user}","branches_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/branches{/branch}","tags_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/tags","blobs_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/statuses/{sha}","languages_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/languages","stargazers_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/stargazers","contributors_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/contributors","subscribers_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/subscribers","subscription_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/subscription","commits_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/contents/{+path}","compare_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/merges","archive_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/downloads","issues_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues{/number}","pulls_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls{/number}","milestones_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/milestones{/number}","notifications_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/labels{/name}","releases_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/releases{/id}","deployments_url":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/deployments","created_at":"2016-01-23T09:18:30Z","updated_at":"2016-02-13T21:35:12Z","pushed_at":"2016-09-12T23:47:54Z","git_url":"git://github.com/yuvipanda/jupyterhub-nginx-chp.git","ssh_url":"git@github.com:yuvipanda/jupyterhub-nginx-chp.git","clone_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp.git","svn_url":"https://github.com/yuvipanda/jupyterhub-nginx-chp","homepage":null,"size":28,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8"},"html":{"href":"https://github.com/yuvipanda/jupyterhub-nginx-chp/pull/8"},"issue":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/8"},"comments":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/yuvipanda/jupyterhub-nginx-chp/statuses/e3b944ea53cd7c591a0b0218db6cf8aaf0fb04b8"}}}}
{"actor":{"display_login":"ryanlovett"}}