{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/88978334","pull_request_review_id":9521152,"id":88978334,"diff_hunk":"@@ -17,17 +17,17 @@\n \n #![feature(rustc_attrs)]\n \n-#[rustc_clean(label=\"Hir\", cfg=\"rpass2\")]\n+#[rustc_clean(label=\"HirBody\", cfg=\"rpass2\")]\n fn line_same() {\n     let _ = line!();\n }\n \n-#[rustc_clean(label=\"Hir\", cfg=\"rpass2\")]\n+#[rustc_clean(label=\"HirBody\", cfg=\"rpass2\")]\n fn col_same() {\n     let _ = column!();\n }\n \n-#[rustc_clean(label=\"Hir\", cfg=\"rpass2\")]\n+#[rustc_clean(label=\"HirBody\", cfg=\"rpass2\")]","path":"src/test/incremental/source_loc_macros.rs","position":17,"original_position":17,"commit_id":"c7d698143c018b2436077fd1a32ce3d8b0a293f7","original_commit_id":"c6525e7647fd36c6f1ca4882de440f81005f7ade","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"Seems like it'd be good to have both `Hir` and `HirBody` here?","created_at":"2016-11-21T20:13:30Z","updated_at":"2016-11-21T20:22:20Z","html_url":"https://github.com/rust-lang/rust/pull/37918#discussion_r88978334","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/37918","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/88978334"},"html":{"href":"https://github.com/rust-lang/rust/pull/37918#discussion_r88978334"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/37918"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/37918","id":94668368,"html_url":"https://github.com/rust-lang/rust/pull/37918","diff_url":"https://github.com/rust-lang/rust/pull/37918.diff","patch_url":"https://github.com/rust-lang/rust/pull/37918.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/37918","number":37918,"state":"open","locked":false,"title":"Separate function bodies from their signatures in HIR","user":{"login":"flodiebold","id":906069,"avatar_url":"https://avatars.githubusercontent.com/u/906069?v=3","gravatar_id":"","url":"https://api.github.com/users/flodiebold","html_url":"https://github.com/flodiebold","followers_url":"https://api.github.com/users/flodiebold/followers","following_url":"https://api.github.com/users/flodiebold/following{/other_user}","gists_url":"https://api.github.com/users/flodiebold/gists{/gist_id}","starred_url":"https://api.github.com/users/flodiebold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodiebold/subscriptions","organizations_url":"https://api.github.com/users/flodiebold/orgs","repos_url":"https://api.github.com/users/flodiebold/repos","events_url":"https://api.github.com/users/flodiebold/events{/privacy}","received_events_url":"https://api.github.com/users/flodiebold/received_events","type":"User","site_admin":false},"body":"Also give them their own dep map node.\r\n\r\nI'm still unhappy with the handling of inlined items (1452edc1), but maybe you have a suggestion how to improve it.\r\n\r\nFixes #35078.\r\n\r\nr? @nikomatsakis","created_at":"2016-11-21T18:17:13Z","updated_at":"2016-11-21T20:22:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a533076cf401f9352fc649443503cfd85fa56b10","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/37918/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/37918/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/37918/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/c7d698143c018b2436077fd1a32ce3d8b0a293f7","head":{"label":"flodiebold:separate-bodies","ref":"separate-bodies","sha":"c7d698143c018b2436077fd1a32ce3d8b0a293f7","user":{"login":"flodiebold","id":906069,"avatar_url":"https://avatars.githubusercontent.com/u/906069?v=3","gravatar_id":"","url":"https://api.github.com/users/flodiebold","html_url":"https://github.com/flodiebold","followers_url":"https://api.github.com/users/flodiebold/followers","following_url":"https://api.github.com/users/flodiebold/following{/other_user}","gists_url":"https://api.github.com/users/flodiebold/gists{/gist_id}","starred_url":"https://api.github.com/users/flodiebold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodiebold/subscriptions","organizations_url":"https://api.github.com/users/flodiebold/orgs","repos_url":"https://api.github.com/users/flodiebold/repos","events_url":"https://api.github.com/users/flodiebold/events{/privacy}","received_events_url":"https://api.github.com/users/flodiebold/received_events","type":"User","site_admin":false},"repo":{"id":70330584,"name":"rust","full_name":"flodiebold/rust","owner":{"login":"flodiebold","id":906069,"avatar_url":"https://avatars.githubusercontent.com/u/906069?v=3","gravatar_id":"","url":"https://api.github.com/users/flodiebold","html_url":"https://github.com/flodiebold","followers_url":"https://api.github.com/users/flodiebold/followers","following_url":"https://api.github.com/users/flodiebold/following{/other_user}","gists_url":"https://api.github.com/users/flodiebold/gists{/gist_id}","starred_url":"https://api.github.com/users/flodiebold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodiebold/subscriptions","organizations_url":"https://api.github.com/users/flodiebold/orgs","repos_url":"https://api.github.com/users/flodiebold/repos","events_url":"https://api.github.com/users/flodiebold/events{/privacy}","received_events_url":"https://api.github.com/users/flodiebold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flodiebold/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/flodiebold/rust","forks_url":"https://api.github.com/repos/flodiebold/rust/forks","keys_url":"https://api.github.com/repos/flodiebold/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flodiebold/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flodiebold/rust/teams","hooks_url":"https://api.github.com/repos/flodiebold/rust/hooks","issue_events_url":"https://api.github.com/repos/flodiebold/rust/issues/events{/number}","events_url":"https://api.github.com/repos/flodiebold/rust/events","assignees_url":"https://api.github.com/repos/flodiebold/rust/assignees{/user}","branches_url":"https://api.github.com/repos/flodiebold/rust/branches{/branch}","tags_url":"https://api.github.com/repos/flodiebold/rust/tags","blobs_url":"https://api.github.com/repos/flodiebold/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flodiebold/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flodiebold/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/flodiebold/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flodiebold/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/flodiebold/rust/languages","stargazers_url":"https://api.github.com/repos/flodiebold/rust/stargazers","contributors_url":"https://api.github.com/repos/flodiebold/rust/contributors","subscribers_url":"https://api.github.com/repos/flodiebold/rust/subscribers","subscription_url":"https://api.github.com/repos/flodiebold/rust/subscription","commits_url":"https://api.github.com/repos/flodiebold/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/flodiebold/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/flodiebold/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/flodiebold/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/flodiebold/rust/contents/{+path}","compare_url":"https://api.github.com/repos/flodiebold/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flodiebold/rust/merges","archive_url":"https://api.github.com/repos/flodiebold/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flodiebold/rust/downloads","issues_url":"https://api.github.com/repos/flodiebold/rust/issues{/number}","pulls_url":"https://api.github.com/repos/flodiebold/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/flodiebold/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/flodiebold/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flodiebold/rust/labels{/name}","releases_url":"https://api.github.com/repos/flodiebold/rust/releases{/id}","deployments_url":"https://api.github.com/repos/flodiebold/rust/deployments","created_at":"2016-10-08T12:45:48Z","updated_at":"2016-10-08T12:46:07Z","pushed_at":"2016-11-21T19:34:31Z","git_url":"git://github.com/flodiebold/rust.git","ssh_url":"git@github.com:flodiebold/rust.git","clone_url":"https://github.com/flodiebold/rust.git","svn_url":"https://github.com/flodiebold/rust","homepage":"https://www.rust-lang.org","size":310505,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"ebec55406ba94faf8b2cd23b27a8f74df97d1ca4","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-11-21T20:18:36Z","pushed_at":"2016-11-21T20:17:10Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":530816,"stargazers_count":19067,"watchers_count":19067,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3660,"mirror_url":null,"open_issues_count":2885,"forks":3660,"open_issues":2885,"watchers":19067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/37918"},"html":{"href":"https://github.com/rust-lang/rust/pull/37918"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/37918"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/37918/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/37918/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/37918/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/c7d698143c018b2436077fd1a32ce3d8b0a293f7"}}}}
{"actor":{"display_login":"nikomatsakis"}}