{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/85106024","pull_request_review_id":5839961,"id":85106024,"diff_hunk":"@@ -37,6 +41,16 @@\n @Extension\n public class DefaultJnlpSlaveReceiver extends JnlpAgentReceiver {\n \n+    /**\n+     * Disables strict verification of connections. Turn this on if you have plugins that incorrectly extend\n+     * {@link ComputerLauncher} when then should have extended {@link DelegatingComputerLauncher}\n+     *\n+     * @since FIXME\n+     */","path":"core/src/main/java/jenkins/slaves/DefaultJnlpSlaveReceiver.java","position":33,"original_position":33,"commit_id":"0d7570a8a540f0504ce041ae0ce03a127be54459","original_commit_id":"0d7570a8a540f0504ce041ae0ce03a127be54459","user":{"login":"daniel-beck","id":1831569,"avatar_url":"https://avatars.githubusercontent.com/u/1831569?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false},"body":"`@Extension(NoExternalUse.class)`","created_at":"2016-10-26T12:00:37Z","updated_at":"2016-10-26T12:00:37Z","html_url":"https://github.com/jenkinsci/jenkins/pull/2602#discussion_r85106024","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/85106024"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2602#discussion_r85106024"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602","id":90970457,"html_url":"https://github.com/jenkinsci/jenkins/pull/2602","diff_url":"https://github.com/jenkinsci/jenkins/pull/2602.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2602.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2602","number":2602,"state":"open","locked":false,"title":"[JENKINS-39232] Walk the DelegatingComputerLauncher instances when checking if JNLPComputerLauncher","user":{"login":"stephenc","id":209336,"avatar_url":"https://avatars.githubusercontent.com/u/209336?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenc","html_url":"https://github.com/stephenc","followers_url":"https://api.github.com/users/stephenc/followers","following_url":"https://api.github.com/users/stephenc/following{/other_user}","gists_url":"https://api.github.com/users/stephenc/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenc/subscriptions","organizations_url":"https://api.github.com/users/stephenc/orgs","repos_url":"https://api.github.com/users/stephenc/repos","events_url":"https://api.github.com/users/stephenc/events{/privacy}","received_events_url":"https://api.github.com/users/stephenc/received_events","type":"User","site_admin":false},"body":"See [JENKINS-39232](https://issues.jenkins-ci.org/browse/JENKINS-39232)\r\n\r\n@jenkinsci/code-reviewers @reviewbybees\r\n\r\nReplaces #2601 ","created_at":"2016-10-26T09:49:00Z","updated_at":"2016-10-26T12:00:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"511ea5b72b56902b3f7d9d501ab4a5fdac9f4b53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2602/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/0d7570a8a540f0504ce041ae0ce03a127be54459","head":{"label":"stephenc:jenkins-39232","ref":"jenkins-39232","sha":"0d7570a8a540f0504ce041ae0ce03a127be54459","user":{"login":"stephenc","id":209336,"avatar_url":"https://avatars.githubusercontent.com/u/209336?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenc","html_url":"https://github.com/stephenc","followers_url":"https://api.github.com/users/stephenc/followers","following_url":"https://api.github.com/users/stephenc/following{/other_user}","gists_url":"https://api.github.com/users/stephenc/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenc/subscriptions","organizations_url":"https://api.github.com/users/stephenc/orgs","repos_url":"https://api.github.com/users/stephenc/repos","events_url":"https://api.github.com/users/stephenc/events{/privacy}","received_events_url":"https://api.github.com/users/stephenc/received_events","type":"User","site_admin":false},"repo":{"id":1399992,"name":"jenkins","full_name":"stephenc/jenkins","owner":{"login":"stephenc","id":209336,"avatar_url":"https://avatars.githubusercontent.com/u/209336?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenc","html_url":"https://github.com/stephenc","followers_url":"https://api.github.com/users/stephenc/followers","following_url":"https://api.github.com/users/stephenc/following{/other_user}","gists_url":"https://api.github.com/users/stephenc/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenc/subscriptions","organizations_url":"https://api.github.com/users/stephenc/orgs","repos_url":"https://api.github.com/users/stephenc/repos","events_url":"https://api.github.com/users/stephenc/events{/privacy}","received_events_url":"https://api.github.com/users/stephenc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephenc/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/stephenc/jenkins","forks_url":"https://api.github.com/repos/stephenc/jenkins/forks","keys_url":"https://api.github.com/repos/stephenc/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenc/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenc/jenkins/teams","hooks_url":"https://api.github.com/repos/stephenc/jenkins/hooks","issue_events_url":"https://api.github.com/repos/stephenc/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/stephenc/jenkins/events","assignees_url":"https://api.github.com/repos/stephenc/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/stephenc/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/stephenc/jenkins/tags","blobs_url":"https://api.github.com/repos/stephenc/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenc/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenc/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenc/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenc/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenc/jenkins/languages","stargazers_url":"https://api.github.com/repos/stephenc/jenkins/stargazers","contributors_url":"https://api.github.com/repos/stephenc/jenkins/contributors","subscribers_url":"https://api.github.com/repos/stephenc/jenkins/subscribers","subscription_url":"https://api.github.com/repos/stephenc/jenkins/subscription","commits_url":"https://api.github.com/repos/stephenc/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenc/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenc/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenc/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenc/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/stephenc/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenc/jenkins/merges","archive_url":"https://api.github.com/repos/stephenc/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenc/jenkins/downloads","issues_url":"https://api.github.com/repos/stephenc/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/stephenc/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenc/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenc/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenc/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/stephenc/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/stephenc/jenkins/deployments","created_at":"2011-02-22T23:22:48Z","updated_at":"2015-04-27T13:30:13Z","pushed_at":"2016-10-26T11:56:45Z","git_url":"git://github.com/stephenc/jenkins.git","ssh_url":"git@github.com:stephenc/jenkins.git","clone_url":"https://github.com/stephenc/jenkins.git","svn_url":"https://github.com/stephenc/jenkins","homepage":"http://jenkins-ci.org/","size":92601,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"8242e0eb1625454ae5539c444c8d8ecf99a70b62","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-10-26T10:18:17Z","pushed_at":"2016-10-26T11:56:50Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"https://jenkins.io/","size":141668,"stargazers_count":6881,"watchers_count":6881,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2902,"mirror_url":null,"open_issues_count":113,"forks":2902,"open_issues":113,"watchers":6881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2602"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2602"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2602/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2602/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/0d7570a8a540f0504ce041ae0ce03a127be54459"}}}}
{"actor":{"display_login":"daniel-beck"}}