{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/92521521","pull_request_review_id":13038569,"id":92521521,"diff_hunk":"@@ -89,16 +89,6 @@ public static void CtorArrayNullArray()\n         }\n \n         [Fact]\n-        public static void CtorArrayWrongArrayType()","path":"src/System.Memory/tests/ReadOnlySpan/CtorArray.cs","position":4,"original_position":4,"commit_id":"82d61e9aa2a063b66fb2085c78b8c90eec9cdcfc","original_commit_id":"82d61e9aa2a063b66fb2085c78b8c90eec9cdcfc","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"It would be better to keep this test, but make it test the right condition - that it is possible to create the Span from variant arrays.","created_at":"2016-12-15T00:27:49Z","updated_at":"2016-12-15T00:27:49Z","html_url":"https://github.com/dotnet/corefx/pull/14262#discussion_r92521521","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/14262","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/92521521"},"html":{"href":"https://github.com/dotnet/corefx/pull/14262#discussion_r92521521"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14262"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/14262","id":96845846,"html_url":"https://github.com/dotnet/corefx/pull/14262","diff_url":"https://github.com/dotnet/corefx/pull/14262.diff","patch_url":"https://github.com/dotnet/corefx/pull/14262.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/14262","number":14262,"state":"closed","locked":false,"title":"nuget package to work with fast and slow span","user":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars.githubusercontent.com/u/6527137?v=3","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"body":"Changing system.memory builds and pkgproj so that .netcoreapp gets fast\r\nspan from coreclr while net45 gets slow span from corefx\r\n\r\nNote: There are some discrepancies between the ref assembly for Span and the two implementations which will be resolved in future PRs. For now, the workaround is the ApiCompatBaseline so that the API verification passes. The missing implementations in Fast Span will throw runtime error if called.","created_at":"2016-12-07T02:10:22Z","updated_at":"2016-12-15T00:27:49Z","closed_at":"2016-12-15T00:27:46Z","merged_at":"2016-12-15T00:27:46Z","merge_commit_sha":"29160c35139f6e6f452864cf20c71b269e3bfed5","assignee":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars.githubusercontent.com/u/6527137?v=3","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"assignees":[{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars.githubusercontent.com/u/6527137?v=3","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestone/4","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"2.0.0","description":".NET Core 2.0 Placeholder (next major release)\r\nhttps://github.com/dotnet/core/blob/master/roadmap.md\r\n\r\nNote: Previously known as 1.2.","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":325,"closed_issues":3320,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2016-12-15T00:27:46Z","due_on":"2017-04-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/14262/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/14262/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/14262/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/82d61e9aa2a063b66fb2085c78b8c90eec9cdcfc","head":{"label":"ahsonkhan:sysmemory_nuget_package","ref":"sysmemory_nuget_package","sha":"82d61e9aa2a063b66fb2085c78b8c90eec9cdcfc","user":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars.githubusercontent.com/u/6527137?v=3","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"repo":{"id":75784851,"name":"corefx","full_name":"ahsonkhan/corefx","owner":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars.githubusercontent.com/u/6527137?v=3","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahsonkhan/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ahsonkhan/corefx","forks_url":"https://api.github.com/repos/ahsonkhan/corefx/forks","keys_url":"https://api.github.com/repos/ahsonkhan/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahsonkhan/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahsonkhan/corefx/teams","hooks_url":"https://api.github.com/repos/ahsonkhan/corefx/hooks","issue_events_url":"https://api.github.com/repos/ahsonkhan/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ahsonkhan/corefx/events","assignees_url":"https://api.github.com/repos/ahsonkhan/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ahsonkhan/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ahsonkhan/corefx/tags","blobs_url":"https://api.github.com/repos/ahsonkhan/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahsonkhan/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahsonkhan/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahsonkhan/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahsonkhan/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ahsonkhan/corefx/languages","stargazers_url":"https://api.github.com/repos/ahsonkhan/corefx/stargazers","contributors_url":"https://api.github.com/repos/ahsonkhan/corefx/contributors","subscribers_url":"https://api.github.com/repos/ahsonkhan/corefx/subscribers","subscription_url":"https://api.github.com/repos/ahsonkhan/corefx/subscription","commits_url":"https://api.github.com/repos/ahsonkhan/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahsonkhan/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahsonkhan/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahsonkhan/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahsonkhan/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ahsonkhan/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahsonkhan/corefx/merges","archive_url":"https://api.github.com/repos/ahsonkhan/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahsonkhan/corefx/downloads","issues_url":"https://api.github.com/repos/ahsonkhan/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ahsonkhan/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ahsonkhan/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ahsonkhan/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahsonkhan/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ahsonkhan/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ahsonkhan/corefx/deployments","created_at":"2016-12-07T00:49:36Z","updated_at":"2016-12-07T00:50:05Z","pushed_at":"2016-12-14T23:12:45Z","git_url":"git://github.com/ahsonkhan/corefx.git","ssh_url":"git@github.com:ahsonkhan/corefx.git","clone_url":"https://github.com/ahsonkhan/corefx.git","svn_url":"https://github.com/ahsonkhan/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":125058,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"dc9e81c740b7dde554faf3ba1b595b32dc18400f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-12-14T23:16:17Z","pushed_at":"2016-12-15T00:27:46Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":125406,"stargazers_count":10942,"watchers_count":10942,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2807,"mirror_url":null,"open_issues_count":1297,"forks":2807,"open_issues":1297,"watchers":10942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14262"},"html":{"href":"https://github.com/dotnet/corefx/pull/14262"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14262"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14262/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14262/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14262/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/82d61e9aa2a063b66fb2085c78b8c90eec9cdcfc"}}}}
{"actor":{"display_login":"jkotas"}}