{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/69628423","id":69628423,"diff_hunk":"@@ -64,7 +64,8 @@ def log_multivariate_normal_density(X, means, covars, covariance_type='diag'):\n     return log_multivariate_normal_density_dict[covariance_type](\n         X, means, covars)\n \n-\n+@deprecated(\"The class function sample_gaussian is deprecated and \"\n+            \"will be removed in 0.20. Use numpy.multivariate_normal instead.\")","path":"sklearn/mixture/gmm.py","position":6,"original_position":6,"commit_id":"42691a70d875064c8c66460b13890d20bb0ec0fa","original_commit_id":"42691a70d875064c8c66460b13890d20bb0ec0fa","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"if you deprecate a function you need to remove it from everywhere. is this used somewhere? otherwsie the test suite will throw a lot of deprecation warnings","created_at":"2016-07-05T20:07:05Z","updated_at":"2016-07-05T20:07:05Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6957#discussion_r69628423","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/69628423"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6957#discussion_r69628423"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957","id":76175315,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/6957","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6957.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6957.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6957","number":6957,"state":"open","locked":false,"title":"[MRG+1] DOC correct docstring for sample_gaussian","user":{"login":"kwohlfahrt","id":2422454,"avatar_url":"https://avatars.githubusercontent.com/u/2422454?v=3","gravatar_id":"","url":"https://api.github.com/users/kwohlfahrt","html_url":"https://github.com/kwohlfahrt","followers_url":"https://api.github.com/users/kwohlfahrt/followers","following_url":"https://api.github.com/users/kwohlfahrt/following{/other_user}","gists_url":"https://api.github.com/users/kwohlfahrt/gists{/gist_id}","starred_url":"https://api.github.com/users/kwohlfahrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwohlfahrt/subscriptions","organizations_url":"https://api.github.com/users/kwohlfahrt/orgs","repos_url":"https://api.github.com/users/kwohlfahrt/repos","events_url":"https://api.github.com/users/kwohlfahrt/events{/privacy}","received_events_url":"https://api.github.com/users/kwohlfahrt/received_events","type":"User","site_admin":false},"body":"#### Reference Issue\r\n\r\nNone.\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nDocstring for `sklearn.mixture.sample_gaussian` did not match function behaviour. Caused some trouble trying to implement a compatible version for a different distribution. Corrects this for future reference.","created_at":"2016-07-04T14:57:43Z","updated_at":"2016-07-05T20:07:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cd7fbc064778714b5871e93dbdf07cf1f5941a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6957/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/42691a70d875064c8c66460b13890d20bb0ec0fa","head":{"label":"kwohlfahrt:master","ref":"master","sha":"42691a70d875064c8c66460b13890d20bb0ec0fa","user":{"login":"kwohlfahrt","id":2422454,"avatar_url":"https://avatars.githubusercontent.com/u/2422454?v=3","gravatar_id":"","url":"https://api.github.com/users/kwohlfahrt","html_url":"https://github.com/kwohlfahrt","followers_url":"https://api.github.com/users/kwohlfahrt/followers","following_url":"https://api.github.com/users/kwohlfahrt/following{/other_user}","gists_url":"https://api.github.com/users/kwohlfahrt/gists{/gist_id}","starred_url":"https://api.github.com/users/kwohlfahrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwohlfahrt/subscriptions","organizations_url":"https://api.github.com/users/kwohlfahrt/orgs","repos_url":"https://api.github.com/users/kwohlfahrt/repos","events_url":"https://api.github.com/users/kwohlfahrt/events{/privacy}","received_events_url":"https://api.github.com/users/kwohlfahrt/received_events","type":"User","site_admin":false},"repo":{"id":62569458,"name":"scikit-learn","full_name":"kwohlfahrt/scikit-learn","owner":{"login":"kwohlfahrt","id":2422454,"avatar_url":"https://avatars.githubusercontent.com/u/2422454?v=3","gravatar_id":"","url":"https://api.github.com/users/kwohlfahrt","html_url":"https://github.com/kwohlfahrt","followers_url":"https://api.github.com/users/kwohlfahrt/followers","following_url":"https://api.github.com/users/kwohlfahrt/following{/other_user}","gists_url":"https://api.github.com/users/kwohlfahrt/gists{/gist_id}","starred_url":"https://api.github.com/users/kwohlfahrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwohlfahrt/subscriptions","organizations_url":"https://api.github.com/users/kwohlfahrt/orgs","repos_url":"https://api.github.com/users/kwohlfahrt/repos","events_url":"https://api.github.com/users/kwohlfahrt/events{/privacy}","received_events_url":"https://api.github.com/users/kwohlfahrt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwohlfahrt/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/kwohlfahrt/scikit-learn","forks_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/forks","keys_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/teams","hooks_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/events","assignees_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/tags","blobs_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/subscription","commits_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/merges","archive_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/downloads","issues_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/kwohlfahrt/scikit-learn/deployments","created_at":"2016-07-04T14:48:11Z","updated_at":"2016-07-04T14:48:19Z","pushed_at":"2016-07-05T13:46:34Z","git_url":"git://github.com/kwohlfahrt/scikit-learn.git","ssh_url":"git@github.com:kwohlfahrt/scikit-learn.git","clone_url":"https://github.com/kwohlfahrt/scikit-learn.git","svn_url":"https://github.com/kwohlfahrt/scikit-learn","homepage":"http://scikit-learn.org","size":77172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"4d33cd62e4c3be012e083811cf8dc9a06dc7080b","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-07-05T20:02:12Z","pushed_at":"2016-07-05T18:58:59Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":124530,"stargazers_count":12210,"watchers_count":12210,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7062,"mirror_url":null,"open_issues_count":1208,"forks":7062,"open_issues":1208,"watchers":12210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6957"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6957"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6957/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6957/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/42691a70d875064c8c66460b13890d20bb0ec0fa"}}}}
{"actor":{"display_login":"agramfort"}}