{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11480","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11480/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11480/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11480/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11480","id":178830960,"number":11480,"title":"Skip callbacks in Api::BaseController inherited from ApplicationController","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/api","name":"api","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"assignees":[{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-09-23T09:40:39Z","updated_at":"2016-10-03T19:47:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11480","html_url":"https://github.com/ManageIQ/manageiq/pull/11480","diff_url":"https://github.com/ManageIQ/manageiq/pull/11480.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11480.patch"},"body":"* `reset_toolbar` sets the `@toolbars` variable back to `{}`, but it is\r\n  never used in the API code\r\n* `set_session_tenant` sets a value in the session which is never used\r\n  in the API code. Besides, `current_user` will be `nil`\r\n* `set_user_time_zone` sets a value in the session and `Time.zone` to\r\n  the user timezone, but since `current_user` is `nil` it will just set\r\n  it to the server timezone.\r\n* ~~`set_gettext_locale` I believe is not needed, since we don't support\r\n  `Accept-Language` in the JSON API~~\r\n* `allow_websocket` - websockets are not utilized in JSON API calls\r\n\r\n@abellotti @Fryguy I may be making some assumptions here, so please keep me honest.\r\n\r\nThis change comes from https://github.com/ManageIQ/manageiq/pull/11085 where I originally wanted to remove `ApplicationController` from the `Api::BaseController` inheritance tree. Since I removed that from that PR as it was too big a change, I'm laying out the first steps here in this separate PR\r\n\r\n@miq-bot add-label api, technical debt\r\n@miq-bot assign @abellotti "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/251206750","html_url":"https://github.com/ManageIQ/manageiq/pull/11480#issuecomment-251206750","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11480","id":251206750,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T19:47:43Z","updated_at":"2016-10-03T19:47:43Z","body":"<rubocop />Checked commit https://github.com/imtayadeway/manageiq/commit/4e0da8205fdfb10bd499bdbc11171c3f58b876f1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n1 file checked, 0 offenses detected\nEverything looks good. :star:\n"}}
{"actor":{"display_login":"miq-bot"}}