{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/562","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/562/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/562/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/562/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/562","id":191198857,"number":562,"title":"[WIP] migrate for dotnet preview2 to preview3","user":{"login":"ctaggart","id":80104,"avatar_url":"https://avatars.githubusercontent.com/u/80104?v=3","gravatar_id":"","url":"https://api.github.com/users/ctaggart","html_url":"https://github.com/ctaggart","followers_url":"https://api.github.com/users/ctaggart/followers","following_url":"https://api.github.com/users/ctaggart/following{/other_user}","gists_url":"https://api.github.com/users/ctaggart/gists{/gist_id}","starred_url":"https://api.github.com/users/ctaggart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctaggart/subscriptions","organizations_url":"https://api.github.com/users/ctaggart/orgs","repos_url":"https://api.github.com/users/ctaggart/repos","events_url":"https://api.github.com/users/ctaggart/events{/privacy}","received_events_url":"https://api.github.com/users/ctaggart/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-23T06:45:11Z","updated_at":"2016-11-26T19:48:13Z","closed_at":"2016-11-26T19:48:13Z","pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/562","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/562","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/562.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/562.patch"},"body":"This is work-in-progress. Following up with #561, I thought I'd see what it takes to migrate from dotnet  preview2 to preview3. The `dotnet migrate` tool gets you most of the way there. I then added `<RuntimeIdentifier>win7-x86</RuntimeIdentifier>` to the exe projects and replaced `xproj` with `csproj` in the `sln` file.\r\n\r\nhttps://docs.microsoft.com/en-us/dotnet/articles/core/preview3/tools/dotnet-migrate\r\n```\r\ndotnet migrate .\\google-cloud-dotnet\\apis\\global.json --skip-backup\r\ndotnet migrate .\\google-cloud-dotnet\\tools\\global.json --skip-backup\r\n```\r\n\r\nLet me know if this could be used or if I should abandon a pull request like this."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/comments/263082084","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/562#issuecomment-263082084","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/562","id":263082084,"user":{"login":"ctaggart","id":80104,"avatar_url":"https://avatars.githubusercontent.com/u/80104?v=3","gravatar_id":"","url":"https://api.github.com/users/ctaggart","html_url":"https://github.com/ctaggart","followers_url":"https://api.github.com/users/ctaggart/followers","following_url":"https://api.github.com/users/ctaggart/following{/other_user}","gists_url":"https://api.github.com/users/ctaggart/gists{/gist_id}","starred_url":"https://api.github.com/users/ctaggart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctaggart/subscriptions","organizations_url":"https://api.github.com/users/ctaggart/orgs","repos_url":"https://api.github.com/users/ctaggart/repos","events_url":"https://api.github.com/users/ctaggart/events{/privacy}","received_events_url":"https://api.github.com/users/ctaggart/received_events","type":"User","site_admin":false},"created_at":"2016-11-26T19:48:13Z","updated_at":"2016-11-26T19:48:13Z","body":"The 2016-11-16 [Announcing .NET Core Tools MSBuild “alpha”](https://blogs.msdn.microsoft.com/dotnet/2016/11/16/announcing-net-core-tools-msbuild-alpha/) is accurately labeled \"alpha\". I spent several hour yesterday and today trying to migrate everything there. It is not trivial.\r\n\r\nAfter I got past the duplicate xproj files #581, this appeared to get me started:\r\n\r\n```\r\ngit clean -xfd\r\nbash -c \"find . -type f -name 'global.json' -print0 | xargs -0 sed -i 's/1.0.0-preview2-003131/1.0.0-preview3-004056/g'\"\r\ndotnet migrate . --skip-backup\r\ngit rm **/*.xproj **/project.json\r\nbash -c \"find . -type f -name '*.sln' -print0 | xargs -0 sed -i 's/.xproj/.csproj/g'\"\r\n```\r\n\r\nBut then I figured out that I need to\r\n * [update testhost to latest for net45 support](https://github.com/ctaggart/google-cloud-dotnet/commit/3db82b8cf4db048e5690be50f4072abc06e4b4ea) to avoid [errors](https://github.com/ctaggart/google-cloud-dotnet/issues/2)\r\n * [updated xunit libraries](https://github.com/ctaggart/google-cloud-dotnet/commit/0d4abe189b013f2538e5959d571a7fecd6f9cf54) to avoid [errors](https://github.com/ctaggart/google-cloud-dotnet/issues/3)\r\n\r\nBut I wasn't able to solve\r\n* [TargetFrameworkAttribute causing 'System' could not be found in the global namespace](https://github.com/dotnet/sdk/issues/431)\r\n* [Unable to load projects after dotnet migrate](https://github.com/dotnet/sdk/issues/431)\r\n\r\nAccording to the comments MSBuild \"alpha\" announcement, .NET Core tooling support will be in Visual Studio 2017, not 2015. That makes sense to me, based on the scope of change. It looks like really great direction, but things are indeed pretty unstable right now."}}
{"actor":{"display_login":"ctaggart"}}