{"action":"created","issue":{"url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/124","repository_url":"https://api.github.com/repos/PrivateBin/PrivateBin","labels_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/124/comments","events_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/124/events","html_url":"https://github.com/PrivateBin/PrivateBin/pull/124","id":185215472,"number":124,"title":"[WIP] Add \"JS not working\" error message","user":{"login":"rugk","id":11966684,"avatar_url":"https://avatars.githubusercontent.com/u/11966684?v=3","gravatar_id":"","url":"https://api.github.com/users/rugk","html_url":"https://github.com/rugk","followers_url":"https://api.github.com/users/rugk/followers","following_url":"https://api.github.com/users/rugk/following{/other_user}","gists_url":"https://api.github.com/users/rugk/gists{/gist_id}","starred_url":"https://api.github.com/users/rugk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rugk/subscriptions","organizations_url":"https://api.github.com/users/rugk/orgs","repos_url":"https://api.github.com/users/rugk/repos","events_url":"https://api.github.com/users/rugk/events{/privacy}","received_events_url":"https://api.github.com/users/rugk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"elrido","id":1017622,"avatar_url":"https://avatars.githubusercontent.com/u/1017622?v=3","gravatar_id":"","url":"https://api.github.com/users/elrido","html_url":"https://github.com/elrido","followers_url":"https://api.github.com/users/elrido/followers","following_url":"https://api.github.com/users/elrido/following{/other_user}","gists_url":"https://api.github.com/users/elrido/gists{/gist_id}","starred_url":"https://api.github.com/users/elrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elrido/subscriptions","organizations_url":"https://api.github.com/users/elrido/orgs","repos_url":"https://api.github.com/users/elrido/repos","events_url":"https://api.github.com/users/elrido/events{/privacy}","received_events_url":"https://api.github.com/users/elrido/received_events","type":"User","site_admin":false},"assignees":[{"login":"elrido","id":1017622,"avatar_url":"https://avatars.githubusercontent.com/u/1017622?v=3","gravatar_id":"","url":"https://api.github.com/users/elrido","html_url":"https://github.com/elrido","followers_url":"https://api.github.com/users/elrido/followers","following_url":"https://api.github.com/users/elrido/following{/other_user}","gists_url":"https://api.github.com/users/elrido/gists{/gist_id}","starred_url":"https://api.github.com/users/elrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elrido/subscriptions","organizations_url":"https://api.github.com/users/elrido/orgs","repos_url":"https://api.github.com/users/elrido/repos","events_url":"https://api.github.com/users/elrido/events{/privacy}","received_events_url":"https://api.github.com/users/elrido/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-25T19:47:02Z","updated_at":"2016-11-13T11:50:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/124","html_url":"https://github.com/PrivateBin/PrivateBin/pull/124","diff_url":"https://github.com/PrivateBin/PrivateBin/pull/124.diff","patch_url":"https://github.com/PrivateBin/PrivateBin/pull/124.patch"},"body":"<!-- This is a template for your Pull Request. This are just some suggestions for you. You do not have to use all of them. -->\n\n<!-- **Attention:** Please tick this box to agree to release your code under the projects license. Otherwise your PR cannot be accepted. -->\n- [x] I agree to release the changes in this PR under the Zlib/libpng license as shown in the  [LICENSE file](https://github.com/PrivateBin/PrivateBin/blob/master/LICENSE.md#zliblibpng-license-for-privatebin).\n\n<!-- Alternatively uncomment and tick this box to release your code under public domain:\n* [ ] To the extent possible under law, I have waived all copyright and related or neighboring rights to this PR and publish it as public domain.\n-->\n\n<!-- If your PR fixes an issue, mention it here. You can also just copy the URL - GitHub will convert it for you.\nIf this PR fixes several issues, please prepend each issue url/number with the word \"fix\"/\"fixes\" or \"close\"/\"closes\" as this automatically closes the issues you mentioned when the PR is merged.\n-->\n\nThis PR fixes #103\n## Changes\n\n<!-- List all the changes you have done -->\n- added a JS error message, which only is shown when JavaScript is just no loaded, but supported/activated by/in the browser \n\nIt is:\n- hidden by JS code executed as early as possible\n- not hidden by noscript tags, so that it is _not_ shown when JS is just disabled\n\nI tested it with Chromium's throttling and I did not see the error message as a false-positive:\n![thottelingprove](https://cloud.githubusercontent.com/assets/11966684/19701582/497c95b6-9afc-11e6-95da-cefa882568a8.gif)\n## ToDo\n\n<!-- Add things, you still want to do. It is recommend to put \"[DNM]\", \"[DONOTMERGE]\", \"[WIP]\" or \"[WORKINPROGRESS]\" **into the title** of your PR if you still want to work on this PR, but just do not want to have it merged yet. -->\n- [ ] Add code to all templates\n- [ ] Create & link FAQ\n\n@elrido Please test it and look over it. If everything is all right, I'll finish the TODOs.\n"},"comment":{"url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/comments/260181408","html_url":"https://github.com/PrivateBin/PrivateBin/pull/124#issuecomment-260181408","issue_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/124","id":260181408,"user":{"login":"elrido","id":1017622,"avatar_url":"https://avatars.githubusercontent.com/u/1017622?v=3","gravatar_id":"","url":"https://api.github.com/users/elrido","html_url":"https://github.com/elrido","followers_url":"https://api.github.com/users/elrido/followers","following_url":"https://api.github.com/users/elrido/following{/other_user}","gists_url":"https://api.github.com/users/elrido/gists{/gist_id}","starred_url":"https://api.github.com/users/elrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elrido/subscriptions","organizations_url":"https://api.github.com/users/elrido/orgs","repos_url":"https://api.github.com/users/elrido/repos","events_url":"https://api.github.com/users/elrido/events{/privacy}","received_events_url":"https://api.github.com/users/elrido/received_events","type":"User","site_admin":false},"created_at":"2016-11-13T11:50:38Z","updated_at":"2016-11-13T11:50:38Z","body":"I reviewed it and it looks good.\r\n\r\nHave added the missing/updated message IDs to the translation files, did some tweaking of the CSS and also merged it with the master to get rid of the styleCI warnings and simplify the merge back.\r\n\r\nWhen all templates are updated and we have a link for the FAQs (which also needs to be added to all translation files, so translators know it needs translation) we can merge it."}}
{"actor":{"display_login":"elrido"}}