{"action":"created","comment":{"url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/comments/85160556","pull_request_review_id":5890964,"id":85160556,"diff_hunk":"@@ -147,7 +144,8 @@ def provision(request):\n                     .format(mediasite_root_folder, term, course.course_code, course.sis_course_id)\n                 # this is needed because a bug in Mediasite allows for the creation of a URL with potentially\n                 # dangerous strings in it. we strip out the characters that we know might create that type of URL\n-                catalog_display_name = catalog_display_name.translate(None, '<>*%:&\\\\ ')\n+                catalog_display_name = catalog_display_name.translate(\n+                    {ord(c): None for c in '<>*%:&\\\\ '})","path":"web/views.py","position":39,"original_position":39,"commit_id":"ed778912ec53245d59abd2df43307428965037a7","original_commit_id":"ed778912ec53245d59abd2df43307428965037a7","user":{"login":"elliottyates","id":8975317,"avatar_url":"https://avatars.githubusercontent.com/u/8975317?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottyates","html_url":"https://github.com/elliottyates","followers_url":"https://api.github.com/users/elliottyates/followers","following_url":"https://api.github.com/users/elliottyates/following{/other_user}","gists_url":"https://api.github.com/users/elliottyates/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottyates/subscriptions","organizations_url":"https://api.github.com/users/elliottyates/orgs","repos_url":"https://api.github.com/users/elliottyates/repos","events_url":"https://api.github.com/users/elliottyates/events{/privacy}","received_events_url":"https://api.github.com/users/elliottyates/received_events","type":"User","site_admin":false},"body":"Yes I'm happy to do so -- basically, the `translate` function [works differently on unicode strings](https://docs.python.org/2/library/stdtypes.html#str.translate), and this kind of dict comprehension is a common practice. You have to provide a mapping now from code point to translated/swapped character.","created_at":"2016-10-26T16:10:42Z","updated_at":"2016-10-26T16:10:54Z","html_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning/pull/11#discussion_r85160556","pull_request_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/comments/85160556"},"html":{"href":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning/pull/11#discussion_r85160556"},"pull_request":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11","id":90823420,"html_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning/pull/11","diff_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning/pull/11.diff","patch_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning/pull/11.patch","issue_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/11","number":11,"state":"open","locked":false,"title":"TLT-2873: Unicode course title support","user":{"login":"elliottyates","id":8975317,"avatar_url":"https://avatars.githubusercontent.com/u/8975317?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottyates","html_url":"https://github.com/elliottyates","followers_url":"https://api.github.com/users/elliottyates/followers","following_url":"https://api.github.com/users/elliottyates/following{/other_user}","gists_url":"https://api.github.com/users/elliottyates/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottyates/subscriptions","organizations_url":"https://api.github.com/users/elliottyates/orgs","repos_url":"https://api.github.com/users/elliottyates/repos","events_url":"https://api.github.com/users/elliottyates/events{/privacy}","received_events_url":"https://api.github.com/users/elliottyates/received_events","type":"User","site_admin":false},"body":"Courses with Unicode characters in their titles are now provisionable; folder and catalog in Mediasite will correctly display these characters. https://jira.huit.harvard.edu/browse/TLT-2873.\r\n\r\nThis supersedes #7.\r\nTest site: GSE - CIID 377696.\r\n\r\nThis has been tested\r\n(1) from scratch; and,\r\n(2) in the case where the folders, catalog, modules, and roles exist already.\r\n\r\nIf any of the intermediate resources doesn't exist, it should still work, but I have had problems testing these scenarios because it appears there is some cached information I can't control or view on dvsdev if you delete, for instance, a catalog, then try to re-provision with identical information shortly thereafter. There's a support ticket open with Sonic Foundry to track this issue: https://support.sonicfoundry.com/Account/Case/00066385.","created_at":"2016-10-25T14:48:37Z","updated_at":"2016-10-26T16:10:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea60d3fdc34d594a713f713d50e3e93c49673821","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/11/comments","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/statuses/ed778912ec53245d59abd2df43307428965037a7","head":{"label":"Harvard-University-iCommons:task/elliottyates/tlt-2873/unicode_support_in_course_titles","ref":"task/elliottyates/tlt-2873/unicode_support_in_course_titles","sha":"ed778912ec53245d59abd2df43307428965037a7","user":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":61666699,"name":"MediasiteProvisioning","full_name":"Harvard-University-iCommons/MediasiteProvisioning","owner":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning","description":null,"fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/deployments","created_at":"2016-06-21T20:58:14Z","updated_at":"2016-06-23T14:12:06Z","pushed_at":"2016-10-25T14:49:15Z","git_url":"git://github.com/Harvard-University-iCommons/MediasiteProvisioning.git","ssh_url":"git@github.com:Harvard-University-iCommons/MediasiteProvisioning.git","clone_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning.git","svn_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning","homepage":null,"size":169,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Harvard-University-iCommons:develop","ref":"develop","sha":"6319b8f71c6d0c11bf917b077ae5124ecf110a8b","user":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":61666699,"name":"MediasiteProvisioning","full_name":"Harvard-University-iCommons/MediasiteProvisioning","owner":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning","description":null,"fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/deployments","created_at":"2016-06-21T20:58:14Z","updated_at":"2016-06-23T14:12:06Z","pushed_at":"2016-10-25T14:49:15Z","git_url":"git://github.com/Harvard-University-iCommons/MediasiteProvisioning.git","ssh_url":"git@github.com:Harvard-University-iCommons/MediasiteProvisioning.git","clone_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning.git","svn_url":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning","homepage":null,"size":169,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11"},"html":{"href":"https://github.com/Harvard-University-iCommons/MediasiteProvisioning/pull/11"},"issue":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/11"},"comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Harvard-University-iCommons/MediasiteProvisioning/statuses/ed778912ec53245d59abd2df43307428965037a7"}}}}
{"actor":{"display_login":"elliottyates"}}