{"action":"opened","number":137,"pull_request":{"url":"https://api.github.com/repos/graalvm/truffle/pulls/137","id":63266452,"html_url":"https://github.com/graalvm/truffle/pull/137","diff_url":"https://github.com/graalvm/truffle/pull/137.diff","patch_url":"https://github.com/graalvm/truffle/pull/137.patch","issue_url":"https://api.github.com/repos/graalvm/truffle/issues/137","number":137,"state":"open","locked":false,"title":"Rename SuspendedEvent.kill() to prepareKill() and do kill lazily.","user":{"login":"entlicher","id":5479271,"avatar_url":"https://avatars.githubusercontent.com/u/5479271?v=3","gravatar_id":"","url":"https://api.github.com/users/entlicher","html_url":"https://github.com/entlicher","followers_url":"https://api.github.com/users/entlicher/followers","following_url":"https://api.github.com/users/entlicher/following{/other_user}","gists_url":"https://api.github.com/users/entlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/entlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entlicher/subscriptions","organizations_url":"https://api.github.com/users/entlicher/orgs","repos_url":"https://api.github.com/users/entlicher/repos","events_url":"https://api.github.com/users/entlicher/events{/privacy}","received_events_url":"https://api.github.com/users/entlicher/received_events","type":"User","site_admin":false},"body":"`SuspendedEvent.kill()` directly throw the `KillException`, which has unpleasant consequences:\r\n\r\n- Any code that follows `SuspendedEvent.kill()` call will not be processed, which may not be expected.\r\n- We can not prevent users from accidentally calling `SuspendedEvent.kill()` in a possible asynchronous code handling the events. In this case it unexpectedly blows up.\r\n\r\nTo achieve the same effect, which was intended by the original code, but to be more polite to the caller of this method, I suggest to have just a `kill` marker on the `SuspendedEvent` and throw the `KillException` in the infrastructure. As the method is not killing right away now, I'm changing the name from `kill()` to `prepareKill()`, which corresponds with other `prepare*()` methods.","created_at":"2016-03-17T18:01:19Z","updated_at":"2016-03-17T18:01:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/graalvm/truffle/pulls/137/commits","review_comments_url":"https://api.github.com/repos/graalvm/truffle/pulls/137/comments","review_comment_url":"https://api.github.com/repos/graalvm/truffle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graalvm/truffle/issues/137/comments","statuses_url":"https://api.github.com/repos/graalvm/truffle/statuses/85ae38115f109221edc8d23c1504cedc646736bd","head":{"label":"entlicher:PrepareKill","ref":"PrepareKill","sha":"85ae38115f109221edc8d23c1504cedc646736bd","user":{"login":"entlicher","id":5479271,"avatar_url":"https://avatars.githubusercontent.com/u/5479271?v=3","gravatar_id":"","url":"https://api.github.com/users/entlicher","html_url":"https://github.com/entlicher","followers_url":"https://api.github.com/users/entlicher/followers","following_url":"https://api.github.com/users/entlicher/following{/other_user}","gists_url":"https://api.github.com/users/entlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/entlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entlicher/subscriptions","organizations_url":"https://api.github.com/users/entlicher/orgs","repos_url":"https://api.github.com/users/entlicher/repos","events_url":"https://api.github.com/users/entlicher/events{/privacy}","received_events_url":"https://api.github.com/users/entlicher/received_events","type":"User","site_admin":false},"repo":{"id":53626278,"name":"truffle","full_name":"entlicher/truffle","owner":{"login":"entlicher","id":5479271,"avatar_url":"https://avatars.githubusercontent.com/u/5479271?v=3","gravatar_id":"","url":"https://api.github.com/users/entlicher","html_url":"https://github.com/entlicher","followers_url":"https://api.github.com/users/entlicher/followers","following_url":"https://api.github.com/users/entlicher/following{/other_user}","gists_url":"https://api.github.com/users/entlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/entlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entlicher/subscriptions","organizations_url":"https://api.github.com/users/entlicher/orgs","repos_url":"https://api.github.com/users/entlicher/repos","events_url":"https://api.github.com/users/entlicher/events{/privacy}","received_events_url":"https://api.github.com/users/entlicher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/entlicher/truffle","description":"The Truffle Language Implementation Framework","fork":true,"url":"https://api.github.com/repos/entlicher/truffle","forks_url":"https://api.github.com/repos/entlicher/truffle/forks","keys_url":"https://api.github.com/repos/entlicher/truffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/entlicher/truffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/entlicher/truffle/teams","hooks_url":"https://api.github.com/repos/entlicher/truffle/hooks","issue_events_url":"https://api.github.com/repos/entlicher/truffle/issues/events{/number}","events_url":"https://api.github.com/repos/entlicher/truffle/events","assignees_url":"https://api.github.com/repos/entlicher/truffle/assignees{/user}","branches_url":"https://api.github.com/repos/entlicher/truffle/branches{/branch}","tags_url":"https://api.github.com/repos/entlicher/truffle/tags","blobs_url":"https://api.github.com/repos/entlicher/truffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/entlicher/truffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/entlicher/truffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/entlicher/truffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/entlicher/truffle/statuses/{sha}","languages_url":"https://api.github.com/repos/entlicher/truffle/languages","stargazers_url":"https://api.github.com/repos/entlicher/truffle/stargazers","contributors_url":"https://api.github.com/repos/entlicher/truffle/contributors","subscribers_url":"https://api.github.com/repos/entlicher/truffle/subscribers","subscription_url":"https://api.github.com/repos/entlicher/truffle/subscription","commits_url":"https://api.github.com/repos/entlicher/truffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/entlicher/truffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/entlicher/truffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/entlicher/truffle/issues/comments{/number}","contents_url":"https://api.github.com/repos/entlicher/truffle/contents/{+path}","compare_url":"https://api.github.com/repos/entlicher/truffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/entlicher/truffle/merges","archive_url":"https://api.github.com/repos/entlicher/truffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/entlicher/truffle/downloads","issues_url":"https://api.github.com/repos/entlicher/truffle/issues{/number}","pulls_url":"https://api.github.com/repos/entlicher/truffle/pulls{/number}","milestones_url":"https://api.github.com/repos/entlicher/truffle/milestones{/number}","notifications_url":"https://api.github.com/repos/entlicher/truffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/entlicher/truffle/labels{/name}","releases_url":"https://api.github.com/repos/entlicher/truffle/releases{/id}","deployments_url":"https://api.github.com/repos/entlicher/truffle/deployments","created_at":"2016-03-11T00:02:13Z","updated_at":"2016-03-11T00:02:17Z","pushed_at":"2016-03-17T17:50:59Z","git_url":"git://github.com/entlicher/truffle.git","ssh_url":"git@github.com:entlicher/truffle.git","clone_url":"https://github.com/entlicher/truffle.git","svn_url":"https://github.com/entlicher/truffle","homepage":"","size":16747,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graalvm:master","ref":"master","sha":"66e6e29da6fc598ae1b1c4da037d435231baec4b","user":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"repo":{"id":49662222,"name":"truffle","full_name":"graalvm/truffle","owner":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graalvm/truffle","description":"The Truffle Language Implementation Framework","fork":false,"url":"https://api.github.com/repos/graalvm/truffle","forks_url":"https://api.github.com/repos/graalvm/truffle/forks","keys_url":"https://api.github.com/repos/graalvm/truffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graalvm/truffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graalvm/truffle/teams","hooks_url":"https://api.github.com/repos/graalvm/truffle/hooks","issue_events_url":"https://api.github.com/repos/graalvm/truffle/issues/events{/number}","events_url":"https://api.github.com/repos/graalvm/truffle/events","assignees_url":"https://api.github.com/repos/graalvm/truffle/assignees{/user}","branches_url":"https://api.github.com/repos/graalvm/truffle/branches{/branch}","tags_url":"https://api.github.com/repos/graalvm/truffle/tags","blobs_url":"https://api.github.com/repos/graalvm/truffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graalvm/truffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graalvm/truffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/graalvm/truffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graalvm/truffle/statuses/{sha}","languages_url":"https://api.github.com/repos/graalvm/truffle/languages","stargazers_url":"https://api.github.com/repos/graalvm/truffle/stargazers","contributors_url":"https://api.github.com/repos/graalvm/truffle/contributors","subscribers_url":"https://api.github.com/repos/graalvm/truffle/subscribers","subscription_url":"https://api.github.com/repos/graalvm/truffle/subscription","commits_url":"https://api.github.com/repos/graalvm/truffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/graalvm/truffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/graalvm/truffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/graalvm/truffle/issues/comments{/number}","contents_url":"https://api.github.com/repos/graalvm/truffle/contents/{+path}","compare_url":"https://api.github.com/repos/graalvm/truffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graalvm/truffle/merges","archive_url":"https://api.github.com/repos/graalvm/truffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graalvm/truffle/downloads","issues_url":"https://api.github.com/repos/graalvm/truffle/issues{/number}","pulls_url":"https://api.github.com/repos/graalvm/truffle/pulls{/number}","milestones_url":"https://api.github.com/repos/graalvm/truffle/milestones{/number}","notifications_url":"https://api.github.com/repos/graalvm/truffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graalvm/truffle/labels{/name}","releases_url":"https://api.github.com/repos/graalvm/truffle/releases{/id}","deployments_url":"https://api.github.com/repos/graalvm/truffle/deployments","created_at":"2016-01-14T17:11:35Z","updated_at":"2016-03-16T23:00:56Z","pushed_at":"2016-03-17T15:59:52Z","git_url":"git://github.com/graalvm/truffle.git","ssh_url":"git@github.com:graalvm/truffle.git","clone_url":"https://github.com/graalvm/truffle.git","svn_url":"https://github.com/graalvm/truffle","homepage":"","size":17830,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":28,"forks":18,"open_issues":28,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/137"},"html":{"href":"https://github.com/graalvm/truffle/pull/137"},"issue":{"href":"https://api.github.com/repos/graalvm/truffle/issues/137"},"comments":{"href":"https://api.github.com/repos/graalvm/truffle/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graalvm/truffle/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/graalvm/truffle/statuses/85ae38115f109221edc8d23c1504cedc646736bd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":13,"changed_files":4}}