{"action":"created","issue":{"url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/689","repository_url":"https://api.github.com/repos/mathiasbynens/dotfiles","labels_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/689/labels{/name}","comments_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/689/comments","events_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/689/events","html_url":"https://github.com/mathiasbynens/dotfiles/pull/689","id":168517641,"number":689,"title":"Clean up obsolete Bash coding style in bootstrap.sh","user":{"login":"janosgyerik","id":1076364,"avatar_url":"https://avatars.githubusercontent.com/u/1076364?v=3","gravatar_id":"","url":"https://api.github.com/users/janosgyerik","html_url":"https://github.com/janosgyerik","followers_url":"https://api.github.com/users/janosgyerik/followers","following_url":"https://api.github.com/users/janosgyerik/following{/other_user}","gists_url":"https://api.github.com/users/janosgyerik/gists{/gist_id}","starred_url":"https://api.github.com/users/janosgyerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janosgyerik/subscriptions","organizations_url":"https://api.github.com/users/janosgyerik/orgs","repos_url":"https://api.github.com/users/janosgyerik/repos","events_url":"https://api.github.com/users/janosgyerik/events{/privacy}","received_events_url":"https://api.github.com/users/janosgyerik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-31T13:24:31Z","updated_at":"2016-08-01T03:31:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/689","html_url":"https://github.com/mathiasbynens/dotfiles/pull/689","diff_url":"https://github.com/mathiasbynens/dotfiles/pull/689.diff","patch_url":"https://github.com/mathiasbynens/dotfiles/pull/689.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/comments/236482013","html_url":"https://github.com/mathiasbynens/dotfiles/pull/689#issuecomment-236482013","issue_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/689","id":236482013,"user":{"login":"Tatsh","id":724848,"avatar_url":"https://avatars.githubusercontent.com/u/724848?v=3","gravatar_id":"","url":"https://api.github.com/users/Tatsh","html_url":"https://github.com/Tatsh","followers_url":"https://api.github.com/users/Tatsh/followers","following_url":"https://api.github.com/users/Tatsh/following{/other_user}","gists_url":"https://api.github.com/users/Tatsh/gists{/gist_id}","starred_url":"https://api.github.com/users/Tatsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tatsh/subscriptions","organizations_url":"https://api.github.com/users/Tatsh/orgs","repos_url":"https://api.github.com/users/Tatsh/repos","events_url":"https://api.github.com/users/Tatsh/events{/privacy}","received_events_url":"https://api.github.com/users/Tatsh/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T03:31:21Z","updated_at":"2016-08-01T03:31:21Z","body":"If you are going to fix this line, why not make it right by `shellcheck -s bash`?\r\n\r\n```bash\r\nif [[ \"$1\" = '--force' ]] || [[ \"$1\" = '-f' ]]; then\r\n```\r\n\r\nReading when `-o` or `||` is between is `[[ ]]` is more difficult. And you should always quote variables except when you want expansion.\r\n\r\n`=`/`==`/ is [covered in the Bash Wiki](http://mywiki.wooledge.org/BashFAQ/031). This script targets Bash, and `[[` (therefore `==`) is understood by Bash. Only if you use `[` must you use single `=`. In this project I do not think we are concerned about really old shells or alternatives like Dash."}}
{"actor":{"display_login":"Tatsh"}}