{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/5243","repository_url":"https://api.github.com/repos/astropy/astropy","labels_url":"https://api.github.com/repos/astropy/astropy/issues/5243/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/5243/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/5243/events","html_url":"https://github.com/astropy/astropy/pull/5243","id":171491669,"number":5243,"title":"added 2D cartesian shapelets model","user":{"login":"alex-delavega","id":12821250,"avatar_url":"https://avatars.githubusercontent.com/u/12821250?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-delavega","html_url":"https://github.com/alex-delavega","followers_url":"https://api.github.com/users/alex-delavega/followers","following_url":"https://api.github.com/users/alex-delavega/following{/other_user}","gists_url":"https://api.github.com/users/alex-delavega/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-delavega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-delavega/subscriptions","organizations_url":"https://api.github.com/users/alex-delavega/orgs","repos_url":"https://api.github.com/users/alex-delavega/repos","events_url":"https://api.github.com/users/alex-delavega/events{/privacy}","received_events_url":"https://api.github.com/users/alex-delavega/received_events","type":"User","site_admin":false},"labels":[{"id":35800382,"url":"https://api.github.com/repos/astropy/astropy/labels/modeling","name":"modeling","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-16T18:59:08Z","updated_at":"2016-12-07T12:37:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/5243","html_url":"https://github.com/astropy/astropy/pull/5243","diff_url":"https://github.com/astropy/astropy/pull/5243.diff","patch_url":"https://github.com/astropy/astropy/pull/5243.patch"},"body":"Added fittable 2D model for cartesian shapelets. Models flux of object through summation of basis functions comprising products of Hermite polynomials and gaussians. \n"},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/265436817","html_url":"https://github.com/astropy/astropy/pull/5243#issuecomment-265436817","issue_url":"https://api.github.com/repos/astropy/astropy/issues/5243","id":265436817,"user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T12:37:59Z","updated_at":"2016-12-07T12:37:59Z","body":"@alex-delavega - Thanks!\r\n\r\nNote that there's e.g. https://github.com/griffinfoster/shapelets by @griffinfoster , which I think contains more functionality than implemented here. It's the same license as Astropy, so it's OK to look at or even copy test or code from there.\r\n\r\nSo question to all - should shapelets go in `astropy.models`?\r\n\r\nI have no opinion on this. If the direction is leaning towards yes, my comments would be:\r\n- Please rebase against `master`.\r\n- Please add at least one more test that shows that it \"works\", i.e. higher-order terms match some result from a paper or other code like https://github.com/griffinfoster/shapelets/\r\n- Since it's not as complete as https://github.com/griffinfoster/shapelets/, I would suggest to add a link to that code from the docstring.\r\n"}}
{"actor":{"display_login":"cdeil"}}