{"action":"closed","number":18459,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18459","id":86154042,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18459","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18459.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18459.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18459","number":18459,"state":"closed","locked":false,"title":"Mining Mod","user":{"login":"DangerNoodle","id":22048567,"avatar_url":"https://avatars.githubusercontent.com/u/22048567?v=3","gravatar_id":"","url":"https://api.github.com/users/DangerNoodle","html_url":"https://github.com/DangerNoodle","followers_url":"https://api.github.com/users/DangerNoodle/followers","following_url":"https://api.github.com/users/DangerNoodle/following{/other_user}","gists_url":"https://api.github.com/users/DangerNoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/DangerNoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DangerNoodle/subscriptions","organizations_url":"https://api.github.com/users/DangerNoodle/orgs","repos_url":"https://api.github.com/users/DangerNoodle/repos","events_url":"https://api.github.com/users/DangerNoodle/events{/privacy}","received_events_url":"https://api.github.com/users/DangerNoodle/received_events","type":"User","site_admin":false},"body":"This mod is an attempt at an idea I mentioned during an earlier pull request. Currently leaving this as mod content might be the best option in the meantime, but content can be mainlined if desired.\r\n\r\nAdds mapgen entries containing mineral veins and clusters, scattered about through normal terrain. These essentially use the overmap method to add random veins in the least intrusive manner I could think of, as I do not think that source code changes would be easy for me to implement.\r\n\r\nVeins can occur in both shallow and deep format. Shallow veins will have only a single vein/cluster directly underneath the surface. Deep veins/clusters range from z-levels minus-two to minus-five, but each z-level has only a 75% chance of containing anything. Deep metals occur less often than shallow ones, and have different weights of potential minerals.\r\n\r\nIn addition to pre-existing rock salt, coal, niter, and sulfur being potential finds, the mod adds native copper, silver, gold, and aluminum. These require you to melt them down into usable material, but are relatively simple to do so, being native metals.\r\n\r\nAdditionally changes mundane rock to no longer be a source of coal or rock salt.\r\n\r\nEven with occurrences set rather high, this makes ore somewhat rare, but reasonably possible to find with some attempt to poke around.\r\n\r\nMore complex ores that would require actual smelting are planned for the future, but for the time being this is more than enough.","created_at":"2016-09-21T12:38:08Z","updated_at":"2016-09-23T09:41:41Z","closed_at":"2016-09-23T09:41:41Z","merged_at":null,"merge_commit_sha":"63878842f1bc5d181fc52720664f13a41f8349d1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18459/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18459/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18459/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/7f78d7a9fb3cbf660dc0fc5719da2e504633415a","head":{"label":"DangerNoodle:mining-mod","ref":"mining-mod","sha":"7f78d7a9fb3cbf660dc0fc5719da2e504633415a","user":{"login":"DangerNoodle","id":22048567,"avatar_url":"https://avatars.githubusercontent.com/u/22048567?v=3","gravatar_id":"","url":"https://api.github.com/users/DangerNoodle","html_url":"https://github.com/DangerNoodle","followers_url":"https://api.github.com/users/DangerNoodle/followers","following_url":"https://api.github.com/users/DangerNoodle/following{/other_user}","gists_url":"https://api.github.com/users/DangerNoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/DangerNoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DangerNoodle/subscriptions","organizations_url":"https://api.github.com/users/DangerNoodle/orgs","repos_url":"https://api.github.com/users/DangerNoodle/repos","events_url":"https://api.github.com/users/DangerNoodle/events{/privacy}","received_events_url":"https://api.github.com/users/DangerNoodle/received_events","type":"User","site_admin":false},"repo":{"id":67589744,"name":"Cataclysm-DDA","full_name":"DangerNoodle/Cataclysm-DDA","owner":{"login":"DangerNoodle","id":22048567,"avatar_url":"https://avatars.githubusercontent.com/u/22048567?v=3","gravatar_id":"","url":"https://api.github.com/users/DangerNoodle","html_url":"https://github.com/DangerNoodle","followers_url":"https://api.github.com/users/DangerNoodle/followers","following_url":"https://api.github.com/users/DangerNoodle/following{/other_user}","gists_url":"https://api.github.com/users/DangerNoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/DangerNoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DangerNoodle/subscriptions","organizations_url":"https://api.github.com/users/DangerNoodle/orgs","repos_url":"https://api.github.com/users/DangerNoodle/repos","events_url":"https://api.github.com/users/DangerNoodle/events{/privacy}","received_events_url":"https://api.github.com/users/DangerNoodle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DangerNoodle/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA","forks_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/DangerNoodle/Cataclysm-DDA/deployments","created_at":"2016-09-07T08:54:38Z","updated_at":"2016-09-07T08:54:47Z","pushed_at":"2016-09-23T08:06:08Z","git_url":"git://github.com/DangerNoodle/Cataclysm-DDA.git","ssh_url":"git@github.com:DangerNoodle/Cataclysm-DDA.git","clone_url":"https://github.com/DangerNoodle/Cataclysm-DDA.git","svn_url":"https://github.com/DangerNoodle/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":796775,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"4266ce654bd180328987f8da3a1609b41c939dd0","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-09-22T17:35:13Z","pushed_at":"2016-09-23T08:42:00Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1073652,"stargazers_count":1078,"watchers_count":1078,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":959,"mirror_url":null,"open_issues_count":1250,"forks":959,"open_issues":1250,"watchers":1078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18459"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18459"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18459"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18459/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18459/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18459/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/7f78d7a9fb3cbf660dc0fc5719da2e504633415a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":35,"review_comments":0,"commits":2,"additions":1375,"deletions":0,"changed_files":8}}
{"actor":{"display_login":"mugling"}}