{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/60055366","id":60055366,"diff_hunk":"@@ -981,6 +1047,85 @@ Store = Service.extend({\n     });\n     ```\n \n+    _When_ the returned promise resolves depends on the reload reload behavior,","path":"addon/-private/system/store.js","position":136,"original_position":136,"commit_id":"486e07ecf1b093ac3df802aa67c5a374ca22c6d0","original_commit_id":"486e07ecf1b093ac3df802aa67c5a374ca22c6d0","user":{"login":"xomaczar","id":2079865,"avatar_url":"https://avatars.githubusercontent.com/u/2079865?v=3","gravatar_id":"","url":"https://api.github.com/users/xomaczar","html_url":"https://github.com/xomaczar","followers_url":"https://api.github.com/users/xomaczar/followers","following_url":"https://api.github.com/users/xomaczar/following{/other_user}","gists_url":"https://api.github.com/users/xomaczar/gists{/gist_id}","starred_url":"https://api.github.com/users/xomaczar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xomaczar/subscriptions","organizations_url":"https://api.github.com/users/xomaczar/orgs","repos_url":"https://api.github.com/users/xomaczar/repos","events_url":"https://api.github.com/users/xomaczar/events{/privacy}","received_events_url":"https://api.github.com/users/xomaczar/received_events","type":"User","site_admin":false},"body":"Typo reload reload","created_at":"2016-04-18T13:17:47Z","updated_at":"2016-04-18T13:17:47Z","html_url":"https://github.com/emberjs/data/pull/4338#discussion_r60055366","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/4338","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/60055366"},"html":{"href":"https://github.com/emberjs/data/pull/4338#discussion_r60055366"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/4338"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4338","id":66734240,"html_url":"https://github.com/emberjs/data/pull/4338","diff_url":"https://github.com/emberjs/data/pull/4338.diff","patch_url":"https://github.com/emberjs/data/pull/4338.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/4338","number":4338,"state":"open","locked":false,"title":"[DOC beta] Overhaul documentation for reload / background reload","user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"body":"Initial stab at adding better documentation for the reload and background reload behavior of `store.findRecord` and `store.findAll`. The behavior has been described in the [release blog post for `v.13`](http://emberjs.com/blog/2015/06/18/ember-data-1-13-released.html#toc_new-adapter-hooks-for-better-caching), but the API documentation currently lacks this information, which unfortunately caused some headaches (#4162, #4148, #3657, #3483).","created_at":"2016-04-16T10:23:21Z","updated_at":"2016-04-18T13:17:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec8907bbd4c25f2772054ca0567625bf3501b9f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/4338/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/4338/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4338/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/486e07ecf1b093ac3df802aa67c5a374ca22c6d0","head":{"label":"pangratz:doc-reload-backgroundReload","ref":"doc-reload-backgroundReload","sha":"486e07ecf1b093ac3df802aa67c5a374ca22c6d0","user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"repo":{"id":3021258,"name":"data","full_name":"pangratz/data","owner":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pangratz/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/pangratz/data","forks_url":"https://api.github.com/repos/pangratz/data/forks","keys_url":"https://api.github.com/repos/pangratz/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pangratz/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pangratz/data/teams","hooks_url":"https://api.github.com/repos/pangratz/data/hooks","issue_events_url":"https://api.github.com/repos/pangratz/data/issues/events{/number}","events_url":"https://api.github.com/repos/pangratz/data/events","assignees_url":"https://api.github.com/repos/pangratz/data/assignees{/user}","branches_url":"https://api.github.com/repos/pangratz/data/branches{/branch}","tags_url":"https://api.github.com/repos/pangratz/data/tags","blobs_url":"https://api.github.com/repos/pangratz/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pangratz/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pangratz/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/pangratz/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pangratz/data/statuses/{sha}","languages_url":"https://api.github.com/repos/pangratz/data/languages","stargazers_url":"https://api.github.com/repos/pangratz/data/stargazers","contributors_url":"https://api.github.com/repos/pangratz/data/contributors","subscribers_url":"https://api.github.com/repos/pangratz/data/subscribers","subscription_url":"https://api.github.com/repos/pangratz/data/subscription","commits_url":"https://api.github.com/repos/pangratz/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/pangratz/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/pangratz/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/pangratz/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/pangratz/data/contents/{+path}","compare_url":"https://api.github.com/repos/pangratz/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pangratz/data/merges","archive_url":"https://api.github.com/repos/pangratz/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pangratz/data/downloads","issues_url":"https://api.github.com/repos/pangratz/data/issues{/number}","pulls_url":"https://api.github.com/repos/pangratz/data/pulls{/number}","milestones_url":"https://api.github.com/repos/pangratz/data/milestones{/number}","notifications_url":"https://api.github.com/repos/pangratz/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pangratz/data/labels{/name}","releases_url":"https://api.github.com/repos/pangratz/data/releases{/id}","deployments_url":"https://api.github.com/repos/pangratz/data/deployments","created_at":"2011-12-20T17:39:07Z","updated_at":"2015-05-08T20:55:11Z","pushed_at":"2016-04-18T09:42:48Z","git_url":"git://github.com/pangratz/data.git","ssh_url":"git@github.com:pangratz/data.git","clone_url":"https://github.com/pangratz/data.git","svn_url":"https://github.com/pangratz/data","homepage":"","size":11065,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"a9f57a4beeee0f9f39bd63f3e44939aa7ccc79f3","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2016-04-15T15:40:10Z","pushed_at":"2016-04-16T10:33:34Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":19819,"stargazers_count":2662,"watchers_count":2662,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1047,"mirror_url":null,"open_issues_count":203,"forks":1047,"open_issues":203,"watchers":2662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/4338"},"html":{"href":"https://github.com/emberjs/data/pull/4338"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/4338"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/4338/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/4338/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/4338/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/486e07ecf1b093ac3df802aa67c5a374ca22c6d0"}}}}