{"action":"created","issue":{"url":"https://api.github.com/repos/go-kit/kit/issues/283","repository_url":"https://api.github.com/repos/go-kit/kit","labels_url":"https://api.github.com/repos/go-kit/kit/issues/283/labels{/name}","comments_url":"https://api.github.com/repos/go-kit/kit/issues/283/comments","events_url":"https://api.github.com/repos/go-kit/kit/issues/283/events","html_url":"https://github.com/go-kit/kit/issues/283","id":158339228,"number":283,"title":"gRPC support for application error encoding and decoding through metadata","user":{"login":"ravlio","id":2349151,"avatar_url":"https://avatars.githubusercontent.com/u/2349151?v=3","gravatar_id":"","url":"https://api.github.com/users/ravlio","html_url":"https://github.com/ravlio","followers_url":"https://api.github.com/users/ravlio/followers","following_url":"https://api.github.com/users/ravlio/following{/other_user}","gists_url":"https://api.github.com/users/ravlio/gists{/gist_id}","starred_url":"https://api.github.com/users/ravlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravlio/subscriptions","organizations_url":"https://api.github.com/users/ravlio/orgs","repos_url":"https://api.github.com/users/ravlio/repos","events_url":"https://api.github.com/users/ravlio/events{/privacy}","received_events_url":"https://api.github.com/users/ravlio/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/go-kit/kit/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-03T10:37:11Z","updated_at":"2016-06-07T08:02:57Z","closed_at":null,"body":"It is would be very nice to make application error handlers for gRPC as same as in http transport realization. I need to forward custom error with code and message and some other data from server to client and I have no other ideas then to put it all to metadata. I think that it is possible to do by putting error handler in server after decoder and invoker and client after invoker in the manner of http transport do."},"comment":{"url":"https://api.github.com/repos/go-kit/kit/issues/comments/224208554","html_url":"https://github.com/go-kit/kit/issues/283#issuecomment-224208554","issue_url":"https://api.github.com/repos/go-kit/kit/issues/283","id":224208554,"user":{"login":"ravlio","id":2349151,"avatar_url":"https://avatars.githubusercontent.com/u/2349151?v=3","gravatar_id":"","url":"https://api.github.com/users/ravlio","html_url":"https://github.com/ravlio","followers_url":"https://api.github.com/users/ravlio/followers","following_url":"https://api.github.com/users/ravlio/following{/other_user}","gists_url":"https://api.github.com/users/ravlio/gists{/gist_id}","starred_url":"https://api.github.com/users/ravlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravlio/subscriptions","organizations_url":"https://api.github.com/users/ravlio/orgs","repos_url":"https://api.github.com/users/ravlio/repos","events_url":"https://api.github.com/users/ravlio/events{/privacy}","received_events_url":"https://api.github.com/users/ravlio/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T08:02:57Z","updated_at":"2016-06-07T08:02:57Z","body":"Thank you for refactoring of examples, things getting more clear, I have found grpc error handler in addSvc with custom errors. But if I provoke some error like ErrTwoZeroes the server goes down and log error three times in a row. Looks more like unrecoverable protocol fault then regular handled error when I simply can check error with `if err != nil && err.(type) == ErrMyCustomError` on client.\r\n\r\nI can do all the validations on client side but there is always the chance of errors. Any thoughts on this? Best practices? I want to mention that error may occur not only in service but often in request decoder function."}}
{"actor":{"display_login":"ravlio"}}