{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/76857853","id":76857853,"diff_hunk":"@@ -89,6 +98,32 @@ public function __get($attribute)\n         if ($attribute === 'name' || $attribute === 'subject') {\n             return $this->{$attribute}();\n         }\n+        if ($attribute === 'data') {\n+            trigger_error('Public read access to data is deprecated, use data()', E_USER_DEPRECATED);\n+            return $this->_data;\n+        }\n+        if ($attribute === 'result') {\n+            trigger_error('Public read access to result is deprecated, use result()', E_USER_DEPRECATED);\n+            return $this->_result;\n+        }\n+    }\n+\n+    /**\n+     * Provides backward compatibility for write access to data and result properties.\n+     *\n+     * @param string $attribute Attribute name.\n+     * @param mixed $value\n+     */","path":"src/Event/Event.php","position":71,"original_position":71,"commit_id":"6f0ee46e9074655b22e4c18cf75ed1ebb09dd88c","original_commit_id":"6f0ee46e9074655b22e4c18cf75ed1ebb09dd88c","user":{"login":"thinkingmedia","id":551022,"avatar_url":"https://avatars.githubusercontent.com/u/551022?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkingmedia","html_url":"https://github.com/thinkingmedia","followers_url":"https://api.github.com/users/thinkingmedia/followers","following_url":"https://api.github.com/users/thinkingmedia/following{/other_user}","gists_url":"https://api.github.com/users/thinkingmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkingmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkingmedia/subscriptions","organizations_url":"https://api.github.com/users/thinkingmedia/orgs","repos_url":"https://api.github.com/users/thinkingmedia/repos","events_url":"https://api.github.com/users/thinkingmedia/events{/privacy}","received_events_url":"https://api.github.com/users/thinkingmedia/received_events","type":"User","site_admin":false},"body":"shouldn't have to document void return.","created_at":"2016-08-30T18:57:18Z","updated_at":"2016-08-30T18:57:18Z","html_url":"https://github.com/cakephp/cakephp/pull/9376#discussion_r76857853","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9376","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/76857853"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9376#discussion_r76857853"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9376"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/9376","id":83325685,"html_url":"https://github.com/cakephp/cakephp/pull/9376","diff_url":"https://github.com/cakephp/cakephp/pull/9376.diff","patch_url":"https://github.com/cakephp/cakephp/pull/9376.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/9376","number":9376,"state":"open","locked":false,"title":"Consistent type usage for Event data","user":{"login":"thinkingmedia","id":551022,"avatar_url":"https://avatars.githubusercontent.com/u/551022?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkingmedia","html_url":"https://github.com/thinkingmedia","followers_url":"https://api.github.com/users/thinkingmedia/followers","following_url":"https://api.github.com/users/thinkingmedia/following{/other_user}","gists_url":"https://api.github.com/users/thinkingmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkingmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkingmedia/subscriptions","organizations_url":"https://api.github.com/users/thinkingmedia/orgs","repos_url":"https://api.github.com/users/thinkingmedia/repos","events_url":"https://api.github.com/users/thinkingmedia/events{/privacy}","received_events_url":"https://api.github.com/users/thinkingmedia/received_events","type":"User","site_admin":false},"body":"closes #8923 \r\n\r\n- replaces usage of `attach` with `on` in tests\r\n- replaces usage of `detach` with `off` in tests\r\n- adds `Event` type hinting for all event listeners\r\n- adds `setData` method to `Event`\r\n- adds`data($key = null)` getter method, null returns all data.\r\n- adds `setResult` method to `Event`\r\n- adds `result()` getter method.\r\n- `Event::data` still supports read/write operations, but generates a deprecated warning.\r\n- `Event::result` still supports read/write operations, but generates a deprecated warning.","created_at":"2016-08-30T18:48:49Z","updated_at":"2016-08-30T18:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"945795b240713de69ca29390bc13f2c8fb60dce1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9376/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9376/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/9376/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/6f0ee46e9074655b22e4c18cf75ed1ebb09dd88c","head":{"label":"thinkingmedia:thinkingmedia/event-data","ref":"thinkingmedia/event-data","sha":"6f0ee46e9074655b22e4c18cf75ed1ebb09dd88c","user":{"login":"thinkingmedia","id":551022,"avatar_url":"https://avatars.githubusercontent.com/u/551022?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkingmedia","html_url":"https://github.com/thinkingmedia","followers_url":"https://api.github.com/users/thinkingmedia/followers","following_url":"https://api.github.com/users/thinkingmedia/following{/other_user}","gists_url":"https://api.github.com/users/thinkingmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkingmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkingmedia/subscriptions","organizations_url":"https://api.github.com/users/thinkingmedia/orgs","repos_url":"https://api.github.com/users/thinkingmedia/repos","events_url":"https://api.github.com/users/thinkingmedia/events{/privacy}","received_events_url":"https://api.github.com/users/thinkingmedia/received_events","type":"User","site_admin":false},"repo":{"id":34620903,"name":"cakephp","full_name":"thinkingmedia/cakephp","owner":{"login":"thinkingmedia","id":551022,"avatar_url":"https://avatars.githubusercontent.com/u/551022?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkingmedia","html_url":"https://github.com/thinkingmedia","followers_url":"https://api.github.com/users/thinkingmedia/followers","following_url":"https://api.github.com/users/thinkingmedia/following{/other_user}","gists_url":"https://api.github.com/users/thinkingmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkingmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkingmedia/subscriptions","organizations_url":"https://api.github.com/users/thinkingmedia/orgs","repos_url":"https://api.github.com/users/thinkingmedia/repos","events_url":"https://api.github.com/users/thinkingmedia/events{/privacy}","received_events_url":"https://api.github.com/users/thinkingmedia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thinkingmedia/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/thinkingmedia/cakephp","forks_url":"https://api.github.com/repos/thinkingmedia/cakephp/forks","keys_url":"https://api.github.com/repos/thinkingmedia/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thinkingmedia/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thinkingmedia/cakephp/teams","hooks_url":"https://api.github.com/repos/thinkingmedia/cakephp/hooks","issue_events_url":"https://api.github.com/repos/thinkingmedia/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/thinkingmedia/cakephp/events","assignees_url":"https://api.github.com/repos/thinkingmedia/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/thinkingmedia/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/thinkingmedia/cakephp/tags","blobs_url":"https://api.github.com/repos/thinkingmedia/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thinkingmedia/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thinkingmedia/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/thinkingmedia/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thinkingmedia/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/thinkingmedia/cakephp/languages","stargazers_url":"https://api.github.com/repos/thinkingmedia/cakephp/stargazers","contributors_url":"https://api.github.com/repos/thinkingmedia/cakephp/contributors","subscribers_url":"https://api.github.com/repos/thinkingmedia/cakephp/subscribers","subscription_url":"https://api.github.com/repos/thinkingmedia/cakephp/subscription","commits_url":"https://api.github.com/repos/thinkingmedia/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/thinkingmedia/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/thinkingmedia/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/thinkingmedia/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/thinkingmedia/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/thinkingmedia/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thinkingmedia/cakephp/merges","archive_url":"https://api.github.com/repos/thinkingmedia/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thinkingmedia/cakephp/downloads","issues_url":"https://api.github.com/repos/thinkingmedia/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/thinkingmedia/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/thinkingmedia/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/thinkingmedia/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thinkingmedia/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/thinkingmedia/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/thinkingmedia/cakephp/deployments","created_at":"2015-04-26T16:45:21Z","updated_at":"2016-04-13T01:30:59Z","pushed_at":"2016-08-30T18:39:21Z","git_url":"git://github.com/thinkingmedia/cakephp.git","ssh_url":"git@github.com:thinkingmedia/cakephp.git","clone_url":"https://github.com/thinkingmedia/cakephp.git","svn_url":"https://github.com/thinkingmedia/cakephp","homepage":"http://cakephp.org","size":63748,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"8314c2ff833280bbc7102cb6d4fcf62240cd3ac4","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2016-08-30T17:41:39Z","pushed_at":"2016-08-30T18:48:49Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":130447,"stargazers_count":6676,"watchers_count":6676,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3033,"mirror_url":null,"open_issues_count":201,"forks":3033,"open_issues":201,"watchers":6676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9376"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9376"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9376"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9376/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9376/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9376/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/6f0ee46e9074655b22e4c18cf75ed1ebb09dd88c"}}}}
{"actor":{"display_login":"thinkingmedia"}}