{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/comments/64446448","id":64446448,"diff_hunk":"@@ -51,11 +51,6 @@ @interface BUYApplePayHelpers ()\n \n @implementation BUYApplePayHelpers\n \n-- (instancetype)initWithClient:(BUYClient *)client checkout:(BUYCheckout *)checkout\n-{\n-\treturn [self initWithClient:client checkout:checkout shop:nil];\n-}\n-\n - (instancetype)initWithClient:(BUYClient *)client checkout:(BUYCheckout *)checkout shop:(BUYShop *)shop","path":"Mobile Buy SDK/Mobile Buy SDK/Utils/BUYApplePayHelpers.m","position":null,"original_position":9,"commit_id":"02444162b21ab384c5156578e88e60d1f340b28c","original_commit_id":"338310ea5d577d6291d6a3837e67ca9563bd2a53","user":{"login":"bgulanowski","id":186680,"avatar_url":"https://avatars.githubusercontent.com/u/186680?v=3","gravatar_id":"","url":"https://api.github.com/users/bgulanowski","html_url":"https://github.com/bgulanowski","followers_url":"https://api.github.com/users/bgulanowski/followers","following_url":"https://api.github.com/users/bgulanowski/following{/other_user}","gists_url":"https://api.github.com/users/bgulanowski/gists{/gist_id}","starred_url":"https://api.github.com/users/bgulanowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgulanowski/subscriptions","organizations_url":"https://api.github.com/users/bgulanowski/orgs","repos_url":"https://api.github.com/users/bgulanowski/repos","events_url":"https://api.github.com/users/bgulanowski/events{/privacy}","received_events_url":"https://api.github.com/users/bgulanowski/received_events","type":"User","site_admin":false},"body":"Whether to use ivar or property notation for private read/write properties is a convention. However, the standard practise is moving towards the latter (property/setter) access. I've personally flip-flopped on this. I do believe that ivar access is correct for `-init` methods, but we should use setters/property access elsewhere. There are a few reasons, including KVO.","created_at":"2016-05-24T18:17:09Z","updated_at":"2016-05-24T18:17:09Z","html_url":"https://github.com/Shopify/mobile-buy-sdk-ios/pull/175#discussion_r64446448","pull_request_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/comments/64446448"},"html":{"href":"https://github.com/Shopify/mobile-buy-sdk-ios/pull/175#discussion_r64446448"},"pull_request":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175","id":70760299,"html_url":"https://github.com/Shopify/mobile-buy-sdk-ios/pull/175","diff_url":"https://github.com/Shopify/mobile-buy-sdk-ios/pull/175.diff","patch_url":"https://github.com/Shopify/mobile-buy-sdk-ios/pull/175.patch","issue_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/175","number":175,"state":"open","locked":false,"title":"Clean up BUYApplePayHelpers","user":{"login":"gabrieloc","id":983669,"avatar_url":"https://avatars.githubusercontent.com/u/983669?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrieloc","html_url":"https://github.com/gabrieloc","followers_url":"https://api.github.com/users/gabrieloc/followers","following_url":"https://api.github.com/users/gabrieloc/following{/other_user}","gists_url":"https://api.github.com/users/gabrieloc/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieloc/subscriptions","organizations_url":"https://api.github.com/users/gabrieloc/orgs","repos_url":"https://api.github.com/users/gabrieloc/repos","events_url":"https://api.github.com/users/gabrieloc/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieloc/received_events","type":"User","site_admin":false},"body":"**What this does**\r\n- Makes `shop` a required argument for initialization\r\n- Removes redundant payment authorization methods\r\n- Polling work handled by https://github.com/Shopify/mobile-buy-sdk-ios/pull/174\r\n\r\nFixes #154 \r\n\r\n@davidmuzi @dbart01  ","created_at":"2016-05-19T20:32:55Z","updated_at":"2016-05-24T18:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ddc001b9e53cd8ddf913a1702ad4af280f4794b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175/commits","review_comments_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175/comments","review_comment_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/175/comments","statuses_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/statuses/02444162b21ab384c5156578e88e60d1f340b28c","head":{"label":"Shopify:task/154-cleanup-applepay-helpers","ref":"task/154-cleanup-applepay-helpers","sha":"02444162b21ab384c5156578e88e60d1f340b28c","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":36382861,"name":"mobile-buy-sdk-ios","full_name":"Shopify/mobile-buy-sdk-ios","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/mobile-buy-sdk-ios","description":"Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using Apple Pay or their credit card.","fork":false,"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios","forks_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/forks","keys_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/teams","hooks_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/hooks","issue_events_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/events","assignees_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/tags","blobs_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/languages","stargazers_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/stargazers","contributors_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/contributors","subscribers_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/subscribers","subscription_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/subscription","commits_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/merges","archive_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/downloads","issues_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/deployments","created_at":"2015-05-27T17:12:56Z","updated_at":"2016-05-20T23:47:38Z","pushed_at":"2016-05-24T17:41:44Z","git_url":"git://github.com/Shopify/mobile-buy-sdk-ios.git","ssh_url":"git@github.com:Shopify/mobile-buy-sdk-ios.git","clone_url":"https://github.com/Shopify/mobile-buy-sdk-ios.git","svn_url":"https://github.com/Shopify/mobile-buy-sdk-ios","homepage":"","size":15343,"stargazers_count":54,"watchers_count":54,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":25,"forks":25,"open_issues":25,"watchers":54,"default_branch":"master"}},"base":{"label":"Shopify:integration/sdk-2.0","ref":"integration/sdk-2.0","sha":"be59c98e710380b1729ba6c07542a88a0cc2c3bd","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":36382861,"name":"mobile-buy-sdk-ios","full_name":"Shopify/mobile-buy-sdk-ios","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/mobile-buy-sdk-ios","description":"Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using Apple Pay or their credit card.","fork":false,"url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios","forks_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/forks","keys_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/teams","hooks_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/hooks","issue_events_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/events","assignees_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/tags","blobs_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/languages","stargazers_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/stargazers","contributors_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/contributors","subscribers_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/subscribers","subscription_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/subscription","commits_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/merges","archive_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/downloads","issues_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/deployments","created_at":"2015-05-27T17:12:56Z","updated_at":"2016-05-20T23:47:38Z","pushed_at":"2016-05-24T17:41:44Z","git_url":"git://github.com/Shopify/mobile-buy-sdk-ios.git","ssh_url":"git@github.com:Shopify/mobile-buy-sdk-ios.git","clone_url":"https://github.com/Shopify/mobile-buy-sdk-ios.git","svn_url":"https://github.com/Shopify/mobile-buy-sdk-ios","homepage":"","size":15343,"stargazers_count":54,"watchers_count":54,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":25,"forks":25,"open_issues":25,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175"},"html":{"href":"https://github.com/Shopify/mobile-buy-sdk-ios/pull/175"},"issue":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/175"},"comments":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/mobile-buy-sdk-ios/statuses/02444162b21ab384c5156578e88e60d1f340b28c"}}}}
{"actor":{"display_login":"bgulanowski"}}