{"action":"created","comment":{"url":"https://api.github.com/repos/uwdata/compassql/pulls/comments/75410955","id":75410955,"diff_hunk":"@@ -19,6 +19,50 @@ const CONFIG_WITH_AUTO_ADD_COUNT = extend({}, DEFAULT_QUERY_CONFIG, {autoAddCoun\n \n describe('generate', function () {\n   describe('1D', () => {\n+    describe('Q with mark=?, channel=size', () => {\n+      it('should enumerate mark=point and generate a point plot', () => {\n+        const query = {\n+          mark: '?',\n+          encodings: [{\n+            channel: Channel.SIZE,\n+            field: 'A',\n+            type: Type.QUANTITATIVE\n+          }]\n+        };\n+        const answerSet = generate(query, schema);\n+        assert.equal(answerSet.length, 1);\n+        assert.equal(answerSet[0].getMark(), Mark.POINT);\n+      });\n+    });\n+\n+    describe('Q with mark=?, channel=?', () => {","path":"test/generate.test.ts","position":20,"original_position":20,"commit_id":"4f230eb3bd16cd48c60e18ac0761d89454aece9a","original_commit_id":"4f230eb3bd16cd48c60e18ac0761d89454aece9a","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars.githubusercontent.com/u/111269?v=3","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"Add 'Q mark = point, channel = ?' \r\nand you should get only x y","created_at":"2016-08-19T00:09:44Z","updated_at":"2016-08-19T00:09:44Z","html_url":"https://github.com/uwdata/compassql/pull/238#discussion_r75410955","pull_request_url":"https://api.github.com/repos/uwdata/compassql/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/comments/75410955"},"html":{"href":"https://github.com/uwdata/compassql/pull/238#discussion_r75410955"},"pull_request":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/uwdata/compassql/pulls/238","id":81724612,"html_url":"https://github.com/uwdata/compassql/pull/238","diff_url":"https://github.com/uwdata/compassql/pull/238.diff","patch_url":"https://github.com/uwdata/compassql/pull/238.patch","issue_url":"https://api.github.com/repos/uwdata/compassql/issues/238","number":238,"state":"open","locked":false,"title":"Relax hasAllRequiredChannelsForMark constraint for when mark is an enum spec","user":{"login":"felixcodes","id":17525561,"avatar_url":"https://avatars.githubusercontent.com/u/17525561?v=3","gravatar_id":"","url":"https://api.github.com/users/felixcodes","html_url":"https://github.com/felixcodes","followers_url":"https://api.github.com/users/felixcodes/followers","following_url":"https://api.github.com/users/felixcodes/following{/other_user}","gists_url":"https://api.github.com/users/felixcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/felixcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixcodes/subscriptions","organizations_url":"https://api.github.com/users/felixcodes/orgs","repos_url":"https://api.github.com/users/felixcodes/repos","events_url":"https://api.github.com/users/felixcodes/events{/privacy}","received_events_url":"https://api.github.com/users/felixcodes/received_events","type":"User","site_admin":false},"body":"fix #237 \r\n- Allow a point plot to generate when mark is an enum spec.","created_at":"2016-08-17T22:00:13Z","updated_at":"2016-08-19T00:09:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66c0a3e323247617d0bb6343555b807a10a221a2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uwdata/compassql/pulls/238/commits","review_comments_url":"https://api.github.com/repos/uwdata/compassql/pulls/238/comments","review_comment_url":"https://api.github.com/repos/uwdata/compassql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uwdata/compassql/issues/238/comments","statuses_url":"https://api.github.com/repos/uwdata/compassql/statuses/4f230eb3bd16cd48c60e18ac0761d89454aece9a","head":{"label":"uwdata:fo/237-relax-constraint-when-no-x-and-y","ref":"fo/237-relax-constraint-when-no-x-and-y","sha":"4f230eb3bd16cd48c60e18ac0761d89454aece9a","user":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"repo":{"id":58768960,"name":"compassql","full_name":"uwdata/compassql","owner":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwdata/compassql","description":"CompassQL Query Language for visualization recommendation.","fork":false,"url":"https://api.github.com/repos/uwdata/compassql","forks_url":"https://api.github.com/repos/uwdata/compassql/forks","keys_url":"https://api.github.com/repos/uwdata/compassql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwdata/compassql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwdata/compassql/teams","hooks_url":"https://api.github.com/repos/uwdata/compassql/hooks","issue_events_url":"https://api.github.com/repos/uwdata/compassql/issues/events{/number}","events_url":"https://api.github.com/repos/uwdata/compassql/events","assignees_url":"https://api.github.com/repos/uwdata/compassql/assignees{/user}","branches_url":"https://api.github.com/repos/uwdata/compassql/branches{/branch}","tags_url":"https://api.github.com/repos/uwdata/compassql/tags","blobs_url":"https://api.github.com/repos/uwdata/compassql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwdata/compassql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwdata/compassql/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwdata/compassql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwdata/compassql/statuses/{sha}","languages_url":"https://api.github.com/repos/uwdata/compassql/languages","stargazers_url":"https://api.github.com/repos/uwdata/compassql/stargazers","contributors_url":"https://api.github.com/repos/uwdata/compassql/contributors","subscribers_url":"https://api.github.com/repos/uwdata/compassql/subscribers","subscription_url":"https://api.github.com/repos/uwdata/compassql/subscription","commits_url":"https://api.github.com/repos/uwdata/compassql/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwdata/compassql/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwdata/compassql/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwdata/compassql/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwdata/compassql/contents/{+path}","compare_url":"https://api.github.com/repos/uwdata/compassql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwdata/compassql/merges","archive_url":"https://api.github.com/repos/uwdata/compassql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwdata/compassql/downloads","issues_url":"https://api.github.com/repos/uwdata/compassql/issues{/number}","pulls_url":"https://api.github.com/repos/uwdata/compassql/pulls{/number}","milestones_url":"https://api.github.com/repos/uwdata/compassql/milestones{/number}","notifications_url":"https://api.github.com/repos/uwdata/compassql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwdata/compassql/labels{/name}","releases_url":"https://api.github.com/repos/uwdata/compassql/releases{/id}","deployments_url":"https://api.github.com/repos/uwdata/compassql/deployments","created_at":"2016-05-13T20:01:53Z","updated_at":"2016-07-19T01:19:16Z","pushed_at":"2016-08-18T22:23:17Z","git_url":"git://github.com/uwdata/compassql.git","ssh_url":"git@github.com:uwdata/compassql.git","clone_url":"https://github.com/uwdata/compassql.git","svn_url":"https://github.com/uwdata/compassql","homepage":null,"size":1669,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":64,"forks":0,"open_issues":64,"watchers":2,"default_branch":"master"}},"base":{"label":"uwdata:master","ref":"master","sha":"23d601621d77a9b43a1be9849555f063737c39fa","user":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"repo":{"id":58768960,"name":"compassql","full_name":"uwdata/compassql","owner":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwdata/compassql","description":"CompassQL Query Language for visualization recommendation.","fork":false,"url":"https://api.github.com/repos/uwdata/compassql","forks_url":"https://api.github.com/repos/uwdata/compassql/forks","keys_url":"https://api.github.com/repos/uwdata/compassql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwdata/compassql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwdata/compassql/teams","hooks_url":"https://api.github.com/repos/uwdata/compassql/hooks","issue_events_url":"https://api.github.com/repos/uwdata/compassql/issues/events{/number}","events_url":"https://api.github.com/repos/uwdata/compassql/events","assignees_url":"https://api.github.com/repos/uwdata/compassql/assignees{/user}","branches_url":"https://api.github.com/repos/uwdata/compassql/branches{/branch}","tags_url":"https://api.github.com/repos/uwdata/compassql/tags","blobs_url":"https://api.github.com/repos/uwdata/compassql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwdata/compassql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwdata/compassql/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwdata/compassql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwdata/compassql/statuses/{sha}","languages_url":"https://api.github.com/repos/uwdata/compassql/languages","stargazers_url":"https://api.github.com/repos/uwdata/compassql/stargazers","contributors_url":"https://api.github.com/repos/uwdata/compassql/contributors","subscribers_url":"https://api.github.com/repos/uwdata/compassql/subscribers","subscription_url":"https://api.github.com/repos/uwdata/compassql/subscription","commits_url":"https://api.github.com/repos/uwdata/compassql/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwdata/compassql/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwdata/compassql/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwdata/compassql/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwdata/compassql/contents/{+path}","compare_url":"https://api.github.com/repos/uwdata/compassql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwdata/compassql/merges","archive_url":"https://api.github.com/repos/uwdata/compassql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwdata/compassql/downloads","issues_url":"https://api.github.com/repos/uwdata/compassql/issues{/number}","pulls_url":"https://api.github.com/repos/uwdata/compassql/pulls{/number}","milestones_url":"https://api.github.com/repos/uwdata/compassql/milestones{/number}","notifications_url":"https://api.github.com/repos/uwdata/compassql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwdata/compassql/labels{/name}","releases_url":"https://api.github.com/repos/uwdata/compassql/releases{/id}","deployments_url":"https://api.github.com/repos/uwdata/compassql/deployments","created_at":"2016-05-13T20:01:53Z","updated_at":"2016-07-19T01:19:16Z","pushed_at":"2016-08-18T22:23:17Z","git_url":"git://github.com/uwdata/compassql.git","ssh_url":"git@github.com:uwdata/compassql.git","clone_url":"https://github.com/uwdata/compassql.git","svn_url":"https://github.com/uwdata/compassql","homepage":null,"size":1669,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":64,"forks":0,"open_issues":64,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/238"},"html":{"href":"https://github.com/uwdata/compassql/pull/238"},"issue":{"href":"https://api.github.com/repos/uwdata/compassql/issues/238"},"comments":{"href":"https://api.github.com/repos/uwdata/compassql/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/uwdata/compassql/statuses/4f230eb3bd16cd48c60e18ac0761d89454aece9a"}}}}
{"actor":{"display_login":"kanitw"}}