{"action":"closed","number":2377,"pull_request":{"url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2377","id":72348733,"html_url":"https://github.com/liqd/adhocracy3/pull/2377","diff_url":"https://github.com/liqd/adhocracy3/pull/2377.diff","patch_url":"https://github.com/liqd/adhocracy3/pull/2377.patch","issue_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2377","number":2377,"state":"closed","locked":false,"title":"renew 'customHeaders'","user":{"login":"der-john","id":16540898,"avatar_url":"https://avatars.githubusercontent.com/u/16540898?v=3","gravatar_id":"","url":"https://api.github.com/users/der-john","html_url":"https://github.com/der-john","followers_url":"https://api.github.com/users/der-john/followers","following_url":"https://api.github.com/users/der-john/following{/other_user}","gists_url":"https://api.github.com/users/der-john/gists{/gist_id}","starred_url":"https://api.github.com/users/der-john/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-john/subscriptions","organizations_url":"https://api.github.com/users/der-john/orgs","repos_url":"https://api.github.com/users/der-john/repos","events_url":"https://api.github.com/users/der-john/events{/privacy}","received_events_url":"https://api.github.com/users/der-john/received_events","type":"User","site_admin":false},"body":"This renews the refactoring achieved by #2113: The core of the issue is that @xi and I found out it was illogical to have `adhProcessProvider.templateFactories` and `adhResourceArea.customHeader`, which both customised something in a similar way depending only on the process type, but function differently and are at different places.\r\n\r\nSo here I suggest four things:\r\n\r\n- to replace the customHeader logic with logic that's completely analogous to `adhProcessProvider.templateFactories`,\r\n- call this logic `processButtonSlot`, because that's really the UI component that it regulates,\r\n- (129bb56) do away with the `AlexanderplatzAddProposalButton` - it's identical to `IdeaCollectionAddProposalButton`,\r\n- (0b7b101) move the `IdeaCollectionAddProposalButton` to Meinberlin/Proposal and simply call it `MeinberlinAddProposalButton`, since it's now the only one in meinberlin.","created_at":"2016-06-02T13:45:53Z","updated_at":"2016-06-08T08:36:57Z","closed_at":"2016-06-08T08:36:57Z","merged_at":null,"merge_commit_sha":"92ebb3d6382bc765422db7a767849997935fe9dd","assignee":{"login":"der-john","id":16540898,"avatar_url":"https://avatars.githubusercontent.com/u/16540898?v=3","gravatar_id":"","url":"https://api.github.com/users/der-john","html_url":"https://github.com/der-john","followers_url":"https://api.github.com/users/der-john/followers","following_url":"https://api.github.com/users/der-john/following{/other_user}","gists_url":"https://api.github.com/users/der-john/gists{/gist_id}","starred_url":"https://api.github.com/users/der-john/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-john/subscriptions","organizations_url":"https://api.github.com/users/der-john/orgs","repos_url":"https://api.github.com/users/der-john/repos","events_url":"https://api.github.com/users/der-john/events{/privacy}","received_events_url":"https://api.github.com/users/der-john/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2377/commits","review_comments_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2377/comments","review_comment_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2377/comments","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/129bb569bc0f744f808b1d7b54abd487c835e96b","head":{"label":"liqd:2016-06-js-process-button-slot","ref":"2016-06-js-process-button-slot","sha":"129bb569bc0f744f808b1d7b54abd487c835e96b","user":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"repo":{"id":22982974,"name":"adhocracy3","full_name":"liqd/adhocracy3","owner":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liqd/adhocracy3","description":"Adhocracy 3 with customizations for various projects","fork":false,"url":"https://api.github.com/repos/liqd/adhocracy3","forks_url":"https://api.github.com/repos/liqd/adhocracy3/forks","keys_url":"https://api.github.com/repos/liqd/adhocracy3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liqd/adhocracy3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liqd/adhocracy3/teams","hooks_url":"https://api.github.com/repos/liqd/adhocracy3/hooks","issue_events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/events{/number}","events_url":"https://api.github.com/repos/liqd/adhocracy3/events","assignees_url":"https://api.github.com/repos/liqd/adhocracy3/assignees{/user}","branches_url":"https://api.github.com/repos/liqd/adhocracy3/branches{/branch}","tags_url":"https://api.github.com/repos/liqd/adhocracy3/tags","blobs_url":"https://api.github.com/repos/liqd/adhocracy3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liqd/adhocracy3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liqd/adhocracy3/git/refs{/sha}","trees_url":"https://api.github.com/repos/liqd/adhocracy3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/{sha}","languages_url":"https://api.github.com/repos/liqd/adhocracy3/languages","stargazers_url":"https://api.github.com/repos/liqd/adhocracy3/stargazers","contributors_url":"https://api.github.com/repos/liqd/adhocracy3/contributors","subscribers_url":"https://api.github.com/repos/liqd/adhocracy3/subscribers","subscription_url":"https://api.github.com/repos/liqd/adhocracy3/subscription","commits_url":"https://api.github.com/repos/liqd/adhocracy3/commits{/sha}","git_commits_url":"https://api.github.com/repos/liqd/adhocracy3/git/commits{/sha}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/comments{/number}","issue_comment_url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments{/number}","contents_url":"https://api.github.com/repos/liqd/adhocracy3/contents/{+path}","compare_url":"https://api.github.com/repos/liqd/adhocracy3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liqd/adhocracy3/merges","archive_url":"https://api.github.com/repos/liqd/adhocracy3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liqd/adhocracy3/downloads","issues_url":"https://api.github.com/repos/liqd/adhocracy3/issues{/number}","pulls_url":"https://api.github.com/repos/liqd/adhocracy3/pulls{/number}","milestones_url":"https://api.github.com/repos/liqd/adhocracy3/milestones{/number}","notifications_url":"https://api.github.com/repos/liqd/adhocracy3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liqd/adhocracy3/labels{/name}","releases_url":"https://api.github.com/repos/liqd/adhocracy3/releases{/id}","deployments_url":"https://api.github.com/repos/liqd/adhocracy3/deployments","created_at":"2014-08-15T08:07:57Z","updated_at":"2016-06-07T10:43:37Z","pushed_at":"2016-06-08T03:50:41Z","git_url":"git://github.com/liqd/adhocracy3.git","ssh_url":"git@github.com:liqd/adhocracy3.git","clone_url":"https://github.com/liqd/adhocracy3.git","svn_url":"https://github.com/liqd/adhocracy3","homepage":"","size":24358,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":94,"forks":13,"open_issues":94,"watchers":44,"default_branch":"master"}},"base":{"label":"liqd:master","ref":"master","sha":"d48cfce236c6c71c883fb2d296084cb1f840ff29","user":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"repo":{"id":22982974,"name":"adhocracy3","full_name":"liqd/adhocracy3","owner":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liqd/adhocracy3","description":"Adhocracy 3 with customizations for various projects","fork":false,"url":"https://api.github.com/repos/liqd/adhocracy3","forks_url":"https://api.github.com/repos/liqd/adhocracy3/forks","keys_url":"https://api.github.com/repos/liqd/adhocracy3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liqd/adhocracy3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liqd/adhocracy3/teams","hooks_url":"https://api.github.com/repos/liqd/adhocracy3/hooks","issue_events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/events{/number}","events_url":"https://api.github.com/repos/liqd/adhocracy3/events","assignees_url":"https://api.github.com/repos/liqd/adhocracy3/assignees{/user}","branches_url":"https://api.github.com/repos/liqd/adhocracy3/branches{/branch}","tags_url":"https://api.github.com/repos/liqd/adhocracy3/tags","blobs_url":"https://api.github.com/repos/liqd/adhocracy3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liqd/adhocracy3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liqd/adhocracy3/git/refs{/sha}","trees_url":"https://api.github.com/repos/liqd/adhocracy3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/{sha}","languages_url":"https://api.github.com/repos/liqd/adhocracy3/languages","stargazers_url":"https://api.github.com/repos/liqd/adhocracy3/stargazers","contributors_url":"https://api.github.com/repos/liqd/adhocracy3/contributors","subscribers_url":"https://api.github.com/repos/liqd/adhocracy3/subscribers","subscription_url":"https://api.github.com/repos/liqd/adhocracy3/subscription","commits_url":"https://api.github.com/repos/liqd/adhocracy3/commits{/sha}","git_commits_url":"https://api.github.com/repos/liqd/adhocracy3/git/commits{/sha}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/comments{/number}","issue_comment_url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments{/number}","contents_url":"https://api.github.com/repos/liqd/adhocracy3/contents/{+path}","compare_url":"https://api.github.com/repos/liqd/adhocracy3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liqd/adhocracy3/merges","archive_url":"https://api.github.com/repos/liqd/adhocracy3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liqd/adhocracy3/downloads","issues_url":"https://api.github.com/repos/liqd/adhocracy3/issues{/number}","pulls_url":"https://api.github.com/repos/liqd/adhocracy3/pulls{/number}","milestones_url":"https://api.github.com/repos/liqd/adhocracy3/milestones{/number}","notifications_url":"https://api.github.com/repos/liqd/adhocracy3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liqd/adhocracy3/labels{/name}","releases_url":"https://api.github.com/repos/liqd/adhocracy3/releases{/id}","deployments_url":"https://api.github.com/repos/liqd/adhocracy3/deployments","created_at":"2014-08-15T08:07:57Z","updated_at":"2016-06-07T10:43:37Z","pushed_at":"2016-06-08T03:50:41Z","git_url":"git://github.com/liqd/adhocracy3.git","ssh_url":"git@github.com:liqd/adhocracy3.git","clone_url":"https://github.com/liqd/adhocracy3.git","svn_url":"https://github.com/liqd/adhocracy3","homepage":"","size":24358,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":94,"forks":13,"open_issues":94,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/2377"},"html":{"href":"https://github.com/liqd/adhocracy3/pull/2377"},"issue":{"href":"https://api.github.com/repos/liqd/adhocracy3/issues/2377"},"comments":{"href":"https://api.github.com/repos/liqd/adhocracy3/issues/2377/comments"},"review_comments":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/2377/comments"},"review_comment":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/2377/commits"},"statuses":{"href":"https://api.github.com/repos/liqd/adhocracy3/statuses/129bb569bc0f744f808b1d7b54abd487c835e96b"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":5,"commits":6,"additions":98,"deletions":89,"changed_files":27}}
{"actor":{"display_login":"der-john"}}