{"comment":{"url":"https://api.github.com/repos/aurelia/router/comments/15270323","html_url":"https://github.com/aurelia/router/commit/dbce60c37bc94e74ff7e279ae28b3b770b5ff764#commitcomment-15270323","id":15270323,"user":{"login":"davismj","id":3845823,"avatar_url":"https://avatars.githubusercontent.com/u/3845823?v=3","gravatar_id":"","url":"https://api.github.com/users/davismj","html_url":"https://github.com/davismj","followers_url":"https://api.github.com/users/davismj/followers","following_url":"https://api.github.com/users/davismj/following{/other_user}","gists_url":"https://api.github.com/users/davismj/gists{/gist_id}","starred_url":"https://api.github.com/users/davismj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davismj/subscriptions","organizations_url":"https://api.github.com/users/davismj/orgs","repos_url":"https://api.github.com/users/davismj/repos","events_url":"https://api.github.com/users/davismj/events{/privacy}","received_events_url":"https://api.github.com/users/davismj/received_events","type":"User","site_admin":false},"position":20,"line":31,"path":"src/app-router.js","commit_id":"dbce60c37bc94e74ff7e279ae28b3b770b5ff764","created_at":"2016-01-05T17:29:11Z","updated_at":"2016-01-05T17:29:11Z","body":"If anything has assigned queue referrentially (`binding.value = router._queue`), this reference is to the array you've replaced on line 31. Not only is it a memory leak, as the old queue array will remain in memory, but it may also produce unwanted behavior. \r\n\r\n`this._queue.splice(0,Infinity)` simply clears the array without instantiating a new array. There is no potential for memory leak or unwanted side effects."}}