{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/70087779","id":70087779,"diff_hunk":"@@ -82,14 +82,13 @@ def initialize(config_str, settings = LogStash::SETTINGS, namespaced_metric = ni\n       raise\n     end\n \n-    @input_queue = LogStash::Util::WrappedSynchronousQueue.new\n+    queue = LogStash::Util::WrappedSynchronousQueue.new\n+    @input_queue_client = queue.write_client\n+    @filter_queue_client = queue.read_client","path":"logstash-core/lib/logstash/pipeline.rb","position":46,"original_position":46,"commit_id":"f22a56bb60e7800b7789949e5408e7c8c7990032","original_commit_id":"f22a56bb60e7800b7789949e5408e7c8c7990032","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"The client is an adapter that presents one API to the each side of any given queue implementation. There also may be different concerns regarding batching and thread-safety guarantees between read and write that may complicate a dual purpose client. Further, separate clients guarantee that an input can't read an event from the queue and a worker can't write an event to the queue - which suits our current requirements.\r\n\r\nThe DLQ client, for example, should only be able to write events out.\r\n\r\nIt is possible to have per input client instances and each instance may post metrics on that input's interaction with the queue without the input needing to know or do this.\r\n\r\nBut given that a batch is isolated to a worker thread then that thread's interaction with the queue to retrieve a batch can post metrics on a per thread per batch basis.\r\n\r\nIn this PR the batch metrics are thread anonymous - that can be a future enhancement.","created_at":"2016-07-08T15:01:03Z","updated_at":"2016-07-08T15:01:03Z","html_url":"https://github.com/elastic/logstash/pull/5560#discussion_r70087779","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/5560","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/70087779"},"html":{"href":"https://github.com/elastic/logstash/pull/5560#discussion_r70087779"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/5560","id":75493186,"html_url":"https://github.com/elastic/logstash/pull/5560","diff_url":"https://github.com/elastic/logstash/pull/5560.diff","patch_url":"https://github.com/elastic/logstash/pull/5560.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5560","number":5560,"state":"open","locked":false,"title":"Add queue client support (and batch object) to pipeline","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"Following discussion, this is WrappedSynchronousQueue Client support classes proposal.","created_at":"2016-06-28T15:01:32Z","updated_at":"2016-07-08T15:01:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae654fa5274faeb529568e76edec7d728f548fc2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/5560/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/5560/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5560/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/f22a56bb60e7800b7789949e5408e7c8c7990032","head":{"label":"guyboertje:fix/5525","ref":"fix/5525","sha":"f22a56bb60e7800b7789949e5408e7c8c7990032","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"repo":{"id":44548170,"name":"logstash","full_name":"guyboertje/logstash","owner":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guyboertje/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/guyboertje/logstash","forks_url":"https://api.github.com/repos/guyboertje/logstash/forks","keys_url":"https://api.github.com/repos/guyboertje/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guyboertje/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guyboertje/logstash/teams","hooks_url":"https://api.github.com/repos/guyboertje/logstash/hooks","issue_events_url":"https://api.github.com/repos/guyboertje/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/guyboertje/logstash/events","assignees_url":"https://api.github.com/repos/guyboertje/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/guyboertje/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/guyboertje/logstash/tags","blobs_url":"https://api.github.com/repos/guyboertje/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guyboertje/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guyboertje/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/guyboertje/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guyboertje/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/guyboertje/logstash/languages","stargazers_url":"https://api.github.com/repos/guyboertje/logstash/stargazers","contributors_url":"https://api.github.com/repos/guyboertje/logstash/contributors","subscribers_url":"https://api.github.com/repos/guyboertje/logstash/subscribers","subscription_url":"https://api.github.com/repos/guyboertje/logstash/subscription","commits_url":"https://api.github.com/repos/guyboertje/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/guyboertje/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/guyboertje/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/guyboertje/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/guyboertje/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/guyboertje/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guyboertje/logstash/merges","archive_url":"https://api.github.com/repos/guyboertje/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guyboertje/logstash/downloads","issues_url":"https://api.github.com/repos/guyboertje/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/guyboertje/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/guyboertje/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/guyboertje/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guyboertje/logstash/labels{/name}","releases_url":"https://api.github.com/repos/guyboertje/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/guyboertje/logstash/deployments","created_at":"2015-10-19T16:26:52Z","updated_at":"2016-01-12T15:34:23Z","pushed_at":"2016-07-08T14:44:56Z","git_url":"git://github.com/guyboertje/logstash.git","ssh_url":"git@github.com:guyboertje/logstash.git","clone_url":"https://github.com/guyboertje/logstash.git","svn_url":"https://github.com/guyboertje/logstash","homepage":"https://www.elastic.co/products/logstash","size":76074,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"1fa83b99dd9dd7e1548ad4d9f79d75c63c3efd7c","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-07-08T14:43:29Z","pushed_at":"2016-07-08T14:31:59Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":89014,"stargazers_count":6126,"watchers_count":6126,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1825,"mirror_url":null,"open_issues_count":780,"forks":1825,"open_issues":780,"watchers":6126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560"},"html":{"href":"https://github.com/elastic/logstash/pull/5560"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/5560"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/5560/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5560/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/f22a56bb60e7800b7789949e5408e7c8c7990032"}}}}
{"actor":{"display_login":"guyboertje"}}