{"action":"created","comment":{"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments/84484029","pull_request_review_id":5261026,"id":84484029,"diff_hunk":"@@ -20,18 +19,44 @@ set(CXX_STANDARD_REQUIRED ON)\n set(CMAKE_CXX_STANDARD 14)\n \n if(LUG_COMPILER_MSVC)\n-    if(CMAKE_CXX_FLAGS MATCHES \"/W[0-4]\")\n-        string(REGEX REPLACE \"/W[0-4]\" \"/W4\" CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS}\")\n-    else()\n-        list(APPEND CMAKE_CXX_FLAGS \"/W4\")\n-    endif()\n+   if(CMAKE_CXX_FLAGS MATCHES \"/W[0-4]\")\n+       string(REGEX REPLACE \"/W[0-4]\" \"/W4\" CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS}\")\n+   else()\n+       list(APPEND CMAKE_CXX_FLAGS \"/W4\")\n+   endif()\n elseif(LUG_COMPILER_GCC OR LUG_COMPILER_CLANG)\n-    list(APPEND CMAKE_CXX_FLAGS \"-Wall -Wextra -Werror\")\n+   list(APPEND CMAKE_CXX_FLAGS \"-Wall -Wextra\")\n+    if(LUG_OS_ANDROID)\n+        list(APPEND CMAKE_CXX_FLAGS \"-std=c++14\")\n+        string(REPLACE \";\" \" \" \"CMAKE_CXX_FLAGS\" \"${CMAKE_CXX_FLAGS}\")\n+    endif()\n+endif()\n+\n+if(ANDROID_NATIVE_API_LEVEL EQUAL 23)\n+    set(LUG_STATIC_LIBRARIES true)\n endif()\n \n+\n # find Lugdunum and link with it\n-find_package(LUG REQUIRED system)\n-if(LUG_FOUND)\n-    include_directories(${LUG_INCLUDE_DIR})\n+find_package(LUG REQUIRED)","path":"samples/base/CMakeLists.txt","position":40,"original_position":40,"commit_id":"b18f21e8306e85120fdacfd5bc725c92a132eb0d","original_commit_id":"b18f21e8306e85120fdacfd5bc725c92a132eb0d","user":{"login":"saveman71","id":1615426,"avatar_url":"https://avatars.githubusercontent.com/u/1615426?v=3","gravatar_id":"","url":"https://api.github.com/users/saveman71","html_url":"https://github.com/saveman71","followers_url":"https://api.github.com/users/saveman71/followers","following_url":"https://api.github.com/users/saveman71/following{/other_user}","gists_url":"https://api.github.com/users/saveman71/gists{/gist_id}","starred_url":"https://api.github.com/users/saveman71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saveman71/subscriptions","organizations_url":"https://api.github.com/users/saveman71/orgs","repos_url":"https://api.github.com/users/saveman71/repos","events_url":"https://api.github.com/users/saveman71/events{/privacy}","received_events_url":"https://api.github.com/users/saveman71/received_events","type":"User","site_admin":false},"body":"And why? Currently the sample doesn't use any functionality from system.","created_at":"2016-10-21T13:57:42Z","updated_at":"2016-10-21T13:57:42Z","html_url":"https://github.com/Lugdunum3D/Lugdunum/pull/7#discussion_r84484029","pull_request_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments/84484029"},"html":{"href":"https://github.com/Lugdunum3D/Lugdunum/pull/7#discussion_r84484029"},"pull_request":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7","id":89096212,"html_url":"https://github.com/Lugdunum3D/Lugdunum/pull/7","diff_url":"https://github.com/Lugdunum3D/Lugdunum/pull/7.diff","patch_url":"https://github.com/Lugdunum3D/Lugdunum/pull/7.patch","issue_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/7","number":7,"state":"open","locked":false,"title":"Build process android","user":{"login":"Sumenia","id":6384877,"avatar_url":"https://avatars.githubusercontent.com/u/6384877?v=3","gravatar_id":"","url":"https://api.github.com/users/Sumenia","html_url":"https://github.com/Sumenia","followers_url":"https://api.github.com/users/Sumenia/followers","following_url":"https://api.github.com/users/Sumenia/following{/other_user}","gists_url":"https://api.github.com/users/Sumenia/gists{/gist_id}","starred_url":"https://api.github.com/users/Sumenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sumenia/subscriptions","organizations_url":"https://api.github.com/users/Sumenia/orgs","repos_url":"https://api.github.com/users/Sumenia/repos","events_url":"https://api.github.com/users/Sumenia/events{/privacy}","received_events_url":"https://api.github.com/users/Sumenia/received_events","type":"User","site_admin":false},"body":"This is the build process working for android Marshmallow and Nougat.\nfindLug doesn’t work within gradle so having lugdunum library install\nin android/app/src/main/lugdunum is mandatory\n\nDue to dynamic library dependancy policy in Android M, building\nLugdunum in static is mandatory.\n\nalso :\nI removed weird broken ascii spaces across the project\nFixed the README.md","created_at":"2016-10-12T21:20:21Z","updated_at":"2016-10-21T13:57:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a30f9c1a5530ea9821423dd0ebda0f5236c2ecd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/7/comments","statuses_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/b18f21e8306e85120fdacfd5bc725c92a132eb0d","head":{"label":"Lugdunum3D:featue-build-process-android","ref":"featue-build-process-android","sha":"b18f21e8306e85120fdacfd5bc725c92a132eb0d","user":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"repo":{"id":69289273,"name":"Lugdunum","full_name":"Lugdunum3D/Lugdunum","owner":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lugdunum3D/Lugdunum","description":"A game engine think with Vulkan API in mind from scratch","fork":false,"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum","forks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/forks","keys_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/teams","hooks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/hooks","issue_events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/events{/number}","events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/events","assignees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/assignees{/user}","branches_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/branches{/branch}","tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/tags","blobs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/{sha}","languages_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/languages","stargazers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/stargazers","contributors_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contributors","subscribers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscribers","subscription_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscription","commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contents/{+path}","compare_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/merges","archive_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/downloads","issues_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues{/number}","pulls_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls{/number}","milestones_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/milestones{/number}","notifications_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/labels{/name}","releases_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/releases{/id}","deployments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/deployments","created_at":"2016-09-26T20:18:40Z","updated_at":"2016-10-14T19:22:18Z","pushed_at":"2016-10-21T13:35:35Z","git_url":"git://github.com/Lugdunum3D/Lugdunum.git","ssh_url":"git@github.com:Lugdunum3D/Lugdunum.git","clone_url":"https://github.com/Lugdunum3D/Lugdunum.git","svn_url":"https://github.com/Lugdunum3D/Lugdunum","homepage":null,"size":201,"stargazers_count":3,"watchers_count":3,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"Lugdunum3D:dev","ref":"dev","sha":"baf1fe65b29f97aa9a14712a502a283bdec191c6","user":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"repo":{"id":69289273,"name":"Lugdunum","full_name":"Lugdunum3D/Lugdunum","owner":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lugdunum3D/Lugdunum","description":"A game engine think with Vulkan API in mind from scratch","fork":false,"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum","forks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/forks","keys_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/teams","hooks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/hooks","issue_events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/events{/number}","events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/events","assignees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/assignees{/user}","branches_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/branches{/branch}","tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/tags","blobs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/{sha}","languages_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/languages","stargazers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/stargazers","contributors_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contributors","subscribers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscribers","subscription_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscription","commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contents/{+path}","compare_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/merges","archive_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/downloads","issues_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues{/number}","pulls_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls{/number}","milestones_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/milestones{/number}","notifications_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/labels{/name}","releases_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/releases{/id}","deployments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/deployments","created_at":"2016-09-26T20:18:40Z","updated_at":"2016-10-14T19:22:18Z","pushed_at":"2016-10-21T13:35:35Z","git_url":"git://github.com/Lugdunum3D/Lugdunum.git","ssh_url":"git@github.com:Lugdunum3D/Lugdunum.git","clone_url":"https://github.com/Lugdunum3D/Lugdunum.git","svn_url":"https://github.com/Lugdunum3D/Lugdunum","homepage":null,"size":201,"stargazers_count":3,"watchers_count":3,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7"},"html":{"href":"https://github.com/Lugdunum3D/Lugdunum/pull/7"},"issue":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/7"},"comments":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/b18f21e8306e85120fdacfd5bc725c92a132eb0d"}}}}
{"actor":{"display_login":"saveman71"}}