{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11246","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11246/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11246/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11246/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11246","id":176851949,"number":11246,"title":"Remove toast when marking/deleting notification from the drawer","user":{"login":"skateman","id":649130,"avatar_url":"https://avatars.githubusercontent.com/u/649130?v=3","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-14T08:58:03Z","updated_at":"2016-09-14T10:41:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11246","html_url":"https://github.com/ManageIQ/manageiq/pull/11246","diff_url":"https://github.com/ManageIQ/manageiq/pull/11246.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11246.patch"},"body":"When a notification is removed/marked as read, its toast pair needs to be dismissed.\r\n\r\n**Before:**\r\n![before](https://cloud.githubusercontent.com/assets/649130/18505951/f426fece-7a69-11e6-9373-9105439cc8f0.gif)\r\n\r\n**After:**\r\n![after](https://cloud.githubusercontent.com/assets/649130/18505957/f8637026-7a69-11e6-81be-c337a9887f63.gif)\r\n\r\n@jeff-phillips-18 "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/246973842","html_url":"https://github.com/ManageIQ/manageiq/pull/11246#issuecomment-246973842","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11246","id":246973842,"user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T10:41:57Z","updated_at":"2016-09-14T10:41:57Z","body":"Changes look good but I noticed that in the removeToast function notifyObservers is called even when the notification is not found in the current toast list. It should only be called if the toast list is modified."}}
{"actor":{"display_login":"jeff-phillips-18"}}