{"action":"created","comment":{"url":"https://api.github.com/repos/vega/lyra/pulls/comments/59430520","id":59430520,"diff_hunk":"@@ -72,12 +73,16 @@ var Group = connect(\n     return iconMarkup;\n   },\n   deleteUpdate: function(id) {\n+    ReactTooltip.hide();\n     this.deleteMark(id);\n     // set selected to null\n     this.props.select(null);\n     // redraw sidebar\n     this.updateSidebar();\n   },\n+  componentWillUnmount: function(){\n+    ReactTooltip.hide();\n+  },","path":"src/js/components/visualization/GroupSubMenu.jsx","position":21,"original_position":21,"commit_id":"be6d0df4d8e5b118796791383bfe43fb6b0d92ed","original_commit_id":"be6d0df4d8e5b118796791383bfe43fb6b0d92ed","user":{"login":"deathbearbrown","id":607541,"avatar_url":"https://avatars.githubusercontent.com/u/607541?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbearbrown","html_url":"https://github.com/deathbearbrown","followers_url":"https://api.github.com/users/deathbearbrown/followers","following_url":"https://api.github.com/users/deathbearbrown/following{/other_user}","gists_url":"https://api.github.com/users/deathbearbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbearbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbearbrown/subscriptions","organizations_url":"https://api.github.com/users/deathbearbrown/orgs","repos_url":"https://api.github.com/users/deathbearbrown/repos","events_url":"https://api.github.com/users/deathbearbrown/events{/privacy}","received_events_url":"https://api.github.com/users/deathbearbrown/received_events","type":"User","site_admin":false},"body":"No because the inner marks are created through a loop that makes the HTML. So when the loop is modified it doesn't actually unmount this component. ","created_at":"2016-04-12T18:40:31Z","updated_at":"2016-04-12T18:40:32Z","html_url":"https://github.com/vega/lyra/pull/340#discussion_r59430520","pull_request_url":"https://api.github.com/repos/vega/lyra/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/vega/lyra/pulls/comments/59430520"},"html":{"href":"https://github.com/vega/lyra/pull/340#discussion_r59430520"},"pull_request":{"href":"https://api.github.com/repos/vega/lyra/pulls/340"}}},"pull_request":{"url":"https://api.github.com/repos/vega/lyra/pulls/340","id":66205514,"html_url":"https://github.com/vega/lyra/pull/340","diff_url":"https://github.com/vega/lyra/pull/340.diff","patch_url":"https://github.com/vega/lyra/pull/340.patch","issue_url":"https://api.github.com/repos/vega/lyra/issues/340","number":340,"state":"open","locked":false,"title":"close tooltip on delete","user":{"login":"deathbearbrown","id":607541,"avatar_url":"https://avatars.githubusercontent.com/u/607541?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbearbrown","html_url":"https://github.com/deathbearbrown","followers_url":"https://api.github.com/users/deathbearbrown/followers","following_url":"https://api.github.com/users/deathbearbrown/following{/other_user}","gists_url":"https://api.github.com/users/deathbearbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbearbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbearbrown/subscriptions","organizations_url":"https://api.github.com/users/deathbearbrown/orgs","repos_url":"https://api.github.com/users/deathbearbrown/repos","events_url":"https://api.github.com/users/deathbearbrown/events{/privacy}","received_events_url":"https://api.github.com/users/deathbearbrown/received_events","type":"User","site_admin":false},"body":"When a mark was deleted from the visualization sidebar, the tool tip wouldn't disapear. \r\n\r\nChanges proposed in this pull request:\r\n- remove the tooltip on delete\r\n- also remove the tooltip on unmount of the component (to be double safe) \r\n\r\n\r\n**Steps to functionally test this:**\r\n\r\n1. make a group\r\n2. delete it\r\n3. tooltip should disappear\r\n\r\n\r\n-----\r\n\r\n1. make a group\r\n2. put a mark in the group\r\n3. delete the mark in the group\r\n4. tooltip should disappear\r\n\r\n","created_at":"2016-04-12T18:31:28Z","updated_at":"2016-04-12T18:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cbc217a866dafb4ed5b127762c3f095be8b45b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vega/lyra/pulls/340/commits","review_comments_url":"https://api.github.com/repos/vega/lyra/pulls/340/comments","review_comment_url":"https://api.github.com/repos/vega/lyra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/lyra/issues/340/comments","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/be6d0df4d8e5b118796791383bfe43fb6b0d92ed","head":{"label":"deathbearbrown:unmount-deleted","ref":"unmount-deleted","sha":"be6d0df4d8e5b118796791383bfe43fb6b0d92ed","user":{"login":"deathbearbrown","id":607541,"avatar_url":"https://avatars.githubusercontent.com/u/607541?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbearbrown","html_url":"https://github.com/deathbearbrown","followers_url":"https://api.github.com/users/deathbearbrown/followers","following_url":"https://api.github.com/users/deathbearbrown/following{/other_user}","gists_url":"https://api.github.com/users/deathbearbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbearbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbearbrown/subscriptions","organizations_url":"https://api.github.com/users/deathbearbrown/orgs","repos_url":"https://api.github.com/users/deathbearbrown/repos","events_url":"https://api.github.com/users/deathbearbrown/events{/privacy}","received_events_url":"https://api.github.com/users/deathbearbrown/received_events","type":"User","site_admin":false},"repo":{"id":52285428,"name":"lyra","full_name":"deathbearbrown/lyra","owner":{"login":"deathbearbrown","id":607541,"avatar_url":"https://avatars.githubusercontent.com/u/607541?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbearbrown","html_url":"https://github.com/deathbearbrown","followers_url":"https://api.github.com/users/deathbearbrown/followers","following_url":"https://api.github.com/users/deathbearbrown/following{/other_user}","gists_url":"https://api.github.com/users/deathbearbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbearbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbearbrown/subscriptions","organizations_url":"https://api.github.com/users/deathbearbrown/orgs","repos_url":"https://api.github.com/users/deathbearbrown/repos","events_url":"https://api.github.com/users/deathbearbrown/events{/privacy}","received_events_url":"https://api.github.com/users/deathbearbrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deathbearbrown/lyra","description":"An interactive, graphical Visualization Design Environment (VDE)","fork":true,"url":"https://api.github.com/repos/deathbearbrown/lyra","forks_url":"https://api.github.com/repos/deathbearbrown/lyra/forks","keys_url":"https://api.github.com/repos/deathbearbrown/lyra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deathbearbrown/lyra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deathbearbrown/lyra/teams","hooks_url":"https://api.github.com/repos/deathbearbrown/lyra/hooks","issue_events_url":"https://api.github.com/repos/deathbearbrown/lyra/issues/events{/number}","events_url":"https://api.github.com/repos/deathbearbrown/lyra/events","assignees_url":"https://api.github.com/repos/deathbearbrown/lyra/assignees{/user}","branches_url":"https://api.github.com/repos/deathbearbrown/lyra/branches{/branch}","tags_url":"https://api.github.com/repos/deathbearbrown/lyra/tags","blobs_url":"https://api.github.com/repos/deathbearbrown/lyra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deathbearbrown/lyra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deathbearbrown/lyra/git/refs{/sha}","trees_url":"https://api.github.com/repos/deathbearbrown/lyra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deathbearbrown/lyra/statuses/{sha}","languages_url":"https://api.github.com/repos/deathbearbrown/lyra/languages","stargazers_url":"https://api.github.com/repos/deathbearbrown/lyra/stargazers","contributors_url":"https://api.github.com/repos/deathbearbrown/lyra/contributors","subscribers_url":"https://api.github.com/repos/deathbearbrown/lyra/subscribers","subscription_url":"https://api.github.com/repos/deathbearbrown/lyra/subscription","commits_url":"https://api.github.com/repos/deathbearbrown/lyra/commits{/sha}","git_commits_url":"https://api.github.com/repos/deathbearbrown/lyra/git/commits{/sha}","comments_url":"https://api.github.com/repos/deathbearbrown/lyra/comments{/number}","issue_comment_url":"https://api.github.com/repos/deathbearbrown/lyra/issues/comments{/number}","contents_url":"https://api.github.com/repos/deathbearbrown/lyra/contents/{+path}","compare_url":"https://api.github.com/repos/deathbearbrown/lyra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deathbearbrown/lyra/merges","archive_url":"https://api.github.com/repos/deathbearbrown/lyra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deathbearbrown/lyra/downloads","issues_url":"https://api.github.com/repos/deathbearbrown/lyra/issues{/number}","pulls_url":"https://api.github.com/repos/deathbearbrown/lyra/pulls{/number}","milestones_url":"https://api.github.com/repos/deathbearbrown/lyra/milestones{/number}","notifications_url":"https://api.github.com/repos/deathbearbrown/lyra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deathbearbrown/lyra/labels{/name}","releases_url":"https://api.github.com/repos/deathbearbrown/lyra/releases{/id}","deployments_url":"https://api.github.com/repos/deathbearbrown/lyra/deployments","created_at":"2016-02-22T16:00:56Z","updated_at":"2016-02-22T16:00:58Z","pushed_at":"2016-04-12T18:28:26Z","git_url":"git://github.com/deathbearbrown/lyra.git","ssh_url":"git@github.com:deathbearbrown/lyra.git","clone_url":"https://github.com/deathbearbrown/lyra.git","svn_url":"https://github.com/deathbearbrown/lyra","homepage":"http://idl.cs.washington.edu/projects/lyra/","size":7721,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vega:lyra2","ref":"lyra2","sha":"e1e5ea18d69d18f4224d0a766791187bdfcb8f4f","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":6179334,"name":"lyra","full_name":"vega/lyra","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/lyra","description":"An interactive, graphical Visualization Design Environment (VDE)","fork":false,"url":"https://api.github.com/repos/vega/lyra","forks_url":"https://api.github.com/repos/vega/lyra/forks","keys_url":"https://api.github.com/repos/vega/lyra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/lyra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/lyra/teams","hooks_url":"https://api.github.com/repos/vega/lyra/hooks","issue_events_url":"https://api.github.com/repos/vega/lyra/issues/events{/number}","events_url":"https://api.github.com/repos/vega/lyra/events","assignees_url":"https://api.github.com/repos/vega/lyra/assignees{/user}","branches_url":"https://api.github.com/repos/vega/lyra/branches{/branch}","tags_url":"https://api.github.com/repos/vega/lyra/tags","blobs_url":"https://api.github.com/repos/vega/lyra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/lyra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/lyra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/lyra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/lyra/languages","stargazers_url":"https://api.github.com/repos/vega/lyra/stargazers","contributors_url":"https://api.github.com/repos/vega/lyra/contributors","subscribers_url":"https://api.github.com/repos/vega/lyra/subscribers","subscription_url":"https://api.github.com/repos/vega/lyra/subscription","commits_url":"https://api.github.com/repos/vega/lyra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/lyra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/lyra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/lyra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/lyra/contents/{+path}","compare_url":"https://api.github.com/repos/vega/lyra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/lyra/merges","archive_url":"https://api.github.com/repos/vega/lyra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/lyra/downloads","issues_url":"https://api.github.com/repos/vega/lyra/issues{/number}","pulls_url":"https://api.github.com/repos/vega/lyra/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/lyra/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/lyra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/lyra/labels{/name}","releases_url":"https://api.github.com/repos/vega/lyra/releases{/id}","deployments_url":"https://api.github.com/repos/vega/lyra/deployments","created_at":"2012-10-11T19:16:35Z","updated_at":"2016-04-11T00:55:03Z","pushed_at":"2016-04-12T18:32:18Z","git_url":"git://github.com/vega/lyra.git","ssh_url":"git@github.com:vega/lyra.git","clone_url":"https://github.com/vega/lyra.git","svn_url":"https://github.com/vega/lyra","homepage":"http://idl.cs.washington.edu/projects/lyra/","size":7898,"stargazers_count":579,"watchers_count":579,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":102,"mirror_url":null,"open_issues_count":63,"forks":102,"open_issues":63,"watchers":579,"default_branch":"lyra2"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/lyra/pulls/340"},"html":{"href":"https://github.com/vega/lyra/pull/340"},"issue":{"href":"https://api.github.com/repos/vega/lyra/issues/340"},"comments":{"href":"https://api.github.com/repos/vega/lyra/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/lyra/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/lyra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/lyra/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/vega/lyra/statuses/be6d0df4d8e5b118796791383bfe43fb6b0d92ed"}}}}