{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/70405170","id":70405170,"diff_hunk":"@@ -328,8 +373,10 @@ uct_posix_alloc(uct_md_h md, size_t *length_p, ucs_ternary_value_t hugetlb,\n \n out_ok:\n     ucs_free(file_name);\n-    /* closing the shm_fd here won't unmap the mem region*/\n-    close(shm_fd);\n+    if (posix_config->use_proc_link == 0) {","path":"src/uct/sm/mm/mm_posix.c","position":110,"original_position":110,"commit_id":"64ac44bd38055eca006b3265dfea89c0c9ff50b1","original_commit_id":"64ac44bd38055eca006b3265dfea89c0c9ff50b1","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars.githubusercontent.com/u/2255631?v=3","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"`if (!posix_config->use_proc_link) {`","created_at":"2016-07-12T09:29:25Z","updated_at":"2016-07-12T09:29:25Z","html_url":"https://github.com/openucx/ucx/pull/871#discussion_r70405170","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/871","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/70405170"},"html":{"href":"https://github.com/openucx/ucx/pull/871#discussion_r70405170"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/871"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/871","id":76210981,"html_url":"https://github.com/openucx/ucx/pull/871","diff_url":"https://github.com/openucx/ucx/pull/871.diff","patch_url":"https://github.com/openucx/ucx/pull/871.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/871","number":871,"state":"open","locked":false,"title":"UCT/SM: pass /proc/<pid>/fd/<fd> instead of path for posix shared mem…","user":{"login":"xinzhao3","id":16946816,"avatar_url":"https://avatars.githubusercontent.com/u/16946816?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzhao3","html_url":"https://github.com/xinzhao3","followers_url":"https://api.github.com/users/xinzhao3/followers","following_url":"https://api.github.com/users/xinzhao3/following{/other_user}","gists_url":"https://api.github.com/users/xinzhao3/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzhao3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzhao3/subscriptions","organizations_url":"https://api.github.com/users/xinzhao3/orgs","repos_url":"https://api.github.com/users/xinzhao3/repos","events_url":"https://api.github.com/users/xinzhao3/events{/privacy}","received_events_url":"https://api.github.com/users/xinzhao3/received_events","type":"User","site_admin":false},"body":"…ory.\r\n\r\nOriginally in posix shared memory implementation, every process passes\r\na path to open shared memory file. This has the problem of stale files\r\nwhen the host process exits early. To avoid this, in the patch, we pass\r\n/proc/<pid>/fd/<fd> instead of path on each process, and does following:\r\n\r\n1. Each process opens its own posix file\r\n2. Each process immediately unlinks it (but keeps it open)\r\n3. Each process mmaps the file\r\n4. Let other processes open /proc/<pid>/fd/<fd> and mmap to it\r\n5. In case of exit, the file will be automatically deleted, because no\r\n   directory entry points to it\r\n\r\nfixes #718","created_at":"2016-07-05T02:17:01Z","updated_at":"2016-07-12T09:29:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c345aa6607e2991ee4c44d014a29790cd012438d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/871/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/871/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/871/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/64ac44bd38055eca006b3265dfea89c0c9ff50b1","head":{"label":"xinzhao3:topic/bugfix_718","ref":"topic/bugfix_718","sha":"64ac44bd38055eca006b3265dfea89c0c9ff50b1","user":{"login":"xinzhao3","id":16946816,"avatar_url":"https://avatars.githubusercontent.com/u/16946816?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzhao3","html_url":"https://github.com/xinzhao3","followers_url":"https://api.github.com/users/xinzhao3/followers","following_url":"https://api.github.com/users/xinzhao3/following{/other_user}","gists_url":"https://api.github.com/users/xinzhao3/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzhao3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzhao3/subscriptions","organizations_url":"https://api.github.com/users/xinzhao3/orgs","repos_url":"https://api.github.com/users/xinzhao3/repos","events_url":"https://api.github.com/users/xinzhao3/events{/privacy}","received_events_url":"https://api.github.com/users/xinzhao3/received_events","type":"User","site_admin":false},"repo":{"id":61566172,"name":"ucx","full_name":"xinzhao3/ucx","owner":{"login":"xinzhao3","id":16946816,"avatar_url":"https://avatars.githubusercontent.com/u/16946816?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzhao3","html_url":"https://github.com/xinzhao3","followers_url":"https://api.github.com/users/xinzhao3/followers","following_url":"https://api.github.com/users/xinzhao3/following{/other_user}","gists_url":"https://api.github.com/users/xinzhao3/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzhao3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzhao3/subscriptions","organizations_url":"https://api.github.com/users/xinzhao3/orgs","repos_url":"https://api.github.com/users/xinzhao3/repos","events_url":"https://api.github.com/users/xinzhao3/events{/privacy}","received_events_url":"https://api.github.com/users/xinzhao3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xinzhao3/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/xinzhao3/ucx","forks_url":"https://api.github.com/repos/xinzhao3/ucx/forks","keys_url":"https://api.github.com/repos/xinzhao3/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xinzhao3/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xinzhao3/ucx/teams","hooks_url":"https://api.github.com/repos/xinzhao3/ucx/hooks","issue_events_url":"https://api.github.com/repos/xinzhao3/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/xinzhao3/ucx/events","assignees_url":"https://api.github.com/repos/xinzhao3/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/xinzhao3/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/xinzhao3/ucx/tags","blobs_url":"https://api.github.com/repos/xinzhao3/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xinzhao3/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xinzhao3/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/xinzhao3/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xinzhao3/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/xinzhao3/ucx/languages","stargazers_url":"https://api.github.com/repos/xinzhao3/ucx/stargazers","contributors_url":"https://api.github.com/repos/xinzhao3/ucx/contributors","subscribers_url":"https://api.github.com/repos/xinzhao3/ucx/subscribers","subscription_url":"https://api.github.com/repos/xinzhao3/ucx/subscription","commits_url":"https://api.github.com/repos/xinzhao3/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/xinzhao3/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/xinzhao3/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/xinzhao3/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/xinzhao3/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/xinzhao3/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xinzhao3/ucx/merges","archive_url":"https://api.github.com/repos/xinzhao3/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xinzhao3/ucx/downloads","issues_url":"https://api.github.com/repos/xinzhao3/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/xinzhao3/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/xinzhao3/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/xinzhao3/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xinzhao3/ucx/labels{/name}","releases_url":"https://api.github.com/repos/xinzhao3/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/xinzhao3/ucx/deployments","created_at":"2016-06-20T17:15:58Z","updated_at":"2016-06-20T17:16:00Z","pushed_at":"2016-07-11T19:45:53Z","git_url":"git://github.com/xinzhao3/ucx.git","ssh_url":"git@github.com:xinzhao3/ucx.git","clone_url":"https://github.com/xinzhao3/ucx.git","svn_url":"https://github.com/xinzhao3/ucx","homepage":" http://www.openucx.org","size":5620,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"1590f9e0dde4aa8dc8b784ce8a7b9abfdfc7b123","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2016-07-07T15:08:42Z","pushed_at":"2016-07-12T09:25:23Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":7435,"stargazers_count":40,"watchers_count":40,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":73,"forks":39,"open_issues":73,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/871"},"html":{"href":"https://github.com/openucx/ucx/pull/871"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/871"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/871/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/871/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/871/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/64ac44bd38055eca006b3265dfea89c0c9ff50b1"}}}}
{"actor":{"display_login":"yosefe"}}