{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/88068061","pull_request_review_id":8653282,"id":88068061,"diff_hunk":"@@ -37,12 +40,14 @@ Mount the host's `/etc/resolv.conf` file directly into the container in order to\n \n ```ini\n [Service]\n-Environment=\"RKT_OPTS=--volume=resolv,kind=host,source=/etc/resolv.conf --mount volume=resolv,target=/etc/resolv.conf\"\n+Environment=\"RKT_OPTS=--volume=resolv,kind=host,source=/etc/resolv.conf --mount volume=resolv,target=/etc/resolv.conf \\","path":"Documentation/kubelet-wrapper.md","position":18,"original_position":18,"commit_id":"3d2e7fbad5d7ffa4cd4aeebc0ee594fc44015d8d","original_commit_id":"3d2e7fbad5d7ffa4cd4aeebc0ee594fc44015d8d","user":{"login":"aaronlevy","id":374924,"avatar_url":"https://avatars.githubusercontent.com/u/374924?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlevy","html_url":"https://github.com/aaronlevy","followers_url":"https://api.github.com/users/aaronlevy/followers","following_url":"https://api.github.com/users/aaronlevy/following{/other_user}","gists_url":"https://api.github.com/users/aaronlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlevy/subscriptions","organizations_url":"https://api.github.com/users/aaronlevy/orgs","repos_url":"https://api.github.com/users/aaronlevy/repos","events_url":"https://api.github.com/users/aaronlevy/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlevy/received_events","type":"User","site_admin":false},"body":"Can you split this line to make it a bit more readable?","created_at":"2016-11-15T17:26:23Z","updated_at":"2016-11-15T17:26:23Z","html_url":"https://github.com/coreos/coreos-kubernetes/pull/759#discussion_r88068061","pull_request_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/88068061"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/759#discussion_r88068061"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759","id":93668317,"html_url":"https://github.com/coreos/coreos-kubernetes/pull/759","diff_url":"https://github.com/coreos/coreos-kubernetes/pull/759.diff","patch_url":"https://github.com/coreos/coreos-kubernetes/pull/759.patch","issue_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/759","number":759,"state":"open","locked":false,"title":"kubelet-wrapper: delete old pods on start","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"See discussion in https://github.com/coreos/coreos-overlay/pull/2230 and https://github.com/coreos/bugs/issues/1612 for why we want this.\r\n\r\nThis was all done by hand, so it's possible I made a dumb mistake somewhere (I hope not though).\r\n\r\nI did check the multi-node/vagrant one worked as expected and that pods didn't pile up if I intentionally broke the kubelet cli","created_at":"2016-11-14T23:15:00Z","updated_at":"2016-11-15T17:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b84ec46d78e5e9b626dbdc9031d8b4ae87f8484","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/759/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/3d2e7fbad5d7ffa4cd4aeebc0ee594fc44015d8d","head":{"label":"euank:uuid-rm","ref":"uuid-rm","sha":"3d2e7fbad5d7ffa4cd4aeebc0ee594fc44015d8d","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"repo":{"id":61406806,"name":"coreos-kubernetes","full_name":"euank/coreos-kubernetes","owner":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/euank/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":true,"url":"https://api.github.com/repos/euank/coreos-kubernetes","forks_url":"https://api.github.com/repos/euank/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/euank/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euank/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euank/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/euank/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/euank/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/euank/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/euank/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/euank/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/euank/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/euank/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euank/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euank/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/euank/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euank/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/euank/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/euank/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/euank/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/euank/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/euank/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/euank/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/euank/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/euank/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/euank/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/euank/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/euank/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euank/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/euank/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euank/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/euank/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/euank/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/euank/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/euank/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euank/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/euank/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/euank/coreos-kubernetes/deployments","created_at":"2016-06-17T22:57:49Z","updated_at":"2016-06-17T22:57:50Z","pushed_at":"2016-11-15T00:37:30Z","git_url":"git://github.com/euank/coreos-kubernetes.git","ssh_url":"git@github.com:euank/coreos-kubernetes.git","clone_url":"https://github.com/euank/coreos-kubernetes.git","svn_url":"https://github.com/euank/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":26846,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"34d4787f67dc48bd9117fb22b38cebe6f3ec6808","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":41458519,"name":"coreos-kubernetes","full_name":"coreos/coreos-kubernetes","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":false,"url":"https://api.github.com/repos/coreos/coreos-kubernetes","forks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/coreos/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/coreos/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/deployments","created_at":"2015-08-27T01:25:24Z","updated_at":"2016-11-15T03:40:32Z","pushed_at":"2016-11-15T17:25:08Z","git_url":"git://github.com/coreos/coreos-kubernetes.git","ssh_url":"git@github.com:coreos/coreos-kubernetes.git","clone_url":"https://github.com/coreos/coreos-kubernetes.git","svn_url":"https://github.com/coreos/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":52332,"stargazers_count":719,"watchers_count":719,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":132,"forks":333,"open_issues":132,"watchers":719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/759"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/759"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/3d2e7fbad5d7ffa4cd4aeebc0ee594fc44015d8d"}}}}
{"actor":{"display_login":"aaronlevy"}}