{"action":"created","comment":{"url":"https://api.github.com/repos/dpi/smsframework/pulls/comments/92595865","pull_request_review_id":13113731,"id":92595865,"diff_hunk":"@@ -383,6 +388,7 @@ public function testEventsQueueIncoming() {\n     $this->container->get('cron')->run();\n \n     $expected[] = SmsEvents::MESSAGE_INCOMING_PRE_PROCESS;\n+    $expected[] = 'incomingEvent'; // Plugin incoming event.","path":"tests/src/Kernel/SmsFrameworkProviderTest.php","position":34,"original_position":34,"commit_id":"4c61097772bcfcd4262e54f3d9622d0ba38c79ee","original_commit_id":"ffbe6a1e1170f81c452f55fa81ddc77a86325816","user":{"login":"dpi","id":21850,"avatar_url":"https://avatars.githubusercontent.com/u/21850?v=3","gravatar_id":"","url":"https://api.github.com/users/dpi","html_url":"https://github.com/dpi","followers_url":"https://api.github.com/users/dpi/followers","following_url":"https://api.github.com/users/dpi/following{/other_user}","gists_url":"https://api.github.com/users/dpi/gists{/gist_id}","starred_url":"https://api.github.com/users/dpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpi/subscriptions","organizations_url":"https://api.github.com/users/dpi/orgs","repos_url":"https://api.github.com/users/dpi/repos","events_url":"https://api.github.com/users/dpi/events{/privacy}","received_events_url":"https://api.github.com/users/dpi/received_events","type":"User","site_admin":false},"body":"Before this is committed I'm going to change the magic constant from __FUNCTION__ to __METHOD__ so it captures the full namespace and class name. So it is easier to reverse engineer where its coming from when looking at the testing/assertion code.\r\n\r\n`$expected[] = 'incomingEvent';` will become `$expected[] = 'Drupal\\sms_test_gateway\\Plugin\\SmsGateway\\Memory::incomingEvent'`","created_at":"2016-12-15T11:59:52Z","updated_at":"2016-12-15T11:59:52Z","html_url":"https://github.com/dpi/smsframework/pull/60#discussion_r92595865","pull_request_url":"https://api.github.com/repos/dpi/smsframework/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/dpi/smsframework/pulls/comments/92595865"},"html":{"href":"https://github.com/dpi/smsframework/pull/60#discussion_r92595865"},"pull_request":{"href":"https://api.github.com/repos/dpi/smsframework/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/dpi/smsframework/pulls/60","id":96388358,"html_url":"https://github.com/dpi/smsframework/pull/60","diff_url":"https://github.com/dpi/smsframework/pull/60.diff","patch_url":"https://github.com/dpi/smsframework/pull/60.patch","issue_url":"https://api.github.com/repos/dpi/smsframework/issues/60","number":60,"state":"open","locked":false,"title":"Incoming message handling tweaks","user":{"login":"dpi","id":21850,"avatar_url":"https://avatars.githubusercontent.com/u/21850?v=3","gravatar_id":"","url":"https://api.github.com/users/dpi","html_url":"https://github.com/dpi","followers_url":"https://api.github.com/users/dpi/followers","following_url":"https://api.github.com/users/dpi/following{/other_user}","gists_url":"https://api.github.com/users/dpi/gists{/gist_id}","starred_url":"https://api.github.com/users/dpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpi/subscriptions","organizations_url":"https://api.github.com/users/dpi/orgs","repos_url":"https://api.github.com/users/dpi/repos","events_url":"https://api.github.com/users/dpi/events{/privacy}","received_events_url":"https://api.github.com/users/dpi/received_events","type":"User","site_admin":false},"body":"https://www.drupal.org/node/2832601","created_at":"2016-12-03T06:11:37Z","updated_at":"2016-12-15T11:59:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0aecf8773b597ddb666917a6bf7284a8a7fdad3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dpi/smsframework/pulls/60/commits","review_comments_url":"https://api.github.com/repos/dpi/smsframework/pulls/60/comments","review_comment_url":"https://api.github.com/repos/dpi/smsframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dpi/smsframework/issues/60/comments","statuses_url":"https://api.github.com/repos/dpi/smsframework/statuses/4c61097772bcfcd4262e54f3d9622d0ba38c79ee","head":{"label":"dpi:incoming-tweaks-2832601","ref":"incoming-tweaks-2832601","sha":"4c61097772bcfcd4262e54f3d9622d0ba38c79ee","user":{"login":"dpi","id":21850,"avatar_url":"https://avatars.githubusercontent.com/u/21850?v=3","gravatar_id":"","url":"https://api.github.com/users/dpi","html_url":"https://github.com/dpi","followers_url":"https://api.github.com/users/dpi/followers","following_url":"https://api.github.com/users/dpi/following{/other_user}","gists_url":"https://api.github.com/users/dpi/gists{/gist_id}","starred_url":"https://api.github.com/users/dpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpi/subscriptions","organizations_url":"https://api.github.com/users/dpi/orgs","repos_url":"https://api.github.com/users/dpi/repos","events_url":"https://api.github.com/users/dpi/events{/privacy}","received_events_url":"https://api.github.com/users/dpi/received_events","type":"User","site_admin":false},"repo":{"id":42919897,"name":"smsframework","full_name":"dpi/smsframework","owner":{"login":"dpi","id":21850,"avatar_url":"https://avatars.githubusercontent.com/u/21850?v=3","gravatar_id":"","url":"https://api.github.com/users/dpi","html_url":"https://github.com/dpi","followers_url":"https://api.github.com/users/dpi/followers","following_url":"https://api.github.com/users/dpi/following{/other_user}","gists_url":"https://api.github.com/users/dpi/gists{/gist_id}","starred_url":"https://api.github.com/users/dpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpi/subscriptions","organizations_url":"https://api.github.com/users/dpi/orgs","repos_url":"https://api.github.com/users/dpi/repos","events_url":"https://api.github.com/users/dpi/events{/privacy}","received_events_url":"https://api.github.com/users/dpi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpi/smsframework","description":"Fork of Drupal SMS Framework","fork":false,"url":"https://api.github.com/repos/dpi/smsframework","forks_url":"https://api.github.com/repos/dpi/smsframework/forks","keys_url":"https://api.github.com/repos/dpi/smsframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpi/smsframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpi/smsframework/teams","hooks_url":"https://api.github.com/repos/dpi/smsframework/hooks","issue_events_url":"https://api.github.com/repos/dpi/smsframework/issues/events{/number}","events_url":"https://api.github.com/repos/dpi/smsframework/events","assignees_url":"https://api.github.com/repos/dpi/smsframework/assignees{/user}","branches_url":"https://api.github.com/repos/dpi/smsframework/branches{/branch}","tags_url":"https://api.github.com/repos/dpi/smsframework/tags","blobs_url":"https://api.github.com/repos/dpi/smsframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpi/smsframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpi/smsframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpi/smsframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpi/smsframework/statuses/{sha}","languages_url":"https://api.github.com/repos/dpi/smsframework/languages","stargazers_url":"https://api.github.com/repos/dpi/smsframework/stargazers","contributors_url":"https://api.github.com/repos/dpi/smsframework/contributors","subscribers_url":"https://api.github.com/repos/dpi/smsframework/subscribers","subscription_url":"https://api.github.com/repos/dpi/smsframework/subscription","commits_url":"https://api.github.com/repos/dpi/smsframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpi/smsframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpi/smsframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpi/smsframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpi/smsframework/contents/{+path}","compare_url":"https://api.github.com/repos/dpi/smsframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpi/smsframework/merges","archive_url":"https://api.github.com/repos/dpi/smsframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpi/smsframework/downloads","issues_url":"https://api.github.com/repos/dpi/smsframework/issues{/number}","pulls_url":"https://api.github.com/repos/dpi/smsframework/pulls{/number}","milestones_url":"https://api.github.com/repos/dpi/smsframework/milestones{/number}","notifications_url":"https://api.github.com/repos/dpi/smsframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpi/smsframework/labels{/name}","releases_url":"https://api.github.com/repos/dpi/smsframework/releases{/id}","deployments_url":"https://api.github.com/repos/dpi/smsframework/deployments","created_at":"2015-09-22T08:00:13Z","updated_at":"2016-11-19T17:33:26Z","pushed_at":"2016-12-13T13:02:00Z","git_url":"git://github.com/dpi/smsframework.git","ssh_url":"git@github.com:dpi/smsframework.git","clone_url":"https://github.com/dpi/smsframework.git","svn_url":"https://github.com/dpi/smsframework","homepage":"https://www.drupal.org/project/smsframework","size":1449,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"8.x-1.x"}},"base":{"label":"dpi:8.x-1.x","ref":"8.x-1.x","sha":"5a61ceb244a0514f590e1f272fdb196585db9523","user":{"login":"dpi","id":21850,"avatar_url":"https://avatars.githubusercontent.com/u/21850?v=3","gravatar_id":"","url":"https://api.github.com/users/dpi","html_url":"https://github.com/dpi","followers_url":"https://api.github.com/users/dpi/followers","following_url":"https://api.github.com/users/dpi/following{/other_user}","gists_url":"https://api.github.com/users/dpi/gists{/gist_id}","starred_url":"https://api.github.com/users/dpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpi/subscriptions","organizations_url":"https://api.github.com/users/dpi/orgs","repos_url":"https://api.github.com/users/dpi/repos","events_url":"https://api.github.com/users/dpi/events{/privacy}","received_events_url":"https://api.github.com/users/dpi/received_events","type":"User","site_admin":false},"repo":{"id":42919897,"name":"smsframework","full_name":"dpi/smsframework","owner":{"login":"dpi","id":21850,"avatar_url":"https://avatars.githubusercontent.com/u/21850?v=3","gravatar_id":"","url":"https://api.github.com/users/dpi","html_url":"https://github.com/dpi","followers_url":"https://api.github.com/users/dpi/followers","following_url":"https://api.github.com/users/dpi/following{/other_user}","gists_url":"https://api.github.com/users/dpi/gists{/gist_id}","starred_url":"https://api.github.com/users/dpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpi/subscriptions","organizations_url":"https://api.github.com/users/dpi/orgs","repos_url":"https://api.github.com/users/dpi/repos","events_url":"https://api.github.com/users/dpi/events{/privacy}","received_events_url":"https://api.github.com/users/dpi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpi/smsframework","description":"Fork of Drupal SMS Framework","fork":false,"url":"https://api.github.com/repos/dpi/smsframework","forks_url":"https://api.github.com/repos/dpi/smsframework/forks","keys_url":"https://api.github.com/repos/dpi/smsframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpi/smsframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpi/smsframework/teams","hooks_url":"https://api.github.com/repos/dpi/smsframework/hooks","issue_events_url":"https://api.github.com/repos/dpi/smsframework/issues/events{/number}","events_url":"https://api.github.com/repos/dpi/smsframework/events","assignees_url":"https://api.github.com/repos/dpi/smsframework/assignees{/user}","branches_url":"https://api.github.com/repos/dpi/smsframework/branches{/branch}","tags_url":"https://api.github.com/repos/dpi/smsframework/tags","blobs_url":"https://api.github.com/repos/dpi/smsframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpi/smsframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpi/smsframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpi/smsframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpi/smsframework/statuses/{sha}","languages_url":"https://api.github.com/repos/dpi/smsframework/languages","stargazers_url":"https://api.github.com/repos/dpi/smsframework/stargazers","contributors_url":"https://api.github.com/repos/dpi/smsframework/contributors","subscribers_url":"https://api.github.com/repos/dpi/smsframework/subscribers","subscription_url":"https://api.github.com/repos/dpi/smsframework/subscription","commits_url":"https://api.github.com/repos/dpi/smsframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpi/smsframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpi/smsframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpi/smsframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpi/smsframework/contents/{+path}","compare_url":"https://api.github.com/repos/dpi/smsframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpi/smsframework/merges","archive_url":"https://api.github.com/repos/dpi/smsframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpi/smsframework/downloads","issues_url":"https://api.github.com/repos/dpi/smsframework/issues{/number}","pulls_url":"https://api.github.com/repos/dpi/smsframework/pulls{/number}","milestones_url":"https://api.github.com/repos/dpi/smsframework/milestones{/number}","notifications_url":"https://api.github.com/repos/dpi/smsframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpi/smsframework/labels{/name}","releases_url":"https://api.github.com/repos/dpi/smsframework/releases{/id}","deployments_url":"https://api.github.com/repos/dpi/smsframework/deployments","created_at":"2015-09-22T08:00:13Z","updated_at":"2016-11-19T17:33:26Z","pushed_at":"2016-12-13T13:02:00Z","git_url":"git://github.com/dpi/smsframework.git","ssh_url":"git@github.com:dpi/smsframework.git","clone_url":"https://github.com/dpi/smsframework.git","svn_url":"https://github.com/dpi/smsframework","homepage":"https://www.drupal.org/project/smsframework","size":1449,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/dpi/smsframework/pulls/60"},"html":{"href":"https://github.com/dpi/smsframework/pull/60"},"issue":{"href":"https://api.github.com/repos/dpi/smsframework/issues/60"},"comments":{"href":"https://api.github.com/repos/dpi/smsframework/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/dpi/smsframework/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/dpi/smsframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dpi/smsframework/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/dpi/smsframework/statuses/4c61097772bcfcd4262e54f3d9622d0ba38c79ee"}}}}
{"actor":{"display_login":"dpi"}}