{"push_id":1262950554,"size":3,"distinct_size":1,"ref":"refs/heads/master","head":"a52488aaa5fadd7f308472e8190c041aa691de85","before":"cae57d567aab672417892175b9913ebe2a8ad578","commits":[{"sha":"4fed6b70ebc393854ba4270a6966bd2f3928fec8","author":{"name":"Mat Moore","email":"5aafce608516d8eb949cb92e3eb191d1950e2ce1@digital.cabinet-office.gov.uk"},"message":"Revive delete_document\n\n`delete_content!` is not a substitute for `delete_document`:\n\n- this endpoint doesn't work for content without base paths\n- this endpoint doesn't work for recommended-links (urls that may be external to gov.uk)\n- this endpoint doesn't handle things stored in the metadata index, such as best bets\n\nI considered creating more specific methods to replace `delete_document`, but\nI don't think this is worth doing. There are already multiple apps using `delete_document`:\nhttps://github.com/search?utf8=%E2%9C%93&q=org%3Aalphagov+delete_document&type=Code&ref=searchresults\n\nAlso, in my opinion `/document/` is a more useful API. `delete_document` complements `add_document` which covers\nthe things a publishing app needs to do with rummager. The `/content/` API only supports GET and DELETE.","distinct":false,"url":"https://api.github.com/repos/alphagov/gds-api-adapters/commits/4fed6b70ebc393854ba4270a6966bd2f3928fec8"},{"sha":"bc10b43dd967cd344629fac5f01b771d9e2cb2fb","author":{"name":"Mat Moore","email":"5aafce608516d8eb949cb92e3eb191d1950e2ce1@digital.cabinet-office.gov.uk"},"message":"Extend rummager test helpers\n\n- De-deprecate delete_document helpers, because the endpoint is still useful\n- Allow /document/ helpers to take an optional index parameter, mirroring the API\n- Allow all assert methods to pass through additional webmock options\n  (use case: asserting that a request is called twice: https://github.com/alphagov/search-admin/pull/51)\n- Change `stub_any_rummager_post` to behave the same as `stub_any_rummager_post_with_queueing_enabled`: rummager always returns 202 and so should our stubs\n- Deprecate stub_any_rummager_post_with_queueing_enabled as it is now redundant\n- Bump the version due to backwards incompatable test helper changes (but if tests break, it's a bug)","distinct":false,"url":"https://api.github.com/repos/alphagov/gds-api-adapters/commits/bc10b43dd967cd344629fac5f01b771d9e2cb2fb"},{"sha":"a52488aaa5fadd7f308472e8190c041aa691de85","author":{"name":"Mat","email":"386aabb46488f62471267b7b2b44f2424b8f749a@users.noreply.github.com"},"message":"Merge pull request #560 from alphagov/un-deprecate-deleting-things\n\nRevive and extend helpers for rummager /document/ API","distinct":true,"url":"https://api.github.com/repos/alphagov/gds-api-adapters/commits/a52488aaa5fadd7f308472e8190c041aa691de85"}]}
{"actor":{"display_login":"MatMoore"}}