{"action":"created","issue":{"url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1675","repository_url":"https://api.github.com/repos/wildfly/wildfly-core","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1675/labels{/name}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1675/comments","events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1675/events","html_url":"https://github.com/wildfly/wildfly-core/pull/1675","id":165252929,"number":1675,"title":"[WFCORE-429]: Incremental redeployment (single file update) over management API","user":{"login":"ehsavoie","id":73053,"avatar_url":"https://avatars.githubusercontent.com/u/73053?v=3","gravatar_id":"","url":"https://api.github.com/users/ehsavoie","html_url":"https://github.com/ehsavoie","followers_url":"https://api.github.com/users/ehsavoie/followers","following_url":"https://api.github.com/users/ehsavoie/following{/other_user}","gists_url":"https://api.github.com/users/ehsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/ehsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehsavoie/subscriptions","organizations_url":"https://api.github.com/users/ehsavoie/orgs","repos_url":"https://api.github.com/users/ehsavoie/repos","events_url":"https://api.github.com/users/ehsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/ehsavoie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wildfly/wildfly-core/labels/downstream-update-required","name":"downstream-update-required","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-07-13T07:15:48Z","updated_at":"2016-08-17T19:22:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1675","html_url":"https://github.com/wildfly/wildfly-core/pull/1675","diff_url":"https://github.com/wildfly/wildfly-core/pull/1675.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/1675.patch"},"body":"HashUtil for hashing exploded deployments.\r\nPathUtil for recursive deleting/copying.\r\nadd-content, remove-content, read-conten, browse-content, explode in standalone and domain.\r\nSupport for empty directories and empty files.\r\nSupport for sub content explode.\r\nPreparing CLI integration for streams.\r\nAdding lock + local temp copy to avoid conflicts between read-content and remove deployment / content.\r\nAdding \"empty\" parameter to avoid missing content in deployment.\r\nAdding \"overwrite\" parameter to add-content to avoid creating an update-content operation.\r\nAdding transformers for retro compatibility taking unmanaged deployments into account.\r\n\r\nJira: https://issues.jboss.org/browse/WFCORE-429\r\nAnalysis document: https://developer.jboss.org/docs/DOC-55497\r\n\r\nThere is a branch for some more integration tests on WildFly\r\nhttps://github.com/ehsavoie/wildfly/tree/WFCORE-429\r\nIntegration with the update in full: https://ci.wildfly.org/viewLog.html?buildId=21461&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments"},"comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/240518927","html_url":"https://github.com/wildfly/wildfly-core/pull/1675#issuecomment-240518927","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1675","id":240518927,"user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=3","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T19:22:24Z","updated_at":"2016-08-17T19:22:24Z","body":"@ehsavoie I'm feeling more strongly now that the 'empty' setting should be a field in the existing 'content' param/attribute and not a new top level param.\r\n\r\nThe ModelControllerMBeanTestCase failure shows that adding it as a new top level param results in a breaking change for JMX clients. I thought for a while that making it as a field in 'content' would also have a breaking effect, so it would be a breaking change either way. But that is not the case. The way ModelControllerMBeanTestCase was implemented fooled me into thinking the requirements for creating the 'content' param in JMX was that all fields must be used, including any new 'empty' field. But that's not true. See #1745 where I change to test to use simpler JMX code, something more like what real JMX-based end users would likely do. The user only needs to set the fields that are relevant to them, and code that was unaware of 'empty' would continue to work unmodified.\r\n\r\nWDYT?"}}
{"actor":{"display_login":"bstansberry"}}