{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/css-layout/issues/263","repository_url":"https://api.github.com/repos/facebook/css-layout","labels_url":"https://api.github.com/repos/facebook/css-layout/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/facebook/css-layout/issues/263/comments","events_url":"https://api.github.com/repos/facebook/css-layout/issues/263/events","html_url":"https://github.com/facebook/css-layout/pull/263","id":191860614,"number":263,"title":"Enable `-fPIC` for C library","user":{"login":"passy","id":9906,"avatar_url":"https://avatars.githubusercontent.com/u/9906?v=3","gravatar_id":"","url":"https://api.github.com/users/passy","html_url":"https://github.com/passy","followers_url":"https://api.github.com/users/passy/followers","following_url":"https://api.github.com/users/passy/following{/other_user}","gists_url":"https://api.github.com/users/passy/gists{/gist_id}","starred_url":"https://api.github.com/users/passy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passy/subscriptions","organizations_url":"https://api.github.com/users/passy/orgs","repos_url":"https://api.github.com/users/passy/repos","events_url":"https://api.github.com/users/passy/events{/privacy}","received_events_url":"https://api.github.com/users/passy/received_events","type":"User","site_admin":false},"labels":[{"id":196858700,"url":"https://api.github.com/repos/facebook/css-layout/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-27T13:10:33Z","updated_at":"2016-11-28T10:52:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/css-layout/pulls/263","html_url":"https://github.com/facebook/css-layout/pull/263","diff_url":"https://github.com/facebook/css-layout/pull/263.diff","patch_url":"https://github.com/facebook/css-layout/pull/263.patch"},"body":"At least or x86_64 linux, it appears that you need position-independent\r\ncode is required in order to link against it. Otherwise you see errors\r\nlike this:\r\n\r\n```\r\n/usr/bin/ld: lib_sys.rlib(CSSLayout.c.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC\r\n/usr/bin/ld: lib_sys.rlib(CSSNodeList.c.o): relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a shared object; recompile with -fPIC\r\n/usr/bin/ld: final link failed: Nonrepresentable section on output\r\ncollect2: error: ld returned 1 exit status\r\n```\r\n\r\nIf I understand it correctly, you don't strictly need PIC for static libraries, but as soon as you want to link *other* dynamically linked library into it, it is required - which makes logical sense to me. Let me know if you want to enable this by default or leave it up to the developers to enable this if needed."},"comment":{"url":"https://api.github.com/repos/facebook/css-layout/issues/comments/263241246","html_url":"https://github.com/facebook/css-layout/pull/263#issuecomment-263241246","issue_url":"https://api.github.com/repos/facebook/css-layout/issues/263","id":263241246,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T10:52:38Z","updated_at":"2016-11-28T10:52:38Z","body":"@emilsjolander has imported this pull request.  If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D4237009)."}}
{"actor":{"display_login":"facebook-github-bot"}}