{"action":"created","comment":{"url":"https://api.github.com/repos/valhalla/thor/pulls/comments/89840600","pull_request_review_id":10373236,"id":89840600,"diff_hunk":"@@ -90,9 +90,15 @@ worker_t::result_t thor_worker_t::trace_attributes(\n     trip_path = map_match();\n   }\n   json::MapPtr json;\n+  auto id = request.get_optional<std::string>(\"id\");\n+  //length defaults to km, speed defaults to km/h\n+  double scale = 1;\n+  auto units = request.get<std::string>(\"units\", \"km\");\n+  if (units == \"mi\") {","path":"src/thor/trace_attributes_action.cc","position":28,"original_position":28,"commit_id":"e7a7a439d37eb52c32163bf7750b02d213fb51f9","original_commit_id":"e7a7a439d37eb52c32163bf7750b02d213fb51f9","user":{"login":"dgearhart","id":7515853,"avatar_url":"https://avatars.githubusercontent.com/u/7515853?v=3","gravatar_id":"","url":"https://api.github.com/users/dgearhart","html_url":"https://github.com/dgearhart","followers_url":"https://api.github.com/users/dgearhart/followers","following_url":"https://api.github.com/users/dgearhart/following{/other_user}","gists_url":"https://api.github.com/users/dgearhart/gists{/gist_id}","starred_url":"https://api.github.com/users/dgearhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgearhart/subscriptions","organizations_url":"https://api.github.com/users/dgearhart/orgs","repos_url":"https://api.github.com/users/dgearhart/repos","events_url":"https://api.github.com/users/dgearhart/events{/privacy}","received_events_url":"https://api.github.com/users/dgearhart/received_events","type":"User","site_admin":false},"body":"check mi and miles","created_at":"2016-11-28T17:58:34Z","updated_at":"2016-11-28T17:58:34Z","html_url":"https://github.com/valhalla/thor/pull/473#discussion_r89840600","pull_request_url":"https://api.github.com/repos/valhalla/thor/pulls/473","_links":{"self":{"href":"https://api.github.com/repos/valhalla/thor/pulls/comments/89840600"},"html":{"href":"https://github.com/valhalla/thor/pull/473#discussion_r89840600"},"pull_request":{"href":"https://api.github.com/repos/valhalla/thor/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/valhalla/thor/pulls/473","id":95532428,"html_url":"https://github.com/valhalla/thor/pull/473","diff_url":"https://github.com/valhalla/thor/pull/473.diff","patch_url":"https://github.com/valhalla/thor/pull/473.patch","issue_url":"https://api.github.com/repos/valhalla/thor/issues/473","number":473,"state":"open","locked":false,"title":"Length & speed based on units","user":{"login":"kdiluca","id":12497844,"avatar_url":"https://avatars.githubusercontent.com/u/12497844?v=3","gravatar_id":"","url":"https://api.github.com/users/kdiluca","html_url":"https://github.com/kdiluca","followers_url":"https://api.github.com/users/kdiluca/followers","following_url":"https://api.github.com/users/kdiluca/following{/other_user}","gists_url":"https://api.github.com/users/kdiluca/gists{/gist_id}","starred_url":"https://api.github.com/users/kdiluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdiluca/subscriptions","organizations_url":"https://api.github.com/users/kdiluca/orgs","repos_url":"https://api.github.com/users/kdiluca/repos","events_url":"https://api.github.com/users/kdiluca/events{/privacy}","received_events_url":"https://api.github.com/users/kdiluca/received_events","type":"User","site_admin":false},"body":"I merged from master but my only changes were in trace_attributes for units, length and speed.","created_at":"2016-11-28T16:36:09Z","updated_at":"2016-11-28T17:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07519cba5e1676c3c3b1c0dd9eaa6d442c84276b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/valhalla/thor/pulls/473/commits","review_comments_url":"https://api.github.com/repos/valhalla/thor/pulls/473/comments","review_comment_url":"https://api.github.com/repos/valhalla/thor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/valhalla/thor/issues/473/comments","statuses_url":"https://api.github.com/repos/valhalla/thor/statuses/e7a7a439d37eb52c32163bf7750b02d213fb51f9","head":{"label":"valhalla:kdiluca","ref":"kdiluca","sha":"e7a7a439d37eb52c32163bf7750b02d213fb51f9","user":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":28186592,"name":"thor","full_name":"valhalla/thor","owner":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/thor","description":"Tiled Hierarchical Open Routing - a routing engine backed by tiled open source routing data","fork":false,"url":"https://api.github.com/repos/valhalla/thor","forks_url":"https://api.github.com/repos/valhalla/thor/forks","keys_url":"https://api.github.com/repos/valhalla/thor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/thor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/thor/teams","hooks_url":"https://api.github.com/repos/valhalla/thor/hooks","issue_events_url":"https://api.github.com/repos/valhalla/thor/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/thor/events","assignees_url":"https://api.github.com/repos/valhalla/thor/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/thor/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/thor/tags","blobs_url":"https://api.github.com/repos/valhalla/thor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/thor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/thor/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/thor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/thor/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/thor/languages","stargazers_url":"https://api.github.com/repos/valhalla/thor/stargazers","contributors_url":"https://api.github.com/repos/valhalla/thor/contributors","subscribers_url":"https://api.github.com/repos/valhalla/thor/subscribers","subscription_url":"https://api.github.com/repos/valhalla/thor/subscription","commits_url":"https://api.github.com/repos/valhalla/thor/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/thor/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/thor/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/thor/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/thor/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/thor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/thor/merges","archive_url":"https://api.github.com/repos/valhalla/thor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/thor/downloads","issues_url":"https://api.github.com/repos/valhalla/thor/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/thor/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/thor/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/thor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/thor/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/thor/releases{/id}","deployments_url":"https://api.github.com/repos/valhalla/thor/deployments","created_at":"2014-12-18T14:25:42Z","updated_at":"2016-11-17T17:35:50Z","pushed_at":"2016-11-28T17:45:12Z","git_url":"git://github.com/valhalla/thor.git","ssh_url":"git@github.com:valhalla/thor.git","clone_url":"https://github.com/valhalla/thor.git","svn_url":"https://github.com/valhalla/thor","homepage":null,"size":9733,"stargazers_count":104,"watchers_count":104,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":26,"forks":19,"open_issues":26,"watchers":104,"default_branch":"master"}},"base":{"label":"valhalla:master","ref":"master","sha":"54ac3b0f3aa8aa17a137554c6ea43516de0f5ac7","user":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":28186592,"name":"thor","full_name":"valhalla/thor","owner":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/thor","description":"Tiled Hierarchical Open Routing - a routing engine backed by tiled open source routing data","fork":false,"url":"https://api.github.com/repos/valhalla/thor","forks_url":"https://api.github.com/repos/valhalla/thor/forks","keys_url":"https://api.github.com/repos/valhalla/thor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/thor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/thor/teams","hooks_url":"https://api.github.com/repos/valhalla/thor/hooks","issue_events_url":"https://api.github.com/repos/valhalla/thor/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/thor/events","assignees_url":"https://api.github.com/repos/valhalla/thor/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/thor/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/thor/tags","blobs_url":"https://api.github.com/repos/valhalla/thor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/thor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/thor/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/thor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/thor/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/thor/languages","stargazers_url":"https://api.github.com/repos/valhalla/thor/stargazers","contributors_url":"https://api.github.com/repos/valhalla/thor/contributors","subscribers_url":"https://api.github.com/repos/valhalla/thor/subscribers","subscription_url":"https://api.github.com/repos/valhalla/thor/subscription","commits_url":"https://api.github.com/repos/valhalla/thor/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/thor/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/thor/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/thor/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/thor/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/thor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/thor/merges","archive_url":"https://api.github.com/repos/valhalla/thor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/thor/downloads","issues_url":"https://api.github.com/repos/valhalla/thor/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/thor/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/thor/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/thor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/thor/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/thor/releases{/id}","deployments_url":"https://api.github.com/repos/valhalla/thor/deployments","created_at":"2014-12-18T14:25:42Z","updated_at":"2016-11-17T17:35:50Z","pushed_at":"2016-11-28T17:45:12Z","git_url":"git://github.com/valhalla/thor.git","ssh_url":"git@github.com:valhalla/thor.git","clone_url":"https://github.com/valhalla/thor.git","svn_url":"https://github.com/valhalla/thor","homepage":null,"size":9733,"stargazers_count":104,"watchers_count":104,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":26,"forks":19,"open_issues":26,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/valhalla/thor/pulls/473"},"html":{"href":"https://github.com/valhalla/thor/pull/473"},"issue":{"href":"https://api.github.com/repos/valhalla/thor/issues/473"},"comments":{"href":"https://api.github.com/repos/valhalla/thor/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/valhalla/thor/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/valhalla/thor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/valhalla/thor/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/valhalla/thor/statuses/e7a7a439d37eb52c32163bf7750b02d213fb51f9"}}}}
{"actor":{"display_login":"dgearhart"}}