{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/719","repository_url":"https://api.github.com/repos/vmware/docker-volume-vsphere","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/719/labels{/name}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/719/comments","events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/719/events","html_url":"https://github.com/vmware/docker-volume-vsphere/issues/719","id":187926869,"number":719,"title":"vmdk_ops.py:removeVMDK() must check that a volume isn't in use before even attempting to remove it.","user":{"login":"govint","id":15854712,"avatar_url":"https://avatars.githubusercontent.com/u/15854712?v=3","gravatar_id":"","url":"https://api.github.com/users/govint","html_url":"https://github.com/govint","followers_url":"https://api.github.com/users/govint/followers","following_url":"https://api.github.com/users/govint/following{/other_user}","gists_url":"https://api.github.com/users/govint/gists{/gist_id}","starred_url":"https://api.github.com/users/govint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govint/subscriptions","organizations_url":"https://api.github.com/users/govint/orgs","repos_url":"https://api.github.com/users/govint/repos","events_url":"https://api.github.com/users/govint/events{/privacy}","received_events_url":"https://api.github.com/users/govint/received_events","type":"User","site_admin":false},"labels":[{"id":381170957,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels/component/server","name":"component/server","color":"bfd4f2","default":false},{"id":310972920,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels/kind/bug","name":"kind/bug","color":"fbca04","default":false},{"id":326563847,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels/P1","name":"P1","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"govint","id":15854712,"avatar_url":"https://avatars.githubusercontent.com/u/15854712?v=3","gravatar_id":"","url":"https://api.github.com/users/govint","html_url":"https://github.com/govint","followers_url":"https://api.github.com/users/govint/followers","following_url":"https://api.github.com/users/govint/following{/other_user}","gists_url":"https://api.github.com/users/govint/gists{/gist_id}","starred_url":"https://api.github.com/users/govint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govint/subscriptions","organizations_url":"https://api.github.com/users/govint/orgs","repos_url":"https://api.github.com/users/govint/repos","events_url":"https://api.github.com/users/govint/events{/privacy}","received_events_url":"https://api.github.com/users/govint/received_events","type":"User","site_admin":false},"assignees":[{"login":"govint","id":15854712,"avatar_url":"https://avatars.githubusercontent.com/u/15854712?v=3","gravatar_id":"","url":"https://api.github.com/users/govint","html_url":"https://github.com/govint","followers_url":"https://api.github.com/users/govint/followers","following_url":"https://api.github.com/users/govint/following{/other_user}","gists_url":"https://api.github.com/users/govint/gists{/gist_id}","starred_url":"https://api.github.com/users/govint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govint/subscriptions","organizations_url":"https://api.github.com/users/govint/orgs","repos_url":"https://api.github.com/users/govint/repos","events_url":"https://api.github.com/users/govint/events{/privacy}","received_events_url":"https://api.github.com/users/govint/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones/2","html_url":"https://github.com/vmware/docker-volume-vsphere/milestones/v1%20GA","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones/2/labels","id":1584322,"number":2,"title":"v1 GA","description":"General Availability - this is when we claim v1 is ready\r\n\r\n(Since we use monthly drops, we need to rethink GA definition. Setting it to 10/1 for now.","creator":{"login":"msterin","id":4379889,"avatar_url":"https://avatars.githubusercontent.com/u/4379889?v=3","gravatar_id":"","url":"https://api.github.com/users/msterin","html_url":"https://github.com/msterin","followers_url":"https://api.github.com/users/msterin/followers","following_url":"https://api.github.com/users/msterin/following{/other_user}","gists_url":"https://api.github.com/users/msterin/gists{/gist_id}","starred_url":"https://api.github.com/users/msterin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msterin/subscriptions","organizations_url":"https://api.github.com/users/msterin/orgs","repos_url":"https://api.github.com/users/msterin/repos","events_url":"https://api.github.com/users/msterin/events{/privacy}","received_events_url":"https://api.github.com/users/msterin/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":64,"state":"open","created_at":"2016-02-15T21:32:16Z","updated_at":"2016-11-09T03:01:00Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-11-08T08:10:16Z","updated_at":"2016-11-09T04:24:43Z","closed_at":null,"body":"Add check for usage before disk is removed."},"comment":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/comments/259331394","html_url":"https://github.com/vmware/docker-volume-vsphere/issues/719#issuecomment-259331394","issue_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/719","id":259331394,"user":{"login":"msterin","id":4379889,"avatar_url":"https://avatars.githubusercontent.com/u/4379889?v=3","gravatar_id":"","url":"https://api.github.com/users/msterin","html_url":"https://github.com/msterin","followers_url":"https://api.github.com/users/msterin/followers","following_url":"https://api.github.com/users/msterin/following{/other_user}","gists_url":"https://api.github.com/users/msterin/gists{/gist_id}","starred_url":"https://api.github.com/users/msterin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msterin/subscriptions","organizations_url":"https://api.github.com/users/msterin/orgs","repos_url":"https://api.github.com/users/msterin/repos","events_url":"https://api.github.com/users/msterin/events{/privacy}","received_events_url":"https://api.github.com/users/msterin/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T04:24:43Z","updated_at":"2016-11-09T04:24:43Z","body":"Before we introduced KV files there was no need to check, as the VMX and VMFS locks were checking it for us. With sidecar KVs, we planned to rely on sidecar / vmdk transactionality (that, in fact, was top reason to pick up sidecars).  Unfortunately it is not working as promised, but my suggestion would be to just recover KV file if removeVMDK fails - it will have to happen very unfrequently, while check for usage will have to happen every time. "}}
{"actor":{"display_login":"msterin"}}