{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/58540998","id":58540998,"diff_hunk":"@@ -40,13 +40,13 @@ static int execute_test(D2I_TEST_FIXTURE fixture)\n {\n     BIO *bio = NULL;\n     ASN1_VALUE *value = NULL;\n-    int ret = 1;\n+    int ret = 0;\n     unsigned char buf[2048];\n     const unsigned char *buf_ptr = buf;\n     int len;\n \n     if ((bio = BIO_new_file(test_file, \"r\")) == NULL)\n-        return 1;\n+        return 0;","path":"test/d2i_test.c","position":12,"original_position":12,"commit_id":"0628137e2ae59a4e994922e8c466895caf6dae7a","original_commit_id":"0628137e2ae59a4e994922e8c466895caf6dae7a","user":{"login":"ekasper","id":7046250,"avatar_url":"https://avatars.githubusercontent.com/u/7046250?v=3","gravatar_id":"","url":"https://api.github.com/users/ekasper","html_url":"https://github.com/ekasper","followers_url":"https://api.github.com/users/ekasper/followers","following_url":"https://api.github.com/users/ekasper/following{/other_user}","gists_url":"https://api.github.com/users/ekasper/gists{/gist_id}","starred_url":"https://api.github.com/users/ekasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekasper/subscriptions","organizations_url":"https://api.github.com/users/ekasper/orgs","repos_url":"https://api.github.com/users/ekasper/repos","events_url":"https://api.github.com/users/ekasper/events{/privacy}","received_events_url":"https://api.github.com/users/ekasper/received_events","type":"User","site_admin":false},"body":"\"If there is no cleanup needed then just return directly.\"","created_at":"2016-04-05T13:51:43Z","updated_at":"2016-04-05T13:51:43Z","html_url":"https://github.com/openssl/openssl/pull/944#discussion_r58540998","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/944","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/58540998"},"html":{"href":"https://github.com/openssl/openssl/pull/944#discussion_r58540998"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/944"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/944","id":65296266,"html_url":"https://github.com/openssl/openssl/pull/944","diff_url":"https://github.com/openssl/openssl/pull/944.diff","patch_url":"https://github.com/openssl/openssl/pull/944.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/944","number":944,"state":"open","locked":false,"title":"testutil: return 1 on success","user":{"login":"ekasper","id":7046250,"avatar_url":"https://avatars.githubusercontent.com/u/7046250?v=3","gravatar_id":"","url":"https://api.github.com/users/ekasper","html_url":"https://github.com/ekasper","followers_url":"https://api.github.com/users/ekasper/followers","following_url":"https://api.github.com/users/ekasper/following{/other_user}","gists_url":"https://api.github.com/users/ekasper/gists{/gist_id}","starred_url":"https://api.github.com/users/ekasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekasper/subscriptions","organizations_url":"https://api.github.com/users/ekasper/orgs","repos_url":"https://api.github.com/users/ekasper/repos","events_url":"https://api.github.com/users/ekasper/events{/privacy}","received_events_url":"https://api.github.com/users/ekasper/received_events","type":"User","site_admin":false},"body":"Require that test methods return 1 on success (not 0). This is more\r\ncustomary for OpenSSL.","created_at":"2016-04-05T12:31:42Z","updated_at":"2016-04-05T13:51:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d44889ee985af72aa7b494ba9d5394aadf9d763b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/944/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/944/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/944/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/0628137e2ae59a4e994922e8c466895caf6dae7a","head":{"label":"ekasper:0034-return1-success","ref":"0034-return1-success","sha":"0628137e2ae59a4e994922e8c466895caf6dae7a","user":{"login":"ekasper","id":7046250,"avatar_url":"https://avatars.githubusercontent.com/u/7046250?v=3","gravatar_id":"","url":"https://api.github.com/users/ekasper","html_url":"https://github.com/ekasper","followers_url":"https://api.github.com/users/ekasper/followers","following_url":"https://api.github.com/users/ekasper/following{/other_user}","gists_url":"https://api.github.com/users/ekasper/gists{/gist_id}","starred_url":"https://api.github.com/users/ekasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekasper/subscriptions","organizations_url":"https://api.github.com/users/ekasper/orgs","repos_url":"https://api.github.com/users/ekasper/repos","events_url":"https://api.github.com/users/ekasper/events{/privacy}","received_events_url":"https://api.github.com/users/ekasper/received_events","type":"User","site_admin":false},"repo":{"id":18060184,"name":"openssl","full_name":"ekasper/openssl","owner":{"login":"ekasper","id":7046250,"avatar_url":"https://avatars.githubusercontent.com/u/7046250?v=3","gravatar_id":"","url":"https://api.github.com/users/ekasper","html_url":"https://github.com/ekasper","followers_url":"https://api.github.com/users/ekasper/followers","following_url":"https://api.github.com/users/ekasper/following{/other_user}","gists_url":"https://api.github.com/users/ekasper/gists{/gist_id}","starred_url":"https://api.github.com/users/ekasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekasper/subscriptions","organizations_url":"https://api.github.com/users/ekasper/orgs","repos_url":"https://api.github.com/users/ekasper/repos","events_url":"https://api.github.com/users/ekasper/events{/privacy}","received_events_url":"https://api.github.com/users/ekasper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekasper/openssl","description":"","fork":true,"url":"https://api.github.com/repos/ekasper/openssl","forks_url":"https://api.github.com/repos/ekasper/openssl/forks","keys_url":"https://api.github.com/repos/ekasper/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekasper/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekasper/openssl/teams","hooks_url":"https://api.github.com/repos/ekasper/openssl/hooks","issue_events_url":"https://api.github.com/repos/ekasper/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/ekasper/openssl/events","assignees_url":"https://api.github.com/repos/ekasper/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/ekasper/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/ekasper/openssl/tags","blobs_url":"https://api.github.com/repos/ekasper/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekasper/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekasper/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekasper/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekasper/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/ekasper/openssl/languages","stargazers_url":"https://api.github.com/repos/ekasper/openssl/stargazers","contributors_url":"https://api.github.com/repos/ekasper/openssl/contributors","subscribers_url":"https://api.github.com/repos/ekasper/openssl/subscribers","subscription_url":"https://api.github.com/repos/ekasper/openssl/subscription","commits_url":"https://api.github.com/repos/ekasper/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekasper/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekasper/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekasper/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekasper/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/ekasper/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekasper/openssl/merges","archive_url":"https://api.github.com/repos/ekasper/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekasper/openssl/downloads","issues_url":"https://api.github.com/repos/ekasper/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/ekasper/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/ekasper/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/ekasper/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekasper/openssl/labels{/name}","releases_url":"https://api.github.com/repos/ekasper/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/ekasper/openssl/deployments","created_at":"2014-03-24T11:21:01Z","updated_at":"2014-07-21T17:31:40Z","pushed_at":"2016-04-05T13:28:15Z","git_url":"git://github.com/ekasper/openssl.git","ssh_url":"git@github.com:ekasper/openssl.git","clone_url":"https://github.com/ekasper/openssl.git","svn_url":"https://github.com/ekasper/openssl","homepage":null,"size":77508,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"453dfd8d5ee0893146e0fb61a5978ab59ba95c01","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-04-05T12:36:35Z","pushed_at":"2016-04-05T13:29:33Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":96126,"stargazers_count":2410,"watchers_count":2410,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1373,"mirror_url":null,"open_issues_count":155,"forks":1373,"open_issues":155,"watchers":2410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/944"},"html":{"href":"https://github.com/openssl/openssl/pull/944"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/944"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/944/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/944/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/944/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/0628137e2ae59a4e994922e8c466895caf6dae7a"}}}}