{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/493","repository_url":"https://api.github.com/repos/vaadin/vaadin-grid","labels_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/493/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/493/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/493/events","html_url":"https://github.com/vaadin/vaadin-grid/pull/493","id":183031675,"number":493,"title":"Add Column Groups","user":{"login":"Saulis","id":1039468,"avatar_url":"https://avatars.githubusercontent.com/u/1039468?v=3","gravatar_id":"","url":"https://api.github.com/users/Saulis","html_url":"https://github.com/Saulis","followers_url":"https://api.github.com/users/Saulis/followers","following_url":"https://api.github.com/users/Saulis/following{/other_user}","gists_url":"https://api.github.com/users/Saulis/gists{/gist_id}","starred_url":"https://api.github.com/users/Saulis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saulis/subscriptions","organizations_url":"https://api.github.com/users/Saulis/orgs","repos_url":"https://api.github.com/users/Saulis/repos","events_url":"https://api.github.com/users/Saulis/events{/privacy}","received_events_url":"https://api.github.com/users/Saulis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vaadin/vaadin-grid/labels/2.0","name":"2.0","color":"fef2c0"},{"url":"https://api.github.com/repos/vaadin/vaadin-grid/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2016-10-14T11:54:09Z","updated_at":"2016-10-27T12:42:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/pulls/493","html_url":"https://github.com/vaadin/vaadin-grid/pull/493","diff_url":"https://github.com/vaadin/vaadin-grid/pull/493.diff","patch_url":"https://github.com/vaadin/vaadin-grid/pull/493.patch"},"body":"Connects to #441\r\n\r\nThis PR doesn't have the `frozen` functionality yet, adding that separately.\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-grid/493)\r\n<!-- Reviewable:end -->"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/comments/256630065","html_url":"https://github.com/vaadin/vaadin-grid/pull/493#issuecomment-256630065","issue_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/493","id":256630065,"user":{"login":"manolo","id":161853,"avatar_url":"https://avatars.githubusercontent.com/u/161853?v=3","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T12:42:54Z","updated_at":"2016-10-27T12:42:54Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[vaadin-grid-table.html, line 238 at r13](https://reviewable.io:443/reviews/vaadin/vaadin-grid/493#-KV53puUZaebYjoP5v9o:-KV58uUTi-jrHvckyZtL:b-j03f0z) ([raw file](https://github.com/vaadin/vaadin-grid/blob/f7cb8d1552385fc04064235dc519f011025ecb87/vaadin-grid-table.html#L238)):*\n<details><summary><i>Previously, tomivirkki (Tomi Virkki) wrote…</i></summary>\n> In this case 'this' is a `<vaadin-grid-table>` which is not an existing/default DOM element like ´<template>´ or ´<div>´. Adding custom attributes to existing elements will break validation for the document but that's not the case with custom elements.\n</details>\nI guess validators do not know so much about custom elements, normally they are static parsers.\nBut anyway, traditionally it was considered that not using class names in selectors would hit the performance, in gwt and jquery they have promoted that for ages. At least old browsers used to perform faster with classnames.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/vaadin-grid/493)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"manolo"}}