{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1894","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1894/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1894/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1894/events","html_url":"https://github.com/ReactiveX/rxjs/pull/1894","id":172531449,"number":1894,"title":"fix(Subject): do not expose static create method to inherited","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ReactiveX/rxjs/labels/type:%20discussion","name":"type: discussion","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-22T19:15:34Z","updated_at":"2016-08-22T22:07:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1894","html_url":"https://github.com/ReactiveX/rxjs/pull/1894","diff_url":"https://github.com/ReactiveX/rxjs/pull/1894.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/1894.patch"},"body":"**Description:**\r\nThis PR aligns interface of classes inherited from `Subject<T>`, do not expose static creation method by introducing abstract class `SubjectBase<T>`.\r\n\r\n**Related issue (if exists):**\r\n\r\ncloses #1890"},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/241566462","html_url":"https://github.com/ReactiveX/rxjs/pull/1894#issuecomment-241566462","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1894","id":241566462,"user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T22:07:35Z","updated_at":"2016-08-22T22:07:35Z","body":"> (new AsyncSubject) instanceof Subject will no longer pass, and that scares me and seems counter-intuitive.\r\n\r\n: I think that's legit point that I couldn't think of at the moment writing PR. do we have general usecases for checking types of inherited subjects?"}}
{"actor":{"display_login":"kwonoj"}}