{"action":"created","comment":{"url":"https://api.github.com/repos/huboard/huboard-web/pulls/comments/53339443","id":53339443,"diff_hunk":"@@ -5,11 +5,11 @@ var HbColumnCrumbComponent = Ember.Component.extend({\n   classNames: ['crumb'],\n   classNameBindings: [\"stateClass\", \"isSelected:active:inactive\", \"indexClass\"],\n   isSelected: function(){\n-    if(this.get(\"issue.data.state\") === \"closed\"){\n-      return this.get(\"visibleColumns.lastObject.data.name\") === this.get(\"column.data.name\");\n-    }\n-    return this.get(\"issue.data.current_state.name\") === this.get(\"column.data.name\");\n-  }.property(\"issue.data.current_state.name\", \"column.data.name\", \"issue.data.state\"),\n+    var current_issue = this.get(\"issue\");\n+    return this.get(\"column.sortedIssues\").find((issue)=> {\n+      return issue.get(\"id\") === current_issue.get(\"id\");\n+    });\n+  }.property(\"column.sortedIssues.@each\"),","path":"ember-app/app/components/hb-column-crumb.js","position":13,"original_position":13,"commit_id":"1caefe4b97d2e94f16ba1cc2db522f28a87a5640","original_commit_id":"1caefe4b97d2e94f16ba1cc2db522f28a87a5640","user":{"login":"discorick","id":1130665,"avatar_url":"https://avatars.githubusercontent.com/u/1130665?v=3","gravatar_id":"","url":"https://api.github.com/users/discorick","html_url":"https://github.com/discorick","followers_url":"https://api.github.com/users/discorick/followers","following_url":"https://api.github.com/users/discorick/following{/other_user}","gists_url":"https://api.github.com/users/discorick/gists{/gist_id}","starred_url":"https://api.github.com/users/discorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discorick/subscriptions","organizations_url":"https://api.github.com/users/discorick/orgs","repos_url":"https://api.github.com/users/discorick/repos","events_url":"https://api.github.com/users/discorick/events{/privacy}","received_events_url":"https://api.github.com/users/discorick/received_events","type":"User","site_admin":false},"body":"I double checked the rendering speed with the Ember inspector, they are virtually identical. \r\n\r\nI am interested when I make the sister change with the milestone column model if we see any change. But that is a seperate PR. ","created_at":"2016-02-18T16:27:45Z","updated_at":"2016-02-18T16:27:45Z","html_url":"https://github.com/huboard/huboard-web/pull/204#discussion_r53339443","pull_request_url":"https://api.github.com/repos/huboard/huboard-web/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/huboard/huboard-web/pulls/comments/53339443"},"html":{"href":"https://github.com/huboard/huboard-web/pull/204#discussion_r53339443"},"pull_request":{"href":"https://api.github.com/repos/huboard/huboard-web/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/huboard/huboard-web/pulls/204","id":59528398,"html_url":"https://github.com/huboard/huboard-web/pull/204","diff_url":"https://github.com/huboard/huboard-web/pull/204.diff","patch_url":"https://github.com/huboard/huboard-web/pull/204.patch","issue_url":"https://api.github.com/repos/huboard/huboard-web/issues/204","number":204,"state":"open","locked":false,"title":"Fixes missing status on column breadcrumbs","user":{"login":"discorick","id":1130665,"avatar_url":"https://avatars.githubusercontent.com/u/1130665?v=3","gravatar_id":"","url":"https://api.github.com/users/discorick","html_url":"https://github.com/discorick","followers_url":"https://api.github.com/users/discorick/followers","following_url":"https://api.github.com/users/discorick/following{/other_user}","gists_url":"https://api.github.com/users/discorick/gists{/gist_id}","starred_url":"https://api.github.com/users/discorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discorick/subscriptions","organizations_url":"https://api.github.com/users/discorick/orgs","repos_url":"https://api.github.com/users/discorick/repos","events_url":"https://api.github.com/users/discorick/events{/privacy}","received_events_url":"https://api.github.com/users/discorick/received_events","type":"User","site_admin":false},"body":"Addresses #187 \r\n\r\nColumn crumb statuses were computing based on their names, however this breaks down on WIP columns when a linked repo does not share the same WIP. Fixes by moving a columns sortedIssues into the column itself, enabling us to check if the issue itself exists in the column or not.","created_at":"2016-02-16T17:54:54Z","updated_at":"2016-02-18T16:27:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e7d365b9561e6958e561896a819534f76f5001","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/huboard/huboard-web/pulls/204/commits","review_comments_url":"https://api.github.com/repos/huboard/huboard-web/pulls/204/comments","review_comment_url":"https://api.github.com/repos/huboard/huboard-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/huboard/huboard-web/issues/204/comments","statuses_url":"https://api.github.com/repos/huboard/huboard-web/statuses/1caefe4b97d2e94f16ba1cc2db522f28a87a5640","head":{"label":"huboard:discorick/missing_status_on_breadcrumbs","ref":"discorick/missing_status_on_breadcrumbs","sha":"1caefe4b97d2e94f16ba1cc2db522f28a87a5640","user":{"login":"huboard","id":1236155,"avatar_url":"https://avatars.githubusercontent.com/u/1236155?v=3","gravatar_id":"","url":"https://api.github.com/users/huboard","html_url":"https://github.com/huboard","followers_url":"https://api.github.com/users/huboard/followers","following_url":"https://api.github.com/users/huboard/following{/other_user}","gists_url":"https://api.github.com/users/huboard/gists{/gist_id}","starred_url":"https://api.github.com/users/huboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huboard/subscriptions","organizations_url":"https://api.github.com/users/huboard/orgs","repos_url":"https://api.github.com/users/huboard/repos","events_url":"https://api.github.com/users/huboard/events{/privacy}","received_events_url":"https://api.github.com/users/huboard/received_events","type":"Organization","site_admin":false},"repo":{"id":29268631,"name":"huboard-web","full_name":"huboard/huboard-web","owner":{"login":"huboard","id":1236155,"avatar_url":"https://avatars.githubusercontent.com/u/1236155?v=3","gravatar_id":"","url":"https://api.github.com/users/huboard","html_url":"https://github.com/huboard","followers_url":"https://api.github.com/users/huboard/followers","following_url":"https://api.github.com/users/huboard/following{/other_user}","gists_url":"https://api.github.com/users/huboard/gists{/gist_id}","starred_url":"https://api.github.com/users/huboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huboard/subscriptions","organizations_url":"https://api.github.com/users/huboard/orgs","repos_url":"https://api.github.com/users/huboard/repos","events_url":"https://api.github.com/users/huboard/events{/privacy}","received_events_url":"https://api.github.com/users/huboard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/huboard/huboard-web","description":"GitHub issues made awesome","fork":false,"url":"https://api.github.com/repos/huboard/huboard-web","forks_url":"https://api.github.com/repos/huboard/huboard-web/forks","keys_url":"https://api.github.com/repos/huboard/huboard-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huboard/huboard-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huboard/huboard-web/teams","hooks_url":"https://api.github.com/repos/huboard/huboard-web/hooks","issue_events_url":"https://api.github.com/repos/huboard/huboard-web/issues/events{/number}","events_url":"https://api.github.com/repos/huboard/huboard-web/events","assignees_url":"https://api.github.com/repos/huboard/huboard-web/assignees{/user}","branches_url":"https://api.github.com/repos/huboard/huboard-web/branches{/branch}","tags_url":"https://api.github.com/repos/huboard/huboard-web/tags","blobs_url":"https://api.github.com/repos/huboard/huboard-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huboard/huboard-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huboard/huboard-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/huboard/huboard-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huboard/huboard-web/statuses/{sha}","languages_url":"https://api.github.com/repos/huboard/huboard-web/languages","stargazers_url":"https://api.github.com/repos/huboard/huboard-web/stargazers","contributors_url":"https://api.github.com/repos/huboard/huboard-web/contributors","subscribers_url":"https://api.github.com/repos/huboard/huboard-web/subscribers","subscription_url":"https://api.github.com/repos/huboard/huboard-web/subscription","commits_url":"https://api.github.com/repos/huboard/huboard-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/huboard/huboard-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/huboard/huboard-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/huboard/huboard-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/huboard/huboard-web/contents/{+path}","compare_url":"https://api.github.com/repos/huboard/huboard-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huboard/huboard-web/merges","archive_url":"https://api.github.com/repos/huboard/huboard-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huboard/huboard-web/downloads","issues_url":"https://api.github.com/repos/huboard/huboard-web/issues{/number}","pulls_url":"https://api.github.com/repos/huboard/huboard-web/pulls{/number}","milestones_url":"https://api.github.com/repos/huboard/huboard-web/milestones{/number}","notifications_url":"https://api.github.com/repos/huboard/huboard-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huboard/huboard-web/labels{/name}","releases_url":"https://api.github.com/repos/huboard/huboard-web/releases{/id}","deployments_url":"https://api.github.com/repos/huboard/huboard-web/deployments","created_at":"2015-01-14T22:17:00Z","updated_at":"2016-02-01T19:50:11Z","pushed_at":"2016-02-17T19:23:02Z","git_url":"git://github.com/huboard/huboard-web.git","ssh_url":"git@github.com:huboard/huboard-web.git","clone_url":"https://github.com/huboard/huboard-web.git","svn_url":"https://github.com/huboard/huboard-web","homepage":"https://huboard.com","size":23699,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":42,"forks":19,"open_issues":42,"watchers":26,"default_branch":"master"}},"base":{"label":"huboard:master","ref":"master","sha":"5d45cf5e56d853c676ce9ff547b99be63d207cfb","user":{"login":"huboard","id":1236155,"avatar_url":"https://avatars.githubusercontent.com/u/1236155?v=3","gravatar_id":"","url":"https://api.github.com/users/huboard","html_url":"https://github.com/huboard","followers_url":"https://api.github.com/users/huboard/followers","following_url":"https://api.github.com/users/huboard/following{/other_user}","gists_url":"https://api.github.com/users/huboard/gists{/gist_id}","starred_url":"https://api.github.com/users/huboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huboard/subscriptions","organizations_url":"https://api.github.com/users/huboard/orgs","repos_url":"https://api.github.com/users/huboard/repos","events_url":"https://api.github.com/users/huboard/events{/privacy}","received_events_url":"https://api.github.com/users/huboard/received_events","type":"Organization","site_admin":false},"repo":{"id":29268631,"name":"huboard-web","full_name":"huboard/huboard-web","owner":{"login":"huboard","id":1236155,"avatar_url":"https://avatars.githubusercontent.com/u/1236155?v=3","gravatar_id":"","url":"https://api.github.com/users/huboard","html_url":"https://github.com/huboard","followers_url":"https://api.github.com/users/huboard/followers","following_url":"https://api.github.com/users/huboard/following{/other_user}","gists_url":"https://api.github.com/users/huboard/gists{/gist_id}","starred_url":"https://api.github.com/users/huboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huboard/subscriptions","organizations_url":"https://api.github.com/users/huboard/orgs","repos_url":"https://api.github.com/users/huboard/repos","events_url":"https://api.github.com/users/huboard/events{/privacy}","received_events_url":"https://api.github.com/users/huboard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/huboard/huboard-web","description":"GitHub issues made awesome","fork":false,"url":"https://api.github.com/repos/huboard/huboard-web","forks_url":"https://api.github.com/repos/huboard/huboard-web/forks","keys_url":"https://api.github.com/repos/huboard/huboard-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huboard/huboard-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huboard/huboard-web/teams","hooks_url":"https://api.github.com/repos/huboard/huboard-web/hooks","issue_events_url":"https://api.github.com/repos/huboard/huboard-web/issues/events{/number}","events_url":"https://api.github.com/repos/huboard/huboard-web/events","assignees_url":"https://api.github.com/repos/huboard/huboard-web/assignees{/user}","branches_url":"https://api.github.com/repos/huboard/huboard-web/branches{/branch}","tags_url":"https://api.github.com/repos/huboard/huboard-web/tags","blobs_url":"https://api.github.com/repos/huboard/huboard-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huboard/huboard-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huboard/huboard-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/huboard/huboard-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huboard/huboard-web/statuses/{sha}","languages_url":"https://api.github.com/repos/huboard/huboard-web/languages","stargazers_url":"https://api.github.com/repos/huboard/huboard-web/stargazers","contributors_url":"https://api.github.com/repos/huboard/huboard-web/contributors","subscribers_url":"https://api.github.com/repos/huboard/huboard-web/subscribers","subscription_url":"https://api.github.com/repos/huboard/huboard-web/subscription","commits_url":"https://api.github.com/repos/huboard/huboard-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/huboard/huboard-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/huboard/huboard-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/huboard/huboard-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/huboard/huboard-web/contents/{+path}","compare_url":"https://api.github.com/repos/huboard/huboard-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huboard/huboard-web/merges","archive_url":"https://api.github.com/repos/huboard/huboard-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huboard/huboard-web/downloads","issues_url":"https://api.github.com/repos/huboard/huboard-web/issues{/number}","pulls_url":"https://api.github.com/repos/huboard/huboard-web/pulls{/number}","milestones_url":"https://api.github.com/repos/huboard/huboard-web/milestones{/number}","notifications_url":"https://api.github.com/repos/huboard/huboard-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huboard/huboard-web/labels{/name}","releases_url":"https://api.github.com/repos/huboard/huboard-web/releases{/id}","deployments_url":"https://api.github.com/repos/huboard/huboard-web/deployments","created_at":"2015-01-14T22:17:00Z","updated_at":"2016-02-01T19:50:11Z","pushed_at":"2016-02-17T19:23:02Z","git_url":"git://github.com/huboard/huboard-web.git","ssh_url":"git@github.com:huboard/huboard-web.git","clone_url":"https://github.com/huboard/huboard-web.git","svn_url":"https://github.com/huboard/huboard-web","homepage":"https://huboard.com","size":23699,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":42,"forks":19,"open_issues":42,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/huboard/huboard-web/pulls/204"},"html":{"href":"https://github.com/huboard/huboard-web/pull/204"},"issue":{"href":"https://api.github.com/repos/huboard/huboard-web/issues/204"},"comments":{"href":"https://api.github.com/repos/huboard/huboard-web/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/huboard/huboard-web/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/huboard/huboard-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/huboard/huboard-web/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/huboard/huboard-web/statuses/1caefe4b97d2e94f16ba1cc2db522f28a87a5640"}}}}