{"action":"created","issue":{"url":"https://api.github.com/repos/xanzy/go-cloudstack/issues/46","labels_url":"https://api.github.com/repos/xanzy/go-cloudstack/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/xanzy/go-cloudstack/issues/46/comments","events_url":"https://api.github.com/repos/xanzy/go-cloudstack/issues/46/events","html_url":"https://github.com/xanzy/go-cloudstack/pull/46","id":128665976,"number":46,"title":"Specify proper key/value names for serviceproviderlist","user":{"login":"Carles-Figuerola","id":13749641,"avatar_url":"https://avatars.githubusercontent.com/u/13749641?v=3","gravatar_id":"","url":"https://api.github.com/users/Carles-Figuerola","html_url":"https://github.com/Carles-Figuerola","followers_url":"https://api.github.com/users/Carles-Figuerola/followers","following_url":"https://api.github.com/users/Carles-Figuerola/following{/other_user}","gists_url":"https://api.github.com/users/Carles-Figuerola/gists{/gist_id}","starred_url":"https://api.github.com/users/Carles-Figuerola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carles-Figuerola/subscriptions","organizations_url":"https://api.github.com/users/Carles-Figuerola/orgs","repos_url":"https://api.github.com/users/Carles-Figuerola/repos","events_url":"https://api.github.com/users/Carles-Figuerola/events{/privacy}","received_events_url":"https://api.github.com/users/Carles-Figuerola/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-25T22:58:26Z","updated_at":"2016-01-26T07:31:30Z","closed_at":"2016-01-26T07:31:30Z","pull_request":{"url":"https://api.github.com/repos/xanzy/go-cloudstack/pulls/46","html_url":"https://github.com/xanzy/go-cloudstack/pull/46","diff_url":"https://github.com/xanzy/go-cloudstack/pull/46.diff","patch_url":"https://github.com/xanzy/go-cloudstack/pull/46.patch"},"body":"Change the behaviour of serviceproviderlist on networkoffering so the proper key/value names are passed. Originally a request looks like this:\r\n\r\n```\r\nhttp://cloudstackhost:8080/client/api?\r\napiKey=REDACTED\r\ncommand=createNetworkOffering\r\ndisplaytext=networkoffering_test2\r\nguestiptype=isolated\r\nname=networkoffering_test2\r\nresponse=json\r\nserviceproviderlist[0].key=userdata\r\nserviceproviderlist[0].value=VirtualRouter\r\nserviceproviderlist[1].key=dhcp\r\nserviceproviderlist[1].value=VirtualRouter\r\nsupportedservices=userdata%2Cdhcp\r\ntraffictype=GUEST\r\n```\r\nand fails with:\r\n\r\n```\r\nCloudStack API error 431 (CSExceptionErrorCode: 4350): Service null is not enabled for the network offering, can't add a provider to it\r\n```\r\n\r\nWhereas cloudmonkey passes the proper values:\r\n\r\n```\r\nhttp://cloudstackhost:8080/client/api?\r\napiKey=REDACTED\r\ncommand=createNetworkOffering\r\ndisplaytext=networkoffering_test2\r\nguestiptype=isolated\r\nname=networkoffering_test2\r\nresponse=json\r\nserviceproviderlist[0].provider=VirtualRouter\r\nserviceproviderlist[0].service=userdata\r\nserviceproviderlist[1].provider=VirtualRouter\r\nserviceproviderlist[1].service=dhcp\r\nsupportedservices=userdata%2Cdhcp\r\ntraffictype=GUEST\r\n```"},"comment":{"url":"https://api.github.com/repos/xanzy/go-cloudstack/issues/comments/174872488","html_url":"https://github.com/xanzy/go-cloudstack/pull/46#issuecomment-174872488","issue_url":"https://api.github.com/repos/xanzy/go-cloudstack/issues/46","id":174872488,"user":{"login":"svanharmelen","id":4171547,"avatar_url":"https://avatars.githubusercontent.com/u/4171547?v=3","gravatar_id":"","url":"https://api.github.com/users/svanharmelen","html_url":"https://github.com/svanharmelen","followers_url":"https://api.github.com/users/svanharmelen/followers","following_url":"https://api.github.com/users/svanharmelen/following{/other_user}","gists_url":"https://api.github.com/users/svanharmelen/gists{/gist_id}","starred_url":"https://api.github.com/users/svanharmelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svanharmelen/subscriptions","organizations_url":"https://api.github.com/users/svanharmelen/orgs","repos_url":"https://api.github.com/users/svanharmelen/repos","events_url":"https://api.github.com/users/svanharmelen/events{/privacy}","received_events_url":"https://api.github.com/users/svanharmelen/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T07:31:30Z","updated_at":"2016-01-26T07:31:30Z","body":"I'll close this one as it's not possible to merge the changes like this. If you're having trouble making the needed changes is the `generate` package, then it's also fine to open an issue for this. Then I will try to find a generic fix that we can add. As I suspect more API's could be suffering from this.\r\n\r\nBy the way cool that you are using this package in a slightly different way and with some different calls, as it seems we have a nice change of improving some stuff :grinning: "}}