{"action":"created","issue":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/134","repository_url":"https://api.github.com/repos/conda-forge/conda-smithy","labels_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/134/comments","events_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/134/events","html_url":"https://github.com/conda-forge/conda-smithy/pull/134","id":148067951,"number":134,"title":"Added the ability to add extra yum deps to the feedstock.","user":{"login":"pelson","id":810663,"avatar_url":"https://avatars.githubusercontent.com/u/810663?v=3","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2016-04-13T13:52:27Z","updated_at":"2016-05-12T07:28:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/pulls/134","html_url":"https://github.com/conda-forge/conda-smithy/pull/134","diff_url":"https://github.com/conda-forge/conda-smithy/pull/134.diff","patch_url":"https://github.com/conda-forge/conda-smithy/pull/134.patch"},"body":"This PR enables the ```recipe/yum_requirements.txt``` capability. Crucially, unlike #135 it puts the yum requirements explicitly into the ```run_docker_build.sh``` at ```conda smithy rerender``` time, rather than inspecting the ```yum_requirements.txt``` at *build* time.\r\n\r\n\r\n-----------\r\nThe following content is out of date:\r\n\r\n\r\nWith this change, one can add the following to a conda-forge.yml and expect their build script to add appropriate yum build dependencies:\r\n\r\n```\r\n+++ b/conda-forge.yml\r\n@@ -4,3 +4,6 @@\r\n+  extra-yum-pkgs:\r\n+    - mesa-libGL-devel\r\n```\r\n\r\nThere is no guarantee that this is a usable build unless the package is installed on a user's machine also,  so this capability should be used *exceptionally* scarcely."},"comment":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/comments/218680792","html_url":"https://github.com/conda-forge/conda-smithy/pull/134#issuecomment-218680792","issue_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/134","id":218680792,"user":{"login":"pelson","id":810663,"avatar_url":"https://avatars.githubusercontent.com/u/810663?v=3","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T07:28:57Z","updated_at":"2016-05-12T07:28:57Z","body":"So, in order to unblock https://github.com/conda-forge/staged-recipes/pull/568 I will merge this. My rationale is as follows: \r\n * it *doesn't* tie us into a way of doing things (well, short of having a `recipe/yum_requirements.txt`, which we both agree on)\r\n * impact of backing out of the change is far smaller than it would be with #135 \r\n * we aren't closing the door on #135 - it is a supplementary change that we can add at a later date (even if that means next week)\r\n\r\nThe **huge** downside for me about doing this though is that it is my PR rather than yours which is being merged - I really don't want this to be seen as a slight on your PR which has in no small part influenced where this PR has ended up.\r\n\r\nThere are a number of changes backing up in `conda-smithy`, and I'm going to get them out of the door ASAP. Happy to release again in short order (as has been done before) if new features are introduced.\r\n"}}