{"action":"closed","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/6067","repository_url":"https://api.github.com/repos/scipy/scipy","labels_url":"https://api.github.com/repos/scipy/scipy/issues/6067/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/6067/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/6067/events","html_url":"https://github.com/scipy/scipy/issues/6067","id":148373404,"number":6067,"title":"Bug in scipy.signal.resample() when using a window","user":{"login":"s9w","id":6044318,"avatar_url":"https://avatars.githubusercontent.com/u/6044318?v=3","gravatar_id":"","url":"https://api.github.com/users/s9w","html_url":"https://github.com/s9w","followers_url":"https://api.github.com/users/s9w/followers","following_url":"https://api.github.com/users/s9w/following{/other_user}","gists_url":"https://api.github.com/users/s9w/gists{/gist_id}","starred_url":"https://api.github.com/users/s9w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s9w/subscriptions","organizations_url":"https://api.github.com/users/s9w/orgs","repos_url":"https://api.github.com/users/s9w/repos","events_url":"https://api.github.com/users/s9w/events{/privacy}","received_events_url":"https://api.github.com/users/s9w/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scipy/scipy/labels/scipy.signal","name":"scipy.signal","color":"207de5"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-04-14T14:08:54Z","updated_at":"2016-08-10T17:02:14Z","closed_at":"2016-08-10T17:02:14Z","body":"The `signal.resample()` function accepts an optional parameter to specify a window in frequency domain. If that's done with a tuple with name and parameter, the window is retrieved from another function. Relevant code from [signaltools.py](https://github.com/scipy/scipy/blob/master/scipy/signal/signaltools.py#L1848):\r\n\r\n```\r\nif window is not None:\r\n    if callable(window):\r\n        # ...\r\n    elif isinstance(window, ndarray):\r\n        # ...\r\n    else:\r\n        W = fftpack.ifftshift(get_window(window, Nx))\r\n```\r\n\r\nHowever that `get_window()` function returns the window in time- and not frequency domain! Which is obviously not correct. The `get_window()` can be found [here in the windows.py](https://github.com/scipy/scipy/blob/master/scipy/signal/windows.py#L1610)."}}
{"actor":{"display_login":"e-q"}}