{"action":"created","issue":{"url":"https://api.github.com/repos/chentsulin/electron-react-boilerplate/issues/527","repository_url":"https://api.github.com/repos/chentsulin/electron-react-boilerplate","labels_url":"https://api.github.com/repos/chentsulin/electron-react-boilerplate/issues/527/labels{/name}","comments_url":"https://api.github.com/repos/chentsulin/electron-react-boilerplate/issues/527/comments","events_url":"https://api.github.com/repos/chentsulin/electron-react-boilerplate/issues/527/events","html_url":"https://github.com/chentsulin/electron-react-boilerplate/issues/527","id":188000369,"number":527,"title":"Package uses different electron version than electron-prebuilt","user":{"login":"stefanKuijers","id":1039326,"avatar_url":"https://avatars.githubusercontent.com/u/1039326?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanKuijers","html_url":"https://github.com/stefanKuijers","followers_url":"https://api.github.com/users/stefanKuijers/followers","following_url":"https://api.github.com/users/stefanKuijers/following{/other_user}","gists_url":"https://api.github.com/users/stefanKuijers/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanKuijers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanKuijers/subscriptions","organizations_url":"https://api.github.com/users/stefanKuijers/orgs","repos_url":"https://api.github.com/users/stefanKuijers/repos","events_url":"https://api.github.com/users/stefanKuijers/events{/privacy}","received_events_url":"https://api.github.com/users/stefanKuijers/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-08T14:07:16Z","updated_at":"2016-11-09T10:02:28Z","closed_at":"2016-11-08T21:27:15Z","body":"## Downgrade\r\nI was forced to downgrade electon to 1.2.8 because I want to make integrate node-sass into my app. \r\n\r\nSo I changed package.json to include electron-prebuild 1.2.8. Deleted the electron-prebuilt folder and ran npm install. \r\nI changed ```node_modules/.bin/electron``` to point to ```electron-prebuilt/cli.js``` instead of ```electron/cli.js```.\r\n\r\nWhen I run ```npm run dev``` and check the ```process.versions```.\r\n```\r\nNode: 6.1.0\r\nElectron: 1.2.8\r\nmodules (V8): 48\r\n```\r\n\r\n## Problem\r\nThe problem comes after I pack the app. ```npm run package-win```. **The packing runs as expected** _however_ I do see that in the logs it used electron version 1.4.5. I checked the process.versions in the running packaged app and it returns the following:\r\n```\r\nNode: 6.5.0,\r\nElectron: 1.4.5\r\nmodules (V8): 50\r\n```\r\n\r\nIn any other case fine except that node-sass won't work which is one of the main features of the app. \r\n\r\n## Solution\r\nI found ```node_modules/electron``` and deleted it. After that I repackaged my app and it build with the right version of electron.\r\n\r\nBecause of these issues I assumed that it would automatically pickup the same version as I installed with electron-prebuilt:\r\nhttps://github.com/webpack/webpack/issues/1463\r\nhttps://github.com/chentsulin/electron-react-boilerplate/commit/ef2e24fee1e8ac4285e1068d418e688d1c0a16bb\r\nhttps://github.com/chentsulin/electron-react-boilerplate/issues/33\r\n\r\nJust opening an issue cause it might be good to add this to the docs or in case someone else is forced to downgrade.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/chentsulin/electron-react-boilerplate/issues/comments/259376425","html_url":"https://github.com/chentsulin/electron-react-boilerplate/issues/527#issuecomment-259376425","issue_url":"https://api.github.com/repos/chentsulin/electron-react-boilerplate/issues/527","id":259376425,"user":{"login":"stefanKuijers","id":1039326,"avatar_url":"https://avatars.githubusercontent.com/u/1039326?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanKuijers","html_url":"https://github.com/stefanKuijers","followers_url":"https://api.github.com/users/stefanKuijers/followers","following_url":"https://api.github.com/users/stefanKuijers/following{/other_user}","gists_url":"https://api.github.com/users/stefanKuijers/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanKuijers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanKuijers/subscriptions","organizations_url":"https://api.github.com/users/stefanKuijers/orgs","repos_url":"https://api.github.com/users/stefanKuijers/repos","events_url":"https://api.github.com/users/stefanKuijers/events{/privacy}","received_events_url":"https://api.github.com/users/stefanKuijers/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T10:02:28Z","updated_at":"2016-11-09T10:02:28Z","body":"For now the solution that I proposed before is enough for me.\r\n> I found node_modules/electron and deleted it. After that I repackaged my app and it build with the right version of electron.\r\n\r\nWe should keep in mind that this a an edge-case. 80%+ of the users will want to use the latest version of Electron. 10% might downgrade but not as many versions back as I had to. This was for a very specific purpose: working with node-sass. based on that:\r\nI'm not sure I would put time into finding a better solution as deleting one folder and maybe changing 4 paths over 2 files. \r\n\r\nMakes sense right?"}}
{"actor":{"display_login":"stefanKuijers"}}