{"action":"created","comment":{"url":"https://api.github.com/repos/ScalABM/agora/pulls/comments/80357559","id":80357559,"diff_hunk":"@@ -30,9 +30,9 @@ class PriorityOrderBookSpec extends AbstractOrderBookSpec {\n \n   val prng = new Random(1234)\n \n-  def askOrderBookFactory(tradable: Security) = PriorityOrderBook[AskOrder](tradable)\n+  def askOrderBookFactory(tradable: Security) = PriorityOrderBook[BidOrder, AskOrder](tradable)\n \n-  def bidOrderBookFactory(tradable: Security) = PriorityOrderBook[BidOrder](tradable)\n+  def bidOrderBookFactory(tradable: Security) = PriorityOrderBook[AskOrder, BidOrder](tradable)","path":"src/test/scala-2.11/markets/mutable/orderbooks/PriorityOrderBookSpec.scala","position":19,"original_position":19,"commit_id":"2e3816e774a75e7ef3357318cec7bd7105ba9e95","original_commit_id":"2e3816e774a75e7ef3357318cec7bd7105ba9e95","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Public method must have explicit type](https://www.codacy.com/app/davidrpugh/markets-sandbox/file/4030661555/issues/source?bid=2921361&fileBranchId=3741064#l35)","created_at":"2016-09-24T09:37:04Z","updated_at":"2016-09-24T09:37:04Z","html_url":"https://github.com/ScalABM/agora/pull/185#discussion_r80357559","pull_request_url":"https://api.github.com/repos/ScalABM/agora/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/ScalABM/agora/pulls/comments/80357559"},"html":{"href":"https://github.com/ScalABM/agora/pull/185#discussion_r80357559"},"pull_request":{"href":"https://api.github.com/repos/ScalABM/agora/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/ScalABM/agora/pulls/185","id":86608981,"html_url":"https://github.com/ScalABM/agora/pull/185","diff_url":"https://github.com/ScalABM/agora/pull/185.diff","patch_url":"https://github.com/ScalABM/agora/pull/185.patch","issue_url":"https://api.github.com/repos/ScalABM/agora/issues/185","number":185,"state":"open","locked":false,"title":"Add boolean function","user":{"login":"davidrpugh","id":2219562,"avatar_url":"https://avatars.githubusercontent.com/u/2219562?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrpugh","html_url":"https://github.com/davidrpugh","followers_url":"https://api.github.com/users/davidrpugh/followers","following_url":"https://api.github.com/users/davidrpugh/following{/other_user}","gists_url":"https://api.github.com/users/davidrpugh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrpugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrpugh/subscriptions","organizations_url":"https://api.github.com/users/davidrpugh/orgs","repos_url":"https://api.github.com/users/davidrpugh/repos","events_url":"https://api.github.com/users/davidrpugh/events{/privacy}","received_events_url":"https://api.github.com/users/davidrpugh/received_events","type":"User","site_admin":false},"body":"This PR is for adding the most basic way to represent preferences via an `Order`: a Boolean function.","created_at":"2016-09-24T06:13:45Z","updated_at":"2016-09-24T09:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb226c3b06f54bdcc02c4d70485c7aef22bcddfa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ScalABM/agora/pulls/185/commits","review_comments_url":"https://api.github.com/repos/ScalABM/agora/pulls/185/comments","review_comment_url":"https://api.github.com/repos/ScalABM/agora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScalABM/agora/issues/185/comments","statuses_url":"https://api.github.com/repos/ScalABM/agora/statuses/2e3816e774a75e7ef3357318cec7bd7105ba9e95","head":{"label":"ScalABM:add-boolean-function","ref":"add-boolean-function","sha":"2e3816e774a75e7ef3357318cec7bd7105ba9e95","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"agora","full_name":"ScalABM/agora","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/agora","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/agora","forks_url":"https://api.github.com/repos/ScalABM/agora/forks","keys_url":"https://api.github.com/repos/ScalABM/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/agora/teams","hooks_url":"https://api.github.com/repos/ScalABM/agora/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/agora/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/agora/events","assignees_url":"https://api.github.com/repos/ScalABM/agora/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/agora/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/agora/tags","blobs_url":"https://api.github.com/repos/ScalABM/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/agora/languages","stargazers_url":"https://api.github.com/repos/ScalABM/agora/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/agora/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/agora/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/agora/subscription","commits_url":"https://api.github.com/repos/ScalABM/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/agora/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/agora/merges","archive_url":"https://api.github.com/repos/ScalABM/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/agora/downloads","issues_url":"https://api.github.com/repos/ScalABM/agora/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/agora/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/agora/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/agora/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-09-15T15:30:59Z","pushed_at":"2016-09-24T09:35:11Z","git_url":"git://github.com/ScalABM/agora.git","ssh_url":"git@github.com:ScalABM/agora.git","clone_url":"https://github.com/ScalABM/agora.git","svn_url":"https://github.com/ScalABM/agora","homepage":null,"size":1116,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":21,"forks":1,"open_issues":21,"watchers":1,"default_branch":"master"}},"base":{"label":"ScalABM:develop","ref":"develop","sha":"e1f4492460beff014d60c072d9e0ae95fdad3024","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"agora","full_name":"ScalABM/agora","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/agora","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/agora","forks_url":"https://api.github.com/repos/ScalABM/agora/forks","keys_url":"https://api.github.com/repos/ScalABM/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/agora/teams","hooks_url":"https://api.github.com/repos/ScalABM/agora/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/agora/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/agora/events","assignees_url":"https://api.github.com/repos/ScalABM/agora/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/agora/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/agora/tags","blobs_url":"https://api.github.com/repos/ScalABM/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/agora/languages","stargazers_url":"https://api.github.com/repos/ScalABM/agora/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/agora/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/agora/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/agora/subscription","commits_url":"https://api.github.com/repos/ScalABM/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/agora/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/agora/merges","archive_url":"https://api.github.com/repos/ScalABM/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/agora/downloads","issues_url":"https://api.github.com/repos/ScalABM/agora/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/agora/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/agora/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/agora/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-09-15T15:30:59Z","pushed_at":"2016-09-24T09:35:11Z","git_url":"git://github.com/ScalABM/agora.git","ssh_url":"git@github.com:ScalABM/agora.git","clone_url":"https://github.com/ScalABM/agora.git","svn_url":"https://github.com/ScalABM/agora","homepage":null,"size":1116,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":21,"forks":1,"open_issues":21,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScalABM/agora/pulls/185"},"html":{"href":"https://github.com/ScalABM/agora/pull/185"},"issue":{"href":"https://api.github.com/repos/ScalABM/agora/issues/185"},"comments":{"href":"https://api.github.com/repos/ScalABM/agora/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/ScalABM/agora/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/ScalABM/agora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScalABM/agora/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/ScalABM/agora/statuses/2e3816e774a75e7ef3357318cec7bd7105ba9e95"}}}}
{"actor":{"display_login":"codacy-bot"}}