{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/77872473","id":77872473,"diff_hunk":"@@ -351,16 +347,19 @@ class GpdbRestore(Operation):\n         \"\"\"\n \n         if self.context.timestamp:\n-            (restore_timestamp, restore_db, compress) = ValidateTimestamp(self.context).run()\n+            (restore_timestamp, restore_db, compress, old_format) = ValidateTimestamp(self.context).run()","path":"gpMgmt/bin/gpdbrestore","position":34,"original_position":34,"commit_id":"2c06d829b9e5a9489e45936729a3d61691c39161","original_commit_id":"2c06d829b9e5a9489e45936729a3d61691c39161","user":{"login":"Chibin","id":1973117,"avatar_url":"https://avatars.githubusercontent.com/u/1973117?v=3","gravatar_id":"","url":"https://api.github.com/users/Chibin","html_url":"https://github.com/Chibin","followers_url":"https://api.github.com/users/Chibin/followers","following_url":"https://api.github.com/users/Chibin/following{/other_user}","gists_url":"https://api.github.com/users/Chibin/gists{/gist_id}","starred_url":"https://api.github.com/users/Chibin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chibin/subscriptions","organizations_url":"https://api.github.com/users/Chibin/orgs","repos_url":"https://api.github.com/users/Chibin/repos","events_url":"https://api.github.com/users/Chibin/events{/privacy}","received_events_url":"https://api.github.com/users/Chibin/received_events","type":"User","site_admin":false},"body":"ValidateTimestamp returns self.context.use_old_filename_format as old_format ... what's the point of this?","created_at":"2016-09-07T17:53:24Z","updated_at":"2016-09-07T17:53:24Z","html_url":"https://github.com/greenplum-db/gpdb/pull/1078#discussion_r77872473","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/77872473"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1078#discussion_r77872473"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078","id":82965320,"html_url":"https://github.com/greenplum-db/gpdb/pull/1078","diff_url":"https://github.com/greenplum-db/gpdb/pull/1078.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1078.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1078","number":1078,"state":"open","locked":false,"title":"Changed backup file naming conventions to incorporate content id.","user":{"login":"Chibin","id":1973117,"avatar_url":"https://avatars.githubusercontent.com/u/1973117?v=3","gravatar_id":"","url":"https://api.github.com/users/Chibin","html_url":"https://github.com/Chibin","followers_url":"https://api.github.com/users/Chibin/followers","following_url":"https://api.github.com/users/Chibin/following{/other_user}","gists_url":"https://api.github.com/users/Chibin/gists{/gist_id}","starred_url":"https://api.github.com/users/Chibin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chibin/subscriptions","organizations_url":"https://api.github.com/users/Chibin/orgs","repos_url":"https://api.github.com/users/Chibin/repos","events_url":"https://api.github.com/users/Chibin/events{/privacy}","received_events_url":"https://api.github.com/users/Chibin/received_events","type":"User","site_admin":false},"body":"Description by @jmcatamney \r\nPreviously, backup files were keyed only to the dbid of the segment from\r\nwhich they were backed up, which caused problems when trying to restore\r\nfiles backed up on a mirror segment, restore files to a new cluster with\r\na different dbid mapping, and so forth.\r\n\r\nThis commit fixes the above issues by changing the backup file naming\r\nconvention to incorporate the content id of the backed-up segment and\r\nenables restoring files based on the content id. Also, gpdbrestore\r\nseamlessly handles mixing the old and new filename formats, so users can\r\ncontinue making incremental backups on top of full and incremental backups\r\nusing the old format after beginning to use this version of gpcrondump.\r\n","created_at":"2016-08-26T22:54:51Z","updated_at":"2016-09-07T17:53:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5aaf60419a6cf905cad204b7b07fcdac61e82a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1078/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/2c06d829b9e5a9489e45936729a3d61691c39161","head":{"label":"Chibin:content_id","ref":"content_id","sha":"2c06d829b9e5a9489e45936729a3d61691c39161","user":{"login":"Chibin","id":1973117,"avatar_url":"https://avatars.githubusercontent.com/u/1973117?v=3","gravatar_id":"","url":"https://api.github.com/users/Chibin","html_url":"https://github.com/Chibin","followers_url":"https://api.github.com/users/Chibin/followers","following_url":"https://api.github.com/users/Chibin/following{/other_user}","gists_url":"https://api.github.com/users/Chibin/gists{/gist_id}","starred_url":"https://api.github.com/users/Chibin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chibin/subscriptions","organizations_url":"https://api.github.com/users/Chibin/orgs","repos_url":"https://api.github.com/users/Chibin/repos","events_url":"https://api.github.com/users/Chibin/events{/privacy}","received_events_url":"https://api.github.com/users/Chibin/received_events","type":"User","site_admin":false},"repo":{"id":45487529,"name":"gpdb","full_name":"Chibin/gpdb","owner":{"login":"Chibin","id":1973117,"avatar_url":"https://avatars.githubusercontent.com/u/1973117?v=3","gravatar_id":"","url":"https://api.github.com/users/Chibin","html_url":"https://github.com/Chibin","followers_url":"https://api.github.com/users/Chibin/followers","following_url":"https://api.github.com/users/Chibin/following{/other_user}","gists_url":"https://api.github.com/users/Chibin/gists{/gist_id}","starred_url":"https://api.github.com/users/Chibin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chibin/subscriptions","organizations_url":"https://api.github.com/users/Chibin/orgs","repos_url":"https://api.github.com/users/Chibin/repos","events_url":"https://api.github.com/users/Chibin/events{/privacy}","received_events_url":"https://api.github.com/users/Chibin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chibin/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/Chibin/gpdb","forks_url":"https://api.github.com/repos/Chibin/gpdb/forks","keys_url":"https://api.github.com/repos/Chibin/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chibin/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chibin/gpdb/teams","hooks_url":"https://api.github.com/repos/Chibin/gpdb/hooks","issue_events_url":"https://api.github.com/repos/Chibin/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/Chibin/gpdb/events","assignees_url":"https://api.github.com/repos/Chibin/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/Chibin/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/Chibin/gpdb/tags","blobs_url":"https://api.github.com/repos/Chibin/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chibin/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chibin/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chibin/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chibin/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/Chibin/gpdb/languages","stargazers_url":"https://api.github.com/repos/Chibin/gpdb/stargazers","contributors_url":"https://api.github.com/repos/Chibin/gpdb/contributors","subscribers_url":"https://api.github.com/repos/Chibin/gpdb/subscribers","subscription_url":"https://api.github.com/repos/Chibin/gpdb/subscription","commits_url":"https://api.github.com/repos/Chibin/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chibin/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chibin/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chibin/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chibin/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/Chibin/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chibin/gpdb/merges","archive_url":"https://api.github.com/repos/Chibin/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chibin/gpdb/downloads","issues_url":"https://api.github.com/repos/Chibin/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/Chibin/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/Chibin/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/Chibin/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chibin/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/Chibin/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/Chibin/gpdb/deployments","created_at":"2015-11-03T18:38:29Z","updated_at":"2016-02-04T23:52:15Z","pushed_at":"2016-09-02T16:34:59Z","git_url":"git://github.com/Chibin/gpdb.git","ssh_url":"git@github.com:Chibin/gpdb.git","clone_url":"https://github.com/Chibin/gpdb.git","svn_url":"https://github.com/Chibin/gpdb","homepage":"http://greenplum.org","size":176039,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"ed004c4b1ac2716a9ce034d04bcdda33fd3f1e7d","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-09-07T14:37:56Z","pushed_at":"2016-09-07T16:39:48Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":228367,"stargazers_count":1599,"watchers_count":1599,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"open_issues_count":106,"forks":444,"open_issues":106,"watchers":1599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1078"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1078"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1078/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1078/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/2c06d829b9e5a9489e45936729a3d61691c39161"}}}}
{"actor":{"display_login":"Chibin"}}