{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27714","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27714/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27714/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27714/events","html_url":"https://github.com/kubernetes/kubernetes/pull/27714","id":161171662,"number":27714,"title":"Send recycle events from pod to pv.","user":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/storage","name":"area/storage","color":"006b75"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cherrypick-approved","name":"cherrypick-approved","color":"fef2c0"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P0","name":"priority/P0","color":"e11d21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/cluster","name":"team/cluster","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/17","html_url":"https://github.com/kubernetes/kubernetes/milestones/next-candidate","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/17/labels","id":1510379,"number":17,"title":"next-candidate","description":"Candidates for the next milestone","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":300,"closed_issues":129,"state":"open","created_at":"2016-01-16T17:58:20Z","updated_at":"2016-08-16T20:33:46Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-06-20T11:13:55Z","updated_at":"2016-08-17T08:43:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27714","html_url":"https://github.com/kubernetes/kubernetes/pull/27714","diff_url":"https://github.com/kubernetes/kubernetes/pull/27714.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27714.patch"},"body":"This allows users to diagnose what's wrong with recycler. Recycler pods are started automatically with a cryptic name and they are deleted immediately when they finish.\r\n\r\ne.g, `kubectl describe pv` could show that NFS cannot be mounted (and how many pods have tried it):\r\n\r\n```\r\n  FirstSeen     LastSeen        Count   From                            SubobjectPath   Type            Reason          Message\r\n  ---------     --------        -----   ----                            -------------   --------        ------          -------\r\n  59m           59m             1       {persistentvolume-controller }                  Warning         RecyclerPod     Recycler pod: Unable to mount volumes for pod \"recycler-for-nfs_default(5421800e-347b-11e6-a79b-3c970e965218)\": timeout expired waiting for volumes to attach/mount for pod \"recycler-for-nfs\"/\"default\". list of unattached/unmounted volumes=[vol]\r\n  53m           53m             1       {persistentvolume-controller }                  Warning         RecyclerPod     Recycler pod: Unable to mount volumes for pod \"recycler-for-nfs_default(3c9809e5-347c-11e6-a79b-3c970e965218)\": timeout expired waiting for volumes to attach/mount for pod \"recycler-for-nfs\"/\"default\". list of unattached/unmounted volumes=[vol]\r\n  46m           46m             1       {persistentvolume-controller }                  Warning         RecyclerPod     Recycler pod: Unable to mount volumes for pod \"recycler-for-nfs_default(250dd2a2-347d-11e6-a79b-3c970e965218)\": timeout expired waiting for volumes to attach/mount for pod \"recycler-for-nfs\"/\"default\". list of unattached/unmounted volumes=[vol]\r\n  40m           40m             1       {persistentvolume-controller }                  Warning         RecyclerPod     Recycler pod: Unable to mount volumes for pod \"recycler-for-nfs_default(0d84ea33-347e-11e6-a79b-3c970e965218)\": timeout expired waiting for volumes to attach/mount for pod \"recycler-for-nfs\"/\"default\". list of unattached/unmounted volumes=[vol]\r\n  33m           33m             1       {persistentvolume-controller }                  Warning         RecyclerPod     Recycler pod: Unable to mount volumes for pod \"recycler-for-nfs_default(f5fb63bf-347e-11e6-a79b-3c970e965218)\": timeout expired waiting for volumes to attach/mount for pod \"recycler-for-nfs\"/\"default\". list of unattached/unmounted volumes=[vol]\r\n  27m           27m             1       {persistentvolume-controller }                  Warning         RecyclerPod     Recycler pod: Unable to mount volumes for pod \"recycler-for-nfs_default(de7128fd-347f-11e6-a79b-3c970e965218)\": timeout expired waiting for volumes to attach/mount for pod \"recycler-for-nfs\"/\"default\". list of unattached/unmounted volumes=[vol]\r\n  1h            3m              75      {persistentvolume-controller }                  Normal          RecyclerPod     Recycler pod: Successfully assigned recycler-for-nfs to 127.0.0.1\r\n  1h            3m              76      {persistentvolume-controller }                  Normal          RecyclerPod     Recycler pod: Pod was active on the node longer than specified deadline\r\n  1h            1m              12      {persistentvolume-controller }                  Warning         RecyclerPod     Recycler pod: Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod \"recycler-for-nfs\"/\"default\". list of unattached/unmounted volumes=[vol]\r\n  20m           1m              4       {persistentvolume-controller }                  Warning         RecyclerPod     (events with common reason combined)\r\n```\r\n\r\nThese steps were necessary:\r\n\r\n- added event watcher to volume.RecycleVolumeByWatchingPodUntilCompletion\r\n- pass all these events through volume plugins to volume controller\r\n- rework volume.RecycleVolumeByWatchingPodUntilCompletion unit tests to a table (too much copy-paste)\r\n- fix all unit tests along the way\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/27714)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/240350490","html_url":"https://github.com/kubernetes/kubernetes/pull/27714#issuecomment-240350490","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27714","id":240350490,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T08:43:23Z","updated_at":"2016-08-17T08:43:23Z","body":"GCE e2e build/test **passed** for commit 7f29bbfccfc4fb6845f876d6ce7c529cf599b216.\n* [Test Results](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/27714/kubernetes-pull-build-test-e2e-gce/54016)\n* [Build Log](http://pr-test.k8s.io/27714/kubernetes-pull-build-test-e2e-gce/54016/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/27714/kubernetes-pull-build-test-e2e-gce/54016/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//54016)\n\n"}}
{"actor":{"display_login":"k8s-bot"}}