{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/comments/78208458","id":78208458,"diff_hunk":"@@ -143,20 +143,82 @@ personal-tax-account {\n   path = \"/personal-account\"\n }\n \n-two-step-verification {\n-  enabled = false\n-  host = ${company-auth.host}\n-  path = \"/coafe/two-step-verification/register\"\n-}\n-\n two-step-verification-required {\n   host = ${business-tax-account.host}\n   path = \"/business-account/two-step-verification/failed\"\n }\n \n+user-delegation-frontend {\n+  host = \"http://localhost:9851\"\n+  path = \"/user-delegation\"\n+}\n+\n+self-assessment-enrolments = [\"enr3\", \"enr4\"]\n+vat-enrolments = [\"enr5\", \"enr6\"]\n+\n company-auth.host = \"http://localhost:9025\"\n contact-frontend.host = \"http://localhost:9250\"\n tax-account-router.host = \"http://localhost:9280\"\n-\n business-enrolments = \"enr1,enr2\"\n-self-assessment-enrolments = \"enr3,enr4\"\n+\n+locations {\n+  two-step-verification-optional {\n+    name = \"two-step-verification\"\n+    url = ${two-step-verification.host}${two-step-verification.path}\n+    queryparams {\n+      continue = ${locations.bta.url}\n+      failure = ${locations.bta.url}\n+      origin = \"business-tax-account\"\n+    }\n+  }\n+  two-step-verification-mandatory {\n+    name = \"two-step-verification\"\n+    url = ${two-step-verification.host}${two-step-verification.path}\n+    queryparams {\n+      continue = ${locations.bta.url}\n+      failure = ${locations.tax-account-router.url}\n+      origin = \"business-tax-account\"\n+    }\n+  }\n+  set-up-extra-security {\n+    name = \"set-up-extra-security\"\n+    url = ${user-delegation-frontend.host}${user-delegation-frontend.path}\"/set-up-extra-security\"\n+  }\n+  bta {\n+    name = \"business-tax-account\"\n+    url = ${business-tax-account.host}${business-tax-account.path}\n+  }\n+  tax-account-router{\n+    name = \"tax-account-router\"\n+    url = ${tax-account-router.host}\"/account\"\n+  }\n+}\n+\n+two-step-verification {\n+  enabled = false\n+  host = ${company-auth.host}\n+  path = \"/coafe/two-step-verification/register\"\n+  user-segment {\n+    sa {","path":"conf/application.conf","position":68,"original_position":68,"commit_id":"479bfd364792251e673f7b6acec464fa6bddc943","original_commit_id":"479bfd364792251e673f7b6acec464fa6bddc943","user":{"login":"paoloboni","id":4746479,"avatar_url":"https://avatars.githubusercontent.com/u/4746479?v=3","gravatar_id":"","url":"https://api.github.com/users/paoloboni","html_url":"https://github.com/paoloboni","followers_url":"https://api.github.com/users/paoloboni/followers","following_url":"https://api.github.com/users/paoloboni/following{/other_user}","gists_url":"https://api.github.com/users/paoloboni/gists{/gist_id}","starred_url":"https://api.github.com/users/paoloboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paoloboni/subscriptions","organizations_url":"https://api.github.com/users/paoloboni/orgs","repos_url":"https://api.github.com/users/paoloboni/repos","events_url":"https://api.github.com/users/paoloboni/events{/privacy}","received_events_url":"https://api.github.com/users/paoloboni/received_events","type":"User","site_admin":false},"body":"I'm not sure we need these keys. Can't `user-segment` just be an array of objects? `sa_vat` below is likely to be just `vat`, but I guess we don't really care about this value - the important things here are:\r\n- the order of user segments\r\n- the list of enrolments\r\n- outcomes for admins/assistants","created_at":"2016-09-09T16:23:12Z","updated_at":"2016-09-09T16:23:12Z","html_url":"https://github.com/hmrc/tax-account-router-frontend/pull/31#discussion_r78208458","pull_request_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/comments/78208458"},"html":{"href":"https://github.com/hmrc/tax-account-router-frontend/pull/31#discussion_r78208458"},"pull_request":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31","id":84490552,"html_url":"https://github.com/hmrc/tax-account-router-frontend/pull/31","diff_url":"https://github.com/hmrc/tax-account-router-frontend/pull/31.diff","patch_url":"https://github.com/hmrc/tax-account-router-frontend/pull/31.patch","issue_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/31","number":31,"state":"open","locked":false,"title":"TSV-188 User type conditions for new user segment","user":{"login":"anshulbajpai","id":291429,"avatar_url":"https://avatars.githubusercontent.com/u/291429?v=3","gravatar_id":"","url":"https://api.github.com/users/anshulbajpai","html_url":"https://github.com/anshulbajpai","followers_url":"https://api.github.com/users/anshulbajpai/followers","following_url":"https://api.github.com/users/anshulbajpai/following{/other_user}","gists_url":"https://api.github.com/users/anshulbajpai/gists{/gist_id}","starred_url":"https://api.github.com/users/anshulbajpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshulbajpai/subscriptions","organizations_url":"https://api.github.com/users/anshulbajpai/orgs","repos_url":"https://api.github.com/users/anshulbajpai/repos","events_url":"https://api.github.com/users/anshulbajpai/events{/privacy}","received_events_url":"https://api.github.com/users/anshulbajpai/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-08T14:40:23Z","updated_at":"2016-09-09T16:23:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aff9c5c1eafccf8f22a1f2470902a0deb4b83c15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31/commits","review_comments_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31/comments","review_comment_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/31/comments","statuses_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/statuses/479bfd364792251e673f7b6acec464fa6bddc943","head":{"label":"hmrc:TSV-188","ref":"TSV-188","sha":"479bfd364792251e673f7b6acec464fa6bddc943","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":42583590,"name":"tax-account-router-frontend","full_name":"hmrc/tax-account-router-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/tax-account-router-frontend","description":"","fork":false,"url":"https://api.github.com/repos/hmrc/tax-account-router-frontend","forks_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/deployments","created_at":"2015-09-16T11:40:45Z","updated_at":"2016-03-25T13:46:30Z","pushed_at":"2016-09-09T15:43:28Z","git_url":"git://github.com/hmrc/tax-account-router-frontend.git","ssh_url":"git@github.com:hmrc/tax-account-router-frontend.git","clone_url":"https://github.com/hmrc/tax-account-router-frontend.git","svn_url":"https://github.com/hmrc/tax-account-router-frontend","homepage":null,"size":7841,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"d1dee79810c256f92f3665f4f908353ad021f4bf","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":42583590,"name":"tax-account-router-frontend","full_name":"hmrc/tax-account-router-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/tax-account-router-frontend","description":"","fork":false,"url":"https://api.github.com/repos/hmrc/tax-account-router-frontend","forks_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/tax-account-router-frontend/deployments","created_at":"2015-09-16T11:40:45Z","updated_at":"2016-03-25T13:46:30Z","pushed_at":"2016-09-09T15:43:28Z","git_url":"git://github.com/hmrc/tax-account-router-frontend.git","ssh_url":"git@github.com:hmrc/tax-account-router-frontend.git","clone_url":"https://github.com/hmrc/tax-account-router-frontend.git","svn_url":"https://github.com/hmrc/tax-account-router-frontend","homepage":null,"size":7841,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31"},"html":{"href":"https://github.com/hmrc/tax-account-router-frontend/pull/31"},"issue":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/31"},"comments":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/tax-account-router-frontend/statuses/479bfd364792251e673f7b6acec464fa6bddc943"}}}}
{"actor":{"display_login":"paoloboni"}}