{"action":"created","comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/51340693","id":51340693,"diff_hunk":"@@ -214,7 +214,8 @@\n   (use-package erc-image\n     :init (with-eval-after-load 'erc (add-to-list 'erc-modules 'image))))\n \n-(defun erc/init-erc-terminal-notifier ())\n+(defun erc/init-erc-terminal-notifier ()\n+  (use-package erc-terminal-notifier))","path":"layers/+irc/erc/packages.el","position":6,"original_position":6,"commit_id":"84388fb9ddca5466b556c7fcc94bb01d6f199643","original_commit_id":"84388fb9ddca5466b556c7fcc94bb01d6f199643","user":{"login":"nixmaniack","id":542810,"avatar_url":"https://avatars.githubusercontent.com/u/542810?v=3","gravatar_id":"","url":"https://api.github.com/users/nixmaniack","html_url":"https://github.com/nixmaniack","followers_url":"https://api.github.com/users/nixmaniack/followers","following_url":"https://api.github.com/users/nixmaniack/following{/other_user}","gists_url":"https://api.github.com/users/nixmaniack/gists{/gist_id}","starred_url":"https://api.github.com/users/nixmaniack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixmaniack/subscriptions","organizations_url":"https://api.github.com/users/nixmaniack/orgs","repos_url":"https://api.github.com/users/nixmaniack/repos","events_url":"https://api.github.com/users/nixmaniack/events{/privacy}","received_events_url":"https://api.github.com/users/nixmaniack/received_events","type":"User","site_admin":false},"body":"Looks fine in erc layer. Although you may benefit by adding `:if (executable-find \"terminal-notifier\")` to use-package to selectively enable only if the executable is found. ","created_at":"2016-01-30T05:19:57Z","updated_at":"2016-01-30T05:19:57Z","html_url":"https://github.com/syl20bnr/spacemacs/pull/4872#discussion_r51340693","pull_request_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872","_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/51340693"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/4872#discussion_r51340693"},"pull_request":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872"}}},"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872","id":57723969,"html_url":"https://github.com/syl20bnr/spacemacs/pull/4872","diff_url":"https://github.com/syl20bnr/spacemacs/pull/4872.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/4872.patch","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4872","number":4872,"state":"open","locked":false,"title":"ERC terminal notifier","user":{"login":"Andre0991","id":7083061,"avatar_url":"https://avatars.githubusercontent.com/u/7083061?v=3","gravatar_id":"","url":"https://api.github.com/users/Andre0991","html_url":"https://github.com/Andre0991","followers_url":"https://api.github.com/users/Andre0991/followers","following_url":"https://api.github.com/users/Andre0991/following{/other_user}","gists_url":"https://api.github.com/users/Andre0991/gists{/gist_id}","starred_url":"https://api.github.com/users/Andre0991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andre0991/subscriptions","organizations_url":"https://api.github.com/users/Andre0991/orgs","repos_url":"https://api.github.com/users/Andre0991/repos","events_url":"https://api.github.com/users/Andre0991/events{/privacy}","received_events_url":"https://api.github.com/users/Andre0991/received_events","type":"User","site_admin":false},"body":"`use-package` wasn't being used for in `erc/init-erc-terminal-notifier`. Now I get notifications.\r\n\r\nTwo things:\r\n\r\na) Should this be really part of the `erc` layer instead of `osx`? In the end the result would be the same  in both ways, of course, but `osx` makes more sense to me.\r\nb) I don't understand why this doesn't trigger any error  when `terminal-notifier` isn't installed, but it really doesn't. Why?","created_at":"2016-01-30T01:06:47Z","updated_at":"2016-01-30T05:19:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdfdd55e729c085298496bb185986d0d80d8fd0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872/commits","review_comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872/comments","review_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4872/comments","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/84388fb9ddca5466b556c7fcc94bb01d6f199643","head":{"label":"Andre0991:erc-terminal-notifier-fix","ref":"erc-terminal-notifier-fix","sha":"84388fb9ddca5466b556c7fcc94bb01d6f199643","user":{"login":"Andre0991","id":7083061,"avatar_url":"https://avatars.githubusercontent.com/u/7083061?v=3","gravatar_id":"","url":"https://api.github.com/users/Andre0991","html_url":"https://github.com/Andre0991","followers_url":"https://api.github.com/users/Andre0991/followers","following_url":"https://api.github.com/users/Andre0991/following{/other_user}","gists_url":"https://api.github.com/users/Andre0991/gists{/gist_id}","starred_url":"https://api.github.com/users/Andre0991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andre0991/subscriptions","organizations_url":"https://api.github.com/users/Andre0991/orgs","repos_url":"https://api.github.com/users/Andre0991/repos","events_url":"https://api.github.com/users/Andre0991/events{/privacy}","received_events_url":"https://api.github.com/users/Andre0991/received_events","type":"User","site_admin":false},"repo":{"id":49748266,"name":"spacemacs","full_name":"Andre0991/spacemacs","owner":{"login":"Andre0991","id":7083061,"avatar_url":"https://avatars.githubusercontent.com/u/7083061?v=3","gravatar_id":"","url":"https://api.github.com/users/Andre0991","html_url":"https://github.com/Andre0991","followers_url":"https://api.github.com/users/Andre0991/followers","following_url":"https://api.github.com/users/Andre0991/following{/other_user}","gists_url":"https://api.github.com/users/Andre0991/gists{/gist_id}","starred_url":"https://api.github.com/users/Andre0991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andre0991/subscriptions","organizations_url":"https://api.github.com/users/Andre0991/orgs","repos_url":"https://api.github.com/users/Andre0991/repos","events_url":"https://api.github.com/users/Andre0991/events{/privacy}","received_events_url":"https://api.github.com/users/Andre0991/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andre0991/spacemacs","description":"A community-driven Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":true,"url":"https://api.github.com/repos/Andre0991/spacemacs","forks_url":"https://api.github.com/repos/Andre0991/spacemacs/forks","keys_url":"https://api.github.com/repos/Andre0991/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andre0991/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andre0991/spacemacs/teams","hooks_url":"https://api.github.com/repos/Andre0991/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/Andre0991/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/Andre0991/spacemacs/events","assignees_url":"https://api.github.com/repos/Andre0991/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/Andre0991/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/Andre0991/spacemacs/tags","blobs_url":"https://api.github.com/repos/Andre0991/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andre0991/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andre0991/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andre0991/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andre0991/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/Andre0991/spacemacs/languages","stargazers_url":"https://api.github.com/repos/Andre0991/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/Andre0991/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/Andre0991/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/Andre0991/spacemacs/subscription","commits_url":"https://api.github.com/repos/Andre0991/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andre0991/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andre0991/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andre0991/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andre0991/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/Andre0991/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andre0991/spacemacs/merges","archive_url":"https://api.github.com/repos/Andre0991/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andre0991/spacemacs/downloads","issues_url":"https://api.github.com/repos/Andre0991/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/Andre0991/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/Andre0991/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/Andre0991/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andre0991/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/Andre0991/spacemacs/releases{/id}","deployments_url":"https://api.github.com/repos/Andre0991/spacemacs/deployments","created_at":"2016-01-15T22:21:12Z","updated_at":"2016-01-15T22:21:15Z","pushed_at":"2016-01-30T01:17:46Z","git_url":"git://github.com/Andre0991/spacemacs.git","ssh_url":"git@github.com:Andre0991/spacemacs.git","clone_url":"https://github.com/Andre0991/spacemacs.git","svn_url":"https://github.com/Andre0991/spacemacs","homepage":"http://spacemacs.org","size":21958,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syl20bnr:develop","ref":"develop","sha":"33fd71d4bf9a8554effad2cbb16ed5fa52716f42","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"repo":{"id":7212645,"name":"spacemacs","full_name":"syl20bnr/spacemacs","owner":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syl20bnr/spacemacs","description":"A community-driven Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":false,"url":"https://api.github.com/repos/syl20bnr/spacemacs","forks_url":"https://api.github.com/repos/syl20bnr/spacemacs/forks","keys_url":"https://api.github.com/repos/syl20bnr/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syl20bnr/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syl20bnr/spacemacs/teams","hooks_url":"https://api.github.com/repos/syl20bnr/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/events","assignees_url":"https://api.github.com/repos/syl20bnr/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/syl20bnr/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/tags","blobs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/syl20bnr/spacemacs/languages","stargazers_url":"https://api.github.com/repos/syl20bnr/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/syl20bnr/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscription","commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/syl20bnr/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/syl20bnr/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syl20bnr/spacemacs/merges","archive_url":"https://api.github.com/repos/syl20bnr/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syl20bnr/spacemacs/downloads","issues_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/syl20bnr/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/syl20bnr/spacemacs/releases{/id}","deployments_url":"https://api.github.com/repos/syl20bnr/spacemacs/deployments","created_at":"2012-12-17T21:34:03Z","updated_at":"2016-01-30T05:11:39Z","pushed_at":"2016-01-30T03:39:36Z","git_url":"git://github.com/syl20bnr/spacemacs.git","ssh_url":"git@github.com:syl20bnr/spacemacs.git","clone_url":"https://github.com/syl20bnr/spacemacs.git","svn_url":"https://github.com/syl20bnr/spacemacs","homepage":"http://spacemacs.org","size":35646,"stargazers_count":5736,"watchers_count":5736,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1430,"mirror_url":null,"open_issues_count":673,"forks":1430,"open_issues":673,"watchers":5736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/4872"},"issue":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4872"},"comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4872/comments"},"review_comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872/comments"},"review_comment":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4872/commits"},"statuses":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/84388fb9ddca5466b556c7fcc94bb01d6f199643"}}}}