{"action":"closed","number":142,"pull_request":{"url":"https://api.github.com/repos/w3c/wpt-tools/pulls/142","id":96744192,"html_url":"https://github.com/w3c/wpt-tools/pull/142","diff_url":"https://github.com/w3c/wpt-tools/pull/142.diff","patch_url":"https://github.com/w3c/wpt-tools/pull/142.patch","issue_url":"https://api.github.com/repos/w3c/wpt-tools/issues/142","number":142,"state":"closed","locked":false,"title":"Fix for correctly interpreting the whitelist under Windows","user":{"login":"jeremypoulter","id":6116992,"avatar_url":"https://avatars.githubusercontent.com/u/6116992?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremypoulter","html_url":"https://github.com/jeremypoulter","followers_url":"https://api.github.com/users/jeremypoulter/followers","following_url":"https://api.github.com/users/jeremypoulter/following{/other_user}","gists_url":"https://api.github.com/users/jeremypoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremypoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremypoulter/subscriptions","organizations_url":"https://api.github.com/users/jeremypoulter/orgs","repos_url":"https://api.github.com/users/jeremypoulter/repos","events_url":"https://api.github.com/users/jeremypoulter/events{/privacy}","received_events_url":"https://api.github.com/users/jeremypoulter/received_events","type":"User","site_admin":false},"body":"os.path.normcase also converts / to \\ on Windows (using the native Windows Python). This caused the paths in the white list (that have been run through normcase) to not match the file paths (that have not been run through normpath). This fix just uses the normpath version of the filepath for matching rather than the original path.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/w3c/wpt-tools/142)\n<!-- Reviewable:end -->\n","created_at":"2016-12-06T15:24:26Z","updated_at":"2016-12-14T13:41:37Z","closed_at":"2016-12-14T13:41:37Z","merged_at":"2016-12-14T13:41:37Z","merge_commit_sha":"08b225a12331de82bc4f0cb49ac0b798f31318f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/wpt-tools/pulls/142/commits","review_comments_url":"https://api.github.com/repos/w3c/wpt-tools/pulls/142/comments","review_comment_url":"https://api.github.com/repos/w3c/wpt-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/wpt-tools/issues/142/comments","statuses_url":"https://api.github.com/repos/w3c/wpt-tools/statuses/7fcd588cff36205d0ef0e41bfb55a61d94a57387","head":{"label":"jeremypoulter:lint_on_windows_fixup","ref":"lint_on_windows_fixup","sha":"7fcd588cff36205d0ef0e41bfb55a61d94a57387","user":{"login":"jeremypoulter","id":6116992,"avatar_url":"https://avatars.githubusercontent.com/u/6116992?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremypoulter","html_url":"https://github.com/jeremypoulter","followers_url":"https://api.github.com/users/jeremypoulter/followers","following_url":"https://api.github.com/users/jeremypoulter/following{/other_user}","gists_url":"https://api.github.com/users/jeremypoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremypoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremypoulter/subscriptions","organizations_url":"https://api.github.com/users/jeremypoulter/orgs","repos_url":"https://api.github.com/users/jeremypoulter/repos","events_url":"https://api.github.com/users/jeremypoulter/events{/privacy}","received_events_url":"https://api.github.com/users/jeremypoulter/received_events","type":"User","site_admin":false},"repo":{"id":73832066,"name":"wpt-tools","full_name":"jeremypoulter/wpt-tools","owner":{"login":"jeremypoulter","id":6116992,"avatar_url":"https://avatars.githubusercontent.com/u/6116992?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremypoulter","html_url":"https://github.com/jeremypoulter","followers_url":"https://api.github.com/users/jeremypoulter/followers","following_url":"https://api.github.com/users/jeremypoulter/following{/other_user}","gists_url":"https://api.github.com/users/jeremypoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremypoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremypoulter/subscriptions","organizations_url":"https://api.github.com/users/jeremypoulter/orgs","repos_url":"https://api.github.com/users/jeremypoulter/repos","events_url":"https://api.github.com/users/jeremypoulter/events{/privacy}","received_events_url":"https://api.github.com/users/jeremypoulter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremypoulter/wpt-tools","description":"Tools for Web Platform Tests","fork":true,"url":"https://api.github.com/repos/jeremypoulter/wpt-tools","forks_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/forks","keys_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/teams","hooks_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/hooks","issue_events_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/issues/events{/number}","events_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/events","assignees_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/assignees{/user}","branches_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/branches{/branch}","tags_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/tags","blobs_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/languages","stargazers_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/stargazers","contributors_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/contributors","subscribers_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/subscribers","subscription_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/subscription","commits_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/contents/{+path}","compare_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/merges","archive_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/downloads","issues_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/issues{/number}","pulls_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/labels{/name}","releases_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/releases{/id}","deployments_url":"https://api.github.com/repos/jeremypoulter/wpt-tools/deployments","created_at":"2016-11-15T16:20:02Z","updated_at":"2016-11-15T16:20:03Z","pushed_at":"2016-12-14T10:47:34Z","git_url":"git://github.com/jeremypoulter/wpt-tools.git","ssh_url":"git@github.com:jeremypoulter/wpt-tools.git","clone_url":"https://github.com/jeremypoulter/wpt-tools.git","svn_url":"https://github.com/jeremypoulter/wpt-tools","homepage":null,"size":1796,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"7afafbf447660bf0df9ccbd34b9e5c7153980759","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":32922994,"name":"wpt-tools","full_name":"w3c/wpt-tools","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/wpt-tools","description":"Tools for Web Platform Tests","fork":false,"url":"https://api.github.com/repos/w3c/wpt-tools","forks_url":"https://api.github.com/repos/w3c/wpt-tools/forks","keys_url":"https://api.github.com/repos/w3c/wpt-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/wpt-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/wpt-tools/teams","hooks_url":"https://api.github.com/repos/w3c/wpt-tools/hooks","issue_events_url":"https://api.github.com/repos/w3c/wpt-tools/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/wpt-tools/events","assignees_url":"https://api.github.com/repos/w3c/wpt-tools/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/wpt-tools/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/wpt-tools/tags","blobs_url":"https://api.github.com/repos/w3c/wpt-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/wpt-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/wpt-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/wpt-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/wpt-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/wpt-tools/languages","stargazers_url":"https://api.github.com/repos/w3c/wpt-tools/stargazers","contributors_url":"https://api.github.com/repos/w3c/wpt-tools/contributors","subscribers_url":"https://api.github.com/repos/w3c/wpt-tools/subscribers","subscription_url":"https://api.github.com/repos/w3c/wpt-tools/subscription","commits_url":"https://api.github.com/repos/w3c/wpt-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/wpt-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/wpt-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/wpt-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/wpt-tools/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/wpt-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/wpt-tools/merges","archive_url":"https://api.github.com/repos/w3c/wpt-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/wpt-tools/downloads","issues_url":"https://api.github.com/repos/w3c/wpt-tools/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/wpt-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/wpt-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/wpt-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/wpt-tools/labels{/name}","releases_url":"https://api.github.com/repos/w3c/wpt-tools/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/wpt-tools/deployments","created_at":"2015-03-26T11:17:43Z","updated_at":"2016-12-11T10:21:23Z","pushed_at":"2016-12-14T13:41:37Z","git_url":"git://github.com/w3c/wpt-tools.git","ssh_url":"git@github.com:w3c/wpt-tools.git","clone_url":"https://github.com/w3c/wpt-tools.git","svn_url":"https://github.com/w3c/wpt-tools","homepage":null,"size":1869,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":25,"forks":32,"open_issues":25,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/wpt-tools/pulls/142"},"html":{"href":"https://github.com/w3c/wpt-tools/pull/142"},"issue":{"href":"https://api.github.com/repos/w3c/wpt-tools/issues/142"},"comments":{"href":"https://api.github.com/repos/w3c/wpt-tools/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/wpt-tools/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/wpt-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/wpt-tools/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/wpt-tools/statuses/7fcd588cff36205d0ef0e41bfb55a61d94a57387"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gsnedders","id":176218,"avatar_url":"https://avatars.githubusercontent.com/u/176218?v=3","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},"comments":6,"review_comments":7,"commits":7,"additions":36,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"gsnedders"}}