{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/11298","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/11298/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/11298/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/11298/events","html_url":"https://github.com/xbmc/xbmc/pull/11298","id":198045858,"number":11298,"title":"[PVR][music][video] Video Fullscreen/Music Visualisation: Fix hiding of player info","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"labels":[{"id":1659186,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"0b02e1","default":false},{"id":276934948,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Music","name":"Music","color":"009800","default":false},{"id":15146247,"url":"https://api.github.com/repos/xbmc/xbmc/labels/PVR","name":"PVR","color":"009800","default":false},{"id":400751192,"url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20L***","name":"v18 L***","color":"fbca04","default":false},{"id":276935033,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Video","name":"Video","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/95","html_url":"https://github.com/xbmc/xbmc/milestone/95","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/95/labels","id":2166828,"number":95,"title":"L 18.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":166,"state":"open","created_at":"2016-11-30T16:58:49Z","updated_at":"2016-12-29T23:44:18Z","due_on":"2017-01-31T08:00:00Z","closed_at":null},"comments":4,"created_at":"2016-12-29T18:03:10Z","updated_at":"2016-12-30T08:38:23Z","closed_at":"2016-12-29T23:44:18Z","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/11298","html_url":"https://github.com/xbmc/xbmc/pull/11298","diff_url":"https://github.com/xbmc/xbmc/pull/11298.diff","patch_url":"https://github.com/xbmc/xbmc/pull/11298.patch"},"body":"Ever wondered why the normal way of closing dialogs (using esc key or back button on your remote) does not close the player info in video fullscreen or music visualisation, but exits fullscreen to previous window? This is because player info internally is 'something else' than most other dialogs and closing it technically is different form closing a dialog.\r\n\r\nThis PR fixes this. Now esc key, back button on remote closes the player info if open and exits fullscreen if player info is not open. Feels 'naturally' and consistent now, imo. \r\n\r\nThis was tested on latest master on LInux and macOS.\r\n\r\nFor those not knowing what 'player info' is - for live tv it's this:\r\n\r\n![screenshot007](https://cloud.githubusercontent.com/assets/3226626/21550333/41dd9eec-cdf9-11e6-8164-2af79d1a3558.png)\r\n\r\nIt pops for instance up, if you press up/down while in fullscreen live tv window. ;-)\r\n\r\n@Jalle19 for review, please?"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/269746128","html_url":"https://github.com/xbmc/xbmc/pull/11298#issuecomment-269746128","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/11298","id":269746128,"user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T08:38:23Z","updated_at":"2016-12-30T08:38:23Z","body":"> idea was good, sadly our code doesnt allow a straightforward fix for that mess. :)\r\n\r\n Yep, that's what I ment."}}
{"actor":{"display_login":"ksooo"}}