{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/67489644","id":67489644,"diff_hunk":"@@ -30,17 +30,20 @@\n import com.fasterxml.jackson.core.type.TypeReference;\n \n /**\n+ * This MDB is provided to populate the CommunicationDetailsCache when Communication Details.\n+ * Each clustered APM server node will receive the communication details data, so each cache\n+ * is expected to only be a local cache.\n+ *\n+ * Discussion regarding potential future use of a distributed cache is associated with HWKAPM-479.\n+ * If this change happens, then this MDB should be converted back to a durable (load balanced) subscriber.\n+ *\n  * @author gbrown\n  */\n-@MessageDriven(name = \"CommunicationDetails_Cache\", messageListenerInterface = MessageListener.class,\n+@MessageDriven(name = \"CommunicationDetails_CommunicationDetailsCache\", messageListenerInterface = MessageListener.class,\n         activationConfig =\n         {\n                 @ActivationConfigProperty(propertyName = \"destinationType\", propertyValue = \"javax.jms.Topic\"),\n-                @ActivationConfigProperty(propertyName = \"destination\", propertyValue = \"CommunicationDetails\"),\n-                @ActivationConfigProperty(propertyName = \"subscriptionDurability\", propertyValue = \"Durable\"),","path":"server/jms/src/main/java/org/hawkular/apm/server/jms/CommunicationDetailsCacheMDB.java","position":19,"original_position":19,"commit_id":"8a1da948222d25622b984bc7595ae747deece6d3","original_commit_id":"8a1da948222d25622b984bc7595ae747deece6d3","user":{"login":"pilhuhn","id":208246,"avatar_url":"https://avatars.githubusercontent.com/u/208246?v=3","gravatar_id":"","url":"https://api.github.com/users/pilhuhn","html_url":"https://github.com/pilhuhn","followers_url":"https://api.github.com/users/pilhuhn/followers","following_url":"https://api.github.com/users/pilhuhn/following{/other_user}","gists_url":"https://api.github.com/users/pilhuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/pilhuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilhuhn/subscriptions","organizations_url":"https://api.github.com/users/pilhuhn/orgs","repos_url":"https://api.github.com/users/pilhuhn/repos","events_url":"https://api.github.com/users/pilhuhn/events{/privacy}","received_events_url":"https://api.github.com/users/pilhuhn/received_events","type":"User","site_admin":false},"body":"Why are you removing the Durability here?","created_at":"2016-06-17T10:20:09Z","updated_at":"2016-06-17T10:20:09Z","html_url":"https://github.com/hawkular/hawkular-apm/pull/444#discussion_r67489644","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/67489644"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/444#discussion_r67489644"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444","id":74095686,"html_url":"https://github.com/hawkular/hawkular-apm/pull/444","diff_url":"https://github.com/hawkular/hawkular-apm/pull/444.diff","patch_url":"https://github.com/hawkular/hawkular-apm/pull/444.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/444","number":444,"state":"open","locked":false,"title":"HWKAPM-478 Support caching information in a clustered environment","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-16T14:56:33Z","updated_at":"2016-06-17T10:20:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"241cc3564889f705d002be1a66cdbf8189ff2bdd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/444/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/8a1da948222d25622b984bc7595ae747deece6d3","head":{"label":"objectiser:HWKAPM-478","ref":"HWKAPM-478","sha":"8a1da948222d25622b984bc7595ae747deece6d3","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"repo":{"id":34446762,"name":"hawkular-apm","full_name":"objectiser/hawkular-apm","owner":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objectiser/hawkular-apm","description":"Application Performance Management for Hawkular","fork":true,"url":"https://api.github.com/repos/objectiser/hawkular-apm","forks_url":"https://api.github.com/repos/objectiser/hawkular-apm/forks","keys_url":"https://api.github.com/repos/objectiser/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objectiser/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objectiser/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/objectiser/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/objectiser/hawkular-apm/events","assignees_url":"https://api.github.com/repos/objectiser/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/objectiser/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objectiser/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/objectiser/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/objectiser/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/objectiser/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/objectiser/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/objectiser/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/objectiser/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objectiser/hawkular-apm/merges","archive_url":"https://api.github.com/repos/objectiser/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objectiser/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/objectiser/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/objectiser/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/objectiser/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objectiser/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/objectiser/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/objectiser/hawkular-apm/deployments","created_at":"2015-04-23T09:26:55Z","updated_at":"2016-06-03T10:47:39Z","pushed_at":"2016-06-16T15:33:47Z","git_url":"git://github.com/objectiser/hawkular-apm.git","ssh_url":"git@github.com:objectiser/hawkular-apm.git","clone_url":"https://github.com/objectiser/hawkular-apm.git","svn_url":"https://github.com/objectiser/hawkular-apm","homepage":"","size":5058,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"94ea5d0c2951fb91546eda99b40f5ec050a6f4da","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":34446334,"name":"hawkular-apm","full_name":"hawkular/hawkular-apm","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-apm","description":"Application Performance Management for Hawkular","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-apm","forks_url":"https://api.github.com/repos/hawkular/hawkular-apm/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-apm/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-apm/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-apm/deployments","created_at":"2015-04-23T09:17:50Z","updated_at":"2016-06-03T10:45:56Z","pushed_at":"2016-06-16T15:33:48Z","git_url":"git://github.com/hawkular/hawkular-apm.git","ssh_url":"git@github.com:hawkular/hawkular-apm.git","clone_url":"https://github.com/hawkular/hawkular-apm.git","svn_url":"https://github.com/hawkular/hawkular-apm","homepage":"","size":5080,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/444"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/444"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/8a1da948222d25622b984bc7595ae747deece6d3"}}}}
{"actor":{"display_login":"pilhuhn"}}