{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/80745276","pull_request_review_id":1779588,"id":80745276,"diff_hunk":"@@ -347,7 +348,51 @@ export function main() {\n              setTimeout(() => {\n                expect(multiTrim(document.body.textContent))\n                    .toEqual(\n-                       'Hello SAVKIN, Victor; A: VICTOR; B: SAVKIN; | Hello TEST; A: First; B: Last; | WORKS-SAVKIN, Victor');\n+                       'Hello SAVKIN, Victor, SF; A: VICTOR; B: SAVKIN; C: SF; | Hello TEST; A: First; B: Last; C: City; | WORKS-SAVKIN, Victor, SF');\n+               ref.dispose();\n+             }, 0);\n+           });\n+         }));\n+\n+      it('should bind optional properties', async(() => {\n+           const adapter: UpgradeAdapter = new UpgradeAdapter(forwardRef(() => Ng2Module));\n+           var ng1Module = angular.module('ng1', []);\n+\n+           var ng1 = function() {","path":"modules/@angular/upgrade/test/upgrade_spec.ts","position":45,"original_position":45,"commit_id":"6be23068470d6dd7603b3dc9ac341f9843400f84","original_commit_id":"6be23068470d6dd7603b3dc9ac341f9843400f84","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"`() => {...}`","created_at":"2016-09-27T17:14:54Z","updated_at":"2016-09-27T17:14:54Z","html_url":"https://github.com/angular/angular/pull/11411#discussion_r80745276","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/11411","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/80745276"},"html":{"href":"https://github.com/angular/angular/pull/11411#discussion_r80745276"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/11411"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/11411","id":84278697,"html_url":"https://github.com/angular/angular/pull/11411","diff_url":"https://github.com/angular/angular/pull/11411.diff","patch_url":"https://github.com/angular/angular/pull/11411.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/11411","number":11411,"state":"open","locked":false,"title":"fix(upgrade): bind optional properties when upgrading from ng1","user":{"login":"chrisse27","id":5329890,"avatar_url":"https://avatars.githubusercontent.com/u/5329890?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisse27","html_url":"https://github.com/chrisse27","followers_url":"https://api.github.com/users/chrisse27/followers","following_url":"https://api.github.com/users/chrisse27/following{/other_user}","gists_url":"https://api.github.com/users/chrisse27/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisse27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisse27/subscriptions","organizations_url":"https://api.github.com/users/chrisse27/orgs","repos_url":"https://api.github.com/users/chrisse27/repos","events_url":"https://api.github.com/users/chrisse27/events{/privacy}","received_events_url":"https://api.github.com/users/chrisse27/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nPreviously, optional properties of a directive/component would be wrongly mapped and thus ignored.\r\n\r\nSee #10181\r\n\r\n**What is the new behavior?**\r\n\r\nOptional properties of an ng1 directive/component are correctly bound\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\nCloses #10181","created_at":"2016-09-07T10:55:57Z","updated_at":"2016-09-27T17:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d518d726c9a7e57ec4f5e469ca4213ae27598e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/11411/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/11411/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/11411/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/6be23068470d6dd7603b3dc9ac341f9843400f84","head":{"label":"chrisse27:bugfix/10181","ref":"bugfix/10181","sha":"6be23068470d6dd7603b3dc9ac341f9843400f84","user":{"login":"chrisse27","id":5329890,"avatar_url":"https://avatars.githubusercontent.com/u/5329890?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisse27","html_url":"https://github.com/chrisse27","followers_url":"https://api.github.com/users/chrisse27/followers","following_url":"https://api.github.com/users/chrisse27/following{/other_user}","gists_url":"https://api.github.com/users/chrisse27/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisse27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisse27/subscriptions","organizations_url":"https://api.github.com/users/chrisse27/orgs","repos_url":"https://api.github.com/users/chrisse27/repos","events_url":"https://api.github.com/users/chrisse27/events{/privacy}","received_events_url":"https://api.github.com/users/chrisse27/received_events","type":"User","site_admin":false},"repo":{"id":67583895,"name":"angular","full_name":"chrisse27/angular","owner":{"login":"chrisse27","id":5329890,"avatar_url":"https://avatars.githubusercontent.com/u/5329890?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisse27","html_url":"https://github.com/chrisse27","followers_url":"https://api.github.com/users/chrisse27/followers","following_url":"https://api.github.com/users/chrisse27/following{/other_user}","gists_url":"https://api.github.com/users/chrisse27/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisse27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisse27/subscriptions","organizations_url":"https://api.github.com/users/chrisse27/orgs","repos_url":"https://api.github.com/users/chrisse27/repos","events_url":"https://api.github.com/users/chrisse27/events{/privacy}","received_events_url":"https://api.github.com/users/chrisse27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisse27/angular","description":null,"fork":true,"url":"https://api.github.com/repos/chrisse27/angular","forks_url":"https://api.github.com/repos/chrisse27/angular/forks","keys_url":"https://api.github.com/repos/chrisse27/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisse27/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisse27/angular/teams","hooks_url":"https://api.github.com/repos/chrisse27/angular/hooks","issue_events_url":"https://api.github.com/repos/chrisse27/angular/issues/events{/number}","events_url":"https://api.github.com/repos/chrisse27/angular/events","assignees_url":"https://api.github.com/repos/chrisse27/angular/assignees{/user}","branches_url":"https://api.github.com/repos/chrisse27/angular/branches{/branch}","tags_url":"https://api.github.com/repos/chrisse27/angular/tags","blobs_url":"https://api.github.com/repos/chrisse27/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisse27/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisse27/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisse27/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisse27/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisse27/angular/languages","stargazers_url":"https://api.github.com/repos/chrisse27/angular/stargazers","contributors_url":"https://api.github.com/repos/chrisse27/angular/contributors","subscribers_url":"https://api.github.com/repos/chrisse27/angular/subscribers","subscription_url":"https://api.github.com/repos/chrisse27/angular/subscription","commits_url":"https://api.github.com/repos/chrisse27/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisse27/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisse27/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisse27/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisse27/angular/contents/{+path}","compare_url":"https://api.github.com/repos/chrisse27/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisse27/angular/merges","archive_url":"https://api.github.com/repos/chrisse27/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisse27/angular/downloads","issues_url":"https://api.github.com/repos/chrisse27/angular/issues{/number}","pulls_url":"https://api.github.com/repos/chrisse27/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisse27/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisse27/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisse27/angular/labels{/name}","releases_url":"https://api.github.com/repos/chrisse27/angular/releases{/id}","deployments_url":"https://api.github.com/repos/chrisse27/angular/deployments","created_at":"2016-09-07T07:41:11Z","updated_at":"2016-09-07T07:41:33Z","pushed_at":"2016-09-19T22:42:10Z","git_url":"git://github.com/chrisse27/angular.git","ssh_url":"git@github.com:chrisse27/angular.git","clone_url":"https://github.com/chrisse27/angular.git","svn_url":"https://github.com/chrisse27/angular","homepage":"https://angular.io","size":28692,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"70488ed3826ae67600634e47a22689c5b6ef0ba2","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-09-27T16:46:11Z","pushed_at":"2016-09-27T17:10:45Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":645639,"stargazers_count":16733,"watchers_count":16733,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4268,"mirror_url":null,"open_issues_count":1055,"forks":4268,"open_issues":1055,"watchers":16733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/11411"},"html":{"href":"https://github.com/angular/angular/pull/11411"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/11411"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/11411/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/11411/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/11411/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/6be23068470d6dd7603b3dc9ac341f9843400f84"}}}}
{"actor":{"display_login":"vicb"}}