{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/49939091","id":49939091,"diff_hunk":"@@ -8,3 +8,44 @@\n      String func_150254_d();\n  \n      List<IChatComponent> func_150253_a();\n+@@ -57,7 +56,7 @@\n+ \n+                         for (JsonElement jsonelement : jsonarray1)\n+                         {\n+-                            IChatComponent ichatcomponent2 = this.deserialize(jsonelement, jsonelement.getClass(), p_deserialize_3_);\n++                            IChatComponent ichatcomponent2 = p_deserialize_3_.deserialize(jsonelement, IChatComponent.class);","path":"patches/minecraft/net/minecraft/util/IChatComponent.java.patch","position":9,"original_position":9,"commit_id":"49a831a8c0708ed0b7e5e399d121c87cd61ae37a","original_commit_id":"49a831a8c0708ed0b7e5e399d121c87cd61ae37a","user":{"login":"cpw","id":1217211,"avatar_url":"https://avatars.githubusercontent.com/u/1217211?v=3","gravatar_id":"","url":"https://api.github.com/users/cpw","html_url":"https://github.com/cpw","followers_url":"https://api.github.com/users/cpw/followers","following_url":"https://api.github.com/users/cpw/following{/other_user}","gists_url":"https://api.github.com/users/cpw/gists{/gist_id}","starred_url":"https://api.github.com/users/cpw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpw/subscriptions","organizations_url":"https://api.github.com/users/cpw/orgs","repos_url":"https://api.github.com/users/cpw/repos","events_url":"https://api.github.com/users/cpw/events{/privacy}","received_events_url":"https://api.github.com/users/cpw/received_events","type":"User","site_admin":false},"body":"why passing to the argument rather than this?","created_at":"2016-01-17T00:12:04Z","updated_at":"2016-01-17T00:12:04Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2380#discussion_r49939091","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/49939091"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2380#discussion_r49939091"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380","id":56255756,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2380","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2380.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2380.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2380","number":2380,"state":"open","locked":false,"title":"Patch IChatComponent deserialization to be more easily expandable and avoided two possible ClassCastExceptions","user":{"login":"Mathe172","id":3540742,"avatar_url":"https://avatars.githubusercontent.com/u/3540742?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathe172","html_url":"https://github.com/Mathe172","followers_url":"https://api.github.com/users/Mathe172/followers","following_url":"https://api.github.com/users/Mathe172/following{/other_user}","gists_url":"https://api.github.com/users/Mathe172/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathe172/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathe172/subscriptions","organizations_url":"https://api.github.com/users/Mathe172/orgs","repos_url":"https://api.github.com/users/Mathe172/repos","events_url":"https://api.github.com/users/Mathe172/events{/privacy}","received_events_url":"https://api.github.com/users/Mathe172/received_events","type":"User","site_admin":false},"body":"Basically, the deserialization is now rerouted back over the DeserializationContext (as is should be, according to the Gson-doc). This allows you to hook into the deserialization process by supplying a custom DeserializationContext (since this context is now used everywhere where appropriate). ~~Making the GSON field public allows you to use it as fallback when doing some custom deserializations.~~ [Removed: Can easily be done by anyone using ATs - Thanks @ diesieben07 for pointing that out]\r\nThis PR also fixes two ClassCastExceptions caused by malformed JSON. One now throws a JsonParseException ('with'-tag) and one interprets the element as a one element array ('extra'-tag)\r\n(For more details, see commit message)","created_at":"2016-01-16T15:20:26Z","updated_at":"2016-01-17T00:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74ee87dcc8a11a8df1952285e62d7624449f6cff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2380/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/49a831a8c0708ed0b7e5e399d121c87cd61ae37a","head":{"label":"Mathe172:master","ref":"master","sha":"49a831a8c0708ed0b7e5e399d121c87cd61ae37a","user":{"login":"Mathe172","id":3540742,"avatar_url":"https://avatars.githubusercontent.com/u/3540742?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathe172","html_url":"https://github.com/Mathe172","followers_url":"https://api.github.com/users/Mathe172/followers","following_url":"https://api.github.com/users/Mathe172/following{/other_user}","gists_url":"https://api.github.com/users/Mathe172/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathe172/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathe172/subscriptions","organizations_url":"https://api.github.com/users/Mathe172/orgs","repos_url":"https://api.github.com/users/Mathe172/repos","events_url":"https://api.github.com/users/Mathe172/events{/privacy}","received_events_url":"https://api.github.com/users/Mathe172/received_events","type":"User","site_admin":false},"repo":{"id":49777578,"name":"MinecraftForge","full_name":"Mathe172/MinecraftForge","owner":{"login":"Mathe172","id":3540742,"avatar_url":"https://avatars.githubusercontent.com/u/3540742?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathe172","html_url":"https://github.com/Mathe172","followers_url":"https://api.github.com/users/Mathe172/followers","following_url":"https://api.github.com/users/Mathe172/following{/other_user}","gists_url":"https://api.github.com/users/Mathe172/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathe172/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathe172/subscriptions","organizations_url":"https://api.github.com/users/Mathe172/orgs","repos_url":"https://api.github.com/users/Mathe172/repos","events_url":"https://api.github.com/users/Mathe172/events{/privacy}","received_events_url":"https://api.github.com/users/Mathe172/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mathe172/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/Mathe172/MinecraftForge","forks_url":"https://api.github.com/repos/Mathe172/MinecraftForge/forks","keys_url":"https://api.github.com/repos/Mathe172/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mathe172/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mathe172/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/Mathe172/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/Mathe172/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/Mathe172/MinecraftForge/events","assignees_url":"https://api.github.com/repos/Mathe172/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/Mathe172/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/Mathe172/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/Mathe172/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mathe172/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mathe172/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mathe172/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mathe172/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/Mathe172/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/Mathe172/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/Mathe172/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/Mathe172/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/Mathe172/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/Mathe172/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mathe172/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mathe172/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mathe172/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mathe172/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/Mathe172/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mathe172/MinecraftForge/merges","archive_url":"https://api.github.com/repos/Mathe172/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mathe172/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/Mathe172/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/Mathe172/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/Mathe172/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/Mathe172/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mathe172/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/Mathe172/MinecraftForge/releases{/id}","created_at":"2016-01-16T14:55:13Z","updated_at":"2016-01-16T14:55:16Z","pushed_at":"2016-01-16T20:17:04Z","git_url":"git://github.com/Mathe172/MinecraftForge.git","ssh_url":"git@github.com:Mathe172/MinecraftForge.git","clone_url":"https://github.com/Mathe172/MinecraftForge.git","svn_url":"https://github.com/Mathe172/MinecraftForge","homepage":"","size":83382,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"7b92a2790878c9d12c0532aba07dfe1e912dadff","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-01-15T19:03:22Z","pushed_at":"2016-01-17T00:11:00Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":141268,"stargazers_count":1174,"watchers_count":1174,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":680,"mirror_url":null,"open_issues_count":229,"forks":680,"open_issues":229,"watchers":1174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2380"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2380"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2380/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2380/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/49a831a8c0708ed0b7e5e399d121c87cd61ae37a"}}}}