{"action":"created","issue":{"url":"https://api.github.com/repos/KyleAMathews/deepmerge/issues/50","repository_url":"https://api.github.com/repos/KyleAMathews/deepmerge","labels_url":"https://api.github.com/repos/KyleAMathews/deepmerge/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/KyleAMathews/deepmerge/issues/50/comments","events_url":"https://api.github.com/repos/KyleAMathews/deepmerge/issues/50/events","html_url":"https://github.com/KyleAMathews/deepmerge/pull/50","id":187554091,"number":50,"title":"add tests for invoking merge.all","user":{"login":"Bloomca","id":5978525,"avatar_url":"https://avatars.githubusercontent.com/u/5978525?v=3","gravatar_id":"","url":"https://api.github.com/users/Bloomca","html_url":"https://github.com/Bloomca","followers_url":"https://api.github.com/users/Bloomca/followers","following_url":"https://api.github.com/users/Bloomca/following{/other_user}","gists_url":"https://api.github.com/users/Bloomca/gists{/gist_id}","starred_url":"https://api.github.com/users/Bloomca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bloomca/subscriptions","organizations_url":"https://api.github.com/users/Bloomca/orgs","repos_url":"https://api.github.com/users/Bloomca/repos","events_url":"https://api.github.com/users/Bloomca/events{/privacy}","received_events_url":"https://api.github.com/users/Bloomca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-06T10:45:13Z","updated_at":"2016-11-06T15:18:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KyleAMathews/deepmerge/pulls/50","html_url":"https://github.com/KyleAMathews/deepmerge/pull/50","diff_url":"https://github.com/KyleAMathews/deepmerge/pull/50.diff","patch_url":"https://github.com/KyleAMathews/deepmerge/pull/50.patch"},"body":"Hi!\r\n\r\nAs we discussed [here](https://github.com/KyleAMathews/deepmerge/issues/33#issuecomment-258039194), I've made a test file with tests for calling.\r\n\r\nIt doesn't test any functionality, because actually it depends on implementation.\r\n\r\nSo, the first object in array is the target, and all others are sources? And all tests for functionality should be the same as in the file `test/merge.js`? I can add them as well, just want to ensure.\r\n\r\nHope it is what you've meant =)\r\n\r\ncc @TehShrike "},"comment":{"url":"https://api.github.com/repos/KyleAMathews/deepmerge/issues/comments/258687506","html_url":"https://github.com/KyleAMathews/deepmerge/pull/50#issuecomment-258687506","issue_url":"https://api.github.com/repos/KyleAMathews/deepmerge/issues/50","id":258687506,"user":{"login":"TehShrike","id":1141869,"avatar_url":"https://avatars.githubusercontent.com/u/1141869?v=3","gravatar_id":"","url":"https://api.github.com/users/TehShrike","html_url":"https://github.com/TehShrike","followers_url":"https://api.github.com/users/TehShrike/followers","following_url":"https://api.github.com/users/TehShrike/following{/other_user}","gists_url":"https://api.github.com/users/TehShrike/gists{/gist_id}","starred_url":"https://api.github.com/users/TehShrike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TehShrike/subscriptions","organizations_url":"https://api.github.com/users/TehShrike/orgs","repos_url":"https://api.github.com/users/TehShrike/repos","events_url":"https://api.github.com/users/TehShrike/events{/privacy}","received_events_url":"https://api.github.com/users/TehShrike/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T15:18:06Z","updated_at":"2016-11-06T15:18:06Z","body":"Yup, pretty much what I was thinking!  I wonder about that second test though - it might be more appropriate to throw a regular `Error` in that case instead of `TypeError`, since the argument was an array, it just didn't have enough elements.\r\n\r\nI don't think we need many tests beyond this for functionality, just enough to make sure that the main merge function (which already has a bunch of tests) is being properly called.\r\n\r\nSo about all I can think of is: \r\n\r\n- pass in more than 2 arguments, and make sure that properties from all of them end up in the output - asserting that we're calling the main merge function on every input\r\n- pass in more than 2 arguments, and when the clone option is `true`, assert that an object property on each of the inputs is different from the object property in the output - asserting that we're passing in the options with every call to the main merge function\r\n\r\nDo you want to add those tests and the implementation in this branch/pull request?  I'm fine leaving this pull request open, or we can merge your changes into a `merge-all` branch on this repo and open future pull requests against that branch, either way."}}
{"actor":{"display_login":"TehShrike"}}