{"action":"closed","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-styles/issues/294","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-styles","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-styles/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-styles/issues/294/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-styles/issues/294/events","html_url":"https://github.com/mapbox/mapbox-gl-styles/issues/294","id":141303710,"number":294,"title":"Avoid scaling images (map feedback + test suggestion)","user":{"login":"samanpwbb","id":108094,"avatar_url":"https://avatars.githubusercontent.com/u/108094?v=3","gravatar_id":"","url":"https://api.github.com/users/samanpwbb","html_url":"https://github.com/samanpwbb","followers_url":"https://api.github.com/users/samanpwbb/followers","following_url":"https://api.github.com/users/samanpwbb/following{/other_user}","gists_url":"https://api.github.com/users/samanpwbb/gists{/gist_id}","starred_url":"https://api.github.com/users/samanpwbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanpwbb/subscriptions","organizations_url":"https://api.github.com/users/samanpwbb/orgs","repos_url":"https://api.github.com/users/samanpwbb/repos","events_url":"https://api.github.com/users/samanpwbb/events{/privacy}","received_events_url":"https://api.github.com/users/samanpwbb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-16T15:09:47Z","updated_at":"2016-05-02T21:34:14Z","closed_at":"2016-05-02T21:34:14Z","body":"I notice there are cases in emerald where image size is above 1: https://github.com/mapbox/mapbox-gl-styles/blob/remove-sandnoise/styles/emerald-v8.json#L5022\r\n\r\nSetting an image size above 1 means you will have cheap looking blurry images, especially on non-retina screens. It should never happen. Remember that even though the source images are SVG, our asset API serves PNGs. Out of respect for how screen resolution works, I think we should enforce a range of image size values only from: 1 to .5. \r\n\r\nIdeally, every image should always be size 1.\r\n\r\nA value set exactly to .5 does make sense in some cases: if the full size image is also used, and the full size image has vertex values that are almost always equal to even integers. Otherwise even .5 sized images will look blurry.\r\n\r\nThere are cases when you want to gradually ramp up an icon from say .8 to 1. I think that's fair. Maybe if an image is used in a ramp, we have slightly looser rules.\r\n\r\ncc: @amyleew @peterqliu "}}