{"action":"created","comment":{"url":"https://api.github.com/repos/basho/riak_test/pulls/comments/89813609","pull_request_review_id":10347329,"id":89813609,"diff_hunk":"@@ -218,7 +218,8 @@ init_per_testcase(query_orderby_ldb_io_error, Cfg) ->\n     QBufDir = filename:join([rtdev:node_path(Node), \"data/query_buffers\"]),\n     Cmd = get_write_perm_cmd(take_away, QBufDir),\n     ct:log(\"running ~s\", [Cmd]),\n-    \"\" = os:cmd(Cmd),\n+    CmdOut = \"\" = os:cmd(Cmd),","path":"tests/ts_simple_query_buffers_SUITE.erl","position":null,"original_position":5,"commit_id":"954affbf22f6795d09d3071e30c945258862543f","original_commit_id":"954affbf22f6795d09d3071e30c945258862543f","user":{"login":"hmmr","id":1107079,"avatar_url":"https://avatars.githubusercontent.com/u/1107079?v=3","gravatar_id":"","url":"https://api.github.com/users/hmmr","html_url":"https://github.com/hmmr","followers_url":"https://api.github.com/users/hmmr/followers","following_url":"https://api.github.com/users/hmmr/following{/other_user}","gists_url":"https://api.github.com/users/hmmr/gists{/gist_id}","starred_url":"https://api.github.com/users/hmmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmmr/subscriptions","organizations_url":"https://api.github.com/users/hmmr/orgs","repos_url":"https://api.github.com/users/hmmr/repos","events_url":"https://api.github.com/users/hmmr/events{/privacy}","received_events_url":"https://api.github.com/users/hmmr/received_events","type":"User","site_admin":false},"body":"No, you want to print it before matching to `\"\"`.","created_at":"2016-11-28T16:08:25Z","updated_at":"2016-11-28T16:08:25Z","html_url":"https://github.com/basho/riak_test/pull/1209#discussion_r89813609","pull_request_url":"https://api.github.com/repos/basho/riak_test/pulls/1209","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_test/pulls/comments/89813609"},"html":{"href":"https://github.com/basho/riak_test/pull/1209#discussion_r89813609"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_test/pulls/1209"}}},"pull_request":{"url":"https://api.github.com/repos/basho/riak_test/pulls/1209","id":95074946,"html_url":"https://github.com/basho/riak_test/pull/1209","diff_url":"https://github.com/basho/riak_test/pull/1209.diff","patch_url":"https://github.com/basho/riak_test/pull/1209.patch","issue_url":"https://api.github.com/repos/basho/riak_test/issues/1209","number":1209,"state":"open","locked":false,"title":"Query buffer suite chmod fix kc","user":{"login":"korry8911","id":10292569,"avatar_url":"https://avatars.githubusercontent.com/u/10292569?v=3","gravatar_id":"","url":"https://api.github.com/users/korry8911","html_url":"https://github.com/korry8911","followers_url":"https://api.github.com/users/korry8911/followers","following_url":"https://api.github.com/users/korry8911/following{/other_user}","gists_url":"https://api.github.com/users/korry8911/gists{/gist_id}","starred_url":"https://api.github.com/users/korry8911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korry8911/subscriptions","organizations_url":"https://api.github.com/users/korry8911/orgs","repos_url":"https://api.github.com/users/korry8911/repos","events_url":"https://api.github.com/users/korry8911/events{/privacy}","received_events_url":"https://api.github.com/users/korry8911/received_events","type":"User","site_admin":false},"body":"@javajolt @hmmr \r\nok so this test needs to remove and restore write permission to the query buffer directory to test that the proper error is passed. The way it was doing this is through chmod but since riak_test is run using root user in basho_builds, chmod is rendered useless. To regain the expect behavior there are two function chattr and chflags that are now used.  The reason for using two different functions is that linux uses one and osx uses the other.  As far as I can tell these are the only two functions that will remove and restore write permissions for root user for their respectifve OSes. I inlcuded the option of using the OSX chlags so that local testing will have the same behavior as the basho_builds runs.","created_at":"2016-11-23T20:33:26Z","updated_at":"2016-11-28T16:10:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"febd5e6a09d28d3fb2209ee6feb96658c73adbb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/basho/riak_test/pulls/1209/commits","review_comments_url":"https://api.github.com/repos/basho/riak_test/pulls/1209/comments","review_comment_url":"https://api.github.com/repos/basho/riak_test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basho/riak_test/issues/1209/comments","statuses_url":"https://api.github.com/repos/basho/riak_test/statuses/954affbf22f6795d09d3071e30c945258862543f","head":{"label":"basho:query_buffer_SUITE-chmod-fix-kc","ref":"query_buffer_SUITE-chmod-fix-kc","sha":"954affbf22f6795d09d3071e30c945258862543f","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":3149948,"name":"riak_test","full_name":"basho/riak_test","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_test","description":"I'm in your cluster, testing your riaks","fork":false,"url":"https://api.github.com/repos/basho/riak_test","forks_url":"https://api.github.com/repos/basho/riak_test/forks","keys_url":"https://api.github.com/repos/basho/riak_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_test/teams","hooks_url":"https://api.github.com/repos/basho/riak_test/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_test/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_test/events","assignees_url":"https://api.github.com/repos/basho/riak_test/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_test/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_test/tags","blobs_url":"https://api.github.com/repos/basho/riak_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_test/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_test/languages","stargazers_url":"https://api.github.com/repos/basho/riak_test/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_test/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_test/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_test/subscription","commits_url":"https://api.github.com/repos/basho/riak_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak_test/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_test/merges","archive_url":"https://api.github.com/repos/basho/riak_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_test/downloads","issues_url":"https://api.github.com/repos/basho/riak_test/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_test/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_test/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_test/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_test/releases{/id}","deployments_url":"https://api.github.com/repos/basho/riak_test/deployments","created_at":"2012-01-11T00:31:00Z","updated_at":"2016-11-17T22:49:39Z","pushed_at":"2016-11-28T15:40:18Z","git_url":"git://github.com/basho/riak_test.git","ssh_url":"git@github.com:basho/riak_test.git","clone_url":"https://github.com/basho/riak_test.git","svn_url":"https://github.com/basho/riak_test","homepage":"http://basho.github.com/riak_test/","size":32986,"stargazers_count":61,"watchers_count":61,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":58,"forks":38,"open_issues":58,"watchers":61,"default_branch":"develop"}},"base":{"label":"basho:riak_ts-develop","ref":"riak_ts-develop","sha":"8e1b0371ac74f178705b56814552ab5a0ee22ea8","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":3149948,"name":"riak_test","full_name":"basho/riak_test","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_test","description":"I'm in your cluster, testing your riaks","fork":false,"url":"https://api.github.com/repos/basho/riak_test","forks_url":"https://api.github.com/repos/basho/riak_test/forks","keys_url":"https://api.github.com/repos/basho/riak_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_test/teams","hooks_url":"https://api.github.com/repos/basho/riak_test/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_test/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_test/events","assignees_url":"https://api.github.com/repos/basho/riak_test/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_test/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_test/tags","blobs_url":"https://api.github.com/repos/basho/riak_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_test/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_test/languages","stargazers_url":"https://api.github.com/repos/basho/riak_test/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_test/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_test/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_test/subscription","commits_url":"https://api.github.com/repos/basho/riak_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak_test/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_test/merges","archive_url":"https://api.github.com/repos/basho/riak_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_test/downloads","issues_url":"https://api.github.com/repos/basho/riak_test/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_test/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_test/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_test/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_test/releases{/id}","deployments_url":"https://api.github.com/repos/basho/riak_test/deployments","created_at":"2012-01-11T00:31:00Z","updated_at":"2016-11-17T22:49:39Z","pushed_at":"2016-11-28T15:40:18Z","git_url":"git://github.com/basho/riak_test.git","ssh_url":"git@github.com:basho/riak_test.git","clone_url":"https://github.com/basho/riak_test.git","svn_url":"https://github.com/basho/riak_test","homepage":"http://basho.github.com/riak_test/","size":32986,"stargazers_count":61,"watchers_count":61,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":58,"forks":38,"open_issues":58,"watchers":61,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/riak_test/pulls/1209"},"html":{"href":"https://github.com/basho/riak_test/pull/1209"},"issue":{"href":"https://api.github.com/repos/basho/riak_test/issues/1209"},"comments":{"href":"https://api.github.com/repos/basho/riak_test/issues/1209/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/riak_test/pulls/1209/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/riak_test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basho/riak_test/pulls/1209/commits"},"statuses":{"href":"https://api.github.com/repos/basho/riak_test/statuses/954affbf22f6795d09d3071e30c945258862543f"}}}}
{"actor":{"display_login":"hmmr"}}