{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/haddock/pulls/comments/77865551","id":77865551,"diff_hunk":"@@ -602,6 +612,34 @@ mkExportItems\n     isExported = (`elem` exportedNames)\n \n \n+    -- Convert a bundled pattern to a GADT constructor\n+    bundledPatToCon :: Name -> ErrMsgGhc [(LConDecl Name,(Name, DocForDecl Name))]\n+    bundledPatToCon t = case findDecl t of\n+      ([L l (ValD (PatSynBind _))], (doc, _)) -> do\n+        export <- hiValExportItem dflags t l doc (l `elem` splices) $ M.lookup t fixMap\n+        case export of\n+          (ExportDecl (L l' (SigD (PatSynSig (L _ n) ty))) doc' _ _ _ _) ->\n+            return [(L l' (ConDeclGADT [L l' n] ty Nothing),(n,doc'))]\n+          _ -> return []\n+      ([L _ (SigD (PatSynSig (L l' n) ty))], (doc, _)) ->\n+        return [(L l' (ConDeclGADT [L l' n] ty Nothing),(n,doc))]\n+      _ -> return []\n+\n+\n+    -- Add bundled-pattens-converted-to-constructors to a data type declaration","path":"haddock-api/src/Haddock/Interface/Create.hs","position":93,"original_position":93,"commit_id":"7984c8fb8f238793641a419c93fbcb4f6e933ae5","original_commit_id":"7984c8fb8f238793641a419c93fbcb4f6e933ae5","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"pattern","created_at":"2016-09-07T17:12:38Z","updated_at":"2016-09-07T17:12:38Z","html_url":"https://github.com/haskell/haddock/pull/494#discussion_r77865551","pull_request_url":"https://api.github.com/repos/haskell/haddock/pulls/494","_links":{"self":{"href":"https://api.github.com/repos/haskell/haddock/pulls/comments/77865551"},"html":{"href":"https://github.com/haskell/haddock/pull/494#discussion_r77865551"},"pull_request":{"href":"https://api.github.com/repos/haskell/haddock/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/haddock/pulls/494","id":67043784,"html_url":"https://github.com/haskell/haddock/pull/494","diff_url":"https://github.com/haskell/haddock/pull/494.diff","patch_url":"https://github.com/haskell/haddock/pull/494.patch","issue_url":"https://api.github.com/repos/haskell/haddock/issues/494","number":494,"state":"open","locked":false,"title":"Display bundled pattern synonyms as constructors.","user":{"login":"mpickering","id":1216657,"avatar_url":"https://avatars.githubusercontent.com/u/1216657?v=3","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"body":"Need to do a proper review but don't have time at the moment.","created_at":"2016-04-19T15:53:57Z","updated_at":"2016-09-07T17:12:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3910f8e13f5fa35e88e2036ebba122298ff15299","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/haddock/pulls/494/commits","review_comments_url":"https://api.github.com/repos/haskell/haddock/pulls/494/comments","review_comment_url":"https://api.github.com/repos/haskell/haddock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/haddock/issues/494/comments","statuses_url":"https://api.github.com/repos/haskell/haddock/statuses/7984c8fb8f238793641a419c93fbcb4f6e933ae5","head":{"label":"mpickering:master","ref":"master","sha":"7984c8fb8f238793641a419c93fbcb4f6e933ae5","user":{"login":"mpickering","id":1216657,"avatar_url":"https://avatars.githubusercontent.com/u/1216657?v=3","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"repo":{"id":29112597,"name":"haddock","full_name":"mpickering/haddock","owner":{"login":"mpickering","id":1216657,"avatar_url":"https://avatars.githubusercontent.com/u/1216657?v=3","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpickering/haddock","description":"Haskell Documentation Tool","fork":true,"url":"https://api.github.com/repos/mpickering/haddock","forks_url":"https://api.github.com/repos/mpickering/haddock/forks","keys_url":"https://api.github.com/repos/mpickering/haddock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpickering/haddock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpickering/haddock/teams","hooks_url":"https://api.github.com/repos/mpickering/haddock/hooks","issue_events_url":"https://api.github.com/repos/mpickering/haddock/issues/events{/number}","events_url":"https://api.github.com/repos/mpickering/haddock/events","assignees_url":"https://api.github.com/repos/mpickering/haddock/assignees{/user}","branches_url":"https://api.github.com/repos/mpickering/haddock/branches{/branch}","tags_url":"https://api.github.com/repos/mpickering/haddock/tags","blobs_url":"https://api.github.com/repos/mpickering/haddock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpickering/haddock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpickering/haddock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpickering/haddock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpickering/haddock/statuses/{sha}","languages_url":"https://api.github.com/repos/mpickering/haddock/languages","stargazers_url":"https://api.github.com/repos/mpickering/haddock/stargazers","contributors_url":"https://api.github.com/repos/mpickering/haddock/contributors","subscribers_url":"https://api.github.com/repos/mpickering/haddock/subscribers","subscription_url":"https://api.github.com/repos/mpickering/haddock/subscription","commits_url":"https://api.github.com/repos/mpickering/haddock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpickering/haddock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpickering/haddock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpickering/haddock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpickering/haddock/contents/{+path}","compare_url":"https://api.github.com/repos/mpickering/haddock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpickering/haddock/merges","archive_url":"https://api.github.com/repos/mpickering/haddock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpickering/haddock/downloads","issues_url":"https://api.github.com/repos/mpickering/haddock/issues{/number}","pulls_url":"https://api.github.com/repos/mpickering/haddock/pulls{/number}","milestones_url":"https://api.github.com/repos/mpickering/haddock/milestones{/number}","notifications_url":"https://api.github.com/repos/mpickering/haddock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpickering/haddock/labels{/name}","releases_url":"https://api.github.com/repos/mpickering/haddock/releases{/id}","deployments_url":"https://api.github.com/repos/mpickering/haddock/deployments","created_at":"2015-01-12T01:05:03Z","updated_at":"2016-04-19T15:50:01Z","pushed_at":"2016-05-09T14:37:24Z","git_url":"git://github.com/mpickering/haddock.git","ssh_url":"git@github.com:mpickering/haddock.git","clone_url":"https://github.com/mpickering/haddock.git","svn_url":"https://github.com/mpickering/haddock","homepage":"www.haskell.org/haddock/","size":13210,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"fea4b0a3589ad67d72594b16ceb0e6922e7f2bb8","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":19586474,"name":"haddock","full_name":"haskell/haddock","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/haddock","description":"Haskell Documentation Tool","fork":false,"url":"https://api.github.com/repos/haskell/haddock","forks_url":"https://api.github.com/repos/haskell/haddock/forks","keys_url":"https://api.github.com/repos/haskell/haddock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/haddock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/haddock/teams","hooks_url":"https://api.github.com/repos/haskell/haddock/hooks","issue_events_url":"https://api.github.com/repos/haskell/haddock/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/haddock/events","assignees_url":"https://api.github.com/repos/haskell/haddock/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/haddock/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/haddock/tags","blobs_url":"https://api.github.com/repos/haskell/haddock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/haddock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/haddock/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/haddock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/haddock/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/haddock/languages","stargazers_url":"https://api.github.com/repos/haskell/haddock/stargazers","contributors_url":"https://api.github.com/repos/haskell/haddock/contributors","subscribers_url":"https://api.github.com/repos/haskell/haddock/subscribers","subscription_url":"https://api.github.com/repos/haskell/haddock/subscription","commits_url":"https://api.github.com/repos/haskell/haddock/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/haddock/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/haddock/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/haddock/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/haddock/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/haddock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/haddock/merges","archive_url":"https://api.github.com/repos/haskell/haddock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/haddock/downloads","issues_url":"https://api.github.com/repos/haskell/haddock/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/haddock/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/haddock/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/haddock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/haddock/labels{/name}","releases_url":"https://api.github.com/repos/haskell/haddock/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/haddock/deployments","created_at":"2014-05-08T19:42:26Z","updated_at":"2016-09-04T15:25:35Z","pushed_at":"2016-08-29T19:47:45Z","git_url":"git://github.com/haskell/haddock.git","ssh_url":"git@github.com:haskell/haddock.git","clone_url":"https://github.com/haskell/haddock.git","svn_url":"https://github.com/haskell/haddock","homepage":"www.haskell.org/haddock/","size":13898,"stargazers_count":71,"watchers_count":71,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":184,"forks":68,"open_issues":184,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/haddock/pulls/494"},"html":{"href":"https://github.com/haskell/haddock/pull/494"},"issue":{"href":"https://api.github.com/repos/haskell/haddock/issues/494"},"comments":{"href":"https://api.github.com/repos/haskell/haddock/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/haddock/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/haddock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/haddock/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/haddock/statuses/7984c8fb8f238793641a419c93fbcb4f6e933ae5"}}}}
{"actor":{"display_login":"ezyang"}}