{"action":"closed","number":4233,"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4233","id":94691789,"html_url":"https://github.com/w3c/web-platform-tests/pull/4233","diff_url":"https://github.com/w3c/web-platform-tests/pull/4233.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/4233.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4233","number":4233,"state":"closed","locked":false,"title":"Cache Storage: Make test setup resilient against buggy implementations","user":{"login":"inexorabletash","id":771547,"avatar_url":"https://avatars.githubusercontent.com/u/771547?v=3","gravatar_id":"","url":"https://api.github.com/users/inexorabletash","html_url":"https://github.com/inexorabletash","followers_url":"https://api.github.com/users/inexorabletash/followers","following_url":"https://api.github.com/users/inexorabletash/following{/other_user}","gists_url":"https://api.github.com/users/inexorabletash/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorabletash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorabletash/subscriptions","organizations_url":"https://api.github.com/users/inexorabletash/orgs","repos_url":"https://api.github.com/users/inexorabletash/repos","events_url":"https://api.github.com/users/inexorabletash/events{/privacy}","received_events_url":"https://api.github.com/users/inexorabletash/received_events","type":"User","site_admin":false},"body":"One test asserts that the cache name \"unpaired\\uD800\" does not get mapped to \"unpaired\\uFFFD\", but relies on a cache by that name not existing. If an implementation is buggy it will implicitly create the cache, causing the test to fail the setup checks on subsequent runs, as opposed to hitting the actual test assertions.\r\n\r\nChange the test to delete the caches so that it starts with a clean slate regardless of whether or it passes the test.\r\n\r\n\r\n","created_at":"2016-11-21T20:36:56Z","updated_at":"2016-11-22T18:38:01Z","closed_at":"2016-11-22T18:38:01Z","merged_at":"2016-11-22T18:38:01Z","merge_commit_sha":"a4c2b37ce8678756ee5ebcd7350b190f30ea6c9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4233/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4233/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4233/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/99b43f1edac32d3b23d7fd168fb5015b2b72bca4","head":{"label":"inexorabletash:sw-cache-flake","ref":"sw-cache-flake","sha":"99b43f1edac32d3b23d7fd168fb5015b2b72bca4","user":{"login":"inexorabletash","id":771547,"avatar_url":"https://avatars.githubusercontent.com/u/771547?v=3","gravatar_id":"","url":"https://api.github.com/users/inexorabletash","html_url":"https://github.com/inexorabletash","followers_url":"https://api.github.com/users/inexorabletash/followers","following_url":"https://api.github.com/users/inexorabletash/following{/other_user}","gists_url":"https://api.github.com/users/inexorabletash/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorabletash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorabletash/subscriptions","organizations_url":"https://api.github.com/users/inexorabletash/orgs","repos_url":"https://api.github.com/users/inexorabletash/repos","events_url":"https://api.github.com/users/inexorabletash/events{/privacy}","received_events_url":"https://api.github.com/users/inexorabletash/received_events","type":"User","site_admin":false},"repo":{"id":18644067,"name":"web-platform-tests","full_name":"inexorabletash/web-platform-tests","owner":{"login":"inexorabletash","id":771547,"avatar_url":"https://avatars.githubusercontent.com/u/771547?v=3","gravatar_id":"","url":"https://api.github.com/users/inexorabletash","html_url":"https://github.com/inexorabletash","followers_url":"https://api.github.com/users/inexorabletash/followers","following_url":"https://api.github.com/users/inexorabletash/following{/other_user}","gists_url":"https://api.github.com/users/inexorabletash/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorabletash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorabletash/subscriptions","organizations_url":"https://api.github.com/users/inexorabletash/orgs","repos_url":"https://api.github.com/users/inexorabletash/repos","events_url":"https://api.github.com/users/inexorabletash/events{/privacy}","received_events_url":"https://api.github.com/users/inexorabletash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inexorabletash/web-platform-tests","description":"Test Suites for Web Platform specifications","fork":true,"url":"https://api.github.com/repos/inexorabletash/web-platform-tests","forks_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/forks","keys_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/events","assignees_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/merges","archive_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/inexorabletash/web-platform-tests/deployments","created_at":"2014-04-10T16:48:27Z","updated_at":"2016-01-13T21:36:44Z","pushed_at":"2016-11-22T18:29:28Z","git_url":"git://github.com/inexorabletash/web-platform-tests.git","ssh_url":"git@github.com:inexorabletash/web-platform-tests.git","clone_url":"https://github.com/inexorabletash/web-platform-tests.git","svn_url":"https://github.com/inexorabletash/web-platform-tests","homepage":"","size":167870,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"1e61b51400ca005116d82fc46325ceebee407627","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2016-11-22T03:01:43Z","pushed_at":"2016-11-22T18:38:02Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":339679,"stargazers_count":889,"watchers_count":889,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":968,"mirror_url":null,"open_issues_count":411,"forks":968,"open_issues":411,"watchers":889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4233"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/4233"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/4233"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/4233/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4233/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4233/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/99b43f1edac32d3b23d7fd168fb5015b2b72bca4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"inexorabletash","id":771547,"avatar_url":"https://avatars.githubusercontent.com/u/771547?v=3","gravatar_id":"","url":"https://api.github.com/users/inexorabletash","html_url":"https://github.com/inexorabletash","followers_url":"https://api.github.com/users/inexorabletash/followers","following_url":"https://api.github.com/users/inexorabletash/following{/other_user}","gists_url":"https://api.github.com/users/inexorabletash/gists{/gist_id}","starred_url":"https://api.github.com/users/inexorabletash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexorabletash/subscriptions","organizations_url":"https://api.github.com/users/inexorabletash/orgs","repos_url":"https://api.github.com/users/inexorabletash/repos","events_url":"https://api.github.com/users/inexorabletash/events{/privacy}","received_events_url":"https://api.github.com/users/inexorabletash/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"commits":1,"additions":22,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"inexorabletash"}}