{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/vault/issues/1449","repository_url":"https://api.github.com/repos/hashicorp/vault","labels_url":"https://api.github.com/repos/hashicorp/vault/issues/1449/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/1449/comments","events_url":"https://api.github.com/repos/hashicorp/vault/issues/1449/events","html_url":"https://github.com/hashicorp/vault/issues/1449","id":156785242,"number":1449,"title":"PKI backend should validate input","user":{"login":"sethvargo","id":408570,"avatar_url":"https://avatars.githubusercontent.com/u/408570?v=3","gravatar_id":"","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-25T15:49:32Z","updated_at":"2016-05-25T19:43:37Z","closed_at":null,"body":"During training today, almost half the class entered a silly and easy typo and Vault happily accepted the value.\r\n\r\n```\r\nvault write pki/roles/my-vault-com allowed_domains=\"my-vault.com\" allowed_subdomains=\"true\"\r\n```\r\n\r\nThe actual config is:\r\n\r\n```diff\r\n- allowed_subdomains\r\n+ allow_subdomains\r\n```\r\n\r\nThis is a really easy mistake since the prior value is `allowed_domains`. Could we validate the input and say something like:\r\n\r\n> Unknown key(s): [allowed_subdomains]\r\n\r\n/cc @jefferai \r\n"},"comment":{"url":"https://api.github.com/repos/hashicorp/vault/issues/comments/221684997","html_url":"https://github.com/hashicorp/vault/issues/1449#issuecomment-221684997","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/1449","id":221684997,"user":{"login":"jefferai","id":28627,"avatar_url":"https://avatars.githubusercontent.com/u/28627?v=3","gravatar_id":"","url":"https://api.github.com/users/jefferai","html_url":"https://github.com/jefferai","followers_url":"https://api.github.com/users/jefferai/followers","following_url":"https://api.github.com/users/jefferai/following{/other_user}","gists_url":"https://api.github.com/users/jefferai/gists{/gist_id}","starred_url":"https://api.github.com/users/jefferai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefferai/subscriptions","organizations_url":"https://api.github.com/users/jefferai/orgs","repos_url":"https://api.github.com/users/jefferai/repos","events_url":"https://api.github.com/users/jefferai/events{/privacy}","received_events_url":"https://api.github.com/users/jefferai/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T19:43:37Z","updated_at":"2016-05-25T19:43:37Z","body":"This is more of a larger question around validating input based on endpoint schemas, which Vault doesn't do anywhere. But we could do something targeted here due to the value switch."}}
{"actor":{"display_login":"jefferai"}}