{"action":"created","issue":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/245","repository_url":"https://api.github.com/repos/sourcelair/xterm.js","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/245/comments","events_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/245/events","html_url":"https://github.com/sourcelair/xterm.js/pull/245","id":172814173,"number":245,"title":"ES6 remap","user":{"login":"131","id":13545,"avatar_url":"https://avatars.githubusercontent.com/u/13545?v=3","gravatar_id":"","url":"https://api.github.com/users/131","html_url":"https://github.com/131","followers_url":"https://api.github.com/users/131/followers","following_url":"https://api.github.com/users/131/following{/other_user}","gists_url":"https://api.github.com/users/131/gists{/gist_id}","starred_url":"https://api.github.com/users/131/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/131/subscriptions","organizations_url":"https://api.github.com/users/131/orgs","repos_url":"https://api.github.com/users/131/repos","events_url":"https://api.github.com/users/131/events{/privacy}","received_events_url":"https://api.github.com/users/131/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-08-23T21:40:39Z","updated_at":"2016-08-26T01:25:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sourcelair/xterm.js/pulls/245","html_url":"https://github.com/sourcelair/xterm.js/pull/245","diff_url":"https://github.com/sourcelair/xterm.js/pull/245.diff","patch_url":"https://github.com/sourcelair/xterm.js/pull/245.patch"},"body":"Fix  https://github.com/sourcelair/xterm.js/issues/158\r\n\r\nSlice code in ES6 module.\r\n\r\nCompositionhelper, viewport & eventemitter are proper ES6 classes.\r\nThe Terminal classe is big, yet wcwidth and escapeSequence have been sliced too, this increase overall readability and testing scope. ( slicing can be done on other parts of Terminal class, if desired)\r\n\r\nTests are fine\r\nDocumentation generation is fine\r\n\r\nnew pm task\r\n* npm run build:dist to build standalone version ( exactly same signature as current version) in /dist folder\r\n\r\n\r\nStrongly simplify demo/app.js (server side)\r\n  no need for external fetch, just use WS socket all along\r\nStrongly simplify demo/index.html / demo/main.js\r\n\r\nStrongly simplify addon design & loading\r\n\r\nin package.json\r\n  node_modules/.bin is in npm run path, so no need to set it"},"comment":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/comments/242595066","html_url":"https://github.com/sourcelair/xterm.js/pull/245#issuecomment-242595066","issue_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/245","id":242595066,"user":{"login":"parisk","id":1188592,"avatar_url":"https://avatars.githubusercontent.com/u/1188592?v=3","gravatar_id":"","url":"https://api.github.com/users/parisk","html_url":"https://github.com/parisk","followers_url":"https://api.github.com/users/parisk/followers","following_url":"https://api.github.com/users/parisk/following{/other_user}","gists_url":"https://api.github.com/users/parisk/gists{/gist_id}","starred_url":"https://api.github.com/users/parisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisk/subscriptions","organizations_url":"https://api.github.com/users/parisk/orgs","repos_url":"https://api.github.com/users/parisk/repos","events_url":"https://api.github.com/users/parisk/events{/privacy}","received_events_url":"https://api.github.com/users/parisk/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T01:25:59Z","updated_at":"2016-08-26T01:25:59Z","body":"While I lean more towards TypeScript now that I took a deeper look at it and @Tyriar's PR, I would like to make one main comment here: could we leave demo refactoring out of this, in order to reduce to-be-reviewed code?\r\n\r\nAlso may I ask we did you decide to introduce the `index.js` files?"}}
{"actor":{"display_login":"parisk"}}