{"action":"created","issue":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3347","repository_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite","labels_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3347/labels{/name}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3347/comments","events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3347/events","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3347","id":174801121,"number":3347,"title":"Fix issues with Keyboard Navigation when `fixHideLinks` is turned off.","user":{"login":"alexvanolst","id":7325958,"avatar_url":"https://avatars.githubusercontent.com/u/7325958?v=3","gravatar_id":"","url":"https://api.github.com/users/alexvanolst","html_url":"https://github.com/alexvanolst","followers_url":"https://api.github.com/users/alexvanolst/followers","following_url":"https://api.github.com/users/alexvanolst/following{/other_user}","gists_url":"https://api.github.com/users/alexvanolst/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvanolst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvanolst/subscriptions","organizations_url":"https://api.github.com/users/alexvanolst/orgs","repos_url":"https://api.github.com/users/alexvanolst/repos","events_url":"https://api.github.com/users/alexvanolst/events{/privacy}","received_events_url":"https://api.github.com/users/alexvanolst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-02T16:39:35Z","updated_at":"2016-09-02T16:54:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3347","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3347","diff_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3347.diff","patch_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3347.patch"},"body":"Resolves two issues around hiding links with a keyboard shortcut.\r\n\r\n**Issue 1:** \r\nNull reference on pressing hide shortcut shortly after hiding or when no element is selected (this causes keyboard navigation to stop working). Quite an old issue, there was a post [here](https://www.reddit.com/r/RESissues/comments/40irwi/bug_issues_with_hide_shortcuthiding_submissions/?st=islzf9j7&sh=c3e95dd3) but it was deleted.\r\n\r\n**Issue 2:**\r\nScrolling to the next item does not work nicely when hiding items, since after the item has been hidden the page content moves and the content that was previously scrolled to moves off screen. I've added a 'none' option as a workaround for users experiencing this. \r\n\r\nhttps://www.reddit.com/r/RESissues/comments/4qc4xc/bug_hide_select_new_5_second_delay_hides_moves_up/?st=islz1ap4&sh=d7cffdd2 (only fixes case where `fixHideLinks` is off)"},"comment":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/comments/244429712","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3347#issuecomment-244429712","issue_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3347","id":244429712,"user":{"login":"larsjohnsen","id":1748521,"avatar_url":"https://avatars.githubusercontent.com/u/1748521?v=3","gravatar_id":"","url":"https://api.github.com/users/larsjohnsen","html_url":"https://github.com/larsjohnsen","followers_url":"https://api.github.com/users/larsjohnsen/followers","following_url":"https://api.github.com/users/larsjohnsen/following{/other_user}","gists_url":"https://api.github.com/users/larsjohnsen/gists{/gist_id}","starred_url":"https://api.github.com/users/larsjohnsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsjohnsen/subscriptions","organizations_url":"https://api.github.com/users/larsjohnsen/orgs","repos_url":"https://api.github.com/users/larsjohnsen/repos","events_url":"https://api.github.com/users/larsjohnsen/events{/privacy}","received_events_url":"https://api.github.com/users/larsjohnsen/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T16:54:36Z","updated_at":"2016-09-02T16:54:36Z","body":"Related: I wrote `selectClosestVisible` which may be used here after `click(hide)` instead of the `scrollStyle: 'null'` workaround.\r\n\r\nhttps://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3042/commits/b532b9b7e45c2741726cb7c133c230e98631f596#diff-04a03be1356b2339100df6464d9f34d6R181\r\nFeel free to copy it. "}}
{"actor":{"display_login":"larsjohnsen"}}