{"action":"created","issue":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/4554","repository_url":"https://api.github.com/repos/phpbb/phpbb","labels_url":"https://api.github.com/repos/phpbb/phpbb/issues/4554/labels{/name}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/4554/comments","events_url":"https://api.github.com/repos/phpbb/phpbb/issues/4554/events","html_url":"https://github.com/phpbb/phpbb/pull/4554","id":193317911,"number":4554,"title":"[ticket/13853] Flexible schema for profilefields step 1 configuration","user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-03T22:36:13Z","updated_at":"2016-12-06T19:28:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/4554","html_url":"https://github.com/phpbb/phpbb/pull/4554","diff_url":"https://github.com/phpbb/phpbb/pull/4554.diff","patch_url":"https://github.com/phpbb/phpbb/pull/4554.patch"},"body":"Modify the way adm/style/acp_profile.html STEP 1 (lines 106 to 128)\r\nis coded to make it flexible and expandable to other new types of\r\nprofile fields, rather than the current mechanism, hardcoded for\r\nthe default types.\r\n\r\nA flexible mechanism similar to the one used of STEP 2 is used.\r\n\r\nThis required a slight modification of the type_interface, and\r\ncorresponding modifications to all implementations of that interface.\r\n\r\nIncludes a fix in the type_interface, missing a required method.\r\n\r\nChecklist:\r\n\r\n- [ ] Correct branch: master for new features; 3.2.x, 3.1.x for fixes\r\n- [ ] Tests pass\r\n- [ ] Code follows coding guidelines: [master / 3.2.x](https://area51.phpbb.com/docs/master/coding-guidelines.html), [3.1.x](https://area51.phpbb.com/docs/31x/coding-guidelines.html)\r\n- [ ] Commit follows commit message [format](https://wiki.phpbb.com/Git#Commit_Messages)\r\n\r\nTracker ticket:\r\n\r\nhttps://tracker.phpbb.com/browse/PHPBB3-13853\r\n"},"comment":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/265247593","html_url":"https://github.com/phpbb/phpbb/pull/4554#issuecomment-265247593","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/4554","id":265247593,"user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T19:28:41Z","updated_at":"2016-12-06T19:28:41Z","body":"Looking at it again, I think this will also help in case someone wants to modify the way things are displayed, as the \"options\" are exposed to extensions through the core.acp_profile_create_edit_after event.  If the code remains as is, the variables are hardcoded to the template, and not exposed to extensions for potential modification.  The only way to modify them would be to reproduce the code in each and every type (that needs modification) within the extension...  This may be even more generalized, if required, by exposing the regular template variables (in addition to block/type dependent variables, already taken care of) before being sent to the template..."}}
{"actor":{"display_login":"javiexin"}}