{"action":"created","comment":{"url":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/comments/63539024","id":63539024,"diff_hunk":"@@ -32,10 +36,18 @@ def from_android_tablet?\n         os == \"Android\" && !android_mobile?\n       end\n \n+      def from_android_os?\n+        from_android? || from_android_tablet?\n+      end\n+\n       def from_windows_phone?\n         os == \"Windows Phone OS\"\n       end\n \n+      def from_windows_phone_os?\n+        from_windows_phone?","path":"lib/rack/user_agent/detector.rb","position":null,"original_position":24,"commit_id":"56f1c003fbc4d8db20da1a7e06cdaf32d60bde07","original_commit_id":"a9d0bd818424b0e8dcc78238a34d46d41feb9528","user":{"login":"knjko","id":35577,"avatar_url":"https://avatars.githubusercontent.com/u/35577?v=3","gravatar_id":"","url":"https://api.github.com/users/knjko","html_url":"https://github.com/knjko","followers_url":"https://api.github.com/users/knjko/followers","following_url":"https://api.github.com/users/knjko/following{/other_user}","gists_url":"https://api.github.com/users/knjko/gists{/gist_id}","starred_url":"https://api.github.com/users/knjko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knjko/subscriptions","organizations_url":"https://api.github.com/users/knjko/orgs","repos_url":"https://api.github.com/users/knjko/repos","events_url":"https://api.github.com/users/knjko/events{/privacy}","received_events_url":"https://api.github.com/users/knjko/received_events","type":"User","site_admin":false},"body":"@k0kubun \r\nYou are right, it was useless :)\r\nI just added this for detecting Windows Phone and other Windows Phone devices such as tablets, but it seems that *Windows Phone Tablet* doesn't exist. I got rid of this 🚮 ","created_at":"2016-05-17T15:02:50Z","updated_at":"2016-05-17T15:02:50Z","html_url":"https://github.com/k0kubun/rack-user_agent/pull/6#discussion_r63539024","pull_request_url":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/comments/63539024"},"html":{"href":"https://github.com/k0kubun/rack-user_agent/pull/6#discussion_r63539024"},"pull_request":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6","id":70360185,"html_url":"https://github.com/k0kubun/rack-user_agent/pull/6","diff_url":"https://github.com/k0kubun/rack-user_agent/pull/6.diff","patch_url":"https://github.com/k0kubun/rack-user_agent/pull/6.patch","issue_url":"https://api.github.com/repos/k0kubun/rack-user_agent/issues/6","number":6,"state":"open","locked":false,"title":"Add methods to detect os","user":{"login":"knjko","id":35577,"avatar_url":"https://avatars.githubusercontent.com/u/35577?v=3","gravatar_id":"","url":"https://api.github.com/users/knjko","html_url":"https://github.com/knjko","followers_url":"https://api.github.com/users/knjko/followers","following_url":"https://api.github.com/users/knjko/following{/other_user}","gists_url":"https://api.github.com/users/knjko/gists{/gist_id}","starred_url":"https://api.github.com/users/knjko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knjko/subscriptions","organizations_url":"https://api.github.com/users/knjko/orgs","repos_url":"https://api.github.com/users/knjko/repos","events_url":"https://api.github.com/users/knjko/events{/privacy}","received_events_url":"https://api.github.com/users/knjko/received_events","type":"User","site_admin":false},"body":"Is it useful for you to detect OS? 🔍 \r\n\r\n```ruby\r\nif request.from_iphone? || request.from_ipad? || request.from_ipod? # => request.from_ios?\r\n  ...\r\nend\r\n```\r\n\r\nFYI `user_agents` should return *all* user agents?","created_at":"2016-05-17T13:50:37Z","updated_at":"2016-05-17T15:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0d4d518916d7a84b1dacc86e4170b5d6f3c0145","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6/commits","review_comments_url":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6/comments","review_comment_url":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/k0kubun/rack-user_agent/issues/6/comments","statuses_url":"https://api.github.com/repos/k0kubun/rack-user_agent/statuses/56f1c003fbc4d8db20da1a7e06cdaf32d60bde07","head":{"label":"knjko:detect_os","ref":"detect_os","sha":"56f1c003fbc4d8db20da1a7e06cdaf32d60bde07","user":{"login":"knjko","id":35577,"avatar_url":"https://avatars.githubusercontent.com/u/35577?v=3","gravatar_id":"","url":"https://api.github.com/users/knjko","html_url":"https://github.com/knjko","followers_url":"https://api.github.com/users/knjko/followers","following_url":"https://api.github.com/users/knjko/following{/other_user}","gists_url":"https://api.github.com/users/knjko/gists{/gist_id}","starred_url":"https://api.github.com/users/knjko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knjko/subscriptions","organizations_url":"https://api.github.com/users/knjko/orgs","repos_url":"https://api.github.com/users/knjko/repos","events_url":"https://api.github.com/users/knjko/events{/privacy}","received_events_url":"https://api.github.com/users/knjko/received_events","type":"User","site_admin":false},"repo":{"id":58993308,"name":"rack-user_agent","full_name":"knjko/rack-user_agent","owner":{"login":"knjko","id":35577,"avatar_url":"https://avatars.githubusercontent.com/u/35577?v=3","gravatar_id":"","url":"https://api.github.com/users/knjko","html_url":"https://github.com/knjko","followers_url":"https://api.github.com/users/knjko/followers","following_url":"https://api.github.com/users/knjko/following{/other_user}","gists_url":"https://api.github.com/users/knjko/gists{/gist_id}","starred_url":"https://api.github.com/users/knjko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knjko/subscriptions","organizations_url":"https://api.github.com/users/knjko/orgs","repos_url":"https://api.github.com/users/knjko/repos","events_url":"https://api.github.com/users/knjko/events{/privacy}","received_events_url":"https://api.github.com/users/knjko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knjko/rack-user_agent","description":"Rack::Request extension for handling User-Agent","fork":true,"url":"https://api.github.com/repos/knjko/rack-user_agent","forks_url":"https://api.github.com/repos/knjko/rack-user_agent/forks","keys_url":"https://api.github.com/repos/knjko/rack-user_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knjko/rack-user_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knjko/rack-user_agent/teams","hooks_url":"https://api.github.com/repos/knjko/rack-user_agent/hooks","issue_events_url":"https://api.github.com/repos/knjko/rack-user_agent/issues/events{/number}","events_url":"https://api.github.com/repos/knjko/rack-user_agent/events","assignees_url":"https://api.github.com/repos/knjko/rack-user_agent/assignees{/user}","branches_url":"https://api.github.com/repos/knjko/rack-user_agent/branches{/branch}","tags_url":"https://api.github.com/repos/knjko/rack-user_agent/tags","blobs_url":"https://api.github.com/repos/knjko/rack-user_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knjko/rack-user_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knjko/rack-user_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/knjko/rack-user_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knjko/rack-user_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/knjko/rack-user_agent/languages","stargazers_url":"https://api.github.com/repos/knjko/rack-user_agent/stargazers","contributors_url":"https://api.github.com/repos/knjko/rack-user_agent/contributors","subscribers_url":"https://api.github.com/repos/knjko/rack-user_agent/subscribers","subscription_url":"https://api.github.com/repos/knjko/rack-user_agent/subscription","commits_url":"https://api.github.com/repos/knjko/rack-user_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/knjko/rack-user_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/knjko/rack-user_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/knjko/rack-user_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/knjko/rack-user_agent/contents/{+path}","compare_url":"https://api.github.com/repos/knjko/rack-user_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knjko/rack-user_agent/merges","archive_url":"https://api.github.com/repos/knjko/rack-user_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knjko/rack-user_agent/downloads","issues_url":"https://api.github.com/repos/knjko/rack-user_agent/issues{/number}","pulls_url":"https://api.github.com/repos/knjko/rack-user_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/knjko/rack-user_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/knjko/rack-user_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knjko/rack-user_agent/labels{/name}","releases_url":"https://api.github.com/repos/knjko/rack-user_agent/releases{/id}","deployments_url":"https://api.github.com/repos/knjko/rack-user_agent/deployments","created_at":"2016-05-17T05:35:28Z","updated_at":"2016-05-17T05:35:29Z","pushed_at":"2016-05-17T14:54:46Z","git_url":"git://github.com/knjko/rack-user_agent.git","ssh_url":"git@github.com:knjko/rack-user_agent.git","clone_url":"https://github.com/knjko/rack-user_agent.git","svn_url":"https://github.com/knjko/rack-user_agent","homepage":"","size":60,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"k0kubun:master","ref":"master","sha":"fc3fe0c535083748cd16c25bf608d7c13f593637","user":{"login":"k0kubun","id":3138447,"avatar_url":"https://avatars.githubusercontent.com/u/3138447?v=3","gravatar_id":"","url":"https://api.github.com/users/k0kubun","html_url":"https://github.com/k0kubun","followers_url":"https://api.github.com/users/k0kubun/followers","following_url":"https://api.github.com/users/k0kubun/following{/other_user}","gists_url":"https://api.github.com/users/k0kubun/gists{/gist_id}","starred_url":"https://api.github.com/users/k0kubun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k0kubun/subscriptions","organizations_url":"https://api.github.com/users/k0kubun/orgs","repos_url":"https://api.github.com/users/k0kubun/repos","events_url":"https://api.github.com/users/k0kubun/events{/privacy}","received_events_url":"https://api.github.com/users/k0kubun/received_events","type":"User","site_admin":false},"repo":{"id":26926052,"name":"rack-user_agent","full_name":"k0kubun/rack-user_agent","owner":{"login":"k0kubun","id":3138447,"avatar_url":"https://avatars.githubusercontent.com/u/3138447?v=3","gravatar_id":"","url":"https://api.github.com/users/k0kubun","html_url":"https://github.com/k0kubun","followers_url":"https://api.github.com/users/k0kubun/followers","following_url":"https://api.github.com/users/k0kubun/following{/other_user}","gists_url":"https://api.github.com/users/k0kubun/gists{/gist_id}","starred_url":"https://api.github.com/users/k0kubun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k0kubun/subscriptions","organizations_url":"https://api.github.com/users/k0kubun/orgs","repos_url":"https://api.github.com/users/k0kubun/repos","events_url":"https://api.github.com/users/k0kubun/events{/privacy}","received_events_url":"https://api.github.com/users/k0kubun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k0kubun/rack-user_agent","description":"Rack::Request extension for handling User-Agent","fork":false,"url":"https://api.github.com/repos/k0kubun/rack-user_agent","forks_url":"https://api.github.com/repos/k0kubun/rack-user_agent/forks","keys_url":"https://api.github.com/repos/k0kubun/rack-user_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k0kubun/rack-user_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k0kubun/rack-user_agent/teams","hooks_url":"https://api.github.com/repos/k0kubun/rack-user_agent/hooks","issue_events_url":"https://api.github.com/repos/k0kubun/rack-user_agent/issues/events{/number}","events_url":"https://api.github.com/repos/k0kubun/rack-user_agent/events","assignees_url":"https://api.github.com/repos/k0kubun/rack-user_agent/assignees{/user}","branches_url":"https://api.github.com/repos/k0kubun/rack-user_agent/branches{/branch}","tags_url":"https://api.github.com/repos/k0kubun/rack-user_agent/tags","blobs_url":"https://api.github.com/repos/k0kubun/rack-user_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k0kubun/rack-user_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k0kubun/rack-user_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/k0kubun/rack-user_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k0kubun/rack-user_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/k0kubun/rack-user_agent/languages","stargazers_url":"https://api.github.com/repos/k0kubun/rack-user_agent/stargazers","contributors_url":"https://api.github.com/repos/k0kubun/rack-user_agent/contributors","subscribers_url":"https://api.github.com/repos/k0kubun/rack-user_agent/subscribers","subscription_url":"https://api.github.com/repos/k0kubun/rack-user_agent/subscription","commits_url":"https://api.github.com/repos/k0kubun/rack-user_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/k0kubun/rack-user_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/k0kubun/rack-user_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/k0kubun/rack-user_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/k0kubun/rack-user_agent/contents/{+path}","compare_url":"https://api.github.com/repos/k0kubun/rack-user_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k0kubun/rack-user_agent/merges","archive_url":"https://api.github.com/repos/k0kubun/rack-user_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k0kubun/rack-user_agent/downloads","issues_url":"https://api.github.com/repos/k0kubun/rack-user_agent/issues{/number}","pulls_url":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/k0kubun/rack-user_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/k0kubun/rack-user_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k0kubun/rack-user_agent/labels{/name}","releases_url":"https://api.github.com/repos/k0kubun/rack-user_agent/releases{/id}","deployments_url":"https://api.github.com/repos/k0kubun/rack-user_agent/deployments","created_at":"2014-11-20T18:33:33Z","updated_at":"2016-05-16T04:49:04Z","pushed_at":"2016-05-17T14:54:47Z","git_url":"git://github.com/k0kubun/rack-user_agent.git","ssh_url":"git@github.com:k0kubun/rack-user_agent.git","clone_url":"https://github.com/k0kubun/rack-user_agent.git","svn_url":"https://github.com/k0kubun/rack-user_agent","homepage":"","size":59,"stargazers_count":79,"watchers_count":79,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6"},"html":{"href":"https://github.com/k0kubun/rack-user_agent/pull/6"},"issue":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/issues/6"},"comments":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/k0kubun/rack-user_agent/statuses/56f1c003fbc4d8db20da1a7e06cdaf32d60bde07"}}}}