{"action":"created","comment":{"url":"https://api.github.com/repos/briannesbitt/Carbon/pulls/comments/54819434","id":54819434,"diff_hunk":"@@ -240,17 +242,19 @@ public function __construct($time = null, $tz = null)\n     /**\n      * Create a Carbon instance from a DateTime one.\n      *\n-     * @param \\DateTime $dt\n+     * @param \\DateTime|\\DateTimeImmutable|\\DateTimeInterface $dt\n      *\n      * @return static\n      */\n-    public static function instance(DateTime $dt)\n+    public static function instance($dt)","path":"src/Carbon/Carbon.php","position":19,"original_position":19,"commit_id":"8a9b5316d38e85c0e7ef02e4b8b4eba52372c2f3","original_commit_id":"bc60f8cb74c7e81c311dbd046a183c4cd3f8966f","user":{"login":"nicholas-eden","id":2496835,"avatar_url":"https://avatars.githubusercontent.com/u/2496835?v=3","gravatar_id":"","url":"https://api.github.com/users/nicholas-eden","html_url":"https://github.com/nicholas-eden","followers_url":"https://api.github.com/users/nicholas-eden/followers","following_url":"https://api.github.com/users/nicholas-eden/following{/other_user}","gists_url":"https://api.github.com/users/nicholas-eden/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholas-eden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholas-eden/subscriptions","organizations_url":"https://api.github.com/users/nicholas-eden/orgs","repos_url":"https://api.github.com/users/nicholas-eden/repos","events_url":"https://api.github.com/users/nicholas-eden/events{/privacy}","received_events_url":"https://api.github.com/users/nicholas-eden/received_events","type":"User","site_admin":false},"body":"Shouldn't this be typehinting DateTimeInterface?","created_at":"2016-03-03T00:43:58Z","updated_at":"2016-03-03T00:43:58Z","html_url":"https://github.com/briannesbitt/Carbon/pull/594#discussion_r54819434","pull_request_url":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594","_links":{"self":{"href":"https://api.github.com/repos/briannesbitt/Carbon/pulls/comments/54819434"},"html":{"href":"https://github.com/briannesbitt/Carbon/pull/594#discussion_r54819434"},"pull_request":{"href":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594"}}},"pull_request":{"url":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594","id":57530512,"html_url":"https://github.com/briannesbitt/Carbon/pull/594","diff_url":"https://github.com/briannesbitt/Carbon/pull/594.diff","patch_url":"https://github.com/briannesbitt/Carbon/pull/594.patch","issue_url":"https://api.github.com/repos/briannesbitt/Carbon/issues/594","number":594,"state":"open","locked":false,"title":"[2.0] Allows instantiation from DateTimeImmutable and DateTimeInterface","user":{"login":"lucasmichot","id":513603,"avatar_url":"https://avatars.githubusercontent.com/u/513603?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmichot","html_url":"https://github.com/lucasmichot","followers_url":"https://api.github.com/users/lucasmichot/followers","following_url":"https://api.github.com/users/lucasmichot/following{/other_user}","gists_url":"https://api.github.com/users/lucasmichot/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmichot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmichot/subscriptions","organizations_url":"https://api.github.com/users/lucasmichot/orgs","repos_url":"https://api.github.com/users/lucasmichot/repos","events_url":"https://api.github.com/users/lucasmichot/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmichot/received_events","type":"User","site_admin":false},"body":"Allows instantiation from DateTimeImmutable and DateTimeInterface\r\n\r\n---\r\n\r\n\r\n**This PR is BC. It should be safe to merge it for version `2` only**\r\n/cc @briannesbitt \r\n\r\n---\r\n\r\nreplace #233 and #593 ","created_at":"2016-01-28T16:52:19Z","updated_at":"2016-03-03T00:43:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02bbd9bf0f6c0e185e13e18bb0395f7ef7272c4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594/commits","review_comments_url":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594/comments","review_comment_url":"https://api.github.com/repos/briannesbitt/Carbon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/briannesbitt/Carbon/issues/594/comments","statuses_url":"https://api.github.com/repos/briannesbitt/Carbon/statuses/8a9b5316d38e85c0e7ef02e4b8b4eba52372c2f3","head":{"label":"lucasmichot:feature/master/immutable-and-interface","ref":"feature/master/immutable-and-interface","sha":"8a9b5316d38e85c0e7ef02e4b8b4eba52372c2f3","user":{"login":"lucasmichot","id":513603,"avatar_url":"https://avatars.githubusercontent.com/u/513603?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmichot","html_url":"https://github.com/lucasmichot","followers_url":"https://api.github.com/users/lucasmichot/followers","following_url":"https://api.github.com/users/lucasmichot/following{/other_user}","gists_url":"https://api.github.com/users/lucasmichot/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmichot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmichot/subscriptions","organizations_url":"https://api.github.com/users/lucasmichot/orgs","repos_url":"https://api.github.com/users/lucasmichot/repos","events_url":"https://api.github.com/users/lucasmichot/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmichot/received_events","type":"User","site_admin":false},"repo":{"id":13926883,"name":"Carbon","full_name":"lucasmichot/Carbon","owner":{"login":"lucasmichot","id":513603,"avatar_url":"https://avatars.githubusercontent.com/u/513603?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmichot","html_url":"https://github.com/lucasmichot","followers_url":"https://api.github.com/users/lucasmichot/followers","following_url":"https://api.github.com/users/lucasmichot/following{/other_user}","gists_url":"https://api.github.com/users/lucasmichot/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmichot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmichot/subscriptions","organizations_url":"https://api.github.com/users/lucasmichot/orgs","repos_url":"https://api.github.com/users/lucasmichot/repos","events_url":"https://api.github.com/users/lucasmichot/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmichot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasmichot/Carbon","description":"A simple API extension for DateTime with PHP 5.3+","fork":true,"url":"https://api.github.com/repos/lucasmichot/Carbon","forks_url":"https://api.github.com/repos/lucasmichot/Carbon/forks","keys_url":"https://api.github.com/repos/lucasmichot/Carbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasmichot/Carbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasmichot/Carbon/teams","hooks_url":"https://api.github.com/repos/lucasmichot/Carbon/hooks","issue_events_url":"https://api.github.com/repos/lucasmichot/Carbon/issues/events{/number}","events_url":"https://api.github.com/repos/lucasmichot/Carbon/events","assignees_url":"https://api.github.com/repos/lucasmichot/Carbon/assignees{/user}","branches_url":"https://api.github.com/repos/lucasmichot/Carbon/branches{/branch}","tags_url":"https://api.github.com/repos/lucasmichot/Carbon/tags","blobs_url":"https://api.github.com/repos/lucasmichot/Carbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasmichot/Carbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasmichot/Carbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasmichot/Carbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasmichot/Carbon/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasmichot/Carbon/languages","stargazers_url":"https://api.github.com/repos/lucasmichot/Carbon/stargazers","contributors_url":"https://api.github.com/repos/lucasmichot/Carbon/contributors","subscribers_url":"https://api.github.com/repos/lucasmichot/Carbon/subscribers","subscription_url":"https://api.github.com/repos/lucasmichot/Carbon/subscription","commits_url":"https://api.github.com/repos/lucasmichot/Carbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasmichot/Carbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasmichot/Carbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasmichot/Carbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasmichot/Carbon/contents/{+path}","compare_url":"https://api.github.com/repos/lucasmichot/Carbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasmichot/Carbon/merges","archive_url":"https://api.github.com/repos/lucasmichot/Carbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasmichot/Carbon/downloads","issues_url":"https://api.github.com/repos/lucasmichot/Carbon/issues{/number}","pulls_url":"https://api.github.com/repos/lucasmichot/Carbon/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasmichot/Carbon/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasmichot/Carbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasmichot/Carbon/labels{/name}","releases_url":"https://api.github.com/repos/lucasmichot/Carbon/releases{/id}","deployments_url":"https://api.github.com/repos/lucasmichot/Carbon/deployments","created_at":"2013-10-28T13:40:01Z","updated_at":"2015-02-18T15:39:29Z","pushed_at":"2016-02-27T14:40:05Z","git_url":"git://github.com/lucasmichot/Carbon.git","ssh_url":"git@github.com:lucasmichot/Carbon.git","clone_url":"https://github.com/lucasmichot/Carbon.git","svn_url":"https://github.com/lucasmichot/Carbon","homepage":null,"size":1103,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"briannesbitt:master","ref":"master","sha":"ecc98cd7efcfc15058b20a5d49caa1e8ae5ab8a3","user":{"login":"briannesbitt","id":170745,"avatar_url":"https://avatars.githubusercontent.com/u/170745?v=3","gravatar_id":"","url":"https://api.github.com/users/briannesbitt","html_url":"https://github.com/briannesbitt","followers_url":"https://api.github.com/users/briannesbitt/followers","following_url":"https://api.github.com/users/briannesbitt/following{/other_user}","gists_url":"https://api.github.com/users/briannesbitt/gists{/gist_id}","starred_url":"https://api.github.com/users/briannesbitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briannesbitt/subscriptions","organizations_url":"https://api.github.com/users/briannesbitt/orgs","repos_url":"https://api.github.com/users/briannesbitt/repos","events_url":"https://api.github.com/users/briannesbitt/events{/privacy}","received_events_url":"https://api.github.com/users/briannesbitt/received_events","type":"User","site_admin":false},"repo":{"id":5724990,"name":"Carbon","full_name":"briannesbitt/Carbon","owner":{"login":"briannesbitt","id":170745,"avatar_url":"https://avatars.githubusercontent.com/u/170745?v=3","gravatar_id":"","url":"https://api.github.com/users/briannesbitt","html_url":"https://github.com/briannesbitt","followers_url":"https://api.github.com/users/briannesbitt/followers","following_url":"https://api.github.com/users/briannesbitt/following{/other_user}","gists_url":"https://api.github.com/users/briannesbitt/gists{/gist_id}","starred_url":"https://api.github.com/users/briannesbitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briannesbitt/subscriptions","organizations_url":"https://api.github.com/users/briannesbitt/orgs","repos_url":"https://api.github.com/users/briannesbitt/repos","events_url":"https://api.github.com/users/briannesbitt/events{/privacy}","received_events_url":"https://api.github.com/users/briannesbitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briannesbitt/Carbon","description":"A simple PHP API extension for DateTime.","fork":false,"url":"https://api.github.com/repos/briannesbitt/Carbon","forks_url":"https://api.github.com/repos/briannesbitt/Carbon/forks","keys_url":"https://api.github.com/repos/briannesbitt/Carbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briannesbitt/Carbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briannesbitt/Carbon/teams","hooks_url":"https://api.github.com/repos/briannesbitt/Carbon/hooks","issue_events_url":"https://api.github.com/repos/briannesbitt/Carbon/issues/events{/number}","events_url":"https://api.github.com/repos/briannesbitt/Carbon/events","assignees_url":"https://api.github.com/repos/briannesbitt/Carbon/assignees{/user}","branches_url":"https://api.github.com/repos/briannesbitt/Carbon/branches{/branch}","tags_url":"https://api.github.com/repos/briannesbitt/Carbon/tags","blobs_url":"https://api.github.com/repos/briannesbitt/Carbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briannesbitt/Carbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briannesbitt/Carbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/briannesbitt/Carbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briannesbitt/Carbon/statuses/{sha}","languages_url":"https://api.github.com/repos/briannesbitt/Carbon/languages","stargazers_url":"https://api.github.com/repos/briannesbitt/Carbon/stargazers","contributors_url":"https://api.github.com/repos/briannesbitt/Carbon/contributors","subscribers_url":"https://api.github.com/repos/briannesbitt/Carbon/subscribers","subscription_url":"https://api.github.com/repos/briannesbitt/Carbon/subscription","commits_url":"https://api.github.com/repos/briannesbitt/Carbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/briannesbitt/Carbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/briannesbitt/Carbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/briannesbitt/Carbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/briannesbitt/Carbon/contents/{+path}","compare_url":"https://api.github.com/repos/briannesbitt/Carbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briannesbitt/Carbon/merges","archive_url":"https://api.github.com/repos/briannesbitt/Carbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briannesbitt/Carbon/downloads","issues_url":"https://api.github.com/repos/briannesbitt/Carbon/issues{/number}","pulls_url":"https://api.github.com/repos/briannesbitt/Carbon/pulls{/number}","milestones_url":"https://api.github.com/repos/briannesbitt/Carbon/milestones{/number}","notifications_url":"https://api.github.com/repos/briannesbitt/Carbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briannesbitt/Carbon/labels{/name}","releases_url":"https://api.github.com/repos/briannesbitt/Carbon/releases{/id}","deployments_url":"https://api.github.com/repos/briannesbitt/Carbon/deployments","created_at":"2012-09-08T02:56:20Z","updated_at":"2016-03-02T23:37:43Z","pushed_at":"2016-03-02T05:36:28Z","git_url":"git://github.com/briannesbitt/Carbon.git","ssh_url":"git@github.com:briannesbitt/Carbon.git","clone_url":"https://github.com/briannesbitt/Carbon.git","svn_url":"https://github.com/briannesbitt/Carbon","homepage":"http://carbon.nesbot.com/","size":1765,"stargazers_count":4060,"watchers_count":4060,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":464,"mirror_url":null,"open_issues_count":101,"forks":464,"open_issues":101,"watchers":4060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594"},"html":{"href":"https://github.com/briannesbitt/Carbon/pull/594"},"issue":{"href":"https://api.github.com/repos/briannesbitt/Carbon/issues/594"},"comments":{"href":"https://api.github.com/repos/briannesbitt/Carbon/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/briannesbitt/Carbon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/briannesbitt/Carbon/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/briannesbitt/Carbon/statuses/8a9b5316d38e85c0e7ef02e4b8b4eba52372c2f3"}}}}