{"action":"created","comment":{"url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/comments/86197070","pull_request_review_id":6866982,"id":86197070,"diff_hunk":"@@ -154,21 +150,23 @@ public void flush(Map<TopicPartition, OffsetAndMetadata> offsets) throws Connect\n \t}\n \n \tprivate String name() {\n-\t\treturn config.get(\"name\");\n+\t\treturn configGet(\"name\").orElseThrow(() -> new IllegalWorkerStateException(\"Tasks always have names\"));\n \t}\n \n \tpublic void finishWriter(BlockGZIPFileWriter writer, TopicPartition tp) throws IOException {\n-\t\twriters.get(tp).finish(tp.topic(), tp.partition());\n+\t\twriterGet(tp).ifPresent(w -> w.finish(tp.topic(), tp.partition()));\n \t\twriters.remove(tp);","path":"sink/src/main/java/com/spredfast/kafka/connect/s3/sink/S3SinkTask.java","position":83,"original_position":83,"commit_id":"ff7e8b9d5ff140496e490e87020a64f319b9d850","original_commit_id":"ff7e8b9d5ff140496e490e87020a64f319b9d850","user":{"login":"iamnoah","id":139201,"avatar_url":"https://avatars.githubusercontent.com/u/139201?v=3","gravatar_id":"","url":"https://api.github.com/users/iamnoah","html_url":"https://github.com/iamnoah","followers_url":"https://api.github.com/users/iamnoah/followers","following_url":"https://api.github.com/users/iamnoah/following{/other_user}","gists_url":"https://api.github.com/users/iamnoah/gists{/gist_id}","starred_url":"https://api.github.com/users/iamnoah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamnoah/subscriptions","organizations_url":"https://api.github.com/users/iamnoah/orgs","repos_url":"https://api.github.com/users/iamnoah/repos","events_url":"https://api.github.com/users/iamnoah/events{/privacy}","received_events_url":"https://api.github.com/users/iamnoah/received_events","type":"User","site_admin":false},"body":"Nope, just a Map.","created_at":"2016-11-02T17:25:26Z","updated_at":"2016-11-02T17:25:26Z","html_url":"https://github.com/spredfast/kafka-connect-s3/pull/14#discussion_r86197070","pull_request_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/comments/86197070"},"html":{"href":"https://github.com/spredfast/kafka-connect-s3/pull/14#discussion_r86197070"},"pull_request":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14","id":92013886,"html_url":"https://github.com/spredfast/kafka-connect-s3/pull/14","diff_url":"https://github.com/spredfast/kafka-connect-s3/pull/14.diff","patch_url":"https://github.com/spredfast/kafka-connect-s3/pull/14.patch","issue_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/14","number":14,"state":"open","locked":false,"title":"handle task config NPEs","user":{"login":"iamnoah","id":139201,"avatar_url":"https://avatars.githubusercontent.com/u/139201?v=3","gravatar_id":"","url":"https://api.github.com/users/iamnoah","html_url":"https://github.com/iamnoah","followers_url":"https://api.github.com/users/iamnoah/followers","following_url":"https://api.github.com/users/iamnoah/following{/other_user}","gists_url":"https://api.github.com/users/iamnoah/gists{/gist_id}","starred_url":"https://api.github.com/users/iamnoah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamnoah/subscriptions","organizations_url":"https://api.github.com/users/iamnoah/orgs","repos_url":"https://api.github.com/users/iamnoah/repos","events_url":"https://api.github.com/users/iamnoah/events{/privacy}","received_events_url":"https://api.github.com/users/iamnoah/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-02T17:08:54Z","updated_at":"2016-11-02T17:25:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"178fedbe316e640f5e5f3d9c867c37bcd2c2507e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14/commits","review_comments_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14/comments","review_comment_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/14/comments","statuses_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/statuses/ff7e8b9d5ff140496e490e87020a64f319b9d850","head":{"label":"spredfast:npes","ref":"npes","sha":"ff7e8b9d5ff140496e490e87020a64f319b9d850","user":{"login":"spredfast","id":521232,"avatar_url":"https://avatars.githubusercontent.com/u/521232?v=3","gravatar_id":"","url":"https://api.github.com/users/spredfast","html_url":"https://github.com/spredfast","followers_url":"https://api.github.com/users/spredfast/followers","following_url":"https://api.github.com/users/spredfast/following{/other_user}","gists_url":"https://api.github.com/users/spredfast/gists{/gist_id}","starred_url":"https://api.github.com/users/spredfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spredfast/subscriptions","organizations_url":"https://api.github.com/users/spredfast/orgs","repos_url":"https://api.github.com/users/spredfast/repos","events_url":"https://api.github.com/users/spredfast/events{/privacy}","received_events_url":"https://api.github.com/users/spredfast/received_events","type":"Organization","site_admin":false},"repo":{"id":60866095,"name":"kafka-connect-s3","full_name":"spredfast/kafka-connect-s3","owner":{"login":"spredfast","id":521232,"avatar_url":"https://avatars.githubusercontent.com/u/521232?v=3","gravatar_id":"","url":"https://api.github.com/users/spredfast","html_url":"https://github.com/spredfast","followers_url":"https://api.github.com/users/spredfast/followers","following_url":"https://api.github.com/users/spredfast/following{/other_user}","gists_url":"https://api.github.com/users/spredfast/gists{/gist_id}","starred_url":"https://api.github.com/users/spredfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spredfast/subscriptions","organizations_url":"https://api.github.com/users/spredfast/orgs","repos_url":"https://api.github.com/users/spredfast/repos","events_url":"https://api.github.com/users/spredfast/events{/privacy}","received_events_url":"https://api.github.com/users/spredfast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spredfast/kafka-connect-s3","description":"A Kafka-Connect Sink for S3 with no Hadoop dependencies.","fork":false,"url":"https://api.github.com/repos/spredfast/kafka-connect-s3","forks_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/forks","keys_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/teams","hooks_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/hooks","issue_events_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/events{/number}","events_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/events","assignees_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/assignees{/user}","branches_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/branches{/branch}","tags_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/tags","blobs_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/refs{/sha}","trees_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/statuses/{sha}","languages_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/languages","stargazers_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/stargazers","contributors_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/contributors","subscribers_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/subscribers","subscription_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/subscription","commits_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/commits{/sha}","git_commits_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/commits{/sha}","comments_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/comments{/number}","issue_comment_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/comments{/number}","contents_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/contents/{+path}","compare_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/merges","archive_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/downloads","issues_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues{/number}","pulls_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls{/number}","milestones_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/milestones{/number}","notifications_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/labels{/name}","releases_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/releases{/id}","deployments_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/deployments","created_at":"2016-06-10T17:41:25Z","updated_at":"2016-10-26T20:32:54Z","pushed_at":"2016-11-02T17:08:55Z","git_url":"git://github.com/spredfast/kafka-connect-s3.git","ssh_url":"git@github.com:spredfast/kafka-connect-s3.git","clone_url":"https://github.com/spredfast/kafka-connect-s3.git","svn_url":"https://github.com/spredfast/kafka-connect-s3","homepage":null,"size":231,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"spredfast:master","ref":"master","sha":"322345bdb755a0d73a154cdb63610ea310414266","user":{"login":"spredfast","id":521232,"avatar_url":"https://avatars.githubusercontent.com/u/521232?v=3","gravatar_id":"","url":"https://api.github.com/users/spredfast","html_url":"https://github.com/spredfast","followers_url":"https://api.github.com/users/spredfast/followers","following_url":"https://api.github.com/users/spredfast/following{/other_user}","gists_url":"https://api.github.com/users/spredfast/gists{/gist_id}","starred_url":"https://api.github.com/users/spredfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spredfast/subscriptions","organizations_url":"https://api.github.com/users/spredfast/orgs","repos_url":"https://api.github.com/users/spredfast/repos","events_url":"https://api.github.com/users/spredfast/events{/privacy}","received_events_url":"https://api.github.com/users/spredfast/received_events","type":"Organization","site_admin":false},"repo":{"id":60866095,"name":"kafka-connect-s3","full_name":"spredfast/kafka-connect-s3","owner":{"login":"spredfast","id":521232,"avatar_url":"https://avatars.githubusercontent.com/u/521232?v=3","gravatar_id":"","url":"https://api.github.com/users/spredfast","html_url":"https://github.com/spredfast","followers_url":"https://api.github.com/users/spredfast/followers","following_url":"https://api.github.com/users/spredfast/following{/other_user}","gists_url":"https://api.github.com/users/spredfast/gists{/gist_id}","starred_url":"https://api.github.com/users/spredfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spredfast/subscriptions","organizations_url":"https://api.github.com/users/spredfast/orgs","repos_url":"https://api.github.com/users/spredfast/repos","events_url":"https://api.github.com/users/spredfast/events{/privacy}","received_events_url":"https://api.github.com/users/spredfast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spredfast/kafka-connect-s3","description":"A Kafka-Connect Sink for S3 with no Hadoop dependencies.","fork":false,"url":"https://api.github.com/repos/spredfast/kafka-connect-s3","forks_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/forks","keys_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/teams","hooks_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/hooks","issue_events_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/events{/number}","events_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/events","assignees_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/assignees{/user}","branches_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/branches{/branch}","tags_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/tags","blobs_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/refs{/sha}","trees_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/statuses/{sha}","languages_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/languages","stargazers_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/stargazers","contributors_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/contributors","subscribers_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/subscribers","subscription_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/subscription","commits_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/commits{/sha}","git_commits_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/git/commits{/sha}","comments_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/comments{/number}","issue_comment_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/comments{/number}","contents_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/contents/{+path}","compare_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/merges","archive_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/downloads","issues_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues{/number}","pulls_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls{/number}","milestones_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/milestones{/number}","notifications_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/labels{/name}","releases_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/releases{/id}","deployments_url":"https://api.github.com/repos/spredfast/kafka-connect-s3/deployments","created_at":"2016-06-10T17:41:25Z","updated_at":"2016-10-26T20:32:54Z","pushed_at":"2016-11-02T17:08:55Z","git_url":"git://github.com/spredfast/kafka-connect-s3.git","ssh_url":"git@github.com:spredfast/kafka-connect-s3.git","clone_url":"https://github.com/spredfast/kafka-connect-s3.git","svn_url":"https://github.com/spredfast/kafka-connect-s3","homepage":null,"size":231,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14"},"html":{"href":"https://github.com/spredfast/kafka-connect-s3/pull/14"},"issue":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/14"},"comments":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/spredfast/kafka-connect-s3/statuses/ff7e8b9d5ff140496e490e87020a64f319b9d850"}}}}
{"actor":{"display_login":"iamnoah"}}