{"action":"created","comment":{"url":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/comments/77779183","id":77779183,"diff_hunk":"@@ -160,14 +160,14 @@ class DictionaryCompiler\n       value_store_->CloseFeeding();\n       sorter_.end();\n       sorter_.merge_runs();\n+      CreateGenerator();\n \n       // check that at least 1 item is there\n       if (!sorter_.can_pull()) {","path":"keyvi/src/cpp/dictionary/dictionary_compiler.h","position":7,"original_position":7,"commit_id":"aa47e0e2a402ddd61e28d68ebe895c03d005cb89","original_commit_id":"aa47e0e2a402ddd61e28d68ebe895c03d005cb89","user":{"login":"narek-cliqz","id":18262927,"avatar_url":"https://avatars.githubusercontent.com/u/18262927?v=3","gravatar_id":"","url":"https://api.github.com/users/narek-cliqz","html_url":"https://github.com/narek-cliqz","followers_url":"https://api.github.com/users/narek-cliqz/followers","following_url":"https://api.github.com/users/narek-cliqz/following{/other_user}","gists_url":"https://api.github.com/users/narek-cliqz/gists{/gist_id}","starred_url":"https://api.github.com/users/narek-cliqz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narek-cliqz/subscriptions","organizations_url":"https://api.github.com/users/narek-cliqz/orgs","repos_url":"https://api.github.com/users/narek-cliqz/repos","events_url":"https://api.github.com/users/narek-cliqz/events{/privacy}","received_events_url":"https://api.github.com/users/narek-cliqz/received_events","type":"User","site_admin":false},"body":"What about if we remove this check and add `if ( sorter_.can_pull())` on line: 170 ? ","created_at":"2016-09-07T08:26:54Z","updated_at":"2016-09-07T08:26:54Z","html_url":"https://github.com/cliqz-oss/keyvi/pull/120#discussion_r77779183","pull_request_url":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/comments/77779183"},"html":{"href":"https://github.com/cliqz-oss/keyvi/pull/120#discussion_r77779183"},"pull_request":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120","id":84183606,"html_url":"https://github.com/cliqz-oss/keyvi/pull/120","diff_url":"https://github.com/cliqz-oss/keyvi/pull/120.diff","patch_url":"https://github.com/cliqz-oss/keyvi/pull/120.patch","issue_url":"https://api.github.com/repos/cliqz-oss/keyvi/issues/120","number":120,"state":"open","locked":false,"title":"fix regression, empty dict","user":{"login":"hendrik-cliqz","id":7126422,"avatar_url":"https://avatars.githubusercontent.com/u/7126422?v=3","gravatar_id":"","url":"https://api.github.com/users/hendrik-cliqz","html_url":"https://github.com/hendrik-cliqz","followers_url":"https://api.github.com/users/hendrik-cliqz/followers","following_url":"https://api.github.com/users/hendrik-cliqz/following{/other_user}","gists_url":"https://api.github.com/users/hendrik-cliqz/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrik-cliqz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrik-cliqz/subscriptions","organizations_url":"https://api.github.com/users/hendrik-cliqz/orgs","repos_url":"https://api.github.com/users/hendrik-cliqz/repos","events_url":"https://api.github.com/users/hendrik-cliqz/events{/privacy}","received_events_url":"https://api.github.com/users/hendrik-cliqz/received_events","type":"User","site_admin":false},"body":"This fixes a regression, creation of an empty dict segfaults. Also added missing test code for this.\r\n\r\n@narek-cliqz \r\n","created_at":"2016-09-06T19:43:00Z","updated_at":"2016-09-07T08:26:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d2315dabc0a6085e65880c1f485097ad811e42c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120/commits","review_comments_url":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120/comments","review_comment_url":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cliqz-oss/keyvi/issues/120/comments","statuses_url":"https://api.github.com/repos/cliqz-oss/keyvi/statuses/aa47e0e2a402ddd61e28d68ebe895c03d005cb89","head":{"label":"hendrik-cliqz:fix-empty-dict","ref":"fix-empty-dict","sha":"aa47e0e2a402ddd61e28d68ebe895c03d005cb89","user":{"login":"hendrik-cliqz","id":7126422,"avatar_url":"https://avatars.githubusercontent.com/u/7126422?v=3","gravatar_id":"","url":"https://api.github.com/users/hendrik-cliqz","html_url":"https://github.com/hendrik-cliqz","followers_url":"https://api.github.com/users/hendrik-cliqz/followers","following_url":"https://api.github.com/users/hendrik-cliqz/following{/other_user}","gists_url":"https://api.github.com/users/hendrik-cliqz/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrik-cliqz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrik-cliqz/subscriptions","organizations_url":"https://api.github.com/users/hendrik-cliqz/orgs","repos_url":"https://api.github.com/users/hendrik-cliqz/repos","events_url":"https://api.github.com/users/hendrik-cliqz/events{/privacy}","received_events_url":"https://api.github.com/users/hendrik-cliqz/received_events","type":"User","site_admin":false},"repo":{"id":39909003,"name":"keyvi","full_name":"hendrik-cliqz/keyvi","owner":{"login":"hendrik-cliqz","id":7126422,"avatar_url":"https://avatars.githubusercontent.com/u/7126422?v=3","gravatar_id":"","url":"https://api.github.com/users/hendrik-cliqz","html_url":"https://github.com/hendrik-cliqz","followers_url":"https://api.github.com/users/hendrik-cliqz/followers","following_url":"https://api.github.com/users/hendrik-cliqz/following{/other_user}","gists_url":"https://api.github.com/users/hendrik-cliqz/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrik-cliqz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrik-cliqz/subscriptions","organizations_url":"https://api.github.com/users/hendrik-cliqz/orgs","repos_url":"https://api.github.com/users/hendrik-cliqz/repos","events_url":"https://api.github.com/users/hendrik-cliqz/events{/privacy}","received_events_url":"https://api.github.com/users/hendrik-cliqz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hendrik-cliqz/keyvi","description":"keyvi is a key value index, an in-memory FST-based data structure, optimized for size and lookup performance.","fork":true,"url":"https://api.github.com/repos/hendrik-cliqz/keyvi","forks_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/forks","keys_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/teams","hooks_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/hooks","issue_events_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/issues/events{/number}","events_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/events","assignees_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/assignees{/user}","branches_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/branches{/branch}","tags_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/tags","blobs_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/git/refs{/sha}","trees_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/statuses/{sha}","languages_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/languages","stargazers_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/stargazers","contributors_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/contributors","subscribers_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/subscribers","subscription_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/subscription","commits_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/commits{/sha}","git_commits_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/git/commits{/sha}","comments_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/comments{/number}","issue_comment_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/issues/comments{/number}","contents_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/contents/{+path}","compare_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/merges","archive_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/downloads","issues_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/issues{/number}","pulls_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/pulls{/number}","milestones_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/milestones{/number}","notifications_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/labels{/name}","releases_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/releases{/id}","deployments_url":"https://api.github.com/repos/hendrik-cliqz/keyvi/deployments","created_at":"2015-07-29T18:17:25Z","updated_at":"2016-02-27T20:22:27Z","pushed_at":"2016-09-07T07:39:53Z","git_url":"git://github.com/hendrik-cliqz/keyvi.git","ssh_url":"git@github.com:hendrik-cliqz/keyvi.git","clone_url":"https://github.com/hendrik-cliqz/keyvi.git","svn_url":"https://github.com/hendrik-cliqz/keyvi","homepage":null,"size":9860,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cliqz-oss:master","ref":"master","sha":"e9d2b902baa08061f206a914da8e5e89a95b2a77","user":{"login":"cliqz-oss","id":14331294,"avatar_url":"https://avatars.githubusercontent.com/u/14331294?v=3","gravatar_id":"","url":"https://api.github.com/users/cliqz-oss","html_url":"https://github.com/cliqz-oss","followers_url":"https://api.github.com/users/cliqz-oss/followers","following_url":"https://api.github.com/users/cliqz-oss/following{/other_user}","gists_url":"https://api.github.com/users/cliqz-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/cliqz-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliqz-oss/subscriptions","organizations_url":"https://api.github.com/users/cliqz-oss/orgs","repos_url":"https://api.github.com/users/cliqz-oss/repos","events_url":"https://api.github.com/users/cliqz-oss/events{/privacy}","received_events_url":"https://api.github.com/users/cliqz-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":39101094,"name":"keyvi","full_name":"cliqz-oss/keyvi","owner":{"login":"cliqz-oss","id":14331294,"avatar_url":"https://avatars.githubusercontent.com/u/14331294?v=3","gravatar_id":"","url":"https://api.github.com/users/cliqz-oss","html_url":"https://github.com/cliqz-oss","followers_url":"https://api.github.com/users/cliqz-oss/followers","following_url":"https://api.github.com/users/cliqz-oss/following{/other_user}","gists_url":"https://api.github.com/users/cliqz-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/cliqz-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliqz-oss/subscriptions","organizations_url":"https://api.github.com/users/cliqz-oss/orgs","repos_url":"https://api.github.com/users/cliqz-oss/repos","events_url":"https://api.github.com/users/cliqz-oss/events{/privacy}","received_events_url":"https://api.github.com/users/cliqz-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cliqz-oss/keyvi","description":"keyvi is a key value index, an in-memory FST-based data structure, optimized for size and lookup performance.","fork":false,"url":"https://api.github.com/repos/cliqz-oss/keyvi","forks_url":"https://api.github.com/repos/cliqz-oss/keyvi/forks","keys_url":"https://api.github.com/repos/cliqz-oss/keyvi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cliqz-oss/keyvi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cliqz-oss/keyvi/teams","hooks_url":"https://api.github.com/repos/cliqz-oss/keyvi/hooks","issue_events_url":"https://api.github.com/repos/cliqz-oss/keyvi/issues/events{/number}","events_url":"https://api.github.com/repos/cliqz-oss/keyvi/events","assignees_url":"https://api.github.com/repos/cliqz-oss/keyvi/assignees{/user}","branches_url":"https://api.github.com/repos/cliqz-oss/keyvi/branches{/branch}","tags_url":"https://api.github.com/repos/cliqz-oss/keyvi/tags","blobs_url":"https://api.github.com/repos/cliqz-oss/keyvi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cliqz-oss/keyvi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cliqz-oss/keyvi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cliqz-oss/keyvi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cliqz-oss/keyvi/statuses/{sha}","languages_url":"https://api.github.com/repos/cliqz-oss/keyvi/languages","stargazers_url":"https://api.github.com/repos/cliqz-oss/keyvi/stargazers","contributors_url":"https://api.github.com/repos/cliqz-oss/keyvi/contributors","subscribers_url":"https://api.github.com/repos/cliqz-oss/keyvi/subscribers","subscription_url":"https://api.github.com/repos/cliqz-oss/keyvi/subscription","commits_url":"https://api.github.com/repos/cliqz-oss/keyvi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cliqz-oss/keyvi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cliqz-oss/keyvi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cliqz-oss/keyvi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cliqz-oss/keyvi/contents/{+path}","compare_url":"https://api.github.com/repos/cliqz-oss/keyvi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cliqz-oss/keyvi/merges","archive_url":"https://api.github.com/repos/cliqz-oss/keyvi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cliqz-oss/keyvi/downloads","issues_url":"https://api.github.com/repos/cliqz-oss/keyvi/issues{/number}","pulls_url":"https://api.github.com/repos/cliqz-oss/keyvi/pulls{/number}","milestones_url":"https://api.github.com/repos/cliqz-oss/keyvi/milestones{/number}","notifications_url":"https://api.github.com/repos/cliqz-oss/keyvi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cliqz-oss/keyvi/labels{/name}","releases_url":"https://api.github.com/repos/cliqz-oss/keyvi/releases{/id}","deployments_url":"https://api.github.com/repos/cliqz-oss/keyvi/deployments","created_at":"2015-07-14T21:25:01Z","updated_at":"2016-07-18T09:58:43Z","pushed_at":"2016-09-07T07:39:54Z","git_url":"git://github.com/cliqz-oss/keyvi.git","ssh_url":"git@github.com:cliqz-oss/keyvi.git","clone_url":"https://github.com/cliqz-oss/keyvi.git","svn_url":"https://github.com/cliqz-oss/keyvi","homepage":null,"size":9857,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":8,"forks":23,"open_issues":8,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120"},"html":{"href":"https://github.com/cliqz-oss/keyvi/pull/120"},"issue":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/issues/120"},"comments":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/cliqz-oss/keyvi/statuses/aa47e0e2a402ddd61e28d68ebe895c03d005cb89"}}}}
{"actor":{"display_login":"narek-cliqz"}}