{"action":"closed","issue":{"url":"https://api.github.com/repos/radarsat1/liblo/issues/21","repository_url":"https://api.github.com/repos/radarsat1/liblo","labels_url":"https://api.github.com/repos/radarsat1/liblo/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/radarsat1/liblo/issues/21/comments","events_url":"https://api.github.com/repos/radarsat1/liblo/issues/21/events","html_url":"https://github.com/radarsat1/liblo/issues/21","id":84435278,"number":21,"title":"Cygwin make fails","user":{"login":"Samardon","id":2303534,"avatar_url":"https://avatars.githubusercontent.com/u/2303534?v=3","gravatar_id":"","url":"https://api.github.com/users/Samardon","html_url":"https://github.com/Samardon","followers_url":"https://api.github.com/users/Samardon/followers","following_url":"https://api.github.com/users/Samardon/following{/other_user}","gists_url":"https://api.github.com/users/Samardon/gists{/gist_id}","starred_url":"https://api.github.com/users/Samardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samardon/subscriptions","organizations_url":"https://api.github.com/users/Samardon/orgs","repos_url":"https://api.github.com/users/Samardon/repos","events_url":"https://api.github.com/users/Samardon/events{/privacy}","received_events_url":"https://api.github.com/users/Samardon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-03T08:36:15Z","updated_at":"2016-02-11T15:25:19Z","closed_at":"2016-02-11T15:25:19Z","body":"With the following error:\r\n```\r\ngcc -DHAVE_CONFIG_H -I. -I../..     -I../.. -O0 -g -Wall -Werror -DDEBUG -MT oscdump\r\n-oscdump.o -MD -MP -MF .deps/oscdump-oscdump.Tpo -c -o oscdump-oscdump.o `test -f 'oscdump.c' || echo './'`oscdump.c\r\noscdump.c: In function ‘main’:\r\noscdump.c:86:5: error: array subscript has type ‘char’ [-Werror=char-subscripts]\r\n     } else if (isdigit(port[0])) {\r\n     ^\r\ncc1: all warnings being treated as errors\r\nMakefile:479: recipe for target 'oscdump-oscdump.o' failed\r\nmake[4]: *** [oscdump-oscdump.o] Error 1\r\nmake[4]: Leaving directory '/home/user/projects/liblo/liblo-0.28/src/tools'\r\nMakefile:519: recipe for target 'all-recursive' failed\r\nmake[3]: *** [all-recursive] Error 1\r\nmake[3]: Leaving directory '/home/user/projects/liblo/liblo-0.28/src/tools'\r\nMakefile:949: recipe for target 'all-recursive' failed\r\nmake[2]: *** [all-recursive] Error 1\r\nmake[2]: Leaving directory '/home/user/projects/liblo/liblo-0.28/src'\r\nMakefile:457: recipe for target 'all-recursive' failed\r\nmake[1]: *** [all-recursive] Error 1\r\nmake[1]: Leaving directory '/home/user/projects/liblo/liblo-0.28'\r\nMakefile:365: recipe for target 'all' failed\r\nmake: *** [all] Error 2\r\n```\r\nI was able to fix the error with a cast, changing:\r\n`     } else if (isdigit(port[0])) {`\r\nto:\r\n`     } else if (isdigit((int)port[0])) {`\r\nHowever, I'm not familiar enough with the language to say for certain that this is the best way to go about it, so I thought it best to hold off on making a PR for it."}}