{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15966","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15966/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15966/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15966/events","html_url":"https://github.com/mantidproject/mantid/pull/15966","id":150304048,"number":15966,"title":"System test for Pearl powder diffraction script","user":{"login":"shahrozahmed1","id":13132173,"avatar_url":"https://avatars.githubusercontent.com/u/13132173?v=3","gravatar_id":"","url":"https://api.github.com/users/shahrozahmed1","html_url":"https://github.com/shahrozahmed1","followers_url":"https://api.github.com/users/shahrozahmed1/followers","following_url":"https://api.github.com/users/shahrozahmed1/following{/other_user}","gists_url":"https://api.github.com/users/shahrozahmed1/gists{/gist_id}","starred_url":"https://api.github.com/users/shahrozahmed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahrozahmed1/subscriptions","organizations_url":"https://api.github.com/users/shahrozahmed1/orgs","repos_url":"https://api.github.com/users/shahrozahmed1/repos","events_url":"https://api.github.com/users/shahrozahmed1/events{/privacy}","received_events_url":"https://api.github.com/users/shahrozahmed1/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Diffraction","name":"Component: Diffraction","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Group:%20Powder","name":"Group: Powder","color":"bfe5bf"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Quality:%20System%20Tests","name":"Quality: System Tests","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":586,"closed_issues":628,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-04-26T08:50:17Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":2,"created_at":"2016-04-22T08:23:13Z","updated_at":"2016-04-26T10:53:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15966","html_url":"https://github.com/mantidproject/mantid/pull/15966","diff_url":"https://github.com/mantidproject/mantid/pull/15966.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15966.patch"},"body":"- [x] #15946 *PR is merged*\r\n\r\n**Description of work.**\r\n\r\nSystem test for the new pearl script, this script which is ran within this system test triggers the `pearl_focus`, which is the most commonly used command by the `Pearl` scientists according to Craig Bull.  I have created a similar folder structure to `\\\\britannic\\Pearl\\Mantid` within system test data. The `pearl_focus` will use existing calibrations files, which are usually generated once every start of cycle. Essentially another test case should be added within this system test soon which generated the calibrations files and uses it to focus.\r\n\r\n**To test:**\r\n\r\n- Run the test locally (remember to rerun cmake/build system tests to get the files) \r\n- Make sure all generated files are cleared upon completion of system test\r\n- All builds pass\r\n\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #15913\r\n*Does not need to be in the release notes.*\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/214701428","html_url":"https://github.com/mantidproject/mantid/pull/15966#issuecomment-214701428","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15966","id":214701428,"user":{"login":"shahrozahmed1","id":13132173,"avatar_url":"https://avatars.githubusercontent.com/u/13132173?v=3","gravatar_id":"","url":"https://api.github.com/users/shahrozahmed1","html_url":"https://github.com/shahrozahmed1","followers_url":"https://api.github.com/users/shahrozahmed1/followers","following_url":"https://api.github.com/users/shahrozahmed1/following{/other_user}","gists_url":"https://api.github.com/users/shahrozahmed1/gists{/gist_id}","starred_url":"https://api.github.com/users/shahrozahmed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahrozahmed1/subscriptions","organizations_url":"https://api.github.com/users/shahrozahmed1/orgs","repos_url":"https://api.github.com/users/shahrozahmed1/repos","events_url":"https://api.github.com/users/shahrozahmed1/events{/privacy}","received_events_url":"https://api.github.com/users/shahrozahmed1/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T10:53:44Z","updated_at":"2016-04-26T10:53:44Z","body":"@FedeMPouzols weird that these pylint violations are not produced locally at all even though I am using the same `pylint.cfg` file.. "}}