{"action":"created","comment":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/72871600","id":72871600,"diff_hunk":"@@ -409,67 +438,69 @@ def _parsePreamble(preamble):\n                     ('maxBW',False),\n                     ('minBW',False)]\n     '''\n-    preambleKeys = [('byteFormat',True),\n-                ('dataType',True),\n-                ('numPoints',True),\n-                ('count',True),\n-                ('xStep',True),\n-                ('xFirst',True),\n-                ('xRef',True),\n-                ('yStep',True),\n-                ('yOrigin',True),\n-                ('yRef',True),\n-                ('coupling',True),\n-                ('xRange',True),\n-                ('xLeftDisplay',True),\n-                ('yRange',True),\n-                ('yCenterDisplay',True),\n-                ('date',True),\n-                ('time',True),\n-                ('model',True),\n-                ('acquisitionMode',True),\n-                ('percentTimeBucketsComplete',True),\n-                ('xUnits',True),\n-                ('yUnits',True),\n-                ('maxBW',True),\n-                ('minBW',True)]\n-    preambleDict = {}\n-    for key,val in zip(preambleKeys,preambleVals):\n+    preamble_keys = [('byteFormat', True),\n+                ('dataType', True),\n+                ('numPoints', True),\n+                ('count', True),\n+                ('xStep', True),\n+                ('xFirst', True),\n+                ('xRef', True),\n+                ('yStep', True),\n+                ('yOrigin', True),\n+                ('yRef', True),\n+                ('coupling', True),\n+                ('xRange', True),\n+                ('xLeftDisplay', True),\n+                ('yRange', True),\n+                ('yCenterDisplay', True),\n+                ('date', True),\n+                ('time', True),\n+                ('model', True),\n+                ('acquisitionMode', True),\n+                ('percentTimeBucketsComplete', True),\n+                ('xUnits', True),\n+                ('yUnits', True),\n+                ('maxBW', True),\n+                ('minBW', True)]\n+    preample_dict = {}\n+    for key, val in zip(preamble_keys, preamble_vals):\n         if key[1]:\n-            preambleDict[key[0]] = val\n-    def unitType(num):\n-        if num=='1':\n+            preample_dict[key[0]] = val\n+\n+    def unit_type(num):\n+        if num == '1':\n             return 'V'\n-        elif num=='2':\n+        elif num == '2':\n             return 'ns'\n         else:\n             raise Exception('Units not time or voltage')\n-    preambleDict['xUnit'] = unitType(preambleDict['xUnits'])\n-    preambleDict['yUnit'] = unitType(preambleDict['yUnits'])\n-    return (preambleDict)\n+    preample_dict['xUnit'] = unit_type(preample_dict['xUnits'])\n+    preample_dict['yUnit'] = unit_type(preample_dict['yUnits'])\n+    return (preample_dict)\n+\n \n-def _parseBinaryData(data, wordLength):\n+def _parseBinaryData(data, word_length):\n     \"\"\"Parse binary data packed as string of RIBinary\n     \"\"\"","path":"agilent_infiniium_scope.py","position":null,"original_position":633,"commit_id":"c6cd800ca1dd5676c108ebd17468a78d41c59b1d","original_commit_id":"c3b86007365c492d1e43dfaa172a7ac91959ff26","user":{"login":"BrooksCampbell","id":10713905,"avatar_url":"https://avatars.githubusercontent.com/u/10713905?v=3","gravatar_id":"","url":"https://api.github.com/users/BrooksCampbell","html_url":"https://github.com/BrooksCampbell","followers_url":"https://api.github.com/users/BrooksCampbell/followers","following_url":"https://api.github.com/users/BrooksCampbell/following{/other_user}","gists_url":"https://api.github.com/users/BrooksCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/BrooksCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrooksCampbell/subscriptions","organizations_url":"https://api.github.com/users/BrooksCampbell/orgs","repos_url":"https://api.github.com/users/BrooksCampbell/repos","events_url":"https://api.github.com/users/BrooksCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/BrooksCampbell/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2016-07-29T22:50:40Z","updated_at":"2016-07-29T22:50:40Z","html_url":"https://github.com/martinisgroup/servers/pull/367#discussion_r72871600","pull_request_url":"https://api.github.com/repos/martinisgroup/servers/pulls/367","_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/72871600"},"html":{"href":"https://github.com/martinisgroup/servers/pull/367#discussion_r72871600"},"pull_request":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/367","id":79420480,"html_url":"https://github.com/martinisgroup/servers/pull/367","diff_url":"https://github.com/martinisgroup/servers/pull/367.diff","patch_url":"https://github.com/martinisgroup/servers/pull/367.patch","issue_url":"https://api.github.com/repos/martinisgroup/servers/issues/367","number":367,"state":"open","locked":false,"title":"U/brooks/infiniium scope server cleanup","user":{"login":"BrooksCampbell","id":10713905,"avatar_url":"https://avatars.githubusercontent.com/u/10713905?v=3","gravatar_id":"","url":"https://api.github.com/users/BrooksCampbell","html_url":"https://github.com/BrooksCampbell","followers_url":"https://api.github.com/users/BrooksCampbell/followers","following_url":"https://api.github.com/users/BrooksCampbell/following{/other_user}","gists_url":"https://api.github.com/users/BrooksCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/BrooksCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrooksCampbell/subscriptions","organizations_url":"https://api.github.com/users/BrooksCampbell/orgs","repos_url":"https://api.github.com/users/BrooksCampbell/repos","events_url":"https://api.github.com/users/BrooksCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/BrooksCampbell/received_events","type":"User","site_admin":false},"body":"Update infiniium scope server to use read_raw to pull binary data.\r\n\r\nAdds two *OPC? queries to the *RST and *CLS writes (Keysight suggested this as a best practice).\r\n\r\nAlso fixed a lot of white space issues and camel case variable names.","created_at":"2016-07-29T20:37:07Z","updated_at":"2016-07-29T22:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7d920d0098f96e64d3a053fc9c1f370cb3a1f7e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/martinisgroup/servers/pulls/367/commits","review_comments_url":"https://api.github.com/repos/martinisgroup/servers/pulls/367/comments","review_comment_url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martinisgroup/servers/issues/367/comments","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/c6cd800ca1dd5676c108ebd17468a78d41c59b1d","head":{"label":"martinisgroup:u/Brooks/infiniium_scope_server_cleanup","ref":"u/Brooks/infiniium_scope_server_cleanup","sha":"c6cd800ca1dd5676c108ebd17468a78d41c59b1d","user":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":21184808,"name":"servers","full_name":"martinisgroup/servers","owner":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/martinisgroup/servers","description":"LabRAD servers","fork":false,"url":"https://api.github.com/repos/martinisgroup/servers","forks_url":"https://api.github.com/repos/martinisgroup/servers/forks","keys_url":"https://api.github.com/repos/martinisgroup/servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinisgroup/servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinisgroup/servers/teams","hooks_url":"https://api.github.com/repos/martinisgroup/servers/hooks","issue_events_url":"https://api.github.com/repos/martinisgroup/servers/issues/events{/number}","events_url":"https://api.github.com/repos/martinisgroup/servers/events","assignees_url":"https://api.github.com/repos/martinisgroup/servers/assignees{/user}","branches_url":"https://api.github.com/repos/martinisgroup/servers/branches{/branch}","tags_url":"https://api.github.com/repos/martinisgroup/servers/tags","blobs_url":"https://api.github.com/repos/martinisgroup/servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinisgroup/servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinisgroup/servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinisgroup/servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/{sha}","languages_url":"https://api.github.com/repos/martinisgroup/servers/languages","stargazers_url":"https://api.github.com/repos/martinisgroup/servers/stargazers","contributors_url":"https://api.github.com/repos/martinisgroup/servers/contributors","subscribers_url":"https://api.github.com/repos/martinisgroup/servers/subscribers","subscription_url":"https://api.github.com/repos/martinisgroup/servers/subscription","commits_url":"https://api.github.com/repos/martinisgroup/servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinisgroup/servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinisgroup/servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinisgroup/servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinisgroup/servers/contents/{+path}","compare_url":"https://api.github.com/repos/martinisgroup/servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinisgroup/servers/merges","archive_url":"https://api.github.com/repos/martinisgroup/servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinisgroup/servers/downloads","issues_url":"https://api.github.com/repos/martinisgroup/servers/issues{/number}","pulls_url":"https://api.github.com/repos/martinisgroup/servers/pulls{/number}","milestones_url":"https://api.github.com/repos/martinisgroup/servers/milestones{/number}","notifications_url":"https://api.github.com/repos/martinisgroup/servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinisgroup/servers/labels{/name}","releases_url":"https://api.github.com/repos/martinisgroup/servers/releases{/id}","deployments_url":"https://api.github.com/repos/martinisgroup/servers/deployments","created_at":"2014-06-25T00:07:25Z","updated_at":"2016-02-03T23:29:43Z","pushed_at":"2016-07-29T22:50:32Z","git_url":"git://github.com/martinisgroup/servers.git","ssh_url":"git@github.com:martinisgroup/servers.git","clone_url":"https://github.com/martinisgroup/servers.git","svn_url":"https://github.com/martinisgroup/servers","homepage":"","size":53813,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":119,"forks":6,"open_issues":119,"watchers":6,"default_branch":"master"}},"base":{"label":"martinisgroup:master","ref":"master","sha":"9479dd15d80f41b7f4bf2bda66444a302f573d12","user":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":21184808,"name":"servers","full_name":"martinisgroup/servers","owner":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/martinisgroup/servers","description":"LabRAD servers","fork":false,"url":"https://api.github.com/repos/martinisgroup/servers","forks_url":"https://api.github.com/repos/martinisgroup/servers/forks","keys_url":"https://api.github.com/repos/martinisgroup/servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinisgroup/servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinisgroup/servers/teams","hooks_url":"https://api.github.com/repos/martinisgroup/servers/hooks","issue_events_url":"https://api.github.com/repos/martinisgroup/servers/issues/events{/number}","events_url":"https://api.github.com/repos/martinisgroup/servers/events","assignees_url":"https://api.github.com/repos/martinisgroup/servers/assignees{/user}","branches_url":"https://api.github.com/repos/martinisgroup/servers/branches{/branch}","tags_url":"https://api.github.com/repos/martinisgroup/servers/tags","blobs_url":"https://api.github.com/repos/martinisgroup/servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinisgroup/servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinisgroup/servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinisgroup/servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/{sha}","languages_url":"https://api.github.com/repos/martinisgroup/servers/languages","stargazers_url":"https://api.github.com/repos/martinisgroup/servers/stargazers","contributors_url":"https://api.github.com/repos/martinisgroup/servers/contributors","subscribers_url":"https://api.github.com/repos/martinisgroup/servers/subscribers","subscription_url":"https://api.github.com/repos/martinisgroup/servers/subscription","commits_url":"https://api.github.com/repos/martinisgroup/servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinisgroup/servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinisgroup/servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinisgroup/servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinisgroup/servers/contents/{+path}","compare_url":"https://api.github.com/repos/martinisgroup/servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinisgroup/servers/merges","archive_url":"https://api.github.com/repos/martinisgroup/servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinisgroup/servers/downloads","issues_url":"https://api.github.com/repos/martinisgroup/servers/issues{/number}","pulls_url":"https://api.github.com/repos/martinisgroup/servers/pulls{/number}","milestones_url":"https://api.github.com/repos/martinisgroup/servers/milestones{/number}","notifications_url":"https://api.github.com/repos/martinisgroup/servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinisgroup/servers/labels{/name}","releases_url":"https://api.github.com/repos/martinisgroup/servers/releases{/id}","deployments_url":"https://api.github.com/repos/martinisgroup/servers/deployments","created_at":"2014-06-25T00:07:25Z","updated_at":"2016-02-03T23:29:43Z","pushed_at":"2016-07-29T22:50:32Z","git_url":"git://github.com/martinisgroup/servers.git","ssh_url":"git@github.com:martinisgroup/servers.git","clone_url":"https://github.com/martinisgroup/servers.git","svn_url":"https://github.com/martinisgroup/servers","homepage":"","size":53813,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":119,"forks":6,"open_issues":119,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/367"},"html":{"href":"https://github.com/martinisgroup/servers/pull/367"},"issue":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/367"},"comments":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/martinisgroup/servers/statuses/c6cd800ca1dd5676c108ebd17468a78d41c59b1d"}}}}
{"actor":{"display_login":"BrooksCampbell"}}