{"action":"created","issue":{"url":"https://api.github.com/repos/Bruce17/dependable/issues/2","repository_url":"https://api.github.com/repos/Bruce17/dependable","labels_url":"https://api.github.com/repos/Bruce17/dependable/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/Bruce17/dependable/issues/2/comments","events_url":"https://api.github.com/repos/Bruce17/dependable/issues/2/events","html_url":"https://github.com/Bruce17/dependable/pull/2","id":167626450,"number":2,"title":"Adds support for fat arrow functions.","user":{"login":"calmdev","id":461249,"avatar_url":"https://avatars.githubusercontent.com/u/461249?v=3","gravatar_id":"","url":"https://api.github.com/users/calmdev","html_url":"https://github.com/calmdev","followers_url":"https://api.github.com/users/calmdev/followers","following_url":"https://api.github.com/users/calmdev/following{/other_user}","gists_url":"https://api.github.com/users/calmdev/gists{/gist_id}","starred_url":"https://api.github.com/users/calmdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmdev/subscriptions","organizations_url":"https://api.github.com/users/calmdev/orgs","repos_url":"https://api.github.com/users/calmdev/repos","events_url":"https://api.github.com/users/calmdev/events{/privacy}","received_events_url":"https://api.github.com/users/calmdev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-26T14:48:13Z","updated_at":"2016-07-27T13:35:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Bruce17/dependable/pulls/2","html_url":"https://github.com/Bruce17/dependable/pull/2","diff_url":"https://github.com/Bruce17/dependable/pull/2.diff","patch_url":"https://github.com/Bruce17/dependable/pull/2.patch"},"body":"Hey! Noticed you've been doing a lot of work over here. I've switch over to your fork. How do you feel about supporting fat arrow functions? This change to the `strFunc` regex seems to be working for me and all the tests are still passing.\r\n\r\n```js\r\n// es6 fat arrow\r\ncontainer.register('_', () => require('lodash'));\r\n// vs es5\r\ncontainer.register('_', function() { \r\n  return require('lodash'); \r\n});\r\n```\r\n\r\nwithout this change use of fat arrow functions will throw an error:\r\n\r\n```shell\r\nthrow new Error('Could not parse function arguments: ' + func.toString());\r\nError: Could not parse function arguments: () => require('lodash')\r\n```\r\n\r\nGood work so far and let me know what's up! 🍻 "},"comment":{"url":"https://api.github.com/repos/Bruce17/dependable/issues/comments/235586505","html_url":"https://github.com/Bruce17/dependable/pull/2#issuecomment-235586505","issue_url":"https://api.github.com/repos/Bruce17/dependable/issues/2","id":235586505,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T13:35:28Z","updated_at":"2016-07-27T13:35:28Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7184408/badge)](https://coveralls.io/builds/7184408)\n\nCoverage decreased (-1.1%) to 97.076% when pulling **fb2362ac1a14048a6016836cb675833db05e770b on calmdev:feature/fat-arrow-functions** into **086edb682bc8e8ac1b71f08784fd906efd3bb39d on Bruce17:master**.\n"}}
{"actor":{"display_login":"coveralls"}}