{"action":"created","issue":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1067","repository_url":"https://api.github.com/repos/gemini-hlsw/ocs","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1067/labels{/name}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1067/comments","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1067/events","html_url":"https://github.com/gemini-hlsw/ocs/pull/1067","id":171923273,"number":1067,"title":"REL-2922: Parallactic angle setting PA at too high a precision","user":{"login":"sraaphorst","id":8795653,"avatar_url":"https://avatars.githubusercontent.com/u/8795653?v=3","gravatar_id":"","url":"https://api.github.com/users/sraaphorst","html_url":"https://github.com/sraaphorst","followers_url":"https://api.github.com/users/sraaphorst/followers","following_url":"https://api.github.com/users/sraaphorst/following{/other_user}","gists_url":"https://api.github.com/users/sraaphorst/gists{/gist_id}","starred_url":"https://api.github.com/users/sraaphorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sraaphorst/subscriptions","organizations_url":"https://api.github.com/users/sraaphorst/orgs","repos_url":"https://api.github.com/users/sraaphorst/repos","events_url":"https://api.github.com/users/sraaphorst/events{/privacy}","received_events_url":"https://api.github.com/users/sraaphorst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-18T15:02:09Z","updated_at":"2016-08-18T19:24:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1067","html_url":"https://github.com/gemini-hlsw/ocs/pull/1067","diff_url":"https://github.com/gemini-hlsw/ocs/pull/1067.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/1067.patch"},"body":"When using the parallactic angle mode for observations, the resultant PA is calculated at an extremely high precision. This resulted in issues with the instrument configuration: for example, the parallactic angle would be calculated and set on the instrument to a high level of precision, and then BAGS would run, and then set the PA to the \"almost equals\" angle at a lower precision, which would cause issues with the parallactic angle once again to be calculated and determine itself to be different from the instrument PA. Lather, rinse, repeat.\r\n\r\nThis change comprises:\r\n1. Using a more standard precision for setting the PA on the instrument for parallactic angle calculations;\r\n2. Not recognizing a 180 flip from the calculated parallactic angle (which can be used by BAGS in GS selection and is permitted) as a new PA; and\r\n3. General cleanup."},"comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments/240829124","html_url":"https://github.com/gemini-hlsw/ocs/pull/1067#issuecomment-240829124","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1067","id":240829124,"user":{"login":"sraaphorst","id":8795653,"avatar_url":"https://avatars.githubusercontent.com/u/8795653?v=3","gravatar_id":"","url":"https://api.github.com/users/sraaphorst","html_url":"https://github.com/sraaphorst","followers_url":"https://api.github.com/users/sraaphorst/followers","following_url":"https://api.github.com/users/sraaphorst/following{/other_user}","gists_url":"https://api.github.com/users/sraaphorst/gists{/gist_id}","starred_url":"https://api.github.com/users/sraaphorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sraaphorst/subscriptions","organizations_url":"https://api.github.com/users/sraaphorst/orgs","repos_url":"https://api.github.com/users/sraaphorst/repos","events_url":"https://api.github.com/users/sraaphorst/events{/privacy}","received_events_url":"https://api.github.com/users/sraaphorst/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T19:24:08Z","updated_at":"2016-08-18T19:24:08Z","body":"For reference, the observation where this is easily reproducible and to which I refer above is:\r\nGS-2016B-Q-64-55\r\n\r\nAlso note that there is REL-2921, which requires moving some of the parallactic angle controls methods to run on the Swing EDT so that they occur in the right order with BAGS, as right now, it is easy to make things happen out of order due to BAGS only running on the EDT."}}
{"actor":{"display_login":"sraaphorst"}}