{"action":"created","comment":{"url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments/53041241","id":53041241,"diff_hunk":"@@ -25,5 +25,9 @@\n }\n !*/\n define(['Modernizr'], function(Modernizr) {\n-  Modernizr.addTest('websockets', 'WebSocket' in window && window.WebSocket.CLOSING === 2);\n+  try {\n+    Modernizr.addTest('websockets', 'WebSocket' in window && window.WebSocket.CLOSING === 2);\n+  } catch (e) {\n+    Modernizr.addTest('websockets', false);","path":"feature-detects/websockets.js","position":8,"original_position":8,"commit_id":"cca2489bbfd1c90f74d9798ad42a11d3537f406e","original_commit_id":"cca2489bbfd1c90f74d9798ad42a11d3537f406e","user":{"login":"philippsimon","id":2590857,"avatar_url":"https://avatars.githubusercontent.com/u/2590857?v=3","gravatar_id":"","url":"https://api.github.com/users/philippsimon","html_url":"https://github.com/philippsimon","followers_url":"https://api.github.com/users/philippsimon/followers","following_url":"https://api.github.com/users/philippsimon/following{/other_user}","gists_url":"https://api.github.com/users/philippsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/philippsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippsimon/subscriptions","organizations_url":"https://api.github.com/users/philippsimon/orgs","repos_url":"https://api.github.com/users/philippsimon/repos","events_url":"https://api.github.com/users/philippsimon/events{/privacy}","received_events_url":"https://api.github.com/users/philippsimon/received_events","type":"User","site_admin":false},"body":"I would say it wouldn't even run the test, but yes it's more clear","created_at":"2016-02-16T17:00:57Z","updated_at":"2016-02-16T17:00:57Z","html_url":"https://github.com/Modernizr/Modernizr/pull/1884#discussion_r53041241","pull_request_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884","_links":{"self":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments/53041241"},"html":{"href":"https://github.com/Modernizr/Modernizr/pull/1884#discussion_r53041241"},"pull_request":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884"}}},"pull_request":{"url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884","id":59488085,"html_url":"https://github.com/Modernizr/Modernizr/pull/1884","diff_url":"https://github.com/Modernizr/Modernizr/pull/1884.diff","patch_url":"https://github.com/Modernizr/Modernizr/pull/1884.patch","issue_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/1884","number":1884,"state":"open","locked":false,"title":"Fix websockets test for some Panasonic SmartTVs","user":{"login":"philippsimon","id":2590857,"avatar_url":"https://avatars.githubusercontent.com/u/2590857?v=3","gravatar_id":"","url":"https://api.github.com/users/philippsimon","html_url":"https://github.com/philippsimon","followers_url":"https://api.github.com/users/philippsimon/followers","following_url":"https://api.github.com/users/philippsimon/following{/other_user}","gists_url":"https://api.github.com/users/philippsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/philippsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippsimon/subscriptions","organizations_url":"https://api.github.com/users/philippsimon/orgs","repos_url":"https://api.github.com/users/philippsimon/repos","events_url":"https://api.github.com/users/philippsimon/events{/privacy}","received_events_url":"https://api.github.com/users/philippsimon/received_events","type":"User","site_admin":false},"body":"SmartTV browsers from 2012 Panasonic TVs crash otherwise.\r\nIt seems they didn't integrate `window.WebSocket` fully.","created_at":"2016-02-16T13:09:09Z","updated_at":"2016-02-16T17:00:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64f0a5ba038cdf5c65de3204ef52df1fb64c9026","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884/commits","review_comments_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884/comments","review_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/1884/comments","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/cca2489bbfd1c90f74d9798ad42a11d3537f406e","head":{"label":"philippsimon:websockets-fix","ref":"websockets-fix","sha":"cca2489bbfd1c90f74d9798ad42a11d3537f406e","user":{"login":"philippsimon","id":2590857,"avatar_url":"https://avatars.githubusercontent.com/u/2590857?v=3","gravatar_id":"","url":"https://api.github.com/users/philippsimon","html_url":"https://github.com/philippsimon","followers_url":"https://api.github.com/users/philippsimon/followers","following_url":"https://api.github.com/users/philippsimon/following{/other_user}","gists_url":"https://api.github.com/users/philippsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/philippsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippsimon/subscriptions","organizations_url":"https://api.github.com/users/philippsimon/orgs","repos_url":"https://api.github.com/users/philippsimon/repos","events_url":"https://api.github.com/users/philippsimon/events{/privacy}","received_events_url":"https://api.github.com/users/philippsimon/received_events","type":"User","site_admin":false},"repo":{"id":51833484,"name":"Modernizr","full_name":"philippsimon/Modernizr","owner":{"login":"philippsimon","id":2590857,"avatar_url":"https://avatars.githubusercontent.com/u/2590857?v=3","gravatar_id":"","url":"https://api.github.com/users/philippsimon","html_url":"https://github.com/philippsimon","followers_url":"https://api.github.com/users/philippsimon/followers","following_url":"https://api.github.com/users/philippsimon/following{/other_user}","gists_url":"https://api.github.com/users/philippsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/philippsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippsimon/subscriptions","organizations_url":"https://api.github.com/users/philippsimon/orgs","repos_url":"https://api.github.com/users/philippsimon/repos","events_url":"https://api.github.com/users/philippsimon/events{/privacy}","received_events_url":"https://api.github.com/users/philippsimon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philippsimon/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":true,"url":"https://api.github.com/repos/philippsimon/Modernizr","forks_url":"https://api.github.com/repos/philippsimon/Modernizr/forks","keys_url":"https://api.github.com/repos/philippsimon/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philippsimon/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philippsimon/Modernizr/teams","hooks_url":"https://api.github.com/repos/philippsimon/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/philippsimon/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/philippsimon/Modernizr/events","assignees_url":"https://api.github.com/repos/philippsimon/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/philippsimon/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/philippsimon/Modernizr/tags","blobs_url":"https://api.github.com/repos/philippsimon/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philippsimon/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philippsimon/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/philippsimon/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philippsimon/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/philippsimon/Modernizr/languages","stargazers_url":"https://api.github.com/repos/philippsimon/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/philippsimon/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/philippsimon/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/philippsimon/Modernizr/subscription","commits_url":"https://api.github.com/repos/philippsimon/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/philippsimon/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/philippsimon/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/philippsimon/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/philippsimon/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/philippsimon/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philippsimon/Modernizr/merges","archive_url":"https://api.github.com/repos/philippsimon/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philippsimon/Modernizr/downloads","issues_url":"https://api.github.com/repos/philippsimon/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/philippsimon/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/philippsimon/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/philippsimon/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philippsimon/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/philippsimon/Modernizr/releases{/id}","deployments_url":"https://api.github.com/repos/philippsimon/Modernizr/deployments","created_at":"2016-02-16T12:14:30Z","updated_at":"2016-02-16T12:14:31Z","pushed_at":"2016-02-16T13:07:59Z","git_url":"git://github.com/philippsimon/Modernizr.git","ssh_url":"git@github.com:philippsimon/Modernizr.git","clone_url":"https://github.com/philippsimon/Modernizr.git","svn_url":"https://github.com/philippsimon/Modernizr","homepage":"https://modernizr.com","size":37008,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Modernizr:master","ref":"master","sha":"00a4157b83037f94c3fe3ad97f3770b62466c156","user":{"login":"Modernizr","id":131060,"avatar_url":"https://avatars.githubusercontent.com/u/131060?v=3","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"repo":{"id":317757,"name":"Modernizr","full_name":"Modernizr/Modernizr","owner":{"login":"Modernizr","id":131060,"avatar_url":"https://avatars.githubusercontent.com/u/131060?v=3","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Modernizr/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":false,"url":"https://api.github.com/repos/Modernizr/Modernizr","forks_url":"https://api.github.com/repos/Modernizr/Modernizr/forks","keys_url":"https://api.github.com/repos/Modernizr/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Modernizr/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Modernizr/Modernizr/teams","hooks_url":"https://api.github.com/repos/Modernizr/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/Modernizr/Modernizr/events","assignees_url":"https://api.github.com/repos/Modernizr/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/Modernizr/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/Modernizr/Modernizr/tags","blobs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Modernizr/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Modernizr/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/Modernizr/Modernizr/languages","stargazers_url":"https://api.github.com/repos/Modernizr/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/Modernizr/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/Modernizr/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/Modernizr/Modernizr/subscription","commits_url":"https://api.github.com/repos/Modernizr/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Modernizr/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Modernizr/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/Modernizr/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Modernizr/Modernizr/merges","archive_url":"https://api.github.com/repos/Modernizr/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Modernizr/Modernizr/downloads","issues_url":"https://api.github.com/repos/Modernizr/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/Modernizr/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/Modernizr/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Modernizr/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/Modernizr/Modernizr/releases{/id}","deployments_url":"https://api.github.com/repos/Modernizr/Modernizr/deployments","created_at":"2009-09-25T20:13:23Z","updated_at":"2016-02-16T16:23:36Z","pushed_at":"2016-02-16T13:09:10Z","git_url":"git://github.com/Modernizr/Modernizr.git","ssh_url":"git@github.com:Modernizr/Modernizr.git","clone_url":"https://github.com/Modernizr/Modernizr.git","svn_url":"https://github.com/Modernizr/Modernizr","homepage":"https://modernizr.com","size":64670,"stargazers_count":17332,"watchers_count":17332,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2400,"mirror_url":null,"open_issues_count":122,"forks":2400,"open_issues":122,"watchers":17332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884"},"html":{"href":"https://github.com/Modernizr/Modernizr/pull/1884"},"issue":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/1884"},"comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/1884/comments"},"review_comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884/comments"},"review_comment":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1884/commits"},"statuses":{"href":"https://api.github.com/repos/Modernizr/Modernizr/statuses/cca2489bbfd1c90f74d9798ad42a11d3537f406e"}}}}