{"action":"created","issue":{"url":"https://api.github.com/repos/xbehave/xbehave.net/issues/349","repository_url":"https://api.github.com/repos/xbehave/xbehave.net","labels_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/349/comments","events_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/349/events","html_url":"https://github.com/xbehave/xbehave.net/issues/349","id":183265508,"number":349,"title":"A minor issue related to the formatting of the tests","user":{"login":"eyalsk","id":3756641,"avatar_url":"https://avatars.githubusercontent.com/u/3756641?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalsk","html_url":"https://github.com/eyalsk","followers_url":"https://api.github.com/users/eyalsk/followers","following_url":"https://api.github.com/users/eyalsk/following{/other_user}","gists_url":"https://api.github.com/users/eyalsk/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalsk/subscriptions","organizations_url":"https://api.github.com/users/eyalsk/orgs","repos_url":"https://api.github.com/users/eyalsk/repos","events_url":"https://api.github.com/users/eyalsk/events{/privacy}","received_events_url":"https://api.github.com/users/eyalsk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbehave/xbehave.net/labels/discussion","name":"discussion","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-16T12:53:13Z","updated_at":"2016-10-16T15:39:43Z","closed_at":null,"body":"Hey, \r\n\r\nI'm not sure whether this relates to xbehave, xunit or ReSharper itself but at times I have tests like this:\r\n```C#\r\n[Scenario]\r\npublic void ThrowArgumentNullException()\r\n{\r\n    $@\"When the xmlCommandElement parameter is null \r\n        then the method {nameof(XmlCommandElementConverter.ToCommandModel)} \r\n        should throw {nameof(ArgumentNullException)}\"\r\n        .x(() => Action(() => {\r\n                            XmlCommandElementConverter.ToCommandModel(xmlCommandElement: null);\r\n                        }).ShouldThrow<ArgumentNullException>());\r\n}\r\n```\r\nNow, at the display level of the unit test runner I get the following result:\r\n```\r\nWhen the xmlCommandElement parameter is null \\r\\n                then the method ToCommandModel \\r\\n                should throw ArgumentNullException\r\n```\r\nBut I expect to get the following result:\r\n```\r\nWhen the xmlCommandElement parameter is null then the method ToCommandModel should throw ArgumentNullException\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/xbehave/xbehave.net/issues/comments/254054165","html_url":"https://github.com/xbehave/xbehave.net/issues/349#issuecomment-254054165","issue_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/349","id":254054165,"user":{"login":"eyalsk","id":3756641,"avatar_url":"https://avatars.githubusercontent.com/u/3756641?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalsk","html_url":"https://github.com/eyalsk","followers_url":"https://api.github.com/users/eyalsk/followers","following_url":"https://api.github.com/users/eyalsk/following{/other_user}","gists_url":"https://api.github.com/users/eyalsk/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalsk/subscriptions","organizations_url":"https://api.github.com/users/eyalsk/orgs","repos_url":"https://api.github.com/users/eyalsk/repos","events_url":"https://api.github.com/users/eyalsk/events{/privacy}","received_events_url":"https://api.github.com/users/eyalsk/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T15:39:43Z","updated_at":"2016-10-16T15:39:43Z","body":"@adamralph Well, I can't really see any downsides to it and to be honest, the _name_ of the tests should never be formatted much like functions aren't formatted and people shouldn't rely on it, it doesn't make sense simply because the underlying tech, specifically, xunit and ReSharper don't account for it and you end up looking at unreadable test names.\r\n\r\nI don't think it will have such a huge impact on performance, however, like anything I'd do a benchmark test and also try to do it without Regex at all.\r\n\r\nThese days, people tend to use Regex like LINQ and kill flies with a sledgehammer. ;)"}}
{"actor":{"display_login":"eyalsk"}}