{"action":"created","comment":{"url":"https://api.github.com/repos/johndyer/mediaelement/pulls/comments/71090395","id":71090395,"diff_hunk":"@@ -850,10 +862,45 @@\n \t\t\tif (typeof height != 'undefined') {\n \t\t\t\tt.height = height;\n \t\t\t}\n-\n+ \n+            \t\t// check stretching modes\n+            \t\tswitch(t.options.stretching) {\n+                \t\tcase 'fill':\n+        \t\t\t\t// The 'fill' effect only makes sense on video; for audio we will set the dimensions\n+                    \t\t\tif (t.isVideo) {\n+                    \t\t\t\tthis.setFillMode();\n+ \t\t\t\t\t} else {\n+                                \t\tthis.setDimensions(t.width, t.height);\n+ \t\t\t\t\t}\n+                    \t\t\tbreak;\n+                \t\tcase 'responsive':\n+                    \t\t\tthis.setResponsiveMode();\n+                    \t\t\tbreak;\n+                \t\tcase 'none':\n+                    \t\t\tthis.setDimensions(t.width, t.height);\n+                    \t\t\tbreak;\n+                \t\t// This is the 'auto' mode\n+                \t\tdefault:\n+                    \t\t\tif (this.hasFluidMode() === true) {\n+                        \t\t\tthis.setResponsiveMode();\n+                    \t\t\t} else {\n+                        \t\t\tthis.setDimensions(t.width, t.height);\n+                    \t\t\t}\n+                    \t\t\tbreak;\n+            \t\t}\n+\t\t},\n+ \n+\t        hasFluidMode: function() {\n+\t        \tvar t = this;\n+\t \n \t\t\t// detect 100% mode - use currentStyle for IE since css() doesn't return percentages\n-\t\t\tif (t.height.toString().indexOf('%') > 0 || (t.$node.css('max-width') !== 'none' && t.$node.css('max-width') !== 't.width') || (t.$node[0].currentStyle && t.$node[0].currentStyle.maxWidth === '100%')) {\n-\n+\t\t\treturn (t.height.toString().indexOf('%') > 0 || (t.$node.css('max-width') !== 'none' && t.$node.css('max-width') !== 't.width') || (t.$node[0].currentStyle && t.$node[0].currentStyle.maxWidth === '100%'));\n+\t        },\n+ \n+\t        setResponsiveMode: function() {\n+\t\t\tvar t = this;\n+\t\t\tif (t.hasFluidMode) {","path":"src/js/mep-player.js","position":98,"original_position":98,"commit_id":"c3b07bccf343e6d162f38ff536836447bace54da","original_commit_id":"c3b07bccf343e6d162f38ff536836447bace54da","user":{"login":"johndyer","id":214227,"avatar_url":"https://avatars.githubusercontent.com/u/214227?v=3","gravatar_id":"","url":"https://api.github.com/users/johndyer","html_url":"https://github.com/johndyer","followers_url":"https://api.github.com/users/johndyer/followers","following_url":"https://api.github.com/users/johndyer/following{/other_user}","gists_url":"https://api.github.com/users/johndyer/gists{/gist_id}","starred_url":"https://api.github.com/users/johndyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndyer/subscriptions","organizations_url":"https://api.github.com/users/johndyer/orgs","repos_url":"https://api.github.com/users/johndyer/repos","events_url":"https://api.github.com/users/johndyer/events{/privacy}","received_events_url":"https://api.github.com/users/johndyer/received_events","type":"User","site_admin":false},"body":"I just removed the check for the function \"hasFluidMode\" so it works without that. ","created_at":"2016-07-17T22:03:05Z","updated_at":"2016-07-17T22:03:05Z","html_url":"https://github.com/johndyer/mediaelement/pull/1773#discussion_r71090395","pull_request_url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773","_links":{"self":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/comments/71090395"},"html":{"href":"https://github.com/johndyer/mediaelement/pull/1773#discussion_r71090395"},"pull_request":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773"}}},"pull_request":{"url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773","id":77284393,"html_url":"https://github.com/johndyer/mediaelement/pull/1773","diff_url":"https://github.com/johndyer/mediaelement/pull/1773.diff","patch_url":"https://github.com/johndyer/mediaelement/pull/1773.patch","issue_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1773","number":1773,"state":"closed","locked":false,"title":"Stretching mechanism","user":{"login":"ron666","id":910829,"avatar_url":"https://avatars.githubusercontent.com/u/910829?v=3","gravatar_id":"","url":"https://api.github.com/users/ron666","html_url":"https://github.com/ron666","followers_url":"https://api.github.com/users/ron666/followers","following_url":"https://api.github.com/users/ron666/following{/other_user}","gists_url":"https://api.github.com/users/ron666/gists{/gist_id}","starred_url":"https://api.github.com/users/ron666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron666/subscriptions","organizations_url":"https://api.github.com/users/ron666/orgs","repos_url":"https://api.github.com/users/ron666/repos","events_url":"https://api.github.com/users/ron666/events{/privacy}","received_events_url":"https://api.github.com/users/ron666/received_events","type":"User","site_admin":false},"body":"Stretching mechanism to get \"fill\" effect like JWPlayer","created_at":"2016-07-13T13:02:29Z","updated_at":"2016-07-17T22:03:05Z","closed_at":"2016-07-17T21:25:35Z","merged_at":"2016-07-17T21:25:35Z","merge_commit_sha":"362a46403ee13051f822644ae14f49f413c2313e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773/commits","review_comments_url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773/comments","review_comment_url":"https://api.github.com/repos/johndyer/mediaelement/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1773/comments","statuses_url":"https://api.github.com/repos/johndyer/mediaelement/statuses/c3b07bccf343e6d162f38ff536836447bace54da","head":{"label":"ron666:stretching-mechanism","ref":"stretching-mechanism","sha":"c3b07bccf343e6d162f38ff536836447bace54da","user":{"login":"ron666","id":910829,"avatar_url":"https://avatars.githubusercontent.com/u/910829?v=3","gravatar_id":"","url":"https://api.github.com/users/ron666","html_url":"https://github.com/ron666","followers_url":"https://api.github.com/users/ron666/followers","following_url":"https://api.github.com/users/ron666/following{/other_user}","gists_url":"https://api.github.com/users/ron666/gists{/gist_id}","starred_url":"https://api.github.com/users/ron666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron666/subscriptions","organizations_url":"https://api.github.com/users/ron666/orgs","repos_url":"https://api.github.com/users/ron666/repos","events_url":"https://api.github.com/users/ron666/events{/privacy}","received_events_url":"https://api.github.com/users/ron666/received_events","type":"User","site_admin":false},"repo":{"id":61681860,"name":"mediaelement","full_name":"ron666/mediaelement","owner":{"login":"ron666","id":910829,"avatar_url":"https://avatars.githubusercontent.com/u/910829?v=3","gravatar_id":"","url":"https://api.github.com/users/ron666","html_url":"https://github.com/ron666","followers_url":"https://api.github.com/users/ron666/followers","following_url":"https://api.github.com/users/ron666/following{/other_user}","gists_url":"https://api.github.com/users/ron666/gists{/gist_id}","starred_url":"https://api.github.com/users/ron666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron666/subscriptions","organizations_url":"https://api.github.com/users/ron666/orgs","repos_url":"https://api.github.com/users/ron666/repos","events_url":"https://api.github.com/users/ron666/events{/privacy}","received_events_url":"https://api.github.com/users/ron666/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ron666/mediaelement","description":"HTML5 <audio> or <video> player with Flash and Silverlight shims that mimics the HTML5 MediaElement API, enabling a consistent UI in all browsers.","fork":true,"url":"https://api.github.com/repos/ron666/mediaelement","forks_url":"https://api.github.com/repos/ron666/mediaelement/forks","keys_url":"https://api.github.com/repos/ron666/mediaelement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ron666/mediaelement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ron666/mediaelement/teams","hooks_url":"https://api.github.com/repos/ron666/mediaelement/hooks","issue_events_url":"https://api.github.com/repos/ron666/mediaelement/issues/events{/number}","events_url":"https://api.github.com/repos/ron666/mediaelement/events","assignees_url":"https://api.github.com/repos/ron666/mediaelement/assignees{/user}","branches_url":"https://api.github.com/repos/ron666/mediaelement/branches{/branch}","tags_url":"https://api.github.com/repos/ron666/mediaelement/tags","blobs_url":"https://api.github.com/repos/ron666/mediaelement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ron666/mediaelement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ron666/mediaelement/git/refs{/sha}","trees_url":"https://api.github.com/repos/ron666/mediaelement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ron666/mediaelement/statuses/{sha}","languages_url":"https://api.github.com/repos/ron666/mediaelement/languages","stargazers_url":"https://api.github.com/repos/ron666/mediaelement/stargazers","contributors_url":"https://api.github.com/repos/ron666/mediaelement/contributors","subscribers_url":"https://api.github.com/repos/ron666/mediaelement/subscribers","subscription_url":"https://api.github.com/repos/ron666/mediaelement/subscription","commits_url":"https://api.github.com/repos/ron666/mediaelement/commits{/sha}","git_commits_url":"https://api.github.com/repos/ron666/mediaelement/git/commits{/sha}","comments_url":"https://api.github.com/repos/ron666/mediaelement/comments{/number}","issue_comment_url":"https://api.github.com/repos/ron666/mediaelement/issues/comments{/number}","contents_url":"https://api.github.com/repos/ron666/mediaelement/contents/{+path}","compare_url":"https://api.github.com/repos/ron666/mediaelement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ron666/mediaelement/merges","archive_url":"https://api.github.com/repos/ron666/mediaelement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ron666/mediaelement/downloads","issues_url":"https://api.github.com/repos/ron666/mediaelement/issues{/number}","pulls_url":"https://api.github.com/repos/ron666/mediaelement/pulls{/number}","milestones_url":"https://api.github.com/repos/ron666/mediaelement/milestones{/number}","notifications_url":"https://api.github.com/repos/ron666/mediaelement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ron666/mediaelement/labels{/name}","releases_url":"https://api.github.com/repos/ron666/mediaelement/releases{/id}","deployments_url":"https://api.github.com/repos/ron666/mediaelement/deployments","created_at":"2016-06-22T02:16:02Z","updated_at":"2016-06-22T02:16:04Z","pushed_at":"2016-07-15T22:10:45Z","git_url":"git://github.com/ron666/mediaelement.git","ssh_url":"git@github.com:ron666/mediaelement.git","clone_url":"https://github.com/ron666/mediaelement.git","svn_url":"https://github.com/ron666/mediaelement","homepage":"http://mediaelementjs.com/","size":192132,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johndyer:master","ref":"master","sha":"e3885a58e482dbc0cd573226de3fb2948f92cc20","user":{"login":"johndyer","id":214227,"avatar_url":"https://avatars.githubusercontent.com/u/214227?v=3","gravatar_id":"","url":"https://api.github.com/users/johndyer","html_url":"https://github.com/johndyer","followers_url":"https://api.github.com/users/johndyer/followers","following_url":"https://api.github.com/users/johndyer/following{/other_user}","gists_url":"https://api.github.com/users/johndyer/gists{/gist_id}","starred_url":"https://api.github.com/users/johndyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndyer/subscriptions","organizations_url":"https://api.github.com/users/johndyer/orgs","repos_url":"https://api.github.com/users/johndyer/repos","events_url":"https://api.github.com/users/johndyer/events{/privacy}","received_events_url":"https://api.github.com/users/johndyer/received_events","type":"User","site_admin":false},"repo":{"id":802006,"name":"mediaelement","full_name":"johndyer/mediaelement","owner":{"login":"johndyer","id":214227,"avatar_url":"https://avatars.githubusercontent.com/u/214227?v=3","gravatar_id":"","url":"https://api.github.com/users/johndyer","html_url":"https://github.com/johndyer","followers_url":"https://api.github.com/users/johndyer/followers","following_url":"https://api.github.com/users/johndyer/following{/other_user}","gists_url":"https://api.github.com/users/johndyer/gists{/gist_id}","starred_url":"https://api.github.com/users/johndyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndyer/subscriptions","organizations_url":"https://api.github.com/users/johndyer/orgs","repos_url":"https://api.github.com/users/johndyer/repos","events_url":"https://api.github.com/users/johndyer/events{/privacy}","received_events_url":"https://api.github.com/users/johndyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johndyer/mediaelement","description":"HTML5 <audio> or <video> player with Flash and Silverlight shims that mimics the HTML5 MediaElement API, enabling a consistent UI in all browsers.","fork":false,"url":"https://api.github.com/repos/johndyer/mediaelement","forks_url":"https://api.github.com/repos/johndyer/mediaelement/forks","keys_url":"https://api.github.com/repos/johndyer/mediaelement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johndyer/mediaelement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johndyer/mediaelement/teams","hooks_url":"https://api.github.com/repos/johndyer/mediaelement/hooks","issue_events_url":"https://api.github.com/repos/johndyer/mediaelement/issues/events{/number}","events_url":"https://api.github.com/repos/johndyer/mediaelement/events","assignees_url":"https://api.github.com/repos/johndyer/mediaelement/assignees{/user}","branches_url":"https://api.github.com/repos/johndyer/mediaelement/branches{/branch}","tags_url":"https://api.github.com/repos/johndyer/mediaelement/tags","blobs_url":"https://api.github.com/repos/johndyer/mediaelement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johndyer/mediaelement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johndyer/mediaelement/git/refs{/sha}","trees_url":"https://api.github.com/repos/johndyer/mediaelement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johndyer/mediaelement/statuses/{sha}","languages_url":"https://api.github.com/repos/johndyer/mediaelement/languages","stargazers_url":"https://api.github.com/repos/johndyer/mediaelement/stargazers","contributors_url":"https://api.github.com/repos/johndyer/mediaelement/contributors","subscribers_url":"https://api.github.com/repos/johndyer/mediaelement/subscribers","subscription_url":"https://api.github.com/repos/johndyer/mediaelement/subscription","commits_url":"https://api.github.com/repos/johndyer/mediaelement/commits{/sha}","git_commits_url":"https://api.github.com/repos/johndyer/mediaelement/git/commits{/sha}","comments_url":"https://api.github.com/repos/johndyer/mediaelement/comments{/number}","issue_comment_url":"https://api.github.com/repos/johndyer/mediaelement/issues/comments{/number}","contents_url":"https://api.github.com/repos/johndyer/mediaelement/contents/{+path}","compare_url":"https://api.github.com/repos/johndyer/mediaelement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johndyer/mediaelement/merges","archive_url":"https://api.github.com/repos/johndyer/mediaelement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johndyer/mediaelement/downloads","issues_url":"https://api.github.com/repos/johndyer/mediaelement/issues{/number}","pulls_url":"https://api.github.com/repos/johndyer/mediaelement/pulls{/number}","milestones_url":"https://api.github.com/repos/johndyer/mediaelement/milestones{/number}","notifications_url":"https://api.github.com/repos/johndyer/mediaelement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johndyer/mediaelement/labels{/name}","releases_url":"https://api.github.com/repos/johndyer/mediaelement/releases{/id}","deployments_url":"https://api.github.com/repos/johndyer/mediaelement/deployments","created_at":"2010-07-28T02:32:56Z","updated_at":"2016-07-17T16:03:03Z","pushed_at":"2016-07-17T21:25:57Z","git_url":"git://github.com/johndyer/mediaelement.git","ssh_url":"git@github.com:johndyer/mediaelement.git","clone_url":"https://github.com/johndyer/mediaelement.git","svn_url":"https://github.com/johndyer/mediaelement","homepage":"http://mediaelementjs.com/","size":199987,"stargazers_count":4092,"watchers_count":4092,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":950,"mirror_url":null,"open_issues_count":765,"forks":950,"open_issues":765,"watchers":4092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773"},"html":{"href":"https://github.com/johndyer/mediaelement/pull/1773"},"issue":{"href":"https://api.github.com/repos/johndyer/mediaelement/issues/1773"},"comments":{"href":"https://api.github.com/repos/johndyer/mediaelement/issues/1773/comments"},"review_comments":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773/comments"},"review_comment":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/1773/commits"},"statuses":{"href":"https://api.github.com/repos/johndyer/mediaelement/statuses/c3b07bccf343e6d162f38ff536836447bace54da"}}}}
{"actor":{"display_login":"johndyer"}}