{"action":"created","comment":{"url":"https://api.github.com/repos/hadley/readr/pulls/comments/66134441","id":66134441,"diff_hunk":"@@ -69,6 +69,12 @@ bool isDouble(const std::string& x, LocaleInfo* pLocale) {\n   return parseDouble(pLocale->decimalMark_, begin, end, res) && begin == end;\n }\n \n+bool isTime(const std::string& x, LocaleInfo* pLocale) {\n+  DateTimeParser parser(pLocale);\n+  parser.setDate(x.c_str());\n+  return parser.parse(pLocale->timeFormat_);","path":"src/CollectorGuess.cpp","position":7,"original_position":7,"commit_id":"05326fc3f9c44452cd4cd82fb18c18067ab45940","original_commit_id":"05326fc3f9c44452cd4cd82fb18c18067ab45940","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"body":"I think `parseTime()` is too flexible actually. Using it the following tests fail\r\n\r\n``` r\r\ncollector_guess(\"0001\")\r\n#> [1] \"time\"\r\ncollector_guess(\"00010203\")\r\n#> [1] \"time\"\r\n```","created_at":"2016-06-07T19:14:35Z","updated_at":"2016-06-07T19:14:35Z","html_url":"https://github.com/hadley/readr/pull/424#discussion_r66134441","pull_request_url":"https://api.github.com/repos/hadley/readr/pulls/424","_links":{"self":{"href":"https://api.github.com/repos/hadley/readr/pulls/comments/66134441"},"html":{"href":"https://github.com/hadley/readr/pull/424#discussion_r66134441"},"pull_request":{"href":"https://api.github.com/repos/hadley/readr/pulls/424"}}},"pull_request":{"url":"https://api.github.com/repos/hadley/readr/pulls/424","id":72929926,"html_url":"https://github.com/hadley/readr/pull/424","diff_url":"https://github.com/hadley/readr/pull/424.diff","patch_url":"https://github.com/hadley/readr/pull/424.patch","issue_url":"https://api.github.com/repos/hadley/readr/issues/424","number":424,"state":"open","locked":false,"title":"collector_guess now guesses time formats as well","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"body":"One thing to note with this is the default time format is `%H:%M`, so the examples in the issue are still going to be guessed as dates unless they change the `time_format` in the locale (as is done in the tests).\r\n\r\nI don't know if we should change the default time format to `%H:%M:%S` or not.\r\n\r\nFixes #384 ","created_at":"2016-06-07T19:02:17Z","updated_at":"2016-06-07T19:14:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f3e554047ca7f230e0f38d8286a39973df51425","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hadley/readr/pulls/424/commits","review_comments_url":"https://api.github.com/repos/hadley/readr/pulls/424/comments","review_comment_url":"https://api.github.com/repos/hadley/readr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hadley/readr/issues/424/comments","statuses_url":"https://api.github.com/repos/hadley/readr/statuses/05326fc3f9c44452cd4cd82fb18c18067ab45940","head":{"label":"jimhester:feature/issue384","ref":"feature/issue384","sha":"05326fc3f9c44452cd4cd82fb18c18067ab45940","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"repo":{"id":60553356,"name":"readr","full_name":"jimhester/readr","owner":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimhester/readr","description":"Read flat files (csv, tsv, fwf) into R","fork":true,"url":"https://api.github.com/repos/jimhester/readr","forks_url":"https://api.github.com/repos/jimhester/readr/forks","keys_url":"https://api.github.com/repos/jimhester/readr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimhester/readr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimhester/readr/teams","hooks_url":"https://api.github.com/repos/jimhester/readr/hooks","issue_events_url":"https://api.github.com/repos/jimhester/readr/issues/events{/number}","events_url":"https://api.github.com/repos/jimhester/readr/events","assignees_url":"https://api.github.com/repos/jimhester/readr/assignees{/user}","branches_url":"https://api.github.com/repos/jimhester/readr/branches{/branch}","tags_url":"https://api.github.com/repos/jimhester/readr/tags","blobs_url":"https://api.github.com/repos/jimhester/readr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimhester/readr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimhester/readr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimhester/readr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimhester/readr/statuses/{sha}","languages_url":"https://api.github.com/repos/jimhester/readr/languages","stargazers_url":"https://api.github.com/repos/jimhester/readr/stargazers","contributors_url":"https://api.github.com/repos/jimhester/readr/contributors","subscribers_url":"https://api.github.com/repos/jimhester/readr/subscribers","subscription_url":"https://api.github.com/repos/jimhester/readr/subscription","commits_url":"https://api.github.com/repos/jimhester/readr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimhester/readr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimhester/readr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimhester/readr/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimhester/readr/contents/{+path}","compare_url":"https://api.github.com/repos/jimhester/readr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimhester/readr/merges","archive_url":"https://api.github.com/repos/jimhester/readr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimhester/readr/downloads","issues_url":"https://api.github.com/repos/jimhester/readr/issues{/number}","pulls_url":"https://api.github.com/repos/jimhester/readr/pulls{/number}","milestones_url":"https://api.github.com/repos/jimhester/readr/milestones{/number}","notifications_url":"https://api.github.com/repos/jimhester/readr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimhester/readr/labels{/name}","releases_url":"https://api.github.com/repos/jimhester/readr/releases{/id}","deployments_url":"https://api.github.com/repos/jimhester/readr/deployments","created_at":"2016-06-06T19:01:13Z","updated_at":"2016-06-06T19:01:14Z","pushed_at":"2016-06-07T19:10:21Z","git_url":"git://github.com/jimhester/readr.git","ssh_url":"git@github.com:jimhester/readr.git","clone_url":"https://github.com/jimhester/readr.git","svn_url":"https://github.com/jimhester/readr","homepage":"","size":1177,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hadley:master","ref":"master","sha":"6e09e41b64e54d9aaccf7a34dcc9ff44f2e71b06","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"repo":{"id":11663980,"name":"readr","full_name":"hadley/readr","owner":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hadley/readr","description":"Read flat files (csv, tsv, fwf) into R","fork":false,"url":"https://api.github.com/repos/hadley/readr","forks_url":"https://api.github.com/repos/hadley/readr/forks","keys_url":"https://api.github.com/repos/hadley/readr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hadley/readr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hadley/readr/teams","hooks_url":"https://api.github.com/repos/hadley/readr/hooks","issue_events_url":"https://api.github.com/repos/hadley/readr/issues/events{/number}","events_url":"https://api.github.com/repos/hadley/readr/events","assignees_url":"https://api.github.com/repos/hadley/readr/assignees{/user}","branches_url":"https://api.github.com/repos/hadley/readr/branches{/branch}","tags_url":"https://api.github.com/repos/hadley/readr/tags","blobs_url":"https://api.github.com/repos/hadley/readr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hadley/readr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hadley/readr/git/refs{/sha}","trees_url":"https://api.github.com/repos/hadley/readr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hadley/readr/statuses/{sha}","languages_url":"https://api.github.com/repos/hadley/readr/languages","stargazers_url":"https://api.github.com/repos/hadley/readr/stargazers","contributors_url":"https://api.github.com/repos/hadley/readr/contributors","subscribers_url":"https://api.github.com/repos/hadley/readr/subscribers","subscription_url":"https://api.github.com/repos/hadley/readr/subscription","commits_url":"https://api.github.com/repos/hadley/readr/commits{/sha}","git_commits_url":"https://api.github.com/repos/hadley/readr/git/commits{/sha}","comments_url":"https://api.github.com/repos/hadley/readr/comments{/number}","issue_comment_url":"https://api.github.com/repos/hadley/readr/issues/comments{/number}","contents_url":"https://api.github.com/repos/hadley/readr/contents/{+path}","compare_url":"https://api.github.com/repos/hadley/readr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hadley/readr/merges","archive_url":"https://api.github.com/repos/hadley/readr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hadley/readr/downloads","issues_url":"https://api.github.com/repos/hadley/readr/issues{/number}","pulls_url":"https://api.github.com/repos/hadley/readr/pulls{/number}","milestones_url":"https://api.github.com/repos/hadley/readr/milestones{/number}","notifications_url":"https://api.github.com/repos/hadley/readr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hadley/readr/labels{/name}","releases_url":"https://api.github.com/repos/hadley/readr/releases{/id}","deployments_url":"https://api.github.com/repos/hadley/readr/deployments","created_at":"2013-07-25T15:28:22Z","updated_at":"2016-06-07T04:03:54Z","pushed_at":"2016-06-07T19:10:21Z","git_url":"git://github.com/hadley/readr.git","ssh_url":"git@github.com:hadley/readr.git","clone_url":"https://github.com/hadley/readr.git","svn_url":"https://github.com/hadley/readr","homepage":"","size":1220,"stargazers_count":396,"watchers_count":396,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":50,"forks":86,"open_issues":50,"watchers":396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hadley/readr/pulls/424"},"html":{"href":"https://github.com/hadley/readr/pull/424"},"issue":{"href":"https://api.github.com/repos/hadley/readr/issues/424"},"comments":{"href":"https://api.github.com/repos/hadley/readr/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/hadley/readr/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/hadley/readr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hadley/readr/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/hadley/readr/statuses/05326fc3f9c44452cd4cd82fb18c18067ab45940"}}}}
{"actor":{"display_login":"jimhester"}}