{"action":"created","comment":{"url":"https://api.github.com/repos/mike1808/splash/pulls/comments/66141122","id":66141122,"diff_hunk":"@@ -637,6 +638,26 @@ def runjs(self, js_source, handle_errors=True):\n             result_protection=False\n         )\n \n+    def with_timeout(self, run_coro, timeout, callback, errback):\n+        timer = QTimer(self)\n+        timer.setSingleShot(True)\n+\n+        def timer_callback():\n+            print(\"timer is over!\")\n+\n+        timer.timeout.connect(timer_callback)\n+\n+        def coro_success(result):\n+            if timer.isActive():\n+                timer.stop()\n+\n+            callback(result)\n+\n+        run_coro(coro_success, errback)()\n+\n+        timer.start(timeout)\n+        self._active_timers.add(timer)","path":"splash/browser_tab.py","position":30,"original_position":30,"commit_id":"014b6f7c0d63ee24eede20ca7eb9289adab9a928","original_commit_id":"014b6f7c0d63ee24eede20ca7eb9289adab9a928","user":{"login":"kmike","id":107893,"avatar_url":"https://avatars.githubusercontent.com/u/107893?v=3","gravatar_id":"","url":"https://api.github.com/users/kmike","html_url":"https://github.com/kmike","followers_url":"https://api.github.com/users/kmike/followers","following_url":"https://api.github.com/users/kmike/following{/other_user}","gists_url":"https://api.github.com/users/kmike/gists{/gist_id}","starred_url":"https://api.github.com/users/kmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmike/subscriptions","organizations_url":"https://api.github.com/users/kmike/orgs","repos_url":"https://api.github.com/users/kmike/repos","events_url":"https://api.github.com/users/kmike/events{/privacy}","received_events_url":"https://api.github.com/users/kmike/received_events","type":"User","site_admin":false},"body":"who removes timer from `self._active_timers`?","created_at":"2016-06-07T19:57:58Z","updated_at":"2016-06-07T19:57:58Z","html_url":"https://github.com/mike1808/splash/pull/1#discussion_r66141122","pull_request_url":"https://api.github.com/repos/mike1808/splash/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mike1808/splash/pulls/comments/66141122"},"html":{"href":"https://github.com/mike1808/splash/pull/1#discussion_r66141122"},"pull_request":{"href":"https://api.github.com/repos/mike1808/splash/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mike1808/splash/pulls/1","id":72928877,"html_url":"https://github.com/mike1808/splash/pull/1","diff_url":"https://github.com/mike1808/splash/pull/1.diff","patch_url":"https://github.com/mike1808/splash/pull/1.patch","issue_url":"https://api.github.com/repos/mike1808/splash/issues/1","number":1,"state":"open","locked":false,"title":"add initial implementation of with_timeout API","user":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-07T18:55:40Z","updated_at":"2016-06-07T19:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1bdaed80f7fa38cd4445c296781392f35cd26bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mike1808/splash/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mike1808/splash/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mike1808/splash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mike1808/splash/issues/1/comments","statuses_url":"https://api.github.com/repos/mike1808/splash/statuses/014b6f7c0d63ee24eede20ca7eb9289adab9a928","head":{"label":"mike1808:with-timeout-api","ref":"with-timeout-api","sha":"014b6f7c0d63ee24eede20ca7eb9289adab9a928","user":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"repo":{"id":54326662,"name":"splash","full_name":"mike1808/splash","owner":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike1808/splash","description":"Lightweight, scriptable browser as a service with an HTTP API","fork":true,"url":"https://api.github.com/repos/mike1808/splash","forks_url":"https://api.github.com/repos/mike1808/splash/forks","keys_url":"https://api.github.com/repos/mike1808/splash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike1808/splash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike1808/splash/teams","hooks_url":"https://api.github.com/repos/mike1808/splash/hooks","issue_events_url":"https://api.github.com/repos/mike1808/splash/issues/events{/number}","events_url":"https://api.github.com/repos/mike1808/splash/events","assignees_url":"https://api.github.com/repos/mike1808/splash/assignees{/user}","branches_url":"https://api.github.com/repos/mike1808/splash/branches{/branch}","tags_url":"https://api.github.com/repos/mike1808/splash/tags","blobs_url":"https://api.github.com/repos/mike1808/splash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike1808/splash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike1808/splash/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike1808/splash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike1808/splash/statuses/{sha}","languages_url":"https://api.github.com/repos/mike1808/splash/languages","stargazers_url":"https://api.github.com/repos/mike1808/splash/stargazers","contributors_url":"https://api.github.com/repos/mike1808/splash/contributors","subscribers_url":"https://api.github.com/repos/mike1808/splash/subscribers","subscription_url":"https://api.github.com/repos/mike1808/splash/subscription","commits_url":"https://api.github.com/repos/mike1808/splash/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike1808/splash/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike1808/splash/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike1808/splash/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike1808/splash/contents/{+path}","compare_url":"https://api.github.com/repos/mike1808/splash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike1808/splash/merges","archive_url":"https://api.github.com/repos/mike1808/splash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike1808/splash/downloads","issues_url":"https://api.github.com/repos/mike1808/splash/issues{/number}","pulls_url":"https://api.github.com/repos/mike1808/splash/pulls{/number}","milestones_url":"https://api.github.com/repos/mike1808/splash/milestones{/number}","notifications_url":"https://api.github.com/repos/mike1808/splash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike1808/splash/labels{/name}","releases_url":"https://api.github.com/repos/mike1808/splash/releases{/id}","deployments_url":"https://api.github.com/repos/mike1808/splash/deployments","created_at":"2016-03-20T16:00:44Z","updated_at":"2016-03-20T16:00:45Z","pushed_at":"2016-06-07T19:03:32Z","git_url":"git://github.com/mike1808/splash.git","ssh_url":"git@github.com:mike1808/splash.git","clone_url":"https://github.com/mike1808/splash.git","svn_url":"https://github.com/mike1808/splash","homepage":"","size":2817,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mike1808:master","ref":"master","sha":"ad656e3ee22f7b3161279777cb7cc0d12a47d786","user":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"repo":{"id":54326662,"name":"splash","full_name":"mike1808/splash","owner":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike1808/splash","description":"Lightweight, scriptable browser as a service with an HTTP API","fork":true,"url":"https://api.github.com/repos/mike1808/splash","forks_url":"https://api.github.com/repos/mike1808/splash/forks","keys_url":"https://api.github.com/repos/mike1808/splash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike1808/splash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike1808/splash/teams","hooks_url":"https://api.github.com/repos/mike1808/splash/hooks","issue_events_url":"https://api.github.com/repos/mike1808/splash/issues/events{/number}","events_url":"https://api.github.com/repos/mike1808/splash/events","assignees_url":"https://api.github.com/repos/mike1808/splash/assignees{/user}","branches_url":"https://api.github.com/repos/mike1808/splash/branches{/branch}","tags_url":"https://api.github.com/repos/mike1808/splash/tags","blobs_url":"https://api.github.com/repos/mike1808/splash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike1808/splash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike1808/splash/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike1808/splash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike1808/splash/statuses/{sha}","languages_url":"https://api.github.com/repos/mike1808/splash/languages","stargazers_url":"https://api.github.com/repos/mike1808/splash/stargazers","contributors_url":"https://api.github.com/repos/mike1808/splash/contributors","subscribers_url":"https://api.github.com/repos/mike1808/splash/subscribers","subscription_url":"https://api.github.com/repos/mike1808/splash/subscription","commits_url":"https://api.github.com/repos/mike1808/splash/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike1808/splash/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike1808/splash/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike1808/splash/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike1808/splash/contents/{+path}","compare_url":"https://api.github.com/repos/mike1808/splash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike1808/splash/merges","archive_url":"https://api.github.com/repos/mike1808/splash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike1808/splash/downloads","issues_url":"https://api.github.com/repos/mike1808/splash/issues{/number}","pulls_url":"https://api.github.com/repos/mike1808/splash/pulls{/number}","milestones_url":"https://api.github.com/repos/mike1808/splash/milestones{/number}","notifications_url":"https://api.github.com/repos/mike1808/splash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike1808/splash/labels{/name}","releases_url":"https://api.github.com/repos/mike1808/splash/releases{/id}","deployments_url":"https://api.github.com/repos/mike1808/splash/deployments","created_at":"2016-03-20T16:00:44Z","updated_at":"2016-03-20T16:00:45Z","pushed_at":"2016-06-07T19:03:32Z","git_url":"git://github.com/mike1808/splash.git","ssh_url":"git@github.com:mike1808/splash.git","clone_url":"https://github.com/mike1808/splash.git","svn_url":"https://github.com/mike1808/splash","homepage":"","size":2817,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mike1808/splash/pulls/1"},"html":{"href":"https://github.com/mike1808/splash/pull/1"},"issue":{"href":"https://api.github.com/repos/mike1808/splash/issues/1"},"comments":{"href":"https://api.github.com/repos/mike1808/splash/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mike1808/splash/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mike1808/splash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mike1808/splash/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mike1808/splash/statuses/014b6f7c0d63ee24eede20ca7eb9289adab9a928"}}}}
{"actor":{"display_login":"kmike"}}