{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/navstar/pulls/comments/89947097","pull_request_review_id":10474294,"id":89947097,"diff_hunk":"@@ -106,52 +107,61 @@ terminate(_Reason, _State, _Data) ->\n code_change(_OldVsn, OldState, OldData, _Extra) ->\n     {ok, OldState, OldData}.\n \n-%%-------------------------------------------------------------------------------------------------------------\n+%%--------------------------------------------------------------------------------\n %% State transition\n-%% \n+%%-------------------------------------------------------------------------------- \n %%                                                                lashup_event\n %%                                                                  +------+\n %%                                                                  |      |\n-%%  +--------------+              +----------------+              +-+--------+                +-------------+\n-%%  |              |              |                |              |          |                |             |\n-%%  |              | lashup_event |                | lashup event |          |   timeout      |             |\n-%%  | unconfigured +------------> |    applying    +------------> | batching +--------------> | configuring |\n-%%  |              |              |  first_config  |              |          |                |             |\n-%%  |              |              |                |              |          | <--------------+             |\n-%%  |              |              |                |              |          |  lashup_event  |             |\n-%%  +--------------+              +----------------+              +----------+                +-------------+\n+%%  +--------------+              +----------------+              +-+--------+\n+%%  |              |              |                |              |          |\n+%%  |              | lashup_event |                | lashup event |          |\n+%%  | unconfigured +------------> |  configuring   +------------> | batching |\n+%%  |              |              |                |              |          |\n+%%  |              |              |                | <------------|          |\n+%%  |              |              |                |   timeout    |          |\n+%%  +--------------+              +----------------+              +----------+\n %%\n-%%--------------------------------------------------------------------------------------------------------------\n+%%--------------------------------------------------------------------------------\n \n unconfigured(info, EventContent, Data) ->\n-    {next_state, applying_first_config, Data, {next_event, internal, EventContent}}.\n+    {next_state, configuring, Data, {next_event, internal, EventContent}}.\n \n-applying_first_config(internal, \n-            _EventContent = {lashup_kv_events, Event = #{key := [navstar, overlay, Subnet], ref := Ref}},\n-            _Data = #data{ref = Ref}) when is_tuple(Subnet), tuple_size(Subnet) == 2 ->\n-    lager:info(\"Applying first config: ~p~n\", [Event]),\n-    navstar_overlay_configure:start_link(reply, Event),\n+configuring(internal, {lashup_kv_events, NewEvent = #{key := [navstar, overlay, Subnet], ref := Ref}},\n+            #data{ref = Ref, events = OldEvent}) when is_tuple(Subnet), tuple_size(Subnet) == 2 ->\n+    DeltaEvent = get_delta_event(NewEvent, OldEvent),","path":"apps/navstar_overlay/src/navstar_overlay_lashup_kv_listener.erl","position":65,"original_position":65,"commit_id":"4d7a3c50550474f73b3dbf56256bb12c367239ae","original_commit_id":"4d7a3c50550474f73b3dbf56256bb12c367239ae","user":{"login":"GoelDeepak","id":1878114,"avatar_url":"https://avatars.githubusercontent.com/u/1878114?v=3","gravatar_id":"","url":"https://api.github.com/users/GoelDeepak","html_url":"https://github.com/GoelDeepak","followers_url":"https://api.github.com/users/GoelDeepak/followers","following_url":"https://api.github.com/users/GoelDeepak/following{/other_user}","gists_url":"https://api.github.com/users/GoelDeepak/gists{/gist_id}","starred_url":"https://api.github.com/users/GoelDeepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoelDeepak/subscriptions","organizations_url":"https://api.github.com/users/GoelDeepak/orgs","repos_url":"https://api.github.com/users/GoelDeepak/repos","events_url":"https://api.github.com/users/GoelDeepak/events{/privacy}","received_events_url":"https://api.github.com/users/GoelDeepak/received_events","type":"User","site_admin":false},"body":"We may not be able to calculate delta using ingest_update because of batching. navstar_overlay reference of old value might be different from lashup_kv old value.","created_at":"2016-11-29T06:18:00Z","updated_at":"2016-11-29T06:18:00Z","html_url":"https://github.com/dcos/navstar/pull/33#discussion_r89947097","pull_request_url":"https://api.github.com/repos/dcos/navstar/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/dcos/navstar/pulls/comments/89947097"},"html":{"href":"https://github.com/dcos/navstar/pull/33#discussion_r89947097"},"pull_request":{"href":"https://api.github.com/repos/dcos/navstar/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/navstar/pulls/33","id":95101101,"html_url":"https://github.com/dcos/navstar/pull/33","diff_url":"https://github.com/dcos/navstar/pull/33.diff","patch_url":"https://github.com/dcos/navstar/pull/33.patch","issue_url":"https://api.github.com/repos/dcos/navstar/issues/33","number":33,"state":"open","locked":false,"title":"Overlay Optimization","user":{"login":"GoelDeepak","id":1878114,"avatar_url":"https://avatars.githubusercontent.com/u/1878114?v=3","gravatar_id":"","url":"https://api.github.com/users/GoelDeepak","html_url":"https://github.com/GoelDeepak","followers_url":"https://api.github.com/users/GoelDeepak/followers","following_url":"https://api.github.com/users/GoelDeepak/following{/other_user}","gists_url":"https://api.github.com/users/GoelDeepak/gists{/gist_id}","starred_url":"https://api.github.com/users/GoelDeepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoelDeepak/subscriptions","organizations_url":"https://api.github.com/users/GoelDeepak/orgs","repos_url":"https://api.github.com/users/GoelDeepak/repos","events_url":"https://api.github.com/users/GoelDeepak/events{/privacy}","received_events_url":"https://api.github.com/users/GoelDeepak/received_events","type":"User","site_admin":false},"body":"This patch changes the way overlay configuration is applied. Instead of repeatedly applying full configuration it applies only the delta.","created_at":"2016-11-24T00:42:59Z","updated_at":"2016-11-29T06:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a9aba136ce9f8ef0b43166f1ef666ae802eb03","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/navstar/pulls/33/commits","review_comments_url":"https://api.github.com/repos/dcos/navstar/pulls/33/comments","review_comment_url":"https://api.github.com/repos/dcos/navstar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/navstar/issues/33/comments","statuses_url":"https://api.github.com/repos/dcos/navstar/statuses/4d7a3c50550474f73b3dbf56256bb12c367239ae","head":{"label":"GoelDeepak:dev","ref":"dev","sha":"4d7a3c50550474f73b3dbf56256bb12c367239ae","user":{"login":"GoelDeepak","id":1878114,"avatar_url":"https://avatars.githubusercontent.com/u/1878114?v=3","gravatar_id":"","url":"https://api.github.com/users/GoelDeepak","html_url":"https://github.com/GoelDeepak","followers_url":"https://api.github.com/users/GoelDeepak/followers","following_url":"https://api.github.com/users/GoelDeepak/following{/other_user}","gists_url":"https://api.github.com/users/GoelDeepak/gists{/gist_id}","starred_url":"https://api.github.com/users/GoelDeepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoelDeepak/subscriptions","organizations_url":"https://api.github.com/users/GoelDeepak/orgs","repos_url":"https://api.github.com/users/GoelDeepak/repos","events_url":"https://api.github.com/users/GoelDeepak/events{/privacy}","received_events_url":"https://api.github.com/users/GoelDeepak/received_events","type":"User","site_admin":false},"repo":{"id":69299745,"name":"navstar","full_name":"GoelDeepak/navstar","owner":{"login":"GoelDeepak","id":1878114,"avatar_url":"https://avatars.githubusercontent.com/u/1878114?v=3","gravatar_id":"","url":"https://api.github.com/users/GoelDeepak","html_url":"https://github.com/GoelDeepak","followers_url":"https://api.github.com/users/GoelDeepak/followers","following_url":"https://api.github.com/users/GoelDeepak/following{/other_user}","gists_url":"https://api.github.com/users/GoelDeepak/gists{/gist_id}","starred_url":"https://api.github.com/users/GoelDeepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoelDeepak/subscriptions","organizations_url":"https://api.github.com/users/GoelDeepak/orgs","repos_url":"https://api.github.com/users/GoelDeepak/repos","events_url":"https://api.github.com/users/GoelDeepak/events{/privacy}","received_events_url":"https://api.github.com/users/GoelDeepak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GoelDeepak/navstar","description":null,"fork":true,"url":"https://api.github.com/repos/GoelDeepak/navstar","forks_url":"https://api.github.com/repos/GoelDeepak/navstar/forks","keys_url":"https://api.github.com/repos/GoelDeepak/navstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoelDeepak/navstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoelDeepak/navstar/teams","hooks_url":"https://api.github.com/repos/GoelDeepak/navstar/hooks","issue_events_url":"https://api.github.com/repos/GoelDeepak/navstar/issues/events{/number}","events_url":"https://api.github.com/repos/GoelDeepak/navstar/events","assignees_url":"https://api.github.com/repos/GoelDeepak/navstar/assignees{/user}","branches_url":"https://api.github.com/repos/GoelDeepak/navstar/branches{/branch}","tags_url":"https://api.github.com/repos/GoelDeepak/navstar/tags","blobs_url":"https://api.github.com/repos/GoelDeepak/navstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoelDeepak/navstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoelDeepak/navstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoelDeepak/navstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoelDeepak/navstar/statuses/{sha}","languages_url":"https://api.github.com/repos/GoelDeepak/navstar/languages","stargazers_url":"https://api.github.com/repos/GoelDeepak/navstar/stargazers","contributors_url":"https://api.github.com/repos/GoelDeepak/navstar/contributors","subscribers_url":"https://api.github.com/repos/GoelDeepak/navstar/subscribers","subscription_url":"https://api.github.com/repos/GoelDeepak/navstar/subscription","commits_url":"https://api.github.com/repos/GoelDeepak/navstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoelDeepak/navstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoelDeepak/navstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoelDeepak/navstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoelDeepak/navstar/contents/{+path}","compare_url":"https://api.github.com/repos/GoelDeepak/navstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoelDeepak/navstar/merges","archive_url":"https://api.github.com/repos/GoelDeepak/navstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoelDeepak/navstar/downloads","issues_url":"https://api.github.com/repos/GoelDeepak/navstar/issues{/number}","pulls_url":"https://api.github.com/repos/GoelDeepak/navstar/pulls{/number}","milestones_url":"https://api.github.com/repos/GoelDeepak/navstar/milestones{/number}","notifications_url":"https://api.github.com/repos/GoelDeepak/navstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoelDeepak/navstar/labels{/name}","releases_url":"https://api.github.com/repos/GoelDeepak/navstar/releases{/id}","deployments_url":"https://api.github.com/repos/GoelDeepak/navstar/deployments","created_at":"2016-09-26T23:01:26Z","updated_at":"2016-09-26T23:01:27Z","pushed_at":"2016-11-25T06:05:35Z","git_url":"git://github.com/GoelDeepak/navstar.git","ssh_url":"git@github.com:GoelDeepak/navstar.git","clone_url":"https://github.com/GoelDeepak/navstar.git","svn_url":"https://github.com/GoelDeepak/navstar","homepage":null,"size":2766,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"70102cf1550aa3043d61fd6ff28ad46610885c39","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":59186043,"name":"navstar","full_name":"dcos/navstar","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/navstar","description":null,"fork":false,"url":"https://api.github.com/repos/dcos/navstar","forks_url":"https://api.github.com/repos/dcos/navstar/forks","keys_url":"https://api.github.com/repos/dcos/navstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/navstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/navstar/teams","hooks_url":"https://api.github.com/repos/dcos/navstar/hooks","issue_events_url":"https://api.github.com/repos/dcos/navstar/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/navstar/events","assignees_url":"https://api.github.com/repos/dcos/navstar/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/navstar/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/navstar/tags","blobs_url":"https://api.github.com/repos/dcos/navstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/navstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/navstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/navstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/navstar/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/navstar/languages","stargazers_url":"https://api.github.com/repos/dcos/navstar/stargazers","contributors_url":"https://api.github.com/repos/dcos/navstar/contributors","subscribers_url":"https://api.github.com/repos/dcos/navstar/subscribers","subscription_url":"https://api.github.com/repos/dcos/navstar/subscription","commits_url":"https://api.github.com/repos/dcos/navstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/navstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/navstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/navstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/navstar/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/navstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/navstar/merges","archive_url":"https://api.github.com/repos/dcos/navstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/navstar/downloads","issues_url":"https://api.github.com/repos/dcos/navstar/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/navstar/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/navstar/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/navstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/navstar/labels{/name}","releases_url":"https://api.github.com/repos/dcos/navstar/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/navstar/deployments","created_at":"2016-05-19T07:59:25Z","updated_at":"2016-11-07T05:35:46Z","pushed_at":"2016-11-25T06:05:35Z","git_url":"git://github.com/dcos/navstar.git","ssh_url":"git@github.com:dcos/navstar.git","clone_url":"https://github.com/dcos/navstar.git","svn_url":"https://github.com/dcos/navstar","homepage":null,"size":2780,"stargazers_count":5,"watchers_count":5,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/navstar/pulls/33"},"html":{"href":"https://github.com/dcos/navstar/pull/33"},"issue":{"href":"https://api.github.com/repos/dcos/navstar/issues/33"},"comments":{"href":"https://api.github.com/repos/dcos/navstar/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/navstar/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/navstar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/navstar/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/navstar/statuses/4d7a3c50550474f73b3dbf56256bb12c367239ae"}}}}
{"actor":{"display_login":"GoelDeepak"}}