{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/autorest/pulls/comments/69233957","id":69233957,"diff_hunk":"@@ -58,6 +66,78 @@ public override void NormalizeClientModel(ServiceClient serviceClient)\n             AzureExtensions.NormalizeAzureClientModel(serviceClient, Settings, CodeNamer);\n             CorrectFilterParameters(serviceClient);\n             base.NormalizeClientModel(serviceClient);\n+            AddRubyPageableMethod(serviceClient);\n+            ApplyPagination(serviceClient);\n+\n+        }\n+\n+        /// <summary>\n+        /// Adds method to use for autopagination\n+        /// </summary>\n+        /// <param name=\"serviceClient\">The service client.</param>\n+        private void AddRubyPageableMethod(ServiceClient serviceClient)\n+        {\n+            if (serviceClient == null)\n+            {\n+                throw new ArgumentNullException(\"serviceClient\");","path":"AutoRest/Generators/Ruby/Azure.Ruby/AzureRubyCodeGenerator.cs","position":52,"original_position":52,"commit_id":"620da212ab34195cb5cd86c083a397498266d042","original_commit_id":"620da212ab34195cb5cd86c083a397498266d042","user":{"login":"vishrutshah","id":8782776,"avatar_url":"https://avatars.githubusercontent.com/u/8782776?v=3","gravatar_id":"","url":"https://api.github.com/users/vishrutshah","html_url":"https://github.com/vishrutshah","followers_url":"https://api.github.com/users/vishrutshah/followers","following_url":"https://api.github.com/users/vishrutshah/following{/other_user}","gists_url":"https://api.github.com/users/vishrutshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vishrutshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishrutshah/subscriptions","organizations_url":"https://api.github.com/users/vishrutshah/orgs","repos_url":"https://api.github.com/users/vishrutshah/repos","events_url":"https://api.github.com/users/vishrutshah/events{/privacy}","received_events_url":"https://api.github.com/users/vishrutshah/received_events","type":"User","site_admin":false},"body":"In general my preferece'd be to use Nameof operator instead of string like throw new ArgumentNullException(nameof(serviceClient)); so that just incase we change the name of parameter it'll force us to change this line as well. ","created_at":"2016-07-01T00:51:49Z","updated_at":"2016-07-01T00:51:49Z","html_url":"https://github.com/Azure/autorest/pull/1211#discussion_r69233957","pull_request_url":"https://api.github.com/repos/Azure/autorest/pulls/1211","_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments/69233957"},"html":{"href":"https://github.com/Azure/autorest/pull/1211#discussion_r69233957"},"pull_request":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1211"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/autorest/pulls/1211","id":75698370,"html_url":"https://github.com/Azure/autorest/pull/1211","diff_url":"https://github.com/Azure/autorest/pull/1211.diff","patch_url":"https://github.com/Azure/autorest/pull/1211.patch","issue_url":"https://api.github.com/repos/Azure/autorest/issues/1211","number":1211,"state":"open","locked":false,"title":"[In- review] Improving pageable extension adding autopagination","user":{"login":"veronicagg","id":17714137,"avatar_url":"https://avatars.githubusercontent.com/u/17714137?v=3","gravatar_id":"","url":"https://api.github.com/users/veronicagg","html_url":"https://github.com/veronicagg","followers_url":"https://api.github.com/users/veronicagg/followers","following_url":"https://api.github.com/users/veronicagg/following{/other_user}","gists_url":"https://api.github.com/users/veronicagg/gists{/gist_id}","starred_url":"https://api.github.com/users/veronicagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veronicagg/subscriptions","organizations_url":"https://api.github.com/users/veronicagg/orgs","repos_url":"https://api.github.com/users/veronicagg/repos","events_url":"https://api.github.com/users/veronicagg/events{/privacy}","received_events_url":"https://api.github.com/users/veronicagg/received_events","type":"User","site_admin":false},"body":"Updating x-ms-pageable extension to add auto-pagination by default and \"as_lazy\" methods to iterate over pages of results.","created_at":"2016-06-29T18:32:13Z","updated_at":"2016-07-01T00:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7f9368bf01c2609100b69579ecaae6181dbe72b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/autorest/pulls/1211/commits","review_comments_url":"https://api.github.com/repos/Azure/autorest/pulls/1211/comments","review_comment_url":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/autorest/issues/1211/comments","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/620da212ab34195cb5cd86c083a397498266d042","head":{"label":"veronicagg:paging","ref":"paging","sha":"620da212ab34195cb5cd86c083a397498266d042","user":{"login":"veronicagg","id":17714137,"avatar_url":"https://avatars.githubusercontent.com/u/17714137?v=3","gravatar_id":"","url":"https://api.github.com/users/veronicagg","html_url":"https://github.com/veronicagg","followers_url":"https://api.github.com/users/veronicagg/followers","following_url":"https://api.github.com/users/veronicagg/following{/other_user}","gists_url":"https://api.github.com/users/veronicagg/gists{/gist_id}","starred_url":"https://api.github.com/users/veronicagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veronicagg/subscriptions","organizations_url":"https://api.github.com/users/veronicagg/orgs","repos_url":"https://api.github.com/users/veronicagg/repos","events_url":"https://api.github.com/users/veronicagg/events{/privacy}","received_events_url":"https://api.github.com/users/veronicagg/received_events","type":"User","site_admin":false},"repo":{"id":56541703,"name":"autorest","full_name":"veronicagg/autorest","owner":{"login":"veronicagg","id":17714137,"avatar_url":"https://avatars.githubusercontent.com/u/17714137?v=3","gravatar_id":"","url":"https://api.github.com/users/veronicagg","html_url":"https://github.com/veronicagg","followers_url":"https://api.github.com/users/veronicagg/followers","following_url":"https://api.github.com/users/veronicagg/following{/other_user}","gists_url":"https://api.github.com/users/veronicagg/gists{/gist_id}","starred_url":"https://api.github.com/users/veronicagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veronicagg/subscriptions","organizations_url":"https://api.github.com/users/veronicagg/orgs","repos_url":"https://api.github.com/users/veronicagg/repos","events_url":"https://api.github.com/users/veronicagg/events{/privacy}","received_events_url":"https://api.github.com/users/veronicagg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/veronicagg/autorest","description":"","fork":true,"url":"https://api.github.com/repos/veronicagg/autorest","forks_url":"https://api.github.com/repos/veronicagg/autorest/forks","keys_url":"https://api.github.com/repos/veronicagg/autorest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/veronicagg/autorest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/veronicagg/autorest/teams","hooks_url":"https://api.github.com/repos/veronicagg/autorest/hooks","issue_events_url":"https://api.github.com/repos/veronicagg/autorest/issues/events{/number}","events_url":"https://api.github.com/repos/veronicagg/autorest/events","assignees_url":"https://api.github.com/repos/veronicagg/autorest/assignees{/user}","branches_url":"https://api.github.com/repos/veronicagg/autorest/branches{/branch}","tags_url":"https://api.github.com/repos/veronicagg/autorest/tags","blobs_url":"https://api.github.com/repos/veronicagg/autorest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/veronicagg/autorest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/veronicagg/autorest/git/refs{/sha}","trees_url":"https://api.github.com/repos/veronicagg/autorest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/veronicagg/autorest/statuses/{sha}","languages_url":"https://api.github.com/repos/veronicagg/autorest/languages","stargazers_url":"https://api.github.com/repos/veronicagg/autorest/stargazers","contributors_url":"https://api.github.com/repos/veronicagg/autorest/contributors","subscribers_url":"https://api.github.com/repos/veronicagg/autorest/subscribers","subscription_url":"https://api.github.com/repos/veronicagg/autorest/subscription","commits_url":"https://api.github.com/repos/veronicagg/autorest/commits{/sha}","git_commits_url":"https://api.github.com/repos/veronicagg/autorest/git/commits{/sha}","comments_url":"https://api.github.com/repos/veronicagg/autorest/comments{/number}","issue_comment_url":"https://api.github.com/repos/veronicagg/autorest/issues/comments{/number}","contents_url":"https://api.github.com/repos/veronicagg/autorest/contents/{+path}","compare_url":"https://api.github.com/repos/veronicagg/autorest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/veronicagg/autorest/merges","archive_url":"https://api.github.com/repos/veronicagg/autorest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/veronicagg/autorest/downloads","issues_url":"https://api.github.com/repos/veronicagg/autorest/issues{/number}","pulls_url":"https://api.github.com/repos/veronicagg/autorest/pulls{/number}","milestones_url":"https://api.github.com/repos/veronicagg/autorest/milestones{/number}","notifications_url":"https://api.github.com/repos/veronicagg/autorest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/veronicagg/autorest/labels{/name}","releases_url":"https://api.github.com/repos/veronicagg/autorest/releases{/id}","deployments_url":"https://api.github.com/repos/veronicagg/autorest/deployments","created_at":"2016-04-18T20:59:22Z","updated_at":"2016-04-18T20:59:28Z","pushed_at":"2016-06-30T21:45:13Z","git_url":"git://github.com/veronicagg/autorest.git","ssh_url":"git@github.com:veronicagg/autorest.git","clone_url":"https://github.com/veronicagg/autorest.git","svn_url":"https://github.com/veronicagg/autorest","homepage":null,"size":48893,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"86aa2fc5087c11ad7fb9c1a98081f71f37a8a86a","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":31089461,"name":"autorest","full_name":"Azure/autorest","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest","description":"Swagger (OpenAPI) Specification code generator featuring C# and Razor templates. Supports C#, Java, Node.js, TypeScript, Python and Ruby.","fork":false,"url":"https://api.github.com/repos/Azure/autorest","forks_url":"https://api.github.com/repos/Azure/autorest/forks","keys_url":"https://api.github.com/repos/Azure/autorest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest/teams","hooks_url":"https://api.github.com/repos/Azure/autorest/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest/events","assignees_url":"https://api.github.com/repos/Azure/autorest/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest/tags","blobs_url":"https://api.github.com/repos/Azure/autorest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest/subscription","commits_url":"https://api.github.com/repos/Azure/autorest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest/merges","archive_url":"https://api.github.com/repos/Azure/autorest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest/downloads","issues_url":"https://api.github.com/repos/Azure/autorest/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/autorest/deployments","created_at":"2015-02-20T23:02:54Z","updated_at":"2016-06-30T00:51:37Z","pushed_at":"2016-06-30T23:17:30Z","git_url":"git://github.com/Azure/autorest.git","ssh_url":"git@github.com:Azure/autorest.git","clone_url":"https://github.com/Azure/autorest.git","svn_url":"https://github.com/Azure/autorest","homepage":"","size":54519,"stargazers_count":410,"watchers_count":410,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":85,"forks":145,"open_issues":85,"watchers":410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1211"},"html":{"href":"https://github.com/Azure/autorest/pull/1211"},"issue":{"href":"https://api.github.com/repos/Azure/autorest/issues/1211"},"comments":{"href":"https://api.github.com/repos/Azure/autorest/issues/1211/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1211/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1211/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/autorest/statuses/620da212ab34195cb5cd86c083a397498266d042"}}}}
{"actor":{"display_login":"vishrutshah"}}