{"push_id":1147799302,"size":98,"distinct_size":42,"ref":"refs/heads/master","head":"48689481753af22986851c908f6d7b6d8f0a9567","before":"6321ad486b0462544d85cc47290da938b1d7d1ba","commits":[{"sha":"a49558def830a22a833363ac4e4a46b2d7fc0674","author":{"name":"Jim Remsik","email":"01daad4d9d4d1463407786cb0f972199d6b254a2@gmail.com"},"message":"Documentation typo – missing word\n\nSummary:\nAdds a word to enhance readability.\nCloses https://github.com/facebook/react-native/pull/7867\n\nDifferential Revision: D3370881\n\nPulled By: nicklockwood\n\nfbshipit-source-id: e3555a859dd3a44f2b9d12a22d1a2366a6a8097f","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/a49558def830a22a833363ac4e4a46b2d7fc0674"},{"sha":"2d32a6df27dc60b0e965b638e8e45147f9d4b892","author":{"name":"Siqi Liu","email":"ae4a0336777d71ff9ea6588e2e7de37e09cb842e@fb.com"},"message":"Add Shortcut \"Double R\" to Reload JS in iOS\n\nSummary:\nEnable double tap R on iOS, consistent with Android.\nKeep the existing Cmd+R on iOS because people are already used to it.\nMake Cmd+Key and Double Key both invalid when focus is in textview or textfield.\nAlso try to add Cmd+R in Android, but seems no good.\n\nReviewed By: nicklockwood\n\nDifferential Revision: D3343907\n\nfbshipit-source-id: 68f7e3b0393711c137e1d932db33e1b6a2a19e09","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/2d32a6df27dc60b0e965b638e8e45147f9d4b892"},{"sha":"4391ef218b5145fb04103e260f862f968f653063","author":{"name":"Martin Konicek","email":"f9c5ef9b5325ce81d68a8d733940290a1a837e54@fb.com"},"message":"Tweak dev menu label: Stop Remote JS Debugging\n\nSummary:\n\"Stop\" is a bit clearer - the debugger is started and stopped, rather than enabled / disabled. Small difference :)\n\nIn contrast, live reloading and hot reloading are enabled and disabled.\n\nsatya164 pointed it out in [this comment](https://github.com/facebook/react-native/commit/31eea8eee3bd904065b06c639321dbc2cea1ca55#commitcomment-17682563) and I agree.\n\n**Test Plan**\n\nRan the UIExplorer:\n\n<img width=\"432\" alt=\"screen shot 2016-05-31 at 11 11 28 pm\" src=\"https://cloud.githubusercontent.com/assets/346214/15692439/473c26b6-2786-11e6-969a-d494067cbc3b.png\">\n\nOn Android the change is kind of obvious :)\nCloses https://github.com/facebook/react-native/pull/7861\n\nDifferential Revision: D3371207\n\nPulled By: mkonicek\n\nfbshipit-source-id: 769288f687a98d62cf5c1a22cbc857b7dc4acf00","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/4391ef218b5145fb04103e260f862f968f653063"},{"sha":"6603cef95cd30fcc05330707d4ce10a2c4e22046","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Fix ScrollView to work correctly for new css-layout\n\nReviewed By: sahrens\n\nDifferential Revision: D3367140\n\nfbshipit-source-id: ea470f289c92ebca71543a9b9328a7a5ed6d572b","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/6603cef95cd30fcc05330707d4ce10a2c4e22046"},{"sha":"0e82eb3bed05c06677efb03e55361d04fbe7451f","author":{"name":"Alessandro Nadalin","email":"acb0168ce7921e7696d43be2438a69f37f406826@gmail.com"},"message":"Update Upgrading.md\n\nSummary:\nJust updating the docs as .18 is quite old :)\nCloses https://github.com/facebook/react-native/pull/7824\n\nDifferential Revision: D3371417\n\nPulled By: javache\n\nfbshipit-source-id: 91b8249f814eeef68cbeff4b481624644dc7be73","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/0e82eb3bed05c06677efb03e55361d04fbe7451f"},{"sha":"aa53770c253f8f222113ad4a8ce55dbd148dd484","author":{"name":"Konstantin Raev","email":"262a3feb6c5718f8f9d3bda3bc4169ca50eb70b8@fb.com"},"message":"removed unused code: _numPrependedModules\n\nSummary:\ncc davidaurelio\nCloses https://github.com/facebook/react-native/pull/7873\n\nDifferential Revision: D3371406\n\nPulled By: javache\n\nfbshipit-source-id: 72ed3838a88022ae5c0832dcca5abda75f18dbe1","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/aa53770c253f8f222113ad4a8ce55dbd148dd484"},{"sha":"bdcdfb03d41f82e2c9cd94147fd5fafe89e1a339","author":{"name":"Nick Lockwood","email":"c3998cc0d63bddc85da2da582ab467453b0e9127@fb.com"},"message":"Fixed \"Sending `didSendNetworkData` with no listeners registered\" warning\n\nSummary:\nXMLHttpRequest was sending the request before registering any listeners, resulting in a warning from the native event emitter.\n\nSince we weren't seeing widespread problems with XHR missing data, this was probably working OK in practice because the queuing of events meant that the listener would have been registered before the message was actually delivered.\n\nStill, this was working more through luck than design. This diff fixes it by registering the listeners *before* sending the request.\n\nReviewed By: lexs\n\nDifferential Revision: D3371320\n\nfbshipit-source-id: c688d4053a61f856eaacccd0106905edbefcc86a","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/bdcdfb03d41f82e2c9cd94147fd5fafe89e1a339"},{"sha":"002024cc456246761421f6e5c354466baa819843","author":{"name":"Nick Lockwood","email":"c3998cc0d63bddc85da2da582ab467453b0e9127@fb.com"},"message":"Removed hard-coded DatePicker width\n\nSummary: The DatePicker had a hard-coded width of 320 for no reason I can think of. Removing it allows the DatePicker to naturally scale to fit the width of the container, which is how the regular Picker works already.\n\nReviewed By: lexs\n\nDifferential Revision: D3371355\n\nfbshipit-source-id: e06d31f7275de41bb00226232cf47ad022d25b4d","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/002024cc456246761421f6e5c354466baa819843"},{"sha":"e87bea464b88ca11f9f02c31c5ed8df6f44abcb3","author":{"name":"Emilio Rodriguez","email":"81ca8e890aadf300511cecf04183a74d4b990ce9@gmail.com"},"message":"Replaced old password prop with secureTextEntry\n\nSummary: Closes https://github.com/facebook/react-native/pull/7783\n\nDifferential Revision: D3371521\n\nPulled By: javache\n\nfbshipit-source-id: f442b549e6fc8c2c8e5ec12f32185bfabafbdd81","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/e87bea464b88ca11f9f02c31c5ed8df6f44abcb3"},{"sha":"88190f7e9d873649f0cb8ef322c5802b155a47a0","author":{"name":"Konstantin Raev","email":"262a3feb6c5718f8f9d3bda3bc4169ca50eb70b8@fb.com"},"message":"A few instrumentation tests were fixed and are supposed to be more stable\n\nReviewed By: avaly\n\nDifferential Revision: D3354433\n\nfbshipit-source-id: 4e3f00fae94e5cb910e188b0e3fbe204361a4d01","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/88190f7e9d873649f0cb8ef322c5802b155a47a0"},{"sha":"572a85fa24f2d2b4d5e2b05cdbfc88f3a4bbc2e0","author":{"name":"Martín Bigio","email":"ea98e1d0a9a4d10e3af04e16be88050749615623@instagram.com"},"message":"Fix multiline TextField initial render\n\nSummary:\nThe TextInput when configured with `multiline=true` has a minor issue due to which if the initial text doesn't fit in one line, the input won't span multiple lines. The root cause of the problem is that the `onChange` event is not fired for the initial render. This issue has been reported on open-source: https://github.com/facebook/react-native/commit/481f560f64806ba3324cf722d6bf8c3f36ac74a5\n\nThis is an attempt to fix this problem by moving the logic to fire the event to the method that updates the content size. This way we can guarantee that anytime the content size changes we'll trigger the JS event.\n\nThe downside of this approach is that it's possible that multiple events get fired for a single character change. As per the comment that was removed, this was already happening when adding a character that when rendered, would increase the content size. By moving the code to the new place, this can happen more often (twice per character tapped). Let me know if you think this is an issue.\n\nI don't know this code much, so please be careful reviewing. I'm happy to add more test cases I may have missed to the test plan :).\n\nReviewed By: nicklockwood\n\nDifferential Revision: D3348218\n\nfbshipit-source-id: d3da3c0da1a0da9b9960625441191497e91d322e","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/572a85fa24f2d2b4d5e2b05cdbfc88f3a4bbc2e0"},{"sha":"0cc0aaecbb39db0e1d48081109d80dede6869744","author":{"name":"Siqi Liu","email":"ae4a0336777d71ff9ea6588e2e7de37e09cb842e@fb.com"},"message":"Followup for Add Shortcut \"Double R\" to Reload JS in iOS\n\nSummary: Change nit codes in comments.\n\nReviewed By: mkonicek\n\nDifferential Revision: D3371536\n\nfbshipit-source-id: 4133af88568f15410ff90c945695f82ffd94eb95","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/0cc0aaecbb39db0e1d48081109d80dede6869744"},{"sha":"cec913e7ce05d26181ab4d46e2e41d72acdfb87d","author":{"name":"Jakob Kerkhove","email":"1ea1cd06918e2aa65129cc4ec9da180047723ca2@users.noreply.github.com"},"message":"Native propTypes RCTDatePickerIOS !== propTypes DatePickerIOS\n\nSummary:\nThe propTypes of RCTDatePickerIOS do not fit with the propTypes of DatePickerIOS.\nAll dates (date, minimumDate, maximumDate) are a timestamp (check line 126), so they should have propType number.\nOnDateChange function should not be required since it is called onChange in the iOS implementation.\n\nThe problem currently causes warnings that the given types are wrong, while they were added correctly.\nCloses https://github.com/facebook/react-native/pull/7833\n\nDifferential Revision: D3371324\n\nPulled By: nicklockwood\n\nfbshipit-source-id: bca5b2bbe7e9dd2e045288bfbd268578848c7bff","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/cec913e7ce05d26181ab4d46e2e41d72acdfb87d"},{"sha":"ee8496f364070f1b3629b94b347a0e11b2895dec","author":{"name":"Adam Comella","email":"d1c71746ae3861372e1ee3d0a97afe181b0f3e6d@microsoft.com"},"message":"iOS: Support HTTP headers for source prop on <Image> components\n\nSummary:\nAllows developers to specify headers to include in the HTTP request\nwhen fetching a remote image. For example, one might leverage this\nwhen fetching an image from an endpoint that requires authentication:\n\n```\n<Image\n  style={styles.logo}\n  source={{\n    uri: 'http://facebook.github.io/react/img/logo_og.png',\n    headers: {\n      Authorization: 'someAuthToken'\n    }\n  }}\n/>\n```\n\nNote that the header values must be strings.\n\nWorks on iOS and Android.\n\n**Test plan (required)**\n\n- Ran a small example like the one above on iOS and Android and ensured the headers were sent to the server.\n- Ran a small example to ensure that \\<Image\\> components without headers still work.\n- Currently using this code in our app.\n\nAdam Comella\nMicrosoft Corp.\nCloses https://github.com/facebook/react-native/pull/7338\n\nReviewed By: javache\n\nDifferential Revision: D3371458\n\nPulled By: nicklockwood\n\nfbshipit-source-id: cdb24fe2572c3ae3ba82c86ad383af6d85157e20","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/ee8496f364070f1b3629b94b347a0e11b2895dec"},{"sha":"bbc6139baf215da40da125a92965da03d7627cd9","author":{"name":"Martín Bigio","email":"ea98e1d0a9a4d10e3af04e16be88050749615623@instagram.com"},"message":"Reverted commit D3348218\n\nSummary:\nThe TextInput when configured with `multiline=true` has a minor issue due to which if the initial text doesn't fit in one line, the input won't span multiple lines. The root cause of the problem is that the `onChange` event is not fired for the initial render. This issue has been reported on open-source: https://github.com/facebook/react-native/commit/481f560f64806ba3324cf722d6bf8c3f36ac74a5\n\nThis is an attempt to fix this problem by moving the logic to fire the event to the method that updates the content size. This way we can guarantee that anytime the content size changes we'll trigger the JS event.\n\nThe downside of this approach is that it's possible that multiple events get fired for a single character change. As per the comment that was removed, this was already happening when adding a character that when rendered, would increase the content size. By moving the code to the new place, this can happen more often (twice per character tapped). Let me know if you think this is an issue.\n\nI don't know this code much, so please be careful reviewing. I'm happy to add more test cases I may have missed to the test plan :).\n\nReviewed By: nicklockwood\n\nDifferential Revision: D3348218\n\nfbshipit-source-id: 6b457624c9126e771c326eac61cd1cdd6496671d","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/bbc6139baf215da40da125a92965da03d7627cd9"},{"sha":"7e100ac7a225bd5f03dc97a828f414b9f862e1ff","author":{"name":"Alex Kotliarskyi","email":"1040746ae9366ab18b414ffcc13be951ec9c2928@fb.com"},"message":"Extract getDevServerURL into reusable module\n\nSummary:\nMany RN devtools (inspector, source maps, etc.) rely on packager.\nThis refactors individual SourceCode.scriptURL parsing into one function\nthat will be easier to change in the future.\n\nReviewed By: javache\n\nDifferential Revision: D3348465\n\nfbshipit-source-id: 5a55939ea59e1517cb63bcbe4963f57f02ab15f3","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/7e100ac7a225bd5f03dc97a828f414b9f862e1ff"},{"sha":"2ef533352fcccf82c6bd82ce7facb2c92403ba22","author":{"name":"Alex Kotliarskyi","email":"1040746ae9366ab18b414ffcc13be951ec9c2928@fb.com"},"message":"Extract symbolicateStackTrace into its own module\n\nSummary:\nHaving a function that symbolicates any given stack trace\nis convenient, e.g. in #7459\n\nMore cleanup to follow.\n\nReviewed By: davidaurelio\n\nDifferential Revision: D3348616\n\nfbshipit-source-id: 6313ec837869c6080829c811345a06aa1b2dcd21","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/2ef533352fcccf82c6bd82ce7facb2c92403ba22"},{"sha":"0d1d7ba2b7e142e9a3b41dcdaa3b1ca52177f5a5","author":{"name":"Alex Kotliarskyi","email":"1040746ae9366ab18b414ffcc13be951ec9c2928@fb.com"},"message":"Remove dead SourceMap code\n\nSummary:\nIn several pervious diffs we have moved symbolication of JS stack traces\nto the packeger. This lets us save a bunch of memory (~80MB) and CPU on device,\nreduces dependency on JS after exception occured.\n\nThis diff cleans up a bunch of code that was used to do symbolication on client side.\n\nReviewed By: javache\n\nDifferential Revision: D3348676\n\nfbshipit-source-id: 88baa5c502836c9ca892896e1ee5d83db37486d3","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/0d1d7ba2b7e142e9a3b41dcdaa3b1ca52177f5a5"},{"sha":"886a558f75dfa5871b9efe40df91d330df6c0792","author":{"name":"Chris Hopman","email":"b4caa24f9de55f461e4c51db2576ccfc3b9fb18e@fb.com"},"message":"Extract all NativeArray/NativeMap from OnLoad.cpp\n\nSummary: These will, eventually, need to be moved to the new bridge and so must become standalone things. For *NativeArray, this is almost just moving them out into their own .h/.cpp files. The *NativeMaps are updated to be hybrids instead of countables (in addition to getting their own .h/.cpp).\n\nReviewed By: mhorowitz\n\nDifferential Revision: D3325169\n\nfbshipit-source-id: 40cfcab92b3fb2310bcd4de8f39e82f85d404abd","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/886a558f75dfa5871b9efe40df91d330df6c0792"},{"sha":"aaf557da52869d2728bce716d34b748af07a7ebd","author":{"name":"Christine Abernathy","email":"055f8462a9fc823eeeb6a0368935ab27dc9ad3a1@fb.com"},"message":"Fix instructions so react-native packages are installed first\n\nSummary:\nPost React 15.x one of the files pulled in for documentation reside in that repo: NativeMethodsMixin.js\n\nThis ensures that developers install react-native packages first (which includes React) so the file can be found when it's referenced in server/extractDocs.js\n\n**Test plan (required)**\n\n1. Ran through the instructions.\n2. Made sure http://localhost:8079/react-native/docs/nativemethodsmixin.html exists in the nav and is shows correctly.\nCloses https://github.com/facebook/react-native/pull/7882\n\nDifferential Revision: D3376395\n\nPulled By: caabernathy\n\nfbshipit-source-id: bfcef271516ed2b21f04d86114dfceb2ff35138c","distinct":false,"url":"https://api.github.com/repos/wildlifela/react-native/commits/aaf557da52869d2728bce716d34b748af07a7ebd"}]}
{"actor":{"display_login":"christopherdro"}}