{"action":"created","comment":{"url":"https://api.github.com/repos/FezVrasta/popper.js/pulls/comments/77448402","id":77448402,"diff_hunk":"@@ -14,6 +15,7 @@ import runModifiers from '../utils/runModifiers';\n  * @argument {Object} options - Modifiers configuration and options\n  * @returns {Object} The data object, properly modified\n  */\n+","path":"src/modifiers/flip.js","position":10,"original_position":10,"commit_id":"30f14c4e603e4194f6a01ecc5286f8e01b7e003a","original_commit_id":"30f14c4e603e4194f6a01ecc5286f8e01b7e003a","user":{"login":"FezVrasta","id":5382443,"avatar_url":"https://avatars.githubusercontent.com/u/5382443?v=3","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"body":"No space between JSdocs comments and the function please 🙃","created_at":"2016-09-04T08:00:42Z","updated_at":"2016-09-04T08:00:42Z","html_url":"https://github.com/FezVrasta/popper.js/pull/82#discussion_r77448402","pull_request_url":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/FezVrasta/popper.js/pulls/comments/77448402"},"html":{"href":"https://github.com/FezVrasta/popper.js/pull/82#discussion_r77448402"},"pull_request":{"href":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82","id":83915369,"html_url":"https://github.com/FezVrasta/popper.js/pull/82","diff_url":"https://github.com/FezVrasta/popper.js/pull/82.diff","patch_url":"https://github.com/FezVrasta/popper.js/pull/82.patch","issue_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/82","number":82,"state":"open","locked":false,"title":"Improve detection strategy of flip modifier","user":{"login":"nadiam84","id":6586830,"avatar_url":"https://avatars.githubusercontent.com/u/6586830?v=3","gravatar_id":"","url":"https://api.github.com/users/nadiam84","html_url":"https://github.com/nadiam84","followers_url":"https://api.github.com/users/nadiam84/followers","following_url":"https://api.github.com/users/nadiam84/following{/other_user}","gists_url":"https://api.github.com/users/nadiam84/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiam84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiam84/subscriptions","organizations_url":"https://api.github.com/users/nadiam84/orgs","repos_url":"https://api.github.com/users/nadiam84/repos","events_url":"https://api.github.com/users/nadiam84/events{/privacy}","received_events_url":"https://api.github.com/users/nadiam84/received_events","type":"User","site_admin":false},"body":"This PR is an attempt to solve the issue #78. There are two commits here. \r\n\r\nThe first one is solving \"moving after target\" problem. I.e. popper will behave like it doesn't have 'preventOverflow' modifier, but still will flip itself from the parent. It looks like this:\r\n\r\nhttps://goo.gl/photos/H5QafmbZ1xjVuHeD6\r\n\r\nEnabling this behaviour would look like this:\r\n```\r\nmodifiers: {\r\n    preventOverflow: {\r\n        moveWithTarget: true\r\n    }\r\n}\r\n```\r\n\r\nThe second commit is improving flipping behavior so that popper can also flip its position's variation ('start' to 'end' and vice versa). It looks like this:\r\n\r\nhttps://goo.gl/photos/MtneBBm9nNd6Nynz6\r\n\r\n```\r\nmodifiers: {\r\n    flip: {\r\n        flipVariations: true\r\n    }\r\n}\r\n```","created_at":"2016-09-04T07:04:05Z","updated_at":"2016-09-04T08:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6856e1dc08265d3951447783fdc6023941f84625","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82/commits","review_comments_url":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82/comments","review_comment_url":"https://api.github.com/repos/FezVrasta/popper.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/82/comments","statuses_url":"https://api.github.com/repos/FezVrasta/popper.js/statuses/30f14c4e603e4194f6a01ecc5286f8e01b7e003a","head":{"label":"nadiam84:v1-dev-improvements","ref":"v1-dev-improvements","sha":"30f14c4e603e4194f6a01ecc5286f8e01b7e003a","user":{"login":"nadiam84","id":6586830,"avatar_url":"https://avatars.githubusercontent.com/u/6586830?v=3","gravatar_id":"","url":"https://api.github.com/users/nadiam84","html_url":"https://github.com/nadiam84","followers_url":"https://api.github.com/users/nadiam84/followers","following_url":"https://api.github.com/users/nadiam84/following{/other_user}","gists_url":"https://api.github.com/users/nadiam84/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiam84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiam84/subscriptions","organizations_url":"https://api.github.com/users/nadiam84/orgs","repos_url":"https://api.github.com/users/nadiam84/repos","events_url":"https://api.github.com/users/nadiam84/events{/privacy}","received_events_url":"https://api.github.com/users/nadiam84/received_events","type":"User","site_admin":false},"repo":{"id":65361584,"name":"popper.js","full_name":"nadiam84/popper.js","owner":{"login":"nadiam84","id":6586830,"avatar_url":"https://avatars.githubusercontent.com/u/6586830?v=3","gravatar_id":"","url":"https://api.github.com/users/nadiam84","html_url":"https://github.com/nadiam84","followers_url":"https://api.github.com/users/nadiam84/followers","following_url":"https://api.github.com/users/nadiam84/following{/other_user}","gists_url":"https://api.github.com/users/nadiam84/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiam84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiam84/subscriptions","organizations_url":"https://api.github.com/users/nadiam84/orgs","repos_url":"https://api.github.com/users/nadiam84/repos","events_url":"https://api.github.com/users/nadiam84/events{/privacy}","received_events_url":"https://api.github.com/users/nadiam84/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nadiam84/popper.js","description":"A kickass library to manage your poppers","fork":true,"url":"https://api.github.com/repos/nadiam84/popper.js","forks_url":"https://api.github.com/repos/nadiam84/popper.js/forks","keys_url":"https://api.github.com/repos/nadiam84/popper.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadiam84/popper.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadiam84/popper.js/teams","hooks_url":"https://api.github.com/repos/nadiam84/popper.js/hooks","issue_events_url":"https://api.github.com/repos/nadiam84/popper.js/issues/events{/number}","events_url":"https://api.github.com/repos/nadiam84/popper.js/events","assignees_url":"https://api.github.com/repos/nadiam84/popper.js/assignees{/user}","branches_url":"https://api.github.com/repos/nadiam84/popper.js/branches{/branch}","tags_url":"https://api.github.com/repos/nadiam84/popper.js/tags","blobs_url":"https://api.github.com/repos/nadiam84/popper.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadiam84/popper.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadiam84/popper.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadiam84/popper.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadiam84/popper.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nadiam84/popper.js/languages","stargazers_url":"https://api.github.com/repos/nadiam84/popper.js/stargazers","contributors_url":"https://api.github.com/repos/nadiam84/popper.js/contributors","subscribers_url":"https://api.github.com/repos/nadiam84/popper.js/subscribers","subscription_url":"https://api.github.com/repos/nadiam84/popper.js/subscription","commits_url":"https://api.github.com/repos/nadiam84/popper.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadiam84/popper.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadiam84/popper.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadiam84/popper.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadiam84/popper.js/contents/{+path}","compare_url":"https://api.github.com/repos/nadiam84/popper.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadiam84/popper.js/merges","archive_url":"https://api.github.com/repos/nadiam84/popper.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadiam84/popper.js/downloads","issues_url":"https://api.github.com/repos/nadiam84/popper.js/issues{/number}","pulls_url":"https://api.github.com/repos/nadiam84/popper.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nadiam84/popper.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nadiam84/popper.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadiam84/popper.js/labels{/name}","releases_url":"https://api.github.com/repos/nadiam84/popper.js/releases{/id}","deployments_url":"https://api.github.com/repos/nadiam84/popper.js/deployments","created_at":"2016-08-10T07:45:25Z","updated_at":"2016-08-10T07:45:26Z","pushed_at":"2016-09-04T06:45:11Z","git_url":"git://github.com/nadiam84/popper.js.git","ssh_url":"git@github.com:nadiam84/popper.js.git","clone_url":"https://github.com/nadiam84/popper.js.git","svn_url":"https://github.com/nadiam84/popper.js","homepage":"https://popper.js.org","size":16658,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FezVrasta:v1-dev","ref":"v1-dev","sha":"37aaf4891272cc149e79b4bb597cb8cfbc72f76c","user":{"login":"FezVrasta","id":5382443,"avatar_url":"https://avatars.githubusercontent.com/u/5382443?v=3","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"repo":{"id":54994103,"name":"popper.js","full_name":"FezVrasta/popper.js","owner":{"login":"FezVrasta","id":5382443,"avatar_url":"https://avatars.githubusercontent.com/u/5382443?v=3","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FezVrasta/popper.js","description":"A kickass library to manage your poppers","fork":false,"url":"https://api.github.com/repos/FezVrasta/popper.js","forks_url":"https://api.github.com/repos/FezVrasta/popper.js/forks","keys_url":"https://api.github.com/repos/FezVrasta/popper.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FezVrasta/popper.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FezVrasta/popper.js/teams","hooks_url":"https://api.github.com/repos/FezVrasta/popper.js/hooks","issue_events_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/events{/number}","events_url":"https://api.github.com/repos/FezVrasta/popper.js/events","assignees_url":"https://api.github.com/repos/FezVrasta/popper.js/assignees{/user}","branches_url":"https://api.github.com/repos/FezVrasta/popper.js/branches{/branch}","tags_url":"https://api.github.com/repos/FezVrasta/popper.js/tags","blobs_url":"https://api.github.com/repos/FezVrasta/popper.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FezVrasta/popper.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FezVrasta/popper.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/FezVrasta/popper.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FezVrasta/popper.js/statuses/{sha}","languages_url":"https://api.github.com/repos/FezVrasta/popper.js/languages","stargazers_url":"https://api.github.com/repos/FezVrasta/popper.js/stargazers","contributors_url":"https://api.github.com/repos/FezVrasta/popper.js/contributors","subscribers_url":"https://api.github.com/repos/FezVrasta/popper.js/subscribers","subscription_url":"https://api.github.com/repos/FezVrasta/popper.js/subscription","commits_url":"https://api.github.com/repos/FezVrasta/popper.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/FezVrasta/popper.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/FezVrasta/popper.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/FezVrasta/popper.js/contents/{+path}","compare_url":"https://api.github.com/repos/FezVrasta/popper.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FezVrasta/popper.js/merges","archive_url":"https://api.github.com/repos/FezVrasta/popper.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FezVrasta/popper.js/downloads","issues_url":"https://api.github.com/repos/FezVrasta/popper.js/issues{/number}","pulls_url":"https://api.github.com/repos/FezVrasta/popper.js/pulls{/number}","milestones_url":"https://api.github.com/repos/FezVrasta/popper.js/milestones{/number}","notifications_url":"https://api.github.com/repos/FezVrasta/popper.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FezVrasta/popper.js/labels{/name}","releases_url":"https://api.github.com/repos/FezVrasta/popper.js/releases{/id}","deployments_url":"https://api.github.com/repos/FezVrasta/popper.js/deployments","created_at":"2016-03-29T17:00:47Z","updated_at":"2016-09-04T06:46:14Z","pushed_at":"2016-09-04T07:04:05Z","git_url":"git://github.com/FezVrasta/popper.js.git","ssh_url":"git@github.com:FezVrasta/popper.js.git","clone_url":"https://github.com/FezVrasta/popper.js.git","svn_url":"https://github.com/FezVrasta/popper.js","homepage":"https://popper.js.org","size":1314,"stargazers_count":3052,"watchers_count":3052,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":8,"forks":104,"open_issues":8,"watchers":3052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82"},"html":{"href":"https://github.com/FezVrasta/popper.js/pull/82"},"issue":{"href":"https://api.github.com/repos/FezVrasta/popper.js/issues/82"},"comments":{"href":"https://api.github.com/repos/FezVrasta/popper.js/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/FezVrasta/popper.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FezVrasta/popper.js/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/FezVrasta/popper.js/statuses/30f14c4e603e4194f6a01ecc5286f8e01b7e003a"}}}}
{"actor":{"display_login":"FezVrasta"}}