{"action":"closed","number":21100,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21100","id":59093113,"html_url":"https://github.com/kubernetes/kubernetes/pull/21100","diff_url":"https://github.com/kubernetes/kubernetes/pull/21100.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/21100.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21100","number":21100,"state":"closed","locked":false,"title":"Don't call DaemonSet and HPA type variables controller, it is just confusing to the reader. [LGTM]","user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-11T21:02:19Z","updated_at":"2016-02-16T17:52:57Z","closed_at":"2016-02-16T17:52:57Z","merged_at":"2016-02-16T17:52:57Z","merge_commit_sha":"fc75e529edfd38cb6ceac132c89a0ca52e10cddb","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21100/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21100/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21100/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/688cae77cb0ad40e10776cf74596b6b37b383845","head":{"label":"madhusudancs:daemonset-validation-change-confusing-varnames","ref":"daemonset-validation-change-confusing-varnames","sha":"688cae77cb0ad40e10776cf74596b6b37b383845","user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"repo":{"id":43526269,"name":"kubernetes","full_name":"madhusudancs/kubernetes","owner":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madhusudancs/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/madhusudancs/kubernetes","forks_url":"https://api.github.com/repos/madhusudancs/kubernetes/forks","keys_url":"https://api.github.com/repos/madhusudancs/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madhusudancs/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madhusudancs/kubernetes/teams","hooks_url":"https://api.github.com/repos/madhusudancs/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/madhusudancs/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/madhusudancs/kubernetes/events","assignees_url":"https://api.github.com/repos/madhusudancs/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/madhusudancs/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/madhusudancs/kubernetes/tags","blobs_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madhusudancs/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/madhusudancs/kubernetes/languages","stargazers_url":"https://api.github.com/repos/madhusudancs/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/madhusudancs/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/madhusudancs/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/madhusudancs/kubernetes/subscription","commits_url":"https://api.github.com/repos/madhusudancs/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/madhusudancs/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/madhusudancs/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/madhusudancs/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/madhusudancs/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/madhusudancs/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madhusudancs/kubernetes/merges","archive_url":"https://api.github.com/repos/madhusudancs/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madhusudancs/kubernetes/downloads","issues_url":"https://api.github.com/repos/madhusudancs/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/madhusudancs/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/madhusudancs/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/madhusudancs/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madhusudancs/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/madhusudancs/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/madhusudancs/kubernetes/deployments","created_at":"2015-10-01T23:19:31Z","updated_at":"2016-01-11T22:54:35Z","pushed_at":"2016-02-15T20:52:55Z","git_url":"git://github.com/madhusudancs/kubernetes.git","ssh_url":"git@github.com:madhusudancs/kubernetes.git","clone_url":"https://github.com/madhusudancs/kubernetes.git","svn_url":"https://github.com/madhusudancs/kubernetes","homepage":"http://kubernetes.io","size":168134,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2778bc0c13a5680f5214f9223a319bbd6514b805","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-16T17:49:38Z","pushed_at":"2016-02-16T17:52:57Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":327006,"stargazers_count":12712,"watchers_count":12712,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3621,"mirror_url":null,"open_issues_count":2845,"forks":3621,"open_issues":2845,"watchers":12712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21100"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/21100"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21100"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21100/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21100/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21100/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/688cae77cb0ad40e10776cf74596b6b37b383845"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"commits":1,"additions":12,"deletions":12,"changed_files":1}}