{"push_id":1301784950,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"2adb6eb0cd30c11f58052753f72e1db6bb77f25d","before":"a610249b9ea7c414810b1c0a12f9a81c13c834ec","commits":[{"sha":"2adb6eb0cd30c11f58052753f72e1db6bb77f25d","author":{"name":"Vladimir Slaykovskiy","email":"a2c91f93d7731427090dedc99a666f02b495e24f@fb.com"},"message":"Reduce footprint of ScribeClient\n\nSummary:\nI've found all code paths that contributed to the number of threads in new ScribeClient. Here's a list of flags that reduce the number of thread:\n  --default_tls_thread_count=1 # was 32\n  --sr2_event_base_pool_size=1\n  --has_thrift_dispatcher_reporter=0 # creates a thrift server with a few extra threads\n  --observer_manager_pool_size=1 # default is 4\n\nOptimizations in this diff:\n- Don't initialize OBCClient object if it is not used\n- Added FLAG_observer_manager_pool_size to control size of the pool in ObserverManager\n\nCurrently OBC counters are switched off globally in ScribeCliean, it means that new code path that creates SR instances is disabled, but eventually we plan to switch it on. Clients that don't use SR and want to keep their RSS/threads profile low, should pass flags listed above. I'll announce this in ScribeUsers group as well.\n\nDifferential Revision: D3870704\n\nfbshipit-source-id: 0efad6b3dc43c072ab11cac7e9461c09532ea11c","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/2adb6eb0cd30c11f58052753f72e1db6bb77f25d"}]}
{"actor":{"display_login":"facebook-github-bot-0"}}