{"comment":{"url":"https://api.github.com/repos/nothize/telegram-jung2-bot/comments/17395944","html_url":"https://github.com/nothize/telegram-jung2-bot/commit/4617a6ec6df8cbd9fbb655890e73ba91c2714440#commitcomment-17395944","id":17395944,"user":{"login":"nothize","id":225121,"avatar_url":"https://avatars.githubusercontent.com/u/225121?v=3","gravatar_id":"","url":"https://api.github.com/users/nothize","html_url":"https://github.com/nothize","followers_url":"https://api.github.com/users/nothize/followers","following_url":"https://api.github.com/users/nothize/following{/other_user}","gists_url":"https://api.github.com/users/nothize/gists{/gist_id}","starred_url":"https://api.github.com/users/nothize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nothize/subscriptions","organizations_url":"https://api.github.com/users/nothize/orgs","repos_url":"https://api.github.com/users/nothize/repos","events_url":"https://api.github.com/users/nothize/events{/privacy}","received_events_url":"https://api.github.com/users/nothize/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"4617a6ec6df8cbd9fbb655890e73ba91c2714440","created_at":"2016-05-09T03:54:29Z","updated_at":"2016-05-09T03:54:29Z","body":"As I've moved a large piece of message controller to ds/mongo.js, it maybe better to:\r\n\r\n1. publish the change to upstream if there is no conflict with outstanding feature branches; or\r\n2. postpone the dao branch until the conflicting feature branches are published to upstream (and then I rebase to upstream).\r\n\r\nHowever, I don't know how to test ds/datastore.init() properly as the code snippets were moved from app.js which wasn't covered by the tests. (eg. how to mock mongoose.connect properly)"}}