{"action":"created","comment":{"url":"https://api.github.com/repos/rstudio/htmltools/pulls/comments/85965362","pull_request_review_id":6648397,"id":85965362,"diff_hunk":"@@ -46,6 +46,27 @@ test_that(\"UTF-8 characters in templates\", {\n   expect_identical(charToRaw(text), as.raw(c(0xc3, 0xbf)))\n })\n \n+test_that(\"UTF-8 characters in template head but not body\", {\n+  # On Windows, a string with \"中文\" will automatically be marked as UTF-8.\n+  ui <- tagList(\n+    tags$head(tags$script(\"alert('中文')\")),","path":"tests/testthat/test-template.R","position":7,"original_position":7,"commit_id":"810fa61eba84fbc8d808fc79acd929c54f9e2d59","original_commit_id":"810fa61eba84fbc8d808fc79acd929c54f9e2d59","user":{"login":"yihui","id":163582,"avatar_url":"https://avatars.githubusercontent.com/u/163582?v=3","gravatar_id":"","url":"https://api.github.com/users/yihui","html_url":"https://github.com/yihui","followers_url":"https://api.github.com/users/yihui/followers","following_url":"https://api.github.com/users/yihui/following{/other_user}","gists_url":"https://api.github.com/users/yihui/gists{/gist_id}","starred_url":"https://api.github.com/users/yihui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihui/subscriptions","organizations_url":"https://api.github.com/users/yihui/orgs","repos_url":"https://api.github.com/users/yihui/repos","events_url":"https://api.github.com/users/yihui/events{/privacy}","received_events_url":"https://api.github.com/users/yihui/received_events","type":"User","site_admin":false},"body":"Okay great!","created_at":"2016-11-01T16:28:23Z","updated_at":"2016-11-01T16:28:23Z","html_url":"https://github.com/rstudio/htmltools/pull/71#discussion_r85965362","pull_request_url":"https://api.github.com/repos/rstudio/htmltools/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/rstudio/htmltools/pulls/comments/85965362"},"html":{"href":"https://github.com/rstudio/htmltools/pull/71#discussion_r85965362"},"pull_request":{"href":"https://api.github.com/repos/rstudio/htmltools/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/rstudio/htmltools/pulls/71","id":87429648,"html_url":"https://github.com/rstudio/htmltools/pull/71","diff_url":"https://github.com/rstudio/htmltools/pull/71.diff","patch_url":"https://github.com/rstudio/htmltools/pull/71.patch","issue_url":"https://api.github.com/repos/rstudio/htmltools/issues/71","number":71,"state":"closed","locked":false,"title":"Fix encoding issue on Windows","user":{"login":"wch","id":86978,"avatar_url":"https://avatars.githubusercontent.com/u/86978?v=3","gravatar_id":"","url":"https://api.github.com/users/wch","html_url":"https://github.com/wch","followers_url":"https://api.github.com/users/wch/followers","following_url":"https://api.github.com/users/wch/following{/other_user}","gists_url":"https://api.github.com/users/wch/gists{/gist_id}","starred_url":"https://api.github.com/users/wch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wch/subscriptions","organizations_url":"https://api.github.com/users/wch/orgs","repos_url":"https://api.github.com/users/wch/repos","events_url":"https://api.github.com/users/wch/events{/privacy}","received_events_url":"https://api.github.com/users/wch/received_events","type":"User","site_admin":false},"body":"This fixes #69.\n","created_at":"2016-09-30T03:35:13Z","updated_at":"2016-11-01T16:28:23Z","closed_at":"2016-09-30T19:41:14Z","merged_at":"2016-09-30T19:41:14Z","merge_commit_sha":"4fbf9904dea3554db660f3efdd46503482b343a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rstudio/htmltools/pulls/71/commits","review_comments_url":"https://api.github.com/repos/rstudio/htmltools/pulls/71/comments","review_comment_url":"https://api.github.com/repos/rstudio/htmltools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rstudio/htmltools/issues/71/comments","statuses_url":"https://api.github.com/repos/rstudio/htmltools/statuses/810fa61eba84fbc8d808fc79acd929c54f9e2d59","head":{"label":"rstudio:fix-encoding","ref":"fix-encoding","sha":"810fa61eba84fbc8d808fc79acd929c54f9e2d59","user":{"login":"rstudio","id":513560,"avatar_url":"https://avatars.githubusercontent.com/u/513560?v=3","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":18398793,"name":"htmltools","full_name":"rstudio/htmltools","owner":{"login":"rstudio","id":513560,"avatar_url":"https://avatars.githubusercontent.com/u/513560?v=3","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rstudio/htmltools","description":null,"fork":false,"url":"https://api.github.com/repos/rstudio/htmltools","forks_url":"https://api.github.com/repos/rstudio/htmltools/forks","keys_url":"https://api.github.com/repos/rstudio/htmltools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/htmltools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/htmltools/teams","hooks_url":"https://api.github.com/repos/rstudio/htmltools/hooks","issue_events_url":"https://api.github.com/repos/rstudio/htmltools/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/htmltools/events","assignees_url":"https://api.github.com/repos/rstudio/htmltools/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/htmltools/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/htmltools/tags","blobs_url":"https://api.github.com/repos/rstudio/htmltools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/htmltools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/htmltools/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/htmltools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/htmltools/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/htmltools/languages","stargazers_url":"https://api.github.com/repos/rstudio/htmltools/stargazers","contributors_url":"https://api.github.com/repos/rstudio/htmltools/contributors","subscribers_url":"https://api.github.com/repos/rstudio/htmltools/subscribers","subscription_url":"https://api.github.com/repos/rstudio/htmltools/subscription","commits_url":"https://api.github.com/repos/rstudio/htmltools/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/htmltools/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/htmltools/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/htmltools/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/htmltools/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/htmltools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/htmltools/merges","archive_url":"https://api.github.com/repos/rstudio/htmltools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/htmltools/downloads","issues_url":"https://api.github.com/repos/rstudio/htmltools/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/htmltools/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/htmltools/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/htmltools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/htmltools/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/htmltools/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/htmltools/deployments","created_at":"2014-04-03T10:11:03Z","updated_at":"2016-10-21T02:35:07Z","pushed_at":"2016-10-20T18:46:38Z","git_url":"git://github.com/rstudio/htmltools.git","ssh_url":"git@github.com:rstudio/htmltools.git","clone_url":"https://github.com/rstudio/htmltools.git","svn_url":"https://github.com/rstudio/htmltools","homepage":null,"size":422,"stargazers_count":25,"watchers_count":25,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":13,"forks":19,"open_issues":13,"watchers":25,"default_branch":"master"}},"base":{"label":"rstudio:master","ref":"master","sha":"9bd279fcf48fc6233bd023bf91eb3dd7788e46c1","user":{"login":"rstudio","id":513560,"avatar_url":"https://avatars.githubusercontent.com/u/513560?v=3","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":18398793,"name":"htmltools","full_name":"rstudio/htmltools","owner":{"login":"rstudio","id":513560,"avatar_url":"https://avatars.githubusercontent.com/u/513560?v=3","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rstudio/htmltools","description":null,"fork":false,"url":"https://api.github.com/repos/rstudio/htmltools","forks_url":"https://api.github.com/repos/rstudio/htmltools/forks","keys_url":"https://api.github.com/repos/rstudio/htmltools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/htmltools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/htmltools/teams","hooks_url":"https://api.github.com/repos/rstudio/htmltools/hooks","issue_events_url":"https://api.github.com/repos/rstudio/htmltools/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/htmltools/events","assignees_url":"https://api.github.com/repos/rstudio/htmltools/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/htmltools/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/htmltools/tags","blobs_url":"https://api.github.com/repos/rstudio/htmltools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/htmltools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/htmltools/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/htmltools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/htmltools/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/htmltools/languages","stargazers_url":"https://api.github.com/repos/rstudio/htmltools/stargazers","contributors_url":"https://api.github.com/repos/rstudio/htmltools/contributors","subscribers_url":"https://api.github.com/repos/rstudio/htmltools/subscribers","subscription_url":"https://api.github.com/repos/rstudio/htmltools/subscription","commits_url":"https://api.github.com/repos/rstudio/htmltools/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/htmltools/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/htmltools/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/htmltools/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/htmltools/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/htmltools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/htmltools/merges","archive_url":"https://api.github.com/repos/rstudio/htmltools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/htmltools/downloads","issues_url":"https://api.github.com/repos/rstudio/htmltools/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/htmltools/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/htmltools/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/htmltools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/htmltools/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/htmltools/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/htmltools/deployments","created_at":"2014-04-03T10:11:03Z","updated_at":"2016-10-21T02:35:07Z","pushed_at":"2016-10-20T18:46:38Z","git_url":"git://github.com/rstudio/htmltools.git","ssh_url":"git@github.com:rstudio/htmltools.git","clone_url":"https://github.com/rstudio/htmltools.git","svn_url":"https://github.com/rstudio/htmltools","homepage":null,"size":422,"stargazers_count":25,"watchers_count":25,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":13,"forks":19,"open_issues":13,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rstudio/htmltools/pulls/71"},"html":{"href":"https://github.com/rstudio/htmltools/pull/71"},"issue":{"href":"https://api.github.com/repos/rstudio/htmltools/issues/71"},"comments":{"href":"https://api.github.com/repos/rstudio/htmltools/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/rstudio/htmltools/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/rstudio/htmltools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rstudio/htmltools/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/rstudio/htmltools/statuses/810fa61eba84fbc8d808fc79acd929c54f9e2d59"}}}}
{"actor":{"display_login":"yihui"}}