{"action":"created","comment":{"url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/comments/65294093","id":65294093,"diff_hunk":"@@ -106,16 +106,18 @@ def create_asg(self, title, minsize, maxsize, subnets, load_balancer, keypair, i\n                 self.sns_notification_configurations = self.trop_asg.NotificationConfigurations = \\\n                     [NotificationConfigurations(TopicARN=sns_topic_arn, NotificationTypes=sns_notification_types)]\n             else:\n-                raise MalformedSNSError(\"Error: sns_notification_types must be a non null list.\")\n+                raise MalformedSNSError('Error: sns_notification_types must be a non null list.')\n \n         self.trop_asg.LaunchConfigurationName = Ref(self.create_launch_config(\n             title=title,\n             keypair=keypair,\n             image_id=image_id,\n             instance_type=instance_type,\n             iam_instance_profile_arn=iam_instance_profile_arn,\n-            userdata=userdata if userdata is not None else \"\"","path":"amazonia/classes/asg.py","position":22,"original_position":22,"commit_id":"04edaf3025f55a701fcd746564cc38bb8f007bf3","original_commit_id":"04edaf3025f55a701fcd746564cc38bb8f007bf3","user":{"login":"snayler0","id":7955220,"avatar_url":"https://avatars.githubusercontent.com/u/7955220?v=3","gravatar_id":"","url":"https://api.github.com/users/snayler0","html_url":"https://github.com/snayler0","followers_url":"https://api.github.com/users/snayler0/followers","following_url":"https://api.github.com/users/snayler0/following{/other_user}","gists_url":"https://api.github.com/users/snayler0/gists{/gist_id}","starred_url":"https://api.github.com/users/snayler0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snayler0/subscriptions","organizations_url":"https://api.github.com/users/snayler0/orgs","repos_url":"https://api.github.com/users/snayler0/repos","events_url":"https://api.github.com/users/snayler0/events{/privacy}","received_events_url":"https://api.github.com/users/snayler0/received_events","type":"User","site_admin":false},"body":"I thought it might be better to remove the userdata=userdata line (117) here entirely and then just assign it in the if statement below?\r\n\r\neg: `self.trop_asg.LaunchConfigurationName.userdata = userdata if userdata is not None`","created_at":"2016-06-01T02:29:12Z","updated_at":"2016-06-01T02:29:12Z","html_url":"https://github.com/GeoscienceAustralia/amazonia/pull/10#discussion_r65294093","pull_request_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/comments/65294093"},"html":{"href":"https://github.com/GeoscienceAustralia/amazonia/pull/10#discussion_r65294093"},"pull_request":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10","id":72103192,"html_url":"https://github.com/GeoscienceAustralia/amazonia/pull/10","diff_url":"https://github.com/GeoscienceAustralia/amazonia/pull/10.diff","patch_url":"https://github.com/GeoscienceAustralia/amazonia/pull/10.patch","issue_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/10","number":10,"state":"open","locked":false,"title":"Amazonia Walkthrough Fixes","user":{"login":"fuddstar","id":11380594,"avatar_url":"https://avatars.githubusercontent.com/u/11380594?v=3","gravatar_id":"","url":"https://api.github.com/users/fuddstar","html_url":"https://github.com/fuddstar","followers_url":"https://api.github.com/users/fuddstar/followers","following_url":"https://api.github.com/users/fuddstar/following{/other_user}","gists_url":"https://api.github.com/users/fuddstar/gists{/gist_id}","starred_url":"https://api.github.com/users/fuddstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuddstar/subscriptions","organizations_url":"https://api.github.com/users/fuddstar/orgs","repos_url":"https://api.github.com/users/fuddstar/repos","events_url":"https://api.github.com/users/fuddstar/events{/privacy}","received_events_url":"https://api.github.com/users/fuddstar/received_events","type":"User","site_admin":false},"body":"Replace inappropriate docstrings with hash comments\r\nAllow asg to take empty userdata\r\nRemove equals equals thing from RDS\r\nDouble quotes to single quotes\r\n\r\nBamboo build passing https://gaautobots.atlassian.net/builds/browse/PIPE-AT72-4","created_at":"2016-05-31T23:43:46Z","updated_at":"2016-06-01T02:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03e2be71c0f7bcf00b42ac23b53c05f2274c081b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10/commits","review_comments_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10/comments","review_comment_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/10/comments","statuses_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/statuses/04edaf3025f55a701fcd746564cc38bb8f007bf3","head":{"label":"GeoscienceAustralia:dev-amazonia-fixes-AUTO-556-fudd","ref":"dev-amazonia-fixes-AUTO-556-fudd","sha":"04edaf3025f55a701fcd746564cc38bb8f007bf3","user":{"login":"GeoscienceAustralia","id":4704285,"avatar_url":"https://avatars.githubusercontent.com/u/4704285?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"repo":{"id":59636467,"name":"amazonia","full_name":"GeoscienceAustralia/amazonia","owner":{"login":"GeoscienceAustralia","id":4704285,"avatar_url":"https://avatars.githubusercontent.com/u/4704285?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GeoscienceAustralia/amazonia","description":"A pattern based AWS CloudFormation generator","fork":false,"url":"https://api.github.com/repos/GeoscienceAustralia/amazonia","forks_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/forks","keys_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/teams","hooks_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/hooks","issue_events_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/events{/number}","events_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/events","assignees_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/assignees{/user}","branches_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/branches{/branch}","tags_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/tags","blobs_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/languages","stargazers_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/stargazers","contributors_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/contributors","subscribers_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/subscribers","subscription_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/subscription","commits_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/contents/{+path}","compare_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/merges","archive_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/downloads","issues_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues{/number}","pulls_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/labels{/name}","releases_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/releases{/id}","deployments_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/deployments","created_at":"2016-05-25T06:21:48Z","updated_at":"2016-05-25T06:31:58Z","pushed_at":"2016-06-01T02:19:10Z","git_url":"git://github.com/GeoscienceAustralia/amazonia.git","ssh_url":"git@github.com:GeoscienceAustralia/amazonia.git","clone_url":"https://github.com/GeoscienceAustralia/amazonia.git","svn_url":"https://github.com/GeoscienceAustralia/amazonia","homepage":null,"size":256,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"GeoscienceAustralia:integration","ref":"integration","sha":"cdfcb7a8cf8cb0f70dc34ebf92680d8dd1790cac","user":{"login":"GeoscienceAustralia","id":4704285,"avatar_url":"https://avatars.githubusercontent.com/u/4704285?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"repo":{"id":59636467,"name":"amazonia","full_name":"GeoscienceAustralia/amazonia","owner":{"login":"GeoscienceAustralia","id":4704285,"avatar_url":"https://avatars.githubusercontent.com/u/4704285?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GeoscienceAustralia/amazonia","description":"A pattern based AWS CloudFormation generator","fork":false,"url":"https://api.github.com/repos/GeoscienceAustralia/amazonia","forks_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/forks","keys_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/teams","hooks_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/hooks","issue_events_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/events{/number}","events_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/events","assignees_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/assignees{/user}","branches_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/branches{/branch}","tags_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/tags","blobs_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/languages","stargazers_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/stargazers","contributors_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/contributors","subscribers_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/subscribers","subscription_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/subscription","commits_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/contents/{+path}","compare_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/merges","archive_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/downloads","issues_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues{/number}","pulls_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/labels{/name}","releases_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/releases{/id}","deployments_url":"https://api.github.com/repos/GeoscienceAustralia/amazonia/deployments","created_at":"2016-05-25T06:21:48Z","updated_at":"2016-05-25T06:31:58Z","pushed_at":"2016-06-01T02:19:10Z","git_url":"git://github.com/GeoscienceAustralia/amazonia.git","ssh_url":"git@github.com:GeoscienceAustralia/amazonia.git","clone_url":"https://github.com/GeoscienceAustralia/amazonia.git","svn_url":"https://github.com/GeoscienceAustralia/amazonia","homepage":null,"size":256,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10"},"html":{"href":"https://github.com/GeoscienceAustralia/amazonia/pull/10"},"issue":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/10"},"comments":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/GeoscienceAustralia/amazonia/statuses/04edaf3025f55a701fcd746564cc38bb8f007bf3"}}}}
{"actor":{"display_login":"snayler0"}}