{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/650","repository_url":"https://api.github.com/repos/wikimedia/wikipedia-ios","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/650/comments","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/650/events","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/650","id":146661662,"number":650,"title":"(Text) Size Matters","user":{"login":"coreyfloyd","id":64771,"avatar_url":"https://avatars.githubusercontent.com/u/64771?v=3","gravatar_id":"","url":"https://api.github.com/users/coreyfloyd","html_url":"https://github.com/coreyfloyd","followers_url":"https://api.github.com/users/coreyfloyd/followers","following_url":"https://api.github.com/users/coreyfloyd/following{/other_user}","gists_url":"https://api.github.com/users/coreyfloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyfloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyfloyd/subscriptions","organizations_url":"https://api.github.com/users/coreyfloyd/orgs","repos_url":"https://api.github.com/users/coreyfloyd/repos","events_url":"https://api.github.com/users/coreyfloyd/events{/privacy}","received_events_url":"https://api.github.com/users/coreyfloyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-07T15:36:11Z","updated_at":"2016-04-07T23:09:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/650","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/650","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/650.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/650.patch"},"body":"Adding text size slider / popup\r\n\r\nThe text setting implementation was based on @montehurd's spike work.\r\n\r\nNot much else to say, used some Pods… couldn't use the PopoverViewController because that won't display as a popup on iPhones.\r\n\r\nYou can play with the step values in the Developer settings (Tweaks) menu under \"Article\"\r\n\r\n![text size](https://cloud.githubusercontent.com/assets/64771/14356907/978c0a34-fcb4-11e5-8986-48043cbcddd2.gif)"},"comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments/207132930","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/650#issuecomment-207132930","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/650","id":207132930,"user":{"login":"coreyfloyd","id":64771,"avatar_url":"https://avatars.githubusercontent.com/u/64771?v=3","gravatar_id":"","url":"https://api.github.com/users/coreyfloyd","html_url":"https://github.com/coreyfloyd","followers_url":"https://api.github.com/users/coreyfloyd/followers","following_url":"https://api.github.com/users/coreyfloyd/following{/other_user}","gists_url":"https://api.github.com/users/coreyfloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyfloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyfloyd/subscriptions","organizations_url":"https://api.github.com/users/coreyfloyd/orgs","repos_url":"https://api.github.com/users/coreyfloyd/repos","events_url":"https://api.github.com/users/coreyfloyd/events{/privacy}","received_events_url":"https://api.github.com/users/coreyfloyd/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T23:09:38Z","updated_at":"2016-04-07T23:09:38Z","body":"> @coreyfloyd crash on iOS 9.3 after peeking and popping a couple web view links.\r\n\r\nFinally able to repro: So not related to this patch:\r\n\r\n```\r\n2016-04-07 19:04:08.506 Wikipedia Debug[7584:2723377] *** Assertion failure in -[WMFArticleViewController initWithArticleTitle:dataStore:], /Users/cfloyd/Dropbox/Development/wikipedia-ios/Wikipedia/Code/WMFArticleViewController.m:133\r\n2016-04-07 19:04:08.514 Wikipedia Debug[7584:2723377] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: title'\r\nlibc++abi.dylib: terminating with uncaught exception of type NSException\r\n```\r\n\r\nIt says the article VC isn't being instantiated with a title. So something with peeks and pops… filling a bug ticket.\r\n\r\n(Note: since this is an assertion, you won't see a crash in production)\r\n\r\nTL;DR relevant method:\r\n```\r\n- (instancetype)initWithArticleTitle:(MWKTitle*)title\r\n                           dataStore:(MWKDataStore*)dataStore {\r\n    NSParameterAssert(title);\r\n    NSParameterAssert(dataStore);\r\n\r\n    self = [super init];\r\n    if (self) {\r\n        self.articleTitle             = title;\r\n        self.dataStore                = dataStore;\r\n        self.hidesBottomBarWhenPushed = YES;\r\n    }\r\n    return self;\r\n}\r\n```\r\n\r\n\r\n\r\n"}}