{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6274","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6274/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6274/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6274/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6274","id":131116203,"number":6274,"title":"[MRG] MAINT: Make sure all tests are included with installation","user":{"login":"jakevdp","id":781659,"avatar_url":"https://avatars.githubusercontent.com/u/781659?v=3","gravatar_id":"","url":"https://api.github.com/users/jakevdp","html_url":"https://github.com/jakevdp","followers_url":"https://api.github.com/users/jakevdp/followers","following_url":"https://api.github.com/users/jakevdp/following{/other_user}","gists_url":"https://api.github.com/users/jakevdp/gists{/gist_id}","starred_url":"https://api.github.com/users/jakevdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakevdp/subscriptions","organizations_url":"https://api.github.com/users/jakevdp/orgs","repos_url":"https://api.github.com/users/jakevdp/repos","events_url":"https://api.github.com/users/jakevdp/events{/privacy}","received_events_url":"https://api.github.com/users/jakevdp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-03T18:42:57Z","updated_at":"2016-02-04T14:22:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6274","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6274","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6274.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6274.patch"},"body":"As I mentioned in #6273, the build scripts leave out several of the test modules, so when you run ``nosetests sklearn`` outside the source tree not all the tests are run.\r\n\r\nI looked into this and found ~6 submodules that had this issue. In the process of fixing all of them, I found it easier to re-organize and alphabetize portions of the setup file.\r\n\r\nI also chose to have all submodules with a setup script import their own sub-submodules. Previously, there was a mix of doing the additions locally and doing the additions at the top level."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/179866227","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6274#issuecomment-179866227","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6274","id":179866227,"user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T14:22:38Z","updated_at":"2016-02-04T14:22:38Z","body":"> So what's the way forward here? Should I try to fix the test failures as part of this PR before we merge? The failing code is already in master, it's just not being reflected in the CI tests at the moment.\r\n\r\nThe problem if we merge is that the failures notification will hide new failures in PR. So I would rather like to fix the failures before merging. Let's make a list of them as new issues linked to this PR."}}