{"action":"created","issue":{"url":"https://api.github.com/repos/erikras/redux-form/issues/1929","repository_url":"https://api.github.com/repos/erikras/redux-form","labels_url":"https://api.github.com/repos/erikras/redux-form/issues/1929/labels{/name}","comments_url":"https://api.github.com/repos/erikras/redux-form/issues/1929/comments","events_url":"https://api.github.com/repos/erikras/redux-form/issues/1929/events","html_url":"https://github.com/erikras/redux-form/issues/1929","id":181819575,"number":1929,"title":"[6.1.0] Form has been submitted even when async validation fails","user":{"login":"diegohaz","id":3068563,"avatar_url":"https://avatars.githubusercontent.com/u/3068563?v=3","gravatar_id":"","url":"https://api.github.com/users/diegohaz","html_url":"https://github.com/diegohaz","followers_url":"https://api.github.com/users/diegohaz/followers","following_url":"https://api.github.com/users/diegohaz/following{/other_user}","gists_url":"https://api.github.com/users/diegohaz/gists{/gist_id}","starred_url":"https://api.github.com/users/diegohaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegohaz/subscriptions","organizations_url":"https://api.github.com/users/diegohaz/orgs","repos_url":"https://api.github.com/users/diegohaz/repos","events_url":"https://api.github.com/users/diegohaz/events{/privacy}","received_events_url":"https://api.github.com/users/diegohaz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-08T10:56:38Z","updated_at":"2016-10-08T11:06:20Z","closed_at":null,"body":"In #1843, this change was made: https://github.com/elodszopos/redux-form/commit/73d60f8a75512e8b0fe16d3884f10f6994be8bd9\r\n\r\nThe test passes because [it still returns a rejected promise](https://github.com/erikras/redux-form/blob/f6e1fb9316f6201f259d0ce761908618513f2e0c/src/__tests__/handleSubmit.spec.js#L103)\r\n\r\nAlso, this test needs to be rewritten, because even if you return a resolved promise it passes (`catch` doesn't run)."},"comment":{"url":"https://api.github.com/repos/erikras/redux-form/issues/comments/252418695","html_url":"https://github.com/erikras/redux-form/issues/1929#issuecomment-252418695","issue_url":"https://api.github.com/repos/erikras/redux-form/issues/1929","id":252418695,"user":{"login":"diegohaz","id":3068563,"avatar_url":"https://avatars.githubusercontent.com/u/3068563?v=3","gravatar_id":"","url":"https://api.github.com/users/diegohaz","html_url":"https://github.com/diegohaz","followers_url":"https://api.github.com/users/diegohaz/followers","following_url":"https://api.github.com/users/diegohaz/following{/other_user}","gists_url":"https://api.github.com/users/diegohaz/gists{/gist_id}","starred_url":"https://api.github.com/users/diegohaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegohaz/subscriptions","organizations_url":"https://api.github.com/users/diegohaz/orgs","repos_url":"https://api.github.com/users/diegohaz/repos","events_url":"https://api.github.com/users/diegohaz/events{/privacy}","received_events_url":"https://api.github.com/users/diegohaz/received_events","type":"User","site_admin":false},"created_at":"2016-10-08T11:06:20Z","updated_at":"2016-10-08T11:06:20Z","body":"A possible solution would be verifying if asyncValidation has returned something other than undefined, but I think it would be better to revert the PR. Uncaught promises isn't that thing."}}
{"actor":{"display_login":"diegohaz"}}