{"action":"created","comment":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/75069518","id":75069518,"diff_hunk":"@@ -471,14 +471,30 @@ bool CCTagLocalizer::localizeRig(const std::vector<std::unique_ptr<features::Reg\n                                  std::vector<LocalizationResult>& vec_locResults)\n {\n #ifdef HAVE_OPENGV\n-  return localizeRig_opengv(vec_queryRegions,\n-                            vec_imageSize,\n-                            parameters,\n-                            vec_queryIntrinsics,\n-                            vec_subPoses,\n-                            rigPose,\n-                            vec_locResults);\n+  if(parameters->_useLocalizeRigNaive)","path":"src/openMVG/localization/CCTagLocalizer.cpp","position":23,"original_position":23,"commit_id":"5d956becace7c5190d8d95cd8d43509ea80bdd31","original_commit_id":"5d956becace7c5190d8d95cd8d43509ea80bdd31","user":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"body":"Oh yeah, stupid proposition, new try:\r\n```\r\n#ifdef HAVE_OPENGV\r\nif(!parameters->_useLocalizeRigNaive)\r\n{\r\n  return localizeRig_opengv(xxx);\r\n}\r\nelse\r\n#endif\r\n{\r\n  if(!parameters->_useLocalizeRigNaive)\r\n    POPART_COUT(\"OpenGV is not available. Fallback to localizeRig_naive().\");\r\n  return localizeRig_naive(xxx);\r\n}\r\n```","created_at":"2016-08-17T06:42:07Z","updated_at":"2016-08-17T06:42:07Z","html_url":"https://github.com/poparteu/openMVG/pull/220#discussion_r75069518","pull_request_url":"https://api.github.com/repos/poparteu/openMVG/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/75069518"},"html":{"href":"https://github.com/poparteu/openMVG/pull/220#discussion_r75069518"},"pull_request":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/220","id":81181639,"html_url":"https://github.com/poparteu/openMVG/pull/220","diff_url":"https://github.com/poparteu/openMVG/pull/220.diff","patch_url":"https://github.com/poparteu/openMVG/pull/220.patch","issue_url":"https://api.github.com/repos/poparteu/openMVG/issues/220","number":220,"state":"open","locked":false,"title":"[WIP] some fixes for rig localization / calibration","user":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"body":"* `localizeRig_naive()` always available and can be forced at run-time with a param switch\r\n* added missing `refineRig()`\r\n* bugFix (poparteu/openMVG##216) for CCTagLocalizer","created_at":"2016-08-12T20:53:46Z","updated_at":"2016-08-17T06:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eb3042db0b08f3adf391a0caf54a3786a016b57","assignee":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/poparteu/openMVG/milestones/14","html_url":"https://github.com/poparteu/openMVG/milestones/2016_08","labels_url":"https://api.github.com/repos/poparteu/openMVG/milestones/14/labels","id":1812937,"number":14,"title":"2016_08","description":"","creator":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":15,"state":"open","created_at":"2016-06-07T08:43:54Z","updated_at":"2016-08-12T20:53:46Z","due_on":"2016-08-31T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/poparteu/openMVG/pulls/220/commits","review_comments_url":"https://api.github.com/repos/poparteu/openMVG/pulls/220/comments","review_comment_url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poparteu/openMVG/issues/220/comments","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/5d956becace7c5190d8d95cd8d43509ea80bdd31","head":{"label":"poparteu:dev_fixesRig","ref":"dev_fixesRig","sha":"5d956becace7c5190d8d95cd8d43509ea80bdd31","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/poparteu/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2016-08-10T11:18:00Z","pushed_at":"2016-08-16T22:10:05Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":25059,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":56,"forks":2,"open_issues":56,"watchers":3,"default_branch":"popart_develop"}},"base":{"label":"poparteu:popart_develop","ref":"popart_develop","sha":"0eadbd2ba505842def5b121fa64ebc1f1666da34","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/poparteu/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2016-08-10T11:18:00Z","pushed_at":"2016-08-16T22:10:05Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":25059,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":56,"forks":2,"open_issues":56,"watchers":3,"default_branch":"popart_develop"}},"_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/220"},"html":{"href":"https://github.com/poparteu/openMVG/pull/220"},"issue":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/220"},"comments":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/poparteu/openMVG/statuses/5d956becace7c5190d8d95cd8d43509ea80bdd31"}}}}
{"actor":{"display_login":"fabiencastan"}}