{"action":"closed","issue":{"url":"https://api.github.com/repos/charlierudolph/dependency-lint/issues/36","repository_url":"https://api.github.com/repos/charlierudolph/dependency-lint","labels_url":"https://api.github.com/repos/charlierudolph/dependency-lint/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/charlierudolph/dependency-lint/issues/36/comments","events_url":"https://api.github.com/repos/charlierudolph/dependency-lint/issues/36/events","html_url":"https://github.com/charlierudolph/dependency-lint/issues/36","id":185482133,"number":36,"title":"Make --auto-correct only return an error code if uncorrected errors remain","user":{"login":"nfriedly","id":114976,"avatar_url":"https://avatars.githubusercontent.com/u/114976?v=3","gravatar_id":"","url":"https://api.github.com/users/nfriedly","html_url":"https://github.com/nfriedly","followers_url":"https://api.github.com/users/nfriedly/followers","following_url":"https://api.github.com/users/nfriedly/following{/other_user}","gists_url":"https://api.github.com/users/nfriedly/gists{/gist_id}","starred_url":"https://api.github.com/users/nfriedly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfriedly/subscriptions","organizations_url":"https://api.github.com/users/nfriedly/orgs","repos_url":"https://api.github.com/users/nfriedly/repos","events_url":"https://api.github.com/users/nfriedly/events{/privacy}","received_events_url":"https://api.github.com/users/nfriedly/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-26T19:05:43Z","updated_at":"2016-12-27T18:15:22Z","closed_at":"2016-12-27T18:15:22Z","body":"I can see an argument for the current behavior, but I think that dependency-lint --auto-correct should work similar to eslint . --fix in that fixed errors do not count against the total errors, and if all errors were successfully fixed, then it should return 0 (no error).\n\nRather then ending with \"✖ 1 error\", it could say\n\n✓ 1 correction\n✓ 0 errors\n\nFor the moment, I'm currently putting dependency-lint --auto-correct || dependency-lint in my npm script.\n\nBTW, this is a great tool either way, and I'm definitely going to be using it in more projects.\n"}}
{"actor":{"display_login":"charlierudolph"}}