{"action":"created","comment":{"url":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments/90963336","pull_request_review_id":11476808,"id":90963336,"diff_hunk":"@@ -0,0 +1,330 @@\n+# This manifest installs the per-node agents, as well\n+# as the CNI plugins and network config on\n+# each master and worker node in a Kubernetes cluster.\n+kind: DaemonSet\n+apiVersion: extensions/v1beta1\n+metadata:\n+  name: canal-node\n+  namespace: kube-system\n+  labels:\n+    k8s-app: canal-node\n+spec:\n+  selector:\n+    matchLabels:\n+      k8s-app: canal-node\n+  template:\n+    metadata:\n+      annotations:\n+        scheduler.alpha.kubernetes.io/critical-pod: ''\n+        scheduler.alpha.kubernetes.io/tolerations: '[{\"key\":\"CriticalAddonsOnly\", \"operator\":\"Exists\"}]'\n+      labels:\n+        k8s-app: canal-node\n+    spec:\n+      hostNetwork: true\n+      containers:\n+        # Runs the flannel daemon to enable vxlan networking between","path":"ansible/roles/kraken.fabric/kraken.fabric.flannel/templates/canal.yaml.part.jinja2","position":25,"original_position":25,"commit_id":"6d8a7b43a7ccf2a49f331ca239a418d88e27b2ca","original_commit_id":"6d8a7b43a7ccf2a49f331ca239a418d88e27b2ca","user":{"login":"venezia","id":6701146,"avatar_url":"https://avatars.githubusercontent.com/u/6701146?v=3","gravatar_id":"","url":"https://api.github.com/users/venezia","html_url":"https://github.com/venezia","followers_url":"https://api.github.com/users/venezia/followers","following_url":"https://api.github.com/users/venezia/following{/other_user}","gists_url":"https://api.github.com/users/venezia/gists{/gist_id}","starred_url":"https://api.github.com/users/venezia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venezia/subscriptions","organizations_url":"https://api.github.com/users/venezia/orgs","repos_url":"https://api.github.com/users/venezia/repos","events_url":"https://api.github.com/users/venezia/events{/privacy}","received_events_url":"https://api.github.com/users/venezia/received_events","type":"User","site_admin":false},"body":"Probably should defer to Canal team for that answer","created_at":"2016-12-05T21:50:05Z","updated_at":"2016-12-05T21:50:05Z","html_url":"https://github.com/samsung-cnct/k2/pull/111#discussion_r90963336","pull_request_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments/90963336"},"html":{"href":"https://github.com/samsung-cnct/k2/pull/111#discussion_r90963336"},"pull_request":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/samsung-cnct/k2/pulls/111","id":96598989,"html_url":"https://github.com/samsung-cnct/k2/pull/111","diff_url":"https://github.com/samsung-cnct/k2/pull/111.diff","patch_url":"https://github.com/samsung-cnct/k2/pull/111.patch","issue_url":"https://api.github.com/repos/samsung-cnct/k2/issues/111","number":111,"state":"open","locked":false,"title":"Self hosted fabric","user":{"login":"venezia","id":6701146,"avatar_url":"https://avatars.githubusercontent.com/u/6701146?v=3","gravatar_id":"","url":"https://api.github.com/users/venezia","html_url":"https://github.com/venezia","followers_url":"https://api.github.com/users/venezia/followers","following_url":"https://api.github.com/users/venezia/following{/other_user}","gists_url":"https://api.github.com/users/venezia/gists{/gist_id}","starred_url":"https://api.github.com/users/venezia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venezia/subscriptions","organizations_url":"https://api.github.com/users/venezia/orgs","repos_url":"https://api.github.com/users/venezia/repos","events_url":"https://api.github.com/users/venezia/events{/privacy}","received_events_url":"https://api.github.com/users/venezia/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-05T20:02:48Z","updated_at":"2016-12-05T21:50:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee69ad62dd291c673ab940f72d5ca692388baeef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/111/commits","review_comments_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/111/comments","review_comment_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsung-cnct/k2/issues/111/comments","statuses_url":"https://api.github.com/repos/samsung-cnct/k2/statuses/6d8a7b43a7ccf2a49f331ca239a418d88e27b2ca","head":{"label":"venezia:self_hosted_fabric","ref":"self_hosted_fabric","sha":"6d8a7b43a7ccf2a49f331ca239a418d88e27b2ca","user":{"login":"venezia","id":6701146,"avatar_url":"https://avatars.githubusercontent.com/u/6701146?v=3","gravatar_id":"","url":"https://api.github.com/users/venezia","html_url":"https://github.com/venezia","followers_url":"https://api.github.com/users/venezia/followers","following_url":"https://api.github.com/users/venezia/following{/other_user}","gists_url":"https://api.github.com/users/venezia/gists{/gist_id}","starred_url":"https://api.github.com/users/venezia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venezia/subscriptions","organizations_url":"https://api.github.com/users/venezia/orgs","repos_url":"https://api.github.com/users/venezia/repos","events_url":"https://api.github.com/users/venezia/events{/privacy}","received_events_url":"https://api.github.com/users/venezia/received_events","type":"User","site_admin":false},"repo":{"id":69517819,"name":"k2","full_name":"venezia/k2","owner":{"login":"venezia","id":6701146,"avatar_url":"https://avatars.githubusercontent.com/u/6701146?v=3","gravatar_id":"","url":"https://api.github.com/users/venezia","html_url":"https://github.com/venezia","followers_url":"https://api.github.com/users/venezia/followers","following_url":"https://api.github.com/users/venezia/following{/other_user}","gists_url":"https://api.github.com/users/venezia/gists{/gist_id}","starred_url":"https://api.github.com/users/venezia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venezia/subscriptions","organizations_url":"https://api.github.com/users/venezia/orgs","repos_url":"https://api.github.com/users/venezia/repos","events_url":"https://api.github.com/users/venezia/events{/privacy}","received_events_url":"https://api.github.com/users/venezia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/venezia/k2","description":"K2 (Kraken 2)","fork":true,"url":"https://api.github.com/repos/venezia/k2","forks_url":"https://api.github.com/repos/venezia/k2/forks","keys_url":"https://api.github.com/repos/venezia/k2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/venezia/k2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/venezia/k2/teams","hooks_url":"https://api.github.com/repos/venezia/k2/hooks","issue_events_url":"https://api.github.com/repos/venezia/k2/issues/events{/number}","events_url":"https://api.github.com/repos/venezia/k2/events","assignees_url":"https://api.github.com/repos/venezia/k2/assignees{/user}","branches_url":"https://api.github.com/repos/venezia/k2/branches{/branch}","tags_url":"https://api.github.com/repos/venezia/k2/tags","blobs_url":"https://api.github.com/repos/venezia/k2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/venezia/k2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/venezia/k2/git/refs{/sha}","trees_url":"https://api.github.com/repos/venezia/k2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/venezia/k2/statuses/{sha}","languages_url":"https://api.github.com/repos/venezia/k2/languages","stargazers_url":"https://api.github.com/repos/venezia/k2/stargazers","contributors_url":"https://api.github.com/repos/venezia/k2/contributors","subscribers_url":"https://api.github.com/repos/venezia/k2/subscribers","subscription_url":"https://api.github.com/repos/venezia/k2/subscription","commits_url":"https://api.github.com/repos/venezia/k2/commits{/sha}","git_commits_url":"https://api.github.com/repos/venezia/k2/git/commits{/sha}","comments_url":"https://api.github.com/repos/venezia/k2/comments{/number}","issue_comment_url":"https://api.github.com/repos/venezia/k2/issues/comments{/number}","contents_url":"https://api.github.com/repos/venezia/k2/contents/{+path}","compare_url":"https://api.github.com/repos/venezia/k2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/venezia/k2/merges","archive_url":"https://api.github.com/repos/venezia/k2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/venezia/k2/downloads","issues_url":"https://api.github.com/repos/venezia/k2/issues{/number}","pulls_url":"https://api.github.com/repos/venezia/k2/pulls{/number}","milestones_url":"https://api.github.com/repos/venezia/k2/milestones{/number}","notifications_url":"https://api.github.com/repos/venezia/k2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/venezia/k2/labels{/name}","releases_url":"https://api.github.com/repos/venezia/k2/releases{/id}","deployments_url":"https://api.github.com/repos/venezia/k2/deployments","created_at":"2016-09-29T01:18:49Z","updated_at":"2016-12-01T19:37:58Z","pushed_at":"2016-12-05T20:15:34Z","git_url":"git://github.com/venezia/k2.git","ssh_url":"git@github.com:venezia/k2.git","clone_url":"https://github.com/venezia/k2.git","svn_url":"https://github.com/venezia/k2","homepage":null,"size":1659,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samsung-cnct:master","ref":"master","sha":"845c0df42dd8a07839d57b3943da19057437dcde","user":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars.githubusercontent.com/u/11511065?v=3","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"repo":{"id":68646823,"name":"k2","full_name":"samsung-cnct/k2","owner":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars.githubusercontent.com/u/11511065?v=3","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samsung-cnct/k2","description":"K2 (Kraken 2)","fork":false,"url":"https://api.github.com/repos/samsung-cnct/k2","forks_url":"https://api.github.com/repos/samsung-cnct/k2/forks","keys_url":"https://api.github.com/repos/samsung-cnct/k2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsung-cnct/k2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsung-cnct/k2/teams","hooks_url":"https://api.github.com/repos/samsung-cnct/k2/hooks","issue_events_url":"https://api.github.com/repos/samsung-cnct/k2/issues/events{/number}","events_url":"https://api.github.com/repos/samsung-cnct/k2/events","assignees_url":"https://api.github.com/repos/samsung-cnct/k2/assignees{/user}","branches_url":"https://api.github.com/repos/samsung-cnct/k2/branches{/branch}","tags_url":"https://api.github.com/repos/samsung-cnct/k2/tags","blobs_url":"https://api.github.com/repos/samsung-cnct/k2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsung-cnct/k2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsung-cnct/k2/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsung-cnct/k2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsung-cnct/k2/statuses/{sha}","languages_url":"https://api.github.com/repos/samsung-cnct/k2/languages","stargazers_url":"https://api.github.com/repos/samsung-cnct/k2/stargazers","contributors_url":"https://api.github.com/repos/samsung-cnct/k2/contributors","subscribers_url":"https://api.github.com/repos/samsung-cnct/k2/subscribers","subscription_url":"https://api.github.com/repos/samsung-cnct/k2/subscription","commits_url":"https://api.github.com/repos/samsung-cnct/k2/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsung-cnct/k2/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsung-cnct/k2/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsung-cnct/k2/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsung-cnct/k2/contents/{+path}","compare_url":"https://api.github.com/repos/samsung-cnct/k2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsung-cnct/k2/merges","archive_url":"https://api.github.com/repos/samsung-cnct/k2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsung-cnct/k2/downloads","issues_url":"https://api.github.com/repos/samsung-cnct/k2/issues{/number}","pulls_url":"https://api.github.com/repos/samsung-cnct/k2/pulls{/number}","milestones_url":"https://api.github.com/repos/samsung-cnct/k2/milestones{/number}","notifications_url":"https://api.github.com/repos/samsung-cnct/k2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsung-cnct/k2/labels{/name}","releases_url":"https://api.github.com/repos/samsung-cnct/k2/releases{/id}","deployments_url":"https://api.github.com/repos/samsung-cnct/k2/deployments","created_at":"2016-09-19T21:07:47Z","updated_at":"2016-11-27T14:55:43Z","pushed_at":"2016-12-05T20:15:34Z","git_url":"git://github.com/samsung-cnct/k2.git","ssh_url":"git@github.com:samsung-cnct/k2.git","clone_url":"https://github.com/samsung-cnct/k2.git","svn_url":"https://github.com/samsung-cnct/k2","homepage":null,"size":1654,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":50,"forks":12,"open_issues":50,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/111"},"html":{"href":"https://github.com/samsung-cnct/k2/pull/111"},"issue":{"href":"https://api.github.com/repos/samsung-cnct/k2/issues/111"},"comments":{"href":"https://api.github.com/repos/samsung-cnct/k2/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/samsung-cnct/k2/statuses/6d8a7b43a7ccf2a49f331ca239a418d88e27b2ca"}}}}
{"actor":{"display_login":"venezia"}}