{"action":"created","issue":{"url":"https://api.github.com/repos/AdamMatheny/GlobalGameJam2016/issues/1","labels_url":"https://api.github.com/repos/AdamMatheny/GlobalGameJam2016/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/AdamMatheny/GlobalGameJam2016/issues/1/comments","events_url":"https://api.github.com/repos/AdamMatheny/GlobalGameJam2016/issues/1/events","html_url":"https://github.com/AdamMatheny/GlobalGameJam2016/pull/1","id":130584122,"number":1,"title":"Added Notes","user":{"login":"JohnLeeroy","id":2716866,"avatar_url":"https://avatars.githubusercontent.com/u/2716866?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLeeroy","html_url":"https://github.com/JohnLeeroy","followers_url":"https://api.github.com/users/JohnLeeroy/followers","following_url":"https://api.github.com/users/JohnLeeroy/following{/other_user}","gists_url":"https://api.github.com/users/JohnLeeroy/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLeeroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLeeroy/subscriptions","organizations_url":"https://api.github.com/users/JohnLeeroy/orgs","repos_url":"https://api.github.com/users/JohnLeeroy/repos","events_url":"https://api.github.com/users/JohnLeeroy/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLeeroy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-02T06:01:02Z","updated_at":"2016-02-02T06:04:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AdamMatheny/GlobalGameJam2016/pulls/1","html_url":"https://github.com/AdamMatheny/GlobalGameJam2016/pull/1","diff_url":"https://github.com/AdamMatheny/GlobalGameJam2016/pull/1.diff","patch_url":"https://github.com/AdamMatheny/GlobalGameJam2016/pull/1.patch"},"body":"Hey, looked over the codebase and I had a few notes on how I think things can be implemented better.  I understand it was coded during a game jam so I'm not thinking this is an indication of your skill.\r\n\r\nMaybe you already agree with my comments, maybe you disagree, but hopefully I provided some perspective on how things can be implemented differently."},"comment":{"url":"https://api.github.com/repos/AdamMatheny/GlobalGameJam2016/issues/comments/178392019","html_url":"https://github.com/AdamMatheny/GlobalGameJam2016/pull/1#issuecomment-178392019","issue_url":"https://api.github.com/repos/AdamMatheny/GlobalGameJam2016/issues/1","id":178392019,"user":{"login":"JohnLeeroy","id":2716866,"avatar_url":"https://avatars.githubusercontent.com/u/2716866?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLeeroy","html_url":"https://github.com/JohnLeeroy","followers_url":"https://api.github.com/users/JohnLeeroy/followers","following_url":"https://api.github.com/users/JohnLeeroy/following{/other_user}","gists_url":"https://api.github.com/users/JohnLeeroy/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLeeroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLeeroy/subscriptions","organizations_url":"https://api.github.com/users/JohnLeeroy/orgs","repos_url":"https://api.github.com/users/JohnLeeroy/repos","events_url":"https://api.github.com/users/JohnLeeroy/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLeeroy/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T06:04:20Z","updated_at":"2016-02-02T06:04:20Z","body":"Here's some ideas on general micro-optimizations you can apply.\r\n\r\nDon’t use FindObjectOfType\r\n  - Only finds first object of that type.  I would recommend GameObject.Find([name]).GetComponent<[component]> instead.  \r\n\r\nTrack objects you spawn, see factory pattern\r\n  - Helps you track any floating game objects that should be destroyed\r\n  - Lets you leverage reusing a gameobject instead of destroying it and spawning a new one later.\r\n\r\nUse more coroutines instead of update()\r\n  - Somethings just don't need to be checked or ran every frame.  \r\n\r\nDon’t call get component twice or multiple times\r\n  - GetComponent is kind of slow.  Store it in a local variable the first time and use that variable instead.\r\n"}}