{"action":"created","comment":{"url":"https://api.github.com/repos/influxdata/influxdb/pulls/comments/90453898","pull_request_review_id":10971862,"id":90453898,"diff_hunk":"@@ -13,6 +13,7 @@\n - [#7621](https://github.com/influxdata/influxdb/issues/7621): Expand string and boolean fields when using a wildcard with `sample()`.\n - [#7616](https://github.com/influxdata/influxdb/pull/7616): Fix chuid argument order in init script @ccasey\n - [#7656](https://github.com/influxdata/influxdb/issues/7656): Fix cross-platform backup/restore\n+- [#7615](https://github.com/influxdata/influxdb/issues/7615): Reject invalid subscription urls.","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"980356282e97c5443568ff0fd453ef25b5ebdfb1","original_commit_id":"980356282e97c5443568ff0fd453ef25b5ebdfb1","user":{"login":"e-dard","id":501993,"avatar_url":"https://avatars.githubusercontent.com/u/501993?v=3","gravatar_id":"","url":"https://api.github.com/users/e-dard","html_url":"https://github.com/e-dard","followers_url":"https://api.github.com/users/e-dard/followers","following_url":"https://api.github.com/users/e-dard/following{/other_user}","gists_url":"https://api.github.com/users/e-dard/gists{/gist_id}","starred_url":"https://api.github.com/users/e-dard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-dard/subscriptions","organizations_url":"https://api.github.com/users/e-dard/orgs","repos_url":"https://api.github.com/users/e-dard/repos","events_url":"https://api.github.com/users/e-dard/events{/privacy}","received_events_url":"https://api.github.com/users/e-dard/received_events","type":"User","site_admin":false},"body":"Please feel free to give yourself credit (`add @allenpetersen`)","created_at":"2016-12-01T14:15:54Z","updated_at":"2016-12-01T14:15:54Z","html_url":"https://github.com/influxdata/influxdb/pull/7673#discussion_r90453898","pull_request_url":"https://api.github.com/repos/influxdata/influxdb/pulls/7673","_links":{"self":{"href":"https://api.github.com/repos/influxdata/influxdb/pulls/comments/90453898"},"html":{"href":"https://github.com/influxdata/influxdb/pull/7673#discussion_r90453898"},"pull_request":{"href":"https://api.github.com/repos/influxdata/influxdb/pulls/7673"}}},"pull_request":{"url":"https://api.github.com/repos/influxdata/influxdb/pulls/7673","id":96026675,"html_url":"https://github.com/influxdata/influxdb/pull/7673","diff_url":"https://github.com/influxdata/influxdb/pull/7673.diff","patch_url":"https://github.com/influxdata/influxdb/pull/7673.patch","issue_url":"https://api.github.com/repos/influxdata/influxdb/issues/7673","number":7673,"state":"open","locked":false,"title":"Reject invalid subscription urls","user":{"login":"allenpetersen","id":592300,"avatar_url":"https://avatars.githubusercontent.com/u/592300?v=3","gravatar_id":"","url":"https://api.github.com/users/allenpetersen","html_url":"https://github.com/allenpetersen","followers_url":"https://api.github.com/users/allenpetersen/followers","following_url":"https://api.github.com/users/allenpetersen/following{/other_user}","gists_url":"https://api.github.com/users/allenpetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/allenpetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenpetersen/subscriptions","organizations_url":"https://api.github.com/users/allenpetersen/orgs","repos_url":"https://api.github.com/users/allenpetersen/repos","events_url":"https://api.github.com/users/allenpetersen/events{/privacy}","received_events_url":"https://api.github.com/users/allenpetersen/received_events","type":"User","site_admin":false},"body":"###### Required for all non-trivial PRs\r\n- [x] Rebased/mergable\r\n- [x] Tests pass\r\n- [x] CHANGELOG.md updated\r\n- [x] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)\r\n\r\nThe url must have a scheme of udp or tcp in addition to a port number.\r\nCREATE SUBSCRIPTION will fail if there are invalid destinations.\r\n\r\nAdditionally Service.createSubscription will skip over any invalid\r\ndestinations on previously created subscriptions.\r\n\r\nFixes #7615","created_at":"2016-12-01T05:01:00Z","updated_at":"2016-12-01T14:31:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a64d5f0711976b0ef187c7e8a402717afaa3baa0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/influxdata/influxdb/pulls/7673/commits","review_comments_url":"https://api.github.com/repos/influxdata/influxdb/pulls/7673/comments","review_comment_url":"https://api.github.com/repos/influxdata/influxdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/influxdata/influxdb/issues/7673/comments","statuses_url":"https://api.github.com/repos/influxdata/influxdb/statuses/980356282e97c5443568ff0fd453ef25b5ebdfb1","head":{"label":"allenpetersen:ap_7615","ref":"ap_7615","sha":"980356282e97c5443568ff0fd453ef25b5ebdfb1","user":{"login":"allenpetersen","id":592300,"avatar_url":"https://avatars.githubusercontent.com/u/592300?v=3","gravatar_id":"","url":"https://api.github.com/users/allenpetersen","html_url":"https://github.com/allenpetersen","followers_url":"https://api.github.com/users/allenpetersen/followers","following_url":"https://api.github.com/users/allenpetersen/following{/other_user}","gists_url":"https://api.github.com/users/allenpetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/allenpetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenpetersen/subscriptions","organizations_url":"https://api.github.com/users/allenpetersen/orgs","repos_url":"https://api.github.com/users/allenpetersen/repos","events_url":"https://api.github.com/users/allenpetersen/events{/privacy}","received_events_url":"https://api.github.com/users/allenpetersen/received_events","type":"User","site_admin":false},"repo":{"id":74793785,"name":"influxdb","full_name":"allenpetersen/influxdb","owner":{"login":"allenpetersen","id":592300,"avatar_url":"https://avatars.githubusercontent.com/u/592300?v=3","gravatar_id":"","url":"https://api.github.com/users/allenpetersen","html_url":"https://github.com/allenpetersen","followers_url":"https://api.github.com/users/allenpetersen/followers","following_url":"https://api.github.com/users/allenpetersen/following{/other_user}","gists_url":"https://api.github.com/users/allenpetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/allenpetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenpetersen/subscriptions","organizations_url":"https://api.github.com/users/allenpetersen/orgs","repos_url":"https://api.github.com/users/allenpetersen/repos","events_url":"https://api.github.com/users/allenpetersen/events{/privacy}","received_events_url":"https://api.github.com/users/allenpetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allenpetersen/influxdb","description":"Scalable datastore for metrics, events, and real-time analytics","fork":true,"url":"https://api.github.com/repos/allenpetersen/influxdb","forks_url":"https://api.github.com/repos/allenpetersen/influxdb/forks","keys_url":"https://api.github.com/repos/allenpetersen/influxdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenpetersen/influxdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenpetersen/influxdb/teams","hooks_url":"https://api.github.com/repos/allenpetersen/influxdb/hooks","issue_events_url":"https://api.github.com/repos/allenpetersen/influxdb/issues/events{/number}","events_url":"https://api.github.com/repos/allenpetersen/influxdb/events","assignees_url":"https://api.github.com/repos/allenpetersen/influxdb/assignees{/user}","branches_url":"https://api.github.com/repos/allenpetersen/influxdb/branches{/branch}","tags_url":"https://api.github.com/repos/allenpetersen/influxdb/tags","blobs_url":"https://api.github.com/repos/allenpetersen/influxdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenpetersen/influxdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenpetersen/influxdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenpetersen/influxdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenpetersen/influxdb/statuses/{sha}","languages_url":"https://api.github.com/repos/allenpetersen/influxdb/languages","stargazers_url":"https://api.github.com/repos/allenpetersen/influxdb/stargazers","contributors_url":"https://api.github.com/repos/allenpetersen/influxdb/contributors","subscribers_url":"https://api.github.com/repos/allenpetersen/influxdb/subscribers","subscription_url":"https://api.github.com/repos/allenpetersen/influxdb/subscription","commits_url":"https://api.github.com/repos/allenpetersen/influxdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenpetersen/influxdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenpetersen/influxdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenpetersen/influxdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenpetersen/influxdb/contents/{+path}","compare_url":"https://api.github.com/repos/allenpetersen/influxdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenpetersen/influxdb/merges","archive_url":"https://api.github.com/repos/allenpetersen/influxdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenpetersen/influxdb/downloads","issues_url":"https://api.github.com/repos/allenpetersen/influxdb/issues{/number}","pulls_url":"https://api.github.com/repos/allenpetersen/influxdb/pulls{/number}","milestones_url":"https://api.github.com/repos/allenpetersen/influxdb/milestones{/number}","notifications_url":"https://api.github.com/repos/allenpetersen/influxdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenpetersen/influxdb/labels{/name}","releases_url":"https://api.github.com/repos/allenpetersen/influxdb/releases{/id}","deployments_url":"https://api.github.com/repos/allenpetersen/influxdb/deployments","created_at":"2016-11-25T23:31:33Z","updated_at":"2016-11-25T23:31:38Z","pushed_at":"2016-12-01T05:00:14Z","git_url":"git://github.com/allenpetersen/influxdb.git","ssh_url":"git@github.com:allenpetersen/influxdb.git","clone_url":"https://github.com/allenpetersen/influxdb.git","svn_url":"https://github.com/allenpetersen/influxdb","homepage":"https://influxdata.com","size":46924,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"influxdata:master","ref":"master","sha":"3dc5165b3ccf66df6aa1a6e80a9b74a0f1d97d47","user":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars.githubusercontent.com/u/5713248?v=3","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":13124802,"name":"influxdb","full_name":"influxdata/influxdb","owner":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars.githubusercontent.com/u/5713248?v=3","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/influxdb","description":"Scalable datastore for metrics, events, and real-time analytics","fork":false,"url":"https://api.github.com/repos/influxdata/influxdb","forks_url":"https://api.github.com/repos/influxdata/influxdb/forks","keys_url":"https://api.github.com/repos/influxdata/influxdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/influxdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/influxdb/teams","hooks_url":"https://api.github.com/repos/influxdata/influxdb/hooks","issue_events_url":"https://api.github.com/repos/influxdata/influxdb/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/influxdb/events","assignees_url":"https://api.github.com/repos/influxdata/influxdb/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/influxdb/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/influxdb/tags","blobs_url":"https://api.github.com/repos/influxdata/influxdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/influxdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/influxdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/influxdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/influxdb/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/influxdb/languages","stargazers_url":"https://api.github.com/repos/influxdata/influxdb/stargazers","contributors_url":"https://api.github.com/repos/influxdata/influxdb/contributors","subscribers_url":"https://api.github.com/repos/influxdata/influxdb/subscribers","subscription_url":"https://api.github.com/repos/influxdata/influxdb/subscription","commits_url":"https://api.github.com/repos/influxdata/influxdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/influxdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/influxdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/influxdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/influxdb/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/influxdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/influxdb/merges","archive_url":"https://api.github.com/repos/influxdata/influxdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/influxdb/downloads","issues_url":"https://api.github.com/repos/influxdata/influxdb/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/influxdb/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/influxdb/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/influxdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/influxdb/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/influxdb/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/influxdb/deployments","created_at":"2013-09-26T14:31:10Z","updated_at":"2016-12-01T14:30:55Z","pushed_at":"2016-12-01T13:48:44Z","git_url":"git://github.com/influxdata/influxdb.git","ssh_url":"git@github.com:influxdata/influxdb.git","clone_url":"https://github.com/influxdata/influxdb.git","svn_url":"https://github.com/influxdata/influxdb","homepage":"https://influxdata.com","size":63358,"stargazers_count":9303,"watchers_count":9303,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1310,"mirror_url":null,"open_issues_count":374,"forks":1310,"open_issues":374,"watchers":9303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdata/influxdb/pulls/7673"},"html":{"href":"https://github.com/influxdata/influxdb/pull/7673"},"issue":{"href":"https://api.github.com/repos/influxdata/influxdb/issues/7673"},"comments":{"href":"https://api.github.com/repos/influxdata/influxdb/issues/7673/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdata/influxdb/pulls/7673/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdata/influxdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/influxdata/influxdb/pulls/7673/commits"},"statuses":{"href":"https://api.github.com/repos/influxdata/influxdb/statuses/980356282e97c5443568ff0fd453ef25b5ebdfb1"}}}}
{"actor":{"display_login":"e-dard"}}