{"action":"opened","number":13348,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/13348","id":59774831,"html_url":"https://github.com/cms-sw/cmssw/pull/13348","diff_url":"https://github.com/cms-sw/cmssw/pull/13348.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/13348.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13348","number":13348,"state":"open","locked":false,"title":"Add GsfTracks to tracking validation","user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"body":"This PR adds the monitoring of GsfTracks (`electronGsfTracks` collection) to tracking validation. The efficiency is defined wrt. TrackingParticles with `abs(pdgId) == 11`, and fake rate wrt. all TrackingParticles. On the same go, the definition of fake rate for conversions is also changed to be wrt. all TrackingParticles. In order to achieve these nicely, and to again properly support the separate `label_tp_effic` and `label_tp_fake` parameters of MultiTrackValidator, the following changes were made\r\n* The configuration of `TrackingParticleNumberOfLayersProducer` is fixed\r\n* MTV supports reading `TrackingParticleRefVector` instead of `TrackingParticleCollection`\r\n  * It would have been easier to just use `View<TrackingParticle>`, but `TrackToTrackingParticleAssociator` interface does not support it, and changing it would have had much larger impact. (I'll probably try to do it anyway some day)\r\n* `TrackingParticleConversionSelector` is changed to produce `TrackingParticleRefVector` (and renamed and turned to `edm::global`)\r\n* `TrackValidation_cff`is migrated to use `TrackingParticleRefVector` instead of copies\r\n* SimToReco (TP->track) association is created wrt. `label_tp_fake` TPs instead of `label_tp_eff`, and `label_tp_eff` is required to be a subset of `label_tp_fake` (explicit check is added)\r\n  * The SimToReco association is used in efficiency numerator, but also in duplicate rate numerator. For duplicates, the SimToReco must contain associations for TPs from `label_tp_fake`. For efficiency, these \"extra\" associations don't matter since the associations are checked only for `label_tp_eff`.\r\n\r\nTested in CMSSW_8_0_X_2016-02-15-1100 (with and without #13242), expecting changes under `Tracking/TrackConversion` (for fakes and other track-based histograms), and addition of `Tracking/TrackGsf` folder.\r\n\r\n@rovere @VinInn \nAutomatically ported from CMSSW_8_0_X #13324 (original by @makortel).","created_at":"2016-02-18T09:59:55Z","updated_at":"2016-02-18T09:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/13348/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/13348/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13348/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/5eb3f947972cc8d56701a33499f28052deeeaf93","head":{"label":"makortel:mtvGsfTracks","ref":"mtvGsfTracks","sha":"5eb3f947972cc8d56701a33499f28052deeeaf93","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"repo":{"id":11017982,"name":"cmssw","full_name":"makortel/cmssw","owner":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/makortel/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/makortel/cmssw","forks_url":"https://api.github.com/repos/makortel/cmssw/forks","keys_url":"https://api.github.com/repos/makortel/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makortel/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makortel/cmssw/teams","hooks_url":"https://api.github.com/repos/makortel/cmssw/hooks","issue_events_url":"https://api.github.com/repos/makortel/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/makortel/cmssw/events","assignees_url":"https://api.github.com/repos/makortel/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/makortel/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/makortel/cmssw/tags","blobs_url":"https://api.github.com/repos/makortel/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makortel/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makortel/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/makortel/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makortel/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/makortel/cmssw/languages","stargazers_url":"https://api.github.com/repos/makortel/cmssw/stargazers","contributors_url":"https://api.github.com/repos/makortel/cmssw/contributors","subscribers_url":"https://api.github.com/repos/makortel/cmssw/subscribers","subscription_url":"https://api.github.com/repos/makortel/cmssw/subscription","commits_url":"https://api.github.com/repos/makortel/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/makortel/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/makortel/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/makortel/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/makortel/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/makortel/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makortel/cmssw/merges","archive_url":"https://api.github.com/repos/makortel/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makortel/cmssw/downloads","issues_url":"https://api.github.com/repos/makortel/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/makortel/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/makortel/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/makortel/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makortel/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/makortel/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/makortel/cmssw/deployments","created_at":"2013-06-28T06:39:15Z","updated_at":"2014-06-24T14:24:59Z","pushed_at":"2016-02-18T09:46:55Z","git_url":"git://github.com/makortel/cmssw.git","ssh_url":"git@github.com:makortel/cmssw.git","clone_url":"https://github.com/makortel/cmssw.git","svn_url":"https://github.com/makortel/cmssw","homepage":null,"size":848433,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"bc39402767886fee6fb487bc23f4b6cce70f8a87","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-02-16T10:59:08Z","pushed_at":"2016-02-18T09:59:39Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1025116,"stargazers_count":292,"watchers_count":292,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1717,"mirror_url":null,"open_issues_count":240,"forks":1717,"open_issues":240,"watchers":292,"default_branch":"CMSSW_8_0_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/13348"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/13348"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/13348"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/13348/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/13348/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/13348/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/5eb3f947972cc8d56701a33499f28052deeeaf93"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":217,"deletions":128,"changed_files":10}}