{"action":"created","comment":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments/77295622","id":77295622,"diff_hunk":"@@ -48,19 +48,27 @@\n     <% if competitions.empty? %>\n       <%= render 'no_competitions_found' %>\n     <% else %>\n-      <% past_competitions, ongoing_and_upcoming_competitions = competitions.partition(&:is_over?) %>\n-      <% recent_competitions, distant_competitions = past_competitions.partition { |c| (Date.today - c.end_date).to_i < Competition::RECENT_DAYS } %>\n-      <% unless ongoing_and_upcoming_competitions.empty? %>\n-        <div class=\"col-md-12\" id=\"upcoming-comps\">\n-          <%= render 'admin_index_table', competitions: ongoing_and_upcoming_competitions, title: \"Ongoing and upcoming competitions\" %>\n-        </div>\n+      <% if params[:state] == 'past' %>\n+        <% recent_competitions, distant_competitions = competitions.partition { |c| (Date.today - c.end_date).to_i < Competition::RECENT_DAYS } %>\n+        <% distant_competitions = distant_competitions.reverse %>\n+        <% recent_competitions = recent_competitions.reverse %>\n+        <% unless recent_competitions.empty? %>\n+          <div class=\"col-md-12\" id=\"recent-comps\">\n+            <%= render 'admin_index_table', competitions: recent_competitions, title: \"Competitions within the last #{Competition::RECENT_DAYS} days\" %>\n+          </div>\n+        <% end %>\n+        <% unless distant_competitions.empty? %>\n+          <div class=\"col-md-12\" id=\"past-comps\">\n+            <%= render 'admin_index_table', competitions: distant_competitions, title: \"Past competitions\" %>\n+          </div>\n+        <% end %>\n+      <% else %>\n+        <% unless competitions.empty? %>\n+          <div class=\"col-md-12\" id=\"upcoming-comps\">\n+            <%= render 'admin_index_table', competitions: competitions, title: \"Ongoing and upcoming competitions\" %>\n+          </div>","path":"WcaOnRails/app/views/competitions/_index_competitions_list.html.erb","position":28,"original_position":28,"commit_id":"562c8c883852658ff16d1b02456c97bd6d08e828","original_commit_id":"562c8c883852658ff16d1b02456c97bd6d08e828","user":{"login":"larspetrus","id":755243,"avatar_url":"https://avatars.githubusercontent.com/u/755243?v=3","gravatar_id":"","url":"https://api.github.com/users/larspetrus","html_url":"https://github.com/larspetrus","followers_url":"https://api.github.com/users/larspetrus/followers","following_url":"https://api.github.com/users/larspetrus/following{/other_user}","gists_url":"https://api.github.com/users/larspetrus/gists{/gist_id}","starred_url":"https://api.github.com/users/larspetrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larspetrus/subscriptions","organizations_url":"https://api.github.com/users/larspetrus/orgs","repos_url":"https://api.github.com/users/larspetrus/repos","events_url":"https://api.github.com/users/larspetrus/events{/privacy}","received_events_url":"https://api.github.com/users/larspetrus/received_events","type":"User","site_admin":false},"body":"If - and only if - you feel ambitious:\r\n\r\nBoth the div and the`unless` could be moved into the partial, like so:\r\n\r\n    <%= render 'admin_index_table', id:\"recent-comps\",    competitions: recent_competitions,  title: \"Competitions within the last #{Competition::RECENT_DAYS} days\" %>\r\n    <%= render 'admin_index_table', id: \"past-comps\",     competitions: distant_competitions, title: \"Past competitions\" %>\r\n    <%= render 'admin_index_table', id: \"upcoming-comps\", competitions: competitions,         title: \"Ongoing and upcoming competitions\" %>\r\n","created_at":"2016-09-02T05:41:39Z","updated_at":"2016-09-02T05:41:39Z","html_url":"https://github.com/cubing/worldcubeassociation.org/pull/849#discussion_r77295622","pull_request_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849","_links":{"self":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments/77295622"},"html":{"href":"https://github.com/cubing/worldcubeassociation.org/pull/849#discussion_r77295622"},"pull_request":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849"}}},"pull_request":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849","id":83716089,"html_url":"https://github.com/cubing/worldcubeassociation.org/pull/849","diff_url":"https://github.com/cubing/worldcubeassociation.org/pull/849.diff","patch_url":"https://github.com/cubing/worldcubeassociation.org/pull/849.patch","issue_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/849","number":849,"state":"open","locked":false,"title":"Don't load all competitions, and correct ordering.","user":{"login":"pedrosino","id":1881933,"avatar_url":"https://avatars.githubusercontent.com/u/1881933?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosino","html_url":"https://github.com/pedrosino","followers_url":"https://api.github.com/users/pedrosino/followers","following_url":"https://api.github.com/users/pedrosino/following{/other_user}","gists_url":"https://api.github.com/users/pedrosino/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosino/subscriptions","organizations_url":"https://api.github.com/users/pedrosino/orgs","repos_url":"https://api.github.com/users/pedrosino/repos","events_url":"https://api.github.com/users/pedrosino/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosino/received_events","type":"User","site_admin":false},"body":"Building on #815 \r\n\r\nLoading ALL competitions every time (even filtered by search) is way too slow now, and not sustainable as we grow.","created_at":"2016-09-01T22:12:49Z","updated_at":"2016-09-02T05:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"deb65be28ad4ac5df492fb85082d2c9aec4c08f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849/commits","review_comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849/comments","review_comment_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/849/comments","statuses_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/562c8c883852658ff16d1b02456c97bd6d08e828","head":{"label":"pedrosino:comp-admin","ref":"comp-admin","sha":"562c8c883852658ff16d1b02456c97bd6d08e828","user":{"login":"pedrosino","id":1881933,"avatar_url":"https://avatars.githubusercontent.com/u/1881933?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosino","html_url":"https://github.com/pedrosino","followers_url":"https://api.github.com/users/pedrosino/followers","following_url":"https://api.github.com/users/pedrosino/following{/other_user}","gists_url":"https://api.github.com/users/pedrosino/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosino/subscriptions","organizations_url":"https://api.github.com/users/pedrosino/orgs","repos_url":"https://api.github.com/users/pedrosino/repos","events_url":"https://api.github.com/users/pedrosino/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosino/received_events","type":"User","site_admin":false},"repo":{"id":45578783,"name":"worldcubeassociation.org","full_name":"pedrosino/worldcubeassociation.org","owner":{"login":"pedrosino","id":1881933,"avatar_url":"https://avatars.githubusercontent.com/u/1881933?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosino","html_url":"https://github.com/pedrosino","followers_url":"https://api.github.com/users/pedrosino/followers","following_url":"https://api.github.com/users/pedrosino/following{/other_user}","gists_url":"https://api.github.com/users/pedrosino/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosino/subscriptions","organizations_url":"https://api.github.com/users/pedrosino/orgs","repos_url":"https://api.github.com/users/pedrosino/repos","events_url":"https://api.github.com/users/pedrosino/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedrosino/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":true,"url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org","forks_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/deployments","created_at":"2015-11-05T01:22:31Z","updated_at":"2016-01-11T18:58:19Z","pushed_at":"2016-09-01T22:13:41Z","git_url":"git://github.com/pedrosino/worldcubeassociation.org.git","ssh_url":"git@github.com:pedrosino/worldcubeassociation.org.git","clone_url":"https://github.com/pedrosino/worldcubeassociation.org.git","svn_url":"https://github.com/pedrosino/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":52614,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cubing:master","ref":"master","sha":"9ed2e83476540e9d2279c3c25b658443550585b9","user":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"repo":{"id":34161579,"name":"worldcubeassociation.org","full_name":"cubing/worldcubeassociation.org","owner":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cubing/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":false,"url":"https://api.github.com/repos/cubing/worldcubeassociation.org","forks_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/deployments","created_at":"2015-04-18T10:21:53Z","updated_at":"2016-07-31T18:31:59Z","pushed_at":"2016-09-02T01:37:28Z","git_url":"git://github.com/cubing/worldcubeassociation.org.git","ssh_url":"git@github.com:cubing/worldcubeassociation.org.git","clone_url":"https://github.com/cubing/worldcubeassociation.org.git","svn_url":"https://github.com/cubing/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":56221,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":177,"forks":29,"open_issues":177,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849"},"html":{"href":"https://github.com/cubing/worldcubeassociation.org/pull/849"},"issue":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/849"},"comments":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/849/comments"},"review_comments":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849/comments"},"review_comment":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/849/commits"},"statuses":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/562c8c883852658ff16d1b02456c97bd6d08e828"}}}}
{"actor":{"display_login":"larspetrus"}}