{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/comments/85746022","pull_request_review_id":6435566,"id":85746022,"diff_hunk":"@@ -0,0 +1,148 @@\n+/*\n+ * Copyright 2016 JBoss by Red Hat.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.guvnor.ala.build.maven.executor;\n+\n+import java.io.BufferedReader;\n+import java.io.File;\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.io.InputStreamReader;\n+import java.io.PipedInputStream;\n+import java.io.PipedOutputStream;\n+import java.io.PrintStream;\n+import java.nio.file.Files;\n+import java.util.ArrayList;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Properties;\n+import org.apache.commons.io.FileUtils;\n+import org.apache.maven.project.MavenProject;\n+import org.guvnor.ala.build.Project;\n+\n+import org.guvnor.ala.build.maven.model.impl.MavenProjectImpl;\n+import org.guvnor.ala.build.maven.util.MavenBuildExecutor;\n+\n+import org.guvnor.ala.build.maven.util.RepositoryVisitor;\n+import org.guvnor.ala.source.Source;\n+import org.guvnor.ala.source.git.GitHub;\n+import org.guvnor.ala.source.git.GitRepository;\n+import org.junit.After;\n+import static org.junit.Assert.assertTrue;\n+import org.junit.Before;\n+import org.junit.Test;\n+import org.kie.scanner.embedder.MavenProjectLoader;\n+\n+/**\n+ *\n+ */\n+public class MavenCliOutputTest {\n+\n+    public MavenCliOutputTest() {\n+    }\n+\n+    private File tempPath;\n+\n+    @Before\n+    public void setUp() throws IOException {\n+        tempPath = Files.createTempDirectory(\"zzz\").toFile();\n+    }\n+\n+    @After\n+    public void tearDown() {\n+        FileUtils.deleteQuietly(tempPath);\n+    }\n+\n+    @Test\n+    public void waitForAppBuildTest() {","path":"guvnor-ala/guvnor-ala-build-maven/src/test/java/org/guvnor/ala/build/maven/executor/MavenCliOutputTest.java","position":69,"original_position":69,"commit_id":"53d54cddc29f65c0eb8bbc35fabf49359fbb5e43","original_commit_id":"53d54cddc29f65c0eb8bbc35fabf49359fbb5e43","user":{"login":"mbarkley","id":4459888,"avatar_url":"https://avatars.githubusercontent.com/u/4459888?v=3","gravatar_id":"","url":"https://api.github.com/users/mbarkley","html_url":"https://github.com/mbarkley","followers_url":"https://api.github.com/users/mbarkley/followers","following_url":"https://api.github.com/users/mbarkley/following{/other_user}","gists_url":"https://api.github.com/users/mbarkley/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarkley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarkley/subscriptions","organizations_url":"https://api.github.com/users/mbarkley/orgs","repos_url":"https://api.github.com/users/mbarkley/repos","events_url":"https://api.github.com/users/mbarkley/events{/privacy}","received_events_url":"https://api.github.com/users/mbarkley/received_events","type":"User","site_admin":false},"body":"Am I correct in assuming that this only tests the `MavenBuilderExecutor.executeMaven` method? If that is the case I think a unit test with a mocked Maven executor would be easier to understand and maintain.","created_at":"2016-10-31T14:15:15Z","updated_at":"2016-10-31T14:48:40Z","html_url":"https://github.com/droolsjbpm/guvnor/pull/380#discussion_r85746022","pull_request_url":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/comments/85746022"},"html":{"href":"https://github.com/droolsjbpm/guvnor/pull/380#discussion_r85746022"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380","id":91389469,"html_url":"https://github.com/droolsjbpm/guvnor/pull/380","diff_url":"https://github.com/droolsjbpm/guvnor/pull/380.diff","patch_url":"https://github.com/droolsjbpm/guvnor/pull/380.patch","issue_url":"https://api.github.com/repos/droolsjbpm/guvnor/issues/380","number":380,"state":"open","locked":false,"title":"- Supporting Dev And Super Dev Mode for LS","user":{"login":"Salaboy","id":271966,"avatar_url":"https://avatars.githubusercontent.com/u/271966?v=3","gravatar_id":"","url":"https://api.github.com/users/Salaboy","html_url":"https://github.com/Salaboy","followers_url":"https://api.github.com/users/Salaboy/followers","following_url":"https://api.github.com/users/Salaboy/following{/other_user}","gists_url":"https://api.github.com/users/Salaboy/gists{/gist_id}","starred_url":"https://api.github.com/users/Salaboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Salaboy/subscriptions","organizations_url":"https://api.github.com/users/Salaboy/orgs","repos_url":"https://api.github.com/users/Salaboy/repos","events_url":"https://api.github.com/users/Salaboy/events{/privacy}","received_events_url":"https://api.github.com/users/Salaboy/received_events","type":"User","site_admin":false},"body":"This pull request add the pipeline modification for supporting Dev and Super Dev Mode in LS. \nThis PR includes the updated Repository visitor to work with temporary directories that are indexed to be reused and only the changes are applied when needed.\nThis PR is linked to this Drools PR that needs to be merged in in order for this code to work: https://github.com/droolsjbpm/drools/pull/968\n\nand to this PR in LS: https://github.com/droolsjbpm/livespark/pull/57\n\n@mbarkley can you please test this  and give feedback? \n","created_at":"2016-10-28T14:16:32Z","updated_at":"2016-10-31T14:48:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d049eb6bb972b299e79315572eea30473cfeadd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/guvnor/issues/380/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/guvnor/statuses/53d54cddc29f65c0eb8bbc35fabf49359fbb5e43","head":{"label":"Salaboy:ALA-devModeAndSDM","ref":"ALA-devModeAndSDM","sha":"53d54cddc29f65c0eb8bbc35fabf49359fbb5e43","user":{"login":"Salaboy","id":271966,"avatar_url":"https://avatars.githubusercontent.com/u/271966?v=3","gravatar_id":"","url":"https://api.github.com/users/Salaboy","html_url":"https://github.com/Salaboy","followers_url":"https://api.github.com/users/Salaboy/followers","following_url":"https://api.github.com/users/Salaboy/following{/other_user}","gists_url":"https://api.github.com/users/Salaboy/gists{/gist_id}","starred_url":"https://api.github.com/users/Salaboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Salaboy/subscriptions","organizations_url":"https://api.github.com/users/Salaboy/orgs","repos_url":"https://api.github.com/users/Salaboy/repos","events_url":"https://api.github.com/users/Salaboy/events{/privacy}","received_events_url":"https://api.github.com/users/Salaboy/received_events","type":"User","site_admin":false},"repo":{"id":68893086,"name":"guvnor","full_name":"Salaboy/guvnor","owner":{"login":"Salaboy","id":271966,"avatar_url":"https://avatars.githubusercontent.com/u/271966?v=3","gravatar_id":"","url":"https://api.github.com/users/Salaboy","html_url":"https://github.com/Salaboy","followers_url":"https://api.github.com/users/Salaboy/followers","following_url":"https://api.github.com/users/Salaboy/following{/other_user}","gists_url":"https://api.github.com/users/Salaboy/gists{/gist_id}","starred_url":"https://api.github.com/users/Salaboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Salaboy/subscriptions","organizations_url":"https://api.github.com/users/Salaboy/orgs","repos_url":"https://api.github.com/users/Salaboy/repos","events_url":"https://api.github.com/users/Salaboy/events{/privacy}","received_events_url":"https://api.github.com/users/Salaboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Salaboy/guvnor","description":"Guvnor is the governance framework for KIE workbenches","fork":true,"url":"https://api.github.com/repos/Salaboy/guvnor","forks_url":"https://api.github.com/repos/Salaboy/guvnor/forks","keys_url":"https://api.github.com/repos/Salaboy/guvnor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Salaboy/guvnor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Salaboy/guvnor/teams","hooks_url":"https://api.github.com/repos/Salaboy/guvnor/hooks","issue_events_url":"https://api.github.com/repos/Salaboy/guvnor/issues/events{/number}","events_url":"https://api.github.com/repos/Salaboy/guvnor/events","assignees_url":"https://api.github.com/repos/Salaboy/guvnor/assignees{/user}","branches_url":"https://api.github.com/repos/Salaboy/guvnor/branches{/branch}","tags_url":"https://api.github.com/repos/Salaboy/guvnor/tags","blobs_url":"https://api.github.com/repos/Salaboy/guvnor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Salaboy/guvnor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Salaboy/guvnor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Salaboy/guvnor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Salaboy/guvnor/statuses/{sha}","languages_url":"https://api.github.com/repos/Salaboy/guvnor/languages","stargazers_url":"https://api.github.com/repos/Salaboy/guvnor/stargazers","contributors_url":"https://api.github.com/repos/Salaboy/guvnor/contributors","subscribers_url":"https://api.github.com/repos/Salaboy/guvnor/subscribers","subscription_url":"https://api.github.com/repos/Salaboy/guvnor/subscription","commits_url":"https://api.github.com/repos/Salaboy/guvnor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Salaboy/guvnor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Salaboy/guvnor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Salaboy/guvnor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Salaboy/guvnor/contents/{+path}","compare_url":"https://api.github.com/repos/Salaboy/guvnor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Salaboy/guvnor/merges","archive_url":"https://api.github.com/repos/Salaboy/guvnor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Salaboy/guvnor/downloads","issues_url":"https://api.github.com/repos/Salaboy/guvnor/issues{/number}","pulls_url":"https://api.github.com/repos/Salaboy/guvnor/pulls{/number}","milestones_url":"https://api.github.com/repos/Salaboy/guvnor/milestones{/number}","notifications_url":"https://api.github.com/repos/Salaboy/guvnor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Salaboy/guvnor/labels{/name}","releases_url":"https://api.github.com/repos/Salaboy/guvnor/releases{/id}","deployments_url":"https://api.github.com/repos/Salaboy/guvnor/deployments","created_at":"2016-09-22T06:50:49Z","updated_at":"2016-09-22T06:50:53Z","pushed_at":"2016-10-27T10:04:05Z","git_url":"git://github.com/Salaboy/guvnor.git","ssh_url":"git@github.com:Salaboy/guvnor.git","clone_url":"https://github.com/Salaboy/guvnor.git","svn_url":"https://github.com/Salaboy/guvnor","homepage":"http://www.jboss.org/drools/drools-guvnor","size":487837,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"62a3da3ad338ceeab973183033c2797f86b889df","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1354561,"name":"guvnor","full_name":"droolsjbpm/guvnor","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/guvnor","description":"Guvnor is the governance framework for KIE workbenches","fork":false,"url":"https://api.github.com/repos/droolsjbpm/guvnor","forks_url":"https://api.github.com/repos/droolsjbpm/guvnor/forks","keys_url":"https://api.github.com/repos/droolsjbpm/guvnor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/guvnor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/guvnor/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/guvnor/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/guvnor/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/guvnor/events","assignees_url":"https://api.github.com/repos/droolsjbpm/guvnor/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/guvnor/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/guvnor/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/guvnor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/guvnor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/guvnor/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/guvnor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/guvnor/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/guvnor/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/guvnor/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/guvnor/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/guvnor/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/guvnor/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/guvnor/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/guvnor/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/guvnor/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/guvnor/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/guvnor/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/guvnor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/guvnor/merges","archive_url":"https://api.github.com/repos/droolsjbpm/guvnor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/guvnor/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/guvnor/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/guvnor/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/guvnor/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/guvnor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/guvnor/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/guvnor/releases{/id}","deployments_url":"https://api.github.com/repos/droolsjbpm/guvnor/deployments","created_at":"2011-02-11T10:35:34Z","updated_at":"2016-10-16T13:04:41Z","pushed_at":"2016-10-28T14:16:32Z","git_url":"git://github.com/droolsjbpm/guvnor.git","ssh_url":"git@github.com:droolsjbpm/guvnor.git","clone_url":"https://github.com/droolsjbpm/guvnor.git","svn_url":"https://github.com/droolsjbpm/guvnor","homepage":"http://www.jboss.org/drools/drools-guvnor","size":492479,"stargazers_count":154,"watchers_count":154,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":350,"mirror_url":null,"open_issues_count":2,"forks":350,"open_issues":2,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380"},"html":{"href":"https://github.com/droolsjbpm/guvnor/pull/380"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/issues/380"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/guvnor/statuses/53d54cddc29f65c0eb8bbc35fabf49359fbb5e43"}}}}
{"actor":{"display_login":"mbarkley"}}