{"action":"created","comment":{"url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/comments/59930296","id":59930296,"diff_hunk":"@@ -17,3 +15,8 @@ global.respondWithSuccess = (requestPromiseMock, result) => {\n global.respondWithFailure = (requestPromiseMock, result) => {\n   td.when(requestPromiseMock).thenDo(() => Bluebird.reject(result));\n };\n+\n+beforeEach(() => {","path":"test/helpers.js","position":14,"original_position":14,"commit_id":"e850872b2fffcc790ebcddf7221ed835f465fd9c","original_commit_id":"e850872b2fffcc790ebcddf7221ed835f465fd9c","user":{"login":"glauco","id":76370,"avatar_url":"https://avatars.githubusercontent.com/u/76370?v=3","gravatar_id":"","url":"https://api.github.com/users/glauco","html_url":"https://github.com/glauco","followers_url":"https://api.github.com/users/glauco/followers","following_url":"https://api.github.com/users/glauco/following{/other_user}","gists_url":"https://api.github.com/users/glauco/gists{/gist_id}","starred_url":"https://api.github.com/users/glauco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glauco/subscriptions","organizations_url":"https://api.github.com/users/glauco/orgs","repos_url":"https://api.github.com/users/glauco/repos","events_url":"https://api.github.com/users/glauco/events{/privacy}","received_events_url":"https://api.github.com/users/glauco/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better using `beforeAll` instead of `beforeEach`?","created_at":"2016-04-15T19:42:19Z","updated_at":"2016-04-15T19:42:19Z","html_url":"https://github.com/agco-fuse/fuse-equipment-api/pull/12#discussion_r59930296","pull_request_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/comments/59930296"},"html":{"href":"https://github.com/agco-fuse/fuse-equipment-api/pull/12#discussion_r59930296"},"pull_request":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12","id":66693716,"html_url":"https://github.com/agco-fuse/fuse-equipment-api/pull/12","diff_url":"https://github.com/agco-fuse/fuse-equipment-api/pull/12.diff","patch_url":"https://github.com/agco-fuse/fuse-equipment-api/pull/12.patch","issue_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/12","number":12,"state":"open","locked":false,"title":"Remove warnings on test","user":{"login":"bltavares","id":109474,"avatar_url":"https://avatars.githubusercontent.com/u/109474?v=3","gravatar_id":"","url":"https://api.github.com/users/bltavares","html_url":"https://github.com/bltavares","followers_url":"https://api.github.com/users/bltavares/followers","following_url":"https://api.github.com/users/bltavares/following{/other_user}","gists_url":"https://api.github.com/users/bltavares/gists{/gist_id}","starred_url":"https://api.github.com/users/bltavares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bltavares/subscriptions","organizations_url":"https://api.github.com/users/bltavares/orgs","repos_url":"https://api.github.com/users/bltavares/repos","events_url":"https://api.github.com/users/bltavares/events{/privacy}","received_events_url":"https://api.github.com/users/bltavares/received_events","type":"User","site_admin":false},"body":"Currently on master there are some test cases that are producing some warnings:\r\n\r\n<img width=\"1272\" alt=\"screen shot 2016-04-15 at 4 33 47 pm\" src=\"https://cloud.githubusercontent.com/assets/109474/14572901/eac440a8-0327-11e6-959a-0f37c47ceef2.png\">\r\n\r\nWith this changes, the warnings will be removed:\r\n\r\n<img width=\"680\" alt=\"screen shot 2016-04-15 at 4 33 17 pm\" src=\"https://cloud.githubusercontent.com/assets/109474/14572908/fa573fd4-0327-11e6-8fec-23f3a61426a0.png\">\r\n\r\nThe major changes are:\r\n\r\n- HTTP Mock client is being recreated between test scenarios to not get polluted between runs\r\n- Removed mock verification when the exact arguments have been stubbed, in favor of verifying the behavior on the expected output.","created_at":"2016-04-15T19:36:45Z","updated_at":"2016-04-15T19:42:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a034e5e75795a9650cc489b0159dfa7c730752a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12/commits","review_comments_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12/comments","review_comment_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/12/comments","statuses_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/statuses/e850872b2fffcc790ebcddf7221ed835f465fd9c","head":{"label":"agco-fuse:remove_warnings_on_test","ref":"remove_warnings_on_test","sha":"e850872b2fffcc790ebcddf7221ed835f465fd9c","user":{"login":"agco-fuse","id":18173515,"avatar_url":"https://avatars.githubusercontent.com/u/18173515?v=3","gravatar_id":"","url":"https://api.github.com/users/agco-fuse","html_url":"https://github.com/agco-fuse","followers_url":"https://api.github.com/users/agco-fuse/followers","following_url":"https://api.github.com/users/agco-fuse/following{/other_user}","gists_url":"https://api.github.com/users/agco-fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/agco-fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agco-fuse/subscriptions","organizations_url":"https://api.github.com/users/agco-fuse/orgs","repos_url":"https://api.github.com/users/agco-fuse/repos","events_url":"https://api.github.com/users/agco-fuse/events{/privacy}","received_events_url":"https://api.github.com/users/agco-fuse/received_events","type":"Organization","site_admin":false},"repo":{"id":55786259,"name":"fuse-equipment-api","full_name":"agco-fuse/fuse-equipment-api","owner":{"login":"agco-fuse","id":18173515,"avatar_url":"https://avatars.githubusercontent.com/u/18173515?v=3","gravatar_id":"","url":"https://api.github.com/users/agco-fuse","html_url":"https://github.com/agco-fuse","followers_url":"https://api.github.com/users/agco-fuse/followers","following_url":"https://api.github.com/users/agco-fuse/following{/other_user}","gists_url":"https://api.github.com/users/agco-fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/agco-fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agco-fuse/subscriptions","organizations_url":"https://api.github.com/users/agco-fuse/orgs","repos_url":"https://api.github.com/users/agco-fuse/repos","events_url":"https://api.github.com/users/agco-fuse/events{/privacy}","received_events_url":"https://api.github.com/users/agco-fuse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/agco-fuse/fuse-equipment-api","description":"","fork":false,"url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api","forks_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/forks","keys_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/teams","hooks_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/hooks","issue_events_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/events{/number}","events_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/events","assignees_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/assignees{/user}","branches_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/branches{/branch}","tags_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/tags","blobs_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/languages","stargazers_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/stargazers","contributors_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/contributors","subscribers_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/subscribers","subscription_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/subscription","commits_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/contents/{+path}","compare_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/merges","archive_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/downloads","issues_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues{/number}","pulls_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/labels{/name}","releases_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/releases{/id}","deployments_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/deployments","created_at":"2016-04-08T14:44:32Z","updated_at":"2016-04-12T14:49:55Z","pushed_at":"2016-04-15T19:36:46Z","git_url":"git://github.com/agco-fuse/fuse-equipment-api.git","ssh_url":"git@github.com:agco-fuse/fuse-equipment-api.git","clone_url":"https://github.com/agco-fuse/fuse-equipment-api.git","svn_url":"https://github.com/agco-fuse/fuse-equipment-api","homepage":null,"size":60,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"agco-fuse:master","ref":"master","sha":"5e59a9388f8ccc2a4b50bc44704efc1012b4ba8d","user":{"login":"agco-fuse","id":18173515,"avatar_url":"https://avatars.githubusercontent.com/u/18173515?v=3","gravatar_id":"","url":"https://api.github.com/users/agco-fuse","html_url":"https://github.com/agco-fuse","followers_url":"https://api.github.com/users/agco-fuse/followers","following_url":"https://api.github.com/users/agco-fuse/following{/other_user}","gists_url":"https://api.github.com/users/agco-fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/agco-fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agco-fuse/subscriptions","organizations_url":"https://api.github.com/users/agco-fuse/orgs","repos_url":"https://api.github.com/users/agco-fuse/repos","events_url":"https://api.github.com/users/agco-fuse/events{/privacy}","received_events_url":"https://api.github.com/users/agco-fuse/received_events","type":"Organization","site_admin":false},"repo":{"id":55786259,"name":"fuse-equipment-api","full_name":"agco-fuse/fuse-equipment-api","owner":{"login":"agco-fuse","id":18173515,"avatar_url":"https://avatars.githubusercontent.com/u/18173515?v=3","gravatar_id":"","url":"https://api.github.com/users/agco-fuse","html_url":"https://github.com/agco-fuse","followers_url":"https://api.github.com/users/agco-fuse/followers","following_url":"https://api.github.com/users/agco-fuse/following{/other_user}","gists_url":"https://api.github.com/users/agco-fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/agco-fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agco-fuse/subscriptions","organizations_url":"https://api.github.com/users/agco-fuse/orgs","repos_url":"https://api.github.com/users/agco-fuse/repos","events_url":"https://api.github.com/users/agco-fuse/events{/privacy}","received_events_url":"https://api.github.com/users/agco-fuse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/agco-fuse/fuse-equipment-api","description":"","fork":false,"url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api","forks_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/forks","keys_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/teams","hooks_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/hooks","issue_events_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/events{/number}","events_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/events","assignees_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/assignees{/user}","branches_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/branches{/branch}","tags_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/tags","blobs_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/languages","stargazers_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/stargazers","contributors_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/contributors","subscribers_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/subscribers","subscription_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/subscription","commits_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/contents/{+path}","compare_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/merges","archive_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/downloads","issues_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues{/number}","pulls_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/labels{/name}","releases_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/releases{/id}","deployments_url":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/deployments","created_at":"2016-04-08T14:44:32Z","updated_at":"2016-04-12T14:49:55Z","pushed_at":"2016-04-15T19:36:46Z","git_url":"git://github.com/agco-fuse/fuse-equipment-api.git","ssh_url":"git@github.com:agco-fuse/fuse-equipment-api.git","clone_url":"https://github.com/agco-fuse/fuse-equipment-api.git","svn_url":"https://github.com/agco-fuse/fuse-equipment-api","homepage":null,"size":60,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12"},"html":{"href":"https://github.com/agco-fuse/fuse-equipment-api/pull/12"},"issue":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/12"},"comments":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/agco-fuse/fuse-equipment-api/statuses/e850872b2fffcc790ebcddf7221ed835f465fd9c"}}}}