{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/919","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/919/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/919/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/919/events","html_url":"https://github.com/openzipkin/zipkin/issues/919","id":128873268,"number":919,"title":"Why does Span.serviceName give priority to ServerAddress?","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-26T16:38:49Z","updated_at":"2016-01-27T13:38:19Z","closed_at":null,"body":"I agree that server-side should take precedence over client-side, but it seems the CoreServer annotations should be the top priority, not ServerAddress binary annotation. In the current form, if 10 clients call the same service, but all decide to call it differently in ServerAddress, it will appear under 10 different names. And if the service owners wants to find traces in their service, they need to search under 10 names.\r\n\r\nBut if the CoreServer annotation is the first priority, it will always have the same name. \r\n"},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/175632019","html_url":"https://github.com/openzipkin/zipkin/issues/919#issuecomment-175632019","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/919","id":175632019,"user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"created_at":"2016-01-27T13:38:19Z","updated_at":"2016-01-27T13:38:19Z","body":"@adriancole by far-right do you mean those that will not log their own annotations? In that case the span will have Client Send/Recv and a ServerAddress, and the latter will win. I am not proposing to change that, only to let Server Send/Recv win over ServerAddress."}}