{"action":"closed","number":626,"pull_request":{"url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/626","id":86070848,"html_url":"https://github.com/assetgraph/assetgraph/pull/626","diff_url":"https://github.com/assetgraph/assetgraph/pull/626.diff","patch_url":"https://github.com/assetgraph/assetgraph/pull/626.patch","issue_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/626","number":626,"state":"closed","locked":false,"title":"Add ability to handle canonical relative urls","user":{"login":"Munter","id":331790,"avatar_url":"https://avatars.githubusercontent.com/u/331790?v=3","gravatar_id":"","url":"https://api.github.com/users/Munter","html_url":"https://github.com/Munter","followers_url":"https://api.github.com/users/Munter/followers","following_url":"https://api.github.com/users/Munter/following{/other_user}","gists_url":"https://api.github.com/users/Munter/gists{/gist_id}","starred_url":"https://api.github.com/users/Munter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Munter/subscriptions","organizations_url":"https://api.github.com/users/Munter/orgs","repos_url":"https://api.github.com/users/Munter/repos","events_url":"https://api.github.com/users/Munter/events{/privacy}","received_events_url":"https://api.github.com/users/Munter/received_events","type":"User","site_admin":false},"body":"This adds a new configuration for the assetgraph constructor: `canonicalRoot`\r\nA new `relation.hrefType: 'canonical'`has also been added.\r\n\r\nThe idea is to let assetgraph populate any href to a URL that is inside the `canonicalRoot` as if it was inside `assetGraph.root`.\r\n\r\nThis will enable us to pick up absolute URL's, like you often see in blog setups like jekyll or wordpress, where the deployment domain is prepended to the url. The same problem goes for OpenGraph relations, where the specification says to use an absolute url, but the assets are locally available.\r\n\r\nAm I even using canonical correctly at this point? Should this be called `deploymentRoot` and `deploymentRelative` instead?\r\n\r\nWork in progress...","created_at":"2016-09-20T22:54:35Z","updated_at":"2016-10-06T18:24:01Z","closed_at":"2016-10-06T18:24:01Z","merged_at":"2016-10-06T18:24:01Z","merge_commit_sha":"e7bb388952ab67a3776cb8d04ff746bfabf454d8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/626/commits","review_comments_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/626/comments","review_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/626/comments","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/4164c11893f00016966d1d6b68272a747adc1f11","head":{"label":"assetgraph:feature/canonicalRelativeRelation","ref":"feature/canonicalRelativeRelation","sha":"4164c11893f00016966d1d6b68272a747adc1f11","user":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?v=3","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":1324028,"name":"assetgraph","full_name":"assetgraph/assetgraph","owner":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?v=3","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assetgraph/assetgraph","description":"Optimization framework for web pages and applications","fork":false,"url":"https://api.github.com/repos/assetgraph/assetgraph","forks_url":"https://api.github.com/repos/assetgraph/assetgraph/forks","keys_url":"https://api.github.com/repos/assetgraph/assetgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assetgraph/assetgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assetgraph/assetgraph/teams","hooks_url":"https://api.github.com/repos/assetgraph/assetgraph/hooks","issue_events_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/events{/number}","events_url":"https://api.github.com/repos/assetgraph/assetgraph/events","assignees_url":"https://api.github.com/repos/assetgraph/assetgraph/assignees{/user}","branches_url":"https://api.github.com/repos/assetgraph/assetgraph/branches{/branch}","tags_url":"https://api.github.com/repos/assetgraph/assetgraph/tags","blobs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assetgraph/assetgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/assetgraph/assetgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/assetgraph/assetgraph/languages","stargazers_url":"https://api.github.com/repos/assetgraph/assetgraph/stargazers","contributors_url":"https://api.github.com/repos/assetgraph/assetgraph/contributors","subscribers_url":"https://api.github.com/repos/assetgraph/assetgraph/subscribers","subscription_url":"https://api.github.com/repos/assetgraph/assetgraph/subscription","commits_url":"https://api.github.com/repos/assetgraph/assetgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/assetgraph/assetgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/assetgraph/assetgraph/contents/{+path}","compare_url":"https://api.github.com/repos/assetgraph/assetgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assetgraph/assetgraph/merges","archive_url":"https://api.github.com/repos/assetgraph/assetgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assetgraph/assetgraph/downloads","issues_url":"https://api.github.com/repos/assetgraph/assetgraph/issues{/number}","pulls_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/assetgraph/assetgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/assetgraph/assetgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assetgraph/assetgraph/labels{/name}","releases_url":"https://api.github.com/repos/assetgraph/assetgraph/releases{/id}","deployments_url":"https://api.github.com/repos/assetgraph/assetgraph/deployments","created_at":"2011-02-03T13:05:29Z","updated_at":"2016-09-27T13:40:25Z","pushed_at":"2016-10-06T18:24:01Z","git_url":"git://github.com/assetgraph/assetgraph.git","ssh_url":"git@github.com:assetgraph/assetgraph.git","clone_url":"https://github.com/assetgraph/assetgraph.git","svn_url":"https://github.com/assetgraph/assetgraph","homepage":"","size":13983,"stargazers_count":663,"watchers_count":663,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":45,"forks":26,"open_issues":45,"watchers":663,"default_branch":"master"}},"base":{"label":"assetgraph:master","ref":"master","sha":"6d6b3a9ff4cbdbe45660ddb69802c3af0a1e26a1","user":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?v=3","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":1324028,"name":"assetgraph","full_name":"assetgraph/assetgraph","owner":{"login":"assetgraph","id":6302962,"avatar_url":"https://avatars.githubusercontent.com/u/6302962?v=3","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assetgraph/assetgraph","description":"Optimization framework for web pages and applications","fork":false,"url":"https://api.github.com/repos/assetgraph/assetgraph","forks_url":"https://api.github.com/repos/assetgraph/assetgraph/forks","keys_url":"https://api.github.com/repos/assetgraph/assetgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assetgraph/assetgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assetgraph/assetgraph/teams","hooks_url":"https://api.github.com/repos/assetgraph/assetgraph/hooks","issue_events_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/events{/number}","events_url":"https://api.github.com/repos/assetgraph/assetgraph/events","assignees_url":"https://api.github.com/repos/assetgraph/assetgraph/assignees{/user}","branches_url":"https://api.github.com/repos/assetgraph/assetgraph/branches{/branch}","tags_url":"https://api.github.com/repos/assetgraph/assetgraph/tags","blobs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assetgraph/assetgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/assetgraph/assetgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/assetgraph/assetgraph/languages","stargazers_url":"https://api.github.com/repos/assetgraph/assetgraph/stargazers","contributors_url":"https://api.github.com/repos/assetgraph/assetgraph/contributors","subscribers_url":"https://api.github.com/repos/assetgraph/assetgraph/subscribers","subscription_url":"https://api.github.com/repos/assetgraph/assetgraph/subscription","commits_url":"https://api.github.com/repos/assetgraph/assetgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/assetgraph/assetgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/assetgraph/assetgraph/contents/{+path}","compare_url":"https://api.github.com/repos/assetgraph/assetgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assetgraph/assetgraph/merges","archive_url":"https://api.github.com/repos/assetgraph/assetgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assetgraph/assetgraph/downloads","issues_url":"https://api.github.com/repos/assetgraph/assetgraph/issues{/number}","pulls_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/assetgraph/assetgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/assetgraph/assetgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assetgraph/assetgraph/labels{/name}","releases_url":"https://api.github.com/repos/assetgraph/assetgraph/releases{/id}","deployments_url":"https://api.github.com/repos/assetgraph/assetgraph/deployments","created_at":"2011-02-03T13:05:29Z","updated_at":"2016-09-27T13:40:25Z","pushed_at":"2016-10-06T18:24:01Z","git_url":"git://github.com/assetgraph/assetgraph.git","ssh_url":"git@github.com:assetgraph/assetgraph.git","clone_url":"https://github.com/assetgraph/assetgraph.git","svn_url":"https://github.com/assetgraph/assetgraph","homepage":"","size":13983,"stargazers_count":663,"watchers_count":663,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":45,"forks":26,"open_issues":45,"watchers":663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/626"},"html":{"href":"https://github.com/assetgraph/assetgraph/pull/626"},"issue":{"href":"https://api.github.com/repos/assetgraph/assetgraph/issues/626"},"comments":{"href":"https://api.github.com/repos/assetgraph/assetgraph/issues/626/comments"},"review_comments":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/626/comments"},"review_comment":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/626/commits"},"statuses":{"href":"https://api.github.com/repos/assetgraph/assetgraph/statuses/4164c11893f00016966d1d6b68272a747adc1f11"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Munter","id":331790,"avatar_url":"https://avatars.githubusercontent.com/u/331790?v=3","gravatar_id":"","url":"https://api.github.com/users/Munter","html_url":"https://github.com/Munter","followers_url":"https://api.github.com/users/Munter/followers","following_url":"https://api.github.com/users/Munter/following{/other_user}","gists_url":"https://api.github.com/users/Munter/gists{/gist_id}","starred_url":"https://api.github.com/users/Munter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Munter/subscriptions","organizations_url":"https://api.github.com/users/Munter/orgs","repos_url":"https://api.github.com/users/Munter/repos","events_url":"https://api.github.com/users/Munter/events{/privacy}","received_events_url":"https://api.github.com/users/Munter/received_events","type":"User","site_admin":false},"comments":15,"review_comments":15,"commits":9,"additions":333,"deletions":7,"changed_files":8}}
{"actor":{"display_login":"Munter"}}