{"action":"created","comment":{"url":"https://api.github.com/repos/graze/ciff-renderer/pulls/comments/90956427","pull_request_review_id":11444253,"id":90956427,"diff_hunk":"@@ -0,0 +1,22 @@\n+<?php\n+\n+namespace Graze\\CiffRenderer\\Parser\\FieldParser\\FieldParserDate\\DateFormatter;\n+\n+use Graze\\CiffRenderer\\Parser\\FieldParser\\FieldParserDate\\DateFormatter\\DateFormatterInterface;\n+use Urbanplum\\DotnetDateTime\\DotnetDateTime;\n+\n+class DateFormatterBasic implements DateFormatterInterface\n+{\n+    /**\n+     * @param \\DateTimeInterface $date\n+     * @param string $format\n+     * @return string\n+     */\n+    public function format(\\DateTimeInterface $date, $format)\n+    {\n+        $dotnetDateTime = new DotnetDateTime();\n+        $phpFormat = $dotnetDateTime->formatToPhp($format);","path":"src/Parser/FieldParser/FieldParserDate/DateFormatter/DateFormatterBasic.php","position":18,"original_position":18,"commit_id":"56cf288be40eea83e9a91f83eeb45f52b95f4d3b","original_commit_id":"56cf288be40eea83e9a91f83eeb45f52b95f4d3b","user":{"login":"wpillar","id":188514,"avatar_url":"https://avatars.githubusercontent.com/u/188514?v=3","gravatar_id":"","url":"https://api.github.com/users/wpillar","html_url":"https://github.com/wpillar","followers_url":"https://api.github.com/users/wpillar/followers","following_url":"https://api.github.com/users/wpillar/following{/other_user}","gists_url":"https://api.github.com/users/wpillar/gists{/gist_id}","starred_url":"https://api.github.com/users/wpillar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpillar/subscriptions","organizations_url":"https://api.github.com/users/wpillar/orgs","repos_url":"https://api.github.com/users/wpillar/repos","events_url":"https://api.github.com/users/wpillar/events{/privacy}","received_events_url":"https://api.github.com/users/wpillar/received_events","type":"User","site_admin":false},"body":"What's all this about?","created_at":"2016-12-05T21:13:38Z","updated_at":"2016-12-05T21:13:38Z","html_url":"https://github.com/graze/ciff-renderer/pull/19#discussion_r90956427","pull_request_url":"https://api.github.com/repos/graze/ciff-renderer/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/graze/ciff-renderer/pulls/comments/90956427"},"html":{"href":"https://github.com/graze/ciff-renderer/pull/19#discussion_r90956427"},"pull_request":{"href":"https://api.github.com/repos/graze/ciff-renderer/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/graze/ciff-renderer/pulls/19","id":94967176,"html_url":"https://github.com/graze/ciff-renderer/pull/19","diff_url":"https://github.com/graze/ciff-renderer/pull/19.diff","patch_url":"https://github.com/graze/ciff-renderer/pull/19.patch","issue_url":"https://api.github.com/repos/graze/ciff-renderer/issues/19","number":19,"state":"open","locked":false,"title":"Refactor - 01 - decoupling","user":{"login":"john-n-smith","id":1314694,"avatar_url":"https://avatars.githubusercontent.com/u/1314694?v=3","gravatar_id":"","url":"https://api.github.com/users/john-n-smith","html_url":"https://github.com/john-n-smith","followers_url":"https://api.github.com/users/john-n-smith/followers","following_url":"https://api.github.com/users/john-n-smith/following{/other_user}","gists_url":"https://api.github.com/users/john-n-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/john-n-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-n-smith/subscriptions","organizations_url":"https://api.github.com/users/john-n-smith/orgs","repos_url":"https://api.github.com/users/john-n-smith/repos","events_url":"https://api.github.com/users/john-n-smith/events{/privacy}","received_events_url":"https://api.github.com/users/john-n-smith/received_events","type":"User","site_admin":false},"body":"This is a major rewrite and going to be tricky to review. It may not be useful to compare it to the original code base.\r\n\r\nMajor changes are: \r\n- Injecting dependencies\r\n- Separation of Parsers from Renderers  - no need for the two to be linked\r\n- No longer necessary for Renderer Builders\r\n- Re-write tests (now dependencies can be mocked)\r\n- Removed Parser tests as they are to be rewritten in a subsequent PR\r\n\r\nUnfortunately, injecting dependencies means breaking API changes in the way `CiffRenderer` is constructed. This will be released as 2.0.0.\r\n\r\nThere are additional PRs with prefix `Refactor - xx -`, which should be reviewed in ascending order.","created_at":"2016-11-23T09:24:11Z","updated_at":"2016-12-05T21:27:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53e0f2455bbef79555d8d301e8c5bbfec9a7db53","assignee":{"login":"wpillar","id":188514,"avatar_url":"https://avatars.githubusercontent.com/u/188514?v=3","gravatar_id":"","url":"https://api.github.com/users/wpillar","html_url":"https://github.com/wpillar","followers_url":"https://api.github.com/users/wpillar/followers","following_url":"https://api.github.com/users/wpillar/following{/other_user}","gists_url":"https://api.github.com/users/wpillar/gists{/gist_id}","starred_url":"https://api.github.com/users/wpillar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpillar/subscriptions","organizations_url":"https://api.github.com/users/wpillar/orgs","repos_url":"https://api.github.com/users/wpillar/repos","events_url":"https://api.github.com/users/wpillar/events{/privacy}","received_events_url":"https://api.github.com/users/wpillar/received_events","type":"User","site_admin":false},"assignees":[{"login":"wpillar","id":188514,"avatar_url":"https://avatars.githubusercontent.com/u/188514?v=3","gravatar_id":"","url":"https://api.github.com/users/wpillar","html_url":"https://github.com/wpillar","followers_url":"https://api.github.com/users/wpillar/followers","following_url":"https://api.github.com/users/wpillar/following{/other_user}","gists_url":"https://api.github.com/users/wpillar/gists{/gist_id}","starred_url":"https://api.github.com/users/wpillar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpillar/subscriptions","organizations_url":"https://api.github.com/users/wpillar/orgs","repos_url":"https://api.github.com/users/wpillar/repos","events_url":"https://api.github.com/users/wpillar/events{/privacy}","received_events_url":"https://api.github.com/users/wpillar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/graze/ciff-renderer/pulls/19/commits","review_comments_url":"https://api.github.com/repos/graze/ciff-renderer/pulls/19/comments","review_comment_url":"https://api.github.com/repos/graze/ciff-renderer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graze/ciff-renderer/issues/19/comments","statuses_url":"https://api.github.com/repos/graze/ciff-renderer/statuses/56cf288be40eea83e9a91f83eeb45f52b95f4d3b","head":{"label":"graze:refactor-01-decoupling","ref":"refactor-01-decoupling","sha":"56cf288be40eea83e9a91f83eeb45f52b95f4d3b","user":{"login":"graze","id":637788,"avatar_url":"https://avatars.githubusercontent.com/u/637788?v=3","gravatar_id":"","url":"https://api.github.com/users/graze","html_url":"https://github.com/graze","followers_url":"https://api.github.com/users/graze/followers","following_url":"https://api.github.com/users/graze/following{/other_user}","gists_url":"https://api.github.com/users/graze/gists{/gist_id}","starred_url":"https://api.github.com/users/graze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graze/subscriptions","organizations_url":"https://api.github.com/users/graze/orgs","repos_url":"https://api.github.com/users/graze/repos","events_url":"https://api.github.com/users/graze/events{/privacy}","received_events_url":"https://api.github.com/users/graze/received_events","type":"Organization","site_admin":false},"repo":{"id":37184174,"name":"ciff-renderer","full_name":"graze/ciff-renderer","owner":{"login":"graze","id":637788,"avatar_url":"https://avatars.githubusercontent.com/u/637788?v=3","gravatar_id":"","url":"https://api.github.com/users/graze","html_url":"https://github.com/graze","followers_url":"https://api.github.com/users/graze/followers","following_url":"https://api.github.com/users/graze/following{/other_user}","gists_url":"https://api.github.com/users/graze/gists{/gist_id}","starred_url":"https://api.github.com/users/graze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graze/subscriptions","organizations_url":"https://api.github.com/users/graze/orgs","repos_url":"https://api.github.com/users/graze/repos","events_url":"https://api.github.com/users/graze/events{/privacy}","received_events_url":"https://api.github.com/users/graze/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graze/ciff-renderer","description":":pencil2: Render Coder Independent File Format (.CIFF) files using PHP","fork":false,"url":"https://api.github.com/repos/graze/ciff-renderer","forks_url":"https://api.github.com/repos/graze/ciff-renderer/forks","keys_url":"https://api.github.com/repos/graze/ciff-renderer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graze/ciff-renderer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graze/ciff-renderer/teams","hooks_url":"https://api.github.com/repos/graze/ciff-renderer/hooks","issue_events_url":"https://api.github.com/repos/graze/ciff-renderer/issues/events{/number}","events_url":"https://api.github.com/repos/graze/ciff-renderer/events","assignees_url":"https://api.github.com/repos/graze/ciff-renderer/assignees{/user}","branches_url":"https://api.github.com/repos/graze/ciff-renderer/branches{/branch}","tags_url":"https://api.github.com/repos/graze/ciff-renderer/tags","blobs_url":"https://api.github.com/repos/graze/ciff-renderer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graze/ciff-renderer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graze/ciff-renderer/git/refs{/sha}","trees_url":"https://api.github.com/repos/graze/ciff-renderer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graze/ciff-renderer/statuses/{sha}","languages_url":"https://api.github.com/repos/graze/ciff-renderer/languages","stargazers_url":"https://api.github.com/repos/graze/ciff-renderer/stargazers","contributors_url":"https://api.github.com/repos/graze/ciff-renderer/contributors","subscribers_url":"https://api.github.com/repos/graze/ciff-renderer/subscribers","subscription_url":"https://api.github.com/repos/graze/ciff-renderer/subscription","commits_url":"https://api.github.com/repos/graze/ciff-renderer/commits{/sha}","git_commits_url":"https://api.github.com/repos/graze/ciff-renderer/git/commits{/sha}","comments_url":"https://api.github.com/repos/graze/ciff-renderer/comments{/number}","issue_comment_url":"https://api.github.com/repos/graze/ciff-renderer/issues/comments{/number}","contents_url":"https://api.github.com/repos/graze/ciff-renderer/contents/{+path}","compare_url":"https://api.github.com/repos/graze/ciff-renderer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graze/ciff-renderer/merges","archive_url":"https://api.github.com/repos/graze/ciff-renderer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graze/ciff-renderer/downloads","issues_url":"https://api.github.com/repos/graze/ciff-renderer/issues{/number}","pulls_url":"https://api.github.com/repos/graze/ciff-renderer/pulls{/number}","milestones_url":"https://api.github.com/repos/graze/ciff-renderer/milestones{/number}","notifications_url":"https://api.github.com/repos/graze/ciff-renderer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graze/ciff-renderer/labels{/name}","releases_url":"https://api.github.com/repos/graze/ciff-renderer/releases{/id}","deployments_url":"https://api.github.com/repos/graze/ciff-renderer/deployments","created_at":"2015-06-10T08:12:15Z","updated_at":"2016-11-17T21:33:19Z","pushed_at":"2016-12-03T11:27:20Z","git_url":"git://github.com/graze/ciff-renderer.git","ssh_url":"git@github.com:graze/ciff-renderer.git","clone_url":"https://github.com/graze/ciff-renderer.git","svn_url":"https://github.com/graze/ciff-renderer","homepage":"","size":222,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"graze:master","ref":"master","sha":"958457aa025c1171010c71cfb01f99f256335368","user":{"login":"graze","id":637788,"avatar_url":"https://avatars.githubusercontent.com/u/637788?v=3","gravatar_id":"","url":"https://api.github.com/users/graze","html_url":"https://github.com/graze","followers_url":"https://api.github.com/users/graze/followers","following_url":"https://api.github.com/users/graze/following{/other_user}","gists_url":"https://api.github.com/users/graze/gists{/gist_id}","starred_url":"https://api.github.com/users/graze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graze/subscriptions","organizations_url":"https://api.github.com/users/graze/orgs","repos_url":"https://api.github.com/users/graze/repos","events_url":"https://api.github.com/users/graze/events{/privacy}","received_events_url":"https://api.github.com/users/graze/received_events","type":"Organization","site_admin":false},"repo":{"id":37184174,"name":"ciff-renderer","full_name":"graze/ciff-renderer","owner":{"login":"graze","id":637788,"avatar_url":"https://avatars.githubusercontent.com/u/637788?v=3","gravatar_id":"","url":"https://api.github.com/users/graze","html_url":"https://github.com/graze","followers_url":"https://api.github.com/users/graze/followers","following_url":"https://api.github.com/users/graze/following{/other_user}","gists_url":"https://api.github.com/users/graze/gists{/gist_id}","starred_url":"https://api.github.com/users/graze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graze/subscriptions","organizations_url":"https://api.github.com/users/graze/orgs","repos_url":"https://api.github.com/users/graze/repos","events_url":"https://api.github.com/users/graze/events{/privacy}","received_events_url":"https://api.github.com/users/graze/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graze/ciff-renderer","description":":pencil2: Render Coder Independent File Format (.CIFF) files using PHP","fork":false,"url":"https://api.github.com/repos/graze/ciff-renderer","forks_url":"https://api.github.com/repos/graze/ciff-renderer/forks","keys_url":"https://api.github.com/repos/graze/ciff-renderer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graze/ciff-renderer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graze/ciff-renderer/teams","hooks_url":"https://api.github.com/repos/graze/ciff-renderer/hooks","issue_events_url":"https://api.github.com/repos/graze/ciff-renderer/issues/events{/number}","events_url":"https://api.github.com/repos/graze/ciff-renderer/events","assignees_url":"https://api.github.com/repos/graze/ciff-renderer/assignees{/user}","branches_url":"https://api.github.com/repos/graze/ciff-renderer/branches{/branch}","tags_url":"https://api.github.com/repos/graze/ciff-renderer/tags","blobs_url":"https://api.github.com/repos/graze/ciff-renderer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graze/ciff-renderer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graze/ciff-renderer/git/refs{/sha}","trees_url":"https://api.github.com/repos/graze/ciff-renderer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graze/ciff-renderer/statuses/{sha}","languages_url":"https://api.github.com/repos/graze/ciff-renderer/languages","stargazers_url":"https://api.github.com/repos/graze/ciff-renderer/stargazers","contributors_url":"https://api.github.com/repos/graze/ciff-renderer/contributors","subscribers_url":"https://api.github.com/repos/graze/ciff-renderer/subscribers","subscription_url":"https://api.github.com/repos/graze/ciff-renderer/subscription","commits_url":"https://api.github.com/repos/graze/ciff-renderer/commits{/sha}","git_commits_url":"https://api.github.com/repos/graze/ciff-renderer/git/commits{/sha}","comments_url":"https://api.github.com/repos/graze/ciff-renderer/comments{/number}","issue_comment_url":"https://api.github.com/repos/graze/ciff-renderer/issues/comments{/number}","contents_url":"https://api.github.com/repos/graze/ciff-renderer/contents/{+path}","compare_url":"https://api.github.com/repos/graze/ciff-renderer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graze/ciff-renderer/merges","archive_url":"https://api.github.com/repos/graze/ciff-renderer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graze/ciff-renderer/downloads","issues_url":"https://api.github.com/repos/graze/ciff-renderer/issues{/number}","pulls_url":"https://api.github.com/repos/graze/ciff-renderer/pulls{/number}","milestones_url":"https://api.github.com/repos/graze/ciff-renderer/milestones{/number}","notifications_url":"https://api.github.com/repos/graze/ciff-renderer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graze/ciff-renderer/labels{/name}","releases_url":"https://api.github.com/repos/graze/ciff-renderer/releases{/id}","deployments_url":"https://api.github.com/repos/graze/ciff-renderer/deployments","created_at":"2015-06-10T08:12:15Z","updated_at":"2016-11-17T21:33:19Z","pushed_at":"2016-12-03T11:27:20Z","git_url":"git://github.com/graze/ciff-renderer.git","ssh_url":"git@github.com:graze/ciff-renderer.git","clone_url":"https://github.com/graze/ciff-renderer.git","svn_url":"https://github.com/graze/ciff-renderer","homepage":"","size":222,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graze/ciff-renderer/pulls/19"},"html":{"href":"https://github.com/graze/ciff-renderer/pull/19"},"issue":{"href":"https://api.github.com/repos/graze/ciff-renderer/issues/19"},"comments":{"href":"https://api.github.com/repos/graze/ciff-renderer/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/graze/ciff-renderer/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/graze/ciff-renderer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graze/ciff-renderer/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/graze/ciff-renderer/statuses/56cf288be40eea83e9a91f83eeb45f52b95f4d3b"}}}}
{"actor":{"display_login":"wpillar"}}