{"action":"created","comment":{"url":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/comments/70721736","id":70721736,"diff_hunk":"@@ -268,7 +268,7 @@ def readTestcaseLine(line):\n def writeTestcase(filename):\n     with open(filename, \"w\") as file:\n         file.write(before)\n-        for i in range(len(parts)):\n+        for i in xrange(len(parts)):","path":"lithium/lithium.py","position":null,"original_position":5,"commit_id":"8f05c6a487b04b7d08ba9e4887aae24e4ac6c0d1","original_commit_id":"b96d5154af652d5a4f6e4214978e21a866f5ca62","user":{"login":"tysmith","id":4673661,"avatar_url":"https://avatars.githubusercontent.com/u/4673661?v=3","gravatar_id":"","url":"https://api.github.com/users/tysmith","html_url":"https://github.com/tysmith","followers_url":"https://api.github.com/users/tysmith/followers","following_url":"https://api.github.com/users/tysmith/following{/other_user}","gists_url":"https://api.github.com/users/tysmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tysmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysmith/subscriptions","organizations_url":"https://api.github.com/users/tysmith/orgs","repos_url":"https://api.github.com/users/tysmith/repos","events_url":"https://api.github.com/users/tysmith/events{/privacy}","received_events_url":"https://api.github.com/users/tysmith/received_events","type":"User","site_admin":false},"body":"xrange() does not exist in python3 and the benefit is very likely unnoticeable. I'd stick with range.","created_at":"2016-07-13T22:41:14Z","updated_at":"2016-07-13T22:41:14Z","html_url":"https://github.com/MozillaSecurity/lithium/pull/5#discussion_r70721736","pull_request_url":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/comments/70721736"},"html":{"href":"https://github.com/MozillaSecurity/lithium/pull/5#discussion_r70721736"},"pull_request":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5","id":77372613,"html_url":"https://github.com/MozillaSecurity/lithium/pull/5","diff_url":"https://github.com/MozillaSecurity/lithium/pull/5.diff","patch_url":"https://github.com/MozillaSecurity/lithium/pull/5.patch","issue_url":"https://api.github.com/repos/MozillaSecurity/lithium/issues/5","number":5,"state":"open","locked":false,"title":"Lint fixes","user":{"login":"nth10sd","id":488630,"avatar_url":"https://avatars.githubusercontent.com/u/488630?v=3","gravatar_id":"","url":"https://api.github.com/users/nth10sd","html_url":"https://github.com/nth10sd","followers_url":"https://api.github.com/users/nth10sd/followers","following_url":"https://api.github.com/users/nth10sd/following{/other_user}","gists_url":"https://api.github.com/users/nth10sd/gists{/gist_id}","starred_url":"https://api.github.com/users/nth10sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nth10sd/subscriptions","organizations_url":"https://api.github.com/users/nth10sd/orgs","repos_url":"https://api.github.com/users/nth10sd/repos","events_url":"https://api.github.com/users/nth10sd/events{/privacy}","received_events_url":"https://api.github.com/users/nth10sd/received_events","type":"User","site_admin":false},"body":"As per #4, this PR fixes the majority of issues (excluding globals) pointed out by various linters (pep8, pep257, Mc Cabe, pyflakes, pylint). I had set up the linter-python extension in Atom to look for these issues.\r\n\r\nI've tried to separate out the changes to different atomic commits. For whitespace changes, check out this [neat GitHub trick](https://github.com/blog/967-github-secrets).\r\n\r\nI'm not entirely sure about the last commit. Is the repeat variable really not used? How should the code be fixed? I can remove this commit from the PR if needed.\r\n\r\n@jruderman and @tysmith, I would appreciate if you can take a look. Thanks!","created_at":"2016-07-13T22:28:27Z","updated_at":"2016-07-13T22:41:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff93d540f817315839bf4a788913103214ec8b49","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5/commits","review_comments_url":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5/comments","review_comment_url":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MozillaSecurity/lithium/issues/5/comments","statuses_url":"https://api.github.com/repos/MozillaSecurity/lithium/statuses/8f05c6a487b04b7d08ba9e4887aae24e4ac6c0d1","head":{"label":"nth10sd:lint-fixes","ref":"lint-fixes","sha":"8f05c6a487b04b7d08ba9e4887aae24e4ac6c0d1","user":{"login":"nth10sd","id":488630,"avatar_url":"https://avatars.githubusercontent.com/u/488630?v=3","gravatar_id":"","url":"https://api.github.com/users/nth10sd","html_url":"https://github.com/nth10sd","followers_url":"https://api.github.com/users/nth10sd/followers","following_url":"https://api.github.com/users/nth10sd/following{/other_user}","gists_url":"https://api.github.com/users/nth10sd/gists{/gist_id}","starred_url":"https://api.github.com/users/nth10sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nth10sd/subscriptions","organizations_url":"https://api.github.com/users/nth10sd/orgs","repos_url":"https://api.github.com/users/nth10sd/repos","events_url":"https://api.github.com/users/nth10sd/events{/privacy}","received_events_url":"https://api.github.com/users/nth10sd/received_events","type":"User","site_admin":false},"repo":{"id":38802369,"name":"lithium","full_name":"nth10sd/lithium","owner":{"login":"nth10sd","id":488630,"avatar_url":"https://avatars.githubusercontent.com/u/488630?v=3","gravatar_id":"","url":"https://api.github.com/users/nth10sd","html_url":"https://github.com/nth10sd","followers_url":"https://api.github.com/users/nth10sd/followers","following_url":"https://api.github.com/users/nth10sd/following{/other_user}","gists_url":"https://api.github.com/users/nth10sd/gists{/gist_id}","starred_url":"https://api.github.com/users/nth10sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nth10sd/subscriptions","organizations_url":"https://api.github.com/users/nth10sd/orgs","repos_url":"https://api.github.com/users/nth10sd/repos","events_url":"https://api.github.com/users/nth10sd/events{/privacy}","received_events_url":"https://api.github.com/users/nth10sd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nth10sd/lithium","description":"Line-based testcase reducer","fork":true,"url":"https://api.github.com/repos/nth10sd/lithium","forks_url":"https://api.github.com/repos/nth10sd/lithium/forks","keys_url":"https://api.github.com/repos/nth10sd/lithium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nth10sd/lithium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nth10sd/lithium/teams","hooks_url":"https://api.github.com/repos/nth10sd/lithium/hooks","issue_events_url":"https://api.github.com/repos/nth10sd/lithium/issues/events{/number}","events_url":"https://api.github.com/repos/nth10sd/lithium/events","assignees_url":"https://api.github.com/repos/nth10sd/lithium/assignees{/user}","branches_url":"https://api.github.com/repos/nth10sd/lithium/branches{/branch}","tags_url":"https://api.github.com/repos/nth10sd/lithium/tags","blobs_url":"https://api.github.com/repos/nth10sd/lithium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nth10sd/lithium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nth10sd/lithium/git/refs{/sha}","trees_url":"https://api.github.com/repos/nth10sd/lithium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nth10sd/lithium/statuses/{sha}","languages_url":"https://api.github.com/repos/nth10sd/lithium/languages","stargazers_url":"https://api.github.com/repos/nth10sd/lithium/stargazers","contributors_url":"https://api.github.com/repos/nth10sd/lithium/contributors","subscribers_url":"https://api.github.com/repos/nth10sd/lithium/subscribers","subscription_url":"https://api.github.com/repos/nth10sd/lithium/subscription","commits_url":"https://api.github.com/repos/nth10sd/lithium/commits{/sha}","git_commits_url":"https://api.github.com/repos/nth10sd/lithium/git/commits{/sha}","comments_url":"https://api.github.com/repos/nth10sd/lithium/comments{/number}","issue_comment_url":"https://api.github.com/repos/nth10sd/lithium/issues/comments{/number}","contents_url":"https://api.github.com/repos/nth10sd/lithium/contents/{+path}","compare_url":"https://api.github.com/repos/nth10sd/lithium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nth10sd/lithium/merges","archive_url":"https://api.github.com/repos/nth10sd/lithium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nth10sd/lithium/downloads","issues_url":"https://api.github.com/repos/nth10sd/lithium/issues{/number}","pulls_url":"https://api.github.com/repos/nth10sd/lithium/pulls{/number}","milestones_url":"https://api.github.com/repos/nth10sd/lithium/milestones{/number}","notifications_url":"https://api.github.com/repos/nth10sd/lithium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nth10sd/lithium/labels{/name}","releases_url":"https://api.github.com/repos/nth10sd/lithium/releases{/id}","deployments_url":"https://api.github.com/repos/nth10sd/lithium/deployments","created_at":"2015-07-09T06:36:56Z","updated_at":"2016-01-26T08:25:55Z","pushed_at":"2016-07-13T22:22:23Z","git_url":"git://github.com/nth10sd/lithium.git","ssh_url":"git@github.com:nth10sd/lithium.git","clone_url":"https://github.com/nth10sd/lithium.git","svn_url":"https://github.com/nth10sd/lithium","homepage":"https://www.squarefree.com/lithium/using.html","size":341,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MozillaSecurity:master","ref":"master","sha":"d2bc7e18c6273d483c2282a9df77a4ccdc04b1b5","user":{"login":"MozillaSecurity","id":7916837,"avatar_url":"https://avatars.githubusercontent.com/u/7916837?v=3","gravatar_id":"","url":"https://api.github.com/users/MozillaSecurity","html_url":"https://github.com/MozillaSecurity","followers_url":"https://api.github.com/users/MozillaSecurity/followers","following_url":"https://api.github.com/users/MozillaSecurity/following{/other_user}","gists_url":"https://api.github.com/users/MozillaSecurity/gists{/gist_id}","starred_url":"https://api.github.com/users/MozillaSecurity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MozillaSecurity/subscriptions","organizations_url":"https://api.github.com/users/MozillaSecurity/orgs","repos_url":"https://api.github.com/users/MozillaSecurity/repos","events_url":"https://api.github.com/users/MozillaSecurity/events{/privacy}","received_events_url":"https://api.github.com/users/MozillaSecurity/received_events","type":"Organization","site_admin":false},"repo":{"id":38723305,"name":"lithium","full_name":"MozillaSecurity/lithium","owner":{"login":"MozillaSecurity","id":7916837,"avatar_url":"https://avatars.githubusercontent.com/u/7916837?v=3","gravatar_id":"","url":"https://api.github.com/users/MozillaSecurity","html_url":"https://github.com/MozillaSecurity","followers_url":"https://api.github.com/users/MozillaSecurity/followers","following_url":"https://api.github.com/users/MozillaSecurity/following{/other_user}","gists_url":"https://api.github.com/users/MozillaSecurity/gists{/gist_id}","starred_url":"https://api.github.com/users/MozillaSecurity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MozillaSecurity/subscriptions","organizations_url":"https://api.github.com/users/MozillaSecurity/orgs","repos_url":"https://api.github.com/users/MozillaSecurity/repos","events_url":"https://api.github.com/users/MozillaSecurity/events{/privacy}","received_events_url":"https://api.github.com/users/MozillaSecurity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MozillaSecurity/lithium","description":"Line-based testcase reducer","fork":false,"url":"https://api.github.com/repos/MozillaSecurity/lithium","forks_url":"https://api.github.com/repos/MozillaSecurity/lithium/forks","keys_url":"https://api.github.com/repos/MozillaSecurity/lithium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MozillaSecurity/lithium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MozillaSecurity/lithium/teams","hooks_url":"https://api.github.com/repos/MozillaSecurity/lithium/hooks","issue_events_url":"https://api.github.com/repos/MozillaSecurity/lithium/issues/events{/number}","events_url":"https://api.github.com/repos/MozillaSecurity/lithium/events","assignees_url":"https://api.github.com/repos/MozillaSecurity/lithium/assignees{/user}","branches_url":"https://api.github.com/repos/MozillaSecurity/lithium/branches{/branch}","tags_url":"https://api.github.com/repos/MozillaSecurity/lithium/tags","blobs_url":"https://api.github.com/repos/MozillaSecurity/lithium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MozillaSecurity/lithium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MozillaSecurity/lithium/git/refs{/sha}","trees_url":"https://api.github.com/repos/MozillaSecurity/lithium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MozillaSecurity/lithium/statuses/{sha}","languages_url":"https://api.github.com/repos/MozillaSecurity/lithium/languages","stargazers_url":"https://api.github.com/repos/MozillaSecurity/lithium/stargazers","contributors_url":"https://api.github.com/repos/MozillaSecurity/lithium/contributors","subscribers_url":"https://api.github.com/repos/MozillaSecurity/lithium/subscribers","subscription_url":"https://api.github.com/repos/MozillaSecurity/lithium/subscription","commits_url":"https://api.github.com/repos/MozillaSecurity/lithium/commits{/sha}","git_commits_url":"https://api.github.com/repos/MozillaSecurity/lithium/git/commits{/sha}","comments_url":"https://api.github.com/repos/MozillaSecurity/lithium/comments{/number}","issue_comment_url":"https://api.github.com/repos/MozillaSecurity/lithium/issues/comments{/number}","contents_url":"https://api.github.com/repos/MozillaSecurity/lithium/contents/{+path}","compare_url":"https://api.github.com/repos/MozillaSecurity/lithium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MozillaSecurity/lithium/merges","archive_url":"https://api.github.com/repos/MozillaSecurity/lithium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MozillaSecurity/lithium/downloads","issues_url":"https://api.github.com/repos/MozillaSecurity/lithium/issues{/number}","pulls_url":"https://api.github.com/repos/MozillaSecurity/lithium/pulls{/number}","milestones_url":"https://api.github.com/repos/MozillaSecurity/lithium/milestones{/number}","notifications_url":"https://api.github.com/repos/MozillaSecurity/lithium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MozillaSecurity/lithium/labels{/name}","releases_url":"https://api.github.com/repos/MozillaSecurity/lithium/releases{/id}","deployments_url":"https://api.github.com/repos/MozillaSecurity/lithium/deployments","created_at":"2015-07-08T00:57:39Z","updated_at":"2016-06-29T07:58:24Z","pushed_at":"2016-07-13T22:28:27Z","git_url":"git://github.com/MozillaSecurity/lithium.git","ssh_url":"git@github.com:MozillaSecurity/lithium.git","clone_url":"https://github.com/MozillaSecurity/lithium.git","svn_url":"https://github.com/MozillaSecurity/lithium","homepage":"https://www.squarefree.com/lithium/using.html","size":339,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5"},"html":{"href":"https://github.com/MozillaSecurity/lithium/pull/5"},"issue":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/issues/5"},"comments":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/MozillaSecurity/lithium/statuses/8f05c6a487b04b7d08ba9e4887aae24e4ac6c0d1"}}}}
{"actor":{"display_login":"tysmith"}}