{"action":"created","comment":{"url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/comments/68933167","id":68933167,"diff_hunk":"@@ -35,28 +39,28 @@\n \t        });\n \t    };\n \n-\t    $scope.isSelected = function(usr) {\n+\t    $scope.isSelected = function (usr) {\n \t        return _.find($scope.selectedUsers, function (itm) {\n \t            return itm.Id == usr.Id;\n \t        }) !== undefined;\n \t    };\n \n \t    $scope.isSelectedAll = function () {\n-\t        return $scope.users !== undefined && _.every($scope.users.items, function(itm) {\n-\t            return !!_.find($scope.selectedUsers, function(itm2) {\n+\t        return $scope.users !== undefined && _.every($scope.users.items, function (itm) {\n+\t            return !!_.find($scope.selectedUsers, function (itm2) {\n \t                return itm.Id == itm2.Id;\n \t            });\n \t        });\n \t    };\n \n \t    $scope.selectUser = function (usr) {\n-            if (!$scope.isSelected(usr)) {\n-                $scope.selectedUsers.push(usr);\n-            } else {\n-                $scope.selectedUsers = _.reject($scope.selectedUsers, function (itm) {\n-                    return itm.Id == usr.Id;\n-                });\n-            }\n+\t        if (!$scope.isSelected(usr)) {","path":"src/Our.Umbraco.BulkUserAdmin/Web/UI/App_Plugins/BulkUserAdmin/js/bua.controllers.js","position":58,"original_position":58,"commit_id":"779349e6baac045ec275c27f49b79ca5de0e970a","original_commit_id":"779349e6baac045ec275c27f49b79ca5de0e970a","user":{"login":"leekelleher","id":209066,"avatar_url":"https://avatars.githubusercontent.com/u/209066?v=3","gravatar_id":"","url":"https://api.github.com/users/leekelleher","html_url":"https://github.com/leekelleher","followers_url":"https://api.github.com/users/leekelleher/followers","following_url":"https://api.github.com/users/leekelleher/following{/other_user}","gists_url":"https://api.github.com/users/leekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/leekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leekelleher/subscriptions","organizations_url":"https://api.github.com/users/leekelleher/orgs","repos_url":"https://api.github.com/users/leekelleher/repos","events_url":"https://api.github.com/users/leekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/leekelleher/received_events","type":"User","site_admin":false},"body":"Hmmm, good question. Like I say, no biggie, it's fixable.\r\n\r\nPersonally I tend to do a `CTRL+K,CTRL+D` in VS Studio to format the code, not sure if VSCode supports that? or maybe we could give something like [EditorConfig](http://editorconfig.org/) a try?\r\n\r\nBut I guess EditorConfig is something that we could apply on multiple projects for consistency.","created_at":"2016-06-29T11:57:30Z","updated_at":"2016-06-29T11:57:30Z","html_url":"https://github.com/leekelleher/umbraco-bulk-user-admin/pull/5#discussion_r68933167","pull_request_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/comments/68933167"},"html":{"href":"https://github.com/leekelleher/umbraco-bulk-user-admin/pull/5#discussion_r68933167"},"pull_request":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5","id":75534498,"html_url":"https://github.com/leekelleher/umbraco-bulk-user-admin/pull/5","diff_url":"https://github.com/leekelleher/umbraco-bulk-user-admin/pull/5.diff","patch_url":"https://github.com/leekelleher/umbraco-bulk-user-admin/pull/5.patch","issue_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/issues/5","number":5,"state":"open","locked":false,"title":"Added in Sortable headers to dashboard table","user":{"login":"jamiepollock","id":5408006,"avatar_url":"https://avatars.githubusercontent.com/u/5408006?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiepollock","html_url":"https://github.com/jamiepollock","followers_url":"https://api.github.com/users/jamiepollock/followers","following_url":"https://api.github.com/users/jamiepollock/following{/other_user}","gists_url":"https://api.github.com/users/jamiepollock/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiepollock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiepollock/subscriptions","organizations_url":"https://api.github.com/users/jamiepollock/orgs","repos_url":"https://api.github.com/users/jamiepollock/repos","events_url":"https://api.github.com/users/jamiepollock/events{/privacy}","received_events_url":"https://api.github.com/users/jamiepollock/received_events","type":"User","site_admin":false},"body":"Based on Umbraco v7.3 (or lower) logic on how table headers allow for sorting. The logic was simplified as it wasn't needed to be so generic for this application.\r\n\r\nMaybe later on I'd consider adding in the \"grid\" view but that may mean we'd have to fracture off older versions of Umbraco which don't support the newer markup.\r\n\r\nFeel free to discuss the Web .cs code layout, I tried to keep things where they were and adhere to coding styles already used :)\r\n\r\nAlso the generic OrderBy function was something I would have liked to have added unit tests around but didn't know where to begin adding them in.","created_at":"2016-06-28T19:19:41Z","updated_at":"2016-06-29T11:57:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d140e1190b5a4cf7fb2a85b7417d350259bebd2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5/commits","review_comments_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5/comments","review_comment_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/issues/5/comments","statuses_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/statuses/779349e6baac045ec275c27f49b79ca5de0e970a","head":{"label":"jamiepollock:develop","ref":"develop","sha":"779349e6baac045ec275c27f49b79ca5de0e970a","user":{"login":"jamiepollock","id":5408006,"avatar_url":"https://avatars.githubusercontent.com/u/5408006?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiepollock","html_url":"https://github.com/jamiepollock","followers_url":"https://api.github.com/users/jamiepollock/followers","following_url":"https://api.github.com/users/jamiepollock/following{/other_user}","gists_url":"https://api.github.com/users/jamiepollock/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiepollock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiepollock/subscriptions","organizations_url":"https://api.github.com/users/jamiepollock/orgs","repos_url":"https://api.github.com/users/jamiepollock/repos","events_url":"https://api.github.com/users/jamiepollock/events{/privacy}","received_events_url":"https://api.github.com/users/jamiepollock/received_events","type":"User","site_admin":false},"repo":{"id":62046566,"name":"umbraco-bulk-user-admin","full_name":"jamiepollock/umbraco-bulk-user-admin","owner":{"login":"jamiepollock","id":5408006,"avatar_url":"https://avatars.githubusercontent.com/u/5408006?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiepollock","html_url":"https://github.com/jamiepollock","followers_url":"https://api.github.com/users/jamiepollock/followers","following_url":"https://api.github.com/users/jamiepollock/following{/other_user}","gists_url":"https://api.github.com/users/jamiepollock/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiepollock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiepollock/subscriptions","organizations_url":"https://api.github.com/users/jamiepollock/orgs","repos_url":"https://api.github.com/users/jamiepollock/repos","events_url":"https://api.github.com/users/jamiepollock/events{/privacy}","received_events_url":"https://api.github.com/users/jamiepollock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamiepollock/umbraco-bulk-user-admin","description":"Bulk User Admin for Umbraco back-office","fork":true,"url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin","forks_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/forks","keys_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/teams","hooks_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/hooks","issue_events_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/issues/events{/number}","events_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/events","assignees_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/assignees{/user}","branches_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/branches{/branch}","tags_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/tags","blobs_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/languages","stargazers_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/stargazers","contributors_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/contributors","subscribers_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/subscribers","subscription_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/subscription","commits_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/contents/{+path}","compare_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/merges","archive_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/downloads","issues_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/issues{/number}","pulls_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/labels{/name}","releases_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/releases{/id}","deployments_url":"https://api.github.com/repos/jamiepollock/umbraco-bulk-user-admin/deployments","created_at":"2016-06-27T10:11:06Z","updated_at":"2016-06-27T10:11:07Z","pushed_at":"2016-06-28T19:15:00Z","git_url":"git://github.com/jamiepollock/umbraco-bulk-user-admin.git","ssh_url":"git@github.com:jamiepollock/umbraco-bulk-user-admin.git","clone_url":"https://github.com/jamiepollock/umbraco-bulk-user-admin.git","svn_url":"https://github.com/jamiepollock/umbraco-bulk-user-admin","homepage":null,"size":1966,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"leekelleher:develop","ref":"develop","sha":"79b64fac1ed1db9a5af95c897db4daa4124d5f82","user":{"login":"leekelleher","id":209066,"avatar_url":"https://avatars.githubusercontent.com/u/209066?v=3","gravatar_id":"","url":"https://api.github.com/users/leekelleher","html_url":"https://github.com/leekelleher","followers_url":"https://api.github.com/users/leekelleher/followers","following_url":"https://api.github.com/users/leekelleher/following{/other_user}","gists_url":"https://api.github.com/users/leekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/leekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leekelleher/subscriptions","organizations_url":"https://api.github.com/users/leekelleher/orgs","repos_url":"https://api.github.com/users/leekelleher/repos","events_url":"https://api.github.com/users/leekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/leekelleher/received_events","type":"User","site_admin":false},"repo":{"id":42182145,"name":"umbraco-bulk-user-admin","full_name":"leekelleher/umbraco-bulk-user-admin","owner":{"login":"leekelleher","id":209066,"avatar_url":"https://avatars.githubusercontent.com/u/209066?v=3","gravatar_id":"","url":"https://api.github.com/users/leekelleher","html_url":"https://github.com/leekelleher","followers_url":"https://api.github.com/users/leekelleher/followers","following_url":"https://api.github.com/users/leekelleher/following{/other_user}","gists_url":"https://api.github.com/users/leekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/leekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leekelleher/subscriptions","organizations_url":"https://api.github.com/users/leekelleher/orgs","repos_url":"https://api.github.com/users/leekelleher/repos","events_url":"https://api.github.com/users/leekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/leekelleher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leekelleher/umbraco-bulk-user-admin","description":"Bulk User Admin for Umbraco back-office","fork":false,"url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin","forks_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/forks","keys_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/teams","hooks_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/hooks","issue_events_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/issues/events{/number}","events_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/events","assignees_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/assignees{/user}","branches_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/branches{/branch}","tags_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/tags","blobs_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/languages","stargazers_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/stargazers","contributors_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/contributors","subscribers_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/subscribers","subscription_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/subscription","commits_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/contents/{+path}","compare_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/merges","archive_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/downloads","issues_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/issues{/number}","pulls_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/labels{/name}","releases_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/releases{/id}","deployments_url":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/deployments","created_at":"2015-09-09T14:05:41Z","updated_at":"2016-06-27T13:53:33Z","pushed_at":"2016-06-28T19:19:41Z","git_url":"git://github.com/leekelleher/umbraco-bulk-user-admin.git","ssh_url":"git@github.com:leekelleher/umbraco-bulk-user-admin.git","clone_url":"https://github.com/leekelleher/umbraco-bulk-user-admin.git","svn_url":"https://github.com/leekelleher/umbraco-bulk-user-admin","homepage":null,"size":1962,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5"},"html":{"href":"https://github.com/leekelleher/umbraco-bulk-user-admin/pull/5"},"issue":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/issues/5"},"comments":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/leekelleher/umbraco-bulk-user-admin/statuses/779349e6baac045ec275c27f49b79ca5de0e970a"}}}}
{"actor":{"display_login":"leekelleher"}}