{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/15042","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/15042/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/15042/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/15042/events","html_url":"https://github.com/dotnet/roslyn/pull/15042","id":187596119,"number":15042,"title":"Export an appropriate service so that serialization works properly in the external process.","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"labels":[{"id":197452922,"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-06T22:52:58Z","updated_at":"2016-11-07T04:22:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/15042","html_url":"https://github.com/dotnet/roslyn/pull/15042","diff_url":"https://github.com/dotnet/roslyn/pull/15042.diff","patch_url":"https://github.com/dotnet/roslyn/pull/15042.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/258744455","html_url":"https://github.com/dotnet/roslyn/pull/15042#issuecomment-258744455","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/15042","id":258744455,"user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T04:22:44Z","updated_at":"2016-11-07T04:22:44Z","body":"Let's discuss this tomorrow.  Right now the concern is that we have a service that we've built many layers on top of that doesn't appear to work properly in completely normal use cases.  This causes excess CPU and memory allocations.  This behavior was not documented and looks to have been added simply to make a dashboard green, despite the problems it could cause higher up the stack.  On top of this, this behavior change was not communicated.  So a core service now breaks, and all the higher up stack layers behave poorly because the conditions that could cause it to break were never communicated.\r\n\r\nPlease inform people in the future if you are going to do things that change things about how the lower layers of hte system work.  People working on the higher levels need to be aware of these changes as it deeply affects the design and implementation of our features.   This is similar to the change that happened that made it so that you couldn't necessary go from an open document to a text snapshot.  This change was not communicated and it caused crashes because a previous invariant that people communicated, and could depend on, was undone.  This is a similar case.  A heuristic that breaks a service *for some set of solutions* without any documentation is extremely bad.   We do not do that in Roslyn and we certainly shouldn't be doing that just so a test can pass.  \r\n\r\n"}}
{"actor":{"display_login":"CyrusNajmabadi"}}