{"action":"created","comment":{"url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/comments/81657200","pull_request_review_id":2621713,"id":81657200,"diff_hunk":"@@ -55,24 +55,23 @@ def start_workers!\n \n     def start_worker!\n       worker = nil\n-        thread_class.new do\n-          worker_id = @workers_mutex.synchronize do\n-            @worker_id += 1\n+      thread_class.new do\n+        worker_id = @workers_mutex.synchronize do\n+          @worker_id += 1\n+        end\n+        worker = Worker.new(:thread_pool => self, :worker_id => worker_id)\n+        worker_created! worker\n+        begin\n+          worker_starting! worker\n+          @workers_mutex.synchronize do\n+            @workers << worker\n           end\n-          worker = Worker.new(:thread_pool => self, :worker_id => worker_id)\n-          worker_created! worker\n-          begin\n-            worker_starting! worker\n-            @workers_mutex.synchronize do\n-              @workers << worker\n-            end\n-            worker.run!\n-          ensure\n-            @workers_mutex.synchronize do\n-              @workers.delete(worker)\n-            end\n-            worker_stopping! worker\n+          worker.run!\n+        ensure\n+          @workers_mutex.synchronize do\n+            @workers.delete(worker)\n           end\n+          worker_stopping! worker\n         end","path":"lib/asir/thread_pool.rb","position":37,"original_position":37,"commit_id":"ca0f81fcacce3fe1d6fc5141d87bfaf83c576025","original_commit_id":"ca0f81fcacce3fe1d6fc5141d87bfaf83c576025","user":{"login":"jiahou","id":5040281,"avatar_url":"https://avatars.githubusercontent.com/u/5040281?v=3","gravatar_id":"","url":"https://api.github.com/users/jiahou","html_url":"https://github.com/jiahou","followers_url":"https://api.github.com/users/jiahou/followers","following_url":"https://api.github.com/users/jiahou/following{/other_user}","gists_url":"https://api.github.com/users/jiahou/gists{/gist_id}","starred_url":"https://api.github.com/users/jiahou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiahou/subscriptions","organizations_url":"https://api.github.com/users/jiahou/orgs","repos_url":"https://api.github.com/users/jiahou/repos","events_url":"https://api.github.com/users/jiahou/events{/privacy}","received_events_url":"https://api.github.com/users/jiahou/received_events","type":"User","site_admin":false},"body":"The mass indentation changes obfuscate the fix. Consider using separate commits next time.\r\n\r\nFix: Looks like there was an extra \"end\" right before this line.","created_at":"2016-10-03T22:53:54Z","updated_at":"2016-10-03T22:53:54Z","html_url":"https://github.com/kstephens/abstracting_services_in_ruby/pull/3#discussion_r81657200","pull_request_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/comments/81657200"},"html":{"href":"https://github.com/kstephens/abstracting_services_in_ruby/pull/3#discussion_r81657200"},"pull_request":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3","id":13616168,"html_url":"https://github.com/kstephens/abstracting_services_in_ruby/pull/3","diff_url":"https://github.com/kstephens/abstracting_services_in_ruby/pull/3.diff","patch_url":"https://github.com/kstephens/abstracting_services_in_ruby/pull/3.patch","issue_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/issues/3","number":3,"state":"open","locked":false,"title":"syntax fix","user":{"login":"mharris717","id":64296,"avatar_url":"https://avatars.githubusercontent.com/u/64296?v=3","gravatar_id":"","url":"https://api.github.com/users/mharris717","html_url":"https://github.com/mharris717","followers_url":"https://api.github.com/users/mharris717/followers","following_url":"https://api.github.com/users/mharris717/following{/other_user}","gists_url":"https://api.github.com/users/mharris717/gists{/gist_id}","starred_url":"https://api.github.com/users/mharris717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mharris717/subscriptions","organizations_url":"https://api.github.com/users/mharris717/orgs","repos_url":"https://api.github.com/users/mharris717/repos","events_url":"https://api.github.com/users/mharris717/events{/privacy}","received_events_url":"https://api.github.com/users/mharris717/received_events","type":"User","site_admin":false},"body":"the start_worker commit introduced a syntax error","created_at":"2014-03-16T21:06:47Z","updated_at":"2016-10-03T22:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc11158efa9022c1aa9d856fa711f24f21cba45f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3/commits","review_comments_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3/comments","review_comment_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/issues/3/comments","statuses_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/statuses/ca0f81fcacce3fe1d6fc5141d87bfaf83c576025","head":{"label":"mharris717:syntax_error_fix","ref":"syntax_error_fix","sha":"ca0f81fcacce3fe1d6fc5141d87bfaf83c576025","user":{"login":"mharris717","id":64296,"avatar_url":"https://avatars.githubusercontent.com/u/64296?v=3","gravatar_id":"","url":"https://api.github.com/users/mharris717","html_url":"https://github.com/mharris717","followers_url":"https://api.github.com/users/mharris717/followers","following_url":"https://api.github.com/users/mharris717/following{/other_user}","gists_url":"https://api.github.com/users/mharris717/gists{/gist_id}","starred_url":"https://api.github.com/users/mharris717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mharris717/subscriptions","organizations_url":"https://api.github.com/users/mharris717/orgs","repos_url":"https://api.github.com/users/mharris717/repos","events_url":"https://api.github.com/users/mharris717/events{/privacy}","received_events_url":"https://api.github.com/users/mharris717/received_events","type":"User","site_admin":false},"repo":{"id":17809075,"name":"abstracting_services_in_ruby","full_name":"mharris717/abstracting_services_in_ruby","owner":{"login":"mharris717","id":64296,"avatar_url":"https://avatars.githubusercontent.com/u/64296?v=3","gravatar_id":"","url":"https://api.github.com/users/mharris717","html_url":"https://github.com/mharris717","followers_url":"https://api.github.com/users/mharris717/followers","following_url":"https://api.github.com/users/mharris717/following{/other_user}","gists_url":"https://api.github.com/users/mharris717/gists{/gist_id}","starred_url":"https://api.github.com/users/mharris717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mharris717/subscriptions","organizations_url":"https://api.github.com/users/mharris717/orgs","repos_url":"https://api.github.com/users/mharris717/repos","events_url":"https://api.github.com/users/mharris717/events{/privacy}","received_events_url":"https://api.github.com/users/mharris717/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mharris717/abstracting_services_in_ruby","description":"Demonstrates abstraction of services in Ruby","fork":true,"url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby","forks_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/forks","keys_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/teams","hooks_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/hooks","issue_events_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/issues/events{/number}","events_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/events","assignees_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/assignees{/user}","branches_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/branches{/branch}","tags_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/tags","blobs_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/languages","stargazers_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/stargazers","contributors_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/contributors","subscribers_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/subscribers","subscription_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/subscription","commits_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/contents/{+path}","compare_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/merges","archive_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/downloads","issues_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/issues{/number}","pulls_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/labels{/name}","releases_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/releases{/id}","deployments_url":"https://api.github.com/repos/mharris717/abstracting_services_in_ruby/deployments","created_at":"2014-03-16T20:57:29Z","updated_at":"2014-03-16T21:06:47Z","pushed_at":"2014-03-16T21:05:42Z","git_url":"git://github.com/mharris717/abstracting_services_in_ruby.git","ssh_url":"git@github.com:mharris717/abstracting_services_in_ruby.git","clone_url":"https://github.com/mharris717/abstracting_services_in_ruby.git","svn_url":"https://github.com/mharris717/abstracting_services_in_ruby","homepage":"http://kurtstephens.com/","size":867,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kstephens:master","ref":"master","sha":"e8b39cd4aa98d0e08cc2687174e40394d02925e9","user":{"login":"kstephens","id":14147,"avatar_url":"https://avatars.githubusercontent.com/u/14147?v=3","gravatar_id":"","url":"https://api.github.com/users/kstephens","html_url":"https://github.com/kstephens","followers_url":"https://api.github.com/users/kstephens/followers","following_url":"https://api.github.com/users/kstephens/following{/other_user}","gists_url":"https://api.github.com/users/kstephens/gists{/gist_id}","starred_url":"https://api.github.com/users/kstephens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kstephens/subscriptions","organizations_url":"https://api.github.com/users/kstephens/orgs","repos_url":"https://api.github.com/users/kstephens/repos","events_url":"https://api.github.com/users/kstephens/events{/privacy}","received_events_url":"https://api.github.com/users/kstephens/received_events","type":"User","site_admin":false},"repo":{"id":850375,"name":"abstracting_services_in_ruby","full_name":"kstephens/abstracting_services_in_ruby","owner":{"login":"kstephens","id":14147,"avatar_url":"https://avatars.githubusercontent.com/u/14147?v=3","gravatar_id":"","url":"https://api.github.com/users/kstephens","html_url":"https://github.com/kstephens","followers_url":"https://api.github.com/users/kstephens/followers","following_url":"https://api.github.com/users/kstephens/following{/other_user}","gists_url":"https://api.github.com/users/kstephens/gists{/gist_id}","starred_url":"https://api.github.com/users/kstephens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kstephens/subscriptions","organizations_url":"https://api.github.com/users/kstephens/orgs","repos_url":"https://api.github.com/users/kstephens/repos","events_url":"https://api.github.com/users/kstephens/events{/privacy}","received_events_url":"https://api.github.com/users/kstephens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kstephens/abstracting_services_in_ruby","description":"Demonstrates abstraction of services in Ruby","fork":false,"url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby","forks_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/forks","keys_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/teams","hooks_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/hooks","issue_events_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/issues/events{/number}","events_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/events","assignees_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/assignees{/user}","branches_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/branches{/branch}","tags_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/tags","blobs_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/languages","stargazers_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/stargazers","contributors_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/contributors","subscribers_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/subscribers","subscription_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/subscription","commits_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/contents/{+path}","compare_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/merges","archive_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/downloads","issues_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/issues{/number}","pulls_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/labels{/name}","releases_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/releases{/id}","deployments_url":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/deployments","created_at":"2010-08-20T02:59:32Z","updated_at":"2013-11-12T04:43:09Z","pushed_at":"2013-10-24T21:03:14Z","git_url":"git://github.com/kstephens/abstracting_services_in_ruby.git","ssh_url":"git@github.com:kstephens/abstracting_services_in_ruby.git","clone_url":"https://github.com/kstephens/abstracting_services_in_ruby.git","svn_url":"https://github.com/kstephens/abstracting_services_in_ruby","homepage":"http://kurtstephens.com/","size":1081,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3"},"html":{"href":"https://github.com/kstephens/abstracting_services_in_ruby/pull/3"},"issue":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/issues/3"},"comments":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/kstephens/abstracting_services_in_ruby/statuses/ca0f81fcacce3fe1d6fc5141d87bfaf83c576025"}}}}
{"actor":{"display_login":"jiahou"}}