{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Deflect/pulls/comments/85930691","pull_request_review_id":6612246,"id":85930691,"diff_hunk":"@@ -178,9 +180,9 @@ void QmlStreamer::Impl::_initRenderer()\n {\n     _updateSizes( QSize( _rootItem->width(), _rootItem->height( )));\n \n-    _quickRenderer = new QuickRenderer( *_quickWindow, *_renderControl,\n-                                        true );\n+    _quickRenderer = new QuickRenderer( *_quickWindow, *_renderControl, true );\n \n+#ifdef DEFLECTQT_MULTITHREADED\n #if QT_VERSION >= 0x050500","path":"deflect/qt/QmlStreamerImpl.cpp","position":20,"original_position":20,"commit_id":"57f6f6010374dff10f978cca3090cbc300e805ab","original_commit_id":"57f6f6010374dff10f978cca3090cbc300e805ab","user":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars.githubusercontent.com/u/5166658?v=3","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"body":"#else here should probably just static_assert(false) instead of printing a warning because it does not work at all","created_at":"2016-11-01T13:47:37Z","updated_at":"2016-11-01T13:50:25Z","html_url":"https://github.com/BlueBrain/Deflect/pull/134#discussion_r85930691","pull_request_url":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Deflect/pulls/comments/85930691"},"html":{"href":"https://github.com/BlueBrain/Deflect/pull/134#discussion_r85930691"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134","id":91781759,"html_url":"https://github.com/BlueBrain/Deflect/pull/134","diff_url":"https://github.com/BlueBrain/Deflect/pull/134.diff","patch_url":"https://github.com/BlueBrain/Deflect/pull/134.patch","issue_url":"https://api.github.com/repos/BlueBrain/Deflect/issues/134","number":134,"state":"open","locked":false,"title":"DeflectQt: Multithreaded rendering is off by default for Qt version < 5.5","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-11-01T13:20:58Z","updated_at":"2016-11-01T13:50:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26375e7c0c9c85ab968abe63f8fab0e996e239c3","assignee":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars.githubusercontent.com/u/5166658?v=3","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"assignees":[{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars.githubusercontent.com/u/5166658?v=3","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Deflect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Deflect/issues/134/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Deflect/statuses/57f6f6010374dff10f978cca3090cbc300e805ab","head":{"label":"tribal-tec:master","ref":"master","sha":"57f6f6010374dff10f978cca3090cbc300e805ab","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"repo":{"id":28908257,"name":"Deflect","full_name":"tribal-tec/Deflect","owner":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tribal-tec/Deflect","description":null,"fork":true,"url":"https://api.github.com/repos/tribal-tec/Deflect","forks_url":"https://api.github.com/repos/tribal-tec/Deflect/forks","keys_url":"https://api.github.com/repos/tribal-tec/Deflect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tribal-tec/Deflect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tribal-tec/Deflect/teams","hooks_url":"https://api.github.com/repos/tribal-tec/Deflect/hooks","issue_events_url":"https://api.github.com/repos/tribal-tec/Deflect/issues/events{/number}","events_url":"https://api.github.com/repos/tribal-tec/Deflect/events","assignees_url":"https://api.github.com/repos/tribal-tec/Deflect/assignees{/user}","branches_url":"https://api.github.com/repos/tribal-tec/Deflect/branches{/branch}","tags_url":"https://api.github.com/repos/tribal-tec/Deflect/tags","blobs_url":"https://api.github.com/repos/tribal-tec/Deflect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tribal-tec/Deflect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tribal-tec/Deflect/git/refs{/sha}","trees_url":"https://api.github.com/repos/tribal-tec/Deflect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tribal-tec/Deflect/statuses/{sha}","languages_url":"https://api.github.com/repos/tribal-tec/Deflect/languages","stargazers_url":"https://api.github.com/repos/tribal-tec/Deflect/stargazers","contributors_url":"https://api.github.com/repos/tribal-tec/Deflect/contributors","subscribers_url":"https://api.github.com/repos/tribal-tec/Deflect/subscribers","subscription_url":"https://api.github.com/repos/tribal-tec/Deflect/subscription","commits_url":"https://api.github.com/repos/tribal-tec/Deflect/commits{/sha}","git_commits_url":"https://api.github.com/repos/tribal-tec/Deflect/git/commits{/sha}","comments_url":"https://api.github.com/repos/tribal-tec/Deflect/comments{/number}","issue_comment_url":"https://api.github.com/repos/tribal-tec/Deflect/issues/comments{/number}","contents_url":"https://api.github.com/repos/tribal-tec/Deflect/contents/{+path}","compare_url":"https://api.github.com/repos/tribal-tec/Deflect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tribal-tec/Deflect/merges","archive_url":"https://api.github.com/repos/tribal-tec/Deflect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tribal-tec/Deflect/downloads","issues_url":"https://api.github.com/repos/tribal-tec/Deflect/issues{/number}","pulls_url":"https://api.github.com/repos/tribal-tec/Deflect/pulls{/number}","milestones_url":"https://api.github.com/repos/tribal-tec/Deflect/milestones{/number}","notifications_url":"https://api.github.com/repos/tribal-tec/Deflect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tribal-tec/Deflect/labels{/name}","releases_url":"https://api.github.com/repos/tribal-tec/Deflect/releases{/id}","deployments_url":"https://api.github.com/repos/tribal-tec/Deflect/deployments","created_at":"2015-01-07T09:40:59Z","updated_at":"2016-01-26T13:10:50Z","pushed_at":"2016-11-01T13:20:51Z","git_url":"git://github.com/tribal-tec/Deflect.git","ssh_url":"git@github.com:tribal-tec/Deflect.git","clone_url":"https://github.com/tribal-tec/Deflect.git","svn_url":"https://github.com/tribal-tec/Deflect","homepage":null,"size":677,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"5a7433cd123ac6633624ef3fb0e538fe44861f63","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":28862537,"name":"Deflect","full_name":"BlueBrain/Deflect","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Deflect","description":"C++ library for building applications to stream pixels to Tide","fork":false,"url":"https://api.github.com/repos/BlueBrain/Deflect","forks_url":"https://api.github.com/repos/BlueBrain/Deflect/forks","keys_url":"https://api.github.com/repos/BlueBrain/Deflect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Deflect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Deflect/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Deflect/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Deflect/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Deflect/events","assignees_url":"https://api.github.com/repos/BlueBrain/Deflect/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Deflect/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Deflect/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Deflect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Deflect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Deflect/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Deflect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Deflect/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Deflect/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Deflect/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Deflect/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Deflect/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Deflect/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Deflect/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Deflect/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Deflect/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Deflect/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Deflect/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Deflect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Deflect/merges","archive_url":"https://api.github.com/repos/BlueBrain/Deflect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Deflect/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Deflect/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Deflect/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Deflect/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Deflect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Deflect/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Deflect/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Deflect/deployments","created_at":"2015-01-06T12:31:50Z","updated_at":"2016-10-31T09:37:52Z","pushed_at":"2016-11-01T13:20:58Z","git_url":"git://github.com/BlueBrain/Deflect.git","ssh_url":"git@github.com:BlueBrain/Deflect.git","clone_url":"https://github.com/BlueBrain/Deflect.git","svn_url":"https://github.com/BlueBrain/Deflect","homepage":"https://bluebrain.github.io","size":657,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134"},"html":{"href":"https://github.com/BlueBrain/Deflect/pull/134"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Deflect/issues/134"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Deflect/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Deflect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Deflect/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Deflect/statuses/57f6f6010374dff10f978cca3090cbc300e805ab"}}}}
{"actor":{"display_login":"rdumusc"}}