{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/91582693","pull_request_review_id":12092699,"id":91582693,"diff_hunk":"@@ -67,6 +67,12 @@ - (void)registerDispatcher:(id<ADDispatcher>)dispatcher\n     @synchronized(self)\n     {\n         SAFE_ARC_RELEASE(_dispatcher);\n+        if (!dispatcher)\n+        {\n+            _dispatcher = nil;\n+            return;\n+        }\n+        ","path":"ADAL/src/telemetry/ADTelemetry.m","position":9,"original_position":9,"commit_id":"3d0c32d66c1fc0a54d65907e0bec84d9e7f6847c","original_commit_id":"3d0c32d66c1fc0a54d65907e0bec84d9e7f6847c","user":{"login":"jasoncoolmax","id":8347347,"avatar_url":"https://avatars.githubusercontent.com/u/8347347?v=3","gravatar_id":"","url":"https://api.github.com/users/jasoncoolmax","html_url":"https://github.com/jasoncoolmax","followers_url":"https://api.github.com/users/jasoncoolmax/followers","following_url":"https://api.github.com/users/jasoncoolmax/following{/other_user}","gists_url":"https://api.github.com/users/jasoncoolmax/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncoolmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncoolmax/subscriptions","organizations_url":"https://api.github.com/users/jasoncoolmax/orgs","repos_url":"https://api.github.com/users/jasoncoolmax/repos","events_url":"https://api.github.com/users/jasoncoolmax/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncoolmax/received_events","type":"User","site_admin":false},"body":"if user passes in nil as dispatcher, we simply set _dispatcher to nil, such that we won't end up collecting a bunch of events and has no where to dispatch and discard them.","created_at":"2016-12-08T19:00:21Z","updated_at":"2016-12-08T19:00:21Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/850#discussion_r91582693","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/91582693"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/850#discussion_r91582693"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850","id":96981022,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/850","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/850.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/850.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/850","number":850,"state":"open","locked":false,"title":"Add Unit test to verify Telemetry Output for acquireToken ","user":{"login":"jasoncoolmax","id":8347347,"avatar_url":"https://avatars.githubusercontent.com/u/8347347?v=3","gravatar_id":"","url":"https://api.github.com/users/jasoncoolmax","html_url":"https://github.com/jasoncoolmax","followers_url":"https://api.github.com/users/jasoncoolmax/followers","following_url":"https://api.github.com/users/jasoncoolmax/following{/other_user}","gists_url":"https://api.github.com/users/jasoncoolmax/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncoolmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncoolmax/subscriptions","organizations_url":"https://api.github.com/users/jasoncoolmax/orgs","repos_url":"https://api.github.com/users/jasoncoolmax/repos","events_url":"https://api.github.com/users/jasoncoolmax/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncoolmax/received_events","type":"User","site_admin":false},"body":"(fixes #832)\r\n\r\n- Unit test is added to verify telemetry output for acquireToken.\r\n- Remove some unnecessary check in unit tests\r\n- ADTelemetry.h is made public","created_at":"2016-12-07T18:32:26Z","updated_at":"2016-12-08T19:00:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c30787f38a88339cf8cd93b2ec2b9e7ab83f435e","assignee":{"login":"RPangrle","id":7004783,"avatar_url":"https://avatars.githubusercontent.com/u/7004783?v=3","gravatar_id":"","url":"https://api.github.com/users/RPangrle","html_url":"https://github.com/RPangrle","followers_url":"https://api.github.com/users/RPangrle/followers","following_url":"https://api.github.com/users/RPangrle/following{/other_user}","gists_url":"https://api.github.com/users/RPangrle/gists{/gist_id}","starred_url":"https://api.github.com/users/RPangrle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPangrle/subscriptions","organizations_url":"https://api.github.com/users/RPangrle/orgs","repos_url":"https://api.github.com/users/RPangrle/repos","events_url":"https://api.github.com/users/RPangrle/events{/privacy}","received_events_url":"https://api.github.com/users/RPangrle/received_events","type":"User","site_admin":false},"assignees":[{"login":"RPangrle","id":7004783,"avatar_url":"https://avatars.githubusercontent.com/u/7004783?v=3","gravatar_id":"","url":"https://api.github.com/users/RPangrle","html_url":"https://github.com/RPangrle","followers_url":"https://api.github.com/users/RPangrle/followers","following_url":"https://api.github.com/users/RPangrle/following{/other_user}","gists_url":"https://api.github.com/users/RPangrle/gists{/gist_id}","starred_url":"https://api.github.com/users/RPangrle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPangrle/subscriptions","organizations_url":"https://api.github.com/users/RPangrle/orgs","repos_url":"https://api.github.com/users/RPangrle/repos","events_url":"https://api.github.com/users/RPangrle/events{/privacy}","received_events_url":"https://api.github.com/users/RPangrle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/850/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/3d0c32d66c1fc0a54d65907e0bec84d9e7f6847c","head":{"label":"AzureAD:jason/832","ref":"jason/832","sha":"3d0c32d66c1fc0a54d65907e0bec84d9e7f6847c","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703038,"name":"azure-activedirectory-library-for-objc","full_name":"AzureAD/azure-activedirectory-library-for-objc","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/deployments","created_at":"2013-11-26T00:46:00Z","updated_at":"2016-12-04T12:23:44Z","pushed_at":"2016-12-08T18:50:16Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","homepage":"","size":20314,"stargazers_count":98,"watchers_count":98,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":36,"forks":66,"open_issues":36,"watchers":98,"default_branch":"dev"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"60d2e668659f78dc7ee3b24cd219933bf6621230","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703038,"name":"azure-activedirectory-library-for-objc","full_name":"AzureAD/azure-activedirectory-library-for-objc","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/deployments","created_at":"2013-11-26T00:46:00Z","updated_at":"2016-12-04T12:23:44Z","pushed_at":"2016-12-08T18:50:16Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","homepage":"","size":20314,"stargazers_count":98,"watchers_count":98,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":36,"forks":66,"open_issues":36,"watchers":98,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/850"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/850"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/3d0c32d66c1fc0a54d65907e0bec84d9e7f6847c"}}}}
{"actor":{"display_login":"jasoncoolmax"}}