{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/1432","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/1432/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/1432/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/1432/events","html_url":"https://github.com/Homebrew/brew/pull/1432","id":187101263,"number":1432,"title":"metafiles: warn about missing metafiles ","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-03T15:48:12Z","updated_at":"2016-11-13T16:55:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/1432","html_url":"https://github.com/Homebrew/brew/pull/1432","diff_url":"https://github.com/Homebrew/brew/pull/1432.diff","patch_url":"https://github.com/Homebrew/brew/pull/1432.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [x] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nHave a PR instead of idle rambling in https://github.com/Homebrew/homebrew-core/pull/6544. Not that you have to accept it these days 😉. Explanation is obvious enough, really.\r\n\r\nSome impacted formulae, although they aren't flagged in your standard `brew audit` currently because of the `@strict` block:\r\n```\r\nack:\r\n  * Metafiles such as README, LICENSE or COPYING do not seem\r\n    to have been installed. Please ensure this is correct\r\n    otherwise you may need to add `prefix.install_metafiles`\r\n    to the formula.\r\nboost:\r\n  * Metafiles such as README, LICENSE or COPYING do not seem\r\n    to have been installed. Please ensure this is correct\r\n    otherwise you may need to add `prefix.install_metafiles`\r\n    to the formula.\r\nboost-python:\r\n  * Metafiles such as README, LICENSE or COPYING do not seem\r\n    to have been installed. Please ensure this is correct\r\n    otherwise you may need to add `prefix.install_metafiles`\r\n    to the formula.\r\nbsdmake:\r\n  * Metafiles such as README, LICENSE or COPYING do not seem\r\n    to have been installed. Please ensure this is correct\r\n    otherwise you may need to add `prefix.install_metafiles`\r\n    to the formula.\r\n```\r\n\r\n`boost` and `boost-python` are actually flagging an issue with the `metafiles` code itself, because the license there is `LICENSE_1_0.txt` which the `metafiles` code currently ignores."},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/260197846","html_url":"https://github.com/Homebrew/brew/pull/1432#issuecomment-260197846","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/1432","id":260197846,"user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"created_at":"2016-11-13T16:55:46Z","updated_at":"2016-11-13T16:55:46Z","body":"To be honest, I forgot I'd opened this around all the election stuff. I'll try to think about it a bit more. \r\n\r\nThe metafiles stuff has proven difficult to get \"right\" over time; Alex modified it for the better a while back but doing so exposed other issues. That makes me quite wary about fiddling with the logic itself directly, but I'm also sympathetic to the argument Homebrew doesn't necessarily want `prefix.install_metafiles` to become a manual fix all over the place.\r\n\r\nTheoretically you could try to be clever if the `buildpath` doesn't contain any metafiles the installation process goes hunting for them in subdirectories, but I'm not sure that doesn't spawn other issues, such as:\r\n\r\nFormula x\r\n```\r\n- buildpath\r\n  - configure\r\n  - Makefile.in\r\n  - docs\r\n    - Building\r\n    - README\r\n    - LICENSE\r\n    - Changelog\r\n```\r\nInstalls `README` & `LICENSE` correctly.\r\n\r\nFormula y\r\n```\r\n- buildpath\r\n  - src/github.com/ducks/pond\r\n    - README\r\n  - src/github.com/horses/horse\r\n    - README\r\n    - COPYING\r\n  - src/github.com/test/test2\r\n    - README\r\n    - LICENSE\r\n    - vendor\r\n      - golang.org/x/net\r\n        - README\r\n        - LICENSE\r\n```\r\nWhere `src/github.com/test/test2` contains the Go formula we're building, but instead the `README` from `src/github.com/ducks/pond` gets installed. It's not an especially common scenario, but there are formula that use both Go vendoring and Go resources because the resources cover a build tool upstream don't need to vendor permanently, etc.\r\n\r\nDue to the way it operates the metafiles logic needs to more-or-less work for everything, to an extent, and I'm not immediately sure how to draw up an automated solution that doesn't risk working even less well than the current logic."}}
{"actor":{"display_login":"DomT4"}}