{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/79066734","id":79066734,"diff_hunk":"@@ -0,0 +1,131 @@\n+//===--- GenStruct.cpp - Swift IR Generation For 'struct' Types -----------===//\n+//\n+// This source file is part of the Swift.org open source project\n+//\n+// Copyright (c) 2014 - 2016 Apple Inc. and the Swift project authors\n+// Licensed under Apache License v2.0 with Runtime Library Exception\n+//\n+// See http://swift.org/LICENSE.txt for license information\n+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors\n+//\n+//===----------------------------------------------------------------------===//\n+//\n+//  This file implements IR generation for constant values.\n+//\n+//===----------------------------------------------------------------------===//\n+\n+#include \"llvm/IR/Function.h\"\n+#include \"llvm/IR/Module.h\"\n+#include \"llvm/IR/Instructions.h\"\n+#include \"llvm/IR/IntrinsicInst.h\"\n+#include \"llvm/IR/InlineAsm.h\"\n+#include \"llvm/IR/Intrinsics.h\"\n+#include \"llvm/ADT/MapVector.h\"\n+#include \"llvm/ADT/SmallBitVector.h\"\n+#include \"llvm/ADT/TinyPtrVector.h\"\n+\n+#include \"llvm/IR/Constant.h\"\n+#include \"IRGenModule.h\"\n+#include \"GenStruct.h\"\n+#include \"TypeInfo.h\"\n+\n+using namespace swift;\n+using namespace irgen;\n+\n+/// Construct a ConstantInt from an IntegerLiteralInst.\n+llvm::Constant *IRGenModule::emitConstantInt(swift::IntegerLiteralInst *ILI) {","path":"lib/IRGen/GenConstant.cpp","position":36,"original_position":36,"commit_id":"2f378f26f2856306544558845d2bddb6d6dd09a2","original_commit_id":"5aa6d8bc6b0d10dae9146cf37e900a09cc40abe3","user":{"login":"rjmccall","id":793869,"avatar_url":"https://avatars.githubusercontent.com/u/793869?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmccall","html_url":"https://github.com/rjmccall","followers_url":"https://api.github.com/users/rjmccall/followers","following_url":"https://api.github.com/users/rjmccall/following{/other_user}","gists_url":"https://api.github.com/users/rjmccall/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmccall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmccall/subscriptions","organizations_url":"https://api.github.com/users/rjmccall/orgs","repos_url":"https://api.github.com/users/rjmccall/repos","events_url":"https://api.github.com/users/rjmccall/events{/privacy}","received_events_url":"https://api.github.com/users/rjmccall/received_events","type":"User","site_admin":false},"body":"These don't really need to be exposed as interface on IRGenModule.\r\n\r\nAnd you shouldn't need a swift:: qualifier here.","created_at":"2016-09-15T21:32:08Z","updated_at":"2016-09-15T21:39:15Z","html_url":"https://github.com/apple/swift/pull/4814#discussion_r79066734","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/4814","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/79066734"},"html":{"href":"https://github.com/apple/swift/pull/4814#discussion_r79066734"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/4814"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/4814","id":85481180,"html_url":"https://github.com/apple/swift/pull/4814","diff_url":"https://github.com/apple/swift/pull/4814.diff","patch_url":"https://github.com/apple/swift/pull/4814.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/4814","number":4814,"state":"open","locked":false,"title":"SR 716: handle constant structs with padding","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nHandle padding in global structs. \r\n\r\nPreviously there was a mismatch between SIL's concept of a\r\nstruct (padding is implicit) and LLVM's (padding is explicit) in IRGen's\r\nconstant evaluator. The explicit padding fields need to be given a value\r\nin the IR.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nResolves [SR-716](https://bugs.swift.org/browse/SR-716).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->","created_at":"2016-09-15T21:11:07Z","updated_at":"2016-09-15T21:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6d4e5af9206e0ebc3d7ab96e2bf0e9a32fea670","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/4814/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/4814/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/4814/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/2f378f26f2856306544558845d2bddb6d6dd09a2","head":{"label":"huonw:sr-716-constant-struct-with-padding","ref":"sr-716-constant-struct-with-padding","sha":"2f378f26f2856306544558845d2bddb6d6dd09a2","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"repo":{"id":67061123,"name":"swift","full_name":"huonw/swift","owner":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huonw/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/huonw/swift","forks_url":"https://api.github.com/repos/huonw/swift/forks","keys_url":"https://api.github.com/repos/huonw/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huonw/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huonw/swift/teams","hooks_url":"https://api.github.com/repos/huonw/swift/hooks","issue_events_url":"https://api.github.com/repos/huonw/swift/issues/events{/number}","events_url":"https://api.github.com/repos/huonw/swift/events","assignees_url":"https://api.github.com/repos/huonw/swift/assignees{/user}","branches_url":"https://api.github.com/repos/huonw/swift/branches{/branch}","tags_url":"https://api.github.com/repos/huonw/swift/tags","blobs_url":"https://api.github.com/repos/huonw/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huonw/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huonw/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/huonw/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huonw/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/huonw/swift/languages","stargazers_url":"https://api.github.com/repos/huonw/swift/stargazers","contributors_url":"https://api.github.com/repos/huonw/swift/contributors","subscribers_url":"https://api.github.com/repos/huonw/swift/subscribers","subscription_url":"https://api.github.com/repos/huonw/swift/subscription","commits_url":"https://api.github.com/repos/huonw/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/huonw/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/huonw/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/huonw/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/huonw/swift/contents/{+path}","compare_url":"https://api.github.com/repos/huonw/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huonw/swift/merges","archive_url":"https://api.github.com/repos/huonw/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huonw/swift/downloads","issues_url":"https://api.github.com/repos/huonw/swift/issues{/number}","pulls_url":"https://api.github.com/repos/huonw/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/huonw/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/huonw/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huonw/swift/labels{/name}","releases_url":"https://api.github.com/repos/huonw/swift/releases{/id}","deployments_url":"https://api.github.com/repos/huonw/swift/deployments","created_at":"2016-08-31T18:00:30Z","updated_at":"2016-08-31T18:00:55Z","pushed_at":"2016-09-15T21:33:38Z","git_url":"git://github.com/huonw/swift.git","ssh_url":"git@github.com:huonw/swift.git","clone_url":"https://github.com/huonw/swift.git","svn_url":"https://github.com/huonw/swift","homepage":"https://swift.org/","size":118356,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"208e82f66f5b5b46b4c717f13354f3b14f8ab4f6","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-09-15T20:48:18Z","pushed_at":"2016-09-15T21:35:56Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":183558,"stargazers_count":33901,"watchers_count":33901,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4794,"mirror_url":null,"open_issues_count":94,"forks":4794,"open_issues":94,"watchers":33901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/4814"},"html":{"href":"https://github.com/apple/swift/pull/4814"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/4814"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/4814/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/4814/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/4814/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/2f378f26f2856306544558845d2bddb6d6dd09a2"}}}}
{"actor":{"display_login":"rjmccall"}}