{"action":"created","comment":{"url":"https://api.github.com/repos/apache/falcon/pulls/comments/69884069","id":69884069,"diff_hunk":"@@ -1160,6 +1160,24 @@ public void testImportFeedSqoopInvalid() throws Exception {\n         Assert.fail(\"ValidationException should have been thrown\");\n     }\n \n+    @Test (expectedExceptions = {ValidationException.class, FalconException.class})\n+    public void testImportFeedWithNoTimePartition() throws Exception {\n+\n+        InputStream feedStream = this.getClass()\n+                .getResourceAsStream(\"/config/feed/feed-import-no-timepartition-0.1.xml\");\n+        parser.parseAndValidate(feedStream);\n+        Assert.fail(\"ValidationException should have been thrown\");\n+    }\n+\n+    @Test (expectedExceptions = {ValidationException.class, FalconException.class})","path":"common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java","position":13,"original_position":13,"commit_id":"193e9cc5f6c811b70e9b8c6d9fb7e407a8cea3f4","original_commit_id":"193e9cc5f6c811b70e9b8c6d9fb7e407a8cea3f4","user":{"login":"ajayyadava","id":373156,"avatar_url":"https://avatars.githubusercontent.com/u/373156?v=3","gravatar_id":"","url":"https://api.github.com/users/ajayyadava","html_url":"https://github.com/ajayyadava","followers_url":"https://api.github.com/users/ajayyadava/followers","following_url":"https://api.github.com/users/ajayyadava/following{/other_user}","gists_url":"https://api.github.com/users/ajayyadava/gists{/gist_id}","starred_url":"https://api.github.com/users/ajayyadava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajayyadava/subscriptions","organizations_url":"https://api.github.com/users/ajayyadava/orgs","repos_url":"https://api.github.com/users/ajayyadava/repos","events_url":"https://api.github.com/users/ajayyadava/events{/privacy}","received_events_url":"https://api.github.com/users/ajayyadava/received_events","type":"User","site_admin":false},"body":"Shouldn't this be just ValidationException.class. Using two exceptions make the test a bit indeterministic and may pass in other cases as well.","created_at":"2016-07-07T10:25:01Z","updated_at":"2016-07-07T10:25:01Z","html_url":"https://github.com/apache/falcon/pull/214#discussion_r69884069","pull_request_url":"https://api.github.com/repos/apache/falcon/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments/69884069"},"html":{"href":"https://github.com/apache/falcon/pull/214#discussion_r69884069"},"pull_request":{"href":"https://api.github.com/repos/apache/falcon/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/apache/falcon/pulls/214","id":76524537,"html_url":"https://github.com/apache/falcon/pull/214","diff_url":"https://github.com/apache/falcon/pull/214.diff","patch_url":"https://github.com/apache/falcon/pull/214.patch","issue_url":"https://api.github.com/repos/apache/falcon/issues/214","number":214,"state":"open","locked":false,"title":"FALCON-2030 : Enfornce time partition in the storage path for feeds w…","user":{"login":"vramachan","id":11688485,"avatar_url":"https://avatars.githubusercontent.com/u/11688485?v=3","gravatar_id":"","url":"https://api.github.com/users/vramachan","html_url":"https://github.com/vramachan","followers_url":"https://api.github.com/users/vramachan/followers","following_url":"https://api.github.com/users/vramachan/following{/other_user}","gists_url":"https://api.github.com/users/vramachan/gists{/gist_id}","starred_url":"https://api.github.com/users/vramachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramachan/subscriptions","organizations_url":"https://api.github.com/users/vramachan/orgs","repos_url":"https://api.github.com/users/vramachan/repos","events_url":"https://api.github.com/users/vramachan/events{/privacy}","received_events_url":"https://api.github.com/users/vramachan/received_events","type":"User","site_admin":false},"body":"Enforce time partition in the storage path for feeds with import and export policy.\r\nHCAT storage types, this restriction is already handled.","created_at":"2016-07-07T00:48:19Z","updated_at":"2016-07-07T10:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5511bd8d9a3945b3bfc366a17c7efe381d0a5241","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/falcon/pulls/214/commits","review_comments_url":"https://api.github.com/repos/apache/falcon/pulls/214/comments","review_comment_url":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/falcon/issues/214/comments","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/193e9cc5f6c811b70e9b8c6d9fb7e407a8cea3f4","head":{"label":"vramachan:FALCON-2030.EnforceTimePartition","ref":"FALCON-2030.EnforceTimePartition","sha":"193e9cc5f6c811b70e9b8c6d9fb7e407a8cea3f4","user":{"login":"vramachan","id":11688485,"avatar_url":"https://avatars.githubusercontent.com/u/11688485?v=3","gravatar_id":"","url":"https://api.github.com/users/vramachan","html_url":"https://github.com/vramachan","followers_url":"https://api.github.com/users/vramachan/followers","following_url":"https://api.github.com/users/vramachan/following{/other_user}","gists_url":"https://api.github.com/users/vramachan/gists{/gist_id}","starred_url":"https://api.github.com/users/vramachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramachan/subscriptions","organizations_url":"https://api.github.com/users/vramachan/orgs","repos_url":"https://api.github.com/users/vramachan/repos","events_url":"https://api.github.com/users/vramachan/events{/privacy}","received_events_url":"https://api.github.com/users/vramachan/received_events","type":"User","site_admin":false},"repo":{"id":56727821,"name":"falcon","full_name":"vramachan/falcon","owner":{"login":"vramachan","id":11688485,"avatar_url":"https://avatars.githubusercontent.com/u/11688485?v=3","gravatar_id":"","url":"https://api.github.com/users/vramachan","html_url":"https://github.com/vramachan","followers_url":"https://api.github.com/users/vramachan/followers","following_url":"https://api.github.com/users/vramachan/following{/other_user}","gists_url":"https://api.github.com/users/vramachan/gists{/gist_id}","starred_url":"https://api.github.com/users/vramachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramachan/subscriptions","organizations_url":"https://api.github.com/users/vramachan/orgs","repos_url":"https://api.github.com/users/vramachan/repos","events_url":"https://api.github.com/users/vramachan/events{/privacy}","received_events_url":"https://api.github.com/users/vramachan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vramachan/falcon","description":"Mirror of Apache Falcon","fork":true,"url":"https://api.github.com/repos/vramachan/falcon","forks_url":"https://api.github.com/repos/vramachan/falcon/forks","keys_url":"https://api.github.com/repos/vramachan/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vramachan/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vramachan/falcon/teams","hooks_url":"https://api.github.com/repos/vramachan/falcon/hooks","issue_events_url":"https://api.github.com/repos/vramachan/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/vramachan/falcon/events","assignees_url":"https://api.github.com/repos/vramachan/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/vramachan/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/vramachan/falcon/tags","blobs_url":"https://api.github.com/repos/vramachan/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vramachan/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vramachan/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/vramachan/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vramachan/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/vramachan/falcon/languages","stargazers_url":"https://api.github.com/repos/vramachan/falcon/stargazers","contributors_url":"https://api.github.com/repos/vramachan/falcon/contributors","subscribers_url":"https://api.github.com/repos/vramachan/falcon/subscribers","subscription_url":"https://api.github.com/repos/vramachan/falcon/subscription","commits_url":"https://api.github.com/repos/vramachan/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/vramachan/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/vramachan/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/vramachan/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/vramachan/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/vramachan/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vramachan/falcon/merges","archive_url":"https://api.github.com/repos/vramachan/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vramachan/falcon/downloads","issues_url":"https://api.github.com/repos/vramachan/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/vramachan/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/vramachan/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/vramachan/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vramachan/falcon/labels{/name}","releases_url":"https://api.github.com/repos/vramachan/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/vramachan/falcon/deployments","created_at":"2016-04-20T23:37:25Z","updated_at":"2016-04-20T23:37:29Z","pushed_at":"2016-07-07T00:46:49Z","git_url":"git://github.com/vramachan/falcon.git","ssh_url":"git@github.com:vramachan/falcon.git","clone_url":"https://github.com/vramachan/falcon.git","svn_url":"https://github.com/vramachan/falcon","homepage":null,"size":30453,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b2526d8f4b8043ed0e1c005b89533683815e2373","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":11543457,"name":"falcon","full_name":"apache/falcon","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/falcon","description":"Mirror of Apache Falcon","fork":false,"url":"https://api.github.com/repos/apache/falcon","forks_url":"https://api.github.com/repos/apache/falcon/forks","keys_url":"https://api.github.com/repos/apache/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/falcon/teams","hooks_url":"https://api.github.com/repos/apache/falcon/hooks","issue_events_url":"https://api.github.com/repos/apache/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/apache/falcon/events","assignees_url":"https://api.github.com/repos/apache/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/apache/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/apache/falcon/tags","blobs_url":"https://api.github.com/repos/apache/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/falcon/languages","stargazers_url":"https://api.github.com/repos/apache/falcon/stargazers","contributors_url":"https://api.github.com/repos/apache/falcon/contributors","subscribers_url":"https://api.github.com/repos/apache/falcon/subscribers","subscription_url":"https://api.github.com/repos/apache/falcon/subscription","commits_url":"https://api.github.com/repos/apache/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/apache/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/falcon/merges","archive_url":"https://api.github.com/repos/apache/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/falcon/downloads","issues_url":"https://api.github.com/repos/apache/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/apache/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/falcon/labels{/name}","releases_url":"https://api.github.com/repos/apache/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/apache/falcon/deployments","created_at":"2013-07-20T07:00:14Z","updated_at":"2016-07-07T05:53:57Z","pushed_at":"2016-07-07T09:41:14Z","git_url":"git://github.com/apache/falcon.git","ssh_url":"git@github.com:apache/falcon.git","clone_url":"https://github.com/apache/falcon.git","svn_url":"https://github.com/apache/falcon","homepage":null,"size":32415,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":"git://git.apache.org/falcon.git","open_issues_count":22,"forks":79,"open_issues":22,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/214"},"html":{"href":"https://github.com/apache/falcon/pull/214"},"issue":{"href":"https://api.github.com/repos/apache/falcon/issues/214"},"comments":{"href":"https://api.github.com/repos/apache/falcon/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/falcon/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/falcon/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/apache/falcon/statuses/193e9cc5f6c811b70e9b8c6d9fb7e407a8cea3f4"}}}}
{"actor":{"display_login":"ajayyadava"}}