{"action":"closed","issue":{"url":"https://api.github.com/repos/SamDecrock/node-http-ntlm/issues/29","repository_url":"https://api.github.com/repos/SamDecrock/node-http-ntlm","labels_url":"https://api.github.com/repos/SamDecrock/node-http-ntlm/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/SamDecrock/node-http-ntlm/issues/29/comments","events_url":"https://api.github.com/repos/SamDecrock/node-http-ntlm/issues/29/events","html_url":"https://github.com/SamDecrock/node-http-ntlm/issues/29","id":104144537,"number":29,"title":"No error check while sending type1 message to server.","user":{"login":"meteormanaged","id":10685349,"avatar_url":"https://avatars.githubusercontent.com/u/10685349?v=3","gravatar_id":"","url":"https://api.github.com/users/meteormanaged","html_url":"https://github.com/meteormanaged","followers_url":"https://api.github.com/users/meteormanaged/followers","following_url":"https://api.github.com/users/meteormanaged/following{/other_user}","gists_url":"https://api.github.com/users/meteormanaged/gists{/gist_id}","starred_url":"https://api.github.com/users/meteormanaged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteormanaged/subscriptions","organizations_url":"https://api.github.com/users/meteormanaged/orgs","repos_url":"https://api.github.com/users/meteormanaged/repos","events_url":"https://api.github.com/users/meteormanaged/events{/privacy}","received_events_url":"https://api.github.com/users/meteormanaged/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-08-31T22:12:20Z","updated_at":"2016-11-18T15:52:03Z","closed_at":"2016-11-18T15:52:03Z","body":"httpntlm.js - line 50\n\n```\nhttpreq.get(options.url, type1options, $);\n```\n\nThe above appears to make the assumption of a certain type of response but will not bark under certain conditions or responses such as:\n\n```\n[Error: DEPTH_ZERO_SELF_SIGNED_CERT]\n```\n\nThis would be the default response generated attempting to connect to a server with a self signed certificate (which could very well be expected in a dev environment).  \n\nConnecting to a server with a self signed certificate and replacing the above code with the following will show you the error:\n\n```\nhttpreq.get(options.url, type1options, function(err, res){\n            if(err) console.dir(err);\n        });\n```\n\nNot sure how you're passing errors or know enough aboust async to pull, methinks. I'll try playing with it. \n"}}
{"actor":{"display_login":"SamDecrock"}}