{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/core-setup/issues/429","repository_url":"https://api.github.com/repos/dotnet/core-setup","labels_url":"https://api.github.com/repos/dotnet/core-setup/issues/429/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/429/comments","events_url":"https://api.github.com/repos/dotnet/core-setup/issues/429/events","html_url":"https://github.com/dotnet/core-setup/pull/429","id":181544062,"number":429,"title":"[Port to rel/1.1.0] Removing ToLower workarounds in DependencyModel Resolution.","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/core-setup/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-06T22:44:40Z","updated_at":"2016-10-07T00:02:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/429","html_url":"https://github.com/dotnet/core-setup/pull/429","diff_url":"https://github.com/dotnet/core-setup/pull/429.diff","patch_url":"https://github.com/dotnet/core-setup/pull/429.patch"},"body":"Porting change to rel/1.1.0.\r\n\r\nThese workarounds are no longer valid.  The Resolution logic should be respecting Path and HashPath properties, and falling back to straight PackageId Version values, if those are not set.\r\n\r\nFix #423\r\n\r\n/cc @gkhanna79 @joelverhagen "},"comment":{"url":"https://api.github.com/repos/dotnet/core-setup/issues/comments/252121549","html_url":"https://github.com/dotnet/core-setup/pull/429#issuecomment-252121549","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/429","id":252121549,"user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T00:02:59Z","updated_at":"2016-10-07T00:02:59Z","body":"> What about https://github.com/dotnet/core-setup/blob/master/test/Microsoft.Extensions.DependencyModel.Tests/DependencyContextBuilderTests.cs#L181 ?\r\n\r\nThis test is at the wrong level.  It is depending on the CLI's ProjectModel and DependencyContextBuilder - types that are not in this repo and soon to be removed with the move to MSBuild.  It is wrong for dotnet/core-setup to depend on types from dotnet/cli.  This was an accident because of the following dependency graph:  \r\n\r\n```\r\ndotnet-test-xunit => Microsoft.Extension.Testing.Abstractions => ProjectModel\r\n```\r\n\r\nTo answer this specific instance, these tests are still depending on the 1.0.0-preview2 versions of ProjectModel and DependencyContextBuilder, which don't have the changes for Path and HashPath."}}
{"actor":{"display_login":"eerhardt"}}