{"action":"created","issue":{"url":"https://api.github.com/repos/troessner/reek/issues/899","repository_url":"https://api.github.com/repos/troessner/reek","labels_url":"https://api.github.com/repos/troessner/reek/issues/899/labels{/name}","comments_url":"https://api.github.com/repos/troessner/reek/issues/899/comments","events_url":"https://api.github.com/repos/troessner/reek/issues/899/events","html_url":"https://github.com/troessner/reek/pull/899","id":143449681,"number":899,"title":"Fix excluded paths for custom config formats","user":{"login":"thepry","id":1745708,"avatar_url":"https://avatars.githubusercontent.com/u/1745708?v=3","gravatar_id":"","url":"https://api.github.com/users/thepry","html_url":"https://github.com/thepry","followers_url":"https://api.github.com/users/thepry/followers","following_url":"https://api.github.com/users/thepry/following{/other_user}","gists_url":"https://api.github.com/users/thepry/gists{/gist_id}","starred_url":"https://api.github.com/users/thepry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepry/subscriptions","organizations_url":"https://api.github.com/users/thepry/orgs","repos_url":"https://api.github.com/users/thepry/repos","events_url":"https://api.github.com/users/thepry/events{/privacy}","received_events_url":"https://api.github.com/users/thepry/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/troessner/reek/labels/defect","name":"defect","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-03-25T08:01:10Z","updated_at":"2016-04-10T18:55:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/troessner/reek/pulls/899","html_url":"https://github.com/troessner/reek/pull/899","diff_url":"https://github.com/troessner/reek/pull/899.diff","patch_url":"https://github.com/troessner/reek/pull/899.patch"},"body":"In current master, configuration is never passed to source locator, so it uses default value:\r\n```ruby\r\n# /lib/reek/source/source_locator.rb\r\n  def initialize(paths, configuration: Configuration::AppConfiguration.default)\r\n```\r\n\r\n`Configuration::AppConfiguration.default` finds `*.reek` files in you app directory and uses them. Which causes problems in the following case:\r\nIf your configuration file isn't located in project root, or uses different format, like `config.reek.yml`, `exclude_paths` option would not work. But if you have `*.reek` file in your app root, reek will use `exclude_paths` from there, not from specified configuration file.\r\n\r\nIn my fix configuration is passed from `Application` down to ` Source::SourceLocator`"},"comment":{"url":"https://api.github.com/repos/troessner/reek/issues/comments/208044295","html_url":"https://github.com/troessner/reek/pull/899#issuecomment-208044295","issue_url":"https://api.github.com/repos/troessner/reek/issues/899","id":208044295,"user":{"login":"troessner","id":271109,"avatar_url":"https://avatars.githubusercontent.com/u/271109?v=3","gravatar_id":"","url":"https://api.github.com/users/troessner","html_url":"https://github.com/troessner","followers_url":"https://api.github.com/users/troessner/followers","following_url":"https://api.github.com/users/troessner/following{/other_user}","gists_url":"https://api.github.com/users/troessner/gists{/gist_id}","starred_url":"https://api.github.com/users/troessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troessner/subscriptions","organizations_url":"https://api.github.com/users/troessner/orgs","repos_url":"https://api.github.com/users/troessner/repos","events_url":"https://api.github.com/users/troessner/events{/privacy}","received_events_url":"https://api.github.com/users/troessner/received_events","type":"User","site_admin":false},"created_at":"2016-04-10T18:55:22Z","updated_at":"2016-04-10T18:55:22Z","body":"Merging this one since #900 is in master.\r\nGreat job, thanks!"}}