{"action":"created","comment":{"url":"https://api.github.com/repos/google/cadvisor/pulls/comments/68292007","id":68292007,"diff_hunk":"@@ -150,8 +150,8 @@ func (w *ThinPoolWatcher) Refresh() error {\n }\n \n const (\n-\tthinPoolDmsetupStatusTokens           = 11\n \tthinPoolDmsetupStatusHeldMetadataRoot = 6\n+\tthinPoolDmsetupStatusMinTokens        = thinPoolDmsetupStatusHeldMetadataRoot + 1","path":"devicemapper/thin_pool_watcher.go","position":6,"original_position":6,"commit_id":"8faba9efbd4dcd245225157a10cf2b8bcf565c56","original_commit_id":"8faba9efbd4dcd245225157a10cf2b8bcf565c56","user":{"login":"sjenning","id":493891,"avatar_url":"https://avatars.githubusercontent.com/u/493891?v=3","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},"body":"nit: s/Tokens/Fields/ since we changed it below","created_at":"2016-06-23T18:43:35Z","updated_at":"2016-06-23T18:43:35Z","html_url":"https://github.com/google/cadvisor/pull/1348#discussion_r68292007","pull_request_url":"https://api.github.com/repos/google/cadvisor/pulls/1348","_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments/68292007"},"html":{"href":"https://github.com/google/cadvisor/pull/1348#discussion_r68292007"},"pull_request":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1348"}}},"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/1348","id":74975188,"html_url":"https://github.com/google/cadvisor/pull/1348","diff_url":"https://github.com/google/cadvisor/pull/1348.diff","patch_url":"https://github.com/google/cadvisor/pull/1348.patch","issue_url":"https://api.github.com/repos/google/cadvisor/issues/1348","number":1348,"state":"open","locked":false,"title":"Fix detection of devmapper metadata reservation","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"Because new versions of devicemapper may add additional fields to the output of 'dmsetup status',\r\nchange the check to use SplitN to get the minimum fields required, and ignore any additional fields\r\nafter the one we care about.\r\n\r\nRef https://github.com/kubernetes/kubernetes/issues/27955\r\n\r\n@derekwaynecarr @sjenning @pmorie ","created_at":"2016-06-23T15:26:41Z","updated_at":"2016-06-23T18:43:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"757de1021a116cddabf062a39cc52dd978986f39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/cadvisor/pulls/1348/commits","review_comments_url":"https://api.github.com/repos/google/cadvisor/pulls/1348/comments","review_comment_url":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/1348/comments","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/8faba9efbd4dcd245225157a10cf2b8bcf565c56","head":{"label":"ncdc:fix-dmsetup-status-parsing-for-thin-ls","ref":"fix-dmsetup-status-parsing-for-thin-ls","sha":"8faba9efbd4dcd245225157a10cf2b8bcf565c56","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"repo":{"id":50130837,"name":"cadvisor","full_name":"ncdc/cadvisor","owner":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncdc/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":true,"url":"https://api.github.com/repos/ncdc/cadvisor","forks_url":"https://api.github.com/repos/ncdc/cadvisor/forks","keys_url":"https://api.github.com/repos/ncdc/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncdc/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncdc/cadvisor/teams","hooks_url":"https://api.github.com/repos/ncdc/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/ncdc/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/ncdc/cadvisor/events","assignees_url":"https://api.github.com/repos/ncdc/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/ncdc/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/ncdc/cadvisor/tags","blobs_url":"https://api.github.com/repos/ncdc/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncdc/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncdc/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncdc/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncdc/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/ncdc/cadvisor/languages","stargazers_url":"https://api.github.com/repos/ncdc/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/ncdc/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/ncdc/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/ncdc/cadvisor/subscription","commits_url":"https://api.github.com/repos/ncdc/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncdc/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncdc/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncdc/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncdc/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/ncdc/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncdc/cadvisor/merges","archive_url":"https://api.github.com/repos/ncdc/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncdc/cadvisor/downloads","issues_url":"https://api.github.com/repos/ncdc/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/ncdc/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/ncdc/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/ncdc/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncdc/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/ncdc/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/ncdc/cadvisor/deployments","created_at":"2016-01-21T19:20:52Z","updated_at":"2016-01-21T19:20:53Z","pushed_at":"2016-06-23T17:22:54Z","git_url":"git://github.com/ncdc/cadvisor.git","ssh_url":"git@github.com:ncdc/cadvisor.git","clone_url":"https://github.com/ncdc/cadvisor.git","svn_url":"https://github.com/ncdc/cadvisor","homepage":"","size":22262,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"6351fbfc84d488f062224505b4005ab41f5038da","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20653934,"name":"cadvisor","full_name":"google/cadvisor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":false,"url":"https://api.github.com/repos/google/cadvisor","forks_url":"https://api.github.com/repos/google/cadvisor/forks","keys_url":"https://api.github.com/repos/google/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cadvisor/teams","hooks_url":"https://api.github.com/repos/google/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/google/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/cadvisor/events","assignees_url":"https://api.github.com/repos/google/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/cadvisor/tags","blobs_url":"https://api.github.com/repos/google/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cadvisor/languages","stargazers_url":"https://api.github.com/repos/google/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/google/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/google/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/google/cadvisor/subscription","commits_url":"https://api.github.com/repos/google/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cadvisor/merges","archive_url":"https://api.github.com/repos/google/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cadvisor/downloads","issues_url":"https://api.github.com/repos/google/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/google/cadvisor/deployments","created_at":"2014-06-09T16:36:33Z","updated_at":"2016-06-23T16:34:41Z","pushed_at":"2016-06-23T17:22:54Z","git_url":"git://github.com/google/cadvisor.git","ssh_url":"git@github.com:google/cadvisor.git","clone_url":"https://github.com/google/cadvisor.git","svn_url":"https://github.com/google/cadvisor","homepage":"","size":30361,"stargazers_count":4076,"watchers_count":4076,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":571,"mirror_url":null,"open_issues_count":196,"forks":571,"open_issues":196,"watchers":4076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1348"},"html":{"href":"https://github.com/google/cadvisor/pull/1348"},"issue":{"href":"https://api.github.com/repos/google/cadvisor/issues/1348"},"comments":{"href":"https://api.github.com/repos/google/cadvisor/issues/1348/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1348/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1348/commits"},"statuses":{"href":"https://api.github.com/repos/google/cadvisor/statuses/8faba9efbd4dcd245225157a10cf2b8bcf565c56"}}}}
{"actor":{"display_login":"sjenning"}}