{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/48968429","id":48968429,"diff_hunk":"@@ -168,8 +196,13 @@ void Jit64::psq_lXX(UGeckoInstruction inst)\n \tint w = indexed ? inst.Wx : inst.W;\n \tFALLBACK_IF(!a);\n \n+\tstd::map<u8, u32>::iterator it = js.constantGqr.find(i);\n+\tbool gqrIsConstant = it != js.constantGqr.end();\n+\tu32 gqrConstant = it->second >> 16;","path":"Source/Core/Core/PowerPC/Jit64/Jit_LoadStorePaired.cpp","position":84,"original_position":84,"commit_id":"0d57bdf78702a1f53a5b7b39e23ddeb48f44730f","original_commit_id":"0d57bdf78702a1f53a5b7b39e23ddeb48f44730f","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"same,\r\nu32 gqrConstant = gqrIsConstant ? it->second & 0xffff : 0;","created_at":"2016-01-06T15:28:42Z","updated_at":"2016-01-06T15:28:42Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3454#discussion_r48968429","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/48968429"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3454#discussion_r48968429"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454","id":55175429,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3454","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3454.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3454.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3454","number":3454,"state":"open","locked":false,"title":"JIT perf improvements for quantized loads/stores","user":{"login":"mmastrac","id":512240,"avatar_url":"https://avatars.githubusercontent.com/u/512240?v=3","gravatar_id":"","url":"https://api.github.com/users/mmastrac","html_url":"https://github.com/mmastrac","followers_url":"https://api.github.com/users/mmastrac/followers","following_url":"https://api.github.com/users/mmastrac/following{/other_user}","gists_url":"https://api.github.com/users/mmastrac/gists{/gist_id}","starred_url":"https://api.github.com/users/mmastrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmastrac/subscriptions","organizations_url":"https://api.github.com/users/mmastrac/orgs","repos_url":"https://api.github.com/users/mmastrac/repos","events_url":"https://api.github.com/users/mmastrac/events{/privacy}","received_events_url":"https://api.github.com/users/mmastrac/received_events","type":"User","site_admin":false},"body":"This is a first step to address some low-hanging fruit in the quantized paired-single load/stores. It allows for blocks with multiple GQRs to use the fast path, as well as inlining the code for quantized loads when we know the value of the GQR.","created_at":"2016-01-06T04:13:50Z","updated_at":"2016-01-06T15:28:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aef2eb22004bb9214bb8a31abcfd606def5dc022","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3454/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/0d57bdf78702a1f53a5b7b39e23ddeb48f44730f","head":{"label":"mmastrac:gqr_fixes","ref":"gqr_fixes","sha":"0d57bdf78702a1f53a5b7b39e23ddeb48f44730f","user":{"login":"mmastrac","id":512240,"avatar_url":"https://avatars.githubusercontent.com/u/512240?v=3","gravatar_id":"","url":"https://api.github.com/users/mmastrac","html_url":"https://github.com/mmastrac","followers_url":"https://api.github.com/users/mmastrac/followers","following_url":"https://api.github.com/users/mmastrac/following{/other_user}","gists_url":"https://api.github.com/users/mmastrac/gists{/gist_id}","starred_url":"https://api.github.com/users/mmastrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmastrac/subscriptions","organizations_url":"https://api.github.com/users/mmastrac/orgs","repos_url":"https://api.github.com/users/mmastrac/repos","events_url":"https://api.github.com/users/mmastrac/events{/privacy}","received_events_url":"https://api.github.com/users/mmastrac/received_events","type":"User","site_admin":false},"repo":{"id":49040741,"name":"dolphin","full_name":"mmastrac/dolphin","owner":{"login":"mmastrac","id":512240,"avatar_url":"https://avatars.githubusercontent.com/u/512240?v=3","gravatar_id":"","url":"https://api.github.com/users/mmastrac","html_url":"https://github.com/mmastrac","followers_url":"https://api.github.com/users/mmastrac/followers","following_url":"https://api.github.com/users/mmastrac/following{/other_user}","gists_url":"https://api.github.com/users/mmastrac/gists{/gist_id}","starred_url":"https://api.github.com/users/mmastrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmastrac/subscriptions","organizations_url":"https://api.github.com/users/mmastrac/orgs","repos_url":"https://api.github.com/users/mmastrac/repos","events_url":"https://api.github.com/users/mmastrac/events{/privacy}","received_events_url":"https://api.github.com/users/mmastrac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmastrac/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/mmastrac/dolphin","forks_url":"https://api.github.com/repos/mmastrac/dolphin/forks","keys_url":"https://api.github.com/repos/mmastrac/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmastrac/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmastrac/dolphin/teams","hooks_url":"https://api.github.com/repos/mmastrac/dolphin/hooks","issue_events_url":"https://api.github.com/repos/mmastrac/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/mmastrac/dolphin/events","assignees_url":"https://api.github.com/repos/mmastrac/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/mmastrac/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/mmastrac/dolphin/tags","blobs_url":"https://api.github.com/repos/mmastrac/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmastrac/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmastrac/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmastrac/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmastrac/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/mmastrac/dolphin/languages","stargazers_url":"https://api.github.com/repos/mmastrac/dolphin/stargazers","contributors_url":"https://api.github.com/repos/mmastrac/dolphin/contributors","subscribers_url":"https://api.github.com/repos/mmastrac/dolphin/subscribers","subscription_url":"https://api.github.com/repos/mmastrac/dolphin/subscription","commits_url":"https://api.github.com/repos/mmastrac/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmastrac/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmastrac/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmastrac/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmastrac/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/mmastrac/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmastrac/dolphin/merges","archive_url":"https://api.github.com/repos/mmastrac/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmastrac/dolphin/downloads","issues_url":"https://api.github.com/repos/mmastrac/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/mmastrac/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/mmastrac/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/mmastrac/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmastrac/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/mmastrac/dolphin/releases{/id}","created_at":"2016-01-05T03:55:24Z","updated_at":"2016-01-05T03:55:46Z","pushed_at":"2016-01-06T06:50:00Z","git_url":"git://github.com/mmastrac/dolphin.git","ssh_url":"git@github.com:mmastrac/dolphin.git","clone_url":"https://github.com/mmastrac/dolphin.git","svn_url":"https://github.com/mmastrac/dolphin","homepage":"https://dolphin-emu.org/","size":228817,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"7c2c73a5fd38de40e7176a4f14a504856b45b635","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-01-06T11:36:18Z","pushed_at":"2016-01-06T15:08:34Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":252080,"stargazers_count":1921,"watchers_count":1921,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":82,"forks":588,"open_issues":82,"watchers":1921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3454"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3454"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3454/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3454/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/0d57bdf78702a1f53a5b7b39e23ddeb48f44730f"}}}}