{"action":"closed","number":81,"pull_request":{"url":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/81","id":94632342,"html_url":"https://github.com/gfontenot/vim-xcode/pull/81","diff_url":"https://github.com/gfontenot/vim-xcode/pull/81.diff","patch_url":"https://github.com/gfontenot/vim-xcode/pull/81.patch","issue_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues/81","number":81,"state":"closed","locked":false,"title":"Improve project detection","user":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"body":"Previously, we were only using the projects/workspaces in the root of\nthe project repo to determine if we could run our Xcode commands. This\nmade sense for the most part but also meant that if you explicitly\ndeclared a path to an Xcode project/workspace and it _wasn't_ in the\nroot, we wouldn't let you run these commands. This made working with\nnon-standard project layouts (like those in React Native projects)\ndifficult to work with.\n\nTo fix this, we can refactor our project/workspace detection to take\nthe explicit file paths into account. If you're explicitly defining a\nproject path and it doesn't exist, I feel like that's your fault and you\ndeserve what you get.","created_at":"2016-11-21T15:07:32Z","updated_at":"2016-11-21T15:12:33Z","closed_at":"2016-11-21T15:12:33Z","merged_at":"2016-11-21T15:12:33Z","merge_commit_sha":"d3ec9c1080767b2e5b9af0c5df227c83db5f523d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/81/commits","review_comments_url":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/81/comments","review_comment_url":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues/81/comments","statuses_url":"https://api.github.com/repos/gfontenot/vim-xcode/statuses/d3ec9c1080767b2e5b9af0c5df227c83db5f523d","head":{"label":"gfontenot:gf-smarter-xcode-detection","ref":"gf-smarter-xcode-detection","sha":"d3ec9c1080767b2e5b9af0c5df227c83db5f523d","user":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"repo":{"id":42274637,"name":"vim-xcode","full_name":"gfontenot/vim-xcode","owner":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfontenot/vim-xcode","description":"Work with Xcode projects from within Vim","fork":false,"url":"https://api.github.com/repos/gfontenot/vim-xcode","forks_url":"https://api.github.com/repos/gfontenot/vim-xcode/forks","keys_url":"https://api.github.com/repos/gfontenot/vim-xcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfontenot/vim-xcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfontenot/vim-xcode/teams","hooks_url":"https://api.github.com/repos/gfontenot/vim-xcode/hooks","issue_events_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues/events{/number}","events_url":"https://api.github.com/repos/gfontenot/vim-xcode/events","assignees_url":"https://api.github.com/repos/gfontenot/vim-xcode/assignees{/user}","branches_url":"https://api.github.com/repos/gfontenot/vim-xcode/branches{/branch}","tags_url":"https://api.github.com/repos/gfontenot/vim-xcode/tags","blobs_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfontenot/vim-xcode/statuses/{sha}","languages_url":"https://api.github.com/repos/gfontenot/vim-xcode/languages","stargazers_url":"https://api.github.com/repos/gfontenot/vim-xcode/stargazers","contributors_url":"https://api.github.com/repos/gfontenot/vim-xcode/contributors","subscribers_url":"https://api.github.com/repos/gfontenot/vim-xcode/subscribers","subscription_url":"https://api.github.com/repos/gfontenot/vim-xcode/subscription","commits_url":"https://api.github.com/repos/gfontenot/vim-xcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfontenot/vim-xcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfontenot/vim-xcode/contents/{+path}","compare_url":"https://api.github.com/repos/gfontenot/vim-xcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfontenot/vim-xcode/merges","archive_url":"https://api.github.com/repos/gfontenot/vim-xcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfontenot/vim-xcode/downloads","issues_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues{/number}","pulls_url":"https://api.github.com/repos/gfontenot/vim-xcode/pulls{/number}","milestones_url":"https://api.github.com/repos/gfontenot/vim-xcode/milestones{/number}","notifications_url":"https://api.github.com/repos/gfontenot/vim-xcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfontenot/vim-xcode/labels{/name}","releases_url":"https://api.github.com/repos/gfontenot/vim-xcode/releases{/id}","deployments_url":"https://api.github.com/repos/gfontenot/vim-xcode/deployments","created_at":"2015-09-10T22:44:26Z","updated_at":"2016-09-06T19:02:19Z","pushed_at":"2016-11-21T15:12:33Z","git_url":"git://github.com/gfontenot/vim-xcode.git","ssh_url":"git@github.com:gfontenot/vim-xcode.git","clone_url":"https://github.com/gfontenot/vim-xcode.git","svn_url":"https://github.com/gfontenot/vim-xcode","homepage":"","size":117,"stargazers_count":47,"watchers_count":47,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":47,"default_branch":"master"}},"base":{"label":"gfontenot:master","ref":"master","sha":"16c81007e99fc4dad0dd55edd50126b23ae80fba","user":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"repo":{"id":42274637,"name":"vim-xcode","full_name":"gfontenot/vim-xcode","owner":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfontenot/vim-xcode","description":"Work with Xcode projects from within Vim","fork":false,"url":"https://api.github.com/repos/gfontenot/vim-xcode","forks_url":"https://api.github.com/repos/gfontenot/vim-xcode/forks","keys_url":"https://api.github.com/repos/gfontenot/vim-xcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfontenot/vim-xcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfontenot/vim-xcode/teams","hooks_url":"https://api.github.com/repos/gfontenot/vim-xcode/hooks","issue_events_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues/events{/number}","events_url":"https://api.github.com/repos/gfontenot/vim-xcode/events","assignees_url":"https://api.github.com/repos/gfontenot/vim-xcode/assignees{/user}","branches_url":"https://api.github.com/repos/gfontenot/vim-xcode/branches{/branch}","tags_url":"https://api.github.com/repos/gfontenot/vim-xcode/tags","blobs_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfontenot/vim-xcode/statuses/{sha}","languages_url":"https://api.github.com/repos/gfontenot/vim-xcode/languages","stargazers_url":"https://api.github.com/repos/gfontenot/vim-xcode/stargazers","contributors_url":"https://api.github.com/repos/gfontenot/vim-xcode/contributors","subscribers_url":"https://api.github.com/repos/gfontenot/vim-xcode/subscribers","subscription_url":"https://api.github.com/repos/gfontenot/vim-xcode/subscription","commits_url":"https://api.github.com/repos/gfontenot/vim-xcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfontenot/vim-xcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfontenot/vim-xcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfontenot/vim-xcode/contents/{+path}","compare_url":"https://api.github.com/repos/gfontenot/vim-xcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfontenot/vim-xcode/merges","archive_url":"https://api.github.com/repos/gfontenot/vim-xcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfontenot/vim-xcode/downloads","issues_url":"https://api.github.com/repos/gfontenot/vim-xcode/issues{/number}","pulls_url":"https://api.github.com/repos/gfontenot/vim-xcode/pulls{/number}","milestones_url":"https://api.github.com/repos/gfontenot/vim-xcode/milestones{/number}","notifications_url":"https://api.github.com/repos/gfontenot/vim-xcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfontenot/vim-xcode/labels{/name}","releases_url":"https://api.github.com/repos/gfontenot/vim-xcode/releases{/id}","deployments_url":"https://api.github.com/repos/gfontenot/vim-xcode/deployments","created_at":"2015-09-10T22:44:26Z","updated_at":"2016-09-06T19:02:19Z","pushed_at":"2016-11-21T15:12:33Z","git_url":"git://github.com/gfontenot/vim-xcode.git","ssh_url":"git@github.com:gfontenot/vim-xcode.git","clone_url":"https://github.com/gfontenot/vim-xcode.git","svn_url":"https://github.com/gfontenot/vim-xcode","homepage":"","size":117,"stargazers_count":47,"watchers_count":47,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/81"},"html":{"href":"https://github.com/gfontenot/vim-xcode/pull/81"},"issue":{"href":"https://api.github.com/repos/gfontenot/vim-xcode/issues/81"},"comments":{"href":"https://api.github.com/repos/gfontenot/vim-xcode/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gfontenot/vim-xcode/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/gfontenot/vim-xcode/statuses/d3ec9c1080767b2e5b9af0c5df227c83db5f523d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"gfontenot"}}