{"action":"created","comment":{"url":"https://api.github.com/repos/soltius/chef-base/pulls/comments/82096922","pull_request_review_id":3028116,"id":82096922,"diff_hunk":"@@ -4,67 +4,36 @@\n #\n # Copyright (c) 2016 Soltius New Zealand Ltd, All Rights Reserved.\n \n-#\n-# Linux-specific Examples\n-#\n-RSpec.shared_examples 'default_linux' do\n-  it 'includes recipe chef-base::docker' do\n-    expect(chef_run).to include_recipe('chef-base::docker')\n-  end\n-\n-  it 'includes recipe mlocate::default' do\n-    expect(chef_run).to include_recipe('mlocate::default')\n-  end\n-\n-  it 'includes recipe vim::default' do\n-    expect(chef_run).to include_recipe('vim::default')\n-  end\n-end\n-\n-#\n-# Windows-specific Examples\n-#\n-RSpec.shared_examples 'default_windows' do\n-  before do\n-    allow_any_instance_of(Chef::Recipe).to receive(:include_recipe).and_call_original\n-    allow_any_instance_of(Chef::Recipe).to receive(:include_recipe).with('chocolatey::default')\n-  end\n+describe 'chef-base::default' do\n+  context 'on all Platforms' do\n+    let(:chef_run) { ChefSpec::SoloRunner.new(PLATFORMS.first).converge(described_recipe) }","path":"test/unit/recipes/default_spec.rb","position":31,"original_position":31,"commit_id":"d51ad0c24ed9fe7fa930d83279e58ac0d18ac8a0","original_commit_id":"d51ad0c24ed9fe7fa930d83279e58ac0d18ac8a0","user":{"login":"igorlg","id":278827,"avatar_url":"https://avatars.githubusercontent.com/u/278827?v=3","gravatar_id":"","url":"https://api.github.com/users/igorlg","html_url":"https://github.com/igorlg","followers_url":"https://api.github.com/users/igorlg/followers","following_url":"https://api.github.com/users/igorlg/following{/other_user}","gists_url":"https://api.github.com/users/igorlg/gists{/gist_id}","starred_url":"https://api.github.com/users/igorlg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorlg/subscriptions","organizations_url":"https://api.github.com/users/igorlg/orgs","repos_url":"https://api.github.com/users/igorlg/repos","events_url":"https://api.github.com/users/igorlg/events{/privacy}","received_events_url":"https://api.github.com/users/igorlg/received_events","type":"User","site_admin":false},"body":"@shinitiandrei you're right... I removed the loop to test and forgot to add it back. Thanks a lot!","created_at":"2016-10-06T00:10:46Z","updated_at":"2016-10-06T00:10:46Z","html_url":"https://github.com/soltius/chef-base/pull/19#discussion_r82096922","pull_request_url":"https://api.github.com/repos/soltius/chef-base/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/soltius/chef-base/pulls/comments/82096922"},"html":{"href":"https://github.com/soltius/chef-base/pull/19#discussion_r82096922"},"pull_request":{"href":"https://api.github.com/repos/soltius/chef-base/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/soltius/chef-base/pulls/19","id":88162046,"html_url":"https://github.com/soltius/chef-base/pull/19","diff_url":"https://github.com/soltius/chef-base/pull/19.diff","patch_url":"https://github.com/soltius/chef-base/pull/19.patch","issue_url":"https://api.github.com/repos/soltius/chef-base/issues/19","number":19,"state":"open","locked":false,"title":"AUT-29 refactor recipe structure","user":{"login":"igorlg","id":278827,"avatar_url":"https://avatars.githubusercontent.com/u/278827?v=3","gravatar_id":"","url":"https://api.github.com/users/igorlg","html_url":"https://github.com/igorlg","followers_url":"https://api.github.com/users/igorlg/followers","following_url":"https://api.github.com/users/igorlg/following{/other_user}","gists_url":"https://api.github.com/users/igorlg/gists{/gist_id}","starred_url":"https://api.github.com/users/igorlg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorlg/subscriptions","organizations_url":"https://api.github.com/users/igorlg/orgs","repos_url":"https://api.github.com/users/igorlg/repos","events_url":"https://api.github.com/users/igorlg/events{/privacy}","received_events_url":"https://api.github.com/users/igorlg/received_events","type":"User","site_admin":false},"body":"Refactored Recipes and Unit Tests, added Platform helper.","created_at":"2016-10-05T21:36:51Z","updated_at":"2016-10-06T00:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"375784092267fc9f4acfd2c17aec44a6cb25284a","assignee":{"login":"shinitiandrei","id":6587581,"avatar_url":"https://avatars.githubusercontent.com/u/6587581?v=3","gravatar_id":"","url":"https://api.github.com/users/shinitiandrei","html_url":"https://github.com/shinitiandrei","followers_url":"https://api.github.com/users/shinitiandrei/followers","following_url":"https://api.github.com/users/shinitiandrei/following{/other_user}","gists_url":"https://api.github.com/users/shinitiandrei/gists{/gist_id}","starred_url":"https://api.github.com/users/shinitiandrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinitiandrei/subscriptions","organizations_url":"https://api.github.com/users/shinitiandrei/orgs","repos_url":"https://api.github.com/users/shinitiandrei/repos","events_url":"https://api.github.com/users/shinitiandrei/events{/privacy}","received_events_url":"https://api.github.com/users/shinitiandrei/received_events","type":"User","site_admin":false},"assignees":[{"login":"shinitiandrei","id":6587581,"avatar_url":"https://avatars.githubusercontent.com/u/6587581?v=3","gravatar_id":"","url":"https://api.github.com/users/shinitiandrei","html_url":"https://github.com/shinitiandrei","followers_url":"https://api.github.com/users/shinitiandrei/followers","following_url":"https://api.github.com/users/shinitiandrei/following{/other_user}","gists_url":"https://api.github.com/users/shinitiandrei/gists{/gist_id}","starred_url":"https://api.github.com/users/shinitiandrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinitiandrei/subscriptions","organizations_url":"https://api.github.com/users/shinitiandrei/orgs","repos_url":"https://api.github.com/users/shinitiandrei/repos","events_url":"https://api.github.com/users/shinitiandrei/events{/privacy}","received_events_url":"https://api.github.com/users/shinitiandrei/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/soltius/chef-base/pulls/19/commits","review_comments_url":"https://api.github.com/repos/soltius/chef-base/pulls/19/comments","review_comment_url":"https://api.github.com/repos/soltius/chef-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/soltius/chef-base/issues/19/comments","statuses_url":"https://api.github.com/repos/soltius/chef-base/statuses/d51ad0c24ed9fe7fa930d83279e58ac0d18ac8a0","head":{"label":"soltius:AUT-29-refactor-recipe-structure","ref":"AUT-29-refactor-recipe-structure","sha":"d51ad0c24ed9fe7fa930d83279e58ac0d18ac8a0","user":{"login":"soltius","id":16785665,"avatar_url":"https://avatars.githubusercontent.com/u/16785665?v=3","gravatar_id":"","url":"https://api.github.com/users/soltius","html_url":"https://github.com/soltius","followers_url":"https://api.github.com/users/soltius/followers","following_url":"https://api.github.com/users/soltius/following{/other_user}","gists_url":"https://api.github.com/users/soltius/gists{/gist_id}","starred_url":"https://api.github.com/users/soltius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltius/subscriptions","organizations_url":"https://api.github.com/users/soltius/orgs","repos_url":"https://api.github.com/users/soltius/repos","events_url":"https://api.github.com/users/soltius/events{/privacy}","received_events_url":"https://api.github.com/users/soltius/received_events","type":"Organization","site_admin":false},"repo":{"id":67184786,"name":"chef-base","full_name":"soltius/chef-base","owner":{"login":"soltius","id":16785665,"avatar_url":"https://avatars.githubusercontent.com/u/16785665?v=3","gravatar_id":"","url":"https://api.github.com/users/soltius","html_url":"https://github.com/soltius","followers_url":"https://api.github.com/users/soltius/followers","following_url":"https://api.github.com/users/soltius/following{/other_user}","gists_url":"https://api.github.com/users/soltius/gists{/gist_id}","starred_url":"https://api.github.com/users/soltius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltius/subscriptions","organizations_url":"https://api.github.com/users/soltius/orgs","repos_url":"https://api.github.com/users/soltius/repos","events_url":"https://api.github.com/users/soltius/events{/privacy}","received_events_url":"https://api.github.com/users/soltius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soltius/chef-base","description":"Performs \"foundation\" tasks on managed hosts","fork":false,"url":"https://api.github.com/repos/soltius/chef-base","forks_url":"https://api.github.com/repos/soltius/chef-base/forks","keys_url":"https://api.github.com/repos/soltius/chef-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltius/chef-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltius/chef-base/teams","hooks_url":"https://api.github.com/repos/soltius/chef-base/hooks","issue_events_url":"https://api.github.com/repos/soltius/chef-base/issues/events{/number}","events_url":"https://api.github.com/repos/soltius/chef-base/events","assignees_url":"https://api.github.com/repos/soltius/chef-base/assignees{/user}","branches_url":"https://api.github.com/repos/soltius/chef-base/branches{/branch}","tags_url":"https://api.github.com/repos/soltius/chef-base/tags","blobs_url":"https://api.github.com/repos/soltius/chef-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltius/chef-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltius/chef-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltius/chef-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltius/chef-base/statuses/{sha}","languages_url":"https://api.github.com/repos/soltius/chef-base/languages","stargazers_url":"https://api.github.com/repos/soltius/chef-base/stargazers","contributors_url":"https://api.github.com/repos/soltius/chef-base/contributors","subscribers_url":"https://api.github.com/repos/soltius/chef-base/subscribers","subscription_url":"https://api.github.com/repos/soltius/chef-base/subscription","commits_url":"https://api.github.com/repos/soltius/chef-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltius/chef-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltius/chef-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltius/chef-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltius/chef-base/contents/{+path}","compare_url":"https://api.github.com/repos/soltius/chef-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltius/chef-base/merges","archive_url":"https://api.github.com/repos/soltius/chef-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltius/chef-base/downloads","issues_url":"https://api.github.com/repos/soltius/chef-base/issues{/number}","pulls_url":"https://api.github.com/repos/soltius/chef-base/pulls{/number}","milestones_url":"https://api.github.com/repos/soltius/chef-base/milestones{/number}","notifications_url":"https://api.github.com/repos/soltius/chef-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltius/chef-base/labels{/name}","releases_url":"https://api.github.com/repos/soltius/chef-base/releases{/id}","deployments_url":"https://api.github.com/repos/soltius/chef-base/deployments","created_at":"2016-09-02T02:56:34Z","updated_at":"2016-09-07T11:14:43Z","pushed_at":"2016-10-05T21:55:18Z","git_url":"git://github.com/soltius/chef-base.git","ssh_url":"git@github.com:soltius/chef-base.git","clone_url":"https://github.com/soltius/chef-base.git","svn_url":"https://github.com/soltius/chef-base","homepage":null,"size":145,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"soltius:master","ref":"master","sha":"12facb3d6ce4ed30956304d4aa0e284f0071d265","user":{"login":"soltius","id":16785665,"avatar_url":"https://avatars.githubusercontent.com/u/16785665?v=3","gravatar_id":"","url":"https://api.github.com/users/soltius","html_url":"https://github.com/soltius","followers_url":"https://api.github.com/users/soltius/followers","following_url":"https://api.github.com/users/soltius/following{/other_user}","gists_url":"https://api.github.com/users/soltius/gists{/gist_id}","starred_url":"https://api.github.com/users/soltius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltius/subscriptions","organizations_url":"https://api.github.com/users/soltius/orgs","repos_url":"https://api.github.com/users/soltius/repos","events_url":"https://api.github.com/users/soltius/events{/privacy}","received_events_url":"https://api.github.com/users/soltius/received_events","type":"Organization","site_admin":false},"repo":{"id":67184786,"name":"chef-base","full_name":"soltius/chef-base","owner":{"login":"soltius","id":16785665,"avatar_url":"https://avatars.githubusercontent.com/u/16785665?v=3","gravatar_id":"","url":"https://api.github.com/users/soltius","html_url":"https://github.com/soltius","followers_url":"https://api.github.com/users/soltius/followers","following_url":"https://api.github.com/users/soltius/following{/other_user}","gists_url":"https://api.github.com/users/soltius/gists{/gist_id}","starred_url":"https://api.github.com/users/soltius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltius/subscriptions","organizations_url":"https://api.github.com/users/soltius/orgs","repos_url":"https://api.github.com/users/soltius/repos","events_url":"https://api.github.com/users/soltius/events{/privacy}","received_events_url":"https://api.github.com/users/soltius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soltius/chef-base","description":"Performs \"foundation\" tasks on managed hosts","fork":false,"url":"https://api.github.com/repos/soltius/chef-base","forks_url":"https://api.github.com/repos/soltius/chef-base/forks","keys_url":"https://api.github.com/repos/soltius/chef-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltius/chef-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltius/chef-base/teams","hooks_url":"https://api.github.com/repos/soltius/chef-base/hooks","issue_events_url":"https://api.github.com/repos/soltius/chef-base/issues/events{/number}","events_url":"https://api.github.com/repos/soltius/chef-base/events","assignees_url":"https://api.github.com/repos/soltius/chef-base/assignees{/user}","branches_url":"https://api.github.com/repos/soltius/chef-base/branches{/branch}","tags_url":"https://api.github.com/repos/soltius/chef-base/tags","blobs_url":"https://api.github.com/repos/soltius/chef-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltius/chef-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltius/chef-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltius/chef-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltius/chef-base/statuses/{sha}","languages_url":"https://api.github.com/repos/soltius/chef-base/languages","stargazers_url":"https://api.github.com/repos/soltius/chef-base/stargazers","contributors_url":"https://api.github.com/repos/soltius/chef-base/contributors","subscribers_url":"https://api.github.com/repos/soltius/chef-base/subscribers","subscription_url":"https://api.github.com/repos/soltius/chef-base/subscription","commits_url":"https://api.github.com/repos/soltius/chef-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltius/chef-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltius/chef-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltius/chef-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltius/chef-base/contents/{+path}","compare_url":"https://api.github.com/repos/soltius/chef-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltius/chef-base/merges","archive_url":"https://api.github.com/repos/soltius/chef-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltius/chef-base/downloads","issues_url":"https://api.github.com/repos/soltius/chef-base/issues{/number}","pulls_url":"https://api.github.com/repos/soltius/chef-base/pulls{/number}","milestones_url":"https://api.github.com/repos/soltius/chef-base/milestones{/number}","notifications_url":"https://api.github.com/repos/soltius/chef-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltius/chef-base/labels{/name}","releases_url":"https://api.github.com/repos/soltius/chef-base/releases{/id}","deployments_url":"https://api.github.com/repos/soltius/chef-base/deployments","created_at":"2016-09-02T02:56:34Z","updated_at":"2016-09-07T11:14:43Z","pushed_at":"2016-10-05T21:55:18Z","git_url":"git://github.com/soltius/chef-base.git","ssh_url":"git@github.com:soltius/chef-base.git","clone_url":"https://github.com/soltius/chef-base.git","svn_url":"https://github.com/soltius/chef-base","homepage":null,"size":145,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/soltius/chef-base/pulls/19"},"html":{"href":"https://github.com/soltius/chef-base/pull/19"},"issue":{"href":"https://api.github.com/repos/soltius/chef-base/issues/19"},"comments":{"href":"https://api.github.com/repos/soltius/chef-base/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/soltius/chef-base/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/soltius/chef-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/soltius/chef-base/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/soltius/chef-base/statuses/d51ad0c24ed9fe7fa930d83279e58ac0d18ac8a0"}}}}
{"actor":{"display_login":"igorlg"}}