{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-server/issues/1574","repository_url":"https://api.github.com/repos/mozilla/addons-server","labels_url":"https://api.github.com/repos/mozilla/addons-server/issues/1574/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/1574/comments","events_url":"https://api.github.com/repos/mozilla/addons-server/issues/1574/events","html_url":"https://github.com/mozilla/addons-server/issues/1574","id":130601763,"number":1574,"title":"Unify ugettext, ugettext_lazy and variants usage","user":{"login":"EnTeQuAk","id":139033,"avatar_url":"https://avatars.githubusercontent.com/u/139033?v=3","gravatar_id":"","url":"https://api.github.com/users/EnTeQuAk","html_url":"https://github.com/EnTeQuAk","followers_url":"https://api.github.com/users/EnTeQuAk/followers","following_url":"https://api.github.com/users/EnTeQuAk/following{/other_user}","gists_url":"https://api.github.com/users/EnTeQuAk/gists{/gist_id}","starred_url":"https://api.github.com/users/EnTeQuAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnTeQuAk/subscriptions","organizations_url":"https://api.github.com/users/EnTeQuAk/orgs","repos_url":"https://api.github.com/users/EnTeQuAk/repos","events_url":"https://api.github.com/users/EnTeQuAk/events{/privacy}","received_events_url":"https://api.github.com/users/EnTeQuAk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/addons-server/labels/code%20quality","name":"code quality","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-02T07:37:08Z","updated_at":"2016-02-23T16:26:00Z","closed_at":null,"body":"Unify `ugettext`, `ugettext_lazy` and variants usage. It's not always used correctly (e.g non-lazy ugettext on module-level) and sometimes `_` references to the lazy variant and vice versa. We need a clear guideline.\r\n\r\nI'd propose:\r\n\r\n* `ugettext_lazy` -> `_` (as this is used most often, e.g in models, forms and constants)\r\n* explicit `ugettext` (and others) calls to make sure one sees the differences\r\n\r\nOpinions?"},"comment":{"url":"https://api.github.com/repos/mozilla/addons-server/issues/comments/187772556","html_url":"https://github.com/mozilla/addons-server/issues/1574#issuecomment-187772556","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/1574","id":187772556,"user":{"login":"eviljeff","id":768592,"avatar_url":"https://avatars.githubusercontent.com/u/768592?v=3","gravatar_id":"","url":"https://api.github.com/users/eviljeff","html_url":"https://github.com/eviljeff","followers_url":"https://api.github.com/users/eviljeff/followers","following_url":"https://api.github.com/users/eviljeff/following{/other_user}","gists_url":"https://api.github.com/users/eviljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eviljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviljeff/subscriptions","organizations_url":"https://api.github.com/users/eviljeff/orgs","repos_url":"https://api.github.com/users/eviljeff/repos","events_url":"https://api.github.com/users/eviljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eviljeff/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T16:26:00Z","updated_at":"2016-02-23T16:26:00Z","body":"from a quick search of module imports, it looks like\r\n50 * ugettext as _ \r\n17 * ugettext_lazy as _lazy\r\n14 * ugettext_lazy as _\r\n\r\nSo just pointing out if those are the guidelines it's reversing the current norm in the code."}}