{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/362","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/362/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/362/events","html_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/362","id":165638501,"number":362,"title":"Remove CloudSdkProvider in favour of new CloudSdkResolver strategy","user":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars.githubusercontent.com/u/202851?v=3","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars.githubusercontent.com/u/3290856?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"assignees":[{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars.githubusercontent.com/u/3290856?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-14T19:23:30Z","updated_at":"2016-07-15T14:21:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/362","html_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/362","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/362.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/362.patch"},"body":"Turn `CloudSdkProvider`, a wrapper class that looked for the Google Cloud SDK in a user-specified location, into [a CloudSdk resolver](https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/168).  This allows us to get rid of `CloudSdkProvider` and use the normal CloudSdk.Builder pattern.  `CloudSdkPrompter` must continue to exist, however."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/comments/232963971","html_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/362#issuecomment-232963971","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/362","id":232963971,"user":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars.githubusercontent.com/u/202851?v=3","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T14:21:23Z","updated_at":"2016-07-15T14:21:23Z","body":"This depends on [a change to app-tools-lib](https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/168).  I'll rebase these changes onto #335.\r\n\r\nI had speculated to João on chat about turning the `CloudSdkPrompter`, which prompts the user to download and configure the Google Cloud SDK if required, into a last-ditch resolver:\r\n\r\n> I had wondered if we could turn the [eclipse-side] CloudSdkPrompter into the last-ditch Resolver that would prompt the user if it was running on the SWT thread and if there wasn't a some specific ThreadLocal flag to disable prompting.\r\n> Turning the [eclipse-side] Prompter into a Resolver also reduces the number of calling conventions to create / discover the SDK.\r\n\r\nThat would require some way to order the resolvers."}}
{"actor":{"display_login":"briandealwis"}}