{"action":"created","comment":{"url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/comments/92816998","pull_request_review_id":13339283,"id":92816998,"diff_hunk":"@@ -164,9 +164,10 @@ def ca_bundle():\n     See http://docs.python-requests.org/en/master/user/advanced/ for further details.\n     \"\"\"\n     if 'ROOT_CA' in os.environ:\n+        root_ca = ''.join(e for e in os.environ['ROOT_CA'] if e != '\\t')","path":"main.py","position":4,"original_position":4,"commit_id":"9dfcab5671f1878f48695c562a97dd61f2068aea","original_commit_id":"9dfcab5671f1878f48695c562a97dd61f2068aea","user":{"login":"balintzs","id":16084033,"avatar_url":"https://avatars.githubusercontent.com/u/16084033?v=3","gravatar_id":"","url":"https://api.github.com/users/balintzs","html_url":"https://github.com/balintzs","followers_url":"https://api.github.com/users/balintzs/followers","following_url":"https://api.github.com/users/balintzs/following{/other_user}","gists_url":"https://api.github.com/users/balintzs/gists{/gist_id}","starred_url":"https://api.github.com/users/balintzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balintzs/subscriptions","organizations_url":"https://api.github.com/users/balintzs/orgs","repos_url":"https://api.github.com/users/balintzs/repos","events_url":"https://api.github.com/users/balintzs/events{/privacy}","received_events_url":"https://api.github.com/users/balintzs/received_events","type":"User","site_admin":false},"body":"This may fail if the formatting is different. How about checking for `e` being an empty string after you strip it from whitespaces: `e.strip() != \"\"`?","created_at":"2016-12-16T14:11:13Z","updated_at":"2016-12-16T14:11:13Z","html_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol/pull/12#discussion_r92816998","pull_request_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/comments/92816998"},"html":{"href":"https://github.com/Skyscanner/slingshot-steps-groundcontrol/pull/12#discussion_r92816998"},"pull_request":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12","id":98340055,"html_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol/pull/12","diff_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol/pull/12.diff","patch_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol/pull/12.patch","issue_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/12","number":12,"state":"open","locked":false,"title":"Cleaning up configobj artifacts","user":{"login":"paulci","id":15837291,"avatar_url":"https://avatars.githubusercontent.com/u/15837291?v=3","gravatar_id":"","url":"https://api.github.com/users/paulci","html_url":"https://github.com/paulci","followers_url":"https://api.github.com/users/paulci/followers","following_url":"https://api.github.com/users/paulci/following{/other_user}","gists_url":"https://api.github.com/users/paulci/gists{/gist_id}","starred_url":"https://api.github.com/users/paulci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulci/subscriptions","organizations_url":"https://api.github.com/users/paulci/orgs","repos_url":"https://api.github.com/users/paulci/repos","events_url":"https://api.github.com/users/paulci/events{/privacy}","received_events_url":"https://api.github.com/users/paulci/received_events","type":"User","site_admin":false},"body":"Configobj adds \\n\\t to each line, causing an error when reading the ceritificate.\r\n\r\n### Changes:\r\n* Strip \\t to allow the certificate to be correctly formatted\r\n\r\n### Testing:\r\n* Manual testing\r\n* Unit tests\r\n\r\n### Impact:\r\n* None expected","created_at":"2016-12-16T14:06:01Z","updated_at":"2016-12-16T14:11:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c2070298fde5223e1df23fb8b50e96308ef3987","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/12/comments","statuses_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/statuses/9dfcab5671f1878f48695c562a97dd61f2068aea","head":{"label":"Skyscanner:investigation","ref":"investigation","sha":"9dfcab5671f1878f48695c562a97dd61f2068aea","user":{"login":"Skyscanner","id":522811,"avatar_url":"https://avatars.githubusercontent.com/u/522811?v=3","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"repo":{"id":66553937,"name":"slingshot-steps-groundcontrol","full_name":"Skyscanner/slingshot-steps-groundcontrol","owner":{"login":"Skyscanner","id":522811,"avatar_url":"https://avatars.githubusercontent.com/u/522811?v=3","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol","description":"Contains the steps that we use to interact with GroundControl, our ECS Scheduler","fork":false,"url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol","forks_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/forks","keys_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/teams","hooks_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/hooks","issue_events_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/events","assignees_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/tags","blobs_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/languages","stargazers_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/stargazers","contributors_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/contributors","subscribers_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/subscribers","subscription_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/subscription","commits_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/merges","archive_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/downloads","issues_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/deployments","created_at":"2016-08-25T11:57:34Z","updated_at":"2016-10-27T09:47:32Z","pushed_at":"2016-12-16T14:06:02Z","git_url":"git://github.com/Skyscanner/slingshot-steps-groundcontrol.git","ssh_url":"git@github.com:Skyscanner/slingshot-steps-groundcontrol.git","clone_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol.git","svn_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Skyscanner:master","ref":"master","sha":"a02de5fbc17fbf6b88c2d119d030b13e2eb64b2d","user":{"login":"Skyscanner","id":522811,"avatar_url":"https://avatars.githubusercontent.com/u/522811?v=3","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"repo":{"id":66553937,"name":"slingshot-steps-groundcontrol","full_name":"Skyscanner/slingshot-steps-groundcontrol","owner":{"login":"Skyscanner","id":522811,"avatar_url":"https://avatars.githubusercontent.com/u/522811?v=3","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol","description":"Contains the steps that we use to interact with GroundControl, our ECS Scheduler","fork":false,"url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol","forks_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/forks","keys_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/teams","hooks_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/hooks","issue_events_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/events","assignees_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/tags","blobs_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/languages","stargazers_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/stargazers","contributors_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/contributors","subscribers_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/subscribers","subscription_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/subscription","commits_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/merges","archive_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/downloads","issues_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/deployments","created_at":"2016-08-25T11:57:34Z","updated_at":"2016-10-27T09:47:32Z","pushed_at":"2016-12-16T14:06:02Z","git_url":"git://github.com/Skyscanner/slingshot-steps-groundcontrol.git","ssh_url":"git@github.com:Skyscanner/slingshot-steps-groundcontrol.git","clone_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol.git","svn_url":"https://github.com/Skyscanner/slingshot-steps-groundcontrol","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12"},"html":{"href":"https://github.com/Skyscanner/slingshot-steps-groundcontrol/pull/12"},"issue":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/12"},"comments":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Skyscanner/slingshot-steps-groundcontrol/statuses/9dfcab5671f1878f48695c562a97dd61f2068aea"}}}}
{"actor":{"display_login":"balintzs"}}