{"action":"created","issue":{"url":"https://api.github.com/repos/bukowskis/style-guide/issues/12","repository_url":"https://api.github.com/repos/bukowskis/style-guide","labels_url":"https://api.github.com/repos/bukowskis/style-guide/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/bukowskis/style-guide/issues/12/comments","events_url":"https://api.github.com/repos/bukowskis/style-guide/issues/12/events","html_url":"https://github.com/bukowskis/style-guide/pull/12","id":182020409,"number":12,"title":"Back to the drawing board #4","user":{"login":"mmzoo","id":1029840,"avatar_url":"https://avatars.githubusercontent.com/u/1029840?v=3","gravatar_id":"","url":"https://api.github.com/users/mmzoo","html_url":"https://github.com/mmzoo","followers_url":"https://api.github.com/users/mmzoo/followers","following_url":"https://api.github.com/users/mmzoo/following{/other_user}","gists_url":"https://api.github.com/users/mmzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mmzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmzoo/subscriptions","organizations_url":"https://api.github.com/users/mmzoo/orgs","repos_url":"https://api.github.com/users/mmzoo/repos","events_url":"https://api.github.com/users/mmzoo/events{/privacy}","received_events_url":"https://api.github.com/users/mmzoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-10T13:53:13Z","updated_at":"2016-10-11T08:40:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bukowskis/style-guide/pulls/12","html_url":"https://github.com/bukowskis/style-guide/pull/12","diff_url":"https://github.com/bukowskis/style-guide/pull/12.diff","patch_url":"https://github.com/bukowskis/style-guide/pull/12.patch"},"body":"I applied existing overrides to my best knowledge.\r\nEither way, this is a good starting point."},"comment":{"url":"https://api.github.com/repos/bukowskis/style-guide/issues/comments/252848525","html_url":"https://github.com/bukowskis/style-guide/pull/12#issuecomment-252848525","issue_url":"https://api.github.com/repos/bukowskis/style-guide/issues/12","id":252848525,"user":{"login":"mmzoo","id":1029840,"avatar_url":"https://avatars.githubusercontent.com/u/1029840?v=3","gravatar_id":"","url":"https://api.github.com/users/mmzoo","html_url":"https://github.com/mmzoo","followers_url":"https://api.github.com/users/mmzoo/followers","following_url":"https://api.github.com/users/mmzoo/following{/other_user}","gists_url":"https://api.github.com/users/mmzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mmzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmzoo/subscriptions","organizations_url":"https://api.github.com/users/mmzoo/orgs","repos_url":"https://api.github.com/users/mmzoo/repos","events_url":"https://api.github.com/users/mmzoo/events{/privacy}","received_events_url":"https://api.github.com/users/mmzoo/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T08:40:08Z","updated_at":"2016-10-11T08:40:08Z","body":"> finns det några cops som verkar inte vara aktuella längre \r\n\r\nJag kollade att alla finns som jag la in. T.ex. [här](https://github.com/bbatsov/rubocop/blob/f689210c71f61b5f7d3a8ecf41543148198d9416/config/enabled.yml#L1283)\r\n\r\n> Style/NumericLiterals\r\n\r\nMissade den, la till den nu.\r\n\r\n> Style/StringLiterals\r\n\r\nAh, den dök inte upp i git blame. La till den.\r\n\r\n> Style/LambdaCall\r\n\r\nJag förstod inte riktigt vad det betydde (\"sometimes .call is the proper choice and other times it makes more sense with .()\") och det fanns ingen diskussion. Därför tänkte ja ha default här så det kan tas upp när det händer igen. Antagligen gillar några inte `.()` och några bryr sig inte. Jag täntke bara vara praktiskt här och börja från noll tills nästa review där det dyker upp.\r\n\r\n> Style/FileName\r\n\r\nJag kollade, buggen verkar vara fixat.\r\n\r\n> För mig är det uppenbar att en delad style guide får inte redigeras utan diskussion\r\n\r\nHåller med.\r\n"}}
{"actor":{"display_login":"mmzoo"}}