{"action":"created","issue":{"url":"https://api.github.com/repos/annttu/Diamond-collectors/issues/1","repository_url":"https://api.github.com/repos/annttu/Diamond-collectors","labels_url":"https://api.github.com/repos/annttu/Diamond-collectors/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/annttu/Diamond-collectors/issues/1/comments","events_url":"https://api.github.com/repos/annttu/Diamond-collectors/issues/1/events","html_url":"https://github.com/annttu/Diamond-collectors/issues/1","id":186536769,"number":1,"title":"prev != self.prev","user":{"login":"CaptainQwark","id":3491935,"avatar_url":"https://avatars.githubusercontent.com/u/3491935?v=3","gravatar_id":"","url":"https://api.github.com/users/CaptainQwark","html_url":"https://github.com/CaptainQwark","followers_url":"https://api.github.com/users/CaptainQwark/followers","following_url":"https://api.github.com/users/CaptainQwark/following{/other_user}","gists_url":"https://api.github.com/users/CaptainQwark/gists{/gist_id}","starred_url":"https://api.github.com/users/CaptainQwark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaptainQwark/subscriptions","organizations_url":"https://api.github.com/users/CaptainQwark/orgs","repos_url":"https://api.github.com/users/CaptainQwark/repos","events_url":"https://api.github.com/users/CaptainQwark/events{/privacy}","received_events_url":"https://api.github.com/users/CaptainQwark/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-01T13:43:11Z","updated_at":"2016-11-02T06:50:01Z","closed_at":"2016-11-01T16:56:29Z","body":"Hi, thanks for sharing the zfs arc collector, but there is a serious bug in it:\r\n\r\nOn line 75 you have: `prev = copy.deepcopy(self.cur)` but a few lines later you use `self.prev`. `self.prev` is not the same as `prev`! Either use self.prev on line 75 or drop the `self.` on the lines below that. In the latter case you can remove `self.prev` from the `__init__` as well.\r\n\r\nWithout this fix the collected values are way off for every metric. \r\n"},"comment":{"url":"https://api.github.com/repos/annttu/Diamond-collectors/issues/comments/257786179","html_url":"https://github.com/annttu/Diamond-collectors/issues/1#issuecomment-257786179","issue_url":"https://api.github.com/repos/annttu/Diamond-collectors/issues/1","id":257786179,"user":{"login":"CaptainQwark","id":3491935,"avatar_url":"https://avatars.githubusercontent.com/u/3491935?v=3","gravatar_id":"","url":"https://api.github.com/users/CaptainQwark","html_url":"https://github.com/CaptainQwark","followers_url":"https://api.github.com/users/CaptainQwark/followers","following_url":"https://api.github.com/users/CaptainQwark/following{/other_user}","gists_url":"https://api.github.com/users/CaptainQwark/gists{/gist_id}","starred_url":"https://api.github.com/users/CaptainQwark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaptainQwark/subscriptions","organizations_url":"https://api.github.com/users/CaptainQwark/orgs","repos_url":"https://api.github.com/users/CaptainQwark/repos","events_url":"https://api.github.com/users/CaptainQwark/events{/privacy}","received_events_url":"https://api.github.com/users/CaptainQwark/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T06:50:01Z","updated_at":"2016-11-02T06:50:01Z","body":"Nice, thanks!\n\nAlex.\n\nSent from my iPad\n\n> On 1 Nov 2016, at 17:56, Antti Jaakkola <notifications@github.com> wrote:\n> \n> Thanks for noticing this! I fixed this in commit 9abe896.\n> \n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"CaptainQwark"}}