{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/88736105","pull_request_review_id":9300588,"id":88736105,"diff_hunk":"@@ -355,6 +354,13 @@ angular.module('openshiftConsole')\n             $scope.parameterDisplayNames[parameter.name] = parameter.displayName || parameter.name;\n           });\n \n+          _.each($scope.template.parameters, function(parameter) {\n+            var found = _.find(JSON.parse($routeParams.templateParamsMap), function(param){","path":"app/scripts/controllers/newfromtemplate.js","position":15,"original_position":15,"commit_id":"860657c2c4eae302c05cb17b0d281fa16dd4cb3d","original_commit_id":"860657c2c4eae302c05cb17b0d281fa16dd4cb3d","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Need to catch the exception on JSON parse failures. This is not JSON we're generating, so it might have syntax errors.","created_at":"2016-11-18T20:46:08Z","updated_at":"2016-11-18T20:59:47Z","html_url":"https://github.com/openshift/origin-web-console/pull/884#discussion_r88736105","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/884","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/88736105"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/884#discussion_r88736105"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/884"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/884","id":94052279,"html_url":"https://github.com/openshift/origin-web-console/pull/884","diff_url":"https://github.com/openshift/origin-web-console/pull/884.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/884.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/884","number":884,"state":"open","locked":false,"title":"Adding \"Run on OpenShift\" functionality","user":{"login":"rhamilto","id":895728,"avatar_url":"https://avatars.githubusercontent.com/u/895728?v=3","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"body":"Proposed image stream query string params:\r\n\r\n* namespace (optional, but if not specified, defaults to 'openshift')\r\n* app (optional)\r\n* imageStream (required)\r\n* imageTag (required)\r\n* sourceURI (optional)\r\n* sourceRef (optional)\r\n* contextDir (optional)\r\n\r\nProposed template query string params:\r\n\r\n* namespace (optional, but if not specified, defaults to 'openshift')\r\n* template (required)\r\n* templateParamsMap (optional)\r\n\r\nTesting URLs:\r\n\r\ncreate?app=nodejsEDITED&imageStream=nodejs&imageTag=4&sourceURI=https:%2F%2Fgithub.com%2Fopenshift%2Fnodejs-ex.gitEDITED&sourceRef=masterEDITED&contextDir=%2FEDITED\r\n\r\ncreate?template=nodejs-mongodb-example&templateParamsMap=%5B%7B\"name\":\"NAME\",\"value\":\"nodejs-mongodb-example-EDITED\"%7D,%7B\"name\":\"SOURCE_REPOSITORY_URL\",\"value\":\"https:%2F%2Fgithub.com%2Fopenshift%2Fnodejs-ex.gitEDITED\"%7D,%7B\"name\":\"SOURCE_REPOSITORY_REF\",\"value\":\"EDITED\"%7D,%7B\"name\":\"CONTEXT_DIR\",\"value\":\"%2FEDITED\"%7D%5D\r\n\r\nScreenshots:\r\n\r\nUser has existing project(s) and can create new project(s)\r\n\r\n<img width=\"1224\" alt=\"screen shot 2016-11-17 at 8 36 27 am\" src=\"https://cloud.githubusercontent.com/assets/895728/20391599/20f0bf84-aca2-11e6-8016-4c909aa89b05.PNG\">\r\n<img width=\"1226\" alt=\"screen shot 2016-11-17 at 8 36 39 am\" src=\"https://cloud.githubusercontent.com/assets/895728/20391600/20f11394-aca2-11e6-89ac-4c6109d5b178.PNG\">\r\n\r\n\r\nUser has no project(s), but can create new project(s)\r\n\r\n<img width=\"1225\" alt=\"screen shot 2016-11-17 at 8 55 55 am\" src=\"https://cloud.githubusercontent.com/assets/895728/20392037/1ed79c5c-aca4-11e6-9f14-48459272ab9e.PNG\">\r\n\r\n\r\nUser has existing project(s), but cannot create new project(s)\r\n\r\n<img width=\"1226\" alt=\"screen shot 2016-11-17 at 8 56 28 am\" src=\"https://cloud.githubusercontent.com/assets/895728/20392042/26385e28-aca4-11e6-8080-cc4be1b06061.PNG\">\r\n\r\n\r\nUser has no existing project(s) nor can create new project(s)\r\n\r\n<img width=\"1227\" alt=\"screen shot 2016-11-17 at 8 56 56 am\" src=\"https://cloud.githubusercontent.com/assets/895728/20392050/2daaad1e-aca4-11e6-8887-ed41f2a903c4.PNG\">\r\nWondering if the messaging at the bottom is obvious enough?  This shouldn't be a common case, but still...\r\n\r\n@jwforres or @spadgett, PTAL.\r\n","created_at":"2016-11-16T21:20:30Z","updated_at":"2016-11-18T20:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e7c5d58f19126b43c4d08625cf296cc7b892e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/884/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/884/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/884/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/860657c2c4eae302c05cb17b0d281fa16dd4cb3d","head":{"label":"rhamilto:run-on","ref":"run-on","sha":"860657c2c4eae302c05cb17b0d281fa16dd4cb3d","user":{"login":"rhamilto","id":895728,"avatar_url":"https://avatars.githubusercontent.com/u/895728?v=3","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"repo":{"id":58545493,"name":"origin-web-console","full_name":"rhamilto/origin-web-console","owner":{"login":"rhamilto","id":895728,"avatar_url":"https://avatars.githubusercontent.com/u/895728?v=3","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhamilto/origin-web-console","description":null,"fork":true,"url":"https://api.github.com/repos/rhamilto/origin-web-console","forks_url":"https://api.github.com/repos/rhamilto/origin-web-console/forks","keys_url":"https://api.github.com/repos/rhamilto/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhamilto/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhamilto/origin-web-console/teams","hooks_url":"https://api.github.com/repos/rhamilto/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/rhamilto/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/rhamilto/origin-web-console/events","assignees_url":"https://api.github.com/repos/rhamilto/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/rhamilto/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/rhamilto/origin-web-console/tags","blobs_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhamilto/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/rhamilto/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/rhamilto/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/rhamilto/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/rhamilto/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/rhamilto/origin-web-console/subscription","commits_url":"https://api.github.com/repos/rhamilto/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhamilto/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhamilto/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhamilto/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/rhamilto/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhamilto/origin-web-console/merges","archive_url":"https://api.github.com/repos/rhamilto/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhamilto/origin-web-console/downloads","issues_url":"https://api.github.com/repos/rhamilto/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/rhamilto/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/rhamilto/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/rhamilto/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhamilto/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/rhamilto/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/rhamilto/origin-web-console/deployments","created_at":"2016-05-11T13:04:40Z","updated_at":"2016-05-11T13:04:42Z","pushed_at":"2016-11-18T19:15:39Z","git_url":"git://github.com/rhamilto/origin-web-console.git","ssh_url":"git@github.com:rhamilto/origin-web-console.git","clone_url":"https://github.com/rhamilto/origin-web-console.git","svn_url":"https://github.com/rhamilto/origin-web-console","homepage":null,"size":20954,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"ca4be237df6935819e795eeb2962e985230876e1","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-11-15T12:44:27Z","pushed_at":"2016-11-18T20:30:23Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":23132,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":86,"forks":60,"open_issues":86,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/884"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/884"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/884"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/884/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/884/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/884/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/860657c2c4eae302c05cb17b0d281fa16dd4cb3d"}}}}
{"actor":{"display_login":"spadgett"}}