{"action":"opened","issue":{"url":"https://api.github.com/repos/knockout/knockout/issues/2084","repository_url":"https://api.github.com/repos/knockout/knockout","labels_url":"https://api.github.com/repos/knockout/knockout/issues/2084/labels{/name}","comments_url":"https://api.github.com/repos/knockout/knockout/issues/2084/comments","events_url":"https://api.github.com/repos/knockout/knockout/issues/2084/events","html_url":"https://github.com/knockout/knockout/issues/2084","id":162650565,"number":2084,"title":"Skipping notification if a reference type observable value did not change","user":{"login":"cervengoc","id":6099330,"avatar_url":"https://avatars.githubusercontent.com/u/6099330?v=3","gravatar_id":"","url":"https://api.github.com/users/cervengoc","html_url":"https://github.com/cervengoc","followers_url":"https://api.github.com/users/cervengoc/followers","following_url":"https://api.github.com/users/cervengoc/following{/other_user}","gists_url":"https://api.github.com/users/cervengoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cervengoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cervengoc/subscriptions","organizations_url":"https://api.github.com/users/cervengoc/orgs","repos_url":"https://api.github.com/users/cervengoc/repos","events_url":"https://api.github.com/users/cervengoc/events{/privacy}","received_events_url":"https://api.github.com/users/cervengoc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-06-28T10:14:29Z","updated_at":"2016-06-28T10:14:29Z","closed_at":null,"body":"When using `ko.option.deferUpdates`, for primitive types there is a built logic which skips notification if the value of an observable has not effectively changed.\r\n\r\nI'm in a situation where I use `valueHasMutated` on arrays, to implement batch modification handling (for example I have a `refill` method). The problem is that it invokes notifications and introduces problems in the application.\r\n\r\nI think it would make sense to check *reference* types (arrays, functions, objects) for reference-equality in the default equality comparer. What do you think? Seems like a minor code change.\r\n"}}
{"actor":{"display_login":"cervengoc"}}