{"action":"created","comment":{"url":"https://api.github.com/repos/allegro/marathon-consul/pulls/comments/49139631","id":49139631,"diff_hunk":"@@ -49,6 +49,7 @@ make test\n - Provided HTTP healtcheck will be transferred to Consul.\n - Labels with `tag` value will be converted to Consul tags, `marathon` tag is added by default\n  (e.g, `labels: [\"public\":\"tag\", \"varnish\":\"tag\", \"env\": \"test\"]` → `tags: [\"public\", \"varnish\", \"marathon\"]`).\n+- To schedule Marathon-consul sync one of two options has to be set: `sync-leader` (run sync only on specified node [leadership](https://mesosphere.github.io/marathon/docs/rest-api.html#get-v2-leader)) or `sync-force` (run always).","path":"README.md","position":4,"original_position":4,"commit_id":"dea78b082b6334bbc5404d2db3ab0d6d6ce5705e","original_commit_id":"dea78b082b6334bbc5404d2db3ab0d6d6ce5705e","user":{"login":"janisz","id":1616386,"avatar_url":"https://avatars.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"body":"IMO we should describe what's the difference between `sync-leader` and `marathon-location`. Also describe when sync will take place so I'll write something like this:\r\n> (run sync only on node that is Marathon leader ([marthon leader] equals `sync-leader`)","created_at":"2016-01-07T23:10:45Z","updated_at":"2016-01-07T23:10:45Z","html_url":"https://github.com/allegro/marathon-consul/pull/20#discussion_r49139631","pull_request_url":"https://api.github.com/repos/allegro/marathon-consul/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/allegro/marathon-consul/pulls/comments/49139631"},"html":{"href":"https://github.com/allegro/marathon-consul/pull/20#discussion_r49139631"},"pull_request":{"href":"https://api.github.com/repos/allegro/marathon-consul/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/allegro/marathon-consul/pulls/20","id":55353086,"html_url":"https://github.com/allegro/marathon-consul/pull/20","diff_url":"https://github.com/allegro/marathon-consul/pull/20.diff","patch_url":"https://github.com/allegro/marathon-consul/pull/20.patch","issue_url":"https://api.github.com/repos/allegro/marathon-consul/issues/20","number":20,"state":"open","locked":false,"title":"Marathon leadership-aware sync","user":{"login":"dankraw","id":2399036,"avatar_url":"https://avatars.githubusercontent.com/u/2399036?v=3","gravatar_id":"","url":"https://api.github.com/users/dankraw","html_url":"https://github.com/dankraw","followers_url":"https://api.github.com/users/dankraw/followers","following_url":"https://api.github.com/users/dankraw/following{/other_user}","gists_url":"https://api.github.com/users/dankraw/gists{/gist_id}","starred_url":"https://api.github.com/users/dankraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankraw/subscriptions","organizations_url":"https://api.github.com/users/dankraw/orgs","repos_url":"https://api.github.com/users/dankraw/repos","events_url":"https://api.github.com/users/dankraw/events{/privacy}","received_events_url":"https://api.github.com/users/dankraw/received_events","type":"User","site_admin":false},"body":"Scheduled Marathon-Consul sync will run:\r\n1. only when specified node has leadership\r\n2. always when forced","created_at":"2016-01-07T15:51:02Z","updated_at":"2016-01-07T23:10:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a9d5015c17af813811d25d146e755f83c2b7f0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/allegro/marathon-consul/pulls/20/commits","review_comments_url":"https://api.github.com/repos/allegro/marathon-consul/pulls/20/comments","review_comment_url":"https://api.github.com/repos/allegro/marathon-consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allegro/marathon-consul/issues/20/comments","statuses_url":"https://api.github.com/repos/allegro/marathon-consul/statuses/dea78b082b6334bbc5404d2db3ab0d6d6ce5705e","head":{"label":"allegro:leader_sync","ref":"leader_sync","sha":"dea78b082b6334bbc5404d2db3ab0d6d6ce5705e","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":47399967,"name":"marathon-consul","full_name":"allegro/marathon-consul","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/marathon-consul","description":"Event-based registration of Marathon apps in Consul","fork":false,"url":"https://api.github.com/repos/allegro/marathon-consul","forks_url":"https://api.github.com/repos/allegro/marathon-consul/forks","keys_url":"https://api.github.com/repos/allegro/marathon-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/marathon-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/marathon-consul/teams","hooks_url":"https://api.github.com/repos/allegro/marathon-consul/hooks","issue_events_url":"https://api.github.com/repos/allegro/marathon-consul/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/marathon-consul/events","assignees_url":"https://api.github.com/repos/allegro/marathon-consul/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/marathon-consul/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/marathon-consul/tags","blobs_url":"https://api.github.com/repos/allegro/marathon-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/marathon-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/marathon-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/marathon-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/marathon-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/marathon-consul/languages","stargazers_url":"https://api.github.com/repos/allegro/marathon-consul/stargazers","contributors_url":"https://api.github.com/repos/allegro/marathon-consul/contributors","subscribers_url":"https://api.github.com/repos/allegro/marathon-consul/subscribers","subscription_url":"https://api.github.com/repos/allegro/marathon-consul/subscription","commits_url":"https://api.github.com/repos/allegro/marathon-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/marathon-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/marathon-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/marathon-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/marathon-consul/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/marathon-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/marathon-consul/merges","archive_url":"https://api.github.com/repos/allegro/marathon-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/marathon-consul/downloads","issues_url":"https://api.github.com/repos/allegro/marathon-consul/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/marathon-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/marathon-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/marathon-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/marathon-consul/labels{/name}","releases_url":"https://api.github.com/repos/allegro/marathon-consul/releases{/id}","created_at":"2015-12-04T11:26:26Z","updated_at":"2016-01-07T10:54:38Z","pushed_at":"2016-01-07T15:51:02Z","git_url":"git://github.com/allegro/marathon-consul.git","ssh_url":"git@github.com:allegro/marathon-consul.git","clone_url":"https://github.com/allegro/marathon-consul.git","svn_url":"https://github.com/allegro/marathon-consul","homepage":"","size":170,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":32,"default_branch":"master"}},"base":{"label":"allegro:master","ref":"master","sha":"6e038ebbf3d9bc950937ccdbb5bd8029b7332908","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":47399967,"name":"marathon-consul","full_name":"allegro/marathon-consul","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/marathon-consul","description":"Event-based registration of Marathon apps in Consul","fork":false,"url":"https://api.github.com/repos/allegro/marathon-consul","forks_url":"https://api.github.com/repos/allegro/marathon-consul/forks","keys_url":"https://api.github.com/repos/allegro/marathon-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/marathon-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/marathon-consul/teams","hooks_url":"https://api.github.com/repos/allegro/marathon-consul/hooks","issue_events_url":"https://api.github.com/repos/allegro/marathon-consul/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/marathon-consul/events","assignees_url":"https://api.github.com/repos/allegro/marathon-consul/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/marathon-consul/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/marathon-consul/tags","blobs_url":"https://api.github.com/repos/allegro/marathon-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/marathon-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/marathon-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/marathon-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/marathon-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/marathon-consul/languages","stargazers_url":"https://api.github.com/repos/allegro/marathon-consul/stargazers","contributors_url":"https://api.github.com/repos/allegro/marathon-consul/contributors","subscribers_url":"https://api.github.com/repos/allegro/marathon-consul/subscribers","subscription_url":"https://api.github.com/repos/allegro/marathon-consul/subscription","commits_url":"https://api.github.com/repos/allegro/marathon-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/marathon-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/marathon-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/marathon-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/marathon-consul/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/marathon-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/marathon-consul/merges","archive_url":"https://api.github.com/repos/allegro/marathon-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/marathon-consul/downloads","issues_url":"https://api.github.com/repos/allegro/marathon-consul/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/marathon-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/marathon-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/marathon-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/marathon-consul/labels{/name}","releases_url":"https://api.github.com/repos/allegro/marathon-consul/releases{/id}","created_at":"2015-12-04T11:26:26Z","updated_at":"2016-01-07T10:54:38Z","pushed_at":"2016-01-07T15:51:02Z","git_url":"git://github.com/allegro/marathon-consul.git","ssh_url":"git@github.com:allegro/marathon-consul.git","clone_url":"https://github.com/allegro/marathon-consul.git","svn_url":"https://github.com/allegro/marathon-consul","homepage":"","size":170,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allegro/marathon-consul/pulls/20"},"html":{"href":"https://github.com/allegro/marathon-consul/pull/20"},"issue":{"href":"https://api.github.com/repos/allegro/marathon-consul/issues/20"},"comments":{"href":"https://api.github.com/repos/allegro/marathon-consul/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/allegro/marathon-consul/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/allegro/marathon-consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allegro/marathon-consul/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/allegro/marathon-consul/statuses/dea78b082b6334bbc5404d2db3ab0d6d6ce5705e"}}}}