{"action":"created","issue":{"url":"https://api.github.com/repos/dqhieu/TipCalculator/issues/1","repository_url":"https://api.github.com/repos/dqhieu/TipCalculator","labels_url":"https://api.github.com/repos/dqhieu/TipCalculator/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/dqhieu/TipCalculator/issues/1/comments","events_url":"https://api.github.com/repos/dqhieu/TipCalculator/issues/1/events","html_url":"https://github.com/dqhieu/TipCalculator/issues/1","id":162267569,"number":1,"title":"Submitting CoderSchool iOS Prework","user":{"login":"dqhieu","id":8291457,"avatar_url":"https://avatars.githubusercontent.com/u/8291457?v=3","gravatar_id":"","url":"https://api.github.com/users/dqhieu","html_url":"https://github.com/dqhieu","followers_url":"https://api.github.com/users/dqhieu/followers","following_url":"https://api.github.com/users/dqhieu/following{/other_user}","gists_url":"https://api.github.com/users/dqhieu/gists{/gist_id}","starred_url":"https://api.github.com/users/dqhieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dqhieu/subscriptions","organizations_url":"https://api.github.com/users/dqhieu/orgs","repos_url":"https://api.github.com/users/dqhieu/repos","events_url":"https://api.github.com/users/dqhieu/events{/privacy}","received_events_url":"https://api.github.com/users/dqhieu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-25T06:52:01Z","updated_at":"2016-06-26T11:35:20Z","closed_at":null,"body":"Here is my completed prework Tip Calculator. Thank you!\r\n\r\n/cc @coderschoolreview"},"comment":{"url":"https://api.github.com/repos/dqhieu/TipCalculator/issues/comments/228596898","html_url":"https://github.com/dqhieu/TipCalculator/issues/1#issuecomment-228596898","issue_url":"https://api.github.com/repos/dqhieu/TipCalculator/issues/1","id":228596898,"user":{"login":"minhchau273","id":12395213,"avatar_url":"https://avatars.githubusercontent.com/u/12395213?v=3","gravatar_id":"","url":"https://api.github.com/users/minhchau273","html_url":"https://github.com/minhchau273","followers_url":"https://api.github.com/users/minhchau273/followers","following_url":"https://api.github.com/users/minhchau273/following{/other_user}","gists_url":"https://api.github.com/users/minhchau273/gists{/gist_id}","starred_url":"https://api.github.com/users/minhchau273/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minhchau273/subscriptions","organizations_url":"https://api.github.com/users/minhchau273/orgs","repos_url":"https://api.github.com/users/minhchau273/repos","events_url":"https://api.github.com/users/minhchau273/events{/privacy}","received_events_url":"https://api.github.com/users/minhchau273/received_events","type":"User","site_admin":false},"created_at":"2016-06-26T11:35:20Z","updated_at":"2016-06-26T11:35:20Z","body":"👍 Congratulation on finishing the Tip Calculator with the nice UI. Your app looks great.\r\n\r\n#### Some small comments:\r\n- Looks like you've already had the experience with iOS development before. You even use the auto layout and `UIGestureRecognizer`. 😉 \r\n- Good usage of the `NSUserDefault`. This is one of the methods to pass data between view controllers.\r\n- Nice idea with the pan gesture but it's a little bit hard for users to pan it to their expected percentage exactly.\r\n- You shouldn't let user input the invalid min and max values in Settings, should you? Although you've validated them but you did it in silence. Users don't know you reset the min and max values to the same one util they go back the Settings. I though the pan gesture doesn't work well cuz I try panning the total amount but nothing happens.\r\n- Your app crashed when I paste some text to the amount text field.  \r\n<img width=\"753\" alt=\"screen shot 2016-06-26 at 6 30 56 pm\" src=\"https://cloud.githubusercontent.com/assets/12395213/16362002/2cd17ac4-3bcc-11e6-934a-c88a82ce7674.png\">\r\n\r\nExcellent submission overall 🍡 "}}
{"actor":{"display_login":"minhchau273"}}