{"action":"created","comment":{"url":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/comments/91791084","pull_request_review_id":12303758,"id":91791084,"diff_hunk":"@@ -56,3 +60,76 @@ BOOST_AUTO_TEST_CASE(test_compute_energy)\n     BOOST_REQUIRE(std::abs(error[i]) < tolerance);\n   }\n }\n+\n+// Check that the postprocessor output the quantities that were asked\n+BOOST_AUTO_TEST_CASE(test_supercapacitor_inspector)\n+{\n+  // Build an energy storage device\n+  boost::property_tree::ptree ptree;\n+  boost::property_tree::info_parser::read_info(\"super_capacitor.info\", ptree);\n+  ptree.put(\"debug.material_ids\", true);\n+  ptree.put(\"debug.material_properties\",\n+            \"solid_electrical_conductivity,liquid_electrical_conductivity\");\n+  ptree.put(\"debug.solution_fields\",\n+            \"solid_potential,liquid_potential,overpotential\");\n+  ptree.put(\"debug.solution_fluxes\",\n+            \"solid_current_density,liquid_current_density\");\n+  boost::mpi::communicator world;\n+  std::shared_ptr<cap::EnergyStorageDevice> device =\n+      cap::EnergyStorageDevice::build(ptree, world);\n+\n+  // Execute one time step\n+  double const time_step = 10.;\n+  double const imposed_current = 1e-2;\n+  device->evolve_one_time_step_constant_current(time_step, imposed_current);\n+\n+  // Output the vtu file\n+  cap::SuperCapacitorInspector<2> supercap_inspector;\n+  supercap_inspector.inspect(device.get());\n+\n+  // Check for that the fields are present in the output file\n+  unsigned int fields_found = 0;\n+  std::vector<std::string> fields;\n+  fields.push_back(\"material_id\");\n+  fields.push_back(\"liquid_electrical_conductivity\");\n+  fields.push_back(\"solid_electrical_conductivity\");\n+  fields.push_back(\"solid_potential\");\n+  fields.push_back(\"liquid_potential\");\n+  fields.push_back(\"overpotential\");\n+  fields.push_back(\"solid_current_density_0\");\n+  fields.push_back(\"solid_current_density_1\");\n+  fields.push_back(\"liquid_current_density_0\");\n+  fields.push_back(\"liquid_current_density_1\");","path":"cpp/test/test_postprocessor.cc","position":63,"original_position":63,"commit_id":"f66c1ff1739c0d935fd1584f05fb2ca0badf75d0","original_commit_id":"f66c1ff1739c0d935fd1584f05fb2ca0badf75d0","user":{"login":"Rombur","id":368538,"avatar_url":"https://avatars.githubusercontent.com/u/368538?v=3","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"body":"I don't want to try every possible combinations because I can also output every single material property...","created_at":"2016-12-09T20:37:50Z","updated_at":"2016-12-09T20:37:50Z","html_url":"https://github.com/ORNL-CEES/Cap/pull/246#discussion_r91791084","pull_request_url":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/comments/91791084"},"html":{"href":"https://github.com/ORNL-CEES/Cap/pull/246#discussion_r91791084"},"pull_request":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246","id":97371716,"html_url":"https://github.com/ORNL-CEES/Cap/pull/246","diff_url":"https://github.com/ORNL-CEES/Cap/pull/246.diff","patch_url":"https://github.com/ORNL-CEES/Cap/pull/246.patch","issue_url":"https://api.github.com/repos/ORNL-CEES/Cap/issues/246","number":246,"state":"open","locked":false,"title":"Postprocessor","user":{"login":"Rombur","id":368538,"avatar_url":"https://avatars.githubusercontent.com/u/368538?v=3","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"body":"Add two tests and clean another one.","created_at":"2016-12-09T20:06:31Z","updated_at":"2016-12-09T20:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8576c934569501f9487a2fd9613a362a5b66958b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246/commits","review_comments_url":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246/comments","review_comment_url":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ORNL-CEES/Cap/issues/246/comments","statuses_url":"https://api.github.com/repos/ORNL-CEES/Cap/statuses/f66c1ff1739c0d935fd1584f05fb2ca0badf75d0","head":{"label":"Rombur:postprocessor","ref":"postprocessor","sha":"f66c1ff1739c0d935fd1584f05fb2ca0badf75d0","user":{"login":"Rombur","id":368538,"avatar_url":"https://avatars.githubusercontent.com/u/368538?v=3","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"repo":{"id":50516122,"name":"Cap","full_name":"Rombur/Cap","owner":{"login":"Rombur","id":368538,"avatar_url":"https://avatars.githubusercontent.com/u/368538?v=3","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rombur/Cap","description":"A library for modeling energy storage devices.","fork":true,"url":"https://api.github.com/repos/Rombur/Cap","forks_url":"https://api.github.com/repos/Rombur/Cap/forks","keys_url":"https://api.github.com/repos/Rombur/Cap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rombur/Cap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rombur/Cap/teams","hooks_url":"https://api.github.com/repos/Rombur/Cap/hooks","issue_events_url":"https://api.github.com/repos/Rombur/Cap/issues/events{/number}","events_url":"https://api.github.com/repos/Rombur/Cap/events","assignees_url":"https://api.github.com/repos/Rombur/Cap/assignees{/user}","branches_url":"https://api.github.com/repos/Rombur/Cap/branches{/branch}","tags_url":"https://api.github.com/repos/Rombur/Cap/tags","blobs_url":"https://api.github.com/repos/Rombur/Cap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rombur/Cap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rombur/Cap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rombur/Cap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rombur/Cap/statuses/{sha}","languages_url":"https://api.github.com/repos/Rombur/Cap/languages","stargazers_url":"https://api.github.com/repos/Rombur/Cap/stargazers","contributors_url":"https://api.github.com/repos/Rombur/Cap/contributors","subscribers_url":"https://api.github.com/repos/Rombur/Cap/subscribers","subscription_url":"https://api.github.com/repos/Rombur/Cap/subscription","commits_url":"https://api.github.com/repos/Rombur/Cap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rombur/Cap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rombur/Cap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rombur/Cap/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rombur/Cap/contents/{+path}","compare_url":"https://api.github.com/repos/Rombur/Cap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rombur/Cap/merges","archive_url":"https://api.github.com/repos/Rombur/Cap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rombur/Cap/downloads","issues_url":"https://api.github.com/repos/Rombur/Cap/issues{/number}","pulls_url":"https://api.github.com/repos/Rombur/Cap/pulls{/number}","milestones_url":"https://api.github.com/repos/Rombur/Cap/milestones{/number}","notifications_url":"https://api.github.com/repos/Rombur/Cap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rombur/Cap/labels{/name}","releases_url":"https://api.github.com/repos/Rombur/Cap/releases{/id}","deployments_url":"https://api.github.com/repos/Rombur/Cap/deployments","created_at":"2016-01-27T15:17:09Z","updated_at":"2016-01-27T15:17:10Z","pushed_at":"2016-12-09T20:05:57Z","git_url":"git://github.com/Rombur/Cap.git","ssh_url":"git@github.com:Rombur/Cap.git","clone_url":"https://github.com/Rombur/Cap.git","svn_url":"https://github.com/Rombur/Cap","homepage":"http://cap.readthedocs.org","size":1803,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ORNL-CEES:master","ref":"master","sha":"848120927f2f3e408147b5ed860a1a695b315f89","user":{"login":"ORNL-CEES","id":6653148,"avatar_url":"https://avatars.githubusercontent.com/u/6653148?v=3","gravatar_id":"","url":"https://api.github.com/users/ORNL-CEES","html_url":"https://github.com/ORNL-CEES","followers_url":"https://api.github.com/users/ORNL-CEES/followers","following_url":"https://api.github.com/users/ORNL-CEES/following{/other_user}","gists_url":"https://api.github.com/users/ORNL-CEES/gists{/gist_id}","starred_url":"https://api.github.com/users/ORNL-CEES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ORNL-CEES/subscriptions","organizations_url":"https://api.github.com/users/ORNL-CEES/orgs","repos_url":"https://api.github.com/users/ORNL-CEES/repos","events_url":"https://api.github.com/users/ORNL-CEES/events{/privacy}","received_events_url":"https://api.github.com/users/ORNL-CEES/received_events","type":"Organization","site_admin":false},"repo":{"id":50514800,"name":"Cap","full_name":"ORNL-CEES/Cap","owner":{"login":"ORNL-CEES","id":6653148,"avatar_url":"https://avatars.githubusercontent.com/u/6653148?v=3","gravatar_id":"","url":"https://api.github.com/users/ORNL-CEES","html_url":"https://github.com/ORNL-CEES","followers_url":"https://api.github.com/users/ORNL-CEES/followers","following_url":"https://api.github.com/users/ORNL-CEES/following{/other_user}","gists_url":"https://api.github.com/users/ORNL-CEES/gists{/gist_id}","starred_url":"https://api.github.com/users/ORNL-CEES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ORNL-CEES/subscriptions","organizations_url":"https://api.github.com/users/ORNL-CEES/orgs","repos_url":"https://api.github.com/users/ORNL-CEES/repos","events_url":"https://api.github.com/users/ORNL-CEES/events{/privacy}","received_events_url":"https://api.github.com/users/ORNL-CEES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ORNL-CEES/Cap","description":"A library for modeling energy storage devices.","fork":false,"url":"https://api.github.com/repos/ORNL-CEES/Cap","forks_url":"https://api.github.com/repos/ORNL-CEES/Cap/forks","keys_url":"https://api.github.com/repos/ORNL-CEES/Cap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ORNL-CEES/Cap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ORNL-CEES/Cap/teams","hooks_url":"https://api.github.com/repos/ORNL-CEES/Cap/hooks","issue_events_url":"https://api.github.com/repos/ORNL-CEES/Cap/issues/events{/number}","events_url":"https://api.github.com/repos/ORNL-CEES/Cap/events","assignees_url":"https://api.github.com/repos/ORNL-CEES/Cap/assignees{/user}","branches_url":"https://api.github.com/repos/ORNL-CEES/Cap/branches{/branch}","tags_url":"https://api.github.com/repos/ORNL-CEES/Cap/tags","blobs_url":"https://api.github.com/repos/ORNL-CEES/Cap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ORNL-CEES/Cap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ORNL-CEES/Cap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ORNL-CEES/Cap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ORNL-CEES/Cap/statuses/{sha}","languages_url":"https://api.github.com/repos/ORNL-CEES/Cap/languages","stargazers_url":"https://api.github.com/repos/ORNL-CEES/Cap/stargazers","contributors_url":"https://api.github.com/repos/ORNL-CEES/Cap/contributors","subscribers_url":"https://api.github.com/repos/ORNL-CEES/Cap/subscribers","subscription_url":"https://api.github.com/repos/ORNL-CEES/Cap/subscription","commits_url":"https://api.github.com/repos/ORNL-CEES/Cap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ORNL-CEES/Cap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ORNL-CEES/Cap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ORNL-CEES/Cap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ORNL-CEES/Cap/contents/{+path}","compare_url":"https://api.github.com/repos/ORNL-CEES/Cap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ORNL-CEES/Cap/merges","archive_url":"https://api.github.com/repos/ORNL-CEES/Cap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ORNL-CEES/Cap/downloads","issues_url":"https://api.github.com/repos/ORNL-CEES/Cap/issues{/number}","pulls_url":"https://api.github.com/repos/ORNL-CEES/Cap/pulls{/number}","milestones_url":"https://api.github.com/repos/ORNL-CEES/Cap/milestones{/number}","notifications_url":"https://api.github.com/repos/ORNL-CEES/Cap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ORNL-CEES/Cap/labels{/name}","releases_url":"https://api.github.com/repos/ORNL-CEES/Cap/releases{/id}","deployments_url":"https://api.github.com/repos/ORNL-CEES/Cap/deployments","created_at":"2016-01-27T14:56:58Z","updated_at":"2016-11-18T19:55:18Z","pushed_at":"2016-12-09T20:06:31Z","git_url":"git://github.com/ORNL-CEES/Cap.git","ssh_url":"git@github.com:ORNL-CEES/Cap.git","clone_url":"https://github.com/ORNL-CEES/Cap.git","svn_url":"https://github.com/ORNL-CEES/Cap","homepage":"http://cap.readthedocs.org","size":1807,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246"},"html":{"href":"https://github.com/ORNL-CEES/Cap/pull/246"},"issue":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/issues/246"},"comments":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/ORNL-CEES/Cap/statuses/f66c1ff1739c0d935fd1584f05fb2ca0badf75d0"}}}}
{"actor":{"display_login":"Rombur"}}