{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments/93980773","pull_request_review_id":14511565,"id":93980773,"diff_hunk":"@@ -0,0 +1,42 @@\n+﻿// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using NuGet.Shared;\n+\n+namespace NuGet.Server.Core.Infrastructure\n+{\n+    public class IdAndVersionEqualityComparer : IEqualityComparer<IServerPackage>\n+    {\n+        private static IdAndVersionEqualityComparer _instance = new IdAndVersionEqualityComparer();","path":"src/NuGet.Server.Core/Infrastructure/IdAndVersionEqualityComparer.cs","position":12,"original_position":12,"commit_id":"bc9a8612c07f0d1de396848568f204b5d711a0c0","original_commit_id":"bc9a8612c07f0d1de396848568f204b5d711a0c0","user":{"login":"joelverhagen","id":94054,"avatar_url":"https://avatars.githubusercontent.com/u/94054?v=3","gravatar_id":"","url":"https://api.github.com/users/joelverhagen","html_url":"https://github.com/joelverhagen","followers_url":"https://api.github.com/users/joelverhagen/followers","following_url":"https://api.github.com/users/joelverhagen/following{/other_user}","gists_url":"https://api.github.com/users/joelverhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/joelverhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelverhagen/subscriptions","organizations_url":"https://api.github.com/users/joelverhagen/orgs","repos_url":"https://api.github.com/users/joelverhagen/repos","events_url":"https://api.github.com/users/joelverhagen/events{/privacy}","received_events_url":"https://api.github.com/users/joelverhagen/received_events","type":"User","site_admin":false},"body":"Nice catch.","created_at":"2016-12-27T23:38:43Z","updated_at":"2016-12-27T23:38:43Z","html_url":"https://github.com/NuGet/NuGet.Server/pull/25#discussion_r93980773","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments/93980773"},"html":{"href":"https://github.com/NuGet/NuGet.Server/pull/25#discussion_r93980773"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25","id":99490915,"html_url":"https://github.com/NuGet/NuGet.Server/pull/25","diff_url":"https://github.com/NuGet/NuGet.Server/pull/25.diff","patch_url":"https://github.com/NuGet/NuGet.Server/pull/25.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/25","number":25,"state":"open","locked":false,"title":"Remove IPackage and IPackageRepository implementations","user":{"login":"joelverhagen","id":94054,"avatar_url":"https://avatars.githubusercontent.com/u/94054?v=3","gravatar_id":"","url":"https://api.github.com/users/joelverhagen","html_url":"https://github.com/joelverhagen","followers_url":"https://api.github.com/users/joelverhagen/followers","following_url":"https://api.github.com/users/joelverhagen/following{/other_user}","gists_url":"https://api.github.com/users/joelverhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/joelverhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelverhagen/subscriptions","organizations_url":"https://api.github.com/users/joelverhagen/orgs","repos_url":"https://api.github.com/users/joelverhagen/repos","events_url":"https://api.github.com/users/joelverhagen/events{/privacy}","received_events_url":"https://api.github.com/users/joelverhagen/received_events","type":"User","site_admin":false},"body":"Instead of depending on NuGet.Core interfaces for server-side concerns, remove the `IPackage` interface from `ServerPackage` and `IPackageRepository` from `ServerPackageRepository`. This allows the following:\r\n\r\n1. Interface changes on `ServerPackage` without effecting NuGet.Core consumers `IPackage` interface.\r\n1. Further deprecation of NuGet.Core. This means we can more easily move to 3.x/4.x libraries for NuGet.Server in the future.\r\n1. Removal of unused properties and methods on `ServerPackage` and `ServerPackageRepository`.\r\n\r\nNuGet.Core is still used to read .nupkgs from disk but is not part of the \"core\" server side API.\r\n\r\n/cc @emgarten @skofman1 @dtivel\r\n","created_at":"2016-12-27T22:52:03Z","updated_at":"2016-12-27T23:38:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1fcc31b7192bc225c651029c42152d87e60a8a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/25/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Server/statuses/bc9a8612c07f0d1de396848568f204b5d711a0c0","head":{"label":"joelverhagen:ps-fork-core","ref":"ps-fork-core","sha":"bc9a8612c07f0d1de396848568f204b5d711a0c0","user":{"login":"joelverhagen","id":94054,"avatar_url":"https://avatars.githubusercontent.com/u/94054?v=3","gravatar_id":"","url":"https://api.github.com/users/joelverhagen","html_url":"https://github.com/joelverhagen","followers_url":"https://api.github.com/users/joelverhagen/followers","following_url":"https://api.github.com/users/joelverhagen/following{/other_user}","gists_url":"https://api.github.com/users/joelverhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/joelverhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelverhagen/subscriptions","organizations_url":"https://api.github.com/users/joelverhagen/orgs","repos_url":"https://api.github.com/users/joelverhagen/repos","events_url":"https://api.github.com/users/joelverhagen/events{/privacy}","received_events_url":"https://api.github.com/users/joelverhagen/received_events","type":"User","site_admin":false},"repo":{"id":77474911,"name":"NuGet.Server","full_name":"joelverhagen/NuGet.Server","owner":{"login":"joelverhagen","id":94054,"avatar_url":"https://avatars.githubusercontent.com/u/94054?v=3","gravatar_id":"","url":"https://api.github.com/users/joelverhagen","html_url":"https://github.com/joelverhagen","followers_url":"https://api.github.com/users/joelverhagen/followers","following_url":"https://api.github.com/users/joelverhagen/following{/other_user}","gists_url":"https://api.github.com/users/joelverhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/joelverhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelverhagen/subscriptions","organizations_url":"https://api.github.com/users/joelverhagen/orgs","repos_url":"https://api.github.com/users/joelverhagen/repos","events_url":"https://api.github.com/users/joelverhagen/events{/privacy}","received_events_url":"https://api.github.com/users/joelverhagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joelverhagen/NuGet.Server","description":"The home of the NuGet.server package, a lightweight standalone NuGet server","fork":true,"url":"https://api.github.com/repos/joelverhagen/NuGet.Server","forks_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/forks","keys_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/teams","hooks_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/hooks","issue_events_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/issues/events{/number}","events_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/events","assignees_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/assignees{/user}","branches_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/branches{/branch}","tags_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/tags","blobs_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/statuses/{sha}","languages_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/languages","stargazers_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/stargazers","contributors_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/contributors","subscribers_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/subscribers","subscription_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/subscription","commits_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/contents/{+path}","compare_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/merges","archive_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/downloads","issues_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/issues{/number}","pulls_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/pulls{/number}","milestones_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/milestones{/number}","notifications_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/labels{/name}","releases_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/releases{/id}","deployments_url":"https://api.github.com/repos/joelverhagen/NuGet.Server/deployments","created_at":"2016-12-27T18:26:46Z","updated_at":"2016-12-27T18:26:48Z","pushed_at":"2016-12-27T22:45:47Z","git_url":"git://github.com/joelverhagen/NuGet.Server.git","ssh_url":"git@github.com:joelverhagen/NuGet.Server.git","clone_url":"https://github.com/joelverhagen/NuGet.Server.git","svn_url":"https://github.com/joelverhagen/NuGet.Server","homepage":null,"size":2632,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"5652a0343fb57209a4295a7cdd2028e50684d8f6","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":47568519,"name":"NuGet.Server","full_name":"NuGet/NuGet.Server","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Server","description":"The home of the NuGet.server package, a lightweight standalone NuGet server","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Server","forks_url":"https://api.github.com/repos/NuGet/NuGet.Server/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Server/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Server/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Server/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Server/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Server/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Server/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Server/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Server/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Server/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Server/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Server/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Server/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Server/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Server/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Server/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Server/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Server/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Server/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Server/deployments","created_at":"2015-12-07T17:37:29Z","updated_at":"2016-12-27T14:22:25Z","pushed_at":"2016-12-27T22:52:04Z","git_url":"git://github.com/NuGet/NuGet.Server.git","ssh_url":"git@github.com:NuGet/NuGet.Server.git","clone_url":"https://github.com/NuGet/NuGet.Server.git","svn_url":"https://github.com/NuGet/NuGet.Server","homepage":null,"size":2604,"stargazers_count":87,"watchers_count":87,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":3,"forks":57,"open_issues":3,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25"},"html":{"href":"https://github.com/NuGet/NuGet.Server/pull/25"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/issues/25"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/statuses/bc9a8612c07f0d1de396848568f204b5d711a0c0"}}}}
{"actor":{"display_login":"joelverhagen"}}