{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7425","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7425/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7425/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7425/events","html_url":"https://github.com/nodejs/node/pull/7425","id":162312088,"number":7425,"title":"stream: support decoding buffers for Writables","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0"},{"url":"https://api.github.com/repos/nodejs/node/labels/stream","name":"stream","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-06-26T04:30:59Z","updated_at":"2016-08-04T12:16:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7425","html_url":"https://github.com/nodejs/node/pull/7425","diff_url":"https://github.com/nodejs/node/pull/7425.diff","patch_url":"https://github.com/nodejs/node/pull/7425.patch"},"body":"##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows) passes\r\n- [x] a test and/or benchmark is included\r\n- [x] documentation is changed or added\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nstream\r\n\r\n##### Description of change\r\n\r\nSee https://github.com/nodejs/node/issues/7315 for motivation.\r\n\r\nSupport decoding the input of writable streams to a specific decoding before passing it to `_write()`.\r\n\r\nBy default, all data written to a writable stream is encoded into Buffers. This change enables the reverse situation, i.e. when it is desired by the stream implementer to process all input as strings, whether it was passed to `write()` as a string or not.\r\n\r\nThis makes sense for multi-byte character encodings where the buffers that are written using `write()` may contain partial characters, so calling `chunk.toString()` is not universally applicable."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/237535858","html_url":"https://github.com/nodejs/node/pull/7425#issuecomment-237535858","issue_url":"https://api.github.com/repos/nodejs/node/issues/7425","id":237535858,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T12:16:33Z","updated_at":"2016-08-04T12:16:33Z","body":"I’ll run those again with more iterations to get a clearer picture there (btw, the full 30× run of all HTTP & net benchmarks took over 1½ days… I’m not doing that again :D)"}}
{"actor":{"display_login":"addaleax"}}