{"action":"created","comment":{"url":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/comments/81423831","pull_request_review_id":2407805,"id":81423831,"diff_hunk":"@@ -112,6 +112,18 @@ impl<S> From<ErrorStack> for HandshakeError<S> {\n fn ctx() -> Result<SslContext, Error> {\n     let mut ctx = try!(SslContext::new(SslMethod::Sslv23));\n     try!(ctx.set_default_verify_paths());\n+\n+    // options to enable and cipher list lifted from libcurl\n+    let mut opts = ssl::SSL_OP_ALL;\n+    opts |= ssl::SSL_OP_NO_TICKET;\n+    opts |= ssl::SSL_OP_NO_COMPRESSION;\n+    opts &= !ssl::SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG;\n+    opts &= !ssl::SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS;\n+    opts |= ssl::SSL_OP_NO_SSLV2;\n+    opts |= ssl::SSL_OP_NO_SSLV3;","path":"src/imp/openssl.rs","position":12,"original_position":12,"commit_id":"90a204d483460e253ef059236b20a00e3258234f","original_commit_id":"90a204d483460e253ef059236b20a00e3258234f","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"body":"We may want to force disable sslv2 and sslv3 on the other implementations for uniformity. This seems reasonable though.","created_at":"2016-09-30T21:49:33Z","updated_at":"2016-09-30T21:49:33Z","html_url":"https://github.com/sfackler/rust-native-tls/pull/9#discussion_r81423831","pull_request_url":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/comments/81423831"},"html":{"href":"https://github.com/sfackler/rust-native-tls/pull/9#discussion_r81423831"},"pull_request":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9","id":87567985,"html_url":"https://github.com/sfackler/rust-native-tls/pull/9","diff_url":"https://github.com/sfackler/rust-native-tls/pull/9.diff","patch_url":"https://github.com/sfackler/rust-native-tls/pull/9.patch","issue_url":"https://api.github.com/repos/sfackler/rust-native-tls/issues/9","number":9,"state":"open","locked":false,"title":"Set some defaults based on libcurl","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"* Enable `SSL_OP_ALL` by default which apparently enables a number of useful bug\r\n  workarounds (claimed by libcurl)\r\n* Frob a few bits here afterwards to disable some insecure options.\r\n* Use the cipher list from libcurl to enable/disable ciphers","created_at":"2016-09-30T21:19:11Z","updated_at":"2016-09-30T21:49:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac433d05dace812fcc6c7b82c7d2c7b0e2cd6e89","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9/commits","review_comments_url":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9/comments","review_comment_url":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sfackler/rust-native-tls/issues/9/comments","statuses_url":"https://api.github.com/repos/sfackler/rust-native-tls/statuses/90a204d483460e253ef059236b20a00e3258234f","head":{"label":"alexcrichton:openssl-defaults","ref":"openssl-defaults","sha":"90a204d483460e253ef059236b20a00e3258234f","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":63932136,"name":"rust-native-tls","full_name":"alexcrichton/rust-native-tls","owner":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/rust-native-tls","description":null,"fork":true,"url":"https://api.github.com/repos/alexcrichton/rust-native-tls","forks_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/forks","keys_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/teams","hooks_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/events","assignees_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/tags","blobs_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/subscription","commits_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/merges","archive_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/downloads","issues_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/releases{/id}","deployments_url":"https://api.github.com/repos/alexcrichton/rust-native-tls/deployments","created_at":"2016-07-22T07:14:46Z","updated_at":"2016-07-22T07:14:47Z","pushed_at":"2016-09-30T21:27:14Z","git_url":"git://github.com/alexcrichton/rust-native-tls.git","ssh_url":"git@github.com:alexcrichton/rust-native-tls.git","clone_url":"https://github.com/alexcrichton/rust-native-tls.git","svn_url":"https://github.com/alexcrichton/rust-native-tls","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sfackler:master","ref":"master","sha":"ba79cd1e95f0f399d9e7288b6ae3f56478f35998","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"repo":{"id":56415591,"name":"rust-native-tls","full_name":"sfackler/rust-native-tls","owner":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfackler/rust-native-tls","description":"","fork":false,"url":"https://api.github.com/repos/sfackler/rust-native-tls","forks_url":"https://api.github.com/repos/sfackler/rust-native-tls/forks","keys_url":"https://api.github.com/repos/sfackler/rust-native-tls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfackler/rust-native-tls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfackler/rust-native-tls/teams","hooks_url":"https://api.github.com/repos/sfackler/rust-native-tls/hooks","issue_events_url":"https://api.github.com/repos/sfackler/rust-native-tls/issues/events{/number}","events_url":"https://api.github.com/repos/sfackler/rust-native-tls/events","assignees_url":"https://api.github.com/repos/sfackler/rust-native-tls/assignees{/user}","branches_url":"https://api.github.com/repos/sfackler/rust-native-tls/branches{/branch}","tags_url":"https://api.github.com/repos/sfackler/rust-native-tls/tags","blobs_url":"https://api.github.com/repos/sfackler/rust-native-tls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfackler/rust-native-tls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfackler/rust-native-tls/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfackler/rust-native-tls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfackler/rust-native-tls/statuses/{sha}","languages_url":"https://api.github.com/repos/sfackler/rust-native-tls/languages","stargazers_url":"https://api.github.com/repos/sfackler/rust-native-tls/stargazers","contributors_url":"https://api.github.com/repos/sfackler/rust-native-tls/contributors","subscribers_url":"https://api.github.com/repos/sfackler/rust-native-tls/subscribers","subscription_url":"https://api.github.com/repos/sfackler/rust-native-tls/subscription","commits_url":"https://api.github.com/repos/sfackler/rust-native-tls/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfackler/rust-native-tls/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfackler/rust-native-tls/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfackler/rust-native-tls/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfackler/rust-native-tls/contents/{+path}","compare_url":"https://api.github.com/repos/sfackler/rust-native-tls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfackler/rust-native-tls/merges","archive_url":"https://api.github.com/repos/sfackler/rust-native-tls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfackler/rust-native-tls/downloads","issues_url":"https://api.github.com/repos/sfackler/rust-native-tls/issues{/number}","pulls_url":"https://api.github.com/repos/sfackler/rust-native-tls/pulls{/number}","milestones_url":"https://api.github.com/repos/sfackler/rust-native-tls/milestones{/number}","notifications_url":"https://api.github.com/repos/sfackler/rust-native-tls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfackler/rust-native-tls/labels{/name}","releases_url":"https://api.github.com/repos/sfackler/rust-native-tls/releases{/id}","deployments_url":"https://api.github.com/repos/sfackler/rust-native-tls/deployments","created_at":"2016-04-17T02:40:11Z","updated_at":"2016-09-29T13:59:27Z","pushed_at":"2016-09-30T21:27:14Z","git_url":"git://github.com/sfackler/rust-native-tls.git","ssh_url":"git@github.com:sfackler/rust-native-tls.git","clone_url":"https://github.com/sfackler/rust-native-tls.git","svn_url":"https://github.com/sfackler/rust-native-tls","homepage":null,"size":77,"stargazers_count":11,"watchers_count":11,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9"},"html":{"href":"https://github.com/sfackler/rust-native-tls/pull/9"},"issue":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/issues/9"},"comments":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/sfackler/rust-native-tls/statuses/90a204d483460e253ef059236b20a00e3258234f"}}}}
{"actor":{"display_login":"sfackler"}}