{"action":"created","issue":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1205","repository_url":"https://api.github.com/repos/opensim-org/opensim-core","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1205/labels{/name}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1205/comments","events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1205/events","html_url":"https://github.com/opensim-org/opensim-core/pull/1205","id":172781784,"number":1205,"title":"Fix path failure when WrapObject is attached to a PhysicalOffsetFrame","user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars.githubusercontent.com/u/6494122?v=3","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars.githubusercontent.com/u/6494122?v=3","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"assignees":[{"login":"aseth1","id":6494122,"avatar_url":"https://avatars.githubusercontent.com/u/6494122?v=3","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/opensim-org/opensim-core/milestones/1","html_url":"https://github.com/opensim-org/opensim-core/milestones/OpenSim%204.0","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones/1/labels","id":725618,"number":1,"title":"OpenSim 4.0","description":"","creator":{"login":"jenhicks","id":4510959,"avatar_url":"https://avatars.githubusercontent.com/u/4510959?v=3","gravatar_id":"","url":"https://api.github.com/users/jenhicks","html_url":"https://github.com/jenhicks","followers_url":"https://api.github.com/users/jenhicks/followers","following_url":"https://api.github.com/users/jenhicks/following{/other_user}","gists_url":"https://api.github.com/users/jenhicks/gists{/gist_id}","starred_url":"https://api.github.com/users/jenhicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenhicks/subscriptions","organizations_url":"https://api.github.com/users/jenhicks/orgs","repos_url":"https://api.github.com/users/jenhicks/repos","events_url":"https://api.github.com/users/jenhicks/events{/privacy}","received_events_url":"https://api.github.com/users/jenhicks/received_events","type":"User","site_admin":false},"open_issues":139,"closed_issues":331,"state":"open","created_at":"2014-07-18T21:08:06Z","updated_at":"2016-09-21T22:47:08Z","due_on":null,"closed_at":null},"comments":49,"created_at":"2016-08-23T19:11:01Z","updated_at":"2016-09-23T01:15:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1205","html_url":"https://github.com/opensim-org/opensim-core/pull/1205","diff_url":"https://github.com/opensim-org/opensim-core/pull/1205.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/1205.patch"},"body":"This PR fixes #1129. \r\n\r\nThe main changes are:\r\n 1. attached a patella `WrapCylinder` to a `PhyscialOffsetFrame` on the thigh `Body` instead of using the `WrapObject`'s internal transform to the `exampleHopperDevice` and trapping Exceptions thrown during its execution.\r\n 2. added a private list of ordered subcomponents that specifies the the order in which subcomponents are added to the System. Bodies and Joints anywhere in the Model, for example, must be added to the System in the order of a valid MultibodyTree, followed by Frames, Constraints and Forces. All Components can have an opinion about their order, but the top-level (Model) has the final say. Corresponding methods to reset the list and build it were added.\r\n 3.  The major fallout of the change was that CMC was assuming coordinate data in the order of the CoordinateSet corresponds directly with the order of q's in the State. The Coordinates in CoordinateSet are in order of the traversal order of `getComponentList<Joint>` which has nothing to do with the State order, so this assumption cannot be made and was removed from CMC.\r\n 4. Some general cleanup, correction and tightening of tolerances in related test cases.\r\n 5. The order of the `DecorativeGeometry` to be drawn was changed due changes in Component order, so the standard for `testVisualization` had to be updated.\r\n\r\nThis PR likely fixes #1105 as well, but it is not explicitly tested. A subsequent PR will address that and will attempt to remove the now unnecessary reordering of the Joints in the model's JointSet in Model.cpp [lines 591-702](https://github.com/opensim-org/opensim-core/commit/09197e1969601320d738125582cf3c7ba89e8d04#diff-447a828d94f7bb607768e454b9d331cbR691)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/opensim-org/opensim-core/1205)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/249075166","html_url":"https://github.com/opensim-org/opensim-core/pull/1205#issuecomment-249075166","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1205","id":249075166,"user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars.githubusercontent.com/u/6494122?v=3","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T01:15:47Z","updated_at":"2016-09-23T01:15:47Z","body":"@tkuchida @chrisdembia, master (with #1267) was merged with this PR and `testInitState` is now passing across the board (Yay!). There is the `testContactGeometry`  failure in debug, which is timing out on travis (known issue reported in #393). If there are no further issues please merge."}}
{"actor":{"display_login":"aseth1"}}