{"action":"created","comment":{"url":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments/71460671","id":71460671,"diff_hunk":"@@ -11097,13 +11144,28 @@ mr_lengthval_string_internal (DB_VALUE * value, int disk, int align)\n     {\n       return len;\n     }\n-  else if (align == INT_ALIGNMENT)\n-    {\n-      return or_packed_varchar_length (len);\n-    }\n   else\n     {\n-      return or_varchar_length (len);\n+      if (len >= PRIM_MINIMUM_STRING_LENGTH_FOR_COMPRESSION)\n+\t{\n+\t  len = mr_get_compression_length (str, len) + PRIM_TEMPORARY_DISK_SIZE;","path":"src/object/object_primitive.c","position":140,"original_position":140,"commit_id":"647e8e489a0fc618c69c953f78a530455ebadc55","original_commit_id":"647e8e489a0fc618c69c953f78a530455ebadc55","user":{"login":"eseokoh","id":17467172,"avatar_url":"https://avatars.githubusercontent.com/u/17467172?v=3","gravatar_id":"","url":"https://api.github.com/users/eseokoh","html_url":"https://github.com/eseokoh","followers_url":"https://api.github.com/users/eseokoh/followers","following_url":"https://api.github.com/users/eseokoh/following{/other_user}","gists_url":"https://api.github.com/users/eseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/eseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eseokoh/subscriptions","organizations_url":"https://api.github.com/users/eseokoh/orgs","repos_url":"https://api.github.com/users/eseokoh/repos","events_url":"https://api.github.com/users/eseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/eseokoh/received_events","type":"User","site_admin":false},"body":"@lucianlazar2211 \r\n\r\nPlease handle errors of `mr_get_compression_length`. \r\n","created_at":"2016-07-20T03:30:47Z","updated_at":"2016-07-20T03:30:47Z","html_url":"https://github.com/CUBRID/cubrid/pull/160#discussion_r71460671","pull_request_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments/71460671"},"html":{"href":"https://github.com/CUBRID/cubrid/pull/160#discussion_r71460671"},"pull_request":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/CUBRID/cubrid/pulls/160","id":77847544,"html_url":"https://github.com/CUBRID/cubrid/pull/160","diff_url":"https://github.com/CUBRID/cubrid/pull/160.diff","patch_url":"https://github.com/CUBRID/cubrid/pull/160.patch","issue_url":"https://api.github.com/repos/CUBRID/cubrid/issues/160","number":160,"state":"open","locked":false,"title":"[CBRD-20158] String compression","user":{"login":"lucianlazar2211","id":19164748,"avatar_url":"https://avatars.githubusercontent.com/u/19164748?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianlazar2211","html_url":"https://github.com/lucianlazar2211","followers_url":"https://api.github.com/users/lucianlazar2211/followers","following_url":"https://api.github.com/users/lucianlazar2211/following{/other_user}","gists_url":"https://api.github.com/users/lucianlazar2211/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianlazar2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianlazar2211/subscriptions","organizations_url":"https://api.github.com/users/lucianlazar2211/orgs","repos_url":"https://api.github.com/users/lucianlazar2211/repos","events_url":"https://api.github.com/users/lucianlazar2211/events{/privacy}","received_events_url":"https://api.github.com/users/lucianlazar2211/received_events","type":"User","site_admin":false},"body":"http://jira.cubrid.org/browse/CBRD-20158\r\n\r\nStrings are now saved on the disk in a compressed form, using the same compression function as the one used in the log compression. This is applied ,for now, to `VARCHAR` and `VARNCHAR` types. The compression is done before putting the strings in the `OR_BUF` buffer, more precisely in the `or_put_varchar_internal` function.\r\n\r\nThe current encoding for the `VARCHAR` and `VARNCHAR` types with size larger than `255 (0xFF)` : \r\n`[0xFF][4_bytes_compressed_data_size][4_bytes_decompressed_data_size][compressed_data]`.\r\n\r\nIf the string is supposed to be compressed, however its `compressed_size > original_size - 8`, then we set `compressed_size = -1`, and add to the buffer `decompressed_size` of the original data.\r\n\r\n\r\nThere is one regression that needs revision, and that is: `sql/_23_apricot_qa/_01_sql_extension3/_02_new_sql_types/_01_enum/cases/_18_adhoc_multiple.sql`.","created_at":"2016-07-18T17:39:15Z","updated_at":"2016-07-20T03:30:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c08b9a8296bd6a220439f944350dfce178b4a5f","assignee":{"login":"ribram","id":12672652,"avatar_url":"https://avatars.githubusercontent.com/u/12672652?v=3","gravatar_id":"","url":"https://api.github.com/users/ribram","html_url":"https://github.com/ribram","followers_url":"https://api.github.com/users/ribram/followers","following_url":"https://api.github.com/users/ribram/following{/other_user}","gists_url":"https://api.github.com/users/ribram/gists{/gist_id}","starred_url":"https://api.github.com/users/ribram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ribram/subscriptions","organizations_url":"https://api.github.com/users/ribram/orgs","repos_url":"https://api.github.com/users/ribram/repos","events_url":"https://api.github.com/users/ribram/events{/privacy}","received_events_url":"https://api.github.com/users/ribram/received_events","type":"User","site_admin":false},"assignees":[{"login":"ribram","id":12672652,"avatar_url":"https://avatars.githubusercontent.com/u/12672652?v=3","gravatar_id":"","url":"https://api.github.com/users/ribram","html_url":"https://github.com/ribram","followers_url":"https://api.github.com/users/ribram/followers","following_url":"https://api.github.com/users/ribram/following{/other_user}","gists_url":"https://api.github.com/users/ribram/gists{/gist_id}","starred_url":"https://api.github.com/users/ribram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ribram/subscriptions","organizations_url":"https://api.github.com/users/ribram/orgs","repos_url":"https://api.github.com/users/ribram/repos","events_url":"https://api.github.com/users/ribram/events{/privacy}","received_events_url":"https://api.github.com/users/ribram/received_events","type":"User","site_admin":false},{"login":"razvanradulescu","id":16611470,"avatar_url":"https://avatars.githubusercontent.com/u/16611470?v=3","gravatar_id":"","url":"https://api.github.com/users/razvanradulescu","html_url":"https://github.com/razvanradulescu","followers_url":"https://api.github.com/users/razvanradulescu/followers","following_url":"https://api.github.com/users/razvanradulescu/following{/other_user}","gists_url":"https://api.github.com/users/razvanradulescu/gists{/gist_id}","starred_url":"https://api.github.com/users/razvanradulescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/razvanradulescu/subscriptions","organizations_url":"https://api.github.com/users/razvanradulescu/orgs","repos_url":"https://api.github.com/users/razvanradulescu/repos","events_url":"https://api.github.com/users/razvanradulescu/events{/privacy}","received_events_url":"https://api.github.com/users/razvanradulescu/received_events","type":"User","site_admin":false},{"login":"eseokoh","id":17467172,"avatar_url":"https://avatars.githubusercontent.com/u/17467172?v=3","gravatar_id":"","url":"https://api.github.com/users/eseokoh","html_url":"https://github.com/eseokoh","followers_url":"https://api.github.com/users/eseokoh/followers","following_url":"https://api.github.com/users/eseokoh/following{/other_user}","gists_url":"https://api.github.com/users/eseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/eseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eseokoh/subscriptions","organizations_url":"https://api.github.com/users/eseokoh/orgs","repos_url":"https://api.github.com/users/eseokoh/repos","events_url":"https://api.github.com/users/eseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/eseokoh/received_events","type":"User","site_admin":false},{"login":"lucianlazar2211","id":19164748,"avatar_url":"https://avatars.githubusercontent.com/u/19164748?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianlazar2211","html_url":"https://github.com/lucianlazar2211","followers_url":"https://api.github.com/users/lucianlazar2211/followers","following_url":"https://api.github.com/users/lucianlazar2211/following{/other_user}","gists_url":"https://api.github.com/users/lucianlazar2211/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianlazar2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianlazar2211/subscriptions","organizations_url":"https://api.github.com/users/lucianlazar2211/orgs","repos_url":"https://api.github.com/users/lucianlazar2211/repos","events_url":"https://api.github.com/users/lucianlazar2211/events{/privacy}","received_events_url":"https://api.github.com/users/lucianlazar2211/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/160/commits","review_comments_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/160/comments","review_comment_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CUBRID/cubrid/issues/160/comments","statuses_url":"https://api.github.com/repos/CUBRID/cubrid/statuses/647e8e489a0fc618c69c953f78a530455ebadc55","head":{"label":"lucianlazar2211:CBRD-20158-string-compress","ref":"CBRD-20158-string-compress","sha":"647e8e489a0fc618c69c953f78a530455ebadc55","user":{"login":"lucianlazar2211","id":19164748,"avatar_url":"https://avatars.githubusercontent.com/u/19164748?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianlazar2211","html_url":"https://github.com/lucianlazar2211","followers_url":"https://api.github.com/users/lucianlazar2211/followers","following_url":"https://api.github.com/users/lucianlazar2211/following{/other_user}","gists_url":"https://api.github.com/users/lucianlazar2211/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianlazar2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianlazar2211/subscriptions","organizations_url":"https://api.github.com/users/lucianlazar2211/orgs","repos_url":"https://api.github.com/users/lucianlazar2211/repos","events_url":"https://api.github.com/users/lucianlazar2211/events{/privacy}","received_events_url":"https://api.github.com/users/lucianlazar2211/received_events","type":"User","site_admin":false},"repo":{"id":57952979,"name":"cubrid","full_name":"lucianlazar2211/cubrid","owner":{"login":"lucianlazar2211","id":19164748,"avatar_url":"https://avatars.githubusercontent.com/u/19164748?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianlazar2211","html_url":"https://github.com/lucianlazar2211","followers_url":"https://api.github.com/users/lucianlazar2211/followers","following_url":"https://api.github.com/users/lucianlazar2211/following{/other_user}","gists_url":"https://api.github.com/users/lucianlazar2211/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianlazar2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianlazar2211/subscriptions","organizations_url":"https://api.github.com/users/lucianlazar2211/orgs","repos_url":"https://api.github.com/users/lucianlazar2211/repos","events_url":"https://api.github.com/users/lucianlazar2211/events{/privacy}","received_events_url":"https://api.github.com/users/lucianlazar2211/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucianlazar2211/cubrid","description":"CUBRID is a comprehensive open source relational database management system highly optimized for Web Applications.","fork":true,"url":"https://api.github.com/repos/lucianlazar2211/cubrid","forks_url":"https://api.github.com/repos/lucianlazar2211/cubrid/forks","keys_url":"https://api.github.com/repos/lucianlazar2211/cubrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucianlazar2211/cubrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucianlazar2211/cubrid/teams","hooks_url":"https://api.github.com/repos/lucianlazar2211/cubrid/hooks","issue_events_url":"https://api.github.com/repos/lucianlazar2211/cubrid/issues/events{/number}","events_url":"https://api.github.com/repos/lucianlazar2211/cubrid/events","assignees_url":"https://api.github.com/repos/lucianlazar2211/cubrid/assignees{/user}","branches_url":"https://api.github.com/repos/lucianlazar2211/cubrid/branches{/branch}","tags_url":"https://api.github.com/repos/lucianlazar2211/cubrid/tags","blobs_url":"https://api.github.com/repos/lucianlazar2211/cubrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucianlazar2211/cubrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucianlazar2211/cubrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucianlazar2211/cubrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucianlazar2211/cubrid/statuses/{sha}","languages_url":"https://api.github.com/repos/lucianlazar2211/cubrid/languages","stargazers_url":"https://api.github.com/repos/lucianlazar2211/cubrid/stargazers","contributors_url":"https://api.github.com/repos/lucianlazar2211/cubrid/contributors","subscribers_url":"https://api.github.com/repos/lucianlazar2211/cubrid/subscribers","subscription_url":"https://api.github.com/repos/lucianlazar2211/cubrid/subscription","commits_url":"https://api.github.com/repos/lucianlazar2211/cubrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucianlazar2211/cubrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucianlazar2211/cubrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucianlazar2211/cubrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucianlazar2211/cubrid/contents/{+path}","compare_url":"https://api.github.com/repos/lucianlazar2211/cubrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucianlazar2211/cubrid/merges","archive_url":"https://api.github.com/repos/lucianlazar2211/cubrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucianlazar2211/cubrid/downloads","issues_url":"https://api.github.com/repos/lucianlazar2211/cubrid/issues{/number}","pulls_url":"https://api.github.com/repos/lucianlazar2211/cubrid/pulls{/number}","milestones_url":"https://api.github.com/repos/lucianlazar2211/cubrid/milestones{/number}","notifications_url":"https://api.github.com/repos/lucianlazar2211/cubrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucianlazar2211/cubrid/labels{/name}","releases_url":"https://api.github.com/repos/lucianlazar2211/cubrid/releases{/id}","deployments_url":"https://api.github.com/repos/lucianlazar2211/cubrid/deployments","created_at":"2016-05-03T08:16:51Z","updated_at":"2016-05-03T08:17:06Z","pushed_at":"2016-07-19T11:20:11Z","git_url":"git://github.com/lucianlazar2211/cubrid.git","ssh_url":"git@github.com:lucianlazar2211/cubrid.git","clone_url":"https://github.com/lucianlazar2211/cubrid.git","svn_url":"https://github.com/lucianlazar2211/cubrid","homepage":"http://www.cubrid.org","size":167824,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"CUBRID:develop","ref":"develop","sha":"e726f995cb8fe7fc6e1a56be8e65f6272bcc28fd","user":{"login":"CUBRID","id":358322,"avatar_url":"https://avatars.githubusercontent.com/u/358322?v=3","gravatar_id":"","url":"https://api.github.com/users/CUBRID","html_url":"https://github.com/CUBRID","followers_url":"https://api.github.com/users/CUBRID/followers","following_url":"https://api.github.com/users/CUBRID/following{/other_user}","gists_url":"https://api.github.com/users/CUBRID/gists{/gist_id}","starred_url":"https://api.github.com/users/CUBRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUBRID/subscriptions","organizations_url":"https://api.github.com/users/CUBRID/orgs","repos_url":"https://api.github.com/users/CUBRID/repos","events_url":"https://api.github.com/users/CUBRID/events{/privacy}","received_events_url":"https://api.github.com/users/CUBRID/received_events","type":"Organization","site_admin":false},"repo":{"id":52080367,"name":"cubrid","full_name":"CUBRID/cubrid","owner":{"login":"CUBRID","id":358322,"avatar_url":"https://avatars.githubusercontent.com/u/358322?v=3","gravatar_id":"","url":"https://api.github.com/users/CUBRID","html_url":"https://github.com/CUBRID","followers_url":"https://api.github.com/users/CUBRID/followers","following_url":"https://api.github.com/users/CUBRID/following{/other_user}","gists_url":"https://api.github.com/users/CUBRID/gists{/gist_id}","starred_url":"https://api.github.com/users/CUBRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUBRID/subscriptions","organizations_url":"https://api.github.com/users/CUBRID/orgs","repos_url":"https://api.github.com/users/CUBRID/repos","events_url":"https://api.github.com/users/CUBRID/events{/privacy}","received_events_url":"https://api.github.com/users/CUBRID/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CUBRID/cubrid","description":"CUBRID is a comprehensive open source relational database management system highly optimized for Web Applications.","fork":false,"url":"https://api.github.com/repos/CUBRID/cubrid","forks_url":"https://api.github.com/repos/CUBRID/cubrid/forks","keys_url":"https://api.github.com/repos/CUBRID/cubrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CUBRID/cubrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CUBRID/cubrid/teams","hooks_url":"https://api.github.com/repos/CUBRID/cubrid/hooks","issue_events_url":"https://api.github.com/repos/CUBRID/cubrid/issues/events{/number}","events_url":"https://api.github.com/repos/CUBRID/cubrid/events","assignees_url":"https://api.github.com/repos/CUBRID/cubrid/assignees{/user}","branches_url":"https://api.github.com/repos/CUBRID/cubrid/branches{/branch}","tags_url":"https://api.github.com/repos/CUBRID/cubrid/tags","blobs_url":"https://api.github.com/repos/CUBRID/cubrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CUBRID/cubrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CUBRID/cubrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/CUBRID/cubrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CUBRID/cubrid/statuses/{sha}","languages_url":"https://api.github.com/repos/CUBRID/cubrid/languages","stargazers_url":"https://api.github.com/repos/CUBRID/cubrid/stargazers","contributors_url":"https://api.github.com/repos/CUBRID/cubrid/contributors","subscribers_url":"https://api.github.com/repos/CUBRID/cubrid/subscribers","subscription_url":"https://api.github.com/repos/CUBRID/cubrid/subscription","commits_url":"https://api.github.com/repos/CUBRID/cubrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/CUBRID/cubrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/CUBRID/cubrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/CUBRID/cubrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/CUBRID/cubrid/contents/{+path}","compare_url":"https://api.github.com/repos/CUBRID/cubrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CUBRID/cubrid/merges","archive_url":"https://api.github.com/repos/CUBRID/cubrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CUBRID/cubrid/downloads","issues_url":"https://api.github.com/repos/CUBRID/cubrid/issues{/number}","pulls_url":"https://api.github.com/repos/CUBRID/cubrid/pulls{/number}","milestones_url":"https://api.github.com/repos/CUBRID/cubrid/milestones{/number}","notifications_url":"https://api.github.com/repos/CUBRID/cubrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CUBRID/cubrid/labels{/name}","releases_url":"https://api.github.com/repos/CUBRID/cubrid/releases{/id}","deployments_url":"https://api.github.com/repos/CUBRID/cubrid/deployments","created_at":"2016-02-19T10:25:32Z","updated_at":"2016-07-12T14:28:43Z","pushed_at":"2016-07-19T15:58:14Z","git_url":"git://github.com/CUBRID/cubrid.git","ssh_url":"git@github.com:CUBRID/cubrid.git","clone_url":"https://github.com/CUBRID/cubrid.git","svn_url":"https://github.com/CUBRID/cubrid","homepage":"http://www.cubrid.org","size":169684,"stargazers_count":15,"watchers_count":15,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/160"},"html":{"href":"https://github.com/CUBRID/cubrid/pull/160"},"issue":{"href":"https://api.github.com/repos/CUBRID/cubrid/issues/160"},"comments":{"href":"https://api.github.com/repos/CUBRID/cubrid/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/CUBRID/cubrid/statuses/647e8e489a0fc618c69c953f78a530455ebadc55"}}}}
{"actor":{"display_login":"eseokoh"}}