{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/81944246","pull_request_review_id":2885657,"id":81944246,"diff_hunk":"@@ -97,12 +98,34 @@ class GetUrlsTest : public CommandsTest<CommandsTestMocks::kIsNice> {\n         utils::MakeShared<policy_manager_test::MockPolicyManager>();\n     ASSERT_TRUE(mock_policy_manager_);\n   }\n+\n+  MessageSharedPtr CreateCommandMsg() {\n+    MessageSharedPtr command_msg(\n+        CreateMessage(NsSmartDeviceLink::NsSmartObjects::SmartType_Map));\n+    (*command_msg)[am::strings::params][am::strings::connection_key] =\n+        kConnectionKey;\n+    (*command_msg)[am::strings::msg_params][am::hmi_request::service] =\n+        kPolicyService;\n+\n+    return command_msg;\n+  }\n+\n+  RequestFromHMIPtr PrepareRunFlowAndCreateCommandRequestFromHMI(\n+      MessageSharedPtr command_msg) {\n+    ON_CALL(mock_app_manager_, event_dispatcher())","path":"src/components/application_manager/test/commands/hmi/get_urls_test.cc","position":26,"original_position":26,"commit_id":"269d8754ad40f402ac4004124f8cf75a4af8d087","original_commit_id":"269d8754ad40f402ac4004124f8cf75a4af8d087","user":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"body":"@dcherniev, please derive `GetUrlsTest` from `CommandRequestTest` \r\nIt provide `ON_CALL` for `event_dispatcher` and `mock_event_dispatcher_`\r\n\r\n-\r\nAlso, if you will set command and message as a members of `GetUrlsTest`, you can move all actions form `CreateCommandMsg()` into constructor.","created_at":"2016-10-05T10:32:49Z","updated_at":"2016-10-05T10:36:18Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/862#discussion_r81944246","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/81944246"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/862#discussion_r81944246"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862","id":87516737,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/862","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/862.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/862.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/862","number":862,"state":"open","locked":false,"title":"Completely cover commands with unit tests","user":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"body":"Covered code lines for following files:\r\n - navi_is_ready_response;\r\n - dial_number_request;\r\n - get_urls;\r\n - perform_audio_pass_thru_request;\r\n - show_constant_tbt_request.\r\n\r\nRelated task : APPLINK-28075","created_at":"2016-09-30T15:38:06Z","updated_at":"2016-10-05T11:00:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61b922f6ceb2c8b2d93a349ab36fe76ec7e21ba3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/862/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/269d8754ad40f402ac4004124f8cf75a4af8d087","head":{"label":"dcherniev:feature/Fully_cover_commands_with_unit_tests","ref":"feature/Fully_cover_commands_with_unit_tests","sha":"269d8754ad40f402ac4004124f8cf75a4af8d087","user":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"repo":{"id":69333178,"name":"sdl_core","full_name":"dcherniev/sdl_core","owner":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcherniev/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/dcherniev/sdl_core","forks_url":"https://api.github.com/repos/dcherniev/sdl_core/forks","keys_url":"https://api.github.com/repos/dcherniev/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcherniev/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcherniev/sdl_core/teams","hooks_url":"https://api.github.com/repos/dcherniev/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/dcherniev/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/dcherniev/sdl_core/events","assignees_url":"https://api.github.com/repos/dcherniev/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/dcherniev/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/dcherniev/sdl_core/tags","blobs_url":"https://api.github.com/repos/dcherniev/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcherniev/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcherniev/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcherniev/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcherniev/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/dcherniev/sdl_core/languages","stargazers_url":"https://api.github.com/repos/dcherniev/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/dcherniev/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/dcherniev/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/dcherniev/sdl_core/subscription","commits_url":"https://api.github.com/repos/dcherniev/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcherniev/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcherniev/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcherniev/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcherniev/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/dcherniev/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcherniev/sdl_core/merges","archive_url":"https://api.github.com/repos/dcherniev/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcherniev/sdl_core/downloads","issues_url":"https://api.github.com/repos/dcherniev/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/dcherniev/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/dcherniev/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/dcherniev/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcherniev/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/dcherniev/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/dcherniev/sdl_core/deployments","created_at":"2016-09-27T07:59:09Z","updated_at":"2016-09-27T07:59:18Z","pushed_at":"2016-10-04T15:03:23Z","git_url":"git://github.com/dcherniev/sdl_core.git","ssh_url":"git@github.com:dcherniev/sdl_core.git","clone_url":"https://github.com/dcherniev/sdl_core.git","svn_url":"https://github.com/dcherniev/sdl_core","homepage":"","size":176955,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"306aa7dd448e5c52679eb07fe2aeffe8aeb30eae","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-09-29T03:18:39Z","pushed_at":"2016-10-05T10:32:46Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":313109,"stargazers_count":79,"watchers_count":79,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":95,"forks":99,"open_issues":95,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/862"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/862"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/862/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/862/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/269d8754ad40f402ac4004124f8cf75a4af8d087"}}}}
{"actor":{"display_login":"LevchenkoS"}}