{"action":"created","comment":{"url":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/comments/60003516","id":60003516,"diff_hunk":"@@ -1591,7 +1591,7 @@ INDEX Particles_Regeneration(CEntity *pen, FLOAT tmStart, FLOAT tmStop, FLOAT fY\n     \n     UBYTE ubR = (UBYTE) (192+afStarsPositions[iRnd][1]*64);\n     UBYTE ubG = (UBYTE) (192+afStarsPositions[iRnd][2]*64);\n-    UBYTE ubB = (UBYTE) (192+afStarsPositions[iRnd][3]*64);\n+    UBYTE ubB = (UBYTE) (192+afStarsPositions[iRnd][3]*64); // FIXME DG: afStarsPositions[i][3] invalid, what's going on here?","path":"Sources/EntitiesMP/Common/Particles.cpp","position":5,"original_position":5,"commit_id":"78ab018fdef55cef1b455ce4249b9fa4371b28d8","original_commit_id":"a358a1763f8f66074dccc7fe1210239b681fcd78","user":{"login":"rcgordon","id":673562,"avatar_url":"https://avatars.githubusercontent.com/u/673562?v=3","gravatar_id":"","url":"https://api.github.com/users/rcgordon","html_url":"https://github.com/rcgordon","followers_url":"https://api.github.com/users/rcgordon/followers","following_url":"https://api.github.com/users/rcgordon/following{/other_user}","gists_url":"https://api.github.com/users/rcgordon/gists{/gist_id}","starred_url":"https://api.github.com/users/rcgordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcgordon/subscriptions","organizations_url":"https://api.github.com/users/rcgordon/orgs","repos_url":"https://api.github.com/users/rcgordon/repos","events_url":"https://api.github.com/users/rcgordon/events{/privacy}","received_events_url":"https://api.github.com/users/rcgordon/received_events","type":"User","site_admin":false},"body":"I saw Clang fire this warning, too...I think this is a bug in the original code, and these should have counted from 0 to 2, not 1 to 3, but that's just a guess.","created_at":"2016-04-18T03:48:44Z","updated_at":"2016-04-18T03:48:44Z","html_url":"https://github.com/rcgordon/Serious-Engine/pull/26#discussion_r60003516","pull_request_url":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/comments/60003516"},"html":{"href":"https://github.com/rcgordon/Serious-Engine/pull/26#discussion_r60003516"},"pull_request":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26","id":66785828,"html_url":"https://github.com/rcgordon/Serious-Engine/pull/26","diff_url":"https://github.com/rcgordon/Serious-Engine/pull/26.diff","patch_url":"https://github.com/rcgordon/Serious-Engine/pull/26.patch","issue_url":"https://api.github.com/repos/rcgordon/Serious-Engine/issues/26","number":26,"state":"open","locked":false,"title":"Some 64bit improvements, lots of 64bit TODOs/STUBBED()","user":{"login":"DanielGibson","id":1216493,"avatar_url":"https://avatars.githubusercontent.com/u/1216493?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielGibson","html_url":"https://github.com/DanielGibson","followers_url":"https://api.github.com/users/DanielGibson/followers","following_url":"https://api.github.com/users/DanielGibson/following{/other_user}","gists_url":"https://api.github.com/users/DanielGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielGibson/subscriptions","organizations_url":"https://api.github.com/users/DanielGibson/orgs","repos_url":"https://api.github.com/users/DanielGibson/repos","events_url":"https://api.github.com/users/DanielGibson/events{/privacy}","received_events_url":"https://api.github.com/users/DanielGibson/received_events","type":"User","site_admin":false},"body":"This should fix some more 64bit issues.\r\n\r\nI also added some more FIXMEs and STUBBED(\"64-but issue\") where the compiler gave me corresponding warnings.\r\n\r\nI was able to play the complete first level of the second encounter, however I think there's still a lot missing.\r\n\r\n\r\nDoes anyone know what `CShell::GetINDEX()` is about? Its return value often is casted to pointer and dereferenced directly afterwards (e.g. in Engine/Network/Network.cpp `CacheShadows()`; I didn't mark all occurences in the code).\r\nIs there some kind of trick (like in `ModelPolygonVertex::Read_t()` where the \"pointers\" are actually indexes that are later converted back to pointers) that I'm missing? I'm surprised that INDEX is used to store a pointer there, not ULONG like in several other places..\r\n","created_at":"2016-04-17T23:44:52Z","updated_at":"2016-04-18T03:48:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"954fcf113a8ec857cbbf06860368078407d8a3ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26/commits","review_comments_url":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26/comments","review_comment_url":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcgordon/Serious-Engine/issues/26/comments","statuses_url":"https://api.github.com/repos/rcgordon/Serious-Engine/statuses/78ab018fdef55cef1b455ce4249b9fa4371b28d8","head":{"label":"DanielGibson:64bit-stuff","ref":"64bit-stuff","sha":"78ab018fdef55cef1b455ce4249b9fa4371b28d8","user":{"login":"DanielGibson","id":1216493,"avatar_url":"https://avatars.githubusercontent.com/u/1216493?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielGibson","html_url":"https://github.com/DanielGibson","followers_url":"https://api.github.com/users/DanielGibson/followers","following_url":"https://api.github.com/users/DanielGibson/following{/other_user}","gists_url":"https://api.github.com/users/DanielGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielGibson/subscriptions","organizations_url":"https://api.github.com/users/DanielGibson/orgs","repos_url":"https://api.github.com/users/DanielGibson/repos","events_url":"https://api.github.com/users/DanielGibson/events{/privacy}","received_events_url":"https://api.github.com/users/DanielGibson/received_events","type":"User","site_admin":false},"repo":{"id":56410245,"name":"Serious-Engine","full_name":"DanielGibson/Serious-Engine","owner":{"login":"DanielGibson","id":1216493,"avatar_url":"https://avatars.githubusercontent.com/u/1216493?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielGibson","html_url":"https://github.com/DanielGibson","followers_url":"https://api.github.com/users/DanielGibson/followers","following_url":"https://api.github.com/users/DanielGibson/following{/other_user}","gists_url":"https://api.github.com/users/DanielGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielGibson/subscriptions","organizations_url":"https://api.github.com/users/DanielGibson/orgs","repos_url":"https://api.github.com/users/DanielGibson/repos","events_url":"https://api.github.com/users/DanielGibson/events{/privacy}","received_events_url":"https://api.github.com/users/DanielGibson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanielGibson/Serious-Engine","description":"An open source version of a game engine developed by Croteam for the classic Serious Sam games.","fork":true,"url":"https://api.github.com/repos/DanielGibson/Serious-Engine","forks_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/forks","keys_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/teams","hooks_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/hooks","issue_events_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/events","assignees_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/tags","blobs_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/languages","stargazers_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/stargazers","contributors_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/contributors","subscribers_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/subscribers","subscription_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/subscription","commits_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/merges","archive_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/downloads","issues_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/labels{/name}","releases_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/releases{/id}","deployments_url":"https://api.github.com/repos/DanielGibson/Serious-Engine/deployments","created_at":"2016-04-16T23:28:52Z","updated_at":"2016-04-16T23:29:00Z","pushed_at":"2016-04-17T22:56:46Z","git_url":"git://github.com/DanielGibson/Serious-Engine.git","ssh_url":"git@github.com:DanielGibson/Serious-Engine.git","clone_url":"https://github.com/DanielGibson/Serious-Engine.git","svn_url":"https://github.com/DanielGibson/Serious-Engine","homepage":null,"size":95784,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rcgordon:master","ref":"master","sha":"aaba5758568c0546dd0b8a471fb42e567827ac68","user":{"login":"rcgordon","id":673562,"avatar_url":"https://avatars.githubusercontent.com/u/673562?v=3","gravatar_id":"","url":"https://api.github.com/users/rcgordon","html_url":"https://github.com/rcgordon","followers_url":"https://api.github.com/users/rcgordon/followers","following_url":"https://api.github.com/users/rcgordon/following{/other_user}","gists_url":"https://api.github.com/users/rcgordon/gists{/gist_id}","starred_url":"https://api.github.com/users/rcgordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcgordon/subscriptions","organizations_url":"https://api.github.com/users/rcgordon/orgs","repos_url":"https://api.github.com/users/rcgordon/repos","events_url":"https://api.github.com/users/rcgordon/events{/privacy}","received_events_url":"https://api.github.com/users/rcgordon/received_events","type":"User","site_admin":false},"repo":{"id":53692949,"name":"Serious-Engine","full_name":"rcgordon/Serious-Engine","owner":{"login":"rcgordon","id":673562,"avatar_url":"https://avatars.githubusercontent.com/u/673562?v=3","gravatar_id":"","url":"https://api.github.com/users/rcgordon","html_url":"https://github.com/rcgordon","followers_url":"https://api.github.com/users/rcgordon/followers","following_url":"https://api.github.com/users/rcgordon/following{/other_user}","gists_url":"https://api.github.com/users/rcgordon/gists{/gist_id}","starred_url":"https://api.github.com/users/rcgordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcgordon/subscriptions","organizations_url":"https://api.github.com/users/rcgordon/orgs","repos_url":"https://api.github.com/users/rcgordon/repos","events_url":"https://api.github.com/users/rcgordon/events{/privacy}","received_events_url":"https://api.github.com/users/rcgordon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rcgordon/Serious-Engine","description":"An open source version of a game engine developed by Croteam for the classic Serious Sam games.","fork":true,"url":"https://api.github.com/repos/rcgordon/Serious-Engine","forks_url":"https://api.github.com/repos/rcgordon/Serious-Engine/forks","keys_url":"https://api.github.com/repos/rcgordon/Serious-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcgordon/Serious-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcgordon/Serious-Engine/teams","hooks_url":"https://api.github.com/repos/rcgordon/Serious-Engine/hooks","issue_events_url":"https://api.github.com/repos/rcgordon/Serious-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/rcgordon/Serious-Engine/events","assignees_url":"https://api.github.com/repos/rcgordon/Serious-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/rcgordon/Serious-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/rcgordon/Serious-Engine/tags","blobs_url":"https://api.github.com/repos/rcgordon/Serious-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcgordon/Serious-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcgordon/Serious-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcgordon/Serious-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcgordon/Serious-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/rcgordon/Serious-Engine/languages","stargazers_url":"https://api.github.com/repos/rcgordon/Serious-Engine/stargazers","contributors_url":"https://api.github.com/repos/rcgordon/Serious-Engine/contributors","subscribers_url":"https://api.github.com/repos/rcgordon/Serious-Engine/subscribers","subscription_url":"https://api.github.com/repos/rcgordon/Serious-Engine/subscription","commits_url":"https://api.github.com/repos/rcgordon/Serious-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcgordon/Serious-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcgordon/Serious-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcgordon/Serious-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcgordon/Serious-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/rcgordon/Serious-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcgordon/Serious-Engine/merges","archive_url":"https://api.github.com/repos/rcgordon/Serious-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcgordon/Serious-Engine/downloads","issues_url":"https://api.github.com/repos/rcgordon/Serious-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/rcgordon/Serious-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/rcgordon/Serious-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcgordon/Serious-Engine/labels{/name}","releases_url":"https://api.github.com/repos/rcgordon/Serious-Engine/releases{/id}","deployments_url":"https://api.github.com/repos/rcgordon/Serious-Engine/deployments","created_at":"2016-03-11T19:53:39Z","updated_at":"2016-04-15T04:33:59Z","pushed_at":"2016-04-17T23:44:52Z","git_url":"git://github.com/rcgordon/Serious-Engine.git","ssh_url":"git@github.com:rcgordon/Serious-Engine.git","clone_url":"https://github.com/rcgordon/Serious-Engine.git","svn_url":"https://github.com/rcgordon/Serious-Engine","homepage":null,"size":95773,"stargazers_count":57,"watchers_count":57,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26"},"html":{"href":"https://github.com/rcgordon/Serious-Engine/pull/26"},"issue":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/issues/26"},"comments":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/rcgordon/Serious-Engine/statuses/78ab018fdef55cef1b455ce4249b9fa4371b28d8"}}}}