{"action":"created","issue":{"url":"https://api.github.com/repos/webcom-components/reach/issues/74","repository_url":"https://api.github.com/repos/webcom-components/reach","labels_url":"https://api.github.com/repos/webcom-components/reach/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/webcom-components/reach/issues/74/comments","events_url":"https://api.github.com/repos/webcom-components/reach/issues/74/events","html_url":"https://github.com/webcom-components/reach/pull/74","id":147225055,"number":74,"title":"SDK changes for orange together","user":{"login":"mennakatkout","id":12731670,"avatar_url":"https://avatars.githubusercontent.com/u/12731670?v=3","gravatar_id":"","url":"https://api.github.com/users/mennakatkout","html_url":"https://github.com/mennakatkout","followers_url":"https://api.github.com/users/mennakatkout/followers","following_url":"https://api.github.com/users/mennakatkout/following{/other_user}","gists_url":"https://api.github.com/users/mennakatkout/gists{/gist_id}","starred_url":"https://api.github.com/users/mennakatkout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mennakatkout/subscriptions","organizations_url":"https://api.github.com/users/mennakatkout/orgs","repos_url":"https://api.github.com/users/mennakatkout/repos","events_url":"https://api.github.com/users/mennakatkout/events{/privacy}","received_events_url":"https://api.github.com/users/mennakatkout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-10T13:27:52Z","updated_at":"2016-04-18T12:45:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webcom-components/reach/pulls/74","html_url":"https://github.com/webcom-components/reach/pull/74","diff_url":"https://github.com/webcom-components/reach/pull/74.diff","patch_url":"https://github.com/webcom-components/reach/pull/74.patch"},"body":"Following changes\r\n:1- Flow subscription/unsubscription process: fixed a bug when closing room and removing video, Mathieu modifications for orange together\r\n2- webRTC object: it is now properly initialized, so that on closing, the object isnot null\r\n3- when closing local stream the video is properly stopped in case of streamAudioVideo\r\n4- fix muting video stream\r\n5- when ice state connection changes to failed or disconnected, we don't terminate the connection through closing webrtc in order for the stream to reconnect upon failure\r\n6- Muting my video will occur for all participants after a person has rejoined the room"},"comment":{"url":"https://api.github.com/repos/webcom-components/reach/issues/comments/211365207","html_url":"https://github.com/webcom-components/reach/pull/74#issuecomment-211365207","issue_url":"https://api.github.com/repos/webcom-components/reach/issues/74","id":211365207,"user":{"login":"juliendelage","id":15608934,"avatar_url":"https://avatars.githubusercontent.com/u/15608934?v=3","gravatar_id":"","url":"https://api.github.com/users/juliendelage","html_url":"https://github.com/juliendelage","followers_url":"https://api.github.com/users/juliendelage/followers","following_url":"https://api.github.com/users/juliendelage/following{/other_user}","gists_url":"https://api.github.com/users/juliendelage/gists{/gist_id}","starred_url":"https://api.github.com/users/juliendelage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliendelage/subscriptions","organizations_url":"https://api.github.com/users/juliendelage/orgs","repos_url":"https://api.github.com/users/juliendelage/repos","events_url":"https://api.github.com/users/juliendelage/events{/privacy}","received_events_url":"https://api.github.com/users/juliendelage/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T12:45:28Z","updated_at":"2016-04-18T12:45:28Z","body":"Hi,\r\n\r\nWe can't accept your Pull Request as is because of the following reasons:\r\n\r\n- The `.gitignore` file should not be modified and even less when adding `dist/` to it. It will break the publish mecanism.\r\n- The content of the `dist/` folder should not be commited (it's automatically pushed by travis when merged with the main branch)\r\n- The changes to the git hooks in the `package.json` file should not be commited. The tests for the git gooks are here to prevent the hooks under travis.\r\n- Two commits with the same message, and a message containing several changes. Please edit your commits. Either a commit per change (preferred) or review your message and merge the 2 commits. Be aware that you commit messages will appear in the [release description](https://github.com/webcom-components/reach/releases)."}}