{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/65988903","id":65988903,"diff_hunk":"@@ -61,14 +82,26 @@\n \n     private Parser parser;\n \n-    private FederationAdminService federationAdmin;\n+    private CatalogFramework catalogFramework;\n+\n+    private FilterBuilder filterBuilder;\n \n     private ParserConfigurator marshalConfigurator;\n \n     private ParserConfigurator unmarshalConfigurator;\n \n     private Set<String> registryIds = ConcurrentHashMap.newKeySet();\n \n+    private static final Logger LOGGER = LoggerFactory.getLogger(IdentificationPlugin.class);","path":"catalog/spatial/registry/registry-identification-plugin/src/main/java/org/codice/ddf/registry/identification/IdentificationPlugin.java","position":91,"original_position":91,"commit_id":"70c1957feebf969e04a9e5b526c97a65856884ff","original_commit_id":"70c1957feebf969e04a9e5b526c97a65856884ff","user":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"body":"I don't see any of these private static variables being used. Were you planning on adding them in a different PR or can they be removed?","created_at":"2016-06-06T23:42:11Z","updated_at":"2016-06-06T23:42:11Z","html_url":"https://github.com/codice/ddf/pull/806#discussion_r65988903","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/806","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/65988903"},"html":{"href":"https://github.com/codice/ddf/pull/806#discussion_r65988903"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/806"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/806","id":71141889,"html_url":"https://github.com/codice/ddf/pull/806","diff_url":"https://github.com/codice/ddf/pull/806.diff","patch_url":"https://github.com/codice/ddf/pull/806.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/806","number":806,"state":"open","locked":false,"title":"DDF-1937 Merge updated identification plugin from ddf-registry to ddf","user":{"login":"mcalcote","id":11355332,"avatar_url":"https://avatars.githubusercontent.com/u/11355332?v=3","gravatar_id":"","url":"https://api.github.com/users/mcalcote","html_url":"https://github.com/mcalcote","followers_url":"https://api.github.com/users/mcalcote/followers","following_url":"https://api.github.com/users/mcalcote/following{/other_user}","gists_url":"https://api.github.com/users/mcalcote/gists{/gist_id}","starred_url":"https://api.github.com/users/mcalcote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcalcote/subscriptions","organizations_url":"https://api.github.com/users/mcalcote/orgs","repos_url":"https://api.github.com/users/mcalcote/repos","events_url":"https://api.github.com/users/mcalcote/events{/privacy}","received_events_url":"https://api.github.com/users/mcalcote/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThe identification plugin has been updated during development on the ddf-registry branch. This pr brings those changes over to the codice ddf code base. Test coverage has been improved and functionality changes have been made to fix bugs and improve performance. \r\n\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@spearskw @harrison-tarr \r\n\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@figliold \r\n@shaundmorris \r\n\r\n#### How should this be tested?\r\nBuild, run itests.\r\n\r\n#### Any background context you want to provide?\r\nThe test coverage took a significant dip during revision has been improved over that ratio, not the ratio from when ddf-registry split from ddf.\r\n\r\n#### What are the relevant tickets?\r\nDDF-2103 Update unit tests\r\nDDF-2058 Remove dependency on admin service\r\nDDF-2014 Update to preserve local transient attributes\r\n\r\n#### Screenshots (if appropriate)\r\nBackend only\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [x] Update / Add Unit Tests\r\n- [x] Update / Add Integration Tests","created_at":"2016-05-24T00:35:03Z","updated_at":"2016-06-06T23:42:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0ed422d2fba11b8cdb79cde3c3798cf704871df","assignee":{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/806/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/806/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/806/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/70c1957feebf969e04a9e5b526c97a65856884ff","head":{"label":"mcalcote:DDF-1937","ref":"DDF-1937","sha":"70c1957feebf969e04a9e5b526c97a65856884ff","user":{"login":"mcalcote","id":11355332,"avatar_url":"https://avatars.githubusercontent.com/u/11355332?v=3","gravatar_id":"","url":"https://api.github.com/users/mcalcote","html_url":"https://github.com/mcalcote","followers_url":"https://api.github.com/users/mcalcote/followers","following_url":"https://api.github.com/users/mcalcote/following{/other_user}","gists_url":"https://api.github.com/users/mcalcote/gists{/gist_id}","starred_url":"https://api.github.com/users/mcalcote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcalcote/subscriptions","organizations_url":"https://api.github.com/users/mcalcote/orgs","repos_url":"https://api.github.com/users/mcalcote/repos","events_url":"https://api.github.com/users/mcalcote/events{/privacy}","received_events_url":"https://api.github.com/users/mcalcote/received_events","type":"User","site_admin":false},"repo":{"id":50143494,"name":"ddf","full_name":"mcalcote/ddf","owner":{"login":"mcalcote","id":11355332,"avatar_url":"https://avatars.githubusercontent.com/u/11355332?v=3","gravatar_id":"","url":"https://api.github.com/users/mcalcote","html_url":"https://github.com/mcalcote","followers_url":"https://api.github.com/users/mcalcote/followers","following_url":"https://api.github.com/users/mcalcote/following{/other_user}","gists_url":"https://api.github.com/users/mcalcote/gists{/gist_id}","starred_url":"https://api.github.com/users/mcalcote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcalcote/subscriptions","organizations_url":"https://api.github.com/users/mcalcote/orgs","repos_url":"https://api.github.com/users/mcalcote/repos","events_url":"https://api.github.com/users/mcalcote/events{/privacy}","received_events_url":"https://api.github.com/users/mcalcote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcalcote/ddf","description":"The Distributed Data Framework - Federated Open Geospatial Consortium (OGC) filter powered metadata catalog with SAML Web SSO secured container","fork":true,"url":"https://api.github.com/repos/mcalcote/ddf","forks_url":"https://api.github.com/repos/mcalcote/ddf/forks","keys_url":"https://api.github.com/repos/mcalcote/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcalcote/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcalcote/ddf/teams","hooks_url":"https://api.github.com/repos/mcalcote/ddf/hooks","issue_events_url":"https://api.github.com/repos/mcalcote/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/mcalcote/ddf/events","assignees_url":"https://api.github.com/repos/mcalcote/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/mcalcote/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/mcalcote/ddf/tags","blobs_url":"https://api.github.com/repos/mcalcote/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcalcote/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcalcote/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcalcote/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcalcote/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/mcalcote/ddf/languages","stargazers_url":"https://api.github.com/repos/mcalcote/ddf/stargazers","contributors_url":"https://api.github.com/repos/mcalcote/ddf/contributors","subscribers_url":"https://api.github.com/repos/mcalcote/ddf/subscribers","subscription_url":"https://api.github.com/repos/mcalcote/ddf/subscription","commits_url":"https://api.github.com/repos/mcalcote/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcalcote/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcalcote/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcalcote/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcalcote/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/mcalcote/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcalcote/ddf/merges","archive_url":"https://api.github.com/repos/mcalcote/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcalcote/ddf/downloads","issues_url":"https://api.github.com/repos/mcalcote/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/mcalcote/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/mcalcote/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/mcalcote/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcalcote/ddf/labels{/name}","releases_url":"https://api.github.com/repos/mcalcote/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/mcalcote/ddf/deployments","created_at":"2016-01-21T23:19:10Z","updated_at":"2016-01-21T23:19:21Z","pushed_at":"2016-06-06T21:01:24Z","git_url":"git://github.com/mcalcote/ddf.git","ssh_url":"git@github.com:mcalcote/ddf.git","clone_url":"https://github.com/mcalcote/ddf.git","svn_url":"https://github.com/mcalcote/ddf","homepage":"","size":145564,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"55aed0a076923068da59ddbd8e468fa241d3827d","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-06-01T06:07:12Z","pushed_at":"2016-06-06T23:00:52Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":164699,"stargazers_count":37,"watchers_count":37,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":80,"mirror_url":null,"open_issues_count":29,"forks":80,"open_issues":29,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/806"},"html":{"href":"https://github.com/codice/ddf/pull/806"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/806"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/806/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/806/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/806/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/70c1957feebf969e04a9e5b526c97a65856884ff"}}}}
{"actor":{"display_login":"shaundmorris"}}