{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/24419","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/24419/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/24419/comments","events_url":"https://api.github.com/repos/rails/rails/issues/24419/events","html_url":"https://github.com/rails/rails/pull/24419","id":145778018,"number":24419,"title":"Extend `ActionController::TestCase` deprecation warning","user":{"login":"rgm","id":6805,"avatar_url":"https://avatars.githubusercontent.com/u/6805?v=3","gravatar_id":"","url":"https://api.github.com/users/rgm","html_url":"https://github.com/rgm","followers_url":"https://api.github.com/users/rgm/followers","following_url":"https://api.github.com/users/rgm/following{/other_user}","gists_url":"https://api.github.com/users/rgm/gists{/gist_id}","starred_url":"https://api.github.com/users/rgm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgm/subscriptions","organizations_url":"https://api.github.com/users/rgm/orgs","repos_url":"https://api.github.com/users/rgm/repos","events_url":"https://api.github.com/users/rgm/events{/privacy}","received_events_url":"https://api.github.com/users/rgm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rails/rails/labels/actionpack","name":"actionpack","color":"FFF700"},{"url":"https://api.github.com/repos/rails/rails/labels/docs","name":"docs","color":"02d7e1"}],"state":"open","locked":false,"assignee":{"login":"eileencodes","id":1080678,"avatar_url":"https://avatars.githubusercontent.com/u/1080678?v=3","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-04-04T19:16:02Z","updated_at":"2016-04-04T21:22:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/24419","html_url":"https://github.com/rails/rails/pull/24419","diff_url":"https://github.com/rails/rails/pull/24419.diff","patch_url":"https://github.com/rails/rails/pull/24419.patch"},"body":"### Summary\r\n\r\nRails 5 requires a syntax change in `ActionController::TestCase` for all `get/post/put/...` test calls, and emits a deprecation warning. But the bigger picture is that `ActionController::TestCase` is going to be put in a gem in 5.1 and this should be made obvious so that people can have a sense of the full scope of work to fix their tests.\r\n\r\n### Other Information\r\n\r\nThe information that `ActionController::TestCase` as a whole has been\r\ndeprecated is not yet on edgerails docs release notes and can be easy to\r\nmiss unless you're reading the release notes on github directly (which\r\nthe source says not to do).\r\n\r\nSee https://github.com/rails/rails/pull/18323 for keyword arg change.\r\nSee https://github.com/rails/rails/commit/4414c5d1795e815b102571425974a8b1d46d932d for the `ActionController::TestCase` deprecation."},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/205502509","html_url":"https://github.com/rails/rails/pull/24419#issuecomment-205502509","issue_url":"https://api.github.com/repos/rails/rails/issues/24419","id":205502509,"user":{"login":"latortuga","id":9379,"avatar_url":"https://avatars.githubusercontent.com/u/9379?v=3","gravatar_id":"","url":"https://api.github.com/users/latortuga","html_url":"https://github.com/latortuga","followers_url":"https://api.github.com/users/latortuga/followers","following_url":"https://api.github.com/users/latortuga/following{/other_user}","gists_url":"https://api.github.com/users/latortuga/gists{/gist_id}","starred_url":"https://api.github.com/users/latortuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latortuga/subscriptions","organizations_url":"https://api.github.com/users/latortuga/orgs","repos_url":"https://api.github.com/users/latortuga/repos","events_url":"https://api.github.com/users/latortuga/events{/privacy}","received_events_url":"https://api.github.com/users/latortuga/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T21:22:50Z","updated_at":"2016-04-04T21:22:50Z","body":"This particular situation hit me today and it was a bit surreal. When I ran my Rails 4 tests, I got deprecation warnings about moving to the `process` API for controller tests. However, the edge rails guides indicate that new controller tests are generated as subclasses of `ActionDispatch::IntegrationTest` instead of `ActionController::TestCase` ..... which does not support the new `process` syntax!\r\n\r\n1. Why is there a new syntax for test classes that are getting deprecated and extracted with no built-in alternative?\r\n2. Why would app developers move to the new syntax of `process :action, method: :get, params: {xyz: 123}` when that isn't even the recommended way of testing controllers anymore?"}}