{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/67946528","id":67946528,"diff_hunk":"@@ -116,6 +165,15 @@\n             \"required\": [\"device\"],\n             \"additionalProperties\": false\n         },\n+        \"NetworkDevices\": {\n+            \"description\": \"The network cofiguration for each NIC\",","path":"lib/task-data/schemas/install-os-base.json","position":123,"original_position":123,"commit_id":"5738707c388102c2893b99c799e35bc10654463e","original_commit_id":"5738707c388102c2893b99c799e35bc10654463e","user":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"body":"\"configuration\" instead of \"cofiguratoin\"","created_at":"2016-06-21T20:35:33Z","updated_at":"2016-06-21T20:35:33Z","html_url":"https://github.com/RackHD/on-tasks/pull/242#discussion_r67946528","pull_request_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/67946528"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/242#discussion_r67946528"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/242","id":74110540,"html_url":"https://github.com/RackHD/on-tasks/pull/242","diff_url":"https://github.com/RackHD/on-tasks/pull/242.diff","patch_url":"https://github.com/RackHD/on-tasks/pull/242.patch","issue_url":"https://api.github.com/repos/RackHD/on-tasks/issues/242","number":242,"state":"open","locked":false,"title":"Refactor task-schema design & finish all install-os task schemas","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"body":"Changes:\r\n1. Refine schema unit-test helper structure, make it more powerful and more user friendly. \r\n2. Add more helper function (especially set/unset testing) to assist and simplify all schema unit-testing design. \r\n3. Add common-task-options schema.\r\n4. Redesign the architecture of all install-os schemas.\r\n5. Validate the task definition's `schemaRef`\r\n6. Enable common-task-options unit-test for all task schema.\r\n7. Refactor the schema unit-test helper to support non task schema.\r\n8. Finish all install-os tasks' schema.\r\n\r\n@RackHD/corecommitters @WangWinson @iceiilin ","created_at":"2016-06-16T16:21:17Z","updated_at":"2016-06-21T20:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c76ed9ea609346550554f5a57914017d1fd24f9d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/242/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/242/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/issues/242/comments","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/5738707c388102c2893b99c799e35bc10654463e","head":{"label":"yyscamper:task-schema","ref":"task-schema","sha":"5738707c388102c2893b99c799e35bc10654463e","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"repo":{"id":45583947,"name":"on-tasks","full_name":"yyscamper/on-tasks","owner":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yyscamper/on-tasks","description":"","fork":true,"url":"https://api.github.com/repos/yyscamper/on-tasks","forks_url":"https://api.github.com/repos/yyscamper/on-tasks/forks","keys_url":"https://api.github.com/repos/yyscamper/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yyscamper/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yyscamper/on-tasks/teams","hooks_url":"https://api.github.com/repos/yyscamper/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/yyscamper/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/yyscamper/on-tasks/events","assignees_url":"https://api.github.com/repos/yyscamper/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/yyscamper/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/yyscamper/on-tasks/tags","blobs_url":"https://api.github.com/repos/yyscamper/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yyscamper/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yyscamper/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/yyscamper/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yyscamper/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/yyscamper/on-tasks/languages","stargazers_url":"https://api.github.com/repos/yyscamper/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/yyscamper/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/yyscamper/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/yyscamper/on-tasks/subscription","commits_url":"https://api.github.com/repos/yyscamper/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/yyscamper/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/yyscamper/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/yyscamper/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/yyscamper/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/yyscamper/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yyscamper/on-tasks/merges","archive_url":"https://api.github.com/repos/yyscamper/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yyscamper/on-tasks/downloads","issues_url":"https://api.github.com/repos/yyscamper/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/yyscamper/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/yyscamper/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/yyscamper/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yyscamper/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/yyscamper/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/yyscamper/on-tasks/deployments","created_at":"2015-11-05T03:07:36Z","updated_at":"2016-01-20T05:44:20Z","pushed_at":"2016-06-21T11:45:16Z","git_url":"git://github.com/yyscamper/on-tasks.git","ssh_url":"git@github.com:yyscamper/on-tasks.git","clone_url":"https://github.com/yyscamper/on-tasks.git","svn_url":"https://github.com/yyscamper/on-tasks","homepage":null,"size":1561,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"0645e70a1d969cb86fb9f069708ad13414d2c3e1","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690099,"name":"on-tasks","full_name":"RackHD/on-tasks","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-tasks","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-tasks","forks_url":"https://api.github.com/repos/RackHD/on-tasks/forks","keys_url":"https://api.github.com/repos/RackHD/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-tasks/teams","hooks_url":"https://api.github.com/repos/RackHD/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-tasks/events","assignees_url":"https://api.github.com/repos/RackHD/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-tasks/tags","blobs_url":"https://api.github.com/repos/RackHD/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-tasks/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-tasks/subscription","commits_url":"https://api.github.com/repos/RackHD/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-tasks/merges","archive_url":"https://api.github.com/repos/RackHD/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-tasks/downloads","issues_url":"https://api.github.com/repos/RackHD/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-tasks/deployments","created_at":"2015-08-31T17:29:32Z","updated_at":"2016-05-17T08:18:08Z","pushed_at":"2016-06-21T11:45:17Z","git_url":"git://github.com/RackHD/on-tasks.git","ssh_url":"git@github.com:RackHD/on-tasks.git","clone_url":"https://github.com/RackHD/on-tasks.git","svn_url":"https://github.com/RackHD/on-tasks","homepage":null,"size":1702,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":6,"forks":43,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/242"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/242"},"issue":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/242"},"comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-tasks/statuses/5738707c388102c2893b99c799e35bc10654463e"}}}}
{"actor":{"display_login":"benbp"}}