{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/7434","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/7434/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/7434/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/7434/events","html_url":"https://github.com/facebook/react-native/pull/7434","id":153593920,"number":7434,"title":"Add versions to GitHub source links in documentation. #7428","user":{"login":"easyCZ","id":1419286,"avatar_url":"https://avatars.githubusercontent.com/u/1419286?v=3","gravatar_id":"","url":"https://api.github.com/users/easyCZ","html_url":"https://github.com/easyCZ","followers_url":"https://api.github.com/users/easyCZ/followers","following_url":"https://api.github.com/users/easyCZ/following{/other_user}","gists_url":"https://api.github.com/users/easyCZ/gists{/gist_id}","starred_url":"https://api.github.com/users/easyCZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easyCZ/subscriptions","organizations_url":"https://api.github.com/users/easyCZ/orgs","repos_url":"https://api.github.com/users/easyCZ/repos","events_url":"https://api.github.com/users/easyCZ/events{/privacy}","received_events_url":"https://api.github.com/users/easyCZ/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20accepted","name":"GH Review: accepted","color":"009800"},{"url":"https://api.github.com/repos/facebook/react-native/labels/Import%20Started","name":"Import Started","color":"eeeeee"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-07T13:17:42Z","updated_at":"2016-05-07T19:28:14Z","closed_at":"2016-05-07T15:36:37Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/7434","html_url":"https://github.com/facebook/react-native/pull/7434","diff_url":"https://github.com/facebook/react-native/pull/7434.diff","patch_url":"https://github.com/facebook/react-native/pull/7434.patch"},"body":"### Motivation \r\nDocumentation references to source code on GitHub should point to their respective versions in order to avoid confusion and prevent broken links when the master branch differs from the currently viewed version. [More details](https://github.com/facebook/react-native/issues/7428)\r\n\r\nOriginally links pointed to a hardcoded master branch on GitHub. The change augments the GitHub url to point to a respective branch of the code. The new urls are as follows:\r\n\r\nnext: `https://github.com/facebook/react-native/blob/master/<path>`\r\nstable: `https://github.com/facebook/react-native/blob/0.25-stable/<path>`\r\n\r\n\r\n### Test Plan\r\nThe website module currently does not have a unit test setup. As a result, I performed the following tests:\r\n\r\n1. Start the server with `RN_VERSION=next` and verified all links point to _master_\r\n<img width=\"945\" alt=\"screen shot 2016-05-07 at 14 10 58\" src=\"https://cloud.githubusercontent.com/assets/1419286/15092307/ee66fb32-145d-11e6-92a0-d03169e517c2.png\">\r\n2. Start the server with `RN_VERSION=0.24` and verified all links point to the _0.24-stable_ branch\r\n<img width=\"941\" alt=\"screen shot 2016-05-07 at 14 10 28\" src=\"https://cloud.githubusercontent.com/assets/1419286/15092306/ecb0e05a-145d-11e6-91ac-fecd5136a159.png\">\r\n\r\nI've gone through the pages and verified the links are correct and unbroken.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/217663240","html_url":"https://github.com/facebook/react-native/pull/7434#issuecomment-217663240","issue_url":"https://api.github.com/repos/facebook/react-native/issues/7434","id":217663240,"user":{"login":"easyCZ","id":1419286,"avatar_url":"https://avatars.githubusercontent.com/u/1419286?v=3","gravatar_id":"","url":"https://api.github.com/users/easyCZ","html_url":"https://github.com/easyCZ","followers_url":"https://api.github.com/users/easyCZ/followers","following_url":"https://api.github.com/users/easyCZ/following{/other_user}","gists_url":"https://api.github.com/users/easyCZ/gists{/gist_id}","starred_url":"https://api.github.com/users/easyCZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easyCZ/subscriptions","organizations_url":"https://api.github.com/users/easyCZ/orgs","repos_url":"https://api.github.com/users/easyCZ/repos","events_url":"https://api.github.com/users/easyCZ/events{/privacy}","received_events_url":"https://api.github.com/users/easyCZ/received_events","type":"User","site_admin":false},"created_at":"2016-05-07T19:28:14Z","updated_at":"2016-05-07T19:28:14Z","body":"@bestander Not sure, looking into it."}}