{"action":"created","comment":{"url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/comments/62801570","id":62801570,"diff_hunk":"@@ -8,10 +8,20 @@\n import org.apache.wicket.model.IModel;\n \n import fr.openwide.core.jpa.business.generic.model.GenericEntity;\n+import fr.openwide.core.wicket.more.markup.repeater.collection.CollectionView;\n import fr.openwide.core.wicket.more.model.GenericEntityModel;\n+import fr.openwide.core.wicket.more.model.ReadOnlyCollectionModel;\n \n /**\n  * A {@link ListView} akin to {@link AbstractGenericEntityCollectionView}, which is itself a {@link RefreshingView}.\n+ * @deprecated use {@link CollectionView} with {@link ReadOnlyCollectionModel} and {@link GenericEntityModel} instead : \n+ * <pre>\n+ * {@code \n+ * GenericEntity*View<T>(\"id\", model);\n+ * -> \n+ * new CollectionView<T>(\"id\", ReadOnlyCollectionModel.of(model, GenericEntityModel.<T>factory()));","path":"owsi-core/owsi-core-components/owsi-core-component-wicket-more/src/main/java/fr/openwide/core/wicket/more/markup/html/collection/GenericEntityListView.java","position":15,"original_position":15,"commit_id":"605b0a1f18e49747925638a18e841bc2a225ed3a","original_commit_id":"841c56d46a8edb041f3d3b224590d5651b530c76","user":{"login":"fenrhil","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/fenrhil","html_url":"https://github.com/fenrhil","followers_url":"https://api.github.com/users/fenrhil/followers","following_url":"https://api.github.com/users/fenrhil/following{/other_user}","gists_url":"https://api.github.com/users/fenrhil/gists{/gist_id}","starred_url":"https://api.github.com/users/fenrhil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenrhil/subscriptions","organizations_url":"https://api.github.com/users/fenrhil/orgs","repos_url":"https://api.github.com/users/fenrhil/repos","events_url":"https://api.github.com/users/fenrhil/events{/privacy}","received_events_url":"https://api.github.com/users/fenrhil/received_events","type":"User","site_admin":false},"body":"Don't forget to replace the sentence just above, too, in order to remove the reference to `ReadOnlyCollectionModel`","created_at":"2016-05-11T07:20:45Z","updated_at":"2016-05-11T07:20:45Z","html_url":"https://github.com/openwide-java/owsi-core-parent/pull/30#discussion_r62801570","pull_request_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/comments/62801570"},"html":{"href":"https://github.com/openwide-java/owsi-core-parent/pull/30#discussion_r62801570"},"pull_request":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30","id":67894628,"html_url":"https://github.com/openwide-java/owsi-core-parent/pull/30","diff_url":"https://github.com/openwide-java/owsi-core-parent/pull/30.diff","patch_url":"https://github.com/openwide-java/owsi-core-parent/pull/30.patch","issue_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/30","number":30,"state":"open","locked":false,"title":"Collection view","user":{"login":"daboooo","id":1834546,"avatar_url":"https://avatars.githubusercontent.com/u/1834546?v=3","gravatar_id":"","url":"https://api.github.com/users/daboooo","html_url":"https://github.com/daboooo","followers_url":"https://api.github.com/users/daboooo/followers","following_url":"https://api.github.com/users/daboooo/following{/other_user}","gists_url":"https://api.github.com/users/daboooo/gists{/gist_id}","starred_url":"https://api.github.com/users/daboooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daboooo/subscriptions","organizations_url":"https://api.github.com/users/daboooo/orgs","repos_url":"https://api.github.com/users/daboooo/repos","events_url":"https://api.github.com/users/daboooo/events{/privacy}","received_events_url":"https://api.github.com/users/daboooo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-26T14:22:46Z","updated_at":"2016-05-11T07:20:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6942cf9c9d25f1bf07c14e32586a63833733731e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30/commits","review_comments_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30/comments","review_comment_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/30/comments","statuses_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/statuses/605b0a1f18e49747925638a18e841bc2a225ed3a","head":{"label":"openwide-java:collection-view","ref":"collection-view","sha":"605b0a1f18e49747925638a18e841bc2a225ed3a","user":{"login":"openwide-java","id":1385131,"avatar_url":"https://avatars.githubusercontent.com/u/1385131?v=3","gravatar_id":"","url":"https://api.github.com/users/openwide-java","html_url":"https://github.com/openwide-java","followers_url":"https://api.github.com/users/openwide-java/followers","following_url":"https://api.github.com/users/openwide-java/following{/other_user}","gists_url":"https://api.github.com/users/openwide-java/gists{/gist_id}","starred_url":"https://api.github.com/users/openwide-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwide-java/subscriptions","organizations_url":"https://api.github.com/users/openwide-java/orgs","repos_url":"https://api.github.com/users/openwide-java/repos","events_url":"https://api.github.com/users/openwide-java/events{/privacy}","received_events_url":"https://api.github.com/users/openwide-java/received_events","type":"Organization","site_admin":false},"repo":{"id":42950514,"name":"owsi-core-parent","full_name":"openwide-java/owsi-core-parent","owner":{"login":"openwide-java","id":1385131,"avatar_url":"https://avatars.githubusercontent.com/u/1385131?v=3","gravatar_id":"","url":"https://api.github.com/users/openwide-java","html_url":"https://github.com/openwide-java","followers_url":"https://api.github.com/users/openwide-java/followers","following_url":"https://api.github.com/users/openwide-java/following{/other_user}","gists_url":"https://api.github.com/users/openwide-java/gists{/gist_id}","starred_url":"https://api.github.com/users/openwide-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwide-java/subscriptions","organizations_url":"https://api.github.com/users/openwide-java/orgs","repos_url":"https://api.github.com/users/openwide-java/repos","events_url":"https://api.github.com/users/openwide-java/events{/privacy}","received_events_url":"https://api.github.com/users/openwide-java/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openwide-java/owsi-core-parent","description":"Our Core framework based on Spring, Hibernate and Wicket","fork":false,"url":"https://api.github.com/repos/openwide-java/owsi-core-parent","forks_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/forks","keys_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/teams","hooks_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/hooks","issue_events_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/events{/number}","events_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/events","assignees_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/assignees{/user}","branches_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/branches{/branch}","tags_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/tags","blobs_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/refs{/sha}","trees_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/statuses/{sha}","languages_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/languages","stargazers_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/stargazers","contributors_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/contributors","subscribers_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/subscribers","subscription_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/subscription","commits_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/commits{/sha}","git_commits_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/commits{/sha}","comments_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/comments{/number}","issue_comment_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/comments{/number}","contents_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/contents/{+path}","compare_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/merges","archive_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/downloads","issues_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues{/number}","pulls_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls{/number}","milestones_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/milestones{/number}","notifications_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/labels{/name}","releases_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/releases{/id}","deployments_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/deployments","created_at":"2015-09-22T17:47:24Z","updated_at":"2016-04-27T07:48:03Z","pushed_at":"2016-05-10T17:20:01Z","git_url":"git://github.com/openwide-java/owsi-core-parent.git","ssh_url":"git@github.com:openwide-java/owsi-core-parent.git","clone_url":"https://github.com/openwide-java/owsi-core-parent.git","svn_url":"https://github.com/openwide-java/owsi-core-parent","homepage":"","size":15391,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"openwide-java:master","ref":"master","sha":"a30ba6b39c79d5f6a6c42d939cdf8af4a8245bb6","user":{"login":"openwide-java","id":1385131,"avatar_url":"https://avatars.githubusercontent.com/u/1385131?v=3","gravatar_id":"","url":"https://api.github.com/users/openwide-java","html_url":"https://github.com/openwide-java","followers_url":"https://api.github.com/users/openwide-java/followers","following_url":"https://api.github.com/users/openwide-java/following{/other_user}","gists_url":"https://api.github.com/users/openwide-java/gists{/gist_id}","starred_url":"https://api.github.com/users/openwide-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwide-java/subscriptions","organizations_url":"https://api.github.com/users/openwide-java/orgs","repos_url":"https://api.github.com/users/openwide-java/repos","events_url":"https://api.github.com/users/openwide-java/events{/privacy}","received_events_url":"https://api.github.com/users/openwide-java/received_events","type":"Organization","site_admin":false},"repo":{"id":42950514,"name":"owsi-core-parent","full_name":"openwide-java/owsi-core-parent","owner":{"login":"openwide-java","id":1385131,"avatar_url":"https://avatars.githubusercontent.com/u/1385131?v=3","gravatar_id":"","url":"https://api.github.com/users/openwide-java","html_url":"https://github.com/openwide-java","followers_url":"https://api.github.com/users/openwide-java/followers","following_url":"https://api.github.com/users/openwide-java/following{/other_user}","gists_url":"https://api.github.com/users/openwide-java/gists{/gist_id}","starred_url":"https://api.github.com/users/openwide-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwide-java/subscriptions","organizations_url":"https://api.github.com/users/openwide-java/orgs","repos_url":"https://api.github.com/users/openwide-java/repos","events_url":"https://api.github.com/users/openwide-java/events{/privacy}","received_events_url":"https://api.github.com/users/openwide-java/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openwide-java/owsi-core-parent","description":"Our Core framework based on Spring, Hibernate and Wicket","fork":false,"url":"https://api.github.com/repos/openwide-java/owsi-core-parent","forks_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/forks","keys_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/teams","hooks_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/hooks","issue_events_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/events{/number}","events_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/events","assignees_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/assignees{/user}","branches_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/branches{/branch}","tags_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/tags","blobs_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/refs{/sha}","trees_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/statuses/{sha}","languages_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/languages","stargazers_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/stargazers","contributors_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/contributors","subscribers_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/subscribers","subscription_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/subscription","commits_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/commits{/sha}","git_commits_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/git/commits{/sha}","comments_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/comments{/number}","issue_comment_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/comments{/number}","contents_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/contents/{+path}","compare_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/merges","archive_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/downloads","issues_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues{/number}","pulls_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls{/number}","milestones_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/milestones{/number}","notifications_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/labels{/name}","releases_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/releases{/id}","deployments_url":"https://api.github.com/repos/openwide-java/owsi-core-parent/deployments","created_at":"2015-09-22T17:47:24Z","updated_at":"2016-04-27T07:48:03Z","pushed_at":"2016-05-10T17:20:01Z","git_url":"git://github.com/openwide-java/owsi-core-parent.git","ssh_url":"git@github.com:openwide-java/owsi-core-parent.git","clone_url":"https://github.com/openwide-java/owsi-core-parent.git","svn_url":"https://github.com/openwide-java/owsi-core-parent","homepage":"","size":15391,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30"},"html":{"href":"https://github.com/openwide-java/owsi-core-parent/pull/30"},"issue":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/30"},"comments":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/openwide-java/owsi-core-parent/statuses/605b0a1f18e49747925638a18e841bc2a225ed3a"}}}}