{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/4670","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/4670/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/4670/comments","events_url":"https://api.github.com/repos/apple/swift/issues/4670/events","html_url":"https://github.com/apple/swift/pull/4670","id":175624867,"number":4670,"title":"[escaping] Correct diagnostic for parameter position","user":{"login":"milseman","id":235334,"avatar_url":"https://avatars.githubusercontent.com/u/235334?v=3","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-07T22:46:38Z","updated_at":"2016-09-08T01:37:58Z","closed_at":"2016-09-08T00:47:58Z","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/4670","html_url":"https://github.com/apple/swift/pull/4670","diff_url":"https://github.com/apple/swift/pull/4670.diff","patch_url":"https://github.com/apple/swift/pull/4670.patch"},"body":"<!-- What's in this pull request? -->\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n\r\nIn situations where @escaping is used in non-function-parameter\r\npositions, we give an incorrect diagnostic message pertaining to\r\nfunction types. Instead, we should just state that this is not allowed\r\nin non-function-parameter positions.\r\n\r\nThis includes the general message fix. Unfortunately, this does not\r\ninclude more friendly messages for special cases, e.g. closure members\r\nof aggregate and optional closures. That may be possible with more\r\nnested type context information in TypeCheckType."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/245470038","html_url":"https://github.com/apple/swift/pull/4670#issuecomment-245470038","issue_url":"https://api.github.com/repos/apple/swift/issues/4670","id":245470038,"user":{"login":"jtbandes","id":14237,"avatar_url":"https://avatars.githubusercontent.com/u/14237?v=3","gravatar_id":"","url":"https://api.github.com/users/jtbandes","html_url":"https://github.com/jtbandes","followers_url":"https://api.github.com/users/jtbandes/followers","following_url":"https://api.github.com/users/jtbandes/following{/other_user}","gists_url":"https://api.github.com/users/jtbandes/gists{/gist_id}","starred_url":"https://api.github.com/users/jtbandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtbandes/subscriptions","organizations_url":"https://api.github.com/users/jtbandes/orgs","repos_url":"https://api.github.com/users/jtbandes/repos","events_url":"https://api.github.com/users/jtbandes/events{/privacy}","received_events_url":"https://api.github.com/users/jtbandes/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T01:37:58Z","updated_at":"2016-09-08T01:37:58Z","body":"I'd suggest `on function parameters` or `on parameters to functions` rather than `in function parameter position`, for clarity."}}
{"actor":{"display_login":"jtbandes"}}