{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/92682464","pull_request_review_id":13202553,"id":92682464,"diff_hunk":"@@ -1816,9 +1795,20 @@\n                         </ol>\n                       </li>\n                       <li>\n+                        <p>If <code><var>candidate</var>.ufrag</code> is not\n+                        equal to any ufrag present in the corresponding\n+                        <a>media description</a> of an applied remote\n+                        description, reject <var>p</var> with an","path":"webrtc.html","position":86,"original_position":52,"commit_id":"53fbc464fa07f8f070bc3be71cb6c432d5a99015","original_commit_id":"573e1b0ead80ac25b70fb12b4630290f58a25b52","user":{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false},"body":"Ok. Then the logical conclusion is that you can have at most 2 ICE generations at the same time (during the time between when the offer is sent and the answer accepts the ICE restart). Then when the answer is applied, the old ICE checklists can be discarded. Does this need to be detailed in draft-ietf-mmusic-ice-sip-sdp? I initially was thinking JSEP, but you're allowed to reject an offer even with normal SDP offer/answer semantics, so this seems like a general \"ICE SDP\" thing.","created_at":"2016-12-15T19:30:44Z","updated_at":"2016-12-15T19:30:44Z","html_url":"https://github.com/w3c/webrtc-pc/pull/968#discussion_r92682464","pull_request_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968","_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/92682464"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/968#discussion_r92682464"},"pull_request":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968","id":97186582,"html_url":"https://github.com/w3c/webrtc-pc/pull/968","diff_url":"https://github.com/w3c/webrtc-pc/pull/968.diff","patch_url":"https://github.com/w3c/webrtc-pc/pull/968.patch","issue_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/968","number":968,"state":"open","locked":false,"title":"Add ufrag to IceCandidate, and use IceCandidate for end-of-candidates.","user":{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false},"body":"Since RTCIceCandidate can be used for end-of-candidates, all the\r\nattributes besides \"ufrag\" now become nullable.\r\n\r\nRebase of PR #757. Fixes #726.","created_at":"2016-12-08T19:39:46Z","updated_at":"2016-12-15T19:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d64b1c47c3bf917efda347504e99bd7dcf415ce0","assignee":{"login":"aboba","id":808811,"avatar_url":"https://avatars.githubusercontent.com/u/808811?v=3","gravatar_id":"","url":"https://api.github.com/users/aboba","html_url":"https://github.com/aboba","followers_url":"https://api.github.com/users/aboba/followers","following_url":"https://api.github.com/users/aboba/following{/other_user}","gists_url":"https://api.github.com/users/aboba/gists{/gist_id}","starred_url":"https://api.github.com/users/aboba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboba/subscriptions","organizations_url":"https://api.github.com/users/aboba/orgs","repos_url":"https://api.github.com/users/aboba/repos","events_url":"https://api.github.com/users/aboba/events{/privacy}","received_events_url":"https://api.github.com/users/aboba/received_events","type":"User","site_admin":false},"assignees":[{"login":"aboba","id":808811,"avatar_url":"https://avatars.githubusercontent.com/u/808811?v=3","gravatar_id":"","url":"https://api.github.com/users/aboba","html_url":"https://github.com/aboba","followers_url":"https://api.github.com/users/aboba/followers","following_url":"https://api.github.com/users/aboba/following{/other_user}","gists_url":"https://api.github.com/users/aboba/gists{/gist_id}","starred_url":"https://api.github.com/users/aboba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboba/subscriptions","organizations_url":"https://api.github.com/users/aboba/orgs","repos_url":"https://api.github.com/users/aboba/repos","events_url":"https://api.github.com/users/aboba/events{/privacy}","received_events_url":"https://api.github.com/users/aboba/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968/commits","review_comments_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968/comments","review_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/968/comments","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/53fbc464fa07f8f070bc3be71cb6c432d5a99015","head":{"label":"taylor-b:trickle_RTCIceCandidate_with_null_candidate","ref":"trickle_RTCIceCandidate_with_null_candidate","sha":"53fbc464fa07f8f070bc3be71cb6c432d5a99015","user":{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false},"repo":{"id":43853249,"name":"webrtc-pc","full_name":"taylor-b/webrtc-pc","owner":{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taylor-b/webrtc-pc","description":"WebRTC 1.0 API","fork":true,"url":"https://api.github.com/repos/taylor-b/webrtc-pc","forks_url":"https://api.github.com/repos/taylor-b/webrtc-pc/forks","keys_url":"https://api.github.com/repos/taylor-b/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taylor-b/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taylor-b/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/taylor-b/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/taylor-b/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/taylor-b/webrtc-pc/events","assignees_url":"https://api.github.com/repos/taylor-b/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/taylor-b/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/taylor-b/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taylor-b/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/taylor-b/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/taylor-b/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/taylor-b/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/taylor-b/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/taylor-b/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/taylor-b/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/taylor-b/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/taylor-b/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/taylor-b/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/taylor-b/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taylor-b/webrtc-pc/merges","archive_url":"https://api.github.com/repos/taylor-b/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taylor-b/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/taylor-b/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/taylor-b/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/taylor-b/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/taylor-b/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taylor-b/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/taylor-b/webrtc-pc/releases{/id}","deployments_url":"https://api.github.com/repos/taylor-b/webrtc-pc/deployments","created_at":"2015-10-08T00:46:11Z","updated_at":"2016-02-26T22:05:47Z","pushed_at":"2016-12-13T23:42:37Z","git_url":"git://github.com/taylor-b/webrtc-pc.git","ssh_url":"git@github.com:taylor-b/webrtc-pc.git","clone_url":"https://github.com/taylor-b/webrtc-pc.git","svn_url":"https://github.com/taylor-b/webrtc-pc","homepage":null,"size":18102,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"c417751d407c526a9db9e3cdf7a5bb247142ef08","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":23384500,"name":"webrtc-pc","full_name":"w3c/webrtc-pc","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webrtc-pc","description":"WebRTC 1.0 API","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-pc","forks_url":"https://api.github.com/repos/w3c/webrtc-pc/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-pc/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-pc/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-pc/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webrtc-pc/deployments","created_at":"2014-08-27T09:39:00Z","updated_at":"2016-12-11T10:22:07Z","pushed_at":"2016-12-15T15:24:02Z","git_url":"git://github.com/w3c/webrtc-pc.git","ssh_url":"git@github.com:w3c/webrtc-pc.git","clone_url":"https://github.com/w3c/webrtc-pc.git","svn_url":"https://github.com/w3c/webrtc-pc","homepage":"https://w3c.github.io/webrtc-pc/","size":18433,"stargazers_count":103,"watchers_count":103,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":55,"forks":54,"open_issues":55,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/968"},"issue":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/968"},"comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/968/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/968/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webrtc-pc/statuses/53fbc464fa07f8f070bc3be71cb6c432d5a99015"}}}}
{"actor":{"display_login":"taylor-b"}}