{"action":"created","issue":{"url":"https://api.github.com/repos/JabRef/jabref/issues/1526","repository_url":"https://api.github.com/repos/JabRef/jabref","labels_url":"https://api.github.com/repos/JabRef/jabref/issues/1526/labels{/name}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/1526/comments","events_url":"https://api.github.com/repos/JabRef/jabref/issues/1526/events","html_url":"https://github.com/JabRef/jabref/pull/1526","id":162932361,"number":1526,"title":"Journal abbreviations dialog ported to JavaFX","user":{"login":"boceckts","id":15340757,"avatar_url":"https://avatars.githubusercontent.com/u/15340757?v=3","gravatar_id":"","url":"https://api.github.com/users/boceckts","html_url":"https://github.com/boceckts","followers_url":"https://api.github.com/users/boceckts/followers","following_url":"https://api.github.com/users/boceckts/following{/other_user}","gists_url":"https://api.github.com/users/boceckts/gists{/gist_id}","starred_url":"https://api.github.com/users/boceckts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boceckts/subscriptions","organizations_url":"https://api.github.com/users/boceckts/orgs","repos_url":"https://api.github.com/users/boceckts/repos","events_url":"https://api.github.com/users/boceckts/events{/privacy}","received_events_url":"https://api.github.com/users/boceckts/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JabRef/jabref/labels/ready-for-review","name":"ready-for-review","color":"e11d21"},{"url":"https://api.github.com/repos/JabRef/jabref/labels/stupro","name":"stupro","color":"fbca04"}],"state":"closed","locked":false,"assignee":{"login":"koppor","id":1366654,"avatar_url":"https://avatars.githubusercontent.com/u/1366654?v=3","gravatar_id":"","url":"https://api.github.com/users/koppor","html_url":"https://github.com/koppor","followers_url":"https://api.github.com/users/koppor/followers","following_url":"https://api.github.com/users/koppor/following{/other_user}","gists_url":"https://api.github.com/users/koppor/gists{/gist_id}","starred_url":"https://api.github.com/users/koppor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koppor/subscriptions","organizations_url":"https://api.github.com/users/koppor/orgs","repos_url":"https://api.github.com/users/koppor/repos","events_url":"https://api.github.com/users/koppor/events{/privacy}","received_events_url":"https://api.github.com/users/koppor/received_events","type":"User","site_admin":false},"assignees":[{"login":"koppor","id":1366654,"avatar_url":"https://avatars.githubusercontent.com/u/1366654?v=3","gravatar_id":"","url":"https://api.github.com/users/koppor","html_url":"https://github.com/koppor","followers_url":"https://api.github.com/users/koppor/followers","following_url":"https://api.github.com/users/koppor/following{/other_user}","gists_url":"https://api.github.com/users/koppor/gists{/gist_id}","starred_url":"https://api.github.com/users/koppor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koppor/subscriptions","organizations_url":"https://api.github.com/users/koppor/orgs","repos_url":"https://api.github.com/users/koppor/repos","events_url":"https://api.github.com/users/koppor/events{/privacy}","received_events_url":"https://api.github.com/users/koppor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-06-29T13:58:31Z","updated_at":"2016-09-07T18:08:16Z","closed_at":"2016-09-01T15:15:03Z","pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/1526","html_url":"https://github.com/JabRef/jabref/pull/1526","diff_url":"https://github.com/JabRef/jabref/pull/1526.diff","patch_url":"https://github.com/JabRef/jabref/pull/1526.patch"},"body":"I tried to extract the logic in a test driven approach to completely separate ui and ui-model and to have a high code test coverage. The design of the dialog was made after the ui-model was finisehd and is close to what was specified in #1396.\r\n\r\n- [x] Change in CHANGELOG.md described\r\n- [x] Tests created for changes\r\n- [x] Screenshots added (for bigger UI changes)\r\n\r\n![listview](https://cloud.githubusercontent.com/assets/15340757/17297484/38b74016-5806-11e6-94ff-4d42c61e584c.PNG)\r\n![listvieweditname](https://cloud.githubusercontent.com/assets/15340757/17297485/39e412fc-5806-11e6-9ad4-bfeaa7aab699.png)\r\n![listviewbuiltinlist](https://cloud.githubusercontent.com/assets/15340757/17297543/6f7a067e-5806-11e6-8f1c-e3979922db16.png)\r\n"},"comment":{"url":"https://api.github.com/repos/JabRef/jabref/issues/comments/245368017","html_url":"https://github.com/JabRef/jabref/pull/1526#issuecomment-245368017","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/1526","id":245368017,"user":{"login":"boceckts","id":15340757,"avatar_url":"https://avatars.githubusercontent.com/u/15340757?v=3","gravatar_id":"","url":"https://api.github.com/users/boceckts","html_url":"https://github.com/boceckts","followers_url":"https://api.github.com/users/boceckts/followers","following_url":"https://api.github.com/users/boceckts/following{/other_user}","gists_url":"https://api.github.com/users/boceckts/gists{/gist_id}","starred_url":"https://api.github.com/users/boceckts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boceckts/subscriptions","organizations_url":"https://api.github.com/users/boceckts/orgs","repos_url":"https://api.github.com/users/boceckts/repos","events_url":"https://api.github.com/users/boceckts/events{/privacy}","received_events_url":"https://api.github.com/users/boceckts/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T18:08:16Z","updated_at":"2016-09-07T18:08:16Z","body":"@koppor I will look into it, did this happen after the javafx branch has been updated?"}}
{"actor":{"display_login":"boceckts"}}