{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/partouf/AchieveAche/pulls/1","id":84224463,"html_url":"https://github.com/partouf/AchieveAche/pull/1","diff_url":"https://github.com/partouf/AchieveAche/pull/1.diff","patch_url":"https://github.com/partouf/AchieveAche/pull/1.patch","issue_url":"https://api.github.com/repos/partouf/AchieveAche/issues/1","number":1,"state":"open","locked":false,"title":"Check for nil in GetAchievementInfo result","user":{"login":"martinvd","id":320906,"avatar_url":"https://avatars.githubusercontent.com/u/320906?v=3","gravatar_id":"","url":"https://api.github.com/users/martinvd","html_url":"https://github.com/martinvd","followers_url":"https://api.github.com/users/martinvd/followers","following_url":"https://api.github.com/users/martinvd/following{/other_user}","gists_url":"https://api.github.com/users/martinvd/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvd/subscriptions","organizations_url":"https://api.github.com/users/martinvd/orgs","repos_url":"https://api.github.com/users/martinvd/repos","events_url":"https://api.github.com/users/martinvd/events{/privacy}","received_events_url":"https://api.github.com/users/martinvd/received_events","type":"User","site_admin":false},"body":"Was getting the following error:\r\n\r\n```\r\nDate: 2016-09-07 02:47:27\r\nID: 1\r\nError occured in: Global\r\nCount: 1\r\nMessage: ..\\AddOns\\achieveache\\AchieveAcheFrame.lua line 47:\r\n   table index is nil\r\nDebug:\r\n   achieveache\\AchieveAcheFrame.lua:47: AchieveAche_LoadAchievementsFromApi()\r\n   achieveache\\AchieveAcheFrame.lua:26: ?()\r\n...\r\n```\r\n\r\nSo now it checks for `nil` in the `GetAchievementInfo` result. Might have something to do with [this](http://wowprogramming.com/docs/api/GetCategoryNumAchievements):\r\n\r\n> BUG: for `includeSuperseded=false` the returned `numItems` is sometimes too high (as is `numUncompleted`)\r\n\r\nBut I tried it with `includeSuperseded=true`, but that still ends up with the last record being `nil`.","created_at":"2016-09-07T01:46:12Z","updated_at":"2016-09-07T01:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/partouf/AchieveAche/pulls/1/commits","review_comments_url":"https://api.github.com/repos/partouf/AchieveAche/pulls/1/comments","review_comment_url":"https://api.github.com/repos/partouf/AchieveAche/pulls/comments{/number}","comments_url":"https://api.github.com/repos/partouf/AchieveAche/issues/1/comments","statuses_url":"https://api.github.com/repos/partouf/AchieveAche/statuses/a2a3d29e37714f95bd397c3054637822964238cb","head":{"label":"martinvd:patch-1","ref":"patch-1","sha":"a2a3d29e37714f95bd397c3054637822964238cb","user":{"login":"martinvd","id":320906,"avatar_url":"https://avatars.githubusercontent.com/u/320906?v=3","gravatar_id":"","url":"https://api.github.com/users/martinvd","html_url":"https://github.com/martinvd","followers_url":"https://api.github.com/users/martinvd/followers","following_url":"https://api.github.com/users/martinvd/following{/other_user}","gists_url":"https://api.github.com/users/martinvd/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvd/subscriptions","organizations_url":"https://api.github.com/users/martinvd/orgs","repos_url":"https://api.github.com/users/martinvd/repos","events_url":"https://api.github.com/users/martinvd/events{/privacy}","received_events_url":"https://api.github.com/users/martinvd/received_events","type":"User","site_admin":false},"repo":{"id":67557983,"name":"AchieveAche","full_name":"martinvd/AchieveAche","owner":{"login":"martinvd","id":320906,"avatar_url":"https://avatars.githubusercontent.com/u/320906?v=3","gravatar_id":"","url":"https://api.github.com/users/martinvd","html_url":"https://github.com/martinvd","followers_url":"https://api.github.com/users/martinvd/followers","following_url":"https://api.github.com/users/martinvd/following{/other_user}","gists_url":"https://api.github.com/users/martinvd/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvd/subscriptions","organizations_url":"https://api.github.com/users/martinvd/orgs","repos_url":"https://api.github.com/users/martinvd/repos","events_url":"https://api.github.com/users/martinvd/events{/privacy}","received_events_url":"https://api.github.com/users/martinvd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinvd/AchieveAche","description":"WoW Addon for Achievements","fork":true,"url":"https://api.github.com/repos/martinvd/AchieveAche","forks_url":"https://api.github.com/repos/martinvd/AchieveAche/forks","keys_url":"https://api.github.com/repos/martinvd/AchieveAche/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinvd/AchieveAche/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinvd/AchieveAche/teams","hooks_url":"https://api.github.com/repos/martinvd/AchieveAche/hooks","issue_events_url":"https://api.github.com/repos/martinvd/AchieveAche/issues/events{/number}","events_url":"https://api.github.com/repos/martinvd/AchieveAche/events","assignees_url":"https://api.github.com/repos/martinvd/AchieveAche/assignees{/user}","branches_url":"https://api.github.com/repos/martinvd/AchieveAche/branches{/branch}","tags_url":"https://api.github.com/repos/martinvd/AchieveAche/tags","blobs_url":"https://api.github.com/repos/martinvd/AchieveAche/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinvd/AchieveAche/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinvd/AchieveAche/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinvd/AchieveAche/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinvd/AchieveAche/statuses/{sha}","languages_url":"https://api.github.com/repos/martinvd/AchieveAche/languages","stargazers_url":"https://api.github.com/repos/martinvd/AchieveAche/stargazers","contributors_url":"https://api.github.com/repos/martinvd/AchieveAche/contributors","subscribers_url":"https://api.github.com/repos/martinvd/AchieveAche/subscribers","subscription_url":"https://api.github.com/repos/martinvd/AchieveAche/subscription","commits_url":"https://api.github.com/repos/martinvd/AchieveAche/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinvd/AchieveAche/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinvd/AchieveAche/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinvd/AchieveAche/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinvd/AchieveAche/contents/{+path}","compare_url":"https://api.github.com/repos/martinvd/AchieveAche/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinvd/AchieveAche/merges","archive_url":"https://api.github.com/repos/martinvd/AchieveAche/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinvd/AchieveAche/downloads","issues_url":"https://api.github.com/repos/martinvd/AchieveAche/issues{/number}","pulls_url":"https://api.github.com/repos/martinvd/AchieveAche/pulls{/number}","milestones_url":"https://api.github.com/repos/martinvd/AchieveAche/milestones{/number}","notifications_url":"https://api.github.com/repos/martinvd/AchieveAche/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinvd/AchieveAche/labels{/name}","releases_url":"https://api.github.com/repos/martinvd/AchieveAche/releases{/id}","deployments_url":"https://api.github.com/repos/martinvd/AchieveAche/deployments","created_at":"2016-09-07T00:44:18Z","updated_at":"2016-09-07T00:44:20Z","pushed_at":"2016-09-07T01:39:05Z","git_url":"git://github.com/martinvd/AchieveAche.git","ssh_url":"git@github.com:martinvd/AchieveAche.git","clone_url":"https://github.com/martinvd/AchieveAche.git","svn_url":"https://github.com/martinvd/AchieveAche","homepage":"https://www.curse.com/addons/wow/achieveache","size":12,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"partouf:master","ref":"master","sha":"3625d0e58914fe044dddd322df4d2bc2cd765a7a","user":{"login":"partouf","id":442630,"avatar_url":"https://avatars.githubusercontent.com/u/442630?v=3","gravatar_id":"","url":"https://api.github.com/users/partouf","html_url":"https://github.com/partouf","followers_url":"https://api.github.com/users/partouf/followers","following_url":"https://api.github.com/users/partouf/following{/other_user}","gists_url":"https://api.github.com/users/partouf/gists{/gist_id}","starred_url":"https://api.github.com/users/partouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/partouf/subscriptions","organizations_url":"https://api.github.com/users/partouf/orgs","repos_url":"https://api.github.com/users/partouf/repos","events_url":"https://api.github.com/users/partouf/events{/privacy}","received_events_url":"https://api.github.com/users/partouf/received_events","type":"User","site_admin":false},"repo":{"id":67552787,"name":"AchieveAche","full_name":"partouf/AchieveAche","owner":{"login":"partouf","id":442630,"avatar_url":"https://avatars.githubusercontent.com/u/442630?v=3","gravatar_id":"","url":"https://api.github.com/users/partouf","html_url":"https://github.com/partouf","followers_url":"https://api.github.com/users/partouf/followers","following_url":"https://api.github.com/users/partouf/following{/other_user}","gists_url":"https://api.github.com/users/partouf/gists{/gist_id}","starred_url":"https://api.github.com/users/partouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/partouf/subscriptions","organizations_url":"https://api.github.com/users/partouf/orgs","repos_url":"https://api.github.com/users/partouf/repos","events_url":"https://api.github.com/users/partouf/events{/privacy}","received_events_url":"https://api.github.com/users/partouf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/partouf/AchieveAche","description":"WoW Addon for Achievements","fork":false,"url":"https://api.github.com/repos/partouf/AchieveAche","forks_url":"https://api.github.com/repos/partouf/AchieveAche/forks","keys_url":"https://api.github.com/repos/partouf/AchieveAche/keys{/key_id}","collaborators_url":"https://api.github.com/repos/partouf/AchieveAche/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/partouf/AchieveAche/teams","hooks_url":"https://api.github.com/repos/partouf/AchieveAche/hooks","issue_events_url":"https://api.github.com/repos/partouf/AchieveAche/issues/events{/number}","events_url":"https://api.github.com/repos/partouf/AchieveAche/events","assignees_url":"https://api.github.com/repos/partouf/AchieveAche/assignees{/user}","branches_url":"https://api.github.com/repos/partouf/AchieveAche/branches{/branch}","tags_url":"https://api.github.com/repos/partouf/AchieveAche/tags","blobs_url":"https://api.github.com/repos/partouf/AchieveAche/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/partouf/AchieveAche/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/partouf/AchieveAche/git/refs{/sha}","trees_url":"https://api.github.com/repos/partouf/AchieveAche/git/trees{/sha}","statuses_url":"https://api.github.com/repos/partouf/AchieveAche/statuses/{sha}","languages_url":"https://api.github.com/repos/partouf/AchieveAche/languages","stargazers_url":"https://api.github.com/repos/partouf/AchieveAche/stargazers","contributors_url":"https://api.github.com/repos/partouf/AchieveAche/contributors","subscribers_url":"https://api.github.com/repos/partouf/AchieveAche/subscribers","subscription_url":"https://api.github.com/repos/partouf/AchieveAche/subscription","commits_url":"https://api.github.com/repos/partouf/AchieveAche/commits{/sha}","git_commits_url":"https://api.github.com/repos/partouf/AchieveAche/git/commits{/sha}","comments_url":"https://api.github.com/repos/partouf/AchieveAche/comments{/number}","issue_comment_url":"https://api.github.com/repos/partouf/AchieveAche/issues/comments{/number}","contents_url":"https://api.github.com/repos/partouf/AchieveAche/contents/{+path}","compare_url":"https://api.github.com/repos/partouf/AchieveAche/compare/{base}...{head}","merges_url":"https://api.github.com/repos/partouf/AchieveAche/merges","archive_url":"https://api.github.com/repos/partouf/AchieveAche/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/partouf/AchieveAche/downloads","issues_url":"https://api.github.com/repos/partouf/AchieveAche/issues{/number}","pulls_url":"https://api.github.com/repos/partouf/AchieveAche/pulls{/number}","milestones_url":"https://api.github.com/repos/partouf/AchieveAche/milestones{/number}","notifications_url":"https://api.github.com/repos/partouf/AchieveAche/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/partouf/AchieveAche/labels{/name}","releases_url":"https://api.github.com/repos/partouf/AchieveAche/releases{/id}","deployments_url":"https://api.github.com/repos/partouf/AchieveAche/deployments","created_at":"2016-09-06T22:55:07Z","updated_at":"2016-09-07T00:41:06Z","pushed_at":"2016-09-06T23:22:49Z","git_url":"git://github.com/partouf/AchieveAche.git","ssh_url":"git@github.com:partouf/AchieveAche.git","clone_url":"https://github.com/partouf/AchieveAche.git","svn_url":"https://github.com/partouf/AchieveAche","homepage":"https://www.curse.com/addons/wow/achieveache","size":12,"stargazers_count":1,"watchers_count":1,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/partouf/AchieveAche/pulls/1"},"html":{"href":"https://github.com/partouf/AchieveAche/pull/1"},"issue":{"href":"https://api.github.com/repos/partouf/AchieveAche/issues/1"},"comments":{"href":"https://api.github.com/repos/partouf/AchieveAche/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/partouf/AchieveAche/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/partouf/AchieveAche/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/partouf/AchieveAche/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/partouf/AchieveAche/statuses/a2a3d29e37714f95bd397c3054637822964238cb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"martinvd"}}