{"action":"created","comment":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/91506855","pull_request_review_id":12014903,"id":91506855,"diff_hunk":"@@ -723,6 +735,18 @@ def get_data_set(self, data_manager=USE_MP, *args, **kwargs):\n \n         return self.data_set\n \n+    def wait_for_bg(self, quiet):\n+        prev_loop = get_bg()\n+        if prev_loop:\n+            if not quiet:\n+                print('Waiting for the previous background Loop to finish...',\n+                      flush=True)\n+            prev_loop.join()\n+\n+        if prev_loop and not quiet:\n+            print('...done. Starting ' + (data_set.location or 'new loop'),","path":"qcodes/loops.py","position":67,"original_position":67,"commit_id":"43b1d209464cc76045e874e50c75940f4dd9b3b3","original_commit_id":"43b1d209464cc76045e874e50c75940f4dd9b3b3","user":{"login":"giulioungaretti","id":2694199,"avatar_url":"https://avatars.githubusercontent.com/u/2694199?v=3","gravatar_id":"","url":"https://api.github.com/users/giulioungaretti","html_url":"https://github.com/giulioungaretti","followers_url":"https://api.github.com/users/giulioungaretti/followers","following_url":"https://api.github.com/users/giulioungaretti/following{/other_user}","gists_url":"https://api.github.com/users/giulioungaretti/gists{/gist_id}","starred_url":"https://api.github.com/users/giulioungaretti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giulioungaretti/subscriptions","organizations_url":"https://api.github.com/users/giulioungaretti/orgs","repos_url":"https://api.github.com/users/giulioungaretti/repos","events_url":"https://api.github.com/users/giulioungaretti/events{/privacy}","received_events_url":"https://api.github.com/users/giulioungaretti/received_events","type":"User","site_admin":false},"body":"will this actually print or raise an exception ? ","created_at":"2016-12-08T12:46:49Z","updated_at":"2016-12-08T12:46:54Z","html_url":"https://github.com/QCoDeS/Qcodes/pull/399#discussion_r91506855","pull_request_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399","_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/91506855"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/399#discussion_r91506855"},"pull_request":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399"}}},"pull_request":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399","id":94643675,"html_url":"https://github.com/QCoDeS/Qcodes/pull/399","diff_url":"https://github.com/QCoDeS/Qcodes/pull/399.diff","patch_url":"https://github.com/QCoDeS/Qcodes/pull/399.patch","issue_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/399","number":399,"state":"open","locked":false,"title":"fix: make background loops work with get_data_set.","user":{"login":"alexcjohnson","id":2678795,"avatar_url":"https://avatars.githubusercontent.com/u/2678795?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcjohnson","html_url":"https://github.com/alexcjohnson","followers_url":"https://api.github.com/users/alexcjohnson/followers","following_url":"https://api.github.com/users/alexcjohnson/following{/other_user}","gists_url":"https://api.github.com/users/alexcjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcjohnson/subscriptions","organizations_url":"https://api.github.com/users/alexcjohnson/orgs","repos_url":"https://api.github.com/users/alexcjohnson/repos","events_url":"https://api.github.com/users/alexcjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/alexcjohnson/received_events","type":"User","site_admin":false},"body":"Fixes #395 \r\n\r\nChanges proposed in this pull request:\r\n- Look for existing background loops during `get_data_set` rather than during `run`\r\n\r\n@peendebak @giulioungaretti ","created_at":"2016-11-21T16:03:55Z","updated_at":"2016-12-08T12:46:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fa33f829a03c9f15c6abc5487b797dca55824fb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399/commits","review_comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399/comments","review_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/399/comments","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/43b1d209464cc76045e874e50c75940f4dd9b3b3","head":{"label":"alexcjohnson:fix/bg-get-data-set","ref":"fix/bg-get-data-set","sha":"43b1d209464cc76045e874e50c75940f4dd9b3b3","user":{"login":"alexcjohnson","id":2678795,"avatar_url":"https://avatars.githubusercontent.com/u/2678795?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcjohnson","html_url":"https://github.com/alexcjohnson","followers_url":"https://api.github.com/users/alexcjohnson/followers","following_url":"https://api.github.com/users/alexcjohnson/following{/other_user}","gists_url":"https://api.github.com/users/alexcjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcjohnson/subscriptions","organizations_url":"https://api.github.com/users/alexcjohnson/orgs","repos_url":"https://api.github.com/users/alexcjohnson/repos","events_url":"https://api.github.com/users/alexcjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/alexcjohnson/received_events","type":"User","site_admin":false},"repo":{"id":74327856,"name":"Qcodes","full_name":"alexcjohnson/Qcodes","owner":{"login":"alexcjohnson","id":2678795,"avatar_url":"https://avatars.githubusercontent.com/u/2678795?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcjohnson","html_url":"https://github.com/alexcjohnson","followers_url":"https://api.github.com/users/alexcjohnson/followers","following_url":"https://api.github.com/users/alexcjohnson/following{/other_user}","gists_url":"https://api.github.com/users/alexcjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcjohnson/subscriptions","organizations_url":"https://api.github.com/users/alexcjohnson/orgs","repos_url":"https://api.github.com/users/alexcjohnson/repos","events_url":"https://api.github.com/users/alexcjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/alexcjohnson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcjohnson/Qcodes","description":"Modular data acquisition and analysis framework","fork":true,"url":"https://api.github.com/repos/alexcjohnson/Qcodes","forks_url":"https://api.github.com/repos/alexcjohnson/Qcodes/forks","keys_url":"https://api.github.com/repos/alexcjohnson/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcjohnson/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcjohnson/Qcodes/teams","hooks_url":"https://api.github.com/repos/alexcjohnson/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/alexcjohnson/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/alexcjohnson/Qcodes/events","assignees_url":"https://api.github.com/repos/alexcjohnson/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/alexcjohnson/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/alexcjohnson/Qcodes/tags","blobs_url":"https://api.github.com/repos/alexcjohnson/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcjohnson/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcjohnson/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcjohnson/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcjohnson/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcjohnson/Qcodes/languages","stargazers_url":"https://api.github.com/repos/alexcjohnson/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/alexcjohnson/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/alexcjohnson/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/alexcjohnson/Qcodes/subscription","commits_url":"https://api.github.com/repos/alexcjohnson/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcjohnson/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcjohnson/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcjohnson/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcjohnson/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/alexcjohnson/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcjohnson/Qcodes/merges","archive_url":"https://api.github.com/repos/alexcjohnson/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcjohnson/Qcodes/downloads","issues_url":"https://api.github.com/repos/alexcjohnson/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/alexcjohnson/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcjohnson/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcjohnson/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcjohnson/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/alexcjohnson/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/alexcjohnson/Qcodes/deployments","created_at":"2016-11-21T05:05:14Z","updated_at":"2016-11-21T05:05:16Z","pushed_at":"2016-11-30T12:50:53Z","git_url":"git://github.com/alexcjohnson/Qcodes.git","ssh_url":"git@github.com:alexcjohnson/Qcodes.git","clone_url":"https://github.com/alexcjohnson/Qcodes.git","svn_url":"https://github.com/alexcjohnson/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":8191,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QCoDeS:master","ref":"master","sha":"15f540842ec9ed43f483212b35ae89422515d64e","user":{"login":"QCoDeS","id":20478252,"avatar_url":"https://avatars.githubusercontent.com/u/20478252?v=3","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"repo":{"id":37137879,"name":"Qcodes","full_name":"QCoDeS/Qcodes","owner":{"login":"QCoDeS","id":20478252,"avatar_url":"https://avatars.githubusercontent.com/u/20478252?v=3","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QCoDeS/Qcodes","description":"Modular data acquisition and analysis framework","fork":false,"url":"https://api.github.com/repos/QCoDeS/Qcodes","forks_url":"https://api.github.com/repos/QCoDeS/Qcodes/forks","keys_url":"https://api.github.com/repos/QCoDeS/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QCoDeS/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QCoDeS/Qcodes/teams","hooks_url":"https://api.github.com/repos/QCoDeS/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/QCoDeS/Qcodes/events","assignees_url":"https://api.github.com/repos/QCoDeS/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/QCoDeS/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/tags","blobs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/QCoDeS/Qcodes/languages","stargazers_url":"https://api.github.com/repos/QCoDeS/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/QCoDeS/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscription","commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/QCoDeS/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/QCoDeS/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QCoDeS/Qcodes/merges","archive_url":"https://api.github.com/repos/QCoDeS/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QCoDeS/Qcodes/downloads","issues_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/QCoDeS/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/QCoDeS/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QCoDeS/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/QCoDeS/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/QCoDeS/Qcodes/deployments","created_at":"2015-06-09T14:42:14Z","updated_at":"2016-11-25T12:29:43Z","pushed_at":"2016-12-08T10:11:21Z","git_url":"git://github.com/QCoDeS/Qcodes.git","ssh_url":"git@github.com:QCoDeS/Qcodes.git","clone_url":"https://github.com/QCoDeS/Qcodes.git","svn_url":"https://github.com/QCoDeS/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":22546,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":117,"forks":7,"open_issues":117,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/399"},"issue":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/399"},"comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/43b1d209464cc76045e874e50c75940f4dd9b3b3"}}}}
{"actor":{"display_login":"giulioungaretti"}}