{"action":"created","comment":{"url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/comments/72554076","id":72554076,"diff_hunk":"@@ -206,53 +206,60 @@ - (void)joinChatroom:(NSString *)chatroomId\n {\n     __weak typeof(self) weakSelf = self;\n     [self showHudInView:self.view hint:NSLocalizedString(@\"chatroom.joining\",@\"Joining the chatroom\")];\n-    [[EMClient sharedClient].roomManager asyncJoinChatroom:chatroomId success:^(EMChatroom *aRoom) {\n-        if (weakSelf) {\n-            EaseMessageViewController *strongSelf = weakSelf;\n-            [strongSelf hideHud];\n-            [strongSelf saveChatroom:aRoom];\n-        } else {\n-            [[EMClient sharedClient].roomManager asyncLeaveChatroom:chatroomId success:^(EMChatroom *aRoom) {\n-                [[EMClient sharedClient].chatManager deleteConversation:chatroomId deleteMessages:YES];\n-            } failure:^(EMError *aError) {\n-                //leave failed\n-            }];\n-        }\n-    } failure:^(EMError *aError) {\n-        if (weakSelf) {\n-            EaseMessageViewController *strongSelf = weakSelf;\n-            [strongSelf hideHud];\n-            [strongSelf showHint:[NSString stringWithFormat:NSLocalizedString(@\"chatroom.joinFailed\",@\"join chatroom \\'%@\\' failed\"), chatroomId]];\n-        } else {\n-            if (aError.code == EMErrorChatroomAlreadyJoined) {\n-                [[EMClient sharedClient].roomManager asyncLeaveChatroom:chatroomId success:^(EMChatroom *aRoom) {\n-                    [[EMClient sharedClient].chatManager deleteConversation:chatroomId deleteMessages:YES];\n-                } failure:^(EMError *aError) {\n-                    //leave failed\n+    [[EMClient sharedClient].roomManager joinChatroom:chatroomId completion:^(EMChatroom *aChatroom, EMError *aError) {\n+        EaseMessageViewController *strongSelf = weakSelf;","path":"EaseUI/EMUIKit/ViewController/EaseMessageViewController.m","position":57,"original_position":57,"commit_id":"dcbb37aa255c37192a8d83d05b1de94f33c9845f","original_commit_id":"dcbb37aa255c37192a8d83d05b1de94f33c9845f","user":{"login":"Neil-Cao","id":9793953,"avatar_url":"https://avatars.githubusercontent.com/u/9793953?v=3","gravatar_id":"","url":"https://api.github.com/users/Neil-Cao","html_url":"https://github.com/Neil-Cao","followers_url":"https://api.github.com/users/Neil-Cao/followers","following_url":"https://api.github.com/users/Neil-Cao/following{/other_user}","gists_url":"https://api.github.com/users/Neil-Cao/gists{/gist_id}","starred_url":"https://api.github.com/users/Neil-Cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neil-Cao/subscriptions","organizations_url":"https://api.github.com/users/Neil-Cao/orgs","repos_url":"https://api.github.com/users/Neil-Cao/repos","events_url":"https://api.github.com/users/Neil-Cao/events{/privacy}","received_events_url":"https://api.github.com/users/Neil-Cao/received_events","type":"User","site_admin":false},"body":"同上","created_at":"2016-07-28T01:46:28Z","updated_at":"2016-07-28T01:46:28Z","html_url":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS/pull/10#discussion_r72554076","pull_request_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/comments/72554076"},"html":{"href":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS/pull/10#discussion_r72554076"},"pull_request":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10","id":79019585,"html_url":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS/pull/10","diff_url":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS/pull/10.diff","patch_url":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS/pull/10.patch","issue_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/issues/10","number":10,"state":"open","locked":false,"title":"update used interface","user":{"login":"Neil-Cao","id":9793953,"avatar_url":"https://avatars.githubusercontent.com/u/9793953?v=3","gravatar_id":"","url":"https://api.github.com/users/Neil-Cao","html_url":"https://github.com/Neil-Cao","followers_url":"https://api.github.com/users/Neil-Cao/followers","following_url":"https://api.github.com/users/Neil-Cao/following{/other_user}","gists_url":"https://api.github.com/users/Neil-Cao/gists{/gist_id}","starred_url":"https://api.github.com/users/Neil-Cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neil-Cao/subscriptions","organizations_url":"https://api.github.com/users/Neil-Cao/orgs","repos_url":"https://api.github.com/users/Neil-Cao/repos","events_url":"https://api.github.com/users/Neil-Cao/events{/privacy}","received_events_url":"https://api.github.com/users/Neil-Cao/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-27T13:01:16Z","updated_at":"2016-07-28T01:46:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d63496e1b43201b18dd689fd775f556b55dbd7d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10/commits","review_comments_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10/comments","review_comment_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/issues/10/comments","statuses_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/statuses/dcbb37aa255c37192a8d83d05b1de94f33c9845f","head":{"label":"Neil-Cao:dev","ref":"dev","sha":"dcbb37aa255c37192a8d83d05b1de94f33c9845f","user":{"login":"Neil-Cao","id":9793953,"avatar_url":"https://avatars.githubusercontent.com/u/9793953?v=3","gravatar_id":"","url":"https://api.github.com/users/Neil-Cao","html_url":"https://github.com/Neil-Cao","followers_url":"https://api.github.com/users/Neil-Cao/followers","following_url":"https://api.github.com/users/Neil-Cao/following{/other_user}","gists_url":"https://api.github.com/users/Neil-Cao/gists{/gist_id}","starred_url":"https://api.github.com/users/Neil-Cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neil-Cao/subscriptions","organizations_url":"https://api.github.com/users/Neil-Cao/orgs","repos_url":"https://api.github.com/users/Neil-Cao/repos","events_url":"https://api.github.com/users/Neil-Cao/events{/privacy}","received_events_url":"https://api.github.com/users/Neil-Cao/received_events","type":"User","site_admin":false},"repo":{"id":64183076,"name":"Hyphenate-EaseUI-iOS","full_name":"Neil-Cao/Hyphenate-EaseUI-iOS","owner":{"login":"Neil-Cao","id":9793953,"avatar_url":"https://avatars.githubusercontent.com/u/9793953?v=3","gravatar_id":"","url":"https://api.github.com/users/Neil-Cao","html_url":"https://github.com/Neil-Cao","followers_url":"https://api.github.com/users/Neil-Cao/followers","following_url":"https://api.github.com/users/Neil-Cao/following{/other_user}","gists_url":"https://api.github.com/users/Neil-Cao/gists{/gist_id}","starred_url":"https://api.github.com/users/Neil-Cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neil-Cao/subscriptions","organizations_url":"https://api.github.com/users/Neil-Cao/orgs","repos_url":"https://api.github.com/users/Neil-Cao/repos","events_url":"https://api.github.com/users/Neil-Cao/events{/privacy}","received_events_url":"https://api.github.com/users/Neil-Cao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neil-Cao/Hyphenate-EaseUI-iOS","description":null,"fork":true,"url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS","forks_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/forks","keys_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/teams","hooks_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/hooks","issue_events_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/events","assignees_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/tags","blobs_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/languages","stargazers_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/stargazers","contributors_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/contributors","subscribers_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/subscribers","subscription_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/subscription","commits_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/merges","archive_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/downloads","issues_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/labels{/name}","releases_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/Neil-Cao/Hyphenate-EaseUI-iOS/deployments","created_at":"2016-07-26T02:24:43Z","updated_at":"2016-07-26T02:24:44Z","pushed_at":"2016-07-27T12:52:17Z","git_url":"git://github.com/Neil-Cao/Hyphenate-EaseUI-iOS.git","ssh_url":"git@github.com:Neil-Cao/Hyphenate-EaseUI-iOS.git","clone_url":"https://github.com/Neil-Cao/Hyphenate-EaseUI-iOS.git","svn_url":"https://github.com/Neil-Cao/Hyphenate-EaseUI-iOS","homepage":null,"size":3641,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HyphenateInc:dev","ref":"dev","sha":"6f4b870221528af4a7f6fb877a6847f1fb90fe7d","user":{"login":"HyphenateInc","id":18541999,"avatar_url":"https://avatars.githubusercontent.com/u/18541999?v=3","gravatar_id":"","url":"https://api.github.com/users/HyphenateInc","html_url":"https://github.com/HyphenateInc","followers_url":"https://api.github.com/users/HyphenateInc/followers","following_url":"https://api.github.com/users/HyphenateInc/following{/other_user}","gists_url":"https://api.github.com/users/HyphenateInc/gists{/gist_id}","starred_url":"https://api.github.com/users/HyphenateInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyphenateInc/subscriptions","organizations_url":"https://api.github.com/users/HyphenateInc/orgs","repos_url":"https://api.github.com/users/HyphenateInc/repos","events_url":"https://api.github.com/users/HyphenateInc/events{/privacy}","received_events_url":"https://api.github.com/users/HyphenateInc/received_events","type":"Organization","site_admin":false},"repo":{"id":57017799,"name":"Hyphenate-EaseUI-iOS","full_name":"HyphenateInc/Hyphenate-EaseUI-iOS","owner":{"login":"HyphenateInc","id":18541999,"avatar_url":"https://avatars.githubusercontent.com/u/18541999?v=3","gravatar_id":"","url":"https://api.github.com/users/HyphenateInc","html_url":"https://github.com/HyphenateInc","followers_url":"https://api.github.com/users/HyphenateInc/followers","following_url":"https://api.github.com/users/HyphenateInc/following{/other_user}","gists_url":"https://api.github.com/users/HyphenateInc/gists{/gist_id}","starred_url":"https://api.github.com/users/HyphenateInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyphenateInc/subscriptions","organizations_url":"https://api.github.com/users/HyphenateInc/orgs","repos_url":"https://api.github.com/users/HyphenateInc/repos","events_url":"https://api.github.com/users/HyphenateInc/events{/privacy}","received_events_url":"https://api.github.com/users/HyphenateInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS","description":"","fork":false,"url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS","forks_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/forks","keys_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/teams","hooks_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/hooks","issue_events_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/events","assignees_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/tags","blobs_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/languages","stargazers_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/stargazers","contributors_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/contributors","subscribers_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/subscribers","subscription_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/subscription","commits_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/merges","archive_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/downloads","issues_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/labels{/name}","releases_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/deployments","created_at":"2016-04-25T06:41:20Z","updated_at":"2016-06-21T22:17:23Z","pushed_at":"2016-07-27T13:01:16Z","git_url":"git://github.com/HyphenateInc/Hyphenate-EaseUI-iOS.git","ssh_url":"git@github.com:HyphenateInc/Hyphenate-EaseUI-iOS.git","clone_url":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS.git","svn_url":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS","homepage":null,"size":3652,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10"},"html":{"href":"https://github.com/HyphenateInc/Hyphenate-EaseUI-iOS/pull/10"},"issue":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/issues/10"},"comments":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/HyphenateInc/Hyphenate-EaseUI-iOS/statuses/dcbb37aa255c37192a8d83d05b1de94f33c9845f"}}}}
{"actor":{"display_login":"Neil-Cao"}}