{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/608","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/608/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/608/events","html_url":"https://github.com/GoogleChrome/lighthouse/pull/608","id":172813339,"number":608,"title":"filterPasses -> validatePasses","user":{"login":"paulirish","id":39191,"avatar_url":"https://avatars.githubusercontent.com/u/39191?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-23T21:36:19Z","updated_at":"2016-08-23T22:31:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/608","html_url":"https://github.com/GoogleChrome/lighthouse/pull/608","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/608.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/608.patch"},"body":"The current filterPass behavior implies that the user can leave all default core gatherers in the config and we'll remove the ones that aren't needed.\r\n\r\nThis is a bit odd as audits and aggregation sections must be correct, so we shouldn't make gatherers in particular be so forgiving.\r\n\r\nFurthermore, the custom perf config no longer requires any core gatherers. It only needs trace & network records, which, without this PR, will end up filtering out the only pass in the config. \r\n\r\nNow instead of changing the config, config.js will issue warnings when gatherers are specified in the config that appear to be unnecessary. The resolution is adjusting the config."},"comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments/241901161","html_url":"https://github.com/GoogleChrome/lighthouse/pull/608#issuecomment-241901161","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/608","id":241901161,"user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T22:31:44Z","updated_at":"2016-08-23T22:31:44Z","body":"I think this still messes up the config object if it's kept around externally to lighthouse, but there should really be a test for that sort of thing :)"}}
{"actor":{"display_login":"brendankenny"}}