{"action":"created","comment":{"url":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/comments/87696681","pull_request_review_id":8301481,"id":87696681,"diff_hunk":"@@ -9,8 +10,8 @@ pub type BcryptResult<T> = Result<T, BcryptError>;\n /// passwords\n pub enum BcryptError {\n     Io(io::Error),\n-    InvalidCost,\n-    InvalidPrefix\n+    InvalidCost(u32),\n+    InvalidPrefix(String),","path":"src/errors.rs","position":16,"original_position":16,"commit_id":"c6fd4f1574b37ee1eab66de27a4c589804b179c2","original_commit_id":"c6fd4f1574b37ee1eab66de27a4c589804b179c2","user":{"login":"drusellers","id":63355,"avatar_url":"https://avatars.githubusercontent.com/u/63355?v=3","gravatar_id":"","url":"https://api.github.com/users/drusellers","html_url":"https://github.com/drusellers","followers_url":"https://api.github.com/users/drusellers/followers","following_url":"https://api.github.com/users/drusellers/following{/other_user}","gists_url":"https://api.github.com/users/drusellers/gists{/gist_id}","starred_url":"https://api.github.com/users/drusellers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drusellers/subscriptions","organizations_url":"https://api.github.com/users/drusellers/orgs","repos_url":"https://api.github.com/users/drusellers/repos","events_url":"https://api.github.com/users/drusellers/events{/privacy}","received_events_url":"https://api.github.com/users/drusellers/received_events","type":"User","site_admin":false},"body":"I'm not pleased with this - but that is because of my newness to rust.","created_at":"2016-11-12T17:36:22Z","updated_at":"2016-11-12T17:36:22Z","html_url":"https://github.com/Keats/rust-bcrypt/pull/3#discussion_r87696681","pull_request_url":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/comments/87696681"},"html":{"href":"https://github.com/Keats/rust-bcrypt/pull/3#discussion_r87696681"},"pull_request":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3","id":93445804,"html_url":"https://github.com/Keats/rust-bcrypt/pull/3","diff_url":"https://github.com/Keats/rust-bcrypt/pull/3.diff","patch_url":"https://github.com/Keats/rust-bcrypt/pull/3.patch","issue_url":"https://api.github.com/repos/Keats/rust-bcrypt/issues/3","number":3,"state":"open","locked":false,"title":"Implement Error Trait for BcryptError","user":{"login":"drusellers","id":63355,"avatar_url":"https://avatars.githubusercontent.com/u/63355?v=3","gravatar_id":"","url":"https://api.github.com/users/drusellers","html_url":"https://github.com/drusellers","followers_url":"https://api.github.com/users/drusellers/followers","following_url":"https://api.github.com/users/drusellers/following{/other_user}","gists_url":"https://api.github.com/users/drusellers/gists{/gist_id}","starred_url":"https://api.github.com/users/drusellers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drusellers/subscriptions","organizations_url":"https://api.github.com/users/drusellers/orgs","repos_url":"https://api.github.com/users/drusellers/repos","events_url":"https://api.github.com/users/drusellers/events{/privacy}","received_events_url":"https://api.github.com/users/drusellers/received_events","type":"User","site_admin":false},"body":"Questions to be answered:\r\n\r\n- Should the error expose the invalid options supplied by the user?\r\n- Is the `.to_string()` call acceptable on line 93 of lib.rs","created_at":"2016-11-12T17:36:00Z","updated_at":"2016-11-12T17:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa3b62bd442a2e549c44d936c048a9ad1f97bc95","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Keats/rust-bcrypt/issues/3/comments","statuses_url":"https://api.github.com/repos/Keats/rust-bcrypt/statuses/c6fd4f1574b37ee1eab66de27a4c589804b179c2","head":{"label":"drusellers:implement-error","ref":"implement-error","sha":"c6fd4f1574b37ee1eab66de27a4c589804b179c2","user":{"login":"drusellers","id":63355,"avatar_url":"https://avatars.githubusercontent.com/u/63355?v=3","gravatar_id":"","url":"https://api.github.com/users/drusellers","html_url":"https://github.com/drusellers","followers_url":"https://api.github.com/users/drusellers/followers","following_url":"https://api.github.com/users/drusellers/following{/other_user}","gists_url":"https://api.github.com/users/drusellers/gists{/gist_id}","starred_url":"https://api.github.com/users/drusellers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drusellers/subscriptions","organizations_url":"https://api.github.com/users/drusellers/orgs","repos_url":"https://api.github.com/users/drusellers/repos","events_url":"https://api.github.com/users/drusellers/events{/privacy}","received_events_url":"https://api.github.com/users/drusellers/received_events","type":"User","site_admin":false},"repo":{"id":73567097,"name":"rust-bcrypt","full_name":"drusellers/rust-bcrypt","owner":{"login":"drusellers","id":63355,"avatar_url":"https://avatars.githubusercontent.com/u/63355?v=3","gravatar_id":"","url":"https://api.github.com/users/drusellers","html_url":"https://github.com/drusellers","followers_url":"https://api.github.com/users/drusellers/followers","following_url":"https://api.github.com/users/drusellers/following{/other_user}","gists_url":"https://api.github.com/users/drusellers/gists{/gist_id}","starred_url":"https://api.github.com/users/drusellers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drusellers/subscriptions","organizations_url":"https://api.github.com/users/drusellers/orgs","repos_url":"https://api.github.com/users/drusellers/repos","events_url":"https://api.github.com/users/drusellers/events{/privacy}","received_events_url":"https://api.github.com/users/drusellers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drusellers/rust-bcrypt","description":"Easily hash and verify passwords using Bcrypt","fork":true,"url":"https://api.github.com/repos/drusellers/rust-bcrypt","forks_url":"https://api.github.com/repos/drusellers/rust-bcrypt/forks","keys_url":"https://api.github.com/repos/drusellers/rust-bcrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drusellers/rust-bcrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drusellers/rust-bcrypt/teams","hooks_url":"https://api.github.com/repos/drusellers/rust-bcrypt/hooks","issue_events_url":"https://api.github.com/repos/drusellers/rust-bcrypt/issues/events{/number}","events_url":"https://api.github.com/repos/drusellers/rust-bcrypt/events","assignees_url":"https://api.github.com/repos/drusellers/rust-bcrypt/assignees{/user}","branches_url":"https://api.github.com/repos/drusellers/rust-bcrypt/branches{/branch}","tags_url":"https://api.github.com/repos/drusellers/rust-bcrypt/tags","blobs_url":"https://api.github.com/repos/drusellers/rust-bcrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drusellers/rust-bcrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drusellers/rust-bcrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/drusellers/rust-bcrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drusellers/rust-bcrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/drusellers/rust-bcrypt/languages","stargazers_url":"https://api.github.com/repos/drusellers/rust-bcrypt/stargazers","contributors_url":"https://api.github.com/repos/drusellers/rust-bcrypt/contributors","subscribers_url":"https://api.github.com/repos/drusellers/rust-bcrypt/subscribers","subscription_url":"https://api.github.com/repos/drusellers/rust-bcrypt/subscription","commits_url":"https://api.github.com/repos/drusellers/rust-bcrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/drusellers/rust-bcrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/drusellers/rust-bcrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/drusellers/rust-bcrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/drusellers/rust-bcrypt/contents/{+path}","compare_url":"https://api.github.com/repos/drusellers/rust-bcrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drusellers/rust-bcrypt/merges","archive_url":"https://api.github.com/repos/drusellers/rust-bcrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drusellers/rust-bcrypt/downloads","issues_url":"https://api.github.com/repos/drusellers/rust-bcrypt/issues{/number}","pulls_url":"https://api.github.com/repos/drusellers/rust-bcrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/drusellers/rust-bcrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/drusellers/rust-bcrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drusellers/rust-bcrypt/labels{/name}","releases_url":"https://api.github.com/repos/drusellers/rust-bcrypt/releases{/id}","deployments_url":"https://api.github.com/repos/drusellers/rust-bcrypt/deployments","created_at":"2016-11-12T17:19:25Z","updated_at":"2016-11-12T17:19:26Z","pushed_at":"2016-11-12T17:34:39Z","git_url":"git://github.com/drusellers/rust-bcrypt.git","ssh_url":"git@github.com:drusellers/rust-bcrypt.git","clone_url":"https://github.com/drusellers/rust-bcrypt.git","svn_url":"https://github.com/drusellers/rust-bcrypt","homepage":"","size":10,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Keats:master","ref":"master","sha":"a238b189ba3f648ec784b3040eef0437929c8eb9","user":{"login":"Keats","id":680355,"avatar_url":"https://avatars.githubusercontent.com/u/680355?v=3","gravatar_id":"","url":"https://api.github.com/users/Keats","html_url":"https://github.com/Keats","followers_url":"https://api.github.com/users/Keats/followers","following_url":"https://api.github.com/users/Keats/following{/other_user}","gists_url":"https://api.github.com/users/Keats/gists{/gist_id}","starred_url":"https://api.github.com/users/Keats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keats/subscriptions","organizations_url":"https://api.github.com/users/Keats/orgs","repos_url":"https://api.github.com/users/Keats/repos","events_url":"https://api.github.com/users/Keats/events{/privacy}","received_events_url":"https://api.github.com/users/Keats/received_events","type":"User","site_admin":false},"repo":{"id":48337314,"name":"rust-bcrypt","full_name":"Keats/rust-bcrypt","owner":{"login":"Keats","id":680355,"avatar_url":"https://avatars.githubusercontent.com/u/680355?v=3","gravatar_id":"","url":"https://api.github.com/users/Keats","html_url":"https://github.com/Keats","followers_url":"https://api.github.com/users/Keats/followers","following_url":"https://api.github.com/users/Keats/following{/other_user}","gists_url":"https://api.github.com/users/Keats/gists{/gist_id}","starred_url":"https://api.github.com/users/Keats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keats/subscriptions","organizations_url":"https://api.github.com/users/Keats/orgs","repos_url":"https://api.github.com/users/Keats/repos","events_url":"https://api.github.com/users/Keats/events{/privacy}","received_events_url":"https://api.github.com/users/Keats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Keats/rust-bcrypt","description":"Easily hash and verify passwords using Bcrypt","fork":false,"url":"https://api.github.com/repos/Keats/rust-bcrypt","forks_url":"https://api.github.com/repos/Keats/rust-bcrypt/forks","keys_url":"https://api.github.com/repos/Keats/rust-bcrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keats/rust-bcrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keats/rust-bcrypt/teams","hooks_url":"https://api.github.com/repos/Keats/rust-bcrypt/hooks","issue_events_url":"https://api.github.com/repos/Keats/rust-bcrypt/issues/events{/number}","events_url":"https://api.github.com/repos/Keats/rust-bcrypt/events","assignees_url":"https://api.github.com/repos/Keats/rust-bcrypt/assignees{/user}","branches_url":"https://api.github.com/repos/Keats/rust-bcrypt/branches{/branch}","tags_url":"https://api.github.com/repos/Keats/rust-bcrypt/tags","blobs_url":"https://api.github.com/repos/Keats/rust-bcrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keats/rust-bcrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keats/rust-bcrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keats/rust-bcrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keats/rust-bcrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/Keats/rust-bcrypt/languages","stargazers_url":"https://api.github.com/repos/Keats/rust-bcrypt/stargazers","contributors_url":"https://api.github.com/repos/Keats/rust-bcrypt/contributors","subscribers_url":"https://api.github.com/repos/Keats/rust-bcrypt/subscribers","subscription_url":"https://api.github.com/repos/Keats/rust-bcrypt/subscription","commits_url":"https://api.github.com/repos/Keats/rust-bcrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keats/rust-bcrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keats/rust-bcrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keats/rust-bcrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keats/rust-bcrypt/contents/{+path}","compare_url":"https://api.github.com/repos/Keats/rust-bcrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keats/rust-bcrypt/merges","archive_url":"https://api.github.com/repos/Keats/rust-bcrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keats/rust-bcrypt/downloads","issues_url":"https://api.github.com/repos/Keats/rust-bcrypt/issues{/number}","pulls_url":"https://api.github.com/repos/Keats/rust-bcrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/Keats/rust-bcrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/Keats/rust-bcrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keats/rust-bcrypt/labels{/name}","releases_url":"https://api.github.com/repos/Keats/rust-bcrypt/releases{/id}","deployments_url":"https://api.github.com/repos/Keats/rust-bcrypt/deployments","created_at":"2015-12-20T21:10:01Z","updated_at":"2016-10-29T10:42:20Z","pushed_at":"2016-11-12T17:36:00Z","git_url":"git://github.com/Keats/rust-bcrypt.git","ssh_url":"git@github.com:Keats/rust-bcrypt.git","clone_url":"https://github.com/Keats/rust-bcrypt.git","svn_url":"https://github.com/Keats/rust-bcrypt","homepage":"","size":10,"stargazers_count":6,"watchers_count":6,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3"},"html":{"href":"https://github.com/Keats/rust-bcrypt/pull/3"},"issue":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/issues/3"},"comments":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Keats/rust-bcrypt/statuses/c6fd4f1574b37ee1eab66de27a4c589804b179c2"}}}}
{"actor":{"display_login":"drusellers"}}