{"action":"created","issue":{"url":"https://api.github.com/repos/stealjs/steal-tools/issues/561","repository_url":"https://api.github.com/repos/stealjs/steal-tools","labels_url":"https://api.github.com/repos/stealjs/steal-tools/issues/561/labels{/name}","comments_url":"https://api.github.com/repos/stealjs/steal-tools/issues/561/comments","events_url":"https://api.github.com/repos/stealjs/steal-tools/issues/561/events","html_url":"https://github.com/stealjs/steal-tools/issues/561","id":191134131,"number":561,"title":"Add warnings based on bundle size","user":{"login":"matthewp","id":361671,"avatar_url":"https://avatars.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},"labels":[{"id":390132113,"url":"https://api.github.com/repos/stealjs/steal-tools/labels/enhancement","name":"enhancement","color":"82a7f2","default":true},{"id":298217645,"url":"https://api.github.com/repos/stealjs/steal-tools/labels/error%20messages","name":"error messages","color":"fad8c7","default":false},{"id":49433619,"url":"https://api.github.com/repos/stealjs/steal-tools/labels/feature","name":"feature","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-22T21:52:15Z","updated_at":"2016-11-25T23:16:09Z","closed_at":null,"body":"One takeaway from the [performance audit] is that steal-tools doesn't do anything to prevent oversized bundles. It's still incredibly easy to have large bundles.\r\n\r\nsteal-tools could warn about this and link to documentation on using progressive loading. I would propose that **100k** be the maximum bundle size allowed.\r\n\r\nWe'll be super annoying about it, and require a specific flag to turn this warning off."},"comment":{"url":"https://api.github.com/repos/stealjs/steal-tools/issues/comments/263031485","html_url":"https://github.com/stealjs/steal-tools/issues/561#issuecomment-263031485","issue_url":"https://api.github.com/repos/stealjs/steal-tools/issues/561","id":263031485,"user":{"login":"justinbmeyer","id":78602,"avatar_url":"https://avatars.githubusercontent.com/u/78602?v=3","gravatar_id":"","url":"https://api.github.com/users/justinbmeyer","html_url":"https://github.com/justinbmeyer","followers_url":"https://api.github.com/users/justinbmeyer/followers","following_url":"https://api.github.com/users/justinbmeyer/following{/other_user}","gists_url":"https://api.github.com/users/justinbmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/justinbmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinbmeyer/subscriptions","organizations_url":"https://api.github.com/users/justinbmeyer/orgs","repos_url":"https://api.github.com/users/justinbmeyer/repos","events_url":"https://api.github.com/users/justinbmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/justinbmeyer/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T23:16:09Z","updated_at":"2016-11-25T23:16:09Z","body":"Sorry, I miss read the original issue.  I thought you were intending to _NOT_ produce a build if people were over.  Yeah, a warning is totally fine. \r\n\r\nFor this to work for donejs, we probably need some lazy way of loading or setting up a `<can-datepicker>`.  Otherwise, it might be pretty hard to get the size down."}}
{"actor":{"display_login":"justinbmeyer"}}