{"action":"closed","number":96,"pull_request":{"url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/96","id":77305119,"html_url":"https://github.com/Inria-Asclepios/medInria-public/pull/96","diff_url":"https://github.com/Inria-Asclepios/medInria-public/pull/96.diff","patch_url":"https://github.com/Inria-Asclepios/medInria-public/pull/96.patch","issue_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/issues/96","number":96,"state":"closed","locked":false,"title":"Scene saving/loading moves from medMainWindow to medViewContainer","user":{"login":"LoicCadour","id":3705584,"avatar_url":"https://avatars.githubusercontent.com/u/3705584?v=3","gravatar_id":"","url":"https://api.github.com/users/LoicCadour","html_url":"https://github.com/LoicCadour","followers_url":"https://api.github.com/users/LoicCadour/followers","following_url":"https://api.github.com/users/LoicCadour/following{/other_user}","gists_url":"https://api.github.com/users/LoicCadour/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicCadour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicCadour/subscriptions","organizations_url":"https://api.github.com/users/LoicCadour/orgs","repos_url":"https://api.github.com/users/LoicCadour/repos","events_url":"https://api.github.com/users/LoicCadour/events{/privacy}","received_events_url":"https://api.github.com/users/LoicCadour/received_events","type":"User","site_admin":false},"body":"### The problems\r\nIssue https://github.com/Inria-Asclepios/medInria-public/issues/84\r\nThe original pb comes from the fact that we now add metadata to our files and the CARTO systems don't like it. We dealt with this in MUSIC, but not in MUSIC Viewer, so CARTO files exported with MUSIC Viewer still have these metadata.\r\n\r\nRather than modifying MUSIC Viewer, I changed the vtk files sent to the centres (in what we call a scene).\r\nThus, I want to remove the fieldData of the vtk files, but to do that I need VTK methods. However, we export the vtk files, the scene, in medMainWindow, which is in the core. The core, that isn't linked to VTK.\r\n\r\nFurthermore, we would like to have a user-friendly way to save the scene at the end of a pipeline, so we need easy access to these methods (which is not the case in medMainWindow).\r\n\r\n### The solution proposed\r\nThis makes me move the code of scene saving to medViewContainer: \r\n_ a scene is basically the content of a container, by definition. _Warning_: we used to be able to save several containers (containers side by side) in a scene, with my code we can't anymore. A scene is a container. Full stop. If you want to save several containers, save several scenes.\r\n_ a container is easily reachable (if you know the workspace, you know its container(s))\r\n\r\nA drawback of of this approach is that we used to make the scene aware of the workspace you were in (i.e if you save the scene while being in the Segmentation workspace, then when loading the scene, it will automatically switch to this workspace). I don't find it very useful, but I prefer to let you know the losses.\r\n\r\nNow a screenshot, for the GUI:\r\n![screen shot 2016-07-13 at 16 54 26](https://cloud.githubusercontent.com/assets/3705584/16807909/917d0db6-491a-11e6-8661-95b12fd9129d.png)\r\n\r\nThe load/save scene buttons are rm from the status bar.\r\n`Load` can now be done from a button inside an empty container.\r\n`Save`, well ... you can see.\r\n\r\nSince the export is used to send the data to the centres, please test this PR.\r\nI'll do another one on the music-plugins to add the export button to the final display step.\r\n(Note: I had to add this button icon in medInria-public)","created_at":"2016-07-13T15:02:42Z","updated_at":"2016-07-25T13:59:09Z","closed_at":"2016-07-25T13:59:08Z","merged_at":"2016-07-25T13:59:08Z","merge_commit_sha":"ca89686f1391c90236805349831fb06e026832ec","assignee":{"login":"LoicCadour","id":3705584,"avatar_url":"https://avatars.githubusercontent.com/u/3705584?v=3","gravatar_id":"","url":"https://api.github.com/users/LoicCadour","html_url":"https://github.com/LoicCadour","followers_url":"https://api.github.com/users/LoicCadour/followers","following_url":"https://api.github.com/users/LoicCadour/following{/other_user}","gists_url":"https://api.github.com/users/LoicCadour/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicCadour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicCadour/subscriptions","organizations_url":"https://api.github.com/users/LoicCadour/orgs","repos_url":"https://api.github.com/users/LoicCadour/repos","events_url":"https://api.github.com/users/LoicCadour/events{/privacy}","received_events_url":"https://api.github.com/users/LoicCadour/received_events","type":"User","site_admin":false},"assignees":[{"login":"LoicCadour","id":3705584,"avatar_url":"https://avatars.githubusercontent.com/u/3705584?v=3","gravatar_id":"","url":"https://api.github.com/users/LoicCadour","html_url":"https://github.com/LoicCadour","followers_url":"https://api.github.com/users/LoicCadour/followers","following_url":"https://api.github.com/users/LoicCadour/following{/other_user}","gists_url":"https://api.github.com/users/LoicCadour/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicCadour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicCadour/subscriptions","organizations_url":"https://api.github.com/users/LoicCadour/orgs","repos_url":"https://api.github.com/users/LoicCadour/repos","events_url":"https://api.github.com/users/LoicCadour/events{/privacy}","received_events_url":"https://api.github.com/users/LoicCadour/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/milestones/2","html_url":"https://github.com/Inria-Asclepios/medInria-public/milestones/v1.1.0","labels_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/milestones/2/labels","id":1804921,"number":2,"title":"v1.1.0","description":"","creator":{"login":"LoicCadour","id":3705584,"avatar_url":"https://avatars.githubusercontent.com/u/3705584?v=3","gravatar_id":"","url":"https://api.github.com/users/LoicCadour","html_url":"https://github.com/LoicCadour","followers_url":"https://api.github.com/users/LoicCadour/followers","following_url":"https://api.github.com/users/LoicCadour/following{/other_user}","gists_url":"https://api.github.com/users/LoicCadour/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicCadour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicCadour/subscriptions","organizations_url":"https://api.github.com/users/LoicCadour/orgs","repos_url":"https://api.github.com/users/LoicCadour/repos","events_url":"https://api.github.com/users/LoicCadour/events{/privacy}","received_events_url":"https://api.github.com/users/LoicCadour/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":6,"state":"open","created_at":"2016-06-02T13:10:32Z","updated_at":"2016-07-25T13:59:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/96/commits","review_comments_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/96/comments","review_comment_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/issues/96/comments","statuses_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/statuses/0755fc7eb2e3c518abbe67156d8e4dcf5b560b8a","head":{"label":"LoicCadour:scene","ref":"scene","sha":"0755fc7eb2e3c518abbe67156d8e4dcf5b560b8a","user":{"login":"LoicCadour","id":3705584,"avatar_url":"https://avatars.githubusercontent.com/u/3705584?v=3","gravatar_id":"","url":"https://api.github.com/users/LoicCadour","html_url":"https://github.com/LoicCadour","followers_url":"https://api.github.com/users/LoicCadour/followers","following_url":"https://api.github.com/users/LoicCadour/following{/other_user}","gists_url":"https://api.github.com/users/LoicCadour/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicCadour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicCadour/subscriptions","organizations_url":"https://api.github.com/users/LoicCadour/orgs","repos_url":"https://api.github.com/users/LoicCadour/repos","events_url":"https://api.github.com/users/LoicCadour/events{/privacy}","received_events_url":"https://api.github.com/users/LoicCadour/received_events","type":"User","site_admin":false},"repo":{"id":8948739,"name":"medInria-public","full_name":"LoicCadour/medInria-public","owner":{"login":"LoicCadour","id":3705584,"avatar_url":"https://avatars.githubusercontent.com/u/3705584?v=3","gravatar_id":"","url":"https://api.github.com/users/LoicCadour","html_url":"https://github.com/LoicCadour","followers_url":"https://api.github.com/users/LoicCadour/followers","following_url":"https://api.github.com/users/LoicCadour/following{/other_user}","gists_url":"https://api.github.com/users/LoicCadour/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicCadour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicCadour/subscriptions","organizations_url":"https://api.github.com/users/LoicCadour/orgs","repos_url":"https://api.github.com/users/LoicCadour/repos","events_url":"https://api.github.com/users/LoicCadour/events{/privacy}","received_events_url":"https://api.github.com/users/LoicCadour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LoicCadour/medInria-public","description":"Open-source part of the medInria software","fork":true,"url":"https://api.github.com/repos/LoicCadour/medInria-public","forks_url":"https://api.github.com/repos/LoicCadour/medInria-public/forks","keys_url":"https://api.github.com/repos/LoicCadour/medInria-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LoicCadour/medInria-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LoicCadour/medInria-public/teams","hooks_url":"https://api.github.com/repos/LoicCadour/medInria-public/hooks","issue_events_url":"https://api.github.com/repos/LoicCadour/medInria-public/issues/events{/number}","events_url":"https://api.github.com/repos/LoicCadour/medInria-public/events","assignees_url":"https://api.github.com/repos/LoicCadour/medInria-public/assignees{/user}","branches_url":"https://api.github.com/repos/LoicCadour/medInria-public/branches{/branch}","tags_url":"https://api.github.com/repos/LoicCadour/medInria-public/tags","blobs_url":"https://api.github.com/repos/LoicCadour/medInria-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LoicCadour/medInria-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LoicCadour/medInria-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/LoicCadour/medInria-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LoicCadour/medInria-public/statuses/{sha}","languages_url":"https://api.github.com/repos/LoicCadour/medInria-public/languages","stargazers_url":"https://api.github.com/repos/LoicCadour/medInria-public/stargazers","contributors_url":"https://api.github.com/repos/LoicCadour/medInria-public/contributors","subscribers_url":"https://api.github.com/repos/LoicCadour/medInria-public/subscribers","subscription_url":"https://api.github.com/repos/LoicCadour/medInria-public/subscription","commits_url":"https://api.github.com/repos/LoicCadour/medInria-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/LoicCadour/medInria-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/LoicCadour/medInria-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/LoicCadour/medInria-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/LoicCadour/medInria-public/contents/{+path}","compare_url":"https://api.github.com/repos/LoicCadour/medInria-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LoicCadour/medInria-public/merges","archive_url":"https://api.github.com/repos/LoicCadour/medInria-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LoicCadour/medInria-public/downloads","issues_url":"https://api.github.com/repos/LoicCadour/medInria-public/issues{/number}","pulls_url":"https://api.github.com/repos/LoicCadour/medInria-public/pulls{/number}","milestones_url":"https://api.github.com/repos/LoicCadour/medInria-public/milestones{/number}","notifications_url":"https://api.github.com/repos/LoicCadour/medInria-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LoicCadour/medInria-public/labels{/name}","releases_url":"https://api.github.com/repos/LoicCadour/medInria-public/releases{/id}","deployments_url":"https://api.github.com/repos/LoicCadour/medInria-public/deployments","created_at":"2013-03-22T09:29:11Z","updated_at":"2015-04-24T13:28:05Z","pushed_at":"2016-07-22T15:34:41Z","git_url":"git://github.com/LoicCadour/medInria-public.git","ssh_url":"git@github.com:LoicCadour/medInria-public.git","clone_url":"https://github.com/LoicCadour/medInria-public.git","svn_url":"https://github.com/LoicCadour/medInria-public","homepage":null,"size":110192,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Inria-Asclepios:integration","ref":"integration","sha":"69c7273c73ffad605256f5289a0819b434de12db","user":{"login":"Inria-Asclepios","id":3994836,"avatar_url":"https://avatars.githubusercontent.com/u/3994836?v=3","gravatar_id":"","url":"https://api.github.com/users/Inria-Asclepios","html_url":"https://github.com/Inria-Asclepios","followers_url":"https://api.github.com/users/Inria-Asclepios/followers","following_url":"https://api.github.com/users/Inria-Asclepios/following{/other_user}","gists_url":"https://api.github.com/users/Inria-Asclepios/gists{/gist_id}","starred_url":"https://api.github.com/users/Inria-Asclepios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inria-Asclepios/subscriptions","organizations_url":"https://api.github.com/users/Inria-Asclepios/orgs","repos_url":"https://api.github.com/users/Inria-Asclepios/repos","events_url":"https://api.github.com/users/Inria-Asclepios/events{/privacy}","received_events_url":"https://api.github.com/users/Inria-Asclepios/received_events","type":"Organization","site_admin":false},"repo":{"id":45173573,"name":"medInria-public","full_name":"Inria-Asclepios/medInria-public","owner":{"login":"Inria-Asclepios","id":3994836,"avatar_url":"https://avatars.githubusercontent.com/u/3994836?v=3","gravatar_id":"","url":"https://api.github.com/users/Inria-Asclepios","html_url":"https://github.com/Inria-Asclepios","followers_url":"https://api.github.com/users/Inria-Asclepios/followers","following_url":"https://api.github.com/users/Inria-Asclepios/following{/other_user}","gists_url":"https://api.github.com/users/Inria-Asclepios/gists{/gist_id}","starred_url":"https://api.github.com/users/Inria-Asclepios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inria-Asclepios/subscriptions","organizations_url":"https://api.github.com/users/Inria-Asclepios/orgs","repos_url":"https://api.github.com/users/Inria-Asclepios/repos","events_url":"https://api.github.com/users/Inria-Asclepios/events{/privacy}","received_events_url":"https://api.github.com/users/Inria-Asclepios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Inria-Asclepios/medInria-public","description":"Open-source part of the medInria software","fork":true,"url":"https://api.github.com/repos/Inria-Asclepios/medInria-public","forks_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/forks","keys_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/teams","hooks_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/hooks","issue_events_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/issues/events{/number}","events_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/events","assignees_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/assignees{/user}","branches_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/branches{/branch}","tags_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/tags","blobs_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/statuses/{sha}","languages_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/languages","stargazers_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/stargazers","contributors_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/contributors","subscribers_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/subscribers","subscription_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/subscription","commits_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/contents/{+path}","compare_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/merges","archive_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/downloads","issues_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/issues{/number}","pulls_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls{/number}","milestones_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/milestones{/number}","notifications_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/labels{/name}","releases_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/releases{/id}","deployments_url":"https://api.github.com/repos/Inria-Asclepios/medInria-public/deployments","created_at":"2015-10-29T09:37:20Z","updated_at":"2016-02-03T13:16:42Z","pushed_at":"2016-07-25T13:59:08Z","git_url":"git://github.com/Inria-Asclepios/medInria-public.git","ssh_url":"git@github.com:Inria-Asclepios/medInria-public.git","clone_url":"https://github.com/Inria-Asclepios/medInria-public.git","svn_url":"https://github.com/Inria-Asclepios/medInria-public","homepage":"https://med.inria.fr/","size":29707,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":40,"forks":1,"open_issues":40,"watchers":0,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/96"},"html":{"href":"https://github.com/Inria-Asclepios/medInria-public/pull/96"},"issue":{"href":"https://api.github.com/repos/Inria-Asclepios/medInria-public/issues/96"},"comments":{"href":"https://api.github.com/repos/Inria-Asclepios/medInria-public/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Inria-Asclepios/medInria-public/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/Inria-Asclepios/medInria-public/statuses/0755fc7eb2e3c518abbe67156d8e4dcf5b560b8a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"LoicCadour","id":3705584,"avatar_url":"https://avatars.githubusercontent.com/u/3705584?v=3","gravatar_id":"","url":"https://api.github.com/users/LoicCadour","html_url":"https://github.com/LoicCadour","followers_url":"https://api.github.com/users/LoicCadour/followers","following_url":"https://api.github.com/users/LoicCadour/following{/other_user}","gists_url":"https://api.github.com/users/LoicCadour/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicCadour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicCadour/subscriptions","organizations_url":"https://api.github.com/users/LoicCadour/orgs","repos_url":"https://api.github.com/users/LoicCadour/repos","events_url":"https://api.github.com/users/LoicCadour/events{/privacy}","received_events_url":"https://api.github.com/users/LoicCadour/received_events","type":"User","site_admin":false},"comments":3,"review_comments":27,"commits":6,"additions":200,"deletions":202,"changed_files":6}}
{"actor":{"display_login":"LoicCadour"}}