{"push_id":1008973656,"size":1000,"distinct_size":6240,"ref":"refs/heads/master","head":"ab7ad20125c0e0a199100fc12c2b7d67d90a6308","before":"e539866d80fa614412f65a12a63a9063fd89ce5e","commits":[{"sha":"ce37de4a19447fc89d2d16f15ba9314fba30d47e","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Add a couple of tests that connect with a WS client","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/ce37de4a19447fc89d2d16f15ba9314fba30d47e"},{"sha":"786ed1b3ad8eeddb911211b67031016730ed55c8","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Handle more IO errors (especially, ECONNRESET)\n\nAlso, address the possibility of the listen thread dying and needing to\nbe respawned. As a bonus, we now defer construction of the thread until\nwe are first given something to monitor.","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/786ed1b3ad8eeddb911211b67031016730ed55c8"},{"sha":"0b94afb0757e02deccced2d85b8478b78f269e0b","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Be more patient while gathering the expected responses","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/0b94afb0757e02deccced2d85b8478b78f269e0b"},{"sha":"3043601d7ab4a3b0e7eea1c6353ab96258f8a78c","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Reduce the client count, in hope of a more consistent test","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/3043601d7ab4a3b0e7eea1c6353ab96258f8a78c"},{"sha":"4d01cd1545a00ed6f96d6cb658a590afd36e1871","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Keep the socket reference after close\n\nWe may still try to send to it.","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/4d01cd1545a00ed6f96d6cb658a590afd36e1871"},{"sha":"703ddadafee29c86ca5be499a80802fbea70a64f","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Merge pull request #23305 from matthewd/concurrent-take-2\n\nEventMachine -> concurrent-ruby, take two","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/703ddadafee29c86ca5be499a80802fbea70a64f"},{"sha":"1c893bc2f94fd2e9e2c0d253eac0faedcd0046b8","author":{"email":"0a7d3d8a45fbf89426fa3c4779ad44e458bb44c6@gmail.com","name":"Kesha Antonov"},"message":"remove require logging","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/1c893bc2f94fd2e9e2c0d253eac0faedcd0046b8"},{"sha":"7d288244b25604d47edc2adaeb7040301cf6c95d","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael França"},"message":"Merge pull request #23336 from kesha-antonov/patch-1\n\nremove require logging","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/7d288244b25604d47edc2adaeb7040301cf6c95d"},{"sha":"da6342779b3228e1796ed4e3c385b52d60821b0f","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Intervene on change_table as well as create_table","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/da6342779b3228e1796ed4e3c385b52d60821b0f"},{"sha":"e6d0d4b1ae1970f3c4379f5bc2c4147a227221c3","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Don't bother stopping EM between tests\n\nIt's not strictly necessary, and maybe this will help with the current\ntest failure.","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/e6d0d4b1ae1970f3c4379f5bc2c4147a227221c3"},{"sha":"349f187f58491f2c2ef929ec0b46d78d4e888e85","author":{"email":"47cf6a1e5193cc6bf5084681d4b1c88e5a578125@gmail.com","name":"Tawan Sierek"},"message":"Add additional documentation on Headers#[] [ci skip]\n\nIssue #16519 covers confusion potentially caused by how HTTP\nheaders, that contain underscores in their names, are retrieved\nthrough `ActionDispatch::Http::Headers#[]`.\n\nThis confusion has its origin in how a CGI maps HTTP header names\nto variable names. Even though underscores in header names\nare rarely encountered, they are valid according to RFC822 [1].\nNonetheless CGI like variable names, as requested by the Rack\nspecfication, will only contain underscores and therefore the\noriginal header name cannot be recovered after the Rack server passed\non the environemnt hash. Please, see also the disscussion on\nStackOverflow [2], which also links to an explaination in the\nnginx documentation [3].\n\n[1] http://www.ietf.org/rfc/rfc822.txt\n[2] http://stackoverflow.com/questions/22856136/why-underscores-are-forbidden-in-http-header-names\n[3] https://www.nginx.com/resources/wiki/start/topics/tutorials/config_pitfalls/#missing-disappearing-http-headers","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/349f187f58491f2c2ef929ec0b46d78d4e888e85"},{"sha":"0ae187961c75c44ea418f44ce0c09f78cdf520ff","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Use a gentler disconnect\n\nThe detach used by close! seems to be making EM very sad on Travis.","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/0ae187961c75c44ea418f44ce0c09f78cdf520ff"},{"sha":"513f72804d800bb9a028f6ffc66ab1a0b45df26f","author":{"email":"acb0485d844224f71261a737461d16e1584df021@users.noreply.github.com","name":"Jon Moss"},"message":"Merge pull request #23338 from tawan/update-doc-request-headers-access\n\nAdd additional documentation on Headers#[] [ci skip]","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/513f72804d800bb9a028f6ffc66ab1a0b45df26f"},{"sha":"5563c329eee5febc22a3330e16fe8a6899d42fe2","author":{"email":"a1b4a5d79a04170be8c419b6b204d1834682e890@gmail.com","name":"schneems"},"message":"Add Default Puma Config\n\nWhen the `puma` command is run without any configuration options it will detect presence of a `config/puma.rb` file and use that. Currently there is discrepancy between `puma` command and `rails server` but Evan said it would be reasonable to add in reading in config from the default location. I am working on that right now as a feature in puma/puma.\n\nWhy do we need this? By default Puma uses 16 threads, and by default ActiveRecord only has 5 threads. Due to the architecture of AR it is guaranteed that if you're running with fewer DB connections than your server has threads you will hit `ActiveRecord::ConnectionTimeoutError ` eventually if your app gets modest amounts of traffic. Since we are providing a default webserver, we should provide reasonable configuration for that webserver.\n\nThis PR does a few things, first it sets the default Puma thread count to 5 to mach ActiveRecord's default. It sets the default environment to `\"development\"` and the default port to 300 so that booting the server with `$ puma` will give you the same default port as `rails server`. It is worth mentioning that by reading in from `PORT` environment variable this config can work with containerized deployments, such as on Heroku. \n\nWe are not using worker processes by default, that way JRuby and windows devs can use this configuration without modification. I went ahead and included a default `on_worker_boot`. It won't be used unless a worker count is specified, that means this config will not use it. Even though it's not being used now It will make someone who wants to try modifying their config to run extra workers easier.\n\ncc/ @pixeltrix","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/5563c329eee5febc22a3330e16fe8a6899d42fe2"},{"sha":"82dc8266dddc199789f3f1e9a9f21975e1c8ee87","author":{"email":"c0de746ec4ffa814022be5a01007d84eff2105fd@gmail.com","name":"Tom Prats"},"message":"Update session to have indifferent access","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/82dc8266dddc199789f3f1e9a9f21975e1c8ee87"},{"sha":"6162c49e40582bf058a6bb82ccc0cfb8f92332b6","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael França"},"message":"Merge pull request #23317 from rfmanuel/after-bundle-in-rails-plugin-template\n\nAdd an after_bundle callback in Rails plugin templates","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/6162c49e40582bf058a6bb82ccc0cfb8f92332b6"},{"sha":"647a04cdbcb4e3abccb9487cdbc7366b4d923ea4","author":{"email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com","name":"yuuji.yaginuma"},"message":"remove unused variable from render test\n\nThis removes the following warning.\n\n```\nrails/actionpack/test/controller/render_test.rb:278: warning: assigned but unused variable - response\n```","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/647a04cdbcb4e3abccb9487cdbc7366b4d923ea4"},{"sha":"a027a750d0a3790965de9faa78c3eeb7f79f517e","author":{"email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com","name":"yuuji.yaginuma"},"message":"remove unused require\n\n`with_indifferent_access` had been used in `assigns` method, but has been removed in ca83436.","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/a027a750d0a3790965de9faa78c3eeb7f79f517e"},{"sha":"eba55447f092dfa99dc813dc7ea21cee9c26b85c","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Update internal documents about ActiveRecord's Reflection\n\nActiveRecord's Reflection was refactored by\nf8d2899d12d59360f29c5eb6a1b1a8fe4ec82ca0 .\nTop of ancestors chain was changed to `AbstractReflection` from\n`MacroReflection`, and new Reflections were added.","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/eba55447f092dfa99dc813dc7ea21cee9c26b85c"},{"sha":"b0ea06b3dbf6200b4728d9cf1a3a47251c96b78d","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"[ci skip] Fix one more typo\n\n- Followup of https://github.com/rails/docrails/commit/10bc49710b7205a6172c3e072b3c77114fefd952","distinct":true,"url":"https://api.github.com/repos/jasnow/rails/commits/b0ea06b3dbf6200b4728d9cf1a3a47251c96b78d"}]}