{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16630","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16630/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16630/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16630/events","html_url":"https://github.com/mantidproject/mantid/pull/16630","id":160390902,"number":16630,"title":"Indirect Data Reduction ISIS Calibration - update colour of range bars","user":{"login":"ElliotAOram","id":13132128,"avatar_url":"https://avatars.githubusercontent.com/u/13132128?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliotAOram","html_url":"https://github.com/ElliotAOram","followers_url":"https://api.github.com/users/ElliotAOram/followers","following_url":"https://api.github.com/users/ElliotAOram/following{/other_user}","gists_url":"https://api.github.com/users/ElliotAOram/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliotAOram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliotAOram/subscriptions","organizations_url":"https://api.github.com/users/ElliotAOram/orgs","repos_url":"https://api.github.com/users/ElliotAOram/repos","events_url":"https://api.github.com/users/ElliotAOram/events{/privacy}","received_events_url":"https://api.github.com/users/ElliotAOram/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20GUI","name":"Component: GUI","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Indirect%20Inelastic","name":"Component: Indirect Inelastic","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"MattKing06","id":13132124,"avatar_url":"https://avatars.githubusercontent.com/u/13132124?v=3","gravatar_id":"","url":"https://api.github.com/users/MattKing06","html_url":"https://github.com/MattKing06","followers_url":"https://api.github.com/users/MattKing06/followers","following_url":"https://api.github.com/users/MattKing06/following{/other_user}","gists_url":"https://api.github.com/users/MattKing06/gists{/gist_id}","starred_url":"https://api.github.com/users/MattKing06/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattKing06/subscriptions","organizations_url":"https://api.github.com/users/MattKing06/orgs","repos_url":"https://api.github.com/users/MattKing06/repos","events_url":"https://api.github.com/users/MattKing06/events{/privacy}","received_events_url":"https://api.github.com/users/MattKing06/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":611,"closed_issues":137,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-06-16T08:40:28Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":2,"created_at":"2016-06-15T10:38:42Z","updated_at":"2016-06-16T08:41:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16630","html_url":"https://github.com/mantidproject/mantid/pull/16630","diff_url":"https://github.com/mantidproject/mantid/pull/16630.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16630.patch"},"body":"Range bars colours in the ISIS Calibration interface have been updated to match the convention in the fit wizard\r\n\r\n**To test:**\r\n\r\n* Switch default facility/instrument to ISIS/IRIS (View > Preferences > Mantid)\r\n* Open ISIS Calibration (Interfaces > Indirect > Data Reduction > ISIS Calibration)\r\n* RunNo = 26176\r\n* Check the `Create RES file` option \r\n* Ensure the interface looks like the following where background is blue and Peak/Rebinning is red\r\n\r\n![image](https://cloud.githubusercontent.com/assets/13132128/16076930/b225127c-32ed-11e6-96f4-30385ec4054b.png)\r\n\r\n\r\nFixes #16491\r\n\r\n[RELEASE NOTES](https://github.com/mantidproject/mantid/blob/5489fdf0c698b79fc11d0d438e55e3f2e629c17f/docs/source/release/v3.8.0/indirect_inelastic.rst#improvements)\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/226423990","html_url":"https://github.com/mantidproject/mantid/pull/16630#issuecomment-226423990","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16630","id":226423990,"user":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T08:41:44Z","updated_at":"2016-06-16T08:41:44Z","body":"This branch has developed a merge conflict with master. Maybe the release notes?"}}
{"actor":{"display_login":"FedeMPouzols"}}