{"action":"created","comment":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/comments/88809616","pull_request_review_id":9371493,"id":88809616,"diff_hunk":"@@ -65,60 +65,58 @@ typedef std::function<bool(const Node&, svg::Style *)> RenderVisitor;\n //! Base class from which Renderers are derived.\n class Renderer {\n   public:\n-\tRenderer() {}\n-\t\n-\tvirtual ~Renderer() {}\n+\tvirtual ~Renderer() = default;\n \n \tvoid\tsetVisitor( const std::function<bool(const Node&, svg::Style *)> &visitor );\n-\t\n-\tvirtual\tvoid\tpushGroup( const Group &group, float opacity ) {}\t\n-\tvirtual void\tpopGroup() {}\t\n-\tvirtual void\tdrawPath( const svg::Path &path ) {}\n-\tvirtual void\tdrawPolyline( const svg::Polyline &polyline ) {}\n-\tvirtual void\tdrawPolygon( const svg::Polygon &polygon ) {}\n-\tvirtual void\tdrawLine( const svg::Line &line ) {}\n-\tvirtual void\tdrawRect( const svg::Rect &rect ) {}\n-\tvirtual void\tdrawCircle( const svg::Circle &circle ) {}\n-\tvirtual void\tdrawEllipse( const svg::Ellipse &ellipse ) {}\n-\tvirtual void\tdrawImage( const svg::Image &image ) {}\n-\tvirtual void\tdrawTextSpan( const svg::TextSpan &span ) {}\n-\n-\tvirtual void\tpushMatrix( const mat3 &m ) {}\n-\tvirtual void\tpopMatrix() {}\n-\tvirtual void\tpushStyle( const svg::Style &style ) {}\n-\tvirtual void\tpopStyle( const svg::Style &style ) {}\t\n-\tvirtual void\tpushFill( const class Paint &paint ) {}\n-\tvirtual void\tpopFill() {}\n-\tvirtual void\tpushStroke( const class Paint &paint ) {}\n-\tvirtual void\tpopStroke() {}\n-\tvirtual void\tpushFillOpacity( float opacity ) {}\n-\tvirtual void\tpopFillOpacity() {}\n-\tvirtual void\tpushStrokeOpacity( float opacity ) {}\n-\tvirtual void\tpopStrokeOpacity() {}\n-\tvirtual void\tpushStrokeWidth( float width ) {}\n-\tvirtual void\tpopStrokeWidth() {}\n-\tvirtual void\tpushFillRule( FillRule rule ) {}\n-\tvirtual void\tpopFillRule() {}\t\n-\tvirtual void\tpushLineCap( LineCap lineCap ) {}\n-\tvirtual void\tpopLineCap() {}\t\n-\tvirtual void\tpushLineJoin( LineJoin lineJoin ) {}\n-\tvirtual void\tpopLineJoin() {}\n-\tvirtual void\tpushTextPen( const vec2 &penPos ) {}\n-\tvirtual void\tpopTextPen() {}\n-\tvirtual void\tpushTextRotation( float rotation ) {}\n-\tvirtual void\tpopTextRotation() {}\n+\n+\tvirtual\tvoid\tpushGroup( const Group & /*group*/, float /*opacity*/ ) {};","path":"include/cinder/svg/Svg.h","position":48,"original_position":48,"commit_id":"1a29001da7e5c840d3e1d829c44cee9616b1ca94","original_commit_id":"1a29001da7e5c840d3e1d829c44cee9616b1ca94","user":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars.githubusercontent.com/u/5132127?v=3","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"body":"The trailing semicolon here - does this prevent some warning?","created_at":"2016-11-20T19:50:33Z","updated_at":"2016-11-20T19:50:33Z","html_url":"https://github.com/cinder/Cinder/pull/1671#discussion_r88809616","pull_request_url":"https://api.github.com/repos/cinder/Cinder/pulls/1671","_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments/88809616"},"html":{"href":"https://github.com/cinder/Cinder/pull/1671#discussion_r88809616"},"pull_request":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1671"}}},"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/1671","id":94481003,"html_url":"https://github.com/cinder/Cinder/pull/1671","diff_url":"https://github.com/cinder/Cinder/pull/1671.diff","patch_url":"https://github.com/cinder/Cinder/pull/1671.patch","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/1671","number":1671,"state":"open","locked":false,"title":"Fix multiple warnings about unused parameters","user":{"login":"MikeGitb","id":13987901,"avatar_url":"https://avatars.githubusercontent.com/u/13987901?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeGitb","html_url":"https://github.com/MikeGitb","followers_url":"https://api.github.com/users/MikeGitb/followers","following_url":"https://api.github.com/users/MikeGitb/following{/other_user}","gists_url":"https://api.github.com/users/MikeGitb/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeGitb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeGitb/subscriptions","organizations_url":"https://api.github.com/users/MikeGitb/orgs","repos_url":"https://api.github.com/users/MikeGitb/repos","events_url":"https://api.github.com/users/MikeGitb/events{/privacy}","received_events_url":"https://api.github.com/users/MikeGitb/received_events","type":"User","site_admin":false},"body":"See #1629 for details.","created_at":"2016-11-19T12:51:15Z","updated_at":"2016-11-20T19:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfa2c7c4c30aa7075c7c69874b53af079946c865","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cinder/Cinder/pulls/1671/commits","review_comments_url":"https://api.github.com/repos/cinder/Cinder/pulls/1671/comments","review_comment_url":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/1671/comments","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/1a29001da7e5c840d3e1d829c44cee9616b1ca94","head":{"label":"MikeGitb:pr/unused_params_various","ref":"pr/unused_params_various","sha":"1a29001da7e5c840d3e1d829c44cee9616b1ca94","user":{"login":"MikeGitb","id":13987901,"avatar_url":"https://avatars.githubusercontent.com/u/13987901?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeGitb","html_url":"https://github.com/MikeGitb","followers_url":"https://api.github.com/users/MikeGitb/followers","following_url":"https://api.github.com/users/MikeGitb/following{/other_user}","gists_url":"https://api.github.com/users/MikeGitb/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeGitb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeGitb/subscriptions","organizations_url":"https://api.github.com/users/MikeGitb/orgs","repos_url":"https://api.github.com/users/MikeGitb/repos","events_url":"https://api.github.com/users/MikeGitb/events{/privacy}","received_events_url":"https://api.github.com/users/MikeGitb/received_events","type":"User","site_admin":false},"repo":{"id":70478656,"name":"Cinder","full_name":"MikeGitb/Cinder","owner":{"login":"MikeGitb","id":13987901,"avatar_url":"https://avatars.githubusercontent.com/u/13987901?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeGitb","html_url":"https://github.com/MikeGitb","followers_url":"https://api.github.com/users/MikeGitb/followers","following_url":"https://api.github.com/users/MikeGitb/following{/other_user}","gists_url":"https://api.github.com/users/MikeGitb/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeGitb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeGitb/subscriptions","organizations_url":"https://api.github.com/users/MikeGitb/orgs","repos_url":"https://api.github.com/users/MikeGitb/repos","events_url":"https://api.github.com/users/MikeGitb/events{/privacy}","received_events_url":"https://api.github.com/users/MikeGitb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikeGitb/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":true,"url":"https://api.github.com/repos/MikeGitb/Cinder","forks_url":"https://api.github.com/repos/MikeGitb/Cinder/forks","keys_url":"https://api.github.com/repos/MikeGitb/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikeGitb/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikeGitb/Cinder/teams","hooks_url":"https://api.github.com/repos/MikeGitb/Cinder/hooks","issue_events_url":"https://api.github.com/repos/MikeGitb/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/MikeGitb/Cinder/events","assignees_url":"https://api.github.com/repos/MikeGitb/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/MikeGitb/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/MikeGitb/Cinder/tags","blobs_url":"https://api.github.com/repos/MikeGitb/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikeGitb/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikeGitb/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikeGitb/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikeGitb/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/MikeGitb/Cinder/languages","stargazers_url":"https://api.github.com/repos/MikeGitb/Cinder/stargazers","contributors_url":"https://api.github.com/repos/MikeGitb/Cinder/contributors","subscribers_url":"https://api.github.com/repos/MikeGitb/Cinder/subscribers","subscription_url":"https://api.github.com/repos/MikeGitb/Cinder/subscription","commits_url":"https://api.github.com/repos/MikeGitb/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikeGitb/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikeGitb/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikeGitb/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikeGitb/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/MikeGitb/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikeGitb/Cinder/merges","archive_url":"https://api.github.com/repos/MikeGitb/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikeGitb/Cinder/downloads","issues_url":"https://api.github.com/repos/MikeGitb/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/MikeGitb/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/MikeGitb/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/MikeGitb/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikeGitb/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/MikeGitb/Cinder/releases{/id}","deployments_url":"https://api.github.com/repos/MikeGitb/Cinder/deployments","created_at":"2016-10-10T10:47:01Z","updated_at":"2016-10-10T10:47:24Z","pushed_at":"2016-11-19T12:48:22Z","git_url":"git://github.com/MikeGitb/Cinder.git","ssh_url":"git@github.com:MikeGitb/Cinder.git","clone_url":"https://github.com/MikeGitb/Cinder.git","svn_url":"https://github.com/MikeGitb/Cinder","homepage":"http://libcinder.org","size":409254,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cinder:master","ref":"master","sha":"6451cfb256a60c2e73ca73941726135bad8afc2e","user":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"repo":{"id":622127,"name":"Cinder","full_name":"cinder/Cinder","owner":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cinder/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":false,"url":"https://api.github.com/repos/cinder/Cinder","forks_url":"https://api.github.com/repos/cinder/Cinder/forks","keys_url":"https://api.github.com/repos/cinder/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinder/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinder/Cinder/teams","hooks_url":"https://api.github.com/repos/cinder/Cinder/hooks","issue_events_url":"https://api.github.com/repos/cinder/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/cinder/Cinder/events","assignees_url":"https://api.github.com/repos/cinder/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/cinder/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/cinder/Cinder/tags","blobs_url":"https://api.github.com/repos/cinder/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinder/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinder/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinder/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/cinder/Cinder/languages","stargazers_url":"https://api.github.com/repos/cinder/Cinder/stargazers","contributors_url":"https://api.github.com/repos/cinder/Cinder/contributors","subscribers_url":"https://api.github.com/repos/cinder/Cinder/subscribers","subscription_url":"https://api.github.com/repos/cinder/Cinder/subscription","commits_url":"https://api.github.com/repos/cinder/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinder/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinder/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinder/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/cinder/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/cinder/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinder/Cinder/merges","archive_url":"https://api.github.com/repos/cinder/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinder/Cinder/downloads","issues_url":"https://api.github.com/repos/cinder/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/cinder/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/cinder/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/cinder/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinder/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/cinder/Cinder/releases{/id}","deployments_url":"https://api.github.com/repos/cinder/Cinder/deployments","created_at":"2010-04-21T19:03:10Z","updated_at":"2016-11-19T12:09:18Z","pushed_at":"2016-11-19T12:51:15Z","git_url":"git://github.com/cinder/Cinder.git","ssh_url":"git@github.com:cinder/Cinder.git","clone_url":"https://github.com/cinder/Cinder.git","svn_url":"https://github.com/cinder/Cinder","homepage":"http://libcinder.org","size":518454,"stargazers_count":2790,"watchers_count":2790,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":669,"mirror_url":null,"open_issues_count":213,"forks":669,"open_issues":213,"watchers":2790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1671"},"html":{"href":"https://github.com/cinder/Cinder/pull/1671"},"issue":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1671"},"comments":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1671/comments"},"review_comments":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1671/comments"},"review_comment":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1671/commits"},"statuses":{"href":"https://api.github.com/repos/cinder/Cinder/statuses/1a29001da7e5c840d3e1d829c44cee9616b1ca94"}}}}
{"actor":{"display_login":"richardeakin"}}