{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/82062957","pull_request_review_id":2996754,"id":82062957,"diff_hunk":"@@ -76,21 +76,44 @@ use dom::htmltrackelement::HTMLTrackElement;\n use dom::htmlulistelement::HTMLUListElement;\n use dom::htmlunknownelement::HTMLUnknownElement;\n use dom::htmlvideoelement::HTMLVideoElement;\n+use dom::svgsvgelement::SVGSVGElement;\n use string_cache::{Atom, QualName};\n+use util::prefs::PREFS;\n \n-pub fn create_element(name: QualName,\n-                      prefix: Option<Atom>,\n-                      document: &Document,\n-                      creator: ElementCreator)\n+fn create_svg_element(name: QualName,\n+                      prefix: Option<DOMString>,\n+                      document: &Document)\n                       -> Root<Element> {\n-    // FIXME(ajeffrey): Convert directly from Atom to DOMString.\n+    assert!(name.ns == ns!(svg));\n \n-    let prefix = prefix.map(|p| DOMString::from(&*p));\n+    macro_rules! make(\n+        ($ctor:ident) => ({\n+            let obj = $ctor::new(name.local, prefix, document);\n+            Root::upcast(obj)\n+        });\n+        ($ctor:ident, $($arg:expr),+) => ({\n+            let obj = $ctor::new(name.local, prefix, document, $($arg),+);\n+            Root::upcast(obj)\n+        })\n+    );","path":"components/script/dom/create.rs","position":29,"original_position":29,"commit_id":"fd7ddc8b3c5e83014b97428a862255aa7137f88f","original_commit_id":"fd7ddc8b3c5e83014b97428a862255aa7137f88f","user":{"login":"splav","id":182050,"avatar_url":"https://avatars.githubusercontent.com/u/182050?v=3","gravatar_id":"","url":"https://api.github.com/users/splav","html_url":"https://github.com/splav","followers_url":"https://api.github.com/users/splav/followers","following_url":"https://api.github.com/users/splav/following{/other_user}","gists_url":"https://api.github.com/users/splav/gists{/gist_id}","starred_url":"https://api.github.com/users/splav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splav/subscriptions","organizations_url":"https://api.github.com/users/splav/orgs","repos_url":"https://api.github.com/users/splav/repos","events_url":"https://api.github.com/users/splav/events{/privacy}","received_events_url":"https://api.github.com/users/splav/received_events","type":"User","site_admin":false},"body":"Actually it's not so obvious. If I move macro out of scope I'll lose name.local, prefix, document local vars and should make them arguments. That makes macro mostly useless.","created_at":"2016-10-05T20:28:25Z","updated_at":"2016-10-05T20:28:25Z","html_url":"https://github.com/servo/servo/pull/13589#discussion_r82062957","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13589","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/82062957"},"html":{"href":"https://github.com/servo/servo/pull/13589#discussion_r82062957"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13589"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13589","id":87988241,"html_url":"https://github.com/servo/servo/pull/13589","diff_url":"https://github.com/servo/servo/pull/13589.diff","patch_url":"https://github.com/servo/servo/pull/13589.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13589","number":13589,"state":"open","locked":false,"title":"Support SVG element (WIP, DO NOT MERGE)","user":{"login":"splav","id":182050,"avatar_url":"https://avatars.githubusercontent.com/u/182050?v=3","gravatar_id":"","url":"https://api.github.com/users/splav","html_url":"https://github.com/splav","followers_url":"https://api.github.com/users/splav/followers","following_url":"https://api.github.com/users/splav/following{/other_user}","gists_url":"https://api.github.com/users/splav/gists{/gist_id}","starred_url":"https://api.github.com/users/splav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splav/subscriptions","organizations_url":"https://api.github.com/users/splav/orgs","repos_url":"https://api.github.com/users/splav/repos","events_url":"https://api.github.com/users/splav/events{/privacy}","received_events_url":"https://api.github.com/users/splav/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\nminimal SVG element implementation\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #12974 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13589)\n<!-- Reviewable:end -->\n","created_at":"2016-10-04T22:42:36Z","updated_at":"2016-10-05T20:28:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a648624dfc31caa9d59f5a35be71f86f6e93eef4","assignee":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13589/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13589/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13589/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/fd7ddc8b3c5e83014b97428a862255aa7137f88f","head":{"label":"splav:SVGElement#12974","ref":"SVGElement#12974","sha":"fd7ddc8b3c5e83014b97428a862255aa7137f88f","user":{"login":"splav","id":182050,"avatar_url":"https://avatars.githubusercontent.com/u/182050?v=3","gravatar_id":"","url":"https://api.github.com/users/splav","html_url":"https://github.com/splav","followers_url":"https://api.github.com/users/splav/followers","following_url":"https://api.github.com/users/splav/following{/other_user}","gists_url":"https://api.github.com/users/splav/gists{/gist_id}","starred_url":"https://api.github.com/users/splav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splav/subscriptions","organizations_url":"https://api.github.com/users/splav/orgs","repos_url":"https://api.github.com/users/splav/repos","events_url":"https://api.github.com/users/splav/events{/privacy}","received_events_url":"https://api.github.com/users/splav/received_events","type":"User","site_admin":false},"repo":{"id":61863689,"name":"servo","full_name":"splav/servo","owner":{"login":"splav","id":182050,"avatar_url":"https://avatars.githubusercontent.com/u/182050?v=3","gravatar_id":"","url":"https://api.github.com/users/splav","html_url":"https://github.com/splav","followers_url":"https://api.github.com/users/splav/followers","following_url":"https://api.github.com/users/splav/following{/other_user}","gists_url":"https://api.github.com/users/splav/gists{/gist_id}","starred_url":"https://api.github.com/users/splav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splav/subscriptions","organizations_url":"https://api.github.com/users/splav/orgs","repos_url":"https://api.github.com/users/splav/repos","events_url":"https://api.github.com/users/splav/events{/privacy}","received_events_url":"https://api.github.com/users/splav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/splav/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/splav/servo","forks_url":"https://api.github.com/repos/splav/servo/forks","keys_url":"https://api.github.com/repos/splav/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splav/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splav/servo/teams","hooks_url":"https://api.github.com/repos/splav/servo/hooks","issue_events_url":"https://api.github.com/repos/splav/servo/issues/events{/number}","events_url":"https://api.github.com/repos/splav/servo/events","assignees_url":"https://api.github.com/repos/splav/servo/assignees{/user}","branches_url":"https://api.github.com/repos/splav/servo/branches{/branch}","tags_url":"https://api.github.com/repos/splav/servo/tags","blobs_url":"https://api.github.com/repos/splav/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splav/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splav/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/splav/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splav/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/splav/servo/languages","stargazers_url":"https://api.github.com/repos/splav/servo/stargazers","contributors_url":"https://api.github.com/repos/splav/servo/contributors","subscribers_url":"https://api.github.com/repos/splav/servo/subscribers","subscription_url":"https://api.github.com/repos/splav/servo/subscription","commits_url":"https://api.github.com/repos/splav/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/splav/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/splav/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/splav/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/splav/servo/contents/{+path}","compare_url":"https://api.github.com/repos/splav/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splav/servo/merges","archive_url":"https://api.github.com/repos/splav/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splav/servo/downloads","issues_url":"https://api.github.com/repos/splav/servo/issues{/number}","pulls_url":"https://api.github.com/repos/splav/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/splav/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/splav/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splav/servo/labels{/name}","releases_url":"https://api.github.com/repos/splav/servo/releases{/id}","deployments_url":"https://api.github.com/repos/splav/servo/deployments","created_at":"2016-06-24T06:59:56Z","updated_at":"2016-06-24T06:29:59Z","pushed_at":"2016-10-04T22:40:31Z","git_url":"git://github.com/splav/servo.git","ssh_url":"git@github.com:splav/servo.git","clone_url":"https://github.com/splav/servo.git","svn_url":"https://github.com/splav/servo","homepage":"https://servo.org/","size":211222,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"318b23ed0047cc39625ca2f33a55d647b5886019","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-05T18:39:22Z","pushed_at":"2016-10-05T20:06:53Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":299268,"stargazers_count":8010,"watchers_count":8010,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1301,"mirror_url":null,"open_issues_count":1763,"forks":1301,"open_issues":1763,"watchers":8010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13589"},"html":{"href":"https://github.com/servo/servo/pull/13589"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13589"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13589/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13589/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13589/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/fd7ddc8b3c5e83014b97428a862255aa7137f88f"}}}}
{"actor":{"display_login":"splav"}}