{"action":"created","issue":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/34","labels_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/34/comments","events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/34/events","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/34","id":120222543,"number":34,"title":"Drag and Drop v2 - Review for release on edx.org","user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-12-03T17:06:38Z","updated_at":"2016-01-28T20:40:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/34","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/34","diff_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/34.diff","patch_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/34.patch"},"body":"This is the main PR for the [SOL-1403 DnDv2 on edx.org epic](https://openedx.atlassian.net/browse/SOL-1403).\r\n\r\nRecent reviews have taken place on the following constituent PRs:\r\n* #33 Allow authors to set background and text color of draggable items: [SOL-1406](https://openedx.atlassian.net/browse/SOL-1406), [SOL-1409](https://openedx.atlassian.net/browse/SOL-1409)\r\n* #35 Add License (AGPLv3): [SOL-1420](https://openedx.atlassian.net/browse/SOL-1420)\r\n* #38 Move draggable items above drop image area: [SOL-1404](https://openedx.atlassian.net/browse/SOL-1404)\r\n* https://github.com/open-craft/xblock-drag-and-drop-v2/pull/4 Make the image resize to fit the container: [SOL-1450](https://openedx.atlassian.net/browse/SOL-1450), Allow problem reset after the first interaction: [SOL-1408](https://openedx.atlassian.net/browse/SOL-1408)\r\n* #39 Support for multiple DnD blocks on the same page: [SOL-1448](https://openedx.atlassian.net/browse/SOL-1448)\r\n* #40 Styling changes from UX review: [SOL-1410](https://openedx.atlassian.net/browse/SOL-1410)\r\n* https://github.com/open-craft/xblock-drag-and-drop-v2/pull/5 Improve default settings and explain settings more clearly: [SOL-1451](https://openedx.atlassian.net/browse/SOL-1451)\r\n* #41 Make DnDv2 accessible: [SOL-1412](https://openedx.atlassian.net/browse/SOL-1412)\r\n* #42 DnDv2 - Show an indicator/spinner while AJAX requests are in progress: [SOL-1452](https://openedx.atlassian.net/browse/SOL-1452)\r\n* #44 DnDv2 - Make the block keyboard navigable: [SOL-1462](https://openedx.atlassian.net/browse/SOL-1462)\r\n* #45 DnDv2 - Allow authors to show the borders on drop zones: [SOL-1405](https://openedx.atlassian.net/browse/SOL-1405)\r\n* #46 Fix flaky tests: [SOL-1449](https://openedx.atlassian.net/browse/SOL-1449)\r\n* #47 Update and refine analytics events and their documentation: [SOL-1473](https://openedx.atlassian.net/browse/SOL-1473)\r\n* #48 Add theming: [SOL-1411](https://openedx.atlassian.net/browse/SOL-1411)\r\n* #52 Re-create all of the documentation screenshots: [SOL-1453](https://openedx.atlassian.net/browse/SOL-1453)\r\n* #49 Improve usability on mobile: [SOL-1474](https://openedx.atlassian.net/browse/SOL-1474)\r\n\r\nTODO (during review):\r\n* a11y: Check if the grey color of the focus outline on the drop targets is OK, or if there's a better way to make it visible against varied backgrounds\r\n* a11y: Check if the grey dotted borders around drop zones when authors turn on \"show drop zones borders\" are OK\r\n\r\n**Testing**\r\n\r\nWe have a sandbox available for testing DnDv2: [Studio](http://studio.master.dndv2.sandbox.opencraft.com/), [LMS](http://master.dndv2.sandbox.opencraft.com/).\r\n\r\n**Reviewers**\r\n\r\n- [ ] a11y: @cptvitamin\r\n- [x] UX: @talbs\r\n- [x] Strings: @pdesjardins\r\n- [x] TNL: @dianakhuang \r\n"},"comment":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/comments/176403846","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/34#issuecomment-176403846","issue_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/34","id":176403846,"user":{"login":"Kelketek","id":1099483,"avatar_url":"https://avatars.githubusercontent.com/u/1099483?v=3","gravatar_id":"","url":"https://api.github.com/users/Kelketek","html_url":"https://github.com/Kelketek","followers_url":"https://api.github.com/users/Kelketek/followers","following_url":"https://api.github.com/users/Kelketek/following{/other_user}","gists_url":"https://api.github.com/users/Kelketek/gists{/gist_id}","starred_url":"https://api.github.com/users/Kelketek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kelketek/subscriptions","organizations_url":"https://api.github.com/users/Kelketek/orgs","repos_url":"https://api.github.com/users/Kelketek/repos","events_url":"https://api.github.com/users/Kelketek/events{/privacy}","received_events_url":"https://api.github.com/users/Kelketek/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T20:40:00Z","updated_at":"2016-01-28T20:40:00Z","body":"@cahrens In this case it'd require a few extra steps, since those IDs don't get created until some interaction happens. As we're short on time I'd like to avoid introducing extra variables.\r\n\r\nHowever I'm curious about this technique. Is there documentation for it? I'd like to use it in the future if I can.\r\n\r\n@clytwynec Please take a look at the latest updates and see if they perform as you expect."}}