{"action":"created","comment":{"url":"https://api.github.com/repos/elm-community/elm-webgl/pulls/comments/88800823","pull_request_review_id":9363875,"id":88800823,"diff_hunk":"@@ -343,7 +373,13 @@ var _elm_community$elm_webgl$Native_WebGL = function () {\n         gl.enableVertexAttribArray(attribLocation);\n \n         if (buffer.buffers[attribute.name] === undefined) {\n-          buffer.buffers[attribute.name] = do_bind_attribute(gl, attribute, render.buffer._0, renderType.elemSize);\n+          var bufferElems;\n+          if (renderType.indexed) {\n+            bufferElems = render.buffer._0._0, renderType.elemSize;","path":"src/Native/WebGL.js","position":89,"original_position":89,"commit_id":"d387ca7be0bd9b2ef247437cd6a9eb0b5dfd18ba","original_commit_id":"d387ca7be0bd9b2ef247437cd6a9eb0b5dfd18ba","user":{"login":"w0rm","id":43472,"avatar_url":"https://avatars.githubusercontent.com/u/43472?v=3","gravatar_id":"","url":"https://api.github.com/users/w0rm","html_url":"https://github.com/w0rm","followers_url":"https://api.github.com/users/w0rm/followers","following_url":"https://api.github.com/users/w0rm/following{/other_user}","gists_url":"https://api.github.com/users/w0rm/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rm/subscriptions","organizations_url":"https://api.github.com/users/w0rm/orgs","repos_url":"https://api.github.com/users/w0rm/repos","events_url":"https://api.github.com/users/w0rm/events{/privacy}","received_events_url":"https://api.github.com/users/w0rm/received_events","type":"User","site_admin":false},"body":"This looks wrong to me, you are using comma operator here","created_at":"2016-11-20T12:59:05Z","updated_at":"2016-11-20T12:59:05Z","html_url":"https://github.com/elm-community/elm-webgl/pull/40#discussion_r88800823","pull_request_url":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/elm-community/elm-webgl/pulls/comments/88800823"},"html":{"href":"https://github.com/elm-community/elm-webgl/pull/40#discussion_r88800823"},"pull_request":{"href":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40","id":91076336,"html_url":"https://github.com/elm-community/elm-webgl/pull/40","diff_url":"https://github.com/elm-community/elm-webgl/pull/40.diff","patch_url":"https://github.com/elm-community/elm-webgl/pull/40.patch","issue_url":"https://api.github.com/repos/elm-community/elm-webgl/issues/40","number":40,"state":"open","locked":false,"title":"Ability to use IndexTriangles","user":{"login":"nacmartin","id":154258,"avatar_url":"https://avatars.githubusercontent.com/u/154258?v=3","gravatar_id":"","url":"https://api.github.com/users/nacmartin","html_url":"https://github.com/nacmartin","followers_url":"https://api.github.com/users/nacmartin/followers","following_url":"https://api.github.com/users/nacmartin/following{/other_user}","gists_url":"https://api.github.com/users/nacmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/nacmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nacmartin/subscriptions","organizations_url":"https://api.github.com/users/nacmartin/orgs","repos_url":"https://api.github.com/users/nacmartin/repos","events_url":"https://api.github.com/users/nacmartin/events{/privacy}","received_events_url":"https://api.github.com/users/nacmartin/received_events","type":"User","site_admin":false},"body":"This provides the ability to specify indices. There is a nice explanation of this technique here http://www.opengl-tutorial.org/intermediate-tutorials/tutorial-9-vbo-indexing/\n\nHere is a gist that uses this feature: https://gist.github.com/nacmartin/fb79c2a0a0b26d9bd2c233f8f2da7564 \n\nNote that this is a change in the API. It doesn't break compatibility, as it only provides a new type for a union type, but I will understand if it is not merged.\n\nThis PR addresses #37\n","created_at":"2016-10-26T19:56:24Z","updated_at":"2016-11-20T12:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb4f7777a4dbce49c847a9e8350e4125f3a5b143","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40/commits","review_comments_url":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40/comments","review_comment_url":"https://api.github.com/repos/elm-community/elm-webgl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elm-community/elm-webgl/issues/40/comments","statuses_url":"https://api.github.com/repos/elm-community/elm-webgl/statuses/d387ca7be0bd9b2ef247437cd6a9eb0b5dfd18ba","head":{"label":"nacmartin:indexed-triangles","ref":"indexed-triangles","sha":"d387ca7be0bd9b2ef247437cd6a9eb0b5dfd18ba","user":{"login":"nacmartin","id":154258,"avatar_url":"https://avatars.githubusercontent.com/u/154258?v=3","gravatar_id":"","url":"https://api.github.com/users/nacmartin","html_url":"https://github.com/nacmartin","followers_url":"https://api.github.com/users/nacmartin/followers","following_url":"https://api.github.com/users/nacmartin/following{/other_user}","gists_url":"https://api.github.com/users/nacmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/nacmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nacmartin/subscriptions","organizations_url":"https://api.github.com/users/nacmartin/orgs","repos_url":"https://api.github.com/users/nacmartin/repos","events_url":"https://api.github.com/users/nacmartin/events{/privacy}","received_events_url":"https://api.github.com/users/nacmartin/received_events","type":"User","site_admin":false},"repo":{"id":72038111,"name":"elm-webgl","full_name":"nacmartin/elm-webgl","owner":{"login":"nacmartin","id":154258,"avatar_url":"https://avatars.githubusercontent.com/u/154258?v=3","gravatar_id":"","url":"https://api.github.com/users/nacmartin","html_url":"https://github.com/nacmartin","followers_url":"https://api.github.com/users/nacmartin/followers","following_url":"https://api.github.com/users/nacmartin/following{/other_user}","gists_url":"https://api.github.com/users/nacmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/nacmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nacmartin/subscriptions","organizations_url":"https://api.github.com/users/nacmartin/orgs","repos_url":"https://api.github.com/users/nacmartin/repos","events_url":"https://api.github.com/users/nacmartin/events{/privacy}","received_events_url":"https://api.github.com/users/nacmartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nacmartin/elm-webgl","description":"Functional 3D Rendering with WebGL in Elm","fork":true,"url":"https://api.github.com/repos/nacmartin/elm-webgl","forks_url":"https://api.github.com/repos/nacmartin/elm-webgl/forks","keys_url":"https://api.github.com/repos/nacmartin/elm-webgl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nacmartin/elm-webgl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nacmartin/elm-webgl/teams","hooks_url":"https://api.github.com/repos/nacmartin/elm-webgl/hooks","issue_events_url":"https://api.github.com/repos/nacmartin/elm-webgl/issues/events{/number}","events_url":"https://api.github.com/repos/nacmartin/elm-webgl/events","assignees_url":"https://api.github.com/repos/nacmartin/elm-webgl/assignees{/user}","branches_url":"https://api.github.com/repos/nacmartin/elm-webgl/branches{/branch}","tags_url":"https://api.github.com/repos/nacmartin/elm-webgl/tags","blobs_url":"https://api.github.com/repos/nacmartin/elm-webgl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nacmartin/elm-webgl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nacmartin/elm-webgl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nacmartin/elm-webgl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nacmartin/elm-webgl/statuses/{sha}","languages_url":"https://api.github.com/repos/nacmartin/elm-webgl/languages","stargazers_url":"https://api.github.com/repos/nacmartin/elm-webgl/stargazers","contributors_url":"https://api.github.com/repos/nacmartin/elm-webgl/contributors","subscribers_url":"https://api.github.com/repos/nacmartin/elm-webgl/subscribers","subscription_url":"https://api.github.com/repos/nacmartin/elm-webgl/subscription","commits_url":"https://api.github.com/repos/nacmartin/elm-webgl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nacmartin/elm-webgl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nacmartin/elm-webgl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nacmartin/elm-webgl/issues/comments{/number}","contents_url":"https://api.github.com/repos/nacmartin/elm-webgl/contents/{+path}","compare_url":"https://api.github.com/repos/nacmartin/elm-webgl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nacmartin/elm-webgl/merges","archive_url":"https://api.github.com/repos/nacmartin/elm-webgl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nacmartin/elm-webgl/downloads","issues_url":"https://api.github.com/repos/nacmartin/elm-webgl/issues{/number}","pulls_url":"https://api.github.com/repos/nacmartin/elm-webgl/pulls{/number}","milestones_url":"https://api.github.com/repos/nacmartin/elm-webgl/milestones{/number}","notifications_url":"https://api.github.com/repos/nacmartin/elm-webgl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nacmartin/elm-webgl/labels{/name}","releases_url":"https://api.github.com/repos/nacmartin/elm-webgl/releases{/id}","deployments_url":"https://api.github.com/repos/nacmartin/elm-webgl/deployments","created_at":"2016-10-26T19:38:52Z","updated_at":"2016-11-16T19:47:53Z","pushed_at":"2016-10-27T21:44:28Z","git_url":"git://github.com/nacmartin/elm-webgl.git","ssh_url":"git@github.com:nacmartin/elm-webgl.git","clone_url":"https://github.com/nacmartin/elm-webgl.git","svn_url":"https://github.com/nacmartin/elm-webgl","homepage":"http://package.elm-lang.org/packages/elm-community/elm-webgl/latest","size":512,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elm-community:master","ref":"master","sha":"67afbcf9d333538f48f88836e54063f1e00540f8","user":{"login":"elm-community","id":15948699,"avatar_url":"https://avatars.githubusercontent.com/u/15948699?v=3","gravatar_id":"","url":"https://api.github.com/users/elm-community","html_url":"https://github.com/elm-community","followers_url":"https://api.github.com/users/elm-community/followers","following_url":"https://api.github.com/users/elm-community/following{/other_user}","gists_url":"https://api.github.com/users/elm-community/gists{/gist_id}","starred_url":"https://api.github.com/users/elm-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elm-community/subscriptions","organizations_url":"https://api.github.com/users/elm-community/orgs","repos_url":"https://api.github.com/users/elm-community/repos","events_url":"https://api.github.com/users/elm-community/events{/privacy}","received_events_url":"https://api.github.com/users/elm-community/received_events","type":"Organization","site_admin":false},"repo":{"id":48340347,"name":"elm-webgl","full_name":"elm-community/elm-webgl","owner":{"login":"elm-community","id":15948699,"avatar_url":"https://avatars.githubusercontent.com/u/15948699?v=3","gravatar_id":"","url":"https://api.github.com/users/elm-community","html_url":"https://github.com/elm-community","followers_url":"https://api.github.com/users/elm-community/followers","following_url":"https://api.github.com/users/elm-community/following{/other_user}","gists_url":"https://api.github.com/users/elm-community/gists{/gist_id}","starred_url":"https://api.github.com/users/elm-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elm-community/subscriptions","organizations_url":"https://api.github.com/users/elm-community/orgs","repos_url":"https://api.github.com/users/elm-community/repos","events_url":"https://api.github.com/users/elm-community/events{/privacy}","received_events_url":"https://api.github.com/users/elm-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elm-community/elm-webgl","description":"DEPRECATED:  See elm-community/webgl.","fork":true,"url":"https://api.github.com/repos/elm-community/elm-webgl","forks_url":"https://api.github.com/repos/elm-community/elm-webgl/forks","keys_url":"https://api.github.com/repos/elm-community/elm-webgl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elm-community/elm-webgl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elm-community/elm-webgl/teams","hooks_url":"https://api.github.com/repos/elm-community/elm-webgl/hooks","issue_events_url":"https://api.github.com/repos/elm-community/elm-webgl/issues/events{/number}","events_url":"https://api.github.com/repos/elm-community/elm-webgl/events","assignees_url":"https://api.github.com/repos/elm-community/elm-webgl/assignees{/user}","branches_url":"https://api.github.com/repos/elm-community/elm-webgl/branches{/branch}","tags_url":"https://api.github.com/repos/elm-community/elm-webgl/tags","blobs_url":"https://api.github.com/repos/elm-community/elm-webgl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elm-community/elm-webgl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elm-community/elm-webgl/git/refs{/sha}","trees_url":"https://api.github.com/repos/elm-community/elm-webgl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elm-community/elm-webgl/statuses/{sha}","languages_url":"https://api.github.com/repos/elm-community/elm-webgl/languages","stargazers_url":"https://api.github.com/repos/elm-community/elm-webgl/stargazers","contributors_url":"https://api.github.com/repos/elm-community/elm-webgl/contributors","subscribers_url":"https://api.github.com/repos/elm-community/elm-webgl/subscribers","subscription_url":"https://api.github.com/repos/elm-community/elm-webgl/subscription","commits_url":"https://api.github.com/repos/elm-community/elm-webgl/commits{/sha}","git_commits_url":"https://api.github.com/repos/elm-community/elm-webgl/git/commits{/sha}","comments_url":"https://api.github.com/repos/elm-community/elm-webgl/comments{/number}","issue_comment_url":"https://api.github.com/repos/elm-community/elm-webgl/issues/comments{/number}","contents_url":"https://api.github.com/repos/elm-community/elm-webgl/contents/{+path}","compare_url":"https://api.github.com/repos/elm-community/elm-webgl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elm-community/elm-webgl/merges","archive_url":"https://api.github.com/repos/elm-community/elm-webgl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elm-community/elm-webgl/downloads","issues_url":"https://api.github.com/repos/elm-community/elm-webgl/issues{/number}","pulls_url":"https://api.github.com/repos/elm-community/elm-webgl/pulls{/number}","milestones_url":"https://api.github.com/repos/elm-community/elm-webgl/milestones{/number}","notifications_url":"https://api.github.com/repos/elm-community/elm-webgl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elm-community/elm-webgl/labels{/name}","releases_url":"https://api.github.com/repos/elm-community/elm-webgl/releases{/id}","deployments_url":"https://api.github.com/repos/elm-community/elm-webgl/deployments","created_at":"2015-12-20T22:56:53Z","updated_at":"2016-11-19T19:34:10Z","pushed_at":"2016-11-17T19:02:10Z","git_url":"git://github.com/elm-community/elm-webgl.git","ssh_url":"git@github.com:elm-community/elm-webgl.git","clone_url":"https://github.com/elm-community/elm-webgl.git","svn_url":"https://github.com/elm-community/elm-webgl","homepage":"http://package.elm-lang.org/packages/elm-community/webgl/latest","size":474,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":5,"forks":20,"open_issues":5,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40"},"html":{"href":"https://github.com/elm-community/elm-webgl/pull/40"},"issue":{"href":"https://api.github.com/repos/elm-community/elm-webgl/issues/40"},"comments":{"href":"https://api.github.com/repos/elm-community/elm-webgl/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/elm-community/elm-webgl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elm-community/elm-webgl/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/elm-community/elm-webgl/statuses/d387ca7be0bd9b2ef247437cd6a9eb0b5dfd18ba"}}}}
{"actor":{"display_login":"w0rm"}}