{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/587","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/587/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/587/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/587/events","html_url":"https://github.com/Homebrew/brew/pull/587","id":167453564,"number":587,"title":"tests: fix code style issues","user":{"login":"eirinikos","id":9170701,"avatar_url":"https://avatars.githubusercontent.com/u/9170701?v=3","gravatar_id":"","url":"https://api.github.com/users/eirinikos","html_url":"https://github.com/eirinikos","followers_url":"https://api.github.com/users/eirinikos/followers","following_url":"https://api.github.com/users/eirinikos/following{/other_user}","gists_url":"https://api.github.com/users/eirinikos/gists{/gist_id}","starred_url":"https://api.github.com/users/eirinikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirinikos/subscriptions","organizations_url":"https://api.github.com/users/eirinikos/orgs","repos_url":"https://api.github.com/users/eirinikos/repos","events_url":"https://api.github.com/users/eirinikos/events{/privacy}","received_events_url":"https://api.github.com/users/eirinikos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Homebrew/brew/labels/gsoc-outreachy","name":"gsoc-outreachy","color":"213954"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-25T20:07:38Z","updated_at":"2016-08-02T10:06:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/587","html_url":"https://github.com/Homebrew/brew/pull/587","diff_url":"https://github.com/Homebrew/brew/pull/587.diff","patch_url":"https://github.com/Homebrew/brew/pull/587.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nThis change fixes many of the existing bugs reported by `brew style` for `Homebrew/test`.\r\n\r\n33 bugs remain; many of them are one of the following:\r\n- `Method definitions must not be nested. Use lambda instead.`\r\n  - these method definitions all (or mostly) seem to be enclosed within `formula do` blocks; does it make sense to convert these to lambdas? (I haven't yet figured out a way to do so that passes `brew tests`.)\r\n\r\n- `Use snake_case for method names.`\r\n  - examples of these methods include `test_check_DYLD_vars` and `test_create_DATA`; it seems like these acronyms are best kept as-is.\r\n\r\n- `Prefer to_s over string interpolation.`\r\n  - these bugs are easy to fix, but many instances of string interpolation seem to be tolerated by `brew style` (e.g., in `test_integration_cmds`; why is that?\r\n\r\nI'm sensing that Rubocop's opinions are meant to be guidelines (rather than gospel), but maybe I'm wrong!\r\n\r\n🎈 "},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/236860988","html_url":"https://github.com/Homebrew/brew/pull/587#issuecomment-236860988","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/587","id":236860988,"user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"created_at":"2016-08-02T10:06:13Z","updated_at":"2016-08-02T10:06:13Z","body":"@eirinikos Nice work! Added a few comments and then we can 🚢 this."}}
{"actor":{"display_login":"MikeMcQuaid"}}