{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/comments/53412179","id":53412179,"diff_hunk":"@@ -0,0 +1,84 @@\n+import functools\n+\n+import pytest\n+\n+from sentry.exceptions import InvalidConfiguration\n+from sentry.testutils.cases import TestCase\n+from sentry.utils.redis import (\n+    ClusterManager, _shared_pool, get_cluster_from_options\n+)\n+\n+make_manager = functools.partial(\n+    ClusterManager,\n+    {","path":"tests/sentry/utils/test_redis.py","position":13,"original_position":13,"commit_id":"2f139f3c1dd5cbaf8a4a0c55679e5dfcb7b537ef","original_commit_id":"2f139f3c1dd5cbaf8a4a0c55679e5dfcb7b537ef","user":{"login":"tkaemming","id":65315,"avatar_url":"https://avatars.githubusercontent.com/u/65315?v=3","gravatar_id":"","url":"https://api.github.com/users/tkaemming","html_url":"https://github.com/tkaemming","followers_url":"https://api.github.com/users/tkaemming/followers","following_url":"https://api.github.com/users/tkaemming/following{/other_user}","gists_url":"https://api.github.com/users/tkaemming/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaemming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaemming/subscriptions","organizations_url":"https://api.github.com/users/tkaemming/orgs","repos_url":"https://api.github.com/users/tkaemming/repos","events_url":"https://api.github.com/users/tkaemming/events{/privacy}","received_events_url":"https://api.github.com/users/tkaemming/received_events","type":"User","site_admin":false},"body":"This is a bit of a hack — it relies on `OptionManager.get` and `dict.get` behaving the same. This does isolate state much better, though.","created_at":"2016-02-19T01:36:21Z","updated_at":"2016-02-19T01:36:21Z","html_url":"https://github.com/getsentry/sentry/pull/2714#discussion_r53412179","pull_request_url":"https://api.github.com/repos/getsentry/sentry/pulls/2714","_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments/53412179"},"html":{"href":"https://github.com/getsentry/sentry/pull/2714#discussion_r53412179"},"pull_request":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/2714"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/2714","id":59883828,"html_url":"https://github.com/getsentry/sentry/pull/2714","diff_url":"https://github.com/getsentry/sentry/pull/2714.diff","patch_url":"https://github.com/getsentry/sentry/pull/2714.patch","issue_url":"https://api.github.com/repos/getsentry/sentry/issues/2714","number":2714,"state":"open","locked":false,"title":"Implement shared Redis clusters.","user":{"login":"tkaemming","id":65315,"avatar_url":"https://avatars.githubusercontent.com/u/65315?v=3","gravatar_id":"","url":"https://api.github.com/users/tkaemming","html_url":"https://github.com/tkaemming","followers_url":"https://api.github.com/users/tkaemming/followers","following_url":"https://api.github.com/users/tkaemming/following{/other_user}","gists_url":"https://api.github.com/users/tkaemming/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaemming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaemming/subscriptions","organizations_url":"https://api.github.com/users/tkaemming/orgs","repos_url":"https://api.github.com/users/tkaemming/repos","events_url":"https://api.github.com/users/tkaemming/events{/privacy}","received_events_url":"https://api.github.com/users/tkaemming/received_events","type":"User","site_admin":false},"body":"This replaces `SENTRY_REDIS_OPTIONS` and per-backend configuration with named Redis clusters, configured from the value of the `redis.clusters` key in `sentry.options`. The preferred method of configuring Redis-based backends is by providing a *cluster name*, rather than the cluster configuration parameters.\r\n\r\nThis deprecates:\r\n\r\n- `SENTRY_REDIS_OPTIONS` in favor of the `redis.clusters` option.\r\n- Passing `hosts` to any backend in favor of `cluster`.\r\n- `sentry.utils.make_rb_cluster` in favor of retrieving clusters defined in configuration via the clsuter manager.\r\n\r\nThis also updates all tests to retrieve Redis clusters via the cluster manager, instead of via cluster configuration or direct construction via `rb.Cluster` or `StrictRedis`. This also consolidates all test cluster setup and teardown to the test wrapper methods.\r\n\r\nResolves GH-2530 and references GH-2693.","created_at":"2016-02-18T23:54:42Z","updated_at":"2016-02-19T01:36:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a05647307cf28f5fe2d4b23a6a04302e09b7a024","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/sentry/pulls/2714/commits","review_comments_url":"https://api.github.com/repos/getsentry/sentry/pulls/2714/comments","review_comment_url":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/sentry/issues/2714/comments","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/2f139f3c1dd5cbaf8a4a0c55679e5dfcb7b537ef","head":{"label":"getsentry:redis-clusters","ref":"redis-clusters","sha":"2f139f3c1dd5cbaf8a4a0c55679e5dfcb7b537ef","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform crash reporting built with love","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2016-02-19T00:47:03Z","pushed_at":"2016-02-19T01:33:13Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://getsentry.com","size":49893,"stargazers_count":8460,"watchers_count":8460,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1008,"mirror_url":null,"open_issues_count":207,"forks":1008,"open_issues":207,"watchers":8460,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"f3efca55b3c67a369be5f422629b5bbc57fe57a1","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform crash reporting built with love","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2016-02-19T00:47:03Z","pushed_at":"2016-02-19T01:33:13Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://getsentry.com","size":49893,"stargazers_count":8460,"watchers_count":8460,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1008,"mirror_url":null,"open_issues_count":207,"forks":1008,"open_issues":207,"watchers":8460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/2714"},"html":{"href":"https://github.com/getsentry/sentry/pull/2714"},"issue":{"href":"https://api.github.com/repos/getsentry/sentry/issues/2714"},"comments":{"href":"https://api.github.com/repos/getsentry/sentry/issues/2714/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/2714/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/2714/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/sentry/statuses/2f139f3c1dd5cbaf8a4a0c55679e5dfcb7b537ef"}}}}