{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/710","repository_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/710/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/710/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/710/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/issues/710","id":151223401,"number":710,"title":"Possible Issues When Implementing Reform ","user":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-26T19:49:55Z","updated_at":"2016-05-04T17:08:57Z","closed_at":null,"body":"I happened to notice that, when implementing reforms, different expressions could lead to different results. \r\n\r\nAs an example, if we specify two reform as follow:\r\n\r\n```\r\nreform1 = {2014: {'_EITC_rt':[[0, 0, 0, 0]]\r\n                 ,'_EITC_prt':[[0, 0, 0, 0]]}\r\n          }\r\npolicy1.implement_reform(reform1)\r\n\r\nreform2 = {2014: {'_EITC_rt':[[0, 0, 0, 0]]},\r\n           2014: {'_EITC_prt':[[0, 0, 0, 0]]\r\n                 }\r\n          }\r\npolicy2.implement_reform(reform2)\r\n```\r\n, which are essentially identical. \r\n\r\nThe results, however, will be different:\r\n\r\nReform 1:\r\n![screen shot 2016-04-26 at 3 43 12 pm](https://cloud.githubusercontent.com/assets/13324931/14831906/9edf799a-0bc5-11e6-917b-dc68e1abe9a5.png)\r\n\r\nReform 2:\r\n![screen shot 2016-04-26 at 3 43 18 pm](https://cloud.githubusercontent.com/assets/13324931/14831911/a614bd6a-0bc5-11e6-85c0-90e35184d16f.png)\r\n\r\nThe issue is that, while trying to implement some reforms, each year entry can only be modified once, and thus all reforms for that specific year shall be included. I thought it would be helpful to have a warning message when users are trying to specify duplicated entries of the same year.  "},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/216934462","html_url":"https://github.com/open-source-economics/Tax-Calculator/issues/710#issuecomment-216934462","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/710","id":216934462,"user":{"login":"MattHJensen","id":8301092,"avatar_url":"https://avatars.githubusercontent.com/u/8301092?v=3","gravatar_id":"","url":"https://api.github.com/users/MattHJensen","html_url":"https://github.com/MattHJensen","followers_url":"https://api.github.com/users/MattHJensen/followers","following_url":"https://api.github.com/users/MattHJensen/following{/other_user}","gists_url":"https://api.github.com/users/MattHJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/MattHJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattHJensen/subscriptions","organizations_url":"https://api.github.com/users/MattHJensen/orgs","repos_url":"https://api.github.com/users/MattHJensen/repos","events_url":"https://api.github.com/users/MattHJensen/events{/privacy}","received_events_url":"https://api.github.com/users/MattHJensen/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T17:08:57Z","updated_at":"2016-05-04T17:08:57Z","body":"@GoFroggyRun, what is the status of this issue? "}}