{"action":"closed","number":5398,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5398","id":95758912,"html_url":"https://github.com/puppetlabs/puppet/pull/5398","diff_url":"https://github.com/puppetlabs/puppet/pull/5398.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5398.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5398","number":5398,"state":"closed","locked":false,"title":"(PUP-6188) consider umask for default perms FS test","user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"body":"Prior to this commit, a test in file_system_spec.rb would assert an expected\r\ndefault permission for a newly created file by Puppet::FileSystem, but failed\r\nto take into account that this would vary based on umask (which varies in linux\r\nby root vs non-root user). This commit updates the test to instead calculate\r\nthe expected permission based on the current umask.\r\n\r\ntransaction spec","created_at":"2016-11-29T19:29:28Z","updated_at":"2016-11-30T22:32:40Z","closed_at":"2016-11-30T22:32:40Z","merged_at":"2016-11-30T22:32:40Z","merge_commit_sha":"0a582a3c3a2aae03a68efaea0556e3d8f3c68b47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5398/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5398/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5398/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/2a4e1236733aea9cba3aa0d16a37bb204d9642fe","head":{"label":"MosesMendoza:PUP-6188/master/fixup_perms_test_fs","ref":"PUP-6188/master/fixup_perms_test_fs","sha":"2a4e1236733aea9cba3aa0d16a37bb204d9642fe","user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"repo":{"id":3267256,"name":"puppet","full_name":"MosesMendoza/puppet","owner":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MosesMendoza/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/MosesMendoza/puppet","forks_url":"https://api.github.com/repos/MosesMendoza/puppet/forks","keys_url":"https://api.github.com/repos/MosesMendoza/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MosesMendoza/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MosesMendoza/puppet/teams","hooks_url":"https://api.github.com/repos/MosesMendoza/puppet/hooks","issue_events_url":"https://api.github.com/repos/MosesMendoza/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/MosesMendoza/puppet/events","assignees_url":"https://api.github.com/repos/MosesMendoza/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/MosesMendoza/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/MosesMendoza/puppet/tags","blobs_url":"https://api.github.com/repos/MosesMendoza/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MosesMendoza/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MosesMendoza/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/MosesMendoza/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MosesMendoza/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/MosesMendoza/puppet/languages","stargazers_url":"https://api.github.com/repos/MosesMendoza/puppet/stargazers","contributors_url":"https://api.github.com/repos/MosesMendoza/puppet/contributors","subscribers_url":"https://api.github.com/repos/MosesMendoza/puppet/subscribers","subscription_url":"https://api.github.com/repos/MosesMendoza/puppet/subscription","commits_url":"https://api.github.com/repos/MosesMendoza/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/MosesMendoza/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/MosesMendoza/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/MosesMendoza/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/MosesMendoza/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/MosesMendoza/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MosesMendoza/puppet/merges","archive_url":"https://api.github.com/repos/MosesMendoza/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MosesMendoza/puppet/downloads","issues_url":"https://api.github.com/repos/MosesMendoza/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/MosesMendoza/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/MosesMendoza/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/MosesMendoza/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MosesMendoza/puppet/labels{/name}","releases_url":"https://api.github.com/repos/MosesMendoza/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/MosesMendoza/puppet/deployments","created_at":"2012-01-25T18:29:08Z","updated_at":"2016-11-30T22:00:16Z","pushed_at":"2016-11-30T22:19:11Z","git_url":"git://github.com/MosesMendoza/puppet.git","ssh_url":"git@github.com:MosesMendoza/puppet.git","clone_url":"https://github.com/MosesMendoza/puppet.git","svn_url":"https://github.com/MosesMendoza/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":53171,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"0a2b9ea7209ce6722c84ad35f6c4b10b088e8bd6","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-11-30T15:43:05Z","pushed_at":"2016-11-30T22:32:40Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":83835,"stargazers_count":4262,"watchers_count":4262,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1745,"mirror_url":null,"open_issues_count":56,"forks":1745,"open_issues":56,"watchers":4262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5398"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5398"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5398"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5398/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5398/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5398/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/2a4e1236733aea9cba3aa0d16a37bb204d9642fe"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"comments":5,"review_comments":3,"commits":1,"additions":19,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"Iristyle"}}