{"action":"created","comment":{"url":"https://api.github.com/repos/propelorm/Propel2/pulls/comments/55988232","id":55988232,"diff_hunk":"@@ -264,7 +264,7 @@ private function reverseEngineerSchema(OutputInterface $output, array $options)\n         $outputDir = sys_get_temp_dir();\n \n         $this->getApplication()->setAutoExit(false);\n-        $fullDsn = sprintf('%s;user=%s;password=%s', $options['dsn'], urlencode($options['user']), urlencode($options['password']));\n+        $fullDsn = sprintf('%s;user=%s;password=%s', $options['dsn'], $options['user'], $options['password']);","path":"src/Propel/Generator/Command/InitCommand.php","position":5,"original_position":5,"commit_id":"79cdad5a38a28c8a311f2528afd20b855edc25a8","original_commit_id":"79cdad5a38a28c8a311f2528afd20b855edc25a8","user":{"login":"benbankes","id":2132746,"avatar_url":"https://avatars.githubusercontent.com/u/2132746?v=3","gravatar_id":"","url":"https://api.github.com/users/benbankes","html_url":"https://github.com/benbankes","followers_url":"https://api.github.com/users/benbankes/followers","following_url":"https://api.github.com/users/benbankes/following{/other_user}","gists_url":"https://api.github.com/users/benbankes/gists{/gist_id}","starred_url":"https://api.github.com/users/benbankes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbankes/subscriptions","organizations_url":"https://api.github.com/users/benbankes/orgs","repos_url":"https://api.github.com/users/benbankes/repos","events_url":"https://api.github.com/users/benbankes/events{/privacy}","received_events_url":"https://api.github.com/users/benbankes/received_events","type":"User","site_admin":false},"body":"@marcj If we refactor some code, we can pull the username/password out of the dsn.  I would be happy to take a stab at that if that is the way you want to go.  That will be a better solution than simply removing urlencode from values to be placed in the dsn string.","created_at":"2016-03-14T11:43:22Z","updated_at":"2016-03-14T11:43:22Z","html_url":"https://github.com/propelorm/Propel2/pull/1142#discussion_r55988232","pull_request_url":"https://api.github.com/repos/propelorm/Propel2/pulls/1142","_links":{"self":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/comments/55988232"},"html":{"href":"https://github.com/propelorm/Propel2/pull/1142#discussion_r55988232"},"pull_request":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/1142"}}},"pull_request":{"url":"https://api.github.com/repos/propelorm/Propel2/pulls/1142","id":62675051,"html_url":"https://github.com/propelorm/Propel2/pull/1142","diff_url":"https://github.com/propelorm/Propel2/pull/1142.diff","patch_url":"https://github.com/propelorm/Propel2/pull/1142.patch","issue_url":"https://api.github.com/repos/propelorm/Propel2/issues/1142","number":1142,"state":"open","locked":false,"title":"Fix propel init fails when password has special chars","user":{"login":"benbankes","id":2132746,"avatar_url":"https://avatars.githubusercontent.com/u/2132746?v=3","gravatar_id":"","url":"https://api.github.com/users/benbankes","html_url":"https://github.com/benbankes","followers_url":"https://api.github.com/users/benbankes/followers","following_url":"https://api.github.com/users/benbankes/following{/other_user}","gists_url":"https://api.github.com/users/benbankes/gists{/gist_id}","starred_url":"https://api.github.com/users/benbankes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbankes/subscriptions","organizations_url":"https://api.github.com/users/benbankes/orgs","repos_url":"https://api.github.com/users/benbankes/repos","events_url":"https://api.github.com/users/benbankes/events{/privacy}","received_events_url":"https://api.github.com/users/benbankes/received_events","type":"User","site_admin":false},"body":"Fixes #1141","created_at":"2016-03-13T16:16:03Z","updated_at":"2016-03-14T11:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"522586ea5e480642c2f8121357544a53abff683d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/propelorm/Propel2/pulls/1142/commits","review_comments_url":"https://api.github.com/repos/propelorm/Propel2/pulls/1142/comments","review_comment_url":"https://api.github.com/repos/propelorm/Propel2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/propelorm/Propel2/issues/1142/comments","statuses_url":"https://api.github.com/repos/propelorm/Propel2/statuses/79cdad5a38a28c8a311f2528afd20b855edc25a8","head":{"label":"benbankes:patch-1","ref":"patch-1","sha":"79cdad5a38a28c8a311f2528afd20b855edc25a8","user":{"login":"benbankes","id":2132746,"avatar_url":"https://avatars.githubusercontent.com/u/2132746?v=3","gravatar_id":"","url":"https://api.github.com/users/benbankes","html_url":"https://github.com/benbankes","followers_url":"https://api.github.com/users/benbankes/followers","following_url":"https://api.github.com/users/benbankes/following{/other_user}","gists_url":"https://api.github.com/users/benbankes/gists{/gist_id}","starred_url":"https://api.github.com/users/benbankes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbankes/subscriptions","organizations_url":"https://api.github.com/users/benbankes/orgs","repos_url":"https://api.github.com/users/benbankes/repos","events_url":"https://api.github.com/users/benbankes/events{/privacy}","received_events_url":"https://api.github.com/users/benbankes/received_events","type":"User","site_admin":false},"repo":{"id":53794299,"name":"Propel2","full_name":"benbankes/Propel2","owner":{"login":"benbankes","id":2132746,"avatar_url":"https://avatars.githubusercontent.com/u/2132746?v=3","gravatar_id":"","url":"https://api.github.com/users/benbankes","html_url":"https://github.com/benbankes","followers_url":"https://api.github.com/users/benbankes/followers","following_url":"https://api.github.com/users/benbankes/following{/other_user}","gists_url":"https://api.github.com/users/benbankes/gists{/gist_id}","starred_url":"https://api.github.com/users/benbankes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbankes/subscriptions","organizations_url":"https://api.github.com/users/benbankes/orgs","repos_url":"https://api.github.com/users/benbankes/repos","events_url":"https://api.github.com/users/benbankes/events{/privacy}","received_events_url":"https://api.github.com/users/benbankes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benbankes/Propel2","description":"Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP","fork":true,"url":"https://api.github.com/repos/benbankes/Propel2","forks_url":"https://api.github.com/repos/benbankes/Propel2/forks","keys_url":"https://api.github.com/repos/benbankes/Propel2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benbankes/Propel2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benbankes/Propel2/teams","hooks_url":"https://api.github.com/repos/benbankes/Propel2/hooks","issue_events_url":"https://api.github.com/repos/benbankes/Propel2/issues/events{/number}","events_url":"https://api.github.com/repos/benbankes/Propel2/events","assignees_url":"https://api.github.com/repos/benbankes/Propel2/assignees{/user}","branches_url":"https://api.github.com/repos/benbankes/Propel2/branches{/branch}","tags_url":"https://api.github.com/repos/benbankes/Propel2/tags","blobs_url":"https://api.github.com/repos/benbankes/Propel2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benbankes/Propel2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benbankes/Propel2/git/refs{/sha}","trees_url":"https://api.github.com/repos/benbankes/Propel2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benbankes/Propel2/statuses/{sha}","languages_url":"https://api.github.com/repos/benbankes/Propel2/languages","stargazers_url":"https://api.github.com/repos/benbankes/Propel2/stargazers","contributors_url":"https://api.github.com/repos/benbankes/Propel2/contributors","subscribers_url":"https://api.github.com/repos/benbankes/Propel2/subscribers","subscription_url":"https://api.github.com/repos/benbankes/Propel2/subscription","commits_url":"https://api.github.com/repos/benbankes/Propel2/commits{/sha}","git_commits_url":"https://api.github.com/repos/benbankes/Propel2/git/commits{/sha}","comments_url":"https://api.github.com/repos/benbankes/Propel2/comments{/number}","issue_comment_url":"https://api.github.com/repos/benbankes/Propel2/issues/comments{/number}","contents_url":"https://api.github.com/repos/benbankes/Propel2/contents/{+path}","compare_url":"https://api.github.com/repos/benbankes/Propel2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benbankes/Propel2/merges","archive_url":"https://api.github.com/repos/benbankes/Propel2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benbankes/Propel2/downloads","issues_url":"https://api.github.com/repos/benbankes/Propel2/issues{/number}","pulls_url":"https://api.github.com/repos/benbankes/Propel2/pulls{/number}","milestones_url":"https://api.github.com/repos/benbankes/Propel2/milestones{/number}","notifications_url":"https://api.github.com/repos/benbankes/Propel2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benbankes/Propel2/labels{/name}","releases_url":"https://api.github.com/repos/benbankes/Propel2/releases{/id}","deployments_url":"https://api.github.com/repos/benbankes/Propel2/deployments","created_at":"2016-03-13T16:10:15Z","updated_at":"2016-03-13T16:10:20Z","pushed_at":"2016-03-13T16:15:30Z","git_url":"git://github.com/benbankes/Propel2.git","ssh_url":"git@github.com:benbankes/Propel2.git","clone_url":"https://github.com/benbankes/Propel2.git","svn_url":"https://github.com/benbankes/Propel2","homepage":"http://propelorm.org/","size":26571,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"propelorm:master","ref":"master","sha":"a572cda8e680c0f78d8d21cf2e21b034261d9c6b","user":{"login":"propelorm","id":954795,"avatar_url":"https://avatars.githubusercontent.com/u/954795?v=3","gravatar_id":"","url":"https://api.github.com/users/propelorm","html_url":"https://github.com/propelorm","followers_url":"https://api.github.com/users/propelorm/followers","following_url":"https://api.github.com/users/propelorm/following{/other_user}","gists_url":"https://api.github.com/users/propelorm/gists{/gist_id}","starred_url":"https://api.github.com/users/propelorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/propelorm/subscriptions","organizations_url":"https://api.github.com/users/propelorm/orgs","repos_url":"https://api.github.com/users/propelorm/repos","events_url":"https://api.github.com/users/propelorm/events{/privacy}","received_events_url":"https://api.github.com/users/propelorm/received_events","type":"Organization","site_admin":false},"repo":{"id":2524463,"name":"Propel2","full_name":"propelorm/Propel2","owner":{"login":"propelorm","id":954795,"avatar_url":"https://avatars.githubusercontent.com/u/954795?v=3","gravatar_id":"","url":"https://api.github.com/users/propelorm","html_url":"https://github.com/propelorm","followers_url":"https://api.github.com/users/propelorm/followers","following_url":"https://api.github.com/users/propelorm/following{/other_user}","gists_url":"https://api.github.com/users/propelorm/gists{/gist_id}","starred_url":"https://api.github.com/users/propelorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/propelorm/subscriptions","organizations_url":"https://api.github.com/users/propelorm/orgs","repos_url":"https://api.github.com/users/propelorm/repos","events_url":"https://api.github.com/users/propelorm/events{/privacy}","received_events_url":"https://api.github.com/users/propelorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/propelorm/Propel2","description":"Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP","fork":false,"url":"https://api.github.com/repos/propelorm/Propel2","forks_url":"https://api.github.com/repos/propelorm/Propel2/forks","keys_url":"https://api.github.com/repos/propelorm/Propel2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/propelorm/Propel2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/propelorm/Propel2/teams","hooks_url":"https://api.github.com/repos/propelorm/Propel2/hooks","issue_events_url":"https://api.github.com/repos/propelorm/Propel2/issues/events{/number}","events_url":"https://api.github.com/repos/propelorm/Propel2/events","assignees_url":"https://api.github.com/repos/propelorm/Propel2/assignees{/user}","branches_url":"https://api.github.com/repos/propelorm/Propel2/branches{/branch}","tags_url":"https://api.github.com/repos/propelorm/Propel2/tags","blobs_url":"https://api.github.com/repos/propelorm/Propel2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/propelorm/Propel2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/propelorm/Propel2/git/refs{/sha}","trees_url":"https://api.github.com/repos/propelorm/Propel2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/propelorm/Propel2/statuses/{sha}","languages_url":"https://api.github.com/repos/propelorm/Propel2/languages","stargazers_url":"https://api.github.com/repos/propelorm/Propel2/stargazers","contributors_url":"https://api.github.com/repos/propelorm/Propel2/contributors","subscribers_url":"https://api.github.com/repos/propelorm/Propel2/subscribers","subscription_url":"https://api.github.com/repos/propelorm/Propel2/subscription","commits_url":"https://api.github.com/repos/propelorm/Propel2/commits{/sha}","git_commits_url":"https://api.github.com/repos/propelorm/Propel2/git/commits{/sha}","comments_url":"https://api.github.com/repos/propelorm/Propel2/comments{/number}","issue_comment_url":"https://api.github.com/repos/propelorm/Propel2/issues/comments{/number}","contents_url":"https://api.github.com/repos/propelorm/Propel2/contents/{+path}","compare_url":"https://api.github.com/repos/propelorm/Propel2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/propelorm/Propel2/merges","archive_url":"https://api.github.com/repos/propelorm/Propel2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/propelorm/Propel2/downloads","issues_url":"https://api.github.com/repos/propelorm/Propel2/issues{/number}","pulls_url":"https://api.github.com/repos/propelorm/Propel2/pulls{/number}","milestones_url":"https://api.github.com/repos/propelorm/Propel2/milestones{/number}","notifications_url":"https://api.github.com/repos/propelorm/Propel2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/propelorm/Propel2/labels{/name}","releases_url":"https://api.github.com/repos/propelorm/Propel2/releases{/id}","deployments_url":"https://api.github.com/repos/propelorm/Propel2/deployments","created_at":"2011-10-06T06:50:51Z","updated_at":"2016-03-14T09:49:33Z","pushed_at":"2016-03-13T16:16:04Z","git_url":"git://github.com/propelorm/Propel2.git","ssh_url":"git@github.com:propelorm/Propel2.git","clone_url":"https://github.com/propelorm/Propel2.git","svn_url":"https://github.com/propelorm/Propel2","homepage":"http://propelorm.org/","size":30001,"stargazers_count":765,"watchers_count":765,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":175,"forks":217,"open_issues":175,"watchers":765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/1142"},"html":{"href":"https://github.com/propelorm/Propel2/pull/1142"},"issue":{"href":"https://api.github.com/repos/propelorm/Propel2/issues/1142"},"comments":{"href":"https://api.github.com/repos/propelorm/Propel2/issues/1142/comments"},"review_comments":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/1142/comments"},"review_comment":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/propelorm/Propel2/pulls/1142/commits"},"statuses":{"href":"https://api.github.com/repos/propelorm/Propel2/statuses/79cdad5a38a28c8a311f2528afd20b855edc25a8"}}}}