{"action":"created","issue":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/860","repository_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz","labels_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/860/labels{/name}","comments_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/860/comments","events_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/860/events","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/860","id":132010641,"number":860,"title":"Fix scatter: markerEdgeColor unknown + some cleanup","user":{"login":"egeerardyn","id":177360,"avatar_url":"https://avatars.githubusercontent.com/u/177360?v=3","gravatar_id":"","url":"https://api.github.com/users/egeerardyn","html_url":"https://github.com/egeerardyn","followers_url":"https://api.github.com/users/egeerardyn/followers","following_url":"https://api.github.com/users/egeerardyn/following{/other_user}","gists_url":"https://api.github.com/users/egeerardyn/gists{/gist_id}","starred_url":"https://api.github.com/users/egeerardyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeerardyn/subscriptions","organizations_url":"https://api.github.com/users/egeerardyn/orgs","repos_url":"https://api.github.com/users/egeerardyn/repos","events_url":"https://api.github.com/users/egeerardyn/events{/privacy}","received_events_url":"https://api.github.com/users/egeerardyn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/labels/+0.0.1","name":"+0.0.1","color":"d3d7cf"},{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/labels/ready-for-action","name":"ready-for-action","color":"eeeeec"}],"state":"open","locked":false,"assignee":{"login":"miscco","id":3017120,"avatar_url":"https://avatars.githubusercontent.com/u/3017120?v=3","gravatar_id":"","url":"https://api.github.com/users/miscco","html_url":"https://github.com/miscco","followers_url":"https://api.github.com/users/miscco/followers","following_url":"https://api.github.com/users/miscco/following{/other_user}","gists_url":"https://api.github.com/users/miscco/gists{/gist_id}","starred_url":"https://api.github.com/users/miscco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miscco/subscriptions","organizations_url":"https://api.github.com/users/miscco/orgs","repos_url":"https://api.github.com/users/miscco/repos","events_url":"https://api.github.com/users/miscco/events{/privacy}","received_events_url":"https://api.github.com/users/miscco/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/milestones/11","html_url":"https://github.com/matlab2tikz/matlab2tikz/milestones/1.1%20Release","labels_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/milestones/11/labels","id":1027955,"number":11,"title":"1.1 Release","description":"","creator":{"login":"egeerardyn","id":177360,"avatar_url":"https://avatars.githubusercontent.com/u/177360?v=3","gravatar_id":"","url":"https://api.github.com/users/egeerardyn","html_url":"https://github.com/egeerardyn","followers_url":"https://api.github.com/users/egeerardyn/followers","following_url":"https://api.github.com/users/egeerardyn/following{/other_user}","gists_url":"https://api.github.com/users/egeerardyn/gists{/gist_id}","starred_url":"https://api.github.com/users/egeerardyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeerardyn/subscriptions","organizations_url":"https://api.github.com/users/egeerardyn/orgs","repos_url":"https://api.github.com/users/egeerardyn/repos","events_url":"https://api.github.com/users/egeerardyn/events{/privacy}","received_events_url":"https://api.github.com/users/egeerardyn/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":60,"state":"open","created_at":"2015-03-18T19:15:33Z","updated_at":"2016-02-08T11:06:31Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2016-02-07T20:50:14Z","updated_at":"2016-02-08T14:14:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/860","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/860","diff_url":"https://github.com/matlab2tikz/matlab2tikz/pull/860.diff","patch_url":"https://github.com/matlab2tikz/matlab2tikz/pull/860.patch"},"body":"This should fix something that was reported on FEX:\r\n\r\n> **Comment from FEX: 07 Feb 2016 by Raph**\r\n> Using scatter() I get the error\r\n>\r\n>> Undefined function or variable 'markerEdgeColor'. \r\n>> ```\r\n>> Error in matlab2tikz>getScatterOptsColormap (line 3237) \r\n>> [m2t, ecolor] = getColor(m2t, h, markerEdgeColor,'patch');\r\n>> ```\r\n>\r\n> Adding the line \r\n> ```\u001Dmatlab\r\n> markerEdgeColor = get(h, 'MarkerEdgeColor'); \r\n> ```\r\n> helps, maybe you can include this or provide a better fix.\r\n\r\nInstead of the perfectly good fix suggested above, I took the opportunity to move some variables into a struct such that other functions can take fewer parameters. The introduced functions do not have any other call sites (according to MATLAB highlighting).\r\n\r\nNote that the surrounding code could use some TLC, e.g. the other place where we do a `translateMarker` could be simplified together with this. But that's for another day and PR."},"comment":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/comments/181389046","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/860#issuecomment-181389046","issue_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/860","id":181389046,"user":{"login":"miscco","id":3017120,"avatar_url":"https://avatars.githubusercontent.com/u/3017120?v=3","gravatar_id":"","url":"https://api.github.com/users/miscco","html_url":"https://github.com/miscco","followers_url":"https://api.github.com/users/miscco/followers","following_url":"https://api.github.com/users/miscco/following{/other_user}","gists_url":"https://api.github.com/users/miscco/gists{/gist_id}","starred_url":"https://api.github.com/users/miscco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miscco/subscriptions","organizations_url":"https://api.github.com/users/miscco/orgs","repos_url":"https://api.github.com/users/miscco/repos","events_url":"https://api.github.com/users/miscco/events{/privacy}","received_events_url":"https://api.github.com/users/miscco/received_events","type":"User","site_admin":false},"created_at":"2016-02-08T14:14:32Z","updated_at":"2016-02-08T14:14:32Z","body":"All in all a very nice PR. Loving it! "}}