{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3156","repository_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3156/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3156/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3156/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3156","id":169026556,"number":3156,"title":"[1.10.2] RegistryDelegate#setName is called before a persistent substitution is activated","user":{"login":"Madsthunder","id":12476160,"avatar_url":"https://avatars.githubusercontent.com/u/12476160?v=3","gravatar_id":"","url":"https://api.github.com/users/Madsthunder","html_url":"https://github.com/Madsthunder","followers_url":"https://api.github.com/users/Madsthunder/followers","following_url":"https://api.github.com/users/Madsthunder/following{/other_user}","gists_url":"https://api.github.com/users/Madsthunder/gists{/gist_id}","starred_url":"https://api.github.com/users/Madsthunder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madsthunder/subscriptions","organizations_url":"https://api.github.com/users/Madsthunder/orgs","repos_url":"https://api.github.com/users/Madsthunder/repos","events_url":"https://api.github.com/users/Madsthunder/events{/privacy}","received_events_url":"https://api.github.com/users/Madsthunder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-03T01:25:10Z","updated_at":"2016-08-09T23:54:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3156","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3156","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3156.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3156.patch"},"body":"Adds a line to FMLControlledNamespacedRegistry#activateSubstitution that sets the name to the nameToReplace variable. Resolves #3131 "},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/238727972","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3156#issuecomment-238727972","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3156","id":238727972,"user":{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T23:54:30Z","updated_at":"2016-08-09T23:54:30Z","body":"My concern is that the sub should NOT be changing names during run time. Which this does. A delegate should never change names.\r\nThe name *should* be set before the sub is registered.  As sub should simply be \"When you ask for NameA you get ObjectB, but when you ask for NameB you also get ObjectB, and ObjectB's name is NameB\"\r\nBut I leave this with @cpw as the registry is his masterpiece."}}
{"actor":{"display_login":"LexManos"}}