{"action":"created","comment":{"url":"https://api.github.com/repos/vega/lyra/pulls/comments/55606257","id":55606257,"diff_hunk":"@@ -5,6 +5,7 @@\n   bottom: 0;\n   width: $inspector-width;\n   background-color: $lblue-bg;\n+  overflow-y: scroll;","path":"src/scss/inspector.scss","position":4,"original_position":4,"commit_id":"2f2e0cdead55f3388d3fe1b91544bb9909e0594e","original_commit_id":"2f2e0cdead55f3388d3fe1b91544bb9909e0594e","user":{"login":"deathbearbrown","id":607541,"avatar_url":"https://avatars.githubusercontent.com/u/607541?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbearbrown","html_url":"https://github.com/deathbearbrown","followers_url":"https://api.github.com/users/deathbearbrown/followers","following_url":"https://api.github.com/users/deathbearbrown/following{/other_user}","gists_url":"https://api.github.com/users/deathbearbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbearbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbearbrown/subscriptions","organizations_url":"https://api.github.com/users/deathbearbrown/orgs","repos_url":"https://api.github.com/users/deathbearbrown/repos","events_url":"https://api.github.com/users/deathbearbrown/events{/privacy}","received_events_url":"https://api.github.com/users/deathbearbrown/received_events","type":"User","site_admin":false},"body":"+1 lol","created_at":"2016-03-09T23:00:46Z","updated_at":"2016-03-09T23:00:46Z","html_url":"https://github.com/vega/lyra/pull/281#discussion_r55606257","pull_request_url":"https://api.github.com/repos/vega/lyra/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/vega/lyra/pulls/comments/55606257"},"html":{"href":"https://github.com/vega/lyra/pull/281#discussion_r55606257"},"pull_request":{"href":"https://api.github.com/repos/vega/lyra/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/vega/lyra/pulls/281","id":62246811,"html_url":"https://github.com/vega/lyra/pull/281","diff_url":"https://github.com/vega/lyra/pull/281.diff","patch_url":"https://github.com/vega/lyra/pull/281.patch","issue_url":"https://api.github.com/repos/vega/lyra/issues/281","number":281,"state":"open","locked":false,"title":"Implement text marks","user":{"login":"kadamwhite","id":442115,"avatar_url":"https://avatars.githubusercontent.com/u/442115?v=3","gravatar_id":"","url":"https://api.github.com/users/kadamwhite","html_url":"https://github.com/kadamwhite","followers_url":"https://api.github.com/users/kadamwhite/followers","following_url":"https://api.github.com/users/kadamwhite/following{/other_user}","gists_url":"https://api.github.com/users/kadamwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/kadamwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadamwhite/subscriptions","organizations_url":"https://api.github.com/users/kadamwhite/orgs","repos_url":"https://api.github.com/users/kadamwhite/repos","events_url":"https://api.github.com/users/kadamwhite/events{/privacy}","received_events_url":"https://api.github.com/users/kadamwhite/received_events","type":"User","site_admin":false},"body":"### Description of the problem this pull request fixes\r\n\r\nAdd support for Text marks and initialize the scene with a dummy text mark instance\r\n\r\nChanges proposed in this pull request:\r\n- Add Text mark with associated manipulators and properties panel. Supported properties should have parity with lyra 1.\r\n- Permit properties window to scroll vertically when it doesn't fit on my teeny laptop screen (very rough impl)\r\n\r\n** If submitting code for review: **\r\n\r\n#### This PR includes:\r\n- [x] Tests\r\n- [x] functional comments\r\n- [ ] high level description of any new components\r\n\r\n### To-Do:\r\n- [x] define connectors\r\n- [x] define channels\r\n- [x] tests!\r\n- [ ] ~~Move hard-coded option dropdowns into vega schema~~\r\n\r\nLYRA-226\r\n\r\nFor #227","created_at":"2016-03-09T15:37:55Z","updated_at":"2016-03-09T23:00:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bec15fc672b05b354069ab32494fd5dc0a838369","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vega/lyra/pulls/281/commits","review_comments_url":"https://api.github.com/repos/vega/lyra/pulls/281/comments","review_comment_url":"https://api.github.com/repos/vega/lyra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/lyra/issues/281/comments","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/2f2e0cdead55f3388d3fe1b91544bb9909e0594e","head":{"label":"vega:feature/implement-text-marks","ref":"feature/implement-text-marks","sha":"2f2e0cdead55f3388d3fe1b91544bb9909e0594e","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":6179334,"name":"lyra","full_name":"vega/lyra","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/lyra","description":"An interactive, graphical Visualization Design Environment (VDE)","fork":false,"url":"https://api.github.com/repos/vega/lyra","forks_url":"https://api.github.com/repos/vega/lyra/forks","keys_url":"https://api.github.com/repos/vega/lyra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/lyra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/lyra/teams","hooks_url":"https://api.github.com/repos/vega/lyra/hooks","issue_events_url":"https://api.github.com/repos/vega/lyra/issues/events{/number}","events_url":"https://api.github.com/repos/vega/lyra/events","assignees_url":"https://api.github.com/repos/vega/lyra/assignees{/user}","branches_url":"https://api.github.com/repos/vega/lyra/branches{/branch}","tags_url":"https://api.github.com/repos/vega/lyra/tags","blobs_url":"https://api.github.com/repos/vega/lyra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/lyra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/lyra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/lyra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/lyra/languages","stargazers_url":"https://api.github.com/repos/vega/lyra/stargazers","contributors_url":"https://api.github.com/repos/vega/lyra/contributors","subscribers_url":"https://api.github.com/repos/vega/lyra/subscribers","subscription_url":"https://api.github.com/repos/vega/lyra/subscription","commits_url":"https://api.github.com/repos/vega/lyra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/lyra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/lyra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/lyra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/lyra/contents/{+path}","compare_url":"https://api.github.com/repos/vega/lyra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/lyra/merges","archive_url":"https://api.github.com/repos/vega/lyra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/lyra/downloads","issues_url":"https://api.github.com/repos/vega/lyra/issues{/number}","pulls_url":"https://api.github.com/repos/vega/lyra/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/lyra/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/lyra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/lyra/labels{/name}","releases_url":"https://api.github.com/repos/vega/lyra/releases{/id}","deployments_url":"https://api.github.com/repos/vega/lyra/deployments","created_at":"2012-10-11T19:16:35Z","updated_at":"2016-03-08T22:07:38Z","pushed_at":"2016-03-09T22:54:57Z","git_url":"git://github.com/vega/lyra.git","ssh_url":"git@github.com:vega/lyra.git","clone_url":"https://github.com/vega/lyra.git","svn_url":"https://github.com/vega/lyra","homepage":"http://idl.cs.washington.edu/projects/lyra/","size":7398,"stargazers_count":566,"watchers_count":566,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":45,"forks":99,"open_issues":45,"watchers":566,"default_branch":"lyra2"}},"base":{"label":"vega:lyra2","ref":"lyra2","sha":"737f21c2bbbcd17e50c2b20a4374e6b8356a392b","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":6179334,"name":"lyra","full_name":"vega/lyra","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/lyra","description":"An interactive, graphical Visualization Design Environment (VDE)","fork":false,"url":"https://api.github.com/repos/vega/lyra","forks_url":"https://api.github.com/repos/vega/lyra/forks","keys_url":"https://api.github.com/repos/vega/lyra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/lyra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/lyra/teams","hooks_url":"https://api.github.com/repos/vega/lyra/hooks","issue_events_url":"https://api.github.com/repos/vega/lyra/issues/events{/number}","events_url":"https://api.github.com/repos/vega/lyra/events","assignees_url":"https://api.github.com/repos/vega/lyra/assignees{/user}","branches_url":"https://api.github.com/repos/vega/lyra/branches{/branch}","tags_url":"https://api.github.com/repos/vega/lyra/tags","blobs_url":"https://api.github.com/repos/vega/lyra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/lyra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/lyra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/lyra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/lyra/languages","stargazers_url":"https://api.github.com/repos/vega/lyra/stargazers","contributors_url":"https://api.github.com/repos/vega/lyra/contributors","subscribers_url":"https://api.github.com/repos/vega/lyra/subscribers","subscription_url":"https://api.github.com/repos/vega/lyra/subscription","commits_url":"https://api.github.com/repos/vega/lyra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/lyra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/lyra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/lyra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/lyra/contents/{+path}","compare_url":"https://api.github.com/repos/vega/lyra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/lyra/merges","archive_url":"https://api.github.com/repos/vega/lyra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/lyra/downloads","issues_url":"https://api.github.com/repos/vega/lyra/issues{/number}","pulls_url":"https://api.github.com/repos/vega/lyra/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/lyra/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/lyra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/lyra/labels{/name}","releases_url":"https://api.github.com/repos/vega/lyra/releases{/id}","deployments_url":"https://api.github.com/repos/vega/lyra/deployments","created_at":"2012-10-11T19:16:35Z","updated_at":"2016-03-08T22:07:38Z","pushed_at":"2016-03-09T22:54:57Z","git_url":"git://github.com/vega/lyra.git","ssh_url":"git@github.com:vega/lyra.git","clone_url":"https://github.com/vega/lyra.git","svn_url":"https://github.com/vega/lyra","homepage":"http://idl.cs.washington.edu/projects/lyra/","size":7398,"stargazers_count":566,"watchers_count":566,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":45,"forks":99,"open_issues":45,"watchers":566,"default_branch":"lyra2"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/lyra/pulls/281"},"html":{"href":"https://github.com/vega/lyra/pull/281"},"issue":{"href":"https://api.github.com/repos/vega/lyra/issues/281"},"comments":{"href":"https://api.github.com/repos/vega/lyra/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/lyra/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/lyra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/lyra/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/vega/lyra/statuses/2f2e0cdead55f3388d3fe1b91544bb9909e0594e"}}}}