{"action":"created","issue":{"url":"https://api.github.com/repos/fact-project/fact-tools/issues/145","repository_url":"https://api.github.com/repos/fact-project/fact-tools","labels_url":"https://api.github.com/repos/fact-project/fact-tools/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/fact-project/fact-tools/issues/145/comments","events_url":"https://api.github.com/repos/fact-project/fact-tools/issues/145/events","html_url":"https://github.com/fact-project/fact-tools/pull/145","id":174312900,"number":145,"title":"Fix javadocs and some imports in sebastians single pe extractor","user":{"login":"mackaiver","id":4076745,"avatar_url":"https://avatars.githubusercontent.com/u/4076745?v=3","gravatar_id":"","url":"https://api.github.com/users/mackaiver","html_url":"https://github.com/mackaiver","followers_url":"https://api.github.com/users/mackaiver/followers","following_url":"https://api.github.com/users/mackaiver/following{/other_user}","gists_url":"https://api.github.com/users/mackaiver/gists{/gist_id}","starred_url":"https://api.github.com/users/mackaiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mackaiver/subscriptions","organizations_url":"https://api.github.com/users/mackaiver/orgs","repos_url":"https://api.github.com/users/mackaiver/repos","events_url":"https://api.github.com/users/mackaiver/events{/privacy}","received_events_url":"https://api.github.com/users/mackaiver/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-31T16:02:52Z","updated_at":"2016-09-12T09:37:17Z","closed_at":"2016-09-12T09:37:17Z","pull_request":{"url":"https://api.github.com/repos/fact-project/fact-tools/pulls/145","html_url":"https://github.com/fact-project/fact-tools/pull/145","diff_url":"https://github.com/fact-project/fact-tools/pull/145.diff","patch_url":"https://github.com/fact-project/fact-tools/pull/145.patch"},"body":"The title says it all. This is basically cosmetics. I however would like to discuss how to handle methods that modify an array in-place instead of returning it. Personally I prefer to return the modified object. Or maybe even better yet: copy the thing and return a new thing. What do you think?"},"comment":{"url":"https://api.github.com/repos/fact-project/fact-tools/issues/comments/246297208","html_url":"https://github.com/fact-project/fact-tools/pull/145#issuecomment-246297208","issue_url":"https://api.github.com/repos/fact-project/fact-tools/issues/145","id":246297208,"user":{"login":"relleums","id":17047733,"avatar_url":"https://avatars.githubusercontent.com/u/17047733?v=3","gravatar_id":"","url":"https://api.github.com/users/relleums","html_url":"https://github.com/relleums","followers_url":"https://api.github.com/users/relleums/followers","following_url":"https://api.github.com/users/relleums/following{/other_user}","gists_url":"https://api.github.com/users/relleums/gists{/gist_id}","starred_url":"https://api.github.com/users/relleums/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relleums/subscriptions","organizations_url":"https://api.github.com/users/relleums/orgs","repos_url":"https://api.github.com/users/relleums/repos","events_url":"https://api.github.com/users/relleums/events{/privacy}","received_events_url":"https://api.github.com/users/relleums/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T09:37:17Z","updated_at":"2016-09-12T09:37:17Z","body":"I vote for\r\n\r\n- not fixing the 'return copy' issue yet\r\n- either using my old explicit for loop with the running index or using the variable name 'slice'  or 'timeSlice' instead of 'aTimeLine' for your range based for loop.\r\n- fixing all the javadocs and imports, as it is implied by your branch name\r\n\r\nand then, merging back.\r\n\r\nJens and I already now know that we want to change/finalize the single pulse extractor API before going in production (returning arrays of arrays instead of ArrayLists of ArrayLists). I would like to branch and work in these changes the moment you got the imports and javadocs corrected."}}
{"actor":{"display_login":"relleums"}}