{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/63381749","id":63381749,"diff_hunk":"@@ -75,40 +153,27 @@ def __virtual__():\n     return (False, 'firewall-cmd is not available, firewalld is probably not installed.')\n \n \n-def present(name,","path":"salt/states/firewalld.py","position":121,"original_position":121,"commit_id":"8c9aa371f6c9fa72845d2cce669d9a6f00631814","original_commit_id":"8c9aa371f6c9fa72845d2cce669d9a6f00631814","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"Is it necessary to rename this? If it's absolutely necessary we need to add documentation on this because we'll break existing states.","created_at":"2016-05-16T16:30:18Z","updated_at":"2016-05-16T16:30:18Z","html_url":"https://github.com/saltstack/salt/pull/33259#discussion_r63381749","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/33259","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/63381749"},"html":{"href":"https://github.com/saltstack/salt/pull/33259#discussion_r63381749"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/33259"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/33259","id":70103451,"html_url":"https://github.com/saltstack/salt/pull/33259","diff_url":"https://github.com/saltstack/salt/pull/33259.diff","patch_url":"https://github.com/saltstack/salt/pull/33259.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/33259","number":33259,"state":"open","locked":false,"title":"Enhance firewalld state.","user":{"login":"whatevsz","id":3748696,"avatar_url":"https://avatars.githubusercontent.com/u/3748696?v=3","gravatar_id":"","url":"https://api.github.com/users/whatevsz","html_url":"https://github.com/whatevsz","followers_url":"https://api.github.com/users/whatevsz/followers","following_url":"https://api.github.com/users/whatevsz/following{/other_user}","gists_url":"https://api.github.com/users/whatevsz/gists{/gist_id}","starred_url":"https://api.github.com/users/whatevsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatevsz/subscriptions","organizations_url":"https://api.github.com/users/whatevsz/orgs","repos_url":"https://api.github.com/users/whatevsz/repos","events_url":"https://api.github.com/users/whatevsz/events{/privacy}","received_events_url":"https://api.github.com/users/whatevsz/received_events","type":"User","site_admin":false},"body":"This pull request introduces various changes to the firewalld state and execution module. The commit messages go into detail, but here is an overview:\r\n\r\n* New state to handle firewalld services which uses functionality introduced in firewalld 0.4.0.\r\n* Rename the `present` state to `zone` now that there is more than one state.\r\n* Change the behavior of the `zone` state as detailed in #33159:\r\n  * State execution is atomic with respect to runtime configuration.\r\n  * State execution time cut to half because the commands are no longer run twice.\r\n* Some small changes that should make the code easier to read and maintainable.\r\n\r\nI've not written any new tests, if they are wanted or required I will add them.\r\n\r\nCloses #33159\r\n","created_at":"2016-05-14T20:45:40Z","updated_at":"2016-05-16T16:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"001cc4bd812a4ff8bc6826829390b964414dce6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/33259/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/33259/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/33259/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/8c9aa371f6c9fa72845d2cce669d9a6f00631814","head":{"label":"whatevsz:firewalld","ref":"firewalld","sha":"8c9aa371f6c9fa72845d2cce669d9a6f00631814","user":{"login":"whatevsz","id":3748696,"avatar_url":"https://avatars.githubusercontent.com/u/3748696?v=3","gravatar_id":"","url":"https://api.github.com/users/whatevsz","html_url":"https://github.com/whatevsz","followers_url":"https://api.github.com/users/whatevsz/followers","following_url":"https://api.github.com/users/whatevsz/following{/other_user}","gists_url":"https://api.github.com/users/whatevsz/gists{/gist_id}","starred_url":"https://api.github.com/users/whatevsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatevsz/subscriptions","organizations_url":"https://api.github.com/users/whatevsz/orgs","repos_url":"https://api.github.com/users/whatevsz/repos","events_url":"https://api.github.com/users/whatevsz/events{/privacy}","received_events_url":"https://api.github.com/users/whatevsz/received_events","type":"User","site_admin":false},"repo":{"id":47554943,"name":"salt","full_name":"whatevsz/salt","owner":{"login":"whatevsz","id":3748696,"avatar_url":"https://avatars.githubusercontent.com/u/3748696?v=3","gravatar_id":"","url":"https://api.github.com/users/whatevsz","html_url":"https://github.com/whatevsz","followers_url":"https://api.github.com/users/whatevsz/followers","following_url":"https://api.github.com/users/whatevsz/following{/other_user}","gists_url":"https://api.github.com/users/whatevsz/gists{/gist_id}","starred_url":"https://api.github.com/users/whatevsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatevsz/subscriptions","organizations_url":"https://api.github.com/users/whatevsz/orgs","repos_url":"https://api.github.com/users/whatevsz/repos","events_url":"https://api.github.com/users/whatevsz/events{/privacy}","received_events_url":"https://api.github.com/users/whatevsz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whatevsz/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/whatevsz/salt","forks_url":"https://api.github.com/repos/whatevsz/salt/forks","keys_url":"https://api.github.com/repos/whatevsz/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatevsz/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatevsz/salt/teams","hooks_url":"https://api.github.com/repos/whatevsz/salt/hooks","issue_events_url":"https://api.github.com/repos/whatevsz/salt/issues/events{/number}","events_url":"https://api.github.com/repos/whatevsz/salt/events","assignees_url":"https://api.github.com/repos/whatevsz/salt/assignees{/user}","branches_url":"https://api.github.com/repos/whatevsz/salt/branches{/branch}","tags_url":"https://api.github.com/repos/whatevsz/salt/tags","blobs_url":"https://api.github.com/repos/whatevsz/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatevsz/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatevsz/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatevsz/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatevsz/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/whatevsz/salt/languages","stargazers_url":"https://api.github.com/repos/whatevsz/salt/stargazers","contributors_url":"https://api.github.com/repos/whatevsz/salt/contributors","subscribers_url":"https://api.github.com/repos/whatevsz/salt/subscribers","subscription_url":"https://api.github.com/repos/whatevsz/salt/subscription","commits_url":"https://api.github.com/repos/whatevsz/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatevsz/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatevsz/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatevsz/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatevsz/salt/contents/{+path}","compare_url":"https://api.github.com/repos/whatevsz/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatevsz/salt/merges","archive_url":"https://api.github.com/repos/whatevsz/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatevsz/salt/downloads","issues_url":"https://api.github.com/repos/whatevsz/salt/issues{/number}","pulls_url":"https://api.github.com/repos/whatevsz/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/whatevsz/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/whatevsz/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatevsz/salt/labels{/name}","releases_url":"https://api.github.com/repos/whatevsz/salt/releases{/id}","deployments_url":"https://api.github.com/repos/whatevsz/salt/deployments","created_at":"2015-12-07T13:51:07Z","updated_at":"2016-01-12T01:45:25Z","pushed_at":"2016-05-16T14:32:09Z","git_url":"git://github.com/whatevsz/salt.git","ssh_url":"git@github.com:whatevsz/salt.git","clone_url":"https://github.com/whatevsz/salt.git","svn_url":"https://github.com/whatevsz/salt","homepage":"saltstack.com","size":159647,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"30ca6443a9c7776513c24ff065a4c73584165a74","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-05-16T06:16:23Z","pushed_at":"2016-05-16T16:27:40Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":226797,"stargazers_count":6525,"watchers_count":6525,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2888,"mirror_url":null,"open_issues_count":3555,"forks":2888,"open_issues":3555,"watchers":6525,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/33259"},"html":{"href":"https://github.com/saltstack/salt/pull/33259"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/33259"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/33259/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/33259/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/33259/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/8c9aa371f6c9fa72845d2cce669d9a6f00631814"}}}}