{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/65457847","id":65457847,"diff_hunk":"@@ -4393,7 +4382,14 @@ void            CodeGen::genFnPrologCalleeRegArgs(regNumber xtraReg,\n         else\n         {\n             // Since slot is typically 1, baseOffset is typically 0\n-            int baseOffset = (regArgTab[argNum].slot - 1) * slotSize;\n+            int slot = regArgTab[argNum].slot;","path":"src/jit/codegencommon.cpp","position":23,"original_position":23,"commit_id":"177e3a13550ea677a1a502e0807dd04ef9564360","original_commit_id":"177e3a13550ea677a1a502e0807dd04ef9564360","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"body":"This patch also works :+1: ","created_at":"2016-06-01T22:54:41Z","updated_at":"2016-06-01T22:54:41Z","html_url":"https://github.com/dotnet/coreclr/pull/5352#discussion_r65457847","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5352","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/65457847"},"html":{"href":"https://github.com/dotnet/coreclr/pull/5352#discussion_r65457847"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5352"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/5352","id":72103390,"html_url":"https://github.com/dotnet/coreclr/pull/5352","diff_url":"https://github.com/dotnet/coreclr/pull/5352.diff","patch_url":"https://github.com/dotnet/coreclr/pull/5352.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/5352","number":5352,"state":"open","locked":false,"title":"Revise variable offset on double in ARM HFA","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"body":"ARM codegen currently uses the incorrect offset when it saves the\r\narguments onto the stack if the argument is HFA of double type.\r\n\r\nThis commit tries to make it correct in order to fix #5326.","created_at":"2016-05-31T23:45:57Z","updated_at":"2016-06-01T22:54:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b86619e346c40e61d3eb953b9b9c12ae5da36abe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5352/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5352/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/5352/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/177e3a13550ea677a1a502e0807dd04ef9564360","head":{"label":"parjong:fix/issue_5326","ref":"fix/issue_5326","sha":"177e3a13550ea677a1a502e0807dd04ef9564360","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"repo":{"id":55585145,"name":"coreclr","full_name":"parjong/coreclr","owner":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parjong/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/parjong/coreclr","forks_url":"https://api.github.com/repos/parjong/coreclr/forks","keys_url":"https://api.github.com/repos/parjong/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parjong/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parjong/coreclr/teams","hooks_url":"https://api.github.com/repos/parjong/coreclr/hooks","issue_events_url":"https://api.github.com/repos/parjong/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/parjong/coreclr/events","assignees_url":"https://api.github.com/repos/parjong/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/parjong/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/parjong/coreclr/tags","blobs_url":"https://api.github.com/repos/parjong/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parjong/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parjong/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/parjong/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parjong/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/parjong/coreclr/languages","stargazers_url":"https://api.github.com/repos/parjong/coreclr/stargazers","contributors_url":"https://api.github.com/repos/parjong/coreclr/contributors","subscribers_url":"https://api.github.com/repos/parjong/coreclr/subscribers","subscription_url":"https://api.github.com/repos/parjong/coreclr/subscription","commits_url":"https://api.github.com/repos/parjong/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/parjong/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/parjong/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/parjong/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/parjong/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/parjong/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parjong/coreclr/merges","archive_url":"https://api.github.com/repos/parjong/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parjong/coreclr/downloads","issues_url":"https://api.github.com/repos/parjong/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/parjong/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/parjong/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/parjong/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parjong/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/parjong/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/parjong/coreclr/deployments","created_at":"2016-04-06T07:32:51Z","updated_at":"2016-04-26T00:03:39Z","pushed_at":"2016-06-01T22:25:16Z","git_url":"git://github.com/parjong/coreclr.git","ssh_url":"git@github.com:parjong/coreclr.git","clone_url":"https://github.com/parjong/coreclr.git","svn_url":"https://github.com/parjong/coreclr","homepage":"http://dotnet.github.io/","size":85186,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1b45b04775415a1bf226b3baec536aa7d9a005a3","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-06-01T20:31:27Z","pushed_at":"2016-06-01T22:40:51Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":92546,"stargazers_count":6452,"watchers_count":6452,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1470,"mirror_url":null,"open_issues_count":779,"forks":1470,"open_issues":779,"watchers":6452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5352"},"html":{"href":"https://github.com/dotnet/coreclr/pull/5352"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/5352"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/5352/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5352/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5352/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/177e3a13550ea677a1a502e0807dd04ef9564360"}}}}
{"actor":{"display_login":"parjong"}}