{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/78725753","id":78725753,"diff_hunk":"@@ -1,6 +1,45 @@\n-[0-9]+\".\"[0-9]+([eE][-+]?[0-9]+)? {\n-  MakeDoubleLiteral(yytext, &yylval.attr[1]);\n-  yysetpos();\n-  return DOUBLE_LITERAL;\n+\t/* This contains both INTEGER_LITERAL and DOUBLE_LITERAL rules */\n+\t/* This ensures that they appear in this order, to ensure they match */\n+\t/* correctly. */\n+","path":"toolchain/lc-compile/src/DOUBLE_LITERAL.t","position":8,"original_position":8,"commit_id":"160b89c9e5167ce9ae1434d3b01bd4a58a820600","original_commit_id":"160b89c9e5167ce9ae1434d3b01bd4a58a820600","user":{"login":"runrevmark","id":3985298,"avatar_url":"https://avatars.githubusercontent.com/u/3985298?v=3","gravatar_id":"","url":"https://api.github.com/users/runrevmark","html_url":"https://github.com/runrevmark","followers_url":"https://api.github.com/users/runrevmark/followers","following_url":"https://api.github.com/users/runrevmark/following{/other_user}","gists_url":"https://api.github.com/users/runrevmark/gists{/gist_id}","starred_url":"https://api.github.com/users/runrevmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runrevmark/subscriptions","organizations_url":"https://api.github.com/users/runrevmark/orgs","repos_url":"https://api.github.com/users/runrevmark/repos","events_url":"https://api.github.com/users/runrevmark/events{/privacy}","received_events_url":"https://api.github.com/users/runrevmark/received_events","type":"User","site_admin":false},"body":"Unfortunately not - I tried that but it makes reflex choke - it expects a .t file for each token.","created_at":"2016-09-14T10:47:13Z","updated_at":"2016-09-14T10:47:13Z","html_url":"https://github.com/livecode/livecode/pull/4494#discussion_r78725753","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/4494","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/78725753"},"html":{"href":"https://github.com/livecode/livecode/pull/4494#discussion_r78725753"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4494"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/4494","id":85204294,"html_url":"https://github.com/livecode/livecode/pull/4494","diff_url":"https://github.com/livecode/livecode/pull/4494.diff","patch_url":"https://github.com/livecode/livecode/pull/4494.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/4494","number":4494,"state":"open","locked":false,"title":"[[ LCB ]] Improve tokenisation of numbers and add hex and bin literals","user":{"login":"runrevmark","id":3985298,"avatar_url":"https://avatars.githubusercontent.com/u/3985298?v=3","gravatar_id":"","url":"https://api.github.com/users/runrevmark","html_url":"https://github.com/runrevmark","followers_url":"https://api.github.com/users/runrevmark/followers","following_url":"https://api.github.com/users/runrevmark/following{/other_user}","gists_url":"https://api.github.com/users/runrevmark/gists{/gist_id}","starred_url":"https://api.github.com/users/runrevmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runrevmark/subscriptions","organizations_url":"https://api.github.com/users/runrevmark/orgs","repos_url":"https://api.github.com/users/runrevmark/repos","events_url":"https://api.github.com/users/runrevmark/events{/privacy}","received_events_url":"https://api.github.com/users/runrevmark/received_events","type":"User","site_admin":false},"body":"This patch improves the tokenisation of numbers in lc-compile and adds\r\nsupport for hexadecimal and binary integer literals.\r\n\r\nThe compiler will now complain about any invalid suffixes on numeric\r\nliterals, meaning that it is not possible to accidentally elide a\r\nnumeric literal with an identifier.\r\n\r\nHexadecimal literals are specified using the prefix \"0x\".\r\n\r\nBinary literals are specified using the prefix \"0b\".\r\n\r\nReal literals have been made more flexible and accurate. In particular,\r\nleading zeros are now checked for in all but the fractional part, and\r\nconsidering a real number to be of the form:\r\n\r\n    Int DecPoint Frac Exp\r\n\r\nThe allowed forms are:\r\n\r\n     Int+DecPoint\r\n     Int+Exp\r\n     Int+DecPoint+Exp\r\n     Int+DecPoint+Frac\r\n     Int+DecPoint+Frac+Exp\r\n     DecPoint+Frac\r\n     DecPoint+Frac+Exp\r\n\r\nAll other combinations will be flagged as a 'malformed real literal'\r\nerror.\r\n\r\nNote: As the regex for integers now intersects with that for reals\r\n(e.g. 1e1 could be an integer with suffix, or a real) rules for both\r\nDOUBLE and INTEGER literals are now in DOUBLE_LITERAL.t with the DOUBLE\r\nrules first. This ensures DOUBLE_LITERAL matches in preference to\r\nINTEGER_LITERAL.","created_at":"2016-09-14T10:37:56Z","updated_at":"2016-09-14T10:47:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0884c46c19b53ba7b52250229f63674fbc89ec17","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/livecode/livecode/milestones/118","html_url":"https://github.com/livecode/livecode/milestones/8.2.0-dp-1","labels_url":"https://api.github.com/repos/livecode/livecode/milestones/118/labels","id":1969211,"number":118,"title":"8.2.0-dp-1","description":null,"creator":{"login":"livecodeali","id":3985854,"avatar_url":"https://avatars.githubusercontent.com/u/3985854?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeali","html_url":"https://github.com/livecodeali","followers_url":"https://api.github.com/users/livecodeali/followers","following_url":"https://api.github.com/users/livecodeali/following{/other_user}","gists_url":"https://api.github.com/users/livecodeali/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeali/subscriptions","organizations_url":"https://api.github.com/users/livecodeali/orgs","repos_url":"https://api.github.com/users/livecodeali/repos","events_url":"https://api.github.com/users/livecodeali/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeali/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":22,"state":"open","created_at":"2016-08-29T09:35:57Z","updated_at":"2016-09-14T10:37:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/4494/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/4494/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/4494/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/160b89c9e5167ce9ae1434d3b01bd4a58a820600","head":{"label":"runrevmark:lcb-hex_binary_literals","ref":"lcb-hex_binary_literals","sha":"160b89c9e5167ce9ae1434d3b01bd4a58a820600","user":{"login":"runrevmark","id":3985298,"avatar_url":"https://avatars.githubusercontent.com/u/3985298?v=3","gravatar_id":"","url":"https://api.github.com/users/runrevmark","html_url":"https://github.com/runrevmark","followers_url":"https://api.github.com/users/runrevmark/followers","following_url":"https://api.github.com/users/runrevmark/following{/other_user}","gists_url":"https://api.github.com/users/runrevmark/gists{/gist_id}","starred_url":"https://api.github.com/users/runrevmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runrevmark/subscriptions","organizations_url":"https://api.github.com/users/runrevmark/orgs","repos_url":"https://api.github.com/users/runrevmark/repos","events_url":"https://api.github.com/users/runrevmark/events{/privacy}","received_events_url":"https://api.github.com/users/runrevmark/received_events","type":"User","site_admin":false},"repo":{"id":9373954,"name":"livecode","full_name":"runrevmark/livecode","owner":{"login":"runrevmark","id":3985298,"avatar_url":"https://avatars.githubusercontent.com/u/3985298?v=3","gravatar_id":"","url":"https://api.github.com/users/runrevmark","html_url":"https://github.com/runrevmark","followers_url":"https://api.github.com/users/runrevmark/followers","following_url":"https://api.github.com/users/runrevmark/following{/other_user}","gists_url":"https://api.github.com/users/runrevmark/gists{/gist_id}","starred_url":"https://api.github.com/users/runrevmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runrevmark/subscriptions","organizations_url":"https://api.github.com/users/runrevmark/orgs","repos_url":"https://api.github.com/users/runrevmark/repos","events_url":"https://api.github.com/users/runrevmark/events{/privacy}","received_events_url":"https://api.github.com/users/runrevmark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runrevmark/livecode","description":"","fork":true,"url":"https://api.github.com/repos/runrevmark/livecode","forks_url":"https://api.github.com/repos/runrevmark/livecode/forks","keys_url":"https://api.github.com/repos/runrevmark/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runrevmark/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runrevmark/livecode/teams","hooks_url":"https://api.github.com/repos/runrevmark/livecode/hooks","issue_events_url":"https://api.github.com/repos/runrevmark/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/runrevmark/livecode/events","assignees_url":"https://api.github.com/repos/runrevmark/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/runrevmark/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/runrevmark/livecode/tags","blobs_url":"https://api.github.com/repos/runrevmark/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runrevmark/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runrevmark/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/runrevmark/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runrevmark/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/runrevmark/livecode/languages","stargazers_url":"https://api.github.com/repos/runrevmark/livecode/stargazers","contributors_url":"https://api.github.com/repos/runrevmark/livecode/contributors","subscribers_url":"https://api.github.com/repos/runrevmark/livecode/subscribers","subscription_url":"https://api.github.com/repos/runrevmark/livecode/subscription","commits_url":"https://api.github.com/repos/runrevmark/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/runrevmark/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/runrevmark/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/runrevmark/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/runrevmark/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/runrevmark/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runrevmark/livecode/merges","archive_url":"https://api.github.com/repos/runrevmark/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runrevmark/livecode/downloads","issues_url":"https://api.github.com/repos/runrevmark/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/runrevmark/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/runrevmark/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/runrevmark/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runrevmark/livecode/labels{/name}","releases_url":"https://api.github.com/repos/runrevmark/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/runrevmark/livecode/deployments","created_at":"2013-04-11T15:43:35Z","updated_at":"2016-07-06T11:56:01Z","pushed_at":"2016-09-14T10:37:12Z","git_url":"git://github.com/runrevmark/livecode.git","ssh_url":"git@github.com:runrevmark/livecode.git","clone_url":"https://github.com/runrevmark/livecode.git","svn_url":"https://github.com/runrevmark/livecode","homepage":null,"size":121810,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"livecode:develop","ref":"develop","sha":"6e810613b7d0edb95f22e4ce9de3f2245bdb056f","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"LiveCode cross-platform development environment (engine)","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecode/livecode/deployments","created_at":"2013-04-10T00:15:57Z","updated_at":"2016-09-13T21:45:35Z","pushed_at":"2016-09-14T10:46:52Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":"https://livecode.com/","size":182284,"stargazers_count":142,"watchers_count":142,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":79,"forks":109,"open_issues":79,"watchers":142,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4494"},"html":{"href":"https://github.com/livecode/livecode/pull/4494"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/4494"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/4494/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4494/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4494/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/160b89c9e5167ce9ae1434d3b01bd4a58a820600"}}}}
{"actor":{"display_login":"runrevmark"}}