{"action":"opened","number":42,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/42","id":79448749,"html_url":"https://github.com/apache/incubator-guacamole-client/pull/42","diff_url":"https://github.com/apache/incubator-guacamole-client/pull/42.diff","patch_url":"https://github.com/apache/incubator-guacamole-client/pull/42.patch","issue_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/42","number":42,"state":"open","locked":false,"title":"GUACAMOLE-5: Provide most recent Credentials to updateUserContext()","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"body":"The `updateUserContext()` function of `AuthenticationProvider` has existed for a while, but it was written under the assumption that `AuthenticatedUser` will always receive an updated set of credentials, thus the possibly-updated `UserContext` will be able to access this information.\r\n\r\nThis is false. The `AuthenticatedUser` will only be updated if `updateAuthenticatedUser()` does so, and relying on that is bad. There's not much for `updateUserContext()` to update with if it can't be guaranteed access to fresh information.\r\n\r\nUpdating `UserContext` may require peeking at the most recent HTTP request / credentials, so the most recent `Credentials` object should be passed to `updateUserContext()` as well.","created_at":"2016-07-30T05:24:59Z","updated_at":"2016-07-30T05:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/42/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/42/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/42/comments","statuses_url":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/abbc83a15bd4e34419561d889086d562385cca62","head":{"label":"mike-jumper:provide-updated-credentials","ref":"provide-updated-credentials","sha":"abbc83a15bd4e34419561d889086d562385cca62","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"repo":{"id":54506694,"name":"incubator-guacamole-client","full_name":"mike-jumper/incubator-guacamole-client","owner":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-jumper/incubator-guacamole-client","description":"Mirror of Apache Guacamole Client (Incubating)","fork":true,"url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client","forks_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/forks","keys_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/teams","hooks_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/events","assignees_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/tags","blobs_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/languages","stargazers_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/subscription","commits_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/merges","archive_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/downloads","issues_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/deployments","created_at":"2016-03-22T20:30:39Z","updated_at":"2016-03-22T20:30:42Z","pushed_at":"2016-07-30T05:18:07Z","git_url":"git://github.com/mike-jumper/incubator-guacamole-client.git","ssh_url":"git@github.com:mike-jumper/incubator-guacamole-client.git","clone_url":"https://github.com/mike-jumper/incubator-guacamole-client.git","svn_url":"https://github.com/mike-jumper/incubator-guacamole-client","homepage":null,"size":10825,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"872aac375cedf8e22444ed6fb2531b0e44869da6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":54452622,"name":"incubator-guacamole-client","full_name":"apache/incubator-guacamole-client","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-guacamole-client","description":"Mirror of Apache Guacamole Client (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-guacamole-client","forks_url":"https://api.github.com/repos/apache/incubator-guacamole-client/forks","keys_url":"https://api.github.com/repos/apache/incubator-guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-guacamole-client/teams","hooks_url":"https://api.github.com/repos/apache/incubator-guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-guacamole-client/events","assignees_url":"https://api.github.com/repos/apache/incubator-guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-guacamole-client/tags","blobs_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-guacamole-client/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-guacamole-client/subscription","commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-guacamole-client/merges","archive_url":"https://api.github.com/repos/apache/incubator-guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-guacamole-client/downloads","issues_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/deployments","created_at":"2016-03-22T07:00:06Z","updated_at":"2016-07-29T11:56:41Z","pushed_at":"2016-07-30T05:10:08Z","git_url":"git://github.com/apache/incubator-guacamole-client.git","ssh_url":"git@github.com:apache/incubator-guacamole-client.git","clone_url":"https://github.com/apache/incubator-guacamole-client.git","svn_url":"https://github.com/apache/incubator-guacamole-client","homepage":null,"size":10765,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":"git://git.apache.org/incubator-guacamole-client.git","open_issues_count":5,"forks":28,"open_issues":5,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/42"},"html":{"href":"https://github.com/apache/incubator-guacamole-client/pull/42"},"issue":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/42"},"comments":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/abbc83a15bd4e34419561d889086d562385cca62"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":11,"changed_files":6}}
{"actor":{"display_login":"mike-jumper"}}