{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments/66161452","id":66161452,"diff_hunk":"@@ -19,25 +19,56 @@\n # the GNU General Public License along with this program.  If not,\n # see <http://www.lsstcorp.org/LegalNotices/>.\n #\n-from lsst.pex.config import makeRegistry\n-from .pcaPsfDeterminer import PcaPsfDeterminer\n+from __future__ import absolute_import, division, print_function\n \n-__all__ = [\"psfDeterminerRegistry\"]\n+import abc\n \n-psfDeterminerRegistry = makeRegistry(\n-    '''A registry of PSF determiner factories\n+import lsst.pipe.base as pipeBase\n+import lsst.pex.config as pexConfig\n \n-    A PSF determiner factory makes a class with the following API:\n+__all__ = [\"BasePsfDeterminerConfig\", \"BasePsfDeterminerTask\", \"psfDeterminerRegistry\"]\n \n-    def __init__(self, config, schema=None):\n+class BasePsfDeterminerConfig(pexConfig.Config):\n+    kernelSize = pexConfig.Field(","path":"python/lsst/meas/algorithms/psfDeterminer.py","position":21,"original_position":21,"commit_id":"b4839fab76364686b27c115b9a1f74835e105797","original_commit_id":"b4839fab76364686b27c115b9a1f74835e105797","user":{"login":"djreiss","id":512257,"avatar_url":"https://avatars.githubusercontent.com/u/512257?v=3","gravatar_id":"","url":"https://api.github.com/users/djreiss","html_url":"https://github.com/djreiss","followers_url":"https://api.github.com/users/djreiss/followers","following_url":"https://api.github.com/users/djreiss/following{/other_user}","gists_url":"https://api.github.com/users/djreiss/gists{/gist_id}","starred_url":"https://api.github.com/users/djreiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djreiss/subscriptions","organizations_url":"https://api.github.com/users/djreiss/orgs","repos_url":"https://api.github.com/users/djreiss/repos","events_url":"https://api.github.com/users/djreiss/events{/privacy}","received_events_url":"https://api.github.com/users/djreiss/received_events","type":"User","site_admin":false},"body":"I think I understand why you put these three settings in the base config, but is there some way to document/explain it? For example, I could see a justification for also including \"borderWidth\" in the base, although I realize that it's only not there because it's not used by PsfexPsfDeterminer. Is that correct?","created_at":"2016-06-07T22:04:38Z","updated_at":"2016-06-07T22:04:38Z","html_url":"https://github.com/lsst/meas_algorithms/pull/35#discussion_r66161452","pull_request_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments/66161452"},"html":{"href":"https://github.com/lsst/meas_algorithms/pull/35#discussion_r66161452"},"pull_request":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35","id":72798783,"html_url":"https://github.com/lsst/meas_algorithms/pull/35","diff_url":"https://github.com/lsst/meas_algorithms/pull/35.diff","patch_url":"https://github.com/lsst/meas_algorithms/pull/35.patch","issue_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/35","number":35,"state":"open","locked":false,"title":"Tickets/dm 6077","user":{"login":"r-owen","id":874176,"avatar_url":"https://avatars.githubusercontent.com/u/874176?v=3","gravatar_id":"","url":"https://api.github.com/users/r-owen","html_url":"https://github.com/r-owen","followers_url":"https://api.github.com/users/r-owen/followers","following_url":"https://api.github.com/users/r-owen/following{/other_user}","gists_url":"https://api.github.com/users/r-owen/gists{/gist_id}","starred_url":"https://api.github.com/users/r-owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-owen/subscriptions","organizations_url":"https://api.github.com/users/r-owen/orgs","repos_url":"https://api.github.com/users/r-owen/repos","events_url":"https://api.github.com/users/r-owen/events{/privacy}","received_events_url":"https://api.github.com/users/r-owen/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-07T00:21:04Z","updated_at":"2016-06-07T22:04:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a347d798139abd87d78383dcb7d83f087940d1f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35/commits","review_comments_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35/comments","review_comment_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/35/comments","statuses_url":"https://api.github.com/repos/lsst/meas_algorithms/statuses/b4839fab76364686b27c115b9a1f74835e105797","head":{"label":"lsst:tickets/DM-6077","ref":"tickets/DM-6077","sha":"b4839fab76364686b27c115b9a1f74835e105797","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013343,"name":"meas_algorithms","full_name":"lsst/meas_algorithms","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_algorithms","description":"LSST Data Management: astronomical measurement algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_algorithms","forks_url":"https://api.github.com/repos/lsst/meas_algorithms/forks","keys_url":"https://api.github.com/repos/lsst/meas_algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_algorithms/teams","hooks_url":"https://api.github.com/repos/lsst/meas_algorithms/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_algorithms/events","assignees_url":"https://api.github.com/repos/lsst/meas_algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_algorithms/tags","blobs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_algorithms/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_algorithms/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_algorithms/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_algorithms/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_algorithms/subscription","commits_url":"https://api.github.com/repos/lsst/meas_algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_algorithms/merges","archive_url":"https://api.github.com/repos/lsst/meas_algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_algorithms/downloads","issues_url":"https://api.github.com/repos/lsst/meas_algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_algorithms/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_algorithms/deployments","created_at":"2014-08-16T07:45:05Z","updated_at":"2016-01-19T02:15:54Z","pushed_at":"2016-06-07T22:01:08Z","git_url":"git://github.com/lsst/meas_algorithms.git","ssh_url":"git@github.com:lsst/meas_algorithms.git","clone_url":"https://github.com/lsst/meas_algorithms.git","svn_url":"https://github.com/lsst/meas_algorithms","homepage":"http://dm.lsst.org/","size":10677,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"8e57d7e1b006f23c58905a9af2d22bec98897405","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013343,"name":"meas_algorithms","full_name":"lsst/meas_algorithms","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_algorithms","description":"LSST Data Management: astronomical measurement algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_algorithms","forks_url":"https://api.github.com/repos/lsst/meas_algorithms/forks","keys_url":"https://api.github.com/repos/lsst/meas_algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_algorithms/teams","hooks_url":"https://api.github.com/repos/lsst/meas_algorithms/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_algorithms/events","assignees_url":"https://api.github.com/repos/lsst/meas_algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_algorithms/tags","blobs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_algorithms/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_algorithms/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_algorithms/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_algorithms/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_algorithms/subscription","commits_url":"https://api.github.com/repos/lsst/meas_algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_algorithms/merges","archive_url":"https://api.github.com/repos/lsst/meas_algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_algorithms/downloads","issues_url":"https://api.github.com/repos/lsst/meas_algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_algorithms/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_algorithms/deployments","created_at":"2014-08-16T07:45:05Z","updated_at":"2016-01-19T02:15:54Z","pushed_at":"2016-06-07T22:01:08Z","git_url":"git://github.com/lsst/meas_algorithms.git","ssh_url":"git@github.com:lsst/meas_algorithms.git","clone_url":"https://github.com/lsst/meas_algorithms.git","svn_url":"https://github.com/lsst/meas_algorithms","homepage":"http://dm.lsst.org/","size":10677,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35"},"html":{"href":"https://github.com/lsst/meas_algorithms/pull/35"},"issue":{"href":"https://api.github.com/repos/lsst/meas_algorithms/issues/35"},"comments":{"href":"https://api.github.com/repos/lsst/meas_algorithms/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/meas_algorithms/statuses/b4839fab76364686b27c115b9a1f74835e105797"}}}}
{"actor":{"display_login":"djreiss"}}