{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/81957966","pull_request_review_id":2898519,"id":81957966,"diff_hunk":"@@ -149,10 +155,13 @@ void OpenALStream::SoundLoop()\n   memset(uiBuffers, 0, numBuffers * sizeof(ALuint));\n   uiSource = 0;\n \n-  // Checks if a X-Fi is being used. If it is, disable FLOAT32 support as this sound card has no\n-  // support for it even though it reports it does.\n+  if (alIsExtensionPresent(\"AL_EXT_float32\"))\n+    float32_capable = true;\n+\n+  // Checks if a X-Fi is being used. If it is, enable FIXED32 support as this sound card\n+  // is the only one that supports it for now.\n   if (strstr(alGetString(AL_RENDERER), \"X-Fi\"))\n-    float32_capable = false;\n+    fixed32_capable = true;","path":"Source/Core/AudioCommon/OpenALStream.cpp","position":37,"original_position":37,"commit_id":"68e13c47bab82220ae57b4339aeb99a0e4526d4c","original_commit_id":"68e13c47bab82220ae57b4339aeb99a0e4526d4c","user":{"login":"LAGonauta","id":14236067,"avatar_url":"https://avatars.githubusercontent.com/u/14236067?v=3","gravatar_id":"","url":"https://api.github.com/users/LAGonauta","html_url":"https://github.com/LAGonauta","followers_url":"https://api.github.com/users/LAGonauta/followers","following_url":"https://api.github.com/users/LAGonauta/following{/other_user}","gists_url":"https://api.github.com/users/LAGonauta/gists{/gist_id}","starred_url":"https://api.github.com/users/LAGonauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAGonauta/subscriptions","organizations_url":"https://api.github.com/users/LAGonauta/orgs","repos_url":"https://api.github.com/users/LAGonauta/repos","events_url":"https://api.github.com/users/LAGonauta/events{/privacy}","received_events_url":"https://api.github.com/users/LAGonauta/received_events","type":"User","site_admin":false},"body":"I believe the nForce implementation is quite dead since... 2004? I bet it doesn't even work on Vista or newer. Forget about any 64-bit processor support.\r\n\r\nASUS seems to use the implementation from C-Media, I hope someone can test it but I bet that it only supports 16-bit fixed point, with luck it also supports floating point. It is probably software rendered and properly fall back to 16-bit if floating point support is not found. It would be great if someone could test it. Also, does it have 64-bit processor support?\r\n\r\nMy onboard audio is from Realtek, and no OpenAL driver comes with the newest driver. Is it still used/supported by Realtek?\r\n\r\nSome Creative cards use software rendered OpenAL from Sensaura, through Sens_oal.dll driver. Last time I tested it didn't support any kind of 32-bit samples, but works fine with the 16-bit fall back.\r\n\r\nI believe that valid software rendered drivers that should be tested are \"OpenAL Soft\", \"AeonWave-OpenAL\", \"Rapture3D\" and the \"Generic software\" from default wrap_oal.dll driver.\r\nOpenAL Soft works great with floating point samples as anyone can test it and \"Generic software\" from wrap_oal.dll properly falls back to 16-bit, but it would be great if someone could test with those other renderers.","created_at":"2016-10-05T12:10:05Z","updated_at":"2016-10-05T12:10:05Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3080#discussion_r81957966","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/81957966"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3080#discussion_r81957966"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080","id":45740159,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3080","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3080.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3080.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3080","number":3080,"state":"open","locked":false,"title":"OpenAL 32-bit fixed point support","user":{"login":"LAGonauta","id":14236067,"avatar_url":"https://avatars.githubusercontent.com/u/14236067?v=3","gravatar_id":"","url":"https://api.github.com/users/LAGonauta","html_url":"https://github.com/LAGonauta","followers_url":"https://api.github.com/users/LAGonauta/followers","following_url":"https://api.github.com/users/LAGonauta/following{/other_user}","gists_url":"https://api.github.com/users/LAGonauta/gists{/gist_id}","starred_url":"https://api.github.com/users/LAGonauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAGonauta/subscriptions","organizations_url":"https://api.github.com/users/LAGonauta/orgs","repos_url":"https://api.github.com/users/LAGonauta/repos","events_url":"https://api.github.com/users/LAGonauta/events{/privacy}","received_events_url":"https://api.github.com/users/LAGonauta/received_events","type":"User","site_admin":false},"body":"I believe that clamping to (-1 ; 1) is the best solution, and this new method works correctly, even though it is possible to hear the hard-clipping it is better than distortion. When the DPL2 decoder is reworked the clamping will probably be unnecessary, but until then it is needed.\r\n\r\nOriginal PR message follows:\r\n\r\nThe X-Fi DSP supports only 32-bit and 16-bit fixed point buffers. This commit adds support to 32-bit fixed point buffers on stereo and on surround and allows a X-Fi to output surround sound with no artifacts or noise. I also changed how floating point support is detected.\r\nThere is a problem, though. The Dolby Decoder gives some samples outside the usual [ -1 ; 1 ] range, and just clamping them to 1 or -1 gives undesirable sound artifacts as the samples are usually at [ -2,5 ; 2,5 ]. As there is enough dynamic range on 32-bit fixed point, I am clamping it to [ -4 ; 4 ]. The best solution is to fix the DPL2 decoder somehow, but I am still trying to understand how it works.\r\nFFDShow always clamps to one, but I did not verify if its DPL2 decoder gives samples outside [ -1; 1 ].\r\n\r\nTested on OpenAL Soft, X-Fi and Generic Software (wrap_oal). Everything seems to be working, but someone needs to test it on Linux and on Mac.\r\n\r\nEDIT:\r\nI am not clamping on [ -4; 4 ] anymore as this is clearly wrong, but this causes some artifacts. I need to fix the DPL2 decoder somehow.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3080)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-09-23T03:08:36Z","updated_at":"2016-10-05T12:10:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78029972a0624b63e5a46a2e9b45262634fad419","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3080/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/68e13c47bab82220ae57b4339aeb99a0e4526d4c","head":{"label":"LAGonauta:openal-32bit-fixed-point-support","ref":"openal-32bit-fixed-point-support","sha":"68e13c47bab82220ae57b4339aeb99a0e4526d4c","user":{"login":"LAGonauta","id":14236067,"avatar_url":"https://avatars.githubusercontent.com/u/14236067?v=3","gravatar_id":"","url":"https://api.github.com/users/LAGonauta","html_url":"https://github.com/LAGonauta","followers_url":"https://api.github.com/users/LAGonauta/followers","following_url":"https://api.github.com/users/LAGonauta/following{/other_user}","gists_url":"https://api.github.com/users/LAGonauta/gists{/gist_id}","starred_url":"https://api.github.com/users/LAGonauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAGonauta/subscriptions","organizations_url":"https://api.github.com/users/LAGonauta/orgs","repos_url":"https://api.github.com/users/LAGonauta/repos","events_url":"https://api.github.com/users/LAGonauta/events{/privacy}","received_events_url":"https://api.github.com/users/LAGonauta/received_events","type":"User","site_admin":false},"repo":{"id":42313641,"name":"dolphin","full_name":"LAGonauta/dolphin","owner":{"login":"LAGonauta","id":14236067,"avatar_url":"https://avatars.githubusercontent.com/u/14236067?v=3","gravatar_id":"","url":"https://api.github.com/users/LAGonauta","html_url":"https://github.com/LAGonauta","followers_url":"https://api.github.com/users/LAGonauta/followers","following_url":"https://api.github.com/users/LAGonauta/following{/other_user}","gists_url":"https://api.github.com/users/LAGonauta/gists{/gist_id}","starred_url":"https://api.github.com/users/LAGonauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAGonauta/subscriptions","organizations_url":"https://api.github.com/users/LAGonauta/orgs","repos_url":"https://api.github.com/users/LAGonauta/repos","events_url":"https://api.github.com/users/LAGonauta/events{/privacy}","received_events_url":"https://api.github.com/users/LAGonauta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LAGonauta/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/LAGonauta/dolphin","forks_url":"https://api.github.com/repos/LAGonauta/dolphin/forks","keys_url":"https://api.github.com/repos/LAGonauta/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LAGonauta/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LAGonauta/dolphin/teams","hooks_url":"https://api.github.com/repos/LAGonauta/dolphin/hooks","issue_events_url":"https://api.github.com/repos/LAGonauta/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/LAGonauta/dolphin/events","assignees_url":"https://api.github.com/repos/LAGonauta/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/LAGonauta/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/LAGonauta/dolphin/tags","blobs_url":"https://api.github.com/repos/LAGonauta/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LAGonauta/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LAGonauta/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/LAGonauta/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LAGonauta/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/LAGonauta/dolphin/languages","stargazers_url":"https://api.github.com/repos/LAGonauta/dolphin/stargazers","contributors_url":"https://api.github.com/repos/LAGonauta/dolphin/contributors","subscribers_url":"https://api.github.com/repos/LAGonauta/dolphin/subscribers","subscription_url":"https://api.github.com/repos/LAGonauta/dolphin/subscription","commits_url":"https://api.github.com/repos/LAGonauta/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/LAGonauta/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/LAGonauta/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/LAGonauta/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/LAGonauta/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/LAGonauta/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LAGonauta/dolphin/merges","archive_url":"https://api.github.com/repos/LAGonauta/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LAGonauta/dolphin/downloads","issues_url":"https://api.github.com/repos/LAGonauta/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/LAGonauta/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/LAGonauta/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/LAGonauta/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LAGonauta/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/LAGonauta/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/LAGonauta/dolphin/deployments","created_at":"2015-09-11T14:36:41Z","updated_at":"2016-03-01T20:58:03Z","pushed_at":"2016-10-05T02:34:33Z","git_url":"git://github.com/LAGonauta/dolphin.git","ssh_url":"git@github.com:LAGonauta/dolphin.git","clone_url":"https://github.com/LAGonauta/dolphin.git","svn_url":"https://github.com/LAGonauta/dolphin","homepage":"https://dolphin-emu.org/","size":266546,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"f7e25483e6bfdd5f078ef3e392c45aff899872ab","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-10-04T07:36:10Z","pushed_at":"2016-10-05T10:55:41Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":329488,"stargazers_count":2761,"watchers_count":2761,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":737,"mirror_url":null,"open_issues_count":99,"forks":737,"open_issues":99,"watchers":2761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3080"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3080"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3080/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3080/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/68e13c47bab82220ae57b4339aeb99a0e4526d4c"}}}}
{"actor":{"display_login":"LAGonauta"}}