{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/79903807","id":79903807,"diff_hunk":"@@ -45,33 +49,44 @@\n  */\n public class SimpleStreamingWordCountTest implements Serializable {\n \n-  private static final String[] WORDS_ARRAY = {\n-      \"hi there\", \"hi\", \"hi sue bob\", \"hi sue\", \"\", \"bob hi\"};\n-  private static final List<Iterable<String>> WORDS_QUEUE =\n-      Collections.<Iterable<String>>singletonList(Arrays.asList(WORDS_ARRAY));\n-  private static final String[] EXPECTED_COUNTS = {\"hi: 5\", \"there: 1\", \"sue: 2\", \"bob: 2\"};\n-\n   @Rule\n   public TemporaryFolder checkpointParentDir = new TemporaryFolder();\n \n   @Rule\n   public TestOptionsForStreaming commonOptions = new TestOptionsForStreaming();\n \n+  private static final String[] WORDS = {\"hi there\", \"hi\", \"hi sue bob\", \"hi sue\", \"\", \"bob hi\"};\n+\n+  private static final List<Iterable<String>> MANY_WORDS =\n+      Lists.<Iterable<String>>newArrayList(Arrays.asList(WORDS), Arrays.asList(WORDS));\n+\n+  private static final String[] EXPECTED_WORD_COUNTS = {\"hi: 5\", \"there: 1\", \"sue: 2\", \"bob: 2\"};\n+\n+  private static final Duration BATCH_INTERVAL_MILLIS = Duration.standardSeconds(1);\n+\n   @Test\n   public void testRun() throws Exception {\n+\n     SparkPipelineOptions options = commonOptions.withTmpCheckpointDir(\n         checkpointParentDir.newFolder(getClass().getSimpleName()));\n \n-    Pipeline p = Pipeline.create(options);\n-    PCollection<String> inputWords =\n-        p.apply(CreateStream.fromQueue(WORDS_QUEUE)).setCoder(StringUtf8Coder.of());\n-    PCollection<String> windowedWords = inputWords\n-        .apply(Window.<String>into(FixedWindows.of(Duration.standardSeconds(1))));\n-    PCollection<String> output = windowedWords.apply(new WordCount.CountWords())\n-        .apply(MapElements.via(new WordCount.FormatAsTextFn()));\n+    // override defaults\n+    options.setBatchIntervalMillis(BATCH_INTERVAL_MILLIS.getMillis());\n+    options.setTimeout(BATCH_INTERVAL_MILLIS.multipliedBy(3).getMillis());","path":"runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/SimpleStreamingWordCountTest.java","position":64,"original_position":64,"commit_id":"b2d84ae0b97220bd2d187d17db03a47c41128365","original_commit_id":"b2d84ae0b97220bd2d187d17db03a47c41128365","user":{"login":"amitsela","id":4245753,"avatar_url":"https://avatars.githubusercontent.com/u/4245753?v=3","gravatar_id":"","url":"https://api.github.com/users/amitsela","html_url":"https://github.com/amitsela","followers_url":"https://api.github.com/users/amitsela/followers","following_url":"https://api.github.com/users/amitsela/following{/other_user}","gists_url":"https://api.github.com/users/amitsela/gists{/gist_id}","starred_url":"https://api.github.com/users/amitsela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitsela/subscriptions","organizations_url":"https://api.github.com/users/amitsela/orgs","repos_url":"https://api.github.com/users/amitsela/repos","events_url":"https://api.github.com/users/amitsela/events{/privacy}","received_events_url":"https://api.github.com/users/amitsela/received_events","type":"User","site_admin":false},"body":"Well, it's probably best to debug (just to make sure), but the graceful stop added in #909 will wait until current execution is done... that would be my guess.","created_at":"2016-09-21T18:42:23Z","updated_at":"2016-09-21T18:42:29Z","html_url":"https://github.com/apache/incubator-beam/pull/982#discussion_r79903807","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/982","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/79903807"},"html":{"href":"https://github.com/apache/incubator-beam/pull/982#discussion_r79903807"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/982"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/982","id":86214070,"html_url":"https://github.com/apache/incubator-beam/pull/982","diff_url":"https://github.com/apache/incubator-beam/pull/982.diff","patch_url":"https://github.com/apache/incubator-beam/pull/982.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/982","number":982,"state":"open","locked":false,"title":"[BEAM-613] Revised SimpleStreamingWordCountTest to test multiple batches","user":{"login":"staslev","id":6048315,"avatar_url":"https://avatars.githubusercontent.com/u/6048315?v=3","gravatar_id":"","url":"https://api.github.com/users/staslev","html_url":"https://github.com/staslev","followers_url":"https://api.github.com/users/staslev/followers","following_url":"https://api.github.com/users/staslev/following{/other_user}","gists_url":"https://api.github.com/users/staslev/gists{/gist_id}","starred_url":"https://api.github.com/users/staslev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staslev/subscriptions","organizations_url":"https://api.github.com/users/staslev/orgs","repos_url":"https://api.github.com/users/staslev/repos","events_url":"https://api.github.com/users/staslev/events{/privacy}","received_events_url":"https://api.github.com/users/staslev/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\nR: @amitsela ","created_at":"2016-09-21T18:15:43Z","updated_at":"2016-09-21T18:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502b3e7c2b73fc96e07cedf021a75ece3b6c75f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/982/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/982/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/982/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/b2d84ae0b97220bd2d187d17db03a47c41128365","head":{"label":"staslev:BEAM-613-Improve-SimpleStreamingWordCountTest","ref":"BEAM-613-Improve-SimpleStreamingWordCountTest","sha":"b2d84ae0b97220bd2d187d17db03a47c41128365","user":{"login":"staslev","id":6048315,"avatar_url":"https://avatars.githubusercontent.com/u/6048315?v=3","gravatar_id":"","url":"https://api.github.com/users/staslev","html_url":"https://github.com/staslev","followers_url":"https://api.github.com/users/staslev/followers","following_url":"https://api.github.com/users/staslev/following{/other_user}","gists_url":"https://api.github.com/users/staslev/gists{/gist_id}","starred_url":"https://api.github.com/users/staslev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staslev/subscriptions","organizations_url":"https://api.github.com/users/staslev/orgs","repos_url":"https://api.github.com/users/staslev/repos","events_url":"https://api.github.com/users/staslev/events{/privacy}","received_events_url":"https://api.github.com/users/staslev/received_events","type":"User","site_admin":false},"repo":{"id":65379761,"name":"incubator-beam","full_name":"staslev/incubator-beam","owner":{"login":"staslev","id":6048315,"avatar_url":"https://avatars.githubusercontent.com/u/6048315?v=3","gravatar_id":"","url":"https://api.github.com/users/staslev","html_url":"https://github.com/staslev","followers_url":"https://api.github.com/users/staslev/followers","following_url":"https://api.github.com/users/staslev/following{/other_user}","gists_url":"https://api.github.com/users/staslev/gists{/gist_id}","starred_url":"https://api.github.com/users/staslev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staslev/subscriptions","organizations_url":"https://api.github.com/users/staslev/orgs","repos_url":"https://api.github.com/users/staslev/repos","events_url":"https://api.github.com/users/staslev/events{/privacy}","received_events_url":"https://api.github.com/users/staslev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/staslev/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/staslev/incubator-beam","forks_url":"https://api.github.com/repos/staslev/incubator-beam/forks","keys_url":"https://api.github.com/repos/staslev/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/staslev/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/staslev/incubator-beam/teams","hooks_url":"https://api.github.com/repos/staslev/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/staslev/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/staslev/incubator-beam/events","assignees_url":"https://api.github.com/repos/staslev/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/staslev/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/staslev/incubator-beam/tags","blobs_url":"https://api.github.com/repos/staslev/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/staslev/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/staslev/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/staslev/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/staslev/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/staslev/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/staslev/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/staslev/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/staslev/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/staslev/incubator-beam/subscription","commits_url":"https://api.github.com/repos/staslev/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/staslev/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/staslev/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/staslev/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/staslev/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/staslev/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/staslev/incubator-beam/merges","archive_url":"https://api.github.com/repos/staslev/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/staslev/incubator-beam/downloads","issues_url":"https://api.github.com/repos/staslev/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/staslev/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/staslev/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/staslev/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/staslev/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/staslev/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/staslev/incubator-beam/deployments","created_at":"2016-08-10T12:13:30Z","updated_at":"2016-08-10T12:13:35Z","pushed_at":"2016-09-21T18:13:08Z","git_url":"git://github.com/staslev/incubator-beam.git","ssh_url":"git@github.com:staslev/incubator-beam.git","clone_url":"https://github.com/staslev/incubator-beam.git","svn_url":"https://github.com/staslev/incubator-beam","homepage":null,"size":19080,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"31a35e5c99056b0bd180623974a47d5c5400a395","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-09-21T18:19:21Z","pushed_at":"2016-09-21T18:40:15Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":28263,"stargazers_count":354,"watchers_count":354,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":219,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":47,"forks":219,"open_issues":47,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/982"},"html":{"href":"https://github.com/apache/incubator-beam/pull/982"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/982"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/982/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/982/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/982/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/b2d84ae0b97220bd2d187d17db03a47c41128365"}}}}
{"actor":{"display_login":"amitsela"}}