{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/90718367","pull_request_review_id":11238934,"id":90718367,"diff_hunk":"@@ -124,10 +124,12 @@ error_code_i fillHandler (Context& context,\n         }\n     }\n \n-    if (!context.params.isMember (\"command\"))\n+    if (!context.params.isMember(\"command\") && !context.params.isMember(\"method\"))\n         return rpcCOMMAND_MISSING;","path":"src/ripple/rpc/impl/RPCHandler.cpp","position":6,"original_position":6,"commit_id":"d2da1dfa4522e0e49bee16f52e286f712843d4b9","original_commit_id":"d2da1dfa4522e0e49bee16f52e286f712843d4b9","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"Good point. But that's easy enough to check for, too.","created_at":"2016-12-02T20:57:56Z","updated_at":"2016-12-02T20:57:57Z","html_url":"https://github.com/ripple/rippled/pull/1907#discussion_r90718367","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1907","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/90718367"},"html":{"href":"https://github.com/ripple/rippled/pull/1907#discussion_r90718367"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1907"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1907","id":94391417,"html_url":"https://github.com/ripple/rippled/pull/1907","diff_url":"https://github.com/ripple/rippled/pull/1907.diff","patch_url":"https://github.com/ripple/rippled/pull/1907.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1907","number":1907,"state":"open","locked":false,"title":"Rippled RPC 2.0","user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"body":"This creates a 2.0 rippled API which is Json 2.0 compliant.  It also allows Websocket requests to use the exact same json API.\r\n\r\nSee https://docs.google.com/document/d/1HAxI0WeEqa8S02MOkSnaAY0cQFCjTZq71lYDJfUEowM/edit#heading=h.k5ar887qhamy for more details","created_at":"2016-11-18T16:22:21Z","updated_at":"2016-12-02T20:57:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82abd7243e559dae6b0d1ade333a6ca9e417ae84","assignee":{"login":"bachase","id":14430,"avatar_url":"https://avatars.githubusercontent.com/u/14430?v=3","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},"assignees":[{"login":"bachase","id":14430,"avatar_url":"https://avatars.githubusercontent.com/u/14430?v=3","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1907/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1907/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1907/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/d2da1dfa4522e0e49bee16f52e286f712843d4b9","head":{"label":"HowardHinnant:apiv2","ref":"apiv2","sha":"d2da1dfa4522e0e49bee16f52e286f712843d4b9","user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"repo":{"id":16925449,"name":"rippled","full_name":"HowardHinnant/rippled","owner":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HowardHinnant/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/HowardHinnant/rippled","forks_url":"https://api.github.com/repos/HowardHinnant/rippled/forks","keys_url":"https://api.github.com/repos/HowardHinnant/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HowardHinnant/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HowardHinnant/rippled/teams","hooks_url":"https://api.github.com/repos/HowardHinnant/rippled/hooks","issue_events_url":"https://api.github.com/repos/HowardHinnant/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/HowardHinnant/rippled/events","assignees_url":"https://api.github.com/repos/HowardHinnant/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/HowardHinnant/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/HowardHinnant/rippled/tags","blobs_url":"https://api.github.com/repos/HowardHinnant/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HowardHinnant/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HowardHinnant/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/HowardHinnant/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HowardHinnant/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/HowardHinnant/rippled/languages","stargazers_url":"https://api.github.com/repos/HowardHinnant/rippled/stargazers","contributors_url":"https://api.github.com/repos/HowardHinnant/rippled/contributors","subscribers_url":"https://api.github.com/repos/HowardHinnant/rippled/subscribers","subscription_url":"https://api.github.com/repos/HowardHinnant/rippled/subscription","commits_url":"https://api.github.com/repos/HowardHinnant/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/HowardHinnant/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/HowardHinnant/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/HowardHinnant/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/HowardHinnant/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/HowardHinnant/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HowardHinnant/rippled/merges","archive_url":"https://api.github.com/repos/HowardHinnant/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HowardHinnant/rippled/downloads","issues_url":"https://api.github.com/repos/HowardHinnant/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/HowardHinnant/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/HowardHinnant/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/HowardHinnant/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HowardHinnant/rippled/labels{/name}","releases_url":"https://api.github.com/repos/HowardHinnant/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/HowardHinnant/rippled/deployments","created_at":"2014-02-17T20:21:56Z","updated_at":"2015-04-07T16:53:12Z","pushed_at":"2016-11-28T15:45:34Z","git_url":"git://github.com/HowardHinnant/rippled.git","ssh_url":"git@github.com:HowardHinnant/rippled.git","clone_url":"https://github.com/HowardHinnant/rippled.git","svn_url":"https://github.com/HowardHinnant/rippled","homepage":"https://ripple.com","size":80444,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"9e960ff6b89cd303fbc393f3ecb0bda19ffca92e","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the Ripple Consensus Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2016-12-02T09:49:03Z","pushed_at":"2016-12-01T00:28:27Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":133483,"stargazers_count":1186,"watchers_count":1186,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":370,"mirror_url":null,"open_issues_count":125,"forks":370,"open_issues":125,"watchers":1186,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1907"},"html":{"href":"https://github.com/ripple/rippled/pull/1907"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1907"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1907/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1907/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1907/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/d2da1dfa4522e0e49bee16f52e286f712843d4b9"}}}}
{"actor":{"display_login":"ximinez"}}