{"action":"closed","number":2283,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2283","id":99204242,"html_url":"https://github.com/Microsoft/ChakraCore/pull/2283","diff_url":"https://github.com/Microsoft/ChakraCore/pull/2283.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/2283.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2283","number":2283,"state":"closed","locked":false,"title":"swb: avoid write barrier for global static data","user":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"body":"Added WriteBarrierPtr(nullptr) constructor, no write barrier for nullptr.\nChanged such initializers to use nullptr instead of 0 or NULL.\n\nFor all global static data that may contain WriteBarrierPtr fields, add\na constructor variant that takes a dummy parameter to indicate that\nconstructor is to initialize from static data. The corresponding\nWriteBarrierPtr field uses a special variant to skip write barrier. This\navoids write barrier on static data address (which is in binary image\naddress, not recycler memory, and we have no cardTable for them on x64).\n","created_at":"2016-12-23T05:27:47Z","updated_at":"2016-12-23T18:16:43Z","closed_at":"2016-12-23T18:16:43Z","merged_at":"2016-12-23T18:16:43Z","merge_commit_sha":"c91129d377de99dfc3de105f7c96d260a2a44fef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2283/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2283/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2283/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/c91129d377de99dfc3de105f7c96d260a2a44fef","head":{"label":"jianchun:wbglob","ref":"wbglob","sha":"c91129d377de99dfc3de105f7c96d260a2a44fef","user":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"repo":{"id":49751915,"name":"ChakraCore","full_name":"jianchun/ChakraCore","owner":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jianchun/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/jianchun/ChakraCore","forks_url":"https://api.github.com/repos/jianchun/ChakraCore/forks","keys_url":"https://api.github.com/repos/jianchun/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jianchun/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jianchun/ChakraCore/teams","hooks_url":"https://api.github.com/repos/jianchun/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/jianchun/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/jianchun/ChakraCore/events","assignees_url":"https://api.github.com/repos/jianchun/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/jianchun/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/jianchun/ChakraCore/tags","blobs_url":"https://api.github.com/repos/jianchun/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jianchun/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jianchun/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jianchun/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jianchun/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/jianchun/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/jianchun/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/jianchun/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/jianchun/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/jianchun/ChakraCore/subscription","commits_url":"https://api.github.com/repos/jianchun/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jianchun/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jianchun/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jianchun/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/jianchun/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/jianchun/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jianchun/ChakraCore/merges","archive_url":"https://api.github.com/repos/jianchun/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jianchun/ChakraCore/downloads","issues_url":"https://api.github.com/repos/jianchun/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/jianchun/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/jianchun/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/jianchun/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jianchun/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/jianchun/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/jianchun/ChakraCore/deployments","created_at":"2016-01-16T00:14:09Z","updated_at":"2016-01-16T00:14:24Z","pushed_at":"2016-12-23T05:27:48Z","git_url":"git://github.com/jianchun/ChakraCore.git","ssh_url":"git@github.com:jianchun/ChakraCore.git","clone_url":"https://github.com/jianchun/ChakraCore.git","svn_url":"https://github.com/jianchun/ChakraCore","homepage":null,"size":52707,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:swb","ref":"swb","sha":"0b0385b6f93db08bbe849a6f0ac153f29d7e92c9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-12-23T16:01:32Z","pushed_at":"2016-12-23T18:16:42Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":57230,"stargazers_count":5875,"watchers_count":5875,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":675,"mirror_url":null,"open_issues_count":207,"forks":675,"open_issues":207,"watchers":5875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2283"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/2283"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2283"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2283/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2283/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2283/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/c91129d377de99dfc3de105f7c96d260a2a44fef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":133,"deletions":90,"changed_files":30}}
{"actor":{"display_login":"jianchun"}}