{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/75744273","id":75744273,"diff_hunk":"@@ -41,11 +40,6 @@ func (v *Validator) storage(ctx context.Context, input *data.Data, conf *config.\n \t\treturn\n \t}\n \n-\t// provide a default path if only a DS name is provided\n-\tif imageDSpath.Path == \"\" {","path":"lib/install/validate/storage.go","position":13,"original_position":13,"commit_id":"169528a236489d7f27db3f44e30089ed70f39b72","original_commit_id":"0579ded5b7f401f4f85693c33df20601365fbaae","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"body":"No wait, I'm wrong. We should be keeping the display name as the default. Backing this PR out.","created_at":"2016-08-22T19:42:19Z","updated_at":"2016-08-22T19:42:19Z","html_url":"https://github.com/vmware/vic/pull/2082#discussion_r75744273","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2082","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/75744273"},"html":{"href":"https://github.com/vmware/vic/pull/2082#discussion_r75744273"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2082"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2082","id":82243539,"html_url":"https://github.com/vmware/vic/pull/2082","diff_url":"https://github.com/vmware/vic/pull/2082.diff","patch_url":"https://github.com/vmware/vic/pull/2082.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2082","number":2082,"state":"open","locked":false,"title":"Don't provide redundant 'images' default for image store path","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"body":"Initially I provided a default path for images (\"images\") in `validator.go` but this winds up being redundant, so an empty path is actually fine.\r\n\r\nFixes #2081 ","created_at":"2016-08-22T18:55:10Z","updated_at":"2016-08-22T19:42:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9abf39151951951044c8d53df28c56274e6c3666","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2082/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2082/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2082/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/169528a236489d7f27db3f44e30089ed70f39b72","head":{"label":"gigawhitlocks:2081","ref":"2081","sha":"169528a236489d7f27db3f44e30089ed70f39b72","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"repo":{"id":55534993,"name":"vic","full_name":"gigawhitlocks/vic","owner":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gigawhitlocks/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/gigawhitlocks/vic","forks_url":"https://api.github.com/repos/gigawhitlocks/vic/forks","keys_url":"https://api.github.com/repos/gigawhitlocks/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigawhitlocks/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigawhitlocks/vic/teams","hooks_url":"https://api.github.com/repos/gigawhitlocks/vic/hooks","issue_events_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/events{/number}","events_url":"https://api.github.com/repos/gigawhitlocks/vic/events","assignees_url":"https://api.github.com/repos/gigawhitlocks/vic/assignees{/user}","branches_url":"https://api.github.com/repos/gigawhitlocks/vic/branches{/branch}","tags_url":"https://api.github.com/repos/gigawhitlocks/vic/tags","blobs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigawhitlocks/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigawhitlocks/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigawhitlocks/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/gigawhitlocks/vic/languages","stargazers_url":"https://api.github.com/repos/gigawhitlocks/vic/stargazers","contributors_url":"https://api.github.com/repos/gigawhitlocks/vic/contributors","subscribers_url":"https://api.github.com/repos/gigawhitlocks/vic/subscribers","subscription_url":"https://api.github.com/repos/gigawhitlocks/vic/subscription","commits_url":"https://api.github.com/repos/gigawhitlocks/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigawhitlocks/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigawhitlocks/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigawhitlocks/vic/contents/{+path}","compare_url":"https://api.github.com/repos/gigawhitlocks/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigawhitlocks/vic/merges","archive_url":"https://api.github.com/repos/gigawhitlocks/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigawhitlocks/vic/downloads","issues_url":"https://api.github.com/repos/gigawhitlocks/vic/issues{/number}","pulls_url":"https://api.github.com/repos/gigawhitlocks/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/gigawhitlocks/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/gigawhitlocks/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigawhitlocks/vic/labels{/name}","releases_url":"https://api.github.com/repos/gigawhitlocks/vic/releases{/id}","deployments_url":"https://api.github.com/repos/gigawhitlocks/vic/deployments","created_at":"2016-04-05T18:57:06Z","updated_at":"2016-04-05T18:57:13Z","pushed_at":"2016-08-22T19:40:25Z","git_url":"git://github.com/gigawhitlocks/vic.git","ssh_url":"git@github.com:gigawhitlocks/vic.git","clone_url":"https://github.com/gigawhitlocks/vic.git","svn_url":"https://github.com/gigawhitlocks/vic","homepage":null,"size":33694,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"efb474892e2fec8f27ac61702efbc2f1796e6b14","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-08-18T05:28:20Z","pushed_at":"2016-08-22T19:40:25Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":76485,"stargazers_count":111,"watchers_count":111,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":514,"forks":42,"open_issues":514,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2082"},"html":{"href":"https://github.com/vmware/vic/pull/2082"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2082"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2082/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2082/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2082/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/169528a236489d7f27db3f44e30089ed70f39b72"}}}}
{"actor":{"display_login":"gigawhitlocks"}}