{"action":"created","issue":{"url":"https://api.github.com/repos/Maratyszcza/NNPACK/issues/15","repository_url":"https://api.github.com/repos/Maratyszcza/NNPACK","labels_url":"https://api.github.com/repos/Maratyszcza/NNPACK/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/Maratyszcza/NNPACK/issues/15/comments","events_url":"https://api.github.com/repos/Maratyszcza/NNPACK/issues/15/events","html_url":"https://github.com/Maratyszcza/NNPACK/issues/15","id":151947386,"number":15,"title":"Bug in nnp_convolution_kernel_gradient with non-square image/kernel","user":{"login":"Maratyszcza","id":1093985,"avatar_url":"https://avatars.githubusercontent.com/u/1093985?v=3","gravatar_id":"","url":"https://api.github.com/users/Maratyszcza","html_url":"https://github.com/Maratyszcza","followers_url":"https://api.github.com/users/Maratyszcza/followers","following_url":"https://api.github.com/users/Maratyszcza/following{/other_user}","gists_url":"https://api.github.com/users/Maratyszcza/gists{/gist_id}","starred_url":"https://api.github.com/users/Maratyszcza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maratyszcza/subscriptions","organizations_url":"https://api.github.com/users/Maratyszcza/orgs","repos_url":"https://api.github.com/users/Maratyszcza/repos","events_url":"https://api.github.com/users/Maratyszcza/events{/privacy}","received_events_url":"https://api.github.com/users/Maratyszcza/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-29T19:09:53Z","updated_at":"2016-04-30T10:09:01Z","closed_at":"2016-04-30T10:05:45Z","body":"@szagoruyko found that `nnp_convolution_kernel_gradient` does not match Torch results when image and/or kernel is non-square (i.e. `width != height`). Probably it is also related to Caffe backprop mismatch noticed by @ajtulloch. @szagoruyko checked that the reference implementation `nnp_convolution_kernel_gradient__reference` from `nnpack/reference.h` does not have this bug. TODO:\r\n\r\n- Add test cases for non-square images and kernels (currently all NNPACK tests cases for convolution use square images and kernels).\r\n- Fix the bug"},"comment":{"url":"https://api.github.com/repos/Maratyszcza/NNPACK/issues/comments/215950929","html_url":"https://github.com/Maratyszcza/NNPACK/issues/15#issuecomment-215950929","issue_url":"https://api.github.com/repos/Maratyszcza/NNPACK/issues/15","id":215950929,"user":{"login":"Maratyszcza","id":1093985,"avatar_url":"https://avatars.githubusercontent.com/u/1093985?v=3","gravatar_id":"","url":"https://api.github.com/users/Maratyszcza","html_url":"https://github.com/Maratyszcza","followers_url":"https://api.github.com/users/Maratyszcza/followers","following_url":"https://api.github.com/users/Maratyszcza/following{/other_user}","gists_url":"https://api.github.com/users/Maratyszcza/gists{/gist_id}","starred_url":"https://api.github.com/users/Maratyszcza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maratyszcza/subscriptions","organizations_url":"https://api.github.com/users/Maratyszcza/orgs","repos_url":"https://api.github.com/users/Maratyszcza/repos","events_url":"https://api.github.com/users/Maratyszcza/events{/privacy}","received_events_url":"https://api.github.com/users/Maratyszcza/received_events","type":"User","site_admin":false},"created_at":"2016-04-30T10:09:01Z","updated_at":"2016-04-30T10:09:01Z","body":"Test cases shipped in ce59c9cadd2d561c765953dbfce1ac9bfa557099"}}