{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4091","repository_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4091/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4091/comments","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4091/events","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4091","id":172312445,"number":4091,"title":"[POC] New admin class","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels/review%20required","name":"review required","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-21T09:16:53Z","updated_at":"2016-08-22T14:46:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4091","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4091","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4091.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4091.patch"},"body":"This is just a POC to reduce the admin class.\r\n\r\nA admin definition should only contain these methods as a public API. Methods like `generateUrlgenerateUrl` should be moved to some kind of helper class which will be injected in the constructor.\r\n\r\nRefs https://github.com/sonata-project/SonataAdminBundle/issues/3947\r\n\r\n- All methods in the new `AbstractAdminDefintion` are public, so they can be called from the outside. There is no need to have private or protected methods, because it doesn't contain any advanced logic.\r\n- By default we don't need any constructor parameters in the new `AbstractAdminDefintion`"},"comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments/241436302","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4091#issuecomment-241436302","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4091","id":241436302,"user":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T14:46:05Z","updated_at":"2016-08-22T14:46:05Z","body":"> If i understand correct, all hooks are applied after each other?\r\n\r\nThe logic is the same like today (`AdminInterface`), but it's a separate interface now.\r\n"}}
{"actor":{"display_login":"core23"}}