{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18563","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18563/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18563/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18563/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/18563","id":179737148,"number":18563,"title":"Source control regression","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Build","name":"Build","color":"bfdadc"},{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Priority","name":"Priority","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-28T10:35:29Z","updated_at":"2016-09-28T19:51:42Z","closed_at":null,"body":"I found f80fe5e in the commit log whilst trying to work out why a number of other PR's had become merge conflicts. That commit isn't attributed to a PR and contains 4.5k+ lines of unreviewed code changes.\r\n\r\nThe first priority is to verify this is just `astyle` and nothing else. From there we need to work out what to do next without causing further breakage.\r\n\r\nPlease can all contributors be aware that they should **not** rebase against those changes for now and could all developers please not merge any further code until we decide on a course of action."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/250280103","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/18563#issuecomment-250280103","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18563","id":250280103,"user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T19:51:42Z","updated_at":"2016-09-28T19:51:42Z","body":"Excessively low review times have likely been contributory in the recent breakages. In particular only a few hours for review of a C++ PR is too short - we have a number of good reviewers who would probably have suggested refinements.\r\n\r\nMy other concern is if a JSON PR goes through and another developer objects necessitating reverting it that could upset the contributor if they have taken that as the signal to continue work on the subject. Again low review times exacerbate that.\r\n\r\nAlthough the fix I've written for this should resolve the current problem I don't want to trivialise it too much - the PR queue is deadlocked and we ran 4.5k untested lines on an indeterminate number of users machines. If this hadn't been detected early, and any more PR's merged, we would be in serious difficulty now and stuck with doing a lot of manual rebasing.\r\n\r\nIf you want to maintain the GH stats then you could consider correcting JSON typos and the like - such single line changes are reasonable for self-merge and much preferable to merging a larger PR. The other alternative is to start work on a mod as there is no risk of a merge conflict and I can't see why anyone would object to a developer merging their own mod content."}}
{"actor":{"display_login":"mugling"}}