{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/6922","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/6922/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/6922/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/6922/events","html_url":"https://github.com/magento/magento2/pull/6922","id":181643766,"number":6922,"title":"mage.cookies.set/get fix for value object","user":{"login":"Iazel","id":1616917,"avatar_url":"https://avatars.githubusercontent.com/u/1616917?v=3","gravatar_id":"","url":"https://api.github.com/users/Iazel","html_url":"https://github.com/Iazel","followers_url":"https://api.github.com/users/Iazel/followers","following_url":"https://api.github.com/users/Iazel/following{/other_user}","gists_url":"https://api.github.com/users/Iazel/gists{/gist_id}","starred_url":"https://api.github.com/users/Iazel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iazel/subscriptions","organizations_url":"https://api.github.com/users/Iazel/orgs","repos_url":"https://api.github.com/users/Iazel/repos","events_url":"https://api.github.com/users/Iazel/events{/privacy}","received_events_url":"https://api.github.com/users/Iazel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-07T11:16:52Z","updated_at":"2016-10-13T09:52:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/6922","html_url":"https://github.com/magento/magento2/pull/6922","diff_url":"https://github.com/magento/magento2/pull/6922.diff","patch_url":"https://github.com/magento/magento2/pull/6922.patch"},"body":"When we pass an object as value to `mage.cookies.set`, it incorrectly converts to string and the result is something like: `\"[Object object]\"`.\r\nThis means that when we enable `Cookie Restriction Mode`, the method `CookieHelper::isUserNotAllowSaveCookie` will always return false, breaking other modules such as `Google Analytics` (the monitoring code will never show up!).\r\n\r\nThis PR fix the problem"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/253468171","html_url":"https://github.com/magento/magento2/pull/6922#issuecomment-253468171","issue_url":"https://api.github.com/repos/magento/magento2/issues/6922","id":253468171,"user":{"login":"Iazel","id":1616917,"avatar_url":"https://avatars.githubusercontent.com/u/1616917?v=3","gravatar_id":"","url":"https://api.github.com/users/Iazel","html_url":"https://github.com/Iazel","followers_url":"https://api.github.com/users/Iazel/followers","following_url":"https://api.github.com/users/Iazel/following{/other_user}","gists_url":"https://api.github.com/users/Iazel/gists{/gist_id}","starred_url":"https://api.github.com/users/Iazel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iazel/subscriptions","organizations_url":"https://api.github.com/users/Iazel/orgs","repos_url":"https://api.github.com/users/Iazel/repos","events_url":"https://api.github.com/users/Iazel/events{/privacy}","received_events_url":"https://api.github.com/users/Iazel/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T09:52:20Z","updated_at":"2016-10-13T09:52:20Z","body":"@orlangur Yeah, point 1 do a `json_encode`, but that's because point 2 embed it in Javascript, so the final result on the client side is an object.\r\n\r\nI don't think this overly complicate the library, but instead make it less error-prone and more developer-friendly. I mean, if the core dev team stumbled on this, let alone others ^^\""}}
{"actor":{"display_login":"Iazel"}}