{"action":"created","comment":{"url":"https://api.github.com/repos/chaubold/hytra/pulls/comments/89511392","pull_request_review_id":10055874,"id":89511392,"diff_hunk":"@@ -120,7 +127,24 @@ def getTransitionFeaturesRF(self, traxelA, traxelB, transitionClassifier, probab\n         feats = [probabilityGenerator.getTraxelFeatureDict(obj.Timestep, obj.Id) for obj in [traxelA, traxelB]]\n         featVec = probabilityGenerator.getTransitionFeatureVector(feats[0], feats[1], transitionClassifier.selectedFeatures)\n         probs = transitionClassifier.predictProbabilities(featVec)[0]\n-        return [probs[0]] + [probs[1]] * (max_state - 1)\n+\n+        # or image borders, so predict probability just by distance\n+        upperBound = self.fieldOfView._FieldOfView__upperBound\n+        lowerBound = self.fieldOfView._FieldOfView__lowerBound","path":"hytra/core/ilastikhypothesesgraph.py","position":55,"original_position":55,"commit_id":"b9075b01e2d5d672261c0ec0431cd45afd1b1456","original_commit_id":"b9075b01e2d5d672261c0ec0431cd45afd1b1456","user":{"login":"chaubold","id":16854,"avatar_url":"https://avatars.githubusercontent.com/u/16854?v=3","gravatar_id":"","url":"https://api.github.com/users/chaubold","html_url":"https://github.com/chaubold","followers_url":"https://api.github.com/users/chaubold/followers","following_url":"https://api.github.com/users/chaubold/following{/other_user}","gists_url":"https://api.github.com/users/chaubold/gists{/gist_id}","starred_url":"https://api.github.com/users/chaubold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaubold/subscriptions","organizations_url":"https://api.github.com/users/chaubold/orgs","repos_url":"https://api.github.com/users/chaubold/repos","events_url":"https://api.github.com/users/chaubold/events{/privacy}","received_events_url":"https://api.github.com/users/chaubold/received_events","type":"User","site_admin":false},"body":"it would be nicer to add a getter for upper and lower bound of the field of view than to get hacky access to private members :)","created_at":"2016-11-24T14:58:10Z","updated_at":"2016-11-24T14:58:10Z","html_url":"https://github.com/chaubold/hytra/pull/11#discussion_r89511392","pull_request_url":"https://api.github.com/repos/chaubold/hytra/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/chaubold/hytra/pulls/comments/89511392"},"html":{"href":"https://github.com/chaubold/hytra/pull/11#discussion_r89511392"},"pull_request":{"href":"https://api.github.com/repos/chaubold/hytra/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/chaubold/hytra/pulls/11","id":95143153,"html_url":"https://github.com/chaubold/hytra/pull/11","diff_url":"https://github.com/chaubold/hytra/pull/11.diff","patch_url":"https://github.com/chaubold/hytra/pull/11.patch","issue_url":"https://api.github.com/repos/chaubold/hytra/issues/11","number":11,"state":"open","locked":false,"title":"Skip links gaps","user":{"login":"LetiP","id":16118202,"avatar_url":"https://avatars.githubusercontent.com/u/16118202?v=3","gravatar_id":"","url":"https://api.github.com/users/LetiP","html_url":"https://github.com/LetiP","followers_url":"https://api.github.com/users/LetiP/followers","following_url":"https://api.github.com/users/LetiP/following{/other_user}","gists_url":"https://api.github.com/users/LetiP/gists{/gist_id}","starred_url":"https://api.github.com/users/LetiP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LetiP/subscriptions","organizations_url":"https://api.github.com/users/LetiP/orgs","repos_url":"https://api.github.com/users/LetiP/repos","events_url":"https://api.github.com/users/LetiP/events{/privacy}","received_events_url":"https://api.github.com/users/LetiP/received_events","type":"User","site_admin":false},"body":"Introduce the Skip Links to the Hypotheses Graph, that jump over i>2 frames.\r\n\r\nBecause we want the normal links to be favored though, we impose a greater energy for the SkipLinks than for the normal ones.\r\n\r\nSolution now: works without any extra multiplicative parameter from structured learning (in weights.json), but has a bias parameter --skip-links-bias (see /scripts/hypotheses_graph_to_json.py).\r\n\r\nCommented out solution: extra parameter in weights.json. In contrast to the bias parameter, that was easily found, did not manage to find a sensible value for the multiplicative extra parameter (yet?).","created_at":"2016-11-24T09:30:47Z","updated_at":"2016-11-24T14:58:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chaubold/hytra/pulls/11/commits","review_comments_url":"https://api.github.com/repos/chaubold/hytra/pulls/11/comments","review_comment_url":"https://api.github.com/repos/chaubold/hytra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chaubold/hytra/issues/11/comments","statuses_url":"https://api.github.com/repos/chaubold/hytra/statuses/b9075b01e2d5d672261c0ec0431cd45afd1b1456","head":{"label":"chaubold:skip-links-gaps","ref":"skip-links-gaps","sha":"b9075b01e2d5d672261c0ec0431cd45afd1b1456","user":{"login":"chaubold","id":16854,"avatar_url":"https://avatars.githubusercontent.com/u/16854?v=3","gravatar_id":"","url":"https://api.github.com/users/chaubold","html_url":"https://github.com/chaubold","followers_url":"https://api.github.com/users/chaubold/followers","following_url":"https://api.github.com/users/chaubold/following{/other_user}","gists_url":"https://api.github.com/users/chaubold/gists{/gist_id}","starred_url":"https://api.github.com/users/chaubold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaubold/subscriptions","organizations_url":"https://api.github.com/users/chaubold/orgs","repos_url":"https://api.github.com/users/chaubold/repos","events_url":"https://api.github.com/users/chaubold/events{/privacy}","received_events_url":"https://api.github.com/users/chaubold/received_events","type":"User","site_admin":false},"repo":{"id":50166155,"name":"hytra","full_name":"chaubold/hytra","owner":{"login":"chaubold","id":16854,"avatar_url":"https://avatars.githubusercontent.com/u/16854?v=3","gravatar_id":"","url":"https://api.github.com/users/chaubold","html_url":"https://github.com/chaubold","followers_url":"https://api.github.com/users/chaubold/followers","following_url":"https://api.github.com/users/chaubold/following{/other_user}","gists_url":"https://api.github.com/users/chaubold/gists{/gist_id}","starred_url":"https://api.github.com/users/chaubold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaubold/subscriptions","organizations_url":"https://api.github.com/users/chaubold/orgs","repos_url":"https://api.github.com/users/chaubold/repos","events_url":"https://api.github.com/users/chaubold/events{/privacy}","received_events_url":"https://api.github.com/users/chaubold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaubold/hytra","description":"Python module for multi HYpotheses TRAcking","fork":false,"url":"https://api.github.com/repos/chaubold/hytra","forks_url":"https://api.github.com/repos/chaubold/hytra/forks","keys_url":"https://api.github.com/repos/chaubold/hytra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaubold/hytra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaubold/hytra/teams","hooks_url":"https://api.github.com/repos/chaubold/hytra/hooks","issue_events_url":"https://api.github.com/repos/chaubold/hytra/issues/events{/number}","events_url":"https://api.github.com/repos/chaubold/hytra/events","assignees_url":"https://api.github.com/repos/chaubold/hytra/assignees{/user}","branches_url":"https://api.github.com/repos/chaubold/hytra/branches{/branch}","tags_url":"https://api.github.com/repos/chaubold/hytra/tags","blobs_url":"https://api.github.com/repos/chaubold/hytra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaubold/hytra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaubold/hytra/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaubold/hytra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaubold/hytra/statuses/{sha}","languages_url":"https://api.github.com/repos/chaubold/hytra/languages","stargazers_url":"https://api.github.com/repos/chaubold/hytra/stargazers","contributors_url":"https://api.github.com/repos/chaubold/hytra/contributors","subscribers_url":"https://api.github.com/repos/chaubold/hytra/subscribers","subscription_url":"https://api.github.com/repos/chaubold/hytra/subscription","commits_url":"https://api.github.com/repos/chaubold/hytra/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaubold/hytra/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaubold/hytra/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaubold/hytra/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaubold/hytra/contents/{+path}","compare_url":"https://api.github.com/repos/chaubold/hytra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaubold/hytra/merges","archive_url":"https://api.github.com/repos/chaubold/hytra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaubold/hytra/downloads","issues_url":"https://api.github.com/repos/chaubold/hytra/issues{/number}","pulls_url":"https://api.github.com/repos/chaubold/hytra/pulls{/number}","milestones_url":"https://api.github.com/repos/chaubold/hytra/milestones{/number}","notifications_url":"https://api.github.com/repos/chaubold/hytra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaubold/hytra/labels{/name}","releases_url":"https://api.github.com/repos/chaubold/hytra/releases{/id}","deployments_url":"https://api.github.com/repos/chaubold/hytra/deployments","created_at":"2016-01-22T07:47:49Z","updated_at":"2016-10-24T14:21:20Z","pushed_at":"2016-11-24T12:47:06Z","git_url":"git://github.com/chaubold/hytra.git","ssh_url":"git@github.com:chaubold/hytra.git","clone_url":"https://github.com/chaubold/hytra.git","svn_url":"https://github.com/chaubold/hytra","homepage":"","size":3676,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"chaubold:master","ref":"master","sha":"2c033c994fb66c0de0339566c1b3be0ad6da9f1c","user":{"login":"chaubold","id":16854,"avatar_url":"https://avatars.githubusercontent.com/u/16854?v=3","gravatar_id":"","url":"https://api.github.com/users/chaubold","html_url":"https://github.com/chaubold","followers_url":"https://api.github.com/users/chaubold/followers","following_url":"https://api.github.com/users/chaubold/following{/other_user}","gists_url":"https://api.github.com/users/chaubold/gists{/gist_id}","starred_url":"https://api.github.com/users/chaubold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaubold/subscriptions","organizations_url":"https://api.github.com/users/chaubold/orgs","repos_url":"https://api.github.com/users/chaubold/repos","events_url":"https://api.github.com/users/chaubold/events{/privacy}","received_events_url":"https://api.github.com/users/chaubold/received_events","type":"User","site_admin":false},"repo":{"id":50166155,"name":"hytra","full_name":"chaubold/hytra","owner":{"login":"chaubold","id":16854,"avatar_url":"https://avatars.githubusercontent.com/u/16854?v=3","gravatar_id":"","url":"https://api.github.com/users/chaubold","html_url":"https://github.com/chaubold","followers_url":"https://api.github.com/users/chaubold/followers","following_url":"https://api.github.com/users/chaubold/following{/other_user}","gists_url":"https://api.github.com/users/chaubold/gists{/gist_id}","starred_url":"https://api.github.com/users/chaubold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaubold/subscriptions","organizations_url":"https://api.github.com/users/chaubold/orgs","repos_url":"https://api.github.com/users/chaubold/repos","events_url":"https://api.github.com/users/chaubold/events{/privacy}","received_events_url":"https://api.github.com/users/chaubold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaubold/hytra","description":"Python module for multi HYpotheses TRAcking","fork":false,"url":"https://api.github.com/repos/chaubold/hytra","forks_url":"https://api.github.com/repos/chaubold/hytra/forks","keys_url":"https://api.github.com/repos/chaubold/hytra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaubold/hytra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaubold/hytra/teams","hooks_url":"https://api.github.com/repos/chaubold/hytra/hooks","issue_events_url":"https://api.github.com/repos/chaubold/hytra/issues/events{/number}","events_url":"https://api.github.com/repos/chaubold/hytra/events","assignees_url":"https://api.github.com/repos/chaubold/hytra/assignees{/user}","branches_url":"https://api.github.com/repos/chaubold/hytra/branches{/branch}","tags_url":"https://api.github.com/repos/chaubold/hytra/tags","blobs_url":"https://api.github.com/repos/chaubold/hytra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaubold/hytra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaubold/hytra/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaubold/hytra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaubold/hytra/statuses/{sha}","languages_url":"https://api.github.com/repos/chaubold/hytra/languages","stargazers_url":"https://api.github.com/repos/chaubold/hytra/stargazers","contributors_url":"https://api.github.com/repos/chaubold/hytra/contributors","subscribers_url":"https://api.github.com/repos/chaubold/hytra/subscribers","subscription_url":"https://api.github.com/repos/chaubold/hytra/subscription","commits_url":"https://api.github.com/repos/chaubold/hytra/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaubold/hytra/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaubold/hytra/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaubold/hytra/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaubold/hytra/contents/{+path}","compare_url":"https://api.github.com/repos/chaubold/hytra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaubold/hytra/merges","archive_url":"https://api.github.com/repos/chaubold/hytra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaubold/hytra/downloads","issues_url":"https://api.github.com/repos/chaubold/hytra/issues{/number}","pulls_url":"https://api.github.com/repos/chaubold/hytra/pulls{/number}","milestones_url":"https://api.github.com/repos/chaubold/hytra/milestones{/number}","notifications_url":"https://api.github.com/repos/chaubold/hytra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaubold/hytra/labels{/name}","releases_url":"https://api.github.com/repos/chaubold/hytra/releases{/id}","deployments_url":"https://api.github.com/repos/chaubold/hytra/deployments","created_at":"2016-01-22T07:47:49Z","updated_at":"2016-10-24T14:21:20Z","pushed_at":"2016-11-24T12:47:06Z","git_url":"git://github.com/chaubold/hytra.git","ssh_url":"git@github.com:chaubold/hytra.git","clone_url":"https://github.com/chaubold/hytra.git","svn_url":"https://github.com/chaubold/hytra","homepage":"","size":3676,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chaubold/hytra/pulls/11"},"html":{"href":"https://github.com/chaubold/hytra/pull/11"},"issue":{"href":"https://api.github.com/repos/chaubold/hytra/issues/11"},"comments":{"href":"https://api.github.com/repos/chaubold/hytra/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/chaubold/hytra/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/chaubold/hytra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chaubold/hytra/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/chaubold/hytra/statuses/b9075b01e2d5d672261c0ec0431cd45afd1b1456"}}}}
{"actor":{"display_login":"chaubold"}}