{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/build/pulls/comments/52061411","id":52061411,"diff_hunk":"@@ -46,6 +48,35 @@ class FileBasedAssetReader implements AssetReader {\n       throw new InvalidInputException(id);\n     }\n   }\n+\n+  /// Searches for all [AssetId]s matching [inputSet]s.\n+  Stream<AssetId> listAssetIds(Iterable<InputSet> inputSets) async* {\n+    var seenAssets = new Set<AssetId>();\n+    for (var inputSet in inputSets) {\n+      var packageNode = packageGraph[inputSet.package];\n+      var packagePath = packageNode.location.toFilePath();\n+      for (var glob in inputSet.globs) {\n+        var files = glob.listSync(followLinks: false, root: packagePath).where(","path":"lib/src/asset/file_based.dart","position":31,"original_position":31,"commit_id":"cb7da4f672a92121e9c7c379447c105eae142159","original_commit_id":"cb7da4f672a92121e9c7c379447c105eae142159","user":{"login":"sigmundch","id":2049220,"avatar_url":"https://avatars.githubusercontent.com/u/2049220?v=3","gravatar_id":"","url":"https://api.github.com/users/sigmundch","html_url":"https://github.com/sigmundch","followers_url":"https://api.github.com/users/sigmundch/followers","following_url":"https://api.github.com/users/sigmundch/following{/other_user}","gists_url":"https://api.github.com/users/sigmundch/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmundch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmundch/subscriptions","organizations_url":"https://api.github.com/users/sigmundch/orgs","repos_url":"https://api.github.com/users/sigmundch/repos","events_url":"https://api.github.com/users/sigmundch/events{/privacy}","received_events_url":"https://api.github.com/users/sigmundch/received_events","type":"User","site_admin":false},"body":"might not matter, but I guess you could do this async, given that you are already in an async* method?","created_at":"2016-02-05T19:27:14Z","updated_at":"2016-02-05T19:27:14Z","html_url":"https://github.com/dart-lang/build/pull/33#discussion_r52061411","pull_request_url":"https://api.github.com/repos/dart-lang/build/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/build/pulls/comments/52061411"},"html":{"href":"https://github.com/dart-lang/build/pull/33#discussion_r52061411"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/build/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/build/pulls/33","id":58471899,"html_url":"https://github.com/dart-lang/build/pull/33","diff_url":"https://github.com/dart-lang/build/pull/33.diff","patch_url":"https://github.com/dart-lang/build/pull/33.patch","issue_url":"https://api.github.com/repos/dart-lang/build/issues/33","number":33,"state":"open","locked":false,"title":"add some basic build tests to get started, as well as a basic test framework","user":{"login":"jakemac53","id":984921,"avatar_url":"https://avatars.githubusercontent.com/u/984921?v=3","gravatar_id":"","url":"https://api.github.com/users/jakemac53","html_url":"https://github.com/jakemac53","followers_url":"https://api.github.com/users/jakemac53/followers","following_url":"https://api.github.com/users/jakemac53/following{/other_user}","gists_url":"https://api.github.com/users/jakemac53/gists{/gist_id}","starred_url":"https://api.github.com/users/jakemac53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakemac53/subscriptions","organizations_url":"https://api.github.com/users/jakemac53/orgs","repos_url":"https://api.github.com/users/jakemac53/repos","events_url":"https://api.github.com/users/jakemac53/events{/privacy}","received_events_url":"https://api.github.com/users/jakemac53/received_events","type":"User","site_admin":false},"body":"I also snuck in a needed update to `AssetReader`, which lets you list files matching a list of `InputSet`s. This was the last step needed to have a fully injectable asset system.","created_at":"2016-02-05T19:18:44Z","updated_at":"2016-02-05T19:27:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5e294a3e351054e35a6cd0dec281a5015293942","assignee":{"login":"sigmundch","id":2049220,"avatar_url":"https://avatars.githubusercontent.com/u/2049220?v=3","gravatar_id":"","url":"https://api.github.com/users/sigmundch","html_url":"https://github.com/sigmundch","followers_url":"https://api.github.com/users/sigmundch/followers","following_url":"https://api.github.com/users/sigmundch/following{/other_user}","gists_url":"https://api.github.com/users/sigmundch/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmundch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmundch/subscriptions","organizations_url":"https://api.github.com/users/sigmundch/orgs","repos_url":"https://api.github.com/users/sigmundch/repos","events_url":"https://api.github.com/users/sigmundch/events{/privacy}","received_events_url":"https://api.github.com/users/sigmundch/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dart-lang/build/milestones/2","html_url":"https://github.com/dart-lang/build/milestones/v0.1.1%20release","labels_url":"https://api.github.com/repos/dart-lang/build/milestones/2/labels","id":1534890,"number":2,"title":"v0.1.1 release","description":"Can run clean (non-incremental) builds using this package only, without using pub serve/build.","creator":{"login":"jakemac53","id":984921,"avatar_url":"https://avatars.githubusercontent.com/u/984921?v=3","gravatar_id":"","url":"https://api.github.com/users/jakemac53","html_url":"https://github.com/jakemac53","followers_url":"https://api.github.com/users/jakemac53/followers","following_url":"https://api.github.com/users/jakemac53/following{/other_user}","gists_url":"https://api.github.com/users/jakemac53/gists{/gist_id}","starred_url":"https://api.github.com/users/jakemac53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakemac53/subscriptions","organizations_url":"https://api.github.com/users/jakemac53/orgs","repos_url":"https://api.github.com/users/jakemac53/repos","events_url":"https://api.github.com/users/jakemac53/events{/privacy}","received_events_url":"https://api.github.com/users/jakemac53/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":7,"state":"open","created_at":"2016-01-22T15:49:15Z","updated_at":"2016-02-05T19:18:44Z","due_on":"2016-02-12T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dart-lang/build/pulls/33/commits","review_comments_url":"https://api.github.com/repos/dart-lang/build/pulls/33/comments","review_comment_url":"https://api.github.com/repos/dart-lang/build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/build/issues/33/comments","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/cb7da4f672a92121e9c7c379447c105eae142159","head":{"label":"dart-lang:build-tests","ref":"build-tests","sha":"cb7da4f672a92121e9c7c379447c105eae142159","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":50053618,"name":"build","full_name":"dart-lang/build","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/build","description":"","fork":false,"url":"https://api.github.com/repos/dart-lang/build","forks_url":"https://api.github.com/repos/dart-lang/build/forks","keys_url":"https://api.github.com/repos/dart-lang/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/build/teams","hooks_url":"https://api.github.com/repos/dart-lang/build/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/build/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/build/events","assignees_url":"https://api.github.com/repos/dart-lang/build/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/build/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/build/tags","blobs_url":"https://api.github.com/repos/dart-lang/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/build/languages","stargazers_url":"https://api.github.com/repos/dart-lang/build/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/build/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/build/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/build/subscription","commits_url":"https://api.github.com/repos/dart-lang/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/build/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/build/merges","archive_url":"https://api.github.com/repos/dart-lang/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/build/downloads","issues_url":"https://api.github.com/repos/dart-lang/build/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/build/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/build/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/build/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/build/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/build/deployments","created_at":"2016-01-20T19:12:37Z","updated_at":"2016-01-22T15:28:43Z","pushed_at":"2016-02-05T19:18:44Z","git_url":"git://github.com/dart-lang/build.git","ssh_url":"git@github.com:dart-lang/build.git","clone_url":"https://github.com/dart-lang/build.git","svn_url":"https://github.com/dart-lang/build","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"f67343164f1e33f5c6f09105e88d4b974b1feb82","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":50053618,"name":"build","full_name":"dart-lang/build","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/build","description":"","fork":false,"url":"https://api.github.com/repos/dart-lang/build","forks_url":"https://api.github.com/repos/dart-lang/build/forks","keys_url":"https://api.github.com/repos/dart-lang/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/build/teams","hooks_url":"https://api.github.com/repos/dart-lang/build/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/build/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/build/events","assignees_url":"https://api.github.com/repos/dart-lang/build/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/build/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/build/tags","blobs_url":"https://api.github.com/repos/dart-lang/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/build/languages","stargazers_url":"https://api.github.com/repos/dart-lang/build/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/build/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/build/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/build/subscription","commits_url":"https://api.github.com/repos/dart-lang/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/build/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/build/merges","archive_url":"https://api.github.com/repos/dart-lang/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/build/downloads","issues_url":"https://api.github.com/repos/dart-lang/build/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/build/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/build/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/build/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/build/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/build/deployments","created_at":"2016-01-20T19:12:37Z","updated_at":"2016-01-22T15:28:43Z","pushed_at":"2016-02-05T19:18:44Z","git_url":"git://github.com/dart-lang/build.git","ssh_url":"git@github.com:dart-lang/build.git","clone_url":"https://github.com/dart-lang/build.git","svn_url":"https://github.com/dart-lang/build","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/build/pulls/33"},"html":{"href":"https://github.com/dart-lang/build/pull/33"},"issue":{"href":"https://api.github.com/repos/dart-lang/build/issues/33"},"comments":{"href":"https://api.github.com/repos/dart-lang/build/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/build/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/build/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/build/statuses/cb7da4f672a92121e9c7c379447c105eae142159"}}}}