{"action":"created","issue":{"url":"https://api.github.com/repos/vanilla-music/vanilla/issues/303","repository_url":"https://api.github.com/repos/vanilla-music/vanilla","labels_url":"https://api.github.com/repos/vanilla-music/vanilla/issues/303/labels{/name}","comments_url":"https://api.github.com/repos/vanilla-music/vanilla/issues/303/comments","events_url":"https://api.github.com/repos/vanilla-music/vanilla/issues/303/events","html_url":"https://github.com/vanilla-music/vanilla/pull/303","id":140423824,"number":303,"title":"Implement lyrics fetching using open LyricsWiki API","user":{"login":"Adonai","id":863272,"avatar_url":"https://avatars.githubusercontent.com/u/863272?v=3","gravatar_id":"","url":"https://api.github.com/users/Adonai","html_url":"https://github.com/Adonai","followers_url":"https://api.github.com/users/Adonai/followers","following_url":"https://api.github.com/users/Adonai/following{/other_user}","gists_url":"https://api.github.com/users/Adonai/gists{/gist_id}","starred_url":"https://api.github.com/users/Adonai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adonai/subscriptions","organizations_url":"https://api.github.com/users/Adonai/orgs","repos_url":"https://api.github.com/users/Adonai/repos","events_url":"https://api.github.com/users/Adonai/events{/privacy}","received_events_url":"https://api.github.com/users/Adonai/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-03-12T22:55:49Z","updated_at":"2016-03-13T14:30:49Z","closed_at":"2016-03-13T10:59:28Z","pull_request":{"url":"https://api.github.com/repos/vanilla-music/vanilla/pulls/303","html_url":"https://github.com/vanilla-music/vanilla/pull/303","diff_url":"https://github.com/vanilla-music/vanilla/pull/303.diff","patch_url":"https://github.com/vanilla-music/vanilla/pull/303.patch"},"body":"This PR adds new action for song list context menu\r\n\r\nIt creates a background activity to fetch lyrics page from LyricsWiki\r\nand shows lyrics text of the song in the dialog\r\n\r\nFuture plans: \r\n- saving of lyrics to `USLT` tag (and retrieval)\r\n- support for lyrics synchronization from `*.lrc` files"},"comment":{"url":"https://api.github.com/repos/vanilla-music/vanilla/issues/comments/195965198","html_url":"https://github.com/vanilla-music/vanilla/pull/303#issuecomment-195965198","issue_url":"https://api.github.com/repos/vanilla-music/vanilla/issues/303","id":195965198,"user":{"login":"adrian-bl","id":568734,"avatar_url":"https://avatars.githubusercontent.com/u/568734?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-bl","html_url":"https://github.com/adrian-bl","followers_url":"https://api.github.com/users/adrian-bl/followers","following_url":"https://api.github.com/users/adrian-bl/following{/other_user}","gists_url":"https://api.github.com/users/adrian-bl/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-bl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-bl/subscriptions","organizations_url":"https://api.github.com/users/adrian-bl/orgs","repos_url":"https://api.github.com/users/adrian-bl/repos","events_url":"https://api.github.com/users/adrian-bl/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-bl/received_events","type":"User","site_admin":false},"created_at":"2016-03-13T14:30:49Z","updated_at":"2016-03-13T14:30:49Z","body":"> I know it's not as simple as it sounds, but off top of my head, I know DashClock and Twidere have similar \r\n> capabilities, and I think if we get it right it'll be quite something.\r\n\r\nYes, and Twideres Plugin System is simply using the standard android 'Intents' feature, which we already support (and is used by all widgets and the headphone detector app.)\r\n\r\nTo quote myself:\r\n> > [...] The user would just have to have it installed: vanilla music and the lyrics-downloader could \r\n> > communicate via intents just fine (just like it's done with audio scrobblers)\r\n\r\nI'm a big fan of intents and adding more of them to support various callbacks (eg: stuff like SONG_COVER_UPDATE, SONG_LYRICS_UPDATE, etc) is fine with me - and having a nicer twidere-like settings integration would also be fine for me.\r\n\r\n> P.S. If you like the idea, I can open a new issue (RFC-like) to discuss it.\r\n\r\nYes, that might be a good idea - and a lyrics fetcher might also be a good prototype.\r\nWe could use QuickLyric (https://f-droid.org/repository/browse/?fdid=com.geecko.QuickLyric) as a testbed which already works nicely with vanilla music (by waiting for our broadcast events). All that's missing IMO would be some:\r\n```\r\nfinal Intent intent = new Intent(INTENT_VANILLA_DISPLAY_TEXT_ON_COVER);\r\nintent.putExtra(VANILLA_EXTRA_TEXT, \"These are the song lyrics....\");\r\nintent.putExtra(VANILLA_EXTRA_DURATION, 5000); // 5 sec\r\n```\r\ncallback.\r\n"}}