{"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/comments/91509766","pull_request_review_id":12016458,"id":91509766,"diff_hunk":"@@ -1,34 +1,24 @@\n from os import path, listdir\r\n import logging\r\n \r\n-from golem.core.common import get_golem_path\r\n+logger = logging.getLogger(\"apps.rendering\")\r\n \r\n-logger = logging.getLogger(\"gnr.app\")\r\n-\r\n-PREV_FILE = \"ui/nopreview.png\"\r\n+PREV_FILE = \"view/nopreview.png\"\r\n \r\n \r\n def get_preview_file():\r\n     return path.normpath(PREV_FILE)\r\n \r\n \r\n-def get_task_scripts_path():\r\n-    return path.join(get_golem_path(), \"gnr\", \"task\", \"scripts\")\r\n-\r\n-\r\n-def find_task_script(script_name):\r\n-    scripts_path = get_task_scripts_path()\r\n+def find_task_script(task__file__, script_name):\r\n+    scripts_path = path.abspath(path.join(path.dirname(path.abspath(task__file__)), \"..\", \"resources\", \"scripts\"))\r","path":"apps/rendering/task/renderingdirmanager.py","position":24,"original_position":24,"commit_id":"9694330e8923d48519470d9c86ec39afb5373f75","original_commit_id":"9694330e8923d48519470d9c86ec39afb5373f75","user":{"login":"mfranciszkiewicz","id":3238836,"avatar_url":"https://avatars.githubusercontent.com/u/3238836?v=3","gravatar_id":"","url":"https://api.github.com/users/mfranciszkiewicz","html_url":"https://github.com/mfranciszkiewicz","followers_url":"https://api.github.com/users/mfranciszkiewicz/followers","following_url":"https://api.github.com/users/mfranciszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/mfranciszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranciszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranciszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/mfranciszkiewicz/orgs","repos_url":"https://api.github.com/users/mfranciszkiewicz/repos","events_url":"https://api.github.com/users/mfranciszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/mfranciszkiewicz/received_events","type":"User","site_admin":false},"body":"Perhaps we could use package directories (e.g. `rendering.__path__`) to avoid `..`","created_at":"2016-12-08T13:08:59Z","updated_at":"2016-12-08T13:27:45Z","html_url":"https://github.com/golemfactory/golem/pull/696#discussion_r91509766","pull_request_url":"https://api.github.com/repos/golemfactory/golem/pulls/696","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments/91509766"},"html":{"href":"https://github.com/golemfactory/golem/pull/696#discussion_r91509766"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/696"}}},"pull_request":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/696","id":96327678,"html_url":"https://github.com/golemfactory/golem/pull/696","diff_url":"https://github.com/golemfactory/golem/pull/696.diff","patch_url":"https://github.com/golemfactory/golem/pull/696.patch","issue_url":"https://api.github.com/repos/golemfactory/golem/issues/696","number":696,"state":"open","locked":false,"title":"Refactor gnr ","user":{"login":"badb","id":483392,"avatar_url":"https://avatars.githubusercontent.com/u/483392?v=3","gravatar_id":"","url":"https://api.github.com/users/badb","html_url":"https://github.com/badb","followers_url":"https://api.github.com/users/badb/followers","following_url":"https://api.github.com/users/badb/following{/other_user}","gists_url":"https://api.github.com/users/badb/gists{/gist_id}","starred_url":"https://api.github.com/users/badb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badb/subscriptions","organizations_url":"https://api.github.com/users/badb/orgs","repos_url":"https://api.github.com/users/badb/repos","events_url":"https://api.github.com/users/badb/events{/privacy}","received_events_url":"https://api.github.com/users/badb/received_events","type":"User","site_admin":false},"body":"Resolves #307 \r\n\r\nThere are still many things that should be changed, but maybe it's a good idea to merge it in current form and fix next thing later. \r\n\r\nMain changes:\r\n- different directory structure, some files moved\r\n- ui files renamed to views\r\n- customizers directories renamed to controllers\r\n- some parts of renderingapplication logic moved to applicationlogic (finally we want to remove this class completely)\r\n- appsmanager (temporary solution) that loads config, so golem and gui classes won't have to import things from specific apps\r\n- rendering environment splited into blender environment and lux environment\r\n- scene file editor splitted into blender and lux editor\r\n- find_task_script removed \r\n- main.py removed (it can be replaced by golemapp.py)\r\n- generateui now scans not only gui directory but also apps directories for .ui files\r\n\r\n\r\n","created_at":"2016-12-02T18:20:09Z","updated_at":"2016-12-08T13:27:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b43ae168f10f05ff379609ed3c59b1e76fc2bffd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/golem/pulls/696/commits","review_comments_url":"https://api.github.com/repos/golemfactory/golem/pulls/696/comments","review_comment_url":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/golem/issues/696/comments","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/9694330e8923d48519470d9c86ec39afb5373f75","head":{"label":"golemfactory:refactor_gnr","ref":"refactor_gnr","sha":"9694330e8923d48519470d9c86ec39afb5373f75","user":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars.githubusercontent.com/u/23193179?v=3","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"name":"golem","full_name":"golemfactory/golem","owner":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars.githubusercontent.com/u/23193179?v=3","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/golem","description":"Golem project is to create a global prosumer market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2016-12-07T18:59:17Z","pushed_at":"2016-12-08T12:52:22Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":22954,"stargazers_count":153,"watchers_count":153,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":116,"forks":7,"open_issues":116,"watchers":153,"default_branch":"develop"}},"base":{"label":"golemfactory:develop","ref":"develop","sha":"069ab90214a610a39db5b62171beb683401db01d","user":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars.githubusercontent.com/u/23193179?v=3","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"name":"golem","full_name":"golemfactory/golem","owner":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars.githubusercontent.com/u/23193179?v=3","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/golem","description":"Golem project is to create a global prosumer market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2016-12-07T18:59:17Z","pushed_at":"2016-12-08T12:52:22Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":22954,"stargazers_count":153,"watchers_count":153,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":116,"forks":7,"open_issues":116,"watchers":153,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/696"},"html":{"href":"https://github.com/golemfactory/golem/pull/696"},"issue":{"href":"https://api.github.com/repos/golemfactory/golem/issues/696"},"comments":{"href":"https://api.github.com/repos/golemfactory/golem/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/golem/statuses/9694330e8923d48519470d9c86ec39afb5373f75"}}}}
{"actor":{"display_login":"mfranciszkiewicz"}}