{"action":"created","issue":{"url":"https://api.github.com/repos/melpa/melpa/issues/3965","repository_url":"https://api.github.com/repos/melpa/melpa","labels_url":"https://api.github.com/repos/melpa/melpa/issues/3965/labels{/name}","comments_url":"https://api.github.com/repos/melpa/melpa/issues/3965/comments","events_url":"https://api.github.com/repos/melpa/melpa/issues/3965/events","html_url":"https://github.com/melpa/melpa/pull/3965","id":158656022,"number":3965,"title":"add recipe for 'ifind-mode-plus'","user":{"login":"djangoliv","id":13416971,"avatar_url":"https://avatars.githubusercontent.com/u/13416971?v=3","gravatar_id":"","url":"https://api.github.com/users/djangoliv","html_url":"https://github.com/djangoliv","followers_url":"https://api.github.com/users/djangoliv/followers","following_url":"https://api.github.com/users/djangoliv/following{/other_user}","gists_url":"https://api.github.com/users/djangoliv/gists{/gist_id}","starred_url":"https://api.github.com/users/djangoliv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djangoliv/subscriptions","organizations_url":"https://api.github.com/users/djangoliv/orgs","repos_url":"https://api.github.com/users/djangoliv/repos","events_url":"https://api.github.com/users/djangoliv/events{/privacy}","received_events_url":"https://api.github.com/users/djangoliv/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-06T11:27:06Z","updated_at":"2016-06-06T21:27:06Z","closed_at":"2016-06-06T21:27:06Z","pull_request":{"url":"https://api.github.com/repos/melpa/melpa/pulls/3965","html_url":"https://github.com/melpa/melpa/pull/3965","diff_url":"https://github.com/melpa/melpa/pull/3965.diff","patch_url":"https://github.com/melpa/melpa/pull/3965.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/melpa/melpa/issues/comments/224093705","html_url":"https://github.com/melpa/melpa/pull/3965#issuecomment-224093705","issue_url":"https://api.github.com/repos/melpa/melpa/issues/3965","id":224093705,"user":{"login":"purcell","id":5636,"avatar_url":"https://avatars.githubusercontent.com/u/5636?v=3","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T21:27:06Z","updated_at":"2016-06-06T21:27:06Z","body":"Thanks. A few issues here:\r\n\r\n- This file won't byte-compile cleanly because it references `workspace-dir`. Don't make this code rely on the user setting a variable first: that's really not the emacs way to do things. Instead, make it a `defcustom` with a reasonable default value and allow the user to override.\r\n- The package description on the first line cannot be wrapped: you should shorten it, e.g. to \"Search like isearch across files in a workspace\"\r\n- Re. `ifind-excluded-files-list` and `ifind-excluded-dirs-list`, there are already multiple lists like this (e.g. `grep-find-ignored-files` and `grep-find-ignored-directories`), and code for building `find` commands: try to re-use those rather than reinvent the wheel.\r\n- Use `define-minor-mode` to define `ifind-mode` if possible. The code in `ifind-exit` would then live in the mode definition form. Modifying `overriding-terminal-local-map` looks wrong to me.\r\n- You're missing the mandatory `provide` form.\r\n- Since the library is called `ifind-mode-plus`, the `ifind-*` symbols like `ifind-abort` should instead be called `ifind-mode-plus-*`.\r\n\r\nOverall this feels like it's a mixed bag of project-switching logic and grep-find, and I'm not sure that it's going to be widely useful in its current form when there are more polished alternatives like `projectile` and `ag` etc., not to mention `helm`. Note that `ag.el`, in particular, handles searching in projects really nicely, without requiring the user to \"switch\" from one to another.\r\n\r\nSo I'm going to decline this package for now, and I'd encourage you to explore alternatives. If - after a while - you still feel like this package brings something new to the emacs ecosystem, feel free to resubmit."}}
{"actor":{"display_login":"purcell"}}