{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/5915","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/5915/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/5915/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/5915/events","html_url":"https://github.com/dotnet/coreclr/pull/5915","id":161605584,"number":5915,"title":"Clean up fgMorphArgs","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-22T06:45:35Z","updated_at":"2016-06-22T16:08:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/5915","html_url":"https://github.com/dotnet/coreclr/pull/5915","diff_url":"https://github.com/dotnet/coreclr/pull/5915.diff","patch_url":"https://github.com/dotnet/coreclr/pull/5915.patch"},"body":"Simplify a lot of the coding, especially related to non-standard arg and SysV struct arg handling.\r\n\r\nSpecifically,\r\n\r\n1. Added more details to `fgArgTabEntry::Dump()`\r\n2. Adding non-standard args is always (and already) done under `!lateArgsComputed`, so delete that condition.\r\n3. Standardize on `if (lateArgsComputed) { } else { }` pattern; reverse existing `!lateArgsComputed` cases.\r\n4. Delete unneeded `nonRegPassableStruct` variable.\r\n5. Merge `argIndex++` into loop structure (avoids distributing this to various `continue` cases).\r\n6. Delete some dead code related to `passUsingIntRegs` for `UNIX_AMD64_ABI`.\r\n7. Simplify UNIX `structFloatRegs`/`structIntRegs` counting, and reduce scope of these counters.\r\n8. Simplify `passedInRegisters` condition, and get rid of this temp.\r\n9. Simplify UNIX `nextRegNum`/`nextOtherRegNum` calculation.\r\n10. Simplify non-standard args handling: eliminate one `AddArgReg()` call.\r\n11. Removed `#ifdefs` in code by making `SetIsBackFilled()` unconditional, but creating a do-nothing non-ARM version.\r\n12. lowerxarch.cpp: unrelated: just fix a typo.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/227793837","html_url":"https://github.com/dotnet/coreclr/pull/5915#issuecomment-227793837","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/5915","id":227793837,"user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T16:08:38Z","updated_at":"2016-06-22T16:08:38Z","body":"@briansull PTAL\r\ncc @dotnet/jit-contrib\r\n"}}
{"actor":{"display_login":"BruceForstall"}}