{"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine/pulls/comments/55922151","id":55922151,"diff_hunk":"@@ -0,0 +1,62 @@\n+/**\n+ *  \\file sets.h\n+ *  Polynomial Manipulation\n+ *\n+ **/\n+#ifndef SYMENGINE_SETS_H\n+#define SYMENGINE_SETS_H\n+\n+#include <symengine/basic.h>\n+#include <symengine/functions.h>\n+#include <symengine/number.h>\n+#include <symengine/rational.h>\n+#include <symengine/complex.h>\n+\n+\n+namespace SymEngine {\n+\n+class Interval : public Basic  {","path":"symengine/sets.h","position":18,"original_position":18,"commit_id":"e3b8c4aefbf67de702e9b285b0a3eb363a146d70","original_commit_id":"e3b8c4aefbf67de702e9b285b0a3eb363a146d70","user":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"body":"Thanks!\r\nWhat should I be doing for:\r\n```\r\n    virtual bool is_zero() const = 0;\r\n    virtual bool is_one() const = 0;\r\n    virtual bool is_minus_one() const = 0;\r\n```\r\n","created_at":"2016-03-12T14:33:46Z","updated_at":"2016-03-12T14:33:46Z","html_url":"https://github.com/symengine/symengine/pull/846#discussion_r55922151","pull_request_url":"https://api.github.com/repos/symengine/symengine/pulls/846","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments/55922151"},"html":{"href":"https://github.com/symengine/symengine/pull/846#discussion_r55922151"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/846","id":61778168,"html_url":"https://github.com/symengine/symengine/pull/846","diff_url":"https://github.com/symengine/symengine/pull/846.diff","patch_url":"https://github.com/symengine/symengine/pull/846.patch","issue_url":"https://api.github.com/repos/symengine/symengine/issues/846","number":846,"state":"open","locked":false,"title":"[WIP] Added basic functionality for Intervals","user":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"body":"I have implemented set intervals.\r\nI need some design comments.\r\nI think, I should implement a class `Set` and then inherit `interval` from it, like in logic parallel to `TrigFunction` and `sin`, `cos` etc.\r\nPing @certik @isuruf ","created_at":"2016-03-04T22:02:13Z","updated_at":"2016-03-12T14:33:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd47831a8e17c2cd30e49f2a00ccf8851adcaaff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symengine/symengine/pulls/846/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine/pulls/846/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/846/comments","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/e3b8c4aefbf67de702e9b285b0a3eb363a146d70","head":{"label":"nishnik:implementing_interval","ref":"implementing_interval","sha":"e3b8c4aefbf67de702e9b285b0a3eb363a146d70","user":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"repo":{"id":51446468,"name":"symengine","full_name":"nishnik/symengine","owner":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nishnik/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/nishnik/symengine","forks_url":"https://api.github.com/repos/nishnik/symengine/forks","keys_url":"https://api.github.com/repos/nishnik/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nishnik/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nishnik/symengine/teams","hooks_url":"https://api.github.com/repos/nishnik/symengine/hooks","issue_events_url":"https://api.github.com/repos/nishnik/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/nishnik/symengine/events","assignees_url":"https://api.github.com/repos/nishnik/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/nishnik/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/nishnik/symengine/tags","blobs_url":"https://api.github.com/repos/nishnik/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nishnik/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nishnik/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/nishnik/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nishnik/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/nishnik/symengine/languages","stargazers_url":"https://api.github.com/repos/nishnik/symengine/stargazers","contributors_url":"https://api.github.com/repos/nishnik/symengine/contributors","subscribers_url":"https://api.github.com/repos/nishnik/symengine/subscribers","subscription_url":"https://api.github.com/repos/nishnik/symengine/subscription","commits_url":"https://api.github.com/repos/nishnik/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/nishnik/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/nishnik/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/nishnik/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/nishnik/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/nishnik/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nishnik/symengine/merges","archive_url":"https://api.github.com/repos/nishnik/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nishnik/symengine/downloads","issues_url":"https://api.github.com/repos/nishnik/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/nishnik/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/nishnik/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/nishnik/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nishnik/symengine/labels{/name}","releases_url":"https://api.github.com/repos/nishnik/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/nishnik/symengine/deployments","created_at":"2016-02-10T14:35:30Z","updated_at":"2016-02-10T14:35:32Z","pushed_at":"2016-03-10T22:21:57Z","git_url":"git://github.com/nishnik/symengine.git","ssh_url":"git@github.com:nishnik/symengine.git","clone_url":"https://github.com/nishnik/symengine.git","svn_url":"https://github.com/nishnik/symengine","homepage":"http://sympy.org","size":4256,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"eafc6577b488ce66fafa98e656a0e463fbb1612a","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"symengine/symengine","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/symengine/symengine","forks_url":"https://api.github.com/repos/symengine/symengine/forks","keys_url":"https://api.github.com/repos/symengine/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine/teams","hooks_url":"https://api.github.com/repos/symengine/symengine/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine/events","assignees_url":"https://api.github.com/repos/symengine/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine/tags","blobs_url":"https://api.github.com/repos/symengine/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine/subscription","commits_url":"https://api.github.com/repos/symengine/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine/merges","archive_url":"https://api.github.com/repos/symengine/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine/downloads","issues_url":"https://api.github.com/repos/symengine/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine/deployments","created_at":"2008-08-13T18:40:14Z","updated_at":"2016-03-09T23:50:38Z","pushed_at":"2016-03-12T14:32:12Z","git_url":"git://github.com/symengine/symengine.git","ssh_url":"git@github.com:symengine/symengine.git","clone_url":"https://github.com/symengine/symengine.git","svn_url":"https://github.com/symengine/symengine","homepage":"http://sympy.org","size":34008,"stargazers_count":124,"watchers_count":124,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":105,"forks":99,"open_issues":105,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/846"},"html":{"href":"https://github.com/symengine/symengine/pull/846"},"issue":{"href":"https://api.github.com/repos/symengine/symengine/issues/846"},"comments":{"href":"https://api.github.com/repos/symengine/symengine/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine/statuses/e3b8c4aefbf67de702e9b285b0a3eb363a146d70"}}}}