{"action":"created","issue":{"url":"https://api.github.com/repos/elo7/i18n-amd/issues/3","repository_url":"https://api.github.com/repos/elo7/i18n-amd","labels_url":"https://api.github.com/repos/elo7/i18n-amd/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/elo7/i18n-amd/issues/3/comments","events_url":"https://api.github.com/repos/elo7/i18n-amd/issues/3/events","html_url":"https://github.com/elo7/i18n-amd/pull/3","id":158245528,"number":3,"title":"[accept-cross-origin] Adds parameter to define another domain","user":{"login":"AlineLee","id":1765898,"avatar_url":"https://avatars.githubusercontent.com/u/1765898?v=3","gravatar_id":"","url":"https://api.github.com/users/AlineLee","html_url":"https://github.com/AlineLee","followers_url":"https://api.github.com/users/AlineLee/followers","following_url":"https://api.github.com/users/AlineLee/following{/other_user}","gists_url":"https://api.github.com/users/AlineLee/gists{/gist_id}","starred_url":"https://api.github.com/users/AlineLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlineLee/subscriptions","organizations_url":"https://api.github.com/users/AlineLee/orgs","repos_url":"https://api.github.com/users/AlineLee/repos","events_url":"https://api.github.com/users/AlineLee/events{/privacy}","received_events_url":"https://api.github.com/users/AlineLee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elo7/i18n-amd/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-02T21:36:54Z","updated_at":"2016-06-06T13:20:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elo7/i18n-amd/pulls/3","html_url":"https://github.com/elo7/i18n-amd/pull/3","diff_url":"https://github.com/elo7/i18n-amd/pull/3.diff","patch_url":"https://github.com/elo7/i18n-amd/pull/3.patch"},"body":"👓  @luiz\r\n@tisvasconcelos "},"comment":{"url":"https://api.github.com/repos/elo7/i18n-amd/issues/comments/223956498","html_url":"https://github.com/elo7/i18n-amd/pull/3#issuecomment-223956498","issue_url":"https://api.github.com/repos/elo7/i18n-amd/issues/3","id":223956498,"user":{"login":"erikatakahara","id":7630571,"avatar_url":"https://avatars.githubusercontent.com/u/7630571?v=3","gravatar_id":"","url":"https://api.github.com/users/erikatakahara","html_url":"https://github.com/erikatakahara","followers_url":"https://api.github.com/users/erikatakahara/followers","following_url":"https://api.github.com/users/erikatakahara/following{/other_user}","gists_url":"https://api.github.com/users/erikatakahara/gists{/gist_id}","starred_url":"https://api.github.com/users/erikatakahara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikatakahara/subscriptions","organizations_url":"https://api.github.com/users/erikatakahara/orgs","repos_url":"https://api.github.com/users/erikatakahara/repos","events_url":"https://api.github.com/users/erikatakahara/events{/privacy}","received_events_url":"https://api.github.com/users/erikatakahara/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T13:20:41Z","updated_at":"2016-06-06T13:20:41Z","body":"Although the code looks ok, it feels to me that now, instead of returning a literal object, i18n should return a constructor function. `domain` is a public attribute without access control and this is dangerous.\r\n\r\nUsing a constructor function would also allow a small optimization: we wouldn't need to check every request if the `domain` property is filled in with a truthy value or not.\r\n\r\n@luiz"}}
{"actor":{"display_login":"erikatakahara"}}