{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/71721578","id":71721578,"diff_hunk":"@@ -146,6 +146,68 @@ HD wallets are incompatible with older versions of Bitcoin Core.\n \n [Pull request](https://github.com/bitcoin/bitcoin/pull/8035/files), [BIP 32](https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki)\n \n+Segregated Witness\n+------------------\n+\n+The code preparations for Segregated Witness (\"segwit\"), as described in [BIP\n+141](https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki), [BIP\n+143](https://github.com/bitcoin/bips/blob/master/bip-0143.mediawiki), [BIP\n+144](https://github.com/bitcoin/bips/blob/master/bip-0144.mediawiki), and [BIP\n+145](https://github.com/bitcoin/bips/blob/master/bip-0145.mediawiki) are\n+finished and included in this release.  However, BIP 141 does not yet specify\n+activation parameters on mainnet, and so this release does not support segwit\n+use on mainnet.  Testnet use is supported, and after BIP 141 is updated with\n+proposed parameters, a future release of Bitcoin Core is expected that\n+implements those parameters for mainnet.\n+\n+Furthermore, because segwit activation is not yet specified for mainnet,\n+version 0.13.0 will behave similarly as other pre-segwit releases even after a\n+future activation of BIP 141 on the network.  Upgrading from 0.13.0 will be\n+required in order to utilize segwit-related features on mainnet (such as signal\n+BIP 141 activation, mine segwit blocks, fully validate segwit blocks, relay\n+segwit blocks to other segwit nodes, and use segwit transactions in the\n+wallet, etc).\n+\n+Mining transaction selection (\"Child Pays For Parent\")\n+------------------------------------------------------\n+\n+The mining transaction selection algorithm has been replaced with an algorithm\n+that selects transactions based on their feerate inclusive of unconfirmed\n+ancestor transactions.  This means that a low-fee transaction can become more\n+likely to be selected if a high-fee transaction that spends its outputs is\n+relayed.\n+\n+With this change, the `-blockminsize` command line option has been removed.\n+\n+The command line option `-blockmaxsize` remains an option to specify the\n+maximum number of serialized bytes in a generated block.  In addition, the new\n+command line option `-blockmaxweight` has been added, which specifies the\n+maximum \"block weight\" of a generated block, as defined by [BIP 141 (Segregated\n+Witness)] (https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki).\n+\n+In preparation for Segregated Witness, the mining algorithm has been modified\n+to optimize transaction selection for a given block weight, rather than a given\n+number of serialized bytes in a block.  In this release, transaction selection\n+is unaffected by this distinction (as BIP 141 activation is not supported on\n+mainnet in this release, see above), but in future releases and after BIP 141\n+activation, these calculations would be expected to differ.\n+\n+For optimal runtime performance, miners using this release should specify\n+`-blockmaxweight` on the command line, and not specify `-blockmaxsize`.\n+Additionally (or only) specifying `-blockmaxsize`, or relying on default\n+settings for both, may result in performance degradation, as the logic to\n+support `-blockmaxsize` performs additional computation to ensure that\n+constraint is met.  (Note that for mainnet, in this release, the equivalent","path":"doc/release-notes.md","position":55,"original_position":55,"commit_id":"52a4158f1f159a453c2db09ee8acf7045690e68e","original_commit_id":"52a4158f1f159a453c2db09ee8acf7045690e68e","user":{"login":"luke-jr","id":1095675,"avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=3","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","site_admin":false},"body":"Why is there performance degradation? That was not the case a few months ago, and we probably shouldn't release if it's noteworthy here.","created_at":"2016-07-21T14:56:09Z","updated_at":"2016-07-21T14:56:09Z","html_url":"https://github.com/bitcoin/bitcoin/pull/8374#discussion_r71721578","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/71721578"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8374#discussion_r71721578"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374","id":78040219,"html_url":"https://github.com/bitcoin/bitcoin/pull/8374","diff_url":"https://github.com/bitcoin/bitcoin/pull/8374.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8374.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8374","number":8374,"state":"open","locked":false,"title":"Add release notes for mining changes","user":{"login":"sdaftuar","id":7463573,"avatar_url":"https://avatars.githubusercontent.com/u/7463573?v=3","gravatar_id":"","url":"https://api.github.com/users/sdaftuar","html_url":"https://github.com/sdaftuar","followers_url":"https://api.github.com/users/sdaftuar/followers","following_url":"https://api.github.com/users/sdaftuar/following{/other_user}","gists_url":"https://api.github.com/users/sdaftuar/gists{/gist_id}","starred_url":"https://api.github.com/users/sdaftuar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdaftuar/subscriptions","organizations_url":"https://api.github.com/users/sdaftuar/orgs","repos_url":"https://api.github.com/users/sdaftuar/repos","events_url":"https://api.github.com/users/sdaftuar/events{/privacy}","received_events_url":"https://api.github.com/users/sdaftuar/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-19T20:08:07Z","updated_at":"2016-07-21T14:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4abdebc96bb4593f2469fa4eb61b49b9e47776b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8374/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/52a4158f1f159a453c2db09ee8acf7045690e68e","head":{"label":"sdaftuar:release-notes-mining","ref":"release-notes-mining","sha":"52a4158f1f159a453c2db09ee8acf7045690e68e","user":{"login":"sdaftuar","id":7463573,"avatar_url":"https://avatars.githubusercontent.com/u/7463573?v=3","gravatar_id":"","url":"https://api.github.com/users/sdaftuar","html_url":"https://github.com/sdaftuar","followers_url":"https://api.github.com/users/sdaftuar/followers","following_url":"https://api.github.com/users/sdaftuar/following{/other_user}","gists_url":"https://api.github.com/users/sdaftuar/gists{/gist_id}","starred_url":"https://api.github.com/users/sdaftuar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdaftuar/subscriptions","organizations_url":"https://api.github.com/users/sdaftuar/orgs","repos_url":"https://api.github.com/users/sdaftuar/repos","events_url":"https://api.github.com/users/sdaftuar/events{/privacy}","received_events_url":"https://api.github.com/users/sdaftuar/received_events","type":"User","site_admin":false},"repo":{"id":28761781,"name":"bitcoin","full_name":"sdaftuar/bitcoin","owner":{"login":"sdaftuar","id":7463573,"avatar_url":"https://avatars.githubusercontent.com/u/7463573?v=3","gravatar_id":"","url":"https://api.github.com/users/sdaftuar","html_url":"https://github.com/sdaftuar","followers_url":"https://api.github.com/users/sdaftuar/followers","following_url":"https://api.github.com/users/sdaftuar/following{/other_user}","gists_url":"https://api.github.com/users/sdaftuar/gists{/gist_id}","starred_url":"https://api.github.com/users/sdaftuar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdaftuar/subscriptions","organizations_url":"https://api.github.com/users/sdaftuar/orgs","repos_url":"https://api.github.com/users/sdaftuar/repos","events_url":"https://api.github.com/users/sdaftuar/events{/privacy}","received_events_url":"https://api.github.com/users/sdaftuar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdaftuar/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/sdaftuar/bitcoin","forks_url":"https://api.github.com/repos/sdaftuar/bitcoin/forks","keys_url":"https://api.github.com/repos/sdaftuar/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdaftuar/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdaftuar/bitcoin/teams","hooks_url":"https://api.github.com/repos/sdaftuar/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/sdaftuar/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/sdaftuar/bitcoin/events","assignees_url":"https://api.github.com/repos/sdaftuar/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/sdaftuar/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/sdaftuar/bitcoin/tags","blobs_url":"https://api.github.com/repos/sdaftuar/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdaftuar/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdaftuar/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdaftuar/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdaftuar/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/sdaftuar/bitcoin/languages","stargazers_url":"https://api.github.com/repos/sdaftuar/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/sdaftuar/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/sdaftuar/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/sdaftuar/bitcoin/subscription","commits_url":"https://api.github.com/repos/sdaftuar/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdaftuar/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdaftuar/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdaftuar/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdaftuar/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/sdaftuar/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdaftuar/bitcoin/merges","archive_url":"https://api.github.com/repos/sdaftuar/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdaftuar/bitcoin/downloads","issues_url":"https://api.github.com/repos/sdaftuar/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/sdaftuar/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/sdaftuar/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/sdaftuar/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdaftuar/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/sdaftuar/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/sdaftuar/bitcoin/deployments","created_at":"2015-01-04T02:52:13Z","updated_at":"2016-05-04T18:59:17Z","pushed_at":"2016-07-21T14:09:31Z","git_url":"git://github.com/sdaftuar/bitcoin.git","ssh_url":"git@github.com:sdaftuar/bitcoin.git","clone_url":"https://github.com/sdaftuar/bitcoin.git","svn_url":"https://github.com/sdaftuar/bitcoin","homepage":"https://bitcoin.org/en/download","size":66889,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:0.13","ref":"0.13","sha":"66dde4edf733a50dcf3ac7583e7859a449406a1d","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-07-21T14:29:55Z","pushed_at":"2016-07-21T14:16:43Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":141680,"stargazers_count":9549,"watchers_count":9549,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6375,"mirror_url":null,"open_issues_count":490,"forks":6375,"open_issues":490,"watchers":9549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8374"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8374"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8374/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8374/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/52a4158f1f159a453c2db09ee8acf7045690e68e"}}}}
{"actor":{"display_login":"luke-jr"}}