{"action":"created","issue":{"url":"https://api.github.com/repos/Breeze/breeze.js/issues/177","repository_url":"https://api.github.com/repos/Breeze/breeze.js","labels_url":"https://api.github.com/repos/Breeze/breeze.js/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/Breeze/breeze.js/issues/177/comments","events_url":"https://api.github.com/repos/Breeze/breeze.js/issues/177/events","html_url":"https://github.com/Breeze/breeze.js/issues/177","id":194661666,"number":177,"title":"Breeze 1.6.0 not working with Angular 1.6.0 (custom callback methods - success() and error() have been removed)","user":{"login":"Blarm1959","id":9214064,"avatar_url":"https://avatars.githubusercontent.com/u/9214064?v=3","gravatar_id":"","url":"https://api.github.com/users/Blarm1959","html_url":"https://github.com/Blarm1959","followers_url":"https://api.github.com/users/Blarm1959/followers","following_url":"https://api.github.com/users/Blarm1959/following{/other_user}","gists_url":"https://api.github.com/users/Blarm1959/gists{/gist_id}","starred_url":"https://api.github.com/users/Blarm1959/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blarm1959/subscriptions","organizations_url":"https://api.github.com/users/Blarm1959/orgs","repos_url":"https://api.github.com/users/Blarm1959/repos","events_url":"https://api.github.com/users/Blarm1959/events{/privacy}","received_events_url":"https://api.github.com/users/Blarm1959/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-09T18:13:06Z","updated_at":"2016-12-09T21:29:29Z","closed_at":null,"body":"In Angular 1.6.0 $http's deprecated custom callback methods - success() and error() - have been removed.\r\n\r\nLines 16401 - 16406 in breeze.debug.js are still using success and error:\r\n\r\nif (requestInfo.config) { // exists unless requestInterceptor killed it.\r\n  this.$http(requestInfo.config)\r\n      .then(requestInfo.success)\r\n      .catch(requestInfo.error);\r\n  this.$rootScope && this.$rootScope.$digest();\r\n}\r\nIn the b00_breeze.ajax.angular.js files these are lines 98 - 103.\r\n\r\nFor info see: https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http\r\n\r\nIs there a fix for this?"},"comment":{"url":"https://api.github.com/repos/Breeze/breeze.js/issues/comments/266128513","html_url":"https://github.com/Breeze/breeze.js/issues/177#issuecomment-266128513","issue_url":"https://api.github.com/repos/Breeze/breeze.js/issues/177","id":266128513,"user":{"login":"Blarm1959","id":9214064,"avatar_url":"https://avatars.githubusercontent.com/u/9214064?v=3","gravatar_id":"","url":"https://api.github.com/users/Blarm1959","html_url":"https://github.com/Blarm1959","followers_url":"https://api.github.com/users/Blarm1959/followers","following_url":"https://api.github.com/users/Blarm1959/following{/other_user}","gists_url":"https://api.github.com/users/Blarm1959/gists{/gist_id}","starred_url":"https://api.github.com/users/Blarm1959/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blarm1959/subscriptions","organizations_url":"https://api.github.com/users/Blarm1959/orgs","repos_url":"https://api.github.com/users/Blarm1959/repos","events_url":"https://api.github.com/users/Blarm1959/events{/privacy}","received_events_url":"https://api.github.com/users/Blarm1959/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T21:29:29Z","updated_at":"2016-12-09T21:29:29Z","body":"Got this to work:\r\n\r\n\r\n    if (requestInfo.config) { // exists unless requestInterceptor killed it.\r\n      this.$http(requestInfo.config)\r\n          .then(requestInfo.success)\r\n          .catch(requestInfo.error);\r\n      this.$rootScope && this.$rootScope.$digest();\r\n    }\r\n\r\n    function successFn(response, data, status, headers, xconfig, statusText) {\r\n      // HACK: because $http returns a server side null as a string containing \"null\" - this is WRONG.\r\n        if (response.data === \"null\") response.data = null;\r\n      var httpResponse = {\r\n        config: config,\r\n        data: response.data,\r\n        getHeaders: response.headers,\r\n        ngConfig: response.config,\r\n        status: response.status,\r\n        statusText: response.statusText\r\n      };\r\n      config.success(httpResponse);\r\n    }\r\n\r\n    function errorFn(response, data, status, headers, xconfig, statusText) {\r\n      // Timeout appears as an error with status===0 and no data.\r\n      // Make it better\r\n      if (response.status === 0 && response.data == null) {\r\n        response.data = 'timeout';\r\n      }\r\n      var httpResponse = {\r\n        config: config,\r\n        data: response.data,\r\n        getHeaders: response.headers,\r\n        ngConfig: response.config,\r\n        status: response.status,\r\n        statusText: response.statusText\r\n      };\r\n      config.error(httpResponse);\r\n    }\r\n"}}
{"actor":{"display_login":"Blarm1959"}}