{"action":"opened","number":105,"pull_request":{"url":"https://api.github.com/repos/php-cache/cache/pulls/105","id":91936507,"html_url":"https://github.com/php-cache/cache/pull/105","diff_url":"https://github.com/php-cache/cache/pull/105.diff","patch_url":"https://github.com/php-cache/cache/pull/105.patch","issue_url":"https://api.github.com/repos/php-cache/cache/issues/105","number":105,"state":"open","locked":false,"title":"Make the cache key safe to use as a file name","user":{"login":"guyradford","id":2640704,"avatar_url":"https://avatars.githubusercontent.com/u/2640704?v=3","gravatar_id":"","url":"https://api.github.com/users/guyradford","html_url":"https://github.com/guyradford","followers_url":"https://api.github.com/users/guyradford/followers","following_url":"https://api.github.com/users/guyradford/following{/other_user}","gists_url":"https://api.github.com/users/guyradford/gists{/gist_id}","starred_url":"https://api.github.com/users/guyradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyradford/subscriptions","organizations_url":"https://api.github.com/users/guyradford/orgs","repos_url":"https://api.github.com/users/guyradford/repos","events_url":"https://api.github.com/users/guyradford/events{/privacy}","received_events_url":"https://api.github.com/users/guyradford/received_events","type":"User","site_admin":false},"body":"| Question      | Answer\r\n| ------------- | ------\r\n| Bug fix?      | yes\r\n| New feature?  |no\r\n| BC breaks?    |no (only if cache not cleared)\r\n| Deprecations? |no\r\n| Tests pass?   | yes\r\n| Fixed tickets | NA\r\n| License       | MIT\r\n| Doc PR        | reference to the documentation PR, if any\r\n\r\n### Description\r\n\r\nSome cache keys could not be used with the fileSystem adapter as they where not valid filenames. To solve this I base64 encoded the cache key and replaced = with _ to make a valid filename.\r\n\r\n\r\n### TODO\r\n* [ ] Add tests\r\n* [ ] Add documentation\r\n* [ X ] Updated Changelog.md\r\n\r\n","created_at":"2016-11-02T09:43:30Z","updated_at":"2016-11-02T09:43:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-cache/cache/pulls/105/commits","review_comments_url":"https://api.github.com/repos/php-cache/cache/pulls/105/comments","review_comment_url":"https://api.github.com/repos/php-cache/cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-cache/cache/issues/105/comments","statuses_url":"https://api.github.com/repos/php-cache/cache/statuses/2fc73d3a42b2541eceb06fd7e521e6b7bec517ac","head":{"label":"guyradford:fix-filename-from-cache-key","ref":"fix-filename-from-cache-key","sha":"2fc73d3a42b2541eceb06fd7e521e6b7bec517ac","user":{"login":"guyradford","id":2640704,"avatar_url":"https://avatars.githubusercontent.com/u/2640704?v=3","gravatar_id":"","url":"https://api.github.com/users/guyradford","html_url":"https://github.com/guyradford","followers_url":"https://api.github.com/users/guyradford/followers","following_url":"https://api.github.com/users/guyradford/following{/other_user}","gists_url":"https://api.github.com/users/guyradford/gists{/gist_id}","starred_url":"https://api.github.com/users/guyradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyradford/subscriptions","organizations_url":"https://api.github.com/users/guyradford/orgs","repos_url":"https://api.github.com/users/guyradford/repos","events_url":"https://api.github.com/users/guyradford/events{/privacy}","received_events_url":"https://api.github.com/users/guyradford/received_events","type":"User","site_admin":false},"repo":{"id":72622078,"name":"cache","full_name":"guyradford/cache","owner":{"login":"guyradford","id":2640704,"avatar_url":"https://avatars.githubusercontent.com/u/2640704?v=3","gravatar_id":"","url":"https://api.github.com/users/guyradford","html_url":"https://github.com/guyradford","followers_url":"https://api.github.com/users/guyradford/followers","following_url":"https://api.github.com/users/guyradford/following{/other_user}","gists_url":"https://api.github.com/users/guyradford/gists{/gist_id}","starred_url":"https://api.github.com/users/guyradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyradford/subscriptions","organizations_url":"https://api.github.com/users/guyradford/orgs","repos_url":"https://api.github.com/users/guyradford/repos","events_url":"https://api.github.com/users/guyradford/events{/privacy}","received_events_url":"https://api.github.com/users/guyradford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guyradford/cache","description":"This is the main repository for all our cache adapters","fork":true,"url":"https://api.github.com/repos/guyradford/cache","forks_url":"https://api.github.com/repos/guyradford/cache/forks","keys_url":"https://api.github.com/repos/guyradford/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guyradford/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guyradford/cache/teams","hooks_url":"https://api.github.com/repos/guyradford/cache/hooks","issue_events_url":"https://api.github.com/repos/guyradford/cache/issues/events{/number}","events_url":"https://api.github.com/repos/guyradford/cache/events","assignees_url":"https://api.github.com/repos/guyradford/cache/assignees{/user}","branches_url":"https://api.github.com/repos/guyradford/cache/branches{/branch}","tags_url":"https://api.github.com/repos/guyradford/cache/tags","blobs_url":"https://api.github.com/repos/guyradford/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guyradford/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guyradford/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/guyradford/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guyradford/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/guyradford/cache/languages","stargazers_url":"https://api.github.com/repos/guyradford/cache/stargazers","contributors_url":"https://api.github.com/repos/guyradford/cache/contributors","subscribers_url":"https://api.github.com/repos/guyradford/cache/subscribers","subscription_url":"https://api.github.com/repos/guyradford/cache/subscription","commits_url":"https://api.github.com/repos/guyradford/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/guyradford/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/guyradford/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/guyradford/cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/guyradford/cache/contents/{+path}","compare_url":"https://api.github.com/repos/guyradford/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guyradford/cache/merges","archive_url":"https://api.github.com/repos/guyradford/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guyradford/cache/downloads","issues_url":"https://api.github.com/repos/guyradford/cache/issues{/number}","pulls_url":"https://api.github.com/repos/guyradford/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/guyradford/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/guyradford/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guyradford/cache/labels{/name}","releases_url":"https://api.github.com/repos/guyradford/cache/releases{/id}","deployments_url":"https://api.github.com/repos/guyradford/cache/deployments","created_at":"2016-11-02T09:02:59Z","updated_at":"2016-11-02T09:03:01Z","pushed_at":"2016-11-02T09:40:23Z","git_url":"git://github.com/guyradford/cache.git","ssh_url":"git@github.com:guyradford/cache.git","clone_url":"https://github.com/guyradford/cache.git","svn_url":"https://github.com/guyradford/cache","homepage":"http://www.php-cache.com","size":399,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-cache:master","ref":"master","sha":"d0dbf2df0d95f36ae3764142a313ee1bea78f6ee","user":{"login":"php-cache","id":16170857,"avatar_url":"https://avatars.githubusercontent.com/u/16170857?v=3","gravatar_id":"","url":"https://api.github.com/users/php-cache","html_url":"https://github.com/php-cache","followers_url":"https://api.github.com/users/php-cache/followers","following_url":"https://api.github.com/users/php-cache/following{/other_user}","gists_url":"https://api.github.com/users/php-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/php-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-cache/subscriptions","organizations_url":"https://api.github.com/users/php-cache/orgs","repos_url":"https://api.github.com/users/php-cache/repos","events_url":"https://api.github.com/users/php-cache/events{/privacy}","received_events_url":"https://api.github.com/users/php-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":50789153,"name":"cache","full_name":"php-cache/cache","owner":{"login":"php-cache","id":16170857,"avatar_url":"https://avatars.githubusercontent.com/u/16170857?v=3","gravatar_id":"","url":"https://api.github.com/users/php-cache","html_url":"https://github.com/php-cache","followers_url":"https://api.github.com/users/php-cache/followers","following_url":"https://api.github.com/users/php-cache/following{/other_user}","gists_url":"https://api.github.com/users/php-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/php-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-cache/subscriptions","organizations_url":"https://api.github.com/users/php-cache/orgs","repos_url":"https://api.github.com/users/php-cache/repos","events_url":"https://api.github.com/users/php-cache/events{/privacy}","received_events_url":"https://api.github.com/users/php-cache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-cache/cache","description":"This is the main repository for all our cache adapters","fork":false,"url":"https://api.github.com/repos/php-cache/cache","forks_url":"https://api.github.com/repos/php-cache/cache/forks","keys_url":"https://api.github.com/repos/php-cache/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-cache/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-cache/cache/teams","hooks_url":"https://api.github.com/repos/php-cache/cache/hooks","issue_events_url":"https://api.github.com/repos/php-cache/cache/issues/events{/number}","events_url":"https://api.github.com/repos/php-cache/cache/events","assignees_url":"https://api.github.com/repos/php-cache/cache/assignees{/user}","branches_url":"https://api.github.com/repos/php-cache/cache/branches{/branch}","tags_url":"https://api.github.com/repos/php-cache/cache/tags","blobs_url":"https://api.github.com/repos/php-cache/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-cache/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-cache/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-cache/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-cache/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/php-cache/cache/languages","stargazers_url":"https://api.github.com/repos/php-cache/cache/stargazers","contributors_url":"https://api.github.com/repos/php-cache/cache/contributors","subscribers_url":"https://api.github.com/repos/php-cache/cache/subscribers","subscription_url":"https://api.github.com/repos/php-cache/cache/subscription","commits_url":"https://api.github.com/repos/php-cache/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-cache/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-cache/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-cache/cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-cache/cache/contents/{+path}","compare_url":"https://api.github.com/repos/php-cache/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-cache/cache/merges","archive_url":"https://api.github.com/repos/php-cache/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-cache/cache/downloads","issues_url":"https://api.github.com/repos/php-cache/cache/issues{/number}","pulls_url":"https://api.github.com/repos/php-cache/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/php-cache/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/php-cache/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-cache/cache/labels{/name}","releases_url":"https://api.github.com/repos/php-cache/cache/releases{/id}","deployments_url":"https://api.github.com/repos/php-cache/cache/deployments","created_at":"2016-01-31T18:42:57Z","updated_at":"2016-10-28T04:59:16Z","pushed_at":"2016-10-19T19:12:20Z","git_url":"git://github.com/php-cache/cache.git","ssh_url":"git@github.com:php-cache/cache.git","clone_url":"https://github.com/php-cache/cache.git","svn_url":"https://github.com/php-cache/cache","homepage":"http://www.php-cache.com","size":399,"stargazers_count":59,"watchers_count":59,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-cache/cache/pulls/105"},"html":{"href":"https://github.com/php-cache/cache/pull/105"},"issue":{"href":"https://api.github.com/repos/php-cache/cache/issues/105"},"comments":{"href":"https://api.github.com/repos/php-cache/cache/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/php-cache/cache/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/php-cache/cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-cache/cache/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/php-cache/cache/statuses/2fc73d3a42b2541eceb06fd7e521e6b7bec517ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"guyradford"}}