{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871","id":184559717,"number":871,"title":"Enable configuring service port for local run","user":{"login":"chanseokoh","id":10523105,"avatar_url":"https://avatars.githubusercontent.com/u/10523105?v=3","gravatar_id":"","url":"https://api.github.com/users/chanseokoh","html_url":"https://github.com/chanseokoh","followers_url":"https://api.github.com/users/chanseokoh/followers","following_url":"https://api.github.com/users/chanseokoh/following{/other_user}","gists_url":"https://api.github.com/users/chanseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/chanseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanseokoh/subscriptions","organizations_url":"https://api.github.com/users/chanseokoh/orgs","repos_url":"https://api.github.com/users/chanseokoh/repos","events_url":"https://api.github.com/users/chanseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/chanseokoh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-21T20:16:53Z","updated_at":"2016-10-24T15:51:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871.patch"},"body":"The server port field (spinner) is placed below the runtime environment combo. That's practically the only place we can add this field. This spinner is dynamically shown/hide as you change the server type to/from our App Engine Server.\r\n\r\n![new server _009](https://cloud.githubusercontent.com/assets/10523105/19604848/0b9578e6-9785-11e6-9bf9-375e4b16a1ef.png)\r\n\r\nOne minor problem: the new spinner makes the server selection box even smaller on my machine, to the point that it looks like a single-line text box. I can still clearly see our \"App Engine Standard\" server though.\r\n\r\nLastly, I removed `<useUIThread>false</useUIThread>` (which will set it to true by default) in `pom.xml` to make tests work. Tests can't access `Display` or `Shell` when they are run in a background thread."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/comments/255781186","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871#issuecomment-255781186","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871","id":255781186,"user":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars.githubusercontent.com/u/202851?v=3","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T15:51:58Z","updated_at":"2016-10-24T15:51:58Z","body":"> Even if we can't, I think showing an error message basically addresses this issue.\r\n\r\nI suggested to @chanseokoh that he could show a popup/hover to say _Ports must be 0-65535_.  JFace provides some easy support for that using `org.eclipse.jface.fieldassist.ControlDecoration` (`showHoverText()`)."}}
{"actor":{"display_login":"briandealwis"}}