{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/224","repository_url":"https://api.github.com/repos/facebook/react-native-fbsdk","labels_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/224/comments","events_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/224/events","html_url":"https://github.com/facebook/react-native-fbsdk/pull/224","id":162299060,"number":224,"title":"Add missing enumerations for FBSDKShareDialogMode","user":{"login":"4ian","id":1280130,"avatar_url":"https://avatars.githubusercontent.com/u/1280130?v=3","gravatar_id":"","url":"https://api.github.com/users/4ian","html_url":"https://github.com/4ian","followers_url":"https://api.github.com/users/4ian/followers","following_url":"https://api.github.com/users/4ian/following{/other_user}","gists_url":"https://api.github.com/users/4ian/gists{/gist_id}","starred_url":"https://api.github.com/users/4ian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4ian/subscriptions","organizations_url":"https://api.github.com/users/4ian/orgs","repos_url":"https://api.github.com/users/4ian/repos","events_url":"https://api.github.com/users/4ian/events{/privacy}","received_events_url":"https://api.github.com/users/4ian/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native-fbsdk/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-25T20:50:43Z","updated_at":"2016-07-15T14:15:47Z","closed_at":"2016-06-28T00:11:35Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native-fbsdk/pulls/224","html_url":"https://github.com/facebook/react-native-fbsdk/pull/224","diff_url":"https://github.com/facebook/react-native-fbsdk/pull/224.diff","patch_url":"https://github.com/facebook/react-native-fbsdk/pull/224.patch"},"body":"Hey guys,\r\n\r\nIt seems that not all modes for the `FBSDKShareDialog` are being exposed in `RCTFBSDKShareDialog.m`. That's strange because I was using `react-native-fbsdkshare` and these modes were properly exported (I rely on `feed-web` for an application).\r\n\r\nIs there any reason why it's not the case anymore?\r\nThis PR updates the converter for `FBSDKShareDialogMode` to expose the enum as done previously by `react-native-fbsdkshare`, following [this Facebook documentation](https://developers.facebook.com/docs/reference/ios/current/constants/FBSDKShareDialogMode/)."},"comment":{"url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/comments/232962293","html_url":"https://github.com/facebook/react-native-fbsdk/pull/224#issuecomment-232962293","issue_url":"https://api.github.com/repos/facebook/react-native-fbsdk/issues/224","id":232962293,"user":{"login":"tychota","id":13785185,"avatar_url":"https://avatars.githubusercontent.com/u/13785185?v=3","gravatar_id":"","url":"https://api.github.com/users/tychota","html_url":"https://github.com/tychota","followers_url":"https://api.github.com/users/tychota/followers","following_url":"https://api.github.com/users/tychota/following{/other_user}","gists_url":"https://api.github.com/users/tychota/gists{/gist_id}","starred_url":"https://api.github.com/users/tychota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tychota/subscriptions","organizations_url":"https://api.github.com/users/tychota/orgs","repos_url":"https://api.github.com/users/tychota/repos","events_url":"https://api.github.com/users/tychota/events{/privacy}","received_events_url":"https://api.github.com/users/tychota/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T14:15:47Z","updated_at":"2016-07-15T14:15:47Z","body":"@dzhuowen can you give us more infos why this PR that make the code match [the documentation](https://developers.facebook.com/docs/reference/ios/current/constants/FBSDKShareDialogMode/) was refused.\r\n\r\nMy root problem is that the exposed modes fail to share a link *and* an image.\r\nMore information here http://stackoverflow.com/a/33152056.\r\n\r\nThus `feed-web` seems to be the right solution.\r\n\r\nIf you want, I can open an other issue to have the stackoverflow problem explained.\r\n\r\n> However you can still use the feed-web mode if you prefer.\r\n\r\nIs it possible without the mode exposed ?\r\n"}}
{"actor":{"display_login":"tychota"}}