{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/3444","repository_url":"https://api.github.com/repos/Particular/NServiceBus","labels_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3444/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3444/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3444/events","html_url":"https://github.com/Particular/NServiceBus/pull/3444","id":132652560,"number":3444,"title":"[WIP] Making the factory method for serializer public","user":{"login":"andreasohlund","id":125028,"avatar_url":"https://avatars.githubusercontent.com/u/125028?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasohlund","html_url":"https://github.com/andreasohlund","followers_url":"https://api.github.com/users/andreasohlund/followers","following_url":"https://api.github.com/users/andreasohlund/following{/other_user}","gists_url":"https://api.github.com/users/andreasohlund/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasohlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasohlund/subscriptions","organizations_url":"https://api.github.com/users/andreasohlund/orgs","repos_url":"https://api.github.com/users/andreasohlund/repos","events_url":"https://api.github.com/users/andreasohlund/events{/privacy}","received_events_url":"https://api.github.com/users/andreasohlund/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Particular/NServiceBus/labels/State:%20In%20Progress","name":"State: In Progress","color":"ededed"},{"url":"https://api.github.com/repos/Particular/NServiceBus/labels/Tag:%20Core%20v6","name":"Tag: Core v6","color":"ffff00"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-02-10T09:56:10Z","updated_at":"2016-02-10T12:05:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3444","html_url":"https://github.com/Particular/NServiceBus/pull/3444","diff_url":"https://github.com/Particular/NServiceBus/pull/3444.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3444.patch"},"body":"After a call with @SimonCropp @indualagarsamy and @timbussmann we decided to make this trade off. It adds no new public types since the mapper and `IMessageSerializer` is already public. \r\n\r\nThis will:\r\n\r\n* allow our serializer sample to work\r\n* provides a way to give users a chance to migrate away from using our serializers (upgrade guide)\r\n* allows users on the ASQ transport that has selected XML in the past to be wire compatible without copy pasting the custom XmlSerializer\r\n\r\n\r\nNOTE:\r\n\r\nThe ASQ transport/heartbeats/etc should still go ahead as planned and not reuse any core serializers since we want to get rid of that dependency. This is only for user consumption in v6. We'll discuss the removal of this api in v7.\r\n\r\n\r\n### Todo\r\n\r\n- [ ] Doco pull once we agree on this (upgrade guide)\r\n- [ ] WIP pulls for external serializers if needed\r\n"},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments/182336573","html_url":"https://github.com/Particular/NServiceBus/pull/3444#issuecomment-182336573","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3444","id":182336573,"user":{"login":"andreasohlund","id":125028,"avatar_url":"https://avatars.githubusercontent.com/u/125028?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasohlund","html_url":"https://github.com/andreasohlund","followers_url":"https://api.github.com/users/andreasohlund/followers","following_url":"https://api.github.com/users/andreasohlund/following{/other_user}","gists_url":"https://api.github.com/users/andreasohlund/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasohlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasohlund/subscriptions","organizations_url":"https://api.github.com/users/andreasohlund/orgs","repos_url":"https://api.github.com/users/andreasohlund/repos","events_url":"https://api.github.com/users/andreasohlund/events{/privacy}","received_events_url":"https://api.github.com/users/andreasohlund/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T12:05:43Z","updated_at":"2016-02-10T12:05:43Z","body":">This is a fair tradeoff. Can we create a new issue which captures the discussions and future plans for vNext?\r\n\r\nWill do when we pull this in"}}