{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/comments/63066423","id":63066423,"diff_hunk":"@@ -94,6 +104,17 @@\n   $middleware_ssl_cert_path = \"${ssldir}/middleware_cert.pem\"\n   $middleware_ssl_ca_path   = \"${ssldir}/middleware_ca.pem\"\n \n+  if $securityprovider == 'sshkey' {\n+    package{'sshkeyauth':\n+      ensure   =>  $sshkeyauth_gem_version,\n+      provider =>  'puppet_gem',","path":"manifests/init.pp","position":37,"original_position":37,"commit_id":"0aee6968430a066c85661faff6affb1396a226ca","original_commit_id":"0aee6968430a066c85661faff6affb1396a226ca","user":{"login":"hunner","id":91972,"avatar_url":"https://avatars.githubusercontent.com/u/91972?v=3","gravatar_id":"","url":"https://api.github.com/users/hunner","html_url":"https://github.com/hunner","followers_url":"https://api.github.com/users/hunner/followers","following_url":"https://api.github.com/users/hunner/following{/other_user}","gists_url":"https://api.github.com/users/hunner/gists{/gist_id}","starred_url":"https://api.github.com/users/hunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunner/subscriptions","organizations_url":"https://api.github.com/users/hunner/orgs","repos_url":"https://api.github.com/users/hunner/repos","events_url":"https://api.github.com/users/hunner/events{/privacy}","received_events_url":"https://api.github.com/users/hunner/received_events","type":"User","site_admin":false},"body":"These have an extra space after the `=>`","created_at":"2016-05-12T17:55:21Z","updated_at":"2016-05-12T17:55:21Z","html_url":"https://github.com/voxpupuli/puppet-mcollective/pull/282#discussion_r63066423","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/comments/63066423"},"html":{"href":"https://github.com/voxpupuli/puppet-mcollective/pull/282#discussion_r63066423"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282","id":57877229,"html_url":"https://github.com/voxpupuli/puppet-mcollective/pull/282","diff_url":"https://github.com/voxpupuli/puppet-mcollective/pull/282.diff","patch_url":"https://github.com/voxpupuli/puppet-mcollective/pull/282.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/issues/282","number":282,"state":"open","locked":false,"title":"Add sshkey securityprovider support","user":{"login":"jhg03a","id":4870549,"avatar_url":"https://avatars.githubusercontent.com/u/4870549?v=3","gravatar_id":"","url":"https://api.github.com/users/jhg03a","html_url":"https://github.com/jhg03a","followers_url":"https://api.github.com/users/jhg03a/followers","following_url":"https://api.github.com/users/jhg03a/following{/other_user}","gists_url":"https://api.github.com/users/jhg03a/gists{/gist_id}","starred_url":"https://api.github.com/users/jhg03a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhg03a/subscriptions","organizations_url":"https://api.github.com/users/jhg03a/orgs","repos_url":"https://api.github.com/users/jhg03a/repos","events_url":"https://api.github.com/users/jhg03a/events{/privacy}","received_events_url":"https://api.github.com/users/jhg03a/received_events","type":"User","site_admin":false},"body":"I've added support and loose documentation on getting this module to support the sshkey securityprovider plugin for mcollective in addition to ssl.  Due to time constraints and knowledge limitations, I can't provide tests at this time.  However this is pulled from my running puppet 4 environment.  Comments and tests are welcome.\r\n\r\nThere is also a small benefit for the ssl plugin in that you can now also provide the user key+cert parameters by content instead of source which would be helpful for hiera-eyaml.","created_at":"2016-02-01T18:09:35Z","updated_at":"2016-05-12T17:55:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd61047d2adb18aad330dc6b89bf99938c8ae37f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/issues/282/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/statuses/0aee6968430a066c85661faff6affb1396a226ca","head":{"label":"jhg03a:sshkey.enhancement.cleanup","ref":"sshkey.enhancement.cleanup","sha":"0aee6968430a066c85661faff6affb1396a226ca","user":{"login":"jhg03a","id":4870549,"avatar_url":"https://avatars.githubusercontent.com/u/4870549?v=3","gravatar_id":"","url":"https://api.github.com/users/jhg03a","html_url":"https://github.com/jhg03a","followers_url":"https://api.github.com/users/jhg03a/followers","following_url":"https://api.github.com/users/jhg03a/following{/other_user}","gists_url":"https://api.github.com/users/jhg03a/gists{/gist_id}","starred_url":"https://api.github.com/users/jhg03a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhg03a/subscriptions","organizations_url":"https://api.github.com/users/jhg03a/orgs","repos_url":"https://api.github.com/users/jhg03a/repos","events_url":"https://api.github.com/users/jhg03a/events{/privacy}","received_events_url":"https://api.github.com/users/jhg03a/received_events","type":"User","site_admin":false},"repo":{"id":50677201,"name":"puppet-mcollective-1","full_name":"jhg03a/puppet-mcollective-1","owner":{"login":"jhg03a","id":4870549,"avatar_url":"https://avatars.githubusercontent.com/u/4870549?v=3","gravatar_id":"","url":"https://api.github.com/users/jhg03a","html_url":"https://github.com/jhg03a","followers_url":"https://api.github.com/users/jhg03a/followers","following_url":"https://api.github.com/users/jhg03a/following{/other_user}","gists_url":"https://api.github.com/users/jhg03a/gists{/gist_id}","starred_url":"https://api.github.com/users/jhg03a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhg03a/subscriptions","organizations_url":"https://api.github.com/users/jhg03a/orgs","repos_url":"https://api.github.com/users/jhg03a/repos","events_url":"https://api.github.com/users/jhg03a/events{/privacy}","received_events_url":"https://api.github.com/users/jhg03a/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhg03a/puppet-mcollective-1","description":"MCollective Server and Client Puppet Module","fork":true,"url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1","forks_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/forks","keys_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/teams","hooks_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/hooks","issue_events_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/issues/events{/number}","events_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/events","assignees_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/assignees{/user}","branches_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/branches{/branch}","tags_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/tags","blobs_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/statuses/{sha}","languages_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/languages","stargazers_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/stargazers","contributors_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/contributors","subscribers_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/subscribers","subscription_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/subscription","commits_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/contents/{+path}","compare_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/merges","archive_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/downloads","issues_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/issues{/number}","pulls_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/pulls{/number}","milestones_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/milestones{/number}","notifications_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/labels{/name}","releases_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/releases{/id}","deployments_url":"https://api.github.com/repos/jhg03a/puppet-mcollective-1/deployments","created_at":"2016-01-29T17:01:57Z","updated_at":"2016-01-29T17:01:57Z","pushed_at":"2016-03-12T00:26:14Z","git_url":"git://github.com/jhg03a/puppet-mcollective-1.git","ssh_url":"git@github.com:jhg03a/puppet-mcollective-1.git","clone_url":"https://github.com/jhg03a/puppet-mcollective-1.git","svn_url":"https://github.com/jhg03a/puppet-mcollective-1","homepage":"https://forge.puppetlabs.com/puppet/mcollective","size":468,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"78af8d80aea83b633aa413871a924514e10d3286","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":1522671,"name":"puppet-mcollective","full_name":"voxpupuli/puppet-mcollective","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-mcollective","description":"MCollective Server and Client Puppet Module","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-mcollective","forks_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-mcollective/deployments","created_at":"2011-03-24T20:18:16Z","updated_at":"2016-05-12T13:52:32Z","pushed_at":"2016-05-05T19:21:32Z","git_url":"git://github.com/voxpupuli/puppet-mcollective.git","ssh_url":"git@github.com:voxpupuli/puppet-mcollective.git","clone_url":"https://github.com/voxpupuli/puppet-mcollective.git","svn_url":"https://github.com/voxpupuli/puppet-mcollective","homepage":"https://forge.puppetlabs.com/puppet/mcollective","size":792,"stargazers_count":118,"watchers_count":118,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":18,"forks":194,"open_issues":18,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282"},"html":{"href":"https://github.com/voxpupuli/puppet-mcollective/pull/282"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/issues/282"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-mcollective/statuses/0aee6968430a066c85661faff6affb1396a226ca"}}}}