{"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/comments/70919250","id":70919250,"diff_hunk":"@@ -4,19 +4,27 @@ import Prelude\n import Control.Apply ((*>))\n import Control.Alt ((<|>))\n import Control.Monad.Aff.AVar (makeVar', takeVar, putVar, AVar(), AVAR())\n-import Control.Monad.Aff.Par (Par(..), runPar)\n-import Control.Monad.Aff (attempt, later, later', launchAff, Aff())\n-import Control.Monad.Eff.Class (liftEff)\n-import Control.Monad.Error.Class (catchError)\n+import Control.Monad.Aff (attempt, later, later', Aff)\n+import Control.Monad.Eff (Eff)\n+import Control.Monad.Eff.Ref (REF)\n+import Control.Monad.Eff.Console (CONSOLE)\n+import Control.Parallel.Class (parallel, runParallel)\n import Control.Plus (empty)\n-import Data.Either (Either(..), either)\n+import Data.Either as Either\n import Data.Functor (($>))\n import Data.Maybe (maybe, fromMaybe)\n-import Data.Array (replicate, head, tail)\n-import Test.Unit (runTest, test, assertFn)\n+import Data.Array (head, tail)\n+import Data.Unfoldable (replicate)\n+import Test.Unit (test, suite)\n+import Test.Unit.Assert (assert)\n+import Test.Unit.Console (TESTOUTPUT)\n+import Test.Unit.Main (runTest)\n \n import Control.Monad.Aff.Reattempt (reattempt)\n \n+ignore :: forall m a. Monad m => m a -> m Unit\n+ignore m = m >>= (\\_ -> pure unit)","path":"test/Main.purs","position":30,"original_position":30,"commit_id":"249a49bbbdffdf31ec70ec3e2e0458e1a7a84084","original_commit_id":"249a49bbbdffdf31ec70ec3e2e0458e1a7a84084","user":{"login":"cprichmond","id":4999963,"avatar_url":"https://avatars.githubusercontent.com/u/4999963?v=3","gravatar_id":"","url":"https://api.github.com/users/cprichmond","html_url":"https://github.com/cprichmond","followers_url":"https://api.github.com/users/cprichmond/followers","following_url":"https://api.github.com/users/cprichmond/following{/other_user}","gists_url":"https://api.github.com/users/cprichmond/gists{/gist_id}","starred_url":"https://api.github.com/users/cprichmond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprichmond/subscriptions","organizations_url":"https://api.github.com/users/cprichmond/orgs","repos_url":"https://api.github.com/users/cprichmond/repos","events_url":"https://api.github.com/users/cprichmond/events{/privacy}","received_events_url":"https://api.github.com/users/cprichmond/received_events","type":"User","site_admin":false},"body":"I tried to ignore this but couldn't... where is it used?","created_at":"2016-07-15T04:08:02Z","updated_at":"2016-07-15T04:08:02Z","html_url":"https://github.com/slamdata/purescript-aff-reattempt/pull/13#discussion_r70919250","pull_request_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/comments/70919250"},"html":{"href":"https://github.com/slamdata/purescript-aff-reattempt/pull/13#discussion_r70919250"},"pull_request":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13","id":77555949,"html_url":"https://github.com/slamdata/purescript-aff-reattempt/pull/13","diff_url":"https://github.com/slamdata/purescript-aff-reattempt/pull/13.diff","patch_url":"https://github.com/slamdata/purescript-aff-reattempt/pull/13.patch","issue_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/issues/13","number":13,"state":"open","locked":false,"title":"Upgraded project to PureScript v0.9.1","user":{"login":"daniel-chambers","id":1214352,"avatar_url":"https://avatars.githubusercontent.com/u/1214352?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-chambers","html_url":"https://github.com/daniel-chambers","followers_url":"https://api.github.com/users/daniel-chambers/followers","following_url":"https://api.github.com/users/daniel-chambers/following{/other_user}","gists_url":"https://api.github.com/users/daniel-chambers/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-chambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-chambers/subscriptions","organizations_url":"https://api.github.com/users/daniel-chambers/orgs","repos_url":"https://api.github.com/users/daniel-chambers/repos","events_url":"https://api.github.com/users/daniel-chambers/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-chambers/received_events","type":"User","site_admin":false},"body":"We're looking to use purescript-webdriver in our project; but our project is using PureScript 0.9. This project is a dependency of purescript-webdriver, which I'm also looking at upgrading to PureScript 0.9 if I can. So I've first upgraded this project to PureScript 0.9 and upgraded its dependent libraries to the latest version which are compatible with 0.9.\r\n\r\nThe biggest change is in the unit tests which have been restructured to use the latest purescript-test-unit, which now has direct support for tests in `Aff`. Parallel types were also moved into purescript-parallel, so I switched the tests to use those.\r\n\r\nI also added bower as a dev dependency, as I required it to install the dependent packages. I assume you guys must have it globally installed, but I try to avoid implicit global installation of packages where possible; hence me adding it as a dev dependency. Happy to revert that bit if you don't like it.","created_at":"2016-07-15T02:43:00Z","updated_at":"2016-07-15T04:08:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd7684bf8a77474a2648f66dfca0240c2b91a082","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13/commits","review_comments_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13/comments","review_comment_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/issues/13/comments","statuses_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/statuses/249a49bbbdffdf31ec70ec3e2e0458e1a7a84084","head":{"label":"daniel-chambers:ps-0.9-upgrade","ref":"ps-0.9-upgrade","sha":"249a49bbbdffdf31ec70ec3e2e0458e1a7a84084","user":{"login":"daniel-chambers","id":1214352,"avatar_url":"https://avatars.githubusercontent.com/u/1214352?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-chambers","html_url":"https://github.com/daniel-chambers","followers_url":"https://api.github.com/users/daniel-chambers/followers","following_url":"https://api.github.com/users/daniel-chambers/following{/other_user}","gists_url":"https://api.github.com/users/daniel-chambers/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-chambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-chambers/subscriptions","organizations_url":"https://api.github.com/users/daniel-chambers/orgs","repos_url":"https://api.github.com/users/daniel-chambers/repos","events_url":"https://api.github.com/users/daniel-chambers/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-chambers/received_events","type":"User","site_admin":false},"repo":{"id":63384744,"name":"purescript-aff-reattempt","full_name":"daniel-chambers/purescript-aff-reattempt","owner":{"login":"daniel-chambers","id":1214352,"avatar_url":"https://avatars.githubusercontent.com/u/1214352?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-chambers","html_url":"https://github.com/daniel-chambers","followers_url":"https://api.github.com/users/daniel-chambers/followers","following_url":"https://api.github.com/users/daniel-chambers/following{/other_user}","gists_url":"https://api.github.com/users/daniel-chambers/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-chambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-chambers/subscriptions","organizations_url":"https://api.github.com/users/daniel-chambers/orgs","repos_url":"https://api.github.com/users/daniel-chambers/repos","events_url":"https://api.github.com/users/daniel-chambers/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-chambers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-chambers/purescript-aff-reattempt","description":"A library for reattempting asynchronous computations","fork":true,"url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt","forks_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/forks","keys_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/teams","hooks_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/hooks","issue_events_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/events","assignees_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/tags","blobs_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/languages","stargazers_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/stargazers","contributors_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/contributors","subscribers_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/subscribers","subscription_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/subscription","commits_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/merges","archive_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/downloads","issues_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/labels{/name}","releases_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-chambers/purescript-aff-reattempt/deployments","created_at":"2016-07-15T02:25:34Z","updated_at":"2016-07-15T02:25:35Z","pushed_at":"2016-07-15T02:28:06Z","git_url":"git://github.com/daniel-chambers/purescript-aff-reattempt.git","ssh_url":"git@github.com:daniel-chambers/purescript-aff-reattempt.git","clone_url":"https://github.com/daniel-chambers/purescript-aff-reattempt.git","svn_url":"https://github.com/daniel-chambers/purescript-aff-reattempt","homepage":"","size":14,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slamdata:master","ref":"master","sha":"09d2b47c17664506c6562c721e6a7a0113c3c924","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":42550150,"name":"purescript-aff-reattempt","full_name":"slamdata/purescript-aff-reattempt","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/purescript-aff-reattempt","description":"A library for reattempting asynchronous computations","fork":false,"url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt","forks_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/forks","keys_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/teams","hooks_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/hooks","issue_events_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/events","assignees_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/tags","blobs_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/languages","stargazers_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/stargazers","contributors_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/contributors","subscribers_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/subscribers","subscription_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/subscription","commits_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/issues/comments{/number}","contents_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/merges","archive_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/downloads","issues_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/releases{/id}","deployments_url":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/deployments","created_at":"2015-09-15T22:23:50Z","updated_at":"2016-02-24T21:25:48Z","pushed_at":"2016-07-15T02:43:00Z","git_url":"git://github.com/slamdata/purescript-aff-reattempt.git","ssh_url":"git@github.com:slamdata/purescript-aff-reattempt.git","clone_url":"https://github.com/slamdata/purescript-aff-reattempt.git","svn_url":"https://github.com/slamdata/purescript-aff-reattempt","homepage":"","size":13,"stargazers_count":3,"watchers_count":3,"language":"PureScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13"},"html":{"href":"https://github.com/slamdata/purescript-aff-reattempt/pull/13"},"issue":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/issues/13"},"comments":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/purescript-aff-reattempt/statuses/249a49bbbdffdf31ec70ec3e2e0458e1a7a84084"}}}}
{"actor":{"display_login":"cprichmond"}}