{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/72467977","id":72467977,"diff_hunk":"@@ -471,13 +472,21 @@ def spec_is_platform_compatible?(dependency_graph, dependency, spec)\n     #         An array of target-appropriate nodes whose `payload`s are\n     #         dependencies for `target`.\n     #\n-    def valid_dependencies_for_target_from_node(target, node)\n-      validate_platform(node.payload, target)\n-      dependency_nodes = node.outgoing_edges.select do |edge|\n-        edge_is_valid_for_target?(edge, target)\n-      end.map(&:destination)\n+    def valid_dependencies_for_target_from_node(target, dependencies, node)\n+      dependencies[node.name] ||= begin\n+        validate_platform(node.payload, target)\n+        dependency_nodes = node.outgoing_edges.select do |edge|\n+          edge_is_valid_for_target?(edge, target)\n+        end.map(&:destination)\n \n-      dependency_nodes + dependency_nodes.flat_map { |n| valid_dependencies_for_target_from_node(target, n) }\n+        dependency_nodes + dependency_nodes.flat_map do |item|\n+          node_result = valid_dependencies_for_target_from_node(target, dependencies, item)\n+\n+          node_result\n+        end\n+      end\n+\n+      dependencies[node.name]","path":"lib/cocoapods/resolver.rb","position":36,"original_position":36,"commit_id":"859dad72155ab62dc895fbd8d61dd874e090e73b","original_commit_id":"859dad72155ab62dc895fbd8d61dd874e090e73b","user":{"login":"segiddins","id":1946610,"avatar_url":"https://avatars.githubusercontent.com/u/1946610?v=3","gravatar_id":"","url":"https://api.github.com/users/segiddins","html_url":"https://github.com/segiddins","followers_url":"https://api.github.com/users/segiddins/followers","following_url":"https://api.github.com/users/segiddins/following{/other_user}","gists_url":"https://api.github.com/users/segiddins/gists{/gist_id}","starred_url":"https://api.github.com/users/segiddins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segiddins/subscriptions","organizations_url":"https://api.github.com/users/segiddins/orgs","repos_url":"https://api.github.com/users/segiddins/repos","events_url":"https://api.github.com/users/segiddins/events{/privacy}","received_events_url":"https://api.github.com/users/segiddins/received_events","type":"User","site_admin":false},"body":"this last line is redundant","created_at":"2016-07-27T15:57:17Z","updated_at":"2016-07-27T15:57:17Z","html_url":"https://github.com/CocoaPods/CocoaPods/pull/5578#discussion_r72467977","pull_request_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/72467977"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/5578#discussion_r72467977"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578"}}},"pull_request":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578","id":75581032,"html_url":"https://github.com/CocoaPods/CocoaPods/pull/5578","diff_url":"https://github.com/CocoaPods/CocoaPods/pull/5578.diff","patch_url":"https://github.com/CocoaPods/CocoaPods/pull/5578.patch","issue_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/5578","number":5578,"state":"open","locked":false,"title":"For fix slow dependency issue(base on 1.0.0).","user":{"login":"yanzhiwei147","id":5554220,"avatar_url":"https://avatars.githubusercontent.com/u/5554220?v=3","gravatar_id":"","url":"https://api.github.com/users/yanzhiwei147","html_url":"https://github.com/yanzhiwei147","followers_url":"https://api.github.com/users/yanzhiwei147/followers","following_url":"https://api.github.com/users/yanzhiwei147/following{/other_user}","gists_url":"https://api.github.com/users/yanzhiwei147/gists{/gist_id}","starred_url":"https://api.github.com/users/yanzhiwei147/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanzhiwei147/subscriptions","organizations_url":"https://api.github.com/users/yanzhiwei147/orgs","repos_url":"https://api.github.com/users/yanzhiwei147/repos","events_url":"https://api.github.com/users/yanzhiwei147/events{/privacy}","received_events_url":"https://api.github.com/users/yanzhiwei147/received_events","type":"User","site_admin":false},"body":"for issue #5180","created_at":"2016-06-29T02:47:15Z","updated_at":"2016-07-27T15:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"396f1b64983aea824c5ba1a82cdf1c034f10cd5d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578/commits","review_comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578/comments","review_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/5578/comments","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/859dad72155ab62dc895fbd8d61dd874e090e73b","head":{"label":"SlowDepend:master","ref":"master","sha":"859dad72155ab62dc895fbd8d61dd874e090e73b","user":{"login":"SlowDepend","id":19384375,"avatar_url":"https://avatars.githubusercontent.com/u/19384375?v=3","gravatar_id":"","url":"https://api.github.com/users/SlowDepend","html_url":"https://github.com/SlowDepend","followers_url":"https://api.github.com/users/SlowDepend/followers","following_url":"https://api.github.com/users/SlowDepend/following{/other_user}","gists_url":"https://api.github.com/users/SlowDepend/gists{/gist_id}","starred_url":"https://api.github.com/users/SlowDepend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlowDepend/subscriptions","organizations_url":"https://api.github.com/users/SlowDepend/orgs","repos_url":"https://api.github.com/users/SlowDepend/repos","events_url":"https://api.github.com/users/SlowDepend/events{/privacy}","received_events_url":"https://api.github.com/users/SlowDepend/received_events","type":"Organization","site_admin":false},"repo":{"id":60575418,"name":"CocoaPods","full_name":"SlowDepend/CocoaPods","owner":{"login":"SlowDepend","id":19384375,"avatar_url":"https://avatars.githubusercontent.com/u/19384375?v=3","gravatar_id":"","url":"https://api.github.com/users/SlowDepend","html_url":"https://github.com/SlowDepend","followers_url":"https://api.github.com/users/SlowDepend/followers","following_url":"https://api.github.com/users/SlowDepend/following{/other_user}","gists_url":"https://api.github.com/users/SlowDepend/gists{/gist_id}","starred_url":"https://api.github.com/users/SlowDepend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlowDepend/subscriptions","organizations_url":"https://api.github.com/users/SlowDepend/orgs","repos_url":"https://api.github.com/users/SlowDepend/repos","events_url":"https://api.github.com/users/SlowDepend/events{/privacy}","received_events_url":"https://api.github.com/users/SlowDepend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SlowDepend/CocoaPods","description":"The Cocoa Dependency Manager.","fork":true,"url":"https://api.github.com/repos/SlowDepend/CocoaPods","forks_url":"https://api.github.com/repos/SlowDepend/CocoaPods/forks","keys_url":"https://api.github.com/repos/SlowDepend/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlowDepend/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlowDepend/CocoaPods/teams","hooks_url":"https://api.github.com/repos/SlowDepend/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/SlowDepend/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/SlowDepend/CocoaPods/events","assignees_url":"https://api.github.com/repos/SlowDepend/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/SlowDepend/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/SlowDepend/CocoaPods/tags","blobs_url":"https://api.github.com/repos/SlowDepend/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlowDepend/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlowDepend/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlowDepend/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlowDepend/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/SlowDepend/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/SlowDepend/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/SlowDepend/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/SlowDepend/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/SlowDepend/CocoaPods/subscription","commits_url":"https://api.github.com/repos/SlowDepend/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlowDepend/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlowDepend/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlowDepend/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/SlowDepend/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/SlowDepend/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlowDepend/CocoaPods/merges","archive_url":"https://api.github.com/repos/SlowDepend/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlowDepend/CocoaPods/downloads","issues_url":"https://api.github.com/repos/SlowDepend/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/SlowDepend/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/SlowDepend/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/SlowDepend/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlowDepend/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/SlowDepend/CocoaPods/releases{/id}","deployments_url":"https://api.github.com/repos/SlowDepend/CocoaPods/deployments","created_at":"2016-06-07T02:24:25Z","updated_at":"2016-06-07T02:24:27Z","pushed_at":"2016-07-27T10:54:15Z","git_url":"git://github.com/SlowDepend/CocoaPods.git","ssh_url":"git@github.com:SlowDepend/CocoaPods.git","clone_url":"https://github.com/SlowDepend/CocoaPods.git","svn_url":"https://github.com/SlowDepend/CocoaPods","homepage":"https://cocoapods.org/","size":51993,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaPods:master","ref":"master","sha":"eef5ab337dcb25984e7db33b9d6c96dec0adc6a2","user":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"repo":{"id":2203645,"name":"CocoaPods","full_name":"CocoaPods/CocoaPods","owner":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CocoaPods/CocoaPods","description":"The Cocoa Dependency Manager.","fork":false,"url":"https://api.github.com/repos/CocoaPods/CocoaPods","forks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/forks","keys_url":"https://api.github.com/repos/CocoaPods/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaPods/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaPods/CocoaPods/teams","hooks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/events","assignees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaPods/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/tags","blobs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaPods/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscription","commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaPods/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaPods/CocoaPods/merges","archive_url":"https://api.github.com/repos/CocoaPods/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaPods/CocoaPods/downloads","issues_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaPods/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/CocoaPods/CocoaPods/releases{/id}","deployments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/deployments","created_at":"2011-08-14T00:10:53Z","updated_at":"2016-07-27T14:37:37Z","pushed_at":"2016-07-27T10:54:16Z","git_url":"git://github.com/CocoaPods/CocoaPods.git","ssh_url":"git@github.com:CocoaPods/CocoaPods.git","clone_url":"https://github.com/CocoaPods/CocoaPods.git","svn_url":"https://github.com/CocoaPods/CocoaPods","homepage":"https://cocoapods.org/","size":71669,"stargazers_count":8258,"watchers_count":8258,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1515,"mirror_url":null,"open_issues_count":173,"forks":1515,"open_issues":173,"watchers":8258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/5578"},"issue":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/5578"},"comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/5578/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/5578/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/859dad72155ab62dc895fbd8d61dd874e090e73b"}}}}
{"actor":{"display_login":"segiddins"}}