{"action":"created","comment":{"url":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/comments/90050877","pull_request_review_id":10576175,"id":90050877,"diff_hunk":"@@ -109,7 +112,7 @@ pushsource* createPushSource(uint32 srcid, const char* name) {\n }\n \n void OnCheck(uv_check_t* handle) {\n-\tconst uv_loop_t* const loop = handle->loop;\n+    const uv_loop_t* const loop = handle->loop;","path":"src/plugins/node/loop/nodeloopplugin.cpp","position":23,"original_position":23,"commit_id":"579dfd6281942cf909fc55c5e66da5bb7e0d1787","original_commit_id":"579dfd6281942cf909fc55c5e66da5bb7e0d1787","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Indent error.  You seem to be using spaces whereas everything else in this file uses tabs.","created_at":"2016-11-29T16:45:33Z","updated_at":"2016-11-29T16:48:28Z","html_url":"https://github.com/RuntimeTools/appmetrics/pull/348#discussion_r90050877","pull_request_url":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348","_links":{"self":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/comments/90050877"},"html":{"href":"https://github.com/RuntimeTools/appmetrics/pull/348#discussion_r90050877"},"pull_request":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348"}}},"pull_request":{"url":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348","id":95047346,"html_url":"https://github.com/RuntimeTools/appmetrics/pull/348","diff_url":"https://github.com/RuntimeTools/appmetrics/pull/348.diff","patch_url":"https://github.com/RuntimeTools/appmetrics/pull/348.patch","issue_url":"https://api.github.com/repos/RuntimeTools/appmetrics/issues/348","number":348,"state":"open","locked":false,"title":"Fix a problem with double initialization","user":{"login":"baens","id":823907,"avatar_url":"https://avatars.githubusercontent.com/u/823907?v=3","gravatar_id":"","url":"https://api.github.com/users/baens","html_url":"https://github.com/baens","followers_url":"https://api.github.com/users/baens/followers","following_url":"https://api.github.com/users/baens/following{/other_user}","gists_url":"https://api.github.com/users/baens/gists{/gist_id}","starred_url":"https://api.github.com/users/baens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baens/subscriptions","organizations_url":"https://api.github.com/users/baens/orgs","repos_url":"https://api.github.com/users/baens/repos","events_url":"https://api.github.com/users/baens/events{/privacy}","received_events_url":"https://api.github.com/users/baens/received_events","type":"User","site_admin":false},"body":"The check_handle has a problem with double initialization. So instead of trying to initialize on start, do it when the plugin is initialized and just start and stop the listening loops.\r\n\r\nThis addresses some of #336. There is still problems with the system reconnecting after the 2nd start, but that will probably need to be addressed separately. ","created_at":"2016-11-23T17:25:42Z","updated_at":"2016-11-29T16:48:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3144ad5aaa7ab0e3b53f390f65ae5c25932221e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348/commits","review_comments_url":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348/comments","review_comment_url":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RuntimeTools/appmetrics/issues/348/comments","statuses_url":"https://api.github.com/repos/RuntimeTools/appmetrics/statuses/579dfd6281942cf909fc55c5e66da5bb7e0d1787","head":{"label":"overstock:fix-node-loop","ref":"fix-node-loop","sha":"579dfd6281942cf909fc55c5e66da5bb7e0d1787","user":{"login":"overstock","id":1413930,"avatar_url":"https://avatars.githubusercontent.com/u/1413930?v=3","gravatar_id":"","url":"https://api.github.com/users/overstock","html_url":"https://github.com/overstock","followers_url":"https://api.github.com/users/overstock/followers","following_url":"https://api.github.com/users/overstock/following{/other_user}","gists_url":"https://api.github.com/users/overstock/gists{/gist_id}","starred_url":"https://api.github.com/users/overstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overstock/subscriptions","organizations_url":"https://api.github.com/users/overstock/orgs","repos_url":"https://api.github.com/users/overstock/repos","events_url":"https://api.github.com/users/overstock/events{/privacy}","received_events_url":"https://api.github.com/users/overstock/received_events","type":"Organization","site_admin":false},"repo":{"id":74598645,"name":"appmetrics","full_name":"overstock/appmetrics","owner":{"login":"overstock","id":1413930,"avatar_url":"https://avatars.githubusercontent.com/u/1413930?v=3","gravatar_id":"","url":"https://api.github.com/users/overstock","html_url":"https://github.com/overstock","followers_url":"https://api.github.com/users/overstock/followers","following_url":"https://api.github.com/users/overstock/following{/other_user}","gists_url":"https://api.github.com/users/overstock/gists{/gist_id}","starred_url":"https://api.github.com/users/overstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overstock/subscriptions","organizations_url":"https://api.github.com/users/overstock/orgs","repos_url":"https://api.github.com/users/overstock/repos","events_url":"https://api.github.com/users/overstock/events{/privacy}","received_events_url":"https://api.github.com/users/overstock/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/overstock/appmetrics","description":"Node Application Metrics provides a foundational infrastructure for collecting resource and performance monitoring data for Node.js-based applications.","fork":true,"url":"https://api.github.com/repos/overstock/appmetrics","forks_url":"https://api.github.com/repos/overstock/appmetrics/forks","keys_url":"https://api.github.com/repos/overstock/appmetrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overstock/appmetrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overstock/appmetrics/teams","hooks_url":"https://api.github.com/repos/overstock/appmetrics/hooks","issue_events_url":"https://api.github.com/repos/overstock/appmetrics/issues/events{/number}","events_url":"https://api.github.com/repos/overstock/appmetrics/events","assignees_url":"https://api.github.com/repos/overstock/appmetrics/assignees{/user}","branches_url":"https://api.github.com/repos/overstock/appmetrics/branches{/branch}","tags_url":"https://api.github.com/repos/overstock/appmetrics/tags","blobs_url":"https://api.github.com/repos/overstock/appmetrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overstock/appmetrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overstock/appmetrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/overstock/appmetrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overstock/appmetrics/statuses/{sha}","languages_url":"https://api.github.com/repos/overstock/appmetrics/languages","stargazers_url":"https://api.github.com/repos/overstock/appmetrics/stargazers","contributors_url":"https://api.github.com/repos/overstock/appmetrics/contributors","subscribers_url":"https://api.github.com/repos/overstock/appmetrics/subscribers","subscription_url":"https://api.github.com/repos/overstock/appmetrics/subscription","commits_url":"https://api.github.com/repos/overstock/appmetrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/overstock/appmetrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/overstock/appmetrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/overstock/appmetrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/overstock/appmetrics/contents/{+path}","compare_url":"https://api.github.com/repos/overstock/appmetrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overstock/appmetrics/merges","archive_url":"https://api.github.com/repos/overstock/appmetrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overstock/appmetrics/downloads","issues_url":"https://api.github.com/repos/overstock/appmetrics/issues{/number}","pulls_url":"https://api.github.com/repos/overstock/appmetrics/pulls{/number}","milestones_url":"https://api.github.com/repos/overstock/appmetrics/milestones{/number}","notifications_url":"https://api.github.com/repos/overstock/appmetrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overstock/appmetrics/labels{/name}","releases_url":"https://api.github.com/repos/overstock/appmetrics/releases{/id}","deployments_url":"https://api.github.com/repos/overstock/appmetrics/deployments","created_at":"2016-11-23T17:19:07Z","updated_at":"2016-11-23T17:19:08Z","pushed_at":"2016-11-23T17:19:59Z","git_url":"git://github.com/overstock/appmetrics.git","ssh_url":"git@github.com:overstock/appmetrics.git","clone_url":"https://github.com/overstock/appmetrics.git","svn_url":"https://github.com/overstock/appmetrics","homepage":"https://developer.ibm.com/open/node-application-metrics/","size":617,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RuntimeTools:master","ref":"master","sha":"880bf2a8c23fbcbd66d9a8d38cd5e6dc71039253","user":{"login":"RuntimeTools","id":13256926,"avatar_url":"https://avatars.githubusercontent.com/u/13256926?v=3","gravatar_id":"","url":"https://api.github.com/users/RuntimeTools","html_url":"https://github.com/RuntimeTools","followers_url":"https://api.github.com/users/RuntimeTools/followers","following_url":"https://api.github.com/users/RuntimeTools/following{/other_user}","gists_url":"https://api.github.com/users/RuntimeTools/gists{/gist_id}","starred_url":"https://api.github.com/users/RuntimeTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RuntimeTools/subscriptions","organizations_url":"https://api.github.com/users/RuntimeTools/orgs","repos_url":"https://api.github.com/users/RuntimeTools/repos","events_url":"https://api.github.com/users/RuntimeTools/events{/privacy}","received_events_url":"https://api.github.com/users/RuntimeTools/received_events","type":"Organization","site_admin":false},"repo":{"id":38826376,"name":"appmetrics","full_name":"RuntimeTools/appmetrics","owner":{"login":"RuntimeTools","id":13256926,"avatar_url":"https://avatars.githubusercontent.com/u/13256926?v=3","gravatar_id":"","url":"https://api.github.com/users/RuntimeTools","html_url":"https://github.com/RuntimeTools","followers_url":"https://api.github.com/users/RuntimeTools/followers","following_url":"https://api.github.com/users/RuntimeTools/following{/other_user}","gists_url":"https://api.github.com/users/RuntimeTools/gists{/gist_id}","starred_url":"https://api.github.com/users/RuntimeTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RuntimeTools/subscriptions","organizations_url":"https://api.github.com/users/RuntimeTools/orgs","repos_url":"https://api.github.com/users/RuntimeTools/repos","events_url":"https://api.github.com/users/RuntimeTools/events{/privacy}","received_events_url":"https://api.github.com/users/RuntimeTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RuntimeTools/appmetrics","description":"Node Application Metrics provides a foundational infrastructure for collecting resource and performance monitoring data for Node.js-based applications.","fork":false,"url":"https://api.github.com/repos/RuntimeTools/appmetrics","forks_url":"https://api.github.com/repos/RuntimeTools/appmetrics/forks","keys_url":"https://api.github.com/repos/RuntimeTools/appmetrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RuntimeTools/appmetrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RuntimeTools/appmetrics/teams","hooks_url":"https://api.github.com/repos/RuntimeTools/appmetrics/hooks","issue_events_url":"https://api.github.com/repos/RuntimeTools/appmetrics/issues/events{/number}","events_url":"https://api.github.com/repos/RuntimeTools/appmetrics/events","assignees_url":"https://api.github.com/repos/RuntimeTools/appmetrics/assignees{/user}","branches_url":"https://api.github.com/repos/RuntimeTools/appmetrics/branches{/branch}","tags_url":"https://api.github.com/repos/RuntimeTools/appmetrics/tags","blobs_url":"https://api.github.com/repos/RuntimeTools/appmetrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RuntimeTools/appmetrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RuntimeTools/appmetrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/RuntimeTools/appmetrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RuntimeTools/appmetrics/statuses/{sha}","languages_url":"https://api.github.com/repos/RuntimeTools/appmetrics/languages","stargazers_url":"https://api.github.com/repos/RuntimeTools/appmetrics/stargazers","contributors_url":"https://api.github.com/repos/RuntimeTools/appmetrics/contributors","subscribers_url":"https://api.github.com/repos/RuntimeTools/appmetrics/subscribers","subscription_url":"https://api.github.com/repos/RuntimeTools/appmetrics/subscription","commits_url":"https://api.github.com/repos/RuntimeTools/appmetrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/RuntimeTools/appmetrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/RuntimeTools/appmetrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/RuntimeTools/appmetrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/RuntimeTools/appmetrics/contents/{+path}","compare_url":"https://api.github.com/repos/RuntimeTools/appmetrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RuntimeTools/appmetrics/merges","archive_url":"https://api.github.com/repos/RuntimeTools/appmetrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RuntimeTools/appmetrics/downloads","issues_url":"https://api.github.com/repos/RuntimeTools/appmetrics/issues{/number}","pulls_url":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls{/number}","milestones_url":"https://api.github.com/repos/RuntimeTools/appmetrics/milestones{/number}","notifications_url":"https://api.github.com/repos/RuntimeTools/appmetrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RuntimeTools/appmetrics/labels{/name}","releases_url":"https://api.github.com/repos/RuntimeTools/appmetrics/releases{/id}","deployments_url":"https://api.github.com/repos/RuntimeTools/appmetrics/deployments","created_at":"2015-07-09T14:46:47Z","updated_at":"2016-11-28T17:49:42Z","pushed_at":"2016-11-29T16:30:03Z","git_url":"git://github.com/RuntimeTools/appmetrics.git","ssh_url":"git@github.com:RuntimeTools/appmetrics.git","clone_url":"https://github.com/RuntimeTools/appmetrics.git","svn_url":"https://github.com/RuntimeTools/appmetrics","homepage":"https://developer.ibm.com/open/node-application-metrics/","size":644,"stargazers_count":221,"watchers_count":221,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":37,"forks":43,"open_issues":37,"watchers":221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348"},"html":{"href":"https://github.com/RuntimeTools/appmetrics/pull/348"},"issue":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/issues/348"},"comments":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/RuntimeTools/appmetrics/statuses/579dfd6281942cf909fc55c5e66da5bb7e0d1787"}}}}
{"actor":{"display_login":"bnoordhuis"}}