{"action":"created","issue":{"url":"https://api.github.com/repos/qmlweb/qmlweb/issues/177","repository_url":"https://api.github.com/repos/qmlweb/qmlweb","labels_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/177/comments","events_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/177/events","html_url":"https://github.com/qmlweb/qmlweb/pull/177","id":148340792,"number":177,"title":"fix js import test not passing","user":{"login":"Plaristote","id":1028544,"avatar_url":"https://avatars.githubusercontent.com/u/1028544?v=3","gravatar_id":"","url":"https://api.github.com/users/Plaristote","html_url":"https://github.com/Plaristote","followers_url":"https://api.github.com/users/Plaristote/followers","following_url":"https://api.github.com/users/Plaristote/following{/other_user}","gists_url":"https://api.github.com/users/Plaristote/gists{/gist_id}","starred_url":"https://api.github.com/users/Plaristote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plaristote/subscriptions","organizations_url":"https://api.github.com/users/Plaristote/orgs","repos_url":"https://api.github.com/users/Plaristote/repos","events_url":"https://api.github.com/users/Plaristote/events{/privacy}","received_events_url":"https://api.github.com/users/Plaristote/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-14T12:08:35Z","updated_at":"2016-04-14T12:17:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/177","html_url":"https://github.com/qmlweb/qmlweb/pull/177","diff_url":"https://github.com/qmlweb/qmlweb/pull/177.diff","patch_url":"https://github.com/qmlweb/qmlweb/pull/177.patch"},"body":"* replace qmlEngine references with engine\r\n* fix jsparser not properly walking the AST_Tree\r\n* enable the QMLEngine JavascriptImport test\r\n\r\nI noticed that js import wasn't working. Then I noticed the test was disabled. So I found what was blocking the test and fixed it (qmlEngine was used instead of engine in some place.... but qmlEngine is defined by the AutoLoader, and it's exclusively for use outside of qmlweb's scope. So I replaced the occurences of qmlEngine with engine).\r\n\r\nThen I fixed a bug in jsparser, not properly using the AST_Tree returned by qmlparse.\r\n\r\nThe test was wrong as well: if we set a color to 'magenta', we shouldn't expect the CSS property to be 'magenta', but the rgb value for the magenta color (as this is the new behavior for QMLColor)."},"comment":{"url":"https://api.github.com/repos/qmlweb/qmlweb/issues/comments/209911119","html_url":"https://github.com/qmlweb/qmlweb/pull/177#issuecomment-209911119","issue_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/177","id":209911119,"user":{"login":"ChALkeR","id":291301,"avatar_url":"https://avatars.githubusercontent.com/u/291301?v=3","gravatar_id":"","url":"https://api.github.com/users/ChALkeR","html_url":"https://github.com/ChALkeR","followers_url":"https://api.github.com/users/ChALkeR/followers","following_url":"https://api.github.com/users/ChALkeR/following{/other_user}","gists_url":"https://api.github.com/users/ChALkeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ChALkeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChALkeR/subscriptions","organizations_url":"https://api.github.com/users/ChALkeR/orgs","repos_url":"https://api.github.com/users/ChALkeR/repos","events_url":"https://api.github.com/users/ChALkeR/events{/privacy}","received_events_url":"https://api.github.com/users/ChALkeR/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T12:17:17Z","updated_at":"2016-04-14T12:17:17Z","body":"Those parser lines are from 5be63f5d.\r\n\r\nEverything except for the parser LGTM, and I can't give any comments about the parser — I am not familiar with that code."}}