{"action":"created","issue":{"url":"https://api.github.com/repos/donquixote/cellbrush/issues/5","repository_url":"https://api.github.com/repos/donquixote/cellbrush","labels_url":"https://api.github.com/repos/donquixote/cellbrush/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/donquixote/cellbrush/issues/5/comments","events_url":"https://api.github.com/repos/donquixote/cellbrush/issues/5/events","html_url":"https://github.com/donquixote/cellbrush/issues/5","id":182752567,"number":5,"title":"`createTag()` of `AttributesTrait` accesses a `private` attribute without a getter","user":{"login":"makoru-hikage","id":18744785,"avatar_url":"https://avatars.githubusercontent.com/u/18744785?v=3","gravatar_id":"","url":"https://api.github.com/users/makoru-hikage","html_url":"https://github.com/makoru-hikage","followers_url":"https://api.github.com/users/makoru-hikage/followers","following_url":"https://api.github.com/users/makoru-hikage/following{/other_user}","gists_url":"https://api.github.com/users/makoru-hikage/gists{/gist_id}","starred_url":"https://api.github.com/users/makoru-hikage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makoru-hikage/subscriptions","organizations_url":"https://api.github.com/users/makoru-hikage/orgs","repos_url":"https://api.github.com/users/makoru-hikage/repos","events_url":"https://api.github.com/users/makoru-hikage/events{/privacy}","received_events_url":"https://api.github.com/users/makoru-hikage/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-13T10:28:22Z","updated_at":"2016-10-13T10:53:32Z","closed_at":null,"body":"Line 129 of `AttributesTrait` is faulty; it accesses a `private` attribute. The `$attribute` property of `AttributesTrait` used by `Tag` class is private, but it is accessed with the following:\r\n\r\n`$tag->attributes = $this->attributes;`\r\n\r\nThe aforementioned line is Line 129 of `AttributesTrait`.\r\n\r\nTo summarize what happened: Using the `AttributeTrait`, class `Attributes` accessed the `private $attributes` of `Tag` class. Although both classes `Tag` and `Attributes` use the `AttributesTrait` that has  `private $attributes`, they cannot access such property without doing a 'getter'.\r\n\r\nWill think of a PR soon.\r\n[The usage of PHP Traits is quite confusing, isn't it?]"},"comment":{"url":"https://api.github.com/repos/donquixote/cellbrush/issues/comments/253480841","html_url":"https://github.com/donquixote/cellbrush/issues/5#issuecomment-253480841","issue_url":"https://api.github.com/repos/donquixote/cellbrush/issues/5","id":253480841,"user":{"login":"donquixote","id":150032,"avatar_url":"https://avatars.githubusercontent.com/u/150032?v=3","gravatar_id":"","url":"https://api.github.com/users/donquixote","html_url":"https://github.com/donquixote","followers_url":"https://api.github.com/users/donquixote/followers","following_url":"https://api.github.com/users/donquixote/following{/other_user}","gists_url":"https://api.github.com/users/donquixote/gists{/gist_id}","starred_url":"https://api.github.com/users/donquixote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donquixote/subscriptions","organizations_url":"https://api.github.com/users/donquixote/orgs","repos_url":"https://api.github.com/users/donquixote/repos","events_url":"https://api.github.com/users/donquixote/events{/privacy}","received_events_url":"https://api.github.com/users/donquixote/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T10:53:32Z","updated_at":"2016-10-13T10:53:32Z","body":"> [The usage of PHP Traits is quite confusing, isn't it?]\r\n\r\nYes, I use them a lot less nowadays. They do not properly encapsulate anything, and make it really hard for an IDE to figure out what's going on. I wish PHP had real multiple inheritance."}}
{"actor":{"display_login":"donquixote"}}