{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16083","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16083/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16083/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16083/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16083","id":146433849,"number":16083,"title":"Firearm Damage Rebalance (1/4): Mid-to-High Caliber Pistols","user":{"login":"Nioca","id":11001797,"avatar_url":"https://avatars.githubusercontent.com/u/11001797?v=3","gravatar_id":"","url":"https://api.github.com/users/Nioca","html_url":"https://github.com/Nioca","followers_url":"https://api.github.com/users/Nioca/followers","following_url":"https://api.github.com/users/Nioca/following{/other_user}","gists_url":"https://api.github.com/users/Nioca/gists{/gist_id}","starred_url":"https://api.github.com/users/Nioca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nioca/subscriptions","organizations_url":"https://api.github.com/users/Nioca/orgs","repos_url":"https://api.github.com/users/Nioca/repos","events_url":"https://api.github.com/users/Nioca/events{/privacy}","received_events_url":"https://api.github.com/users/Nioca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-06T21:00:47Z","updated_at":"2016-04-06T22:20:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16083","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16083","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16083.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16083.patch"},"body":"This is the initial pull request to answer #15752, in an attempt the rebalance the damage modifiers on guns. As it currently stands, guns appears to have damage modifiers set purely by numbers out of thin air; this results in weird cases where a bullet fired from a handgun can drastically outperform the same bullet fired from a full-size carbine or SMG (M1911 vs. TDI Vector or Thompson SMG, for example).\r\n\r\nIn real life, to the best of my knowledge, the only aspect of a gun that can significantly effect the damage (in loose terms) a bullet could potentially do is the length and quality of the gun's barrel. In simple terms, all other things being equal, a round fired from a short-barreled firearm is going to have less energy than one fired from a long-barreled firearm, simply because it has less time to accelerate. Barrel quality is pretty much a non-issue, except in the cases of scrap weapons and improvised firearms. Thus, this rebalance bases the damage of weapons on the length of the weapons' barrels. Each caliber has a baseline set for it, based on the data Stalblar pulled for muzzle energy figures (from Wikipedia, for the curious; there's probably better sources to use, but I'm going to stick with this right now for consistency's sake). For every three inches a firearm deviates from the baseline, it gains a one-point bonus or penalty, rounding to the nearest bonus/penalty (so a gun with 6 Inch barrel with a baseline of 4 Inches would round up to a +1).\r\n\r\nThe whole thing is pretty much ready to go (I just need to do the JSON work on the rifles; all the data's already in place), but to make it easier to view the changes, I'm splitting it into four parts. This first part rebalances Mid-to-High power pistol cartridges; I feel this acts the best as a proof-of-concept of what I'm attempting to accomplish. Across all calibers, most weapons won't deviate more than 3 points from baseline, with the ones that do often being outliers in some way (homemade scrap weapons, rifles chambered in pistol cartridges, pistols chambered in rifle cartridges, so forth). I'll be providing tables with each pull request showing the changes, baseline, and barrel lengths.\r\n\r\nIn general, the net result of this is that the wide and arbitrary spread on most firearms is narrowed (which helps make firearm selection less of a no-brainer). In addition, larger and bulkier weapons will tend to have better damage, offering an incentive to use an SMG over a pistol, or a machine gun over a compact automatic carbine.\r\n\r\nFirst, a list of changes across cartridge categories at a glance. .40 S&W got spiced up with a little variety, and .44 Magnum now has -1 across most of its guns, but for the most part, all the others had their spread narrowed; the overall spread for this cartridge group got halved!\r\n**DmgMod Range (New/Old)** is the range of damage modifiers on the guns, with a comparison of after and before. **Crt. Range (New/Old)** is that same range with the cartridge's actual damage applied, giving an idea of the ''actual'' damage spread when using guns from that caliber.\r\n\r\nCartridge | Base Length | DmgMod Range (New/Old) | Crt. Range (New/Old) | Notes\r\n--------- | ----------- | ---------------------- | -------------------- | -----\r\n**OVERALL**|            | **-2 to +4 / -4 to +8**|                      |\r\n9x19mm    | 5.9 Inches  | -1 to +4 / -3 to +3    | 25-30 / 23-29        |\r\n.40 S&W   | 4 Inches    | -2 to +1 / 0           | 26-29 / 28           |\r\n.45 ACP   | 5 Inches    | 0 to +4 / -4 to +6     | 28-32 / 24-34        |\r\n.44 Magnum| 7.5 Inches  | -1 to 0 / 0            | 39-40 / 40           | \r\n.454 Casull|7.5 Inches  | 0 / +6                 | 56 / 62              | Cartridge note: it seems Stalblar put the data up, but didn't actually change this round, resulting in a odd discrepency in damage.\r\n.500 S&W  | 8.4 Inches  | 0 / +8                 | 48 / 56              | See .454 Casull above.\r\n\r\nAnd then a breakdown of each gun. The big winners here are the Calico M960, MAC-10, and the pistol carbines; the former two had their ridiculous damage penalties axed and gained a slight buff on top of it. The latter simply received a sizable damage buff; the L1820 Long Ranger, Kel-Tec SUB-2000 (which had its name fixed) and Cx4 Storm are now dangerous in their own right, rather than just volume hogs. On the nerf side of things, the TEC-9, Leadworks Autorevolvers, M1911, Taurus Raging Bull, and S&W 500 all had their ridiculous damage bonuses axed almost entirely; most are now 0 damage weapons, with the autorevolvers squeaking into a +1.\r\n\r\n             Weapons | Length (in) | NewDmg | OldDmg | Notes\r\n-------------------- | ----------- | ------ | ------ | -----\r\n          **9x19mm** |**Base: 5.9**|        |        | \r\n            Glock 19 | 4.1 Inches  | -1     | 0      | \r\n             USP 9mm | 4.3 Inches  | -1     | 0      | \r\n          Beretta M9 | 4.9 Inches  | 0      | -1     | \r\n          L39B & L39 | 4.9 Inches  | 0      | +1     | The L39s are based off the Auto-9 in Robocop, which is in turn a dressed-up Beretta 93R.\r\n               TEC-9 | 5 Inches    | 0      | +3     | It's assumed here that the in-game TEC-9 is the full-size model and not the mini.\r\n       Briefcase SMG | Unknown     | 0      | +1     | It's comparable in size to an MP5, but its concealed nature likely means a shorter barrel.\r\nLookout 2032 Autorevolver|7.5 Inches?|+1    | +5     | It's Volume 2, same as the Beretta M9. Autorevolvers tended to vary between 6-7.5 inches in barrel length, so we'll err on the side of a +1 here.\r\n                STEN | 7.7 Inches  | +1     | +1     | \r\n             H&K MP5 | 8.9 Inches  | +1     | +1     | \r\n                 Uzi | 10.2 Inches | +1     | 0      | \r\n      9mm Pipe Rifle | Unknown     | +1     | -2     | Despite its quality, it IS a small rifle. However, given the far poorer construction, it's unlikely to hit the same velocity or energy as an actual rifle.\r\n         Calico M960 | 13 Inches   | +2     | -3     | Probably also needs its volume increased by 1. It's about the same overall size as an MP5. But that's a different PR.\r\n    Kel-Tec SUB-2000 | 16.1 Inches | +3     | 0      | \r\n           Cx4 Storm | 16.6 Inches | +4     | 0      |\r\n          **40 S&W** | **Base: 4** |        |        | \r\nSurvivor's Six Shooter| Unknown    | -2     | 0      | It's a handmade scrap weapon, albeit it IS a bit bigger than the other .40 S&W guns present.\r\n         SIG Pro .40 | 3.9 Inches  | 0      | 0      | \r\n             S&W 610 | 6.5 Inches  | +1     | 0      |\r\n            Glock 22 | 8 Inches    | +1     | 0      |\r\n         **.45 ACP** | **Base: 5** |        |        | \r\n              MAC-10 | 4.49 Inches | 0      | -4     | \r\n               M1911 | 5.03 Inches | 0      | +6     | \r\n          TDI Vector | 5.5 Inches  | 0      | -2     |\r\n    L39B-45 & L39-45 | 7 Inches?   | +1     | +1     | It's Volume 3, bigger than the 1911, but it's based on a scaled up Auto-9 (in turn based on the Beretta 93R), which makes it difficult to be sure. But a 2 inch difference is likely.\r\n      L2031 Enforcer | 7.5 Inches? | +1     | +5     | It's Volume 2, same as the 1911. Real-life Autorevolvers tended to vary between 6-7.5 inches in barrel length, so we'll err on the side of a +1 here.\r\n             USP .45 | 7.9 Inches  | +1     | +1     | \r\n               UMP45 | 8 Inches    | +1     | 0      |\r\nThompson Submachine Gun|10.5 Inches| +2     | +1     | \r\nHomemade Hand Cannon | Unknown     | +2     | +3     | The only thing that can be said for sure is that it's bigger than a Desert Eagle, which makes it pretty dang big for a handgun. But it's also a homemade piece of scrap, so its tolerances are likely poor.\r\n   L1820 Long Ranger | 20 Inches?  | +4     | 0      | If it's based off the Winchester 94, it's likely got a 20 inch barrel. For sanity's sake though, let's cap it at +4.\r\n      **.44 Magnum** |**Base: 7.5**|        |        |\r\n    Desert Eagle .44 | 6 Inches    | -1     | 0      | Technically, the Mark XIX Desert Eagle can come with either a 6 Inch (-1) or 10 Inch (+1) barrel, but 6 Inches seems to be the more common barrel\r\n      LeMat Revolver | 6 Inches?   | -1     | 0      | I found figures for the Baby LeMat, but not the full-size one. Doing some measurements on some pictures gave me a figure of 6 Inches, so unless someone can find an actual number here, that's what we'll go with.\r\n             S&W 629 | 6 Inches    | -1     | 0      | \r\n       Ruger Redhawk | 7.5 Inches  | 0      | 0      | 7.5 inches is being used to match the Super Redhawk (which was supposed to be its successor).\r\n**Other Cartridges** | **See Notes**|       |        | **Each gun will have the cartridge's baseline listed in the notes.**\r\n  Taurus Raging Bull | 8 Inches    | 0      | +6     | Baseline: 7.5 Inches\r\n             S&W 500 | 8.4 Inches  | 0      | +8     | Baseline: 8.4 Inches\r\n\r\nOne final note: Aside from a couple typo fixes, this PR also alters the documentation in GAME_BALANCE.md to reflect the changes, and adds the collected barrel length baselines to the cartridge listings over there.\r\n\r\nI'm intending to split this into four different PRs, so as to make it easier to review the changes as we go. If desired, however, I could do a larger PR to finish the rest of them in one sweep."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/206594122","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16083#issuecomment-206594122","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16083","id":206594122,"user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T22:20:13Z","updated_at":"2016-04-06T22:20:13Z","body":"> I'm intending to split this into four different PRs, so as to make it easier to review the changes as we go. If desired, however, I could do a larger PR to finish the rest of them in one sweep.\r\n\r\nThe numbers look fairly good overall. I'd start by updating the ammo `damage` values for the base ammo types only - the issue of tracers and AP rounds can come later once this has had some play testing. It's probably easier as one PR for the relatively low number of lines.\r\n"}}