{"action":"created","comment":{"url":"https://api.github.com/repos/scrapinghub/shub-image/pulls/comments/73151225","id":73151225,"diff_hunk":"@@ -125,9 +127,12 @@ def _prepare_deploy_params(project, version, image_name, endpoint, apikey,\n     if not username:\n         params['pull_insecure_registry'] = True\n     else:\n+        # Missing password leads to auth request to registry authentication\n+        # service without 'account' query parameter which breaks login\n+        # procedure.\n         params['pull_auth_config'] = json.dumps(\n             {'username': username,\n-             'password': password,\n+             'password': password or ' ',","path":"shub_image/deploy.py","position":null,"original_position":33,"commit_id":"e01072276d7ba1d3fe8dcdef2b0af2c2963247ea","original_commit_id":"053513d1f211c5045169a1a004eff5a1330b0fc1","user":{"login":"vshlapakov","id":448111,"avatar_url":"https://avatars.githubusercontent.com/u/448111?v=3","gravatar_id":"","url":"https://api.github.com/users/vshlapakov","html_url":"https://github.com/vshlapakov","followers_url":"https://api.github.com/users/vshlapakov/followers","following_url":"https://api.github.com/users/vshlapakov/following{/other_user}","gists_url":"https://api.github.com/users/vshlapakov/gists{/gist_id}","starred_url":"https://api.github.com/users/vshlapakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vshlapakov/subscriptions","organizations_url":"https://api.github.com/users/vshlapakov/orgs","repos_url":"https://api.github.com/users/vshlapakov/repos","events_url":"https://api.github.com/users/vshlapakov/events{/privacy}","received_events_url":"https://api.github.com/users/vshlapakov/received_events","type":"User","site_admin":false},"body":"Works as well (you can try by yourself by marking one of your repo as private in settings).  For private Docker hub images rules are the same as for any other private registry: you must provide username & password or there will be `image not found` error.","created_at":"2016-08-02T13:11:08Z","updated_at":"2016-08-02T13:11:08Z","html_url":"https://github.com/scrapinghub/shub-image/pull/14#discussion_r73151225","pull_request_url":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/shub-image/pulls/comments/73151225"},"html":{"href":"https://github.com/scrapinghub/shub-image/pull/14#discussion_r73151225"},"pull_request":{"href":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14","id":79546535,"html_url":"https://github.com/scrapinghub/shub-image/pull/14","diff_url":"https://github.com/scrapinghub/shub-image/pull/14.diff","patch_url":"https://github.com/scrapinghub/shub-image/pull/14.patch","issue_url":"https://api.github.com/repos/scrapinghub/shub-image/issues/14","number":14,"state":"open","locked":false,"title":"Use apikey as username by default","user":{"login":"vshlapakov","id":448111,"avatar_url":"https://avatars.githubusercontent.com/u/448111?v=3","gravatar_id":"","url":"https://api.github.com/users/vshlapakov","html_url":"https://github.com/vshlapakov","followers_url":"https://api.github.com/users/vshlapakov/followers","following_url":"https://api.github.com/users/vshlapakov/following{/other_user}","gists_url":"https://api.github.com/users/vshlapakov/gists{/gist_id}","starred_url":"https://api.github.com/users/vshlapakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vshlapakov/subscriptions","organizations_url":"https://api.github.com/users/vshlapakov/orgs","repos_url":"https://api.github.com/users/vshlapakov/repos","events_url":"https://api.github.com/users/vshlapakov/events{/privacy}","received_events_url":"https://api.github.com/users/vshlapakov/received_events","type":"User","site_admin":false},"body":"The PR does the following things:\r\n- uses apikey as default username\r\n- fixes `deploy` command use with no password\r\n- upgrades shub-version up to `2.2.0`\r\n- adds `--insecure` option for `push`,`deploy`,`upload` cmds to use insecure registry\r\n\r\nReview, please.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/scrapinghub/shub-image/14)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-08-01T10:26:49Z","updated_at":"2016-08-02T13:11:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9231a27eb24b5d6226f6db09b9ca3d62a17108c","assignee":{"login":"chekunkov","id":744331,"avatar_url":"https://avatars.githubusercontent.com/u/744331?v=3","gravatar_id":"","url":"https://api.github.com/users/chekunkov","html_url":"https://github.com/chekunkov","followers_url":"https://api.github.com/users/chekunkov/followers","following_url":"https://api.github.com/users/chekunkov/following{/other_user}","gists_url":"https://api.github.com/users/chekunkov/gists{/gist_id}","starred_url":"https://api.github.com/users/chekunkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chekunkov/subscriptions","organizations_url":"https://api.github.com/users/chekunkov/orgs","repos_url":"https://api.github.com/users/chekunkov/repos","events_url":"https://api.github.com/users/chekunkov/events{/privacy}","received_events_url":"https://api.github.com/users/chekunkov/received_events","type":"User","site_admin":false},"assignees":[{"login":"chekunkov","id":744331,"avatar_url":"https://avatars.githubusercontent.com/u/744331?v=3","gravatar_id":"","url":"https://api.github.com/users/chekunkov","html_url":"https://github.com/chekunkov","followers_url":"https://api.github.com/users/chekunkov/followers","following_url":"https://api.github.com/users/chekunkov/following{/other_user}","gists_url":"https://api.github.com/users/chekunkov/gists{/gist_id}","starred_url":"https://api.github.com/users/chekunkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chekunkov/subscriptions","organizations_url":"https://api.github.com/users/chekunkov/orgs","repos_url":"https://api.github.com/users/chekunkov/repos","events_url":"https://api.github.com/users/chekunkov/events{/privacy}","received_events_url":"https://api.github.com/users/chekunkov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14/commits","review_comments_url":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14/comments","review_comment_url":"https://api.github.com/repos/scrapinghub/shub-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapinghub/shub-image/issues/14/comments","statuses_url":"https://api.github.com/repos/scrapinghub/shub-image/statuses/e01072276d7ba1d3fe8dcdef2b0af2c2963247ea","head":{"label":"scrapinghub:sc737","ref":"sc737","sha":"e01072276d7ba1d3fe8dcdef2b0af2c2963247ea","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":52602708,"name":"shub-image","full_name":"scrapinghub/shub-image","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/shub-image","description":"Client side tool to prepare docker images to run crawlers in Scrapinghub","fork":false,"url":"https://api.github.com/repos/scrapinghub/shub-image","forks_url":"https://api.github.com/repos/scrapinghub/shub-image/forks","keys_url":"https://api.github.com/repos/scrapinghub/shub-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/shub-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/shub-image/teams","hooks_url":"https://api.github.com/repos/scrapinghub/shub-image/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/shub-image/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/shub-image/events","assignees_url":"https://api.github.com/repos/scrapinghub/shub-image/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/shub-image/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/shub-image/tags","blobs_url":"https://api.github.com/repos/scrapinghub/shub-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/shub-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/shub-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/shub-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/shub-image/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/shub-image/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/shub-image/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/shub-image/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/shub-image/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/shub-image/subscription","commits_url":"https://api.github.com/repos/scrapinghub/shub-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/shub-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/shub-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/shub-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/shub-image/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/shub-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/shub-image/merges","archive_url":"https://api.github.com/repos/scrapinghub/shub-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/shub-image/downloads","issues_url":"https://api.github.com/repos/scrapinghub/shub-image/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/shub-image/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/shub-image/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/shub-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/shub-image/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/shub-image/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/shub-image/deployments","created_at":"2016-02-26T12:23:13Z","updated_at":"2016-06-14T11:30:20Z","pushed_at":"2016-08-02T12:59:30Z","git_url":"git://github.com/scrapinghub/shub-image.git","ssh_url":"git@github.com:scrapinghub/shub-image.git","clone_url":"https://github.com/scrapinghub/shub-image.git","svn_url":"https://github.com/scrapinghub/shub-image","homepage":"","size":76,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"scrapinghub:master","ref":"master","sha":"14d9c88250beddfb218cc89178c664d2b98c6562","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":52602708,"name":"shub-image","full_name":"scrapinghub/shub-image","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/shub-image","description":"Client side tool to prepare docker images to run crawlers in Scrapinghub","fork":false,"url":"https://api.github.com/repos/scrapinghub/shub-image","forks_url":"https://api.github.com/repos/scrapinghub/shub-image/forks","keys_url":"https://api.github.com/repos/scrapinghub/shub-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/shub-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/shub-image/teams","hooks_url":"https://api.github.com/repos/scrapinghub/shub-image/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/shub-image/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/shub-image/events","assignees_url":"https://api.github.com/repos/scrapinghub/shub-image/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/shub-image/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/shub-image/tags","blobs_url":"https://api.github.com/repos/scrapinghub/shub-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/shub-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/shub-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/shub-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/shub-image/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/shub-image/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/shub-image/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/shub-image/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/shub-image/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/shub-image/subscription","commits_url":"https://api.github.com/repos/scrapinghub/shub-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/shub-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/shub-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/shub-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/shub-image/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/shub-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/shub-image/merges","archive_url":"https://api.github.com/repos/scrapinghub/shub-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/shub-image/downloads","issues_url":"https://api.github.com/repos/scrapinghub/shub-image/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/shub-image/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/shub-image/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/shub-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/shub-image/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/shub-image/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/shub-image/deployments","created_at":"2016-02-26T12:23:13Z","updated_at":"2016-06-14T11:30:20Z","pushed_at":"2016-08-02T12:59:30Z","git_url":"git://github.com/scrapinghub/shub-image.git","ssh_url":"git@github.com:scrapinghub/shub-image.git","clone_url":"https://github.com/scrapinghub/shub-image.git","svn_url":"https://github.com/scrapinghub/shub-image","homepage":"","size":76,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14"},"html":{"href":"https://github.com/scrapinghub/shub-image/pull/14"},"issue":{"href":"https://api.github.com/repos/scrapinghub/shub-image/issues/14"},"comments":{"href":"https://api.github.com/repos/scrapinghub/shub-image/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapinghub/shub-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapinghub/shub-image/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/scrapinghub/shub-image/statuses/e01072276d7ba1d3fe8dcdef2b0af2c2963247ea"}}}}
{"actor":{"display_login":"vshlapakov"}}