{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/15626","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/15626/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/15626/comments","events_url":"https://api.github.com/repos/apache/spark/issues/15626/events","html_url":"https://github.com/apache/spark/pull/15626","id":185177787,"number":15626,"title":"SPARK-17829 [SQL] Stable format for offset log","user":{"login":"tcondie","id":1696558,"avatar_url":"https://avatars.githubusercontent.com/u/1696558?v=3","gravatar_id":"","url":"https://api.github.com/users/tcondie","html_url":"https://github.com/tcondie","followers_url":"https://api.github.com/users/tcondie/followers","following_url":"https://api.github.com/users/tcondie/following{/other_user}","gists_url":"https://api.github.com/users/tcondie/gists{/gist_id}","starred_url":"https://api.github.com/users/tcondie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcondie/subscriptions","organizations_url":"https://api.github.com/users/tcondie/orgs","repos_url":"https://api.github.com/users/tcondie/repos","events_url":"https://api.github.com/users/tcondie/events{/privacy}","received_events_url":"https://api.github.com/users/tcondie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-10-25T17:09:15Z","updated_at":"2016-10-28T20:27:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15626","html_url":"https://github.com/apache/spark/pull/15626","diff_url":"https://github.com/apache/spark/pull/15626.diff","patch_url":"https://github.com/apache/spark/pull/15626.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nCurrently we use java serialization for the WAL that stores the offsets contained in each batch. This has two main issues:\r\nIt can break across spark releases (though this is not the only thing preventing us from upgrading a running query)\r\nIt is unnecessarily opaque to the user.\r\nI'd propose we require offsets to provide a user readable serialization and use that instead. JSON is probably a good option.\r\n\r\n## How was this patch tested?\r\n\r\nTests were added for KafkaSourceOffset in [KafkaSourceOffsetSuite](external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceOffsetSuite.scala) and for LongOffset in [OffsetSuite](sql/core/src/test/scala/org/apache/spark/sql/streaming/OffsetSuite.scala)\r\n\r\nPlease review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a pull request.\r\n\r\n@zsxwing @marmbrus "},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/257020070","html_url":"https://github.com/apache/spark/pull/15626#issuecomment-257020070","issue_url":"https://api.github.com/repos/apache/spark/issues/15626","id":257020070,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T20:27:34Z","updated_at":"2016-10-28T20:27:34Z","body":"**[Test build #67711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67711/consoleFull)** for PR 15626 at commit [`b80b3ce`](https://github.com/apache/spark/commit/b80b3ce537313c0a6715c5c48d37ebb250d394a2).\n * This patch **fails from timeout after a configured wait of \\`250m\\`**.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}