{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/56319532","id":56319532,"diff_hunk":"@@ -178,16 +178,26 @@ def save_archive\n       return false\n     end\n \n-    path.open(\"wb\") do |f|\n-      f.write(file.read)\n+    meta_file = data.join(\"meta.yml\")\n+    unless meta_file.exist?\n+      errors.add(:file_content, I18n.t(\"backups.index.meta_missing\"))\n+      return false\n+    end\n+\n+    begin\n+      meta = YAML.load_file(meta_file)\n+    rescue Psych::SyntaxError\n+      errors.add(:file_content, I18n.t(\"backups.index.invalid_file_content\"))\n+      return false\n     end\n \n-    meta = YAML.load_file(data.join(\"meta.yml\"))\n     self.version = meta[\"version\"].to_s\n     self.size = path.size\n     self.created_at = Time.zone.parse(meta[\"created_at\"])\n-    # 20151222144602_create_backups.rb\n-    self.migration_level = meta[\"migration_level\"] || 20151222144602","path":"crowbar_framework/app/models/backup.rb","position":24,"original_position":24,"commit_id":"377e0962acd1ee2bacf0d6810e6812aacced9b8b","original_commit_id":"377e0962acd1ee2bacf0d6810e6812aacced9b8b","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"oops I messed up the rebase, sorry","created_at":"2016-03-16T11:41:45Z","updated_at":"2016-03-16T11:41:45Z","html_url":"https://github.com/crowbar/crowbar-core/pull/420#discussion_r56319532","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/56319532"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/420#discussion_r56319532"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420","id":62549369,"html_url":"https://github.com/crowbar/crowbar-core/pull/420","diff_url":"https://github.com/crowbar/crowbar-core/pull/420.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/420.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/420","number":420,"state":"open","locked":false,"title":"[stable/3.0] backport #345","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"https://github.com/crowbar/crowbar-core/pull/345\r\n\r\n~~have to rebase on https://github.com/crowbar/crowbar-core/pull/411 so please wait for it to be merged~~\r\nEDIT: done","created_at":"2016-03-11T14:24:22Z","updated_at":"2016-03-16T11:41:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa58791664bb390079e95a27d9ad02ccb431824b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/420/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/377e0962acd1ee2bacf0d6810e6812aacced9b8b","head":{"label":"MaximilianMeister:backport/3.0/upgrade/invalid-tarball","ref":"backport/3.0/upgrade/invalid-tarball","sha":"377e0962acd1ee2bacf0d6810e6812aacced9b8b","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":40901479,"name":"crowbar-core","full_name":"MaximilianMeister/crowbar-core","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/crowbar-core","forks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/deployments","created_at":"2015-08-17T14:29:21Z","updated_at":"2015-08-17T14:29:23Z","pushed_at":"2016-03-16T10:52:05Z","git_url":"git://github.com/MaximilianMeister/crowbar-core.git","ssh_url":"git@github.com:MaximilianMeister/crowbar-core.git","clone_url":"https://github.com/MaximilianMeister/crowbar-core.git","svn_url":"https://github.com/MaximilianMeister/crowbar-core","homepage":null,"size":105933,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:stable/3.0","ref":"stable/3.0","sha":"84cb9ce35f4d5e7bbae3e55416dc310ad7a07ca6","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-01-12T12:38:58Z","pushed_at":"2016-03-16T10:52:05Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":120197,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":39,"forks":23,"open_issues":39,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/420"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/420"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/377e0962acd1ee2bacf0d6810e6812aacced9b8b"}}}}