{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/55619009","id":55619009,"diff_hunk":"@@ -954,3 +956,191 @@ def MoveFile(self, target, source_path, remote_path=''):\n \n     # Copies the file to its final destination in the container\n     target.ContainerCopy(file_name, remote_path)\n+\n+\n+class JujuMixin(DebianMixin):\n+    \"\"\"\n+    Class to allow running juju-deployed workloads\n+\n+    Bootstraps a Juju environment using the manual provider:\n+    https://jujucharms.com/docs/stable/config-manual\n+    \"\"\"\n+\n+    OS_TYPE = 'juju'\n+\n+    isController = False\n+\n+    \"\"\"\n+    A reference to the juju controller, useful when operations occur against\n+    a unit's VM but need to be preformed from the controller.\n+    \"\"\"\n+    controller = None\n+\n+    units = []\n+\n+    environments_yaml = \"\"\"\n+    default: perfkit\n+\n+    environments:\n+        perfkit:\n+            type: manual\n+            bootstrap-host: {0}\n+    \"\"\"\n+\n+    def juju_bootstrap(self):","path":"perfkitbenchmarker/linux_virtual_machine.py","position":47,"original_position":47,"commit_id":"cda32b8fcc7e3db62234effea44098bff094652d","original_commit_id":"cda32b8fcc7e3db62234effea44098bff094652d","user":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"body":"Nit: to keep consistent with the rest of the codebase could you please use CamelCase for methods? And if the method is private, you can prefix the method name with '_'. ","created_at":"2016-03-10T00:56:13Z","updated_at":"2016-03-10T00:56:13Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/764#discussion_r55619009","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/55619009"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/764#discussion_r55619009"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764","id":54204766,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/764","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/764.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/764.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/764","number":764,"state":"open","locked":false,"title":"Add os_type for Juju Mixin","user":{"login":"AdamIsrael","id":125008,"avatar_url":"https://avatars.githubusercontent.com/u/125008?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamIsrael","html_url":"https://github.com/AdamIsrael","followers_url":"https://api.github.com/users/AdamIsrael/followers","following_url":"https://api.github.com/users/AdamIsrael/following{/other_user}","gists_url":"https://api.github.com/users/AdamIsrael/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamIsrael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamIsrael/subscriptions","organizations_url":"https://api.github.com/users/AdamIsrael/orgs","repos_url":"https://api.github.com/users/AdamIsrael/repos","events_url":"https://api.github.com/users/AdamIsrael/events{/privacy}","received_events_url":"https://api.github.com/users/AdamIsrael/received_events","type":"User","site_admin":false},"body":"Hi Tony,\r\n\r\nThis is still a work-in-progress, with some papercuts that need to be cleaned up (including squashing my merge of upstream/master, documentation, and adding support for clouds other than AWS). I believe this branch is more inline with our email discussion, and I want to make sure that the way I implemented the cloud orchestration piece (installing and using juju) makes sense, since that was the one less well-defined. \r\n\r\nTo run:\r\n`./pkb.py --cloud=AWS --os_type=juju --benchmarks=cassandra_stress`","created_at":"2015-12-20T18:20:21Z","updated_at":"2016-03-10T00:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f072cd2449b7b8022e0ba2c7a117e9ae60f32319","assignee":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/764/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/cda32b8fcc7e3db62234effea44098bff094652d","head":{"label":"AdamIsrael:juju-mixin","ref":"juju-mixin","sha":"cda32b8fcc7e3db62234effea44098bff094652d","user":{"login":"AdamIsrael","id":125008,"avatar_url":"https://avatars.githubusercontent.com/u/125008?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamIsrael","html_url":"https://github.com/AdamIsrael","followers_url":"https://api.github.com/users/AdamIsrael/followers","following_url":"https://api.github.com/users/AdamIsrael/following{/other_user}","gists_url":"https://api.github.com/users/AdamIsrael/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamIsrael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamIsrael/subscriptions","organizations_url":"https://api.github.com/users/AdamIsrael/orgs","repos_url":"https://api.github.com/users/AdamIsrael/repos","events_url":"https://api.github.com/users/AdamIsrael/events{/privacy}","received_events_url":"https://api.github.com/users/AdamIsrael/received_events","type":"User","site_admin":false},"repo":{"id":40488390,"name":"PerfKitBenchmarker","full_name":"AdamIsrael/PerfKitBenchmarker","owner":{"login":"AdamIsrael","id":125008,"avatar_url":"https://avatars.githubusercontent.com/u/125008?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamIsrael","html_url":"https://github.com/AdamIsrael","followers_url":"https://api.github.com/users/AdamIsrael/followers","following_url":"https://api.github.com/users/AdamIsrael/following{/other_user}","gists_url":"https://api.github.com/users/AdamIsrael/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamIsrael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamIsrael/subscriptions","organizations_url":"https://api.github.com/users/AdamIsrael/orgs","repos_url":"https://api.github.com/users/AdamIsrael/repos","events_url":"https://api.github.com/users/AdamIsrael/events{/privacy}","received_events_url":"https://api.github.com/users/AdamIsrael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdamIsrael/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/releases{/id}","deployments_url":"https://api.github.com/repos/AdamIsrael/PerfKitBenchmarker/deployments","created_at":"2015-08-10T14:55:07Z","updated_at":"2016-01-19T21:23:56Z","pushed_at":"2016-03-04T23:18:23Z","git_url":"git://github.com/AdamIsrael/PerfKitBenchmarker.git","ssh_url":"git@github.com:AdamIsrael/PerfKitBenchmarker.git","clone_url":"https://github.com/AdamIsrael/PerfKitBenchmarker.git","svn_url":"https://github.com/AdamIsrael/PerfKitBenchmarker","homepage":"","size":4370,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"5af843850f0edd152bd0ac78969b740dd3d3e0da","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks use defaults to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/deployments","created_at":"2014-07-17T17:23:26Z","updated_at":"2016-03-09T00:09:48Z","pushed_at":"2016-03-09T23:04:18Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"http://googlecloudplatform.github.io/PerfKitBenchmarker/","size":85124,"stargazers_count":608,"watchers_count":608,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":121,"mirror_url":null,"open_issues_count":117,"forks":121,"open_issues":117,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/764"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/764"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/cda32b8fcc7e3db62234effea44098bff094652d"}}}}