{"action":"created","comment":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/59142815","id":59142815,"diff_hunk":"@@ -126,7 +127,7 @@ public static File stringToHtml(String inxml, String infilexsl, String outfilena\n \t\t\t\t\tbw = new BufferedWriter(new FileWriter(outfilename + \"-orig.xml\"));\r\n \t\t\t\t\tbw.write(inxml);\r\n \t\t\t\t} catch (IOException e2) {\r\n-\t\t\t\t\tlogger.error(e.getMessage(), e);\r\n+\t\t\t\t\tlogger.error(Constant.messages.getString(\"report.write.diskspace.error.log.message\"), e);\r","path":"src/org/parosproxy/paros/extension/report/ReportGenerator.java","position":13,"original_position":13,"commit_id":"6d982a58934c7ad69364651f642be7a52c6ff1b4","original_commit_id":"6d982a58934c7ad69364651f642be7a52c6ff1b4","user":{"login":"kingthorin","id":7570458,"avatar_url":"https://avatars.githubusercontent.com/u/7570458?v=3","gravatar_id":"","url":"https://api.github.com/users/kingthorin","html_url":"https://github.com/kingthorin","followers_url":"https://api.github.com/users/kingthorin/followers","following_url":"https://api.github.com/users/kingthorin/following{/other_user}","gists_url":"https://api.github.com/users/kingthorin/gists{/gist_id}","starred_url":"https://api.github.com/users/kingthorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingthorin/subscriptions","organizations_url":"https://api.github.com/users/kingthorin/orgs","repos_url":"https://api.github.com/users/kingthorin/repos","events_url":"https://api.github.com/users/kingthorin/events{/privacy}","received_events_url":"https://api.github.com/users/kingthorin/received_events","type":"User","site_admin":false},"body":"From a usability perspective should we also pop a message dialog here? There is a small chance that a huge report might be written where the 5MB warning wouldn't be seen...","created_at":"2016-04-10T22:28:07Z","updated_at":"2016-04-10T22:28:07Z","html_url":"https://github.com/zaproxy/zaproxy/pull/2376#discussion_r59142815","pull_request_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376","_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/59142815"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/2376#discussion_r59142815"},"pull_request":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376"}}},"pull_request":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376","id":65403281,"html_url":"https://github.com/zaproxy/zaproxy/pull/2376","diff_url":"https://github.com/zaproxy/zaproxy/pull/2376.diff","patch_url":"https://github.com/zaproxy/zaproxy/pull/2376.patch","issue_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/2376","number":2376,"state":"open","locked":false,"title":"Issue 2127 Fixes IOException","user":{"login":"mustafa421","id":13444975,"avatar_url":"https://avatars.githubusercontent.com/u/13444975?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafa421","html_url":"https://github.com/mustafa421","followers_url":"https://api.github.com/users/mustafa421/followers","following_url":"https://api.github.com/users/mustafa421/following{/other_user}","gists_url":"https://api.github.com/users/mustafa421/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafa421/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafa421/subscriptions","organizations_url":"https://api.github.com/users/mustafa421/orgs","repos_url":"https://api.github.com/users/mustafa421/repos","events_url":"https://api.github.com/users/mustafa421/events{/privacy}","received_events_url":"https://api.github.com/users/mustafa421/received_events","type":"User","site_admin":false},"body":"This is a rather small and simple fix for #2127 . However, it checks if there is available disk space prior to saving any results. Previously, ZAP attempts to save the file anyway which lead to an IOException being thrown that wasn't properly handled. I haven't internationalized the text just yet, because I'd like to get opinions. Please let me know if I'm missing something or should look into something else as well. Thoughts :) @psiinon @thc202 @kingthorin ","created_at":"2016-04-06T02:55:58Z","updated_at":"2016-04-10T22:28:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b109474dc2c6811567095b5b714de1db900bd38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376/commits","review_comments_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376/comments","review_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/2376/comments","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/6d982a58934c7ad69364651f642be7a52c6ff1b4","head":{"label":"mustafa421:fixIOException2127","ref":"fixIOException2127","sha":"6d982a58934c7ad69364651f642be7a52c6ff1b4","user":{"login":"mustafa421","id":13444975,"avatar_url":"https://avatars.githubusercontent.com/u/13444975?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafa421","html_url":"https://github.com/mustafa421","followers_url":"https://api.github.com/users/mustafa421/followers","following_url":"https://api.github.com/users/mustafa421/following{/other_user}","gists_url":"https://api.github.com/users/mustafa421/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafa421/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafa421/subscriptions","organizations_url":"https://api.github.com/users/mustafa421/orgs","repos_url":"https://api.github.com/users/mustafa421/repos","events_url":"https://api.github.com/users/mustafa421/events{/privacy}","received_events_url":"https://api.github.com/users/mustafa421/received_events","type":"User","site_admin":false},"repo":{"id":53004542,"name":"zaproxy","full_name":"mustafa421/zaproxy","owner":{"login":"mustafa421","id":13444975,"avatar_url":"https://avatars.githubusercontent.com/u/13444975?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafa421","html_url":"https://github.com/mustafa421","followers_url":"https://api.github.com/users/mustafa421/followers","following_url":"https://api.github.com/users/mustafa421/following{/other_user}","gists_url":"https://api.github.com/users/mustafa421/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafa421/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafa421/subscriptions","organizations_url":"https://api.github.com/users/mustafa421/orgs","repos_url":"https://api.github.com/users/mustafa421/repos","events_url":"https://api.github.com/users/mustafa421/events{/privacy}","received_events_url":"https://api.github.com/users/mustafa421/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mustafa421/zaproxy","description":"The OWASP ZAP core project","fork":true,"url":"https://api.github.com/repos/mustafa421/zaproxy","forks_url":"https://api.github.com/repos/mustafa421/zaproxy/forks","keys_url":"https://api.github.com/repos/mustafa421/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mustafa421/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mustafa421/zaproxy/teams","hooks_url":"https://api.github.com/repos/mustafa421/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/mustafa421/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/mustafa421/zaproxy/events","assignees_url":"https://api.github.com/repos/mustafa421/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/mustafa421/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/mustafa421/zaproxy/tags","blobs_url":"https://api.github.com/repos/mustafa421/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mustafa421/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mustafa421/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mustafa421/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mustafa421/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mustafa421/zaproxy/languages","stargazers_url":"https://api.github.com/repos/mustafa421/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/mustafa421/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/mustafa421/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/mustafa421/zaproxy/subscription","commits_url":"https://api.github.com/repos/mustafa421/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mustafa421/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mustafa421/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mustafa421/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mustafa421/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/mustafa421/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mustafa421/zaproxy/merges","archive_url":"https://api.github.com/repos/mustafa421/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mustafa421/zaproxy/downloads","issues_url":"https://api.github.com/repos/mustafa421/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/mustafa421/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mustafa421/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mustafa421/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mustafa421/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/mustafa421/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/mustafa421/zaproxy/deployments","created_at":"2016-03-02T23:33:22Z","updated_at":"2016-03-02T23:33:28Z","pushed_at":"2016-04-08T23:34:23Z","git_url":"git://github.com/mustafa421/zaproxy.git","ssh_url":"git@github.com:mustafa421/zaproxy.git","clone_url":"https://github.com/mustafa421/zaproxy.git","svn_url":"https://github.com/mustafa421/zaproxy","homepage":null,"size":162654,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zaproxy:develop","ref":"develop","sha":"31af8a58c80b1aaf68398c50e91641f833d89d40","user":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars.githubusercontent.com/u/6716868?v=3","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":36817565,"name":"zaproxy","full_name":"zaproxy/zaproxy","owner":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars.githubusercontent.com/u/6716868?v=3","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zaproxy/zaproxy","description":"The OWASP ZAP core project","fork":false,"url":"https://api.github.com/repos/zaproxy/zaproxy","forks_url":"https://api.github.com/repos/zaproxy/zaproxy/forks","keys_url":"https://api.github.com/repos/zaproxy/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaproxy/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaproxy/zaproxy/teams","hooks_url":"https://api.github.com/repos/zaproxy/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/zaproxy/zaproxy/events","assignees_url":"https://api.github.com/repos/zaproxy/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/zaproxy/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/zaproxy/zaproxy/tags","blobs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaproxy/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaproxy/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/zaproxy/zaproxy/languages","stargazers_url":"https://api.github.com/repos/zaproxy/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/zaproxy/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/zaproxy/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/zaproxy/zaproxy/subscription","commits_url":"https://api.github.com/repos/zaproxy/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaproxy/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaproxy/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/zaproxy/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaproxy/zaproxy/merges","archive_url":"https://api.github.com/repos/zaproxy/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaproxy/zaproxy/downloads","issues_url":"https://api.github.com/repos/zaproxy/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/zaproxy/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/zaproxy/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaproxy/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/zaproxy/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/zaproxy/zaproxy/deployments","created_at":"2015-06-03T16:55:01Z","updated_at":"2016-04-10T11:25:28Z","pushed_at":"2016-04-10T18:51:07Z","git_url":"git://github.com/zaproxy/zaproxy.git","ssh_url":"git@github.com:zaproxy/zaproxy.git","clone_url":"https://github.com/zaproxy/zaproxy.git","svn_url":"https://github.com/zaproxy/zaproxy","homepage":null,"size":166634,"stargazers_count":1004,"watchers_count":1004,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"open_issues_count":478,"forks":228,"open_issues":478,"watchers":1004,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/2376"},"issue":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/2376"},"comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/2376/comments"},"review_comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376/comments"},"review_comment":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2376/commits"},"statuses":{"href":"https://api.github.com/repos/zaproxy/zaproxy/statuses/6d982a58934c7ad69364651f642be7a52c6ff1b4"}}}}