{"action":"opened","number":2774,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/2774","id":58794733,"html_url":"https://github.com/qgis/QGIS/pull/2774","diff_url":"https://github.com/qgis/QGIS/pull/2774.diff","patch_url":"https://github.com/qgis/QGIS/pull/2774.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/2774","number":2774,"state":"open","locked":false,"title":"[Processing] Fix ParameterNumber float detection (with unit tests).","user":{"login":"medspx","id":8571115,"avatar_url":"https://avatars.githubusercontent.com/u/8571115?v=3","gravatar_id":"","url":"https://api.github.com/users/medspx","html_url":"https://github.com/medspx","followers_url":"https://api.github.com/users/medspx/followers","following_url":"https://api.github.com/users/medspx/following{/other_user}","gists_url":"https://api.github.com/users/medspx/gists{/gist_id}","starred_url":"https://api.github.com/users/medspx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medspx/subscriptions","organizations_url":"https://api.github.com/users/medspx/orgs","repos_url":"https://api.github.com/users/medspx/repos","events_url":"https://api.github.com/users/medspx/events{/privacy}","received_events_url":"https://api.github.com/users/medspx/received_events","type":"User","site_admin":false},"body":"Since 7754f17a0b25b7cfd4ed6a281aa52552895aadb0 , there is a bug in Processing for float detection of ParameterNumber objects. Every float ParameterNumber is considered integer, leading to the inability to properly set a float value for any Processing algorithms (value is always rounded to an integer in the dialog boxes).\r\n\r\nI've reverted the mistake and I have added a new dedicated unit test for this, to be sure it will not be broken in the future...\r\n\r\nI think that this is an important fix for 2.14...\r\n\r\nThanks @volaya, @alexbruy, @rldhont  !","created_at":"2016-02-09T19:17:43Z","updated_at":"2016-02-09T19:17:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/2774/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/2774/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/2774/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/5d19a3b21b614fb05c45f7c2830d954972766b14","head":{"label":"medspx:processing_fix_parameternumber","ref":"processing_fix_parameternumber","sha":"5d19a3b21b614fb05c45f7c2830d954972766b14","user":{"login":"medspx","id":8571115,"avatar_url":"https://avatars.githubusercontent.com/u/8571115?v=3","gravatar_id":"","url":"https://api.github.com/users/medspx","html_url":"https://github.com/medspx","followers_url":"https://api.github.com/users/medspx/followers","following_url":"https://api.github.com/users/medspx/following{/other_user}","gists_url":"https://api.github.com/users/medspx/gists{/gist_id}","starred_url":"https://api.github.com/users/medspx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medspx/subscriptions","organizations_url":"https://api.github.com/users/medspx/orgs","repos_url":"https://api.github.com/users/medspx/repos","events_url":"https://api.github.com/users/medspx/events{/privacy}","received_events_url":"https://api.github.com/users/medspx/received_events","type":"User","site_admin":false},"repo":{"id":46168388,"name":"QGIS","full_name":"medspx/QGIS","owner":{"login":"medspx","id":8571115,"avatar_url":"https://avatars.githubusercontent.com/u/8571115?v=3","gravatar_id":"","url":"https://api.github.com/users/medspx","html_url":"https://github.com/medspx","followers_url":"https://api.github.com/users/medspx/followers","following_url":"https://api.github.com/users/medspx/following{/other_user}","gists_url":"https://api.github.com/users/medspx/gists{/gist_id}","starred_url":"https://api.github.com/users/medspx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medspx/subscriptions","organizations_url":"https://api.github.com/users/medspx/orgs","repos_url":"https://api.github.com/users/medspx/repos","events_url":"https://api.github.com/users/medspx/events{/privacy}","received_events_url":"https://api.github.com/users/medspx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/medspx/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/medspx/QGIS","forks_url":"https://api.github.com/repos/medspx/QGIS/forks","keys_url":"https://api.github.com/repos/medspx/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/medspx/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/medspx/QGIS/teams","hooks_url":"https://api.github.com/repos/medspx/QGIS/hooks","issue_events_url":"https://api.github.com/repos/medspx/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/medspx/QGIS/events","assignees_url":"https://api.github.com/repos/medspx/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/medspx/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/medspx/QGIS/tags","blobs_url":"https://api.github.com/repos/medspx/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/medspx/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/medspx/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/medspx/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/medspx/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/medspx/QGIS/languages","stargazers_url":"https://api.github.com/repos/medspx/QGIS/stargazers","contributors_url":"https://api.github.com/repos/medspx/QGIS/contributors","subscribers_url":"https://api.github.com/repos/medspx/QGIS/subscribers","subscription_url":"https://api.github.com/repos/medspx/QGIS/subscription","commits_url":"https://api.github.com/repos/medspx/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/medspx/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/medspx/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/medspx/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/medspx/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/medspx/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/medspx/QGIS/merges","archive_url":"https://api.github.com/repos/medspx/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/medspx/QGIS/downloads","issues_url":"https://api.github.com/repos/medspx/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/medspx/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/medspx/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/medspx/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/medspx/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/medspx/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/medspx/QGIS/deployments","created_at":"2015-11-14T09:07:55Z","updated_at":"2016-01-20T09:22:43Z","pushed_at":"2016-02-09T19:08:12Z","git_url":"git://github.com/medspx/QGIS.git","ssh_url":"git@github.com:medspx/QGIS.git","clone_url":"https://github.com/medspx/QGIS.git","svn_url":"https://github.com/medspx/QGIS","homepage":"http://qgis.org","size":1208806,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"d11c689eeaf894ebfc982f9661527d9599a8bf11","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2016-02-09T16:11:47Z","pushed_at":"2016-02-09T16:54:55Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1237651,"stargazers_count":867,"watchers_count":867,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":783,"mirror_url":null,"open_issues_count":61,"forks":783,"open_issues":61,"watchers":867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2774"},"html":{"href":"https://github.com/qgis/QGIS/pull/2774"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/2774"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/2774/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2774/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2774/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/5d19a3b21b614fb05c45f7c2830d954972766b14"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":2,"changed_files":2}}