{"action":"created","comment":{"url":"https://api.github.com/repos/deis/builder/pulls/comments/56086531","id":56086531,"diff_hunk":"@@ -2,91 +2,70 @@\n \n [![Build Status](https://travis-ci.org/deis/builder.svg?branch=master)](https://travis-ci.org/deis/builder) [![Go Report Card](http://goreportcard.com/badge/deis/builder)](http://goreportcard.com/report/deis/builder) [![Docker Repository on Quay](https://quay.io/repository/deisci/builder/status \"Docker Repository on Quay\")](https://quay.io/repository/deisci/builder)\n \n-Deis (pronounced DAY-iss) is an open source PaaS that makes it easy to deploy and manage\n-applications on your own servers. Deis builds on [Kubernetes](http://kubernetes.io/) to provide\n-a lightweight, [Heroku-inspired](http://heroku.com) workflow.\n+Deis (pronounced DAY-iss) is an open source PaaS that makes it easy to deploy and manage applications on your own servers. Deis builds on [Kubernetes](http://kubernetes.io/) to provide a lightweight, easy and secure way to deploy your code to production.\n \n-## Work in Progress\n+## Beta Status\n \n-![Deis Graphic](https://s3-us-west-2.amazonaws.com/get-deis/deis-graphic-small.png)\n-\n-Deis Builder v2 is changing quickly. Your feedback and participation are more than welcome, but be\n-aware that this project is considered a work in progress.\n+This Deis component is currently in beta status, and we welcome your input! If you have feedback, please [submit an issue](https://github.com/deis/builder/issues). If you'd like to participate in development, please read the \"Development\" section below and [submit a pull request](https://github.com/deis/builder/pulls).\n \n # About\n \n-This package provides a the Deis Builder, a git server to respond to `git push`es from clients. When it receives a push, it takes the following high level steps:\n+The builder is primarily a git server that responds to `git push`es from clients. When it receives a push, it takes the below high level steps in order.\n \n-1. Accepts the code and writes to the local file system\n+1. Accepts the code and writes it to the local file system\n 2. Calls `git archive` to produce a tarball (i.e. a `.tar.gz` file) on the local file system\n-3. Saves the tarball according to the following rules:\n-  - If the `DEIS_MINIO_SERVICE_HOST` and `DEIS_MINIO_SERVICE_PORT` environment variables exist, uses the [`mc`](https://github.com/minio/mc) client to save to the [Minio](https://github.com/minio/minio) server at `http://$DEIS_MINIO_SERVICE_HOST:$DEIS_MINIO_SERVICE_HOST`\n-  - Otherwise, if the `DEIS_OUTSIDE_STORAGE_HOST` and `DEIS_OUTSIDE_STORAGE_PORT` environment variables exist, uses the [`mc`](https://github.com/minio/mc) client to save to S3 server (or server that adheres to the S3 API) at `https://$DEIS_OUTSIDE_STORAGE_HOST:$DEIS_OUTSIDE_STORAGE_PORT` (this functionality is currently waiting for merge at https://github.com/deis/builder/pull/21).\n-4. Starts a builder pod according to these rules:\n-  - If a `Dockerfile` is present, starts a [`dockerbuilder`](https://github.com/deis/dockerbuilder) pod, configured to download the code to build from the URL computed in the previous step (`dockerbuilder` and Dockerfile builder are not currently supported. See https://github.com/deis/dockerbuilder/pull/1 for prototype `dockerbuilder` code).\n+3. Saves the tarball to centralized object storage according to the following rules:\n+  - If the `DEIS_MINIO_SERVICE_HOST` and `DEIS_MINIO_SERVICE_PORT` environment variables exist, saves to the [S3 API](http://docs.aws.amazon.com/AmazonS3/latest/API/APIRest.html) compatible server at `http://$DEIS_MINIO_SERVICE_HOST:$DEIS_MINIO_SERVICE_HOST`\n+  - Otherwise, if the `DEIS_OUTSIDE_STORAGE` environment variable exists, saves to `https://$DEIS_OUTSIDE_STORAGE`.\n+4. Starts a new [Kubernetes Pod](http://kubernetes.io/docs/user-guide/pods/) to build the code, according to the following rules:\n+  - If a `Dockerfile` is present in the codebase, starts a [`dockerbuilder`](https://github.com/deis/dockerbuilder) pod, configured to download the code to build from the URL computed in the previous step.\n   - Otherwise, starts a [`slugbuilder`](https://github.com/deis/slugbuilder) pod, configured to download the code to build from the URL computed in the previous step.\n \n-# Hacking Builder\n+# Development\n+\n+The Deis project welcomes contributions from all developers. The high level process for development matches many other open source projects. See below for an outline.\n+\n+* Fork this repository\n+* Make your changes\n+* [Submit a pull request](https://github.com/deis/builder/pulls) (PR) to this repository with your changes, and unit tests whenever possible.\n+\t* If your PR fixes any [issues](https://github.com/deis/builder/issues), make sure you write `Fixes #1234` in your PR description (where `#1234` is the number of the issue you're closing)\n+* The Deis core contributors will review your code. After each of them sign off on your code, they'll label your PR with `LGTM1` and `LGTM2` (respectively). Once that happens, you may merge.\n+\n+## Docker Based Development Environment\n \n-First, install [helm](http://helm.sh) and [boot up a kubernetes cluster][install-k8s]. Next, add the\n-`deis` repository to your chart list:\n+The preferred environment for development uses [the `go-dev` Docker image](https://github.com/deis/docker-go-dev). The tools described in this section to build, test, package and release each version of Deis.","path":"README.md","position":null,"original_position":53,"commit_id":"f7bc75c9e6d5ab9fbff8c2785c2d53b2c7095f9f","original_commit_id":"7cbafb130f7554839d99acaca92a29b199624d3f","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"body":"oops, thanks for the catch. fixed in f7bc75c9e6d5ab9fbff8c2785c2d53b2c7095f9f","created_at":"2016-03-14T22:21:06Z","updated_at":"2016-03-14T22:21:06Z","html_url":"https://github.com/deis/builder/pull/256#discussion_r56086531","pull_request_url":"https://api.github.com/repos/deis/builder/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/deis/builder/pulls/comments/56086531"},"html":{"href":"https://github.com/deis/builder/pull/256#discussion_r56086531"},"pull_request":{"href":"https://api.github.com/repos/deis/builder/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/deis/builder/pulls/256","id":62799317,"html_url":"https://github.com/deis/builder/pull/256","diff_url":"https://github.com/deis/builder/pull/256.diff","patch_url":"https://github.com/deis/builder/pull/256.patch","issue_url":"https://api.github.com/repos/deis/builder/issues/256","number":256,"state":"open","locked":false,"title":"docs(README.md): update docs to match beta status","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"body":"Also:\r\n\r\n- Offloads many of the installation and testing instructions to the e2e tests and the official docs\r\n- Includes more detail on how to set up and use the development environment\r\n  - Includes details on the native `go` toolchain development environment (as an alternative to the docker based dev env)\r\n- Adds 2016 to the copyright\r\n\r\nOnce this change is merged, I'll make similar changes on the READMEs of other repositories.\r\n\r\ncc/ @mboersma @slack ","created_at":"2016-03-14T18:57:08Z","updated_at":"2016-03-14T22:21:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d275ebf96c5bfe19ddb00db4d3458daa30d6659a","assignee":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/builder/milestones/2","html_url":"https://github.com/deis/builder/milestones/v2.0-beta1","labels_url":"https://api.github.com/repos/deis/builder/milestones/2/labels","id":1459775,"number":2,"title":"v2.0-beta1","description":"","creator":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":99,"state":"open","created_at":"2015-12-14T17:56:43Z","updated_at":"2016-03-14T18:57:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/deis/builder/pulls/256/commits","review_comments_url":"https://api.github.com/repos/deis/builder/pulls/256/comments","review_comment_url":"https://api.github.com/repos/deis/builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/builder/issues/256/comments","statuses_url":"https://api.github.com/repos/deis/builder/statuses/f7bc75c9e6d5ab9fbff8c2785c2d53b2c7095f9f","head":{"label":"arschles:readme-beta","ref":"readme-beta","sha":"f7bc75c9e6d5ab9fbff8c2785c2d53b2c7095f9f","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"repo":{"id":46528663,"name":"deis-builder","full_name":"arschles/deis-builder","owner":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arschles/deis-builder","description":"[MIRROR] The Deis Buildpack / Dockerfile builder","fork":true,"url":"https://api.github.com/repos/arschles/deis-builder","forks_url":"https://api.github.com/repos/arschles/deis-builder/forks","keys_url":"https://api.github.com/repos/arschles/deis-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arschles/deis-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arschles/deis-builder/teams","hooks_url":"https://api.github.com/repos/arschles/deis-builder/hooks","issue_events_url":"https://api.github.com/repos/arschles/deis-builder/issues/events{/number}","events_url":"https://api.github.com/repos/arschles/deis-builder/events","assignees_url":"https://api.github.com/repos/arschles/deis-builder/assignees{/user}","branches_url":"https://api.github.com/repos/arschles/deis-builder/branches{/branch}","tags_url":"https://api.github.com/repos/arschles/deis-builder/tags","blobs_url":"https://api.github.com/repos/arschles/deis-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arschles/deis-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arschles/deis-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/arschles/deis-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arschles/deis-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/arschles/deis-builder/languages","stargazers_url":"https://api.github.com/repos/arschles/deis-builder/stargazers","contributors_url":"https://api.github.com/repos/arschles/deis-builder/contributors","subscribers_url":"https://api.github.com/repos/arschles/deis-builder/subscribers","subscription_url":"https://api.github.com/repos/arschles/deis-builder/subscription","commits_url":"https://api.github.com/repos/arschles/deis-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/arschles/deis-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/arschles/deis-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/arschles/deis-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/arschles/deis-builder/contents/{+path}","compare_url":"https://api.github.com/repos/arschles/deis-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arschles/deis-builder/merges","archive_url":"https://api.github.com/repos/arschles/deis-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arschles/deis-builder/downloads","issues_url":"https://api.github.com/repos/arschles/deis-builder/issues{/number}","pulls_url":"https://api.github.com/repos/arschles/deis-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/arschles/deis-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/arschles/deis-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arschles/deis-builder/labels{/name}","releases_url":"https://api.github.com/repos/arschles/deis-builder/releases{/id}","deployments_url":"https://api.github.com/repos/arschles/deis-builder/deployments","created_at":"2015-11-20T00:24:34Z","updated_at":"2016-02-04T16:37:34Z","pushed_at":"2016-03-14T22:20:44Z","git_url":"git://github.com/arschles/deis-builder.git","ssh_url":"git@github.com:arschles/deis-builder.git","clone_url":"https://github.com/arschles/deis-builder.git","svn_url":"https://github.com/arschles/deis-builder","homepage":"https://github.com/deis/builder","size":52722,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dockerbuilder"}},"base":{"label":"deis:master","ref":"master","sha":"fdb79a9af8d64908d4cd3073a5d4a0b2f9ed4e7a","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":44639329,"name":"builder","full_name":"deis/builder","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/builder","description":"Heroku buildpack builder for Deis v2","fork":false,"url":"https://api.github.com/repos/deis/builder","forks_url":"https://api.github.com/repos/deis/builder/forks","keys_url":"https://api.github.com/repos/deis/builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/builder/teams","hooks_url":"https://api.github.com/repos/deis/builder/hooks","issue_events_url":"https://api.github.com/repos/deis/builder/issues/events{/number}","events_url":"https://api.github.com/repos/deis/builder/events","assignees_url":"https://api.github.com/repos/deis/builder/assignees{/user}","branches_url":"https://api.github.com/repos/deis/builder/branches{/branch}","tags_url":"https://api.github.com/repos/deis/builder/tags","blobs_url":"https://api.github.com/repos/deis/builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/builder/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/builder/languages","stargazers_url":"https://api.github.com/repos/deis/builder/stargazers","contributors_url":"https://api.github.com/repos/deis/builder/contributors","subscribers_url":"https://api.github.com/repos/deis/builder/subscribers","subscription_url":"https://api.github.com/repos/deis/builder/subscription","commits_url":"https://api.github.com/repos/deis/builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/builder/contents/{+path}","compare_url":"https://api.github.com/repos/deis/builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/builder/merges","archive_url":"https://api.github.com/repos/deis/builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/builder/downloads","issues_url":"https://api.github.com/repos/deis/builder/issues{/number}","pulls_url":"https://api.github.com/repos/deis/builder/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/builder/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/builder/labels{/name}","releases_url":"https://api.github.com/repos/deis/builder/releases{/id}","deployments_url":"https://api.github.com/repos/deis/builder/deployments","created_at":"2015-10-20T22:49:18Z","updated_at":"2016-02-18T22:24:49Z","pushed_at":"2016-03-14T22:20:45Z","git_url":"git://github.com/deis/builder.git","ssh_url":"git@github.com:deis/builder.git","clone_url":"https://github.com/deis/builder.git","svn_url":"https://github.com/deis/builder","homepage":"http://deis.io","size":52728,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":55,"forks":16,"open_issues":55,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/builder/pulls/256"},"html":{"href":"https://github.com/deis/builder/pull/256"},"issue":{"href":"https://api.github.com/repos/deis/builder/issues/256"},"comments":{"href":"https://api.github.com/repos/deis/builder/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/builder/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/builder/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/deis/builder/statuses/f7bc75c9e6d5ab9fbff8c2785c2d53b2c7095f9f"}}}}