{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/1730","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/1730/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1730/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/1730/events","html_url":"https://github.com/apache/zeppelin/pull/1730","id":193764841,"number":1730,"title":"[ZEPPELIN-1736] Introduce trash & enable removing folder","user":{"login":"tae-jun","id":8201019,"avatar_url":"https://avatars.githubusercontent.com/u/8201019?v=3","gravatar_id":"","url":"https://api.github.com/users/tae-jun","html_url":"https://github.com/tae-jun","followers_url":"https://api.github.com/users/tae-jun/followers","following_url":"https://api.github.com/users/tae-jun/following{/other_user}","gists_url":"https://api.github.com/users/tae-jun/gists{/gist_id}","starred_url":"https://api.github.com/users/tae-jun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tae-jun/subscriptions","organizations_url":"https://api.github.com/users/tae-jun/orgs","repos_url":"https://api.github.com/users/tae-jun/repos","events_url":"https://api.github.com/users/tae-jun/events{/privacy}","received_events_url":"https://api.github.com/users/tae-jun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-06T12:52:42Z","updated_at":"2016-12-06T14:48:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1730","html_url":"https://github.com/apache/zeppelin/pull/1730","diff_url":"https://github.com/apache/zeppelin/pull/1730.diff","patch_url":"https://github.com/apache/zeppelin/pull/1730.patch"},"body":"### What is this PR for?\r\n![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)\r\nThis PR introduces the trash! (which is essential, I think ^^;)\r\n\r\nI added basic operations of the trash:\r\n#### Added operations of trash\r\n* `Move` a folder to the trash\r\n* `Move` a note to the trash\r\n* `Restore` a folder\r\n* `Restore` a note\r\n* `Remove` a folder in the trash for good\r\n* `Remove` a note in the trash for good\r\n* `Empty` the trash\r\n* `Restore all` in the trash\r\n* `Move` a note to the trash from the notebook view\r\n* `Remove` a note to the trash for good from the notebook view\r\n* If there is a folder that has the same name, suffix current data rather than just merging(please see screenshot below!)\r\n\r\n\r\n### What type of PR is it?\r\n[Feature]\r\n\r\n### Future work\r\nMaybe it would be better if notebook view notices that a note is in the trash.\r\n\r\n### What is the Jira issue?\r\n[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)\r\n\r\n### How should this be tested?\r\n* Build this PR\r\n* Move some folders or notes to the trash\r\n* Restore them\r\n* Empty the trash\r\n* Restore all notes in the trash\r\n* Remove folders or notes in the trash\r\n* Remove a folder which has the same folder name in the trash\r\n\r\n### Screenshots (if appropriate)\r\n## Move, restore, remove a note from the main page\r\n![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)\r\n\r\n## Move, restore, remove a folder from the main page\r\n![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)\r\n\r\n## Move, remove a note from the notebook view\r\n![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)\r\n\r\n## Restore, empty the trash\r\n![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)\r\n\r\n## Suffix current date if the folder exists in the trash\r\n![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)\r\n\r\n### Questions:\r\n* Does the licenses files need update? NO\r\n* Is there breaking changes for older versions? NO\r\n* Does this needs documentation? NO\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/265168103","html_url":"https://github.com/apache/zeppelin/pull/1730#issuecomment-265168103","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1730","id":265168103,"user":{"login":"tae-jun","id":8201019,"avatar_url":"https://avatars.githubusercontent.com/u/8201019?v=3","gravatar_id":"","url":"https://api.github.com/users/tae-jun","html_url":"https://github.com/tae-jun","followers_url":"https://api.github.com/users/tae-jun/followers","following_url":"https://api.github.com/users/tae-jun/following{/other_user}","gists_url":"https://api.github.com/users/tae-jun/gists{/gist_id}","starred_url":"https://api.github.com/users/tae-jun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tae-jun/subscriptions","organizations_url":"https://api.github.com/users/tae-jun/orgs","repos_url":"https://api.github.com/users/tae-jun/repos","events_url":"https://api.github.com/users/tae-jun/events{/privacy}","received_events_url":"https://api.github.com/users/tae-jun/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T14:48:15Z","updated_at":"2016-12-06T14:48:15Z","body":"![image](https://cloud.githubusercontent.com/assets/8201019/20929471/8897948a-bc0d-11e6-941b-4123bc09c8a7.png)\r\nIt failed only at Selenium test twice. I guess it's because I **changed the action of remove note button** of notebook view to moving to trash.\r\n\r\nBut I have no idea where to fix! 😢 Please help!"}}
{"actor":{"display_login":"tae-jun"}}