{"action":"created","issue":{"url":"https://api.github.com/repos/apache/storm/issues/1642","repository_url":"https://api.github.com/repos/apache/storm","labels_url":"https://api.github.com/repos/apache/storm/issues/1642/labels{/name}","comments_url":"https://api.github.com/repos/apache/storm/issues/1642/comments","events_url":"https://api.github.com/repos/apache/storm/issues/1642/events","html_url":"https://github.com/apache/storm/pull/1642","id":172543343,"number":1642,"title":"STORM-2018: Supervisor V2.  ","user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-08-22T20:12:47Z","updated_at":"2016-09-05T20:38:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1642","html_url":"https://github.com/apache/storm/pull/1642","diff_url":"https://github.com/apache/storm/pull/1642.diff","patch_url":"https://github.com/apache/storm/pull/1642.patch"},"body":"Still needs run as user and CGroup work, but the rest is working\r\n\r\nAny feedback on this would be welcome.  I am particularly interested in the readability of the code and how easy is it to understand vs the original supervisor.\r\n\r\nAll the unit tests pass and I have done a lot of manual testing switching back and forth between the original supervisor and supervisor V2 to ensure that this can be a rolling upgrade.\r\n\r\nThere are still a number of TODOs in the code.  Most of them are for removing the original supervisor code and cleaning up the result of that."},"comment":{"url":"https://api.github.com/repos/apache/storm/issues/comments/244808981","html_url":"https://github.com/apache/storm/pull/1642#issuecomment-244808981","issue_url":"https://api.github.com/repos/apache/storm/issues/1642","id":244808981,"user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T20:38:26Z","updated_at":"2016-09-05T20:38:26Z","body":"Not sure what has been happening with travis not being able to get to the apache maven repo all the time, but my build in travis passed https://travis-ci.org/revans2/incubator-storm/builds/157725399 despite the official build failing."}}
{"actor":{"display_login":"revans2"}}