{"push_id":1211960034,"size":5,"distinct_size":5,"ref":"refs/heads/ticket/stable/PUP-6499-puppet-resource-user-fails-on-French-Windows","head":"2e697c31561ae1fd62a4348af152e96ac4d3a737","before":"6f0ccdcbe9586eb4a117ce6ae27edcfb1cd9210c","commits":[{"sha":"e91f0bb727c5e26fea815a6c923f417199867e81","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-6499) Ensure WIN32OLE objects emit UTF-8\n\n - When retrieving the names of users / groups and their attributes\n   through WMI, Ruby will unfortunately convert any returned strings\n   into the local codepage (Default.external_encoding) instead of\n   converting the values from UTF-16LE to UTF-8 for internal\n   consumption.\n\n   This then causes problems with Puppets logging when attempting to\n   combine strings that are in UTF-8 and the local encoding.  This was\n   observed on French Windows where the default encoding is CP850.\n\n   Without these changes `puppet resource user` will fail to run with\n   the error:\n\nError: Could not run: incompatible character encodings: UTF-8 and CP850\n\n - Add some tests demonstrating the encoding is set appropriately in\n   the results returned from the ADSI provider.\n\n - Note that the [] attribute reader on User is re-encoding string\n   values returned by IAdsUser.Get (that Ruby has encoded in the\n   local codepage).  It's assumed that callers of []= are already\n   supplying UTF-8 strings for the attribute name and value where\n   appropriate (and Ruby should be translating these to UTF-16LE to\n   call the real APIs) and thus no conversions are necessary here.","distinct":true,"url":"https://api.github.com/repos/Iristyle/puppet/commits/e91f0bb727c5e26fea815a6c923f417199867e81"},{"sha":"25dabd8db8c622e553f7ca04cdd029fb25291449","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(maint) Add ADSI test for WinNT SYSTEM moniker\n\n - Shows that the Puppet::Util::Windows::ADSI::User class is not\n   capable of using BUILTIN style accounts like SYSTEM. The same holds\n   true for any user from the S-1-5 authority.","distinct":true,"url":"https://api.github.com/repos/Iristyle/puppet/commits/25dabd8db8c622e553f7ca04cdd029fb25291449"},{"sha":"2ac91f6e8d4510c023699d5e63bd1b7c922e98d1","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-6499) Add Windows::ADSI.current_user_sid\n\n - This method is primarily added for tests, to remove the use of\n   hardcoded string values (which do not always work properly for\n   internationalized versions of Windows) and instead use well known\n   SID byte arrays for comparison","distinct":true,"url":"https://api.github.com/repos/Iristyle/puppet/commits/2ac91f6e8d4510c023699d5e63bd1b7c922e98d1"},{"sha":"c3ee274e8966475306e5fcbd79f60adcfd22bde3","author":{"name":"Iristyle","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-6499) Fix French Windows user / group tests","distinct":true,"url":"https://api.github.com/repos/Iristyle/puppet/commits/c3ee274e8966475306e5fcbd79f60adcfd22bde3"},{"sha":"2e697c31561ae1fd62a4348af152e96ac4d3a737","author":{"name":"Iristyle","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"WindowsInstaller emits local codepage strings instead of UTF-8","distinct":true,"url":"https://api.github.com/repos/Iristyle/puppet/commits/2e697c31561ae1fd62a4348af152e96ac4d3a737"}]}
{"actor":{"display_login":"Iristyle"}}