{"action":"created","comment":{"url":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments/73039406","id":73039406,"diff_hunk":"@@ -32,18 +33,16 @@ const App = React.createClass({\n   },\n \n   componentDidMount() {\n-    window.addEventListener(\"keydown\", this.toggleSourcesSearch, false);\n+    this.shortcuts = new KeyShortcuts({ window });\n+    this.shortcuts.on(\"Cmd+P\", this.toggleSourcesSearch, { preventDefault: true });\n   },\n \n   componentWillUnmount() {\n-    window.removeEventListener(\"keydown\", this.toggleSourcesSearch, false);\n+    this.shortcuts.off(\"Cmd+P\", this.toggleSourcesSearch);","path":"public/js/components/App.js","position":19,"original_position":19,"commit_id":"ad6448c3a537faa450a40bb52a5a171c8a10ef0e","original_commit_id":"ad6448c3a537faa450a40bb52a5a171c8a10ef0e","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"Thanks. Good suggestion. ","created_at":"2016-08-01T19:39:50Z","updated_at":"2016-08-01T19:39:50Z","html_url":"https://github.com/jlongster/debugger.html/pull/453#discussion_r73039406","pull_request_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/453","_links":{"self":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments/73039406"},"html":{"href":"https://github.com/jlongster/debugger.html/pull/453#discussion_r73039406"},"pull_request":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/jlongster/debugger.html/pulls/453","id":79618218,"html_url":"https://github.com/jlongster/debugger.html/pull/453","diff_url":"https://github.com/jlongster/debugger.html/pull/453.diff","patch_url":"https://github.com/jlongster/debugger.html/pull/453.patch","issue_url":"https://api.github.com/repos/jlongster/debugger.html/issues/453","number":453,"state":"open","locked":false,"title":"Add Key Shortcuts library","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"Fixes #360.\r\n\r\nThis PR adds the key-shortcuts library, Services Shim, and EventEmitter.\r\n\r\nNotes:\r\n+ key shortcuts library gives us an api for setting keyboard events. It did not support preventDefault, so i added a patch that I will also land in m-c.\r\n+ services shim - adds lots of useful properties that are de-privileged. I'm most excited about prefs. Prefs however tried tor read local storage items with the assumption that they were all JSON parseable, which was not the case because todomvc shoves some random stuff in there. Consequently I moved the debugger examples to port 7999.\r\n+ EventEmitter is a general purpose utility in m-c. It is being added to our utils directory because I had to rip out the `logEvent` function which assumes dump is available. There's also a lot of factory setup, which is not necessary. We might be able to reconcile these changes by injecting a dump console.log with webpack's define plugin if we want to\r\n","created_at":"2016-08-01T19:00:09Z","updated_at":"2016-08-01T19:39:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7575b2af1a92915f4f55a9b5806fa45a0cf216a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/453/commits","review_comments_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/453/comments","review_comment_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jlongster/debugger.html/issues/453/comments","statuses_url":"https://api.github.com/repos/jlongster/debugger.html/statuses/ad6448c3a537faa450a40bb52a5a171c8a10ef0e","head":{"label":"jasonLaster:shortcuts","ref":"shortcuts","sha":"ad6448c3a537faa450a40bb52a5a171c8a10ef0e","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"repo":{"id":55007537,"name":"debugger.html","full_name":"jasonLaster/debugger.html","owner":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonLaster/debugger.html","description":"Experimental something something.","fork":true,"url":"https://api.github.com/repos/jasonLaster/debugger.html","forks_url":"https://api.github.com/repos/jasonLaster/debugger.html/forks","keys_url":"https://api.github.com/repos/jasonLaster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonLaster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonLaster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jasonLaster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jasonLaster/debugger.html/events","assignees_url":"https://api.github.com/repos/jasonLaster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jasonLaster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonLaster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonLaster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jasonLaster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jasonLaster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonLaster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonLaster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jasonLaster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonLaster/debugger.html/merges","archive_url":"https://api.github.com/repos/jasonLaster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonLaster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jasonLaster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonLaster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonLaster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonLaster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jasonLaster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jasonLaster/debugger.html/deployments","created_at":"2016-03-29T20:14:57Z","updated_at":"2016-06-29T11:17:41Z","pushed_at":"2016-08-01T18:54:48Z","git_url":"git://github.com/jasonLaster/debugger.html.git","ssh_url":"git@github.com:jasonLaster/debugger.html.git","clone_url":"https://github.com/jasonLaster/debugger.html.git","svn_url":"https://github.com/jasonLaster/debugger.html","homepage":null,"size":2370,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"jlongster:master","ref":"master","sha":"c5eb486798c41b0c423e86054d91922ac3c27164","user":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"jlongster/debugger.html","owner":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlongster/debugger.html","description":"An experimental debugger interface.","fork":false,"url":"https://api.github.com/repos/jlongster/debugger.html","forks_url":"https://api.github.com/repos/jlongster/debugger.html/forks","keys_url":"https://api.github.com/repos/jlongster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlongster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlongster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jlongster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jlongster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jlongster/debugger.html/events","assignees_url":"https://api.github.com/repos/jlongster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jlongster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jlongster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jlongster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlongster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlongster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlongster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlongster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jlongster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jlongster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jlongster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jlongster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jlongster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jlongster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlongster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlongster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlongster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlongster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jlongster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlongster/debugger.html/merges","archive_url":"https://api.github.com/repos/jlongster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlongster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jlongster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jlongster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jlongster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jlongster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlongster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jlongster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jlongster/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2016-08-01T00:28:59Z","pushed_at":"2016-08-01T19:31:48Z","git_url":"git://github.com/jlongster/debugger.html.git","ssh_url":"git@github.com:jlongster/debugger.html.git","clone_url":"https://github.com/jlongster/debugger.html.git","svn_url":"https://github.com/jlongster/debugger.html","homepage":"","size":2433,"stargazers_count":94,"watchers_count":94,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":52,"forks":27,"open_issues":52,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/453"},"html":{"href":"https://github.com/jlongster/debugger.html/pull/453"},"issue":{"href":"https://api.github.com/repos/jlongster/debugger.html/issues/453"},"comments":{"href":"https://api.github.com/repos/jlongster/debugger.html/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/jlongster/debugger.html/statuses/ad6448c3a537faa450a40bb52a5a171c8a10ef0e"}}}}
{"actor":{"display_login":"jasonLaster"}}