{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/3900","repository_url":"https://api.github.com/repos/Particular/NServiceBus","labels_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3900/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3900/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3900/events","html_url":"https://github.com/Particular/NServiceBus/pull/3900","id":163434633,"number":3900,"title":"[WIP] Auto enable instance mapping","user":{"login":"timbussmann","id":3524870,"avatar_url":"https://avatars.githubusercontent.com/u/3524870?v=3","gravatar_id":"","url":"https://api.github.com/users/timbussmann","html_url":"https://github.com/timbussmann","followers_url":"https://api.github.com/users/timbussmann/followers","following_url":"https://api.github.com/users/timbussmann/following{/other_user}","gists_url":"https://api.github.com/users/timbussmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timbussmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbussmann/subscriptions","organizations_url":"https://api.github.com/users/timbussmann/orgs","repos_url":"https://api.github.com/users/timbussmann/repos","events_url":"https://api.github.com/users/timbussmann/events{/privacy}","received_events_url":"https://api.github.com/users/timbussmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-01T16:52:32Z","updated_at":"2016-07-05T22:12:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3900","html_url":"https://github.com/Particular/NServiceBus/pull/3900","diff_url":"https://github.com/Particular/NServiceBus/pull/3900.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3900.patch"},"body":"Connects to Particular/V6Launch#68\r\n\r\nChanges:\r\n\r\n* Change schema to allow empty `endpoints` and `endpoint` elements\r\n* Only use one attempt to read instance mapping file. If it fails it will blow at startup or try again after the configured checkInterval. Is there a valid scenario which requires the `maxLoadAttempts` configuration?\r\n* Load mapping file initially during feature setup for validation and initial data purpose\r\n* uses AppDomain.CurrentDomain.BaseDirectory as root path for relative mapping file paths\r\n* Open mapping file with `FileShare.Read` instead of `FileShare.ReadWrite`, not sure about that, is there any reason for ReadWrite?\r\n* remove `FileBasedEndpointInstanceMapping`\r\n* Auto-enables the mapping file when using Msmq transport\r\n  * it will not read the file and not set up dynamic rules when there is no file at startup time (can be empty though)\r\n  * if a file is found, the dynamic rule is added and a timer will constantly reread the mapping file\r\n\r\nTodos:\r\n\r\n* [x] Cleanup mapping file in tests\r\n* [ ] Avoid dynamic rules and other performance impacts when no instance mapping file is used.\r\n* [x] Add API for custom mapping file path\r\n* [ ] Update docs to changed API"},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments/230618417","html_url":"https://github.com/Particular/NServiceBus/pull/3900#issuecomment-230618417","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3900","id":230618417,"user":{"login":"bording","id":753669,"avatar_url":"https://avatars.githubusercontent.com/u/753669?v=3","gravatar_id":"","url":"https://api.github.com/users/bording","html_url":"https://github.com/bording","followers_url":"https://api.github.com/users/bording/followers","following_url":"https://api.github.com/users/bording/following{/other_user}","gists_url":"https://api.github.com/users/bording/gists{/gist_id}","starred_url":"https://api.github.com/users/bording/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bording/subscriptions","organizations_url":"https://api.github.com/users/bording/orgs","repos_url":"https://api.github.com/users/bording/repos","events_url":"https://api.github.com/users/bording/events{/privacy}","received_events_url":"https://api.github.com/users/bording/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T22:12:41Z","updated_at":"2016-07-05T22:12:41Z","body":"Looking at @DavidBoike's list of items for this: https://github.com/Particular/PlatformDevelopment/issues/843#issuecomment-225480840\r\n\r\nIs there anything else in that list that we want to do here? The logging stuff in item 4 seems useful."}}
{"actor":{"display_login":"bording"}}