{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/80372825","id":80372825,"diff_hunk":"@@ -76,10 +77,15 @@ def test_if_uiconfig_is_available(cluster):\n \n \n def test_if_dcos_history_service_is_up(cluster):\n-    r = cluster.get('/dcos-history-service/ping')\n \n-    assert r.status_code == 200\n-    assert 'pong' == r.text\n+    @retry(stop_max_delay=20000, wait_fixed=500)","path":"packages/dcos-integration-test/extra/test_endpoints.py","position":16,"original_position":16,"commit_id":"4feb2d8fedf45912d7d6d55a9d84544119610a7f","original_commit_id":"4feb2d8fedf45912d7d6d55a9d84544119610a7f","user":{"login":"cmaloney","id":751088,"avatar_url":"https://avatars.githubusercontent.com/u/751088?v=3","gravatar_id":"","url":"https://api.github.com/users/cmaloney","html_url":"https://github.com/cmaloney","followers_url":"https://api.github.com/users/cmaloney/followers","following_url":"https://api.github.com/users/cmaloney/following{/other_user}","gists_url":"https://api.github.com/users/cmaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaloney/subscriptions","organizations_url":"https://api.github.com/users/cmaloney/orgs","repos_url":"https://api.github.com/users/cmaloney/repos","events_url":"https://api.github.com/users/cmaloney/events{/privacy}","received_events_url":"https://api.github.com/users/cmaloney/received_events","type":"User","site_admin":false},"body":"The nginx / adminrouter actually forwards / load balances to all master.mesos addresses: https://github.com/dcos/adminrouter/blob/master/nginx.master.conf#L17\r\n\r\nso by hitting adminrouter, adminrouter sends it to one instance mor or less at random","created_at":"2016-09-25T02:31:15Z","updated_at":"2016-09-25T02:31:16Z","html_url":"https://github.com/dcos/dcos/pull/749#discussion_r80372825","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/749","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/80372825"},"html":{"href":"https://github.com/dcos/dcos/pull/749#discussion_r80372825"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/749"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/749","id":85875772,"html_url":"https://github.com/dcos/dcos/pull/749","diff_url":"https://github.com/dcos/dcos/pull/749.diff","patch_url":"https://github.com/dcos/dcos/pull/749.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/749","number":749,"state":"open","locked":false,"title":"WIP: Handle connection error on dcos-history","user":{"login":"amitaekbote","id":4984257,"avatar_url":"https://avatars.githubusercontent.com/u/4984257?v=3","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false},"body":"When running dcos-history, if the flask app cannot bind to the port assigned it does not fail and keeps retrying. Using gunicorn ensures that the app fails and master is marked unhealthy.\r\n\r\nhttps://mesosphere.atlassian.net/browse/DCOS-5334 \r\n\r\nUnit tests passed\r\nSyntax test passed","created_at":"2016-09-19T21:47:30Z","updated_at":"2016-09-25T02:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c5faff3ab37c3ed86a454fb1539f0f3488c22b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/749/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/749/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/749/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/4feb2d8fedf45912d7d6d55a9d84544119610a7f","head":{"label":"amitaekbote:dcos_history","ref":"dcos_history","sha":"4feb2d8fedf45912d7d6d55a9d84544119610a7f","user":{"login":"amitaekbote","id":4984257,"avatar_url":"https://avatars.githubusercontent.com/u/4984257?v=3","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false},"repo":{"id":68128573,"name":"dcos","full_name":"amitaekbote/dcos","owner":{"login":"amitaekbote","id":4984257,"avatar_url":"https://avatars.githubusercontent.com/u/4984257?v=3","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amitaekbote/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/amitaekbote/dcos","forks_url":"https://api.github.com/repos/amitaekbote/dcos/forks","keys_url":"https://api.github.com/repos/amitaekbote/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amitaekbote/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amitaekbote/dcos/teams","hooks_url":"https://api.github.com/repos/amitaekbote/dcos/hooks","issue_events_url":"https://api.github.com/repos/amitaekbote/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/amitaekbote/dcos/events","assignees_url":"https://api.github.com/repos/amitaekbote/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/amitaekbote/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/amitaekbote/dcos/tags","blobs_url":"https://api.github.com/repos/amitaekbote/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amitaekbote/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amitaekbote/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/amitaekbote/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amitaekbote/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/amitaekbote/dcos/languages","stargazers_url":"https://api.github.com/repos/amitaekbote/dcos/stargazers","contributors_url":"https://api.github.com/repos/amitaekbote/dcos/contributors","subscribers_url":"https://api.github.com/repos/amitaekbote/dcos/subscribers","subscription_url":"https://api.github.com/repos/amitaekbote/dcos/subscription","commits_url":"https://api.github.com/repos/amitaekbote/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/amitaekbote/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/amitaekbote/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/amitaekbote/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/amitaekbote/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/amitaekbote/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amitaekbote/dcos/merges","archive_url":"https://api.github.com/repos/amitaekbote/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amitaekbote/dcos/downloads","issues_url":"https://api.github.com/repos/amitaekbote/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/amitaekbote/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/amitaekbote/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/amitaekbote/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amitaekbote/dcos/labels{/name}","releases_url":"https://api.github.com/repos/amitaekbote/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/amitaekbote/dcos/deployments","created_at":"2016-09-13T16:55:45Z","updated_at":"2016-09-13T16:55:46Z","pushed_at":"2016-09-24T00:45:18Z","git_url":"git://github.com/amitaekbote/dcos.git","ssh_url":"git@github.com:amitaekbote/dcos.git","clone_url":"https://github.com/amitaekbote/dcos.git","svn_url":"https://github.com/amitaekbote/dcos","homepage":"https://dcos.io","size":1802,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"64dbda9e80a70a3a7fb5d5ab45c439c7a71904c6","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2016-09-24T09:14:25Z","pushed_at":"2016-09-24T00:45:19Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":2681,"stargazers_count":904,"watchers_count":904,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":36,"forks":160,"open_issues":36,"watchers":904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/749"},"html":{"href":"https://github.com/dcos/dcos/pull/749"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/749"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/749/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/749/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/749/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/4feb2d8fedf45912d7d6d55a9d84544119610a7f"}}}}
{"actor":{"display_login":"cmaloney"}}