{"action":"created","issue":{"url":"https://api.github.com/repos/adplug/adplug/issues/45","repository_url":"https://api.github.com/repos/adplug/adplug","labels_url":"https://api.github.com/repos/adplug/adplug/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/adplug/adplug/issues/45/comments","events_url":"https://api.github.com/repos/adplug/adplug/issues/45/events","html_url":"https://github.com/adplug/adplug/issues/45","id":187511592,"number":45,"title":"Missing CMF Effects","user":{"login":"thecoreyburton","id":12134368,"avatar_url":"https://avatars.githubusercontent.com/u/12134368?v=3","gravatar_id":"","url":"https://api.github.com/users/thecoreyburton","html_url":"https://github.com/thecoreyburton","followers_url":"https://api.github.com/users/thecoreyburton/followers","following_url":"https://api.github.com/users/thecoreyburton/following{/other_user}","gists_url":"https://api.github.com/users/thecoreyburton/gists{/gist_id}","starred_url":"https://api.github.com/users/thecoreyburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecoreyburton/subscriptions","organizations_url":"https://api.github.com/users/thecoreyburton/orgs","repos_url":"https://api.github.com/users/thecoreyburton/repos","events_url":"https://api.github.com/users/thecoreyburton/events{/privacy}","received_events_url":"https://api.github.com/users/thecoreyburton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-05T17:40:35Z","updated_at":"2016-11-17T22:56:26Z","closed_at":"2016-11-06T10:20:38Z","body":"\"I have noticed another difference: the lead/pad voice has no chorus-like effect in AdPlug, so the same voice sounds better using SBFMDRV driver. But this is for another issue.\" - @binarymaster @ https://github.com/adplug/adplug/issues/41\r\n\r\nIn addition to this comment, whilst I was listening to \"song_d.xr0\" I noticed that notes also seem to be lacking another effect as well. Just after 4:14 in the following link, you'll hear the last note of each small section is repeated several times and gradually fades out: https://www.youtube.com/watch?v=6It3k8sodu4\r\n\r\nWhereas when using AdPlug this effect seems to be missing and the notes are repeated at a consistent, full volume."},"comment":{"url":"https://api.github.com/repos/adplug/adplug/issues/comments/261396532","html_url":"https://github.com/adplug/adplug/issues/45#issuecomment-261396532","issue_url":"https://api.github.com/repos/adplug/adplug/issues/45","id":261396532,"user":{"login":"binarymaster","id":578406,"avatar_url":"https://avatars.githubusercontent.com/u/578406?v=3","gravatar_id":"","url":"https://api.github.com/users/binarymaster","html_url":"https://github.com/binarymaster","followers_url":"https://api.github.com/users/binarymaster/followers","following_url":"https://api.github.com/users/binarymaster/following{/other_user}","gists_url":"https://api.github.com/users/binarymaster/gists{/gist_id}","starred_url":"https://api.github.com/users/binarymaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarymaster/subscriptions","organizations_url":"https://api.github.com/users/binarymaster/orgs","repos_url":"https://api.github.com/users/binarymaster/repos","events_url":"https://api.github.com/users/binarymaster/events{/privacy}","received_events_url":"https://api.github.com/users/binarymaster/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T22:56:26Z","updated_at":"2016-11-17T22:56:26Z","body":"I've added a fix for transpose effect:\r\n- Note transposition is related to a MIDI channel (pretty same as Pitch Bend), not a whole song\r\n- Division by an integer (`this->iTranspose / 128`) was incorrect\r\n\r\nHowever there is another unresolved problem - transpose controller must modify already playing note frequencies in realtime. The same goes for Pitch Bend events.\r\n\r\nAlso I attached sample CMF files that use dynamic frequency changes:\r\n- 1.cmf - uses vibrato at 0:52\r\n- 2.cmf - uses portamento-down at 0:57\r\n\r\n[CMF.zip](https://github.com/adplug/adplug/files/598669/CMF_zip.txt)"}}
{"actor":{"display_login":"binarymaster"}}