{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/7721","repository_url":"https://api.github.com/repos/mozilla/pdf.js","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7721/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7721/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7721/events","html_url":"https://github.com/mozilla/pdf.js/pull/7721","id":182923570,"number":7721,"title":"Add work-around to get printing in OOP frames to work in Chrome","user":{"login":"Rob--W","id":1365071,"avatar_url":"https://avatars.githubusercontent.com/u/1365071?v=3","gravatar_id":"","url":"https://api.github.com/users/Rob--W","html_url":"https://github.com/Rob--W","followers_url":"https://api.github.com/users/Rob--W/followers","following_url":"https://api.github.com/users/Rob--W/following{/other_user}","gists_url":"https://api.github.com/users/Rob--W/gists{/gist_id}","starred_url":"https://api.github.com/users/Rob--W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rob--W/subscriptions","organizations_url":"https://api.github.com/users/Rob--W/orgs","repos_url":"https://api.github.com/users/Rob--W/repos","events_url":"https://api.github.com/users/Rob--W/events{/privacy}","received_events_url":"https://api.github.com/users/Rob--W/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-chrome-specific","name":"4-chrome-specific","color":"e102d8"},{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-printing","name":"4-printing","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"assignees":[{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-13T22:49:57Z","updated_at":"2016-10-16T12:11:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7721","html_url":"https://github.com/mozilla/pdf.js/pull/7721","diff_url":"https://github.com/mozilla/pdf.js/pull/7721.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/7721.patch"},"body":"Fixes #7706\r\nFixes #7720\r\n\r\nI suggest to review the three commits separately, since they are kind of independent.\r\n\r\n@yurydelendik Can you take a look at the first two commits? They are a kind of follow-up to your previous patch at #7697.\r\n\r\nAbout half of the third commit are comments to explain what it does. Its commit message also includes steps for testing. @timvandermeij Could you review the third commit?"},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/254043383","html_url":"https://github.com/mozilla/pdf.js/pull/7721#issuecomment-254043383","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7721","id":254043383,"user":{"login":"Rob--W","id":1365071,"avatar_url":"https://avatars.githubusercontent.com/u/1365071?v=3","gravatar_id":"","url":"https://api.github.com/users/Rob--W","html_url":"https://github.com/Rob--W","followers_url":"https://api.github.com/users/Rob--W/followers","following_url":"https://api.github.com/users/Rob--W/following{/other_user}","gists_url":"https://api.github.com/users/Rob--W/gists{/gist_id}","starred_url":"https://api.github.com/users/Rob--W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rob--W/subscriptions","organizations_url":"https://api.github.com/users/Rob--W/orgs","repos_url":"https://api.github.com/users/Rob--W/repos","events_url":"https://api.github.com/users/Rob--W/events{/privacy}","received_events_url":"https://api.github.com/users/Rob--W/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T12:11:23Z","updated_at":"2016-10-16T12:11:23Z","body":"@timvandermeij Done. Please take a look.\r\n\r\nThe `topContentScript` and `forwardPrintResults` implement the non-trivial Chrome extension communication logic, whereas `processPrintJob` and anything below `getStyleSheetTextForPrinting` implements print/PDF.js. I'm sure that you're able to review the second part, but if you have difficulty with going through the first part I would totally understand (hopefully the ~200 lines of explanatory comments clarifies things a little bit)."}}
{"actor":{"display_login":"Rob--W"}}