{"action":"created","comment":{"url":"https://api.github.com/repos/ethz-asl/infinitam/pulls/comments/92803031","pull_request_review_id":13324465,"id":92803031,"diff_hunk":"@@ -98,11 +98,11 @@ IF(WITH_CUDA)\n   target_link_libraries(InfiniTAM ${CUDA_LIBRARIES})\n ENDIF()\n \n-add_executable(InfiniTAM_node InfiniTAM_node.cpp)\n-target_link_libraries(InfiniTAM_node Engine)\n-target_link_libraries(InfiniTAM_node Utils)\n+add_executable(infinitam_ros_node infinitam_ros_node.cpp)","path":"InfiniTAM/CMakeLists.txt","position":7,"original_position":7,"commit_id":"0f003f1eac08e2b2df7dfba99097feb88cf676dd","original_commit_id":"0f003f1eac08e2b2df7dfba99097feb88cf676dd","user":{"login":"ffurrer","id":917816,"avatar_url":"https://avatars.githubusercontent.com/u/917816?v=3","gravatar_id":"","url":"https://api.github.com/users/ffurrer","html_url":"https://github.com/ffurrer","followers_url":"https://api.github.com/users/ffurrer/followers","following_url":"https://api.github.com/users/ffurrer/following{/other_user}","gists_url":"https://api.github.com/users/ffurrer/gists{/gist_id}","starred_url":"https://api.github.com/users/ffurrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffurrer/subscriptions","organizations_url":"https://api.github.com/users/ffurrer/orgs","repos_url":"https://api.github.com/users/ffurrer/repos","events_url":"https://api.github.com/users/ffurrer/events{/privacy}","received_events_url":"https://api.github.com/users/ffurrer/received_events","type":"User","site_admin":false},"body":"if you use catkin simple, use cs_add_exectuable\r\n\r\nremove the `find_package(glog_catkin REQUIRED)` and similar commands... they are invoked by catkin simple if you set them as dependecies.\r\n\r\nIn general, make sure that the pull-request builds on jenkins.","created_at":"2016-12-16T12:24:26Z","updated_at":"2016-12-16T12:24:26Z","html_url":"https://github.com/ethz-asl/infinitam/pull/5#discussion_r92803031","pull_request_url":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/infinitam/pulls/comments/92803031"},"html":{"href":"https://github.com/ethz-asl/infinitam/pull/5#discussion_r92803031"},"pull_request":{"href":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5","id":97737092,"html_url":"https://github.com/ethz-asl/infinitam/pull/5","diff_url":"https://github.com/ethz-asl/infinitam/pull/5.diff","patch_url":"https://github.com/ethz-asl/infinitam/pull/5.patch","issue_url":"https://api.github.com/repos/ethz-asl/infinitam/issues/5","number":5,"state":"open","locked":false,"title":"Feature/external tracker","user":{"login":"gocarlos","id":1331762,"avatar_url":"https://avatars.githubusercontent.com/u/1331762?v=3","gravatar_id":"","url":"https://api.github.com/users/gocarlos","html_url":"https://github.com/gocarlos","followers_url":"https://api.github.com/users/gocarlos/followers","following_url":"https://api.github.com/users/gocarlos/following{/other_user}","gists_url":"https://api.github.com/users/gocarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/gocarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocarlos/subscriptions","organizations_url":"https://api.github.com/users/gocarlos/orgs","repos_url":"https://api.github.com/users/gocarlos/repos","events_url":"https://api.github.com/users/gocarlos/events{/privacy}","received_events_url":"https://api.github.com/users/gocarlos/received_events","type":"User","site_admin":false},"body":"In this PR is a first version of the external tracker. \r\nRight now one gets the pose of the camera and feed it directly to the main engine. \r\nIt works pretty well. \r\n\r\nDid also some ROS integration, one can start and stop the infinitam over a service and publish the gathered cloud over a ROS topic. \r\n\r\nThe goal is to use this pose as a first guess with ICP together to get better results. \r\n\r\n","created_at":"2016-12-13T11:59:06Z","updated_at":"2016-12-16T12:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"gocarlos","id":1331762,"avatar_url":"https://avatars.githubusercontent.com/u/1331762?v=3","gravatar_id":"","url":"https://api.github.com/users/gocarlos","html_url":"https://github.com/gocarlos","followers_url":"https://api.github.com/users/gocarlos/followers","following_url":"https://api.github.com/users/gocarlos/following{/other_user}","gists_url":"https://api.github.com/users/gocarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/gocarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocarlos/subscriptions","organizations_url":"https://api.github.com/users/gocarlos/orgs","repos_url":"https://api.github.com/users/gocarlos/repos","events_url":"https://api.github.com/users/gocarlos/events{/privacy}","received_events_url":"https://api.github.com/users/gocarlos/received_events","type":"User","site_admin":false},"assignees":[{"login":"gocarlos","id":1331762,"avatar_url":"https://avatars.githubusercontent.com/u/1331762?v=3","gravatar_id":"","url":"https://api.github.com/users/gocarlos","html_url":"https://github.com/gocarlos","followers_url":"https://api.github.com/users/gocarlos/followers","following_url":"https://api.github.com/users/gocarlos/following{/other_user}","gists_url":"https://api.github.com/users/gocarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/gocarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocarlos/subscriptions","organizations_url":"https://api.github.com/users/gocarlos/orgs","repos_url":"https://api.github.com/users/gocarlos/repos","events_url":"https://api.github.com/users/gocarlos/events{/privacy}","received_events_url":"https://api.github.com/users/gocarlos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ethz-asl/infinitam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethz-asl/infinitam/issues/5/comments","statuses_url":"https://api.github.com/repos/ethz-asl/infinitam/statuses/0f003f1eac08e2b2df7dfba99097feb88cf676dd","head":{"label":"ethz-asl:feature/external_tracker","ref":"feature/external_tracker","sha":"0f003f1eac08e2b2df7dfba99097feb88cf676dd","user":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars.githubusercontent.com/u/475362?v=3","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":72531244,"name":"infinitam","full_name":"ethz-asl/infinitam","owner":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars.githubusercontent.com/u/475362?v=3","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/infinitam","description":"An extended infinitam version with a ROS node","fork":false,"url":"https://api.github.com/repos/ethz-asl/infinitam","forks_url":"https://api.github.com/repos/ethz-asl/infinitam/forks","keys_url":"https://api.github.com/repos/ethz-asl/infinitam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/infinitam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/infinitam/teams","hooks_url":"https://api.github.com/repos/ethz-asl/infinitam/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/infinitam/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/infinitam/events","assignees_url":"https://api.github.com/repos/ethz-asl/infinitam/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/infinitam/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/infinitam/tags","blobs_url":"https://api.github.com/repos/ethz-asl/infinitam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/infinitam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/infinitam/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/infinitam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/infinitam/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/infinitam/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/infinitam/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/infinitam/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/infinitam/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/infinitam/subscription","commits_url":"https://api.github.com/repos/ethz-asl/infinitam/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/infinitam/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/infinitam/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/infinitam/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/infinitam/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/infinitam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/infinitam/merges","archive_url":"https://api.github.com/repos/ethz-asl/infinitam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/infinitam/downloads","issues_url":"https://api.github.com/repos/ethz-asl/infinitam/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/infinitam/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/infinitam/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/infinitam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/infinitam/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/infinitam/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/infinitam/deployments","created_at":"2016-11-01T11:48:56Z","updated_at":"2016-12-14T07:21:27Z","pushed_at":"2016-12-14T21:40:39Z","git_url":"git://github.com/ethz-asl/infinitam.git","ssh_url":"git@github.com:ethz-asl/infinitam.git","clone_url":"https://github.com/ethz-asl/infinitam.git","svn_url":"https://github.com/ethz-asl/infinitam","homepage":null,"size":1169,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"ethz-asl:master","ref":"master","sha":"6e91537fdaa6859416eefb80f3b736bcfd33e769","user":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars.githubusercontent.com/u/475362?v=3","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":72531244,"name":"infinitam","full_name":"ethz-asl/infinitam","owner":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars.githubusercontent.com/u/475362?v=3","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/infinitam","description":"An extended infinitam version with a ROS node","fork":false,"url":"https://api.github.com/repos/ethz-asl/infinitam","forks_url":"https://api.github.com/repos/ethz-asl/infinitam/forks","keys_url":"https://api.github.com/repos/ethz-asl/infinitam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/infinitam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/infinitam/teams","hooks_url":"https://api.github.com/repos/ethz-asl/infinitam/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/infinitam/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/infinitam/events","assignees_url":"https://api.github.com/repos/ethz-asl/infinitam/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/infinitam/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/infinitam/tags","blobs_url":"https://api.github.com/repos/ethz-asl/infinitam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/infinitam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/infinitam/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/infinitam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/infinitam/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/infinitam/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/infinitam/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/infinitam/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/infinitam/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/infinitam/subscription","commits_url":"https://api.github.com/repos/ethz-asl/infinitam/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/infinitam/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/infinitam/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/infinitam/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/infinitam/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/infinitam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/infinitam/merges","archive_url":"https://api.github.com/repos/ethz-asl/infinitam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/infinitam/downloads","issues_url":"https://api.github.com/repos/ethz-asl/infinitam/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/infinitam/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/infinitam/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/infinitam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/infinitam/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/infinitam/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/infinitam/deployments","created_at":"2016-11-01T11:48:56Z","updated_at":"2016-12-14T07:21:27Z","pushed_at":"2016-12-14T21:40:39Z","git_url":"git://github.com/ethz-asl/infinitam.git","ssh_url":"git@github.com:ethz-asl/infinitam.git","clone_url":"https://github.com/ethz-asl/infinitam.git","svn_url":"https://github.com/ethz-asl/infinitam","homepage":null,"size":1169,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5"},"html":{"href":"https://github.com/ethz-asl/infinitam/pull/5"},"issue":{"href":"https://api.github.com/repos/ethz-asl/infinitam/issues/5"},"comments":{"href":"https://api.github.com/repos/ethz-asl/infinitam/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ethz-asl/infinitam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethz-asl/infinitam/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ethz-asl/infinitam/statuses/0f003f1eac08e2b2df7dfba99097feb88cf676dd"}}}}
{"actor":{"display_login":"ffurrer"}}