{"action":"created","issue":{"url":"https://api.github.com/repos/modxcms/revolution/issues/13154","repository_url":"https://api.github.com/repos/modxcms/revolution","labels_url":"https://api.github.com/repos/modxcms/revolution/issues/13154/labels{/name}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/13154/comments","events_url":"https://api.github.com/repos/modxcms/revolution/issues/13154/events","html_url":"https://github.com/modxcms/revolution/pull/13154","id":184571910,"number":13154,"title":"Fix missing connectors/security/ directory for download distributions","user":{"login":"pixelchutes","id":352182,"avatar_url":"https://avatars.githubusercontent.com/u/352182?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelchutes","html_url":"https://github.com/pixelchutes","followers_url":"https://api.github.com/users/pixelchutes/followers","following_url":"https://api.github.com/users/pixelchutes/following{/other_user}","gists_url":"https://api.github.com/users/pixelchutes/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelchutes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelchutes/subscriptions","organizations_url":"https://api.github.com/users/pixelchutes/orgs","repos_url":"https://api.github.com/users/pixelchutes/repos","events_url":"https://api.github.com/users/pixelchutes/events{/privacy}","received_events_url":"https://api.github.com/users/pixelchutes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/modxcms/revolution/labels/area-core","name":"area-core","color":"ededed"},{"url":"https://api.github.com/repos/modxcms/revolution/labels/area-setup","name":"area-setup","color":"ededed"},{"url":"https://api.github.com/repos/modxcms/revolution/labels/bug","name":"bug","color":"fbca04"},{"url":"https://api.github.com/repos/modxcms/revolution/labels/priority-2-high","name":"priority-2-high","color":"ec8285"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/modxcms/revolution/milestones/71","html_url":"https://github.com/modxcms/revolution/milestones/v2.5.2","labels_url":"https://api.github.com/repos/modxcms/revolution/milestones/71/labels","id":1956534,"number":71,"title":"v2.5.2","description":null,"creator":{"login":"Jako","id":148371,"avatar_url":"https://avatars.githubusercontent.com/u/148371?v=3","gravatar_id":"","url":"https://api.github.com/users/Jako","html_url":"https://github.com/Jako","followers_url":"https://api.github.com/users/Jako/followers","following_url":"https://api.github.com/users/Jako/following{/other_user}","gists_url":"https://api.github.com/users/Jako/gists{/gist_id}","starred_url":"https://api.github.com/users/Jako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jako/subscriptions","organizations_url":"https://api.github.com/users/Jako/orgs","repos_url":"https://api.github.com/users/Jako/repos","events_url":"https://api.github.com/users/Jako/events{/privacy}","received_events_url":"https://api.github.com/users/Jako/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":20,"state":"open","created_at":"2016-08-22T22:17:52Z","updated_at":"2016-10-21T21:18:15Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-10-21T21:18:15Z","updated_at":"2016-10-22T22:57:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/13154","html_url":"https://github.com/modxcms/revolution/pull/13154","diff_url":"https://github.com/modxcms/revolution/pull/13154.diff","patch_url":"https://github.com/modxcms/revolution/pull/13154.patch"},"body":"### What does it do?\r\nEnsures **connectors/security/*** is no longer missing for download distribution based installs.\r\n\r\n### Why is it needed?\r\nBecause the expired session / session extension handling relies on it.\r\n\r\n### Related issue(s)/PR(s)\r\nFixes #13144\r\n\r\nReverts 5c9e11ac61826c52e022f9e67869a24424265055 (#13146)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/modxcms/revolution/issues/comments/255559003","html_url":"https://github.com/modxcms/revolution/pull/13154#issuecomment-255559003","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/13154","id":255559003,"user":{"login":"pixelchutes","id":352182,"avatar_url":"https://avatars.githubusercontent.com/u/352182?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelchutes","html_url":"https://github.com/pixelchutes","followers_url":"https://api.github.com/users/pixelchutes/followers","following_url":"https://api.github.com/users/pixelchutes/following{/other_user}","gists_url":"https://api.github.com/users/pixelchutes/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelchutes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelchutes/subscriptions","organizations_url":"https://api.github.com/users/pixelchutes/orgs","repos_url":"https://api.github.com/users/pixelchutes/repos","events_url":"https://api.github.com/users/pixelchutes/events{/privacy}","received_events_url":"https://api.github.com/users/pixelchutes/received_events","type":"User","site_admin":false},"created_at":"2016-10-22T22:57:43Z","updated_at":"2016-10-22T22:57:43Z","body":"For us to support action based connector here, we need to add an explicit check to prevent `401 Unauthorized` error.\r\n\r\nThe alternative (this PR), is to use a legacy connector specifically to re-login.\r\n\r\nThe kicker is, for Git installs the file-based connector (login.php) is _already_ in place. For download distributions (.zip's), it never gets installed and will `404 Not Found`."}}
{"actor":{"display_login":"pixelchutes"}}