{"action":"closed","issue":{"url":"https://api.github.com/repos/daveseah/1401A1/issues/9","repository_url":"https://api.github.com/repos/daveseah/1401A1","labels_url":"https://api.github.com/repos/daveseah/1401A1/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/daveseah/1401A1/issues/9/comments","events_url":"https://api.github.com/repos/daveseah/1401A1/issues/9/events","html_url":"https://github.com/daveseah/1401A1/issues/9","id":176708067,"number":9,"title":"Live Reload does not Live Reload","user":{"login":"daveseah","id":2048828,"avatar_url":"https://avatars.githubusercontent.com/u/2048828?v=3","gravatar_id":"","url":"https://api.github.com/users/daveseah","html_url":"https://github.com/daveseah","followers_url":"https://api.github.com/users/daveseah/followers","following_url":"https://api.github.com/users/daveseah/following{/other_user}","gists_url":"https://api.github.com/users/daveseah/gists{/gist_id}","starred_url":"https://api.github.com/users/daveseah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveseah/subscriptions","organizations_url":"https://api.github.com/users/daveseah/orgs","repos_url":"https://api.github.com/users/daveseah/repos","events_url":"https://api.github.com/users/daveseah/events{/privacy}","received_events_url":"https://api.github.com/users/daveseah/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-13T17:59:29Z","updated_at":"2016-09-13T19:07:04Z","closed_at":"2016-09-13T19:07:04Z","body":"The changes made in pull #7 break livereload functionality. Saving a file in the editor should force the browser to refresh. The server reports that it is working:\r\n```\r\n[11:41:28] Finished 'default' after 66 ms\r\n---------- Live reload of assets is enabled, (port 35729) ----------\r\n---------- VISIT ONE OF THESE URLS in CHROME WEB BROWSER ----------\r\n           LOCAL ... http://localhost:3000\r\n           LAN ..... http://192.168.1.198:3000\r\n[13:38:27] Starting 'copy-assets'...\r\n[13:38:27] Finished 'copy-assets' after 112 ms\r\n         * reload: assets/modules/1401-games/demo/tests/011-webrtc-mirror.js\r\n[13:38:43] Starting 'copy-assets'...\r\n[13:38:43] Finished 'copy-assets' after 75 ms\r\n         * reload: assets/modules/1401-games/demo/tests/011-webrtc-mirror.js\r\n```\r\nHowever, the browser running the app does not refresh automatically as it should.\r\n\r\nThe issue appears to be that while the server side is detecting changes (via the gulp build tool's **watch** feature), the browser is not actually connected to the livereload socket, and therefore never is notified. The refactoring of the server code did not take into account that the configuration data in `gulpfile.js` is not available to be passed to the template engine startup in `1401-server.js`. Specifically, this line in `server/views/index.hbs`:\r\n\r\n```\r\n\t{{#reload}}\r\n\t<script src=\"{{../reloadjs}}\"></script>\r\n\t{{/reload}}\r\n```\r\n"}}
{"actor":{"display_login":"daveseah"}}