{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/69672494","id":69672494,"diff_hunk":"@@ -13,12 +13,25 @@\n  */\n package com.facebook.presto.spi;\n \n+import com.facebook.presto.spi.block.BlockEncodingSerde;\n+import com.facebook.presto.spi.type.TypeManager;\n+\n import java.util.List;\n import java.util.Map;\n \n public interface Plugin\n {\n     default void setOptionalConfig(Map<String, String> optionalConfig) {}\n \n+    default void setTypeManager(TypeManager typeManager) {}\n+\n+    default void setNodeManager(NodeManager nodeManager) {}\n+\n+    default void setBlockEncodingSerde(BlockEncodingSerde blockEncodingSerde) {}","path":"presto-spi/src/main/java/com/facebook/presto/spi/Plugin.java","position":18,"original_position":18,"commit_id":"5ef46d769a0c3e9c7cca27bd4057e0aed3b638f0","original_commit_id":"5ef46d769a0c3e9c7cca27bd4057e0aed3b638f0","user":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?v=3","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"It doesn't seem like a good idea to make all plugin types aware of some of these objects. For example, why would an event listener or auth plugin care about a page sorter?","created_at":"2016-07-06T03:59:43Z","updated_at":"2016-07-06T03:59:43Z","html_url":"https://github.com/prestodb/presto/pull/5577#discussion_r69672494","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/5577","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/69672494"},"html":{"href":"https://github.com/prestodb/presto/pull/5577#discussion_r69672494"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5577"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/5577","id":76369372,"html_url":"https://github.com/prestodb/presto/pull/5577","diff_url":"https://github.com/prestodb/presto/pull/5577.diff","patch_url":"https://github.com/prestodb/presto/pull/5577.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/5577","number":5577,"state":"open","locked":false,"title":"Replace Plugin injection with setters","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-07-06T02:08:14Z","updated_at":"2016-07-06T03:59:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec78af8c3f049ae17cbfe8e5728179b6f9ec4b20","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/5577/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/5577/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/5577/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/5ef46d769a0c3e9c7cca27bd4057e0aed3b638f0","head":{"label":"electrum:plugin","ref":"plugin","sha":"5ef46d769a0c3e9c7cca27bd4057e0aed3b638f0","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"repo":{"id":5446003,"name":"presto","full_name":"electrum/presto","owner":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/electrum/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/electrum/presto","forks_url":"https://api.github.com/repos/electrum/presto/forks","keys_url":"https://api.github.com/repos/electrum/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electrum/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electrum/presto/teams","hooks_url":"https://api.github.com/repos/electrum/presto/hooks","issue_events_url":"https://api.github.com/repos/electrum/presto/issues/events{/number}","events_url":"https://api.github.com/repos/electrum/presto/events","assignees_url":"https://api.github.com/repos/electrum/presto/assignees{/user}","branches_url":"https://api.github.com/repos/electrum/presto/branches{/branch}","tags_url":"https://api.github.com/repos/electrum/presto/tags","blobs_url":"https://api.github.com/repos/electrum/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electrum/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electrum/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/electrum/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electrum/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/electrum/presto/languages","stargazers_url":"https://api.github.com/repos/electrum/presto/stargazers","contributors_url":"https://api.github.com/repos/electrum/presto/contributors","subscribers_url":"https://api.github.com/repos/electrum/presto/subscribers","subscription_url":"https://api.github.com/repos/electrum/presto/subscription","commits_url":"https://api.github.com/repos/electrum/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/electrum/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/electrum/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/electrum/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/electrum/presto/contents/{+path}","compare_url":"https://api.github.com/repos/electrum/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electrum/presto/merges","archive_url":"https://api.github.com/repos/electrum/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electrum/presto/downloads","issues_url":"https://api.github.com/repos/electrum/presto/issues{/number}","pulls_url":"https://api.github.com/repos/electrum/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/electrum/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/electrum/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electrum/presto/labels{/name}","releases_url":"https://api.github.com/repos/electrum/presto/releases{/id}","deployments_url":"https://api.github.com/repos/electrum/presto/deployments","created_at":"2012-08-16T23:46:05Z","updated_at":"2015-05-08T16:10:50Z","pushed_at":"2016-07-06T02:09:57Z","git_url":"git://github.com/electrum/presto.git","ssh_url":"git@github.com:electrum/presto.git","clone_url":"https://github.com/electrum/presto.git","svn_url":"https://github.com/electrum/presto","homepage":"http://prestodb.io/","size":57438,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"ea1d653c4f8333981a12cc420d085413e68c030a","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-07-05T22:49:33Z","pushed_at":"2016-07-06T03:55:15Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":156982,"stargazers_count":4887,"watchers_count":4887,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1467,"mirror_url":null,"open_issues_count":574,"forks":1467,"open_issues":574,"watchers":4887,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5577"},"html":{"href":"https://github.com/prestodb/presto/pull/5577"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/5577"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/5577/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5577/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5577/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/5ef46d769a0c3e9c7cca27bd4057e0aed3b638f0"}}}}
{"actor":{"display_login":"martint"}}