{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/comments/91237109","pull_request_review_id":11745263,"id":91237109,"diff_hunk":"@@ -302,27 +314,61 @@ describe('migrations', function() {\n     });\n   });\n \n-  it('should allow numbers with decimals', function(done) {\n-    // TODO: Default install of MySQL 5.7 returns an error here, which we assert should not happen.\n-    if (/^5\\.7/.test(mysqlVersion)) {\n-      assert.ok(mysqlVersion, 'skipping decimal/number test on mysql 5.7');\n-      return done();\n-    }\n-\n-    NumberData.create({number: 1.1234567, tinyInt: 123456, mediumInt: -1234567,\n-      floater: 123456789.1234567}, function(err, obj) {\n+  // In MySQL 5.6/5.7 Out of range values are rejected.\n+  // Reference: http://dev.mysql.com/doc/refman/5.7/en/integer-types.html\n+  it('should allow numbers with decimals ', function(done) {\n+    NumberData.create({number: 1.1234567, tinyInt: 127, mediumInt: 16777215,\n+      floater: 12345678.123456}, function(err, obj) {\n       assert.ok(!err);","path":"test/migration.test.js","position":79,"original_position":79,"commit_id":"7b9d51bca0a1738dbaf7ea83c4ab8cb9518fea19","original_commit_id":"7b9d51bca0a1738dbaf7ea83c4ab8cb9518fea19","user":{"login":"superkhau","id":1617364,"avatar_url":"https://avatars.githubusercontent.com/u/1617364?v=3","gravatar_id":"","url":"https://api.github.com/users/superkhau","html_url":"https://github.com/superkhau","followers_url":"https://api.github.com/users/superkhau/followers","following_url":"https://api.github.com/users/superkhau/following{/other_user}","gists_url":"https://api.github.com/users/superkhau/gists{/gist_id}","starred_url":"https://api.github.com/users/superkhau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superkhau/subscriptions","organizations_url":"https://api.github.com/users/superkhau/orgs","repos_url":"https://api.github.com/users/superkhau/repos","events_url":"https://api.github.com/users/superkhau/events{/privacy}","received_events_url":"https://api.github.com/users/superkhau/received_events","type":"User","site_admin":false},"body":"if (err) return done(err);","created_at":"2016-12-07T07:12:04Z","updated_at":"2016-12-07T07:14:47Z","html_url":"https://github.com/strongloop/loopback-connector-mysql/pull/211#discussion_r91237109","pull_request_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/comments/91237109"},"html":{"href":"https://github.com/strongloop/loopback-connector-mysql/pull/211#discussion_r91237109"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211","id":91031829,"html_url":"https://github.com/strongloop/loopback-connector-mysql/pull/211","diff_url":"https://github.com/strongloop/loopback-connector-mysql/pull/211.diff","patch_url":"https://github.com/strongloop/loopback-connector-mysql/pull/211.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/211","number":211,"state":"open","locked":false,"title":"Fix CI Failures","user":{"login":"loay","id":1986928,"avatar_url":"https://avatars.githubusercontent.com/u/1986928?v=3","gravatar_id":"","url":"https://api.github.com/users/loay","html_url":"https://github.com/loay","followers_url":"https://api.github.com/users/loay/followers","following_url":"https://api.github.com/users/loay/following{/other_user}","gists_url":"https://api.github.com/users/loay/gists{/gist_id}","starred_url":"https://api.github.com/users/loay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loay/subscriptions","organizations_url":"https://api.github.com/users/loay/orgs","repos_url":"https://api.github.com/users/loay/repos","events_url":"https://api.github.com/users/loay/events{/privacy}","received_events_url":"https://api.github.com/users/loay/received_events","type":"User","site_admin":false},"body":"connect to https://github.com/strongloop-internal/scrum-loopback/issues/1104","created_at":"2016-10-26T15:43:38Z","updated_at":"2016-12-07T07:14:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"433006ca03fda6466f7e676e11f77abef0683175","assignee":{"login":"loay","id":1986928,"avatar_url":"https://avatars.githubusercontent.com/u/1986928?v=3","gravatar_id":"","url":"https://api.github.com/users/loay","html_url":"https://github.com/loay","followers_url":"https://api.github.com/users/loay/followers","following_url":"https://api.github.com/users/loay/following{/other_user}","gists_url":"https://api.github.com/users/loay/gists{/gist_id}","starred_url":"https://api.github.com/users/loay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loay/subscriptions","organizations_url":"https://api.github.com/users/loay/orgs","repos_url":"https://api.github.com/users/loay/repos","events_url":"https://api.github.com/users/loay/events{/privacy}","received_events_url":"https://api.github.com/users/loay/received_events","type":"User","site_admin":false},"assignees":[{"login":"loay","id":1986928,"avatar_url":"https://avatars.githubusercontent.com/u/1986928?v=3","gravatar_id":"","url":"https://api.github.com/users/loay","html_url":"https://github.com/loay","followers_url":"https://api.github.com/users/loay/followers","following_url":"https://api.github.com/users/loay/following{/other_user}","gists_url":"https://api.github.com/users/loay/gists{/gist_id}","starred_url":"https://api.github.com/users/loay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loay/subscriptions","organizations_url":"https://api.github.com/users/loay/orgs","repos_url":"https://api.github.com/users/loay/repos","events_url":"https://api.github.com/users/loay/events{/privacy}","received_events_url":"https://api.github.com/users/loay/received_events","type":"User","site_admin":false},{"login":"b-admike","id":13950637,"avatar_url":"https://avatars.githubusercontent.com/u/13950637?v=3","gravatar_id":"","url":"https://api.github.com/users/b-admike","html_url":"https://github.com/b-admike","followers_url":"https://api.github.com/users/b-admike/followers","following_url":"https://api.github.com/users/b-admike/following{/other_user}","gists_url":"https://api.github.com/users/b-admike/gists{/gist_id}","starred_url":"https://api.github.com/users/b-admike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-admike/subscriptions","organizations_url":"https://api.github.com/users/b-admike/orgs","repos_url":"https://api.github.com/users/b-admike/repos","events_url":"https://api.github.com/users/b-admike/events{/privacy}","received_events_url":"https://api.github.com/users/b-admike/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/211/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/statuses/7b9d51bca0a1738dbaf7ea83c4ab8cb9518fea19","head":{"label":"strongloop:Fix/CI","ref":"Fix/CI","sha":"7b9d51bca0a1738dbaf7ea83c4ab8cb9518fea19","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":11557649,"name":"loopback-connector-mysql","full_name":"strongloop/loopback-connector-mysql","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-connector-mysql","description":"Loopback Connector for MySQL","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-connector-mysql","forks_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/deployments","created_at":"2013-07-21T05:28:58Z","updated_at":"2016-11-25T00:23:26Z","pushed_at":"2016-12-07T03:40:28Z","git_url":"git://github.com/strongloop/loopback-connector-mysql.git","ssh_url":"git@github.com:strongloop/loopback-connector-mysql.git","clone_url":"https://github.com/strongloop/loopback-connector-mysql.git","svn_url":"https://github.com/strongloop/loopback-connector-mysql","homepage":null,"size":673,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":75,"forks":75,"open_issues":75,"watchers":53,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"6a3fc7f2aa9b73687784490c5c48f73fa8fde6e4","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":11557649,"name":"loopback-connector-mysql","full_name":"strongloop/loopback-connector-mysql","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-connector-mysql","description":"Loopback Connector for MySQL","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-connector-mysql","forks_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-connector-mysql/deployments","created_at":"2013-07-21T05:28:58Z","updated_at":"2016-11-25T00:23:26Z","pushed_at":"2016-12-07T03:40:28Z","git_url":"git://github.com/strongloop/loopback-connector-mysql.git","ssh_url":"git@github.com:strongloop/loopback-connector-mysql.git","clone_url":"https://github.com/strongloop/loopback-connector-mysql.git","svn_url":"https://github.com/strongloop/loopback-connector-mysql","homepage":null,"size":673,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":75,"forks":75,"open_issues":75,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211"},"html":{"href":"https://github.com/strongloop/loopback-connector-mysql/pull/211"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/211"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-connector-mysql/statuses/7b9d51bca0a1738dbaf7ea83c4ab8cb9518fea19"}}}}
{"actor":{"display_login":"superkhau"}}