{"action":"created","comment":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/comments/62759824","id":62759824,"diff_hunk":"@@ -362,6 +364,14 @@\n         }\n       });\n \n+  //  keys :: StrMap a -> Array String\n+  var keys = function(strMap) {\n+    if (typeof Object.keys === 'function') return Object.keys(strMap);","path":"index.js","position":null,"original_position":15,"commit_id":"8775d664752df964633d5071bbe35c5cd1236222","original_commit_id":"7070ee8fea74924f1debd436935b6d30fe07bc44","user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars.githubusercontent.com/u/210406?v=3","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"body":"> Mocha runs the tests in parallel\r\n\r\nI don't think that's the case. The problem is that Node itself uses `Object.keys`, so deleting it can cause problems. For example:\r\n\r\n```javascript\r\n> delete Object.keys\r\ntrue\r\n> console.log({})\r\nTypeError: Object.keys is not a function\r\n```\r\n\r\nI don't have a good solution to this problem. The *simplest* option is to remove the \"fast\" path, but I'm open to other suggestions. :)\r\n","created_at":"2016-05-10T21:54:19Z","updated_at":"2016-05-10T21:54:19Z","html_url":"https://github.com/sanctuary-js/sanctuary/pull/214#discussion_r62759824","pull_request_url":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/comments/62759824"},"html":{"href":"https://github.com/sanctuary-js/sanctuary/pull/214#discussion_r62759824"},"pull_request":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214","id":69281352,"html_url":"https://github.com/sanctuary-js/sanctuary/pull/214","diff_url":"https://github.com/sanctuary-js/sanctuary/pull/214.diff","patch_url":"https://github.com/sanctuary-js/sanctuary/pull/214.patch","issue_url":"https://api.github.com/repos/sanctuary-js/sanctuary/issues/214","number":214,"state":"open","locked":false,"title":"Add S.keys and S.values","user":{"login":"svozza","id":8573472,"avatar_url":"https://avatars.githubusercontent.com/u/8573472?v=3","gravatar_id":"","url":"https://api.github.com/users/svozza","html_url":"https://github.com/svozza","followers_url":"https://api.github.com/users/svozza/followers","following_url":"https://api.github.com/users/svozza/following{/other_user}","gists_url":"https://api.github.com/users/svozza/gists{/gist_id}","starred_url":"https://api.github.com/users/svozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svozza/subscriptions","organizations_url":"https://api.github.com/users/svozza/orgs","repos_url":"https://api.github.com/users/svozza/repos","events_url":"https://api.github.com/users/svozza/events{/privacy}","received_events_url":"https://api.github.com/users/svozza/received_events","type":"User","site_admin":false},"body":"Creating a type-safe version of `R.keys` was mentioned in #142 and now that `StrMap` is available I thought I'd road test it a bit. The implementation of this will probably provoke discussion, firstly because I'm using an ES5 only implementation: I find the Ramda implementation far too complicated for what should be a simple function. Secondly, I've chosen not to implement `S.values` in terms of `S.keys` because I don't think it makes sense to pay the penalty of type checking the object twice.","created_at":"2016-05-08T22:11:56Z","updated_at":"2016-05-10T21:54:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00888d00ed2ca8568590d263c0be6cc8e0f3608d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214/commits","review_comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214/comments","review_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary/issues/214/comments","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary/statuses/8775d664752df964633d5071bbe35c5cd1236222","head":{"label":"svozza:keys-values-fn","ref":"keys-values-fn","sha":"8775d664752df964633d5071bbe35c5cd1236222","user":{"login":"svozza","id":8573472,"avatar_url":"https://avatars.githubusercontent.com/u/8573472?v=3","gravatar_id":"","url":"https://api.github.com/users/svozza","html_url":"https://github.com/svozza","followers_url":"https://api.github.com/users/svozza/followers","following_url":"https://api.github.com/users/svozza/following{/other_user}","gists_url":"https://api.github.com/users/svozza/gists{/gist_id}","starred_url":"https://api.github.com/users/svozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svozza/subscriptions","organizations_url":"https://api.github.com/users/svozza/orgs","repos_url":"https://api.github.com/users/svozza/repos","events_url":"https://api.github.com/users/svozza/events{/privacy}","received_events_url":"https://api.github.com/users/svozza/received_events","type":"User","site_admin":false},"repo":{"id":34356599,"name":"sanctuary","full_name":"svozza/sanctuary","owner":{"login":"svozza","id":8573472,"avatar_url":"https://avatars.githubusercontent.com/u/8573472?v=3","gravatar_id":"","url":"https://api.github.com/users/svozza","html_url":"https://github.com/svozza","followers_url":"https://api.github.com/users/svozza/followers","following_url":"https://api.github.com/users/svozza/following{/other_user}","gists_url":"https://api.github.com/users/svozza/gists{/gist_id}","starred_url":"https://api.github.com/users/svozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svozza/subscriptions","organizations_url":"https://api.github.com/users/svozza/orgs","repos_url":"https://api.github.com/users/svozza/repos","events_url":"https://api.github.com/users/svozza/events{/privacy}","received_events_url":"https://api.github.com/users/svozza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svozza/sanctuary","description":":see_no_evil: Refuge from unsafe JavaScript","fork":true,"url":"https://api.github.com/repos/svozza/sanctuary","forks_url":"https://api.github.com/repos/svozza/sanctuary/forks","keys_url":"https://api.github.com/repos/svozza/sanctuary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svozza/sanctuary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svozza/sanctuary/teams","hooks_url":"https://api.github.com/repos/svozza/sanctuary/hooks","issue_events_url":"https://api.github.com/repos/svozza/sanctuary/issues/events{/number}","events_url":"https://api.github.com/repos/svozza/sanctuary/events","assignees_url":"https://api.github.com/repos/svozza/sanctuary/assignees{/user}","branches_url":"https://api.github.com/repos/svozza/sanctuary/branches{/branch}","tags_url":"https://api.github.com/repos/svozza/sanctuary/tags","blobs_url":"https://api.github.com/repos/svozza/sanctuary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svozza/sanctuary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svozza/sanctuary/git/refs{/sha}","trees_url":"https://api.github.com/repos/svozza/sanctuary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svozza/sanctuary/statuses/{sha}","languages_url":"https://api.github.com/repos/svozza/sanctuary/languages","stargazers_url":"https://api.github.com/repos/svozza/sanctuary/stargazers","contributors_url":"https://api.github.com/repos/svozza/sanctuary/contributors","subscribers_url":"https://api.github.com/repos/svozza/sanctuary/subscribers","subscription_url":"https://api.github.com/repos/svozza/sanctuary/subscription","commits_url":"https://api.github.com/repos/svozza/sanctuary/commits{/sha}","git_commits_url":"https://api.github.com/repos/svozza/sanctuary/git/commits{/sha}","comments_url":"https://api.github.com/repos/svozza/sanctuary/comments{/number}","issue_comment_url":"https://api.github.com/repos/svozza/sanctuary/issues/comments{/number}","contents_url":"https://api.github.com/repos/svozza/sanctuary/contents/{+path}","compare_url":"https://api.github.com/repos/svozza/sanctuary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svozza/sanctuary/merges","archive_url":"https://api.github.com/repos/svozza/sanctuary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svozza/sanctuary/downloads","issues_url":"https://api.github.com/repos/svozza/sanctuary/issues{/number}","pulls_url":"https://api.github.com/repos/svozza/sanctuary/pulls{/number}","milestones_url":"https://api.github.com/repos/svozza/sanctuary/milestones{/number}","notifications_url":"https://api.github.com/repos/svozza/sanctuary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svozza/sanctuary/labels{/name}","releases_url":"https://api.github.com/repos/svozza/sanctuary/releases{/id}","deployments_url":"https://api.github.com/repos/svozza/sanctuary/deployments","created_at":"2015-04-21T23:00:05Z","updated_at":"2016-01-15T09:29:34Z","pushed_at":"2016-05-10T19:59:42Z","git_url":"git://github.com/svozza/sanctuary.git","ssh_url":"git@github.com:svozza/sanctuary.git","clone_url":"https://github.com/svozza/sanctuary.git","svn_url":"https://github.com/svozza/sanctuary","homepage":"","size":552,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sanctuary-js:master","ref":"master","sha":"2fb179d8e2088c767bcff19e8a96f57e32183ee2","user":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars.githubusercontent.com/u/18357498?v=3","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"repo":{"id":29455960,"name":"sanctuary","full_name":"sanctuary-js/sanctuary","owner":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars.githubusercontent.com/u/18357498?v=3","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sanctuary-js/sanctuary","description":":see_no_evil: Refuge from unsafe JavaScript","fork":false,"url":"https://api.github.com/repos/sanctuary-js/sanctuary","forks_url":"https://api.github.com/repos/sanctuary-js/sanctuary/forks","keys_url":"https://api.github.com/repos/sanctuary-js/sanctuary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanctuary-js/sanctuary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanctuary-js/sanctuary/teams","hooks_url":"https://api.github.com/repos/sanctuary-js/sanctuary/hooks","issue_events_url":"https://api.github.com/repos/sanctuary-js/sanctuary/issues/events{/number}","events_url":"https://api.github.com/repos/sanctuary-js/sanctuary/events","assignees_url":"https://api.github.com/repos/sanctuary-js/sanctuary/assignees{/user}","branches_url":"https://api.github.com/repos/sanctuary-js/sanctuary/branches{/branch}","tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary/tags","blobs_url":"https://api.github.com/repos/sanctuary-js/sanctuary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanctuary-js/sanctuary/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanctuary-js/sanctuary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary/statuses/{sha}","languages_url":"https://api.github.com/repos/sanctuary-js/sanctuary/languages","stargazers_url":"https://api.github.com/repos/sanctuary-js/sanctuary/stargazers","contributors_url":"https://api.github.com/repos/sanctuary-js/sanctuary/contributors","subscribers_url":"https://api.github.com/repos/sanctuary-js/sanctuary/subscribers","subscription_url":"https://api.github.com/repos/sanctuary-js/sanctuary/subscription","commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanctuary-js/sanctuary/contents/{+path}","compare_url":"https://api.github.com/repos/sanctuary-js/sanctuary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanctuary-js/sanctuary/merges","archive_url":"https://api.github.com/repos/sanctuary-js/sanctuary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanctuary-js/sanctuary/downloads","issues_url":"https://api.github.com/repos/sanctuary-js/sanctuary/issues{/number}","pulls_url":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls{/number}","milestones_url":"https://api.github.com/repos/sanctuary-js/sanctuary/milestones{/number}","notifications_url":"https://api.github.com/repos/sanctuary-js/sanctuary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanctuary-js/sanctuary/labels{/name}","releases_url":"https://api.github.com/repos/sanctuary-js/sanctuary/releases{/id}","deployments_url":"https://api.github.com/repos/sanctuary-js/sanctuary/deployments","created_at":"2015-01-19T05:52:10Z","updated_at":"2016-05-10T12:51:40Z","pushed_at":"2016-05-10T19:59:42Z","git_url":"git://github.com/sanctuary-js/sanctuary.git","ssh_url":"git@github.com:sanctuary-js/sanctuary.git","clone_url":"https://github.com/sanctuary-js/sanctuary.git","svn_url":"https://github.com/sanctuary-js/sanctuary","homepage":"http://sanctuary.js.org","size":818,"stargazers_count":308,"watchers_count":308,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":30,"forks":16,"open_issues":30,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214"},"html":{"href":"https://github.com/sanctuary-js/sanctuary/pull/214"},"issue":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/issues/214"},"comments":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary/statuses/8775d664752df964633d5071bbe35c5cd1236222"}}}}