{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15198","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15198/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15198/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15198/events","html_url":"https://github.com/cms-sw/cmssw/pull/15198","id":165434461,"number":15198,"title":"Fix bugs in code that detects missing ROOT dictionaries","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-approved","name":"core-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":1028,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-07-18T18:18:29Z","due_on":null,"closed_at":null},"comments":28,"created_at":"2016-07-13T22:17:36Z","updated_at":"2016-07-18T20:15:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15198","html_url":"https://github.com/cms-sw/cmssw/pull/15198","diff_url":"https://github.com/cms-sw/cmssw/pull/15198.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15198.patch"},"body":"The changes here started when fixing the bug reported\r\nin issue 14242 where \"std::type_info*\" was incorrectly\r\nbeing reported as the type for missing dictionaries.\r\nWhile working on this, found several other problems in\r\nthis part of the code and made significant revisions to\r\nit.\r\n\r\nOne feature that is new is now dictionaries are checked\r\nfor all consumed types. In addition, the pre-existing\r\nchecking for dictionaries of produced types, present types,\r\nand types selected for output is done in a more consistent\r\nway with better and more consistent error messages.\r\n\r\nThese changes rely on the ROOT function TClass::GetMissingDictionaries\r\nmore than the previous version. A design choice was to\r\nuse this instead of developing and maintaining CMS specific\r\ncode to look for dictionaries for all the constituents\r\nof a class. This ROOT function currently does not work as we\r\nexpect and as part of this effort we submitted bug report\r\nJIRA-8208 to the ROOT bug tracking system. When this bug\r\nis fixed in ROOT the missing dictionary checking will find\r\nmore dictionaries to be missing.\r\n\r\nThis also includes addition of dictionaries necessary for\r\nrunTheMatrix to run successfully with the more thorough\r\ndictionary checking."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/233444784","html_url":"https://github.com/cms-sw/cmssw/pull/15198#issuecomment-233444784","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15198","id":233444784,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T20:15:16Z","updated_at":"2016-07-18T20:15:16Z","body":"Comparison is ready\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15198/14116/summary.html"}}
{"actor":{"display_login":"cmsbuild"}}