{"action":"created","comment":{"url":"https://api.github.com/repos/borisbstyle/betaflight/pulls/comments/61670856","id":61670856,"diff_hunk":"@@ -111,7 +111,7 @@ int32_t applyDeadband(int32_t value, int32_t deadband)\n     return value;\n }\n \n-inline int constrain(int amt, int low, int high)","path":"src/main/common/maths.c","position":4,"original_position":4,"commit_id":"daf1e239ebd8655a9ef32e5a8d98984926808c7c","original_commit_id":"daf1e239ebd8655a9ef32e5a8d98984926808c7c","user":{"login":"aughey","id":12618,"avatar_url":"https://avatars.githubusercontent.com/u/12618?v=3","gravatar_id":"","url":"https://api.github.com/users/aughey","html_url":"https://github.com/aughey","followers_url":"https://api.github.com/users/aughey/followers","following_url":"https://api.github.com/users/aughey/following{/other_user}","gists_url":"https://api.github.com/users/aughey/gists{/gist_id}","starred_url":"https://api.github.com/users/aughey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aughey/subscriptions","organizations_url":"https://api.github.com/users/aughey/orgs","repos_url":"https://api.github.com/users/aughey/repos","events_url":"https://api.github.com/users/aughey/events{/privacy}","received_events_url":"https://api.github.com/users/aughey/received_events","type":"User","site_admin":false},"body":"The source for constrain must be in a .h file for other .c files to use it.  To inline, compilers must have the source for the function available.  Inline is only a suggestion, so it's not actually being inlined, except for maybe functions inside of maths.c.\r\n\r\nIf you want it to be inlined, we can move the code to maths.h.","created_at":"2016-04-30T15:15:43Z","updated_at":"2016-04-30T15:15:43Z","html_url":"https://github.com/borisbstyle/betaflight/pull/372#discussion_r61670856","pull_request_url":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372","_links":{"self":{"href":"https://api.github.com/repos/borisbstyle/betaflight/pulls/comments/61670856"},"html":{"href":"https://github.com/borisbstyle/betaflight/pull/372#discussion_r61670856"},"pull_request":{"href":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372"}}},"pull_request":{"url":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372","id":68270178,"html_url":"https://github.com/borisbstyle/betaflight/pull/372","diff_url":"https://github.com/borisbstyle/betaflight/pull/372.diff","patch_url":"https://github.com/borisbstyle/betaflight/pull/372.patch","issue_url":"https://api.github.com/repos/borisbstyle/betaflight/issues/372","number":372,"state":"open","locked":false,"title":"Changes to support offline testing","user":{"login":"aughey","id":12618,"avatar_url":"https://avatars.githubusercontent.com/u/12618?v=3","gravatar_id":"","url":"https://api.github.com/users/aughey","html_url":"https://github.com/aughey","followers_url":"https://api.github.com/users/aughey/followers","following_url":"https://api.github.com/users/aughey/following{/other_user}","gists_url":"https://api.github.com/users/aughey/gists{/gist_id}","starred_url":"https://api.github.com/users/aughey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aughey/subscriptions","organizations_url":"https://api.github.com/users/aughey/orgs","repos_url":"https://api.github.com/users/aughey/repos","events_url":"https://api.github.com/users/aughey/events{/privacy}","received_events_url":"https://api.github.com/users/aughey/received_events","type":"User","site_admin":false},"body":"I have some changes to support offline testing by allowing flash space to be defined externally, fake gyro/acc values to be injected externally, and the main function separated out into an initialization and a loop step function.","created_at":"2016-04-28T18:44:37Z","updated_at":"2016-04-30T15:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f98e221160aba6ac313c844fb986cf1a7e8a52d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372/commits","review_comments_url":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372/comments","review_comment_url":"https://api.github.com/repos/borisbstyle/betaflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borisbstyle/betaflight/issues/372/comments","statuses_url":"https://api.github.com/repos/borisbstyle/betaflight/statuses/daf1e239ebd8655a9ef32e5a8d98984926808c7c","head":{"label":"aughey:betaflight","ref":"betaflight","sha":"daf1e239ebd8655a9ef32e5a8d98984926808c7c","user":{"login":"aughey","id":12618,"avatar_url":"https://avatars.githubusercontent.com/u/12618?v=3","gravatar_id":"","url":"https://api.github.com/users/aughey","html_url":"https://github.com/aughey","followers_url":"https://api.github.com/users/aughey/followers","following_url":"https://api.github.com/users/aughey/following{/other_user}","gists_url":"https://api.github.com/users/aughey/gists{/gist_id}","starred_url":"https://api.github.com/users/aughey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aughey/subscriptions","organizations_url":"https://api.github.com/users/aughey/orgs","repos_url":"https://api.github.com/users/aughey/repos","events_url":"https://api.github.com/users/aughey/events{/privacy}","received_events_url":"https://api.github.com/users/aughey/received_events","type":"User","site_admin":false},"repo":{"id":57323498,"name":"betaflight","full_name":"aughey/betaflight","owner":{"login":"aughey","id":12618,"avatar_url":"https://avatars.githubusercontent.com/u/12618?v=3","gravatar_id":"","url":"https://api.github.com/users/aughey","html_url":"https://github.com/aughey","followers_url":"https://api.github.com/users/aughey/followers","following_url":"https://api.github.com/users/aughey/following{/other_user}","gists_url":"https://api.github.com/users/aughey/gists{/gist_id}","starred_url":"https://api.github.com/users/aughey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aughey/subscriptions","organizations_url":"https://api.github.com/users/aughey/orgs","repos_url":"https://api.github.com/users/aughey/repos","events_url":"https://api.github.com/users/aughey/events{/privacy}","received_events_url":"https://api.github.com/users/aughey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aughey/betaflight","description":"Beta-code version of the cleanflight flight controller firmware","fork":true,"url":"https://api.github.com/repos/aughey/betaflight","forks_url":"https://api.github.com/repos/aughey/betaflight/forks","keys_url":"https://api.github.com/repos/aughey/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aughey/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aughey/betaflight/teams","hooks_url":"https://api.github.com/repos/aughey/betaflight/hooks","issue_events_url":"https://api.github.com/repos/aughey/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/aughey/betaflight/events","assignees_url":"https://api.github.com/repos/aughey/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/aughey/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/aughey/betaflight/tags","blobs_url":"https://api.github.com/repos/aughey/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aughey/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aughey/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/aughey/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aughey/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/aughey/betaflight/languages","stargazers_url":"https://api.github.com/repos/aughey/betaflight/stargazers","contributors_url":"https://api.github.com/repos/aughey/betaflight/contributors","subscribers_url":"https://api.github.com/repos/aughey/betaflight/subscribers","subscription_url":"https://api.github.com/repos/aughey/betaflight/subscription","commits_url":"https://api.github.com/repos/aughey/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/aughey/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/aughey/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/aughey/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/aughey/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/aughey/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aughey/betaflight/merges","archive_url":"https://api.github.com/repos/aughey/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aughey/betaflight/downloads","issues_url":"https://api.github.com/repos/aughey/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/aughey/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/aughey/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/aughey/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aughey/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/aughey/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/aughey/betaflight/deployments","created_at":"2016-04-28T18:06:38Z","updated_at":"2016-04-28T18:06:43Z","pushed_at":"2016-04-28T18:51:54Z","git_url":"git://github.com/aughey/betaflight.git","ssh_url":"git@github.com:aughey/betaflight.git","clone_url":"https://github.com/aughey/betaflight.git","svn_url":"https://github.com/aughey/betaflight","homepage":"http://cleanflight.com","size":69083,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"betaflight"}},"base":{"label":"borisbstyle:betaflight","ref":"betaflight","sha":"d62d894cc86036c7c1ced73aa875a0a94a497ca7","user":{"login":"borisbstyle","id":10757508,"avatar_url":"https://avatars.githubusercontent.com/u/10757508?v=3","gravatar_id":"","url":"https://api.github.com/users/borisbstyle","html_url":"https://github.com/borisbstyle","followers_url":"https://api.github.com/users/borisbstyle/followers","following_url":"https://api.github.com/users/borisbstyle/following{/other_user}","gists_url":"https://api.github.com/users/borisbstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/borisbstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisbstyle/subscriptions","organizations_url":"https://api.github.com/users/borisbstyle/orgs","repos_url":"https://api.github.com/users/borisbstyle/repos","events_url":"https://api.github.com/users/borisbstyle/events{/privacy}","received_events_url":"https://api.github.com/users/borisbstyle/received_events","type":"User","site_admin":false},"repo":{"id":37060852,"name":"betaflight","full_name":"borisbstyle/betaflight","owner":{"login":"borisbstyle","id":10757508,"avatar_url":"https://avatars.githubusercontent.com/u/10757508?v=3","gravatar_id":"","url":"https://api.github.com/users/borisbstyle","html_url":"https://github.com/borisbstyle","followers_url":"https://api.github.com/users/borisbstyle/followers","following_url":"https://api.github.com/users/borisbstyle/following{/other_user}","gists_url":"https://api.github.com/users/borisbstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/borisbstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisbstyle/subscriptions","organizations_url":"https://api.github.com/users/borisbstyle/orgs","repos_url":"https://api.github.com/users/borisbstyle/repos","events_url":"https://api.github.com/users/borisbstyle/events{/privacy}","received_events_url":"https://api.github.com/users/borisbstyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borisbstyle/betaflight","description":"Beta-code version of the cleanflight flight controller firmware","fork":true,"url":"https://api.github.com/repos/borisbstyle/betaflight","forks_url":"https://api.github.com/repos/borisbstyle/betaflight/forks","keys_url":"https://api.github.com/repos/borisbstyle/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisbstyle/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisbstyle/betaflight/teams","hooks_url":"https://api.github.com/repos/borisbstyle/betaflight/hooks","issue_events_url":"https://api.github.com/repos/borisbstyle/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/borisbstyle/betaflight/events","assignees_url":"https://api.github.com/repos/borisbstyle/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/borisbstyle/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/borisbstyle/betaflight/tags","blobs_url":"https://api.github.com/repos/borisbstyle/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisbstyle/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisbstyle/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisbstyle/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisbstyle/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/borisbstyle/betaflight/languages","stargazers_url":"https://api.github.com/repos/borisbstyle/betaflight/stargazers","contributors_url":"https://api.github.com/repos/borisbstyle/betaflight/contributors","subscribers_url":"https://api.github.com/repos/borisbstyle/betaflight/subscribers","subscription_url":"https://api.github.com/repos/borisbstyle/betaflight/subscription","commits_url":"https://api.github.com/repos/borisbstyle/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisbstyle/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisbstyle/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisbstyle/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/borisbstyle/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/borisbstyle/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisbstyle/betaflight/merges","archive_url":"https://api.github.com/repos/borisbstyle/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisbstyle/betaflight/downloads","issues_url":"https://api.github.com/repos/borisbstyle/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/borisbstyle/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/borisbstyle/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/borisbstyle/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisbstyle/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/borisbstyle/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/borisbstyle/betaflight/deployments","created_at":"2015-06-08T10:37:44Z","updated_at":"2016-04-29T06:19:50Z","pushed_at":"2016-04-30T10:20:30Z","git_url":"git://github.com/borisbstyle/betaflight.git","ssh_url":"git@github.com:borisbstyle/betaflight.git","clone_url":"https://github.com/borisbstyle/betaflight.git","svn_url":"https://github.com/borisbstyle/betaflight","homepage":"http://cleanflight.com","size":79897,"stargazers_count":391,"watchers_count":391,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":30,"forks":144,"open_issues":30,"watchers":391,"default_branch":"betaflight"}},"_links":{"self":{"href":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372"},"html":{"href":"https://github.com/borisbstyle/betaflight/pull/372"},"issue":{"href":"https://api.github.com/repos/borisbstyle/betaflight/issues/372"},"comments":{"href":"https://api.github.com/repos/borisbstyle/betaflight/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/borisbstyle/betaflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borisbstyle/betaflight/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/borisbstyle/betaflight/statuses/daf1e239ebd8655a9ef32e5a8d98984926808c7c"}}}}