{"action":"created","issue":{"url":"https://api.github.com/repos/ooxi/jdatauri/issues/8","repository_url":"https://api.github.com/repos/ooxi/jdatauri","labels_url":"https://api.github.com/repos/ooxi/jdatauri/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/ooxi/jdatauri/issues/8/comments","events_url":"https://api.github.com/repos/ooxi/jdatauri/issues/8/events","html_url":"https://github.com/ooxi/jdatauri/pull/8","id":181661661,"number":8,"title":"Did some cleanup and refactoring in the code","user":{"login":"robinkanters","id":1043866,"avatar_url":"https://avatars.githubusercontent.com/u/1043866?v=3","gravatar_id":"","url":"https://api.github.com/users/robinkanters","html_url":"https://github.com/robinkanters","followers_url":"https://api.github.com/users/robinkanters/followers","following_url":"https://api.github.com/users/robinkanters/following{/other_user}","gists_url":"https://api.github.com/users/robinkanters/gists{/gist_id}","starred_url":"https://api.github.com/users/robinkanters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinkanters/subscriptions","organizations_url":"https://api.github.com/users/robinkanters/orgs","repos_url":"https://api.github.com/users/robinkanters/repos","events_url":"https://api.github.com/users/robinkanters/events{/privacy}","received_events_url":"https://api.github.com/users/robinkanters/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-07T12:54:59Z","updated_at":"2016-10-25T12:02:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ooxi/jdatauri/pulls/8","html_url":"https://github.com/ooxi/jdatauri/pull/8","diff_url":"https://github.com/ooxi/jdatauri/pull/8.diff","patch_url":"https://github.com/ooxi/jdatauri/pull/8.patch"},"body":"Do with it what you will 😊 "},"comment":{"url":"https://api.github.com/repos/ooxi/jdatauri/issues/comments/256015757","html_url":"https://github.com/ooxi/jdatauri/pull/8#issuecomment-256015757","issue_url":"https://api.github.com/repos/ooxi/jdatauri/issues/8","id":256015757,"user":{"login":"ooxi","id":2611835,"avatar_url":"https://avatars.githubusercontent.com/u/2611835?v=3","gravatar_id":"","url":"https://api.github.com/users/ooxi","html_url":"https://github.com/ooxi","followers_url":"https://api.github.com/users/ooxi/followers","following_url":"https://api.github.com/users/ooxi/following{/other_user}","gists_url":"https://api.github.com/users/ooxi/gists{/gist_id}","starred_url":"https://api.github.com/users/ooxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooxi/subscriptions","organizations_url":"https://api.github.com/users/ooxi/orgs","repos_url":"https://api.github.com/users/ooxi/repos","events_url":"https://api.github.com/users/ooxi/events{/privacy}","received_events_url":"https://api.github.com/users/ooxi/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T12:02:34Z","updated_at":"2016-10-25T12:02:34Z","body":"Sorry for the late feedback I thought I replied at least two weeks ago, but somehow my response was lost.\r\n\r\n---\r\n\r\nWhile I agree with changing the license comment from Javadoc to normal doc and adding features like a serialization interface (though please use separate pull requests) I do not support the refactoring of `DataUri.parse` since all comments are lost and the algorithm does not reflect the [data uri parsing rules](https://github.com/ooxi/jdatauri#data-uri-parsing-rules).\r\n\r\nPlease inform me if you'd like to update your patch series. I'm happy to accept features with tests and refactoring as separate pull requests :)"}}
{"actor":{"display_login":"ooxi"}}