{"action":"created","issue":{"url":"https://api.github.com/repos/larshp/abapGit/issues/213","repository_url":"https://api.github.com/repos/larshp/abapGit","labels_url":"https://api.github.com/repos/larshp/abapGit/issues/213/labels{/name}","comments_url":"https://api.github.com/repos/larshp/abapGit/issues/213/comments","events_url":"https://api.github.com/repos/larshp/abapGit/issues/213/events","html_url":"https://github.com/larshp/abapGit/issues/213","id":154846471,"number":213,"title":"Design: diff page","user":{"login":"sbcgua","id":15635498,"avatar_url":"https://avatars.githubusercontent.com/u/15635498?v=3","gravatar_id":"","url":"https://api.github.com/users/sbcgua","html_url":"https://github.com/sbcgua","followers_url":"https://api.github.com/users/sbcgua/followers","following_url":"https://api.github.com/users/sbcgua/following{/other_user}","gists_url":"https://api.github.com/users/sbcgua/gists{/gist_id}","starred_url":"https://api.github.com/users/sbcgua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbcgua/subscriptions","organizations_url":"https://api.github.com/users/sbcgua/orgs","repos_url":"https://api.github.com/users/sbcgua/repos","events_url":"https://api.github.com/users/sbcgua/events{/privacy}","received_events_url":"https://api.github.com/users/sbcgua/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-14T10:33:08Z","updated_at":"2016-05-15T07:25:53Z","closed_at":null,"body":"Branch from #202 (due to concurent coding of the main part ;)\r\n\r\nNew disign of DIFF\r\n\r\n![image](https://cloud.githubusercontent.com/assets/15635498/15267905/2eb44ee6-19d7-11e6-879e-8b625bdc1b56.png)\r\n\r\nHave a look [here](https://github.com/sbcgua/abapGit/tree/diffdesign). If OK, I'll create a merge request (after a few more tweaks yet)\r\n\r\n1) html helper class is evolving (don't judge it critically) but the idea is to create html related routines to improve readability of the main code. I have already what to add and what to refactor there.\r\n2) html helper variable naming as arguable - I'd like to keep them as short as possible. Initially they were even called like \"h\".\r\n3) I didn't get why did you do anchors ... could you please explain ?\r\n4) the line numberring should be probably base on actual code in local and remote\r\n5) The logic of highlighting seems to be incorrect currently - it doesn't show an option when remote is change and local is not ... a bug ? ... or I don't understand something ...\r\n6) \"Back\" button - I've asked a colleague of mine to have a look, she said it is possible to make it it via sap button - the code is coming soon.\r\n"},"comment":{"url":"https://api.github.com/repos/larshp/abapGit/issues/comments/219270788","html_url":"https://github.com/larshp/abapGit/issues/213#issuecomment-219270788","issue_url":"https://api.github.com/repos/larshp/abapGit/issues/213","id":219270788,"user":{"login":"larshp","id":5888506,"avatar_url":"https://avatars.githubusercontent.com/u/5888506?v=3","gravatar_id":"","url":"https://api.github.com/users/larshp","html_url":"https://github.com/larshp","followers_url":"https://api.github.com/users/larshp/followers","following_url":"https://api.github.com/users/larshp/following{/other_user}","gists_url":"https://api.github.com/users/larshp/gists{/gist_id}","starred_url":"https://api.github.com/users/larshp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larshp/subscriptions","organizations_url":"https://api.github.com/users/larshp/orgs","repos_url":"https://api.github.com/users/larshp/repos","events_url":"https://api.github.com/users/larshp/events{/privacy}","received_events_url":"https://api.github.com/users/larshp/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T07:25:52Z","updated_at":"2016-05-15T07:25:52Z","body":"hi,\r\nI added a few unit tests regarding the automatic indentation, see https://github.com/larshp/abapGit/commit/ee1bf174a42c8efbff9317e0c1cf140b1746478b#diff-35f1b917526b3abedbc0c9478bc2b08fR19450\r\n\r\nI have some bad habits from the 90'ies where I tend to use BR and INPUT tags without closing them. It is not proper XHTML, but perhaps we should consider just ignoring BR and INPUT tags when calculating the indentation?"}}