{"action":"created","comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/82249093","pull_request_review_id":3170068,"id":82249093,"diff_hunk":"@@ -113,7 +113,7 @@ package object hdfs {\n       sparkFsConf.hdfsUriStr + posixCodec.unsafePrintPath(afile)\n     }\n     // TODO consider closing over task or read \n-    def fileSystem: () => HdfsFileSystem = () => {\n+    def fileSystem: () => Task[HdfsFileSystem] = () => Task.delay {","path":"sparkcore/src/main/scala/quasar/physical/sparkcore/fs/hdfs/package.scala","position":null,"original_position":5,"commit_id":"2197ea2542a6d37cb692ce2988c78a333d54e09f","original_commit_id":"6cf77e62fa2025083daf1e3e8df3eaae61ee0cb8","user":{"login":"drostron","id":318090,"avatar_url":"https://avatars.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false},"body":"Doesn't need to be a function anymore. Can just be:\r\n```scala\r\nval fileSystem: Task[HdfsFileSystem] = Task.delay { ...\r\n```","created_at":"2016-10-06T18:08:25Z","updated_at":"2016-10-06T18:08:25Z","html_url":"https://github.com/quasar-analytics/quasar/pull/1491#discussion_r82249093","pull_request_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491","_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/82249093"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1491#discussion_r82249093"},"pull_request":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491"}}},"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491","id":87610858,"html_url":"https://github.com/quasar-analytics/quasar/pull/1491","diff_url":"https://github.com/quasar-analytics/quasar/pull/1491.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/1491.patch","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1491","number":1491,"state":"open","locked":false,"title":"Full implementation of spark-hdfs: Read/Write/Manage/Query-File ","user":{"login":"rabbitonweb","id":6287558,"avatar_url":"https://avatars.githubusercontent.com/u/6287558?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitonweb","html_url":"https://github.com/rabbitonweb","followers_url":"https://api.github.com/users/rabbitonweb/followers","following_url":"https://api.github.com/users/rabbitonweb/following{/other_user}","gists_url":"https://api.github.com/users/rabbitonweb/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitonweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitonweb/subscriptions","organizations_url":"https://api.github.com/users/rabbitonweb/orgs","repos_url":"https://api.github.com/users/rabbitonweb/repos","events_url":"https://api.github.com/users/rabbitonweb/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitonweb/received_events","type":"User","site_admin":false},"body":"Implement all Read/Write/Manage/Query-File algebras","created_at":"2016-10-01T18:45:03Z","updated_at":"2016-10-06T18:08:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"156bc59deb1948211fc1b82dbe0b462f2b57625f","assignee":{"login":"drostron","id":318090,"avatar_url":"https://avatars.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false},"assignees":[{"login":"drostron","id":318090,"avatar_url":"https://avatars.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/quasar-analytics/quasar/milestones/10","html_url":"https://github.com/quasar-analytics/quasar/milestones/3.1","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones/10/labels","id":1884685,"number":10,"title":"3.1","description":"","creator":{"login":"jdegoes","id":156745,"avatar_url":"https://avatars.githubusercontent.com/u/156745?v=3","gravatar_id":"","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":28,"state":"open","created_at":"2016-07-15T01:51:36Z","updated_at":"2016-10-06T15:17:15Z","due_on":"2016-10-04T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491/commits","review_comments_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491/comments","review_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1491/comments","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/2197ea2542a6d37cb692ce2988c78a333d54e09f","head":{"label":"rabbitonweb:spark-hdfs","ref":"spark-hdfs","sha":"2197ea2542a6d37cb692ce2988c78a333d54e09f","user":{"login":"rabbitonweb","id":6287558,"avatar_url":"https://avatars.githubusercontent.com/u/6287558?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitonweb","html_url":"https://github.com/rabbitonweb","followers_url":"https://api.github.com/users/rabbitonweb/followers","following_url":"https://api.github.com/users/rabbitonweb/following{/other_user}","gists_url":"https://api.github.com/users/rabbitonweb/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitonweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitonweb/subscriptions","organizations_url":"https://api.github.com/users/rabbitonweb/orgs","repos_url":"https://api.github.com/users/rabbitonweb/repos","events_url":"https://api.github.com/users/rabbitonweb/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitonweb/received_events","type":"User","site_admin":false},"repo":{"id":59917674,"name":"quasar","full_name":"rabbitonweb/quasar","owner":{"login":"rabbitonweb","id":6287558,"avatar_url":"https://avatars.githubusercontent.com/u/6287558?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitonweb","html_url":"https://github.com/rabbitonweb","followers_url":"https://api.github.com/users/rabbitonweb/followers","following_url":"https://api.github.com/users/rabbitonweb/following{/other_user}","gists_url":"https://api.github.com/users/rabbitonweb/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitonweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitonweb/subscriptions","organizations_url":"https://api.github.com/users/rabbitonweb/orgs","repos_url":"https://api.github.com/users/rabbitonweb/repos","events_url":"https://api.github.com/users/rabbitonweb/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitonweb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rabbitonweb/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":true,"url":"https://api.github.com/repos/rabbitonweb/quasar","forks_url":"https://api.github.com/repos/rabbitonweb/quasar/forks","keys_url":"https://api.github.com/repos/rabbitonweb/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabbitonweb/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabbitonweb/quasar/teams","hooks_url":"https://api.github.com/repos/rabbitonweb/quasar/hooks","issue_events_url":"https://api.github.com/repos/rabbitonweb/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/rabbitonweb/quasar/events","assignees_url":"https://api.github.com/repos/rabbitonweb/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/rabbitonweb/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/rabbitonweb/quasar/tags","blobs_url":"https://api.github.com/repos/rabbitonweb/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabbitonweb/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabbitonweb/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabbitonweb/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabbitonweb/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/rabbitonweb/quasar/languages","stargazers_url":"https://api.github.com/repos/rabbitonweb/quasar/stargazers","contributors_url":"https://api.github.com/repos/rabbitonweb/quasar/contributors","subscribers_url":"https://api.github.com/repos/rabbitonweb/quasar/subscribers","subscription_url":"https://api.github.com/repos/rabbitonweb/quasar/subscription","commits_url":"https://api.github.com/repos/rabbitonweb/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabbitonweb/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabbitonweb/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabbitonweb/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabbitonweb/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/rabbitonweb/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabbitonweb/quasar/merges","archive_url":"https://api.github.com/repos/rabbitonweb/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabbitonweb/quasar/downloads","issues_url":"https://api.github.com/repos/rabbitonweb/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/rabbitonweb/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/rabbitonweb/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/rabbitonweb/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabbitonweb/quasar/labels{/name}","releases_url":"https://api.github.com/repos/rabbitonweb/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/rabbitonweb/quasar/deployments","created_at":"2016-05-28T22:55:51Z","updated_at":"2016-05-28T22:55:56Z","pushed_at":"2016-10-06T18:05:57Z","git_url":"git://github.com/rabbitonweb/quasar.git","ssh_url":"git@github.com:rabbitonweb/quasar.git","clone_url":"https://github.com/rabbitonweb/quasar.git","svn_url":"https://github.com/rabbitonweb/quasar","homepage":"http://quasar-analytics.org","size":14947,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quasar-analytics:master","ref":"master","sha":"5e410f8c68cd4c0dac1ff9900150992ff413b3bc","user":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"quasar-analytics/quasar","owner":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quasar-analytics/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":false,"url":"https://api.github.com/repos/quasar-analytics/quasar","forks_url":"https://api.github.com/repos/quasar-analytics/quasar/forks","keys_url":"https://api.github.com/repos/quasar-analytics/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quasar-analytics/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quasar-analytics/quasar/teams","hooks_url":"https://api.github.com/repos/quasar-analytics/quasar/hooks","issue_events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/quasar-analytics/quasar/events","assignees_url":"https://api.github.com/repos/quasar-analytics/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/quasar-analytics/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/quasar-analytics/quasar/tags","blobs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quasar-analytics/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quasar-analytics/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/quasar-analytics/quasar/languages","stargazers_url":"https://api.github.com/repos/quasar-analytics/quasar/stargazers","contributors_url":"https://api.github.com/repos/quasar-analytics/quasar/contributors","subscribers_url":"https://api.github.com/repos/quasar-analytics/quasar/subscribers","subscription_url":"https://api.github.com/repos/quasar-analytics/quasar/subscription","commits_url":"https://api.github.com/repos/quasar-analytics/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quasar-analytics/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quasar-analytics/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/quasar-analytics/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quasar-analytics/quasar/merges","archive_url":"https://api.github.com/repos/quasar-analytics/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quasar-analytics/quasar/downloads","issues_url":"https://api.github.com/repos/quasar-analytics/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/quasar-analytics/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/labels{/name}","releases_url":"https://api.github.com/repos/quasar-analytics/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/quasar-analytics/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2016-10-05T17:58:43Z","pushed_at":"2016-10-06T18:05:58Z","git_url":"git://github.com/quasar-analytics/quasar.git","ssh_url":"git@github.com:quasar-analytics/quasar.git","clone_url":"https://github.com/quasar-analytics/quasar.git","svn_url":"https://github.com/quasar-analytics/quasar","homepage":"http://quasar-analytics.org","size":18213,"stargazers_count":323,"watchers_count":323,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":75,"forks":51,"open_issues":75,"watchers":323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1491"},"issue":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1491"},"comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1491/comments"},"review_comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491/comments"},"review_comment":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1491/commits"},"statuses":{"href":"https://api.github.com/repos/quasar-analytics/quasar/statuses/2197ea2542a6d37cb692ce2988c78a333d54e09f"}}}}
{"actor":{"display_login":"drostron"}}