{"action":"created","issue":{"url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/97","repository_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2","labels_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/97/comments","events_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/97/events","html_url":"https://github.com/algolia/algoliasearch-magento-2/pull/97","id":186528467,"number":97,"title":"Fix config helper to use ProductMetadataInterface to get the correct dependecy","user":{"login":"tkotosz","id":4903365,"avatar_url":"https://avatars.githubusercontent.com/u/4903365?v=3","gravatar_id":"","url":"https://api.github.com/users/tkotosz","html_url":"https://github.com/tkotosz","followers_url":"https://api.github.com/users/tkotosz/followers","following_url":"https://api.github.com/users/tkotosz/following{/other_user}","gists_url":"https://api.github.com/users/tkotosz/gists{/gist_id}","starred_url":"https://api.github.com/users/tkotosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkotosz/subscriptions","organizations_url":"https://api.github.com/users/tkotosz/orgs","repos_url":"https://api.github.com/users/tkotosz/repos","events_url":"https://api.github.com/users/tkotosz/events{/privacy}","received_events_url":"https://api.github.com/users/tkotosz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-01T13:01:51Z","updated_at":"2016-11-01T14:57:52Z","closed_at":"2016-11-01T14:49:43Z","pull_request":{"url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/97","html_url":"https://github.com/algolia/algoliasearch-magento-2/pull/97","diff_url":"https://github.com/algolia/algoliasearch-magento-2/pull/97.diff","patch_url":"https://github.com/algolia/algoliasearch-magento-2/pull/97.patch"},"body":"If `Magento\\Framework\\App\\ProductMetadata` used directly then the `$this->productMetadata->getEdition();` will always return `Community` (see https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/App/ProductMetadata.php#L24).\r\n\r\nIf `Magento\\Framework\\App\\ProductMetadataInterface` used instead then:\r\n- in Community Edition the object manager will return the `Magento\\Framework\\App\\ProductMetadata` and the `getEdition` will return `Community`\r\n- in Enterprise Edition the object manager will return the `Magento\\Enterprise\\Model\\ProductMetadata` (because of this preference: `<preference for=\"Magento\\Framework\\App\\ProductMetadataInterface\" type=\"Magento\\Enterprise\\Model\\ProductMetadata\"/>`) and the `getEdition` method of that class will return `Enterprise`"},"comment":{"url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/comments/257588441","html_url":"https://github.com/algolia/algoliasearch-magento-2/pull/97#issuecomment-257588441","issue_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/97","id":257588441,"user":{"login":"tkotosz","id":4903365,"avatar_url":"https://avatars.githubusercontent.com/u/4903365?v=3","gravatar_id":"","url":"https://api.github.com/users/tkotosz","html_url":"https://github.com/tkotosz","followers_url":"https://api.github.com/users/tkotosz/followers","following_url":"https://api.github.com/users/tkotosz/following{/other_user}","gists_url":"https://api.github.com/users/tkotosz/gists{/gist_id}","starred_url":"https://api.github.com/users/tkotosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkotosz/subscriptions","organizations_url":"https://api.github.com/users/tkotosz/orgs","repos_url":"https://api.github.com/users/tkotosz/repos","events_url":"https://api.github.com/users/tkotosz/events{/privacy}","received_events_url":"https://api.github.com/users/tkotosz/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T14:57:52Z","updated_at":"2016-11-01T14:57:52Z","body":"wow, that was quick, thanks for the quick merge :+1: "}}
{"actor":{"display_login":"tkotosz"}}