{"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/12","id":78800566,"html_url":"https://github.com/russellhaering/goxmldsig/pull/12","diff_url":"https://github.com/russellhaering/goxmldsig/pull/12.diff","patch_url":"https://github.com/russellhaering/goxmldsig/pull/12.patch","issue_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues/12","number":12,"state":"open","locked":false,"title":"Support \"InclusiveNamespaces PrefixList\" in Exclusive Canonicalization","user":{"login":"russellhaering","id":81445,"avatar_url":"https://avatars.githubusercontent.com/u/81445?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhaering","html_url":"https://github.com/russellhaering","followers_url":"https://api.github.com/users/russellhaering/followers","following_url":"https://api.github.com/users/russellhaering/following{/other_user}","gists_url":"https://api.github.com/users/russellhaering/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhaering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhaering/subscriptions","organizations_url":"https://api.github.com/users/russellhaering/orgs","repos_url":"https://api.github.com/users/russellhaering/repos","events_url":"https://api.github.com/users/russellhaering/events{/privacy}","received_events_url":"https://api.github.com/users/russellhaering/received_events","type":"User","site_admin":false},"body":"This is based off of #11 \r\n\r\nIt turns out exclusive canonicalization is meant to take a list of namespace prefixes which should be treated in an inclusive fashion as a parameter.\r\n\r\nIn order to better support parameterizing canonicalization, I introduced a new `Canonicalizer` interface, with inclusive and exclusive implementations, each of which is mostly a wrapper around our existing canonicalization functions.\r\n\r\nI also renamed `canonicalHack` to `canonicalPrep` to clarify their relationship to `excCanonicalPrep`. I was able to remove the underscore prefixed versions of each by moving initialization of the recursion into the respective `Canonicalizer` implementations.\r\n\r\nFinally I added support to `excCanonicalPrep` for accepting a list of namespace prefixes to treat in an inclusive fashion. With this change we now support Okta (again - we accidentally supported it before with our inclusive canonicalization, before we discriminated between canonicalization methods correctly).","created_at":"2016-07-26T06:58:08Z","updated_at":"2016-07-26T06:58:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff6acb03b747035b95ef51551d88b9836dfcb8cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/12/commits","review_comments_url":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/12/comments","review_comment_url":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues/12/comments","statuses_url":"https://api.github.com/repos/russellhaering/goxmldsig/statuses/1f1a162d94e90a1e8c147054abb83cfdc0ce9c32","head":{"label":"russellhaering:russell_h/excl_c14n_inclusive_namespaces","ref":"russell_h/excl_c14n_inclusive_namespaces","sha":"1f1a162d94e90a1e8c147054abb83cfdc0ce9c32","user":{"login":"russellhaering","id":81445,"avatar_url":"https://avatars.githubusercontent.com/u/81445?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhaering","html_url":"https://github.com/russellhaering","followers_url":"https://api.github.com/users/russellhaering/followers","following_url":"https://api.github.com/users/russellhaering/following{/other_user}","gists_url":"https://api.github.com/users/russellhaering/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhaering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhaering/subscriptions","organizations_url":"https://api.github.com/users/russellhaering/orgs","repos_url":"https://api.github.com/users/russellhaering/repos","events_url":"https://api.github.com/users/russellhaering/events{/privacy}","received_events_url":"https://api.github.com/users/russellhaering/received_events","type":"User","site_admin":false},"repo":{"id":53961796,"name":"goxmldsig","full_name":"russellhaering/goxmldsig","owner":{"login":"russellhaering","id":81445,"avatar_url":"https://avatars.githubusercontent.com/u/81445?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhaering","html_url":"https://github.com/russellhaering","followers_url":"https://api.github.com/users/russellhaering/followers","following_url":"https://api.github.com/users/russellhaering/following{/other_user}","gists_url":"https://api.github.com/users/russellhaering/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhaering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhaering/subscriptions","organizations_url":"https://api.github.com/users/russellhaering/orgs","repos_url":"https://api.github.com/users/russellhaering/repos","events_url":"https://api.github.com/users/russellhaering/events{/privacy}","received_events_url":"https://api.github.com/users/russellhaering/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/russellhaering/goxmldsig","description":"Pure Go implementation of XML Digital Signatures","fork":false,"url":"https://api.github.com/repos/russellhaering/goxmldsig","forks_url":"https://api.github.com/repos/russellhaering/goxmldsig/forks","keys_url":"https://api.github.com/repos/russellhaering/goxmldsig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russellhaering/goxmldsig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russellhaering/goxmldsig/teams","hooks_url":"https://api.github.com/repos/russellhaering/goxmldsig/hooks","issue_events_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues/events{/number}","events_url":"https://api.github.com/repos/russellhaering/goxmldsig/events","assignees_url":"https://api.github.com/repos/russellhaering/goxmldsig/assignees{/user}","branches_url":"https://api.github.com/repos/russellhaering/goxmldsig/branches{/branch}","tags_url":"https://api.github.com/repos/russellhaering/goxmldsig/tags","blobs_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/refs{/sha}","trees_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russellhaering/goxmldsig/statuses/{sha}","languages_url":"https://api.github.com/repos/russellhaering/goxmldsig/languages","stargazers_url":"https://api.github.com/repos/russellhaering/goxmldsig/stargazers","contributors_url":"https://api.github.com/repos/russellhaering/goxmldsig/contributors","subscribers_url":"https://api.github.com/repos/russellhaering/goxmldsig/subscribers","subscription_url":"https://api.github.com/repos/russellhaering/goxmldsig/subscription","commits_url":"https://api.github.com/repos/russellhaering/goxmldsig/commits{/sha}","git_commits_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/commits{/sha}","comments_url":"https://api.github.com/repos/russellhaering/goxmldsig/comments{/number}","issue_comment_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues/comments{/number}","contents_url":"https://api.github.com/repos/russellhaering/goxmldsig/contents/{+path}","compare_url":"https://api.github.com/repos/russellhaering/goxmldsig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russellhaering/goxmldsig/merges","archive_url":"https://api.github.com/repos/russellhaering/goxmldsig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russellhaering/goxmldsig/downloads","issues_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues{/number}","pulls_url":"https://api.github.com/repos/russellhaering/goxmldsig/pulls{/number}","milestones_url":"https://api.github.com/repos/russellhaering/goxmldsig/milestones{/number}","notifications_url":"https://api.github.com/repos/russellhaering/goxmldsig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russellhaering/goxmldsig/labels{/name}","releases_url":"https://api.github.com/repos/russellhaering/goxmldsig/releases{/id}","deployments_url":"https://api.github.com/repos/russellhaering/goxmldsig/deployments","created_at":"2016-03-15T16:45:33Z","updated_at":"2016-04-16T20:09:16Z","pushed_at":"2016-07-26T06:58:08Z","git_url":"git://github.com/russellhaering/goxmldsig.git","ssh_url":"git@github.com:russellhaering/goxmldsig.git","clone_url":"https://github.com/russellhaering/goxmldsig.git","svn_url":"https://github.com/russellhaering/goxmldsig","homepage":null,"size":47,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"russellhaering:russell_h/fix_canonicalization_algorithm","ref":"russell_h/fix_canonicalization_algorithm","sha":"806a3bcbfaa6b4a5254c289f9927b3e11ce171ae","user":{"login":"russellhaering","id":81445,"avatar_url":"https://avatars.githubusercontent.com/u/81445?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhaering","html_url":"https://github.com/russellhaering","followers_url":"https://api.github.com/users/russellhaering/followers","following_url":"https://api.github.com/users/russellhaering/following{/other_user}","gists_url":"https://api.github.com/users/russellhaering/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhaering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhaering/subscriptions","organizations_url":"https://api.github.com/users/russellhaering/orgs","repos_url":"https://api.github.com/users/russellhaering/repos","events_url":"https://api.github.com/users/russellhaering/events{/privacy}","received_events_url":"https://api.github.com/users/russellhaering/received_events","type":"User","site_admin":false},"repo":{"id":53961796,"name":"goxmldsig","full_name":"russellhaering/goxmldsig","owner":{"login":"russellhaering","id":81445,"avatar_url":"https://avatars.githubusercontent.com/u/81445?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhaering","html_url":"https://github.com/russellhaering","followers_url":"https://api.github.com/users/russellhaering/followers","following_url":"https://api.github.com/users/russellhaering/following{/other_user}","gists_url":"https://api.github.com/users/russellhaering/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhaering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhaering/subscriptions","organizations_url":"https://api.github.com/users/russellhaering/orgs","repos_url":"https://api.github.com/users/russellhaering/repos","events_url":"https://api.github.com/users/russellhaering/events{/privacy}","received_events_url":"https://api.github.com/users/russellhaering/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/russellhaering/goxmldsig","description":"Pure Go implementation of XML Digital Signatures","fork":false,"url":"https://api.github.com/repos/russellhaering/goxmldsig","forks_url":"https://api.github.com/repos/russellhaering/goxmldsig/forks","keys_url":"https://api.github.com/repos/russellhaering/goxmldsig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russellhaering/goxmldsig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russellhaering/goxmldsig/teams","hooks_url":"https://api.github.com/repos/russellhaering/goxmldsig/hooks","issue_events_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues/events{/number}","events_url":"https://api.github.com/repos/russellhaering/goxmldsig/events","assignees_url":"https://api.github.com/repos/russellhaering/goxmldsig/assignees{/user}","branches_url":"https://api.github.com/repos/russellhaering/goxmldsig/branches{/branch}","tags_url":"https://api.github.com/repos/russellhaering/goxmldsig/tags","blobs_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/refs{/sha}","trees_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russellhaering/goxmldsig/statuses/{sha}","languages_url":"https://api.github.com/repos/russellhaering/goxmldsig/languages","stargazers_url":"https://api.github.com/repos/russellhaering/goxmldsig/stargazers","contributors_url":"https://api.github.com/repos/russellhaering/goxmldsig/contributors","subscribers_url":"https://api.github.com/repos/russellhaering/goxmldsig/subscribers","subscription_url":"https://api.github.com/repos/russellhaering/goxmldsig/subscription","commits_url":"https://api.github.com/repos/russellhaering/goxmldsig/commits{/sha}","git_commits_url":"https://api.github.com/repos/russellhaering/goxmldsig/git/commits{/sha}","comments_url":"https://api.github.com/repos/russellhaering/goxmldsig/comments{/number}","issue_comment_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues/comments{/number}","contents_url":"https://api.github.com/repos/russellhaering/goxmldsig/contents/{+path}","compare_url":"https://api.github.com/repos/russellhaering/goxmldsig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russellhaering/goxmldsig/merges","archive_url":"https://api.github.com/repos/russellhaering/goxmldsig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russellhaering/goxmldsig/downloads","issues_url":"https://api.github.com/repos/russellhaering/goxmldsig/issues{/number}","pulls_url":"https://api.github.com/repos/russellhaering/goxmldsig/pulls{/number}","milestones_url":"https://api.github.com/repos/russellhaering/goxmldsig/milestones{/number}","notifications_url":"https://api.github.com/repos/russellhaering/goxmldsig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russellhaering/goxmldsig/labels{/name}","releases_url":"https://api.github.com/repos/russellhaering/goxmldsig/releases{/id}","deployments_url":"https://api.github.com/repos/russellhaering/goxmldsig/deployments","created_at":"2016-03-15T16:45:33Z","updated_at":"2016-04-16T20:09:16Z","pushed_at":"2016-07-26T06:58:08Z","git_url":"git://github.com/russellhaering/goxmldsig.git","ssh_url":"git@github.com:russellhaering/goxmldsig.git","clone_url":"https://github.com/russellhaering/goxmldsig.git","svn_url":"https://github.com/russellhaering/goxmldsig","homepage":null,"size":47,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/12"},"html":{"href":"https://github.com/russellhaering/goxmldsig/pull/12"},"issue":{"href":"https://api.github.com/repos/russellhaering/goxmldsig/issues/12"},"comments":{"href":"https://api.github.com/repos/russellhaering/goxmldsig/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/russellhaering/goxmldsig/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/russellhaering/goxmldsig/statuses/1f1a162d94e90a1e8c147054abb83cfdc0ce9c32"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":200,"deletions":182,"changed_files":6}}
{"actor":{"display_login":"russellhaering"}}