{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/54063486","id":54063486,"diff_hunk":"@@ -30,11 +30,13 @@ function dirperm_permissions_valid = {\n };\n \n type structure_dirperm_entry = {\n-    'path'    : string with match(SELF, '^/')\n-    'perm'    : string with match(SELF,'[0-7]{3,4}')\n-    'owner'   : string with match(SELF, '\\w+(:\\w+)?')\n-    'type'    : string with match(SELF, 'd|f')\n-    'initdir' ? string[]\n+    'path'         : string with match(SELF, '^/')\n+    'perm'         : string with match(SELF,'[0-7]{3,4}')\n+    'owner'        : string with match(SELF, '\\w+(:\\w+)?')\n+    'type'         : string with match(SELF, '^[df]$')\n+    'initdir'      ? string[]\n+    'checkmount'   : boolean = false\n+    'within_mount' : boolean = false","path":"ncm-dirperm/src/main/pan/components/dirperm/schema.pan","position":15,"original_position":15,"commit_id":"df0b8b6c219d55f9d768aeb72500138cbfab215a","original_commit_id":"df0b8b6c219d55f9d768aeb72500138cbfab215a","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"much better!","created_at":"2016-02-25T08:43:41Z","updated_at":"2016-02-25T08:43:41Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/616#discussion_r54063486","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/54063486"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/616#discussion_r54063486"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616","id":48484338,"html_url":"https://github.com/quattor/configuration-modules-core/pull/616","diff_url":"https://github.com/quattor/configuration-modules-core/pull/616.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/616.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/616","number":616,"state":"open","locked":false,"title":"ncm-dirperm: checkmount feature.","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"body":"This checks that a directory is within a mount, before changing\r\nanything. Useful to ensure directories don't unintentionally end up\r\non the root filesystem.","created_at":"2015-10-22T16:59:50Z","updated_at":"2016-02-25T08:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7450148127a75cca416e239eace5ccac653e2dc","assignee":null,"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/12","html_url":"https://github.com/quattor/configuration-modules-core/milestones/16.4","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/12/labels","id":1147837,"number":12,"title":"16.4","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":1,"state":"open","created_at":"2015-06-03T16:16:39Z","updated_at":"2016-02-23T15:45:03Z","due_on":"2016-04-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/616/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/df0b8b6c219d55f9d768aeb72500138cbfab215a","head":{"label":"ajf8:dirperm_checkmount","ref":"dirperm_checkmount","sha":"df0b8b6c219d55f9d768aeb72500138cbfab215a","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"repo":{"id":38760435,"name":"configuration-modules-core","full_name":"ajf8/configuration-modules-core","owner":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajf8/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":true,"url":"https://api.github.com/repos/ajf8/configuration-modules-core","forks_url":"https://api.github.com/repos/ajf8/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/ajf8/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajf8/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajf8/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/ajf8/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/ajf8/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/ajf8/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/ajf8/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/ajf8/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajf8/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ajf8/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/ajf8/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/ajf8/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/ajf8/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/ajf8/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/ajf8/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajf8/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajf8/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/ajf8/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajf8/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/ajf8/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajf8/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/ajf8/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ajf8/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ajf8/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajf8/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/ajf8/configuration-modules-core/releases{/id}","deployments_url":"https://api.github.com/repos/ajf8/configuration-modules-core/deployments","created_at":"2015-07-08T14:48:23Z","updated_at":"2015-07-08T14:48:26Z","pushed_at":"2016-02-24T17:35:20Z","git_url":"git://github.com/ajf8/configuration-modules-core.git","ssh_url":"git@github.com:ajf8/configuration-modules-core.git","clone_url":"https://github.com/ajf8/configuration-modules-core.git","svn_url":"https://github.com/ajf8/configuration-modules-core","homepage":"www.quattor.org","size":9883,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"3a79a98c1be7cd064c7285e6714baa33b9e43e56","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","deployments_url":"https://api.github.com/repos/quattor/configuration-modules-core/deployments","created_at":"2012-10-31T09:08:07Z","updated_at":"2016-01-11T13:45:42Z","pushed_at":"2016-02-24T17:35:21Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":11091,"stargazers_count":7,"watchers_count":7,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":86,"forks":32,"open_issues":86,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/616"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/616"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/df0b8b6c219d55f9d768aeb72500138cbfab215a"}}}}