{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/26","id":74346445,"html_url":"https://github.com/RoboCupULaval/RULEngine/pull/26","diff_url":"https://github.com/RoboCupULaval/RULEngine/pull/26.diff","patch_url":"https://github.com/RoboCupULaval/RULEngine/pull/26.patch","issue_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/issues/26","number":26,"state":"open","locked":false,"title":"Feature/22 ui comm","user":{"login":"agingrasc","id":13291033,"avatar_url":"https://avatars.githubusercontent.com/u/13291033?v=3","gravatar_id":"","url":"https://api.github.com/users/agingrasc","html_url":"https://github.com/agingrasc","followers_url":"https://api.github.com/users/agingrasc/followers","following_url":"https://api.github.com/users/agingrasc/following{/other_user}","gists_url":"https://api.github.com/users/agingrasc/gists{/gist_id}","starred_url":"https://api.github.com/users/agingrasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agingrasc/subscriptions","organizations_url":"https://api.github.com/users/agingrasc/orgs","repos_url":"https://api.github.com/users/agingrasc/repos","events_url":"https://api.github.com/users/agingrasc/events{/privacy}","received_events_url":"https://api.github.com/users/agingrasc/received_events","type":"User","site_admin":false},"body":"@felixpelletier veux-tu bien faire le code review? Il y a eu un refactor au niveau du package de Communication, déplacer des affaires, renommer d'autres, surtout pour condenser les modules et rendre constant et un peu plus génériques la nomenclature des classes.\r\n\r\nQuand j'utilise le terme service j'entends une classe qui implémente une interface et qui s'occupe des détails propre à une technologie (e.g: UDP), éventuellement on pourrait vouloir abstraire cette notion pour que Framework ne fasse qu'appeler un service générique (send robot command, get debug command, etc.) et qu'un module s'occupe d'initiliaser toutes nos shits en voyant quel protocol est disponible selon le contexte (e.g: faire de la comm directe entre 2 interpréteurs pythons, fallback en udp). Entre temps Framework est encore couplé avec l'implémentation précise. J'ai aussi drop dans les noms des trucs inutiles comme 'UDP' puisque les classes vivent sous le module udp_service. J'ai pas besoin de refaire java où on a pkg.foo.bar.FooClass.doFooBarThing().\r\n\r\nRelis avec attention Framework, tu avais repéré des coquilles et des notions que tu avaient en tête (init les services uniquement lorsqu'on init le moteur plutôt que dès qu'on instancie la classe), il y en a peut-être d'autres. Bien sûr, j'ai aussi potentiellement foiré un truc dans mon implémentation de l'envoie et réception pour le debug. Passe les commentaires, j'effectuerai les corrections nécessaires.\r\n\r\n@david2194 Vérifie les méthodes privés de Framework.py _send.. et _receive... pour voir ce qu'il te manque à implémenter dans la façade de debug. Pour les receives, c'est purement du stockage de données stupide, je vais m'occuper dans StrategyIA de traiter ça.","created_at":"2016-06-18T20:23:07Z","updated_at":"2016-06-18T20:23:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"felixpelletier","id":7928218,"avatar_url":"https://avatars.githubusercontent.com/u/7928218?v=3","gravatar_id":"","url":"https://api.github.com/users/felixpelletier","html_url":"https://github.com/felixpelletier","followers_url":"https://api.github.com/users/felixpelletier/followers","following_url":"https://api.github.com/users/felixpelletier/following{/other_user}","gists_url":"https://api.github.com/users/felixpelletier/gists{/gist_id}","starred_url":"https://api.github.com/users/felixpelletier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixpelletier/subscriptions","organizations_url":"https://api.github.com/users/felixpelletier/orgs","repos_url":"https://api.github.com/users/felixpelletier/repos","events_url":"https://api.github.com/users/felixpelletier/events{/privacy}","received_events_url":"https://api.github.com/users/felixpelletier/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/RoboCupULaval/RULEngine/milestones/2","html_url":"https://github.com/RoboCupULaval/RULEngine/milestones/Sprint%20%232%20Architecture","labels_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/milestones/2/labels","id":1743846,"number":2,"title":"Sprint #2 Architecture","description":"Sprint pour le mois de juin.  \r\n\r\nObjectif: bâtir quelques stratégies de base employant 3 robots dans un contexte 3 vs 3. \r\nLivrable: stratégies fonctionnels employant 3 robots \r\nClient: Beenox","creator":{"login":"agingrasc","id":13291033,"avatar_url":"https://avatars.githubusercontent.com/u/13291033?v=3","gravatar_id":"","url":"https://api.github.com/users/agingrasc","html_url":"https://github.com/agingrasc","followers_url":"https://api.github.com/users/agingrasc/followers","following_url":"https://api.github.com/users/agingrasc/following{/other_user}","gists_url":"https://api.github.com/users/agingrasc/gists{/gist_id}","starred_url":"https://api.github.com/users/agingrasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agingrasc/subscriptions","organizations_url":"https://api.github.com/users/agingrasc/orgs","repos_url":"https://api.github.com/users/agingrasc/repos","events_url":"https://api.github.com/users/agingrasc/events{/privacy}","received_events_url":"https://api.github.com/users/agingrasc/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2016-05-03T01:12:04Z","updated_at":"2016-06-18T20:23:07Z","due_on":"2016-06-30T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/26/commits","review_comments_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/26/comments","review_comment_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/issues/26/comments","statuses_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/statuses/ed6988e997ad093819f1c75c5a3d3be9617f2c86","head":{"label":"agingrasc:feature/22-ui-comm","ref":"feature/22-ui-comm","sha":"ed6988e997ad093819f1c75c5a3d3be9617f2c86","user":{"login":"agingrasc","id":13291033,"avatar_url":"https://avatars.githubusercontent.com/u/13291033?v=3","gravatar_id":"","url":"https://api.github.com/users/agingrasc","html_url":"https://github.com/agingrasc","followers_url":"https://api.github.com/users/agingrasc/followers","following_url":"https://api.github.com/users/agingrasc/following{/other_user}","gists_url":"https://api.github.com/users/agingrasc/gists{/gist_id}","starred_url":"https://api.github.com/users/agingrasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agingrasc/subscriptions","organizations_url":"https://api.github.com/users/agingrasc/orgs","repos_url":"https://api.github.com/users/agingrasc/repos","events_url":"https://api.github.com/users/agingrasc/events{/privacy}","received_events_url":"https://api.github.com/users/agingrasc/received_events","type":"User","site_admin":false},"repo":{"id":45622004,"name":"RULEngine","full_name":"agingrasc/RULEngine","owner":{"login":"agingrasc","id":13291033,"avatar_url":"https://avatars.githubusercontent.com/u/13291033?v=3","gravatar_id":"","url":"https://api.github.com/users/agingrasc","html_url":"https://github.com/agingrasc","followers_url":"https://api.github.com/users/agingrasc/followers","following_url":"https://api.github.com/users/agingrasc/following{/other_user}","gists_url":"https://api.github.com/users/agingrasc/gists{/gist_id}","starred_url":"https://api.github.com/users/agingrasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agingrasc/subscriptions","organizations_url":"https://api.github.com/users/agingrasc/orgs","repos_url":"https://api.github.com/users/agingrasc/repos","events_url":"https://api.github.com/users/agingrasc/events{/privacy}","received_events_url":"https://api.github.com/users/agingrasc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agingrasc/RULEngine","description":"","fork":true,"url":"https://api.github.com/repos/agingrasc/RULEngine","forks_url":"https://api.github.com/repos/agingrasc/RULEngine/forks","keys_url":"https://api.github.com/repos/agingrasc/RULEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agingrasc/RULEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agingrasc/RULEngine/teams","hooks_url":"https://api.github.com/repos/agingrasc/RULEngine/hooks","issue_events_url":"https://api.github.com/repos/agingrasc/RULEngine/issues/events{/number}","events_url":"https://api.github.com/repos/agingrasc/RULEngine/events","assignees_url":"https://api.github.com/repos/agingrasc/RULEngine/assignees{/user}","branches_url":"https://api.github.com/repos/agingrasc/RULEngine/branches{/branch}","tags_url":"https://api.github.com/repos/agingrasc/RULEngine/tags","blobs_url":"https://api.github.com/repos/agingrasc/RULEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agingrasc/RULEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agingrasc/RULEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/agingrasc/RULEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agingrasc/RULEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/agingrasc/RULEngine/languages","stargazers_url":"https://api.github.com/repos/agingrasc/RULEngine/stargazers","contributors_url":"https://api.github.com/repos/agingrasc/RULEngine/contributors","subscribers_url":"https://api.github.com/repos/agingrasc/RULEngine/subscribers","subscription_url":"https://api.github.com/repos/agingrasc/RULEngine/subscription","commits_url":"https://api.github.com/repos/agingrasc/RULEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/agingrasc/RULEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/agingrasc/RULEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/agingrasc/RULEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/agingrasc/RULEngine/contents/{+path}","compare_url":"https://api.github.com/repos/agingrasc/RULEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agingrasc/RULEngine/merges","archive_url":"https://api.github.com/repos/agingrasc/RULEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agingrasc/RULEngine/downloads","issues_url":"https://api.github.com/repos/agingrasc/RULEngine/issues{/number}","pulls_url":"https://api.github.com/repos/agingrasc/RULEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/agingrasc/RULEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/agingrasc/RULEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agingrasc/RULEngine/labels{/name}","releases_url":"https://api.github.com/repos/agingrasc/RULEngine/releases{/id}","deployments_url":"https://api.github.com/repos/agingrasc/RULEngine/deployments","created_at":"2015-11-05T15:56:42Z","updated_at":"2015-11-05T15:56:43Z","pushed_at":"2016-06-18T20:13:18Z","git_url":"git://github.com/agingrasc/RULEngine.git","ssh_url":"git@github.com:agingrasc/RULEngine.git","clone_url":"https://github.com/agingrasc/RULEngine.git","svn_url":"https://github.com/agingrasc/RULEngine","homepage":null,"size":3607,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RoboCupULaval:dev","ref":"dev","sha":"7342f48a4e4be6fe583371434e08672ed942f4b8","user":{"login":"RoboCupULaval","id":4028216,"avatar_url":"https://avatars.githubusercontent.com/u/4028216?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboCupULaval","html_url":"https://github.com/RoboCupULaval","followers_url":"https://api.github.com/users/RoboCupULaval/followers","following_url":"https://api.github.com/users/RoboCupULaval/following{/other_user}","gists_url":"https://api.github.com/users/RoboCupULaval/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboCupULaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboCupULaval/subscriptions","organizations_url":"https://api.github.com/users/RoboCupULaval/orgs","repos_url":"https://api.github.com/users/RoboCupULaval/repos","events_url":"https://api.github.com/users/RoboCupULaval/events{/privacy}","received_events_url":"https://api.github.com/users/RoboCupULaval/received_events","type":"Organization","site_admin":false},"repo":{"id":41771085,"name":"RULEngine","full_name":"RoboCupULaval/RULEngine","owner":{"login":"RoboCupULaval","id":4028216,"avatar_url":"https://avatars.githubusercontent.com/u/4028216?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboCupULaval","html_url":"https://github.com/RoboCupULaval","followers_url":"https://api.github.com/users/RoboCupULaval/followers","following_url":"https://api.github.com/users/RoboCupULaval/following{/other_user}","gists_url":"https://api.github.com/users/RoboCupULaval/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboCupULaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboCupULaval/subscriptions","organizations_url":"https://api.github.com/users/RoboCupULaval/orgs","repos_url":"https://api.github.com/users/RoboCupULaval/repos","events_url":"https://api.github.com/users/RoboCupULaval/events{/privacy}","received_events_url":"https://api.github.com/users/RoboCupULaval/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RoboCupULaval/RULEngine","description":"","fork":false,"url":"https://api.github.com/repos/RoboCupULaval/RULEngine","forks_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/forks","keys_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/teams","hooks_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/hooks","issue_events_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/issues/events{/number}","events_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/events","assignees_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/assignees{/user}","branches_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/branches{/branch}","tags_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/tags","blobs_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/languages","stargazers_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/stargazers","contributors_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/contributors","subscribers_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/subscribers","subscription_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/subscription","commits_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/contents/{+path}","compare_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/merges","archive_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/downloads","issues_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/issues{/number}","pulls_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/labels{/name}","releases_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/releases{/id}","deployments_url":"https://api.github.com/repos/RoboCupULaval/RULEngine/deployments","created_at":"2015-09-02T00:48:21Z","updated_at":"2016-04-29T22:15:35Z","pushed_at":"2016-06-18T20:23:07Z","git_url":"git://github.com/RoboCupULaval/RULEngine.git","ssh_url":"git@github.com:RoboCupULaval/RULEngine.git","clone_url":"https://github.com/RoboCupULaval/RULEngine.git","svn_url":"https://github.com/RoboCupULaval/RULEngine","homepage":null,"size":3578,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":3,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/26"},"html":{"href":"https://github.com/RoboCupULaval/RULEngine/pull/26"},"issue":{"href":"https://api.github.com/repos/RoboCupULaval/RULEngine/issues/26"},"comments":{"href":"https://api.github.com/repos/RoboCupULaval/RULEngine/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RoboCupULaval/RULEngine/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/RoboCupULaval/RULEngine/statuses/ed6988e997ad093819f1c75c5a3d3be9617f2c86"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":238,"deletions":132,"changed_files":9}}
{"actor":{"display_login":"agingrasc"}}