{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16089","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16089/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16089/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16089/events","html_url":"https://github.com/cms-sw/cmssw/pull/16089","id":180904348,"number":16089,"title":"Fixes and enhancements on HCAL rechit dumper","user":{"login":"halilg","id":4124885,"avatar_url":"https://avatars.githubusercontent.com/u/4124885?v=3","gravatar_id":"","url":"https://api.github.com/users/halilg","html_url":"https://github.com/halilg","followers_url":"https://api.github.com/users/halilg/followers","following_url":"https://api.github.com/users/halilg/following{/other_user}","gists_url":"https://api.github.com/users/halilg/gists{/gist_id}","starred_url":"https://api.github.com/users/halilg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halilg/subscriptions","organizations_url":"https://api.github.com/users/halilg/orgs","repos_url":"https://api.github.com/users/halilg/repos","events_url":"https://api.github.com/users/halilg/events{/privacy}","received_events_url":"https://api.github.com/users/halilg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hold","name":"hold","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/urgent","name":"urgent","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":1642,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-10-12T17:01:10Z","due_on":null,"closed_at":null},"comments":27,"created_at":"2016-10-04T14:11:46Z","updated_at":"2016-10-12T17:08:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16089","html_url":"https://github.com/cms-sw/cmssw/pull/16089","diff_url":"https://github.com/cms-sw/cmssw/pull/16089.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16089.patch"},"body":"Main code in DataFormats/HcalRecHit/test is HcalRecHitDump.cc, which is a simple \r\ntool to dump HCAL rechits to terminal.\r\n\r\nThis pull request consists of fixes and changes made with the following purposes:\r\n- Fix HcalRecHitDump.cc which was broken by CMSSW 6X\r\n- Add features and scripts to help validate (dump/compare) the \r\nreorganized (as part of Phase 1 upgrade related SW updates) \r\nHCAL rechits\r\n\r\nFile-by-file changes:\r\n\r\nHcalRecHitDump.cc -- Modified rechit dumper. Code now allows the \r\n  user to pick specific rechit collections to dump, also all status bits (including \r\n  newly added ones) can be dumped with arbitrary order.\r\n\r\nHcalRecHitDump_cfg.py (new file) -- example config which shows how\r\n    to dump HBHE rechits using identical format for both Phase 1\r\n    and legacy reconstruction. Of course, the dumped info is\r\n    incomplete because we can only compare features that coincide.\r\n\r\nnumcompare.tcl (new file) -- Poor man's \"diff\" replacement which knows how\r\n    to compare doubles up to certain precision. This code assumes\r\n    that compared files have the same number of lines.\r\n\r\nprint_lines.tcl (new file) -- A simple utility for picking specified lines from\r\n    text files."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/253275627","html_url":"https://github.com/cms-sw/cmssw/pull/16089#issuecomment-253275627","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16089","id":253275627,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T17:08:09Z","updated_at":"2016-10-12T17:08:09Z","body":"Comparison is ready\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16089/15683/summary.html\n\n@slava77 comparisons for the following workflows were not done due to missing matrix map:\n   * 10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017\n   * 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017\n   * 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix\n   * 10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev\n   * 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew"}}
{"actor":{"display_login":"cmsbuild"}}