{"action":"opened","number":695,"pull_request":{"url":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/695","id":75569466,"html_url":"https://github.com/MRtrix3/mrtrix3/pull/695","diff_url":"https://github.com/MRtrix3/mrtrix3/pull/695.diff","patch_url":"https://github.com/MRtrix3/mrtrix3/pull/695.patch","issue_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/695","number":695,"state":"open","locked":false,"title":"marking of override of virtual functions","user":{"login":"maxpietsch","id":10046944,"avatar_url":"https://avatars.githubusercontent.com/u/10046944?v=3","gravatar_id":"","url":"https://api.github.com/users/maxpietsch","html_url":"https://github.com/maxpietsch","followers_url":"https://api.github.com/users/maxpietsch/followers","following_url":"https://api.github.com/users/maxpietsch/following{/other_user}","gists_url":"https://api.github.com/users/maxpietsch/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpietsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpietsch/subscriptions","organizations_url":"https://api.github.com/users/maxpietsch/orgs","repos_url":"https://api.github.com/users/maxpietsch/repos","events_url":"https://api.github.com/users/maxpietsch/events{/privacy}","received_events_url":"https://api.github.com/users/maxpietsch/received_events","type":"User","site_admin":false},"body":"To get rid of override warnings with clang due to unmarked overridden virtual functions.\r\n\r\n1 unrelated warning is remaining:\r\n\r\n\r\n    release/src/dwi/tractography/seeding/seeding.o\r\n\r\n    clang++ -c -std=c++11 -DMRTRIX_MACOSX -fPIC -mmacosx-version-min=10.11 -DMRTRIX_WORD64 -DMRTRIX_NO_NON_POD_VLA -isystem /usr/local/Cellar/eigen/3.2.8/include/eigen3 -Wall -O2 -DNDEBUG -Isrc -Icmd -I./lib -Icmd -isystem /usr/local/Cellar/eigen/3.2.8/include/eigen3 src/dwi/tractography/mapping/mapper.cpp -o release/src/dwi/tractography/mapping/mapper.o:\r\n\r\n    src/dwi/tractography/mapping/mapper.cpp:196:43: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]\r\n      vector_data.reset (new Eigen::VectorXf (std::move (load_vector<float> (path))));\r\n                                              ^\r\n    src/dwi/tractography/mapping/mapper.cpp:196:43: note: remove std::move call here\r\n      vector_data.reset (new Eigen::VectorXf (std::move (load_vector<float> (path))));\r\n                                              ^~~~~~~~~~~                         ~\r\n    1 warning generated.","created_at":"2016-06-28T23:56:59Z","updated_at":"2016-06-28T23:56:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/695/commits","review_comments_url":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/695/comments","review_comment_url":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/695/comments","statuses_url":"https://api.github.com/repos/MRtrix3/mrtrix3/statuses/afbd02b887bd01243f78c8b2ad019bbc5371ed16","head":{"label":"MRtrix3:mrview_virtual_override","ref":"mrview_virtual_override","sha":"afbd02b887bd01243f78c8b2ad019bbc5371ed16","user":{"login":"MRtrix3","id":12139692,"avatar_url":"https://avatars.githubusercontent.com/u/12139692?v=3","gravatar_id":"","url":"https://api.github.com/users/MRtrix3","html_url":"https://github.com/MRtrix3","followers_url":"https://api.github.com/users/MRtrix3/followers","following_url":"https://api.github.com/users/MRtrix3/following{/other_user}","gists_url":"https://api.github.com/users/MRtrix3/gists{/gist_id}","starred_url":"https://api.github.com/users/MRtrix3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRtrix3/subscriptions","organizations_url":"https://api.github.com/users/MRtrix3/orgs","repos_url":"https://api.github.com/users/MRtrix3/repos","events_url":"https://api.github.com/users/MRtrix3/events{/privacy}","received_events_url":"https://api.github.com/users/MRtrix3/received_events","type":"Organization","site_admin":false},"repo":{"id":19347267,"name":"mrtrix3","full_name":"MRtrix3/mrtrix3","owner":{"login":"MRtrix3","id":12139692,"avatar_url":"https://avatars.githubusercontent.com/u/12139692?v=3","gravatar_id":"","url":"https://api.github.com/users/MRtrix3","html_url":"https://github.com/MRtrix3","followers_url":"https://api.github.com/users/MRtrix3/followers","following_url":"https://api.github.com/users/MRtrix3/following{/other_user}","gists_url":"https://api.github.com/users/MRtrix3/gists{/gist_id}","starred_url":"https://api.github.com/users/MRtrix3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRtrix3/subscriptions","organizations_url":"https://api.github.com/users/MRtrix3/orgs","repos_url":"https://api.github.com/users/MRtrix3/repos","events_url":"https://api.github.com/users/MRtrix3/events{/privacy}","received_events_url":"https://api.github.com/users/MRtrix3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MRtrix3/mrtrix3","description":"MRtrix provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density","fork":false,"url":"https://api.github.com/repos/MRtrix3/mrtrix3","forks_url":"https://api.github.com/repos/MRtrix3/mrtrix3/forks","keys_url":"https://api.github.com/repos/MRtrix3/mrtrix3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MRtrix3/mrtrix3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MRtrix3/mrtrix3/teams","hooks_url":"https://api.github.com/repos/MRtrix3/mrtrix3/hooks","issue_events_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/events{/number}","events_url":"https://api.github.com/repos/MRtrix3/mrtrix3/events","assignees_url":"https://api.github.com/repos/MRtrix3/mrtrix3/assignees{/user}","branches_url":"https://api.github.com/repos/MRtrix3/mrtrix3/branches{/branch}","tags_url":"https://api.github.com/repos/MRtrix3/mrtrix3/tags","blobs_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/refs{/sha}","trees_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MRtrix3/mrtrix3/statuses/{sha}","languages_url":"https://api.github.com/repos/MRtrix3/mrtrix3/languages","stargazers_url":"https://api.github.com/repos/MRtrix3/mrtrix3/stargazers","contributors_url":"https://api.github.com/repos/MRtrix3/mrtrix3/contributors","subscribers_url":"https://api.github.com/repos/MRtrix3/mrtrix3/subscribers","subscription_url":"https://api.github.com/repos/MRtrix3/mrtrix3/subscription","commits_url":"https://api.github.com/repos/MRtrix3/mrtrix3/commits{/sha}","git_commits_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/commits{/sha}","comments_url":"https://api.github.com/repos/MRtrix3/mrtrix3/comments{/number}","issue_comment_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/comments{/number}","contents_url":"https://api.github.com/repos/MRtrix3/mrtrix3/contents/{+path}","compare_url":"https://api.github.com/repos/MRtrix3/mrtrix3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MRtrix3/mrtrix3/merges","archive_url":"https://api.github.com/repos/MRtrix3/mrtrix3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MRtrix3/mrtrix3/downloads","issues_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues{/number}","pulls_url":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls{/number}","milestones_url":"https://api.github.com/repos/MRtrix3/mrtrix3/milestones{/number}","notifications_url":"https://api.github.com/repos/MRtrix3/mrtrix3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MRtrix3/mrtrix3/labels{/name}","releases_url":"https://api.github.com/repos/MRtrix3/mrtrix3/releases{/id}","deployments_url":"https://api.github.com/repos/MRtrix3/mrtrix3/deployments","created_at":"2014-05-01T14:47:02Z","updated_at":"2016-06-22T14:05:31Z","pushed_at":"2016-06-28T23:53:34Z","git_url":"git://github.com/MRtrix3/mrtrix3.git","ssh_url":"git@github.com:MRtrix3/mrtrix3.git","clone_url":"https://github.com/MRtrix3/mrtrix3.git","svn_url":"https://github.com/MRtrix3/mrtrix3","homepage":"http://www.mrtrix.org","size":20282,"stargazers_count":48,"watchers_count":48,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":141,"forks":29,"open_issues":141,"watchers":48,"default_branch":"master"}},"base":{"label":"MRtrix3:master","ref":"master","sha":"22ea9a6f648907a69bde0434e3ea7803a649c72f","user":{"login":"MRtrix3","id":12139692,"avatar_url":"https://avatars.githubusercontent.com/u/12139692?v=3","gravatar_id":"","url":"https://api.github.com/users/MRtrix3","html_url":"https://github.com/MRtrix3","followers_url":"https://api.github.com/users/MRtrix3/followers","following_url":"https://api.github.com/users/MRtrix3/following{/other_user}","gists_url":"https://api.github.com/users/MRtrix3/gists{/gist_id}","starred_url":"https://api.github.com/users/MRtrix3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRtrix3/subscriptions","organizations_url":"https://api.github.com/users/MRtrix3/orgs","repos_url":"https://api.github.com/users/MRtrix3/repos","events_url":"https://api.github.com/users/MRtrix3/events{/privacy}","received_events_url":"https://api.github.com/users/MRtrix3/received_events","type":"Organization","site_admin":false},"repo":{"id":19347267,"name":"mrtrix3","full_name":"MRtrix3/mrtrix3","owner":{"login":"MRtrix3","id":12139692,"avatar_url":"https://avatars.githubusercontent.com/u/12139692?v=3","gravatar_id":"","url":"https://api.github.com/users/MRtrix3","html_url":"https://github.com/MRtrix3","followers_url":"https://api.github.com/users/MRtrix3/followers","following_url":"https://api.github.com/users/MRtrix3/following{/other_user}","gists_url":"https://api.github.com/users/MRtrix3/gists{/gist_id}","starred_url":"https://api.github.com/users/MRtrix3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRtrix3/subscriptions","organizations_url":"https://api.github.com/users/MRtrix3/orgs","repos_url":"https://api.github.com/users/MRtrix3/repos","events_url":"https://api.github.com/users/MRtrix3/events{/privacy}","received_events_url":"https://api.github.com/users/MRtrix3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MRtrix3/mrtrix3","description":"MRtrix provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density","fork":false,"url":"https://api.github.com/repos/MRtrix3/mrtrix3","forks_url":"https://api.github.com/repos/MRtrix3/mrtrix3/forks","keys_url":"https://api.github.com/repos/MRtrix3/mrtrix3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MRtrix3/mrtrix3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MRtrix3/mrtrix3/teams","hooks_url":"https://api.github.com/repos/MRtrix3/mrtrix3/hooks","issue_events_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/events{/number}","events_url":"https://api.github.com/repos/MRtrix3/mrtrix3/events","assignees_url":"https://api.github.com/repos/MRtrix3/mrtrix3/assignees{/user}","branches_url":"https://api.github.com/repos/MRtrix3/mrtrix3/branches{/branch}","tags_url":"https://api.github.com/repos/MRtrix3/mrtrix3/tags","blobs_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/refs{/sha}","trees_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MRtrix3/mrtrix3/statuses/{sha}","languages_url":"https://api.github.com/repos/MRtrix3/mrtrix3/languages","stargazers_url":"https://api.github.com/repos/MRtrix3/mrtrix3/stargazers","contributors_url":"https://api.github.com/repos/MRtrix3/mrtrix3/contributors","subscribers_url":"https://api.github.com/repos/MRtrix3/mrtrix3/subscribers","subscription_url":"https://api.github.com/repos/MRtrix3/mrtrix3/subscription","commits_url":"https://api.github.com/repos/MRtrix3/mrtrix3/commits{/sha}","git_commits_url":"https://api.github.com/repos/MRtrix3/mrtrix3/git/commits{/sha}","comments_url":"https://api.github.com/repos/MRtrix3/mrtrix3/comments{/number}","issue_comment_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/comments{/number}","contents_url":"https://api.github.com/repos/MRtrix3/mrtrix3/contents/{+path}","compare_url":"https://api.github.com/repos/MRtrix3/mrtrix3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MRtrix3/mrtrix3/merges","archive_url":"https://api.github.com/repos/MRtrix3/mrtrix3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MRtrix3/mrtrix3/downloads","issues_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues{/number}","pulls_url":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls{/number}","milestones_url":"https://api.github.com/repos/MRtrix3/mrtrix3/milestones{/number}","notifications_url":"https://api.github.com/repos/MRtrix3/mrtrix3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MRtrix3/mrtrix3/labels{/name}","releases_url":"https://api.github.com/repos/MRtrix3/mrtrix3/releases{/id}","deployments_url":"https://api.github.com/repos/MRtrix3/mrtrix3/deployments","created_at":"2014-05-01T14:47:02Z","updated_at":"2016-06-22T14:05:31Z","pushed_at":"2016-06-28T23:53:34Z","git_url":"git://github.com/MRtrix3/mrtrix3.git","ssh_url":"git@github.com:MRtrix3/mrtrix3.git","clone_url":"https://github.com/MRtrix3/mrtrix3.git","svn_url":"https://github.com/MRtrix3/mrtrix3","homepage":"http://www.mrtrix.org","size":20282,"stargazers_count":48,"watchers_count":48,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":141,"forks":29,"open_issues":141,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/695"},"html":{"href":"https://github.com/MRtrix3/mrtrix3/pull/695"},"issue":{"href":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/695"},"comments":{"href":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MRtrix3/mrtrix3/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/MRtrix3/mrtrix3/statuses/afbd02b887bd01243f78c8b2ad019bbc5371ed16"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":32,"deletions":32,"changed_files":3}}
{"actor":{"display_login":"maxpietsch"}}