{"push_id":1196504362,"size":4,"distinct_size":4,"ref":"refs/heads/fix-has_role","head":"8774bb25943dec10dc579d7dec9b5d87d1166fac","before":"7a393c64a54e652e9377dbb5d06ea568f0684d4e","commits":[{"sha":"5d1e632be51eadd2624c348ce0881ac14e762609","author":{"name":"Vincent Untz","email":"f50c232073d52e5b94e70021fd5ea26b70860c35@suse.com"},"message":"crowbar: Fix regression in NodeObject.role? that breaks deactivation\n\nThis was introduced in 84827646: it turns out that Chef::Node.role?\ndoesn't check the roles that are coming from the run list of another\nrole. So it got broken.\n\nResult is that nodes were keeping the roles after a barclamp\ndeactivation.","distinct":true,"url":"https://api.github.com/repos/vuntz/crowbar-core/commits/5d1e632be51eadd2624c348ce0881ac14e762609"},{"sha":"b341f0b9b7ec70e6b2131f94ef3f39e6da60a89b","author":{"name":"Vincent Untz","email":"f50c232073d52e5b94e70021fd5ea26b70860c35@suse.com"},"message":"crowbar: Ensure run_list is how we want it to be\n\nWhen we add a role to a node, we need the role in the run_list_map and\nin the run_list, but if it was in one or the other, we were not doing\nanything. This resulted in semi-broken setups (which could happen due to\ncrashes, or manual editing) not getting fixed when re-applying a\nbarclamp.\n\nNow, when we change the run_list, we really ensure that it's how we want\nit to be.","distinct":true,"url":"https://api.github.com/repos/vuntz/crowbar-core/commits/b341f0b9b7ec70e6b2131f94ef3f39e6da60a89b"},{"sha":"91741e515c5b67af3dddaba6d9e637e65b416a1b","author":{"name":"Vincent Untz","email":"f50c232073d52e5b94e70021fd5ea26b70860c35@suse.com"},"message":"crowbar: Minor cleanup in ServiceObjet.apply_role\n\nDon't be so complicated to build a list of nodes...","distinct":true,"url":"https://api.github.com/repos/vuntz/crowbar-core/commits/91741e515c5b67af3dddaba6d9e637e65b416a1b"},{"sha":"8774bb25943dec10dc579d7dec9b5d87d1166fac","author":{"name":"Vincent Untz","email":"f50c232073d52e5b94e70021fd5ea26b70860c35@suse.com"},"message":"crowbar: Improve debug log in ServiceObject.apply_role\n\nThis includes removing log lines which duplicate data already in the\ndebug logs.","distinct":true,"url":"https://api.github.com/repos/vuntz/crowbar-core/commits/8774bb25943dec10dc579d7dec9b5d87d1166fac"}]}
{"actor":{"display_login":"vuntz"}}