{"action":"closed","issue":{"url":"https://api.github.com/repos/mrmin123/kancolle-auto/issues/136","repository_url":"https://api.github.com/repos/mrmin123/kancolle-auto","labels_url":"https://api.github.com/repos/mrmin123/kancolle-auto/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/mrmin123/kancolle-auto/issues/136/comments","events_url":"https://api.github.com/repos/mrmin123/kancolle-auto/issues/136/events","html_url":"https://github.com/mrmin123/kancolle-auto/issues/136","id":135694951,"number":136,"title":"SubmarineSwitch Issue + Need Improvisation","user":{"login":"minh6a","id":10925298,"avatar_url":"https://avatars.githubusercontent.com/u/10925298?v=3","gravatar_id":"","url":"https://api.github.com/users/minh6a","html_url":"https://github.com/minh6a","followers_url":"https://api.github.com/users/minh6a/followers","following_url":"https://api.github.com/users/minh6a/following{/other_user}","gists_url":"https://api.github.com/users/minh6a/gists{/gist_id}","starred_url":"https://api.github.com/users/minh6a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minh6a/subscriptions","organizations_url":"https://api.github.com/users/minh6a/orgs","repos_url":"https://api.github.com/users/minh6a/repos","events_url":"https://api.github.com/users/minh6a/events{/privacy}","received_events_url":"https://api.github.com/users/minh6a/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mrmin123/kancolle-auto/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/mrmin123/kancolle-auto/labels/in%20progress","name":"in progress","color":"fbca04"}],"state":"closed","locked":false,"assignee":{"login":"mrmin123","id":4326866,"avatar_url":"https://avatars.githubusercontent.com/u/4326866?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmin123","html_url":"https://github.com/mrmin123","followers_url":"https://api.github.com/users/mrmin123/followers","following_url":"https://api.github.com/users/mrmin123/following{/other_user}","gists_url":"https://api.github.com/users/mrmin123/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmin123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmin123/subscriptions","organizations_url":"https://api.github.com/users/mrmin123/orgs","repos_url":"https://api.github.com/users/mrmin123/repos","events_url":"https://api.github.com/users/mrmin123/events{/privacy}","received_events_url":"https://api.github.com/users/mrmin123/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-02-23T10:18:11Z","updated_at":"2016-03-12T21:22:14Z","closed_at":"2016-03-12T21:22:14Z","body":"After SubmarineSwitch, the repairing submarine is switched, however, instead of continuing sortie (as sortie condition is met), the script take the submarine repairing time and postpone the sortie until the submarine is repaired. This is pretty frustrating for me who have 5+ dupes of each submarines with the lowest level of 62 (1->9 hours of repair time).\r\n\r\nSome improvisations can be implemented to SubmarineSwitch:\r\n- Instead of looking for submarine by using stats (to avoid Taigei - 潜水母艦 - AS), using the class name will make the process much faster (SS/SSV) (潜水艦 and 潜水空母). Using only 潜水(sensui) will include the chance that Taigei be chosen -> Use full class name will eliminate this chance -> No need stats check -> Less time replacing Submarine\r\n- In regard of using 潜水艦 and 潜水空母 to find subs,we can add option to replace current ship with SS or SSV only (SS for low repair time and resupply cost, SSV for torp power, armor and ship kills for quests)\r\n- Replace low-morale submarine (which will be feasible with Repair Damage Threshold 1) for more effective orelling"}}