{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/75375171","id":75375171,"diff_hunk":"@@ -52,9 +53,18 @@ class PlatformViewAndroid : public PlatformView {\n   // sky::shell::PlatformView override\n   virtual void Resize(const SkISize& size);\n \n+  virtual void RunFromSource(const std::string& main,\n+                             const std::string& packages,\n+                             const std::string& assets_directory);\n+\n+  void set_flutter_view(JavaObjectWeakGlobalRef flutter_view) {","path":"sky/shell/platform/android/platform_view_android.h","position":16,"original_position":16,"commit_id":"2f1eac64caf1695bcaba814887c5900171822d80","original_commit_id":"2f1eac64caf1695bcaba814887c5900171822d80","user":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars.githubusercontent.com/u/14226037?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"body":"can pass a const JavaObjectWeakGlobalRef& here","created_at":"2016-08-18T19:40:29Z","updated_at":"2016-08-18T19:40:29Z","html_url":"https://github.com/flutter/engine/pull/2944#discussion_r75375171","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/2944","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/75375171"},"html":{"href":"https://github.com/flutter/engine/pull/2944#discussion_r75375171"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/2944"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/2944","id":81847553,"html_url":"https://github.com/flutter/engine/pull/2944","diff_url":"https://github.com/flutter/engine/pull/2944.diff","patch_url":"https://github.com/flutter/engine/pull/2944.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/2944","number":2944,"state":"open","locked":false,"title":"Fix Android keyboard in hot mode","user":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"body":"- [x] Rework how application restart works in hot mode so that the PlatformView can delegate to the native OS thread so that services are properly wired up.\r\n- [x] Fix keyboard on Android.","created_at":"2016-08-18T16:32:44Z","updated_at":"2016-08-18T19:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f63aaf95abf08b5395fc911d18523db1907389fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/2944/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/2944/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/2944/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/2f1eac64caf1695bcaba814887c5900171822d80","head":{"label":"johnmccutchan:fix_keyboard_android_hot","ref":"fix_keyboard_android_hot","sha":"2f1eac64caf1695bcaba814887c5900171822d80","user":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"repo":{"id":65331940,"name":"engine","full_name":"johnmccutchan/engine","owner":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnmccutchan/engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/johnmccutchan/engine","forks_url":"https://api.github.com/repos/johnmccutchan/engine/forks","keys_url":"https://api.github.com/repos/johnmccutchan/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnmccutchan/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnmccutchan/engine/teams","hooks_url":"https://api.github.com/repos/johnmccutchan/engine/hooks","issue_events_url":"https://api.github.com/repos/johnmccutchan/engine/issues/events{/number}","events_url":"https://api.github.com/repos/johnmccutchan/engine/events","assignees_url":"https://api.github.com/repos/johnmccutchan/engine/assignees{/user}","branches_url":"https://api.github.com/repos/johnmccutchan/engine/branches{/branch}","tags_url":"https://api.github.com/repos/johnmccutchan/engine/tags","blobs_url":"https://api.github.com/repos/johnmccutchan/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnmccutchan/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnmccutchan/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnmccutchan/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnmccutchan/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/johnmccutchan/engine/languages","stargazers_url":"https://api.github.com/repos/johnmccutchan/engine/stargazers","contributors_url":"https://api.github.com/repos/johnmccutchan/engine/contributors","subscribers_url":"https://api.github.com/repos/johnmccutchan/engine/subscribers","subscription_url":"https://api.github.com/repos/johnmccutchan/engine/subscription","commits_url":"https://api.github.com/repos/johnmccutchan/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnmccutchan/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnmccutchan/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnmccutchan/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnmccutchan/engine/contents/{+path}","compare_url":"https://api.github.com/repos/johnmccutchan/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnmccutchan/engine/merges","archive_url":"https://api.github.com/repos/johnmccutchan/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnmccutchan/engine/downloads","issues_url":"https://api.github.com/repos/johnmccutchan/engine/issues{/number}","pulls_url":"https://api.github.com/repos/johnmccutchan/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/johnmccutchan/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/johnmccutchan/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnmccutchan/engine/labels{/name}","releases_url":"https://api.github.com/repos/johnmccutchan/engine/releases{/id}","deployments_url":"https://api.github.com/repos/johnmccutchan/engine/deployments","created_at":"2016-08-09T22:18:08Z","updated_at":"2016-08-09T22:18:16Z","pushed_at":"2016-08-18T18:38:38Z","git_url":"git://github.com/johnmccutchan/engine.git","ssh_url":"git@github.com:johnmccutchan/engine.git","clone_url":"https://github.com/johnmccutchan/engine.git","svn_url":"https://github.com/johnmccutchan/engine","homepage":"http://flutter.io","size":84160,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"ace7ce8c01696252fc1b6a3f77003bc5d0fd5a63","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2016-08-18T17:24:26Z","pushed_at":"2016-08-18T19:36:38Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":106750,"stargazers_count":897,"watchers_count":897,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":3,"forks":151,"open_issues":3,"watchers":897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/2944"},"html":{"href":"https://github.com/flutter/engine/pull/2944"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/2944"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/2944/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/2944/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/2944/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/2f1eac64caf1695bcaba814887c5900171822d80"}}}}
{"actor":{"display_login":"jason-simmons"}}