{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/fili/pulls/comments/77881816","id":77881816,"diff_hunk":"@@ -415,11 +423,12 @@ protected void handleResultsResponse(\n      * return an Observable wrapping the PreResponse as is.\n      *\n      * @param preResponse  The PreResponse to be inspected\n+     * @param jobsApiRequest  JobsApiRequest object with all the associated info with it\n      *\n      * @return An Observable wrapping the PreResponse or an Observable wrapping a ResponseException\n      *\n      */\n-    protected Observable<PreResponse> handlePreResponseWithError(PreResponse preResponse) {\n+    protected Observable<PreResponse> handlePreResponseWithError(PreResponse preResponse, ApiRequest jobsApiRequest) {","path":"fili-core/src/main/java/com/yahoo/bard/webservice/web/endpoints/JobsServlet.java","position":63,"original_position":63,"commit_id":"f4456e4b19fc51bee9a80e6af187183a56c77ce1","original_commit_id":"f4456e4b19fc51bee9a80e6af187183a56c77ce1","user":{"login":"cdeszaq","id":612084,"avatar_url":"https://avatars.githubusercontent.com/u/612084?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeszaq","html_url":"https://github.com/cdeszaq","followers_url":"https://api.github.com/users/cdeszaq/followers","following_url":"https://api.github.com/users/cdeszaq/following{/other_user}","gists_url":"https://api.github.com/users/cdeszaq/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeszaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeszaq/subscriptions","organizations_url":"https://api.github.com/users/cdeszaq/orgs","repos_url":"https://api.github.com/users/cdeszaq/repos","events_url":"https://api.github.com/users/cdeszaq/events{/privacy}","received_events_url":"https://api.github.com/users/cdeszaq/received_events","type":"User","site_admin":false},"body":"If there's specific pieces of ApiRequest we keep needing to have, we can extract an interface from it and depend on that instead if it makes more sense. Not sure if it would help here or not, but it's an option.","created_at":"2016-09-07T18:49:28Z","updated_at":"2016-09-07T18:49:28Z","html_url":"https://github.com/yahoo/fili/pull/20#discussion_r77881816","pull_request_url":"https://api.github.com/repos/yahoo/fili/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments/77881816"},"html":{"href":"https://github.com/yahoo/fili/pull/20#discussion_r77881816"},"pull_request":{"href":"https://api.github.com/repos/yahoo/fili/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/fili/pulls/20","id":83355686,"html_url":"https://github.com/yahoo/fili/pull/20","diff_url":"https://github.com/yahoo/fili/pull/20.diff","patch_url":"https://github.com/yahoo/fili/pull/20.patch","issue_url":"https://api.github.com/repos/yahoo/fili/issues/20","number":20,"state":"open","locked":false,"title":"[17] Added pagination parameters to ResultSet","user":{"login":"dayamr","id":1940669,"avatar_url":"https://avatars.githubusercontent.com/u/1940669?v=3","gravatar_id":"","url":"https://api.github.com/users/dayamr","html_url":"https://github.com/dayamr","followers_url":"https://api.github.com/users/dayamr/followers","following_url":"https://api.github.com/users/dayamr/following{/other_user}","gists_url":"https://api.github.com/users/dayamr/gists{/gist_id}","starred_url":"https://api.github.com/users/dayamr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dayamr/subscriptions","organizations_url":"https://api.github.com/users/dayamr/orgs","repos_url":"https://api.github.com/users/dayamr/repos","events_url":"https://api.github.com/users/dayamr/events{/privacy}","received_events_url":"https://api.github.com/users/dayamr/received_events","type":"User","site_admin":false},"body":"- Jobs end point result doesn't contain pagination. Fixed that issue in this PR","created_at":"2016-08-30T22:02:03Z","updated_at":"2016-09-07T18:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"072b58d25886516a233ca4ccc7a2dfbf7d589345","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/fili/pulls/20/commits","review_comments_url":"https://api.github.com/repos/yahoo/fili/pulls/20/comments","review_comment_url":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/fili/issues/20/comments","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/f4456e4b19fc51bee9a80e6af187183a56c77ce1","head":{"label":"yahoo:ISSUE_ID_17_Paginate_the_results","ref":"ISSUE_ID_17_Paginate_the_results","sha":"f4456e4b19fc51bee9a80e6af187183a56c77ce1","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2016-08-31T15:24:19Z","pushed_at":"2016-09-07T15:43:31Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":null,"size":1252,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":14,"forks":6,"open_issues":14,"watchers":9,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"0c154a64602361ce43f288450975f5fb273bcc8a","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2016-08-31T15:24:19Z","pushed_at":"2016-09-07T15:43:31Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":null,"size":1252,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":14,"forks":6,"open_issues":14,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/20"},"html":{"href":"https://github.com/yahoo/fili/pull/20"},"issue":{"href":"https://api.github.com/repos/yahoo/fili/issues/20"},"comments":{"href":"https://api.github.com/repos/yahoo/fili/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/fili/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/fili/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/fili/statuses/f4456e4b19fc51bee9a80e6af187183a56c77ce1"}}}}
{"actor":{"display_login":"cdeszaq"}}