{"action":"created","comment":{"url":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments/91319649","pull_request_review_id":11827857,"id":91319649,"diff_hunk":"@@ -6,12 +6,15 @@\n   <section ng-show=\"${model}.associations.${type}.length > 0\" class=\"associated-section\">\n     <label translate>Associated waypoints</label>\n     <article class=\"associated-documents\">\n-      <div class=\"list-item\"\n+      <div class=\"list-item waypoints\"\n+           % if model == 'route':\n+              style=\"min-height: 115px;\"","path":"c2corg_ui/templates/helpers/edit.html","position":7,"original_position":7,"commit_id":"8fdd134c831fe58eef7da5189f68b27ec3015514","original_commit_id":"8fdd134c831fe58eef7da5189f68b27ec3015514","user":{"login":"asaunier","id":1192331,"avatar_url":"https://avatars.githubusercontent.com/u/1192331?v=3","gravatar_id":"","url":"https://api.github.com/users/asaunier","html_url":"https://github.com/asaunier","followers_url":"https://api.github.com/users/asaunier/followers","following_url":"https://api.github.com/users/asaunier/following{/other_user}","gists_url":"https://api.github.com/users/asaunier/gists{/gist_id}","starred_url":"https://api.github.com/users/asaunier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaunier/subscriptions","organizations_url":"https://api.github.com/users/asaunier/orgs","repos_url":"https://api.github.com/users/asaunier/repos","events_url":"https://api.github.com/users/asaunier/events{/privacy}","received_events_url":"https://api.github.com/users/asaunier/received_events","type":"User","site_admin":false},"body":"Can we use a class instead?","created_at":"2016-12-07T15:43:52Z","updated_at":"2016-12-07T15:43:52Z","html_url":"https://github.com/c2corg/v6_ui/pull/1124#discussion_r91319649","pull_request_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124","_links":{"self":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments/91319649"},"html":{"href":"https://github.com/c2corg/v6_ui/pull/1124#discussion_r91319649"},"pull_request":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124"}}},"pull_request":{"url":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124","id":96922267,"html_url":"https://github.com/c2corg/v6_ui/pull/1124","diff_url":"https://github.com/c2corg/v6_ui/pull/1124.diff","patch_url":"https://github.com/c2corg/v6_ui/pull/1124.patch","issue_url":"https://api.github.com/repos/c2corg/v6_ui/issues/1124","number":1124,"state":"open","locked":false,"title":"Layout columns","user":{"login":"ginold","id":7814311,"avatar_url":"https://avatars.githubusercontent.com/u/7814311?v=3","gravatar_id":"","url":"https://api.github.com/users/ginold","html_url":"https://github.com/ginold","followers_url":"https://api.github.com/users/ginold/followers","following_url":"https://api.github.com/users/ginold/following{/other_user}","gists_url":"https://api.github.com/users/ginold/gists{/gist_id}","starred_url":"https://api.github.com/users/ginold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginold/subscriptions","organizations_url":"https://api.github.com/users/ginold/orgs","repos_url":"https://api.github.com/users/ginold/repos","events_url":"https://api.github.com/users/ginold/events{/privacy}","received_events_url":"https://api.github.com/users/ginold/received_events","type":"User","site_admin":false},"body":"related to #690 \r\n\r\nAfter a few unsuccessful attempts to work with `columns` and `ellipsis` (= hide a text too long and replace last letters with\"...\" -> we're in 2016 and it's impossible to do it for more than a single line with pure CSS!! -.- only chrome supports a special property to do it, how surprising...), I decided to go back again to `flexbox` which we had at the beginning and that we decided to throw away because all the cards had the same height per row of cards, and often it looked weird with one card full and the next one nearly empty.\r\n\r\nNow I came back to this solution and time has passed, the cards have more data and it doesn't look that bad. However, I had to make a lot of adaptations and the cards have changed the layout, hopefully for the best:\r\n\r\n**outings** when in the feed, the author info is redundant with \"xxx has created an outing\"\r\n![screenshot from 2016-12-07 09-24-35](https://cloud.githubusercontent.com/assets/7814311/20968792/6d044316-bc86-11e6-926b-349f47a5e95c.png)\r\n\r\n**articles** you can show the last activities if more than 4 (anyway always showing them all was unreadable...). Could totally be used for outings, routes and others too, but i have never seen more than 3 activities.\r\n![screenshot from 2016-12-07 13-46-00](https://cloud.githubusercontent.com/assets/7814311/20968817/81db8b32-bc86-11e6-9173-ec34f1932387.png)\r\n\r\n\r\n**routes**\r\n![screenshot from 2016-12-07 09-23-39](https://cloud.githubusercontent.com/assets/7814311/20968841/9c49605c-bc86-11e6-933b-4e631da7a057.png)\r\n\r\n**areas**\r\n![screenshot from 2016-12-07 09-25-43](https://cloud.githubusercontent.com/assets/7814311/20968868/b1cbdaf4-bc86-11e6-8540-1b36e5547145.png)\r\n\r\n**xreports**\r\n![screenshot from 2016-12-07 14-10-17](https://cloud.githubusercontent.com/assets/7814311/20968908/e9d73bc8-bc86-11e6-8f59-041212023dc9.png)\r\n\r\n**waypoints**\r\n![screenshot from 2016-12-07 09-25-01](https://cloud.githubusercontent.com/assets/7814311/20968920/f55c8458-bc86-11e6-9f29-25e200d213cb.png)\r\n\r\n**books**\r\n![screenshot from 2016-12-07 09-25-23](https://cloud.githubusercontent.com/assets/7814311/20968960/1a44976a-bc87-11e6-8aeb-27346f7e68d1.png)\r\n\r\n**users** in outing editing\r\n![screenshot from 2016-12-07 14-18-04](https://cloud.githubusercontent.com/assets/7814311/20969136/00a944c6-bc88-11e6-8c5a-574c68948528.png)\r\n\r\n\r\nAll in all, the cards look good IMHO and are sorted from left to right.\r\nI didn't test the Images because they don't load at all and I can't upload, but it should be ok, there is very little to be shown.\r\n\r\nStill looking for typos, it may happen after editing 19 files :P\r\n","created_at":"2016-12-07T13:22:28Z","updated_at":"2016-12-07T15:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9be9fa55979b9dc5f263925bec02c51fd59e3728","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/c2corg/v6_ui/milestones/8","html_url":"https://github.com/c2corg/v6_ui/milestones/Go%20Live","labels_url":"https://api.github.com/repos/c2corg/v6_ui/milestones/8/labels","id":2031429,"number":8,"title":"Go Live","description":"","creator":{"login":"fjacon","id":1583203,"avatar_url":"https://avatars.githubusercontent.com/u/1583203?v=3","gravatar_id":"","url":"https://api.github.com/users/fjacon","html_url":"https://github.com/fjacon","followers_url":"https://api.github.com/users/fjacon/followers","following_url":"https://api.github.com/users/fjacon/following{/other_user}","gists_url":"https://api.github.com/users/fjacon/gists{/gist_id}","starred_url":"https://api.github.com/users/fjacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjacon/subscriptions","organizations_url":"https://api.github.com/users/fjacon/orgs","repos_url":"https://api.github.com/users/fjacon/repos","events_url":"https://api.github.com/users/fjacon/events{/privacy}","received_events_url":"https://api.github.com/users/fjacon/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":62,"state":"open","created_at":"2016-09-27T10:20:53Z","updated_at":"2016-12-07T13:54:47Z","due_on":"2016-12-05T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124/commits","review_comments_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124/comments","review_comment_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/c2corg/v6_ui/issues/1124/comments","statuses_url":"https://api.github.com/repos/c2corg/v6_ui/statuses/8fdd134c831fe58eef7da5189f68b27ec3015514","head":{"label":"c2corg:layout-columns","ref":"layout-columns","sha":"8fdd134c831fe58eef7da5189f68b27ec3015514","user":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"repo":{"id":43445823,"name":"v6_ui","full_name":"c2corg/v6_ui","owner":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/c2corg/v6_ui","description":"UI for c2c.org v6","fork":false,"url":"https://api.github.com/repos/c2corg/v6_ui","forks_url":"https://api.github.com/repos/c2corg/v6_ui/forks","keys_url":"https://api.github.com/repos/c2corg/v6_ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c2corg/v6_ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c2corg/v6_ui/teams","hooks_url":"https://api.github.com/repos/c2corg/v6_ui/hooks","issue_events_url":"https://api.github.com/repos/c2corg/v6_ui/issues/events{/number}","events_url":"https://api.github.com/repos/c2corg/v6_ui/events","assignees_url":"https://api.github.com/repos/c2corg/v6_ui/assignees{/user}","branches_url":"https://api.github.com/repos/c2corg/v6_ui/branches{/branch}","tags_url":"https://api.github.com/repos/c2corg/v6_ui/tags","blobs_url":"https://api.github.com/repos/c2corg/v6_ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c2corg/v6_ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c2corg/v6_ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/c2corg/v6_ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c2corg/v6_ui/statuses/{sha}","languages_url":"https://api.github.com/repos/c2corg/v6_ui/languages","stargazers_url":"https://api.github.com/repos/c2corg/v6_ui/stargazers","contributors_url":"https://api.github.com/repos/c2corg/v6_ui/contributors","subscribers_url":"https://api.github.com/repos/c2corg/v6_ui/subscribers","subscription_url":"https://api.github.com/repos/c2corg/v6_ui/subscription","commits_url":"https://api.github.com/repos/c2corg/v6_ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/c2corg/v6_ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/c2corg/v6_ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/c2corg/v6_ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/c2corg/v6_ui/contents/{+path}","compare_url":"https://api.github.com/repos/c2corg/v6_ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c2corg/v6_ui/merges","archive_url":"https://api.github.com/repos/c2corg/v6_ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c2corg/v6_ui/downloads","issues_url":"https://api.github.com/repos/c2corg/v6_ui/issues{/number}","pulls_url":"https://api.github.com/repos/c2corg/v6_ui/pulls{/number}","milestones_url":"https://api.github.com/repos/c2corg/v6_ui/milestones{/number}","notifications_url":"https://api.github.com/repos/c2corg/v6_ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c2corg/v6_ui/labels{/name}","releases_url":"https://api.github.com/repos/c2corg/v6_ui/releases{/id}","deployments_url":"https://api.github.com/repos/c2corg/v6_ui/deployments","created_at":"2015-09-30T16:52:44Z","updated_at":"2016-11-19T11:59:56Z","pushed_at":"2016-12-07T15:17:37Z","git_url":"git://github.com/c2corg/v6_ui.git","ssh_url":"git@github.com:c2corg/v6_ui.git","clone_url":"https://github.com/c2corg/v6_ui.git","svn_url":"https://github.com/c2corg/v6_ui","homepage":null,"size":4330,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":143,"forks":4,"open_issues":143,"watchers":3,"default_branch":"master"}},"base":{"label":"c2corg:master","ref":"master","sha":"9b289cbe29fc24087fb5e2ccbaf8f4183e03ca8a","user":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"repo":{"id":43445823,"name":"v6_ui","full_name":"c2corg/v6_ui","owner":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/c2corg/v6_ui","description":"UI for c2c.org v6","fork":false,"url":"https://api.github.com/repos/c2corg/v6_ui","forks_url":"https://api.github.com/repos/c2corg/v6_ui/forks","keys_url":"https://api.github.com/repos/c2corg/v6_ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c2corg/v6_ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c2corg/v6_ui/teams","hooks_url":"https://api.github.com/repos/c2corg/v6_ui/hooks","issue_events_url":"https://api.github.com/repos/c2corg/v6_ui/issues/events{/number}","events_url":"https://api.github.com/repos/c2corg/v6_ui/events","assignees_url":"https://api.github.com/repos/c2corg/v6_ui/assignees{/user}","branches_url":"https://api.github.com/repos/c2corg/v6_ui/branches{/branch}","tags_url":"https://api.github.com/repos/c2corg/v6_ui/tags","blobs_url":"https://api.github.com/repos/c2corg/v6_ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c2corg/v6_ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c2corg/v6_ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/c2corg/v6_ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c2corg/v6_ui/statuses/{sha}","languages_url":"https://api.github.com/repos/c2corg/v6_ui/languages","stargazers_url":"https://api.github.com/repos/c2corg/v6_ui/stargazers","contributors_url":"https://api.github.com/repos/c2corg/v6_ui/contributors","subscribers_url":"https://api.github.com/repos/c2corg/v6_ui/subscribers","subscription_url":"https://api.github.com/repos/c2corg/v6_ui/subscription","commits_url":"https://api.github.com/repos/c2corg/v6_ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/c2corg/v6_ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/c2corg/v6_ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/c2corg/v6_ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/c2corg/v6_ui/contents/{+path}","compare_url":"https://api.github.com/repos/c2corg/v6_ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c2corg/v6_ui/merges","archive_url":"https://api.github.com/repos/c2corg/v6_ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c2corg/v6_ui/downloads","issues_url":"https://api.github.com/repos/c2corg/v6_ui/issues{/number}","pulls_url":"https://api.github.com/repos/c2corg/v6_ui/pulls{/number}","milestones_url":"https://api.github.com/repos/c2corg/v6_ui/milestones{/number}","notifications_url":"https://api.github.com/repos/c2corg/v6_ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c2corg/v6_ui/labels{/name}","releases_url":"https://api.github.com/repos/c2corg/v6_ui/releases{/id}","deployments_url":"https://api.github.com/repos/c2corg/v6_ui/deployments","created_at":"2015-09-30T16:52:44Z","updated_at":"2016-11-19T11:59:56Z","pushed_at":"2016-12-07T15:17:37Z","git_url":"git://github.com/c2corg/v6_ui.git","ssh_url":"git@github.com:c2corg/v6_ui.git","clone_url":"https://github.com/c2corg/v6_ui.git","svn_url":"https://github.com/c2corg/v6_ui","homepage":null,"size":4330,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":143,"forks":4,"open_issues":143,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124"},"html":{"href":"https://github.com/c2corg/v6_ui/pull/1124"},"issue":{"href":"https://api.github.com/repos/c2corg/v6_ui/issues/1124"},"comments":{"href":"https://api.github.com/repos/c2corg/v6_ui/issues/1124/comments"},"review_comments":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124/comments"},"review_comment":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/1124/commits"},"statuses":{"href":"https://api.github.com/repos/c2corg/v6_ui/statuses/8fdd134c831fe58eef7da5189f68b27ec3015514"}}}}
{"actor":{"display_login":"asaunier"}}