{"action":"created","comment":{"url":"https://api.github.com/repos/scality/S3/pulls/comments/84950725","pull_request_review_id":5695906,"id":84950725,"diff_hunk":"@@ -301,6 +301,104 @@ describe('putBucketACL API', () => {\n         });\n     });\n \n+    it('should set ACLs with an empty AccessControlList section', done => {\n+        const testACLRequest = {\n+            bucketName,\n+            namespace,\n+            headers: { host: `${bucketName}.s3.amazonaws.com` },\n+            post: '<AccessControlPolicy xmlns=' +\n+                    '\"http://s3.amazonaws.com/doc/2006-03-01/\">' +\n+                  '<Owner>' +\n+                    '<ID>852b113e7a2f25102679df27bb0ae12b3f85be6' +\n+                    'BucketOwnerCanonicalUserID</ID>' +\n+                    '<DisplayName>OwnerDisplayName</DisplayName>' +\n+                  '</Owner>' +\n+                  '<AccessControlList></AccessControlList>' +\n+                '</AccessControlPolicy>',\n+            url: '/?acl',\n+            query: { acl: '' },\n+        };\n+\n+        bucketPutACL(authInfo, testACLRequest, log, err => {\n+            assert.strictEqual(err, undefined);\n+            metadata.getBucket(bucketName, log, (err, md) => {\n+                assert.strictEqual(md.getAcl().Canned, '');\n+                assert.strictEqual(md.getAcl().FULL_CONTROL.length, 0);\n+                assert.strictEqual(md.getAcl().READ.length, 0);\n+                assert.strictEqual(md.getAcl().WRITE.length, 0);\n+                assert.strictEqual(md.getAcl().WRITE_ACP.length, 0);\n+                assert.strictEqual(md.getAcl().READ_ACP.length, 0);\n+                done();\n+            });\n+        });\n+    });\n+\n+    it('should set ACLs without AccessControlList section', done => {","path":"tests/unit/api/bucketPutACL.js","position":36,"original_position":36,"commit_id":"6a6314b7470a16b14cde5f662d6d9636c721c164","original_commit_id":"6a6314b7470a16b14cde5f662d6d9636c721c164","user":{"login":"ttvi","id":5533536,"avatar_url":"https://avatars.githubusercontent.com/u/5533536?v=3","gravatar_id":"","url":"https://api.github.com/users/ttvi","html_url":"https://github.com/ttvi","followers_url":"https://api.github.com/users/ttvi/followers","following_url":"https://api.github.com/users/ttvi/following{/other_user}","gists_url":"https://api.github.com/users/ttvi/gists{/gist_id}","starred_url":"https://api.github.com/users/ttvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttvi/subscriptions","organizations_url":"https://api.github.com/users/ttvi/orgs","repos_url":"https://api.github.com/users/ttvi/repos","events_url":"https://api.github.com/users/ttvi/events{/privacy}","received_events_url":"https://api.github.com/users/ttvi/received_events","type":"User","site_admin":false},"body":"should not be able to set ACLs ...","created_at":"2016-10-25T17:01:53Z","updated_at":"2016-10-25T17:01:53Z","html_url":"https://github.com/scality/S3/pull/305#discussion_r84950725","pull_request_url":"https://api.github.com/repos/scality/S3/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/comments/84950725"},"html":{"href":"https://github.com/scality/S3/pull/305#discussion_r84950725"},"pull_request":{"href":"https://api.github.com/repos/scality/S3/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/scality/S3/pulls/305","id":90445593,"html_url":"https://github.com/scality/S3/pull/305","diff_url":"https://github.com/scality/S3/pull/305.diff","patch_url":"https://github.com/scality/S3/pull/305.patch","issue_url":"https://api.github.com/repos/scality/S3/issues/305","number":305,"state":"open","locked":false,"title":"COMPAT: set ACLs with an empty AccessControlList","user":{"login":"nicolas2bert","id":7453636,"avatar_url":"https://avatars.githubusercontent.com/u/7453636?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas2bert","html_url":"https://github.com/nicolas2bert","followers_url":"https://api.github.com/users/nicolas2bert/followers","following_url":"https://api.github.com/users/nicolas2bert/following{/other_user}","gists_url":"https://api.github.com/users/nicolas2bert/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas2bert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas2bert/subscriptions","organizations_url":"https://api.github.com/users/nicolas2bert/orgs","repos_url":"https://api.github.com/users/nicolas2bert/repos","events_url":"https://api.github.com/users/nicolas2bert/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas2bert/received_events","type":"User","site_admin":false},"body":"FIXES #304","created_at":"2016-10-21T21:17:25Z","updated_at":"2016-10-25T17:01:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f45daee0bc2df615487ce50c4fd315940b06f26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scality/S3/pulls/305/commits","review_comments_url":"https://api.github.com/repos/scality/S3/pulls/305/comments","review_comment_url":"https://api.github.com/repos/scality/S3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/S3/issues/305/comments","statuses_url":"https://api.github.com/repos/scality/S3/statuses/6a6314b7470a16b14cde5f662d6d9636c721c164","head":{"label":"scality:COMPAT/emptyACL","ref":"COMPAT/emptyACL","sha":"6a6314b7470a16b14cde5f662d6d9636c721c164","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-10-25T15:40:33Z","pushed_at":"2016-10-25T01:15:14Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3719,"stargazers_count":235,"watchers_count":235,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":54,"forks":30,"open_issues":54,"watchers":235,"default_branch":"master"}},"base":{"label":"scality:master","ref":"master","sha":"99dd642e21530675f893b8a0c32e5867035bfbb3","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-10-25T15:40:33Z","pushed_at":"2016-10-25T01:15:14Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3719,"stargazers_count":235,"watchers_count":235,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":54,"forks":30,"open_issues":54,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/305"},"html":{"href":"https://github.com/scality/S3/pull/305"},"issue":{"href":"https://api.github.com/repos/scality/S3/issues/305"},"comments":{"href":"https://api.github.com/repos/scality/S3/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/S3/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/S3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/S3/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/scality/S3/statuses/6a6314b7470a16b14cde5f662d6d9636c721c164"}}}}
{"actor":{"display_login":"ttvi"}}