{"action":"created","comment":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/84129735","pull_request_review_id":4926592,"id":84129735,"diff_hunk":"@@ -413,6 +454,37 @@ default int length() {\n     <U extends V> Map<K, V> merge(Map<? extends K, U> that, BiFunction<? super V, ? super U, ? extends V> collisionResolution);\n \n     /**\n+     * Calculates the <em>minimum</em> of this {@code Map} values using the natural {@code Comparator} of the values, if exists.\n+     *\n+     * @return {@code Some(minimum)} of this elements or {@code None} if this is empty or no {@code Comparator} is applicable\n+     */\n+    @SuppressWarnings(\"unchecked\")\n+    @Override\n+    default Option<Tuple2<K, V>> min() {\n+        if (isEmpty()) {\n+            return Option.none();\n+        } else {\n+            if (head()._2 instanceof Comparator) {","path":"javaslang/src/main/java/javaslang/collection/Map.java","position":99,"original_position":99,"commit_id":"a140a75da8d60153840d365e2da6453033af2593","original_commit_id":"a140a75da8d60153840d365e2da6453033af2593","user":{"login":"ruslansennov","id":1582377,"avatar_url":"https://avatars.githubusercontent.com/u/1582377?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslansennov","html_url":"https://github.com/ruslansennov","followers_url":"https://api.github.com/users/ruslansennov/followers","following_url":"https://api.github.com/users/ruslansennov/following{/other_user}","gists_url":"https://api.github.com/users/ruslansennov/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslansennov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslansennov/subscriptions","organizations_url":"https://api.github.com/users/ruslansennov/orgs","repos_url":"https://api.github.com/users/ruslansennov/repos","events_url":"https://api.github.com/users/ruslansennov/events{/privacy}","received_events_url":"https://api.github.com/users/ruslansennov/received_events","type":"User","site_admin":false},"body":"dito","created_at":"2016-10-19T17:57:24Z","updated_at":"2016-10-19T17:58:39Z","html_url":"https://github.com/javaslang/javaslang/pull/1631#discussion_r84129735","pull_request_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1631","_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/84129735"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1631#discussion_r84129735"},"pull_request":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1631"}}},"pull_request":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/1631","id":90056188,"html_url":"https://github.com/javaslang/javaslang/pull/1631","diff_url":"https://github.com/javaslang/javaslang/pull/1631.diff","patch_url":"https://github.com/javaslang/javaslang/pull/1631.patch","issue_url":"https://api.github.com/repos/javaslang/javaslang/issues/1631","number":1631,"state":"open","locked":false,"title":"Overrides numeric Map operations.","user":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"body":"It was necessary for sum(), product() and average(), because a Map consists of Tuples, which are not numeric. We now operate on Map values.\r\n\r\n(Minor fixes in Traversable: Avoids unnecessary object creation in empty case.)","created_at":"2016-10-19T17:34:56Z","updated_at":"2016-10-19T17:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfe7083cfdbecfd2eb6d8e30c65851077c979807","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/javaslang/javaslang/milestones/20","html_url":"https://github.com/javaslang/javaslang/milestones/2.1.0","labels_url":"https://api.github.com/repos/javaslang/javaslang/milestones/20/labels","id":1294243,"number":20,"title":"2.1.0","description":"Boost up collection performance","creator":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":279,"state":"open","created_at":"2015-09-07T18:46:28Z","updated_at":"2016-10-19T17:43:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1631/commits","review_comments_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1631/comments","review_comment_url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javaslang/javaslang/issues/1631/comments","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/a140a75da8d60153840d365e2da6453033af2593","head":{"label":"danieldietrich:numeric-map-ops","ref":"numeric-map-ops","sha":"a140a75da8d60153840d365e2da6453033af2593","user":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"repo":{"id":54592360,"name":"javaslang","full_name":"danieldietrich/javaslang","owner":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danieldietrich/javaslang","description":"A functional library for Java 8+ that provides persistent data types and functional control structures.","fork":true,"url":"https://api.github.com/repos/danieldietrich/javaslang","forks_url":"https://api.github.com/repos/danieldietrich/javaslang/forks","keys_url":"https://api.github.com/repos/danieldietrich/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danieldietrich/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danieldietrich/javaslang/teams","hooks_url":"https://api.github.com/repos/danieldietrich/javaslang/hooks","issue_events_url":"https://api.github.com/repos/danieldietrich/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/danieldietrich/javaslang/events","assignees_url":"https://api.github.com/repos/danieldietrich/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/danieldietrich/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/danieldietrich/javaslang/tags","blobs_url":"https://api.github.com/repos/danieldietrich/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danieldietrich/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danieldietrich/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/danieldietrich/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danieldietrich/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/danieldietrich/javaslang/languages","stargazers_url":"https://api.github.com/repos/danieldietrich/javaslang/stargazers","contributors_url":"https://api.github.com/repos/danieldietrich/javaslang/contributors","subscribers_url":"https://api.github.com/repos/danieldietrich/javaslang/subscribers","subscription_url":"https://api.github.com/repos/danieldietrich/javaslang/subscription","commits_url":"https://api.github.com/repos/danieldietrich/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/danieldietrich/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/danieldietrich/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/danieldietrich/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/danieldietrich/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/danieldietrich/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danieldietrich/javaslang/merges","archive_url":"https://api.github.com/repos/danieldietrich/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danieldietrich/javaslang/downloads","issues_url":"https://api.github.com/repos/danieldietrich/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/danieldietrich/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/danieldietrich/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/danieldietrich/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danieldietrich/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/danieldietrich/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/danieldietrich/javaslang/deployments","created_at":"2016-03-23T20:54:28Z","updated_at":"2016-09-19T09:43:33Z","pushed_at":"2016-10-19T17:31:55Z","git_url":"git://github.com/danieldietrich/javaslang.git","ssh_url":"git@github.com:danieldietrich/javaslang.git","clone_url":"https://github.com/danieldietrich/javaslang.git","svn_url":"https://github.com/danieldietrich/javaslang","homepage":"http://javaslang.io","size":12973,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"javaslang:master","ref":"master","sha":"7bcf7019a3d862167b9d3874f4da1773bf3c8dec","user":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"repo":{"id":16378879,"name":"javaslang","full_name":"javaslang/javaslang","owner":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/javaslang/javaslang","description":"Javaslang is an object-functional language extension to Java 8, which aims to reduce the lines of code and increase code quality. It provides persistent collections, functional abstractions for error handling, concurrent programming, pattern matching and much more.  Javaslang fuses the power of object-oriented programming with the elegance and robustness of functional programming. The most interesting part is a feature-rich, persistent collection library that smoothly integrates with Java's standard collections.","fork":false,"url":"https://api.github.com/repos/javaslang/javaslang","forks_url":"https://api.github.com/repos/javaslang/javaslang/forks","keys_url":"https://api.github.com/repos/javaslang/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javaslang/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javaslang/javaslang/teams","hooks_url":"https://api.github.com/repos/javaslang/javaslang/hooks","issue_events_url":"https://api.github.com/repos/javaslang/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/javaslang/javaslang/events","assignees_url":"https://api.github.com/repos/javaslang/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/javaslang/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/javaslang/javaslang/tags","blobs_url":"https://api.github.com/repos/javaslang/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javaslang/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javaslang/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/javaslang/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/javaslang/javaslang/languages","stargazers_url":"https://api.github.com/repos/javaslang/javaslang/stargazers","contributors_url":"https://api.github.com/repos/javaslang/javaslang/contributors","subscribers_url":"https://api.github.com/repos/javaslang/javaslang/subscribers","subscription_url":"https://api.github.com/repos/javaslang/javaslang/subscription","commits_url":"https://api.github.com/repos/javaslang/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/javaslang/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/javaslang/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/javaslang/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/javaslang/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/javaslang/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javaslang/javaslang/merges","archive_url":"https://api.github.com/repos/javaslang/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javaslang/javaslang/downloads","issues_url":"https://api.github.com/repos/javaslang/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/javaslang/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/javaslang/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/javaslang/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javaslang/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/javaslang/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/javaslang/javaslang/deployments","created_at":"2014-01-30T14:07:25Z","updated_at":"2016-10-19T17:44:55Z","pushed_at":"2016-10-19T17:43:42Z","git_url":"git://github.com/javaslang/javaslang.git","ssh_url":"git@github.com:javaslang/javaslang.git","clone_url":"https://github.com/javaslang/javaslang.git","svn_url":"https://github.com/javaslang/javaslang","homepage":"http://javaslang.io","size":14689,"stargazers_count":1235,"watchers_count":1235,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":134,"forks":143,"open_issues":134,"watchers":1235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1631"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1631"},"issue":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1631"},"comments":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1631/comments"},"review_comments":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1631/comments"},"review_comment":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1631/commits"},"statuses":{"href":"https://api.github.com/repos/javaslang/javaslang/statuses/a140a75da8d60153840d365e2da6453033af2593"}}}}
{"actor":{"display_login":"ruslansennov"}}