{"action":"created","comment":{"url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/comments/82650038","pull_request_review_id":3542935,"id":82650038,"diff_hunk":"@@ -69,39 +69,54 @@ BLEPeripheral::~BLEPeripheral() {\n }\n \n void BLEPeripheral::begin() {\n-  unsigned char advertisementDataType = 0;\n   unsigned char scanDataType = 0;\n \n-  unsigned char advertisementDataLength = 0;\n+  unsigned char advertisementDataSize = 0;\n   unsigned char scanDataLength = 0;\n \n-  unsigned char advertisementData[BLE_ADVERTISEMENT_DATA_MAX_VALUE_LENGTH];\n+  BLEAdvertisementData advertisementData[3];","path":"src/BLEPeripheral.cpp","position":12,"original_position":12,"commit_id":"6e2b2b9fd7a6d730cde29dc558c0cd6af92c25a0","original_commit_id":"6e2b2b9fd7a6d730cde29dc558c0cd6af92c25a0","user":{"login":"sandeepmistry","id":1163840,"avatar_url":"https://avatars.githubusercontent.com/u/1163840?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepmistry","html_url":"https://github.com/sandeepmistry","followers_url":"https://api.github.com/users/sandeepmistry/followers","following_url":"https://api.github.com/users/sandeepmistry/following{/other_user}","gists_url":"https://api.github.com/users/sandeepmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepmistry/subscriptions","organizations_url":"https://api.github.com/users/sandeepmistry/orgs","repos_url":"https://api.github.com/users/sandeepmistry/repos","events_url":"https://api.github.com/users/sandeepmistry/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepmistry/received_events","type":"User","site_admin":false},"body":"So, this will using about 42 more bytes of RAM on nRF8001 boards, which I think is ok. Not sure if there's a way to reduce it.","created_at":"2016-10-10T17:41:50Z","updated_at":"2016-10-10T17:43:41Z","html_url":"https://github.com/sandeepmistry/arduino-BLEPeripheral/pull/89#discussion_r82650038","pull_request_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/comments/82650038"},"html":{"href":"https://github.com/sandeepmistry/arduino-BLEPeripheral/pull/89#discussion_r82650038"},"pull_request":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89","id":88254260,"html_url":"https://github.com/sandeepmistry/arduino-BLEPeripheral/pull/89","diff_url":"https://github.com/sandeepmistry/arduino-BLEPeripheral/pull/89.diff","patch_url":"https://github.com/sandeepmistry/arduino-BLEPeripheral/pull/89.patch","issue_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/issues/89","number":89,"state":"open","locked":false,"title":"Allow advertisement to contain multiple types of data","user":{"login":"asharov","id":1683354,"avatar_url":"https://avatars.githubusercontent.com/u/1683354?v=3","gravatar_id":"","url":"https://api.github.com/users/asharov","html_url":"https://github.com/asharov","followers_url":"https://api.github.com/users/asharov/followers","following_url":"https://api.github.com/users/asharov/following{/other_user}","gists_url":"https://api.github.com/users/asharov/gists{/gist_id}","starred_url":"https://api.github.com/users/asharov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asharov/subscriptions","organizations_url":"https://api.github.com/users/asharov/orgs","repos_url":"https://api.github.com/users/asharov/repos","events_url":"https://api.github.com/users/asharov/events{/privacy}","received_events_url":"https://api.github.com/users/asharov/received_events","type":"User","site_admin":false},"body":"Per issue #86, implementation as discussed there.","created_at":"2016-10-06T12:43:28Z","updated_at":"2016-10-10T17:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71f58bf1e56977b5d4e77db0306870b28647886f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89/commits","review_comments_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89/comments","review_comment_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/issues/89/comments","statuses_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/statuses/6e2b2b9fd7a6d730cde29dc558c0cd6af92c25a0","head":{"label":"asharov:master","ref":"master","sha":"6e2b2b9fd7a6d730cde29dc558c0cd6af92c25a0","user":{"login":"asharov","id":1683354,"avatar_url":"https://avatars.githubusercontent.com/u/1683354?v=3","gravatar_id":"","url":"https://api.github.com/users/asharov","html_url":"https://github.com/asharov","followers_url":"https://api.github.com/users/asharov/followers","following_url":"https://api.github.com/users/asharov/following{/other_user}","gists_url":"https://api.github.com/users/asharov/gists{/gist_id}","starred_url":"https://api.github.com/users/asharov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asharov/subscriptions","organizations_url":"https://api.github.com/users/asharov/orgs","repos_url":"https://api.github.com/users/asharov/repos","events_url":"https://api.github.com/users/asharov/events{/privacy}","received_events_url":"https://api.github.com/users/asharov/received_events","type":"User","site_admin":false},"repo":{"id":70140518,"name":"arduino-BLEPeripheral","full_name":"asharov/arduino-BLEPeripheral","owner":{"login":"asharov","id":1683354,"avatar_url":"https://avatars.githubusercontent.com/u/1683354?v=3","gravatar_id":"","url":"https://api.github.com/users/asharov","html_url":"https://github.com/asharov","followers_url":"https://api.github.com/users/asharov/followers","following_url":"https://api.github.com/users/asharov/following{/other_user}","gists_url":"https://api.github.com/users/asharov/gists{/gist_id}","starred_url":"https://api.github.com/users/asharov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asharov/subscriptions","organizations_url":"https://api.github.com/users/asharov/orgs","repos_url":"https://api.github.com/users/asharov/repos","events_url":"https://api.github.com/users/asharov/events{/privacy}","received_events_url":"https://api.github.com/users/asharov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asharov/arduino-BLEPeripheral","description":"An Arduino library for creating custom BLE peripherals with Nordic Semiconductor's nRF8001 or nR51822.","fork":true,"url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral","forks_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/forks","keys_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/teams","hooks_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/hooks","issue_events_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/issues/events{/number}","events_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/events","assignees_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/assignees{/user}","branches_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/branches{/branch}","tags_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/tags","blobs_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/git/refs{/sha}","trees_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/statuses/{sha}","languages_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/languages","stargazers_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/stargazers","contributors_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/contributors","subscribers_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/subscribers","subscription_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/subscription","commits_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/commits{/sha}","git_commits_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/git/commits{/sha}","comments_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/comments{/number}","issue_comment_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/issues/comments{/number}","contents_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/contents/{+path}","compare_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/merges","archive_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/downloads","issues_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/issues{/number}","pulls_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/pulls{/number}","milestones_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/milestones{/number}","notifications_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/labels{/name}","releases_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/releases{/id}","deployments_url":"https://api.github.com/repos/asharov/arduino-BLEPeripheral/deployments","created_at":"2016-10-06T09:31:23Z","updated_at":"2016-10-06T09:31:25Z","pushed_at":"2016-10-06T12:38:47Z","git_url":"git://github.com/asharov/arduino-BLEPeripheral.git","ssh_url":"git@github.com:asharov/arduino-BLEPeripheral.git","clone_url":"https://github.com/asharov/arduino-BLEPeripheral.git","svn_url":"https://github.com/asharov/arduino-BLEPeripheral","homepage":"","size":1171,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sandeepmistry:master","ref":"master","sha":"5c20a1b76f5c60875706ee738a665d16cee3e160","user":{"login":"sandeepmistry","id":1163840,"avatar_url":"https://avatars.githubusercontent.com/u/1163840?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepmistry","html_url":"https://github.com/sandeepmistry","followers_url":"https://api.github.com/users/sandeepmistry/followers","following_url":"https://api.github.com/users/sandeepmistry/following{/other_user}","gists_url":"https://api.github.com/users/sandeepmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepmistry/subscriptions","organizations_url":"https://api.github.com/users/sandeepmistry/orgs","repos_url":"https://api.github.com/users/sandeepmistry/repos","events_url":"https://api.github.com/users/sandeepmistry/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepmistry/received_events","type":"User","site_admin":false},"repo":{"id":21054064,"name":"arduino-BLEPeripheral","full_name":"sandeepmistry/arduino-BLEPeripheral","owner":{"login":"sandeepmistry","id":1163840,"avatar_url":"https://avatars.githubusercontent.com/u/1163840?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepmistry","html_url":"https://github.com/sandeepmistry","followers_url":"https://api.github.com/users/sandeepmistry/followers","following_url":"https://api.github.com/users/sandeepmistry/following{/other_user}","gists_url":"https://api.github.com/users/sandeepmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepmistry/subscriptions","organizations_url":"https://api.github.com/users/sandeepmistry/orgs","repos_url":"https://api.github.com/users/sandeepmistry/repos","events_url":"https://api.github.com/users/sandeepmistry/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepmistry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandeepmistry/arduino-BLEPeripheral","description":"An Arduino library for creating custom BLE peripherals with Nordic Semiconductor's nRF8001 or nR51822.","fork":false,"url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral","forks_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/forks","keys_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/teams","hooks_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/hooks","issue_events_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/issues/events{/number}","events_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/events","assignees_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/assignees{/user}","branches_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/branches{/branch}","tags_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/tags","blobs_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/statuses/{sha}","languages_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/languages","stargazers_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/stargazers","contributors_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/contributors","subscribers_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/subscribers","subscription_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/subscription","commits_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/contents/{+path}","compare_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/merges","archive_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/downloads","issues_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/issues{/number}","pulls_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls{/number}","milestones_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/milestones{/number}","notifications_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/labels{/name}","releases_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/releases{/id}","deployments_url":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/deployments","created_at":"2014-06-20T22:15:27Z","updated_at":"2016-10-05T21:55:34Z","pushed_at":"2016-10-10T17:38:19Z","git_url":"git://github.com/sandeepmistry/arduino-BLEPeripheral.git","ssh_url":"git@github.com:sandeepmistry/arduino-BLEPeripheral.git","clone_url":"https://github.com/sandeepmistry/arduino-BLEPeripheral.git","svn_url":"https://github.com/sandeepmistry/arduino-BLEPeripheral","homepage":"","size":1343,"stargazers_count":144,"watchers_count":144,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":11,"forks":52,"open_issues":11,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89"},"html":{"href":"https://github.com/sandeepmistry/arduino-BLEPeripheral/pull/89"},"issue":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/issues/89"},"comments":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/sandeepmistry/arduino-BLEPeripheral/statuses/6e2b2b9fd7a6d730cde29dc558c0cd6af92c25a0"}}}}
{"actor":{"display_login":"sandeepmistry"}}