{"action":"created","comment":{"url":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/comments/52548052","id":52548052,"diff_hunk":"@@ -1,10 +1,5 @@\n ---\n - hosts: controllers\n-  become: yes\n   roles:\n-    - common\n-    - mysql\n-    - keystone\n+    - profile/controller\n     - puppet_run\n-  vars:\n-    puppet_role: controller","path":"deployment-example.yaml","position":11,"original_position":11,"commit_id":"18668dacea8656d1f0a4beaff8e2e93febd2af94","original_commit_id":"ccfc7817c348e208076305b984f189f88ae7d865","user":{"login":"larsks","id":82622,"avatar_url":"https://avatars.githubusercontent.com/u/82622?v=3","gravatar_id":"","url":"https://api.github.com/users/larsks","html_url":"https://github.com/larsks","followers_url":"https://api.github.com/users/larsks/followers","following_url":"https://api.github.com/users/larsks/following{/other_user}","gists_url":"https://api.github.com/users/larsks/gists{/gist_id}","starred_url":"https://api.github.com/users/larsks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsks/subscriptions","organizations_url":"https://api.github.com/users/larsks/orgs","repos_url":"https://api.github.com/users/larsks/repos","events_url":"https://api.github.com/users/larsks/events{/privacy}","received_events_url":"https://api.github.com/users/larsks/received_events","type":"User","site_admin":false},"body":"Rebased!","created_at":"2016-02-11T00:06:40Z","updated_at":"2016-02-11T00:06:40Z","html_url":"https://github.com/EmilienM/ansible-marionette/pull/1#discussion_r52548052","pull_request_url":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/comments/52548052"},"html":{"href":"https://github.com/EmilienM/ansible-marionette/pull/1#discussion_r52548052"},"pull_request":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1","id":58963324,"html_url":"https://github.com/EmilienM/ansible-marionette/pull/1","diff_url":"https://github.com/EmilienM/ansible-marionette/pull/1.diff","patch_url":"https://github.com/EmilienM/ansible-marionette/pull/1.patch","issue_url":"https://api.github.com/repos/EmilienM/ansible-marionette/issues/1","number":1,"state":"open","locked":false,"title":"some initial thoughts on the organization of this project","user":{"login":"larsks","id":82622,"avatar_url":"https://avatars.githubusercontent.com/u/82622?v=3","gravatar_id":"","url":"https://api.github.com/users/larsks","html_url":"https://github.com/larsks","followers_url":"https://api.github.com/users/larsks/followers","following_url":"https://api.github.com/users/larsks/following{/other_user}","gists_url":"https://api.github.com/users/larsks/gists{/gist_id}","starred_url":"https://api.github.com/users/larsks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsks/subscriptions","organizations_url":"https://api.github.com/users/larsks/orgs","repos_url":"https://api.github.com/users/larsks/repos","events_url":"https://api.github.com/users/larsks/events{/privacy}","received_events_url":"https://api.github.com/users/larsks/received_events","type":"User","site_admin":false},"body":"Rather than making the choice of role *explicit*, as in the existing\nexample, this makes the puppet role *implict* based on the ansible role\nselected.  In this model, your top-level playbook could have:\n\n    roles:\n      - profile/controller\n\nOr:\n\n    roles:\n      - profile/compute\n\nAnd so forth to select between different host roles. Dependencies (e.g.,\nfor the `common` role that is required everywhere) are handled via\nAnsible's role metadata support (`roles/<rolename>/meta/main.yml`)\n\nIt's also nice to make things reasonably granular...e.g., have roles\nthat *require* puppet depend on a role that is responsible for install\nit.  This just helps keep playbooks focused.\n\nWith these changes, the example deployment playbook becomes:\n\n    - hosts: controllers\n      roles:\n        - profile/controller\n        - puppet_run","created_at":"2016-02-10T22:19:45Z","updated_at":"2016-02-11T00:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f446a9159433d5ba372e91729652fa3240e0830e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1/commits","review_comments_url":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1/comments","review_comment_url":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EmilienM/ansible-marionette/issues/1/comments","statuses_url":"https://api.github.com/repos/EmilienM/ansible-marionette/statuses/18668dacea8656d1f0a4beaff8e2e93febd2af94","head":{"label":"larsks:master","ref":"master","sha":"18668dacea8656d1f0a4beaff8e2e93febd2af94","user":{"login":"larsks","id":82622,"avatar_url":"https://avatars.githubusercontent.com/u/82622?v=3","gravatar_id":"","url":"https://api.github.com/users/larsks","html_url":"https://github.com/larsks","followers_url":"https://api.github.com/users/larsks/followers","following_url":"https://api.github.com/users/larsks/following{/other_user}","gists_url":"https://api.github.com/users/larsks/gists{/gist_id}","starred_url":"https://api.github.com/users/larsks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsks/subscriptions","organizations_url":"https://api.github.com/users/larsks/orgs","repos_url":"https://api.github.com/users/larsks/repos","events_url":"https://api.github.com/users/larsks/events{/privacy}","received_events_url":"https://api.github.com/users/larsks/received_events","type":"User","site_admin":false},"repo":{"id":51476763,"name":"ansible-marionette","full_name":"larsks/ansible-marionette","owner":{"login":"larsks","id":82622,"avatar_url":"https://avatars.githubusercontent.com/u/82622?v=3","gravatar_id":"","url":"https://api.github.com/users/larsks","html_url":"https://github.com/larsks","followers_url":"https://api.github.com/users/larsks/followers","following_url":"https://api.github.com/users/larsks/following{/other_user}","gists_url":"https://api.github.com/users/larsks/gists{/gist_id}","starred_url":"https://api.github.com/users/larsks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsks/subscriptions","organizations_url":"https://api.github.com/users/larsks/orgs","repos_url":"https://api.github.com/users/larsks/repos","events_url":"https://api.github.com/users/larsks/events{/privacy}","received_events_url":"https://api.github.com/users/larsks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larsks/ansible-marionette","description":"Orchestrate with Ansible a complex deployments driven by Puppet OpenStack modules","fork":true,"url":"https://api.github.com/repos/larsks/ansible-marionette","forks_url":"https://api.github.com/repos/larsks/ansible-marionette/forks","keys_url":"https://api.github.com/repos/larsks/ansible-marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsks/ansible-marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsks/ansible-marionette/teams","hooks_url":"https://api.github.com/repos/larsks/ansible-marionette/hooks","issue_events_url":"https://api.github.com/repos/larsks/ansible-marionette/issues/events{/number}","events_url":"https://api.github.com/repos/larsks/ansible-marionette/events","assignees_url":"https://api.github.com/repos/larsks/ansible-marionette/assignees{/user}","branches_url":"https://api.github.com/repos/larsks/ansible-marionette/branches{/branch}","tags_url":"https://api.github.com/repos/larsks/ansible-marionette/tags","blobs_url":"https://api.github.com/repos/larsks/ansible-marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsks/ansible-marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsks/ansible-marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsks/ansible-marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsks/ansible-marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/larsks/ansible-marionette/languages","stargazers_url":"https://api.github.com/repos/larsks/ansible-marionette/stargazers","contributors_url":"https://api.github.com/repos/larsks/ansible-marionette/contributors","subscribers_url":"https://api.github.com/repos/larsks/ansible-marionette/subscribers","subscription_url":"https://api.github.com/repos/larsks/ansible-marionette/subscription","commits_url":"https://api.github.com/repos/larsks/ansible-marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsks/ansible-marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsks/ansible-marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsks/ansible-marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsks/ansible-marionette/contents/{+path}","compare_url":"https://api.github.com/repos/larsks/ansible-marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsks/ansible-marionette/merges","archive_url":"https://api.github.com/repos/larsks/ansible-marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsks/ansible-marionette/downloads","issues_url":"https://api.github.com/repos/larsks/ansible-marionette/issues{/number}","pulls_url":"https://api.github.com/repos/larsks/ansible-marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/larsks/ansible-marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/larsks/ansible-marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsks/ansible-marionette/labels{/name}","releases_url":"https://api.github.com/repos/larsks/ansible-marionette/releases{/id}","deployments_url":"https://api.github.com/repos/larsks/ansible-marionette/deployments","created_at":"2016-02-10T22:19:28Z","updated_at":"2016-02-10T22:19:29Z","pushed_at":"2016-02-11T00:06:10Z","git_url":"git://github.com/larsks/ansible-marionette.git","ssh_url":"git@github.com:larsks/ansible-marionette.git","clone_url":"https://github.com/larsks/ansible-marionette.git","svn_url":"https://github.com/larsks/ansible-marionette","homepage":"","size":17,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EmilienM:master","ref":"master","sha":"07cb97ae14f8135ee68ca953d7173cc14c9b61f3","user":{"login":"EmilienM","id":1688225,"avatar_url":"https://avatars.githubusercontent.com/u/1688225?v=3","gravatar_id":"","url":"https://api.github.com/users/EmilienM","html_url":"https://github.com/EmilienM","followers_url":"https://api.github.com/users/EmilienM/followers","following_url":"https://api.github.com/users/EmilienM/following{/other_user}","gists_url":"https://api.github.com/users/EmilienM/gists{/gist_id}","starred_url":"https://api.github.com/users/EmilienM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmilienM/subscriptions","organizations_url":"https://api.github.com/users/EmilienM/orgs","repos_url":"https://api.github.com/users/EmilienM/repos","events_url":"https://api.github.com/users/EmilienM/events{/privacy}","received_events_url":"https://api.github.com/users/EmilienM/received_events","type":"User","site_admin":false},"repo":{"id":51420184,"name":"ansible-marionette","full_name":"EmilienM/ansible-marionette","owner":{"login":"EmilienM","id":1688225,"avatar_url":"https://avatars.githubusercontent.com/u/1688225?v=3","gravatar_id":"","url":"https://api.github.com/users/EmilienM","html_url":"https://github.com/EmilienM","followers_url":"https://api.github.com/users/EmilienM/followers","following_url":"https://api.github.com/users/EmilienM/following{/other_user}","gists_url":"https://api.github.com/users/EmilienM/gists{/gist_id}","starred_url":"https://api.github.com/users/EmilienM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmilienM/subscriptions","organizations_url":"https://api.github.com/users/EmilienM/orgs","repos_url":"https://api.github.com/users/EmilienM/repos","events_url":"https://api.github.com/users/EmilienM/events{/privacy}","received_events_url":"https://api.github.com/users/EmilienM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EmilienM/ansible-marionette","description":"Orchestrate with Ansible a complex deployments driven by Puppet OpenStack modules","fork":false,"url":"https://api.github.com/repos/EmilienM/ansible-marionette","forks_url":"https://api.github.com/repos/EmilienM/ansible-marionette/forks","keys_url":"https://api.github.com/repos/EmilienM/ansible-marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EmilienM/ansible-marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EmilienM/ansible-marionette/teams","hooks_url":"https://api.github.com/repos/EmilienM/ansible-marionette/hooks","issue_events_url":"https://api.github.com/repos/EmilienM/ansible-marionette/issues/events{/number}","events_url":"https://api.github.com/repos/EmilienM/ansible-marionette/events","assignees_url":"https://api.github.com/repos/EmilienM/ansible-marionette/assignees{/user}","branches_url":"https://api.github.com/repos/EmilienM/ansible-marionette/branches{/branch}","tags_url":"https://api.github.com/repos/EmilienM/ansible-marionette/tags","blobs_url":"https://api.github.com/repos/EmilienM/ansible-marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EmilienM/ansible-marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EmilienM/ansible-marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/EmilienM/ansible-marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EmilienM/ansible-marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/EmilienM/ansible-marionette/languages","stargazers_url":"https://api.github.com/repos/EmilienM/ansible-marionette/stargazers","contributors_url":"https://api.github.com/repos/EmilienM/ansible-marionette/contributors","subscribers_url":"https://api.github.com/repos/EmilienM/ansible-marionette/subscribers","subscription_url":"https://api.github.com/repos/EmilienM/ansible-marionette/subscription","commits_url":"https://api.github.com/repos/EmilienM/ansible-marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/EmilienM/ansible-marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/EmilienM/ansible-marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/EmilienM/ansible-marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/EmilienM/ansible-marionette/contents/{+path}","compare_url":"https://api.github.com/repos/EmilienM/ansible-marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EmilienM/ansible-marionette/merges","archive_url":"https://api.github.com/repos/EmilienM/ansible-marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EmilienM/ansible-marionette/downloads","issues_url":"https://api.github.com/repos/EmilienM/ansible-marionette/issues{/number}","pulls_url":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/EmilienM/ansible-marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/EmilienM/ansible-marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EmilienM/ansible-marionette/labels{/name}","releases_url":"https://api.github.com/repos/EmilienM/ansible-marionette/releases{/id}","deployments_url":"https://api.github.com/repos/EmilienM/ansible-marionette/deployments","created_at":"2016-02-10T04:10:10Z","updated_at":"2016-02-10T17:28:28Z","pushed_at":"2016-02-11T00:06:10Z","git_url":"git://github.com/EmilienM/ansible-marionette.git","ssh_url":"git@github.com:EmilienM/ansible-marionette.git","clone_url":"https://github.com/EmilienM/ansible-marionette.git","svn_url":"https://github.com/EmilienM/ansible-marionette","homepage":"","size":17,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1"},"html":{"href":"https://github.com/EmilienM/ansible-marionette/pull/1"},"issue":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/issues/1"},"comments":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/EmilienM/ansible-marionette/statuses/18668dacea8656d1f0a4beaff8e2e93febd2af94"}}}}