{"action":"created","comment":{"url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments/60268513","id":60268513,"diff_hunk":"@@ -318,12 +318,12 @@ def get_namespace_index(self, uri):\n         uries = self.get_namespace_array()\n         return uries.index(uri)\n \n-    def get_event_object(self, etype=ua.ObjectIds.BaseEventType, source=ua.ObjectIds.Server):\n+    def get_event_object(self, event=ua.BaseEvent()):","path":"opcua/server/server.py","position":13,"original_position":23,"commit_id":"ed565ade124db771e3260946b161cf2b2d6171ab","original_commit_id":"ecf92aab97f182181247d936c820f592ec86f6d6","user":{"login":"oroulet","id":2564046,"avatar_url":"https://avatars.githubusercontent.com/u/2564046?v=3","gravatar_id":"","url":"https://api.github.com/users/oroulet","html_url":"https://github.com/oroulet","followers_url":"https://api.github.com/users/oroulet/followers","following_url":"https://api.github.com/users/oroulet/following{/other_user}","gists_url":"https://api.github.com/users/oroulet/gists{/gist_id}","starred_url":"https://api.github.com/users/oroulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oroulet/subscriptions","organizations_url":"https://api.github.com/users/oroulet/orgs","repos_url":"https://api.github.com/users/oroulet/repos","events_url":"https://api.github.com/users/oroulet/events{/privacy}","received_events_url":"https://api.github.com/users/oroulet/received_events","type":"User","site_admin":false},"body":"I still think it should be called get_event_generator","created_at":"2016-04-19T16:56:10Z","updated_at":"2016-04-19T16:56:10Z","html_url":"https://github.com/FreeOpcUa/python-opcua/pull/133#discussion_r60268513","pull_request_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments/60268513"},"html":{"href":"https://github.com/FreeOpcUa/python-opcua/pull/133#discussion_r60268513"},"pull_request":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133","id":59169065,"html_url":"https://github.com/FreeOpcUa/python-opcua/pull/133","diff_url":"https://github.com/FreeOpcUa/python-opcua/pull/133.diff","patch_url":"https://github.com/FreeOpcUa/python-opcua/pull/133.patch","issue_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/133","number":133,"state":"open","locked":false,"title":"Events debugging","user":{"login":"destogl","id":1918204,"avatar_url":"https://avatars.githubusercontent.com/u/1918204?v=3","gravatar_id":"","url":"https://api.github.com/users/destogl","html_url":"https://github.com/destogl","followers_url":"https://api.github.com/users/destogl/followers","following_url":"https://api.github.com/users/destogl/following{/other_user}","gists_url":"https://api.github.com/users/destogl/gists{/gist_id}","starred_url":"https://api.github.com/users/destogl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/destogl/subscriptions","organizations_url":"https://api.github.com/users/destogl/orgs","repos_url":"https://api.github.com/users/destogl/repos","events_url":"https://api.github.com/users/destogl/events{/privacy}","received_events_url":"https://api.github.com/users/destogl/received_events","type":"User","site_admin":false},"body":"This PR is with some corrections of events implementation. But for a lot of stuff I am not sure what to do. So please do not merge before we answer following questions (changes done according to comments):\r\n\r\n1. Do you now in which part of specification are described Event parameters which are send when events happens? I checked in more detail parts 3 and 4 without any success.\r\n2. What should be format of EventId variable? In one implementation of server based on UA SDK is has following format: \"len=16, 0xac90cce224ca5d4ca7cfef1a4ba43029\".\r\n3. Should Event ID always be the same for the Event? In UA SDK implementation I always get new ones.\r\n4. What does mean all this time-variables? I guess (according to the UA SDK implementation) Time should be time of event not the time of event creation.\r\n5. Is SourceNode variable anywhere else used? Should it be type Node or NodeId?\r\n6. Shouldn't the parent object change its 'EventNotifier' attribute there are events defined for it? If it's not defined than you can not observe events with UAExpert.\r\n","created_at":"2016-02-12T12:48:35Z","updated_at":"2016-04-19T16:56:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e2005a243ce14d49e0665e9d1a451cb7f0a9eaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133/commits","review_comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133/comments","review_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/133/comments","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/ed565ade124db771e3260946b161cf2b2d6171ab","head":{"label":"iirob:events","ref":"events","sha":"ed565ade124db771e3260946b161cf2b2d6171ab","user":{"login":"iirob","id":4102842,"avatar_url":"https://avatars.githubusercontent.com/u/4102842?v=3","gravatar_id":"","url":"https://api.github.com/users/iirob","html_url":"https://github.com/iirob","followers_url":"https://api.github.com/users/iirob/followers","following_url":"https://api.github.com/users/iirob/following{/other_user}","gists_url":"https://api.github.com/users/iirob/gists{/gist_id}","starred_url":"https://api.github.com/users/iirob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iirob/subscriptions","organizations_url":"https://api.github.com/users/iirob/orgs","repos_url":"https://api.github.com/users/iirob/repos","events_url":"https://api.github.com/users/iirob/events{/privacy}","received_events_url":"https://api.github.com/users/iirob/received_events","type":"Organization","site_admin":false},"repo":{"id":37647800,"name":"python-opcua","full_name":"iirob/python-opcua","owner":{"login":"iirob","id":4102842,"avatar_url":"https://avatars.githubusercontent.com/u/4102842?v=3","gravatar_id":"","url":"https://api.github.com/users/iirob","html_url":"https://github.com/iirob","followers_url":"https://api.github.com/users/iirob/followers","following_url":"https://api.github.com/users/iirob/following{/other_user}","gists_url":"https://api.github.com/users/iirob/gists{/gist_id}","starred_url":"https://api.github.com/users/iirob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iirob/subscriptions","organizations_url":"https://api.github.com/users/iirob/orgs","repos_url":"https://api.github.com/users/iirob/repos","events_url":"https://api.github.com/users/iirob/events{/privacy}","received_events_url":"https://api.github.com/users/iirob/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iirob/python-opcua","description":"Pure Python OPC-UA Client and Server","fork":true,"url":"https://api.github.com/repos/iirob/python-opcua","forks_url":"https://api.github.com/repos/iirob/python-opcua/forks","keys_url":"https://api.github.com/repos/iirob/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iirob/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iirob/python-opcua/teams","hooks_url":"https://api.github.com/repos/iirob/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/iirob/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/iirob/python-opcua/events","assignees_url":"https://api.github.com/repos/iirob/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/iirob/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/iirob/python-opcua/tags","blobs_url":"https://api.github.com/repos/iirob/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iirob/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iirob/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/iirob/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iirob/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/iirob/python-opcua/languages","stargazers_url":"https://api.github.com/repos/iirob/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/iirob/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/iirob/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/iirob/python-opcua/subscription","commits_url":"https://api.github.com/repos/iirob/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/iirob/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/iirob/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/iirob/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/iirob/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/iirob/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iirob/python-opcua/merges","archive_url":"https://api.github.com/repos/iirob/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iirob/python-opcua/downloads","issues_url":"https://api.github.com/repos/iirob/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/iirob/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/iirob/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/iirob/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iirob/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/iirob/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/iirob/python-opcua/deployments","created_at":"2015-06-18T08:37:42Z","updated_at":"2016-01-16T15:32:27Z","pushed_at":"2016-04-19T09:08:50Z","git_url":"git://github.com/iirob/python-opcua.git","ssh_url":"git@github.com:iirob/python-opcua.git","clone_url":"https://github.com/iirob/python-opcua.git","svn_url":"https://github.com/iirob/python-opcua","homepage":"","size":2225,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeOpcUa:master","ref":"master","sha":"33dd4565ee333808be5d05d4d38d050d3ea0a257","user":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"repo":{"id":31074280,"name":"python-opcua","full_name":"FreeOpcUa/python-opcua","owner":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeOpcUa/python-opcua","description":"LGPL Pure Python OPC-UA Client and Server","fork":false,"url":"https://api.github.com/repos/FreeOpcUa/python-opcua","forks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/forks","keys_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/teams","hooks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/events","assignees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/tags","blobs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/languages","stargazers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscription","commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/merges","archive_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/downloads","issues_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/deployments","created_at":"2015-02-20T16:46:53Z","updated_at":"2016-04-18T19:55:44Z","pushed_at":"2016-04-19T09:08:50Z","git_url":"git://github.com/FreeOpcUa/python-opcua.git","ssh_url":"git@github.com:FreeOpcUa/python-opcua.git","clone_url":"https://github.com/FreeOpcUa/python-opcua.git","svn_url":"https://github.com/FreeOpcUa/python-opcua","homepage":"http://freeopcua.github.io/","size":2550,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":15,"forks":24,"open_issues":15,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133"},"html":{"href":"https://github.com/FreeOpcUa/python-opcua/pull/133"},"issue":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/133"},"comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/ed565ade124db771e3260946b161cf2b2d6171ab"}}}}