{"action":"created","issue":{"url":"https://api.github.com/repos/TheRealMJP/DeferredTexturing/issues/2","repository_url":"https://api.github.com/repos/TheRealMJP/DeferredTexturing","labels_url":"https://api.github.com/repos/TheRealMJP/DeferredTexturing/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/TheRealMJP/DeferredTexturing/issues/2/comments","events_url":"https://api.github.com/repos/TheRealMJP/DeferredTexturing/issues/2/events","html_url":"https://github.com/TheRealMJP/DeferredTexturing/issues/2","id":175138422,"number":2,"title":"Isn't the ground albedo a reflectance?","user":{"login":"ekmett","id":304657,"avatar_url":"https://avatars.githubusercontent.com/u/304657?v=3","gravatar_id":"","url":"https://api.github.com/users/ekmett","html_url":"https://github.com/ekmett","followers_url":"https://api.github.com/users/ekmett/followers","following_url":"https://api.github.com/users/ekmett/following{/other_user}","gists_url":"https://api.github.com/users/ekmett/gists{/gist_id}","starred_url":"https://api.github.com/users/ekmett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekmett/subscriptions","organizations_url":"https://api.github.com/users/ekmett/orgs","repos_url":"https://api.github.com/users/ekmett/repos","events_url":"https://api.github.com/users/ekmett/events{/privacy}","received_events_url":"https://api.github.com/users/ekmett/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-06T00:07:17Z","updated_at":"2016-09-06T01:44:56Z","closed_at":"2016-09-06T01:44:56Z","body":"In the sample framework code `Skybox.cpp` you compute the spectrum for the ground albedo using\r\n\r\n```\r\n SampledSpectrum groundAlbedoSpectrum = SampledSpectrum::FromRGB(Albedo);\r\n```\r\n\r\nBy default PBRT assumes `FromRGB` is getting an illuminant, but isn't the ground albedo providing reflectance? I'd have expected\r\n\r\n```\r\n SampledSpectrum groundAlbedoSpectrum = SampledSpectrum::FromRGB(Albedo,  SpectrumType::Reflectance);\r\n```"},"comment":{"url":"https://api.github.com/repos/TheRealMJP/DeferredTexturing/issues/comments/244831183","html_url":"https://github.com/TheRealMJP/DeferredTexturing/issues/2#issuecomment-244831183","issue_url":"https://api.github.com/repos/TheRealMJP/DeferredTexturing/issues/2","id":244831183,"user":{"login":"TheRealMJP","id":5241360,"avatar_url":"https://avatars.githubusercontent.com/u/5241360?v=3","gravatar_id":"","url":"https://api.github.com/users/TheRealMJP","html_url":"https://github.com/TheRealMJP","followers_url":"https://api.github.com/users/TheRealMJP/followers","following_url":"https://api.github.com/users/TheRealMJP/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMJP/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMJP/subscriptions","organizations_url":"https://api.github.com/users/TheRealMJP/orgs","repos_url":"https://api.github.com/users/TheRealMJP/repos","events_url":"https://api.github.com/users/TheRealMJP/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMJP/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T01:44:56Z","updated_at":"2016-09-06T01:44:56Z","body":"Fixed in commit [86a4677](https://github.com/TheRealMJP/DeferredTexturing/commit/86a4677de9082495d31d20bacfe5c7d5876afede)"}}
{"actor":{"display_login":"TheRealMJP"}}