{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/platform/issues/4632","repository_url":"https://api.github.com/repos/mattermost/platform","labels_url":"https://api.github.com/repos/mattermost/platform/issues/4632/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/platform/issues/4632/comments","events_url":"https://api.github.com/repos/mattermost/platform/issues/4632/events","html_url":"https://github.com/mattermost/platform/pull/4632","id":191022566,"number":4632,"title":"PLT-4332 Position field for Users","user":{"login":"grundleborg","id":1198059,"avatar_url":"https://avatars.githubusercontent.com/u/1198059?v=3","gravatar_id":"","url":"https://api.github.com/users/grundleborg","html_url":"https://github.com/grundleborg","followers_url":"https://api.github.com/users/grundleborg/followers","following_url":"https://api.github.com/users/grundleborg/following{/other_user}","gists_url":"https://api.github.com/users/grundleborg/gists{/gist_id}","starred_url":"https://api.github.com/users/grundleborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grundleborg/subscriptions","organizations_url":"https://api.github.com/users/grundleborg/orgs","repos_url":"https://api.github.com/users/grundleborg/repos","events_url":"https://api.github.com/users/grundleborg/events{/privacy}","received_events_url":"https://api.github.com/users/grundleborg/received_events","type":"User","site_admin":false},"labels":[{"id":297541710,"url":"https://api.github.com/repos/mattermost/platform/labels/1:%20PM%20Review","name":"1: PM Review","color":"006b75","default":false},{"id":308747687,"url":"https://api.github.com/repos/mattermost/platform/labels/Setup%20Test%20Server","name":"Setup Test Server","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-22T14:31:30Z","updated_at":"2016-11-23T16:20:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mattermost/platform/pulls/4632","html_url":"https://github.com/mattermost/platform/pull/4632","diff_url":"https://github.com/mattermost/platform/pull/4632.diff","patch_url":"https://github.com/mattermost/platform/pull/4632.patch"},"body":"#### Summary\r\nAdds a **Position** field to users, editable in the Account Settings general tab, and displayed below the name in the profile popover.\r\n\r\n#### Ticket Link\r\n#4188 \r\n\r\nhttps://mattermost.atlassian.net/browse/PLT-4332\r\n\r\n#### Issues\r\n\r\n* Need to decide on if/how to integrate this change with other authentication systems.\r\n* When to update the API docs (given this new field isn't in a released version of MM yet)?\r\n\r\n#### Checklist\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [ ] Added API documentation (required for all new APIs)\r\n- [ ] All new/modified APIs include changes to the drivers\r\n- [ ] Has enterprise changes (please link)\r\n- [x] Has UI changes\r\n- [x] Includes text changes and localization file updates\r\n- [x] Touches critical sections of the codebase (auth, upgrade, etc.)\r\n"},"comment":{"url":"https://api.github.com/repos/mattermost/platform/issues/comments/262561357","html_url":"https://github.com/mattermost/platform/pull/4632#issuecomment-262561357","issue_url":"https://api.github.com/repos/mattermost/platform/issues/4632","id":262561357,"user":{"login":"yangchen1","id":5504605,"avatar_url":"https://avatars.githubusercontent.com/u/5504605?v=3","gravatar_id":"","url":"https://api.github.com/users/yangchen1","html_url":"https://github.com/yangchen1","followers_url":"https://api.github.com/users/yangchen1/followers","following_url":"https://api.github.com/users/yangchen1/following{/other_user}","gists_url":"https://api.github.com/users/yangchen1/gists{/gist_id}","starred_url":"https://api.github.com/users/yangchen1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangchen1/subscriptions","organizations_url":"https://api.github.com/users/yangchen1/orgs","repos_url":"https://api.github.com/users/yangchen1/repos","events_url":"https://api.github.com/users/yangchen1/events{/privacy}","received_events_url":"https://api.github.com/users/yangchen1/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T16:20:17Z","updated_at":"2016-11-23T16:20:17Z","body":"Overall looks good! Thanks @grundleborg I forgot to include the character limit in the spec, which should be no more than 35 characters including spaces. Otherwise it goes too out of the box here:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/5504605/20569537/6ca7e846-b16e-11e6-8fbc-8d95c8d6b244.png)\r\n\r\nAlso, this is probably not related to this PR, but clicking the profile picture seems to not display the position field, but clicking people's username does - it should probably show for both.\r\n"}}
{"actor":{"display_login":"yangchen1"}}