{"action":"created","issue":{"url":"https://api.github.com/repos/mcrapet/plowshare-modules-legacy/issues/33","labels_url":"https://api.github.com/repos/mcrapet/plowshare-modules-legacy/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/mcrapet/plowshare-modules-legacy/issues/33/comments","events_url":"https://api.github.com/repos/mcrapet/plowshare-modules-legacy/issues/33/events","html_url":"https://github.com/mcrapet/plowshare-modules-legacy/pull/33","id":125642444,"number":33,"title":"catshare: various improvements","user":{"login":"Raziel-23","id":8607499,"avatar_url":"https://avatars.githubusercontent.com/u/8607499?v=3","gravatar_id":"","url":"https://api.github.com/users/Raziel-23","html_url":"https://github.com/Raziel-23","followers_url":"https://api.github.com/users/Raziel-23/followers","following_url":"https://api.github.com/users/Raziel-23/following{/other_user}","gists_url":"https://api.github.com/users/Raziel-23/gists{/gist_id}","starred_url":"https://api.github.com/users/Raziel-23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raziel-23/subscriptions","organizations_url":"https://api.github.com/users/Raziel-23/orgs","repos_url":"https://api.github.com/users/Raziel-23/repos","events_url":"https://api.github.com/users/Raziel-23/events{/privacy}","received_events_url":"https://api.github.com/users/Raziel-23/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-08T16:20:26Z","updated_at":"2016-01-09T16:13:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mcrapet/plowshare-modules-legacy/pulls/33","html_url":"https://github.com/mcrapet/plowshare-modules-legacy/pull/33","diff_url":"https://github.com/mcrapet/plowshare-modules-legacy/pull/33.diff","patch_url":"https://github.com/mcrapet/plowshare-modules-legacy/pull/33.patch"},"body":"I improved catshare module a bit. If you want I can squash commits into one."},"comment":{"url":"https://api.github.com/repos/mcrapet/plowshare-modules-legacy/issues/comments/170256860","html_url":"https://github.com/mcrapet/plowshare-modules-legacy/pull/33#issuecomment-170256860","issue_url":"https://api.github.com/repos/mcrapet/plowshare-modules-legacy/issues/33","id":170256860,"user":{"login":"Raziel-23","id":8607499,"avatar_url":"https://avatars.githubusercontent.com/u/8607499?v=3","gravatar_id":"","url":"https://api.github.com/users/Raziel-23","html_url":"https://github.com/Raziel-23","followers_url":"https://api.github.com/users/Raziel-23/followers","following_url":"https://api.github.com/users/Raziel-23/following{/other_user}","gists_url":"https://api.github.com/users/Raziel-23/gists{/gist_id}","starred_url":"https://api.github.com/users/Raziel-23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raziel-23/subscriptions","organizations_url":"https://api.github.com/users/Raziel-23/orgs","repos_url":"https://api.github.com/users/Raziel-23/repos","events_url":"https://api.github.com/users/Raziel-23/events{/privacy}","received_events_url":"https://api.github.com/users/Raziel-23/received_events","type":"User","site_admin":false},"created_at":"2016-01-09T16:13:09Z","updated_at":"2016-01-09T16:13:09Z","body":"I forget about one thing in this pull request. In the probe function I can check if link is dead or need permissions in the same way like I did in the download function. Otherwise it will always return $ERR_LINK_DEAD, which is not true. There is only one issue with this approach, probe functions does not support returning $ERR_LINK_NEED_PERMISSIONS like download functions. Theoretically I can return $ERR_LINK_NEED_PERMISSIONS in the probe function, but it not print message 'Insufficient permissions (private/premium link)' like in the download function."}}