{"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/90217177","pull_request_review_id":10737719,"id":90217177,"diff_hunk":"@@ -13,85 +16,92 @@\n  */\n class ConfigurationPopin extends Element\n {\n-    /** @var array */\n+    use SpinCapableTrait;\n+\n     protected $selector = ['css' => '.modal'];\n \n     /**\n-     * Hide a column by dragging to the bucket\n-     *\n-     * @param string $label\n+     * @param string[] $labels\n      */\n-    public function hideColumn($label)\n+    public function showColumns($labels)\n     {\n-        $this->getColumn($label)->dragTo($this->getBucket());\n-        $this->apply();\n+        $searchInput = $this->spin(function () {\n+            return $this->find('css', 'input[type=\"search\"]');\n+        });\n+\n+        $dropZone = $this->spin(function () {\n+            return $this->find('css', '#column-selection');\n+        }, sprintf('Cannot find the drop zone'));\n+\n+        foreach ($labels as $label) {\n+            $searchInput->setValue($label);\n+            $item = $this->getItemForLabel($label);\n+            $this->dragElementTo($item, $dropZone);\n+        }\n     }\n \n     /**\n-     * Move a column\n-     *\n-     * @param string $source\n-     * @param string $target\n+     * @param string[] $labels\n      */\n-    public function moveColumn($source, $target)\n+    public function hideColumns($labels)\n     {\n-        $this->getColumn($source)->dragTo($this->getColumn($target));\n-        $this->apply();\n+        $dropZone = $this->spin(function () {\n+            return $this->find('css', '#column-list');","path":"features/Context/Page/Element/ConfigurationPopin.php","position":58,"original_position":58,"commit_id":"f772a39d3fb3e007e3aa2e08c1079aa73b34c7c4","original_commit_id":"f772a39d3fb3e007e3aa2e08c1079aa73b34c7c4","user":{"login":"pierallard","id":1590933,"avatar_url":"https://avatars.githubusercontent.com/u/1590933?v=3","gravatar_id":"","url":"https://api.github.com/users/pierallard","html_url":"https://github.com/pierallard","followers_url":"https://api.github.com/users/pierallard/followers","following_url":"https://api.github.com/users/pierallard/following{/other_user}","gists_url":"https://api.github.com/users/pierallard/gists{/gist_id}","starred_url":"https://api.github.com/users/pierallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierallard/subscriptions","organizations_url":"https://api.github.com/users/pierallard/orgs","repos_url":"https://api.github.com/users/pierallard/repos","events_url":"https://api.github.com/users/pierallard/events{/privacy}","received_events_url":"https://api.github.com/users/pierallard/received_events","type":"User","site_admin":false},"body":"$element","created_at":"2016-11-30T11:45:40Z","updated_at":"2016-11-30T11:47:41Z","html_url":"https://github.com/akeneo/pim-community-dev/pull/5268#discussion_r90217177","pull_request_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268","_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/90217177"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/5268#discussion_r90217177"},"pull_request":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268"}}},"pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268","id":95333239,"html_url":"https://github.com/akeneo/pim-community-dev/pull/5268","diff_url":"https://github.com/akeneo/pim-community-dev/pull/5268.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/5268.patch","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5268","number":5268,"state":"open","locked":false,"title":"PIM-5862: Fix product grid display on a custom user view","user":{"login":"phaseinducer","id":659491,"avatar_url":"https://avatars.githubusercontent.com/u/659491?v=3","gravatar_id":"","url":"https://api.github.com/users/phaseinducer","html_url":"https://github.com/phaseinducer","followers_url":"https://api.github.com/users/phaseinducer/followers","following_url":"https://api.github.com/users/phaseinducer/following{/other_user}","gists_url":"https://api.github.com/users/phaseinducer/gists{/gist_id}","starred_url":"https://api.github.com/users/phaseinducer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phaseinducer/subscriptions","organizations_url":"https://api.github.com/users/phaseinducer/orgs","repos_url":"https://api.github.com/users/phaseinducer/repos","events_url":"https://api.github.com/users/phaseinducer/events{/privacy}","received_events_url":"https://api.github.com/users/phaseinducer/received_events","type":"User","site_admin":false},"body":"This PR:\r\n- Reverts https://github.com/akeneo/pim-community-dev/pull/4948 because it caused a regression (PIM-6007)\r\n- Provides a fix for the original bug without regression (hopefully)\r\n- Really tests the grid columns selectors popin (because it wasn't the case, nope)\r\n- Adds behats stabilization and fix some incoherent ones\r\n- Fixes the spin method behaviour\r\n\r\n| Q                                 | A\r\n| --------------------------------- | ---\r\n| Added Specs                       | n/a\r\n| Added Behats                      | yes\r\n| Changelog updated                 | yes\r\n| Review and 2 GTM                  | \r\n| Micro Demo to the PO (Story only) | n/a\r\n| Migration script                  | n/a\r\n| Tech Doc                          |","created_at":"2016-11-25T17:18:36Z","updated_at":"2016-11-30T11:47:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5c03457bd5f210a2bf73e7d76f067572ba0ec4c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268/commits","review_comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268/comments","review_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5268/comments","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/f772a39d3fb3e007e3aa2e08c1079aa73b34c7c4","head":{"label":"akeneo:PIM-5862","ref":"PIM-5862","sha":"f772a39d3fb3e007e3aa2e08c1079aa73b34c7c4","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2016-11-29T09:29:59Z","pushed_at":"2016-11-30T11:38:15Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":159343,"stargazers_count":351,"watchers_count":351,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":144,"forks":185,"open_issues":144,"watchers":351,"default_branch":"master"}},"base":{"label":"akeneo:1.5","ref":"1.5","sha":"776fe5736879d17dd6ff5d48196ccfa7c6ef01a3","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2016-11-29T09:29:59Z","pushed_at":"2016-11-30T11:38:15Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":159343,"stargazers_count":351,"watchers_count":351,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":144,"forks":185,"open_issues":144,"watchers":351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/5268"},"issue":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5268"},"comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5268/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5268/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/f772a39d3fb3e007e3aa2e08c1079aa73b34c7c4"}}}}
{"actor":{"display_login":"pierallard"}}