{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/88506097","pull_request_review_id":9078434,"id":88506097,"diff_hunk":"@@ -1,75 +1,7 @@\n-from __future__ import absolute_import, print_function, division\n+import warnings\n+from theano.tensor.slinalg import solve  # noqa","path":"theano/sandbox/solve.py","position":3,"original_position":3,"commit_id":"3a28c0f9bd1fb2bd083b8d36d38b0452ba9063c4","original_commit_id":"3a28c0f9bd1fb2bd083b8d36d38b0452ba9063c4","user":{"login":"slefrancois","id":18192425,"avatar_url":"https://avatars.githubusercontent.com/u/18192425?v=3","gravatar_id":"","url":"https://api.github.com/users/slefrancois","html_url":"https://github.com/slefrancois","followers_url":"https://api.github.com/users/slefrancois/followers","following_url":"https://api.github.com/users/slefrancois/following{/other_user}","gists_url":"https://api.github.com/users/slefrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/slefrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slefrancois/subscriptions","organizations_url":"https://api.github.com/users/slefrancois/orgs","repos_url":"https://api.github.com/users/slefrancois/repos","events_url":"https://api.github.com/users/slefrancois/events{/privacy}","received_events_url":"https://api.github.com/users/slefrancois/received_events","type":"User","site_admin":false},"body":"The noqa doesn't solve Travis' error on missing python 3 compatibility imports. Probable we should go back to explicite whitelisting for flake8.","created_at":"2016-11-17T17:42:35Z","updated_at":"2016-11-17T17:42:35Z","html_url":"https://github.com/Theano/Theano/pull/5210#discussion_r88506097","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/5210","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/88506097"},"html":{"href":"https://github.com/Theano/Theano/pull/5210#discussion_r88506097"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5210"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/5210","id":93253255,"html_url":"https://github.com/Theano/Theano/pull/5210","diff_url":"https://github.com/Theano/Theano/pull/5210.diff","patch_url":"https://github.com/Theano/Theano/pull/5210.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/5210","number":5210,"state":"open","locked":false,"title":"Solve","user":{"login":"tfjgeorge","id":1521241,"avatar_url":"https://avatars.githubusercontent.com/u/1521241?v=3","gravatar_id":"","url":"https://api.github.com/users/tfjgeorge","html_url":"https://github.com/tfjgeorge","followers_url":"https://api.github.com/users/tfjgeorge/followers","following_url":"https://api.github.com/users/tfjgeorge/following{/other_user}","gists_url":"https://api.github.com/users/tfjgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/tfjgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfjgeorge/subscriptions","organizations_url":"https://api.github.com/users/tfjgeorge/orgs","repos_url":"https://api.github.com/users/tfjgeorge/repos","events_url":"https://api.github.com/users/tfjgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/tfjgeorge/received_events","type":"User","site_admin":false},"body":"This fixes #5017 . I removed sandbox/solve.py which was not used anywhere as linalg/ops.py already imports solve from slinalg.py. I updated the documentation for solve and its lower diagonal/upper diagonal counterparts.","created_at":"2016-11-10T23:37:59Z","updated_at":"2016-11-17T17:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86ec2bd21c1fe199d5f7e8d308a5b8fea3bdeacb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/5210/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/5210/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/5210/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/3a28c0f9bd1fb2bd083b8d36d38b0452ba9063c4","head":{"label":"tfjgeorge:solve","ref":"solve","sha":"3a28c0f9bd1fb2bd083b8d36d38b0452ba9063c4","user":{"login":"tfjgeorge","id":1521241,"avatar_url":"https://avatars.githubusercontent.com/u/1521241?v=3","gravatar_id":"","url":"https://api.github.com/users/tfjgeorge","html_url":"https://github.com/tfjgeorge","followers_url":"https://api.github.com/users/tfjgeorge/followers","following_url":"https://api.github.com/users/tfjgeorge/following{/other_user}","gists_url":"https://api.github.com/users/tfjgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/tfjgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfjgeorge/subscriptions","organizations_url":"https://api.github.com/users/tfjgeorge/orgs","repos_url":"https://api.github.com/users/tfjgeorge/repos","events_url":"https://api.github.com/users/tfjgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/tfjgeorge/received_events","type":"User","site_admin":false},"repo":{"id":66982820,"name":"Theano","full_name":"tfjgeorge/Theano","owner":{"login":"tfjgeorge","id":1521241,"avatar_url":"https://avatars.githubusercontent.com/u/1521241?v=3","gravatar_id":"","url":"https://api.github.com/users/tfjgeorge","html_url":"https://github.com/tfjgeorge","followers_url":"https://api.github.com/users/tfjgeorge/followers","following_url":"https://api.github.com/users/tfjgeorge/following{/other_user}","gists_url":"https://api.github.com/users/tfjgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/tfjgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfjgeorge/subscriptions","organizations_url":"https://api.github.com/users/tfjgeorge/orgs","repos_url":"https://api.github.com/users/tfjgeorge/repos","events_url":"https://api.github.com/users/tfjgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/tfjgeorge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tfjgeorge/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/tfjgeorge/Theano","forks_url":"https://api.github.com/repos/tfjgeorge/Theano/forks","keys_url":"https://api.github.com/repos/tfjgeorge/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tfjgeorge/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tfjgeorge/Theano/teams","hooks_url":"https://api.github.com/repos/tfjgeorge/Theano/hooks","issue_events_url":"https://api.github.com/repos/tfjgeorge/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/tfjgeorge/Theano/events","assignees_url":"https://api.github.com/repos/tfjgeorge/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/tfjgeorge/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/tfjgeorge/Theano/tags","blobs_url":"https://api.github.com/repos/tfjgeorge/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tfjgeorge/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tfjgeorge/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/tfjgeorge/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tfjgeorge/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/tfjgeorge/Theano/languages","stargazers_url":"https://api.github.com/repos/tfjgeorge/Theano/stargazers","contributors_url":"https://api.github.com/repos/tfjgeorge/Theano/contributors","subscribers_url":"https://api.github.com/repos/tfjgeorge/Theano/subscribers","subscription_url":"https://api.github.com/repos/tfjgeorge/Theano/subscription","commits_url":"https://api.github.com/repos/tfjgeorge/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/tfjgeorge/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/tfjgeorge/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/tfjgeorge/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/tfjgeorge/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/tfjgeorge/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tfjgeorge/Theano/merges","archive_url":"https://api.github.com/repos/tfjgeorge/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tfjgeorge/Theano/downloads","issues_url":"https://api.github.com/repos/tfjgeorge/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/tfjgeorge/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/tfjgeorge/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/tfjgeorge/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tfjgeorge/Theano/labels{/name}","releases_url":"https://api.github.com/repos/tfjgeorge/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/tfjgeorge/Theano/deployments","created_at":"2016-08-30T22:39:54Z","updated_at":"2016-08-30T22:40:00Z","pushed_at":"2016-11-16T17:51:33Z","git_url":"git://github.com/tfjgeorge/Theano.git","ssh_url":"git@github.com:tfjgeorge/Theano.git","clone_url":"https://github.com/tfjgeorge/Theano.git","svn_url":"https://github.com/tfjgeorge/Theano","homepage":"http://www.deeplearning.net/software/theano","size":59353,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"ecfc65ec8de80ebfee4c63d1bed48c3cd105a805","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-11-17T15:16:47Z","pushed_at":"2016-11-17T16:02:00Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":79448,"stargazers_count":5005,"watchers_count":5005,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1761,"mirror_url":null,"open_issues_count":734,"forks":1761,"open_issues":734,"watchers":5005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5210"},"html":{"href":"https://github.com/Theano/Theano/pull/5210"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/5210"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/5210/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5210/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5210/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/3a28c0f9bd1fb2bd083b8d36d38b0452ba9063c4"}}}}
{"actor":{"display_login":"slefrancois"}}