{"push_id":1294748190,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"3b77f6b6c38fea6616cae10ca8e0c3a20782934a","before":"5e9d030621520073127c20da967bc0ae02174a8b","commits":[{"sha":"7b210b5445654f690267fe71542a5a64f0bf9870","author":{"name":"John Sirois","email":"a3aece39382087830532a4184dc76ba110e155bd@gmail.com"},"message":"Edit Greeting{,Test}.java to get a known edit sha for tests.\n\nThis will be used to re-enable tests in\n`tests/python/pants_test/tasks/test_changed_target_integration.py`.\n\nTesting Done:\nLocally green:\n```\n./pants test examples/tests/java/org/pantsbuild/example/hello/greet\n```\n\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/158877403\n\nBugs closed: 3851\n\nReviewed at https://rbcommons.com/s/twitter/r/4217/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/7b210b5445654f690267fe71542a5a64f0bf9870"},{"sha":"4299f83f1c27d710167d4aa764a704dcc6ae36e4","author":{"name":"John Sirois","email":"a3aece39382087830532a4184dc76ba110e155bd@gmail.com"},"message":"Re-enable test_junit_tests_using_cucumber.\n\nThe required update to the junit runner was upgraded to long ago.\n\nTesting Done:\nLocally green with no skips or xfails:\n```\n./pants test tests/python/pants_test/backend/jvm/tasks:junit_run_integration -- -v\n```\n\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/159135750\n\nBugs closed: 3848\n\nReviewed at https://rbcommons.com/s/twitter/r/4212/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/4299f83f1c27d710167d4aa764a704dcc6ae36e4"},{"sha":"e8e34aaa9a54fdcbe42cee5939c5be46350e26b4","author":{"name":"Eric Ayers","email":"b53f0ef30ac1e0873b1708713dfbbfbabd89722f@gmail.com"},"message":"prepare for 1.2.0dev9 release\n\nTesting Done:\nCI green at https://travis-ci.org/pantsbuild/pants/builds/159275108\n\nReviewed at https://rbcommons.com/s/twitter/r/4223/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/e8e34aaa9a54fdcbe42cee5939c5be46350e26b4"},{"sha":"89b9586b45421f65e4e130ed1d97f5d62c5435d7","author":{"name":"Matt Olsen","email":"31e7b35f7f9f5d76c1e2ef239c79b97264b2f6d0@digital-wanderlust.com"},"message":"Fix regex in release script\n\nUpdate regex to accept version numbers in the form 1.2.0devX as well as 1.2.0-devX\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/159386910\n\nManually verified that regex correctly pulls in the latest release.\n\nBugs closed: 3858\n\nReviewed at https://rbcommons.com/s/twitter/r/4226/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/89b9586b45421f65e4e130ed1d97f5d62c5435d7"},{"sha":"3b77f6b6c38fea6616cae10ca8e0c3a20782934a","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Deprecate the `subsystem_instance` utility function.\n\nIt was implemented as a contextmanager that resets subsystem\nstate in __exit__.  However this interacts badly with tests that\nuse that state (sometimes without even realizing it) outside the\nsubsystem_instance context. Several tests have to do weird\nbalancing acts to get around this.\n\nInstead we introduce a global_subsystem_instance() that simply\ninits and returns the global instance of a subsystem. Test code\ncan rely on our standard test base classes for cleanup between tests,\nor it can reset subsystem state itself if it needs to do so mid-test.\n\nThis change allows us to remove various wrapper contextmanagers\nsprinkled around our tests, and generally supports simplification\nof several tests.\n\nThis is part 2 of my effort to simplify and standardize how we\ncreate subsystems in tests.  See for part 1:\n\n44be4da8bda29e21061e550b6529a346934b9b0f\n\nNote to reviewers: The diff is a little hairy, but the focus is on\nthe change in tests/python/pants_test/subsystem/subsystem_util.py.\nThe rest is just modifying all relevant tests to use the new method,\nand the proof of the validity of those is mostly that the tests pass...\n\nTesting Done:\nCI passes: https://travis-ci.org/pantsbuild/pants/builds/159169092\n\nReviewed at https://rbcommons.com/s/twitter/r/4220/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/3b77f6b6c38fea6616cae10ca8e0c3a20782934a"}]}
{"actor":{"display_login":"benjyw"}}