{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/shopify_api/issues/298","repository_url":"https://api.github.com/repos/Shopify/shopify_api","labels_url":"https://api.github.com/repos/Shopify/shopify_api/issues/298/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/shopify_api/issues/298/comments","events_url":"https://api.github.com/repos/Shopify/shopify_api/issues/298/events","html_url":"https://github.com/Shopify/shopify_api/pull/298","id":171992646,"number":298,"title":"Remove required argument on prefix in disable_prefix_check","user":{"login":"Matt888","id":1594285,"avatar_url":"https://avatars.githubusercontent.com/u/1594285?v=3","gravatar_id":"","url":"https://api.github.com/users/Matt888","html_url":"https://github.com/Matt888","followers_url":"https://api.github.com/users/Matt888/followers","following_url":"https://api.github.com/users/Matt888/following{/other_user}","gists_url":"https://api.github.com/users/Matt888/gists{/gist_id}","starred_url":"https://api.github.com/users/Matt888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matt888/subscriptions","organizations_url":"https://api.github.com/users/Matt888/orgs","repos_url":"https://api.github.com/users/Matt888/repos","events_url":"https://api.github.com/users/Matt888/events{/privacy}","received_events_url":"https://api.github.com/users/Matt888/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Shopify/shopify_api/labels/bug","name":"bug","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-18T20:26:07Z","updated_at":"2016-08-18T20:58:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/shopify_api/pulls/298","html_url":"https://github.com/Shopify/shopify_api/pull/298","diff_url":"https://github.com/Shopify/shopify_api/pull/298.diff","patch_url":"https://github.com/Shopify/shopify_api/pull/298.patch"},"body":"For some reason we are patching this module in ActiveResource and in the actual gem the prefix args are optional (https://github.com/rails/activeresource/blob/f8abaf13174e94d179227f352c9dd6fb8b03e0da/lib/active_resource/base.rb#L1575), but in our version they are required.  This fix makes them optional so this error doesn't happen:\r\n\r\n```ruby\r\nShopifyAPI::ProductListing.find(:first, params: {application_id: KEYS[:shopify_provider_id]})\r\nArgumentError: wrong number of arguments (given 0, expected 1)\r\n           from /Users/matt/.gem/ruby/2.3.1/gems/shopify_api-4.3.0/lib/active_resource/disable_prefix_check.rb:15:in `block in conditional_prefix'\r\n           from /Users/matt/.gem/ruby/2.3.1/bundler/gems/activeresource-f8abaf13174e/lib/active_resource/base.rb:1575:in `create_resource_for'\r\n```\r\n\r\n/review @swalkinshaw @lreeves @minasmart "},"comment":{"url":"https://api.github.com/repos/Shopify/shopify_api/issues/comments/240854637","html_url":"https://github.com/Shopify/shopify_api/pull/298#issuecomment-240854637","issue_url":"https://api.github.com/repos/Shopify/shopify_api/issues/298","id":240854637,"user":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T20:58:46Z","updated_at":"2016-08-18T20:58:46Z","body":":shipit: nice finding."}}
{"actor":{"display_login":"rafaelfranca"}}