{"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/11","id":62073639,"html_url":"https://github.com/ubuntu-core/identity-vault/pull/11","diff_url":"https://github.com/ubuntu-core/identity-vault/pull/11.diff","patch_url":"https://github.com/ubuntu-core/identity-vault/pull/11.patch","issue_url":"https://api.github.com/repos/ubuntu-core/identity-vault/issues/11","number":11,"state":"open","locked":false,"title":"Improved signing handler tests","user":{"login":"arapulido","id":925437,"avatar_url":"https://avatars.githubusercontent.com/u/925437?v=3","gravatar_id":"","url":"https://api.github.com/users/arapulido","html_url":"https://github.com/arapulido","followers_url":"https://api.github.com/users/arapulido/followers","following_url":"https://api.github.com/users/arapulido/following{/other_user}","gists_url":"https://api.github.com/users/arapulido/gists{/gist_id}","starred_url":"https://api.github.com/users/arapulido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arapulido/subscriptions","organizations_url":"https://api.github.com/users/arapulido/orgs","repos_url":"https://api.github.com/users/arapulido/repos","events_url":"https://api.github.com/users/arapulido/events{/privacy}","received_events_url":"https://api.github.com/users/arapulido/received_events","type":"User","site_admin":false},"body":"This is based on the branch I created (and we closed) about table driven tests.\r\nInstead of creating a table, I have extracted functionality for calling the signing handler into a function.\r\n\r\nApart of that, for all tests, I have included a check for the right error message when expected.","created_at":"2016-03-08T13:53:42Z","updated_at":"2016-03-08T13:53:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubuntu-core/identity-vault/issues/11/comments","statuses_url":"https://api.github.com/repos/ubuntu-core/identity-vault/statuses/36b7fbe7054aa7655371589d5ada8956ccd16889","head":{"label":"arapulido:improve_sign_tests","ref":"improve_sign_tests","sha":"36b7fbe7054aa7655371589d5ada8956ccd16889","user":{"login":"arapulido","id":925437,"avatar_url":"https://avatars.githubusercontent.com/u/925437?v=3","gravatar_id":"","url":"https://api.github.com/users/arapulido","html_url":"https://github.com/arapulido","followers_url":"https://api.github.com/users/arapulido/followers","following_url":"https://api.github.com/users/arapulido/following{/other_user}","gists_url":"https://api.github.com/users/arapulido/gists{/gist_id}","starred_url":"https://api.github.com/users/arapulido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arapulido/subscriptions","organizations_url":"https://api.github.com/users/arapulido/orgs","repos_url":"https://api.github.com/users/arapulido/repos","events_url":"https://api.github.com/users/arapulido/events{/privacy}","received_events_url":"https://api.github.com/users/arapulido/received_events","type":"User","site_admin":false},"repo":{"id":51145571,"name":"identity-vault","full_name":"arapulido/identity-vault","owner":{"login":"arapulido","id":925437,"avatar_url":"https://avatars.githubusercontent.com/u/925437?v=3","gravatar_id":"","url":"https://api.github.com/users/arapulido","html_url":"https://github.com/arapulido","followers_url":"https://api.github.com/users/arapulido/followers","following_url":"https://api.github.com/users/arapulido/following{/other_user}","gists_url":"https://api.github.com/users/arapulido/gists{/gist_id}","starred_url":"https://api.github.com/users/arapulido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arapulido/subscriptions","organizations_url":"https://api.github.com/users/arapulido/orgs","repos_url":"https://api.github.com/users/arapulido/repos","events_url":"https://api.github.com/users/arapulido/events{/privacy}","received_events_url":"https://api.github.com/users/arapulido/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arapulido/identity-vault","description":"","fork":true,"url":"https://api.github.com/repos/arapulido/identity-vault","forks_url":"https://api.github.com/repos/arapulido/identity-vault/forks","keys_url":"https://api.github.com/repos/arapulido/identity-vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arapulido/identity-vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arapulido/identity-vault/teams","hooks_url":"https://api.github.com/repos/arapulido/identity-vault/hooks","issue_events_url":"https://api.github.com/repos/arapulido/identity-vault/issues/events{/number}","events_url":"https://api.github.com/repos/arapulido/identity-vault/events","assignees_url":"https://api.github.com/repos/arapulido/identity-vault/assignees{/user}","branches_url":"https://api.github.com/repos/arapulido/identity-vault/branches{/branch}","tags_url":"https://api.github.com/repos/arapulido/identity-vault/tags","blobs_url":"https://api.github.com/repos/arapulido/identity-vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arapulido/identity-vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arapulido/identity-vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/arapulido/identity-vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arapulido/identity-vault/statuses/{sha}","languages_url":"https://api.github.com/repos/arapulido/identity-vault/languages","stargazers_url":"https://api.github.com/repos/arapulido/identity-vault/stargazers","contributors_url":"https://api.github.com/repos/arapulido/identity-vault/contributors","subscribers_url":"https://api.github.com/repos/arapulido/identity-vault/subscribers","subscription_url":"https://api.github.com/repos/arapulido/identity-vault/subscription","commits_url":"https://api.github.com/repos/arapulido/identity-vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/arapulido/identity-vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/arapulido/identity-vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/arapulido/identity-vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/arapulido/identity-vault/contents/{+path}","compare_url":"https://api.github.com/repos/arapulido/identity-vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arapulido/identity-vault/merges","archive_url":"https://api.github.com/repos/arapulido/identity-vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arapulido/identity-vault/downloads","issues_url":"https://api.github.com/repos/arapulido/identity-vault/issues{/number}","pulls_url":"https://api.github.com/repos/arapulido/identity-vault/pulls{/number}","milestones_url":"https://api.github.com/repos/arapulido/identity-vault/milestones{/number}","notifications_url":"https://api.github.com/repos/arapulido/identity-vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arapulido/identity-vault/labels{/name}","releases_url":"https://api.github.com/repos/arapulido/identity-vault/releases{/id}","deployments_url":"https://api.github.com/repos/arapulido/identity-vault/deployments","created_at":"2016-02-05T12:36:37Z","updated_at":"2016-02-19T12:20:31Z","pushed_at":"2016-03-08T13:49:20Z","git_url":"git://github.com/arapulido/identity-vault.git","ssh_url":"git@github.com:arapulido/identity-vault.git","clone_url":"https://github.com/arapulido/identity-vault.git","svn_url":"https://github.com/arapulido/identity-vault","homepage":null,"size":802,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubuntu-core:master","ref":"master","sha":"894269622001c5d96cf5029dc6988afa5c093463","user":{"login":"ubuntu-core","id":15022473,"avatar_url":"https://avatars.githubusercontent.com/u/15022473?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu-core","html_url":"https://github.com/ubuntu-core","followers_url":"https://api.github.com/users/ubuntu-core/followers","following_url":"https://api.github.com/users/ubuntu-core/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu-core/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu-core/subscriptions","organizations_url":"https://api.github.com/users/ubuntu-core/orgs","repos_url":"https://api.github.com/users/ubuntu-core/repos","events_url":"https://api.github.com/users/ubuntu-core/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu-core/received_events","type":"Organization","site_admin":false},"repo":{"id":51011398,"name":"identity-vault","full_name":"ubuntu-core/identity-vault","owner":{"login":"ubuntu-core","id":15022473,"avatar_url":"https://avatars.githubusercontent.com/u/15022473?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu-core","html_url":"https://github.com/ubuntu-core","followers_url":"https://api.github.com/users/ubuntu-core/followers","following_url":"https://api.github.com/users/ubuntu-core/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu-core/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu-core/subscriptions","organizations_url":"https://api.github.com/users/ubuntu-core/orgs","repos_url":"https://api.github.com/users/ubuntu-core/repos","events_url":"https://api.github.com/users/ubuntu-core/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu-core/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubuntu-core/identity-vault","description":"","fork":false,"url":"https://api.github.com/repos/ubuntu-core/identity-vault","forks_url":"https://api.github.com/repos/ubuntu-core/identity-vault/forks","keys_url":"https://api.github.com/repos/ubuntu-core/identity-vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubuntu-core/identity-vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubuntu-core/identity-vault/teams","hooks_url":"https://api.github.com/repos/ubuntu-core/identity-vault/hooks","issue_events_url":"https://api.github.com/repos/ubuntu-core/identity-vault/issues/events{/number}","events_url":"https://api.github.com/repos/ubuntu-core/identity-vault/events","assignees_url":"https://api.github.com/repos/ubuntu-core/identity-vault/assignees{/user}","branches_url":"https://api.github.com/repos/ubuntu-core/identity-vault/branches{/branch}","tags_url":"https://api.github.com/repos/ubuntu-core/identity-vault/tags","blobs_url":"https://api.github.com/repos/ubuntu-core/identity-vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubuntu-core/identity-vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubuntu-core/identity-vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubuntu-core/identity-vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubuntu-core/identity-vault/statuses/{sha}","languages_url":"https://api.github.com/repos/ubuntu-core/identity-vault/languages","stargazers_url":"https://api.github.com/repos/ubuntu-core/identity-vault/stargazers","contributors_url":"https://api.github.com/repos/ubuntu-core/identity-vault/contributors","subscribers_url":"https://api.github.com/repos/ubuntu-core/identity-vault/subscribers","subscription_url":"https://api.github.com/repos/ubuntu-core/identity-vault/subscription","commits_url":"https://api.github.com/repos/ubuntu-core/identity-vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubuntu-core/identity-vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubuntu-core/identity-vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubuntu-core/identity-vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubuntu-core/identity-vault/contents/{+path}","compare_url":"https://api.github.com/repos/ubuntu-core/identity-vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubuntu-core/identity-vault/merges","archive_url":"https://api.github.com/repos/ubuntu-core/identity-vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubuntu-core/identity-vault/downloads","issues_url":"https://api.github.com/repos/ubuntu-core/identity-vault/issues{/number}","pulls_url":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls{/number}","milestones_url":"https://api.github.com/repos/ubuntu-core/identity-vault/milestones{/number}","notifications_url":"https://api.github.com/repos/ubuntu-core/identity-vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubuntu-core/identity-vault/labels{/name}","releases_url":"https://api.github.com/repos/ubuntu-core/identity-vault/releases{/id}","deployments_url":"https://api.github.com/repos/ubuntu-core/identity-vault/deployments","created_at":"2016-02-03T16:04:27Z","updated_at":"2016-02-18T14:12:07Z","pushed_at":"2016-03-07T11:11:28Z","git_url":"git://github.com/ubuntu-core/identity-vault.git","ssh_url":"git@github.com:ubuntu-core/identity-vault.git","clone_url":"https://github.com/ubuntu-core/identity-vault.git","svn_url":"https://github.com/ubuntu-core/identity-vault","homepage":null,"size":816,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/11"},"html":{"href":"https://github.com/ubuntu-core/identity-vault/pull/11"},"issue":{"href":"https://api.github.com/repos/ubuntu-core/identity-vault/issues/11"},"comments":{"href":"https://api.github.com/repos/ubuntu-core/identity-vault/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubuntu-core/identity-vault/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ubuntu-core/identity-vault/statuses/36b7fbe7054aa7655371589d5ada8956ccd16889"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":44,"deletions":92,"changed_files":2}}