{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/79732220","id":79732220,"diff_hunk":"@@ -40,42 +41,48 @@ class AnimationController extends Animation<double>\n \n   /// Creates an animation controller.\n   ///\n-  /// * value is the initial value of the animation.\n-  /// * duration is the length of time this animation should last.\n-  /// * debugLabel is a string to help identify this animation during debugging (used by toString).\n-  /// * lowerBound is the smallest value this animation can obtain and the value at which this animation is deemed to be dismissed.\n-  /// * upperBound is the largest value this animation can obtain and the value at which this animation is deemed to be completed.\n+  /// * [value] is the initial value of the animation.\n+  /// * [duration] is the length of time this animation should last.\n+  /// * [debugLabel] is a string to help identify this animation during debugging (used by toString).\n+  /// * [lowerBound] is the smallest value this animation can obtain and the value at which this animation is deemed to be dismissed.\n+  /// * [upperBound] is the largest value this animation can obtain and the value at which this animation is deemed to be completed.\n+  /// * `vsync` is the [TickerProvider] for the current context. It can be changed by calling [resync].\n   AnimationController({\n     double value,\n     this.duration,\n     this.debugLabel,\n     this.lowerBound: 0.0,\n-    this.upperBound: 1.0\n+    this.upperBound: 1.0,\n+    @required TickerProvider vsync,\n   }) {\n     assert(upperBound >= lowerBound);\n+    assert(vsync != null);\n     _direction = _AnimationDirection.forward;\n-    _ticker = new Ticker(_tick);\n+    _ticker = vsync.createTicker(_tick);\n     _internalSetValue(value ?? lowerBound);\n   }\n \n   /// Creates an animation controller with no upper or lower bound for its value.\n   ///\n-  /// * value is the initial value of the animation.\n-  /// * duration is the length of time this animation should last.\n-  /// * debugLabel is a string to help identify this animation during debugging (used by toString).\n+  /// * [value] is the initial value of the animation.\n+  /// * [duration] is the length of time this animation should last.\n+  /// * [debugLabel] is a string to help identify this animation during debugging (used by toString).","path":"packages/flutter/lib/src/animation/animation_controller.dart","position":59,"original_position":59,"commit_id":"572af072f08ade3e46e3b5ee06b11a656a59f53c","original_commit_id":"572af072f08ade3e46e3b5ee06b11a656a59f53c","user":{"login":"dragostis","id":4136413,"avatar_url":"https://avatars.githubusercontent.com/u/4136413?v=3","gravatar_id":"","url":"https://api.github.com/users/dragostis","html_url":"https://github.com/dragostis","followers_url":"https://api.github.com/users/dragostis/followers","following_url":"https://api.github.com/users/dragostis/following{/other_user}","gists_url":"https://api.github.com/users/dragostis/gists{/gist_id}","starred_url":"https://api.github.com/users/dragostis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragostis/subscriptions","organizations_url":"https://api.github.com/users/dragostis/orgs","repos_url":"https://api.github.com/users/dragostis/repos","events_url":"https://api.github.com/users/dragostis/events{/privacy}","received_events_url":"https://api.github.com/users/dragostis/received_events","type":"User","site_admin":false},"body":"`toString` should be inside `s","created_at":"2016-09-20T23:07:42Z","updated_at":"2016-09-20T23:08:13Z","html_url":"https://github.com/flutter/flutter/pull/5902#discussion_r79732220","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/5902","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/79732220"},"html":{"href":"https://github.com/flutter/flutter/pull/5902#discussion_r79732220"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5902"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/5902","id":85500512,"html_url":"https://github.com/flutter/flutter/pull/5902","diff_url":"https://github.com/flutter/flutter/pull/5902.diff","patch_url":"https://github.com/flutter/flutter/pull/5902.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/5902","number":5902,"state":"open","locked":false,"title":"Turn off AnimationControllers when not in use","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"This requires all AnimationController objects to be given a\r\nTickerProvider, a class that can create the Ticker.\r\n\r\nIt also provides some nice mixins for people who want to have their\r\nState provide a TickerProvider. And a schedulerTickerProvider for those\r\ncases where you just want to see your battery burn.\r\n\r\nAlso, we now enforce destruction order for elements.","created_at":"2016-09-15T23:54:40Z","updated_at":"2016-09-20T23:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6542d0d8d4ddf430e6f9b756730308532a6edde1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/5902/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/5902/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/5902/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/572af072f08ade3e46e3b5ee06b11a656a59f53c","head":{"label":"Hixie:5469-ticker","ref":"5469-ticker","sha":"572af072f08ade3e46e3b5ee06b11a656a59f53c","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"repo":{"id":45635647,"name":"flutter","full_name":"Hixie/flutter","owner":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hixie/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/Hixie/flutter","forks_url":"https://api.github.com/repos/Hixie/flutter/forks","keys_url":"https://api.github.com/repos/Hixie/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hixie/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hixie/flutter/teams","hooks_url":"https://api.github.com/repos/Hixie/flutter/hooks","issue_events_url":"https://api.github.com/repos/Hixie/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/Hixie/flutter/events","assignees_url":"https://api.github.com/repos/Hixie/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/Hixie/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/Hixie/flutter/tags","blobs_url":"https://api.github.com/repos/Hixie/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hixie/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hixie/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hixie/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hixie/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/Hixie/flutter/languages","stargazers_url":"https://api.github.com/repos/Hixie/flutter/stargazers","contributors_url":"https://api.github.com/repos/Hixie/flutter/contributors","subscribers_url":"https://api.github.com/repos/Hixie/flutter/subscribers","subscription_url":"https://api.github.com/repos/Hixie/flutter/subscription","commits_url":"https://api.github.com/repos/Hixie/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hixie/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hixie/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hixie/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hixie/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/Hixie/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hixie/flutter/merges","archive_url":"https://api.github.com/repos/Hixie/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hixie/flutter/downloads","issues_url":"https://api.github.com/repos/Hixie/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/Hixie/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/Hixie/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/Hixie/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hixie/flutter/labels{/name}","releases_url":"https://api.github.com/repos/Hixie/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/Hixie/flutter/deployments","created_at":"2015-11-05T19:54:58Z","updated_at":"2016-02-09T22:48:09Z","pushed_at":"2016-09-20T21:33:42Z","git_url":"git://github.com/Hixie/flutter.git","ssh_url":"git@github.com:Hixie/flutter.git","clone_url":"https://github.com/Hixie/flutter.git","svn_url":"https://github.com/Hixie/flutter","homepage":"http://flutter.io","size":21728,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"400585cb96064db50f9574361b6a471f3dbf4787","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-09-20T11:02:48Z","pushed_at":"2016-09-20T23:01:14Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":116424,"stargazers_count":3281,"watchers_count":3281,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":353,"mirror_url":null,"open_issues_count":1301,"forks":353,"open_issues":1301,"watchers":3281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5902"},"html":{"href":"https://github.com/flutter/flutter/pull/5902"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/5902"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/5902/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5902/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5902/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/572af072f08ade3e46e3b5ee06b11a656a59f53c"}}}}
{"actor":{"display_login":"dragostis"}}