{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/87224937","pull_request_review_id":7845018,"id":87224937,"diff_hunk":"@@ -902,8 +906,13 @@ LocalManager::startProxy()\n     Vec<char> real_proxy_options;\n \n     real_proxy_options.append(proxy_options, strlen(proxy_options));\n+    if (onetime_options && *onetime_options) {\n+      real_proxy_options.append(\" \", strlen(\" \"));\n+      real_proxy_options.append(onetime_options, strlen(onetime_options));\n+    }\n \n-    if (!strstr(proxy_options, MGMT_OPT)) { // Make sure we're starting the proxy in mgmt mode\n+    // Make sure we're starting the proxy in mgmt mode\n+    if (strstr(proxy_options, MGMT_OPT) == 0 && strstr(onetime_options, MGMT_OPT) == 0) {","path":"mgmt/LocalManager.cc","position":36,"original_position":36,"commit_id":"9e09c305bd8d707e139173e6493042a9e3be59fd","original_commit_id":"9e09c305bd8d707e139173e6493042a9e3be59fd","user":{"login":"danobi","id":824615,"avatar_url":"https://avatars.githubusercontent.com/u/824615?v=3","gravatar_id":"","url":"https://api.github.com/users/danobi","html_url":"https://github.com/danobi","followers_url":"https://api.github.com/users/danobi/followers","following_url":"https://api.github.com/users/danobi/following{/other_user}","gists_url":"https://api.github.com/users/danobi/gists{/gist_id}","starred_url":"https://api.github.com/users/danobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danobi/subscriptions","organizations_url":"https://api.github.com/users/danobi/orgs","repos_url":"https://api.github.com/users/danobi/repos","events_url":"https://api.github.com/users/danobi/events{/privacy}","received_events_url":"https://api.github.com/users/danobi/received_events","type":"User","site_admin":false},"body":"`real_proxy_options` is the mysterious `Vec` class. AFAICT, I suppose we could, but it would require more allocation.","created_at":"2016-11-09T16:19:40Z","updated_at":"2016-11-09T16:19:40Z","html_url":"https://github.com/apache/trafficserver/pull/1073#discussion_r87224937","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/1073","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/87224937"},"html":{"href":"https://github.com/apache/trafficserver/pull/1073#discussion_r87224937"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1073"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/1073","id":87783846,"html_url":"https://github.com/apache/trafficserver/pull/1073","diff_url":"https://github.com/apache/trafficserver/pull/1073.diff","patch_url":"https://github.com/apache/trafficserver/pull/1073.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/1073","number":1073,"state":"open","locked":false,"title":"TS-4399 TS-4400 Management API messes up proxy options","user":{"login":"danobi","id":824615,"avatar_url":"https://avatars.githubusercontent.com/u/824615?v=3","gravatar_id":"","url":"https://api.github.com/users/danobi","html_url":"https://github.com/danobi","followers_url":"https://api.github.com/users/danobi/followers","following_url":"https://api.github.com/users/danobi/following{/other_user}","gists_url":"https://api.github.com/users/danobi/gists{/gist_id}","starred_url":"https://api.github.com/users/danobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danobi/subscriptions","organizations_url":"https://api.github.com/users/danobi/orgs","repos_url":"https://api.github.com/users/danobi/repos","events_url":"https://api.github.com/users/danobi/events{/privacy}","received_events_url":"https://api.github.com/users/danobi/received_events","type":"User","site_admin":false},"body":"TS-4399: Management API breaks diagnostic log rotation\nTS-4400: TSProxyStateSet persist cache clearing across restart\n\nThe two issues are related in that they both deal with the\nmanagement API not correctly handling proxy flags.\n\nFor TS-4399, it was because the management API was not aware\nof traffic_manager setting extra proxy options. This was fixed\nby providing CoreAPI a callback to get extra proxy options from\ntraffic_manager.\n\nFor TS-4400, it was because the management API was not properly\nclearing optional flags between proxy reboots. This was fixed\nby resetting the proxy options before each reboot.\n","created_at":"2016-10-03T20:18:42Z","updated_at":"2016-11-09T16:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"432dba3fc20bbf3eb40311850aaddd94f65adf18","assignee":{"login":"jpeach","id":9917,"avatar_url":"https://avatars.githubusercontent.com/u/9917?v=3","gravatar_id":"","url":"https://api.github.com/users/jpeach","html_url":"https://github.com/jpeach","followers_url":"https://api.github.com/users/jpeach/followers","following_url":"https://api.github.com/users/jpeach/following{/other_user}","gists_url":"https://api.github.com/users/jpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeach/subscriptions","organizations_url":"https://api.github.com/users/jpeach/orgs","repos_url":"https://api.github.com/users/jpeach/repos","events_url":"https://api.github.com/users/jpeach/events{/privacy}","received_events_url":"https://api.github.com/users/jpeach/received_events","type":"User","site_admin":false},"assignees":[{"login":"jpeach","id":9917,"avatar_url":"https://avatars.githubusercontent.com/u/9917?v=3","gravatar_id":"","url":"https://api.github.com/users/jpeach","html_url":"https://github.com/jpeach","followers_url":"https://api.github.com/users/jpeach/followers","following_url":"https://api.github.com/users/jpeach/following{/other_user}","gists_url":"https://api.github.com/users/jpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeach/subscriptions","organizations_url":"https://api.github.com/users/jpeach/orgs","repos_url":"https://api.github.com/users/jpeach/repos","events_url":"https://api.github.com/users/jpeach/events{/privacy}","received_events_url":"https://api.github.com/users/jpeach/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/2","html_url":"https://github.com/apache/trafficserver/milestones/7.1.0","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/2/labels","id":1761237,"number":2,"title":"7.1.0","description":"","creator":{"login":"zwoop","id":202131,"avatar_url":"https://avatars.githubusercontent.com/u/202131?v=3","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":114,"state":"open","created_at":"2016-05-11T22:45:45Z","updated_at":"2016-11-09T15:29:42Z","due_on":"2017-02-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/1073/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/1073/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/1073/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/9e09c305bd8d707e139173e6493042a9e3be59fd","head":{"label":"danobi:TS-4399_TS-4400","ref":"TS-4399_TS-4400","sha":"9e09c305bd8d707e139173e6493042a9e3be59fd","user":{"login":"danobi","id":824615,"avatar_url":"https://avatars.githubusercontent.com/u/824615?v=3","gravatar_id":"","url":"https://api.github.com/users/danobi","html_url":"https://github.com/danobi","followers_url":"https://api.github.com/users/danobi/followers","following_url":"https://api.github.com/users/danobi/following{/other_user}","gists_url":"https://api.github.com/users/danobi/gists{/gist_id}","starred_url":"https://api.github.com/users/danobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danobi/subscriptions","organizations_url":"https://api.github.com/users/danobi/orgs","repos_url":"https://api.github.com/users/danobi/repos","events_url":"https://api.github.com/users/danobi/events{/privacy}","received_events_url":"https://api.github.com/users/danobi/received_events","type":"User","site_admin":false},"repo":{"id":33414842,"name":"trafficserver","full_name":"danobi/trafficserver","owner":{"login":"danobi","id":824615,"avatar_url":"https://avatars.githubusercontent.com/u/824615?v=3","gravatar_id":"","url":"https://api.github.com/users/danobi","html_url":"https://github.com/danobi","followers_url":"https://api.github.com/users/danobi/followers","following_url":"https://api.github.com/users/danobi/following{/other_user}","gists_url":"https://api.github.com/users/danobi/gists{/gist_id}","starred_url":"https://api.github.com/users/danobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danobi/subscriptions","organizations_url":"https://api.github.com/users/danobi/orgs","repos_url":"https://api.github.com/users/danobi/repos","events_url":"https://api.github.com/users/danobi/events{/privacy}","received_events_url":"https://api.github.com/users/danobi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danobi/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/danobi/trafficserver","forks_url":"https://api.github.com/repos/danobi/trafficserver/forks","keys_url":"https://api.github.com/repos/danobi/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danobi/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danobi/trafficserver/teams","hooks_url":"https://api.github.com/repos/danobi/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/danobi/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/danobi/trafficserver/events","assignees_url":"https://api.github.com/repos/danobi/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/danobi/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/danobi/trafficserver/tags","blobs_url":"https://api.github.com/repos/danobi/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danobi/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danobi/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/danobi/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danobi/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/danobi/trafficserver/languages","stargazers_url":"https://api.github.com/repos/danobi/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/danobi/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/danobi/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/danobi/trafficserver/subscription","commits_url":"https://api.github.com/repos/danobi/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/danobi/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/danobi/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/danobi/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/danobi/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/danobi/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danobi/trafficserver/merges","archive_url":"https://api.github.com/repos/danobi/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danobi/trafficserver/downloads","issues_url":"https://api.github.com/repos/danobi/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/danobi/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/danobi/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/danobi/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danobi/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/danobi/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/danobi/trafficserver/deployments","created_at":"2015-04-04T18:01:56Z","updated_at":"2016-05-15T23:45:01Z","pushed_at":"2016-11-07T22:56:11Z","git_url":"git://github.com/danobi/trafficserver.git","ssh_url":"git@github.com:danobi/trafficserver.git","clone_url":"https://github.com/danobi/trafficserver.git","svn_url":"https://github.com/danobi/trafficserver","homepage":null,"size":59677,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7662c30e48a444d0d8d37b2e2d34f71b21e3bfcd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2016-11-09T15:13:27Z","pushed_at":"2016-11-09T15:07:35Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":71890,"stargazers_count":473,"watchers_count":473,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":48,"forks":377,"open_issues":48,"watchers":473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1073"},"html":{"href":"https://github.com/apache/trafficserver/pull/1073"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/1073"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/1073/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1073/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1073/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/9e09c305bd8d707e139173e6493042a9e3be59fd"}}}}
{"actor":{"display_login":"danobi"}}