{"action":"created","comment":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/comments/80371073","id":80371073,"diff_hunk":"@@ -3069,6 +3073,15 @@ arc_evict_state(arc_state_t *state, uint64_t spa, int64_t bytes,\n \tnum_sublists = multilist_get_num_sublists(ml);\n \n \t/*\n+\t* Do the job for each type of headers (see b_lsize note below)\n+\t*/\n+\tfor (int l = 0; l < 3 && (total_evicted < bytes || bytes == ARC_EVICT_ALL); l++) {","path":"usr/src/uts/common/fs/zfs/arc.c","position":35,"original_position":35,"commit_id":"9fd2f00e4da8933dbdd511af2ca176082f10c5a1","original_commit_id":"9fd2f00e4da8933dbdd511af2ca176082f10c5a1","user":{"login":"ahrens","id":799124,"avatar_url":"https://avatars.githubusercontent.com/u/799124?v=3","gravatar_id":"","url":"https://api.github.com/users/ahrens","html_url":"https://github.com/ahrens","followers_url":"https://api.github.com/users/ahrens/followers","following_url":"https://api.github.com/users/ahrens/following{/other_user}","gists_url":"https://api.github.com/users/ahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/ahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahrens/subscriptions","organizations_url":"https://api.github.com/users/ahrens/orgs","repos_url":"https://api.github.com/users/ahrens/repos","events_url":"https://api.github.com/users/ahrens/events{/privacy}","received_events_url":"https://api.github.com/users/ahrens/received_events","type":"User","site_admin":false},"body":"`l` is easily misread for `1`, a possible value of `l`.  How about a different variable name?","created_at":"2016-09-24T23:46:38Z","updated_at":"2016-09-24T23:56:45Z","html_url":"https://github.com/openzfs/openzfs/pull/189#discussion_r80371073","pull_request_url":"https://api.github.com/repos/openzfs/openzfs/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/comments/80371073"},"html":{"href":"https://github.com/openzfs/openzfs/pull/189#discussion_r80371073"},"pull_request":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/189","id":84262351,"html_url":"https://github.com/openzfs/openzfs/pull/189","diff_url":"https://github.com/openzfs/openzfs/pull/189.diff","patch_url":"https://github.com/openzfs/openzfs/pull/189.patch","issue_url":"https://api.github.com/repos/openzfs/openzfs/issues/189","number":189,"state":"open","locked":false,"title":"7361 Improve L2ARC filling","user":{"login":"benrubson","id":6764151,"avatar_url":"https://avatars.githubusercontent.com/u/6764151?v=3","gravatar_id":"","url":"https://api.github.com/users/benrubson","html_url":"https://github.com/benrubson","followers_url":"https://api.github.com/users/benrubson/followers","following_url":"https://api.github.com/users/benrubson/following{/other_user}","gists_url":"https://api.github.com/users/benrubson/gists{/gist_id}","starred_url":"https://api.github.com/users/benrubson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrubson/subscriptions","organizations_url":"https://api.github.com/users/benrubson/orgs","repos_url":"https://api.github.com/users/benrubson/repos","events_url":"https://api.github.com/users/benrubson/events{/privacy}","received_events_url":"https://api.github.com/users/benrubson/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nThis patch modifies ZFS so that when it has to evict buffers from ARC, it first chooses buffers which are already in L2ARC.\r\n\r\nSee https://www.illumos.org/issues/7361 for details.\r\n\r\nThank you 👍 \r\n\r\nBen","created_at":"2016-09-07T09:06:23Z","updated_at":"2016-09-24T23:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a7907c9808edfca1ed0f60b6d6d69407b67e24c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzfs/openzfs/pulls/189/commits","review_comments_url":"https://api.github.com/repos/openzfs/openzfs/pulls/189/comments","review_comment_url":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzfs/openzfs/issues/189/comments","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/9fd2f00e4da8933dbdd511af2ca176082f10c5a1","head":{"label":"benrubson:master","ref":"master","sha":"9fd2f00e4da8933dbdd511af2ca176082f10c5a1","user":{"login":"benrubson","id":6764151,"avatar_url":"https://avatars.githubusercontent.com/u/6764151?v=3","gravatar_id":"","url":"https://api.github.com/users/benrubson","html_url":"https://github.com/benrubson","followers_url":"https://api.github.com/users/benrubson/followers","following_url":"https://api.github.com/users/benrubson/following{/other_user}","gists_url":"https://api.github.com/users/benrubson/gists{/gist_id}","starred_url":"https://api.github.com/users/benrubson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrubson/subscriptions","organizations_url":"https://api.github.com/users/benrubson/orgs","repos_url":"https://api.github.com/users/benrubson/repos","events_url":"https://api.github.com/users/benrubson/events{/privacy}","received_events_url":"https://api.github.com/users/benrubson/received_events","type":"User","site_admin":false},"repo":{"id":67359336,"name":"openzfs","full_name":"benrubson/openzfs","owner":{"login":"benrubson","id":6764151,"avatar_url":"https://avatars.githubusercontent.com/u/6764151?v=3","gravatar_id":"","url":"https://api.github.com/users/benrubson","html_url":"https://github.com/benrubson","followers_url":"https://api.github.com/users/benrubson/followers","following_url":"https://api.github.com/users/benrubson/following{/other_user}","gists_url":"https://api.github.com/users/benrubson/gists{/gist_id}","starred_url":"https://api.github.com/users/benrubson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrubson/subscriptions","organizations_url":"https://api.github.com/users/benrubson/orgs","repos_url":"https://api.github.com/users/benrubson/repos","events_url":"https://api.github.com/users/benrubson/events{/privacy}","received_events_url":"https://api.github.com/users/benrubson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benrubson/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/benrubson/openzfs","forks_url":"https://api.github.com/repos/benrubson/openzfs/forks","keys_url":"https://api.github.com/repos/benrubson/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benrubson/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benrubson/openzfs/teams","hooks_url":"https://api.github.com/repos/benrubson/openzfs/hooks","issue_events_url":"https://api.github.com/repos/benrubson/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/benrubson/openzfs/events","assignees_url":"https://api.github.com/repos/benrubson/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/benrubson/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/benrubson/openzfs/tags","blobs_url":"https://api.github.com/repos/benrubson/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benrubson/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benrubson/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/benrubson/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benrubson/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/benrubson/openzfs/languages","stargazers_url":"https://api.github.com/repos/benrubson/openzfs/stargazers","contributors_url":"https://api.github.com/repos/benrubson/openzfs/contributors","subscribers_url":"https://api.github.com/repos/benrubson/openzfs/subscribers","subscription_url":"https://api.github.com/repos/benrubson/openzfs/subscription","commits_url":"https://api.github.com/repos/benrubson/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/benrubson/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/benrubson/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/benrubson/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/benrubson/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/benrubson/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benrubson/openzfs/merges","archive_url":"https://api.github.com/repos/benrubson/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benrubson/openzfs/downloads","issues_url":"https://api.github.com/repos/benrubson/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/benrubson/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/benrubson/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/benrubson/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benrubson/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/benrubson/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/benrubson/openzfs/deployments","created_at":"2016-09-04T17:39:44Z","updated_at":"2016-09-04T17:42:42Z","pushed_at":"2016-09-07T09:04:45Z","git_url":"git://github.com/benrubson/openzfs.git","ssh_url":"git@github.com:benrubson/openzfs.git","clone_url":"https://github.com/benrubson/openzfs.git","svn_url":"https://github.com/benrubson/openzfs","homepage":"http://open-zfs.org","size":253989,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzfs:master","ref":"master","sha":"9cbab779e7cc2fade731e306e206dfcc757f2ae2","user":{"login":"openzfs","id":4510897,"avatar_url":"https://avatars.githubusercontent.com/u/4510897?v=3","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"repo":{"id":44220580,"name":"openzfs","full_name":"openzfs/openzfs","owner":{"login":"openzfs","id":4510897,"avatar_url":"https://avatars.githubusercontent.com/u/4510897?v=3","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzfs/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/openzfs/openzfs","forks_url":"https://api.github.com/repos/openzfs/openzfs/forks","keys_url":"https://api.github.com/repos/openzfs/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzfs/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzfs/openzfs/teams","hooks_url":"https://api.github.com/repos/openzfs/openzfs/hooks","issue_events_url":"https://api.github.com/repos/openzfs/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/openzfs/openzfs/events","assignees_url":"https://api.github.com/repos/openzfs/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/openzfs/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/openzfs/openzfs/tags","blobs_url":"https://api.github.com/repos/openzfs/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzfs/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzfs/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzfs/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openzfs/openzfs/languages","stargazers_url":"https://api.github.com/repos/openzfs/openzfs/stargazers","contributors_url":"https://api.github.com/repos/openzfs/openzfs/contributors","subscribers_url":"https://api.github.com/repos/openzfs/openzfs/subscribers","subscription_url":"https://api.github.com/repos/openzfs/openzfs/subscription","commits_url":"https://api.github.com/repos/openzfs/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzfs/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzfs/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzfs/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzfs/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/openzfs/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzfs/openzfs/merges","archive_url":"https://api.github.com/repos/openzfs/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzfs/openzfs/downloads","issues_url":"https://api.github.com/repos/openzfs/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/openzfs/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openzfs/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openzfs/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzfs/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/openzfs/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/openzfs/openzfs/deployments","created_at":"2015-10-14T03:03:50Z","updated_at":"2016-09-24T09:21:47Z","pushed_at":"2016-09-24T17:51:47Z","git_url":"git://github.com/openzfs/openzfs.git","ssh_url":"git@github.com:openzfs/openzfs.git","clone_url":"https://github.com/openzfs/openzfs.git","svn_url":"https://github.com/openzfs/openzfs","homepage":"http://open-zfs.org","size":258192,"stargazers_count":90,"watchers_count":90,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":36,"forks":31,"open_issues":36,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/189"},"html":{"href":"https://github.com/openzfs/openzfs/pull/189"},"issue":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/189"},"comments":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/openzfs/openzfs/statuses/9fd2f00e4da8933dbdd511af2ca176082f10c5a1"}}}}
{"actor":{"display_login":"ahrens"}}