{"action":"created","issue":{"url":"https://api.github.com/repos/moneyphp/money/issues/341","repository_url":"https://api.github.com/repos/moneyphp/money","labels_url":"https://api.github.com/repos/moneyphp/money/issues/341/labels{/name}","comments_url":"https://api.github.com/repos/moneyphp/money/issues/341/comments","events_url":"https://api.github.com/repos/moneyphp/money/issues/341/events","html_url":"https://github.com/moneyphp/money/pull/341","id":197726274,"number":341,"title":"Fix integer validation when chunk started with a dash","user":{"login":"frederikbosch","id":1552577,"avatar_url":"https://avatars.githubusercontent.com/u/1552577?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikbosch","html_url":"https://github.com/frederikbosch","followers_url":"https://api.github.com/users/frederikbosch/followers","following_url":"https://api.github.com/users/frederikbosch/following{/other_user}","gists_url":"https://api.github.com/users/frederikbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikbosch/subscriptions","organizations_url":"https://api.github.com/users/frederikbosch/orgs","repos_url":"https://api.github.com/users/frederikbosch/repos","events_url":"https://api.github.com/users/frederikbosch/events{/privacy}","received_events_url":"https://api.github.com/users/frederikbosch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-12-27T16:28:31Z","updated_at":"2016-12-27T18:53:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/moneyphp/money/pulls/341","html_url":"https://github.com/moneyphp/money/pull/341","diff_url":"https://github.com/moneyphp/money/pull/341.diff","patch_url":"https://github.com/moneyphp/money/pull/341.patch"},"body":"@sagikazarmark @wimby Created this alternative solution. Positive and negative signs are allowed. but only when they are the first character."},"comment":{"url":"https://api.github.com/repos/moneyphp/money/issues/comments/269366900","html_url":"https://github.com/moneyphp/money/pull/341#issuecomment-269366900","issue_url":"https://api.github.com/repos/moneyphp/money/issues/341","id":269366900,"user":{"login":"wimby","id":11348034,"avatar_url":"https://avatars.githubusercontent.com/u/11348034?v=3","gravatar_id":"","url":"https://api.github.com/users/wimby","html_url":"https://github.com/wimby","followers_url":"https://api.github.com/users/wimby/followers","following_url":"https://api.github.com/users/wimby/following{/other_user}","gists_url":"https://api.github.com/users/wimby/gists{/gist_id}","starred_url":"https://api.github.com/users/wimby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wimby/subscriptions","organizations_url":"https://api.github.com/users/wimby/orgs","repos_url":"https://api.github.com/users/wimby/repos","events_url":"https://api.github.com/users/wimby/events{/privacy}","received_events_url":"https://api.github.com/users/wimby/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T18:53:39Z","updated_at":"2016-12-27T18:53:39Z","body":"I don't think you should look into what PHP accepts as a token T_LNUMBER:\r\n- 0123 is read as octal representation of 83 in decimal\r\n- 0x123 is read as hexadecimal (291 in decimal)\r\nboth are allowed as integers in PHP parser but not with FILTER_VALIDATE_INT.\r\n\r\nI would hold with wikipedia and FILTER_VALIDATE_INT, which disallow anything starting with 0 except only 0. In Math usually does not make sense to have positive and negative zero (+0 and -0), but FILTER_VALIDATE_INT allows it, so what. Same with plus sign. \r\n\r\nIf I understand it correctly, what is allowed here goes to `Calculator` which HAS to handle it (gmp and bcmath can handle plus sign but behave differently with leading zero)."}}
{"actor":{"display_login":"wimby"}}