{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2993","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2993/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2993/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2993/events","html_url":"https://github.com/RobotLocomotion/drake/pull/2993","id":168440366,"number":2993,"title":"Move functional_form from core to common","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-30T01:06:20Z","updated_at":"2016-07-30T01:51:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/2993","html_url":"https://github.com/RobotLocomotion/drake/pull/2993","diff_url":"https://github.com/RobotLocomotion/drake/pull/2993.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/2993.patch"},"body":"This moves functional_form from `core/` to `common/`.  We don't want new code in `core`; it will be going away as System1 is removed.  Furthermore, this means that new code that wants functional form likely already has it linked in `libdrakeCommon`, instead of having to add `libdrakeCore` everywhere and then ripping it out later.\r\n\r\nN.B. For review of these changes, the individual commits (browsed in github, not reviewable) may be easiest to review.  Still post comments in reviewable, though.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/2993)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/236332413","html_url":"https://github.com/RobotLocomotion/drake/pull/2993#issuecomment-236332413","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2993","id":236332413,"user":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"created_at":"2016-07-30T01:51:28Z","updated_at":"2016-07-30T01:51:28Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> Assuming this passes CI.\n\n---\n\nReviewed 12 of 12 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/2993#-:-KNtUnWnbdPjlr4xdO9F:-534171391)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"liangfok"}}