{"action":"created","comment":{"url":"https://api.github.com/repos/uw-midsun/firmware/pulls/comments/91829657","pull_request_review_id":12342760,"id":91829657,"diff_hunk":"@@ -29,7 +30,7 @@ $(T)_TESTS := $($(T)_TEST_RUNNERS:$($(T)_GEN_DIR)/%.c=$($(T)_TEST_BIN_DIR)/%$(PL\n # Generate the test runners\n $($(T)_GEN_DIR)/%_runner.c: $($(T)_TEST_ROOT)/%.c | $($(T)_GEN_DIR)\n \t@echo \"Generating $(notdir $@)\"\n-\t@$(UNITY_GEN_RUNNER) $< $@\n+\t@$(UNITY_GEN_RUNNER) $< $(firstword $|)/$(notdir $@)","path":"make/build_test.mk","position":21,"original_position":21,"commit_id":"5e844a3e5dcc867e6b46e45c3b25dec99f05a470","original_commit_id":"5e844a3e5dcc867e6b46e45c3b25dec99f05a470","user":{"login":"tituschow","id":5583338,"avatar_url":"https://avatars.githubusercontent.com/u/5583338?v=3","gravatar_id":"","url":"https://api.github.com/users/tituschow","html_url":"https://github.com/tituschow","followers_url":"https://api.github.com/users/tituschow/followers","following_url":"https://api.github.com/users/tituschow/following{/other_user}","gists_url":"https://api.github.com/users/tituschow/gists{/gist_id}","starred_url":"https://api.github.com/users/tituschow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tituschow/subscriptions","organizations_url":"https://api.github.com/users/tituschow/orgs","repos_url":"https://api.github.com/users/tituschow/repos","events_url":"https://api.github.com/users/tituschow/events{/privacy}","received_events_url":"https://api.github.com/users/tituschow/received_events","type":"User","site_admin":false},"body":"You shouldn't need to make this change.","created_at":"2016-12-10T05:47:48Z","updated_at":"2016-12-10T05:47:48Z","html_url":"https://github.com/uw-midsun/firmware/pull/16#discussion_r91829657","pull_request_url":"https://api.github.com/repos/uw-midsun/firmware/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/uw-midsun/firmware/pulls/comments/91829657"},"html":{"href":"https://github.com/uw-midsun/firmware/pull/16#discussion_r91829657"},"pull_request":{"href":"https://api.github.com/repos/uw-midsun/firmware/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/uw-midsun/firmware/pulls/16","id":97411584,"html_url":"https://github.com/uw-midsun/firmware/pull/16","diff_url":"https://github.com/uw-midsun/firmware/pull/16.diff","patch_url":"https://github.com/uw-midsun/firmware/pull/16.patch","issue_url":"https://api.github.com/repos/uw-midsun/firmware/issues/16","number":16,"state":"open","locked":false,"title":"ELEC-21 ELEC-38 ELEC-39 ELEC-42 Fixed a bunch of small things","user":{"login":"ckitagawa","id":9539007,"avatar_url":"https://avatars.githubusercontent.com/u/9539007?v=3","gravatar_id":"","url":"https://api.github.com/users/ckitagawa","html_url":"https://github.com/ckitagawa","followers_url":"https://api.github.com/users/ckitagawa/followers","following_url":"https://api.github.com/users/ckitagawa/following{/other_user}","gists_url":"https://api.github.com/users/ckitagawa/gists{/gist_id}","starred_url":"https://api.github.com/users/ckitagawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckitagawa/subscriptions","organizations_url":"https://api.github.com/users/ckitagawa/orgs","repos_url":"https://api.github.com/users/ckitagawa/repos","events_url":"https://api.github.com/users/ckitagawa/events{/privacy}","received_events_url":"https://api.github.com/users/ckitagawa/received_events","type":"User","site_admin":false},"body":"Improved linter to support the format of our test files. It was expecting filename_test.c we are using test_filename.c. This allows \"proper\" header formatting of this file's header, std library headers, other headers for tests. I have not added enforcement of this yet but am working towards an auto format for this. \r\n\r\nAdded support for platform exclusive tests (this makes device specific headers/library modules fully supported). \r\n\r\nChanged x86 platform.mk to gnu99 std to support signals.h for interrupts (wouldn't build under normal c99 see [this](http://stackoverflow.com/questions/8288164/signals-c99-vs-gnu99) for a discussion of why this is necessary).\r\n\r\nRemoved hooks as this is not in active use anymore due to .travis.yml.","created_at":"2016-12-10T03:28:23Z","updated_at":"2016-12-10T05:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed2cd0146715ac756fd6bde1543f3218d3791568","assignee":{"login":"tituschow","id":5583338,"avatar_url":"https://avatars.githubusercontent.com/u/5583338?v=3","gravatar_id":"","url":"https://api.github.com/users/tituschow","html_url":"https://github.com/tituschow","followers_url":"https://api.github.com/users/tituschow/followers","following_url":"https://api.github.com/users/tituschow/following{/other_user}","gists_url":"https://api.github.com/users/tituschow/gists{/gist_id}","starred_url":"https://api.github.com/users/tituschow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tituschow/subscriptions","organizations_url":"https://api.github.com/users/tituschow/orgs","repos_url":"https://api.github.com/users/tituschow/repos","events_url":"https://api.github.com/users/tituschow/events{/privacy}","received_events_url":"https://api.github.com/users/tituschow/received_events","type":"User","site_admin":false},"assignees":[{"login":"tituschow","id":5583338,"avatar_url":"https://avatars.githubusercontent.com/u/5583338?v=3","gravatar_id":"","url":"https://api.github.com/users/tituschow","html_url":"https://github.com/tituschow","followers_url":"https://api.github.com/users/tituschow/followers","following_url":"https://api.github.com/users/tituschow/following{/other_user}","gists_url":"https://api.github.com/users/tituschow/gists{/gist_id}","starred_url":"https://api.github.com/users/tituschow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tituschow/subscriptions","organizations_url":"https://api.github.com/users/tituschow/orgs","repos_url":"https://api.github.com/users/tituschow/repos","events_url":"https://api.github.com/users/tituschow/events{/privacy}","received_events_url":"https://api.github.com/users/tituschow/received_events","type":"User","site_admin":false},{"login":"karlding","id":6836385,"avatar_url":"https://avatars.githubusercontent.com/u/6836385?v=3","gravatar_id":"","url":"https://api.github.com/users/karlding","html_url":"https://github.com/karlding","followers_url":"https://api.github.com/users/karlding/followers","following_url":"https://api.github.com/users/karlding/following{/other_user}","gists_url":"https://api.github.com/users/karlding/gists{/gist_id}","starred_url":"https://api.github.com/users/karlding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlding/subscriptions","organizations_url":"https://api.github.com/users/karlding/orgs","repos_url":"https://api.github.com/users/karlding/repos","events_url":"https://api.github.com/users/karlding/events{/privacy}","received_events_url":"https://api.github.com/users/karlding/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uw-midsun/firmware/pulls/16/commits","review_comments_url":"https://api.github.com/repos/uw-midsun/firmware/pulls/16/comments","review_comment_url":"https://api.github.com/repos/uw-midsun/firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uw-midsun/firmware/issues/16/comments","statuses_url":"https://api.github.com/repos/uw-midsun/firmware/statuses/5e844a3e5dcc867e6b46e45c3b25dec99f05a470","head":{"label":"uw-midsun:lint_make_improvements","ref":"lint_make_improvements","sha":"5e844a3e5dcc867e6b46e45c3b25dec99f05a470","user":{"login":"uw-midsun","id":14828575,"avatar_url":"https://avatars.githubusercontent.com/u/14828575?v=3","gravatar_id":"","url":"https://api.github.com/users/uw-midsun","html_url":"https://github.com/uw-midsun","followers_url":"https://api.github.com/users/uw-midsun/followers","following_url":"https://api.github.com/users/uw-midsun/following{/other_user}","gists_url":"https://api.github.com/users/uw-midsun/gists{/gist_id}","starred_url":"https://api.github.com/users/uw-midsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uw-midsun/subscriptions","organizations_url":"https://api.github.com/users/uw-midsun/orgs","repos_url":"https://api.github.com/users/uw-midsun/repos","events_url":"https://api.github.com/users/uw-midsun/events{/privacy}","received_events_url":"https://api.github.com/users/uw-midsun/received_events","type":"Organization","site_admin":false},"repo":{"id":69197028,"name":"firmware","full_name":"uw-midsun/firmware","owner":{"login":"uw-midsun","id":14828575,"avatar_url":"https://avatars.githubusercontent.com/u/14828575?v=3","gravatar_id":"","url":"https://api.github.com/users/uw-midsun","html_url":"https://github.com/uw-midsun","followers_url":"https://api.github.com/users/uw-midsun/followers","following_url":"https://api.github.com/users/uw-midsun/following{/other_user}","gists_url":"https://api.github.com/users/uw-midsun/gists{/gist_id}","starred_url":"https://api.github.com/users/uw-midsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uw-midsun/subscriptions","organizations_url":"https://api.github.com/users/uw-midsun/orgs","repos_url":"https://api.github.com/users/uw-midsun/repos","events_url":"https://api.github.com/users/uw-midsun/events{/privacy}","received_events_url":"https://api.github.com/users/uw-midsun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uw-midsun/firmware","description":"Firmware for MSXII","fork":false,"url":"https://api.github.com/repos/uw-midsun/firmware","forks_url":"https://api.github.com/repos/uw-midsun/firmware/forks","keys_url":"https://api.github.com/repos/uw-midsun/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uw-midsun/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uw-midsun/firmware/teams","hooks_url":"https://api.github.com/repos/uw-midsun/firmware/hooks","issue_events_url":"https://api.github.com/repos/uw-midsun/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/uw-midsun/firmware/events","assignees_url":"https://api.github.com/repos/uw-midsun/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/uw-midsun/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/uw-midsun/firmware/tags","blobs_url":"https://api.github.com/repos/uw-midsun/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uw-midsun/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uw-midsun/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/uw-midsun/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uw-midsun/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/uw-midsun/firmware/languages","stargazers_url":"https://api.github.com/repos/uw-midsun/firmware/stargazers","contributors_url":"https://api.github.com/repos/uw-midsun/firmware/contributors","subscribers_url":"https://api.github.com/repos/uw-midsun/firmware/subscribers","subscription_url":"https://api.github.com/repos/uw-midsun/firmware/subscription","commits_url":"https://api.github.com/repos/uw-midsun/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/uw-midsun/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/uw-midsun/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/uw-midsun/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/uw-midsun/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/uw-midsun/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uw-midsun/firmware/merges","archive_url":"https://api.github.com/repos/uw-midsun/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uw-midsun/firmware/downloads","issues_url":"https://api.github.com/repos/uw-midsun/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/uw-midsun/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/uw-midsun/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/uw-midsun/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uw-midsun/firmware/labels{/name}","releases_url":"https://api.github.com/repos/uw-midsun/firmware/releases{/id}","deployments_url":"https://api.github.com/repos/uw-midsun/firmware/deployments","created_at":"2016-09-25T23:38:58Z","updated_at":"2016-10-22T19:09:47Z","pushed_at":"2016-12-10T03:28:23Z","git_url":"git://github.com/uw-midsun/firmware.git","ssh_url":"git@github.com:uw-midsun/firmware.git","clone_url":"https://github.com/uw-midsun/firmware.git","svn_url":"https://github.com/uw-midsun/firmware","homepage":"","size":1758,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"uw-midsun:master","ref":"master","sha":"f93d6caa06708755c8fa5c93a2ed5876d599b140","user":{"login":"uw-midsun","id":14828575,"avatar_url":"https://avatars.githubusercontent.com/u/14828575?v=3","gravatar_id":"","url":"https://api.github.com/users/uw-midsun","html_url":"https://github.com/uw-midsun","followers_url":"https://api.github.com/users/uw-midsun/followers","following_url":"https://api.github.com/users/uw-midsun/following{/other_user}","gists_url":"https://api.github.com/users/uw-midsun/gists{/gist_id}","starred_url":"https://api.github.com/users/uw-midsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uw-midsun/subscriptions","organizations_url":"https://api.github.com/users/uw-midsun/orgs","repos_url":"https://api.github.com/users/uw-midsun/repos","events_url":"https://api.github.com/users/uw-midsun/events{/privacy}","received_events_url":"https://api.github.com/users/uw-midsun/received_events","type":"Organization","site_admin":false},"repo":{"id":69197028,"name":"firmware","full_name":"uw-midsun/firmware","owner":{"login":"uw-midsun","id":14828575,"avatar_url":"https://avatars.githubusercontent.com/u/14828575?v=3","gravatar_id":"","url":"https://api.github.com/users/uw-midsun","html_url":"https://github.com/uw-midsun","followers_url":"https://api.github.com/users/uw-midsun/followers","following_url":"https://api.github.com/users/uw-midsun/following{/other_user}","gists_url":"https://api.github.com/users/uw-midsun/gists{/gist_id}","starred_url":"https://api.github.com/users/uw-midsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uw-midsun/subscriptions","organizations_url":"https://api.github.com/users/uw-midsun/orgs","repos_url":"https://api.github.com/users/uw-midsun/repos","events_url":"https://api.github.com/users/uw-midsun/events{/privacy}","received_events_url":"https://api.github.com/users/uw-midsun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uw-midsun/firmware","description":"Firmware for MSXII","fork":false,"url":"https://api.github.com/repos/uw-midsun/firmware","forks_url":"https://api.github.com/repos/uw-midsun/firmware/forks","keys_url":"https://api.github.com/repos/uw-midsun/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uw-midsun/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uw-midsun/firmware/teams","hooks_url":"https://api.github.com/repos/uw-midsun/firmware/hooks","issue_events_url":"https://api.github.com/repos/uw-midsun/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/uw-midsun/firmware/events","assignees_url":"https://api.github.com/repos/uw-midsun/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/uw-midsun/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/uw-midsun/firmware/tags","blobs_url":"https://api.github.com/repos/uw-midsun/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uw-midsun/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uw-midsun/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/uw-midsun/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uw-midsun/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/uw-midsun/firmware/languages","stargazers_url":"https://api.github.com/repos/uw-midsun/firmware/stargazers","contributors_url":"https://api.github.com/repos/uw-midsun/firmware/contributors","subscribers_url":"https://api.github.com/repos/uw-midsun/firmware/subscribers","subscription_url":"https://api.github.com/repos/uw-midsun/firmware/subscription","commits_url":"https://api.github.com/repos/uw-midsun/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/uw-midsun/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/uw-midsun/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/uw-midsun/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/uw-midsun/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/uw-midsun/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uw-midsun/firmware/merges","archive_url":"https://api.github.com/repos/uw-midsun/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uw-midsun/firmware/downloads","issues_url":"https://api.github.com/repos/uw-midsun/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/uw-midsun/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/uw-midsun/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/uw-midsun/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uw-midsun/firmware/labels{/name}","releases_url":"https://api.github.com/repos/uw-midsun/firmware/releases{/id}","deployments_url":"https://api.github.com/repos/uw-midsun/firmware/deployments","created_at":"2016-09-25T23:38:58Z","updated_at":"2016-10-22T19:09:47Z","pushed_at":"2016-12-10T03:28:23Z","git_url":"git://github.com/uw-midsun/firmware.git","ssh_url":"git@github.com:uw-midsun/firmware.git","clone_url":"https://github.com/uw-midsun/firmware.git","svn_url":"https://github.com/uw-midsun/firmware","homepage":"","size":1758,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uw-midsun/firmware/pulls/16"},"html":{"href":"https://github.com/uw-midsun/firmware/pull/16"},"issue":{"href":"https://api.github.com/repos/uw-midsun/firmware/issues/16"},"comments":{"href":"https://api.github.com/repos/uw-midsun/firmware/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/uw-midsun/firmware/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/uw-midsun/firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uw-midsun/firmware/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/uw-midsun/firmware/statuses/5e844a3e5dcc867e6b46e45c3b25dec99f05a470"}}}}
{"actor":{"display_login":"tituschow"}}