{"action":"created","comment":{"url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments/79873239","id":79873239,"diff_hunk":"@@ -0,0 +1,172 @@\n+import Rx from 'rxjs';","path":"renderers/server-render.jsx","position":1,"original_position":1,"commit_id":"724134bf835006fe691604f0f6bc593bfc6b1eb5","original_commit_id":"724134bf835006fe691604f0f6bc593bfc6b1eb5","user":{"login":"sadafie","id":1033572,"avatar_url":"https://avatars.githubusercontent.com/u/1033572?v=3","gravatar_id":"","url":"https://api.github.com/users/sadafie","html_url":"https://github.com/sadafie","followers_url":"https://api.github.com/users/sadafie/followers","following_url":"https://api.github.com/users/sadafie/following{/other_user}","gists_url":"https://api.github.com/users/sadafie/gists{/gist_id}","starred_url":"https://api.github.com/users/sadafie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadafie/subscriptions","organizations_url":"https://api.github.com/users/sadafie/orgs","repos_url":"https://api.github.com/users/sadafie/repos","events_url":"https://api.github.com/users/sadafie/events{/privacy}","received_events_url":"https://api.github.com/users/sadafie/received_events","type":"User","site_admin":false},"body":"As far as directory structure goes, since this is the server entry point, I personally find it a little strange/confusing that it lives in this sub-directory alongside browser-render.jsx. \r\n\r\nCould this file just live top level, and maybe move `browser-render` until `utils/` or somewhere else?","created_at":"2016-09-21T16:18:20Z","updated_at":"2016-09-21T16:19:22Z","html_url":"https://github.com/meetup/meetup-web-platform/pull/4#discussion_r79873239","pull_request_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments/79873239"},"html":{"href":"https://github.com/meetup/meetup-web-platform/pull/4#discussion_r79873239"},"pull_request":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4","id":85501426,"html_url":"https://github.com/meetup/meetup-web-platform/pull/4","diff_url":"https://github.com/meetup/meetup-web-platform/pull/4.diff","patch_url":"https://github.com/meetup/meetup-web-platform/pull/4.patch","issue_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/4","number":4,"state":"open","locked":false,"title":"WP 5 move the renderers over from mup-web","user":{"login":"mmcgahan","id":1885153,"avatar_url":"https://avatars.githubusercontent.com/u/1885153?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcgahan","html_url":"https://github.com/mmcgahan","followers_url":"https://api.github.com/users/mmcgahan/followers","following_url":"https://api.github.com/users/mmcgahan/following{/other_user}","gists_url":"https://api.github.com/users/mmcgahan/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcgahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcgahan/subscriptions","organizations_url":"https://api.github.com/users/mmcgahan/orgs","repos_url":"https://api.github.com/users/mmcgahan/repos","events_url":"https://api.github.com/users/mmcgahan/events{/privacy}","received_events_url":"https://api.github.com/users/mmcgahan/received_events","type":"User","site_admin":false},"body":"https://github.com/meetup/mup-web/pull/308 refactored the browser and server rendering functions to be app-agnostic so that they could be moved here to meetup-web-platform. This PR is just a copy-paste of those already-reviewed modules, with updates to the import paths so that they are internally consistent.\r\n\r\nFor review, please double check that the locations of these scripts make sense - if you think there's a better way to organize them, that's fine.","created_at":"2016-09-16T00:04:49Z","updated_at":"2016-09-21T16:19:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f132ae90ee6cd659211703b623420c0f2e53830d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4/commits","review_comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4/comments","review_comment_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/4/comments","statuses_url":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/724134bf835006fe691604f0f6bc593bfc6b1eb5","head":{"label":"meetup:WP-5_renderers","ref":"WP-5_renderers","sha":"724134bf835006fe691604f0f6bc593bfc6b1eb5","user":{"login":"meetup","id":147855,"avatar_url":"https://avatars.githubusercontent.com/u/147855?v=3","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"repo":{"id":66412742,"name":"meetup-web-platform","full_name":"meetup/meetup-web-platform","owner":{"login":"meetup","id":147855,"avatar_url":"https://avatars.githubusercontent.com/u/147855?v=3","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetup/meetup-web-platform","description":"A collection of Node web application utilities developed for the Meetup web platform","fork":false,"url":"https://api.github.com/repos/meetup/meetup-web-platform","forks_url":"https://api.github.com/repos/meetup/meetup-web-platform/forks","keys_url":"https://api.github.com/repos/meetup/meetup-web-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetup/meetup-web-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetup/meetup-web-platform/teams","hooks_url":"https://api.github.com/repos/meetup/meetup-web-platform/hooks","issue_events_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/events{/number}","events_url":"https://api.github.com/repos/meetup/meetup-web-platform/events","assignees_url":"https://api.github.com/repos/meetup/meetup-web-platform/assignees{/user}","branches_url":"https://api.github.com/repos/meetup/meetup-web-platform/branches{/branch}","tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/tags","blobs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/meetup/meetup-web-platform/languages","stargazers_url":"https://api.github.com/repos/meetup/meetup-web-platform/stargazers","contributors_url":"https://api.github.com/repos/meetup/meetup-web-platform/contributors","subscribers_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscribers","subscription_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscription","commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetup/meetup-web-platform/contents/{+path}","compare_url":"https://api.github.com/repos/meetup/meetup-web-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetup/meetup-web-platform/merges","archive_url":"https://api.github.com/repos/meetup/meetup-web-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetup/meetup-web-platform/downloads","issues_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues{/number}","pulls_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/meetup/meetup-web-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/meetup/meetup-web-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetup/meetup-web-platform/labels{/name}","releases_url":"https://api.github.com/repos/meetup/meetup-web-platform/releases{/id}","deployments_url":"https://api.github.com/repos/meetup/meetup-web-platform/deployments","created_at":"2016-08-23T23:59:22Z","updated_at":"2016-08-24T21:38:26Z","pushed_at":"2016-09-17T00:37:45Z","git_url":"git://github.com/meetup/meetup-web-platform.git","ssh_url":"git@github.com:meetup/meetup-web-platform.git","clone_url":"https://github.com/meetup/meetup-web-platform.git","svn_url":"https://github.com/meetup/meetup-web-platform","homepage":null,"size":192,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"meetup:master","ref":"master","sha":"91f56b664538a2c851c71b3b431aa0965413f337","user":{"login":"meetup","id":147855,"avatar_url":"https://avatars.githubusercontent.com/u/147855?v=3","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"repo":{"id":66412742,"name":"meetup-web-platform","full_name":"meetup/meetup-web-platform","owner":{"login":"meetup","id":147855,"avatar_url":"https://avatars.githubusercontent.com/u/147855?v=3","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetup/meetup-web-platform","description":"A collection of Node web application utilities developed for the Meetup web platform","fork":false,"url":"https://api.github.com/repos/meetup/meetup-web-platform","forks_url":"https://api.github.com/repos/meetup/meetup-web-platform/forks","keys_url":"https://api.github.com/repos/meetup/meetup-web-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetup/meetup-web-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetup/meetup-web-platform/teams","hooks_url":"https://api.github.com/repos/meetup/meetup-web-platform/hooks","issue_events_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/events{/number}","events_url":"https://api.github.com/repos/meetup/meetup-web-platform/events","assignees_url":"https://api.github.com/repos/meetup/meetup-web-platform/assignees{/user}","branches_url":"https://api.github.com/repos/meetup/meetup-web-platform/branches{/branch}","tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/tags","blobs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/meetup/meetup-web-platform/languages","stargazers_url":"https://api.github.com/repos/meetup/meetup-web-platform/stargazers","contributors_url":"https://api.github.com/repos/meetup/meetup-web-platform/contributors","subscribers_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscribers","subscription_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscription","commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetup/meetup-web-platform/contents/{+path}","compare_url":"https://api.github.com/repos/meetup/meetup-web-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetup/meetup-web-platform/merges","archive_url":"https://api.github.com/repos/meetup/meetup-web-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetup/meetup-web-platform/downloads","issues_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues{/number}","pulls_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/meetup/meetup-web-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/meetup/meetup-web-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetup/meetup-web-platform/labels{/name}","releases_url":"https://api.github.com/repos/meetup/meetup-web-platform/releases{/id}","deployments_url":"https://api.github.com/repos/meetup/meetup-web-platform/deployments","created_at":"2016-08-23T23:59:22Z","updated_at":"2016-08-24T21:38:26Z","pushed_at":"2016-09-17T00:37:45Z","git_url":"git://github.com/meetup/meetup-web-platform.git","ssh_url":"git@github.com:meetup/meetup-web-platform.git","clone_url":"https://github.com/meetup/meetup-web-platform.git","svn_url":"https://github.com/meetup/meetup-web-platform","homepage":null,"size":192,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4"},"html":{"href":"https://github.com/meetup/meetup-web-platform/pull/4"},"issue":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/issues/4"},"comments":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/724134bf835006fe691604f0f6bc593bfc6b1eb5"}}}}
{"actor":{"display_login":"sadafie"}}