{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/89182554","pull_request_review_id":9730864,"id":89182554,"diff_hunk":"@@ -28,15 +28,15 @@\n from env import TestEnv\n from test import LisaTest, experiment_test\n \n-# Read the config file and update the globals\n-CONF_FILE = os.path.join(\n-    os.path.dirname(\n-        os.path.abspath(__file__)),\n-    \"acceptance.config\")\n-\n-with open(CONF_FILE, \"r\") as fh:\n-    conf_vars = json.load(fh)\n-    globals().update(conf_vars)\n+WORKLOAD_DURATION_S = 5","path":"tests/eas/acceptance.py","position":13,"original_position":13,"commit_id":"2ef7dbad56c18c6c922877154c9203590e6e0dc0","original_commit_id":"bfc7d08872ea7b04ceca400505fe956e62bce992","user":{"login":"bjackman","id":2939691,"avatar_url":"https://avatars.githubusercontent.com/u/2939691?v=3","gravatar_id":"","url":"https://api.github.com/users/bjackman","html_url":"https://github.com/bjackman","followers_url":"https://api.github.com/users/bjackman/followers","following_url":"https://api.github.com/users/bjackman/following{/other_user}","gists_url":"https://api.github.com/users/bjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/bjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjackman/subscriptions","organizations_url":"https://api.github.com/users/bjackman/orgs","repos_url":"https://api.github.com/users/bjackman/repos","events_url":"https://api.github.com/users/bjackman/events{/privacy}","received_events_url":"https://api.github.com/users/bjackman/received_events","type":"User","site_admin":false},"body":"Added","created_at":"2016-11-22T18:43:10Z","updated_at":"2016-11-22T18:43:10Z","html_url":"https://github.com/ARM-software/lisa/pull/238#discussion_r89182554","pull_request_url":"https://api.github.com/repos/ARM-software/lisa/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/89182554"},"html":{"href":"https://github.com/ARM-software/lisa/pull/238#discussion_r89182554"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/238","id":94216375,"html_url":"https://github.com/ARM-software/lisa/pull/238","diff_url":"https://github.com/ARM-software/lisa/pull/238.diff","patch_url":"https://github.com/ARM-software/lisa/pull/238.patch","issue_url":"https://api.github.com/repos/ARM-software/lisa/issues/238","number":238,"state":"open","locked":false,"title":"Executor & LisaTest interface change","user":{"login":"bjackman","id":2939691,"avatar_url":"https://avatars.githubusercontent.com/u/2939691?v=3","gravatar_id":"","url":"https://api.github.com/users/bjackman","html_url":"https://github.com/bjackman","followers_url":"https://api.github.com/users/bjackman/followers","following_url":"https://api.github.com/users/bjackman/following{/other_user}","gists_url":"https://api.github.com/users/bjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/bjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjackman/subscriptions","organizations_url":"https://api.github.com/users/bjackman/orgs","repos_url":"https://api.github.com/users/bjackman/repos","events_url":"https://api.github.com/users/bjackman/events{/privacy}","received_events_url":"https://api.github.com/users/bjackman/received_events","type":"User","site_admin":false},"body":"The end goal of this PR is to be able to write LisaTest subclasses that generate workloads in a way that depends on target information. It contains:\r\n\r\n\"Actual\" code changes..\r\n- Modifications to Executor to enable this\r\n- The key commit which adds `_getTestConf` and `_getExperimentsConf` to `LisaTest`\r\nAnd changes that illustrate how the above should be used\r\n- Updates to examples in notebooks\r\n- Updates to acceptance tests to follow the style suggested by the changes made here\r\n\r\nI haven't \"tagged\" it but this PR is probably an RFC.","created_at":"2016-11-17T17:47:02Z","updated_at":"2016-11-22T18:43:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20357cfc6a72d70c40d9e723440d5ec990fde7d4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/lisa/pulls/238/commits","review_comments_url":"https://api.github.com/repos/ARM-software/lisa/pulls/238/comments","review_comment_url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/lisa/issues/238/comments","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/2ef7dbad56c18c6c922877154c9203590e6e0dc0","head":{"label":"bjackman:lisa-test-interface-change","ref":"lisa-test-interface-change","sha":"2ef7dbad56c18c6c922877154c9203590e6e0dc0","user":{"login":"bjackman","id":2939691,"avatar_url":"https://avatars.githubusercontent.com/u/2939691?v=3","gravatar_id":"","url":"https://api.github.com/users/bjackman","html_url":"https://github.com/bjackman","followers_url":"https://api.github.com/users/bjackman/followers","following_url":"https://api.github.com/users/bjackman/following{/other_user}","gists_url":"https://api.github.com/users/bjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/bjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjackman/subscriptions","organizations_url":"https://api.github.com/users/bjackman/orgs","repos_url":"https://api.github.com/users/bjackman/repos","events_url":"https://api.github.com/users/bjackman/events{/privacy}","received_events_url":"https://api.github.com/users/bjackman/received_events","type":"User","site_admin":false},"repo":{"id":61138100,"name":"lisa","full_name":"bjackman/lisa","owner":{"login":"bjackman","id":2939691,"avatar_url":"https://avatars.githubusercontent.com/u/2939691?v=3","gravatar_id":"","url":"https://api.github.com/users/bjackman","html_url":"https://github.com/bjackman","followers_url":"https://api.github.com/users/bjackman/followers","following_url":"https://api.github.com/users/bjackman/following{/other_user}","gists_url":"https://api.github.com/users/bjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/bjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjackman/subscriptions","organizations_url":"https://api.github.com/users/bjackman/orgs","repos_url":"https://api.github.com/users/bjackman/repos","events_url":"https://api.github.com/users/bjackman/events{/privacy}","received_events_url":"https://api.github.com/users/bjackman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjackman/lisa","description":"Linux Integrated System Analysis","fork":true,"url":"https://api.github.com/repos/bjackman/lisa","forks_url":"https://api.github.com/repos/bjackman/lisa/forks","keys_url":"https://api.github.com/repos/bjackman/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjackman/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjackman/lisa/teams","hooks_url":"https://api.github.com/repos/bjackman/lisa/hooks","issue_events_url":"https://api.github.com/repos/bjackman/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/bjackman/lisa/events","assignees_url":"https://api.github.com/repos/bjackman/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/bjackman/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/bjackman/lisa/tags","blobs_url":"https://api.github.com/repos/bjackman/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjackman/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjackman/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjackman/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjackman/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/bjackman/lisa/languages","stargazers_url":"https://api.github.com/repos/bjackman/lisa/stargazers","contributors_url":"https://api.github.com/repos/bjackman/lisa/contributors","subscribers_url":"https://api.github.com/repos/bjackman/lisa/subscribers","subscription_url":"https://api.github.com/repos/bjackman/lisa/subscription","commits_url":"https://api.github.com/repos/bjackman/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjackman/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjackman/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjackman/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjackman/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/bjackman/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjackman/lisa/merges","archive_url":"https://api.github.com/repos/bjackman/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjackman/lisa/downloads","issues_url":"https://api.github.com/repos/bjackman/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/bjackman/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/bjackman/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/bjackman/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjackman/lisa/labels{/name}","releases_url":"https://api.github.com/repos/bjackman/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/bjackman/lisa/deployments","created_at":"2016-06-14T16:22:30Z","updated_at":"2016-06-14T16:22:33Z","pushed_at":"2016-11-22T18:29:55Z","git_url":"git://github.com/bjackman/lisa.git","ssh_url":"git@github.com:bjackman/lisa.git","clone_url":"https://github.com/bjackman/lisa.git","svn_url":"https://github.com/bjackman/lisa","homepage":"","size":39503,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:master","ref":"master","sha":"20a1ac25fb898bd3b045b3aecf894df04c93fc80","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":47548304,"name":"lisa","full_name":"ARM-software/lisa","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/lisa","description":"Linux Integrated System Analysis","fork":false,"url":"https://api.github.com/repos/ARM-software/lisa","forks_url":"https://api.github.com/repos/ARM-software/lisa/forks","keys_url":"https://api.github.com/repos/ARM-software/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/lisa/teams","hooks_url":"https://api.github.com/repos/ARM-software/lisa/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/lisa/events","assignees_url":"https://api.github.com/repos/ARM-software/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/lisa/tags","blobs_url":"https://api.github.com/repos/ARM-software/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/lisa/languages","stargazers_url":"https://api.github.com/repos/ARM-software/lisa/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/lisa/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/lisa/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/lisa/subscription","commits_url":"https://api.github.com/repos/ARM-software/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/lisa/merges","archive_url":"https://api.github.com/repos/ARM-software/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/lisa/downloads","issues_url":"https://api.github.com/repos/ARM-software/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/lisa/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/lisa/deployments","created_at":"2015-12-07T11:32:56Z","updated_at":"2016-10-23T14:36:52Z","pushed_at":"2016-11-22T16:12:19Z","git_url":"git://github.com/ARM-software/lisa.git","ssh_url":"git@github.com:ARM-software/lisa.git","clone_url":"https://github.com/ARM-software/lisa.git","svn_url":"https://github.com/ARM-software/lisa","homepage":"","size":54598,"stargazers_count":12,"watchers_count":12,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":43,"forks":20,"open_issues":43,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/238"},"html":{"href":"https://github.com/ARM-software/lisa/pull/238"},"issue":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/238"},"comments":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/lisa/statuses/2ef7dbad56c18c6c922877154c9203590e6e0dc0"}}}}
{"actor":{"display_login":"bjackman"}}