{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/activity-streams/issues/75","repository_url":"https://api.github.com/repos/mozilla/activity-streams","labels_url":"https://api.github.com/repos/mozilla/activity-streams/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/activity-streams/issues/75/comments","events_url":"https://api.github.com/repos/mozilla/activity-streams/issues/75/events","html_url":"https://github.com/mozilla/activity-streams/issues/75","id":132558786,"number":75,"title":"Add some Sass linting?","user":{"login":"pdehaan","id":557895,"avatar_url":"https://avatars.githubusercontent.com/u/557895?v=3","gravatar_id":"","url":"https://api.github.com/users/pdehaan","html_url":"https://github.com/pdehaan","followers_url":"https://api.github.com/users/pdehaan/followers","following_url":"https://api.github.com/users/pdehaan/following{/other_user}","gists_url":"https://api.github.com/users/pdehaan/gists{/gist_id}","starred_url":"https://api.github.com/users/pdehaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdehaan/subscriptions","organizations_url":"https://api.github.com/users/pdehaan/orgs","repos_url":"https://api.github.com/users/pdehaan/repos","events_url":"https://api.github.com/users/pdehaan/events{/privacy}","received_events_url":"https://api.github.com/users/pdehaan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-09T22:47:18Z","updated_at":"2016-02-09T22:47:50Z","closed_at":null,"body":"I have a local, crude lint set up using https://github.com/sasstools/sass-lint and have it returning about 74 warnings and 4 errors (mostly sorting violations and nit-picky formatting)...\r\n\r\n### .sass-lint.yml\r\n```yml\r\noptions:\r\n  merge-default-rules: true\r\n\r\nfiles:\r\n  include: 'content-src/**/*.scss'\r\n\r\n\r\nrules:\r\n  extends-before-declarations: 2\r\n  extends-before-mixins: 2\r\n  hex-notation: [2, {style: uppercase}]\r\n  indentation: [2, {size: 2}]\r\n  leading-zero: [2, {include: true}]\r\n  mixins-before-declarations: [2, {exclude: [breakpoint, mq]}]\r\n  nesting-depth: [2, {max-depth: 4}]\r\n  no-debug: 1\r\n  no-ids: 1\r\n  no-important: 1\r\n  no-warn: 1\r\n  placeholder-in-extend: 2\r\n  property-sort-order: [1, {order: [display, margin], ignore-custom-properties: true}]\r\n```\r\n\r\nAfter you do an `npm i sass-lint` locally, you can run the following command to see the lint results:\r\n```sh\r\n$ ./node_modules/.bin/sass-lint -v -q #or just `sass-lint -v -q` in the package.json scripts section\r\n```"},"comment":{"url":"https://api.github.com/repos/mozilla/activity-streams/issues/comments/182117265","html_url":"https://github.com/mozilla/activity-streams/issues/75#issuecomment-182117265","issue_url":"https://api.github.com/repos/mozilla/activity-streams/issues/75","id":182117265,"user":{"login":"pdehaan","id":557895,"avatar_url":"https://avatars.githubusercontent.com/u/557895?v=3","gravatar_id":"","url":"https://api.github.com/users/pdehaan","html_url":"https://github.com/pdehaan","followers_url":"https://api.github.com/users/pdehaan/followers","following_url":"https://api.github.com/users/pdehaan/following{/other_user}","gists_url":"https://api.github.com/users/pdehaan/gists{/gist_id}","starred_url":"https://api.github.com/users/pdehaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdehaan/subscriptions","organizations_url":"https://api.github.com/users/pdehaan/orgs","repos_url":"https://api.github.com/users/pdehaan/repos","events_url":"https://api.github.com/users/pdehaan/events{/privacy}","received_events_url":"https://api.github.com/users/pdehaan/received_events","type":"User","site_admin":false},"created_at":"2016-02-09T22:47:50Z","updated_at":"2016-02-09T22:47:50Z","body":"Current output is:\r\n```\r\n➜  activity-streams git:(master) ✗ ./node_modules/.bin/sass-lint -v -q\r\n\r\ncontent-src/components/ActivityFeed/ActivityFeed.scss\r\n   2:3   warning  Expected `margin`, found `font-size`      property-sort-order\r\n  10:3   warning  Expected `display`, found `padding-left`  property-sort-order\r\n  19:33  warning  Space expected around operator            space-around-operator\r\n  19:55  warning  Space expected around operator            space-around-operator\r\n  22:1   warning  Space expected between blocks             empty-line-between-blocks\r\n  25:34  warning  Space expected around operator            space-around-operator\r\n  25:56  warning  Space expected around operator            space-around-operator\r\n  28:1   warning  Space expected between blocks             empty-line-between-blocks\r\n  29:5   warning  Expected `display`, found `content`       property-sort-order\r\n  29:14  warning  Strings must use single quotes            quotes\r\n  39:31  warning  Space expected around operator            space-around-operator\r\n  39:53  warning  Space expected around operator            space-around-operator\r\n  41:1   warning  Space expected between blocks             empty-line-between-blocks\r\n  42:5   warning  Expected `display`, found `content`       property-sort-order\r\n  42:14  warning  Strings must use single quotes            quotes\r\n  49:34  warning  Space expected around operator            space-around-operator\r\n  60:1   warning  Space expected between blocks             empty-line-between-blocks\r\n  66:1   warning  Space expected between blocks             empty-line-between-blocks\r\n  72:7   warning  Expected `margin`, found `font-weight`    property-sort-order\r\n  79:1   warning  Space expected between blocks             empty-line-between-blocks\r\n  80:7   warning  Expected `display`, found `font-size`     property-sort-order\r\n\r\ncontent-src/components/Base/Base.scss\r\n  1:1  warning  ID selectors not allowed             no-ids\r\n  2:3  warning  Expected `display`, found `height`   property-sort-order\r\n  8:3  warning  Expected `display`, found `padding`  property-sort-order\r\n\r\ncontent-src/components/Header/Header.scss\r\n   4:3   warning  Duplicate properties are not allowed within a block                               no-duplicate-properties\r\n   7:15  warning  Color literals such as 'fff' should only be used in variable declarations         no-color-literals\r\n   7:15  error    Hex notation should all be upper case                                             hex-notation\r\n   8:28  warning  Color literals such as 'dfe0e1' should only be used in variable declarations      no-color-literals\r\n   8:28  error    Hex notation should all be upper case                                             hex-notation\r\n  14:5   warning  Expected `margin`, found `font-size`                                              property-sort-order\r\n  19:5   warning  Expected `display`, found `align-items`                                           property-sort-order\r\n  27:19  warning  Color literals such as 'F3F4F6' should only be used in variable declarations      no-color-literals\r\n  28:38  warning  Color literals such as 'F3F4F6' should not be passed to functions, use variables  no-color-literals\r\n  38:1   warning  Space expected between blocks                                                     empty-line-between-blocks\r\n  51:3   warning  Expected `margin`, found `background`                                             property-sort-order\r\n  51:15  warning  Color literals such as 'F3F4F6' should only be used in variable declarations      no-color-literals\r\n  52:28  warning  Color literals such as 'F3F4F6' should not be passed to functions, use variables  no-color-literals\r\n  62:1   warning  Space expected between blocks                                                     empty-line-between-blocks\r\n  67:1   warning  Space expected between blocks                                                     empty-line-between-blocks\r\n  68:26  warning  Color literals such as 'F3F4F6' should not be passed to functions, use variables  no-color-literals\r\n\r\ncontent-src/components/NewTabPage/NewTabPage.scss\r\n   1:5  warning  Qualifying elements are not allowed for class selectors       no-qualifying-elements\r\n   1:5  warning  Class `.new-tab` should be nested within its parent selector  force-element-nesting\r\n  11:1  warning  Space expected between blocks                                 empty-line-between-blocks\r\n  15:1  warning  Space expected between blocks                                 empty-line-between-blocks\r\n\r\ncontent-src/components/TimelinePage/TimelinePage.scss\r\n   1:5   warning  Qualifying elements are not allowed for class selectors                       no-qualifying-elements\r\n   1:5   warning  Class `.timeline` should be nested within its parent selector                 force-element-nesting\r\n   3:1   warning  Space expected between blocks                                                 empty-line-between-blocks\r\n   4:5   warning  Expected `margin`, found `max-width`                                          property-sort-order\r\n   7:1   warning  Space expected between blocks                                                 empty-line-between-blocks\r\n   7:6   warning  Qualifying elements are not allowed for class selectors                       no-qualifying-elements\r\n   7:6   warning  Class `.sidebar` should be nested within its parent selector                  force-element-nesting\r\n   8:5   warning  Expected `display`, found `color`                                             property-sort-order\r\n   8:12  warning  Color literals such as '888B92' should only be used in variable declarations  no-color-literals\r\n  13:1   warning  Space expected between blocks                                                 empty-line-between-blocks\r\n  14:7   warning  Expected `margin`, found `list-style`                                         property-sort-order\r\n  18:1   warning  Space expected between blocks                                                 empty-line-between-blocks\r\n  23:1   warning  Space expected between blocks                                                 empty-line-between-blocks\r\n  27:1   warning  Space expected between blocks                                                 empty-line-between-blocks\r\n  28:32  warning  Color literals such as 'E14164' should only be used in variable declarations  no-color-literals\r\n  32:1   warning  Space expected between blocks                                                 empty-line-between-blocks\r\n  32:10  warning  Qualifying elements are not allowed for class selectors                       no-qualifying-elements\r\n  32:10  warning  Class `.content` should be nested within its parent selector                  force-element-nesting\r\n\r\ncontent-src/components/TopSites/TopSites.scss\r\n   6:1   warning  Space expected between blocks                                              empty-line-between-blocks\r\n   7:5   warning  Expected `display`, found `border`                                         property-sort-order\r\n   8:5   warning  Expected `margin`, found `border-radius`                                   property-sort-order\r\n  28:25  warning  Color literals such as 'FFF' should only be used in variable declarations  no-color-literals\r\n  47:13  warning  Class `.tile-title` should be nested within its parent pseudoClass         force-element-nesting\r\n\r\ncontent-src/main.scss\r\n   6:1  warning  ID selectors not allowed       no-ids\r\n  21:1  warning  Space expected between blocks  empty-line-between-blocks\r\n\r\ncontent-src/styles/normalize.scss\r\n   6:3   warning  Selectors must be placed on new lines                               single-line-per-selector\r\n   6:5   warning  Pseudo-class `:before` should be nested within its parent selector  force-pseudo-nesting\r\n   6:13  warning  Selectors must be placed on new lines                               single-line-per-selector\r\n   6:15  warning  Pseudo-class `:after` should be nested within its parent selector   force-pseudo-nesting\r\n  21:17  warning  !important not allowed                                              no-important\r\n\r\ncontent-src/styles/variables.scss\r\n  21:29  error    Hex notation should all be upper case                            hex-notation\r\n  22:25  warning  Color 'white' should be written in its hexadecimal form #ffffff  no-color-keywords\r\n  25:19  error    Hex notation should all be upper case                            hex-notation\r\n  28:31  warning  Color 'white' should be written in its hexadecimal form #ffffff  no-color-keywords\r\n\r\n✖ 78 problems (4 errors, 74 warnings)\r\n```"}}