{"action":"created","comment":{"url":"https://api.github.com/repos/h2o/h2o/pulls/comments/63465056","id":63465056,"diff_hunk":"@@ -411,6 +417,41 @@ typedef struct st_h2o_mimemap_type_t {\n     } data;\n } h2o_mimemap_type_t;\n \n+/* errors emanating from h2o */\n+enum {","path":"include/h2o.h","position":33,"original_position":33,"commit_id":"7ee8e64787f621e536c5fc450e36bb0d492600c9","original_commit_id":"7ee8e64787f621e536c5fc450e36bb0d492600c9","user":{"login":"kazuho","id":41567,"avatar_url":"https://avatars.githubusercontent.com/u/41567?v=3","gravatar_id":"","url":"https://api.github.com/users/kazuho","html_url":"https://github.com/kazuho","followers_url":"https://api.github.com/users/kazuho/followers","following_url":"https://api.github.com/users/kazuho/following{/other_user}","gists_url":"https://api.github.com/users/kazuho/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuho/subscriptions","organizations_url":"https://api.github.com/users/kazuho/orgs","repos_url":"https://api.github.com/users/kazuho/repos","events_url":"https://api.github.com/users/kazuho/events{/privacy}","received_events_url":"https://api.github.com/users/kazuho/received_events","type":"User","site_admin":false},"body":"How about moving the definitions of `H2O_HTTP2_ERROR_*` in http2_internal.h here, instead of trying to define a separate enum?","created_at":"2016-05-17T05:08:35Z","updated_at":"2016-05-17T05:08:35Z","html_url":"https://github.com/h2o/h2o/pull/893#discussion_r63465056","pull_request_url":"https://api.github.com/repos/h2o/h2o/pulls/893","_links":{"self":{"href":"https://api.github.com/repos/h2o/h2o/pulls/comments/63465056"},"html":{"href":"https://github.com/h2o/h2o/pull/893#discussion_r63465056"},"pull_request":{"href":"https://api.github.com/repos/h2o/h2o/pulls/893"}}},"pull_request":{"url":"https://api.github.com/repos/h2o/h2o/pulls/893","id":69028785,"html_url":"https://github.com/h2o/h2o/pull/893","diff_url":"https://github.com/h2o/h2o/pull/893.diff","patch_url":"https://github.com/h2o/h2o/pull/893.patch","issue_url":"https://api.github.com/repos/h2o/h2o/issues/893","number":893,"state":"open","locked":false,"title":"[RFC] Add extended stats","user":{"login":"deweerdt","id":5094,"avatar_url":"https://avatars.githubusercontent.com/u/5094?v=3","gravatar_id":"","url":"https://api.github.com/users/deweerdt","html_url":"https://github.com/deweerdt","followers_url":"https://api.github.com/users/deweerdt/followers","following_url":"https://api.github.com/users/deweerdt/following{/other_user}","gists_url":"https://api.github.com/users/deweerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/deweerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deweerdt/subscriptions","organizations_url":"https://api.github.com/users/deweerdt/orgs","repos_url":"https://api.github.com/users/deweerdt/repos","events_url":"https://api.github.com/users/deweerdt/events{/privacy}","received_events_url":"https://api.github.com/users/deweerdt/received_events","type":"User","site_admin":false},"body":"This PR aims at adding optional additional counters accessible via the status page. This would be enabled when `status` has the value `EXTENDED`.\r\nI post this mainly as a conversation starter, in particular to discuss how the information is gathered. Following our offline discussion, my goal would be to add also http2 counters as well as duration counters in `proxy.c`.","created_at":"2016-05-05T16:05:46Z","updated_at":"2016-05-17T05:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db063aa47843a3e20af8ed4a3216a447d9a0d5c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/h2o/h2o/pulls/893/commits","review_comments_url":"https://api.github.com/repos/h2o/h2o/pulls/893/comments","review_comment_url":"https://api.github.com/repos/h2o/h2o/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2o/h2o/issues/893/comments","statuses_url":"https://api.github.com/repos/h2o/h2o/statuses/7ee8e64787f621e536c5fc450e36bb0d492600c9","head":{"label":"deweerdt:deweerdt/stats","ref":"deweerdt/stats","sha":"7ee8e64787f621e536c5fc450e36bb0d492600c9","user":{"login":"deweerdt","id":5094,"avatar_url":"https://avatars.githubusercontent.com/u/5094?v=3","gravatar_id":"","url":"https://api.github.com/users/deweerdt","html_url":"https://github.com/deweerdt","followers_url":"https://api.github.com/users/deweerdt/followers","following_url":"https://api.github.com/users/deweerdt/following{/other_user}","gists_url":"https://api.github.com/users/deweerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/deweerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deweerdt/subscriptions","organizations_url":"https://api.github.com/users/deweerdt/orgs","repos_url":"https://api.github.com/users/deweerdt/repos","events_url":"https://api.github.com/users/deweerdt/events{/privacy}","received_events_url":"https://api.github.com/users/deweerdt/received_events","type":"User","site_admin":false},"repo":{"id":55793737,"name":"h2o","full_name":"deweerdt/h2o","owner":{"login":"deweerdt","id":5094,"avatar_url":"https://avatars.githubusercontent.com/u/5094?v=3","gravatar_id":"","url":"https://api.github.com/users/deweerdt","html_url":"https://github.com/deweerdt","followers_url":"https://api.github.com/users/deweerdt/followers","following_url":"https://api.github.com/users/deweerdt/following{/other_user}","gists_url":"https://api.github.com/users/deweerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/deweerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deweerdt/subscriptions","organizations_url":"https://api.github.com/users/deweerdt/orgs","repos_url":"https://api.github.com/users/deweerdt/repos","events_url":"https://api.github.com/users/deweerdt/events{/privacy}","received_events_url":"https://api.github.com/users/deweerdt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deweerdt/h2o","description":"H2O - the optimized HTTP/1, HTTP/2 server","fork":true,"url":"https://api.github.com/repos/deweerdt/h2o","forks_url":"https://api.github.com/repos/deweerdt/h2o/forks","keys_url":"https://api.github.com/repos/deweerdt/h2o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deweerdt/h2o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deweerdt/h2o/teams","hooks_url":"https://api.github.com/repos/deweerdt/h2o/hooks","issue_events_url":"https://api.github.com/repos/deweerdt/h2o/issues/events{/number}","events_url":"https://api.github.com/repos/deweerdt/h2o/events","assignees_url":"https://api.github.com/repos/deweerdt/h2o/assignees{/user}","branches_url":"https://api.github.com/repos/deweerdt/h2o/branches{/branch}","tags_url":"https://api.github.com/repos/deweerdt/h2o/tags","blobs_url":"https://api.github.com/repos/deweerdt/h2o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deweerdt/h2o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deweerdt/h2o/git/refs{/sha}","trees_url":"https://api.github.com/repos/deweerdt/h2o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deweerdt/h2o/statuses/{sha}","languages_url":"https://api.github.com/repos/deweerdt/h2o/languages","stargazers_url":"https://api.github.com/repos/deweerdt/h2o/stargazers","contributors_url":"https://api.github.com/repos/deweerdt/h2o/contributors","subscribers_url":"https://api.github.com/repos/deweerdt/h2o/subscribers","subscription_url":"https://api.github.com/repos/deweerdt/h2o/subscription","commits_url":"https://api.github.com/repos/deweerdt/h2o/commits{/sha}","git_commits_url":"https://api.github.com/repos/deweerdt/h2o/git/commits{/sha}","comments_url":"https://api.github.com/repos/deweerdt/h2o/comments{/number}","issue_comment_url":"https://api.github.com/repos/deweerdt/h2o/issues/comments{/number}","contents_url":"https://api.github.com/repos/deweerdt/h2o/contents/{+path}","compare_url":"https://api.github.com/repos/deweerdt/h2o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deweerdt/h2o/merges","archive_url":"https://api.github.com/repos/deweerdt/h2o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deweerdt/h2o/downloads","issues_url":"https://api.github.com/repos/deweerdt/h2o/issues{/number}","pulls_url":"https://api.github.com/repos/deweerdt/h2o/pulls{/number}","milestones_url":"https://api.github.com/repos/deweerdt/h2o/milestones{/number}","notifications_url":"https://api.github.com/repos/deweerdt/h2o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deweerdt/h2o/labels{/name}","releases_url":"https://api.github.com/repos/deweerdt/h2o/releases{/id}","deployments_url":"https://api.github.com/repos/deweerdt/h2o/deployments","created_at":"2016-04-08T16:30:51Z","updated_at":"2016-04-08T16:30:55Z","pushed_at":"2016-05-16T21:09:25Z","git_url":"git://github.com/deweerdt/h2o.git","ssh_url":"git@github.com:deweerdt/h2o.git","clone_url":"https://github.com/deweerdt/h2o.git","svn_url":"https://github.com/deweerdt/h2o","homepage":"https://h2o.examp1e.net","size":46803,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"h2o:master","ref":"master","sha":"da9e0b308ee9fa2c901f111beb18a7f2e51ed91f","user":{"login":"h2o","id":9275116,"avatar_url":"https://avatars.githubusercontent.com/u/9275116?v=3","gravatar_id":"","url":"https://api.github.com/users/h2o","html_url":"https://github.com/h2o","followers_url":"https://api.github.com/users/h2o/followers","following_url":"https://api.github.com/users/h2o/following{/other_user}","gists_url":"https://api.github.com/users/h2o/gists{/gist_id}","starred_url":"https://api.github.com/users/h2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2o/subscriptions","organizations_url":"https://api.github.com/users/h2o/orgs","repos_url":"https://api.github.com/users/h2o/repos","events_url":"https://api.github.com/users/h2o/events{/privacy}","received_events_url":"https://api.github.com/users/h2o/received_events","type":"Organization","site_admin":false},"repo":{"id":23029617,"name":"h2o","full_name":"h2o/h2o","owner":{"login":"h2o","id":9275116,"avatar_url":"https://avatars.githubusercontent.com/u/9275116?v=3","gravatar_id":"","url":"https://api.github.com/users/h2o","html_url":"https://github.com/h2o","followers_url":"https://api.github.com/users/h2o/followers","following_url":"https://api.github.com/users/h2o/following{/other_user}","gists_url":"https://api.github.com/users/h2o/gists{/gist_id}","starred_url":"https://api.github.com/users/h2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2o/subscriptions","organizations_url":"https://api.github.com/users/h2o/orgs","repos_url":"https://api.github.com/users/h2o/repos","events_url":"https://api.github.com/users/h2o/events{/privacy}","received_events_url":"https://api.github.com/users/h2o/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/h2o/h2o","description":"H2O - the optimized HTTP/1, HTTP/2 server","fork":false,"url":"https://api.github.com/repos/h2o/h2o","forks_url":"https://api.github.com/repos/h2o/h2o/forks","keys_url":"https://api.github.com/repos/h2o/h2o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2o/h2o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2o/h2o/teams","hooks_url":"https://api.github.com/repos/h2o/h2o/hooks","issue_events_url":"https://api.github.com/repos/h2o/h2o/issues/events{/number}","events_url":"https://api.github.com/repos/h2o/h2o/events","assignees_url":"https://api.github.com/repos/h2o/h2o/assignees{/user}","branches_url":"https://api.github.com/repos/h2o/h2o/branches{/branch}","tags_url":"https://api.github.com/repos/h2o/h2o/tags","blobs_url":"https://api.github.com/repos/h2o/h2o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2o/h2o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2o/h2o/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2o/h2o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2o/h2o/statuses/{sha}","languages_url":"https://api.github.com/repos/h2o/h2o/languages","stargazers_url":"https://api.github.com/repos/h2o/h2o/stargazers","contributors_url":"https://api.github.com/repos/h2o/h2o/contributors","subscribers_url":"https://api.github.com/repos/h2o/h2o/subscribers","subscription_url":"https://api.github.com/repos/h2o/h2o/subscription","commits_url":"https://api.github.com/repos/h2o/h2o/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2o/h2o/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2o/h2o/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2o/h2o/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2o/h2o/contents/{+path}","compare_url":"https://api.github.com/repos/h2o/h2o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2o/h2o/merges","archive_url":"https://api.github.com/repos/h2o/h2o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2o/h2o/downloads","issues_url":"https://api.github.com/repos/h2o/h2o/issues{/number}","pulls_url":"https://api.github.com/repos/h2o/h2o/pulls{/number}","milestones_url":"https://api.github.com/repos/h2o/h2o/milestones{/number}","notifications_url":"https://api.github.com/repos/h2o/h2o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2o/h2o/labels{/name}","releases_url":"https://api.github.com/repos/h2o/h2o/releases{/id}","deployments_url":"https://api.github.com/repos/h2o/h2o/deployments","created_at":"2014-08-16T23:59:03Z","updated_at":"2016-05-17T00:11:40Z","pushed_at":"2016-05-16T21:09:25Z","git_url":"git://github.com/h2o/h2o.git","ssh_url":"git@github.com:h2o/h2o.git","clone_url":"https://github.com/h2o/h2o.git","svn_url":"https://github.com/h2o/h2o","homepage":"https://h2o.examp1e.net","size":49523,"stargazers_count":5653,"watchers_count":5653,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"open_issues_count":218,"forks":419,"open_issues":218,"watchers":5653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2o/h2o/pulls/893"},"html":{"href":"https://github.com/h2o/h2o/pull/893"},"issue":{"href":"https://api.github.com/repos/h2o/h2o/issues/893"},"comments":{"href":"https://api.github.com/repos/h2o/h2o/issues/893/comments"},"review_comments":{"href":"https://api.github.com/repos/h2o/h2o/pulls/893/comments"},"review_comment":{"href":"https://api.github.com/repos/h2o/h2o/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2o/h2o/pulls/893/commits"},"statuses":{"href":"https://api.github.com/repos/h2o/h2o/statuses/7ee8e64787f621e536c5fc450e36bb0d492600c9"}}}}