{"action":"created","issue":{"url":"https://api.github.com/repos/bonham000/fcc-react-tests-module/issues/21","repository_url":"https://api.github.com/repos/bonham000/fcc-react-tests-module","labels_url":"https://api.github.com/repos/bonham000/fcc-react-tests-module/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/bonham000/fcc-react-tests-module/issues/21/comments","events_url":"https://api.github.com/repos/bonham000/fcc-react-tests-module/issues/21/events","html_url":"https://github.com/bonham000/fcc-react-tests-module/issues/21","id":194916081,"number":21,"title":"Challenge 3 : Where to put the comment","user":{"login":"alayek","id":5607371,"avatar_url":"https://avatars.githubusercontent.com/u/5607371?v=3","gravatar_id":"","url":"https://api.github.com/users/alayek","html_url":"https://github.com/alayek","followers_url":"https://api.github.com/users/alayek/followers","following_url":"https://api.github.com/users/alayek/following{/other_user}","gists_url":"https://api.github.com/users/alayek/gists{/gist_id}","starred_url":"https://api.github.com/users/alayek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alayek/subscriptions","organizations_url":"https://api.github.com/users/alayek/orgs","repos_url":"https://api.github.com/users/alayek/repos","events_url":"https://api.github.com/users/alayek/events{/privacy}","received_events_url":"https://api.github.com/users/alayek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-12T08:32:13Z","updated_at":"2016-12-12T16:54:41Z","closed_at":null,"body":"In the instruction it says \r\n\r\n>Instructions: We've provided a JSX element similiar to what you just wrote. Add a comment after the `h1`.\r\n\r\nI added the comment like this:\r\n\r\n```jsx\r\nconst JSX = (\r\n<div>\r\n\t<h1>This is a block of JSX</h1>\r\n\t<p>Here's a subtitle</p>\r\n  {/* hey */}\r\n</div>);\r\n```\r\n\r\nSolution code:\r\n```jsx\r\nconst JSX = (\r\n<div>\r\n\t<h1>This is a block of JSX</h1>\r\n\t{ /* this is a JSX comment */ }\r\n\t<p>Here's a subtitle</p>\r\n</div>);\r\n```\r\n\r\nDoes it have to be just after `h1` and before `p`, or is it okay to put it anywhere within the JSX?\r\n\r\n---\r\nA small typo: \r\n```diff\r\n- similiar\r\n+ similar\r\n```"},"comment":{"url":"https://api.github.com/repos/bonham000/fcc-react-tests-module/issues/comments/266484879","html_url":"https://github.com/bonham000/fcc-react-tests-module/issues/21#issuecomment-266484879","issue_url":"https://api.github.com/repos/bonham000/fcc-react-tests-module/issues/21","id":266484879,"user":{"login":"alayek","id":5607371,"avatar_url":"https://avatars.githubusercontent.com/u/5607371?v=3","gravatar_id":"","url":"https://api.github.com/users/alayek","html_url":"https://github.com/alayek","followers_url":"https://api.github.com/users/alayek/followers","following_url":"https://api.github.com/users/alayek/following{/other_user}","gists_url":"https://api.github.com/users/alayek/gists{/gist_id}","starred_url":"https://api.github.com/users/alayek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alayek/subscriptions","organizations_url":"https://api.github.com/users/alayek/orgs","repos_url":"https://api.github.com/users/alayek/repos","events_url":"https://api.github.com/users/alayek/events{/privacy}","received_events_url":"https://api.github.com/users/alayek/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T16:54:40Z","updated_at":"2016-12-12T16:54:40Z","body":"@bonham000 @SEGrooms works for me no matter where I put it, as long as it's after `h1`, and within the closing `</div>`. I would recommend putting it clearly that this is,\r\n- either, just after `<h1>`\r\n- or, anywhere after `<h1>`\r\n\r\nWhatever it is, that needs to be clear from the instructions IMHO. I know that it probably sounds like a small nitpick, but over time, you would find confused people asking about it in main chatroom and someone having to clear it up over and over again."}}
{"actor":{"display_login":"alayek"}}