{"action":"created","comment":{"url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/comments/75732811","id":75732811,"diff_hunk":"@@ -0,0 +1,22 @@\n+package org.fluentlenium.configuration;\n+\n+import java.util.Properties;\n+\n+/**\n+ * {@link ConfigurationProperties} based on {@link Properties} object.\n+ *\n+ * @see ConfigurationProperties\n+ */\n+public class PropertiesConfiguration extends AbstractPropertiesConfiguration {\n+    private Properties properties;\n+\n+    public PropertiesConfiguration(Properties properties) {\n+        super(\"\", \"fluentlenium.\");","path":"fluentlenium-core/src/main/java/org/fluentlenium/configuration/PropertiesConfiguration.java","position":14,"original_position":14,"commit_id":"595a355390892d28387de6fcdbf59102decab4ca","original_commit_id":"595a355390892d28387de6fcdbf59102decab4ca","user":{"login":"filipcynarski","id":6398578,"avatar_url":"https://avatars.githubusercontent.com/u/6398578?v=3","gravatar_id":"","url":"https://api.github.com/users/filipcynarski","html_url":"https://github.com/filipcynarski","followers_url":"https://api.github.com/users/filipcynarski/followers","following_url":"https://api.github.com/users/filipcynarski/following{/other_user}","gists_url":"https://api.github.com/users/filipcynarski/gists{/gist_id}","starred_url":"https://api.github.com/users/filipcynarski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipcynarski/subscriptions","organizations_url":"https://api.github.com/users/filipcynarski/orgs","repos_url":"https://api.github.com/users/filipcynarski/repos","events_url":"https://api.github.com/users/filipcynarski/events{/privacy}","received_events_url":"https://api.github.com/users/filipcynarski/received_events","type":"User","site_admin":false},"body":"fluentlenium. is used in a couple of places, let's create enum for that or static field","created_at":"2016-08-22T18:33:48Z","updated_at":"2016-08-22T18:33:48Z","html_url":"https://github.com/FluentLenium/FluentLenium/pull/297#discussion_r75732811","pull_request_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297","_links":{"self":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/comments/75732811"},"html":{"href":"https://github.com/FluentLenium/FluentLenium/pull/297#discussion_r75732811"},"pull_request":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297","id":81490766,"html_url":"https://github.com/FluentLenium/FluentLenium/pull/297","diff_url":"https://github.com/FluentLenium/FluentLenium/pull/297.diff","patch_url":"https://github.com/FluentLenium/FluentLenium/pull/297.patch","issue_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/297","number":297,"state":"closed","locked":false,"title":"Configuration","user":{"login":"Toilal","id":1165758,"avatar_url":"https://avatars.githubusercontent.com/u/1165758?v=3","gravatar_id":"","url":"https://api.github.com/users/Toilal","html_url":"https://github.com/Toilal","followers_url":"https://api.github.com/users/Toilal/followers","following_url":"https://api.github.com/users/Toilal/following{/other_user}","gists_url":"https://api.github.com/users/Toilal/gists{/gist_id}","starred_url":"https://api.github.com/users/Toilal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toilal/subscriptions","organizations_url":"https://api.github.com/users/Toilal/orgs","repos_url":"https://api.github.com/users/Toilal/repos","events_url":"https://api.github.com/users/Toilal/events{/privacy}","received_events_url":"https://api.github.com/users/Toilal/received_events","type":"User","site_admin":false},"body":"Implements #220 \r\n\r\n* [x] Implement configuration features.\r\n* [x] Write tests.\r\n* [x] Add ```eventsEnabled``` configuration property (```EventsFiringWebDriver``` will be created by default).\r\n* [x] Make WebDriverFactory implementations auto-discoverable (at compile time using [classindex](https://github.com/atteo/classindex))\r\n* [x] Add Proxy Support (can ben configured through capabilities)\r\n* [x] Support overriding of DefaultConfiguration class (```defaultConfiguration``` property).\r\n* [x] Support WebDriver capabilities\r\n* [x] Migrate existing test from ```newWebDriver()``` to ```getDriver()``` and ```WebDrivers``` registry","created_at":"2016-08-16T15:19:29Z","updated_at":"2016-08-22T18:33:48Z","closed_at":"2016-08-22T14:52:58Z","merged_at":"2016-08-22T14:52:58Z","merge_commit_sha":"43d2548c08057020c230316f5e9c94220b6e92b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297/commits","review_comments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297/comments","review_comment_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/297/comments","statuses_url":"https://api.github.com/repos/FluentLenium/FluentLenium/statuses/595a355390892d28387de6fcdbf59102decab4ca","head":{"label":"FluentLenium:configuration","ref":"configuration","sha":"595a355390892d28387de6fcdbf59102decab4ca","user":{"login":"FluentLenium","id":1340573,"avatar_url":"https://avatars.githubusercontent.com/u/1340573?v=3","gravatar_id":"","url":"https://api.github.com/users/FluentLenium","html_url":"https://github.com/FluentLenium","followers_url":"https://api.github.com/users/FluentLenium/followers","following_url":"https://api.github.com/users/FluentLenium/following{/other_user}","gists_url":"https://api.github.com/users/FluentLenium/gists{/gist_id}","starred_url":"https://api.github.com/users/FluentLenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluentLenium/subscriptions","organizations_url":"https://api.github.com/users/FluentLenium/orgs","repos_url":"https://api.github.com/users/FluentLenium/repos","events_url":"https://api.github.com/users/FluentLenium/events{/privacy}","received_events_url":"https://api.github.com/users/FluentLenium/received_events","type":"Organization","site_admin":false},"repo":{"id":2088736,"name":"FluentLenium","full_name":"FluentLenium/FluentLenium","owner":{"login":"FluentLenium","id":1340573,"avatar_url":"https://avatars.githubusercontent.com/u/1340573?v=3","gravatar_id":"","url":"https://api.github.com/users/FluentLenium","html_url":"https://github.com/FluentLenium","followers_url":"https://api.github.com/users/FluentLenium/followers","following_url":"https://api.github.com/users/FluentLenium/following{/other_user}","gists_url":"https://api.github.com/users/FluentLenium/gists{/gist_id}","starred_url":"https://api.github.com/users/FluentLenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluentLenium/subscriptions","organizations_url":"https://api.github.com/users/FluentLenium/orgs","repos_url":"https://api.github.com/users/FluentLenium/repos","events_url":"https://api.github.com/users/FluentLenium/events{/privacy}","received_events_url":"https://api.github.com/users/FluentLenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FluentLenium/FluentLenium","description":"FluentLenium makes the writing of acceptance tests  in a fluent way possible using the power of  css selectors. Build upon Selenium WebDriver.","fork":false,"url":"https://api.github.com/repos/FluentLenium/FluentLenium","forks_url":"https://api.github.com/repos/FluentLenium/FluentLenium/forks","keys_url":"https://api.github.com/repos/FluentLenium/FluentLenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluentLenium/FluentLenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluentLenium/FluentLenium/teams","hooks_url":"https://api.github.com/repos/FluentLenium/FluentLenium/hooks","issue_events_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/events{/number}","events_url":"https://api.github.com/repos/FluentLenium/FluentLenium/events","assignees_url":"https://api.github.com/repos/FluentLenium/FluentLenium/assignees{/user}","branches_url":"https://api.github.com/repos/FluentLenium/FluentLenium/branches{/branch}","tags_url":"https://api.github.com/repos/FluentLenium/FluentLenium/tags","blobs_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluentLenium/FluentLenium/statuses/{sha}","languages_url":"https://api.github.com/repos/FluentLenium/FluentLenium/languages","stargazers_url":"https://api.github.com/repos/FluentLenium/FluentLenium/stargazers","contributors_url":"https://api.github.com/repos/FluentLenium/FluentLenium/contributors","subscribers_url":"https://api.github.com/repos/FluentLenium/FluentLenium/subscribers","subscription_url":"https://api.github.com/repos/FluentLenium/FluentLenium/subscription","commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluentLenium/FluentLenium/contents/{+path}","compare_url":"https://api.github.com/repos/FluentLenium/FluentLenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluentLenium/FluentLenium/merges","archive_url":"https://api.github.com/repos/FluentLenium/FluentLenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluentLenium/FluentLenium/downloads","issues_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues{/number}","pulls_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls{/number}","milestones_url":"https://api.github.com/repos/FluentLenium/FluentLenium/milestones{/number}","notifications_url":"https://api.github.com/repos/FluentLenium/FluentLenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluentLenium/FluentLenium/labels{/name}","releases_url":"https://api.github.com/repos/FluentLenium/FluentLenium/releases{/id}","deployments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/deployments","created_at":"2011-07-22T13:26:37Z","updated_at":"2016-08-22T10:18:58Z","pushed_at":"2016-08-22T18:16:02Z","git_url":"git://github.com/FluentLenium/FluentLenium.git","ssh_url":"git@github.com:FluentLenium/FluentLenium.git","clone_url":"https://github.com/FluentLenium/FluentLenium.git","svn_url":"https://github.com/FluentLenium/FluentLenium","homepage":"","size":2733,"stargazers_count":485,"watchers_count":485,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":116,"mirror_url":null,"open_issues_count":21,"forks":116,"open_issues":21,"watchers":485,"default_branch":"master"}},"base":{"label":"FluentLenium:master","ref":"master","sha":"e69349be5e07396341592decaa75719b240cc98c","user":{"login":"FluentLenium","id":1340573,"avatar_url":"https://avatars.githubusercontent.com/u/1340573?v=3","gravatar_id":"","url":"https://api.github.com/users/FluentLenium","html_url":"https://github.com/FluentLenium","followers_url":"https://api.github.com/users/FluentLenium/followers","following_url":"https://api.github.com/users/FluentLenium/following{/other_user}","gists_url":"https://api.github.com/users/FluentLenium/gists{/gist_id}","starred_url":"https://api.github.com/users/FluentLenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluentLenium/subscriptions","organizations_url":"https://api.github.com/users/FluentLenium/orgs","repos_url":"https://api.github.com/users/FluentLenium/repos","events_url":"https://api.github.com/users/FluentLenium/events{/privacy}","received_events_url":"https://api.github.com/users/FluentLenium/received_events","type":"Organization","site_admin":false},"repo":{"id":2088736,"name":"FluentLenium","full_name":"FluentLenium/FluentLenium","owner":{"login":"FluentLenium","id":1340573,"avatar_url":"https://avatars.githubusercontent.com/u/1340573?v=3","gravatar_id":"","url":"https://api.github.com/users/FluentLenium","html_url":"https://github.com/FluentLenium","followers_url":"https://api.github.com/users/FluentLenium/followers","following_url":"https://api.github.com/users/FluentLenium/following{/other_user}","gists_url":"https://api.github.com/users/FluentLenium/gists{/gist_id}","starred_url":"https://api.github.com/users/FluentLenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluentLenium/subscriptions","organizations_url":"https://api.github.com/users/FluentLenium/orgs","repos_url":"https://api.github.com/users/FluentLenium/repos","events_url":"https://api.github.com/users/FluentLenium/events{/privacy}","received_events_url":"https://api.github.com/users/FluentLenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FluentLenium/FluentLenium","description":"FluentLenium makes the writing of acceptance tests  in a fluent way possible using the power of  css selectors. Build upon Selenium WebDriver.","fork":false,"url":"https://api.github.com/repos/FluentLenium/FluentLenium","forks_url":"https://api.github.com/repos/FluentLenium/FluentLenium/forks","keys_url":"https://api.github.com/repos/FluentLenium/FluentLenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluentLenium/FluentLenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluentLenium/FluentLenium/teams","hooks_url":"https://api.github.com/repos/FluentLenium/FluentLenium/hooks","issue_events_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/events{/number}","events_url":"https://api.github.com/repos/FluentLenium/FluentLenium/events","assignees_url":"https://api.github.com/repos/FluentLenium/FluentLenium/assignees{/user}","branches_url":"https://api.github.com/repos/FluentLenium/FluentLenium/branches{/branch}","tags_url":"https://api.github.com/repos/FluentLenium/FluentLenium/tags","blobs_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluentLenium/FluentLenium/statuses/{sha}","languages_url":"https://api.github.com/repos/FluentLenium/FluentLenium/languages","stargazers_url":"https://api.github.com/repos/FluentLenium/FluentLenium/stargazers","contributors_url":"https://api.github.com/repos/FluentLenium/FluentLenium/contributors","subscribers_url":"https://api.github.com/repos/FluentLenium/FluentLenium/subscribers","subscription_url":"https://api.github.com/repos/FluentLenium/FluentLenium/subscription","commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluentLenium/FluentLenium/contents/{+path}","compare_url":"https://api.github.com/repos/FluentLenium/FluentLenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluentLenium/FluentLenium/merges","archive_url":"https://api.github.com/repos/FluentLenium/FluentLenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluentLenium/FluentLenium/downloads","issues_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues{/number}","pulls_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls{/number}","milestones_url":"https://api.github.com/repos/FluentLenium/FluentLenium/milestones{/number}","notifications_url":"https://api.github.com/repos/FluentLenium/FluentLenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluentLenium/FluentLenium/labels{/name}","releases_url":"https://api.github.com/repos/FluentLenium/FluentLenium/releases{/id}","deployments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/deployments","created_at":"2011-07-22T13:26:37Z","updated_at":"2016-08-22T10:18:58Z","pushed_at":"2016-08-22T18:16:02Z","git_url":"git://github.com/FluentLenium/FluentLenium.git","ssh_url":"git@github.com:FluentLenium/FluentLenium.git","clone_url":"https://github.com/FluentLenium/FluentLenium.git","svn_url":"https://github.com/FluentLenium/FluentLenium","homepage":"","size":2733,"stargazers_count":485,"watchers_count":485,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":116,"mirror_url":null,"open_issues_count":21,"forks":116,"open_issues":21,"watchers":485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297"},"html":{"href":"https://github.com/FluentLenium/FluentLenium/pull/297"},"issue":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/297"},"comments":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/statuses/595a355390892d28387de6fcdbf59102decab4ca"}}}}
{"actor":{"display_login":"filipcynarski"}}