{"action":"created","comment":{"url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/comments/65801685","id":65801685,"diff_hunk":"@@ -1,14 +1,18 @@\n import {Config} from './config';\n import {ViewManager} from './view-manager';\n+import {resolvedView} from './decorators/resolved-view';\n \n function configure(aurelia, configCallback) {\n   let config = aurelia.container.get(Config);\n \n-  configCallback(config);\n+  if (configCallback) {","path":"src/aurelia-view.js","position":9,"original_position":9,"commit_id":"f66a31fec6911c0749aa73e2bdf880dced5dd238","original_commit_id":"f66a31fec6911c0749aa73e2bdf880dced5dd238","user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=3","gravatar_id":"","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"body":"Another thought, is checking if perhaps the thing provided is an object. That way you could allow a format like this in your project:\r\n\r\n```js\r\nexport default {\r\n  namespace: {\r\n    map: {\r\n      foo: 'bar'\r\n    }\r\n  }\r\n}\r\n```","created_at":"2016-06-04T11:58:21Z","updated_at":"2016-06-04T11:58:21Z","html_url":"https://github.com/SpoonX/aurelia-view-manager/pull/5#discussion_r65801685","pull_request_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/comments/65801685"},"html":{"href":"https://github.com/SpoonX/aurelia-view-manager/pull/5#discussion_r65801685"},"pull_request":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5","id":72529464,"html_url":"https://github.com/SpoonX/aurelia-view-manager/pull/5","diff_url":"https://github.com/SpoonX/aurelia-view-manager/pull/5.diff","patch_url":"https://github.com/SpoonX/aurelia-view-manager/pull/5.patch","issue_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/issues/5","number":5,"state":"open","locked":false,"title":"Optional config callback","user":{"login":"bas080","id":1840380,"avatar_url":"https://avatars.githubusercontent.com/u/1840380?v=3","gravatar_id":"","url":"https://api.github.com/users/bas080","html_url":"https://github.com/bas080","followers_url":"https://api.github.com/users/bas080/followers","following_url":"https://api.github.com/users/bas080/following{/other_user}","gists_url":"https://api.github.com/users/bas080/gists{/gist_id}","starred_url":"https://api.github.com/users/bas080/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas080/subscriptions","organizations_url":"https://api.github.com/users/bas080/orgs","repos_url":"https://api.github.com/users/bas080/repos","events_url":"https://api.github.com/users/bas080/events{/privacy}","received_events_url":"https://api.github.com/users/bas080/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-03T15:54:32Z","updated_at":"2016-06-04T11:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb445be370f5dfd0b72682fd74d70aa5084f021b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5/commits","review_comments_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5/comments","review_comment_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/issues/5/comments","statuses_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/statuses/f66a31fec6911c0749aa73e2bdf880dced5dd238","head":{"label":"bas080:optional-config-callback","ref":"optional-config-callback","sha":"f66a31fec6911c0749aa73e2bdf880dced5dd238","user":{"login":"bas080","id":1840380,"avatar_url":"https://avatars.githubusercontent.com/u/1840380?v=3","gravatar_id":"","url":"https://api.github.com/users/bas080","html_url":"https://github.com/bas080","followers_url":"https://api.github.com/users/bas080/followers","following_url":"https://api.github.com/users/bas080/following{/other_user}","gists_url":"https://api.github.com/users/bas080/gists{/gist_id}","starred_url":"https://api.github.com/users/bas080/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas080/subscriptions","organizations_url":"https://api.github.com/users/bas080/orgs","repos_url":"https://api.github.com/users/bas080/repos","events_url":"https://api.github.com/users/bas080/events{/privacy}","received_events_url":"https://api.github.com/users/bas080/received_events","type":"User","site_admin":false},"repo":{"id":59645853,"name":"aurelia-view","full_name":"bas080/aurelia-view","owner":{"login":"bas080","id":1840380,"avatar_url":"https://avatars.githubusercontent.com/u/1840380?v=3","gravatar_id":"","url":"https://api.github.com/users/bas080","html_url":"https://github.com/bas080","followers_url":"https://api.github.com/users/bas080/followers","following_url":"https://api.github.com/users/bas080/following{/other_user}","gists_url":"https://api.github.com/users/bas080/gists{/gist_id}","starred_url":"https://api.github.com/users/bas080/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas080/subscriptions","organizations_url":"https://api.github.com/users/bas080/orgs","repos_url":"https://api.github.com/users/bas080/repos","events_url":"https://api.github.com/users/bas080/events{/privacy}","received_events_url":"https://api.github.com/users/bas080/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bas080/aurelia-view","description":"A view manager for aurelia plugins. Add support for overriding views, and multiple frameworks.","fork":true,"url":"https://api.github.com/repos/bas080/aurelia-view","forks_url":"https://api.github.com/repos/bas080/aurelia-view/forks","keys_url":"https://api.github.com/repos/bas080/aurelia-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bas080/aurelia-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bas080/aurelia-view/teams","hooks_url":"https://api.github.com/repos/bas080/aurelia-view/hooks","issue_events_url":"https://api.github.com/repos/bas080/aurelia-view/issues/events{/number}","events_url":"https://api.github.com/repos/bas080/aurelia-view/events","assignees_url":"https://api.github.com/repos/bas080/aurelia-view/assignees{/user}","branches_url":"https://api.github.com/repos/bas080/aurelia-view/branches{/branch}","tags_url":"https://api.github.com/repos/bas080/aurelia-view/tags","blobs_url":"https://api.github.com/repos/bas080/aurelia-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bas080/aurelia-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bas080/aurelia-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/bas080/aurelia-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bas080/aurelia-view/statuses/{sha}","languages_url":"https://api.github.com/repos/bas080/aurelia-view/languages","stargazers_url":"https://api.github.com/repos/bas080/aurelia-view/stargazers","contributors_url":"https://api.github.com/repos/bas080/aurelia-view/contributors","subscribers_url":"https://api.github.com/repos/bas080/aurelia-view/subscribers","subscription_url":"https://api.github.com/repos/bas080/aurelia-view/subscription","commits_url":"https://api.github.com/repos/bas080/aurelia-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/bas080/aurelia-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/bas080/aurelia-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/bas080/aurelia-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/bas080/aurelia-view/contents/{+path}","compare_url":"https://api.github.com/repos/bas080/aurelia-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bas080/aurelia-view/merges","archive_url":"https://api.github.com/repos/bas080/aurelia-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bas080/aurelia-view/downloads","issues_url":"https://api.github.com/repos/bas080/aurelia-view/issues{/number}","pulls_url":"https://api.github.com/repos/bas080/aurelia-view/pulls{/number}","milestones_url":"https://api.github.com/repos/bas080/aurelia-view/milestones{/number}","notifications_url":"https://api.github.com/repos/bas080/aurelia-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bas080/aurelia-view/labels{/name}","releases_url":"https://api.github.com/repos/bas080/aurelia-view/releases{/id}","deployments_url":"https://api.github.com/repos/bas080/aurelia-view/deployments","created_at":"2016-05-25T08:35:54Z","updated_at":"2016-05-27T08:23:09Z","pushed_at":"2016-06-03T15:52:54Z","git_url":"git://github.com/bas080/aurelia-view.git","ssh_url":"git@github.com:bas080/aurelia-view.git","clone_url":"https://github.com/bas080/aurelia-view.git","svn_url":"https://github.com/bas080/aurelia-view","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpoonX:master","ref":"master","sha":"abb1bc9a50df5d41203acfa40b92c7edf75f4066","user":{"login":"SpoonX","id":3681611,"avatar_url":"https://avatars.githubusercontent.com/u/3681611?v=3","gravatar_id":"","url":"https://api.github.com/users/SpoonX","html_url":"https://github.com/SpoonX","followers_url":"https://api.github.com/users/SpoonX/followers","following_url":"https://api.github.com/users/SpoonX/following{/other_user}","gists_url":"https://api.github.com/users/SpoonX/gists{/gist_id}","starred_url":"https://api.github.com/users/SpoonX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpoonX/subscriptions","organizations_url":"https://api.github.com/users/SpoonX/orgs","repos_url":"https://api.github.com/users/SpoonX/repos","events_url":"https://api.github.com/users/SpoonX/events{/privacy}","received_events_url":"https://api.github.com/users/SpoonX/received_events","type":"Organization","site_admin":false},"repo":{"id":59637790,"name":"aurelia-view-manager","full_name":"SpoonX/aurelia-view-manager","owner":{"login":"SpoonX","id":3681611,"avatar_url":"https://avatars.githubusercontent.com/u/3681611?v=3","gravatar_id":"","url":"https://api.github.com/users/SpoonX","html_url":"https://github.com/SpoonX","followers_url":"https://api.github.com/users/SpoonX/followers","following_url":"https://api.github.com/users/SpoonX/following{/other_user}","gists_url":"https://api.github.com/users/SpoonX/gists{/gist_id}","starred_url":"https://api.github.com/users/SpoonX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpoonX/subscriptions","organizations_url":"https://api.github.com/users/SpoonX/orgs","repos_url":"https://api.github.com/users/SpoonX/repos","events_url":"https://api.github.com/users/SpoonX/events{/privacy}","received_events_url":"https://api.github.com/users/SpoonX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpoonX/aurelia-view-manager","description":"A view manager for aurelia plugins. Add support for overriding views, and multiple frameworks.","fork":false,"url":"https://api.github.com/repos/SpoonX/aurelia-view-manager","forks_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/forks","keys_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/teams","hooks_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/hooks","issue_events_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/issues/events{/number}","events_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/events","assignees_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/assignees{/user}","branches_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/branches{/branch}","tags_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/tags","blobs_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/languages","stargazers_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/stargazers","contributors_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/contributors","subscribers_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/subscribers","subscription_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/subscription","commits_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/contents/{+path}","compare_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/merges","archive_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/downloads","issues_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/issues{/number}","pulls_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/labels{/name}","releases_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/releases{/id}","deployments_url":"https://api.github.com/repos/SpoonX/aurelia-view-manager/deployments","created_at":"2016-05-25T06:44:04Z","updated_at":"2016-06-03T08:19:46Z","pushed_at":"2016-06-03T15:54:32Z","git_url":"git://github.com/SpoonX/aurelia-view-manager.git","ssh_url":"git@github.com:SpoonX/aurelia-view-manager.git","clone_url":"https://github.com/SpoonX/aurelia-view-manager.git","svn_url":"https://github.com/SpoonX/aurelia-view-manager","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5"},"html":{"href":"https://github.com/SpoonX/aurelia-view-manager/pull/5"},"issue":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/issues/5"},"comments":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/SpoonX/aurelia-view-manager/statuses/f66a31fec6911c0749aa73e2bdf880dced5dd238"}}}}
{"actor":{"display_login":"RWOverdijk"}}