{"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine/pulls/comments/88947192","pull_request_review_id":9502776,"id":88947192,"diff_hunk":"@@ -737,14 +737,22 @@ void vecbasic_free(CVecBasic *self)\n     delete self;\n }\n \n-void vecbasic_push_back(CVecBasic *self, const basic value)\n+CWRAPPER_OUTPUT_TYPE vecbasic_push_back(CVecBasic *self, const basic value)\n {\n+    CWRAPPER_BEGIN\n+\n     self->m.push_back(value->m);\n+\n+    CWRAPPER_END\n }\n \n-void vecbasic_get(CVecBasic *self, int n, basic result)\n+CWRAPPER_OUTPUT_TYPE vecbasic_get(CVecBasic *self, int n, basic result)\n {\n+    CWRAPPER_BEGIN\n+\n     result->m = self->m[n];\n+","path":"symengine/cwrapper.cpp","position":null,"original_position":20,"commit_id":"8734f2b34c942e47ecd3326a90f4a9cbd11f6af4","original_commit_id":"465d4fb12c4c5ae29b54e6dc5750eff3f57cb4eb","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"Signed to unsigned conversion should be caught by `-Wconversion`. See, #228.","created_at":"2016-11-21T17:37:15Z","updated_at":"2016-11-21T17:37:15Z","html_url":"https://github.com/symengine/symengine/pull/1126#discussion_r88947192","pull_request_url":"https://api.github.com/repos/symengine/symengine/pulls/1126","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments/88947192"},"html":{"href":"https://github.com/symengine/symengine/pull/1126#discussion_r88947192"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1126"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/1126","id":94576634,"html_url":"https://github.com/symengine/symengine/pull/1126","diff_url":"https://github.com/symengine/symengine/pull/1126.diff","patch_url":"https://github.com/symengine/symengine/pull/1126.patch","issue_url":"https://api.github.com/repos/symengine/symengine/issues/1126","number":1126,"state":"open","locked":false,"title":"wrapped vecbasic_* calls in CWRAPPER","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"body":"Fixed, this is from my fork.\r\n\r\nI've wrapped `vecbasic_push_back` and `vecbasic_get` with the `CWRAPPER` macros.","created_at":"2016-11-21T09:09:35Z","updated_at":"2016-11-21T17:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10bf79a459b5ec31f4514c39f52a2dd3d55b3f52","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symengine/symengine/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/1126/comments","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/8734f2b34c942e47ecd3326a90f4a9cbd11f6af4","head":{"label":"bollu:vecbasic-cwrapper","ref":"vecbasic-cwrapper","sha":"8734f2b34c942e47ecd3326a90f4a9cbd11f6af4","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"repo":{"id":52854900,"name":"symengine","full_name":"bollu/symengine","owner":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bollu/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/bollu/symengine","forks_url":"https://api.github.com/repos/bollu/symengine/forks","keys_url":"https://api.github.com/repos/bollu/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bollu/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bollu/symengine/teams","hooks_url":"https://api.github.com/repos/bollu/symengine/hooks","issue_events_url":"https://api.github.com/repos/bollu/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/bollu/symengine/events","assignees_url":"https://api.github.com/repos/bollu/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/bollu/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/bollu/symengine/tags","blobs_url":"https://api.github.com/repos/bollu/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bollu/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bollu/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/bollu/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bollu/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/bollu/symengine/languages","stargazers_url":"https://api.github.com/repos/bollu/symengine/stargazers","contributors_url":"https://api.github.com/repos/bollu/symengine/contributors","subscribers_url":"https://api.github.com/repos/bollu/symengine/subscribers","subscription_url":"https://api.github.com/repos/bollu/symengine/subscription","commits_url":"https://api.github.com/repos/bollu/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/bollu/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/bollu/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/bollu/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/bollu/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/bollu/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bollu/symengine/merges","archive_url":"https://api.github.com/repos/bollu/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bollu/symengine/downloads","issues_url":"https://api.github.com/repos/bollu/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/bollu/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/bollu/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/bollu/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bollu/symengine/labels{/name}","releases_url":"https://api.github.com/repos/bollu/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/bollu/symengine/deployments","created_at":"2016-03-01T06:48:05Z","updated_at":"2016-03-01T06:48:06Z","pushed_at":"2016-11-21T17:19:13Z","git_url":"git://github.com/bollu/symengine.git","ssh_url":"git@github.com:bollu/symengine.git","clone_url":"https://github.com/bollu/symengine.git","svn_url":"https://github.com/bollu/symengine","homepage":"http://sympy.org","size":6220,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"39c08c91d540354e2045efe7de22ead2651f416c","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"symengine/symengine","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/symengine/symengine","forks_url":"https://api.github.com/repos/symengine/symengine/forks","keys_url":"https://api.github.com/repos/symengine/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine/teams","hooks_url":"https://api.github.com/repos/symengine/symengine/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine/events","assignees_url":"https://api.github.com/repos/symengine/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine/tags","blobs_url":"https://api.github.com/repos/symengine/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine/subscription","commits_url":"https://api.github.com/repos/symengine/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine/merges","archive_url":"https://api.github.com/repos/symengine/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine/downloads","issues_url":"https://api.github.com/repos/symengine/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine/deployments","created_at":"2008-08-13T18:40:14Z","updated_at":"2016-11-19T06:53:42Z","pushed_at":"2016-11-21T17:19:13Z","git_url":"git://github.com/symengine/symengine.git","ssh_url":"git@github.com:symengine/symengine.git","clone_url":"https://github.com/symengine/symengine.git","svn_url":"https://github.com/symengine/symengine","homepage":"http://sympy.org","size":40380,"stargazers_count":196,"watchers_count":196,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":109,"forks":124,"open_issues":109,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1126"},"html":{"href":"https://github.com/symengine/symengine/pull/1126"},"issue":{"href":"https://api.github.com/repos/symengine/symengine/issues/1126"},"comments":{"href":"https://api.github.com/repos/symengine/symengine/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine/statuses/8734f2b34c942e47ecd3326a90f4a9cbd11f6af4"}}}}
{"actor":{"display_login":"isuruf"}}