{"action":"created","issue":{"url":"https://api.github.com/repos/resque/resque/issues/1488","repository_url":"https://api.github.com/repos/resque/resque","labels_url":"https://api.github.com/repos/resque/resque/issues/1488/labels{/name}","comments_url":"https://api.github.com/repos/resque/resque/issues/1488/comments","events_url":"https://api.github.com/repos/resque/resque/issues/1488/events","html_url":"https://github.com/resque/resque/pull/1488","id":164400441,"number":1488,"title":"Remove old heartbeats before starting heartbeat thread","user":{"login":"fw42","id":2072686,"avatar_url":"https://avatars.githubusercontent.com/u/2072686?v=3","gravatar_id":"","url":"https://api.github.com/users/fw42","html_url":"https://github.com/fw42","followers_url":"https://api.github.com/users/fw42/followers","following_url":"https://api.github.com/users/fw42/following{/other_user}","gists_url":"https://api.github.com/users/fw42/gists{/gist_id}","starred_url":"https://api.github.com/users/fw42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fw42/subscriptions","organizations_url":"https://api.github.com/users/fw42/orgs","repos_url":"https://api.github.com/users/fw42/repos","events_url":"https://api.github.com/users/fw42/events{/privacy}","received_events_url":"https://api.github.com/users/fw42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-07T20:31:23Z","updated_at":"2016-07-07T20:38:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/resque/resque/pulls/1488","html_url":"https://github.com/resque/resque/pull/1488","diff_url":"https://github.com/resque/resque/pull/1488.diff","patch_url":"https://github.com/resque/resque/pull/1488.patch"},"body":"It seems like https://github.com/resque/resque/pull/1485 did not fix the issue fully. I'm still seeing some PruneDeadWorker exceptions in production, which leads me to believe that there is still a race condition. Sadly I'm not really sure what the race condition is though :-(\r\n\r\nThis PR should once and for all fix it, by explicitly removing old heartbeats (of the same worker id) before sending any new heartbeats (and before registering the worker).\r\n\r\n@dylanahsmith @Sirupsen "},"comment":{"url":"https://api.github.com/repos/resque/resque/issues/comments/231200143","html_url":"https://github.com/resque/resque/pull/1488#issuecomment-231200143","issue_url":"https://api.github.com/repos/resque/resque/issues/1488","id":231200143,"user":{"login":"Sirupsen","id":97400,"avatar_url":"https://avatars.githubusercontent.com/u/97400?v=3","gravatar_id":"","url":"https://api.github.com/users/Sirupsen","html_url":"https://github.com/Sirupsen","followers_url":"https://api.github.com/users/Sirupsen/followers","following_url":"https://api.github.com/users/Sirupsen/following{/other_user}","gists_url":"https://api.github.com/users/Sirupsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sirupsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sirupsen/subscriptions","organizations_url":"https://api.github.com/users/Sirupsen/orgs","repos_url":"https://api.github.com/users/Sirupsen/repos","events_url":"https://api.github.com/users/Sirupsen/events{/privacy}","received_events_url":"https://api.github.com/users/Sirupsen/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T20:38:54Z","updated_at":"2016-07-07T20:38:54Z","body":":( I don't have any other ideas on the race. This doesn't seem crazy regardless, so I'm ok with it."}}
{"actor":{"display_login":"Sirupsen"}}