{"action":"created","comment":{"url":"https://api.github.com/repos/joehand/hypercloud/pulls/comments/93337500","pull_request_review_id":13862039,"id":93337500,"diff_hunk":"@@ -1,23 +1,43 @@\n-var path = require('path')\n-var hyperarchiver = require('hyperarchiver')\n+var assert = require('assert')\n+var fs = require('fs')\n+var memdb = require('memdb')\n+var Archiver = require('hypercore-archiver')\n+// var ArchiverServer = require('archiver-server') TODO needed?","path":"lib/cloud.js","position":7,"original_position":7,"commit_id":"4192f35872deb3f8b1b4b682055d3276e2b03348","original_commit_id":"4192f35872deb3f8b1b4b682055d3276e2b03348","user":{"login":"joehand","id":684965,"avatar_url":"https://avatars.githubusercontent.com/u/684965?v=3","gravatar_id":"","url":"https://api.github.com/users/joehand","html_url":"https://github.com/joehand","followers_url":"https://api.github.com/users/joehand/followers","following_url":"https://api.github.com/users/joehand/following{/other_user}","gists_url":"https://api.github.com/users/joehand/gists{/gist_id}","starred_url":"https://api.github.com/users/joehand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehand/subscriptions","organizations_url":"https://api.github.com/users/joehand/orgs","repos_url":"https://api.github.com/users/joehand/repos","events_url":"https://api.github.com/users/joehand/events{/privacy}","received_events_url":"https://api.github.com/users/joehand/received_events","type":"User","site_admin":false},"body":"We need some sort of server to connect to the dat swarms. `hypercore-archiver` only acts as storage, it doesn't connect to peers itself.\r\n\r\nWe could also implement the server directly with discovery-swarm but think archiver-server is good for this use case. We don't need to use the HTTP parts.","created_at":"2016-12-20T22:17:30Z","updated_at":"2016-12-20T22:18:15Z","html_url":"https://github.com/joehand/hypercloud/pull/4#discussion_r93337500","pull_request_url":"https://api.github.com/repos/joehand/hypercloud/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/joehand/hypercloud/pulls/comments/93337500"},"html":{"href":"https://github.com/joehand/hypercloud/pull/4#discussion_r93337500"},"pull_request":{"href":"https://api.github.com/repos/joehand/hypercloud/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/joehand/hypercloud/pulls/4","id":98804904,"html_url":"https://github.com/joehand/hypercloud/pull/4","diff_url":"https://github.com/joehand/hypercloud/pull/4.diff","patch_url":"https://github.com/joehand/hypercloud/pull/4.patch","issue_url":"https://api.github.com/repos/joehand/hypercloud/issues/4","number":4,"state":"open","locked":false,"title":"Bunch of little things, see description","user":{"login":"pfrazee","id":1270099,"avatar_url":"https://avatars.githubusercontent.com/u/1270099?v=3","gravatar_id":"","url":"https://api.github.com/users/pfrazee","html_url":"https://github.com/pfrazee","followers_url":"https://api.github.com/users/pfrazee/followers","following_url":"https://api.github.com/users/pfrazee/following{/other_user}","gists_url":"https://api.github.com/users/pfrazee/gists{/gist_id}","starred_url":"https://api.github.com/users/pfrazee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfrazee/subscriptions","organizations_url":"https://api.github.com/users/pfrazee/orgs","repos_url":"https://api.github.com/users/pfrazee/repos","events_url":"https://api.github.com/users/pfrazee/events{/privacy}","received_events_url":"https://api.github.com/users/pfrazee/received_events","type":"User","site_admin":false},"body":"- Switch to express\r\n- Restructure index.js to export a factory function, and make bin.js the cli entry point\r\n- Move routes to /v1/* paths\r\n- Add tests\r\n- (Open to discussion & WIP, but) remove hyperarchiver dep and instead import the modules independently, so we can diverge from hyperarchiver more","created_at":"2016-12-20T18:53:28Z","updated_at":"2016-12-20T22:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9668c21055818a08a29b10ce501d9d64b85f2751","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joehand/hypercloud/pulls/4/commits","review_comments_url":"https://api.github.com/repos/joehand/hypercloud/pulls/4/comments","review_comment_url":"https://api.github.com/repos/joehand/hypercloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joehand/hypercloud/issues/4/comments","statuses_url":"https://api.github.com/repos/joehand/hypercloud/statuses/4192f35872deb3f8b1b4b682055d3276e2b03348","head":{"label":"joehand:fill-out-routes","ref":"fill-out-routes","sha":"4192f35872deb3f8b1b4b682055d3276e2b03348","user":{"login":"joehand","id":684965,"avatar_url":"https://avatars.githubusercontent.com/u/684965?v=3","gravatar_id":"","url":"https://api.github.com/users/joehand","html_url":"https://github.com/joehand","followers_url":"https://api.github.com/users/joehand/followers","following_url":"https://api.github.com/users/joehand/following{/other_user}","gists_url":"https://api.github.com/users/joehand/gists{/gist_id}","starred_url":"https://api.github.com/users/joehand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehand/subscriptions","organizations_url":"https://api.github.com/users/joehand/orgs","repos_url":"https://api.github.com/users/joehand/repos","events_url":"https://api.github.com/users/joehand/events{/privacy}","received_events_url":"https://api.github.com/users/joehand/received_events","type":"User","site_admin":false},"repo":{"id":68567697,"name":"hypercloud","full_name":"joehand/hypercloud","owner":{"login":"joehand","id":684965,"avatar_url":"https://avatars.githubusercontent.com/u/684965?v=3","gravatar_id":"","url":"https://api.github.com/users/joehand","html_url":"https://github.com/joehand","followers_url":"https://api.github.com/users/joehand/followers","following_url":"https://api.github.com/users/joehand/following{/other_user}","gists_url":"https://api.github.com/users/joehand/gists{/gist_id}","starred_url":"https://api.github.com/users/joehand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehand/subscriptions","organizations_url":"https://api.github.com/users/joehand/orgs","repos_url":"https://api.github.com/users/joehand/repos","events_url":"https://api.github.com/users/joehand/events{/privacy}","received_events_url":"https://api.github.com/users/joehand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joehand/hypercloud","description":"p2p + ☁ ","fork":false,"url":"https://api.github.com/repos/joehand/hypercloud","forks_url":"https://api.github.com/repos/joehand/hypercloud/forks","keys_url":"https://api.github.com/repos/joehand/hypercloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joehand/hypercloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joehand/hypercloud/teams","hooks_url":"https://api.github.com/repos/joehand/hypercloud/hooks","issue_events_url":"https://api.github.com/repos/joehand/hypercloud/issues/events{/number}","events_url":"https://api.github.com/repos/joehand/hypercloud/events","assignees_url":"https://api.github.com/repos/joehand/hypercloud/assignees{/user}","branches_url":"https://api.github.com/repos/joehand/hypercloud/branches{/branch}","tags_url":"https://api.github.com/repos/joehand/hypercloud/tags","blobs_url":"https://api.github.com/repos/joehand/hypercloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joehand/hypercloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joehand/hypercloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/joehand/hypercloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joehand/hypercloud/statuses/{sha}","languages_url":"https://api.github.com/repos/joehand/hypercloud/languages","stargazers_url":"https://api.github.com/repos/joehand/hypercloud/stargazers","contributors_url":"https://api.github.com/repos/joehand/hypercloud/contributors","subscribers_url":"https://api.github.com/repos/joehand/hypercloud/subscribers","subscription_url":"https://api.github.com/repos/joehand/hypercloud/subscription","commits_url":"https://api.github.com/repos/joehand/hypercloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/joehand/hypercloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/joehand/hypercloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/joehand/hypercloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/joehand/hypercloud/contents/{+path}","compare_url":"https://api.github.com/repos/joehand/hypercloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joehand/hypercloud/merges","archive_url":"https://api.github.com/repos/joehand/hypercloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joehand/hypercloud/downloads","issues_url":"https://api.github.com/repos/joehand/hypercloud/issues{/number}","pulls_url":"https://api.github.com/repos/joehand/hypercloud/pulls{/number}","milestones_url":"https://api.github.com/repos/joehand/hypercloud/milestones{/number}","notifications_url":"https://api.github.com/repos/joehand/hypercloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joehand/hypercloud/labels{/name}","releases_url":"https://api.github.com/repos/joehand/hypercloud/releases{/id}","deployments_url":"https://api.github.com/repos/joehand/hypercloud/deployments","created_at":"2016-09-19T03:57:36Z","updated_at":"2016-12-20T19:08:40Z","pushed_at":"2016-12-20T20:41:22Z","git_url":"git://github.com/joehand/hypercloud.git","ssh_url":"git@github.com:joehand/hypercloud.git","clone_url":"https://github.com/joehand/hypercloud.git","svn_url":"https://github.com/joehand/hypercloud","homepage":null,"size":24,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":32,"default_branch":"master"}},"base":{"label":"joehand:master","ref":"master","sha":"66a02ce705fa73ca2fff7991ddbdf0ac0149cea3","user":{"login":"joehand","id":684965,"avatar_url":"https://avatars.githubusercontent.com/u/684965?v=3","gravatar_id":"","url":"https://api.github.com/users/joehand","html_url":"https://github.com/joehand","followers_url":"https://api.github.com/users/joehand/followers","following_url":"https://api.github.com/users/joehand/following{/other_user}","gists_url":"https://api.github.com/users/joehand/gists{/gist_id}","starred_url":"https://api.github.com/users/joehand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehand/subscriptions","organizations_url":"https://api.github.com/users/joehand/orgs","repos_url":"https://api.github.com/users/joehand/repos","events_url":"https://api.github.com/users/joehand/events{/privacy}","received_events_url":"https://api.github.com/users/joehand/received_events","type":"User","site_admin":false},"repo":{"id":68567697,"name":"hypercloud","full_name":"joehand/hypercloud","owner":{"login":"joehand","id":684965,"avatar_url":"https://avatars.githubusercontent.com/u/684965?v=3","gravatar_id":"","url":"https://api.github.com/users/joehand","html_url":"https://github.com/joehand","followers_url":"https://api.github.com/users/joehand/followers","following_url":"https://api.github.com/users/joehand/following{/other_user}","gists_url":"https://api.github.com/users/joehand/gists{/gist_id}","starred_url":"https://api.github.com/users/joehand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehand/subscriptions","organizations_url":"https://api.github.com/users/joehand/orgs","repos_url":"https://api.github.com/users/joehand/repos","events_url":"https://api.github.com/users/joehand/events{/privacy}","received_events_url":"https://api.github.com/users/joehand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joehand/hypercloud","description":"p2p + ☁ ","fork":false,"url":"https://api.github.com/repos/joehand/hypercloud","forks_url":"https://api.github.com/repos/joehand/hypercloud/forks","keys_url":"https://api.github.com/repos/joehand/hypercloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joehand/hypercloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joehand/hypercloud/teams","hooks_url":"https://api.github.com/repos/joehand/hypercloud/hooks","issue_events_url":"https://api.github.com/repos/joehand/hypercloud/issues/events{/number}","events_url":"https://api.github.com/repos/joehand/hypercloud/events","assignees_url":"https://api.github.com/repos/joehand/hypercloud/assignees{/user}","branches_url":"https://api.github.com/repos/joehand/hypercloud/branches{/branch}","tags_url":"https://api.github.com/repos/joehand/hypercloud/tags","blobs_url":"https://api.github.com/repos/joehand/hypercloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joehand/hypercloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joehand/hypercloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/joehand/hypercloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joehand/hypercloud/statuses/{sha}","languages_url":"https://api.github.com/repos/joehand/hypercloud/languages","stargazers_url":"https://api.github.com/repos/joehand/hypercloud/stargazers","contributors_url":"https://api.github.com/repos/joehand/hypercloud/contributors","subscribers_url":"https://api.github.com/repos/joehand/hypercloud/subscribers","subscription_url":"https://api.github.com/repos/joehand/hypercloud/subscription","commits_url":"https://api.github.com/repos/joehand/hypercloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/joehand/hypercloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/joehand/hypercloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/joehand/hypercloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/joehand/hypercloud/contents/{+path}","compare_url":"https://api.github.com/repos/joehand/hypercloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joehand/hypercloud/merges","archive_url":"https://api.github.com/repos/joehand/hypercloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joehand/hypercloud/downloads","issues_url":"https://api.github.com/repos/joehand/hypercloud/issues{/number}","pulls_url":"https://api.github.com/repos/joehand/hypercloud/pulls{/number}","milestones_url":"https://api.github.com/repos/joehand/hypercloud/milestones{/number}","notifications_url":"https://api.github.com/repos/joehand/hypercloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joehand/hypercloud/labels{/name}","releases_url":"https://api.github.com/repos/joehand/hypercloud/releases{/id}","deployments_url":"https://api.github.com/repos/joehand/hypercloud/deployments","created_at":"2016-09-19T03:57:36Z","updated_at":"2016-12-20T19:08:40Z","pushed_at":"2016-12-20T20:41:22Z","git_url":"git://github.com/joehand/hypercloud.git","ssh_url":"git@github.com:joehand/hypercloud.git","clone_url":"https://github.com/joehand/hypercloud.git","svn_url":"https://github.com/joehand/hypercloud","homepage":null,"size":24,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joehand/hypercloud/pulls/4"},"html":{"href":"https://github.com/joehand/hypercloud/pull/4"},"issue":{"href":"https://api.github.com/repos/joehand/hypercloud/issues/4"},"comments":{"href":"https://api.github.com/repos/joehand/hypercloud/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/joehand/hypercloud/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/joehand/hypercloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joehand/hypercloud/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/joehand/hypercloud/statuses/4192f35872deb3f8b1b4b682055d3276e2b03348"}}}}
{"actor":{"display_login":"joehand"}}