{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/maxwell/pulls/comments/68147882","id":68147882,"diff_hunk":"@@ -73,7 +52,8 @@ private void run(String[] argv) throws Exception {\n \t\tAbstractProducer producer = this.context.getProducer();\n \t\tAbstractBootstrapper bootstrapper = this.context.getBootstrapper();\n \n-\t\tfinal MaxwellReplicator p = new MaxwellReplicator(this.savedSchema, producer, bootstrapper, this.context, this.context.getInitialPosition());\n+\t\tMysqlSchemaStore mysqlSchemaStore = new MysqlSchemaStore(this.context);","path":"src/main/java/com/zendesk/maxwell/Maxwell.java","position":54,"original_position":54,"commit_id":"fc3ff89daa391ee2c59840efd260fe733e2b0c28","original_commit_id":"fc3ff89daa391ee2c59840efd260fe733e2b0c28","user":{"login":"dadah89","id":697824,"avatar_url":"https://avatars.githubusercontent.com/u/697824?v=3","gravatar_id":"","url":"https://api.github.com/users/dadah89","html_url":"https://github.com/dadah89","followers_url":"https://api.github.com/users/dadah89/followers","following_url":"https://api.github.com/users/dadah89/following{/other_user}","gists_url":"https://api.github.com/users/dadah89/gists{/gist_id}","starred_url":"https://api.github.com/users/dadah89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadah89/subscriptions","organizations_url":"https://api.github.com/users/dadah89/orgs","repos_url":"https://api.github.com/users/dadah89/repos","events_url":"https://api.github.com/users/dadah89/events{/privacy}","received_events_url":"https://api.github.com/users/dadah89/received_events","type":"User","site_admin":false},"body":"(guess in that case it'd be `SchemaStoreException`)","created_at":"2016-06-22T22:35:20Z","updated_at":"2016-06-22T22:35:20Z","html_url":"https://github.com/zendesk/maxwell/pull/367#discussion_r68147882","pull_request_url":"https://api.github.com/repos/zendesk/maxwell/pulls/367","_links":{"self":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/comments/68147882"},"html":{"href":"https://github.com/zendesk/maxwell/pull/367#discussion_r68147882"},"pull_request":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/maxwell/pulls/367","id":74483581,"html_url":"https://github.com/zendesk/maxwell/pull/367","diff_url":"https://github.com/zendesk/maxwell/pull/367.diff","patch_url":"https://github.com/zendesk/maxwell/pull/367.patch","issue_url":"https://api.github.com/repos/zendesk/maxwell/issues/367","number":367,"state":"open","locked":false,"title":"Schema store refactor","user":{"login":"osheroff","id":260084,"avatar_url":"https://avatars.githubusercontent.com/u/260084?v=3","gravatar_id":"","url":"https://api.github.com/users/osheroff","html_url":"https://github.com/osheroff","followers_url":"https://api.github.com/users/osheroff/followers","following_url":"https://api.github.com/users/osheroff/following{/other_user}","gists_url":"https://api.github.com/users/osheroff/gists{/gist_id}","starred_url":"https://api.github.com/users/osheroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheroff/subscriptions","organizations_url":"https://api.github.com/users/osheroff/orgs","repos_url":"https://api.github.com/users/osheroff/repos","events_url":"https://api.github.com/users/osheroff/events{/privacy}","received_events_url":"https://api.github.com/users/osheroff/received_events","type":"User","site_admin":false},"body":"This is the final resting place of https://github.com/zendesk/maxwell/pull/356.  It removes direct responsibility for Schema processing from MaxwellReplicator, which instead delegates the work of processing SQL changes and storing updates to the `SchemaStore` interface. \r\n\r\nThis is done with an eye towards multiple consumers in the same JVM.\r\n\r\n@zendesk/rules ","created_at":"2016-06-20T17:44:34Z","updated_at":"2016-06-22T22:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e5d31a6f82741de981880227a23989e2b2f488b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/maxwell/pulls/367/commits","review_comments_url":"https://api.github.com/repos/zendesk/maxwell/pulls/367/comments","review_comment_url":"https://api.github.com/repos/zendesk/maxwell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/maxwell/issues/367/comments","statuses_url":"https://api.github.com/repos/zendesk/maxwell/statuses/fc3ff89daa391ee2c59840efd260fe733e2b0c28","head":{"label":"zendesk:schema_store_refactor","ref":"schema_store_refactor","sha":"fc3ff89daa391ee2c59840efd260fe733e2b0c28","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":30561160,"name":"maxwell","full_name":"zendesk/maxwell","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/maxwell","description":"Maxwell's daemon, a mysql-to-json kafka producer","fork":false,"url":"https://api.github.com/repos/zendesk/maxwell","forks_url":"https://api.github.com/repos/zendesk/maxwell/forks","keys_url":"https://api.github.com/repos/zendesk/maxwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/maxwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/maxwell/teams","hooks_url":"https://api.github.com/repos/zendesk/maxwell/hooks","issue_events_url":"https://api.github.com/repos/zendesk/maxwell/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/maxwell/events","assignees_url":"https://api.github.com/repos/zendesk/maxwell/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/maxwell/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/maxwell/tags","blobs_url":"https://api.github.com/repos/zendesk/maxwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/maxwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/maxwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/maxwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/maxwell/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/maxwell/languages","stargazers_url":"https://api.github.com/repos/zendesk/maxwell/stargazers","contributors_url":"https://api.github.com/repos/zendesk/maxwell/contributors","subscribers_url":"https://api.github.com/repos/zendesk/maxwell/subscribers","subscription_url":"https://api.github.com/repos/zendesk/maxwell/subscription","commits_url":"https://api.github.com/repos/zendesk/maxwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/maxwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/maxwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/maxwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/maxwell/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/maxwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/maxwell/merges","archive_url":"https://api.github.com/repos/zendesk/maxwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/maxwell/downloads","issues_url":"https://api.github.com/repos/zendesk/maxwell/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/maxwell/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/maxwell/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/maxwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/maxwell/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/maxwell/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/maxwell/deployments","created_at":"2015-02-09T22:06:13Z","updated_at":"2016-06-20T21:20:21Z","pushed_at":"2016-06-21T18:40:01Z","git_url":"git://github.com/zendesk/maxwell.git","ssh_url":"git@github.com:zendesk/maxwell.git","clone_url":"https://github.com/zendesk/maxwell.git","svn_url":"https://github.com/zendesk/maxwell","homepage":"http://maxwells-daemon.io/","size":8049,"stargazers_count":148,"watchers_count":148,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":33,"forks":62,"open_issues":33,"watchers":148,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"dc7c90539cc0a3a806196ad636ff35d93c3db869","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":30561160,"name":"maxwell","full_name":"zendesk/maxwell","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/maxwell","description":"Maxwell's daemon, a mysql-to-json kafka producer","fork":false,"url":"https://api.github.com/repos/zendesk/maxwell","forks_url":"https://api.github.com/repos/zendesk/maxwell/forks","keys_url":"https://api.github.com/repos/zendesk/maxwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/maxwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/maxwell/teams","hooks_url":"https://api.github.com/repos/zendesk/maxwell/hooks","issue_events_url":"https://api.github.com/repos/zendesk/maxwell/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/maxwell/events","assignees_url":"https://api.github.com/repos/zendesk/maxwell/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/maxwell/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/maxwell/tags","blobs_url":"https://api.github.com/repos/zendesk/maxwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/maxwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/maxwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/maxwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/maxwell/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/maxwell/languages","stargazers_url":"https://api.github.com/repos/zendesk/maxwell/stargazers","contributors_url":"https://api.github.com/repos/zendesk/maxwell/contributors","subscribers_url":"https://api.github.com/repos/zendesk/maxwell/subscribers","subscription_url":"https://api.github.com/repos/zendesk/maxwell/subscription","commits_url":"https://api.github.com/repos/zendesk/maxwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/maxwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/maxwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/maxwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/maxwell/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/maxwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/maxwell/merges","archive_url":"https://api.github.com/repos/zendesk/maxwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/maxwell/downloads","issues_url":"https://api.github.com/repos/zendesk/maxwell/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/maxwell/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/maxwell/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/maxwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/maxwell/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/maxwell/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/maxwell/deployments","created_at":"2015-02-09T22:06:13Z","updated_at":"2016-06-20T21:20:21Z","pushed_at":"2016-06-21T18:40:01Z","git_url":"git://github.com/zendesk/maxwell.git","ssh_url":"git@github.com:zendesk/maxwell.git","clone_url":"https://github.com/zendesk/maxwell.git","svn_url":"https://github.com/zendesk/maxwell","homepage":"http://maxwells-daemon.io/","size":8049,"stargazers_count":148,"watchers_count":148,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":33,"forks":62,"open_issues":33,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/367"},"html":{"href":"https://github.com/zendesk/maxwell/pull/367"},"issue":{"href":"https://api.github.com/repos/zendesk/maxwell/issues/367"},"comments":{"href":"https://api.github.com/repos/zendesk/maxwell/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/maxwell/statuses/fc3ff89daa391ee2c59840efd260fe733e2b0c28"}}}}
{"actor":{"display_login":"dadah89"}}