{"action":"created","issue":{"url":"https://api.github.com/repos/openscad/openscad/issues/952","repository_url":"https://api.github.com/repos/openscad/openscad","labels_url":"https://api.github.com/repos/openscad/openscad/issues/952/labels{/name}","comments_url":"https://api.github.com/repos/openscad/openscad/issues/952/comments","events_url":"https://api.github.com/repos/openscad/openscad/issues/952/events","html_url":"https://github.com/openscad/openscad/pull/952","id":42823705,"number":952,"title":"Adding marker() nodes","user":{"login":"kintel","id":186094,"avatar_url":"https://avatars.githubusercontent.com/u/186094?v=3","gravatar_id":"","url":"https://api.github.com/users/kintel","html_url":"https://github.com/kintel","followers_url":"https://api.github.com/users/kintel/followers","following_url":"https://api.github.com/users/kintel/following{/other_user}","gists_url":"https://api.github.com/users/kintel/gists{/gist_id}","starred_url":"https://api.github.com/users/kintel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kintel/subscriptions","organizations_url":"https://api.github.com/users/kintel/orgs","repos_url":"https://api.github.com/users/kintel/repos","events_url":"https://api.github.com/users/kintel/events{/privacy}","received_events_url":"https://api.github.com/users/kintel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2014-09-15T21:58:46Z","updated_at":"2016-02-09T16:38:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openscad/openscad/pulls/952","html_url":"https://github.com/openscad/openscad/pull/952","diff_url":"https://github.com/openscad/openscad/pull/952.diff","patch_url":"https://github.com/openscad/openscad/pull/952.patch"},"body":"From @Gregwar (original pull request #939)\r\n\r\nThis introduces marker() nodes.\r\n\r\nMarkers are preserved during the CSG rendering, the contents is evaluated just like echo so you can pass it variables etc.\r\n\r\nThe advantage is that you can \"mark\" some parts of your code, and then access your markers in the CSG, simple to parse, to get for instance the locate coordinate system at a certain point from the origin of the part\r\n\r\nSee #937\r\n\r\nTODO:\r\n* [x] Make marker() experimental\r\n* [ ] Add tests\r\n\r\nTo move out of experimental, we need some discussion on this feature, as well as documentation, but we can handle that in a separate pull request\r\n"},"comment":{"url":"https://api.github.com/repos/openscad/openscad/issues/comments/181947962","html_url":"https://github.com/openscad/openscad/pull/952#issuecomment-181947962","issue_url":"https://api.github.com/repos/openscad/openscad/issues/952","id":181947962,"user":{"login":"doug-moen","id":5274273,"avatar_url":"https://avatars.githubusercontent.com/u/5274273?v=3","gravatar_id":"","url":"https://api.github.com/users/doug-moen","html_url":"https://github.com/doug-moen","followers_url":"https://api.github.com/users/doug-moen/followers","following_url":"https://api.github.com/users/doug-moen/following{/other_user}","gists_url":"https://api.github.com/users/doug-moen/gists{/gist_id}","starred_url":"https://api.github.com/users/doug-moen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doug-moen/subscriptions","organizations_url":"https://api.github.com/users/doug-moen/orgs","repos_url":"https://api.github.com/users/doug-moen/repos","events_url":"https://api.github.com/users/doug-moen/events{/privacy}","received_events_url":"https://api.github.com/users/doug-moen/received_events","type":"User","site_admin":false},"created_at":"2016-02-09T16:38:02Z","updated_at":"2016-02-09T16:38:02Z","body":"No, this has been proposed but not implemented. Marius has requested that\nother feature requests be considered in the context of OpenSCAD2, which is\nwhy I'm supplying this information.\n\nThe CSG tree will contain the final value of variables after evaluation is\ncomplete. The purpose is to add metadata to the tree. The definition a=2+2\nwould add the metadata a=4 to the tree, just as marker(2+2) would add\nmarker (4) to the tree.\n\nOn Tuesday, 9 February 2016, Grégoire Passault <notifications@github.com>\nwrote:\n\n> @doug-moen <https://github.com/doug-moen> this is not the case on master,\n> is it?\n>\n> What would become:\n>\n> abc = 12+34;\n>\n> And:\n>\n> abc = 12;\n> abc = 34;\n>\n> ?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/openscad/openscad/pull/952#issuecomment-181924031>.\n>\n"}}