{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack.io/issues/136","repository_url":"https://api.github.com/repos/webpack/webpack.io","labels_url":"https://api.github.com/repos/webpack/webpack.io/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack.io/issues/136/comments","events_url":"https://api.github.com/repos/webpack/webpack.io/issues/136/events","html_url":"https://github.com/webpack/webpack.io/issues/136","id":175487552,"number":136,"title":"[StackOverflow] Uncaught RangeError: Maximum call stack size exceeded","user":{"login":"pksjce","id":417268,"avatar_url":"https://avatars.githubusercontent.com/u/417268?v=3","gravatar_id":"","url":"https://api.github.com/users/pksjce","html_url":"https://github.com/pksjce","followers_url":"https://api.github.com/users/pksjce/followers","following_url":"https://api.github.com/users/pksjce/following{/other_user}","gists_url":"https://api.github.com/users/pksjce/gists{/gist_id}","starred_url":"https://api.github.com/users/pksjce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pksjce/subscriptions","organizations_url":"https://api.github.com/users/pksjce/orgs","repos_url":"https://api.github.com/users/pksjce/repos","events_url":"https://api.github.com/users/pksjce/events{/privacy}","received_events_url":"https://api.github.com/users/pksjce/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-07T12:17:04Z","updated_at":"2016-09-07T12:17:06Z","closed_at":null,"body":"_From @despairblue on November 3, 2015 19:39_\n\n```\r\nUncaught RangeError: Maximum call stack size exceeded\r\n  hotAddUpdateChunk @ bundle.js:736\r\n  webpackHotUpdateCallback @bundle.js:5\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n  webpackHotUpdateCallback @ bundle.js:6\r\n```\r\n\r\nWhat happens is that after a successful hot reload, [webpackHotUpdateCallback](https://github.com/webpack/webpack/blob/9f440e30ecac00bfc27b91d372a969d3414d194c/lib/JsonpMainTemplate.runtime.js#L7) keeps calling [hotAddUpdateChunk](https://github.com/webpack/webpack/blob/9f440e30ecac00bfc27b91d372a969d3414d194c/lib/HotModuleReplacement.runtime.js#L191) which returns immediately since `hotAvailibleFilesMap[0] === true` but `hostRequestedFilesMap[0] === false`. \r\n\r\nI also can't find a place where `parentHotUpdateCallback` is unset, so I don't see how this circle could ever be broken? Is this used for polling? Then a `setTimeout` could at least reset the stack. \r\n\r\nBut maybe I'm missing something here.\r\n\r\nThanks for working on this and making things like hot module replacement possible!\n\n_Copied from original issue: webpack/webpack#1583_"},"comment":{"url":"https://api.github.com/repos/webpack/webpack.io/issues/comments/245262094","html_url":"https://github.com/webpack/webpack.io/issues/136#issuecomment-245262094","issue_url":"https://api.github.com/repos/webpack/webpack.io/issues/136","id":245262094,"user":{"login":"pksjce","id":417268,"avatar_url":"https://avatars.githubusercontent.com/u/417268?v=3","gravatar_id":"","url":"https://api.github.com/users/pksjce","html_url":"https://github.com/pksjce","followers_url":"https://api.github.com/users/pksjce/followers","following_url":"https://api.github.com/users/pksjce/following{/other_user}","gists_url":"https://api.github.com/users/pksjce/gists{/gist_id}","starred_url":"https://api.github.com/users/pksjce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pksjce/subscriptions","organizations_url":"https://api.github.com/users/pksjce/orgs","repos_url":"https://api.github.com/users/pksjce/repos","events_url":"https://api.github.com/users/pksjce/events{/privacy}","received_events_url":"https://api.github.com/users/pksjce/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T12:17:06Z","updated_at":"2016-09-07T12:17:06Z","body":"_From @despairblue on November 3, 2015 23:15_\n\nOnly using one of them does also not work.\r\n\r\nIf only using `--hot` then the accept callbacks are never called. And only using the `webpack/hot/only-dev-server` entry point without `--hot` makes the dev server refresh the browser on every change instead of hot swapping the modules."}}
{"actor":{"display_login":"pksjce"}}