{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/77990521","id":77990521,"diff_hunk":"@@ -53,26 +54,26 @@ func (p *syncLogPublisher) Publish() error {\n \tvar events []*input.Event\n \tselect {\n \tcase <-p.done:\n-\t\treturn errors.New(\"publishing was stopped\")\n+\t\treturn sigPublisherStop\n \tcase events = <-p.in:\n \t}\n \n \tok := p.client.PublishEvents(getDataEvents(events), publisher.Sync, publisher.Guaranteed)\n \tif !ok {\n \t\t// PublishEvents will only returns false, if p.client has been closed.\n-\t\treturn errors.New(\"publisher didn't published events\")\n+\t\treturn sigPublisherStop","path":"filebeat/publisher/sync.go","position":57,"original_position":57,"commit_id":"322c47f0acc36ba250b234fd32bbd08555989799","original_commit_id":"322c47f0acc36ba250b234fd32bbd08555989799","user":{"login":"urso","id":75886,"avatar_url":"https://avatars.githubusercontent.com/u/75886?v=3","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"body":"we never checked/printed the error. Errors have only be used to indicate: finish publisher loop. The publisher output being closed is one of those signals. We can add some debug statements here, though.","created_at":"2016-09-08T11:44:56Z","updated_at":"2016-09-08T11:44:56Z","html_url":"https://github.com/elastic/beats/pull/2491#discussion_r77990521","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/2491","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/77990521"},"html":{"href":"https://github.com/elastic/beats/pull/2491#discussion_r77990521"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/2491"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/2491","id":84458120,"html_url":"https://github.com/elastic/beats/pull/2491","diff_url":"https://github.com/elastic/beats/pull/2491.diff","patch_url":"https://github.com/elastic/beats/pull/2491.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/2491","number":2491,"state":"open","locked":false,"title":"Replace component output channels by interfaces","user":{"login":"urso","id":75886,"avatar_url":"https://avatars.githubusercontent.com/u/75886?v=3","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-08T11:12:54Z","updated_at":"2016-09-08T11:44:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8483b6889fdc971250df6c2ba6faf7e963dca6d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/2491/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/2491/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/2491/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/322c47f0acc36ba250b234fd32bbd08555989799","head":{"label":"urso:enh/filebeat-out-interfaces","ref":"enh/filebeat-out-interfaces","sha":"322c47f0acc36ba250b234fd32bbd08555989799","user":{"login":"urso","id":75886,"avatar_url":"https://avatars.githubusercontent.com/u/75886?v=3","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"repo":{"id":40138298,"name":"beats","full_name":"urso/beats","owner":{"login":"urso","id":75886,"avatar_url":"https://avatars.githubusercontent.com/u/75886?v=3","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/urso/beats","description":"Open Source Real-Time Packet Analyzer","fork":true,"url":"https://api.github.com/repos/urso/beats","forks_url":"https://api.github.com/repos/urso/beats/forks","keys_url":"https://api.github.com/repos/urso/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urso/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urso/beats/teams","hooks_url":"https://api.github.com/repos/urso/beats/hooks","issue_events_url":"https://api.github.com/repos/urso/beats/issues/events{/number}","events_url":"https://api.github.com/repos/urso/beats/events","assignees_url":"https://api.github.com/repos/urso/beats/assignees{/user}","branches_url":"https://api.github.com/repos/urso/beats/branches{/branch}","tags_url":"https://api.github.com/repos/urso/beats/tags","blobs_url":"https://api.github.com/repos/urso/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urso/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urso/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/urso/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urso/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/urso/beats/languages","stargazers_url":"https://api.github.com/repos/urso/beats/stargazers","contributors_url":"https://api.github.com/repos/urso/beats/contributors","subscribers_url":"https://api.github.com/repos/urso/beats/subscribers","subscription_url":"https://api.github.com/repos/urso/beats/subscription","commits_url":"https://api.github.com/repos/urso/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/urso/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/urso/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/urso/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/urso/beats/contents/{+path}","compare_url":"https://api.github.com/repos/urso/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urso/beats/merges","archive_url":"https://api.github.com/repos/urso/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urso/beats/downloads","issues_url":"https://api.github.com/repos/urso/beats/issues{/number}","pulls_url":"https://api.github.com/repos/urso/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/urso/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/urso/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urso/beats/labels{/name}","releases_url":"https://api.github.com/repos/urso/beats/releases{/id}","deployments_url":"https://api.github.com/repos/urso/beats/deployments","created_at":"2015-08-03T17:25:21Z","updated_at":"2016-05-31T08:47:31Z","pushed_at":"2016-09-08T11:15:10Z","git_url":"git://github.com/urso/beats.git","ssh_url":"git@github.com:urso/beats.git","clone_url":"https://github.com/urso/beats.git","svn_url":"https://github.com/urso/beats","homepage":"https://www.elastic.co/products/beats/packetbeat","size":40180,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"ab009022384411ed0ad685e77fc760bb7229587a","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2016-09-08T11:14:41Z","pushed_at":"2016-09-08T11:40:08Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":46404,"stargazers_count":3162,"watchers_count":3162,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":563,"mirror_url":null,"open_issues_count":276,"forks":563,"open_issues":276,"watchers":3162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/2491"},"html":{"href":"https://github.com/elastic/beats/pull/2491"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/2491"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/2491/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/2491/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/2491/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/322c47f0acc36ba250b234fd32bbd08555989799"}}}}
{"actor":{"display_login":"urso"}}