{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos/issues/527","repository_url":"https://api.github.com/repos/dcos/dcos","labels_url":"https://api.github.com/repos/dcos/dcos/issues/527/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/527/comments","events_url":"https://api.github.com/repos/dcos/dcos/issues/527/events","html_url":"https://github.com/dcos/dcos/pull/527","id":170732662,"number":527,"title":"Installer CLI Argument to Upload Templates to S3 [WIP]","user":{"login":"malnick","id":4028224,"avatar_url":"https://avatars.githubusercontent.com/u/4028224?v=3","gravatar_id":"","url":"https://api.github.com/users/malnick","html_url":"https://github.com/malnick","followers_url":"https://api.github.com/users/malnick/followers","following_url":"https://api.github.com/users/malnick/following{/other_user}","gists_url":"https://api.github.com/users/malnick/gists{/gist_id}","starred_url":"https://api.github.com/users/malnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malnick/subscriptions","organizations_url":"https://api.github.com/users/malnick/orgs","repos_url":"https://api.github.com/users/malnick/repos","events_url":"https://api.github.com/users/malnick/events{/privacy}","received_events_url":"https://api.github.com/users/malnick/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dcos/dcos/labels/Work%20In%20Progress","name":"Work In Progress","color":"c5def5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-08-11T20:00:36Z","updated_at":"2016-08-12T15:46:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/527","html_url":"https://github.com/dcos/dcos/pull/527","diff_url":"https://github.com/dcos/dcos/pull/527.diff","patch_url":"https://github.com/dcos/dcos/pull/527.patch"},"body":"## Depends\r\nRelies on #442 \r\n\r\n## Associated Tickets\r\nSatisfies https://mesosphere.atlassian.net/browse/DCOS-9268\r\n\r\n## Overview\r\nThis uses a config.yaml with a few new keys:\r\n```\r\n---\r\n  cloudformation_s3_url: https://s3-us-west-2.amazonaws.com/jeremy-testing/dcos\r\n  cloudformation_s3_bucket: jeremy\r\n  cloudformation_s3_key: dcos\r\n  cloudformation_s3_region: us-west-2\r\n  zk_super_credentials: super:jeremysecret\r\n  zk_master_credentials: dcos-master:jeremysecret1\r\n  zk_agent_credentials: dcos-agent:jeremysecret2\r\n  # disabled|permissive|strict                                                                                                                                                                                                      \r\n  security: permissive\r\n```\r\n\r\n- `cloudformation_s3_bucket`\r\n- `cloudformation_s3_key`\r\n- `cloudformation_s3_region`\r\n\r\n## TODO\r\n- [ ] Add unit tests\r\n- [ ] Add integration tests"},"comment":{"url":"https://api.github.com/repos/dcos/dcos/issues/comments/239482713","html_url":"https://github.com/dcos/dcos/pull/527#issuecomment-239482713","issue_url":"https://api.github.com/repos/dcos/dcos/issues/527","id":239482713,"user":{"login":"malnick","id":4028224,"avatar_url":"https://avatars.githubusercontent.com/u/4028224?v=3","gravatar_id":"","url":"https://api.github.com/users/malnick","html_url":"https://github.com/malnick","followers_url":"https://api.github.com/users/malnick/followers","following_url":"https://api.github.com/users/malnick/following{/other_user}","gists_url":"https://api.github.com/users/malnick/gists{/gist_id}","starred_url":"https://api.github.com/users/malnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malnick/subscriptions","organizations_url":"https://api.github.com/users/malnick/orgs","repos_url":"https://api.github.com/users/malnick/repos","events_url":"https://api.github.com/users/malnick/events{/privacy}","received_events_url":"https://api.github.com/users/malnick/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T15:46:43Z","updated_at":"2016-08-12T15:46:43Z","body":"Ok, so I realize now what your initial argument is: what and when to call the CLI flag that uploads to S3. \r\n\r\nI agree, we should use a boolean flag with the CF generation flag. I do not agree that we should configure how that upload flag operates using flags, since we require three different S3 parameters, we can simply keep the keys I've added for S3 uploads in the config.yaml.\r\n\r\nDoes that sound sane to you?"}}
{"actor":{"display_login":"malnick"}}