{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7748","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7748/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7748/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7748/events","html_url":"https://github.com/cockroachdb/cockroach/pull/7748","id":164932108,"number":7748,"title":"Event Logs for CREATE/DROP INDEX","user":{"login":"mrtracy","id":6969858,"avatar_url":"https://avatars.githubusercontent.com/u/6969858?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtracy","html_url":"https://github.com/mrtracy","followers_url":"https://api.github.com/users/mrtracy/followers","following_url":"https://api.github.com/users/mrtracy/following{/other_user}","gists_url":"https://api.github.com/users/mrtracy/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtracy/subscriptions","organizations_url":"https://api.github.com/users/mrtracy/orgs","repos_url":"https://api.github.com/users/mrtracy/repos","events_url":"https://api.github.com/users/mrtracy/events{/privacy}","received_events_url":"https://api.github.com/users/mrtracy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-11T20:54:33Z","updated_at":"2016-07-11T22:30:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7748","html_url":"https://github.com/cockroachdb/cockroach/pull/7748","diff_url":"https://github.com/cockroachdb/cockroach/pull/7748.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/7748.patch"},"body":"Adds event log entries for CREATE/DROP INDEX. Both of these operations are\r\nasynchronous schema changes, and will result in a \"finish_schema_change\" event\r\nbeing logged at the completion of the change.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/7748)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/231885392","html_url":"https://github.com/cockroachdb/cockroach/pull/7748#issuecomment-231885392","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7748","id":231885392,"user":{"login":"mrtracy","id":6969858,"avatar_url":"https://avatars.githubusercontent.com/u/6969858?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtracy","html_url":"https://github.com/mrtracy","followers_url":"https://api.github.com/users/mrtracy/followers","following_url":"https://api.github.com/users/mrtracy/following{/other_user}","gists_url":"https://api.github.com/users/mrtracy/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtracy/subscriptions","organizations_url":"https://api.github.com/users/mrtracy/orgs","repos_url":"https://api.github.com/users/mrtracy/repos","events_url":"https://api.github.com/users/mrtracy/events{/privacy}","received_events_url":"https://api.github.com/users/mrtracy/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T22:30:36Z","updated_at":"2016-07-11T22:30:36Z","body":"\n\n\n\nReview status: 1 of 5 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.\n\n---\n\n*[sql/create.go, line 183 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/7748#-KMQmbHLmL_9Zs1e5QkE:-KMR2rQBfrx9xJWdHFFb:-900071791) ([raw file](https://github.com/cockroachdb/cockroach/blob/ff1d267210c3014a61cbf1751a49799ae6e9d2dd/sql/create.go#L183)):*\n<details><summary><i>Previously, tamird (Tamir Duberstein) wrote…</i></summary>\n> throughout:\n> \n> like all the other comments resembling this one - it's not useful\n> \n> Can you add a comment below explaining why this can't be:\n> ```\n> n.p.notifySchemaChange(...)\n> return MakeEventLogger(...).Insert(...)\n> ```\n</details>\nI disagree that the comment is not useful; this is a considerably different task than everything else performed in the function, it's basically a callout \"this is a tangential, but important task\".\n\nHowever, I will add \"as part of the same transaction\", which also makes it apparent why it has to be called before notifySchemaChange.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/7748)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mrtracy"}}