{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/10167","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/10167/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/10167/comments","events_url":"https://api.github.com/repos/angular/angular/issues/10167/events","html_url":"https://github.com/angular/angular/pull/10167","id":166406583,"number":10167,"title":"[Pending on TS 2.0] fix(d.ts): update Validator and ValidatorFN to work with custom valid…","user":{"login":"KaneFreeman","id":1388138,"avatar_url":"https://avatars.githubusercontent.com/u/1388138?v=3","gravatar_id":"","url":"https://api.github.com/users/KaneFreeman","html_url":"https://github.com/KaneFreeman","followers_url":"https://api.github.com/users/KaneFreeman/followers","following_url":"https://api.github.com/users/KaneFreeman/following{/other_user}","gists_url":"https://api.github.com/users/KaneFreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/KaneFreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaneFreeman/subscriptions","organizations_url":"https://api.github.com/users/KaneFreeman/orgs","repos_url":"https://api.github.com/users/KaneFreeman/repos","events_url":"https://api.github.com/users/KaneFreeman/events{/privacy}","received_events_url":"https://api.github.com/users/KaneFreeman/received_events","type":"User","site_admin":false},"labels":[{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":393879365,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20forms","name":"comp: forms","color":"c5def5","default":false},{"id":217962760,"url":"https://api.github.com/repos/angular/angular/labels/pr_state:%20blocked","name":"pr_state: blocked","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-19T18:51:36Z","updated_at":"2016-12-06T17:32:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/10167","html_url":"https://github.com/angular/angular/pull/10167","diff_url":"https://github.com/angular/angular/pull/10167.diff","patch_url":"https://github.com/angular/angular/pull/10167.patch"},"body":"**Please check if the PR fulfills these requirements**\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format\n- [N/A] Tests for the changes have been added (for bug fixes / features)\n- [x] Docs have been added / updated (for bug fixes / features)\n\n**What kind of change does this PR introduce?** (check one with \"x\")\n- [x] Bugfix\n- [ ] Feature\n- [ ] Code style update (formatting, local variables)\n- [ ] Refactoring (no functional changes, no api changes)\n- [ ] Build related changes\n- [ ] CI related changes\n- [ ] Other... Please describe:\n\n**What is the current behavior?** (You can also link to an open issue here)\n#10166\n\n**What is the new behavior?**\nSuccessful compilation with TS 2.0+ and strict null checking with custom validators.\n\n**Does this PR introduce a breaking change?** (check one with \"x\")\n\n```\n[ ] Yes\n[x] No\n```\n\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\n\n**Other information**:\nEliminate the following compiler error when using TS 2.0+ with strict null checking enabled and custom validators:\n\nArgument of type '(c: FormControl) => { customValidation: boolean; } | null' is not assignable to parameter of type 'ValidatorFn | ValidatorFn[] | undefined'.\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/265215593","html_url":"https://github.com/angular/angular/pull/10167#issuecomment-265215593","issue_url":"https://api.github.com/repos/angular/angular/issues/10167","id":265215593,"user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T17:32:14Z","updated_at":"2016-12-06T17:32:14Z","body":"We do not want to depend on TS2+ for now has it might break existing apps.\r\n\r\nThe switch to TS2+ will happen in the next Angular major release, beginning of 2017."}}
{"actor":{"display_login":"vicb"}}