{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl/issues/19","repository_url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl","labels_url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl/issues/19/comments","events_url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl/issues/19/events","html_url":"https://github.com/JuliaImages/ImageFeatures.jl/pull/19","id":172856836,"number":19,"title":"BRISK tutorial","user":{"login":"mronian","id":6151667,"avatar_url":"https://avatars.githubusercontent.com/u/6151667?v=3","gravatar_id":"","url":"https://api.github.com/users/mronian","html_url":"https://github.com/mronian","followers_url":"https://api.github.com/users/mronian/followers","following_url":"https://api.github.com/users/mronian/following{/other_user}","gists_url":"https://api.github.com/users/mronian/gists{/gist_id}","starred_url":"https://api.github.com/users/mronian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mronian/subscriptions","organizations_url":"https://api.github.com/users/mronian/orgs","repos_url":"https://api.github.com/users/mronian/repos","events_url":"https://api.github.com/users/mronian/events{/privacy}","received_events_url":"https://api.github.com/users/mronian/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-24T03:30:08Z","updated_at":"2016-08-25T15:27:46Z","closed_at":"2016-08-24T16:24:11Z","pull_request":{"url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl/pulls/19","html_url":"https://github.com/JuliaImages/ImageFeatures.jl/pull/19","diff_url":"https://github.com/JuliaImages/ImageFeatures.jl/pull/19.diff","patch_url":"https://github.com/JuliaImages/ImageFeatures.jl/pull/19.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl/issues/comments/242429204","html_url":"https://github.com/JuliaImages/ImageFeatures.jl/pull/19#issuecomment-242429204","issue_url":"https://api.github.com/repos/JuliaImages/ImageFeatures.jl/issues/19","id":242429204,"user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T15:27:46Z","updated_at":"2016-08-25T15:27:46Z","body":"Re the images: I meant the images of the sampling patterns, i.e., the plots of the circles at various positions.\r\n\r\nYou're right, I must have misinterpreted the meaning of that time marker. A much more likely culprit is the fact that package tests, [when you ask for coverage](https://github.com/JuliaImages/ImageFeatures.jl/blob/d11f4a0748ba1a7327472e49440806e5419eba24/.travis.yml#L17), are run with `--inline=no` (see `Pkg.test` code [here](https://github.com/JuliaLang/julia/blob/f58aaef9b7aa202e9d59e59798ce7f5c32706a1e/base/pkg/entry.jl#L706)). This is because coverage is woefully inaccurate if inlining is on. If you run the tests locally with `--inline=no`, then it indeed seems pretty slow.\r\n\r\nThere's work going on in base julia (https://github.com/JuliaLang/julia/pull/18196) to give accurate coverage statistics even with inlining on. So in 0.6 this shouldn't be an issue. In the meantime, I think you'll have to choose between using much smaller images in the tests (fewer data points = faster execution) or turning off coverage.\r\n"}}
{"actor":{"display_login":"timholy"}}