{"action":"created","comment":{"url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments/76782083","id":76782083,"diff_hunk":"@@ -503,7 +503,7 @@ namespace se3\n     ///\n     /// \\param[in] model The model structure of the rigid body system.\n     ///\n-    Data (const Model & model);\n+    explicit Data (const Model & model);","path":"src/multibody/model.hpp","position":5,"original_position":5,"commit_id":"f307bdd7d88faaea2ae17815b9e3d855dc4b399f","original_commit_id":"e36367a2636178316bb8f3d0e619c8f91fd34642","user":{"login":"nmansard","id":458248,"avatar_url":"https://avatars.githubusercontent.com/u/458248?v=3","gravatar_id":"","url":"https://api.github.com/users/nmansard","html_url":"https://github.com/nmansard","followers_url":"https://api.github.com/users/nmansard/followers","following_url":"https://api.github.com/users/nmansard/following{/other_user}","gists_url":"https://api.github.com/users/nmansard/gists{/gist_id}","starred_url":"https://api.github.com/users/nmansard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmansard/subscriptions","organizations_url":"https://api.github.com/users/nmansard/orgs","repos_url":"https://api.github.com/users/nmansard/repos","events_url":"https://api.github.com/users/nmansard/events{/privacy}","received_events_url":"https://api.github.com/users/nmansard/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2016-08-30T12:10:11Z","updated_at":"2016-08-30T12:10:11Z","html_url":"https://github.com/stack-of-tasks/pinocchio/pull/302#discussion_r76782083","pull_request_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments/76782083"},"html":{"href":"https://github.com/stack-of-tasks/pinocchio/pull/302#discussion_r76782083"},"pull_request":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302","id":82360150,"html_url":"https://github.com/stack-of-tasks/pinocchio/pull/302","diff_url":"https://github.com/stack-of-tasks/pinocchio/pull/302.diff","patch_url":"https://github.com/stack-of-tasks/pinocchio/pull/302.patch","issue_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/302","number":302,"state":"open","locked":false,"title":"Hpp devel","user":{"login":"jmirabel","id":2388209,"avatar_url":"https://avatars.githubusercontent.com/u/2388209?v=3","gravatar_id":"","url":"https://api.github.com/users/jmirabel","html_url":"https://github.com/jmirabel","followers_url":"https://api.github.com/users/jmirabel/followers","following_url":"https://api.github.com/users/jmirabel/following{/other_user}","gists_url":"https://api.github.com/users/jmirabel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmirabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmirabel/subscriptions","organizations_url":"https://api.github.com/users/jmirabel/orgs","repos_url":"https://api.github.com/users/jmirabel/repos","events_url":"https://api.github.com/users/jmirabel/events{/privacy}","received_events_url":"https://api.github.com/users/jmirabel/received_events","type":"User","site_admin":false},"body":"I open the pull-request to start discussing the changes I did to integrate Pinocchio in HPP.\r\n\r\n## Mandatory changes\r\n- URDF parser: allow bodies without inertia. There could be a check somewhere in Pinocchio.\r\n- SRDF parser: disable collisions between link from URDF and not between all pairs of geometry between two joints because fixed joints are merged with their parent.\r\n\r\n## Convenient changes (but there exists workaround)\r\n- Geometry object does not necessarily need a `parentFrame`. We could allow `-1` when not set.\r\n- Removing `CollisionResult`\r\n- `GeometraData::computeCollision` and `GeometryData::isColliding` API changes. I found they give more flexibility.","created_at":"2016-08-23T13:01:58Z","updated_at":"2016-08-30T12:10:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11d30f2aee17aa3faa441fb2ad84ba386aff1f14","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/stack-of-tasks/pinocchio/milestones/3","html_url":"https://github.com/stack-of-tasks/pinocchio/milestones/HPP%20refactoring","labels_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/milestones/3/labels","id":1855639,"number":3,"title":"HPP refactoring","description":"Fusion of Pinocchio with HPP.","creator":{"login":"jcarpent","id":1567317,"avatar_url":"https://avatars.githubusercontent.com/u/1567317?v=3","gravatar_id":"","url":"https://api.github.com/users/jcarpent","html_url":"https://github.com/jcarpent","followers_url":"https://api.github.com/users/jcarpent/followers","following_url":"https://api.github.com/users/jcarpent/following{/other_user}","gists_url":"https://api.github.com/users/jcarpent/gists{/gist_id}","starred_url":"https://api.github.com/users/jcarpent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcarpent/subscriptions","organizations_url":"https://api.github.com/users/jcarpent/orgs","repos_url":"https://api.github.com/users/jcarpent/repos","events_url":"https://api.github.com/users/jcarpent/events{/privacy}","received_events_url":"https://api.github.com/users/jcarpent/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":37,"state":"open","created_at":"2016-06-29T17:23:22Z","updated_at":"2016-08-26T12:44:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302/commits","review_comments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302/comments","review_comment_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/302/comments","statuses_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/statuses/f307bdd7d88faaea2ae17815b9e3d855dc4b399f","head":{"label":"stack-of-tasks:hpp-devel","ref":"hpp-devel","sha":"f307bdd7d88faaea2ae17815b9e3d855dc4b399f","user":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"repo":{"id":24897645,"name":"pinocchio","full_name":"stack-of-tasks/pinocchio","owner":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stack-of-tasks/pinocchio","description":"Dynamic computations using Spatial Algebra","fork":false,"url":"https://api.github.com/repos/stack-of-tasks/pinocchio","forks_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/forks","keys_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/teams","hooks_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/hooks","issue_events_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/events{/number}","events_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/events","assignees_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/assignees{/user}","branches_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/branches{/branch}","tags_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/tags","blobs_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/refs{/sha}","trees_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/statuses/{sha}","languages_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/languages","stargazers_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/stargazers","contributors_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/contributors","subscribers_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/subscribers","subscription_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/subscription","commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/commits{/sha}","git_commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/commits{/sha}","comments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/comments{/number}","issue_comment_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/comments{/number}","contents_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/contents/{+path}","compare_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/merges","archive_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/downloads","issues_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues{/number}","pulls_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls{/number}","milestones_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/milestones{/number}","notifications_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/labels{/name}","releases_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/releases{/id}","deployments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/deployments","created_at":"2014-10-07T15:42:51Z","updated_at":"2016-07-27T11:22:57Z","pushed_at":"2016-08-26T14:42:57Z","git_url":"git://github.com/stack-of-tasks/pinocchio.git","ssh_url":"git@github.com:stack-of-tasks/pinocchio.git","clone_url":"https://github.com/stack-of-tasks/pinocchio.git","svn_url":"https://github.com/stack-of-tasks/pinocchio","homepage":"http://stack-of-tasks.github.io/pinocchio/","size":7941,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":30,"forks":15,"open_issues":30,"watchers":7,"default_branch":"master"}},"base":{"label":"stack-of-tasks:devel","ref":"devel","sha":"3f034aa1ff7bacdb9d3b46ee67d1a574b84838e8","user":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"repo":{"id":24897645,"name":"pinocchio","full_name":"stack-of-tasks/pinocchio","owner":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stack-of-tasks/pinocchio","description":"Dynamic computations using Spatial Algebra","fork":false,"url":"https://api.github.com/repos/stack-of-tasks/pinocchio","forks_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/forks","keys_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/teams","hooks_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/hooks","issue_events_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/events{/number}","events_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/events","assignees_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/assignees{/user}","branches_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/branches{/branch}","tags_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/tags","blobs_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/refs{/sha}","trees_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/statuses/{sha}","languages_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/languages","stargazers_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/stargazers","contributors_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/contributors","subscribers_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/subscribers","subscription_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/subscription","commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/commits{/sha}","git_commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/commits{/sha}","comments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/comments{/number}","issue_comment_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/comments{/number}","contents_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/contents/{+path}","compare_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/merges","archive_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/downloads","issues_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues{/number}","pulls_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls{/number}","milestones_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/milestones{/number}","notifications_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/labels{/name}","releases_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/releases{/id}","deployments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/deployments","created_at":"2014-10-07T15:42:51Z","updated_at":"2016-07-27T11:22:57Z","pushed_at":"2016-08-26T14:42:57Z","git_url":"git://github.com/stack-of-tasks/pinocchio.git","ssh_url":"git@github.com:stack-of-tasks/pinocchio.git","clone_url":"https://github.com/stack-of-tasks/pinocchio.git","svn_url":"https://github.com/stack-of-tasks/pinocchio","homepage":"http://stack-of-tasks.github.io/pinocchio/","size":7941,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":30,"forks":15,"open_issues":30,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302"},"html":{"href":"https://github.com/stack-of-tasks/pinocchio/pull/302"},"issue":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/302"},"comments":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/statuses/f307bdd7d88faaea2ae17815b9e3d855dc4b399f"}}}}
{"actor":{"display_login":"nmansard"}}