{"action":"created","issue":{"url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/7","repository_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/7/comments","events_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/7/events","html_url":"https://github.com/serilog/serilog-sinks-periodicbatching/issues/7","id":173853864,"number":7,"title":"PeriodicBatchingSink writes first message immediately on .NET Core.","user":{"login":"pakrym","id":1697911,"avatar_url":"https://avatars.githubusercontent.com/u/1697911?v=3","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-29T19:36:02Z","updated_at":"2016-09-04T22:23:32Z","closed_at":null,"body":"When using `PeriodicBatchingSink` on .NET Core first call to `Emit` causes immediate call to `EmitBatchAsync` with a single event passed in.\r\n\r\nWorks as expected on full framework."},"comment":{"url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/comments/244632130","html_url":"https://github.com/serilog/serilog-sinks-periodicbatching/issues/7#issuecomment-244632130","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/7","id":244632130,"user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"created_at":"2016-09-04T22:23:32Z","updated_at":"2016-09-04T22:23:32Z","body":"Thanks for the follow up. This'll be because of the implementation differences of the timers on the two platforms.\r\n\r\nIdeall we'll either:\r\n\r\n 1. Use our custom `PortableTimer` on all platforms, or\r\n 2. Get `Timer.Dispose(WaitHandle)` in .NET Core (https://github.com/dotnet/corefx/issues/2942), or\r\n 3. Adopt @dsplaisted's workaround from https://github.com/Microsoft/dotnet-apiport/pull/283 and go back to `Timer` on all platforms.\r\n\r\nI'd prefer (2), since it's the best-tested code path we have right now, but unless it's \"coming soon\" we should probably reconsider (1) and (3) to get some consistency across the two runtimes. Not sure which is the safer option at this point in time."}}
{"actor":{"display_login":"nblumhardt"}}