{"action":"created","issue":{"url":"https://api.github.com/repos/hanami/hanami/issues/553","repository_url":"https://api.github.com/repos/hanami/hanami","labels_url":"https://api.github.com/repos/hanami/hanami/issues/553/labels{/name}","comments_url":"https://api.github.com/repos/hanami/hanami/issues/553/comments","events_url":"https://api.github.com/repos/hanami/hanami/issues/553/events","html_url":"https://github.com/hanami/hanami/pull/553","id":143029415,"number":553,"title":"Destroy generated route, regardless of url param","user":{"login":"cllns","id":632942,"avatar_url":"https://avatars.githubusercontent.com/u/632942?v=3","gravatar_id":"","url":"https://api.github.com/users/cllns","html_url":"https://github.com/cllns","followers_url":"https://api.github.com/users/cllns/followers","following_url":"https://api.github.com/users/cllns/following{/other_user}","gists_url":"https://api.github.com/users/cllns/gists{/gist_id}","starred_url":"https://api.github.com/users/cllns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cllns/subscriptions","organizations_url":"https://api.github.com/users/cllns/orgs","repos_url":"https://api.github.com/users/cllns/repos","events_url":"https://api.github.com/users/cllns/events{/privacy}","received_events_url":"https://api.github.com/users/cllns/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hanami/hanami/labels/fix","name":"fix","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hanami/hanami/milestones/12","html_url":"https://github.com/hanami/hanami/milestones/v0.8.0","labels_url":"https://api.github.com/repos/hanami/hanami/milestones/12/labels","id":1543738,"number":12,"title":"v0.8.0","description":"","creator":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":55,"state":"open","created_at":"2016-01-26T09:37:50Z","updated_at":"2016-05-27T09:04:38Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-03-23T17:36:24Z","updated_at":"2016-05-27T09:04:54Z","closed_at":"2016-05-27T09:04:31Z","pull_request":{"url":"https://api.github.com/repos/hanami/hanami/pulls/553","html_url":"https://github.com/hanami/hanami/pull/553","diff_url":"https://github.com/hanami/hanami/pull/553.diff","patch_url":"https://github.com/hanami/hanami/pull/553.patch"},"body":"Closes #451 .\r\n\r\nThe code that normally removes the route basically runs the generate command backwards (a.k.a. [`revoke`](https://github.com/erikhuda/thor/blob/f0c2166534e122636f5ce04d61885736ef605617/lib/thor/actions/inject_into_file.rb#L62)). In this case, we want to be more permissive, removing the route regardless of the URL.\r\n\r\nRather than monkey patching Thor, we let it do its thing, then we run a `gsub_file` to remove the offending line. \r\n\r\nI'm not sure we want to add the `@controller_and_action_name` instance variable, but it seems weird to split it to get `@controller_name` and `@action_name`, then join them back together.\r\nMaybe we want to only have`@controller_and_action_name`, and convert `controller_name` and `action_name` into methods. Happy to do that work, if it's the direction we want to go."},"comment":{"url":"https://api.github.com/repos/hanami/hanami/issues/comments/222097421","html_url":"https://github.com/hanami/hanami/pull/553#issuecomment-222097421","issue_url":"https://api.github.com/repos/hanami/hanami/issues/553","id":222097421,"user":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T09:04:54Z","updated_at":"2016-05-27T09:04:54Z","body":"This works @cllns Thank you! 👍 "}}
{"actor":{"display_login":"jodosha"}}