{"action":"created","comment":{"url":"https://api.github.com/repos/bodoni/opentype/pulls/comments/82495968","pull_request_review_id":3402538,"id":82495968,"diff_hunk":"@@ -0,0 +1,31 @@\n+//! The [glyph-definition table][1].\n+//!\n+//! [1]: https://www.microsoft.com/typography/otspec/GDEF.htm\n+\n+pub mod constants;\n+\n+use self::constants::Constants;\n+\n+table! {\n+    @position\n+    #[doc = \"The math table.\"] \n+    pub Math {","path":"src/math_table/mod.rs","position":12,"original_position":12,"commit_id":"9421ad61bc04cdd090d2bd00b903dbb45dd68693","original_commit_id":"9421ad61bc04cdd090d2bd00b903dbb45dd68693","user":{"login":"IvanUkhov","id":57440,"avatar_url":"https://avatars.githubusercontent.com/u/57440?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanUkhov","html_url":"https://github.com/IvanUkhov","followers_url":"https://api.github.com/users/IvanUkhov/followers","following_url":"https://api.github.com/users/IvanUkhov/following{/other_user}","gists_url":"https://api.github.com/users/IvanUkhov/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanUkhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanUkhov/subscriptions","organizations_url":"https://api.github.com/users/IvanUkhov/orgs","repos_url":"https://api.github.com/users/IvanUkhov/repos","events_url":"https://api.github.com/users/IvanUkhov/events{/privacy}","received_events_url":"https://api.github.com/users/IvanUkhov/received_events","type":"User","site_admin":false},"body":"Let’s call it `Mathematics`.","created_at":"2016-10-08T05:13:09Z","updated_at":"2016-10-08T05:52:13Z","html_url":"https://github.com/bodoni/opentype/pull/6#discussion_r82495968","pull_request_url":"https://api.github.com/repos/bodoni/opentype/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/bodoni/opentype/pulls/comments/82495968"},"html":{"href":"https://github.com/bodoni/opentype/pull/6#discussion_r82495968"},"pull_request":{"href":"https://api.github.com/repos/bodoni/opentype/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/bodoni/opentype/pulls/6","id":88508882,"html_url":"https://github.com/bodoni/opentype/pull/6","diff_url":"https://github.com/bodoni/opentype/pull/6.diff","patch_url":"https://github.com/bodoni/opentype/pull/6.patch","issue_url":"https://api.github.com/repos/bodoni/opentype/issues/6","number":6,"state":"open","locked":false,"title":"DO NOT MERGE - Math tables support request for comments","user":{"login":"cbreeden","id":12069845,"avatar_url":"https://avatars.githubusercontent.com/u/12069845?v=3","gravatar_id":"","url":"https://api.github.com/users/cbreeden","html_url":"https://github.com/cbreeden","followers_url":"https://api.github.com/users/cbreeden/followers","following_url":"https://api.github.com/users/cbreeden/following{/other_user}","gists_url":"https://api.github.com/users/cbreeden/gists{/gist_id}","starred_url":"https://api.github.com/users/cbreeden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbreeden/subscriptions","organizations_url":"https://api.github.com/users/cbreeden/orgs","repos_url":"https://api.github.com/users/cbreeden/repos","events_url":"https://api.github.com/users/cbreeden/events{/privacy}","received_events_url":"https://api.github.com/users/cbreeden/received_events","type":"User","site_admin":false},"body":"So I started on adding support for math tables.  I thought that maybe you could take a look and see if this is _roughly_ the right direction.\r\n\r\nOpen Questions:\r\n\r\n1. Many of the units have some kind of defined meaning.  I was hoping I could use the type system to communicate this.  For instance, using the type `DesignUnits` for design units and `Percantage` for percentage units.  These probably belong somewhere else.\r\n\r\n2. Math table support may tend to poor, even for fonts claiming to support OpenType math -- at least this is my hunch right now.  XeTeX will only take a subset of the values found in the constants table and then map them directly to their respective TeX font dimensions (in contrast to LauTeX who modified TeX's internal rendering engine to add support for additional parameters similar to the ones found in the constant table).  I suspect that some fonts may only populate the fields that XeTeX cares about.  So I question if it's worth being able to assign default values for the missing values (I think LauTeX might do something like this, I should verify).  Do you have any thoughts here?","created_at":"2016-10-07T21:12:31Z","updated_at":"2016-10-08T05:52:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad9893447f2249be371607ffd312acd04562e258","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bodoni/opentype/pulls/6/commits","review_comments_url":"https://api.github.com/repos/bodoni/opentype/pulls/6/comments","review_comment_url":"https://api.github.com/repos/bodoni/opentype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bodoni/opentype/issues/6/comments","statuses_url":"https://api.github.com/repos/bodoni/opentype/statuses/9421ad61bc04cdd090d2bd00b903dbb45dd68693","head":{"label":"cbreeden:opentype-1.8","ref":"opentype-1.8","sha":"9421ad61bc04cdd090d2bd00b903dbb45dd68693","user":{"login":"cbreeden","id":12069845,"avatar_url":"https://avatars.githubusercontent.com/u/12069845?v=3","gravatar_id":"","url":"https://api.github.com/users/cbreeden","html_url":"https://github.com/cbreeden","followers_url":"https://api.github.com/users/cbreeden/followers","following_url":"https://api.github.com/users/cbreeden/following{/other_user}","gists_url":"https://api.github.com/users/cbreeden/gists{/gist_id}","starred_url":"https://api.github.com/users/cbreeden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbreeden/subscriptions","organizations_url":"https://api.github.com/users/cbreeden/orgs","repos_url":"https://api.github.com/users/cbreeden/repos","events_url":"https://api.github.com/users/cbreeden/events{/privacy}","received_events_url":"https://api.github.com/users/cbreeden/received_events","type":"User","site_admin":false},"repo":{"id":70282415,"name":"opentype","full_name":"cbreeden/opentype","owner":{"login":"cbreeden","id":12069845,"avatar_url":"https://avatars.githubusercontent.com/u/12069845?v=3","gravatar_id":"","url":"https://api.github.com/users/cbreeden","html_url":"https://github.com/cbreeden","followers_url":"https://api.github.com/users/cbreeden/followers","following_url":"https://api.github.com/users/cbreeden/following{/other_user}","gists_url":"https://api.github.com/users/cbreeden/gists{/gist_id}","starred_url":"https://api.github.com/users/cbreeden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbreeden/subscriptions","organizations_url":"https://api.github.com/users/cbreeden/orgs","repos_url":"https://api.github.com/users/cbreeden/repos","events_url":"https://api.github.com/users/cbreeden/events{/privacy}","received_events_url":"https://api.github.com/users/cbreeden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbreeden/opentype","description":"Parser for OpenType fonts","fork":true,"url":"https://api.github.com/repos/cbreeden/opentype","forks_url":"https://api.github.com/repos/cbreeden/opentype/forks","keys_url":"https://api.github.com/repos/cbreeden/opentype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbreeden/opentype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbreeden/opentype/teams","hooks_url":"https://api.github.com/repos/cbreeden/opentype/hooks","issue_events_url":"https://api.github.com/repos/cbreeden/opentype/issues/events{/number}","events_url":"https://api.github.com/repos/cbreeden/opentype/events","assignees_url":"https://api.github.com/repos/cbreeden/opentype/assignees{/user}","branches_url":"https://api.github.com/repos/cbreeden/opentype/branches{/branch}","tags_url":"https://api.github.com/repos/cbreeden/opentype/tags","blobs_url":"https://api.github.com/repos/cbreeden/opentype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbreeden/opentype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbreeden/opentype/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbreeden/opentype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbreeden/opentype/statuses/{sha}","languages_url":"https://api.github.com/repos/cbreeden/opentype/languages","stargazers_url":"https://api.github.com/repos/cbreeden/opentype/stargazers","contributors_url":"https://api.github.com/repos/cbreeden/opentype/contributors","subscribers_url":"https://api.github.com/repos/cbreeden/opentype/subscribers","subscription_url":"https://api.github.com/repos/cbreeden/opentype/subscription","commits_url":"https://api.github.com/repos/cbreeden/opentype/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbreeden/opentype/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbreeden/opentype/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbreeden/opentype/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbreeden/opentype/contents/{+path}","compare_url":"https://api.github.com/repos/cbreeden/opentype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbreeden/opentype/merges","archive_url":"https://api.github.com/repos/cbreeden/opentype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbreeden/opentype/downloads","issues_url":"https://api.github.com/repos/cbreeden/opentype/issues{/number}","pulls_url":"https://api.github.com/repos/cbreeden/opentype/pulls{/number}","milestones_url":"https://api.github.com/repos/cbreeden/opentype/milestones{/number}","notifications_url":"https://api.github.com/repos/cbreeden/opentype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbreeden/opentype/labels{/name}","releases_url":"https://api.github.com/repos/cbreeden/opentype/releases{/id}","deployments_url":"https://api.github.com/repos/cbreeden/opentype/deployments","created_at":"2016-10-07T20:58:29Z","updated_at":"2016-10-07T20:58:30Z","pushed_at":"2016-10-07T21:02:05Z","git_url":"git://github.com/cbreeden/opentype.git","ssh_url":"git@github.com:cbreeden/opentype.git","clone_url":"https://github.com/cbreeden/opentype.git","svn_url":"https://github.com/cbreeden/opentype","homepage":"","size":2771,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bodoni:opentype-1.8","ref":"opentype-1.8","sha":"2772694f56b2458e2eaa8f9618c8759504226402","user":{"login":"bodoni","id":10583310,"avatar_url":"https://avatars.githubusercontent.com/u/10583310?v=3","gravatar_id":"","url":"https://api.github.com/users/bodoni","html_url":"https://github.com/bodoni","followers_url":"https://api.github.com/users/bodoni/followers","following_url":"https://api.github.com/users/bodoni/following{/other_user}","gists_url":"https://api.github.com/users/bodoni/gists{/gist_id}","starred_url":"https://api.github.com/users/bodoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodoni/subscriptions","organizations_url":"https://api.github.com/users/bodoni/orgs","repos_url":"https://api.github.com/users/bodoni/repos","events_url":"https://api.github.com/users/bodoni/events{/privacy}","received_events_url":"https://api.github.com/users/bodoni/received_events","type":"Organization","site_admin":false},"repo":{"id":22879790,"name":"opentype","full_name":"bodoni/opentype","owner":{"login":"bodoni","id":10583310,"avatar_url":"https://avatars.githubusercontent.com/u/10583310?v=3","gravatar_id":"","url":"https://api.github.com/users/bodoni","html_url":"https://github.com/bodoni","followers_url":"https://api.github.com/users/bodoni/followers","following_url":"https://api.github.com/users/bodoni/following{/other_user}","gists_url":"https://api.github.com/users/bodoni/gists{/gist_id}","starred_url":"https://api.github.com/users/bodoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodoni/subscriptions","organizations_url":"https://api.github.com/users/bodoni/orgs","repos_url":"https://api.github.com/users/bodoni/repos","events_url":"https://api.github.com/users/bodoni/events{/privacy}","received_events_url":"https://api.github.com/users/bodoni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bodoni/opentype","description":"Parser for OpenType fonts","fork":false,"url":"https://api.github.com/repos/bodoni/opentype","forks_url":"https://api.github.com/repos/bodoni/opentype/forks","keys_url":"https://api.github.com/repos/bodoni/opentype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bodoni/opentype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bodoni/opentype/teams","hooks_url":"https://api.github.com/repos/bodoni/opentype/hooks","issue_events_url":"https://api.github.com/repos/bodoni/opentype/issues/events{/number}","events_url":"https://api.github.com/repos/bodoni/opentype/events","assignees_url":"https://api.github.com/repos/bodoni/opentype/assignees{/user}","branches_url":"https://api.github.com/repos/bodoni/opentype/branches{/branch}","tags_url":"https://api.github.com/repos/bodoni/opentype/tags","blobs_url":"https://api.github.com/repos/bodoni/opentype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bodoni/opentype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bodoni/opentype/git/refs{/sha}","trees_url":"https://api.github.com/repos/bodoni/opentype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bodoni/opentype/statuses/{sha}","languages_url":"https://api.github.com/repos/bodoni/opentype/languages","stargazers_url":"https://api.github.com/repos/bodoni/opentype/stargazers","contributors_url":"https://api.github.com/repos/bodoni/opentype/contributors","subscribers_url":"https://api.github.com/repos/bodoni/opentype/subscribers","subscription_url":"https://api.github.com/repos/bodoni/opentype/subscription","commits_url":"https://api.github.com/repos/bodoni/opentype/commits{/sha}","git_commits_url":"https://api.github.com/repos/bodoni/opentype/git/commits{/sha}","comments_url":"https://api.github.com/repos/bodoni/opentype/comments{/number}","issue_comment_url":"https://api.github.com/repos/bodoni/opentype/issues/comments{/number}","contents_url":"https://api.github.com/repos/bodoni/opentype/contents/{+path}","compare_url":"https://api.github.com/repos/bodoni/opentype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bodoni/opentype/merges","archive_url":"https://api.github.com/repos/bodoni/opentype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bodoni/opentype/downloads","issues_url":"https://api.github.com/repos/bodoni/opentype/issues{/number}","pulls_url":"https://api.github.com/repos/bodoni/opentype/pulls{/number}","milestones_url":"https://api.github.com/repos/bodoni/opentype/milestones{/number}","notifications_url":"https://api.github.com/repos/bodoni/opentype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bodoni/opentype/labels{/name}","releases_url":"https://api.github.com/repos/bodoni/opentype/releases{/id}","deployments_url":"https://api.github.com/repos/bodoni/opentype/deployments","created_at":"2014-08-12T14:11:57Z","updated_at":"2016-10-04T02:23:50Z","pushed_at":"2016-10-07T21:12:31Z","git_url":"git://github.com/bodoni/opentype.git","ssh_url":"git@github.com:bodoni/opentype.git","clone_url":"https://github.com/bodoni/opentype.git","svn_url":"https://github.com/bodoni/opentype","homepage":"","size":1893,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bodoni/opentype/pulls/6"},"html":{"href":"https://github.com/bodoni/opentype/pull/6"},"issue":{"href":"https://api.github.com/repos/bodoni/opentype/issues/6"},"comments":{"href":"https://api.github.com/repos/bodoni/opentype/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/bodoni/opentype/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/bodoni/opentype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bodoni/opentype/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/bodoni/opentype/statuses/9421ad61bc04cdd090d2bd00b903dbb45dd68693"}}}}
{"actor":{"display_login":"IvanUkhov"}}