{"action":"created","comment":{"url":"https://api.github.com/repos/Kinto/kinto-signer/pulls/comments/61042886","id":61042886,"diff_hunk":"@@ -12,10 +16,11 @@ def heartbeat(request):\n     signer = request.registry.signer\n     try:\n         result = signer.sign(\"TEST\")\n-        expected = set([\"signature\", \"hash_algorithm\", \"signature_encoding\"])\n-        if len(expected.intersection(result.keys())) != 3:\n+        expected = set(EXPECTED_FIELDS)\n+        if len(expected.intersection(result.keys())) != len(EXPECTED_FIELDS):\n             raise ValueError(\"Invalid response content: %s\" % result)\n         return True\n     except Exception as e:\n+        print(e)","path":"kinto_signer/signer/__init__.py","position":22,"original_position":22,"commit_id":"147b32909fbc091369afef375c7fbfbe58b2624e","original_commit_id":"147b32909fbc091369afef375c7fbfbe58b2624e","user":{"login":"Natim","id":229453,"avatar_url":"https://avatars.githubusercontent.com/u/229453?v=3","gravatar_id":"","url":"https://api.github.com/users/Natim","html_url":"https://github.com/Natim","followers_url":"https://api.github.com/users/Natim/followers","following_url":"https://api.github.com/users/Natim/following{/other_user}","gists_url":"https://api.github.com/users/Natim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natim/subscriptions","organizations_url":"https://api.github.com/users/Natim/orgs","repos_url":"https://api.github.com/users/Natim/repos","events_url":"https://api.github.com/users/Natim/events{/privacy}","received_events_url":"https://api.github.com/users/Natim/received_events","type":"User","site_admin":false},"body":"nit: remove the print since it is logged.","created_at":"2016-04-26T08:01:00Z","updated_at":"2016-04-26T08:01:00Z","html_url":"https://github.com/Kinto/kinto-signer/pull/66#discussion_r61042886","pull_request_url":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto-signer/pulls/comments/61042886"},"html":{"href":"https://github.com/Kinto/kinto-signer/pull/66#discussion_r61042886"},"pull_request":{"href":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66","id":67841760,"html_url":"https://github.com/Kinto/kinto-signer/pull/66","diff_url":"https://github.com/Kinto/kinto-signer/pull/66.diff","patch_url":"https://github.com/Kinto/kinto-signer/pull/66.patch","issue_url":"https://api.github.com/repos/Kinto/kinto-signer/issues/66","number":66,"state":"open","locked":false,"title":"Use Content-Signature protocol from Autograph","user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"body":"Changes had to made to kinto-signer in order to get it work with the verifier in PSM\r\n\r\n/cc @mozmark and @franziskuskiefer \r\n\r\nr? @Natim ","created_at":"2016-04-26T07:59:01Z","updated_at":"2016-04-26T08:01:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b56051169305771e4f6dd2251458b5bc5d5227bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66/commits","review_comments_url":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66/comments","review_comment_url":"https://api.github.com/repos/Kinto/kinto-signer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinto/kinto-signer/issues/66/comments","statuses_url":"https://api.github.com/repos/Kinto/kinto-signer/statuses/147b32909fbc091369afef375c7fbfbe58b2624e","head":{"label":"Kinto:content-signature","ref":"content-signature","sha":"147b32909fbc091369afef375c7fbfbe58b2624e","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":42935019,"name":"kinto-signer","full_name":"Kinto/kinto-signer","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/kinto-signer","description":"Update a signed kinto instance with new records","fork":false,"url":"https://api.github.com/repos/Kinto/kinto-signer","forks_url":"https://api.github.com/repos/Kinto/kinto-signer/forks","keys_url":"https://api.github.com/repos/Kinto/kinto-signer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/kinto-signer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/kinto-signer/teams","hooks_url":"https://api.github.com/repos/Kinto/kinto-signer/hooks","issue_events_url":"https://api.github.com/repos/Kinto/kinto-signer/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/kinto-signer/events","assignees_url":"https://api.github.com/repos/Kinto/kinto-signer/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/kinto-signer/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/kinto-signer/tags","blobs_url":"https://api.github.com/repos/Kinto/kinto-signer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/kinto-signer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/kinto-signer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/kinto-signer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/kinto-signer/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/kinto-signer/languages","stargazers_url":"https://api.github.com/repos/Kinto/kinto-signer/stargazers","contributors_url":"https://api.github.com/repos/Kinto/kinto-signer/contributors","subscribers_url":"https://api.github.com/repos/Kinto/kinto-signer/subscribers","subscription_url":"https://api.github.com/repos/Kinto/kinto-signer/subscription","commits_url":"https://api.github.com/repos/Kinto/kinto-signer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/kinto-signer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/kinto-signer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/kinto-signer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/kinto-signer/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/kinto-signer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/kinto-signer/merges","archive_url":"https://api.github.com/repos/Kinto/kinto-signer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/kinto-signer/downloads","issues_url":"https://api.github.com/repos/Kinto/kinto-signer/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/kinto-signer/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/kinto-signer/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/kinto-signer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/kinto-signer/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/kinto-signer/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/kinto-signer/deployments","created_at":"2015-09-22T13:21:26Z","updated_at":"2016-04-15T13:49:53Z","pushed_at":"2016-04-26T07:59:01Z","git_url":"git://github.com/Kinto/kinto-signer.git","ssh_url":"git@github.com:Kinto/kinto-signer.git","clone_url":"https://github.com/Kinto/kinto-signer.git","svn_url":"https://github.com/Kinto/kinto-signer","homepage":"","size":196,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"Kinto:master","ref":"master","sha":"653bf4e80bbc4fab27c5be269bf72cf787db2036","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":42935019,"name":"kinto-signer","full_name":"Kinto/kinto-signer","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/kinto-signer","description":"Update a signed kinto instance with new records","fork":false,"url":"https://api.github.com/repos/Kinto/kinto-signer","forks_url":"https://api.github.com/repos/Kinto/kinto-signer/forks","keys_url":"https://api.github.com/repos/Kinto/kinto-signer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/kinto-signer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/kinto-signer/teams","hooks_url":"https://api.github.com/repos/Kinto/kinto-signer/hooks","issue_events_url":"https://api.github.com/repos/Kinto/kinto-signer/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/kinto-signer/events","assignees_url":"https://api.github.com/repos/Kinto/kinto-signer/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/kinto-signer/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/kinto-signer/tags","blobs_url":"https://api.github.com/repos/Kinto/kinto-signer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/kinto-signer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/kinto-signer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/kinto-signer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/kinto-signer/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/kinto-signer/languages","stargazers_url":"https://api.github.com/repos/Kinto/kinto-signer/stargazers","contributors_url":"https://api.github.com/repos/Kinto/kinto-signer/contributors","subscribers_url":"https://api.github.com/repos/Kinto/kinto-signer/subscribers","subscription_url":"https://api.github.com/repos/Kinto/kinto-signer/subscription","commits_url":"https://api.github.com/repos/Kinto/kinto-signer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/kinto-signer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/kinto-signer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/kinto-signer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/kinto-signer/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/kinto-signer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/kinto-signer/merges","archive_url":"https://api.github.com/repos/Kinto/kinto-signer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/kinto-signer/downloads","issues_url":"https://api.github.com/repos/Kinto/kinto-signer/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/kinto-signer/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/kinto-signer/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/kinto-signer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/kinto-signer/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/kinto-signer/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/kinto-signer/deployments","created_at":"2015-09-22T13:21:26Z","updated_at":"2016-04-15T13:49:53Z","pushed_at":"2016-04-26T07:59:01Z","git_url":"git://github.com/Kinto/kinto-signer.git","ssh_url":"git@github.com:Kinto/kinto-signer.git","clone_url":"https://github.com/Kinto/kinto-signer.git","svn_url":"https://github.com/Kinto/kinto-signer","homepage":"","size":196,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66"},"html":{"href":"https://github.com/Kinto/kinto-signer/pull/66"},"issue":{"href":"https://api.github.com/repos/Kinto/kinto-signer/issues/66"},"comments":{"href":"https://api.github.com/repos/Kinto/kinto-signer/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinto/kinto-signer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinto/kinto-signer/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/Kinto/kinto-signer/statuses/147b32909fbc091369afef375c7fbfbe58b2624e"}}}}