{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9630","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9630/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9630/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9630/events","html_url":"https://github.com/nodejs/node/pull/9630","id":189559538,"number":9630,"title":"inspector: split HTTP/WS server from the inspector","user":{"login":"eugeneo","id":287917,"avatar_url":"https://avatars.githubusercontent.com/u/287917?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneo","html_url":"https://github.com/eugeneo","followers_url":"https://api.github.com/users/eugeneo/followers","following_url":"https://api.github.com/users/eugeneo/following{/other_user}","gists_url":"https://api.github.com/users/eugeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneo/subscriptions","organizations_url":"https://api.github.com/users/eugeneo/orgs","repos_url":"https://api.github.com/users/eugeneo/repos","events_url":"https://api.github.com/users/eugeneo/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneo/received_events","type":"User","site_admin":false},"labels":[{"id":171787391,"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21","default":false},{"id":444372954,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v7.x","name":"dont-land-on-v7.x","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-16T01:47:39Z","updated_at":"2016-11-22T22:33:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9630","html_url":"https://github.com/nodejs/node/pull/9630","diff_url":"https://github.com/nodejs/node/pull/9630.diff","patch_url":"https://github.com/nodejs/node/pull/9630.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ninspector: HTTP server code was reworked and moved to a new file. No impact if the inspector is not started.\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nBoth our team experiments and some embedder request indicate a potential\r\nin implementing alternative transport for inspector - e.g. IPC pipes or\r\ncustom embedder APIs. This change moves all HTTP specific code into a\r\nseparate class and is a first attempt at defining a boundary between the\r\ninspector agent and transport. This API will be refined as new\r\ntransports are implemented.\r\nNote that even without considering alternative transports, this change\r\nenables better testing of the HTTP server (Valgrind it possible to identify\r\nand fix some existing memory leaks).\r\n\r\nCC: @ofrobots "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/262386219","html_url":"https://github.com/nodejs/node/pull/9630#issuecomment-262386219","issue_url":"https://api.github.com/repos/nodejs/node/issues/9630","id":262386219,"user":{"login":"eugeneo","id":287917,"avatar_url":"https://avatars.githubusercontent.com/u/287917?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneo","html_url":"https://github.com/eugeneo","followers_url":"https://api.github.com/users/eugeneo/followers","following_url":"https://api.github.com/users/eugeneo/following{/other_user}","gists_url":"https://api.github.com/users/eugeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneo/subscriptions","organizations_url":"https://api.github.com/users/eugeneo/orgs","repos_url":"https://api.github.com/users/eugeneo/repos","events_url":"https://api.github.com/users/eugeneo/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneo/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T22:33:36Z","updated_at":"2016-11-22T22:33:36Z","body":"PR had been reworked, please review. I replaced the Session object with an integer session_id, it simplified the API."}}
{"actor":{"display_login":"eugeneo"}}