{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/80762474","pull_request_review_id":1795288,"id":80762474,"diff_hunk":"@@ -5,6 +5,69 @@ information on the list of deprecated flags and APIs please have a look at\n https://docs.docker.com/engine/deprecated/ where target removal dates can also\n be found.\n \n+## 1.12.2-rc1 (2016-09-27)\n+\n+**IMPORTANT**: Docker 1.12 ships with an updated systemd unit file for rpm\n+based installs (which includes RHEL, Fedora, CentOS, and Oracle Linux 7). When\n+upgrading from an older version of docker, the upgrade process may not\n+automatically install the updated version of the unit file, or fail to start\n+the docker service if;\n+\n+- the systemd unit file (`/usr/lib/systemd/system/docker.service`) contains local changes, or\n+- a systemd drop-in file is present, and contains `-H fd://` in the `ExecStart` directive\n+\n+Starting the docker service will produce an error:\n+\n+    Failed to start docker.service: Unit docker.socket failed to load: No such file or directory.\n+\n+or\n+\n+    no sockets found via socket activation: make sure the service was started by systemd.\n+\n+To resolve this:\n+\n+- Backup the current version of the unit file, and replace the file with the\n+  [version that ships with docker 1.12](https://raw.githubusercontent.com/docker/docker/v1.12.0/contrib/init/systemd/docker.service.rpm)\n+- Remove the `Requires=docker.socket` directive from the `/usr/lib/systemd/system/docker.service` file if present\n+- Remove `-H fd://` from the `ExecStart` directive (both in the main unit file, and in any drop-in files present).\n+\n+After making those changes, run `sudo systemctl daemon-reload`, and `sudo\n+systemctl restart docker` to reload changes and (re)start the docker daemon.\n+\n+\n+### Runtime\n+\n+- Fix a panic due to a race condition filtering `docker ps` [#26049](https://github.com/docker/docker/pull/26049)\n+* Implement retry logic to prevent \"Unable to remove filesystem\" errors when using the aufs storage driver [#26536](https://github.com/docker/docker/pull/26536)\n+* Prevent devicemapper from removing device symlinks if `dm.use_deferred_removal` is enabled [#24740](https://github.com/docker/docker/pull/24740)\n+- Fix an issue where the CLI did not return correct exit codes if a command was run with invalid options [#26777](https://github.com/docker/docker/pull/26777)\n+- Fix a panic due to a bug in stdout / stderr processing in health checks [#26507](https://github.com/docker/docker/pull/26507)\n+- Fix exec's children handling [#26874](https://github.com/docker/docker/pull/26874)\n+- Fix exec form of HEALTHCHECK CMD [#26208](https://github.com/docker/docker/pull/26208)\n+\n+### Networking\n+* Vendor libnetwork [#26879](https://github.com/docker/docker/pull/26879) [#26953](https://github.com/docker/docker/pull/26953)\n+ * Avoid returning early on agent join failures [docker/libnetwork#1473](https://github.com/docker/libnetwork/pull/1473)\n+\n+### Swarm Mode\n+\n+* Do not autodetect advertise address on join [#26211](https://github.com/docker/docker/pull/26211)","path":"CHANGELOG.md","position":null,"original_position":50,"commit_id":"361e65bbd08a5685c5819265c3427058715749a9","original_commit_id":"4513467911a8b84bc74b64f425108514c2d505cf","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"no worries, I just pushed with this.","created_at":"2016-09-27T18:28:20Z","updated_at":"2016-09-27T18:28:20Z","html_url":"https://github.com/docker/docker/pull/26956#discussion_r80762474","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/26956","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/80762474"},"html":{"href":"https://github.com/docker/docker/pull/26956#discussion_r80762474"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/26956"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/26956","id":86972249,"html_url":"https://github.com/docker/docker/pull/26956","diff_url":"https://github.com/docker/docker/pull/26956.diff","patch_url":"https://github.com/docker/docker/pull/26956.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/26956","number":26956,"state":"open","locked":false,"title":"Update CHANGELOG for 1.12.2","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Victor Vieux <vieux@docker.com>","created_at":"2016-09-27T17:10:38Z","updated_at":"2016-09-27T18:28:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f8eddf157727a3ec8f586e1038a769b22897e59","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/58","html_url":"https://github.com/docker/docker/milestones/1.12.2","labels_url":"https://api.github.com/repos/docker/docker/milestones/58/labels","id":1973095,"number":58,"title":"1.12.2","description":"","creator":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":72,"state":"open","created_at":"2016-08-30T16:26:40Z","updated_at":"2016-09-27T17:11:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/26956/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/26956/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/26956/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/361e65bbd08a5685c5819265c3427058715749a9","head":{"label":"vieux:changelog-1.12.2","ref":"changelog-1.12.2","sha":"361e65bbd08a5685c5819265c3427058715749a9","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"repo":{"id":9343231,"name":"docker","full_name":"vieux/docker","owner":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vieux/docker","description":"Docker - the Linux container runtime","fork":true,"url":"https://api.github.com/repos/vieux/docker","forks_url":"https://api.github.com/repos/vieux/docker/forks","keys_url":"https://api.github.com/repos/vieux/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vieux/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vieux/docker/teams","hooks_url":"https://api.github.com/repos/vieux/docker/hooks","issue_events_url":"https://api.github.com/repos/vieux/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vieux/docker/events","assignees_url":"https://api.github.com/repos/vieux/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vieux/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vieux/docker/tags","blobs_url":"https://api.github.com/repos/vieux/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vieux/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vieux/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vieux/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vieux/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vieux/docker/languages","stargazers_url":"https://api.github.com/repos/vieux/docker/stargazers","contributors_url":"https://api.github.com/repos/vieux/docker/contributors","subscribers_url":"https://api.github.com/repos/vieux/docker/subscribers","subscription_url":"https://api.github.com/repos/vieux/docker/subscription","commits_url":"https://api.github.com/repos/vieux/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vieux/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vieux/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vieux/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vieux/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vieux/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vieux/docker/merges","archive_url":"https://api.github.com/repos/vieux/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vieux/docker/downloads","issues_url":"https://api.github.com/repos/vieux/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vieux/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vieux/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vieux/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vieux/docker/labels{/name}","releases_url":"https://api.github.com/repos/vieux/docker/releases{/id}","deployments_url":"https://api.github.com/repos/vieux/docker/deployments","created_at":"2013-04-10T09:57:14Z","updated_at":"2014-07-24T21:22:20Z","pushed_at":"2016-09-27T18:28:13Z","git_url":"git://github.com/vieux/docker.git","ssh_url":"git@github.com:vieux/docker.git","clone_url":"https://github.com/vieux/docker.git","svn_url":"https://github.com/vieux/docker","homepage":"http://docker.io","size":105606,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:1.12.x","ref":"1.12.x","sha":"667c02ce8ca12aa273f9d036d0b6488f64109508","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-09-27T18:09:47Z","pushed_at":"2016-09-27T18:28:15Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":211215,"stargazers_count":35358,"watchers_count":35358,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10408,"mirror_url":null,"open_issues_count":1930,"forks":10408,"open_issues":1930,"watchers":35358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/26956"},"html":{"href":"https://github.com/docker/docker/pull/26956"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/26956"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/26956/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/26956/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/26956/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/361e65bbd08a5685c5819265c3427058715749a9"}}}}
{"actor":{"display_login":"vieux"}}