{"action":"closed","issue":{"url":"https://api.github.com/repos/cheezy/page-object/issues/347","labels_url":"https://api.github.com/repos/cheezy/page-object/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/cheezy/page-object/issues/347/comments","events_url":"https://api.github.com/repos/cheezy/page-object/issues/347/events","html_url":"https://github.com/cheezy/page-object/issues/347","id":124224564,"number":347,"title":"Why does wait_until use default_page_wait? Shouldn't it be default_element_wait ?","user":{"login":"tk8817","id":849320,"avatar_url":"https://avatars.githubusercontent.com/u/849320?v=3","gravatar_id":"","url":"https://api.github.com/users/tk8817","html_url":"https://github.com/tk8817","followers_url":"https://api.github.com/users/tk8817/followers","following_url":"https://api.github.com/users/tk8817/following{/other_user}","gists_url":"https://api.github.com/users/tk8817/gists{/gist_id}","starred_url":"https://api.github.com/users/tk8817/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk8817/subscriptions","organizations_url":"https://api.github.com/users/tk8817/orgs","repos_url":"https://api.github.com/users/tk8817/repos","events_url":"https://api.github.com/users/tk8817/events{/privacy}","received_events_url":"https://api.github.com/users/tk8817/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-29T15:19:52Z","updated_at":"2016-01-06T20:15:20Z","closed_at":"2016-01-06T20:15:20Z","body":"``` ruby\r\n def wait_until(timeout = PageObject.default_page_wait, message = nil, &block)\r\n    platform.wait_until(timeout, message, &block)\r\n  end\r\n```\r\n\r\nThe wait_until method in page-object.rb takes 'default_page_wait' as the default timeout when an explicit value is not passed. I would expect it to be default_element_wait instead. \r\n\r\n``` ruby\r\n#example setup of values\r\nPageObject.default_element_wait = 20\r\nPageObject.default_page_wait = 60\r\n```\r\nWould I be incorrect to think that wait_until is more commonly used for elements than pages, especially seeing as a wait_until should not be reached until a page has fully loaded. "}}