{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81546763","pull_request_review_id":2518410,"id":81546763,"diff_hunk":"@@ -50,6 +50,8 @@ type Config struct {\n \t// be appended to all request URIs used to access the apiserver. This allows a frontend\n \t// proxy to easily relocate all of the apiserver endpoints.\n \tHost string\n+\t// UnixSocket is a path to the unix socket that the (proxy) apiserver is listening on.\n+\tUnixSocket string","path":"pkg/client/restclient/config.go","position":null,"original_position":5,"commit_id":"50abc512c360b8ad2fe41bcc7901e6febb63662b","original_commit_id":"1688a2a6e447635a9deb38380c75e112bf5750d0","user":{"login":"nhlfr","id":1553979,"avatar_url":"https://avatars.githubusercontent.com/u/1553979?v=3","gravatar_id":"","url":"https://api.github.com/users/nhlfr","html_url":"https://github.com/nhlfr","followers_url":"https://api.github.com/users/nhlfr/followers","following_url":"https://api.github.com/users/nhlfr/following{/other_user}","gists_url":"https://api.github.com/users/nhlfr/gists{/gist_id}","starred_url":"https://api.github.com/users/nhlfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhlfr/subscriptions","organizations_url":"https://api.github.com/users/nhlfr/orgs","repos_url":"https://api.github.com/users/nhlfr/repos","events_url":"https://api.github.com/users/nhlfr/events{/privacy}","received_events_url":"https://api.github.com/users/nhlfr/received_events","type":"User","site_admin":false},"body":"OK, done.","created_at":"2016-10-03T13:12:32Z","updated_at":"2016-10-03T13:12:33Z","html_url":"https://github.com/kubernetes/kubernetes/pull/33659#discussion_r81546763","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81546763"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33659#discussion_r81546763"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659","id":87122468,"html_url":"https://github.com/kubernetes/kubernetes/pull/33659","diff_url":"https://github.com/kubernetes/kubernetes/pull/33659.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33659.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33659","number":33659,"state":"open","locked":false,"title":"Support for unix sockets in RESTClient and its transport","user":{"login":"nhlfr","id":1553979,"avatar_url":"https://avatars.githubusercontent.com/u/1553979?v=3","gravatar_id":"","url":"https://api.github.com/users/nhlfr","html_url":"https://github.com/nhlfr","followers_url":"https://api.github.com/users/nhlfr/followers","following_url":"https://api.github.com/users/nhlfr/following{/other_user}","gists_url":"https://api.github.com/users/nhlfr/gists{/gist_id}","starred_url":"https://api.github.com/users/nhlfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhlfr/subscriptions","organizations_url":"https://api.github.com/users/nhlfr/orgs","repos_url":"https://api.github.com/users/nhlfr/repos","events_url":"https://api.github.com/users/nhlfr/events{/privacy}","received_events_url":"https://api.github.com/users/nhlfr/received_events","type":"User","site_admin":false},"body":"Introduce a config attribute UnixSocket to both RESTClient config and transport config. That setting may be used later by kubectl/cmd/factory for using unix sockets by cli.\r\n\r\nFixes #33657\r\nRef #31178\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33659)\n<!-- Reviewable:end -->\n","created_at":"2016-09-28T13:43:14Z","updated_at":"2016-10-03T13:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2bb1ede14f3b57d850af38d0152844f58319e14","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33659/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/50abc512c360b8ad2fe41bcc7901e6febb63662b","head":{"label":"nhlfr:restclient-unix-socket","ref":"restclient-unix-socket","sha":"50abc512c360b8ad2fe41bcc7901e6febb63662b","user":{"login":"nhlfr","id":1553979,"avatar_url":"https://avatars.githubusercontent.com/u/1553979?v=3","gravatar_id":"","url":"https://api.github.com/users/nhlfr","html_url":"https://github.com/nhlfr","followers_url":"https://api.github.com/users/nhlfr/followers","following_url":"https://api.github.com/users/nhlfr/following{/other_user}","gists_url":"https://api.github.com/users/nhlfr/gists{/gist_id}","starred_url":"https://api.github.com/users/nhlfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhlfr/subscriptions","organizations_url":"https://api.github.com/users/nhlfr/orgs","repos_url":"https://api.github.com/users/nhlfr/repos","events_url":"https://api.github.com/users/nhlfr/events{/privacy}","received_events_url":"https://api.github.com/users/nhlfr/received_events","type":"User","site_admin":false},"repo":{"id":58543101,"name":"kubernetes","full_name":"nhlfr/kubernetes","owner":{"login":"nhlfr","id":1553979,"avatar_url":"https://avatars.githubusercontent.com/u/1553979?v=3","gravatar_id":"","url":"https://api.github.com/users/nhlfr","html_url":"https://github.com/nhlfr","followers_url":"https://api.github.com/users/nhlfr/followers","following_url":"https://api.github.com/users/nhlfr/following{/other_user}","gists_url":"https://api.github.com/users/nhlfr/gists{/gist_id}","starred_url":"https://api.github.com/users/nhlfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhlfr/subscriptions","organizations_url":"https://api.github.com/users/nhlfr/orgs","repos_url":"https://api.github.com/users/nhlfr/repos","events_url":"https://api.github.com/users/nhlfr/events{/privacy}","received_events_url":"https://api.github.com/users/nhlfr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nhlfr/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/nhlfr/kubernetes","forks_url":"https://api.github.com/repos/nhlfr/kubernetes/forks","keys_url":"https://api.github.com/repos/nhlfr/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhlfr/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhlfr/kubernetes/teams","hooks_url":"https://api.github.com/repos/nhlfr/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/nhlfr/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/nhlfr/kubernetes/events","assignees_url":"https://api.github.com/repos/nhlfr/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/nhlfr/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/nhlfr/kubernetes/tags","blobs_url":"https://api.github.com/repos/nhlfr/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhlfr/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhlfr/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhlfr/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhlfr/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/nhlfr/kubernetes/languages","stargazers_url":"https://api.github.com/repos/nhlfr/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/nhlfr/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/nhlfr/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/nhlfr/kubernetes/subscription","commits_url":"https://api.github.com/repos/nhlfr/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhlfr/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhlfr/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhlfr/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhlfr/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/nhlfr/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhlfr/kubernetes/merges","archive_url":"https://api.github.com/repos/nhlfr/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhlfr/kubernetes/downloads","issues_url":"https://api.github.com/repos/nhlfr/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/nhlfr/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/nhlfr/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/nhlfr/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhlfr/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/nhlfr/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/nhlfr/kubernetes/deployments","created_at":"2016-05-11T12:30:50Z","updated_at":"2016-05-11T12:31:04Z","pushed_at":"2016-10-03T13:11:28Z","git_url":"git://github.com/nhlfr/kubernetes.git","ssh_url":"git@github.com:nhlfr/kubernetes.git","clone_url":"https://github.com/nhlfr/kubernetes.git","svn_url":"https://github.com/nhlfr/kubernetes","homepage":"http://kubernetes.io","size":329118,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"64d2b12d2118a6fd8e57639981208f2e99ca80df","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-10-03T13:02:31Z","pushed_at":"2016-10-03T13:11:33Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":574936,"stargazers_count":17274,"watchers_count":17274,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5601,"mirror_url":null,"open_issues_count":4749,"forks":5601,"open_issues":4749,"watchers":17274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33659"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33659"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33659/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33659/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/50abc512c360b8ad2fe41bcc7901e6febb63662b"}}}}
{"actor":{"display_login":"nhlfr"}}