{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726","repository_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726","id":193946682,"number":4726,"title":"More concise parameter validation","user":{"login":"erikmaarten","id":4586719,"avatar_url":"https://avatars.githubusercontent.com/u/4586719?v=3","gravatar_id":"","url":"https://api.github.com/users/erikmaarten","html_url":"https://github.com/erikmaarten","followers_url":"https://api.github.com/users/erikmaarten/followers","following_url":"https://api.github.com/users/erikmaarten/following{/other_user}","gists_url":"https://api.github.com/users/erikmaarten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmaarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmaarten/subscriptions","organizations_url":"https://api.github.com/users/erikmaarten/orgs","repos_url":"https://api.github.com/users/erikmaarten/repos","events_url":"https://api.github.com/users/erikmaarten/events{/privacy}","received_events_url":"https://api.github.com/users/erikmaarten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-07T03:08:12Z","updated_at":"2016-12-13T14:32:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726.patch"},"body":"This PR introduces a module that exposes a `check` module that is useful mostly to check that function parameters have the correct type and shape.\r\n\r\nCurrently supported\r\n- Primitive types\r\n- Arrays\r\n- Numeric checks: min, max and minMax\r\n\r\nTo show how this will work, I've changed most parameter checks in `Cartesian3` to use `check`."},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/266753202","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726#issuecomment-266753202","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726","id":266753202,"user":{"login":"erikmaarten","id":4586719,"avatar_url":"https://avatars.githubusercontent.com/u/4586719?v=3","gravatar_id":"","url":"https://api.github.com/users/erikmaarten","html_url":"https://github.com/erikmaarten","followers_url":"https://api.github.com/users/erikmaarten/followers","following_url":"https://api.github.com/users/erikmaarten/following{/other_user}","gists_url":"https://api.github.com/users/erikmaarten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmaarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmaarten/subscriptions","organizations_url":"https://api.github.com/users/erikmaarten/orgs","repos_url":"https://api.github.com/users/erikmaarten/repos","events_url":"https://api.github.com/users/erikmaarten/events{/privacy}","received_events_url":"https://api.github.com/users/erikmaarten/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T14:32:44Z","updated_at":"2016-12-13T14:32:44Z","body":">  >    Perhaps we could actually make check.numeric.multiple too, if it's not too specific.\r\n\r\n>  I suspect that will hurt readable as we can't expect everyone to immediately know what all these functions do, especially new contributors making small code changes.\r\n\r\nSure. Minimum/maximum value checks are used in many places, and I'll let the range check (minimum _and_ maximum) stay too. With these plus `defined` and type checks we'll probably have most needs covered. "}}
{"actor":{"display_login":"erikmaarten"}}