{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/comments/84138625","pull_request_review_id":4935071,"id":84138625,"diff_hunk":"@@ -520,23 +520,28 @@ stdx::optional<bsoncxx::document::value> collection::find_one_and_replace(\n     auto opts = libmongoc::find_and_modify_opts_new();\n     auto opts_cleanup = make_guard([&opts] { libmongoc::find_and_modify_opts_destroy(opts); });\n     int flags = ::MONGOC_FIND_AND_MODIFY_NONE;\n-    scoped_bson_t bson_replacement{replacement};\n-    scoped_bson_t bson_sort{options.sort()};\n-    scoped_bson_t bson_projection{options.projection()};","path":"src/mongocxx/collection.cpp","position":6,"original_position":6,"commit_id":"c1d10ba0abe7f6aed60a497aad4c18cf6a95962d","original_commit_id":"c1d10ba0abe7f6aed60a497aad4c18cf6a95962d","user":{"login":"jrassi","id":294716,"avatar_url":"https://avatars.githubusercontent.com/u/294716?v=3","gravatar_id":"","url":"https://api.github.com/users/jrassi","html_url":"https://github.com/jrassi","followers_url":"https://api.github.com/users/jrassi/followers","following_url":"https://api.github.com/users/jrassi/following{/other_user}","gists_url":"https://api.github.com/users/jrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/jrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrassi/subscriptions","organizations_url":"https://api.github.com/users/jrassi/orgs","repos_url":"https://api.github.com/users/jrassi/repos","events_url":"https://api.github.com/users/jrassi/events{/privacy}","received_events_url":"https://api.github.com/users/jrassi/received_events","type":"User","site_admin":false},"body":"Hmm, I'm having trouble understanding your position here.  If glancing at this change makes you uncertain about its correctness, then to me it doesn't seem appropriate at all to commit it as an unreviewed minor change.  Note also that this change is committed separately in this review (8c213c335a2549452e56e4171709ad4e83374870).  Perhaps let's discuss further in person.","created_at":"2016-10-19T18:39:55Z","updated_at":"2016-10-19T18:39:56Z","html_url":"https://github.com/mongodb/mongo-cxx-driver/pull/571#discussion_r84138625","pull_request_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/comments/84138625"},"html":{"href":"https://github.com/mongodb/mongo-cxx-driver/pull/571#discussion_r84138625"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571"}}},"pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571","id":89925854,"html_url":"https://github.com/mongodb/mongo-cxx-driver/pull/571","diff_url":"https://github.com/mongodb/mongo-cxx-driver/pull/571.diff","patch_url":"https://github.com/mongodb/mongo-cxx-driver/pull/571.patch","issue_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/issues/571","number":571,"state":"open","locked":false,"title":"CXX-971 (part 13) Add collation support for find_one_and_* writes","user":{"login":"jrassi","id":294716,"avatar_url":"https://avatars.githubusercontent.com/u/294716?v=3","gravatar_id":"","url":"https://api.github.com/users/jrassi","html_url":"https://github.com/jrassi","followers_url":"https://api.github.com/users/jrassi/followers","following_url":"https://api.github.com/users/jrassi/following{/other_user}","gists_url":"https://api.github.com/users/jrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/jrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrassi/subscriptions","organizations_url":"https://api.github.com/users/jrassi/orgs","repos_url":"https://api.github.com/users/jrassi/repos","events_url":"https://api.github.com/users/jrassi/events{/privacy}","received_events_url":"https://api.github.com/users/jrassi/received_events","type":"User","site_admin":false},"body":"@xdg, PTAL.\r\n\r\nOn top of #568.","created_at":"2016-10-19T01:05:26Z","updated_at":"2016-10-19T18:39:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41b1346d01ea6b4488a6b4eb0304bf52d3e3f806","assignee":{"login":"jrassi","id":294716,"avatar_url":"https://avatars.githubusercontent.com/u/294716?v=3","gravatar_id":"","url":"https://api.github.com/users/jrassi","html_url":"https://github.com/jrassi","followers_url":"https://api.github.com/users/jrassi/followers","following_url":"https://api.github.com/users/jrassi/following{/other_user}","gists_url":"https://api.github.com/users/jrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/jrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrassi/subscriptions","organizations_url":"https://api.github.com/users/jrassi/orgs","repos_url":"https://api.github.com/users/jrassi/repos","events_url":"https://api.github.com/users/jrassi/events{/privacy}","received_events_url":"https://api.github.com/users/jrassi/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrassi","id":294716,"avatar_url":"https://avatars.githubusercontent.com/u/294716?v=3","gravatar_id":"","url":"https://api.github.com/users/jrassi","html_url":"https://github.com/jrassi","followers_url":"https://api.github.com/users/jrassi/followers","following_url":"https://api.github.com/users/jrassi/following{/other_user}","gists_url":"https://api.github.com/users/jrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/jrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrassi/subscriptions","organizations_url":"https://api.github.com/users/jrassi/orgs","repos_url":"https://api.github.com/users/jrassi/repos","events_url":"https://api.github.com/users/jrassi/events{/privacy}","received_events_url":"https://api.github.com/users/jrassi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571/commits","review_comments_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571/comments","review_comment_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/issues/571/comments","statuses_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/statuses/c1d10ba0abe7f6aed60a497aad4c18cf6a95962d","head":{"label":"jrassi:CXX-971-13-fam-writes","ref":"CXX-971-13-fam-writes","sha":"c1d10ba0abe7f6aed60a497aad4c18cf6a95962d","user":{"login":"jrassi","id":294716,"avatar_url":"https://avatars.githubusercontent.com/u/294716?v=3","gravatar_id":"","url":"https://api.github.com/users/jrassi","html_url":"https://github.com/jrassi","followers_url":"https://api.github.com/users/jrassi/followers","following_url":"https://api.github.com/users/jrassi/following{/other_user}","gists_url":"https://api.github.com/users/jrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/jrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrassi/subscriptions","organizations_url":"https://api.github.com/users/jrassi/orgs","repos_url":"https://api.github.com/users/jrassi/repos","events_url":"https://api.github.com/users/jrassi/events{/privacy}","received_events_url":"https://api.github.com/users/jrassi/received_events","type":"User","site_admin":false},"repo":{"id":60628358,"name":"mongo-cxx-driver","full_name":"jrassi/mongo-cxx-driver","owner":{"login":"jrassi","id":294716,"avatar_url":"https://avatars.githubusercontent.com/u/294716?v=3","gravatar_id":"","url":"https://api.github.com/users/jrassi","html_url":"https://github.com/jrassi","followers_url":"https://api.github.com/users/jrassi/followers","following_url":"https://api.github.com/users/jrassi/following{/other_user}","gists_url":"https://api.github.com/users/jrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/jrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrassi/subscriptions","organizations_url":"https://api.github.com/users/jrassi/orgs","repos_url":"https://api.github.com/users/jrassi/repos","events_url":"https://api.github.com/users/jrassi/events{/privacy}","received_events_url":"https://api.github.com/users/jrassi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrassi/mongo-cxx-driver","description":"C++ Driver for MongoDB","fork":true,"url":"https://api.github.com/repos/jrassi/mongo-cxx-driver","forks_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/forks","keys_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/teams","hooks_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/hooks","issue_events_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/issues/events{/number}","events_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/events","assignees_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/assignees{/user}","branches_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/branches{/branch}","tags_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/tags","blobs_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/languages","stargazers_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/stargazers","contributors_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/contributors","subscribers_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/subscribers","subscription_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/subscription","commits_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/contents/{+path}","compare_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/merges","archive_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/downloads","issues_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/issues{/number}","pulls_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/labels{/name}","releases_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/releases{/id}","deployments_url":"https://api.github.com/repos/jrassi/mongo-cxx-driver/deployments","created_at":"2016-06-07T16:18:32Z","updated_at":"2016-06-07T16:18:33Z","pushed_at":"2016-10-19T18:00:42Z","git_url":"git://github.com/jrassi/mongo-cxx-driver.git","ssh_url":"git@github.com:jrassi/mongo-cxx-driver.git","clone_url":"https://github.com/jrassi/mongo-cxx-driver.git","svn_url":"https://github.com/jrassi/mongo-cxx-driver","homepage":null,"size":8324,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:jrassi/CXX-971-collation-feature-4","ref":"jrassi/CXX-971-collation-feature-4","sha":"92c2a680a83be1b78748eccce70e5b2660877c89","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?v=3","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":15881868,"name":"mongo-cxx-driver","full_name":"mongodb/mongo-cxx-driver","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?v=3","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-cxx-driver","description":"C++ Driver for MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-cxx-driver","forks_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/deployments","created_at":"2014-01-13T21:08:36Z","updated_at":"2016-10-15T14:24:12Z","pushed_at":"2016-10-19T18:16:32Z","git_url":"git://github.com/mongodb/mongo-cxx-driver.git","ssh_url":"git@github.com:mongodb/mongo-cxx-driver.git","clone_url":"https://github.com/mongodb/mongo-cxx-driver.git","svn_url":"https://github.com/mongodb/mongo-cxx-driver","homepage":null,"size":12669,"stargazers_count":307,"watchers_count":307,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":262,"mirror_url":null,"open_issues_count":7,"forks":262,"open_issues":7,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571"},"html":{"href":"https://github.com/mongodb/mongo-cxx-driver/pull/571"},"issue":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/issues/571"},"comments":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/issues/571/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/571/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/statuses/c1d10ba0abe7f6aed60a497aad4c18cf6a95962d"}}}}
{"actor":{"display_login":"jrassi"}}