{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/4748","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/4748/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/4748/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/4748/events","html_url":"https://github.com/librenms/librenms/pull/4748","id":181826227,"number":4748,"title":"refactor: Update alert rules to generate sql query and store in db","user":{"login":"laf","id":3941142,"avatar_url":"https://avatars.githubusercontent.com/u/3941142?v=3","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/librenms/librenms/labels/Alerting","name":"Alerting","color":"ff99ff"},{"url":"https://api.github.com/repos/librenms/librenms/labels/Schema","name":"Schema","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-08T13:28:57Z","updated_at":"2016-10-11T21:32:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/4748","html_url":"https://github.com/librenms/librenms/pull/4748","diff_url":"https://github.com/librenms/librenms/pull/4748.diff","patch_url":"https://github.com/librenms/librenms/pull/4748.patch"},"body":"#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you signed the [Contributors agreement](http://docs.librenms.org/General/Contributing/)\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\nShould remain backwards compatible.\r\n\r\nRather than running GenSQL all the time for both polling and alerting we now do this when a rule is edited / added (and also daily just in case) and then store the query to be used directly. This saves us doing un-indexed queries against information_schema DB.\r\n\r\nI've put a blocker on this purely because the schema number i've used is 144 as I already have 143 out for the sensors polling and whilst people test that I don't want to cause any conflicts."},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/253053206","html_url":"https://github.com/librenms/librenms/pull/4748#issuecomment-253053206","issue_url":"https://api.github.com/repos/librenms/librenms/issues/4748","id":253053206,"user":{"login":"laf","id":3941142,"avatar_url":"https://avatars.githubusercontent.com/u/3941142?v=3","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T21:32:37Z","updated_at":"2016-10-11T21:32:37Z","body":"Update schema file number"}}
{"actor":{"display_login":"laf"}}