{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/49918089","id":49918089,"diff_hunk":"@@ -927,6 +927,13 @@ fn check_expected_errors(expected_errors: Vec<errors::ExpectedError>,\n         format!(\"{}:{}:\", testfile.display(), ee.line)\n     }).collect::<Vec<String>>();\n \n+    let (expect_help, expect_note) =\n+        expected_errors.iter()\n+                        .fold((false, false),\n+                              |(acc_help, acc_note), ee|\n+                                  (acc_help || ee.kind == \"help:\", acc_note ||","path":"src/compiletest/runtest.rs","position":8,"original_position":8,"commit_id":"08c590f375ab6b190c83fd4bdbbdc91bf7a8a3d5","original_commit_id":"08c590f375ab6b190c83fd4bdbbdc91bf7a8a3d5","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"body":"so, the logic here is that \"if there is a help, then all help must be present\", plus \"if there is a note, then all notes must be present.\"\r\n\r\nIn hindsight I had *thought* that what we were discussing was \"if there is either a help or a note, then all help and notes must be present.\"\r\n\r\nI suspect that the logic you have chosen is actually more convenient in practice than what I was expecting, but I still figured I should point it out explicitly, in case someone else was as confused as I was about the proposal.","created_at":"2016-01-15T23:32:22Z","updated_at":"2016-01-15T23:32:22Z","html_url":"https://github.com/rust-lang/rust/pull/30778#discussion_r49918089","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/30778","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/49918089"},"html":{"href":"https://github.com/rust-lang/rust/pull/30778#discussion_r49918089"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/30778"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/30778","id":55451892,"html_url":"https://github.com/rust-lang/rust/pull/30778","diff_url":"https://github.com/rust-lang/rust/pull/30778.diff","patch_url":"https://github.com/rust-lang/rust/pull/30778.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/30778","number":30778,"state":"open","locked":false,"title":"Expect all help/note messages are specified in a cfail test","user":{"login":"fhahn","id":450489,"avatar_url":"https://avatars.githubusercontent.com/u/450489?v=3","gravatar_id":"","url":"https://api.github.com/users/fhahn","html_url":"https://github.com/fhahn","followers_url":"https://api.github.com/users/fhahn/followers","following_url":"https://api.github.com/users/fhahn/following{/other_user}","gists_url":"https://api.github.com/users/fhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/fhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhahn/subscriptions","organizations_url":"https://api.github.com/users/fhahn/orgs","repos_url":"https://api.github.com/users/fhahn/repos","events_url":"https://api.github.com/users/fhahn/events{/privacy}","received_events_url":"https://api.github.com/users/fhahn/received_events","type":"User","site_admin":false},"body":"This is a PR for #21195. It changes the way unspecified `help` and `ǹote` messages are handled in compile-fail tests as suggested by @oli-obk in the issue: if there are some `note` or `help` annotations, there must be annotations for all `help` or `note` messages of this test. Maybe it makes also sense to add an option to specify that the this test should fail if there are unspecified `help` or `note` messages.\r\n\r\nWith this change, the following tests fail:\r\n\r\n    [compile-fail] compile-fail/changing-crates.rs\r\n    [compile-fail] compile-fail/default_ty_param_conflict_cross_crate.rs\r\n    [compile-fail] compile-fail/lifetime-inference-give-expl-lifetime-param.rs\r\n    [compile-fail] compile-fail/privacy1.rs\r\n    [compile-fail] compile-fail/svh-change-lit.rs\r\n    [compile-fail] compile-fail/svh-change-significant-cfg.rs\r\n    [compile-fail] compile-fail/svh-change-trait-bound.rs\r\n    [compile-fail] compile-fail/svh-change-type-arg.rs\r\n    [compile-fail] compile-fail/svh-change-type-ret.rs\r\n    [compile-fail] compile-fail/svh-change-type-static.rs\r\n    [compile-fail] compile-fail/svh-use-trait.rs\r\n\r\nI'll add the missing annotations if we decide to accept this change.","created_at":"2016-01-08T11:31:53Z","updated_at":"2016-01-15T23:32:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ac322e4d63219d2893dd727c42a930f7e51a0a","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/30778/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/30778/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/30778/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/08c590f375ab6b190c83fd4bdbbdc91bf7a8a3d5","head":{"label":"fhahn:issue-21195-expect-help","ref":"issue-21195-expect-help","sha":"08c590f375ab6b190c83fd4bdbbdc91bf7a8a3d5","user":{"login":"fhahn","id":450489,"avatar_url":"https://avatars.githubusercontent.com/u/450489?v=3","gravatar_id":"","url":"https://api.github.com/users/fhahn","html_url":"https://github.com/fhahn","followers_url":"https://api.github.com/users/fhahn/followers","following_url":"https://api.github.com/users/fhahn/following{/other_user}","gists_url":"https://api.github.com/users/fhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/fhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhahn/subscriptions","organizations_url":"https://api.github.com/users/fhahn/orgs","repos_url":"https://api.github.com/users/fhahn/repos","events_url":"https://api.github.com/users/fhahn/events{/privacy}","received_events_url":"https://api.github.com/users/fhahn/received_events","type":"User","site_admin":false},"repo":{"id":12282405,"name":"rust","full_name":"fhahn/rust","owner":{"login":"fhahn","id":450489,"avatar_url":"https://avatars.githubusercontent.com/u/450489?v=3","gravatar_id":"","url":"https://api.github.com/users/fhahn","html_url":"https://github.com/fhahn","followers_url":"https://api.github.com/users/fhahn/followers","following_url":"https://api.github.com/users/fhahn/following{/other_user}","gists_url":"https://api.github.com/users/fhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/fhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhahn/subscriptions","organizations_url":"https://api.github.com/users/fhahn/orgs","repos_url":"https://api.github.com/users/fhahn/repos","events_url":"https://api.github.com/users/fhahn/events{/privacy}","received_events_url":"https://api.github.com/users/fhahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhahn/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/fhahn/rust","forks_url":"https://api.github.com/repos/fhahn/rust/forks","keys_url":"https://api.github.com/repos/fhahn/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhahn/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhahn/rust/teams","hooks_url":"https://api.github.com/repos/fhahn/rust/hooks","issue_events_url":"https://api.github.com/repos/fhahn/rust/issues/events{/number}","events_url":"https://api.github.com/repos/fhahn/rust/events","assignees_url":"https://api.github.com/repos/fhahn/rust/assignees{/user}","branches_url":"https://api.github.com/repos/fhahn/rust/branches{/branch}","tags_url":"https://api.github.com/repos/fhahn/rust/tags","blobs_url":"https://api.github.com/repos/fhahn/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhahn/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhahn/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhahn/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhahn/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/fhahn/rust/languages","stargazers_url":"https://api.github.com/repos/fhahn/rust/stargazers","contributors_url":"https://api.github.com/repos/fhahn/rust/contributors","subscribers_url":"https://api.github.com/repos/fhahn/rust/subscribers","subscription_url":"https://api.github.com/repos/fhahn/rust/subscription","commits_url":"https://api.github.com/repos/fhahn/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhahn/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhahn/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhahn/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhahn/rust/contents/{+path}","compare_url":"https://api.github.com/repos/fhahn/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhahn/rust/merges","archive_url":"https://api.github.com/repos/fhahn/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhahn/rust/downloads","issues_url":"https://api.github.com/repos/fhahn/rust/issues{/number}","pulls_url":"https://api.github.com/repos/fhahn/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/fhahn/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/fhahn/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhahn/rust/labels{/name}","releases_url":"https://api.github.com/repos/fhahn/rust/releases{/id}","created_at":"2013-08-21T21:50:21Z","updated_at":"2015-04-23T13:36:41Z","pushed_at":"2016-01-15T21:46:13Z","git_url":"git://github.com/fhahn/rust.git","ssh_url":"git@github.com:fhahn/rust.git","clone_url":"https://github.com/fhahn/rust.git","svn_url":"https://github.com/fhahn/rust","homepage":"http://www.rust-lang.org","size":278199,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"dd51c3a7c1f69a2160da914d1f308916263b7044","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-01-15T21:59:21Z","pushed_at":"2016-01-15T23:30:23Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":466165,"stargazers_count":14919,"watchers_count":14919,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2914,"mirror_url":null,"open_issues_count":2333,"forks":2914,"open_issues":2333,"watchers":14919,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/30778"},"html":{"href":"https://github.com/rust-lang/rust/pull/30778"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/30778"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/30778/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/30778/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/30778/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/08c590f375ab6b190c83fd4bdbbdc91bf7a8a3d5"}}}}