{"action":"created","comment":{"url":"https://api.github.com/repos/DevCon0/storyboard/pulls/comments/49817737","id":49817737,"diff_hunk":"@@ -30,5 +30,16 @@ angular.module('storyBoard.authService', [])\n     });\n   };\n \n+  auth.isAuth = function () {\n+    return !!$window.localStorage.getItem('sessiontoken');\n+  };\n+\n+  auth.signout = function () {\n+    $window.localStorage.removeItem('sessiontoken');\n+    localStorage.clear();\n+    localStorageService.clearAll();","path":"client/services/authServices.js","position":19,"original_position":19,"commit_id":"0214d74ae78fdaeb4829bba17eef5fb834ca903f","original_commit_id":"0214d74ae78fdaeb4829bba17eef5fb834ca903f","user":{"login":"jd009","id":11240043,"avatar_url":"https://avatars.githubusercontent.com/u/11240043?v=3","gravatar_id":"","url":"https://api.github.com/users/jd009","html_url":"https://github.com/jd009","followers_url":"https://api.github.com/users/jd009/followers","following_url":"https://api.github.com/users/jd009/following{/other_user}","gists_url":"https://api.github.com/users/jd009/gists{/gist_id}","starred_url":"https://api.github.com/users/jd009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd009/subscriptions","organizations_url":"https://api.github.com/users/jd009/orgs","repos_url":"https://api.github.com/users/jd009/repos","events_url":"https://api.github.com/users/jd009/events{/privacy}","received_events_url":"https://api.github.com/users/jd009/received_events","type":"User","site_admin":false},"body":"There are 3 lines of code here and they are all trying to do the same thing: delete the sessiontoken.  Could you just use remoteItem to surgically remove the data of interest?  If we happen to store anything else (in addition to sessiontoken), it will be cleared by the other calls and it may not be immediately obvious.  Also, wouldn't localStorage.clear() and localStorageService.clearAll() ultimately do just about the same thing?  Anyway, I would git rid of both of them and just 'removeItem'.","created_at":"2016-01-15T03:30:23Z","updated_at":"2016-01-15T03:30:23Z","html_url":"https://github.com/DevCon0/storyboard/pull/59#discussion_r49817737","pull_request_url":"https://api.github.com/repos/DevCon0/storyboard/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/DevCon0/storyboard/pulls/comments/49817737"},"html":{"href":"https://github.com/DevCon0/storyboard/pull/59#discussion_r49817737"},"pull_request":{"href":"https://api.github.com/repos/DevCon0/storyboard/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/DevCon0/storyboard/pulls/59","id":56121499,"html_url":"https://github.com/DevCon0/storyboard/pull/59","diff_url":"https://github.com/DevCon0/storyboard/pull/59.diff","patch_url":"https://github.com/DevCon0/storyboard/pull/59.patch","issue_url":"https://api.github.com/repos/DevCon0/storyboard/issues/59","number":59,"state":"open","locked":false,"title":"Milco","user":{"login":"davidmilco","id":13225278,"avatar_url":"https://avatars.githubusercontent.com/u/13225278?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmilco","html_url":"https://github.com/davidmilco","followers_url":"https://api.github.com/users/davidmilco/followers","following_url":"https://api.github.com/users/davidmilco/following{/other_user}","gists_url":"https://api.github.com/users/davidmilco/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmilco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmilco/subscriptions","organizations_url":"https://api.github.com/users/davidmilco/orgs","repos_url":"https://api.github.com/users/davidmilco/repos","events_url":"https://api.github.com/users/davidmilco/events{/privacy}","received_events_url":"https://api.github.com/users/davidmilco/received_events","type":"User","site_admin":false},"body":"Changes to my files.  Lots of front end setup.  Should have a working nav bar with functional sign up (and probably sign in).","created_at":"2016-01-15T01:55:43Z","updated_at":"2016-01-15T03:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd4f9187543a535ad6c69c87883cb083839a131","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DevCon0/storyboard/pulls/59/commits","review_comments_url":"https://api.github.com/repos/DevCon0/storyboard/pulls/59/comments","review_comment_url":"https://api.github.com/repos/DevCon0/storyboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevCon0/storyboard/issues/59/comments","statuses_url":"https://api.github.com/repos/DevCon0/storyboard/statuses/0214d74ae78fdaeb4829bba17eef5fb834ca903f","head":{"label":"DevCon0:Milco","ref":"Milco","sha":"0214d74ae78fdaeb4829bba17eef5fb834ca903f","user":{"login":"DevCon0","id":16671161,"avatar_url":"https://avatars.githubusercontent.com/u/16671161?v=3","gravatar_id":"","url":"https://api.github.com/users/DevCon0","html_url":"https://github.com/DevCon0","followers_url":"https://api.github.com/users/DevCon0/followers","following_url":"https://api.github.com/users/DevCon0/following{/other_user}","gists_url":"https://api.github.com/users/DevCon0/gists{/gist_id}","starred_url":"https://api.github.com/users/DevCon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevCon0/subscriptions","organizations_url":"https://api.github.com/users/DevCon0/orgs","repos_url":"https://api.github.com/users/DevCon0/repos","events_url":"https://api.github.com/users/DevCon0/events{/privacy}","received_events_url":"https://api.github.com/users/DevCon0/received_events","type":"Organization","site_admin":false},"repo":{"id":49592672,"name":"storyboard","full_name":"DevCon0/storyboard","owner":{"login":"DevCon0","id":16671161,"avatar_url":"https://avatars.githubusercontent.com/u/16671161?v=3","gravatar_id":"","url":"https://api.github.com/users/DevCon0","html_url":"https://github.com/DevCon0","followers_url":"https://api.github.com/users/DevCon0/followers","following_url":"https://api.github.com/users/DevCon0/following{/other_user}","gists_url":"https://api.github.com/users/DevCon0/gists{/gist_id}","starred_url":"https://api.github.com/users/DevCon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevCon0/subscriptions","organizations_url":"https://api.github.com/users/DevCon0/orgs","repos_url":"https://api.github.com/users/DevCon0/repos","events_url":"https://api.github.com/users/DevCon0/events{/privacy}","received_events_url":"https://api.github.com/users/DevCon0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevCon0/storyboard","description":"Tell, share, and hear stories","fork":false,"url":"https://api.github.com/repos/DevCon0/storyboard","forks_url":"https://api.github.com/repos/DevCon0/storyboard/forks","keys_url":"https://api.github.com/repos/DevCon0/storyboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevCon0/storyboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevCon0/storyboard/teams","hooks_url":"https://api.github.com/repos/DevCon0/storyboard/hooks","issue_events_url":"https://api.github.com/repos/DevCon0/storyboard/issues/events{/number}","events_url":"https://api.github.com/repos/DevCon0/storyboard/events","assignees_url":"https://api.github.com/repos/DevCon0/storyboard/assignees{/user}","branches_url":"https://api.github.com/repos/DevCon0/storyboard/branches{/branch}","tags_url":"https://api.github.com/repos/DevCon0/storyboard/tags","blobs_url":"https://api.github.com/repos/DevCon0/storyboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevCon0/storyboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevCon0/storyboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevCon0/storyboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevCon0/storyboard/statuses/{sha}","languages_url":"https://api.github.com/repos/DevCon0/storyboard/languages","stargazers_url":"https://api.github.com/repos/DevCon0/storyboard/stargazers","contributors_url":"https://api.github.com/repos/DevCon0/storyboard/contributors","subscribers_url":"https://api.github.com/repos/DevCon0/storyboard/subscribers","subscription_url":"https://api.github.com/repos/DevCon0/storyboard/subscription","commits_url":"https://api.github.com/repos/DevCon0/storyboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevCon0/storyboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevCon0/storyboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevCon0/storyboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevCon0/storyboard/contents/{+path}","compare_url":"https://api.github.com/repos/DevCon0/storyboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevCon0/storyboard/merges","archive_url":"https://api.github.com/repos/DevCon0/storyboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevCon0/storyboard/downloads","issues_url":"https://api.github.com/repos/DevCon0/storyboard/issues{/number}","pulls_url":"https://api.github.com/repos/DevCon0/storyboard/pulls{/number}","milestones_url":"https://api.github.com/repos/DevCon0/storyboard/milestones{/number}","notifications_url":"https://api.github.com/repos/DevCon0/storyboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevCon0/storyboard/labels{/name}","releases_url":"https://api.github.com/repos/DevCon0/storyboard/releases{/id}","created_at":"2016-01-13T18:18:32Z","updated_at":"2016-01-14T17:04:54Z","pushed_at":"2016-01-15T02:01:24Z","git_url":"git://github.com/DevCon0/storyboard.git","ssh_url":"git@github.com:DevCon0/storyboard.git","clone_url":"https://github.com/DevCon0/storyboard.git","svn_url":"https://github.com/DevCon0/storyboard","homepage":null,"size":15011,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":38,"forks":0,"open_issues":38,"watchers":1,"default_branch":"master"}},"base":{"label":"DevCon0:master","ref":"master","sha":"7fb9e28f8c0502c417ca0d3566acfb28779e15a3","user":{"login":"DevCon0","id":16671161,"avatar_url":"https://avatars.githubusercontent.com/u/16671161?v=3","gravatar_id":"","url":"https://api.github.com/users/DevCon0","html_url":"https://github.com/DevCon0","followers_url":"https://api.github.com/users/DevCon0/followers","following_url":"https://api.github.com/users/DevCon0/following{/other_user}","gists_url":"https://api.github.com/users/DevCon0/gists{/gist_id}","starred_url":"https://api.github.com/users/DevCon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevCon0/subscriptions","organizations_url":"https://api.github.com/users/DevCon0/orgs","repos_url":"https://api.github.com/users/DevCon0/repos","events_url":"https://api.github.com/users/DevCon0/events{/privacy}","received_events_url":"https://api.github.com/users/DevCon0/received_events","type":"Organization","site_admin":false},"repo":{"id":49592672,"name":"storyboard","full_name":"DevCon0/storyboard","owner":{"login":"DevCon0","id":16671161,"avatar_url":"https://avatars.githubusercontent.com/u/16671161?v=3","gravatar_id":"","url":"https://api.github.com/users/DevCon0","html_url":"https://github.com/DevCon0","followers_url":"https://api.github.com/users/DevCon0/followers","following_url":"https://api.github.com/users/DevCon0/following{/other_user}","gists_url":"https://api.github.com/users/DevCon0/gists{/gist_id}","starred_url":"https://api.github.com/users/DevCon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevCon0/subscriptions","organizations_url":"https://api.github.com/users/DevCon0/orgs","repos_url":"https://api.github.com/users/DevCon0/repos","events_url":"https://api.github.com/users/DevCon0/events{/privacy}","received_events_url":"https://api.github.com/users/DevCon0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevCon0/storyboard","description":"Tell, share, and hear stories","fork":false,"url":"https://api.github.com/repos/DevCon0/storyboard","forks_url":"https://api.github.com/repos/DevCon0/storyboard/forks","keys_url":"https://api.github.com/repos/DevCon0/storyboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevCon0/storyboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevCon0/storyboard/teams","hooks_url":"https://api.github.com/repos/DevCon0/storyboard/hooks","issue_events_url":"https://api.github.com/repos/DevCon0/storyboard/issues/events{/number}","events_url":"https://api.github.com/repos/DevCon0/storyboard/events","assignees_url":"https://api.github.com/repos/DevCon0/storyboard/assignees{/user}","branches_url":"https://api.github.com/repos/DevCon0/storyboard/branches{/branch}","tags_url":"https://api.github.com/repos/DevCon0/storyboard/tags","blobs_url":"https://api.github.com/repos/DevCon0/storyboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevCon0/storyboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevCon0/storyboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevCon0/storyboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevCon0/storyboard/statuses/{sha}","languages_url":"https://api.github.com/repos/DevCon0/storyboard/languages","stargazers_url":"https://api.github.com/repos/DevCon0/storyboard/stargazers","contributors_url":"https://api.github.com/repos/DevCon0/storyboard/contributors","subscribers_url":"https://api.github.com/repos/DevCon0/storyboard/subscribers","subscription_url":"https://api.github.com/repos/DevCon0/storyboard/subscription","commits_url":"https://api.github.com/repos/DevCon0/storyboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevCon0/storyboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevCon0/storyboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevCon0/storyboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevCon0/storyboard/contents/{+path}","compare_url":"https://api.github.com/repos/DevCon0/storyboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevCon0/storyboard/merges","archive_url":"https://api.github.com/repos/DevCon0/storyboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevCon0/storyboard/downloads","issues_url":"https://api.github.com/repos/DevCon0/storyboard/issues{/number}","pulls_url":"https://api.github.com/repos/DevCon0/storyboard/pulls{/number}","milestones_url":"https://api.github.com/repos/DevCon0/storyboard/milestones{/number}","notifications_url":"https://api.github.com/repos/DevCon0/storyboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevCon0/storyboard/labels{/name}","releases_url":"https://api.github.com/repos/DevCon0/storyboard/releases{/id}","created_at":"2016-01-13T18:18:32Z","updated_at":"2016-01-14T17:04:54Z","pushed_at":"2016-01-15T02:01:24Z","git_url":"git://github.com/DevCon0/storyboard.git","ssh_url":"git@github.com:DevCon0/storyboard.git","clone_url":"https://github.com/DevCon0/storyboard.git","svn_url":"https://github.com/DevCon0/storyboard","homepage":null,"size":15011,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":38,"forks":0,"open_issues":38,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DevCon0/storyboard/pulls/59"},"html":{"href":"https://github.com/DevCon0/storyboard/pull/59"},"issue":{"href":"https://api.github.com/repos/DevCon0/storyboard/issues/59"},"comments":{"href":"https://api.github.com/repos/DevCon0/storyboard/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/DevCon0/storyboard/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/DevCon0/storyboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevCon0/storyboard/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/DevCon0/storyboard/statuses/0214d74ae78fdaeb4829bba17eef5fb834ca903f"}}}}