{"action":"created","issue":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2314","repository_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2314/labels{/name}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2314/comments","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2314/events","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2314","id":173875972,"number":2314,"title":"[WIP] updates to placename rendering","user":{"login":"nebulon42","id":3531092,"avatar_url":"https://avatars.githubusercontent.com/u/3531092?v=3","gravatar_id":"","url":"https://api.github.com/users/nebulon42","html_url":"https://github.com/nebulon42","followers_url":"https://api.github.com/users/nebulon42/followers","following_url":"https://api.github.com/users/nebulon42/following{/other_user}","gists_url":"https://api.github.com/users/nebulon42/gists{/gist_id}","starred_url":"https://api.github.com/users/nebulon42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebulon42/subscriptions","organizations_url":"https://api.github.com/users/nebulon42/orgs","repos_url":"https://api.github.com/users/nebulon42/repos","events_url":"https://api.github.com/users/nebulon42/events{/privacy}","received_events_url":"https://api.github.com/users/nebulon42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2016-08-29T21:22:58Z","updated_at":"2016-09-02T17:12:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2314","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2314","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2314.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2314.patch"},"body":"Fixes #1883.\r\nTries to partly fix #1391 for captial cities.\r\n\r\nThis PR leads to the following changes:\r\n* up to (excluding) z8 place names are marked with a dot, double dot for capital cities\r\n* on z4 only bigger capital cities are rendered, other place names are dropped\r\n* state labels can no longer obscure capital cities, because they got higher priority\r\n\r\nPreviews - **outdated**\r\n\r\nz3\r\n![z3](https://cloud.githubusercontent.com/assets/3531092/18067444/29c19122-6e3d-11e6-8644-037e471b27f4.png)\r\n(note that capitals do not obscure country labels, missing country labels are due to broken polygons in my snapshot)\r\n\r\nz4\r\n![z4](https://cloud.githubusercontent.com/assets/3531092/18067503/647ce4a6-6e3d-11e6-8399-3e556b277565.png)\r\n\r\nz5\r\n![z5](https://cloud.githubusercontent.com/assets/3531092/18067796/bdf5c0ec-6e3e-11e6-9718-ae269dced4a3.png)\r\n\r\nz6\r\n![z6](https://cloud.githubusercontent.com/assets/3531092/18067801/c135c43c-6e3e-11e6-9f3a-7e21331e8a16.png)\r\n\r\nz7\r\n![z7](https://cloud.githubusercontent.com/assets/3531092/18067805/c417af62-6e3e-11e6-8fb6-acebe7422227.png)\r\n\r\nz8 (here my database starts deviating from OSM production servers)\r\n![z8](https://cloud.githubusercontent.com/assets/3531092/18067809/c6fade48-6e3e-11e6-9414-58204f7ff5de.png)\r\n\r\nThis PR has still some issues:\r\n* changes of #2181 are not included since I prepared it earlier, I will fine-tune to incorporate this change if necessary\r\n* I noticed fewer place labels at z6 and will have to further investigate that\r\n* Fürth shows up instead of Nürnberg, this should not happen\r\n* If dots should be shown <= z8 or < z8 still needs to be investigated further\r\n\r\nAnother item for discussion is of course if the label placement should be NE,SE,NW or just N,S or E,W."},"comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/244434173","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2314#issuecomment-244434173","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2314","id":244434173,"user":{"login":"kocio-pl","id":5439713,"avatar_url":"https://avatars.githubusercontent.com/u/5439713?v=3","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T17:12:27Z","updated_at":"2016-09-02T17:12:27Z","body":"I understand you, I'm just not interested in checking database. My workflow is pretty simple (osm-carto-lowzoom -> import) and I hope it just works, because I'm not willing to fix boundaries. Once they are repaired (or we accept them breaking), I can make another rendering."}}
{"actor":{"display_login":"kocio-pl"}}