{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/comments/81425278","pull_request_review_id":2409118,"id":81425278,"diff_hunk":"@@ -0,0 +1,19 @@\n+class Zsdx < Formula\n+  desc \"Zelda Mystery of Solarus DX\"\n+  homepage \"http://www.solarus-games.org/games/zelda-mystery-of-solarus-dx/\"\n+  url \"https://github.com/christopho/zsdx/archive/zsdx-1.11.0.tar.gz\"\n+  sha256 \"05a5d220bbf2439c9da2e71cd9d104240878123fff5bc702e2405d6d0712f0dc\"\n+  head \"https://github.com/christopho/zsdx.git\"\n+\n+  depends_on \"cmake\" => :build\n+  depends_on \"solarus\"\n+\n+  def install\n+    system \"cmake\", \".\", *std_cmake_args, \"-DSOLARUS_INSTALL_DATADIR=#{share}\"\n+    system \"make\", \"install\"\n+  end\n+\n+  test do\n+    system \"#{Formula[\"solarus\"].bin}/solarus-run\", \"-help\"","path":"zsdx.rb","position":null,"original_position":17,"commit_id":"05ce2da30704520dfd4e0921b0b13d9d22fe19a0","original_commit_id":"fee836fdbc8a5565b88ce9a113e2cf625361cb75","user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars.githubusercontent.com/u/2618447?v=3","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"body":"Even something trivial like file existence checks would be fine here, and better than checking a different formula's functionality. For GUI programs, we're lenient about allowing trivial tests.\r\n\r\nIf there's something like a `--version` or `--info` that could be run without invoking the GUI, that would be nice too.","created_at":"2016-09-30T22:00:10Z","updated_at":"2016-09-30T22:00:10Z","html_url":"https://github.com/Homebrew/homebrew-games/pull/688#discussion_r81425278","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/comments/81425278"},"html":{"href":"https://github.com/Homebrew/homebrew-games/pull/688#discussion_r81425278"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688","id":87259155,"html_url":"https://github.com/Homebrew/homebrew-games/pull/688","diff_url":"https://github.com/Homebrew/homebrew-games/pull/688.diff","patch_url":"https://github.com/Homebrew/homebrew-games/pull/688.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-games/issues/688","number":688,"state":"open","locked":false,"title":"zsdx 1.11.0 (new formula)","user":{"login":"tomyun","id":906626,"avatar_url":"https://avatars.githubusercontent.com/u/906626?v=3","gravatar_id":"","url":"https://api.github.com/users/tomyun","html_url":"https://github.com/tomyun","followers_url":"https://api.github.com/users/tomyun/followers","following_url":"https://api.github.com/users/tomyun/following{/other_user}","gists_url":"https://api.github.com/users/tomyun/gists{/gist_id}","starred_url":"https://api.github.com/users/tomyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomyun/subscriptions","organizations_url":"https://api.github.com/users/tomyun/orgs","repos_url":"https://api.github.com/users/tomyun/repos","events_url":"https://api.github.com/users/tomyun/events{/privacy}","received_events_url":"https://api.github.com/users/tomyun/received_events","type":"User","site_admin":false},"body":"[Zelda Mystery of Solarus DX](http://www.solarus-games.org/games/zelda-mystery-of-solarus-dx/) is a Zelda fan game created with the `solarus` engine.\r\n\r\n- `SOLARUS_INSTALL_DATADIR` is set to `share`, not `pkgshare`, and it's prepended by the package name.\r\n- `test` actually tests `solarus` engine.","created_at":"2016-09-29T07:25:40Z","updated_at":"2016-09-30T22:00:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ba812605fe3dd9c366dee4a0eeab678c6929458","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-games/issues/688/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-games/statuses/05ce2da30704520dfd4e0921b0b13d9d22fe19a0","head":{"label":"tomyun:zsdx-1.11.0","ref":"zsdx-1.11.0","sha":"05ce2da30704520dfd4e0921b0b13d9d22fe19a0","user":{"login":"tomyun","id":906626,"avatar_url":"https://avatars.githubusercontent.com/u/906626?v=3","gravatar_id":"","url":"https://api.github.com/users/tomyun","html_url":"https://github.com/tomyun","followers_url":"https://api.github.com/users/tomyun/followers","following_url":"https://api.github.com/users/tomyun/following{/other_user}","gists_url":"https://api.github.com/users/tomyun/gists{/gist_id}","starred_url":"https://api.github.com/users/tomyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomyun/subscriptions","organizations_url":"https://api.github.com/users/tomyun/orgs","repos_url":"https://api.github.com/users/tomyun/repos","events_url":"https://api.github.com/users/tomyun/events{/privacy}","received_events_url":"https://api.github.com/users/tomyun/received_events","type":"User","site_admin":false},"repo":{"id":27528788,"name":"homebrew-games","full_name":"tomyun/homebrew-games","owner":{"login":"tomyun","id":906626,"avatar_url":"https://avatars.githubusercontent.com/u/906626?v=3","gravatar_id":"","url":"https://api.github.com/users/tomyun","html_url":"https://github.com/tomyun","followers_url":"https://api.github.com/users/tomyun/followers","following_url":"https://api.github.com/users/tomyun/following{/other_user}","gists_url":"https://api.github.com/users/tomyun/gists{/gist_id}","starred_url":"https://api.github.com/users/tomyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomyun/subscriptions","organizations_url":"https://api.github.com/users/tomyun/orgs","repos_url":"https://api.github.com/users/tomyun/repos","events_url":"https://api.github.com/users/tomyun/events{/privacy}","received_events_url":"https://api.github.com/users/tomyun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomyun/homebrew-games","description":"Game formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/tomyun/homebrew-games","forks_url":"https://api.github.com/repos/tomyun/homebrew-games/forks","keys_url":"https://api.github.com/repos/tomyun/homebrew-games/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomyun/homebrew-games/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomyun/homebrew-games/teams","hooks_url":"https://api.github.com/repos/tomyun/homebrew-games/hooks","issue_events_url":"https://api.github.com/repos/tomyun/homebrew-games/issues/events{/number}","events_url":"https://api.github.com/repos/tomyun/homebrew-games/events","assignees_url":"https://api.github.com/repos/tomyun/homebrew-games/assignees{/user}","branches_url":"https://api.github.com/repos/tomyun/homebrew-games/branches{/branch}","tags_url":"https://api.github.com/repos/tomyun/homebrew-games/tags","blobs_url":"https://api.github.com/repos/tomyun/homebrew-games/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomyun/homebrew-games/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomyun/homebrew-games/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomyun/homebrew-games/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomyun/homebrew-games/statuses/{sha}","languages_url":"https://api.github.com/repos/tomyun/homebrew-games/languages","stargazers_url":"https://api.github.com/repos/tomyun/homebrew-games/stargazers","contributors_url":"https://api.github.com/repos/tomyun/homebrew-games/contributors","subscribers_url":"https://api.github.com/repos/tomyun/homebrew-games/subscribers","subscription_url":"https://api.github.com/repos/tomyun/homebrew-games/subscription","commits_url":"https://api.github.com/repos/tomyun/homebrew-games/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomyun/homebrew-games/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomyun/homebrew-games/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomyun/homebrew-games/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomyun/homebrew-games/contents/{+path}","compare_url":"https://api.github.com/repos/tomyun/homebrew-games/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomyun/homebrew-games/merges","archive_url":"https://api.github.com/repos/tomyun/homebrew-games/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomyun/homebrew-games/downloads","issues_url":"https://api.github.com/repos/tomyun/homebrew-games/issues{/number}","pulls_url":"https://api.github.com/repos/tomyun/homebrew-games/pulls{/number}","milestones_url":"https://api.github.com/repos/tomyun/homebrew-games/milestones{/number}","notifications_url":"https://api.github.com/repos/tomyun/homebrew-games/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomyun/homebrew-games/labels{/name}","releases_url":"https://api.github.com/repos/tomyun/homebrew-games/releases{/id}","deployments_url":"https://api.github.com/repos/tomyun/homebrew-games/deployments","created_at":"2014-12-04T07:31:35Z","updated_at":"2015-03-02T05:04:33Z","pushed_at":"2016-09-30T21:55:08Z","git_url":"git://github.com/tomyun/homebrew-games.git","ssh_url":"git@github.com:tomyun/homebrew-games.git","clone_url":"https://github.com/tomyun/homebrew-games.git","svn_url":"https://github.com/tomyun/homebrew-games","homepage":"brew.sh","size":858,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"edbfc6e926be068a3240ed3745172bbf42614f9f","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":3629537,"name":"homebrew-games","full_name":"Homebrew/homebrew-games","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-games","description":":video_game: Games formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-games","forks_url":"https://api.github.com/repos/Homebrew/homebrew-games/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-games/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-games/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-games/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-games/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-games/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-games/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-games/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-games/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-games/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-games/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-games/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-games/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-games/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-games/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-games/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-games/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-games/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-games/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-games/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-games/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-games/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-games/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-games/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-games/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-games/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-games/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-games/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-games/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-games/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-games/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-games/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-games/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-games/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-games/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-games/deployments","created_at":"2012-03-05T17:32:42Z","updated_at":"2016-09-30T03:36:07Z","pushed_at":"2016-09-30T21:55:09Z","git_url":"git://github.com/Homebrew/homebrew-games.git","ssh_url":"git@github.com:Homebrew/homebrew-games.git","clone_url":"https://github.com/Homebrew/homebrew-games.git","svn_url":"https://github.com/Homebrew/homebrew-games","homepage":"brew.sh","size":1475,"stargazers_count":184,"watchers_count":184,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":11,"forks":148,"open_issues":11,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688"},"html":{"href":"https://github.com/Homebrew/homebrew-games/pull/688"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/issues/688"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-games/statuses/05ce2da30704520dfd4e0921b0b13d9d22fe19a0"}}}}
{"actor":{"display_login":"apjanke"}}