{"action":"created","comment":{"url":"https://api.github.com/repos/mldbai/mldb/pulls/comments/70853379","id":70853379,"diff_hunk":"@@ -2214,7 +2214,7 @@ bind(SqlBindingScope & scope) const\n     BoundFunction fn = scope.doGetFunction(tableName, functionName,\n                                            boundArgs, scope);\n     \n-    if (!fn) {\n+    if (!fn && !fn.bindBuiltinFunction) {","path":"sql/sql_expression_operations.cc","position":5,"original_position":5,"commit_id":"2b4f058615353ef3af7f773bb97259cd666ceb93","original_commit_id":"2b4f058615353ef3af7f773bb97259cd666ceb93","user":{"login":"FinchPowers","id":607566,"avatar_url":"https://avatars.githubusercontent.com/u/607566?v=3","gravatar_id":"","url":"https://api.github.com/users/FinchPowers","html_url":"https://github.com/FinchPowers","followers_url":"https://api.github.com/users/FinchPowers/followers","following_url":"https://api.github.com/users/FinchPowers/following{/other_user}","gists_url":"https://api.github.com/users/FinchPowers/gists{/gist_id}","starred_url":"https://api.github.com/users/FinchPowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinchPowers/subscriptions","organizations_url":"https://api.github.com/users/FinchPowers/orgs","repos_url":"https://api.github.com/users/FinchPowers/repos","events_url":"https://api.github.com/users/FinchPowers/events{/privacy}","received_events_url":"https://api.github.com/users/FinchPowers/received_events","type":"User","site_admin":false},"body":"If I throw if fn is false then it will never reach the bindFunction call a couples of lines lower.","created_at":"2016-07-14T18:02:46Z","updated_at":"2016-07-14T18:02:46Z","html_url":"https://github.com/mldbai/mldb/pull/525#discussion_r70853379","pull_request_url":"https://api.github.com/repos/mldbai/mldb/pulls/525","_links":{"self":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/comments/70853379"},"html":{"href":"https://github.com/mldbai/mldb/pull/525#discussion_r70853379"},"pull_request":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/mldbai/mldb/pulls/525","id":77330868,"html_url":"https://github.com/mldbai/mldb/pull/525","diff_url":"https://github.com/mldbai/mldb/pull/525.diff","patch_url":"https://github.com/mldbai/mldb/pull/525.patch","issue_url":"https://api.github.com/repos/mldbai/mldb/issues/525","number":525,"state":"open","locked":false,"title":"MLDB-1793 try builtin fct alternate impl","user":{"login":"FinchPowers","id":607566,"avatar_url":"https://avatars.githubusercontent.com/u/607566?v=3","gravatar_id":"","url":"https://api.github.com/users/FinchPowers","html_url":"https://github.com/FinchPowers","followers_url":"https://api.github.com/users/FinchPowers/followers","following_url":"https://api.github.com/users/FinchPowers/following{/other_user}","gists_url":"https://api.github.com/users/FinchPowers/gists{/gist_id}","starred_url":"https://api.github.com/users/FinchPowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinchPowers/subscriptions","organizations_url":"https://api.github.com/users/FinchPowers/orgs","repos_url":"https://api.github.com/users/FinchPowers/repos","events_url":"https://api.github.com/users/FinchPowers/events{/privacy}","received_events_url":"https://api.github.com/users/FinchPowers/received_events","type":"User","site_admin":false},"body":"@jeremybarnes Reimplementation as discussed.\r\n@mailletf We should figure out a way to put the exception message in the catch part. Maybe if in `try(expr1, expr2)` `expr2` is a NULL? But then it would be impossible to have NULL as the error value. We could also have a new construct. A new function that takes no args maybe? Something like `try(expr1, err_msg())` where `err_msg()` is, guess what, the error message.","created_at":"2016-07-13T17:41:05Z","updated_at":"2016-07-14T18:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd52baee2c66a9fa798ac298cdc788c3447a0b2f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mldbai/mldb/pulls/525/commits","review_comments_url":"https://api.github.com/repos/mldbai/mldb/pulls/525/comments","review_comment_url":"https://api.github.com/repos/mldbai/mldb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mldbai/mldb/issues/525/comments","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/2b4f058615353ef3af7f773bb97259cd666ceb93","head":{"label":"mldbai:MLDB-1793_try_builtin_alternate_impl","ref":"MLDB-1793_try_builtin_alternate_impl","sha":"2b4f058615353ef3af7f773bb97259cd666ceb93","user":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"repo":{"id":47634692,"name":"mldb","full_name":"mldbai/mldb","owner":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mldbai/mldb","description":"MLDB is the Machine Learning Database","fork":false,"url":"https://api.github.com/repos/mldbai/mldb","forks_url":"https://api.github.com/repos/mldbai/mldb/forks","keys_url":"https://api.github.com/repos/mldbai/mldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mldbai/mldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mldbai/mldb/teams","hooks_url":"https://api.github.com/repos/mldbai/mldb/hooks","issue_events_url":"https://api.github.com/repos/mldbai/mldb/issues/events{/number}","events_url":"https://api.github.com/repos/mldbai/mldb/events","assignees_url":"https://api.github.com/repos/mldbai/mldb/assignees{/user}","branches_url":"https://api.github.com/repos/mldbai/mldb/branches{/branch}","tags_url":"https://api.github.com/repos/mldbai/mldb/tags","blobs_url":"https://api.github.com/repos/mldbai/mldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mldbai/mldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mldbai/mldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mldbai/mldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/{sha}","languages_url":"https://api.github.com/repos/mldbai/mldb/languages","stargazers_url":"https://api.github.com/repos/mldbai/mldb/stargazers","contributors_url":"https://api.github.com/repos/mldbai/mldb/contributors","subscribers_url":"https://api.github.com/repos/mldbai/mldb/subscribers","subscription_url":"https://api.github.com/repos/mldbai/mldb/subscription","commits_url":"https://api.github.com/repos/mldbai/mldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mldbai/mldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mldbai/mldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mldbai/mldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mldbai/mldb/contents/{+path}","compare_url":"https://api.github.com/repos/mldbai/mldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mldbai/mldb/merges","archive_url":"https://api.github.com/repos/mldbai/mldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mldbai/mldb/downloads","issues_url":"https://api.github.com/repos/mldbai/mldb/issues{/number}","pulls_url":"https://api.github.com/repos/mldbai/mldb/pulls{/number}","milestones_url":"https://api.github.com/repos/mldbai/mldb/milestones{/number}","notifications_url":"https://api.github.com/repos/mldbai/mldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mldbai/mldb/labels{/name}","releases_url":"https://api.github.com/repos/mldbai/mldb/releases{/id}","deployments_url":"https://api.github.com/repos/mldbai/mldb/deployments","created_at":"2015-12-08T16:34:16Z","updated_at":"2016-07-13T21:26:01Z","pushed_at":"2016-07-14T17:56:06Z","git_url":"git://github.com/mldbai/mldb.git","ssh_url":"git@github.com:mldbai/mldb.git","clone_url":"https://github.com/mldbai/mldb.git","svn_url":"https://github.com/mldbai/mldb","homepage":"http://mldb.ai","size":23026,"stargazers_count":177,"watchers_count":177,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":10,"forks":12,"open_issues":10,"watchers":177,"default_branch":"master"}},"base":{"label":"mldbai:master","ref":"master","sha":"cba4f5e79efeff6455187c29dcea57c4d6f03c50","user":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"repo":{"id":47634692,"name":"mldb","full_name":"mldbai/mldb","owner":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mldbai/mldb","description":"MLDB is the Machine Learning Database","fork":false,"url":"https://api.github.com/repos/mldbai/mldb","forks_url":"https://api.github.com/repos/mldbai/mldb/forks","keys_url":"https://api.github.com/repos/mldbai/mldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mldbai/mldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mldbai/mldb/teams","hooks_url":"https://api.github.com/repos/mldbai/mldb/hooks","issue_events_url":"https://api.github.com/repos/mldbai/mldb/issues/events{/number}","events_url":"https://api.github.com/repos/mldbai/mldb/events","assignees_url":"https://api.github.com/repos/mldbai/mldb/assignees{/user}","branches_url":"https://api.github.com/repos/mldbai/mldb/branches{/branch}","tags_url":"https://api.github.com/repos/mldbai/mldb/tags","blobs_url":"https://api.github.com/repos/mldbai/mldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mldbai/mldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mldbai/mldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mldbai/mldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/{sha}","languages_url":"https://api.github.com/repos/mldbai/mldb/languages","stargazers_url":"https://api.github.com/repos/mldbai/mldb/stargazers","contributors_url":"https://api.github.com/repos/mldbai/mldb/contributors","subscribers_url":"https://api.github.com/repos/mldbai/mldb/subscribers","subscription_url":"https://api.github.com/repos/mldbai/mldb/subscription","commits_url":"https://api.github.com/repos/mldbai/mldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mldbai/mldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mldbai/mldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mldbai/mldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mldbai/mldb/contents/{+path}","compare_url":"https://api.github.com/repos/mldbai/mldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mldbai/mldb/merges","archive_url":"https://api.github.com/repos/mldbai/mldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mldbai/mldb/downloads","issues_url":"https://api.github.com/repos/mldbai/mldb/issues{/number}","pulls_url":"https://api.github.com/repos/mldbai/mldb/pulls{/number}","milestones_url":"https://api.github.com/repos/mldbai/mldb/milestones{/number}","notifications_url":"https://api.github.com/repos/mldbai/mldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mldbai/mldb/labels{/name}","releases_url":"https://api.github.com/repos/mldbai/mldb/releases{/id}","deployments_url":"https://api.github.com/repos/mldbai/mldb/deployments","created_at":"2015-12-08T16:34:16Z","updated_at":"2016-07-13T21:26:01Z","pushed_at":"2016-07-14T17:56:06Z","git_url":"git://github.com/mldbai/mldb.git","ssh_url":"git@github.com:mldbai/mldb.git","clone_url":"https://github.com/mldbai/mldb.git","svn_url":"https://github.com/mldbai/mldb","homepage":"http://mldb.ai","size":23026,"stargazers_count":177,"watchers_count":177,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":10,"forks":12,"open_issues":10,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/525"},"html":{"href":"https://github.com/mldbai/mldb/pull/525"},"issue":{"href":"https://api.github.com/repos/mldbai/mldb/issues/525"},"comments":{"href":"https://api.github.com/repos/mldbai/mldb/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/mldbai/mldb/statuses/2b4f058615353ef3af7f773bb97259cd666ceb93"}}}}
{"actor":{"display_login":"FinchPowers"}}