{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-rya/issues/99","repository_url":"https://api.github.com/repos/apache/incubator-rya","labels_url":"https://api.github.com/repos/apache/incubator-rya/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-rya/issues/99/comments","events_url":"https://api.github.com/repos/apache/incubator-rya/issues/99/events","html_url":"https://github.com/apache/incubator-rya/pull/99","id":181542129,"number":99,"title":"rya-177 WIP; indexing and mapreduce are now optional profiles in Mave…","user":{"login":"DLotts","id":6505463,"avatar_url":"https://avatars.githubusercontent.com/u/6505463?v=3","gravatar_id":"","url":"https://api.github.com/users/DLotts","html_url":"https://github.com/DLotts","followers_url":"https://api.github.com/users/DLotts/followers","following_url":"https://api.github.com/users/DLotts/following{/other_user}","gists_url":"https://api.github.com/users/DLotts/gists{/gist_id}","starred_url":"https://api.github.com/users/DLotts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DLotts/subscriptions","organizations_url":"https://api.github.com/users/DLotts/orgs","repos_url":"https://api.github.com/users/DLotts/repos","events_url":"https://api.github.com/users/DLotts/events{/privacy}","received_events_url":"https://api.github.com/users/DLotts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-06T22:32:21Z","updated_at":"2016-10-07T02:11:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-rya/pulls/99","html_url":"https://github.com/apache/incubator-rya/pull/99","diff_url":"https://github.com/apache/incubator-rya/pull/99.diff","patch_url":"https://github.com/apache/incubator-rya/pull/99.patch"},"body":"## Description\r\n>What Changed?\r\n\r\nMade indexing and mapreduce modules part of profiles that are not built unless using one of these:\r\n    mvn ... -P indexing \r\n    mvn ... -P mapreduce \r\n\r\nThe purpose is to make geotools related features optional since it has an LGPL license.\r\nAlso under RYA-177 are removing several other less difficult dependencies.\r\n\r\nTODO: remove Geo dependencies from top level POM.xml and find dependencies.  They are marked with comments.  Also remove other dependencies that have incompatible licenses.\r\n\r\n### Tests\r\n>Coverage?\r\n\r\nNo additional junit tests are needed.  A good test is to run exactly this in the project root:\r\n    mvn license:aggregate-add-third-party\r\n\r\nGeoTools should be missing.  Also look for GPL and LGPL and some other incompatible licensed libraries.  look on the rya dev list where I posted the subset of bad ones.  It subject has the wrong issue number, here it is:\r\n\r\nsubject: RYA-179 Review License / Copyright notices on Rya Artifacts\r\nfound here: https://www.mail-archive.com/dev@rya.incubator.apache.org/msg00969.html\r\n\r\n### Links\r\n[Jira](https://issues.apache.org/jira/browse/RYA-177)\r\n\r\n### Checklist\r\n- [ ] Code Review\r\n- [ ] Squash Commits\r\n\r\n#### People To Reivew\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-rya/issues/comments/252137214","html_url":"https://github.com/apache/incubator-rya/pull/99#issuecomment-252137214","issue_url":"https://api.github.com/repos/apache/incubator-rya/issues/99","id":252137214,"user":{"login":"amihalik","id":4710489,"avatar_url":"https://avatars.githubusercontent.com/u/4710489?v=3","gravatar_id":"","url":"https://api.github.com/users/amihalik","html_url":"https://github.com/amihalik","followers_url":"https://api.github.com/users/amihalik/followers","following_url":"https://api.github.com/users/amihalik/following{/other_user}","gists_url":"https://api.github.com/users/amihalik/gists{/gist_id}","starred_url":"https://api.github.com/users/amihalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amihalik/subscriptions","organizations_url":"https://api.github.com/users/amihalik/orgs","repos_url":"https://api.github.com/users/amihalik/repos","events_url":"https://api.github.com/users/amihalik/events{/privacy}","received_events_url":"https://api.github.com/users/amihalik/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T02:11:36Z","updated_at":"2016-10-07T02:11:36Z","body":"A couple things:\r\n\r\nI cannot do a `mvn clean install` .  Apache rat breaks.\r\n\r\nYou need to remove more projects including:\r\n- tinkerpop.rya\r\n- web.rya\r\n- rya.reasoning\r\n- rya.console\r\n- rya.merger\r\n\r\n\r\nAlso, I'd much rather you move all 10 of these \"optional\" project (listed below) to a top level directory named `optional`.  Have a profile in the root pom named \"build-optional\" that enables the module in the `optional` directory.\r\n\r\nTen optional projects:\r\n- mapreduce\r\n- indexing\r\n- rya.indexing.pcj\r\n- indexingExample\r\n- rya.pcj.fluo\r\n- tinkerpop.rya\r\n- web.rya\r\n- rya.reasoning\r\n- rya.console\r\n- rya.merger"}}
{"actor":{"display_login":"amihalik"}}