{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/3916","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/3916/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/3916/comments","events_url":"https://api.github.com/repos/apple/swift/issues/3916/events","html_url":"https://github.com/apple/swift/pull/3916","id":168759169,"number":3916,"title":"Enable module builds of llvm/clang by default","user":{"login":"vedantk","id":97683,"avatar_url":"https://avatars.githubusercontent.com/u/97683?v=3","gravatar_id":"","url":"https://api.github.com/users/vedantk","html_url":"https://github.com/vedantk","followers_url":"https://api.github.com/users/vedantk/followers","following_url":"https://api.github.com/users/vedantk/following{/other_user}","gists_url":"https://api.github.com/users/vedantk/gists{/gist_id}","starred_url":"https://api.github.com/users/vedantk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedantk/subscriptions","organizations_url":"https://api.github.com/users/vedantk/orgs","repos_url":"https://api.github.com/users/vedantk/repos","events_url":"https://api.github.com/users/vedantk/events{/privacy}","received_events_url":"https://api.github.com/users/vedantk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-08-01T22:42:03Z","updated_at":"2016-08-02T18:24:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3916","html_url":"https://github.com/apple/swift/pull/3916","diff_url":"https://github.com/apple/swift/pull/3916.diff","patch_url":"https://github.com/apple/swift/pull/3916.patch"},"body":"<!-- Please complete this template before creating the pull request. -->\r\n#### What's in this pull request?\r\nAdd an option to build-script-impl to enable building llvm/clang with modules. This supersedes PR 3096.\r\n\r\n#### Resolved bug number: ([SR-](https://bugs.swift.org/browse/SR-))\r\n<!-- If this pull request resolves any bugs from Swift bug tracker -->\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\nA smoke test on macOS does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library only for macOS. Simulator standard libraries and\r\n   device standard libraries are not built.\r\n3. lldb is not built.\r\n4. The test and validation-test targets are run only for macOS. The optimized\r\n   version of these tests are not run.\r\n\r\nA smoke test on Linux does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library incrementally.\r\n3. lldb is built incrementally.\r\n4. The swift test and validation-test targets are run. The optimized version of these\r\n   tests are not run.\r\n5. lldb is tested.\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/236995978","html_url":"https://github.com/apple/swift/pull/3916#issuecomment-236995978","issue_url":"https://api.github.com/repos/apple/swift/issues/3916","id":236995978,"user":{"login":"adrian-prantl","id":2251653,"avatar_url":"https://avatars.githubusercontent.com/u/2251653?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-prantl","html_url":"https://github.com/adrian-prantl","followers_url":"https://api.github.com/users/adrian-prantl/followers","following_url":"https://api.github.com/users/adrian-prantl/following{/other_user}","gists_url":"https://api.github.com/users/adrian-prantl/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-prantl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-prantl/subscriptions","organizations_url":"https://api.github.com/users/adrian-prantl/orgs","repos_url":"https://api.github.com/users/adrian-prantl/repos","events_url":"https://api.github.com/users/adrian-prantl/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-prantl/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T18:24:48Z","updated_at":"2016-08-02T18:24:48Z","body":"@gottesmm: Thanks for pointing me to the right document. According to the document test and smoke test are incremental, so we were getting lucky.\r\nThis pull request is for master-next, not for master."}}
{"actor":{"display_login":"adrian-prantl"}}