{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/12167","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/12167/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/12167/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/12167/events","html_url":"https://github.com/openshift/origin/pull/12167","id":193954117,"number":12167,"title":"Combine unique_host.go into host_admitter.go","user":{"login":"louyihua","id":1275238,"avatar_url":"https://avatars.githubusercontent.com/u/1275238?v=3","gravatar_id":"","url":"https://api.github.com/users/louyihua","html_url":"https://github.com/louyihua","followers_url":"https://api.github.com/users/louyihua/followers","following_url":"https://api.github.com/users/louyihua/following{/other_user}","gists_url":"https://api.github.com/users/louyihua/gists{/gist_id}","starred_url":"https://api.github.com/users/louyihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louyihua/subscriptions","organizations_url":"https://api.github.com/users/louyihua/orgs","repos_url":"https://api.github.com/users/louyihua/repos","events_url":"https://api.github.com/users/louyihua/events{/privacy}","received_events_url":"https://api.github.com/users/louyihua/received_events","type":"User","site_admin":false},"labels":[{"id":276708012,"url":"https://api.github.com/repos/openshift/origin/labels/needs-rebase","name":"needs-rebase","color":"cccccc","default":false},{"id":210151912,"url":"https://api.github.com/repos/openshift/origin/labels/priority/P2","name":"priority/P2","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"knobunc","id":10033853,"avatar_url":"https://avatars.githubusercontent.com/u/10033853?v=3","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false},"assignees":[{"login":"knobunc","id":10033853,"avatar_url":"https://avatars.githubusercontent.com/u/10033853?v=3","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-12-07T04:13:06Z","updated_at":"2016-12-22T10:45:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/12167","html_url":"https://github.com/openshift/origin/pull/12167","diff_url":"https://github.com/openshift/origin/pull/12167.diff","patch_url":"https://github.com/openshift/origin/pull/12167.patch"},"body":"Currently, host_admitter.go implements the function for ensuring only one route holds a (host, path) pair. So the function in unique_host.go is mainly replaced. Considering that unique_host.go contains bugs in processing route events, the other two functions of allowed namespaces & overrided hostnames are moved into host_admitter.go and unique_host.go should be deleted.\r\nNote that the tests already in host_admitter.go are enough for the 'unique host' feature, so the test invovles UniqueHost plugin can be safely removed."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/268773998","html_url":"https://github.com/openshift/origin/pull/12167#issuecomment-268773998","issue_url":"https://api.github.com/repos/openshift/origin/issues/12167","id":268773998,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T10:45:08Z","updated_at":"2016-12-22T10:45:08Z","body":"Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again"}}
{"actor":{"display_login":"openshift-bot"}}