{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/14444","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/14444/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/14444/comments","events_url":"https://api.github.com/repos/apache/spark/issues/14444/events","html_url":"https://github.com/apache/spark/pull/14444","id":168754565,"number":14444,"title":"[SPARK-16839] [SQL] redundant aliases after cleanupAliases","user":{"login":"eyalfa","id":1131833,"avatar_url":"https://avatars.githubusercontent.com/u/1131833?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalfa","html_url":"https://github.com/eyalfa","followers_url":"https://api.github.com/users/eyalfa/followers","following_url":"https://api.github.com/users/eyalfa/following{/other_user}","gists_url":"https://api.github.com/users/eyalfa/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalfa/subscriptions","organizations_url":"https://api.github.com/users/eyalfa/orgs","repos_url":"https://api.github.com/users/eyalfa/repos","events_url":"https://api.github.com/users/eyalfa/events{/privacy}","received_events_url":"https://api.github.com/users/eyalfa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-08-01T22:13:06Z","updated_at":"2016-08-04T22:37:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14444","html_url":"https://github.com/apache/spark/pull/14444","diff_url":"https://github.com/apache/spark/pull/14444.diff","patch_url":"https://github.com/apache/spark/pull/14444.patch"},"body":"## What changes were proposed in this pull request?\r\na failing test, \r\na fix that transforms CreateStruct into CreateNamedStruct\r\nand a minor modifications to test code (expect CrateNamedStruct instead of CreateStruct)\r\n\r\n## How was this patch tested?\r\nrunning the analysis suite, making sure added test initially fails, after applying suggested fix rerun the entire analysis package successfully.\r\n\r\n(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)\r\n\r\n\r\n(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/237704443","html_url":"https://github.com/apache/spark/pull/14444#issuecomment-237704443","issue_url":"https://api.github.com/repos/apache/spark/issues/14444","id":237704443,"user":{"login":"eyalfa","id":1131833,"avatar_url":"https://avatars.githubusercontent.com/u/1131833?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalfa","html_url":"https://github.com/eyalfa","followers_url":"https://api.github.com/users/eyalfa/followers","following_url":"https://api.github.com/users/eyalfa/following{/other_user}","gists_url":"https://api.github.com/users/eyalfa/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalfa/subscriptions","organizations_url":"https://api.github.com/users/eyalfa/orgs","repos_url":"https://api.github.com/users/eyalfa/repos","events_url":"https://api.github.com/users/eyalfa/events{/privacy}","received_events_url":"https://api.github.com/users/eyalfa/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T22:37:53Z","updated_at":"2016-08-04T22:37:53Z","body":"@cloud-fan this turned out to be a bit wider than I thought it is, I had to touch few areas:\r\n1. ExpressionEncoder, (seems to be your craft)\r\n2. AstBuilder, (@hvanhovell)\r\n3. CreateStruct, CreateStructUnsafe ( @rxin @yjshen @mengxr @dongjoon-hyun )\r\n4. Analyzer (added the ResolveCreateStruct rule to the resolution batch)"}}
{"actor":{"display_login":"eyalfa"}}