{"action":"opened","number":1348,"pull_request":{"url":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/1348","id":69895654,"html_url":"https://github.com/wpninjas/ninja-forms/pull/1348","diff_url":"https://github.com/wpninjas/ninja-forms/pull/1348.diff","patch_url":"https://github.com/wpninjas/ninja-forms/pull/1348.patch","issue_url":"https://api.github.com/repos/wpninjas/ninja-forms/issues/1348","number":1348,"state":"open","locked":false,"title":"Fix for ajax page replacement error and side effects","user":{"login":"saetia","id":869498,"avatar_url":"https://avatars.githubusercontent.com/u/869498?v=3","gravatar_id":"","url":"https://api.github.com/users/saetia","html_url":"https://github.com/saetia","followers_url":"https://api.github.com/users/saetia/followers","following_url":"https://api.github.com/users/saetia/following{/other_user}","gists_url":"https://api.github.com/users/saetia/gists{/gist_id}","starred_url":"https://api.github.com/users/saetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saetia/subscriptions","organizations_url":"https://api.github.com/users/saetia/orgs","repos_url":"https://api.github.com/users/saetia/repos","events_url":"https://api.github.com/users/saetia/events{/privacy}","received_events_url":"https://api.github.com/users/saetia/received_events","type":"User","site_admin":false},"body":"- Changed **init_all_the_ninja_things()** from a function expression to a declaration to avoid the call to an undefined function.\r\n- Removed the pjax:success event binding. That binds init_all_the_ninja_things() to every single page and partial replacement, which includes pages that most likely don't have contact forms. It will also cause issues for people replacing an unrelated section of the ninja form'd page and not expecting the form to reinitialize. The developer refreshing the form section with pjax will know when to call the init() function.\r\n- Removed the document.ready wrapper around the init_all_the_ninja_things() call. It shouldn't be necessary because the javascript is included in the footer after the dom is ready. This prevents the .ready binding from following along with every subsequent page load after hitting the ninja form'd page.\r\n\r\n#1323","created_at":"2016-05-12T19:47:57Z","updated_at":"2016-05-12T19:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/1348/commits","review_comments_url":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/1348/comments","review_comment_url":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpninjas/ninja-forms/issues/1348/comments","statuses_url":"https://api.github.com/repos/wpninjas/ninja-forms/statuses/c56aab845ae04a8ada070573bcfd8c9a4ac27b4a","head":{"label":"saetia:issue/1347","ref":"issue/1347","sha":"c56aab845ae04a8ada070573bcfd8c9a4ac27b4a","user":{"login":"saetia","id":869498,"avatar_url":"https://avatars.githubusercontent.com/u/869498?v=3","gravatar_id":"","url":"https://api.github.com/users/saetia","html_url":"https://github.com/saetia","followers_url":"https://api.github.com/users/saetia/followers","following_url":"https://api.github.com/users/saetia/following{/other_user}","gists_url":"https://api.github.com/users/saetia/gists{/gist_id}","starred_url":"https://api.github.com/users/saetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saetia/subscriptions","organizations_url":"https://api.github.com/users/saetia/orgs","repos_url":"https://api.github.com/users/saetia/repos","events_url":"https://api.github.com/users/saetia/events{/privacy}","received_events_url":"https://api.github.com/users/saetia/received_events","type":"User","site_admin":false},"repo":{"id":57322389,"name":"ninja-forms","full_name":"saetia/ninja-forms","owner":{"login":"saetia","id":869498,"avatar_url":"https://avatars.githubusercontent.com/u/869498?v=3","gravatar_id":"","url":"https://api.github.com/users/saetia","html_url":"https://github.com/saetia","followers_url":"https://api.github.com/users/saetia/followers","following_url":"https://api.github.com/users/saetia/following{/other_user}","gists_url":"https://api.github.com/users/saetia/gists{/gist_id}","starred_url":"https://api.github.com/users/saetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saetia/subscriptions","organizations_url":"https://api.github.com/users/saetia/orgs","repos_url":"https://api.github.com/users/saetia/repos","events_url":"https://api.github.com/users/saetia/events{/privacy}","received_events_url":"https://api.github.com/users/saetia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saetia/ninja-forms","description":"Ninja Forms is a form creation framework for WordPress.","fork":true,"url":"https://api.github.com/repos/saetia/ninja-forms","forks_url":"https://api.github.com/repos/saetia/ninja-forms/forks","keys_url":"https://api.github.com/repos/saetia/ninja-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saetia/ninja-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saetia/ninja-forms/teams","hooks_url":"https://api.github.com/repos/saetia/ninja-forms/hooks","issue_events_url":"https://api.github.com/repos/saetia/ninja-forms/issues/events{/number}","events_url":"https://api.github.com/repos/saetia/ninja-forms/events","assignees_url":"https://api.github.com/repos/saetia/ninja-forms/assignees{/user}","branches_url":"https://api.github.com/repos/saetia/ninja-forms/branches{/branch}","tags_url":"https://api.github.com/repos/saetia/ninja-forms/tags","blobs_url":"https://api.github.com/repos/saetia/ninja-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saetia/ninja-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saetia/ninja-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/saetia/ninja-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saetia/ninja-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/saetia/ninja-forms/languages","stargazers_url":"https://api.github.com/repos/saetia/ninja-forms/stargazers","contributors_url":"https://api.github.com/repos/saetia/ninja-forms/contributors","subscribers_url":"https://api.github.com/repos/saetia/ninja-forms/subscribers","subscription_url":"https://api.github.com/repos/saetia/ninja-forms/subscription","commits_url":"https://api.github.com/repos/saetia/ninja-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/saetia/ninja-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/saetia/ninja-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/saetia/ninja-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/saetia/ninja-forms/contents/{+path}","compare_url":"https://api.github.com/repos/saetia/ninja-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saetia/ninja-forms/merges","archive_url":"https://api.github.com/repos/saetia/ninja-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saetia/ninja-forms/downloads","issues_url":"https://api.github.com/repos/saetia/ninja-forms/issues{/number}","pulls_url":"https://api.github.com/repos/saetia/ninja-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/saetia/ninja-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/saetia/ninja-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saetia/ninja-forms/labels{/name}","releases_url":"https://api.github.com/repos/saetia/ninja-forms/releases{/id}","deployments_url":"https://api.github.com/repos/saetia/ninja-forms/deployments","created_at":"2016-04-28T17:46:58Z","updated_at":"2016-04-28T17:47:01Z","pushed_at":"2016-05-12T19:23:38Z","git_url":"git://github.com/saetia/ninja-forms.git","ssh_url":"git@github.com:saetia/ninja-forms.git","clone_url":"https://github.com/saetia/ninja-forms.git","svn_url":"https://github.com/saetia/ninja-forms","homepage":null,"size":20708,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpninjas:master","ref":"master","sha":"f93a26e1ab218f7dfe7a3f3f85bf8fa83fe97986","user":{"login":"wpninjas","id":4510486,"avatar_url":"https://avatars.githubusercontent.com/u/4510486?v=3","gravatar_id":"","url":"https://api.github.com/users/wpninjas","html_url":"https://github.com/wpninjas","followers_url":"https://api.github.com/users/wpninjas/followers","following_url":"https://api.github.com/users/wpninjas/following{/other_user}","gists_url":"https://api.github.com/users/wpninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/wpninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpninjas/subscriptions","organizations_url":"https://api.github.com/users/wpninjas/orgs","repos_url":"https://api.github.com/users/wpninjas/repos","events_url":"https://api.github.com/users/wpninjas/events{/privacy}","received_events_url":"https://api.github.com/users/wpninjas/received_events","type":"Organization","site_admin":false},"repo":{"id":10246127,"name":"ninja-forms","full_name":"wpninjas/ninja-forms","owner":{"login":"wpninjas","id":4510486,"avatar_url":"https://avatars.githubusercontent.com/u/4510486?v=3","gravatar_id":"","url":"https://api.github.com/users/wpninjas","html_url":"https://github.com/wpninjas","followers_url":"https://api.github.com/users/wpninjas/followers","following_url":"https://api.github.com/users/wpninjas/following{/other_user}","gists_url":"https://api.github.com/users/wpninjas/gists{/gist_id}","starred_url":"https://api.github.com/users/wpninjas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpninjas/subscriptions","organizations_url":"https://api.github.com/users/wpninjas/orgs","repos_url":"https://api.github.com/users/wpninjas/repos","events_url":"https://api.github.com/users/wpninjas/events{/privacy}","received_events_url":"https://api.github.com/users/wpninjas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpninjas/ninja-forms","description":"Ninja Forms is a form creation framework for WordPress.","fork":false,"url":"https://api.github.com/repos/wpninjas/ninja-forms","forks_url":"https://api.github.com/repos/wpninjas/ninja-forms/forks","keys_url":"https://api.github.com/repos/wpninjas/ninja-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpninjas/ninja-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpninjas/ninja-forms/teams","hooks_url":"https://api.github.com/repos/wpninjas/ninja-forms/hooks","issue_events_url":"https://api.github.com/repos/wpninjas/ninja-forms/issues/events{/number}","events_url":"https://api.github.com/repos/wpninjas/ninja-forms/events","assignees_url":"https://api.github.com/repos/wpninjas/ninja-forms/assignees{/user}","branches_url":"https://api.github.com/repos/wpninjas/ninja-forms/branches{/branch}","tags_url":"https://api.github.com/repos/wpninjas/ninja-forms/tags","blobs_url":"https://api.github.com/repos/wpninjas/ninja-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpninjas/ninja-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpninjas/ninja-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpninjas/ninja-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpninjas/ninja-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/wpninjas/ninja-forms/languages","stargazers_url":"https://api.github.com/repos/wpninjas/ninja-forms/stargazers","contributors_url":"https://api.github.com/repos/wpninjas/ninja-forms/contributors","subscribers_url":"https://api.github.com/repos/wpninjas/ninja-forms/subscribers","subscription_url":"https://api.github.com/repos/wpninjas/ninja-forms/subscription","commits_url":"https://api.github.com/repos/wpninjas/ninja-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpninjas/ninja-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpninjas/ninja-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpninjas/ninja-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpninjas/ninja-forms/contents/{+path}","compare_url":"https://api.github.com/repos/wpninjas/ninja-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpninjas/ninja-forms/merges","archive_url":"https://api.github.com/repos/wpninjas/ninja-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpninjas/ninja-forms/downloads","issues_url":"https://api.github.com/repos/wpninjas/ninja-forms/issues{/number}","pulls_url":"https://api.github.com/repos/wpninjas/ninja-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/wpninjas/ninja-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/wpninjas/ninja-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpninjas/ninja-forms/labels{/name}","releases_url":"https://api.github.com/repos/wpninjas/ninja-forms/releases{/id}","deployments_url":"https://api.github.com/repos/wpninjas/ninja-forms/deployments","created_at":"2013-05-23T14:53:24Z","updated_at":"2016-05-11T13:41:28Z","pushed_at":"2016-05-12T19:44:14Z","git_url":"git://github.com/wpninjas/ninja-forms.git","ssh_url":"git@github.com:wpninjas/ninja-forms.git","clone_url":"https://github.com/wpninjas/ninja-forms.git","svn_url":"https://github.com/wpninjas/ninja-forms","homepage":null,"size":22089,"stargazers_count":263,"watchers_count":263,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":313,"forks":162,"open_issues":313,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/1348"},"html":{"href":"https://github.com/wpninjas/ninja-forms/pull/1348"},"issue":{"href":"https://api.github.com/repos/wpninjas/ninja-forms/issues/1348"},"comments":{"href":"https://api.github.com/repos/wpninjas/ninja-forms/issues/1348/comments"},"review_comments":{"href":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/1348/comments"},"review_comment":{"href":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpninjas/ninja-forms/pulls/1348/commits"},"statuses":{"href":"https://api.github.com/repos/wpninjas/ninja-forms/statuses/c56aab845ae04a8ada070573bcfd8c9a4ac27b4a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":15,"deletions":23,"changed_files":2}}