{"action":"created","issue":{"url":"https://api.github.com/repos/andsens/bootstrap-vz/issues/335","repository_url":"https://api.github.com/repos/andsens/bootstrap-vz","labels_url":"https://api.github.com/repos/andsens/bootstrap-vz/issues/335/labels{/name}","comments_url":"https://api.github.com/repos/andsens/bootstrap-vz/issues/335/comments","events_url":"https://api.github.com/repos/andsens/bootstrap-vz/issues/335/events","html_url":"https://github.com/andsens/bootstrap-vz/pull/335","id":171033076,"number":335,"title":"admin_user: Allow relative paths to pubkeys","user":{"login":"nbraud","id":1155801,"avatar_url":"https://avatars.githubusercontent.com/u/1155801?v=3","gravatar_id":"","url":"https://api.github.com/users/nbraud","html_url":"https://github.com/nbraud","followers_url":"https://api.github.com/users/nbraud/followers","following_url":"https://api.github.com/users/nbraud/following{/other_user}","gists_url":"https://api.github.com/users/nbraud/gists{/gist_id}","starred_url":"https://api.github.com/users/nbraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbraud/subscriptions","organizations_url":"https://api.github.com/users/nbraud/orgs","repos_url":"https://api.github.com/users/nbraud/repos","events_url":"https://api.github.com/users/nbraud/events{/privacy}","received_events_url":"https://api.github.com/users/nbraud/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-13T23:34:57Z","updated_at":"2016-08-14T00:33:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/andsens/bootstrap-vz/pulls/335","html_url":"https://github.com/andsens/bootstrap-vz/pull/335","diff_url":"https://github.com/andsens/bootstrap-vz/pull/335.diff","patch_url":"https://github.com/andsens/bootstrap-vz/pull/335.patch"},"body":"This is a followup on #331, since this specific patch was dropped.\r\n\r\n@andsens I agree that paths relative to the manifest would be best.\r\nHowever, while implementing this I ran into trouble: there is no way for `validate_manifest` to access `manifest.path`.\r\nMoreover, the `file_copy` plugin also allows relative paths, and has the same issue (pathes end up being relative to the working directory).\r\nI suggest that we pass the entire `manifest` object to `validate_manifest`, rather than `manifest.data`, `manifest.schema_validator` and `manifest.validation_error`."},"comment":{"url":"https://api.github.com/repos/andsens/bootstrap-vz/issues/comments/239649196","html_url":"https://github.com/andsens/bootstrap-vz/pull/335#issuecomment-239649196","issue_url":"https://api.github.com/repos/andsens/bootstrap-vz/issues/335","id":239649196,"user":{"login":"nbraud","id":1155801,"avatar_url":"https://avatars.githubusercontent.com/u/1155801?v=3","gravatar_id":"","url":"https://api.github.com/users/nbraud","html_url":"https://github.com/nbraud","followers_url":"https://api.github.com/users/nbraud/followers","following_url":"https://api.github.com/users/nbraud/following{/other_user}","gists_url":"https://api.github.com/users/nbraud/gists{/gist_id}","starred_url":"https://api.github.com/users/nbraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbraud/subscriptions","organizations_url":"https://api.github.com/users/nbraud/orgs","repos_url":"https://api.github.com/users/nbraud/repos","events_url":"https://api.github.com/users/nbraud/events{/privacy}","received_events_url":"https://api.github.com/users/nbraud/received_events","type":"User","site_admin":false},"created_at":"2016-08-14T00:33:38Z","updated_at":"2016-08-14T00:33:38Z","body":"@andsens This is my proposed solution:\r\n- pass the whole manifest to `validate_manifest()`;\r\n- make paths relatives to the manifest (in `admin_user` and `file_copy`), and validate them properly.\r\n\r\nNote that the `file_copy` change is breaking: the documentation previously asserted that paths were relative to the “current directory”."}}
{"actor":{"display_login":"nbraud"}}