{"action":"created","comment":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/50699732","id":50699732,"diff_hunk":"@@ -81,7 +82,9 @@ public Object parse(String value) throws Exception {\n                 InputStream input = new ByteArrayInputStream(string.getBytes());\n \n                 try {\n-                    Filter filter = (Filter) parser.parse(input);\n+                    InputSource inputSource = new InputSource(input);\n+                    inputSource.setEncoding(Charset.defaultCharset().name());","path":"src/wfs/src/main/java/org/geoserver/wfs/kvp/FilterKvpParser.java","position":14,"original_position":14,"commit_id":"56c2a2f7da1a7be96a92fba6ba47179e58ee8678","original_commit_id":"56c2a2f7da1a7be96a92fba6ba47179e58ee8678","user":{"login":"ahuarte47","id":5576272,"avatar_url":"https://avatars.githubusercontent.com/u/5576272?v=3","gravatar_id":"","url":"https://api.github.com/users/ahuarte47","html_url":"https://github.com/ahuarte47","followers_url":"https://api.github.com/users/ahuarte47/followers","following_url":"https://api.github.com/users/ahuarte47/following{/other_user}","gists_url":"https://api.github.com/users/ahuarte47/gists{/gist_id}","starred_url":"https://api.github.com/users/ahuarte47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahuarte47/subscriptions","organizations_url":"https://api.github.com/users/ahuarte47/orgs","repos_url":"https://api.github.com/users/ahuarte47/repos","events_url":"https://api.github.com/users/ahuarte47/events{/privacy}","received_events_url":"https://api.github.com/users/ahuarte47/received_events","type":"User","site_admin":false},"body":"Thanks @aaime, similar to your last advice about \"GeoServerInfo.getSettings().getCharset()\", could it be better replace the hard-coded \"UTF-8\" encoding in that \"getEncodingName\" function ?\r\n\r\nSimilar to:\r\nhttps://github.com/ahuarte47/geoserver/commit/d658eab273fc61f001a3041d1ed4015378962d54#diff-17cf56a09a7f63467323d1504f02d3daR13","created_at":"2016-01-25T14:34:45Z","updated_at":"2016-01-25T14:34:45Z","html_url":"https://github.com/geoserver/geoserver/pull/1446#discussion_r50699732","pull_request_url":"https://api.github.com/repos/geoserver/geoserver/pulls/1446","_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/50699732"},"html":{"href":"https://github.com/geoserver/geoserver/pull/1446#discussion_r50699732"},"pull_request":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1446"}}},"pull_request":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/1446","id":56961340,"html_url":"https://github.com/geoserver/geoserver/pull/1446","diff_url":"https://github.com/geoserver/geoserver/pull/1446.diff","patch_url":"https://github.com/geoserver/geoserver/pull/1446.patch","issue_url":"https://api.github.com/repos/geoserver/geoserver/issues/1446","number":1446,"state":"open","locked":false,"title":"[GEOS-7385] Honour default charset when parsing WFS KVP Filter","user":{"login":"bencaradocdavies","id":1900866,"avatar_url":"https://avatars.githubusercontent.com/u/1900866?v=3","gravatar_id":"","url":"https://api.github.com/users/bencaradocdavies","html_url":"https://github.com/bencaradocdavies","followers_url":"https://api.github.com/users/bencaradocdavies/followers","following_url":"https://api.github.com/users/bencaradocdavies/following{/other_user}","gists_url":"https://api.github.com/users/bencaradocdavies/gists{/gist_id}","starred_url":"https://api.github.com/users/bencaradocdavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencaradocdavies/subscriptions","organizations_url":"https://api.github.com/users/bencaradocdavies/orgs","repos_url":"https://api.github.com/users/bencaradocdavies/repos","events_url":"https://api.github.com/users/bencaradocdavies/events{/privacy}","received_events_url":"https://api.github.com/users/bencaradocdavies/received_events","type":"User","site_admin":false},"body":"See: https://osgeo-org.atlassian.net/browse/GEOS-7385","created_at":"2016-01-23T00:47:47Z","updated_at":"2016-01-25T14:34:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fded1b6014df50cfa47d8330610f18ff8a1448c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geoserver/geoserver/pulls/1446/commits","review_comments_url":"https://api.github.com/repos/geoserver/geoserver/pulls/1446/comments","review_comment_url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoserver/geoserver/issues/1446/comments","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/56c2a2f7da1a7be96a92fba6ba47179e58ee8678","head":{"label":"bencaradocdavies:kvp-filter-charset","ref":"kvp-filter-charset","sha":"56c2a2f7da1a7be96a92fba6ba47179e58ee8678","user":{"login":"bencaradocdavies","id":1900866,"avatar_url":"https://avatars.githubusercontent.com/u/1900866?v=3","gravatar_id":"","url":"https://api.github.com/users/bencaradocdavies","html_url":"https://github.com/bencaradocdavies","followers_url":"https://api.github.com/users/bencaradocdavies/followers","following_url":"https://api.github.com/users/bencaradocdavies/following{/other_user}","gists_url":"https://api.github.com/users/bencaradocdavies/gists{/gist_id}","starred_url":"https://api.github.com/users/bencaradocdavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencaradocdavies/subscriptions","organizations_url":"https://api.github.com/users/bencaradocdavies/orgs","repos_url":"https://api.github.com/users/bencaradocdavies/repos","events_url":"https://api.github.com/users/bencaradocdavies/events{/privacy}","received_events_url":"https://api.github.com/users/bencaradocdavies/received_events","type":"User","site_admin":false},"repo":{"id":6135494,"name":"geoserver","full_name":"bencaradocdavies/geoserver","owner":{"login":"bencaradocdavies","id":1900866,"avatar_url":"https://avatars.githubusercontent.com/u/1900866?v=3","gravatar_id":"","url":"https://api.github.com/users/bencaradocdavies","html_url":"https://github.com/bencaradocdavies","followers_url":"https://api.github.com/users/bencaradocdavies/followers","following_url":"https://api.github.com/users/bencaradocdavies/following{/other_user}","gists_url":"https://api.github.com/users/bencaradocdavies/gists{/gist_id}","starred_url":"https://api.github.com/users/bencaradocdavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencaradocdavies/subscriptions","organizations_url":"https://api.github.com/users/bencaradocdavies/orgs","repos_url":"https://api.github.com/users/bencaradocdavies/repos","events_url":"https://api.github.com/users/bencaradocdavies/events{/privacy}","received_events_url":"https://api.github.com/users/bencaradocdavies/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bencaradocdavies/geoserver","description":"Official GeoServer repository","fork":true,"url":"https://api.github.com/repos/bencaradocdavies/geoserver","forks_url":"https://api.github.com/repos/bencaradocdavies/geoserver/forks","keys_url":"https://api.github.com/repos/bencaradocdavies/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bencaradocdavies/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bencaradocdavies/geoserver/teams","hooks_url":"https://api.github.com/repos/bencaradocdavies/geoserver/hooks","issue_events_url":"https://api.github.com/repos/bencaradocdavies/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/bencaradocdavies/geoserver/events","assignees_url":"https://api.github.com/repos/bencaradocdavies/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/bencaradocdavies/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/bencaradocdavies/geoserver/tags","blobs_url":"https://api.github.com/repos/bencaradocdavies/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bencaradocdavies/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bencaradocdavies/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/bencaradocdavies/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bencaradocdavies/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/bencaradocdavies/geoserver/languages","stargazers_url":"https://api.github.com/repos/bencaradocdavies/geoserver/stargazers","contributors_url":"https://api.github.com/repos/bencaradocdavies/geoserver/contributors","subscribers_url":"https://api.github.com/repos/bencaradocdavies/geoserver/subscribers","subscription_url":"https://api.github.com/repos/bencaradocdavies/geoserver/subscription","commits_url":"https://api.github.com/repos/bencaradocdavies/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/bencaradocdavies/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/bencaradocdavies/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/bencaradocdavies/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/bencaradocdavies/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/bencaradocdavies/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bencaradocdavies/geoserver/merges","archive_url":"https://api.github.com/repos/bencaradocdavies/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bencaradocdavies/geoserver/downloads","issues_url":"https://api.github.com/repos/bencaradocdavies/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/bencaradocdavies/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/bencaradocdavies/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/bencaradocdavies/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bencaradocdavies/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/bencaradocdavies/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/bencaradocdavies/geoserver/deployments","created_at":"2012-10-09T04:48:48Z","updated_at":"2015-04-02T23:46:51Z","pushed_at":"2016-01-22T23:39:49Z","git_url":"git://github.com/bencaradocdavies/geoserver.git","ssh_url":"git@github.com:bencaradocdavies/geoserver.git","clone_url":"https://github.com/bencaradocdavies/geoserver.git","svn_url":"https://github.com/bencaradocdavies/geoserver","homepage":"http://geoserver.org","size":122351,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geoserver:master","ref":"master","sha":"297b4ab1f92e33885d275083ef67a4a97127862c","user":{"login":"geoserver","id":186522,"avatar_url":"https://avatars.githubusercontent.com/u/186522?v=3","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"repo":{"id":2751199,"name":"geoserver","full_name":"geoserver/geoserver","owner":{"login":"geoserver","id":186522,"avatar_url":"https://avatars.githubusercontent.com/u/186522?v=3","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoserver/geoserver","description":"Official GeoServer repository","fork":false,"url":"https://api.github.com/repos/geoserver/geoserver","forks_url":"https://api.github.com/repos/geoserver/geoserver/forks","keys_url":"https://api.github.com/repos/geoserver/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoserver/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoserver/geoserver/teams","hooks_url":"https://api.github.com/repos/geoserver/geoserver/hooks","issue_events_url":"https://api.github.com/repos/geoserver/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/geoserver/geoserver/events","assignees_url":"https://api.github.com/repos/geoserver/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/geoserver/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/geoserver/geoserver/tags","blobs_url":"https://api.github.com/repos/geoserver/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoserver/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoserver/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoserver/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/geoserver/geoserver/languages","stargazers_url":"https://api.github.com/repos/geoserver/geoserver/stargazers","contributors_url":"https://api.github.com/repos/geoserver/geoserver/contributors","subscribers_url":"https://api.github.com/repos/geoserver/geoserver/subscribers","subscription_url":"https://api.github.com/repos/geoserver/geoserver/subscription","commits_url":"https://api.github.com/repos/geoserver/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoserver/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoserver/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoserver/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoserver/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/geoserver/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoserver/geoserver/merges","archive_url":"https://api.github.com/repos/geoserver/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoserver/geoserver/downloads","issues_url":"https://api.github.com/repos/geoserver/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/geoserver/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/geoserver/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/geoserver/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoserver/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/geoserver/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/geoserver/geoserver/deployments","created_at":"2011-11-10T19:56:06Z","updated_at":"2016-01-24T07:43:14Z","pushed_at":"2016-01-23T03:09:56Z","git_url":"git://github.com/geoserver/geoserver.git","ssh_url":"git@github.com:geoserver/geoserver.git","clone_url":"https://github.com/geoserver/geoserver.git","svn_url":"https://github.com/geoserver/geoserver","homepage":"http://geoserver.org/","size":136622,"stargazers_count":540,"watchers_count":540,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":610,"mirror_url":null,"open_issues_count":16,"forks":610,"open_issues":16,"watchers":540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1446"},"html":{"href":"https://github.com/geoserver/geoserver/pull/1446"},"issue":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/1446"},"comments":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/1446/comments"},"review_comments":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1446/comments"},"review_comment":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/1446/commits"},"statuses":{"href":"https://api.github.com/repos/geoserver/geoserver/statuses/56c2a2f7da1a7be96a92fba6ba47179e58ee8678"}}}}