{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/28042","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/28042/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/28042/comments","events_url":"https://api.github.com/repos/docker/docker/issues/28042/events","html_url":"https://github.com/docker/docker/pull/28042","id":187155887,"number":28042,"title":"Add information for `Manager Addresses` in the output of `docker info`","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"labels":[{"id":308856530,"url":"https://api.github.com/repos/docker/docker/labels/docs/revisit","name":"docs/revisit","color":"000000","default":false},{"id":237472270,"url":"https://api.github.com/repos/docker/docker/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf","default":false},{"id":237472313,"url":"https://api.github.com/repos/docker/docker/labels/impact/cli","name":"impact/cli","color":"bfe5bf","default":false},{"id":450032382,"url":"https://api.github.com/repos/docker/docker/labels/impact/documentation","name":"impact/documentation","color":"bfe5bf","default":false},{"id":175375598,"url":"https://api.github.com/repos/docker/docker/labels/status/4-merge","name":"status/4-merge","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":88,"closed_issues":761,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-11T17:30:01Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2016-11-03T18:41:28Z","updated_at":"2016-11-11T17:51:58Z","closed_at":"2016-11-11T17:30:01Z","pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28042","html_url":"https://github.com/docker/docker/pull/28042","diff_url":"https://github.com/docker/docker/pull/28042.diff","patch_url":"https://github.com/docker/docker/pull/28042.patch"},"body":"**- What I did**\r\nAs is specified in #28018, it would be useful to know the manager's addresses even in a worker node. This is especially useful when there are many worker nodes in a big cluster.\r\n\r\nThe information is available in `info.Swarm.RemoteManagers`.\r\n\r\nThis fix add the information of `Manager Addresses` to the output of `docker info`, to explicitly show it.\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\n\r\nA test has been added for this fix.\r\n\r\nAlso the new output:\r\n```\r\n$ docker info\r\n...\r\nCgroup Driver: cgroupfs\r\nPlugins: \r\n Volume: local\r\n Network: bridge host macvlan null overlay\r\nSwarm: active\r\n NodeID: bu6m8b45fxu8ac4w4wx26iw19\r\n Is Manager: false\r\n Node Address: 127.0.0.1\r\n Manager Addresses: 127.0.0.1:2477\r\nRuntimes: runc\r\nDefault Runtime: runc\r\n...\r\n```\r\n\r\n**- Description for the changelog**\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n![cute_funny_animals_21](https://cloud.githubusercontent.com/assets/6932348/19980178/4fe2a7aa-a1ba-11e6-830b-94db6787b2d5.jpg)\r\n\r\n\r\nThis fix fixes #28018.\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/260014718","html_url":"https://github.com/docker/docker/pull/28042#issuecomment-260014718","issue_url":"https://api.github.com/repos/docker/docker/issues/28042","id":260014718,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T17:51:58Z","updated_at":"2016-11-11T17:51:58Z","body":"Perfect, thanks! i'll review later"}}
{"actor":{"display_login":"thaJeztah"}}