{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3693","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3693/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3693/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3693/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3693","id":137595887,"number":3693,"title":"[RFC] Reduce state change hold to 1/60th of a second","user":{"login":"RisingFog","id":2121359,"avatar_url":"https://avatars.githubusercontent.com/u/2121359?v=3","gravatar_id":"","url":"https://api.github.com/users/RisingFog","html_url":"https://github.com/RisingFog","followers_url":"https://api.github.com/users/RisingFog/followers","following_url":"https://api.github.com/users/RisingFog/following{/other_user}","gists_url":"https://api.github.com/users/RisingFog/gists{/gist_id}","starred_url":"https://api.github.com/users/RisingFog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RisingFog/subscriptions","organizations_url":"https://api.github.com/users/RisingFog/orgs","repos_url":"https://api.github.com/users/RisingFog/repos","events_url":"https://api.github.com/users/RisingFog/events{/privacy}","received_events_url":"https://api.github.com/users/RisingFog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-01T14:56:17Z","updated_at":"2016-03-01T16:00:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3693","html_url":"https://github.com/dolphin-emu/dolphin/pull/3693","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3693.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3693.patch"},"body":"Changes the delay from one second to 1/60th of a second. Prior code was introduced to potentially fix a race condition, but it's not clear what race condition was actually occurring. With the delay at one second, frame advancing FIFO logs was impossible without waiting a full second between each frame advance button press.\r\n\r\nI've marked this as RFC as frankly, I'm not sure if this is correct behaviour or implementation. If anything, the discussion could possibly bring us in the right direction to fixing the real issue if such issue is not properly solved in this PR.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3693)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/190784370","html_url":"https://github.com/dolphin-emu/dolphin/pull/3693#issuecomment-190784370","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3693","id":190784370,"user":{"login":"RisingFog","id":2121359,"avatar_url":"https://avatars.githubusercontent.com/u/2121359?v=3","gravatar_id":"","url":"https://api.github.com/users/RisingFog","html_url":"https://github.com/RisingFog","followers_url":"https://api.github.com/users/RisingFog/followers","following_url":"https://api.github.com/users/RisingFog/following{/other_user}","gists_url":"https://api.github.com/users/RisingFog/gists{/gist_id}","starred_url":"https://api.github.com/users/RisingFog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RisingFog/subscriptions","organizations_url":"https://api.github.com/users/RisingFog/orgs","repos_url":"https://api.github.com/users/RisingFog/repos","events_url":"https://api.github.com/users/RisingFog/events{/privacy}","received_events_url":"https://api.github.com/users/RisingFog/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T16:00:41Z","updated_at":"2016-03-01T16:00:41Z","body":"@phire it appears it should be that way, but in FIFO logs it waits the entire duration."}}