{"action":"created","comment":{"url":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/67840837","id":67840837,"diff_hunk":"@@ -39,12 +41,12 @@ class Application extends BaseApplication\n      */\n     public function __construct($version)\n     {\n-        $this->container = new ServiceContainer();\n+        $this->container = new IndexedServiceContainer();\n         parent::__construct('phpspec', $version);\n     }\n \n     /**\n-     * @return ServiceContainer\n+     * @return IndexedServiceContainer","path":"src/PhpSpec/Console/Application.php","position":34,"original_position":34,"commit_id":"1fe1f59bc0762d2886e18289958ccbf8d6f37092","original_commit_id":"1fe1f59bc0762d2886e18289958ccbf8d6f37092","user":{"login":"ciaranmcnulty","id":237866,"avatar_url":"https://avatars.githubusercontent.com/u/237866?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaranmcnulty","html_url":"https://github.com/ciaranmcnulty","followers_url":"https://api.github.com/users/ciaranmcnulty/followers","following_url":"https://api.github.com/users/ciaranmcnulty/following{/other_user}","gists_url":"https://api.github.com/users/ciaranmcnulty/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranmcnulty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranmcnulty/subscriptions","organizations_url":"https://api.github.com/users/ciaranmcnulty/orgs","repos_url":"https://api.github.com/users/ciaranmcnulty/repos","events_url":"https://api.github.com/users/ciaranmcnulty/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranmcnulty/received_events","type":"User","site_admin":false},"body":"Yep, good catch - I'm considering removing this BTW, it's currently only used for testing? It should be `@internal` anyhow","created_at":"2016-06-21T10:01:05Z","updated_at":"2016-06-21T10:01:05Z","html_url":"https://github.com/phpspec/phpspec/pull/961#discussion_r67840837","pull_request_url":"https://api.github.com/repos/phpspec/phpspec/pulls/961","_links":{"self":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/67840837"},"html":{"href":"https://github.com/phpspec/phpspec/pull/961#discussion_r67840837"},"pull_request":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/961"}}},"pull_request":{"url":"https://api.github.com/repos/phpspec/phpspec/pulls/961","id":74400649,"html_url":"https://github.com/phpspec/phpspec/pull/961","diff_url":"https://github.com/phpspec/phpspec/pull/961.diff","patch_url":"https://github.com/phpspec/phpspec/pull/961.patch","issue_url":"https://api.github.com/repos/phpspec/phpspec/issues/961","number":961,"state":"open","locked":false,"title":"Refactor/simplify container","user":{"login":"ciaranmcnulty","id":237866,"avatar_url":"https://avatars.githubusercontent.com/u/237866?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaranmcnulty","html_url":"https://github.com/ciaranmcnulty","followers_url":"https://api.github.com/users/ciaranmcnulty/followers","following_url":"https://api.github.com/users/ciaranmcnulty/following{/other_user}","gists_url":"https://api.github.com/users/ciaranmcnulty/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranmcnulty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranmcnulty/subscriptions","organizations_url":"https://api.github.com/users/ciaranmcnulty/orgs","repos_url":"https://api.github.com/users/ciaranmcnulty/repos","events_url":"https://api.github.com/users/ciaranmcnulty/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranmcnulty/received_events","type":"User","site_admin":false},"body":"Bearing in mind there's likely to be some changes in how extensions operate, I've taken the opportunity to simplify the container usage, chiefly to introduce an interface but also to mark areas likely to be volatile as `@internal`.\r\n\r\nHaving the interface should enable us to change the internally-used container, as well as support more container types in extensions in future via adapters.\r\n\r\nThe only part of the interface I particularly dislike is the `getByPrefix` which always felt hacky, but it's behaviour should be simple enough to emulate in other containers.","created_at":"2016-06-20T07:38:53Z","updated_at":"2016-06-21T10:01:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11540b0bd68e17b1a9bfc52ed2e488a228e9bbdc","assignee":null,"milestone":{"url":"https://api.github.com/repos/phpspec/phpspec/milestones/13","html_url":"https://github.com/phpspec/phpspec/milestones/3.0","labels_url":"https://api.github.com/repos/phpspec/phpspec/milestones/13/labels","id":1594571,"number":13,"title":"3.0","description":null,"creator":{"login":"ciaranmcnulty","id":237866,"avatar_url":"https://avatars.githubusercontent.com/u/237866?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaranmcnulty","html_url":"https://github.com/ciaranmcnulty","followers_url":"https://api.github.com/users/ciaranmcnulty/followers","following_url":"https://api.github.com/users/ciaranmcnulty/following{/other_user}","gists_url":"https://api.github.com/users/ciaranmcnulty/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranmcnulty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranmcnulty/subscriptions","organizations_url":"https://api.github.com/users/ciaranmcnulty/orgs","repos_url":"https://api.github.com/users/ciaranmcnulty/repos","events_url":"https://api.github.com/users/ciaranmcnulty/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranmcnulty/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":9,"state":"open","created_at":"2016-02-20T08:38:47Z","updated_at":"2016-06-20T07:38:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phpspec/phpspec/pulls/961/commits","review_comments_url":"https://api.github.com/repos/phpspec/phpspec/pulls/961/comments","review_comment_url":"https://api.github.com/repos/phpspec/phpspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpspec/phpspec/issues/961/comments","statuses_url":"https://api.github.com/repos/phpspec/phpspec/statuses/1fe1f59bc0762d2886e18289958ccbf8d6f37092","head":{"label":"ciaranmcnulty:refactor/simplify-container","ref":"refactor/simplify-container","sha":"1fe1f59bc0762d2886e18289958ccbf8d6f37092","user":{"login":"ciaranmcnulty","id":237866,"avatar_url":"https://avatars.githubusercontent.com/u/237866?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaranmcnulty","html_url":"https://github.com/ciaranmcnulty","followers_url":"https://api.github.com/users/ciaranmcnulty/followers","following_url":"https://api.github.com/users/ciaranmcnulty/following{/other_user}","gists_url":"https://api.github.com/users/ciaranmcnulty/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranmcnulty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranmcnulty/subscriptions","organizations_url":"https://api.github.com/users/ciaranmcnulty/orgs","repos_url":"https://api.github.com/users/ciaranmcnulty/repos","events_url":"https://api.github.com/users/ciaranmcnulty/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranmcnulty/received_events","type":"User","site_admin":false},"repo":{"id":12401524,"name":"phpspec","full_name":"ciaranmcnulty/phpspec","owner":{"login":"ciaranmcnulty","id":237866,"avatar_url":"https://avatars.githubusercontent.com/u/237866?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaranmcnulty","html_url":"https://github.com/ciaranmcnulty","followers_url":"https://api.github.com/users/ciaranmcnulty/followers","following_url":"https://api.github.com/users/ciaranmcnulty/following{/other_user}","gists_url":"https://api.github.com/users/ciaranmcnulty/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranmcnulty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranmcnulty/subscriptions","organizations_url":"https://api.github.com/users/ciaranmcnulty/orgs","repos_url":"https://api.github.com/users/ciaranmcnulty/repos","events_url":"https://api.github.com/users/ciaranmcnulty/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranmcnulty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ciaranmcnulty/phpspec","description":"SpecBDD Framework for PHP","fork":true,"url":"https://api.github.com/repos/ciaranmcnulty/phpspec","forks_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/forks","keys_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/teams","hooks_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/hooks","issue_events_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/issues/events{/number}","events_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/events","assignees_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/assignees{/user}","branches_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/branches{/branch}","tags_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/tags","blobs_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/statuses/{sha}","languages_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/languages","stargazers_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/stargazers","contributors_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/contributors","subscribers_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/subscribers","subscription_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/subscription","commits_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/contents/{+path}","compare_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/merges","archive_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/downloads","issues_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/issues{/number}","pulls_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/pulls{/number}","milestones_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/milestones{/number}","notifications_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/labels{/name}","releases_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/releases{/id}","deployments_url":"https://api.github.com/repos/ciaranmcnulty/phpspec/deployments","created_at":"2013-08-27T08:58:32Z","updated_at":"2015-04-18T16:22:13Z","pushed_at":"2016-06-20T16:53:43Z","git_url":"git://github.com/ciaranmcnulty/phpspec.git","ssh_url":"git@github.com:ciaranmcnulty/phpspec.git","clone_url":"https://github.com/ciaranmcnulty/phpspec.git","svn_url":"https://github.com/ciaranmcnulty/phpspec","homepage":"http://www.phpspec.net","size":4261,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpspec:master","ref":"master","sha":"92370ffebff98134e6720359c1aa33e21c847f01","user":{"login":"phpspec","id":416702,"avatar_url":"https://avatars.githubusercontent.com/u/416702?v=3","gravatar_id":"","url":"https://api.github.com/users/phpspec","html_url":"https://github.com/phpspec","followers_url":"https://api.github.com/users/phpspec/followers","following_url":"https://api.github.com/users/phpspec/following{/other_user}","gists_url":"https://api.github.com/users/phpspec/gists{/gist_id}","starred_url":"https://api.github.com/users/phpspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpspec/subscriptions","organizations_url":"https://api.github.com/users/phpspec/orgs","repos_url":"https://api.github.com/users/phpspec/repos","events_url":"https://api.github.com/users/phpspec/events{/privacy}","received_events_url":"https://api.github.com/users/phpspec/received_events","type":"Organization","site_admin":false},"repo":{"id":1582219,"name":"phpspec","full_name":"phpspec/phpspec","owner":{"login":"phpspec","id":416702,"avatar_url":"https://avatars.githubusercontent.com/u/416702?v=3","gravatar_id":"","url":"https://api.github.com/users/phpspec","html_url":"https://github.com/phpspec","followers_url":"https://api.github.com/users/phpspec/followers","following_url":"https://api.github.com/users/phpspec/following{/other_user}","gists_url":"https://api.github.com/users/phpspec/gists{/gist_id}","starred_url":"https://api.github.com/users/phpspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpspec/subscriptions","organizations_url":"https://api.github.com/users/phpspec/orgs","repos_url":"https://api.github.com/users/phpspec/repos","events_url":"https://api.github.com/users/phpspec/events{/privacy}","received_events_url":"https://api.github.com/users/phpspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpspec/phpspec","description":"SpecBDD Framework for PHP","fork":false,"url":"https://api.github.com/repos/phpspec/phpspec","forks_url":"https://api.github.com/repos/phpspec/phpspec/forks","keys_url":"https://api.github.com/repos/phpspec/phpspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpspec/phpspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpspec/phpspec/teams","hooks_url":"https://api.github.com/repos/phpspec/phpspec/hooks","issue_events_url":"https://api.github.com/repos/phpspec/phpspec/issues/events{/number}","events_url":"https://api.github.com/repos/phpspec/phpspec/events","assignees_url":"https://api.github.com/repos/phpspec/phpspec/assignees{/user}","branches_url":"https://api.github.com/repos/phpspec/phpspec/branches{/branch}","tags_url":"https://api.github.com/repos/phpspec/phpspec/tags","blobs_url":"https://api.github.com/repos/phpspec/phpspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpspec/phpspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpspec/phpspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpspec/phpspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpspec/phpspec/statuses/{sha}","languages_url":"https://api.github.com/repos/phpspec/phpspec/languages","stargazers_url":"https://api.github.com/repos/phpspec/phpspec/stargazers","contributors_url":"https://api.github.com/repos/phpspec/phpspec/contributors","subscribers_url":"https://api.github.com/repos/phpspec/phpspec/subscribers","subscription_url":"https://api.github.com/repos/phpspec/phpspec/subscription","commits_url":"https://api.github.com/repos/phpspec/phpspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpspec/phpspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpspec/phpspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpspec/phpspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpspec/phpspec/contents/{+path}","compare_url":"https://api.github.com/repos/phpspec/phpspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpspec/phpspec/merges","archive_url":"https://api.github.com/repos/phpspec/phpspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpspec/phpspec/downloads","issues_url":"https://api.github.com/repos/phpspec/phpspec/issues{/number}","pulls_url":"https://api.github.com/repos/phpspec/phpspec/pulls{/number}","milestones_url":"https://api.github.com/repos/phpspec/phpspec/milestones{/number}","notifications_url":"https://api.github.com/repos/phpspec/phpspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpspec/phpspec/labels{/name}","releases_url":"https://api.github.com/repos/phpspec/phpspec/releases{/id}","deployments_url":"https://api.github.com/repos/phpspec/phpspec/deployments","created_at":"2011-04-07T12:48:08Z","updated_at":"2016-06-21T06:38:09Z","pushed_at":"2016-06-20T16:53:44Z","git_url":"git://github.com/phpspec/phpspec.git","ssh_url":"git@github.com:phpspec/phpspec.git","clone_url":"https://github.com/phpspec/phpspec.git","svn_url":"https://github.com/phpspec/phpspec","homepage":"http://www.phpspec.net","size":5271,"stargazers_count":1009,"watchers_count":1009,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"open_issues_count":97,"forks":204,"open_issues":97,"watchers":1009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/961"},"html":{"href":"https://github.com/phpspec/phpspec/pull/961"},"issue":{"href":"https://api.github.com/repos/phpspec/phpspec/issues/961"},"comments":{"href":"https://api.github.com/repos/phpspec/phpspec/issues/961/comments"},"review_comments":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/961/comments"},"review_comment":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/961/commits"},"statuses":{"href":"https://api.github.com/repos/phpspec/phpspec/statuses/1fe1f59bc0762d2886e18289958ccbf8d6f37092"}}}}
{"actor":{"display_login":"ciaranmcnulty"}}