{"action":"created","comment":{"url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments/80790631","pull_request_review_id":1821612,"id":80790631,"diff_hunk":"@@ -0,0 +1,124 @@\n+/*\n+ * Copyright (c) 2016, Uber Technologies, Inc\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+package com.uber.jaeger.httpclient;\n+\n+import static org.junit.Assert.assertEquals;\n+\n+import com.uber.jaeger.Span;\n+import com.uber.jaeger.Tracer;\n+import com.uber.jaeger.context.TraceContext;\n+import com.uber.jaeger.context.TracingUtils;\n+import com.uber.jaeger.reporters.InMemoryReporter;\n+import com.uber.jaeger.samplers.ConstSampler;\n+import com.uber.jaeger.samplers.Sampler;\n+import org.apache.http.HttpHost;\n+import org.apache.http.concurrent.FutureCallback;\n+import org.apache.http.impl.nio.client.CloseableHttpAsyncClient;\n+import org.apache.http.impl.nio.client.HttpAsyncClients;\n+import org.apache.http.message.BasicHttpRequest;\n+import org.junit.Before;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+import org.mockito.runners.MockitoJUnitRunner;\n+import org.mockserver.client.server.MockServerClient;\n+import org.mockserver.junit.MockServerRule;\n+import org.mockserver.model.HttpRequest;\n+import org.mockserver.model.HttpResponse;\n+\n+import java.util.List;\n+\n+@RunWith(MockitoJUnitRunner.class)\n+public class JaegerRequestAndResponseInterceptorIntegrationTest {\n+\n+  @Rule public MockServerRule mockServerRule = new MockServerRule(this);\n+  private InMemoryReporter reporter;\n+  private Tracer tracer;\n+\n+  @SuppressWarnings(\"unused\")\n+  private MockServerClient mockServerClient;\n+\n+  private String BAGGAGE_KEY = \"Bag_End\";\n+  private String BAGGAGE_VALUE = \"smial_at_the_end_of_Bagshot_Row\";","path":"jaeger-apachehttpclient/src/test/java/com/uber/jaeger/httpclient/JaegerRequestAndResponseInterceptorIntegrationTest.java","position":66,"original_position":61,"commit_id":"f3eec1672e0440543e4f48f48d7ecffb82dfabd5","original_commit_id":"6c77b3d0cd38016a3291c2ce63b92d0c5e06a210","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"surprised it works given that the KEY uses upper case letters and underscore.","created_at":"2016-09-27T20:46:12Z","updated_at":"2016-09-27T20:46:12Z","html_url":"https://github.com/uber/jaeger-client-java/pull/63#discussion_r80790631","pull_request_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments/80790631"},"html":{"href":"https://github.com/uber/jaeger-client-java/pull/63#discussion_r80790631"},"pull_request":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63","id":86969885,"html_url":"https://github.com/uber/jaeger-client-java/pull/63","diff_url":"https://github.com/uber/jaeger-client-java/pull/63.diff","patch_url":"https://github.com/uber/jaeger-client-java/pull/63.patch","issue_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/63","number":63,"state":"open","locked":false,"title":"Add support for Apache Http Client","user":{"login":"vprithvi","id":833009,"avatar_url":"https://avatars.githubusercontent.com/u/833009?v=3","gravatar_id":"","url":"https://api.github.com/users/vprithvi","html_url":"https://github.com/vprithvi","followers_url":"https://api.github.com/users/vprithvi/followers","following_url":"https://api.github.com/users/vprithvi/following{/other_user}","gists_url":"https://api.github.com/users/vprithvi/gists{/gist_id}","starred_url":"https://api.github.com/users/vprithvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vprithvi/subscriptions","organizations_url":"https://api.github.com/users/vprithvi/orgs","repos_url":"https://api.github.com/users/vprithvi/repos","events_url":"https://api.github.com/users/vprithvi/events{/privacy}","received_events_url":"https://api.github.com/users/vprithvi/received_events","type":"User","site_admin":false},"body":"- Adds a JaegerHttpRequestInterceptor and JaegerHttpResponseInterceptor\r\n  that can be used on any Apache Http Client to add tracing support\r\n\r\nSee https://github.com/uber/jaeger-client-java/issues/62","created_at":"2016-09-27T16:56:21Z","updated_at":"2016-09-27T20:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa64ad1c5c26309041b01e18fc2c10988f03939b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63/commits","review_comments_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63/comments","review_comment_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/63/comments","statuses_url":"https://api.github.com/repos/uber/jaeger-client-java/statuses/f3eec1672e0440543e4f48f48d7ecffb82dfabd5","head":{"label":"uber:add_apachehttpclient","ref":"add_apachehttpclient","sha":"f3eec1672e0440543e4f48f48d7ecffb82dfabd5","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":56551000,"name":"jaeger-client-java","full_name":"uber/jaeger-client-java","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":false,"url":"https://api.github.com/repos/uber/jaeger-client-java","forks_url":"https://api.github.com/repos/uber/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/uber/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/uber/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/uber/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-client-java/deployments","created_at":"2016-04-19T00:10:02Z","updated_at":"2016-09-15T18:27:03Z","pushed_at":"2016-09-27T20:42:53Z","git_url":"git://github.com/uber/jaeger-client-java.git","ssh_url":"git@github.com:uber/jaeger-client-java.git","clone_url":"https://github.com/uber/jaeger-client-java.git","svn_url":"https://github.com/uber/jaeger-client-java","homepage":"","size":405,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":9,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"190b09b3aeb29eaa412b9ea09f0c7bb7c4e7715e","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":56551000,"name":"jaeger-client-java","full_name":"uber/jaeger-client-java","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":false,"url":"https://api.github.com/repos/uber/jaeger-client-java","forks_url":"https://api.github.com/repos/uber/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/uber/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/uber/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/uber/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-client-java/deployments","created_at":"2016-04-19T00:10:02Z","updated_at":"2016-09-15T18:27:03Z","pushed_at":"2016-09-27T20:42:53Z","git_url":"git://github.com/uber/jaeger-client-java.git","ssh_url":"git@github.com:uber/jaeger-client-java.git","clone_url":"https://github.com/uber/jaeger-client-java.git","svn_url":"https://github.com/uber/jaeger-client-java","homepage":"","size":405,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63"},"html":{"href":"https://github.com/uber/jaeger-client-java/pull/63"},"issue":{"href":"https://api.github.com/repos/uber/jaeger-client-java/issues/63"},"comments":{"href":"https://api.github.com/repos/uber/jaeger-client-java/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/jaeger-client-java/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/uber/jaeger-client-java/statuses/f3eec1672e0440543e4f48f48d7ecffb82dfabd5"}}}}
{"actor":{"display_login":"yurishkuro"}}