{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10641","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10641/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10641/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10641/events","html_url":"https://github.com/joomla/joomla-cms/pull/10641","id":157055927,"number":10641,"title":"[html5] System frontend template","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-05-26T19:06:55Z","updated_at":"2016-07-08T12:56:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10641","html_url":"https://github.com/joomla/joomla-cms/pull/10641","diff_url":"https://github.com/joomla/joomla-cms/pull/10641.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10641.patch"},"body":"#### Summary of Changes\r\n\r\nThis is a redo of https://github.com/joomla/joomla-cms/pull/9842 for **system site** only.\r\n\r\nThis PR does a basic conversion of **system site** template to HTML5.\r\nAlso made some minor corrections:\r\n- Use the API in inline css/js (except error page)\r\n- Use ie9 or lower hml5.js in all files.\r\n\r\n#### Testing Instructions\r\n\r\n1. Install patch\r\n2. Add the following code to force the system template in the frontend (before https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/site.php#L422) \r\n```php\r\n $this->template = new stdClass;\r\n $this->template->template = 'system';\r\n $this->template->params   = new Registry;\r\n```\r\n3. Go to frontend and check if the the following pages are working properly:\r\n - component popup (add `?tmpl=component&print=1` to an existent page)\r\n - error pages (test one non existent URL)\r\n - offline (set the site to offline and check the login page)\r\n\r\nCheck also the code changes.\r\n\r\n#### Observations\r\n\r\nAll pages should now start with this code:\r\n```html\r\n<!DOCTYPE html>\r\n<html lang=\"en-gb\" dir=\"ltr\">\r\n<head>\r\n[...]\r\n\t<meta charset=\"utf-8\" />\r\n[...]\r\n```"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/231352250","html_url":"https://github.com/joomla/joomla-cms/pull/10641#issuecomment-231352250","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10641","id":231352250,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T12:56:16Z","updated_at":"2016-07-08T12:56:16Z","body":"yes, remove the custom code added and you will see it's working correctly with the patch applied."}}
{"actor":{"display_login":"andrepereiradasilva"}}