{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/25718","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/25718/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/25718/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/25718/events","html_url":"https://github.com/owncloud/core/issues/25718","id":169858429,"number":25718,"title":"Shared files, oC 9.1 adding \"(2)\" at the end","user":{"login":"Mysterycz","id":20899532,"avatar_url":"https://avatars.githubusercontent.com/u/20899532?v=3","gravatar_id":"","url":"https://api.github.com/users/Mysterycz","html_url":"https://github.com/Mysterycz","followers_url":"https://api.github.com/users/Mysterycz/followers","following_url":"https://api.github.com/users/Mysterycz/following{/other_user}","gists_url":"https://api.github.com/users/Mysterycz/gists{/gist_id}","starred_url":"https://api.github.com/users/Mysterycz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mysterycz/subscriptions","organizations_url":"https://api.github.com/users/Mysterycz/orgs","repos_url":"https://api.github.com/users/Mysterycz/repos","events_url":"https://api.github.com/users/Mysterycz/events{/privacy}","received_events_url":"https://api.github.com/users/Mysterycz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/owncloud/core/labels/feature:sharing","name":"feature:sharing","color":"d4c5f9"},{"url":"https://api.github.com/repos/owncloud/core/labels/sev1-critical","name":"sev1-critical","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/93","html_url":"https://github.com/owncloud/core/milestones/9.1.2","labels_url":"https://api.github.com/repos/owncloud/core/milestones/93/labels","id":1896102,"number":93,"title":"9.1.2","description":null,"creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":160,"closed_issues":43,"state":"open","created_at":"2016-07-21T09:53:56Z","updated_at":"2016-10-17T07:54:06Z","due_on":"2016-10-24T00:00:00Z","closed_at":null},"comments":156,"created_at":"2016-08-08T07:23:39Z","updated_at":"2016-10-17T15:36:10Z","closed_at":null,"body":"### Steps to reproduce (I don't know how to reproduce it, I need to investigate more)\r\n1. Use oC 9.1\r\n2. Share some files\r\n3. Wait untill some random magic happens and oC will add to all shared files some \"(2)\"\r\n\r\nI found same issue here, but these steps to reproduce does not work:\r\nhttps://github.com/owncloud/core/issues/10736\r\n\r\n### Expected behaviour\r\noC should not rename shared files ...\r\n\r\n### Actual behaviour\r\noC adds \"(2)\" to all shared files (owner does not see renamed + \"(2)\" files\r\n\r\n### Server configuration\r\nUbuntu 14.04\r\nApache2\r\nMySQL\r\nPHP 5.6\r\noC 9.1\r\nUpdated from 9.04\r\nInstalled from official website manually\r\n\r\n```\r\nIntegrity check: No errors have been found.\r\n\r\n```\r\n\r\n**List of activated apps:**\r\n\r\n```\r\n  - activity: 2.3.2\r\n  - comments: 0.3.0\r\n  - dav: 0.2.5\r\n  - encryption: 1.3.0\r\n  - external: 1.2\r\n  - federatedfilesharing: 0.3.0\r\n  - federation: 0.1.0\r\n  - files: 1.5.1\r\n  - files_pdfviewer: 0.8.1\r\n  - files_sharing: 0.10.0\r\n  - files_texteditor: 2.1\r\n  - files_trashbin: 0.9.0\r\n  - files_versions: 1.3.0\r\n  - files_videoplayer: 0.9.8\r\n  - firstrunwizard: 1.1\r\n  - gallery: 15.0.0\r\n  - notifications: 0.3.0\r\n  - ownnote: 1.08\r\n  - provisioning_api: 0.5.0\r\n  - systemtags: 0.3.0\r\n  - templateeditor: 0.1\r\n  - updatenotification: 0.2.1\r\n  - user_ldap: 0.9.0\r\nDisabled:\r\n  - files_antivirus\r\n  - files_external\r\n  - user_external\r\n\r\n```\r\n\r\n**The content of config/config.php:**\r\n\r\n```\r\n{\r\n    \"system\": {\r\n        \"updatechecker\": false,\r\n        \"instanceid\": \"***\",\r\n        \"passwordsalt\": \"***REMOVED SENSITIVE VALUE***\",\r\n        \"secret\": \"***REMOVED SENSITIVE VALUE***\",\r\n        \"trusted_domains\": [\r\n            ***\r\n        ],\r\n        \"datadirectory\": \"\\/home\\/owncloud\\/owncloud\",\r\n        \"overwrite.cli.url\": \"*\",\r\n        \"dbtype\": \"mysql\",\r\n        \"version\": \"9.1.0.15\",\r\n        \"default_language\": \"cz\",\r\n        \"dbname\": \"ownCloud\",\r\n        \"dbhost\": \"localhost\",\r\n        \"dbtableprefix\": \"oc_\",\r\n        \"dbuser\": \"***REMOVED SENSITIVE VALUE***\",\r\n        \"dbpassword\": \"***REMOVED SENSITIVE VALUE***\",\r\n        \"logtimezone\": \"UTC\",\r\n        \"installed\": true,\r\n        \"ldapIgnoreNamingRules\": false,\r\n        \"loglevel\": 2,\r\n        \"appstore.experimental.enabled\": true,\r\n        \"theme\": \"HZS\",\r\n        \"maintenance\": false,\r\n        \"memcache.local\": \"\\\\OC\\\\Memcache\\\\APCu\",\r\n        \"preview_libreoffice_path\": \"\\/usr\\/bin\\/libreoffice\",\r\n        \"mail_from_address\": \"owncloud\",\r\n        \"mail_smtpmode\": \"php\",\r\n        \"mail_domain\": \"**\"\r\n    }\r\n}\r\n\r\n```\r\n\r\n**Are you using external storage, if yes which one:** no\r\n\r\n**Are you using encryption:** yes\r\n\r\n**Are you using an external user-backend, if yes which one:** LDAP\r\n\r\n### Client configuration\r\n**Browser:** Opera 39\r\n**Operating system:** Windows 10"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/254243867","html_url":"https://github.com/owncloud/core/issues/25718#issuecomment-254243867","issue_url":"https://api.github.com/repos/owncloud/core/issues/25718","id":254243867,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T15:36:09Z","updated_at":"2016-10-17T15:36:09Z","body":"I wrote a script that would simulate scrolling through the users page, which itself triggers loading the avatar of every user. That itself does setup the FS of every LDAP user and also creates a LDAP mapping if there was none already.\r\n\r\nWhile this is running, it stopped at my breakpoint in SharedMount. A closer look shows that the addition of a \"(2)\" in these cases are legitimate: the recipient already has a folder called \"XYZ\" in oc_filecache (and likely on disk, I only have the DB dump). And someone shared a folder called \"XYZ\" with that user, so as soon as the user logs in or the user's storage is setup, it will detect the duplicate and append a \"(2)\" to the share. So the received share becomes \"(2)\".\r\n\r\nNormally this kind of situation would happen if a user never logged in before, so their FS was never setup. BUT I see in oc_filecache that this user already has data in their homes.\r\n\r\nSo the question is, how come we find ourselves in a situation where a user already has a folder \"XYZ\" and only later on oc_share contains a share with that name, and only after that the deduplication code runs. This situation is not really possible.\r\n\r\nHowever, we do know that @gregoryR and others in this thread have been \"washing\" this table automatically. So what I'm observing is only a legitimate \"(2)\" that got cleant away, and gets readded when that user's FS is setup. In these cases, I expect that it won't be added again since the duplication was resolved already.\r\n\r\nNow I'm letting the users page script and sync client continue to run and hope to catch the real :bug: \r\n"}}
{"actor":{"display_login":"PVince81"}}