{"action":"created","issue":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/1254","repository_url":"https://api.github.com/repos/foosel/OctoPrint","labels_url":"https://api.github.com/repos/foosel/OctoPrint/issues/1254/labels{/name}","comments_url":"https://api.github.com/repos/foosel/OctoPrint/issues/1254/comments","events_url":"https://api.github.com/repos/foosel/OctoPrint/issues/1254/events","html_url":"https://github.com/foosel/OctoPrint/pull/1254","id":138459537,"number":1254,"title":"[Brainstorming] Warn if any of the objects exceed the printing area","user":{"login":"Javierma","id":13371130,"avatar_url":"https://avatars.githubusercontent.com/u/13371130?v=3","gravatar_id":"","url":"https://api.github.com/users/Javierma","html_url":"https://github.com/Javierma","followers_url":"https://api.github.com/users/Javierma/followers","following_url":"https://api.github.com/users/Javierma/following{/other_user}","gists_url":"https://api.github.com/users/Javierma/gists{/gist_id}","starred_url":"https://api.github.com/users/Javierma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Javierma/subscriptions","organizations_url":"https://api.github.com/users/Javierma/orgs","repos_url":"https://api.github.com/users/Javierma/repos","events_url":"https://api.github.com/users/Javierma/events{/privacy}","received_events_url":"https://api.github.com/users/Javierma/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/foosel/OctoPrint/labels/pr:needs%20some%20work","name":"pr:needs some work","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-04T12:09:04Z","updated_at":"2016-03-08T18:25:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/foosel/OctoPrint/pulls/1254","html_url":"https://github.com/foosel/OctoPrint/pull/1254","diff_url":"https://github.com/foosel/OctoPrint/pull/1254.diff","patch_url":"https://github.com/foosel/OctoPrint/pull/1254.patch"},"body":"After fixing errors and removing non-related files, I try again the pull request. I wasn't able to add only one commit (I don't know why, maybe because previous ones where related with these files) but this time it is much more easy to know the changes that have been done. I believe I solved problems with coding styles (tabs and spaces) but if it is not the case please let me know.\r\n\r\nBasically, what it happens is that when you add a gcode file and is analysed, in case that user has logged in and it is detected that a move exceeds the printing area, it will show a warning like the following one:\r\n\r\n![screenshot from 2016-03-04 12 57 45](https://cloud.githubusercontent.com/assets/13371130/13526729/2e6f3612-e20a-11e5-8e0e-d978ea1f3167.png)\r\n\r\nRegards,\r\n\r\nJavier\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/comments/193901987","html_url":"https://github.com/foosel/OctoPrint/pull/1254#issuecomment-193901987","issue_url":"https://api.github.com/repos/foosel/OctoPrint/issues/1254","id":193901987,"user":{"login":"Javierma","id":13371130,"avatar_url":"https://avatars.githubusercontent.com/u/13371130?v=3","gravatar_id":"","url":"https://api.github.com/users/Javierma","html_url":"https://github.com/Javierma","followers_url":"https://api.github.com/users/Javierma/followers","following_url":"https://api.github.com/users/Javierma/following{/other_user}","gists_url":"https://api.github.com/users/Javierma/gists{/gist_id}","starred_url":"https://api.github.com/users/Javierma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Javierma/subscriptions","organizations_url":"https://api.github.com/users/Javierma/orgs","repos_url":"https://api.github.com/users/Javierma/repos","events_url":"https://api.github.com/users/Javierma/events{/privacy}","received_events_url":"https://api.github.com/users/Javierma/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T18:25:00Z","updated_at":"2016-03-08T18:25:00Z","body":"It took some time but I would say that it is finished or almost. About the different notes:\r\n\r\n-Minimum and maximum values are now sent through the metadada to be used in the frontend.\r\n\r\n-getWarning(): Removed in this last commit (yes, I wrongly applied Java programming).\r\n\r\n-Print origin: In last commit it has been tested for both lowerleft and centre, working for the two cases (maybe for centre origin the message shown can be improved).\r\n\r\n-Start and end gcode: I agree that it also should be evaluated, although it can be quite difficult indeed. I may be wrong, but as far as I know G28 command should be used to say which axis do the homing, so in case of extrusion in start gcode(e.g. for skirt) a G0 or G1 command would be used.\r\n\r\n-Resources: Before these resources I already did online courses (CodeCademy's and Udacity's) but those are not as complete (especially to repair problems as are pretty basic), so thank you for them.\r\n\r\n-Files.js: There where things that I probably changed when I didn't have to, so that's why they appeared as changed. In the last commit you will find some of the things that I had to repair. Now that problems are solved.\r\n\r\n-GUI: I also changed the way that the message appears, trying to be clear and avoid absurd repetitions. The following image is an example of the change:\r\n\r\n![screenshot from 2016-03-08 18 38 08](https://cloud.githubusercontent.com/assets/13371130/13611484/1d8d5ac0-e563-11e5-826b-d07497fa1f08.png)\r\n\r\n"}}