{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/enzyme/pulls/comments/62679803","id":62679803,"diff_hunk":"@@ -134,6 +134,8 @@ if (REACT013) {\n   };\n }\n \n+const batchedUpdates = require('react/lib/ReactUpdates').batchedUpdates;","path":"src/react-compat.js","position":4,"original_position":4,"commit_id":"270a544ea53e824bbe7b4dae447e4b1ab0d75361","original_commit_id":"270a544ea53e824bbe7b4dae447e4b1ab0d75361","user":{"login":"Aweary","id":6886061,"avatar_url":"https://avatars.githubusercontent.com/u/6886061?v=3","gravatar_id":"","url":"https://api.github.com/users/Aweary","html_url":"https://github.com/Aweary","followers_url":"https://api.github.com/users/Aweary/followers","following_url":"https://api.github.com/users/Aweary/following{/other_user}","gists_url":"https://api.github.com/users/Aweary/gists{/gist_id}","starred_url":"https://api.github.com/users/Aweary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aweary/subscriptions","organizations_url":"https://api.github.com/users/Aweary/orgs","repos_url":"https://api.github.com/users/Aweary/repos","events_url":"https://api.github.com/users/Aweary/events{/privacy}","received_events_url":"https://api.github.com/users/Aweary/received_events","type":"User","site_admin":false},"body":"I think we'll likely have to be reactive when it comes to https://github.com/facebook/react/issues/6460. We should definitely try to work with the React team if they want to support libraries like enzyme in some capacity.\r\n\r\nAlso @koba04 can you put this `require` up at the top with the main `const React = require('react')` statement, since this is not a version dependant import at all.","created_at":"2016-05-10T14:20:29Z","updated_at":"2016-05-10T14:20:29Z","html_url":"https://github.com/airbnb/enzyme/pull/342#discussion_r62679803","pull_request_url":"https://api.github.com/repos/airbnb/enzyme/pulls/342","_links":{"self":{"href":"https://api.github.com/repos/airbnb/enzyme/pulls/comments/62679803"},"html":{"href":"https://github.com/airbnb/enzyme/pull/342#discussion_r62679803"},"pull_request":{"href":"https://api.github.com/repos/airbnb/enzyme/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/enzyme/pulls/342","id":67492960,"html_url":"https://github.com/airbnb/enzyme/pull/342","diff_url":"https://github.com/airbnb/enzyme/pull/342.diff","patch_url":"https://github.com/airbnb/enzyme/pull/342.patch","issue_url":"https://api.github.com/repos/airbnb/enzyme/issues/342","number":342,"state":"open","locked":false,"title":"ShallowRenderer.simulate supports batched updates","user":{"login":"koba04","id":250407,"avatar_url":"https://avatars.githubusercontent.com/u/250407?v=3","gravatar_id":"","url":"https://api.github.com/users/koba04","html_url":"https://github.com/koba04","followers_url":"https://api.github.com/users/koba04/followers","following_url":"https://api.github.com/users/koba04/following{/other_user}","gists_url":"https://api.github.com/users/koba04/gists{/gist_id}","starred_url":"https://api.github.com/users/koba04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koba04/subscriptions","organizations_url":"https://api.github.com/users/koba04/orgs","repos_url":"https://api.github.com/users/koba04/repos","events_url":"https://api.github.com/users/koba04/events{/privacy}","received_events_url":"https://api.github.com/users/koba04/received_events","type":"User","site_admin":false},"body":"This PR is for `ShallowWrapper.simulate()` supports batched updates using `ReactUpdates.batchedUpdates`.\r\n\r\n`React.addons.TestUtils.Simulate.{eventName}` is supporting batched updates.\r\nref. https://jsfiddle.net/koba04/6Lchbest/\r\n\r\n`ReactUpdates.batchedUpdates` is exported as `ReactDOM. unstable_batchedUpdates` from React v0.14. In React v0.13, it is exported as  `React.addons.batchedUpdates`.\r\n\r\nIt might be better I use the exported interface.\r\nBut I guess it makes your configurations complex than using `ReactUpdates.batchedUpdates` directly.\r\n\r\nFYI: This batched updates feature is required #318.\r\n\r\nThanks.","created_at":"2016-04-22T10:48:26Z","updated_at":"2016-05-10T14:20:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d8fb25031847ba00658555cd47098e7cc929209","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/enzyme/pulls/342/commits","review_comments_url":"https://api.github.com/repos/airbnb/enzyme/pulls/342/comments","review_comment_url":"https://api.github.com/repos/airbnb/enzyme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/enzyme/issues/342/comments","statuses_url":"https://api.github.com/repos/airbnb/enzyme/statuses/270a544ea53e824bbe7b4dae447e4b1ab0d75361","head":{"label":"koba04:simulate-supports-batched-updates","ref":"simulate-supports-batched-updates","sha":"270a544ea53e824bbe7b4dae447e4b1ab0d75361","user":{"login":"koba04","id":250407,"avatar_url":"https://avatars.githubusercontent.com/u/250407?v=3","gravatar_id":"","url":"https://api.github.com/users/koba04","html_url":"https://github.com/koba04","followers_url":"https://api.github.com/users/koba04/followers","following_url":"https://api.github.com/users/koba04/following{/other_user}","gists_url":"https://api.github.com/users/koba04/gists{/gist_id}","starred_url":"https://api.github.com/users/koba04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koba04/subscriptions","organizations_url":"https://api.github.com/users/koba04/orgs","repos_url":"https://api.github.com/users/koba04/repos","events_url":"https://api.github.com/users/koba04/events{/privacy}","received_events_url":"https://api.github.com/users/koba04/received_events","type":"User","site_admin":false},"repo":{"id":52579445,"name":"enzyme","full_name":"koba04/enzyme","owner":{"login":"koba04","id":250407,"avatar_url":"https://avatars.githubusercontent.com/u/250407?v=3","gravatar_id":"","url":"https://api.github.com/users/koba04","html_url":"https://github.com/koba04","followers_url":"https://api.github.com/users/koba04/followers","following_url":"https://api.github.com/users/koba04/following{/other_user}","gists_url":"https://api.github.com/users/koba04/gists{/gist_id}","starred_url":"https://api.github.com/users/koba04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koba04/subscriptions","organizations_url":"https://api.github.com/users/koba04/orgs","repos_url":"https://api.github.com/users/koba04/repos","events_url":"https://api.github.com/users/koba04/events{/privacy}","received_events_url":"https://api.github.com/users/koba04/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koba04/enzyme","description":"JavaScript Testing utilities for React","fork":true,"url":"https://api.github.com/repos/koba04/enzyme","forks_url":"https://api.github.com/repos/koba04/enzyme/forks","keys_url":"https://api.github.com/repos/koba04/enzyme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koba04/enzyme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koba04/enzyme/teams","hooks_url":"https://api.github.com/repos/koba04/enzyme/hooks","issue_events_url":"https://api.github.com/repos/koba04/enzyme/issues/events{/number}","events_url":"https://api.github.com/repos/koba04/enzyme/events","assignees_url":"https://api.github.com/repos/koba04/enzyme/assignees{/user}","branches_url":"https://api.github.com/repos/koba04/enzyme/branches{/branch}","tags_url":"https://api.github.com/repos/koba04/enzyme/tags","blobs_url":"https://api.github.com/repos/koba04/enzyme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koba04/enzyme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koba04/enzyme/git/refs{/sha}","trees_url":"https://api.github.com/repos/koba04/enzyme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koba04/enzyme/statuses/{sha}","languages_url":"https://api.github.com/repos/koba04/enzyme/languages","stargazers_url":"https://api.github.com/repos/koba04/enzyme/stargazers","contributors_url":"https://api.github.com/repos/koba04/enzyme/contributors","subscribers_url":"https://api.github.com/repos/koba04/enzyme/subscribers","subscription_url":"https://api.github.com/repos/koba04/enzyme/subscription","commits_url":"https://api.github.com/repos/koba04/enzyme/commits{/sha}","git_commits_url":"https://api.github.com/repos/koba04/enzyme/git/commits{/sha}","comments_url":"https://api.github.com/repos/koba04/enzyme/comments{/number}","issue_comment_url":"https://api.github.com/repos/koba04/enzyme/issues/comments{/number}","contents_url":"https://api.github.com/repos/koba04/enzyme/contents/{+path}","compare_url":"https://api.github.com/repos/koba04/enzyme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koba04/enzyme/merges","archive_url":"https://api.github.com/repos/koba04/enzyme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koba04/enzyme/downloads","issues_url":"https://api.github.com/repos/koba04/enzyme/issues{/number}","pulls_url":"https://api.github.com/repos/koba04/enzyme/pulls{/number}","milestones_url":"https://api.github.com/repos/koba04/enzyme/milestones{/number}","notifications_url":"https://api.github.com/repos/koba04/enzyme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koba04/enzyme/labels{/name}","releases_url":"https://api.github.com/repos/koba04/enzyme/releases{/id}","deployments_url":"https://api.github.com/repos/koba04/enzyme/deployments","created_at":"2016-02-26T04:49:38Z","updated_at":"2016-02-26T04:49:40Z","pushed_at":"2016-05-09T09:56:38Z","git_url":"git://github.com/koba04/enzyme.git","ssh_url":"git@github.com:koba04/enzyme.git","clone_url":"https://github.com/koba04/enzyme.git","svn_url":"https://github.com/koba04/enzyme","homepage":"http://airbnb.io/enzyme/","size":1172,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"91f0f98e5e8a899c32d60546399989f6aa14be79","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":45942274,"name":"enzyme","full_name":"airbnb/enzyme","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/enzyme","description":"JavaScript Testing utilities for React","fork":false,"url":"https://api.github.com/repos/airbnb/enzyme","forks_url":"https://api.github.com/repos/airbnb/enzyme/forks","keys_url":"https://api.github.com/repos/airbnb/enzyme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/enzyme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/enzyme/teams","hooks_url":"https://api.github.com/repos/airbnb/enzyme/hooks","issue_events_url":"https://api.github.com/repos/airbnb/enzyme/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/enzyme/events","assignees_url":"https://api.github.com/repos/airbnb/enzyme/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/enzyme/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/enzyme/tags","blobs_url":"https://api.github.com/repos/airbnb/enzyme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/enzyme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/enzyme/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/enzyme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/enzyme/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/enzyme/languages","stargazers_url":"https://api.github.com/repos/airbnb/enzyme/stargazers","contributors_url":"https://api.github.com/repos/airbnb/enzyme/contributors","subscribers_url":"https://api.github.com/repos/airbnb/enzyme/subscribers","subscription_url":"https://api.github.com/repos/airbnb/enzyme/subscription","commits_url":"https://api.github.com/repos/airbnb/enzyme/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/enzyme/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/enzyme/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/enzyme/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/enzyme/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/enzyme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/enzyme/merges","archive_url":"https://api.github.com/repos/airbnb/enzyme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/enzyme/downloads","issues_url":"https://api.github.com/repos/airbnb/enzyme/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/enzyme/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/enzyme/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/enzyme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/enzyme/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/enzyme/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/enzyme/deployments","created_at":"2015-11-10T21:45:38Z","updated_at":"2016-05-10T13:01:12Z","pushed_at":"2016-05-10T13:07:03Z","git_url":"git://github.com/airbnb/enzyme.git","ssh_url":"git@github.com:airbnb/enzyme.git","clone_url":"https://github.com/airbnb/enzyme.git","svn_url":"https://github.com/airbnb/enzyme","homepage":"http://airbnb.io/enzyme/","size":1658,"stargazers_count":4808,"watchers_count":4808,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":237,"mirror_url":null,"open_issues_count":56,"forks":237,"open_issues":56,"watchers":4808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/enzyme/pulls/342"},"html":{"href":"https://github.com/airbnb/enzyme/pull/342"},"issue":{"href":"https://api.github.com/repos/airbnb/enzyme/issues/342"},"comments":{"href":"https://api.github.com/repos/airbnb/enzyme/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/enzyme/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/enzyme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/enzyme/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/enzyme/statuses/270a544ea53e824bbe7b4dae447e4b1ab0d75361"}}}}