{"action":"created","issue":{"url":"https://api.github.com/repos/nltk/nltk/issues/1319","repository_url":"https://api.github.com/repos/nltk/nltk","labels_url":"https://api.github.com/repos/nltk/nltk/issues/1319/labels{/name}","comments_url":"https://api.github.com/repos/nltk/nltk/issues/1319/comments","events_url":"https://api.github.com/repos/nltk/nltk/issues/1319/events","html_url":"https://github.com/nltk/nltk/pull/1319","id":138535676,"number":1319,"title":"Fixed the issue of the denominator always being 1 ","user":{"login":"josiahwang","id":13679011,"avatar_url":"https://avatars.githubusercontent.com/u/13679011?v=3","gravatar_id":"","url":"https://api.github.com/users/josiahwang","html_url":"https://github.com/josiahwang","followers_url":"https://api.github.com/users/josiahwang/followers","following_url":"https://api.github.com/users/josiahwang/following{/other_user}","gists_url":"https://api.github.com/users/josiahwang/gists{/gist_id}","starred_url":"https://api.github.com/users/josiahwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josiahwang/subscriptions","organizations_url":"https://api.github.com/users/josiahwang/orgs","repos_url":"https://api.github.com/users/josiahwang/repos","events_url":"https://api.github.com/users/josiahwang/events{/privacy}","received_events_url":"https://api.github.com/users/josiahwang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-04T17:36:09Z","updated_at":"2016-03-04T23:19:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nltk/nltk/pulls/1319","html_url":"https://github.com/nltk/nltk/pull/1319","diff_url":"https://github.com/nltk/nltk/pull/1319.diff","patch_url":"https://github.com/nltk/nltk/pull/1319.patch"},"body":"Fixed the issue of the denominator always being 1 if the numerator is 0, as Python normalizes fractions by default. This affects smoothing methods 3 and 4.\r\n\r\ne.g. Fraction(0,100) always returns Fraction(0,1) if \"_normalize = False\" is not set.\r\n\r\nOtherwise, the previous fix for smoothing method 3 does not do anything because the denominator is always 1!\r\n"},"comment":{"url":"https://api.github.com/repos/nltk/nltk/issues/comments/192516934","html_url":"https://github.com/nltk/nltk/pull/1319#issuecomment-192516934","issue_url":"https://api.github.com/repos/nltk/nltk/issues/1319","id":192516934,"user":{"login":"alvations","id":1050316,"avatar_url":"https://avatars.githubusercontent.com/u/1050316?v=3","gravatar_id":"","url":"https://api.github.com/users/alvations","html_url":"https://github.com/alvations","followers_url":"https://api.github.com/users/alvations/followers","following_url":"https://api.github.com/users/alvations/following{/other_user}","gists_url":"https://api.github.com/users/alvations/gists{/gist_id}","starred_url":"https://api.github.com/users/alvations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvations/subscriptions","organizations_url":"https://api.github.com/users/alvations/orgs","repos_url":"https://api.github.com/users/alvations/repos","events_url":"https://api.github.com/users/alvations/events{/privacy}","received_events_url":"https://api.github.com/users/alvations/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T23:19:30Z","updated_at":"2016-03-04T23:19:30Z","body":"I think it's okay to merge this for now. But we need to sit down and look through the equations seriously to come up with:\r\n\r\n 1. Code to emulate `mteval-13a.pl`\r\n 2. NLTK implementation of the BLEU that makes most sense to us.\r\n 3. Resolve the wack-a-mole fringe cases with a lot more unittests\r\n\r\n"}}