{"action":"closed","number":365,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/365","id":59307386,"html_url":"https://github.com/Valloric/ycmd/pull/365","diff_url":"https://github.com/Valloric/ycmd/pull/365.diff","patch_url":"https://github.com/Valloric/ycmd/pull/365.patch","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/365","number":365,"state":"closed","locked":false,"title":"[READY] Fix Python 2 support and add Python 3 support on Windows","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"body":"### Python 2 support \r\n\r\nWe cannot pass an environment variable containing unicode literals to `Popen` on Windows and Python2. Instead of converting all environment variables to native strings, we only convert the ones we use.\r\n\r\n### Python 3 support\r\n\r\nWe update the requests submodule to fix a compatibility error between requests and Python 3.5.\r\n\r\nFix from PR #211 is only needed for Python 2.\r\n\r\nIn `build.py`, we prepend the folder of the `ycm_core_tests` executable to the `PATH` instead of replacing it so that the executable is able to find the `python35.dll` library.\r\n\r\nWe don't reuse Omnisharp instances in C♯ tests on Windows and Python 3 because of the following random error occuring when running those tests:\r\n```python\r\nOSError: [WinError 6] The handle is invalid\r\n```\r\n\r\n### AppVeyor configuration\r\n\r\nWe append the `-DUSE_DEV_FLAGS=ON` option to `EXTRA_CMAKE_ARGS` environment variable in `run_tests.py` script in order to use `EXTRA_CMAKE_ARGS` when running tests. We need it on AppVeyor to tell CMake the correct path to the Python 3 library according to architecture. Otherwise, it always pick the 64 bits one. I can't reproduce this issue on my machine so I consider it is specific to AppVeyor.\r\n\r\nWe only do one run for MSVC 11, MSVC 12, and Python 2.7. This reduces the number of runs from 6 to 5.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/365)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-02-14T22:00:19Z","updated_at":"2016-02-15T20:06:45Z","closed_at":"2016-02-15T20:06:45Z","merged_at":"2016-02-15T20:06:45Z","merge_commit_sha":"59e4de2add7c4536a8e4388f1d81202f18f243fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Valloric/ycmd/pulls/365/commits","review_comments_url":"https://api.github.com/repos/Valloric/ycmd/pulls/365/comments","review_comment_url":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/365/comments","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/ef8fc8f8261b31f47630ac3b4fe1af17dbfd1f11","head":{"label":"micbou:windows-more-py3","ref":"windows-more-py3","sha":"ef8fc8f8261b31f47630ac3b4fe1af17dbfd1f11","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"repo":{"id":31660902,"name":"ycmd","full_name":"micbou/ycmd","owner":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micbou/ycmd","description":"A code-completion & code-comprehension server","fork":true,"url":"https://api.github.com/repos/micbou/ycmd","forks_url":"https://api.github.com/repos/micbou/ycmd/forks","keys_url":"https://api.github.com/repos/micbou/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micbou/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micbou/ycmd/teams","hooks_url":"https://api.github.com/repos/micbou/ycmd/hooks","issue_events_url":"https://api.github.com/repos/micbou/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/micbou/ycmd/events","assignees_url":"https://api.github.com/repos/micbou/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/micbou/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/micbou/ycmd/tags","blobs_url":"https://api.github.com/repos/micbou/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micbou/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micbou/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/micbou/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micbou/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/micbou/ycmd/languages","stargazers_url":"https://api.github.com/repos/micbou/ycmd/stargazers","contributors_url":"https://api.github.com/repos/micbou/ycmd/contributors","subscribers_url":"https://api.github.com/repos/micbou/ycmd/subscribers","subscription_url":"https://api.github.com/repos/micbou/ycmd/subscription","commits_url":"https://api.github.com/repos/micbou/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/micbou/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/micbou/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/micbou/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/micbou/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/micbou/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micbou/ycmd/merges","archive_url":"https://api.github.com/repos/micbou/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micbou/ycmd/downloads","issues_url":"https://api.github.com/repos/micbou/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/micbou/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/micbou/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/micbou/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micbou/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/micbou/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/micbou/ycmd/deployments","created_at":"2015-03-04T14:26:37Z","updated_at":"2016-01-24T23:33:30Z","pushed_at":"2016-02-15T15:56:27Z","git_url":"git://github.com/micbou/ycmd.git","ssh_url":"git@github.com:micbou/ycmd.git","clone_url":"https://github.com/micbou/ycmd.git","svn_url":"https://github.com/micbou/ycmd","homepage":null,"size":8445,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Valloric:more-py3","ref":"more-py3","sha":"0fd4acc91dbbb0a3a5f179fc2dbb647fbb4034de","user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"repo":{"id":19832415,"name":"ycmd","full_name":"Valloric/ycmd","owner":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Valloric/ycmd","description":"A code-completion & code-comprehension server","fork":false,"url":"https://api.github.com/repos/Valloric/ycmd","forks_url":"https://api.github.com/repos/Valloric/ycmd/forks","keys_url":"https://api.github.com/repos/Valloric/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Valloric/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Valloric/ycmd/teams","hooks_url":"https://api.github.com/repos/Valloric/ycmd/hooks","issue_events_url":"https://api.github.com/repos/Valloric/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/Valloric/ycmd/events","assignees_url":"https://api.github.com/repos/Valloric/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/Valloric/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/Valloric/ycmd/tags","blobs_url":"https://api.github.com/repos/Valloric/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Valloric/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Valloric/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Valloric/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Valloric/ycmd/languages","stargazers_url":"https://api.github.com/repos/Valloric/ycmd/stargazers","contributors_url":"https://api.github.com/repos/Valloric/ycmd/contributors","subscribers_url":"https://api.github.com/repos/Valloric/ycmd/subscribers","subscription_url":"https://api.github.com/repos/Valloric/ycmd/subscription","commits_url":"https://api.github.com/repos/Valloric/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Valloric/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Valloric/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Valloric/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Valloric/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/Valloric/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Valloric/ycmd/merges","archive_url":"https://api.github.com/repos/Valloric/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Valloric/ycmd/downloads","issues_url":"https://api.github.com/repos/Valloric/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/Valloric/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Valloric/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Valloric/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Valloric/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/Valloric/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/Valloric/ycmd/deployments","created_at":"2014-05-15T19:30:17Z","updated_at":"2016-02-15T19:04:39Z","pushed_at":"2016-02-15T20:06:45Z","git_url":"git://github.com/Valloric/ycmd.git","ssh_url":"git@github.com:Valloric/ycmd.git","clone_url":"https://github.com/Valloric/ycmd.git","svn_url":"https://github.com/Valloric/ycmd","homepage":null,"size":9436,"stargazers_count":500,"watchers_count":500,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"open_issues_count":35,"forks":278,"open_issues":35,"watchers":500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/365"},"html":{"href":"https://github.com/Valloric/ycmd/pull/365"},"issue":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/365"},"comments":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/Valloric/ycmd/statuses/ef8fc8f8261b31f47630ac3b4fe1af17dbfd1f11"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":6,"additions":56,"deletions":35,"changed_files":9}}