{"action":"created","issue":{"url":"https://api.github.com/repos/mlmorg/react-hyperscript/issues/18","repository_url":"https://api.github.com/repos/mlmorg/react-hyperscript","labels_url":"https://api.github.com/repos/mlmorg/react-hyperscript/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/mlmorg/react-hyperscript/issues/18/comments","events_url":"https://api.github.com/repos/mlmorg/react-hyperscript/issues/18/events","html_url":"https://github.com/mlmorg/react-hyperscript/pull/18","id":145583252,"number":18,"title":"Support dataset and attributes keys","user":{"login":"geelen","id":23264,"avatar_url":"https://avatars.githubusercontent.com/u/23264?v=3","gravatar_id":"","url":"https://api.github.com/users/geelen","html_url":"https://github.com/geelen","followers_url":"https://api.github.com/users/geelen/followers","following_url":"https://api.github.com/users/geelen/following{/other_user}","gists_url":"https://api.github.com/users/geelen/gists{/gist_id}","starred_url":"https://api.github.com/users/geelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geelen/subscriptions","organizations_url":"https://api.github.com/users/geelen/orgs","repos_url":"https://api.github.com/users/geelen/repos","events_url":"https://api.github.com/users/geelen/events{/privacy}","received_events_url":"https://api.github.com/users/geelen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-04T04:48:41Z","updated_at":"2016-04-04T05:54:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mlmorg/react-hyperscript/pulls/18","html_url":"https://github.com/mlmorg/react-hyperscript/pull/18","diff_url":"https://github.com/mlmorg/react-hyperscript/pull/18.diff","patch_url":"https://github.com/mlmorg/react-hyperscript/pull/18.patch"},"body":"In the virtual-dom hyperscript implementation, the properties `dataset` and `attributes` are nested properties that get translated onto the resulting node: https://github.com/Matt-Esch/virtual-dom/blob/903d884a8e4f05f303ec6f2b920a3b5237cf8b92/test/nested-properties.js#L45-L74\r\n\r\nThis does the same behaviour, allowing this project to support the use case of someone converting a project from virtual-dom to react-dom i.e. my use case :)\r\n\r\nCheers,\r\n-glen."},"comment":{"url":"https://api.github.com/repos/mlmorg/react-hyperscript/issues/comments/205146851","html_url":"https://github.com/mlmorg/react-hyperscript/pull/18#issuecomment-205146851","issue_url":"https://api.github.com/repos/mlmorg/react-hyperscript/issues/18","id":205146851,"user":{"login":"mlmorg","id":499279,"avatar_url":"https://avatars.githubusercontent.com/u/499279?v=3","gravatar_id":"","url":"https://api.github.com/users/mlmorg","html_url":"https://github.com/mlmorg","followers_url":"https://api.github.com/users/mlmorg/followers","following_url":"https://api.github.com/users/mlmorg/following{/other_user}","gists_url":"https://api.github.com/users/mlmorg/gists{/gist_id}","starred_url":"https://api.github.com/users/mlmorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlmorg/subscriptions","organizations_url":"https://api.github.com/users/mlmorg/orgs","repos_url":"https://api.github.com/users/mlmorg/repos","events_url":"https://api.github.com/users/mlmorg/events{/privacy}","received_events_url":"https://api.github.com/users/mlmorg/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T05:54:56Z","updated_at":"2016-04-04T05:54:56Z","body":"Thanks @geelen. Any chance you could add tests? I'll look at adding some tomorrow night if you don't have time."}}