{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/78421155","id":78421155,"diff_hunk":"@@ -183,9 +203,9 @@ private void writeObject(ObjectOutputStream stream) throws IOException {\n          */\n         stream.defaultWriteObject();\n \n-        stream.writeInt(descriptors.size());\n+        stream.writeInt(getAttributeDescriptors().size());","path":"catalog/core/catalog-core-api-impl/src/main/java/ddf/catalog/data/impl/MetacardTypeImpl.java","position":164,"original_position":164,"commit_id":"5fdda3e6a7b8d26fdc0787218ae5577fd512164c","original_commit_id":"5fdda3e6a7b8d26fdc0787218ae5577fd512164c","user":{"login":"jrnorth","id":4495447,"avatar_url":"https://avatars.githubusercontent.com/u/4495447?v=3","gravatar_id":"","url":"https://api.github.com/users/jrnorth","html_url":"https://github.com/jrnorth","followers_url":"https://api.github.com/users/jrnorth/followers","following_url":"https://api.github.com/users/jrnorth/following{/other_user}","gists_url":"https://api.github.com/users/jrnorth/gists{/gist_id}","starred_url":"https://api.github.com/users/jrnorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrnorth/subscriptions","organizations_url":"https://api.github.com/users/jrnorth/orgs","repos_url":"https://api.github.com/users/jrnorth/repos","events_url":"https://api.github.com/users/jrnorth/events{/privacy}","received_events_url":"https://api.github.com/users/jrnorth/received_events","type":"User","site_admin":false},"body":"Could save the result of `getAttributeDescriptors()` to a local variable since you're using it twice.","created_at":"2016-09-12T17:53:48Z","updated_at":"2016-09-12T17:53:48Z","html_url":"https://github.com/codice/ddf/pull/1222#discussion_r78421155","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/1222","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/78421155"},"html":{"href":"https://github.com/codice/ddf/pull/1222#discussion_r78421155"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/1222"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1222","id":83684226,"html_url":"https://github.com/codice/ddf/pull/1222","diff_url":"https://github.com/codice/ddf/pull/1222.diff","patch_url":"https://github.com/codice/ddf/pull/1222.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/1222","number":1222,"state":"open","locked":false,"title":"DDF-2450: Refactored MetacardTypeImpl","user":{"login":"rzwiefel","id":9013416,"avatar_url":"https://avatars.githubusercontent.com/u/9013416?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nfixes metacardtypeimpl to only prevent more than one attribute per name\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@bdeining @jrnorth\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n\r\n@jlcsmith\r\n@pklinef\r\n\r\n\r\n - Refactored MetacardTypeImpl to perform fast attribute lookup and reduced\r\n  side effect methods. Also now protects again adding attributes with the same\r\n  name.","created_at":"2016-09-01T18:36:45Z","updated_at":"2016-09-12T17:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e93ccb3055fd2b19c7e3fdd7f8f150549e552cb5","assignee":{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"assignees":[{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},{"login":"jlcsmith","id":4503545,"avatar_url":"https://avatars.githubusercontent.com/u/4503545?v=3","gravatar_id":"","url":"https://api.github.com/users/jlcsmith","html_url":"https://github.com/jlcsmith","followers_url":"https://api.github.com/users/jlcsmith/followers","following_url":"https://api.github.com/users/jlcsmith/following{/other_user}","gists_url":"https://api.github.com/users/jlcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jlcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlcsmith/subscriptions","organizations_url":"https://api.github.com/users/jlcsmith/orgs","repos_url":"https://api.github.com/users/jlcsmith/repos","events_url":"https://api.github.com/users/jlcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jlcsmith/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/1222/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/1222/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1222/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/5fdda3e6a7b8d26fdc0787218ae5577fd512164c","head":{"label":"rzwiefel:DDF-2450-metacardtypeimpl-refactor","ref":"DDF-2450-metacardtypeimpl-refactor","sha":"5fdda3e6a7b8d26fdc0787218ae5577fd512164c","user":{"login":"rzwiefel","id":9013416,"avatar_url":"https://avatars.githubusercontent.com/u/9013416?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},"repo":{"id":37286795,"name":"ddf","full_name":"rzwiefel/ddf","owner":{"login":"rzwiefel","id":9013416,"avatar_url":"https://avatars.githubusercontent.com/u/9013416?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rzwiefel/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/rzwiefel/ddf","forks_url":"https://api.github.com/repos/rzwiefel/ddf/forks","keys_url":"https://api.github.com/repos/rzwiefel/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rzwiefel/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rzwiefel/ddf/teams","hooks_url":"https://api.github.com/repos/rzwiefel/ddf/hooks","issue_events_url":"https://api.github.com/repos/rzwiefel/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/rzwiefel/ddf/events","assignees_url":"https://api.github.com/repos/rzwiefel/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/rzwiefel/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/rzwiefel/ddf/tags","blobs_url":"https://api.github.com/repos/rzwiefel/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rzwiefel/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rzwiefel/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rzwiefel/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rzwiefel/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/rzwiefel/ddf/languages","stargazers_url":"https://api.github.com/repos/rzwiefel/ddf/stargazers","contributors_url":"https://api.github.com/repos/rzwiefel/ddf/contributors","subscribers_url":"https://api.github.com/repos/rzwiefel/ddf/subscribers","subscription_url":"https://api.github.com/repos/rzwiefel/ddf/subscription","commits_url":"https://api.github.com/repos/rzwiefel/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rzwiefel/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rzwiefel/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rzwiefel/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rzwiefel/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/rzwiefel/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rzwiefel/ddf/merges","archive_url":"https://api.github.com/repos/rzwiefel/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rzwiefel/ddf/downloads","issues_url":"https://api.github.com/repos/rzwiefel/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/rzwiefel/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/rzwiefel/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/rzwiefel/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rzwiefel/ddf/labels{/name}","releases_url":"https://api.github.com/repos/rzwiefel/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/rzwiefel/ddf/deployments","created_at":"2015-06-11T21:19:40Z","updated_at":"2016-02-01T21:59:06Z","pushed_at":"2016-09-08T15:23:09Z","git_url":"git://github.com/rzwiefel/ddf.git","ssh_url":"git@github.com:rzwiefel/ddf.git","clone_url":"https://github.com/rzwiefel/ddf.git","svn_url":"https://github.com/rzwiefel/ddf","homepage":"","size":150116,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"0ca1f0d530f1819884c75a5b6b70a2b6e8e31f2a","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-08-30T00:53:22Z","pushed_at":"2016-09-12T17:17:39Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":286789,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":39,"forks":90,"open_issues":39,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/1222"},"html":{"href":"https://github.com/codice/ddf/pull/1222"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/1222"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/1222/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/1222/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/1222/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/5fdda3e6a7b8d26fdc0787218ae5577fd512164c"}}}}
{"actor":{"display_login":"jrnorth"}}