{"action":"created","comment":{"url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments/72457585","id":72457585,"diff_hunk":"@@ -43,7 +43,7 @@\n     \"json-stable-stringify\": \"1.0.1\",\n     \"json2yaml\": \"^1.1.0\",\n     \"jsonwebtoken\": \"^7.0.1\",\n-    \"kuzzle-common-objects\": \"^1.0.0\",\n+    \"kuzzle-common-objects\": \"^1.0.1\",","path":"package.json","position":5,"original_position":5,"commit_id":"60baff9a32b1d8a9731a04edf64cc04325133c4f","original_commit_id":"60baff9a32b1d8a9731a04edf64cc04325133c4f","user":{"login":"scottinet","id":12997967,"avatar_url":"https://avatars.githubusercontent.com/u/12997967?v=3","gravatar_id":"","url":"https://api.github.com/users/scottinet","html_url":"https://github.com/scottinet","followers_url":"https://api.github.com/users/scottinet/followers","following_url":"https://api.github.com/users/scottinet/following{/other_user}","gists_url":"https://api.github.com/users/scottinet/gists{/gist_id}","starred_url":"https://api.github.com/users/scottinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottinet/subscriptions","organizations_url":"https://api.github.com/users/scottinet/orgs","repos_url":"https://api.github.com/users/scottinet/repos","events_url":"https://api.github.com/users/scottinet/events{/privacy}","received_events_url":"https://api.github.com/users/scottinet/received_events","type":"User","site_admin":false},"body":"It's 1.0.2 now :-)","created_at":"2016-07-27T15:07:47Z","updated_at":"2016-07-27T15:07:47Z","html_url":"https://github.com/kuzzleio/kuzzle/pull/354#discussion_r72457585","pull_request_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments/72457585"},"html":{"href":"https://github.com/kuzzleio/kuzzle/pull/354#discussion_r72457585"},"pull_request":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354","id":78818193,"html_url":"https://github.com/kuzzleio/kuzzle/pull/354","diff_url":"https://github.com/kuzzleio/kuzzle/pull/354.diff","patch_url":"https://github.com/kuzzleio/kuzzle/pull/354.patch","issue_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/354","number":354,"state":"open","locked":false,"title":"kuz-600 kuz-623 - create first admin & remote actions refactor","user":{"login":"benoitvidis","id":6680551,"avatar_url":"https://avatars.githubusercontent.com/u/6680551?v=3","gravatar_id":"","url":"https://api.github.com/users/benoitvidis","html_url":"https://github.com/benoitvidis","followers_url":"https://api.github.com/users/benoitvidis/followers","following_url":"https://api.github.com/users/benoitvidis/following{/other_user}","gists_url":"https://api.github.com/users/benoitvidis/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitvidis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitvidis/subscriptions","organizations_url":"https://api.github.com/users/benoitvidis/orgs","repos_url":"https://api.github.com/users/benoitvidis/repos","events_url":"https://api.github.com/users/benoitvidis/events{/privacy}","received_events_url":"https://api.github.com/users/benoitvidis/received_events","type":"User","site_admin":false},"body":"I apologize, this PR was initially meant to cover the migration of the create first admin command to use some remote actions.\r\nIt ended up implementing some of the refactors from kuz-623 and some other changes that may need to be discussed :confused:.\r\n\r\n# Changelog\r\n\r\n## createFirstAdmin\r\n\r\n* Moved to a remote action\r\n* Subsequently, the `pid` parameter now becomes mandatory.\r\n* Removed all constraints regarding login and password choice. The only constraint left is that a login cannot be empty (password can be).\r\n\r\n## remoteActions \"clients\" (/lib/api/remoteActions/*)\r\n\r\n* Removed the need to crete one file per action to call.\r\n\r\n## remoteActionsController\r\n\r\n* Fixed a  very nasty situation where some actions where using `this` while not having been invoked using `new`. As a result, the context was populated with some internal properties of the actions.\r\n* All actions now take as a RequestObject object for input, like any other controller actions.\r\n* Removed all `console.log` calls. I believe the message displayed to the end user should be done by the cli component.\r\n\r\n### cleanDb\r\n\r\n* Now deletes Kuzzle internal index only. The business data if any are left intact.\r\n\r\n\r\n\r\n","created_at":"2016-07-26T09:23:54Z","updated_at":"2016-07-27T15:07:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a7db391ceb946795fb0c32c7e898d71a97d1b0b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354/commits","review_comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354/comments","review_comment_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/354/comments","statuses_url":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/60baff9a32b1d8a9731a04edf64cc04325133c4f","head":{"label":"kuzzleio:kuz-600-create-first-admin","ref":"kuz-600-create-first-admin","sha":"60baff9a32b1d8a9731a04edf64cc04325133c4f","user":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":41084349,"name":"kuzzle","full_name":"kuzzleio/kuzzle","owner":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuzzleio/kuzzle","description":"Open-source Back-end, self-hostable & ready to use - Real-time, storage, advanced search - Web, Apps, Mobile, IoT -","fork":false,"url":"https://api.github.com/repos/kuzzleio/kuzzle","forks_url":"https://api.github.com/repos/kuzzleio/kuzzle/forks","keys_url":"https://api.github.com/repos/kuzzleio/kuzzle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/kuzzle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/kuzzle/teams","hooks_url":"https://api.github.com/repos/kuzzleio/kuzzle/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/kuzzle/events","assignees_url":"https://api.github.com/repos/kuzzleio/kuzzle/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/kuzzle/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/tags","blobs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/kuzzle/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/kuzzle/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/kuzzle/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscription","commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/kuzzle/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/kuzzle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/kuzzle/merges","archive_url":"https://api.github.com/repos/kuzzleio/kuzzle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/kuzzle/downloads","issues_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/kuzzle/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/kuzzle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/kuzzle/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/kuzzle/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/kuzzle/deployments","created_at":"2015-08-20T08:26:57Z","updated_at":"2016-07-26T08:02:09Z","pushed_at":"2016-07-27T14:21:46Z","git_url":"git://github.com/kuzzleio/kuzzle.git","ssh_url":"git@github.com:kuzzleio/kuzzle.git","clone_url":"https://github.com/kuzzleio/kuzzle.git","svn_url":"https://github.com/kuzzleio/kuzzle","homepage":"http://kuzzle.io","size":8073,"stargazers_count":307,"watchers_count":307,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":9,"forks":14,"open_issues":9,"watchers":307,"default_branch":"master"}},"base":{"label":"kuzzleio:develop","ref":"develop","sha":"4efea78776a2e220fa7b613f084f810bc2805574","user":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":41084349,"name":"kuzzle","full_name":"kuzzleio/kuzzle","owner":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuzzleio/kuzzle","description":"Open-source Back-end, self-hostable & ready to use - Real-time, storage, advanced search - Web, Apps, Mobile, IoT -","fork":false,"url":"https://api.github.com/repos/kuzzleio/kuzzle","forks_url":"https://api.github.com/repos/kuzzleio/kuzzle/forks","keys_url":"https://api.github.com/repos/kuzzleio/kuzzle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/kuzzle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/kuzzle/teams","hooks_url":"https://api.github.com/repos/kuzzleio/kuzzle/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/kuzzle/events","assignees_url":"https://api.github.com/repos/kuzzleio/kuzzle/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/kuzzle/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/tags","blobs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/kuzzle/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/kuzzle/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/kuzzle/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/kuzzle/subscription","commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/kuzzle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/kuzzle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/kuzzle/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/kuzzle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/kuzzle/merges","archive_url":"https://api.github.com/repos/kuzzleio/kuzzle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/kuzzle/downloads","issues_url":"https://api.github.com/repos/kuzzleio/kuzzle/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/kuzzle/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/kuzzle/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/kuzzle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/kuzzle/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/kuzzle/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/kuzzle/deployments","created_at":"2015-08-20T08:26:57Z","updated_at":"2016-07-26T08:02:09Z","pushed_at":"2016-07-27T14:21:46Z","git_url":"git://github.com/kuzzleio/kuzzle.git","ssh_url":"git@github.com:kuzzleio/kuzzle.git","clone_url":"https://github.com/kuzzleio/kuzzle.git","svn_url":"https://github.com/kuzzleio/kuzzle","homepage":"http://kuzzle.io","size":8073,"stargazers_count":307,"watchers_count":307,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":9,"forks":14,"open_issues":9,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354"},"html":{"href":"https://github.com/kuzzleio/kuzzle/pull/354"},"issue":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/issues/354"},"comments":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/kuzzleio/kuzzle/statuses/60baff9a32b1d8a9731a04edf64cc04325133c4f"}}}}
{"actor":{"display_login":"scottinet"}}