{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/52850409","id":52850409,"diff_hunk":"@@ -3286,17 +3288,28 @@ static void syn_cmd_off(exarg_T *eap, int syncing)\n }\n \n static void syn_cmd_onoff(exarg_T *eap, char *name)\n+  FUNC_ATTR_NONNULL_ALL\n {\n-  char buf[100];\n-\n+  did_syntax_onoff = true;\n   eap->nextcmd = check_nextcmd(eap->arg);\n   if (!eap->skip) {\n-    strcpy(buf, \"so \");\n+    char buf[100];\n+    strncpy(buf, \"so \", 3);","path":"src/nvim/syntax.c","position":22,"original_position":22,"commit_id":"cc2dce45d09fab2ec2269924942fdca7d5643e63","original_commit_id":"cc2dce45d09fab2ec2269924942fdca7d5643e63","user":{"login":"fmoralesc","id":221465,"avatar_url":"https://avatars.githubusercontent.com/u/221465?v=3","gravatar_id":"","url":"https://api.github.com/users/fmoralesc","html_url":"https://github.com/fmoralesc","followers_url":"https://api.github.com/users/fmoralesc/followers","following_url":"https://api.github.com/users/fmoralesc/following{/other_user}","gists_url":"https://api.github.com/users/fmoralesc/gists{/gist_id}","starred_url":"https://api.github.com/users/fmoralesc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmoralesc/subscriptions","organizations_url":"https://api.github.com/users/fmoralesc/orgs","repos_url":"https://api.github.com/users/fmoralesc/repos","events_url":"https://api.github.com/users/fmoralesc/events{/privacy}","received_events_url":"https://api.github.com/users/fmoralesc/received_events","type":"User","site_admin":false},"body":"@justinmk As a fix to the issue you mention, perhaps change this to `strncpy(buf, \"silent! so \", 11);`, perhaps conditional on the global `starting` != 0.","created_at":"2016-02-14T22:48:57Z","updated_at":"2016-02-14T22:48:57Z","html_url":"https://github.com/neovim/neovim/pull/4252#discussion_r52850409","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/4252","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/52850409"},"html":{"href":"https://github.com/neovim/neovim/pull/4252#discussion_r52850409"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4252"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/4252","id":59280096,"html_url":"https://github.com/neovim/neovim/pull/4252","diff_url":"https://github.com/neovim/neovim/pull/4252.diff","patch_url":"https://github.com/neovim/neovim/pull/4252.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/4252","number":4252,"state":"closed","locked":false,"title":"defaults: Enable filetypes, syntax","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-13T22:31:29Z","updated_at":"2016-02-14T22:48:57Z","closed_at":"2016-02-14T22:20:55Z","merged_at":"2016-02-14T22:20:55Z","merge_commit_sha":"5407e472a4b74a4a1748b7f60c02614fcee06ab9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/4252/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/4252/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/4252/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/cc2dce45d09fab2ec2269924942fdca7d5643e63","head":{"label":"justinmk:filetype","ref":"filetype","sha":"cc2dce45d09fab2ec2269924942fdca7d5643e63","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"repo":{"id":17302877,"name":"neovim","full_name":"justinmk/neovim","owner":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinmk/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/justinmk/neovim","forks_url":"https://api.github.com/repos/justinmk/neovim/forks","keys_url":"https://api.github.com/repos/justinmk/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinmk/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinmk/neovim/teams","hooks_url":"https://api.github.com/repos/justinmk/neovim/hooks","issue_events_url":"https://api.github.com/repos/justinmk/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/justinmk/neovim/events","assignees_url":"https://api.github.com/repos/justinmk/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/justinmk/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/justinmk/neovim/tags","blobs_url":"https://api.github.com/repos/justinmk/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinmk/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinmk/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinmk/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinmk/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/justinmk/neovim/languages","stargazers_url":"https://api.github.com/repos/justinmk/neovim/stargazers","contributors_url":"https://api.github.com/repos/justinmk/neovim/contributors","subscribers_url":"https://api.github.com/repos/justinmk/neovim/subscribers","subscription_url":"https://api.github.com/repos/justinmk/neovim/subscription","commits_url":"https://api.github.com/repos/justinmk/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinmk/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinmk/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinmk/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinmk/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/justinmk/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinmk/neovim/merges","archive_url":"https://api.github.com/repos/justinmk/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinmk/neovim/downloads","issues_url":"https://api.github.com/repos/justinmk/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/justinmk/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/justinmk/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/justinmk/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinmk/neovim/labels{/name}","releases_url":"https://api.github.com/repos/justinmk/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/justinmk/neovim/deployments","created_at":"2014-02-28T23:17:54Z","updated_at":"2014-12-29T18:58:05Z","pushed_at":"2016-02-14T22:20:57Z","git_url":"git://github.com/justinmk/neovim.git","ssh_url":"git@github.com:justinmk/neovim.git","clone_url":"https://github.com/justinmk/neovim.git","svn_url":"https://github.com/justinmk/neovim","homepage":"http://neovim.org/","size":36401,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"75f6817a5161949ca2ab08e36b8e0772b8d7da16","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility. Consider helping sustain Neovim development! ","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2016-02-14T22:05:17Z","pushed_at":"2016-02-14T22:20:57Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":59151,"stargazers_count":17270,"watchers_count":17270,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1228,"mirror_url":null,"open_issues_count":644,"forks":1228,"open_issues":644,"watchers":17270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4252"},"html":{"href":"https://github.com/neovim/neovim/pull/4252"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/4252"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/4252/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4252/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4252/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/cc2dce45d09fab2ec2269924942fdca7d5643e63"}}}}