{"action":"closed","number":10268,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10268","id":91264625,"html_url":"https://github.com/cockroachdb/cockroach/pull/10268","diff_url":"https://github.com/cockroachdb/cockroach/pull/10268.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10268.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10268","number":10268,"state":"closed","locked":false,"title":"k8s: Fix potential edge case where a second cluster could get started","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"body":"- Add an init container that checks for whether any other peers exist\n- Re-enable the tolerate-unready-endpoints option. It's bprashanth's\n  recommendation, and makes the init container less likely to miss\n  anything.\n- Switch from joining `cockroachdb` to joining `cockroachdb-public`.\n  This is needed due to re-enabling `tolerate-unready-endpoints`.\n\nI wish we could just directly re-use the peer-finder container without\nhaving to wrap it, but I already burned too much time trying to get it\nto accepts non-trivial commands in its `--on-start` parameter. Almost\neverything I tried would just get treated to a \"No such file or\ndirectory\" error.\n\n@tschottdorf @bprashanth\n\n<!-- Reviewable:start -->\n---\n\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10268)\n\n<!-- Reviewable:end -->\n","created_at":"2016-10-27T19:26:31Z","updated_at":"2016-10-31T22:36:37Z","closed_at":"2016-10-31T22:36:37Z","merged_at":"2016-10-31T22:36:37Z","merge_commit_sha":"8285cc972728b92eed045e230b02e44ba396d05e","assignee":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"assignees":[{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10268/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10268/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10268/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/064401e4b03e18b5c165bcc905b28764c9495ad9","head":{"label":"a-robinson:initcon","ref":"initcon","sha":"064401e4b03e18b5c165bcc905b28764c9495ad9","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"repo":{"id":60129294,"name":"cockroach","full_name":"a-robinson/cockroach","owner":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-robinson/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/a-robinson/cockroach","forks_url":"https://api.github.com/repos/a-robinson/cockroach/forks","keys_url":"https://api.github.com/repos/a-robinson/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-robinson/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-robinson/cockroach/teams","hooks_url":"https://api.github.com/repos/a-robinson/cockroach/hooks","issue_events_url":"https://api.github.com/repos/a-robinson/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/a-robinson/cockroach/events","assignees_url":"https://api.github.com/repos/a-robinson/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/a-robinson/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/a-robinson/cockroach/tags","blobs_url":"https://api.github.com/repos/a-robinson/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-robinson/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-robinson/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-robinson/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-robinson/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/a-robinson/cockroach/languages","stargazers_url":"https://api.github.com/repos/a-robinson/cockroach/stargazers","contributors_url":"https://api.github.com/repos/a-robinson/cockroach/contributors","subscribers_url":"https://api.github.com/repos/a-robinson/cockroach/subscribers","subscription_url":"https://api.github.com/repos/a-robinson/cockroach/subscription","commits_url":"https://api.github.com/repos/a-robinson/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-robinson/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-robinson/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-robinson/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-robinson/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/a-robinson/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-robinson/cockroach/merges","archive_url":"https://api.github.com/repos/a-robinson/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-robinson/cockroach/downloads","issues_url":"https://api.github.com/repos/a-robinson/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/a-robinson/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/a-robinson/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/a-robinson/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-robinson/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/a-robinson/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/a-robinson/cockroach/deployments","created_at":"2016-05-31T22:58:50Z","updated_at":"2016-06-02T14:10:26Z","pushed_at":"2016-10-31T14:47:56Z","git_url":"git://github.com/a-robinson/cockroach.git","ssh_url":"git@github.com:a-robinson/cockroach.git","clone_url":"https://github.com/a-robinson/cockroach.git","svn_url":"https://github.com/a-robinson/cockroach","homepage":"https://www.cockroachlabs.com","size":199816,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"ffb34cc64e226536ef1da5c57f3c8788ea3669cd","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-10-31T16:11:16Z","pushed_at":"2016-10-31T22:36:37Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":384268,"stargazers_count":7792,"watchers_count":7792,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":779,"mirror_url":null,"open_issues_count":772,"forks":779,"open_issues":772,"watchers":7792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10268"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/10268"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/10268"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/10268/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10268/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10268/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/064401e4b03e18b5c165bcc905b28764c9495ad9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":1,"additions":121,"deletions":24,"changed_files":5}}
{"actor":{"display_login":"a-robinson"}}