{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/3410","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/3410/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/3410/comments","events_url":"https://api.github.com/repos/minio/minio/issues/3410/events","html_url":"https://github.com/minio/minio/pull/3410","id":193903463,"number":3410,"title":"objcache: Create returns full cache if maxsize = 0","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-06T22:26:58Z","updated_at":"2016-12-06T22:26:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/3410","html_url":"https://github.com/minio/minio/pull/3410","diff_url":"https://github.com/minio/minio/pull/3410.diff","patch_url":"https://github.com/minio/minio/pull/3410.patch"},"body":"## Description\r\nCreate() doesn't seem to handle the case when maxSize is incorrectly\r\nset as zero which leads to an infinite cache size\r\n\r\n## Motivation and Context\r\nPossible correction of https://github.com/minio/minio/issues/3403\r\n\r\n## How Has This Been Tested?\r\ngo test\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/265293191","html_url":"https://github.com/minio/minio/pull/3410#issuecomment-265293191","issue_url":"https://api.github.com/repos/minio/minio/issues/3410","id":265293191,"user":{"login":"mention-bot","id":15710697,"avatar_url":"https://avatars.githubusercontent.com/u/15710697?v=3","gravatar_id":"","url":"https://api.github.com/users/mention-bot","html_url":"https://github.com/mention-bot","followers_url":"https://api.github.com/users/mention-bot/followers","following_url":"https://api.github.com/users/mention-bot/following{/other_user}","gists_url":"https://api.github.com/users/mention-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mention-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mention-bot/subscriptions","organizations_url":"https://api.github.com/users/mention-bot/orgs","repos_url":"https://api.github.com/users/mention-bot/repos","events_url":"https://api.github.com/users/mention-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mention-bot/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T22:26:59Z","updated_at":"2016-12-06T22:26:59Z","body":"@vadmeste, thanks for your PR! By analyzing the history of the files in this pull request, we identified @harshavardhana, @krishnasrinivas and @krisis to be potential reviewers."}}
{"actor":{"display_login":"mention-bot"}}