{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/62275075","id":62275075,"diff_hunk":"@@ -106,4 +106,10 @@ __declspec(noinline) void FromDOM_NoScriptScope_fatal_error()\n     ReportFatalException(NULL, E_UNEXPECTED, EnterScript_FromDOM_NoScriptScope, scenario);\n }\n \n+__declspec(noinline) void Debugger_AttachDetach_fatal_error()\n+{\n+    int scenario = 5;","path":"lib/Common/Exceptions/ReportError.cpp","position":6,"original_position":6,"commit_id":"dcb4a43c880d858598e5878acf153c3451baf43d","original_commit_id":"dcb4a43c880d858598e5878acf153c3451baf43d","user":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"body":"It is an unused parameter which was put with the idea to group different kinds of fata error, but is not used. All other functions have this. I can put any number.","created_at":"2016-05-06T00:15:08Z","updated_at":"2016-05-06T00:15:08Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/931#discussion_r62275075","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/62275075"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/931#discussion_r62275075"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931","id":69088212,"html_url":"https://github.com/Microsoft/ChakraCore/pull/931","diff_url":"https://github.com/Microsoft/ChakraCore/pull/931.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/931.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/931","number":931,"state":"open","locked":false,"title":"If debugger attach/detach fails terminate the process as we can't recover from failure during attach/detach","user":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"body":"Fixes VSO bug 4158821","created_at":"2016-05-05T23:49:34Z","updated_at":"2016-05-06T00:15:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1bd59fa9485a69051f282686c29bc939b88087d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/931/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/dcb4a43c880d858598e5878acf153c3451baf43d","head":{"label":"agarwal-sandeep:reparseoomfix","ref":"reparseoomfix","sha":"dcb4a43c880d858598e5878acf153c3451baf43d","user":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"repo":{"id":51044322,"name":"ChakraCore","full_name":"agarwal-sandeep/ChakraCore","owner":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agarwal-sandeep/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore","forks_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/forks","keys_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/teams","hooks_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/events","assignees_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/tags","blobs_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/subscription","commits_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/merges","archive_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/downloads","issues_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/agarwal-sandeep/ChakraCore/deployments","created_at":"2016-02-04T01:40:19Z","updated_at":"2016-02-04T01:40:34Z","pushed_at":"2016-05-05T23:49:34Z","git_url":"git://github.com/agarwal-sandeep/ChakraCore.git","ssh_url":"git@github.com:agarwal-sandeep/ChakraCore.git","clone_url":"https://github.com/agarwal-sandeep/ChakraCore.git","svn_url":"https://github.com/agarwal-sandeep/ChakraCore","homepage":null,"size":25597,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"ecc9055553ee47e1ae579caf9e8c9148b8fc679f","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-05-05T15:02:28Z","pushed_at":"2016-05-05T23:59:57Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":33896,"stargazers_count":5175,"watchers_count":5175,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":569,"mirror_url":null,"open_issues_count":128,"forks":569,"open_issues":128,"watchers":5175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/931"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/931"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/931/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/931/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/dcb4a43c880d858598e5878acf153c3451baf43d"}}}}