{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/84201228","pull_request_review_id":4992802,"id":84201228,"diff_hunk":"@@ -223,8 +223,8 @@ var _ = framework.KubeDescribe(\"PetSet [Slow] [Feature:PetSet]\", func() {\n \t\t\t}\n \n \t\t\tBy(\"Reading value under foo from member with index 2\")\n-\t\t\tif v := pet.read(2, \"foo\"); v != \"bar\" {\n-\t\t\t\tframework.Failf(\"Read unexpected value %v, expected bar under key foo\", v)\n+\t\t\tif err := pollReadWithTimeout(pet, 2, \"foo\", \"bar\"); err != nil {","path":"test/e2e/petset.go","position":17,"original_position":17,"commit_id":"049459b4522bff9fc05753b5d9aaa5ae2b99c311","original_commit_id":"38a6f38c6d89103f3b9c816058092d8616328436","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"body":"Fixed by changing `pollReadWithTimeout` to return easier to read errors.","created_at":"2016-10-20T01:49:38Z","updated_at":"2016-10-20T01:49:38Z","html_url":"https://github.com/kubernetes/kubernetes/pull/35158#discussion_r84201228","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/84201228"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/35158#discussion_r84201228"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158","id":90091790,"html_url":"https://github.com/kubernetes/kubernetes/pull/35158","diff_url":"https://github.com/kubernetes/kubernetes/pull/35158.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/35158.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35158","number":35158,"state":"open","locked":false,"title":"Fixing flakes caused by petset tests.","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**: We should wait till the key/value has been replicated to database slaves before trying to read from them.\r\n\r\n**Which issue this PR fixes** Fixes https://github.com/kubernetes/kubernetes/issues/33904, https://github.com/kubernetes/kubernetes/issues/33895\r\n\r\ncc @kubernetes/sig-apps\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/35158)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-10-19T21:13:25Z","updated_at":"2016-10-20T01:49:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf61f8c8274383f489fcee890ea6b1ae7729a3ab","assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"assignees":[{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":223,"closed_issues":171,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-10-20T00:28:52Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35158/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/049459b4522bff9fc05753b5d9aaa5ae2b99c311","head":{"label":"foxish:petset-redis-fix","ref":"petset-redis-fix","sha":"049459b4522bff9fc05753b5d9aaa5ae2b99c311","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"repo":{"id":62426557,"name":"kubernetes","full_name":"foxish/kubernetes","owner":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foxish/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/foxish/kubernetes","forks_url":"https://api.github.com/repos/foxish/kubernetes/forks","keys_url":"https://api.github.com/repos/foxish/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxish/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxish/kubernetes/teams","hooks_url":"https://api.github.com/repos/foxish/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/foxish/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/foxish/kubernetes/events","assignees_url":"https://api.github.com/repos/foxish/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/foxish/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/foxish/kubernetes/tags","blobs_url":"https://api.github.com/repos/foxish/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxish/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxish/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxish/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxish/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/foxish/kubernetes/languages","stargazers_url":"https://api.github.com/repos/foxish/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/foxish/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/foxish/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/foxish/kubernetes/subscription","commits_url":"https://api.github.com/repos/foxish/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxish/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxish/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxish/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxish/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/foxish/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxish/kubernetes/merges","archive_url":"https://api.github.com/repos/foxish/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxish/kubernetes/downloads","issues_url":"https://api.github.com/repos/foxish/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/foxish/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/foxish/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/foxish/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxish/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/foxish/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/foxish/kubernetes/deployments","created_at":"2016-07-02T00:30:27Z","updated_at":"2016-07-02T00:30:44Z","pushed_at":"2016-10-20T01:48:04Z","git_url":"git://github.com/foxish/kubernetes.git","ssh_url":"git@github.com:foxish/kubernetes.git","clone_url":"https://github.com/foxish/kubernetes.git","svn_url":"https://github.com/foxish/kubernetes","homepage":"http://kubernetes.io","size":339476,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7007064e1ed06d48c5aec100a74f3dcff12ff98d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-10-20T01:23:01Z","pushed_at":"2016-10-20T01:49:22Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":598588,"stargazers_count":17726,"watchers_count":17726,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5769,"mirror_url":null,"open_issues_count":4959,"forks":5769,"open_issues":4959,"watchers":17726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/35158"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/35158"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/35158/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35158/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/049459b4522bff9fc05753b5d9aaa5ae2b99c311"}}}}
{"actor":{"display_login":"foxish"}}