{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/50284391","id":50284391,"diff_hunk":"@@ -41,11 +41,30 @@\n   (dofor [f (seq (.getFields Config))]\n          (.get f nil)))\n \n-\n+;; TODO this function and its callings will be replace when nimbus and supervisor move to Java","path":"storm-core/src/clj/org/apache/storm/config.clj","position":23,"original_position":23,"commit_id":"b7374d2bb4cf49111936ec1cbd2a4f4f22661100","original_commit_id":"b7374d2bb4cf49111936ec1cbd2a4f4f22661100","user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"body":"Don't need the TODO.  Please file a separate JIRA to remove the code when it is no longer needed.  You can leave the comment, but preferably with the JIRA number instead.","created_at":"2016-01-20T17:08:15Z","updated_at":"2016-01-20T17:08:15Z","html_url":"https://github.com/apache/storm/pull/1030#discussion_r50284391","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/1030","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/50284391"},"html":{"href":"https://github.com/apache/storm/pull/1030#discussion_r50284391"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/1030"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1030","id":56627774,"html_url":"https://github.com/apache/storm/pull/1030","diff_url":"https://github.com/apache/storm/pull/1030.diff","patch_url":"https://github.com/apache/storm/pull/1030.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1030","number":1030,"state":"open","locked":false,"title":"[STORM-1227] port org.apache.storm.config to java","user":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"body":"1. Port \"org.apache.storm.config\" to java at \"org.apache.storm.config.ConfigUtils\".\r\n2. Update all the callings to the config functions.\r\n3. Mock the java static functions for test purposes.\r\n4. Address issues in unit and manual tests.\r\n5. Comment out most functions in config.clj except a few: cluster-mode (used in multimethod),  ALL-CONFIGS, clojure-config-name.\r\n","created_at":"2016-01-20T16:03:42Z","updated_at":"2016-01-20T17:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ded181a7c762c61bcf5a7c95332dc9064db25c93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1030/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1030/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1030/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/b7374d2bb4cf49111936ec1cbd2a4f4f22661100","head":{"label":"zhuoliu:1227","ref":"1227","sha":"b7374d2bb4cf49111936ec1cbd2a4f4f22661100","user":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"repo":{"id":32997908,"name":"storm","full_name":"zhuoliu/storm","owner":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhuoliu/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/zhuoliu/storm","forks_url":"https://api.github.com/repos/zhuoliu/storm/forks","keys_url":"https://api.github.com/repos/zhuoliu/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhuoliu/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhuoliu/storm/teams","hooks_url":"https://api.github.com/repos/zhuoliu/storm/hooks","issue_events_url":"https://api.github.com/repos/zhuoliu/storm/issues/events{/number}","events_url":"https://api.github.com/repos/zhuoliu/storm/events","assignees_url":"https://api.github.com/repos/zhuoliu/storm/assignees{/user}","branches_url":"https://api.github.com/repos/zhuoliu/storm/branches{/branch}","tags_url":"https://api.github.com/repos/zhuoliu/storm/tags","blobs_url":"https://api.github.com/repos/zhuoliu/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhuoliu/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhuoliu/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhuoliu/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhuoliu/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/zhuoliu/storm/languages","stargazers_url":"https://api.github.com/repos/zhuoliu/storm/stargazers","contributors_url":"https://api.github.com/repos/zhuoliu/storm/contributors","subscribers_url":"https://api.github.com/repos/zhuoliu/storm/subscribers","subscription_url":"https://api.github.com/repos/zhuoliu/storm/subscription","commits_url":"https://api.github.com/repos/zhuoliu/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhuoliu/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhuoliu/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhuoliu/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhuoliu/storm/contents/{+path}","compare_url":"https://api.github.com/repos/zhuoliu/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhuoliu/storm/merges","archive_url":"https://api.github.com/repos/zhuoliu/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhuoliu/storm/downloads","issues_url":"https://api.github.com/repos/zhuoliu/storm/issues{/number}","pulls_url":"https://api.github.com/repos/zhuoliu/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/zhuoliu/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/zhuoliu/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhuoliu/storm/labels{/name}","releases_url":"https://api.github.com/repos/zhuoliu/storm/releases{/id}","created_at":"2015-03-27T16:47:03Z","updated_at":"2015-04-27T16:05:23Z","pushed_at":"2016-01-20T16:21:09Z","git_url":"git://github.com/zhuoliu/storm.git","ssh_url":"git@github.com:zhuoliu/storm.git","clone_url":"https://github.com/zhuoliu/storm.git","svn_url":"https://github.com/zhuoliu/storm","homepage":null,"size":28092,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e7e9eb9492ecd7ff909037561a6e7649f2aa7dc7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-01-20T16:57:40Z","pushed_at":"2016-01-20T17:04:39Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":156822,"stargazers_count":2756,"watchers_count":2756,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2070,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":67,"forks":2070,"open_issues":67,"watchers":2756,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1030"},"html":{"href":"https://github.com/apache/storm/pull/1030"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1030"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1030/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1030/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1030/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/b7374d2bb4cf49111936ec1cbd2a4f4f22661100"}}}}