{"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/18F/domain-scan/pulls/76","id":81232346,"html_url":"https://github.com/18F/domain-scan/pull/76","diff_url":"https://github.com/18F/domain-scan/pull/76.diff","patch_url":"https://github.com/18F/domain-scan/pull/76.patch","issue_url":"https://api.github.com/repos/18F/domain-scan/issues/76","number":76,"state":"closed","locked":false,"title":"Begins a scanner for the pshtt HTTP inspection tool","user":{"login":"konklone","id":4592,"avatar_url":"https://avatars.githubusercontent.com/u/4592?v=3","gravatar_id":"","url":"https://api.github.com/users/konklone","html_url":"https://github.com/konklone","followers_url":"https://api.github.com/users/konklone/followers","following_url":"https://api.github.com/users/konklone/following{/other_user}","gists_url":"https://api.github.com/users/konklone/gists{/gist_id}","starred_url":"https://api.github.com/users/konklone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konklone/subscriptions","organizations_url":"https://api.github.com/users/konklone/orgs","repos_url":"https://api.github.com/users/konklone/repos","events_url":"https://api.github.com/users/konklone/events{/privacy}","received_events_url":"https://api.github.com/users/konklone/received_events","type":"User","site_admin":false},"body":"This creates a scanner that integrates with [`pshtt`](https://github.com/dhs-ncats/pshtt), a Python-based tool. `pshtt` is designed as a single-purpose replacement for the HTTP inspection tool, currently provided via an unmaintained branch of [`site-inspector`](https://github.com/benbalter/site-inspector/tree/erics-mode)) and integrated into domain-scan as the `inspect` scanner.\r\n\r\n`pshtt` is a new tool, and is not yet at feature parity with `site-inspector` and the code still needs some more work and refactoring. It outputs a CSV very similar to `inspect.csv`, though the results currently use different logic and it will not reliably give the same results as the `inspect` scanner.\r\n\r\nIn addition, `pshtt` currently integrates with `sslyze` and requires Python 2, though I would like to see if the use of `sslyze` can be replaced, and if it can be made agnostic to Python 2 or 3. That said, `sslyze` is going to be used somewhere in this tool chain (there's already an `sslyze` scanner in this project), which will require communication between Python 3 and Python 2. It would be useful to figure out what the Right Way is to handle that, because I'm pretty sure that prepending some `pyenv` commands to an unsafe shell execution (as we do now) is not the Right Way.\r\n\r\nThis is a WIP, but it does work with `pshtt`'s `master` branch at the time I'm filing it, so I think it's merge-ready pretty much any time. ","created_at":"2016-08-14T02:34:16Z","updated_at":"2016-08-20T23:30:52Z","closed_at":"2016-08-20T23:30:52Z","merged_at":"2016-08-20T23:30:52Z","merge_commit_sha":"ba176623a0fdbb20a0e8e614aefca7338353d66e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/domain-scan/pulls/76/commits","review_comments_url":"https://api.github.com/repos/18F/domain-scan/pulls/76/comments","review_comment_url":"https://api.github.com/repos/18F/domain-scan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/domain-scan/issues/76/comments","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/ec1ea16fb0606bd39ebea951628831df47e2c2b0","head":{"label":"18F:pshtt","ref":"pshtt","sha":"ec1ea16fb0606bd39ebea951628831df47e2c2b0","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27473797,"name":"domain-scan","full_name":"18F/domain-scan","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/domain-scan","description":"A standard pipeline for running open source scanning tools on domains to measure things like speed, accessibiity, and HTTPS.","fork":false,"url":"https://api.github.com/repos/18F/domain-scan","forks_url":"https://api.github.com/repos/18F/domain-scan/forks","keys_url":"https://api.github.com/repos/18F/domain-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/domain-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/domain-scan/teams","hooks_url":"https://api.github.com/repos/18F/domain-scan/hooks","issue_events_url":"https://api.github.com/repos/18F/domain-scan/issues/events{/number}","events_url":"https://api.github.com/repos/18F/domain-scan/events","assignees_url":"https://api.github.com/repos/18F/domain-scan/assignees{/user}","branches_url":"https://api.github.com/repos/18F/domain-scan/branches{/branch}","tags_url":"https://api.github.com/repos/18F/domain-scan/tags","blobs_url":"https://api.github.com/repos/18F/domain-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/domain-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/domain-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/domain-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/domain-scan/languages","stargazers_url":"https://api.github.com/repos/18F/domain-scan/stargazers","contributors_url":"https://api.github.com/repos/18F/domain-scan/contributors","subscribers_url":"https://api.github.com/repos/18F/domain-scan/subscribers","subscription_url":"https://api.github.com/repos/18F/domain-scan/subscription","commits_url":"https://api.github.com/repos/18F/domain-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/domain-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/domain-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/domain-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/domain-scan/contents/{+path}","compare_url":"https://api.github.com/repos/18F/domain-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/domain-scan/merges","archive_url":"https://api.github.com/repos/18F/domain-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/domain-scan/downloads","issues_url":"https://api.github.com/repos/18F/domain-scan/issues{/number}","pulls_url":"https://api.github.com/repos/18F/domain-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/domain-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/domain-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/domain-scan/labels{/name}","releases_url":"https://api.github.com/repos/18F/domain-scan/releases{/id}","deployments_url":"https://api.github.com/repos/18F/domain-scan/deployments","created_at":"2014-12-03T06:52:17Z","updated_at":"2016-08-19T06:03:55Z","pushed_at":"2016-08-20T23:30:53Z","git_url":"git://github.com/18F/domain-scan.git","ssh_url":"git@github.com:18F/domain-scan.git","clone_url":"https://github.com/18F/domain-scan.git","svn_url":"https://github.com/18F/domain-scan","homepage":"","size":216,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":17,"forks":29,"open_issues":17,"watchers":67,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"5e83bc83a24bdcdf21f91394a6721f9829bc7c91","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27473797,"name":"domain-scan","full_name":"18F/domain-scan","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/domain-scan","description":"A standard pipeline for running open source scanning tools on domains to measure things like speed, accessibiity, and HTTPS.","fork":false,"url":"https://api.github.com/repos/18F/domain-scan","forks_url":"https://api.github.com/repos/18F/domain-scan/forks","keys_url":"https://api.github.com/repos/18F/domain-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/domain-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/domain-scan/teams","hooks_url":"https://api.github.com/repos/18F/domain-scan/hooks","issue_events_url":"https://api.github.com/repos/18F/domain-scan/issues/events{/number}","events_url":"https://api.github.com/repos/18F/domain-scan/events","assignees_url":"https://api.github.com/repos/18F/domain-scan/assignees{/user}","branches_url":"https://api.github.com/repos/18F/domain-scan/branches{/branch}","tags_url":"https://api.github.com/repos/18F/domain-scan/tags","blobs_url":"https://api.github.com/repos/18F/domain-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/domain-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/domain-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/domain-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/domain-scan/languages","stargazers_url":"https://api.github.com/repos/18F/domain-scan/stargazers","contributors_url":"https://api.github.com/repos/18F/domain-scan/contributors","subscribers_url":"https://api.github.com/repos/18F/domain-scan/subscribers","subscription_url":"https://api.github.com/repos/18F/domain-scan/subscription","commits_url":"https://api.github.com/repos/18F/domain-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/domain-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/domain-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/domain-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/domain-scan/contents/{+path}","compare_url":"https://api.github.com/repos/18F/domain-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/domain-scan/merges","archive_url":"https://api.github.com/repos/18F/domain-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/domain-scan/downloads","issues_url":"https://api.github.com/repos/18F/domain-scan/issues{/number}","pulls_url":"https://api.github.com/repos/18F/domain-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/domain-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/domain-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/domain-scan/labels{/name}","releases_url":"https://api.github.com/repos/18F/domain-scan/releases{/id}","deployments_url":"https://api.github.com/repos/18F/domain-scan/deployments","created_at":"2014-12-03T06:52:17Z","updated_at":"2016-08-19T06:03:55Z","pushed_at":"2016-08-20T23:30:53Z","git_url":"git://github.com/18F/domain-scan.git","ssh_url":"git@github.com:18F/domain-scan.git","clone_url":"https://github.com/18F/domain-scan.git","svn_url":"https://github.com/18F/domain-scan","homepage":"","size":216,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":17,"forks":29,"open_issues":17,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/76"},"html":{"href":"https://github.com/18F/domain-scan/pull/76"},"issue":{"href":"https://api.github.com/repos/18F/domain-scan/issues/76"},"comments":{"href":"https://api.github.com/repos/18F/domain-scan/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/18F/domain-scan/statuses/ec1ea16fb0606bd39ebea951628831df47e2c2b0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"konklone","id":4592,"avatar_url":"https://avatars.githubusercontent.com/u/4592?v=3","gravatar_id":"","url":"https://api.github.com/users/konklone","html_url":"https://github.com/konklone","followers_url":"https://api.github.com/users/konklone/followers","following_url":"https://api.github.com/users/konklone/following{/other_user}","gists_url":"https://api.github.com/users/konklone/gists{/gist_id}","starred_url":"https://api.github.com/users/konklone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konklone/subscriptions","organizations_url":"https://api.github.com/users/konklone/orgs","repos_url":"https://api.github.com/users/konklone/repos","events_url":"https://api.github.com/users/konklone/events{/privacy}","received_events_url":"https://api.github.com/users/konklone/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":8,"additions":91,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"konklone"}}