{"action":"created","comment":{"url":"https://api.github.com/repos/cyverse/DE/pulls/comments/61497065","id":61497065,"diff_hunk":"@@ -15,27 +15,26 @@\n \n (defn- get-root\n   [cm user root-path]\n+  (validators/path-readable cm user root-path) ;; CORE-7638; otherwise a 'nil' permission can pop up and cause issues","path":"services/data-info/src/data_info/services/root.clj","position":4,"original_position":4,"commit_id":"e0dd627c651e277aec45a6546c343361dd6d9ebe","original_commit_id":"e0dd627c651e277aec45a6546c343361dd6d9ebe","user":{"login":"ianmcorvidae","id":106004,"avatar_url":"https://avatars.githubusercontent.com/u/106004?v=3","gravatar_id":"","url":"https://api.github.com/users/ianmcorvidae","html_url":"https://github.com/ianmcorvidae","followers_url":"https://api.github.com/users/ianmcorvidae/followers","following_url":"https://api.github.com/users/ianmcorvidae/following{/other_user}","gists_url":"https://api.github.com/users/ianmcorvidae/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcorvidae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcorvidae/subscriptions","organizations_url":"https://api.github.com/users/ianmcorvidae/orgs","repos_url":"https://api.github.com/users/ianmcorvidae/repos","events_url":"https://api.github.com/users/ianmcorvidae/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcorvidae/received_events","type":"User","site_admin":false},"body":"(this is the line which fixes the ticket. the rest is the refactoring)","created_at":"2016-04-28T20:29:41Z","updated_at":"2016-04-28T20:29:41Z","html_url":"https://github.com/cyverse/DE/pull/173#discussion_r61497065","pull_request_url":"https://api.github.com/repos/cyverse/DE/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/cyverse/DE/pulls/comments/61497065"},"html":{"href":"https://github.com/cyverse/DE/pull/173#discussion_r61497065"},"pull_request":{"href":"https://api.github.com/repos/cyverse/DE/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/cyverse/DE/pulls/173","id":68284940,"html_url":"https://github.com/cyverse/DE/pull/173","diff_url":"https://github.com/cyverse/DE/pull/173.diff","patch_url":"https://github.com/cyverse/DE/pull/173.patch","issue_url":"https://api.github.com/repos/cyverse/DE/issues/173","number":173,"state":"open","locked":false,"title":"CORE-7638: validate path readability in get-root so a nil permission can't seep through","user":{"login":"ianmcorvidae","id":106004,"avatar_url":"https://avatars.githubusercontent.com/u/106004?v=3","gravatar_id":"","url":"https://api.github.com/users/ianmcorvidae","html_url":"https://github.com/ianmcorvidae","followers_url":"https://api.github.com/users/ianmcorvidae/followers","following_url":"https://api.github.com/users/ianmcorvidae/following{/other_user}","gists_url":"https://api.github.com/users/ianmcorvidae/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcorvidae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcorvidae/subscriptions","organizations_url":"https://api.github.com/users/ianmcorvidae/orgs","repos_url":"https://api.github.com/users/ianmcorvidae/repos","events_url":"https://api.github.com/users/ianmcorvidae/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcorvidae/received_events","type":"User","site_admin":false},"body":"I also refactored the file generally a bit to be more consistent/clear about what it's doing.","created_at":"2016-04-28T20:28:39Z","updated_at":"2016-04-28T20:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70bef8e931bcfeda2c8bd4e1b7a43bd5f5e121c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cyverse/DE/pulls/173/commits","review_comments_url":"https://api.github.com/repos/cyverse/DE/pulls/173/comments","review_comment_url":"https://api.github.com/repos/cyverse/DE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyverse/DE/issues/173/comments","statuses_url":"https://api.github.com/repos/cyverse/DE/statuses/e0dd627c651e277aec45a6546c343361dd6d9ebe","head":{"label":"cyverse:core-7638","ref":"core-7638","sha":"e0dd627c651e277aec45a6546c343361dd6d9ebe","user":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":45433519,"name":"DE","full_name":"cyverse/DE","owner":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse/DE","description":"The CyVerse Discovery Environment","fork":false,"url":"https://api.github.com/repos/cyverse/DE","forks_url":"https://api.github.com/repos/cyverse/DE/forks","keys_url":"https://api.github.com/repos/cyverse/DE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse/DE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse/DE/teams","hooks_url":"https://api.github.com/repos/cyverse/DE/hooks","issue_events_url":"https://api.github.com/repos/cyverse/DE/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse/DE/events","assignees_url":"https://api.github.com/repos/cyverse/DE/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse/DE/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse/DE/tags","blobs_url":"https://api.github.com/repos/cyverse/DE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse/DE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse/DE/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse/DE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse/DE/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse/DE/languages","stargazers_url":"https://api.github.com/repos/cyverse/DE/stargazers","contributors_url":"https://api.github.com/repos/cyverse/DE/contributors","subscribers_url":"https://api.github.com/repos/cyverse/DE/subscribers","subscription_url":"https://api.github.com/repos/cyverse/DE/subscription","commits_url":"https://api.github.com/repos/cyverse/DE/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse/DE/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse/DE/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse/DE/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse/DE/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse/DE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse/DE/merges","archive_url":"https://api.github.com/repos/cyverse/DE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse/DE/downloads","issues_url":"https://api.github.com/repos/cyverse/DE/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse/DE/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse/DE/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse/DE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse/DE/labels{/name}","releases_url":"https://api.github.com/repos/cyverse/DE/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse/DE/deployments","created_at":"2015-11-03T01:27:41Z","updated_at":"2016-03-05T02:16:59Z","pushed_at":"2016-04-28T20:28:39Z","git_url":"git://github.com/cyverse/DE.git","ssh_url":"git@github.com:cyverse/DE.git","clone_url":"https://github.com/cyverse/DE.git","svn_url":"https://github.com/cyverse/DE","homepage":"https://de.iplantcollaborative.org/de/","size":41357,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"cyverse:2.7","ref":"2.7","sha":"7e50a4ecd9d0a805552411ef4b972080eaa3195f","user":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":45433519,"name":"DE","full_name":"cyverse/DE","owner":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars.githubusercontent.com/u/15638129?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse/DE","description":"The CyVerse Discovery Environment","fork":false,"url":"https://api.github.com/repos/cyverse/DE","forks_url":"https://api.github.com/repos/cyverse/DE/forks","keys_url":"https://api.github.com/repos/cyverse/DE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse/DE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse/DE/teams","hooks_url":"https://api.github.com/repos/cyverse/DE/hooks","issue_events_url":"https://api.github.com/repos/cyverse/DE/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse/DE/events","assignees_url":"https://api.github.com/repos/cyverse/DE/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse/DE/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse/DE/tags","blobs_url":"https://api.github.com/repos/cyverse/DE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse/DE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse/DE/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse/DE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse/DE/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse/DE/languages","stargazers_url":"https://api.github.com/repos/cyverse/DE/stargazers","contributors_url":"https://api.github.com/repos/cyverse/DE/contributors","subscribers_url":"https://api.github.com/repos/cyverse/DE/subscribers","subscription_url":"https://api.github.com/repos/cyverse/DE/subscription","commits_url":"https://api.github.com/repos/cyverse/DE/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse/DE/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse/DE/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse/DE/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse/DE/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse/DE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse/DE/merges","archive_url":"https://api.github.com/repos/cyverse/DE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse/DE/downloads","issues_url":"https://api.github.com/repos/cyverse/DE/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse/DE/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse/DE/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse/DE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse/DE/labels{/name}","releases_url":"https://api.github.com/repos/cyverse/DE/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse/DE/deployments","created_at":"2015-11-03T01:27:41Z","updated_at":"2016-03-05T02:16:59Z","pushed_at":"2016-04-28T20:28:39Z","git_url":"git://github.com/cyverse/DE.git","ssh_url":"git@github.com:cyverse/DE.git","clone_url":"https://github.com/cyverse/DE.git","svn_url":"https://github.com/cyverse/DE","homepage":"https://de.iplantcollaborative.org/de/","size":41357,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyverse/DE/pulls/173"},"html":{"href":"https://github.com/cyverse/DE/pull/173"},"issue":{"href":"https://api.github.com/repos/cyverse/DE/issues/173"},"comments":{"href":"https://api.github.com/repos/cyverse/DE/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/cyverse/DE/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/cyverse/DE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyverse/DE/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/cyverse/DE/statuses/e0dd627c651e277aec45a6546c343361dd6d9ebe"}}}}