{"action":"created","comment":{"url":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/comments/85001338","pull_request_review_id":5744038,"id":85001338,"diff_hunk":"@@ -106,7 +106,7 @@ def append(self, new_stored_event, new_version_number=None, max_retries=3, artif\n         Saves given stored event in this repository.\n         \"\"\"\n         # Check the new event is a stored event instance.\n-        assert isinstance(new_stored_event, StoredEvent)","path":"eventsourcing/domain/services/eventstore.py","position":38,"original_position":38,"commit_id":"1243050e21a3a4ce80c90df09e20c614727b35e2","original_commit_id":"1243050e21a3a4ce80c90df09e20c614727b35e2","user":{"login":"johnbywater","id":3607503,"avatar_url":"https://avatars.githubusercontent.com/u/3607503?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbywater","html_url":"https://github.com/johnbywater","followers_url":"https://api.github.com/users/johnbywater/followers","following_url":"https://api.github.com/users/johnbywater/following{/other_user}","gists_url":"https://api.github.com/users/johnbywater/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbywater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbywater/subscriptions","organizations_url":"https://api.github.com/users/johnbywater/orgs","repos_url":"https://api.github.com/users/johnbywater/repos","events_url":"https://api.github.com/users/johnbywater/events{/privacy}","received_events_url":"https://api.github.com/users/johnbywater/received_events","type":"User","site_admin":false},"body":"Good point!","created_at":"2016-10-25T21:08:22Z","updated_at":"2016-10-25T21:08:23Z","html_url":"https://github.com/johnbywater/eventsourcing/pull/30#discussion_r85001338","pull_request_url":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/comments/85001338"},"html":{"href":"https://github.com/johnbywater/eventsourcing/pull/30#discussion_r85001338"},"pull_request":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30","id":90887542,"html_url":"https://github.com/johnbywater/eventsourcing/pull/30","diff_url":"https://github.com/johnbywater/eventsourcing/pull/30.diff","patch_url":"https://github.com/johnbywater/eventsourcing/pull/30.patch","issue_url":"https://api.github.com/repos/johnbywater/eventsourcing/issues/30","number":30,"state":"open","locked":false,"title":"Remove hard-code dependency on default StoredEvent Implementation from AbstractStoredEventRepository","user":{"login":"renou","id":1410559,"avatar_url":"https://avatars.githubusercontent.com/u/1410559?v=3","gravatar_id":"","url":"https://api.github.com/users/renou","html_url":"https://github.com/renou","followers_url":"https://api.github.com/users/renou/followers","following_url":"https://api.github.com/users/renou/following{/other_user}","gists_url":"https://api.github.com/users/renou/gists{/gist_id}","starred_url":"https://api.github.com/users/renou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renou/subscriptions","organizations_url":"https://api.github.com/users/renou/orgs","repos_url":"https://api.github.com/users/renou/repos","events_url":"https://api.github.com/users/renou/events{/privacy}","received_events_url":"https://api.github.com/users/renou/received_events","type":"User","site_admin":false},"body":"1. remove hard-code dependency on default StoredEvent Implementation(schema) from AbstractStoredEventRepository. Since it's a Abstract repo, it should be able to handle different types of stored event.\r\n\r\n2. moved StoredEvent into Transcoder Implementation since only Transcoder uses it and should depend on it\r\n\r\n3. refactored default transcoder implementation by merging (de)serialize implementations into it since they are only needed there","created_at":"2016-10-25T20:41:58Z","updated_at":"2016-10-25T21:08:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2634a2669e1b700b9e9bbae1d24a63a8b879dd16","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30/commits","review_comments_url":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30/comments","review_comment_url":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johnbywater/eventsourcing/issues/30/comments","statuses_url":"https://api.github.com/repos/johnbywater/eventsourcing/statuses/1243050e21a3a4ce80c90df09e20c614727b35e2","head":{"label":"renou:remove_hard_code_dependecy_on_default_stored_event_imp_from_eventstore","ref":"remove_hard_code_dependecy_on_default_stored_event_imp_from_eventstore","sha":"1243050e21a3a4ce80c90df09e20c614727b35e2","user":{"login":"renou","id":1410559,"avatar_url":"https://avatars.githubusercontent.com/u/1410559?v=3","gravatar_id":"","url":"https://api.github.com/users/renou","html_url":"https://github.com/renou","followers_url":"https://api.github.com/users/renou/followers","following_url":"https://api.github.com/users/renou/following{/other_user}","gists_url":"https://api.github.com/users/renou/gists{/gist_id}","starred_url":"https://api.github.com/users/renou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renou/subscriptions","organizations_url":"https://api.github.com/users/renou/orgs","repos_url":"https://api.github.com/users/renou/repos","events_url":"https://api.github.com/users/renou/events{/privacy}","received_events_url":"https://api.github.com/users/renou/received_events","type":"User","site_admin":false},"repo":{"id":68610581,"name":"eventsourcing","full_name":"renou/eventsourcing","owner":{"login":"renou","id":1410559,"avatar_url":"https://avatars.githubusercontent.com/u/1410559?v=3","gravatar_id":"","url":"https://api.github.com/users/renou","html_url":"https://github.com/renou","followers_url":"https://api.github.com/users/renou/followers","following_url":"https://api.github.com/users/renou/following{/other_user}","gists_url":"https://api.github.com/users/renou/gists{/gist_id}","starred_url":"https://api.github.com/users/renou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renou/subscriptions","organizations_url":"https://api.github.com/users/renou/orgs","repos_url":"https://api.github.com/users/renou/repos","events_url":"https://api.github.com/users/renou/events{/privacy}","received_events_url":"https://api.github.com/users/renou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renou/eventsourcing","description":"Event sourcing in Python","fork":true,"url":"https://api.github.com/repos/renou/eventsourcing","forks_url":"https://api.github.com/repos/renou/eventsourcing/forks","keys_url":"https://api.github.com/repos/renou/eventsourcing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renou/eventsourcing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renou/eventsourcing/teams","hooks_url":"https://api.github.com/repos/renou/eventsourcing/hooks","issue_events_url":"https://api.github.com/repos/renou/eventsourcing/issues/events{/number}","events_url":"https://api.github.com/repos/renou/eventsourcing/events","assignees_url":"https://api.github.com/repos/renou/eventsourcing/assignees{/user}","branches_url":"https://api.github.com/repos/renou/eventsourcing/branches{/branch}","tags_url":"https://api.github.com/repos/renou/eventsourcing/tags","blobs_url":"https://api.github.com/repos/renou/eventsourcing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renou/eventsourcing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renou/eventsourcing/git/refs{/sha}","trees_url":"https://api.github.com/repos/renou/eventsourcing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renou/eventsourcing/statuses/{sha}","languages_url":"https://api.github.com/repos/renou/eventsourcing/languages","stargazers_url":"https://api.github.com/repos/renou/eventsourcing/stargazers","contributors_url":"https://api.github.com/repos/renou/eventsourcing/contributors","subscribers_url":"https://api.github.com/repos/renou/eventsourcing/subscribers","subscription_url":"https://api.github.com/repos/renou/eventsourcing/subscription","commits_url":"https://api.github.com/repos/renou/eventsourcing/commits{/sha}","git_commits_url":"https://api.github.com/repos/renou/eventsourcing/git/commits{/sha}","comments_url":"https://api.github.com/repos/renou/eventsourcing/comments{/number}","issue_comment_url":"https://api.github.com/repos/renou/eventsourcing/issues/comments{/number}","contents_url":"https://api.github.com/repos/renou/eventsourcing/contents/{+path}","compare_url":"https://api.github.com/repos/renou/eventsourcing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renou/eventsourcing/merges","archive_url":"https://api.github.com/repos/renou/eventsourcing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renou/eventsourcing/downloads","issues_url":"https://api.github.com/repos/renou/eventsourcing/issues{/number}","pulls_url":"https://api.github.com/repos/renou/eventsourcing/pulls{/number}","milestones_url":"https://api.github.com/repos/renou/eventsourcing/milestones{/number}","notifications_url":"https://api.github.com/repos/renou/eventsourcing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renou/eventsourcing/labels{/name}","releases_url":"https://api.github.com/repos/renou/eventsourcing/releases{/id}","deployments_url":"https://api.github.com/repos/renou/eventsourcing/deployments","created_at":"2016-09-19T13:50:46Z","updated_at":"2016-09-19T13:50:47Z","pushed_at":"2016-10-25T20:41:10Z","git_url":"git://github.com/renou/eventsourcing.git","ssh_url":"git@github.com:renou/eventsourcing.git","clone_url":"https://github.com/renou/eventsourcing.git","svn_url":"https://github.com/renou/eventsourcing","homepage":null,"size":628,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"johnbywater:develop","ref":"develop","sha":"924c532ce025fe29fe547cc2b27d9164d3e71e92","user":{"login":"johnbywater","id":3607503,"avatar_url":"https://avatars.githubusercontent.com/u/3607503?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbywater","html_url":"https://github.com/johnbywater","followers_url":"https://api.github.com/users/johnbywater/followers","following_url":"https://api.github.com/users/johnbywater/following{/other_user}","gists_url":"https://api.github.com/users/johnbywater/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbywater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbywater/subscriptions","organizations_url":"https://api.github.com/users/johnbywater/orgs","repos_url":"https://api.github.com/users/johnbywater/repos","events_url":"https://api.github.com/users/johnbywater/events{/privacy}","received_events_url":"https://api.github.com/users/johnbywater/received_events","type":"User","site_admin":false},"repo":{"id":41365202,"name":"eventsourcing","full_name":"johnbywater/eventsourcing","owner":{"login":"johnbywater","id":3607503,"avatar_url":"https://avatars.githubusercontent.com/u/3607503?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbywater","html_url":"https://github.com/johnbywater","followers_url":"https://api.github.com/users/johnbywater/followers","following_url":"https://api.github.com/users/johnbywater/following{/other_user}","gists_url":"https://api.github.com/users/johnbywater/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbywater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbywater/subscriptions","organizations_url":"https://api.github.com/users/johnbywater/orgs","repos_url":"https://api.github.com/users/johnbywater/repos","events_url":"https://api.github.com/users/johnbywater/events{/privacy}","received_events_url":"https://api.github.com/users/johnbywater/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnbywater/eventsourcing","description":"Event sourcing in Python","fork":false,"url":"https://api.github.com/repos/johnbywater/eventsourcing","forks_url":"https://api.github.com/repos/johnbywater/eventsourcing/forks","keys_url":"https://api.github.com/repos/johnbywater/eventsourcing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnbywater/eventsourcing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnbywater/eventsourcing/teams","hooks_url":"https://api.github.com/repos/johnbywater/eventsourcing/hooks","issue_events_url":"https://api.github.com/repos/johnbywater/eventsourcing/issues/events{/number}","events_url":"https://api.github.com/repos/johnbywater/eventsourcing/events","assignees_url":"https://api.github.com/repos/johnbywater/eventsourcing/assignees{/user}","branches_url":"https://api.github.com/repos/johnbywater/eventsourcing/branches{/branch}","tags_url":"https://api.github.com/repos/johnbywater/eventsourcing/tags","blobs_url":"https://api.github.com/repos/johnbywater/eventsourcing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnbywater/eventsourcing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnbywater/eventsourcing/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnbywater/eventsourcing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnbywater/eventsourcing/statuses/{sha}","languages_url":"https://api.github.com/repos/johnbywater/eventsourcing/languages","stargazers_url":"https://api.github.com/repos/johnbywater/eventsourcing/stargazers","contributors_url":"https://api.github.com/repos/johnbywater/eventsourcing/contributors","subscribers_url":"https://api.github.com/repos/johnbywater/eventsourcing/subscribers","subscription_url":"https://api.github.com/repos/johnbywater/eventsourcing/subscription","commits_url":"https://api.github.com/repos/johnbywater/eventsourcing/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnbywater/eventsourcing/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnbywater/eventsourcing/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnbywater/eventsourcing/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnbywater/eventsourcing/contents/{+path}","compare_url":"https://api.github.com/repos/johnbywater/eventsourcing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnbywater/eventsourcing/merges","archive_url":"https://api.github.com/repos/johnbywater/eventsourcing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnbywater/eventsourcing/downloads","issues_url":"https://api.github.com/repos/johnbywater/eventsourcing/issues{/number}","pulls_url":"https://api.github.com/repos/johnbywater/eventsourcing/pulls{/number}","milestones_url":"https://api.github.com/repos/johnbywater/eventsourcing/milestones{/number}","notifications_url":"https://api.github.com/repos/johnbywater/eventsourcing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnbywater/eventsourcing/labels{/name}","releases_url":"https://api.github.com/repos/johnbywater/eventsourcing/releases{/id}","deployments_url":"https://api.github.com/repos/johnbywater/eventsourcing/deployments","created_at":"2015-08-25T13:35:28Z","updated_at":"2016-10-25T15:24:11Z","pushed_at":"2016-10-25T20:41:58Z","git_url":"git://github.com/johnbywater/eventsourcing.git","ssh_url":"git@github.com:johnbywater/eventsourcing.git","clone_url":"https://github.com/johnbywater/eventsourcing.git","svn_url":"https://github.com/johnbywater/eventsourcing","homepage":null,"size":638,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":53,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30"},"html":{"href":"https://github.com/johnbywater/eventsourcing/pull/30"},"issue":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/issues/30"},"comments":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/johnbywater/eventsourcing/statuses/1243050e21a3a4ce80c90df09e20c614727b35e2"}}}}
{"actor":{"display_login":"johnbywater"}}