{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/85252329","pull_request_review_id":5978744,"id":85252329,"diff_hunk":"@@ -0,0 +1,150 @@\n+// Copyright 2016 Canonical Ltd.\n+// Licensed under the AGPLv3, see LICENCE file for details.\n+\n+package metricobserver\n+\n+import (\n+\t\"net/http\"\n+\t\"strconv\"\n+\t\"time\"\n+\n+\t\"gopkg.in/juju/names.v2\"\n+\n+\t\"github.com/juju/errors\"\n+\t\"github.com/juju/utils/clock\"\n+\t\"github.com/prometheus/client_golang/prometheus\"\n+\n+\t\"github.com/juju/juju/apiserver/observer\"\n+\t\"github.com/juju/juju/rpc\"\n+)\n+\n+const (\n+\tfacadeLabel    = \"facade\"\n+\tversionLabel   = \"version\"\n+\tmethodLabel    = \"method\"\n+\terrorCodeLabel = \"error_code\"\n+)\n+\n+var metricLabelNames = []string{\n+\tfacadeLabel,\n+\tversionLabel,\n+\tmethodLabel,\n+\terrorCodeLabel,\n+}\n+\n+// Config contains the configuration for a Observer.","path":"apiserver/observer/metricobserver/metricobserver.go","position":35,"original_position":35,"commit_id":"09d2aad866651e0a345bd749d3751695d14f893f","original_commit_id":"09d2aad866651e0a345bd749d3751695d14f893f","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars.githubusercontent.com/u/5808968?v=3","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"nitpic: an Observer","created_at":"2016-10-27T01:26:20Z","updated_at":"2016-10-27T01:43:40Z","html_url":"https://github.com/juju/juju/pull/6494#discussion_r85252329","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/6494","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/85252329"},"html":{"href":"https://github.com/juju/juju/pull/6494#discussion_r85252329"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/6494"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/6494","id":90775777,"html_url":"https://github.com/juju/juju/pull/6494","diff_url":"https://github.com/juju/juju/pull/6494.diff","patch_url":"https://github.com/juju/juju/pull/6494.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/6494","number":6494,"state":"open","locked":false,"title":"Add Prometheus monitoring to agents","user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"body":"We create a Prometheus registry for each\r\nmachine and unit agent, and expose it via\r\nthe agent's introspection socket. The socket\r\ncan be exposed as HTTP using socat or similar,\r\nand then used as a regular Prometheus target.\r\n\r\nWe add the apiserver/observer/metricobserver\r\npackage, which contains an apiserver observer\r\nthat maintains Prometheus metrics. We currently\r\ncreate metrics tracking the total number of API\r\nrequests served, and their latencies. Each metric\r\nis grouped by facade, method, version, and error\r\ncode.\r\n\r\nWe also add metrics for the logsender worker,\r\ntracking the number of log records enqueued,\r\nsent (to the controller), and dropped; and\r\nalso the capacity of the queue so we can\r\ncompute usage %.","created_at":"2016-10-25T10:01:59Z","updated_at":"2016-10-27T01:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e832ab866f7462fc92813454c08f0d95ef928772","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/6494/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/6494/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/6494/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/09d2aad866651e0a345bd749d3751695d14f893f","head":{"label":"axw:introspection-prometheus-metrics","ref":"introspection-prometheus-metrics","sha":"09d2aad866651e0a345bd749d3751695d14f893f","user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"repo":{"id":20466577,"name":"juju","full_name":"axw/juju","owner":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axw/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/axw/juju","forks_url":"https://api.github.com/repos/axw/juju/forks","keys_url":"https://api.github.com/repos/axw/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axw/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axw/juju/teams","hooks_url":"https://api.github.com/repos/axw/juju/hooks","issue_events_url":"https://api.github.com/repos/axw/juju/issues/events{/number}","events_url":"https://api.github.com/repos/axw/juju/events","assignees_url":"https://api.github.com/repos/axw/juju/assignees{/user}","branches_url":"https://api.github.com/repos/axw/juju/branches{/branch}","tags_url":"https://api.github.com/repos/axw/juju/tags","blobs_url":"https://api.github.com/repos/axw/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axw/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axw/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/axw/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axw/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/axw/juju/languages","stargazers_url":"https://api.github.com/repos/axw/juju/stargazers","contributors_url":"https://api.github.com/repos/axw/juju/contributors","subscribers_url":"https://api.github.com/repos/axw/juju/subscribers","subscription_url":"https://api.github.com/repos/axw/juju/subscription","commits_url":"https://api.github.com/repos/axw/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/axw/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/axw/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/axw/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/axw/juju/contents/{+path}","compare_url":"https://api.github.com/repos/axw/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axw/juju/merges","archive_url":"https://api.github.com/repos/axw/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axw/juju/downloads","issues_url":"https://api.github.com/repos/axw/juju/issues{/number}","pulls_url":"https://api.github.com/repos/axw/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/axw/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/axw/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axw/juju/labels{/name}","releases_url":"https://api.github.com/repos/axw/juju/releases{/id}","deployments_url":"https://api.github.com/repos/axw/juju/deployments","created_at":"2014-06-04T01:51:25Z","updated_at":"2016-08-11T02:25:45Z","pushed_at":"2016-10-26T06:51:25Z","git_url":"git://github.com/axw/juju.git","ssh_url":"git@github.com:axw/juju.git","clone_url":"https://github.com/axw/juju.git","svn_url":"https://github.com/axw/juju","homepage":null,"size":104412,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"5983ff2b0e5eddb829f461c62d18272ddf92ba7a","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-10-26T15:55:29Z","pushed_at":"2016-10-27T01:31:34Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":127402,"stargazers_count":523,"watchers_count":523,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":16,"forks":160,"open_issues":16,"watchers":523,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/6494"},"html":{"href":"https://github.com/juju/juju/pull/6494"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/6494"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/6494/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/6494/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/6494/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/09d2aad866651e0a345bd749d3751695d14f893f"}}}}
{"actor":{"display_login":"wallyworld"}}