{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1796","repository_url":"https://api.github.com/repos/facebook/AsyncDisplayKit","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1796/labels{/name}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1796/comments","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1796/events","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1796","id":161595136,"number":1796,"title":"[Carthage] Add cartfile, update example","user":{"login":"hannahmbanana","id":3419380,"avatar_url":"https://avatars.githubusercontent.com/u/3419380?v=3","gravatar_id":"","url":"https://api.github.com/users/hannahmbanana","html_url":"https://github.com/hannahmbanana","followers_url":"https://api.github.com/users/hannahmbanana/followers","following_url":"https://api.github.com/users/hannahmbanana/following{/other_user}","gists_url":"https://api.github.com/users/hannahmbanana/gists{/gist_id}","starred_url":"https://api.github.com/users/hannahmbanana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannahmbanana/subscriptions","organizations_url":"https://api.github.com/users/hannahmbanana/orgs","repos_url":"https://api.github.com/users/hannahmbanana/repos","events_url":"https://api.github.com/users/hannahmbanana/events{/privacy}","received_events_url":"https://api.github.com/users/hannahmbanana/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/CLA%20Signed","name":"CLA Signed","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-22T05:09:51Z","updated_at":"2016-06-22T06:53:04Z","closed_at":"2016-06-22T06:53:04Z","pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1796","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1796","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1796.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1796.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments/227658718","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1796#issuecomment-227658718","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1796","id":227658718,"user":{"login":"hannahmbanana","id":3419380,"avatar_url":"https://avatars.githubusercontent.com/u/3419380?v=3","gravatar_id":"","url":"https://api.github.com/users/hannahmbanana","html_url":"https://github.com/hannahmbanana","followers_url":"https://api.github.com/users/hannahmbanana/followers","following_url":"https://api.github.com/users/hannahmbanana/following{/other_user}","gists_url":"https://api.github.com/users/hannahmbanana/gists{/gist_id}","starred_url":"https://api.github.com/users/hannahmbanana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannahmbanana/subscriptions","organizations_url":"https://api.github.com/users/hannahmbanana/orgs","repos_url":"https://api.github.com/users/hannahmbanana/repos","events_url":"https://api.github.com/users/hannahmbanana/events{/privacy}","received_events_url":"https://api.github.com/users/hannahmbanana/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T06:53:04Z","updated_at":"2016-06-22T06:53:04Z","body":"@garrettmoon - The good news is that when I include PINRemoteImage in ASDK's cartfile, the dependencies work (using the instructions above) and PINCache gets built as well! Including the beta release was a bit tricky, but can be done in a Cartfile with the following line (in case anyone asks you):\r\n\r\n```github \"pinterest/PINRemoteImage\" \"3.0.0-beta.2\"```\r\n\r\nThe bad news is that ASDK needs to import a private PINRemoteImage class. \r\n\r\n-  `ASPINRemoteImageDownloader.m` imports `#import <PINRemoteImage/NSData+ImageDetectors.h>` which is defined in the ​*project*​ headers of `PINRemoteImage`. So when `PINRemoteImage` is built from source to a dynamic framework, and used, `<PINRemoteImage/NSData+ImageDetectors.h>` is not available because it is not available in the project public headers.\r\n\r\nCould `<PINRemoteImage/NSData+ImageDetectors.h>` be made public?\r\n\r\n![image](https://cloud.githubusercontent.com/assets/3419380/16256963/4ca8f05e-380a-11e6-87d2-aaec134f7176.png)"}}
{"actor":{"display_login":"hannahmbanana"}}