{"action":"created","comment":{"url":"https://api.github.com/repos/Capgemini/kubeform/pulls/comments/90085656","pull_request_review_id":10610269,"id":90085656,"diff_hunk":"@@ -59,6 +59,7 @@ for i in $(ls .terraform/modules/*/Makefile); do i=$(dirname $i); make -C $i; do\n ### Provision the cluster infrastructure\n \n ```","path":"docs/getting-started-guides/aws/public.md","position":null,"original_position":3,"commit_id":"8968b0290ca1866bdc38fb9e5c0df162852d5fc7","original_commit_id":"9dea01b606b8d3c225acb8d63c8388ae1354f677","user":{"login":"tamsky","id":96978,"avatar_url":"https://avatars.githubusercontent.com/u/96978?v=3","gravatar_id":"","url":"https://api.github.com/users/tamsky","html_url":"https://github.com/tamsky","followers_url":"https://api.github.com/users/tamsky/followers","following_url":"https://api.github.com/users/tamsky/following{/other_user}","gists_url":"https://api.github.com/users/tamsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tamsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamsky/subscriptions","organizations_url":"https://api.github.com/users/tamsky/orgs","repos_url":"https://api.github.com/users/tamsky/repos","events_url":"https://api.github.com/users/tamsky/events{/privacy}","received_events_url":"https://api.github.com/users/tamsky/received_events","type":"User","site_admin":false},"body":"I spoke too soon.  It needs to stay.\r\n\r\nExplanation is from \r\nhttps://github.com/Capgemini/kubeform/commit/337e104d0704f5e0a5bae72628f4645572543ca3\r\n\r\n> In Terraform 0.7.x, template file data sources do not support the\r\n> 'provisioner' parameter. So instead, we must now use a null_resource to\r\n> get the discovery URL.\r\n> \r\n> And, unfortunately, depending on a null_resource does not mean that you\r\n> can read the file before it exists.\r\n> ","created_at":"2016-11-29T19:12:58Z","updated_at":"2016-11-29T19:12:58Z","html_url":"https://github.com/Capgemini/kubeform/pull/171#discussion_r90085656","pull_request_url":"https://api.github.com/repos/Capgemini/kubeform/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/Capgemini/kubeform/pulls/comments/90085656"},"html":{"href":"https://github.com/Capgemini/kubeform/pull/171#discussion_r90085656"},"pull_request":{"href":"https://api.github.com/repos/Capgemini/kubeform/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/Capgemini/kubeform/pulls/171","id":94242817,"html_url":"https://github.com/Capgemini/kubeform/pull/171","diff_url":"https://github.com/Capgemini/kubeform/pull/171.diff","patch_url":"https://github.com/Capgemini/kubeform/pull/171.patch","issue_url":"https://api.github.com/repos/Capgemini/kubeform/issues/171","number":171,"state":"open","locked":false,"title":"Full support for terraform-0.7.11","user":{"login":"tamsky","id":96978,"avatar_url":"https://avatars.githubusercontent.com/u/96978?v=3","gravatar_id":"","url":"https://api.github.com/users/tamsky","html_url":"https://github.com/tamsky","followers_url":"https://api.github.com/users/tamsky/followers","following_url":"https://api.github.com/users/tamsky/following{/other_user}","gists_url":"https://api.github.com/users/tamsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tamsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamsky/subscriptions","organizations_url":"https://api.github.com/users/tamsky/orgs","repos_url":"https://api.github.com/users/tamsky/repos","events_url":"https://api.github.com/users/tamsky/events{/privacy}","received_events_url":"https://api.github.com/users/tamsky/received_events","type":"User","site_admin":false},"body":"`terraform apply` (and `destroy`) works mostly clean now.\r\n\r\nLater steps in the docs, like `ansible-playbook` doesn't apply cleanly, but I think that's beyond the scope of this PR.\r\n\r\nAfter https://github.com/Capgemini/tf_tls/pull/45 lands,\r\nwe can fix the module references\r\n    `s@github.com/tamsky@github.com/Capgemini@g`\r\n\r\nbuilds from changes in https://github.com/Capgemini/kubeform/pull/170","created_at":"2016-11-17T20:22:43Z","updated_at":"2016-11-29T19:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae58a54ca2e2a1fc28a21fbec373ca6f2893fe35","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Capgemini/kubeform/pulls/171/commits","review_comments_url":"https://api.github.com/repos/Capgemini/kubeform/pulls/171/comments","review_comment_url":"https://api.github.com/repos/Capgemini/kubeform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Capgemini/kubeform/issues/171/comments","statuses_url":"https://api.github.com/repos/Capgemini/kubeform/statuses/8968b0290ca1866bdc38fb9e5c0df162852d5fc7","head":{"label":"tamsky:terraform-0.7.x","ref":"terraform-0.7.x","sha":"8968b0290ca1866bdc38fb9e5c0df162852d5fc7","user":{"login":"tamsky","id":96978,"avatar_url":"https://avatars.githubusercontent.com/u/96978?v=3","gravatar_id":"","url":"https://api.github.com/users/tamsky","html_url":"https://github.com/tamsky","followers_url":"https://api.github.com/users/tamsky/followers","following_url":"https://api.github.com/users/tamsky/following{/other_user}","gists_url":"https://api.github.com/users/tamsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tamsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamsky/subscriptions","organizations_url":"https://api.github.com/users/tamsky/orgs","repos_url":"https://api.github.com/users/tamsky/repos","events_url":"https://api.github.com/users/tamsky/events{/privacy}","received_events_url":"https://api.github.com/users/tamsky/received_events","type":"User","site_admin":false},"repo":{"id":73861515,"name":"kubeform","full_name":"tamsky/kubeform","owner":{"login":"tamsky","id":96978,"avatar_url":"https://avatars.githubusercontent.com/u/96978?v=3","gravatar_id":"","url":"https://api.github.com/users/tamsky","html_url":"https://github.com/tamsky","followers_url":"https://api.github.com/users/tamsky/followers","following_url":"https://api.github.com/users/tamsky/following{/other_user}","gists_url":"https://api.github.com/users/tamsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tamsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamsky/subscriptions","organizations_url":"https://api.github.com/users/tamsky/orgs","repos_url":"https://api.github.com/users/tamsky/repos","events_url":"https://api.github.com/users/tamsky/events{/privacy}","received_events_url":"https://api.github.com/users/tamsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamsky/kubeform","description":"Form your :boat: Kubernetes :anchor: cluster anywhere using CoreOS, Terraform and Ansible","fork":true,"url":"https://api.github.com/repos/tamsky/kubeform","forks_url":"https://api.github.com/repos/tamsky/kubeform/forks","keys_url":"https://api.github.com/repos/tamsky/kubeform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamsky/kubeform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamsky/kubeform/teams","hooks_url":"https://api.github.com/repos/tamsky/kubeform/hooks","issue_events_url":"https://api.github.com/repos/tamsky/kubeform/issues/events{/number}","events_url":"https://api.github.com/repos/tamsky/kubeform/events","assignees_url":"https://api.github.com/repos/tamsky/kubeform/assignees{/user}","branches_url":"https://api.github.com/repos/tamsky/kubeform/branches{/branch}","tags_url":"https://api.github.com/repos/tamsky/kubeform/tags","blobs_url":"https://api.github.com/repos/tamsky/kubeform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamsky/kubeform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamsky/kubeform/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamsky/kubeform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamsky/kubeform/statuses/{sha}","languages_url":"https://api.github.com/repos/tamsky/kubeform/languages","stargazers_url":"https://api.github.com/repos/tamsky/kubeform/stargazers","contributors_url":"https://api.github.com/repos/tamsky/kubeform/contributors","subscribers_url":"https://api.github.com/repos/tamsky/kubeform/subscribers","subscription_url":"https://api.github.com/repos/tamsky/kubeform/subscription","commits_url":"https://api.github.com/repos/tamsky/kubeform/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamsky/kubeform/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamsky/kubeform/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamsky/kubeform/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamsky/kubeform/contents/{+path}","compare_url":"https://api.github.com/repos/tamsky/kubeform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamsky/kubeform/merges","archive_url":"https://api.github.com/repos/tamsky/kubeform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamsky/kubeform/downloads","issues_url":"https://api.github.com/repos/tamsky/kubeform/issues{/number}","pulls_url":"https://api.github.com/repos/tamsky/kubeform/pulls{/number}","milestones_url":"https://api.github.com/repos/tamsky/kubeform/milestones{/number}","notifications_url":"https://api.github.com/repos/tamsky/kubeform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamsky/kubeform/labels{/name}","releases_url":"https://api.github.com/repos/tamsky/kubeform/releases{/id}","deployments_url":"https://api.github.com/repos/tamsky/kubeform/deployments","created_at":"2016-11-15T22:37:55Z","updated_at":"2016-11-15T22:37:56Z","pushed_at":"2016-11-29T18:45:52Z","git_url":"git://github.com/tamsky/kubeform.git","ssh_url":"git@github.com:tamsky/kubeform.git","clone_url":"https://github.com/tamsky/kubeform.git","svn_url":"https://github.com/tamsky/kubeform","homepage":"https://capgemini.github.io/kubeform","size":1679,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Capgemini:master","ref":"master","sha":"4ed771c6e83545756a7bbdf0e5b366d10369a29d","user":{"login":"Capgemini","id":1049773,"avatar_url":"https://avatars.githubusercontent.com/u/1049773?v=3","gravatar_id":"","url":"https://api.github.com/users/Capgemini","html_url":"https://github.com/Capgemini","followers_url":"https://api.github.com/users/Capgemini/followers","following_url":"https://api.github.com/users/Capgemini/following{/other_user}","gists_url":"https://api.github.com/users/Capgemini/gists{/gist_id}","starred_url":"https://api.github.com/users/Capgemini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Capgemini/subscriptions","organizations_url":"https://api.github.com/users/Capgemini/orgs","repos_url":"https://api.github.com/users/Capgemini/repos","events_url":"https://api.github.com/users/Capgemini/events{/privacy}","received_events_url":"https://api.github.com/users/Capgemini/received_events","type":"Organization","site_admin":false},"repo":{"id":53674829,"name":"kubeform","full_name":"Capgemini/kubeform","owner":{"login":"Capgemini","id":1049773,"avatar_url":"https://avatars.githubusercontent.com/u/1049773?v=3","gravatar_id":"","url":"https://api.github.com/users/Capgemini","html_url":"https://github.com/Capgemini","followers_url":"https://api.github.com/users/Capgemini/followers","following_url":"https://api.github.com/users/Capgemini/following{/other_user}","gists_url":"https://api.github.com/users/Capgemini/gists{/gist_id}","starred_url":"https://api.github.com/users/Capgemini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Capgemini/subscriptions","organizations_url":"https://api.github.com/users/Capgemini/orgs","repos_url":"https://api.github.com/users/Capgemini/repos","events_url":"https://api.github.com/users/Capgemini/events{/privacy}","received_events_url":"https://api.github.com/users/Capgemini/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Capgemini/kubeform","description":"Form your :boat: Kubernetes :anchor: cluster anywhere using CoreOS, Terraform and Ansible","fork":false,"url":"https://api.github.com/repos/Capgemini/kubeform","forks_url":"https://api.github.com/repos/Capgemini/kubeform/forks","keys_url":"https://api.github.com/repos/Capgemini/kubeform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Capgemini/kubeform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Capgemini/kubeform/teams","hooks_url":"https://api.github.com/repos/Capgemini/kubeform/hooks","issue_events_url":"https://api.github.com/repos/Capgemini/kubeform/issues/events{/number}","events_url":"https://api.github.com/repos/Capgemini/kubeform/events","assignees_url":"https://api.github.com/repos/Capgemini/kubeform/assignees{/user}","branches_url":"https://api.github.com/repos/Capgemini/kubeform/branches{/branch}","tags_url":"https://api.github.com/repos/Capgemini/kubeform/tags","blobs_url":"https://api.github.com/repos/Capgemini/kubeform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Capgemini/kubeform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Capgemini/kubeform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Capgemini/kubeform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Capgemini/kubeform/statuses/{sha}","languages_url":"https://api.github.com/repos/Capgemini/kubeform/languages","stargazers_url":"https://api.github.com/repos/Capgemini/kubeform/stargazers","contributors_url":"https://api.github.com/repos/Capgemini/kubeform/contributors","subscribers_url":"https://api.github.com/repos/Capgemini/kubeform/subscribers","subscription_url":"https://api.github.com/repos/Capgemini/kubeform/subscription","commits_url":"https://api.github.com/repos/Capgemini/kubeform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Capgemini/kubeform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Capgemini/kubeform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Capgemini/kubeform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Capgemini/kubeform/contents/{+path}","compare_url":"https://api.github.com/repos/Capgemini/kubeform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Capgemini/kubeform/merges","archive_url":"https://api.github.com/repos/Capgemini/kubeform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Capgemini/kubeform/downloads","issues_url":"https://api.github.com/repos/Capgemini/kubeform/issues{/number}","pulls_url":"https://api.github.com/repos/Capgemini/kubeform/pulls{/number}","milestones_url":"https://api.github.com/repos/Capgemini/kubeform/milestones{/number}","notifications_url":"https://api.github.com/repos/Capgemini/kubeform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Capgemini/kubeform/labels{/name}","releases_url":"https://api.github.com/repos/Capgemini/kubeform/releases{/id}","deployments_url":"https://api.github.com/repos/Capgemini/kubeform/deployments","created_at":"2016-03-11T15:02:04Z","updated_at":"2016-11-29T12:18:48Z","pushed_at":"2016-11-29T18:45:53Z","git_url":"git://github.com/Capgemini/kubeform.git","ssh_url":"git@github.com:Capgemini/kubeform.git","clone_url":"https://github.com/Capgemini/kubeform.git","svn_url":"https://github.com/Capgemini/kubeform","homepage":"https://capgemini.github.io/kubeform","size":1693,"stargazers_count":202,"watchers_count":202,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":51,"forks":29,"open_issues":51,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Capgemini/kubeform/pulls/171"},"html":{"href":"https://github.com/Capgemini/kubeform/pull/171"},"issue":{"href":"https://api.github.com/repos/Capgemini/kubeform/issues/171"},"comments":{"href":"https://api.github.com/repos/Capgemini/kubeform/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/Capgemini/kubeform/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/Capgemini/kubeform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Capgemini/kubeform/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/Capgemini/kubeform/statuses/8968b0290ca1866bdc38fb9e5c0df162852d5fc7"}}}}
{"actor":{"display_login":"tamsky"}}