{"action":"opened","number":810,"pull_request":{"url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/810","id":70902514,"html_url":"https://github.com/projecthydra/curation_concerns/pull/810","diff_url":"https://github.com/projecthydra/curation_concerns/pull/810.diff","patch_url":"https://github.com/projecthydra/curation_concerns/pull/810.patch","issue_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/810","number":810,"state":"open","locked":false,"title":"Refactor ImportUrlJob to use BrowseEverything::Retriever","user":{"login":"mbklein","id":196872,"avatar_url":"https://avatars.githubusercontent.com/u/196872?v=3","gravatar_id":"","url":"https://api.github.com/users/mbklein","html_url":"https://github.com/mbklein","followers_url":"https://api.github.com/users/mbklein/followers","following_url":"https://api.github.com/users/mbklein/following{/other_user}","gists_url":"https://api.github.com/users/mbklein/gists{/gist_id}","starred_url":"https://api.github.com/users/mbklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbklein/subscriptions","organizations_url":"https://api.github.com/users/mbklein/orgs","repos_url":"https://api.github.com/users/mbklein/repos","events_url":"https://api.github.com/users/mbklein/events{/privacy}","received_events_url":"https://api.github.com/users/mbklein/received_events","type":"User","site_admin":false},"body":"Fixes #726 \r\n\r\nThis change is interface-compatible with the old `ImportURLJob` implementation, but ignores some of `BrowseEverything::Retriever`’s extended functionality (like respecting expiration dates on single use links and extra auth headers that some cloud providers require). IOW, it’s a regular file downloader that uses a `BrowseEverything` component, but not a full implementation of what it takes to retrieve from all `BrowseEverything` sources.\r\n\r\nChanges proposed in this pull request:\r\n* Replace the hand-rolled `Net::HTTP` downloader with `BrowseEverything::Retriever#retrieve`\r\n* Replace direct HTTP request mocking in the spec test with `WebMock`\r\n\r\n@projecthydra/sufia-code-reviewers\r\n\r\n","created_at":"2016-05-20T19:04:07Z","updated_at":"2016-05-20T19:04:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/810/commits","review_comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/810/comments","review_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/810/comments","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/0d1bc6e4d2e8ae6765690da2c28032ec7d20a8dc","head":{"label":"projecthydra:browse-everything-retriever","ref":"browse-everything-retriever","sha":"0d1bc6e4d2e8ae6765690da2c28032ec7d20a8dc","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":35563024,"name":"curation_concerns","full_name":"projecthydra/curation_concerns","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/curation_concerns","description":"A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.","fork":false,"url":"https://api.github.com/repos/projecthydra/curation_concerns","forks_url":"https://api.github.com/repos/projecthydra/curation_concerns/forks","keys_url":"https://api.github.com/repos/projecthydra/curation_concerns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/curation_concerns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/curation_concerns/teams","hooks_url":"https://api.github.com/repos/projecthydra/curation_concerns/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/curation_concerns/events","assignees_url":"https://api.github.com/repos/projecthydra/curation_concerns/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/curation_concerns/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/tags","blobs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/curation_concerns/languages","stargazers_url":"https://api.github.com/repos/projecthydra/curation_concerns/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/curation_concerns/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscription","commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra/curation_concerns/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/curation_concerns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/curation_concerns/merges","archive_url":"https://api.github.com/repos/projecthydra/curation_concerns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/curation_concerns/downloads","issues_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/curation_concerns/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/curation_concerns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/curation_concerns/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/curation_concerns/releases{/id}","deployments_url":"https://api.github.com/repos/projecthydra/curation_concerns/deployments","created_at":"2015-05-13T17:17:45Z","updated_at":"2016-05-18T18:17:01Z","pushed_at":"2016-05-20T17:19:07Z","git_url":"git://github.com/projecthydra/curation_concerns.git","ssh_url":"git@github.com:projecthydra/curation_concerns.git","clone_url":"https://github.com/projecthydra/curation_concerns.git","svn_url":"https://github.com/projecthydra/curation_concerns","homepage":"","size":4114,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":42,"forks":14,"open_issues":42,"watchers":8,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"f68c98d265d7ae229c3128301ba80665d4b31bd7","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":35563024,"name":"curation_concerns","full_name":"projecthydra/curation_concerns","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/curation_concerns","description":"A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.","fork":false,"url":"https://api.github.com/repos/projecthydra/curation_concerns","forks_url":"https://api.github.com/repos/projecthydra/curation_concerns/forks","keys_url":"https://api.github.com/repos/projecthydra/curation_concerns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/curation_concerns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/curation_concerns/teams","hooks_url":"https://api.github.com/repos/projecthydra/curation_concerns/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/curation_concerns/events","assignees_url":"https://api.github.com/repos/projecthydra/curation_concerns/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/curation_concerns/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/tags","blobs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/curation_concerns/languages","stargazers_url":"https://api.github.com/repos/projecthydra/curation_concerns/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/curation_concerns/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscription","commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra/curation_concerns/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/curation_concerns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/curation_concerns/merges","archive_url":"https://api.github.com/repos/projecthydra/curation_concerns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/curation_concerns/downloads","issues_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/curation_concerns/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/curation_concerns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/curation_concerns/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/curation_concerns/releases{/id}","deployments_url":"https://api.github.com/repos/projecthydra/curation_concerns/deployments","created_at":"2015-05-13T17:17:45Z","updated_at":"2016-05-18T18:17:01Z","pushed_at":"2016-05-20T17:19:07Z","git_url":"git://github.com/projecthydra/curation_concerns.git","ssh_url":"git@github.com:projecthydra/curation_concerns.git","clone_url":"https://github.com/projecthydra/curation_concerns.git","svn_url":"https://github.com/projecthydra/curation_concerns","homepage":"","size":4114,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":42,"forks":14,"open_issues":42,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/810"},"html":{"href":"https://github.com/projecthydra/curation_concerns/pull/810"},"issue":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/issues/810"},"comments":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/issues/810/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/810/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/810/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/0d1bc6e4d2e8ae6765690da2c28032ec7d20a8dc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":22,"changed_files":4}}
{"actor":{"display_login":"mbklein"}}