{"push_id":1436615697,"size":1,"distinct_size":1,"ref":"refs/heads/ac_giphy_obj","head":"775480d43f97c1197178f5043f54e5ff0a0a2562","before":"9dfbe3d166148331d039a7279b4de190db8f1657","commits":[{"sha":"775480d43f97c1197178f5043f54e5ff0a0a2562","author":{"name":"Adrian Cann","email":"08fc9943285e842702a0054c4af3af509b5045f5@gmail.com"},"message":"Refactor Gif scrolling logic into objects\n\n* Implement a functions library for the functions that are somewhat\nindependent from this new class. These are already tested, but now the\nfile is renamed.\n\nThe new Giphy object communicates with the counter.\n* The counter keeps track of current state (GIF img showing). This class\nis purposefully decoupled from the DOM. It does not listen for clicks or\nchange the DOM. It can be told to increment with a direction/amount and\nit will return it's state (which GIF image to show) through it's public\napi currentImg.\n* Giphy asks for the current img and tells the counter class to change\nit's state. To test this interaction I thought it would be fun to mock\nthe counter class without using a mock library like Sinon.\n* Other strange things done here include appending html in the test\nrather than using a template.\n\nNotes:\n* The Giphy class has some distasteful code. It was basically copied and\npasted from a demo on how to use Giphy. It was never satisfactorily\nrewritten. This will be tackled later. For now, the bigger OO\nrestructuring is the focus.","distinct":true,"url":"https://api.github.com/repos/sophomoric/secret/commits/775480d43f97c1197178f5043f54e5ff0a0a2562"}]}
{"actor":{"display_login":"AdrianCann"}}