{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/89823274","pull_request_review_id":10356789,"id":89823274,"diff_hunk":"@@ -107,14 +119,19 @@ var DOMRenderer = ReactFiberReconciler({\n     domElement : Instance,\n     oldProps : Props,\n     newProps : Props,\n-    internalInstanceHandle : Object\n+    rootContainerInstance : Container,\n+    internalInstanceHandle : Object,\n   ) : void {\n-    var type = domElement.tagName.toLowerCase(); // HACK\n-    var root = document.documentElement; // HACK\n+    // TODO: we normalize here because DOM renderer expects tag to be lowercase.\n+    // We can change DOM renderer to compare special case against upper case,\n+    // and use tagName (which is upper case for HTML DOM elements). Or we could\n+    // let the renderer \"normalize\" the fiber type so we don't have to read\n+    // the type from DOM. However we need to remember SVG is case-sensitive.\n+    var tag = domElement.tagName.toLowerCase();","path":"src/renderers/dom/fiber/ReactDOMFiber.js","position":52,"original_position":72,"commit_id":"cb36047749af6c1172f6498e754537c328d5b47c","original_commit_id":"cb36047749af6c1172f6498e754537c328d5b47c","user":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"body":"This is likely going to be an issue to do for every update. We might want to consider just banning non-lowercase uses instead.","created_at":"2016-11-28T16:45:07Z","updated_at":"2016-11-28T16:45:07Z","html_url":"https://github.com/facebook/react/pull/8417#discussion_r89823274","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/8417","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/89823274"},"html":{"href":"https://github.com/facebook/react/pull/8417#discussion_r89823274"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/8417"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8417","id":95227722,"html_url":"https://github.com/facebook/react/pull/8417","diff_url":"https://github.com/facebook/react/pull/8417.diff","patch_url":"https://github.com/facebook/react/pull/8417.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/8417","number":8417,"state":"open","locked":false,"title":"[Fiber] Support SVG by adding a container stack","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"I added a test for SVG. For it to pass, we need to keep track of the closest host container (e.g. `svg` or `foreignobject`) on the stack. <s>Since we need the stack anyway, I also used it to append initial children in the begin phase instead of the complete phase. I am using two separate stacks: one for \"container\" nodes (such as `svg` and `foreignobject`) and another one for any \"new\" nodes so that we can add children to them immediately.</s> Changed to use a single container stack per review comments. I can do the parent stack in a follow up.","created_at":"2016-11-24T21:06:55Z","updated_at":"2016-11-28T16:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ae027a501be3f1fc75b05b053c68b4d6fb7d522","assignee":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/8417/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/8417/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/8417/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/cb36047749af6c1172f6498e754537c328d5b47c","head":{"label":"gaearon:fiber-svg","ref":"fiber-svg","sha":"cb36047749af6c1172f6498e754537c328d5b47c","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"repo":{"id":71563876,"name":"react","full_name":"gaearon/react","owner":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaearon/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/gaearon/react","forks_url":"https://api.github.com/repos/gaearon/react/forks","keys_url":"https://api.github.com/repos/gaearon/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaearon/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaearon/react/teams","hooks_url":"https://api.github.com/repos/gaearon/react/hooks","issue_events_url":"https://api.github.com/repos/gaearon/react/issues/events{/number}","events_url":"https://api.github.com/repos/gaearon/react/events","assignees_url":"https://api.github.com/repos/gaearon/react/assignees{/user}","branches_url":"https://api.github.com/repos/gaearon/react/branches{/branch}","tags_url":"https://api.github.com/repos/gaearon/react/tags","blobs_url":"https://api.github.com/repos/gaearon/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaearon/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaearon/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaearon/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaearon/react/statuses/{sha}","languages_url":"https://api.github.com/repos/gaearon/react/languages","stargazers_url":"https://api.github.com/repos/gaearon/react/stargazers","contributors_url":"https://api.github.com/repos/gaearon/react/contributors","subscribers_url":"https://api.github.com/repos/gaearon/react/subscribers","subscription_url":"https://api.github.com/repos/gaearon/react/subscription","commits_url":"https://api.github.com/repos/gaearon/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaearon/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaearon/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaearon/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaearon/react/contents/{+path}","compare_url":"https://api.github.com/repos/gaearon/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaearon/react/merges","archive_url":"https://api.github.com/repos/gaearon/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaearon/react/downloads","issues_url":"https://api.github.com/repos/gaearon/react/issues{/number}","pulls_url":"https://api.github.com/repos/gaearon/react/pulls{/number}","milestones_url":"https://api.github.com/repos/gaearon/react/milestones{/number}","notifications_url":"https://api.github.com/repos/gaearon/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaearon/react/labels{/name}","releases_url":"https://api.github.com/repos/gaearon/react/releases{/id}","deployments_url":"https://api.github.com/repos/gaearon/react/deployments","created_at":"2016-10-21T12:39:49Z","updated_at":"2016-11-21T18:03:30Z","pushed_at":"2016-11-28T16:41:58Z","git_url":"git://github.com/gaearon/react.git","ssh_url":"git@github.com:gaearon/react.git","clone_url":"https://github.com/gaearon/react.git","svn_url":"https://github.com/gaearon/react","homepage":"https://facebook.github.io/react/","size":70388,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"e34b995f84370002e93875582bddbf3015407a98","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-11-28T16:04:14Z","pushed_at":"2016-11-28T16:41:59Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":148047,"stargazers_count":54842,"watchers_count":54842,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9810,"mirror_url":null,"open_issues_count":629,"forks":9810,"open_issues":629,"watchers":54842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/8417"},"html":{"href":"https://github.com/facebook/react/pull/8417"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/8417"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/8417/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/8417/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/8417/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/cb36047749af6c1172f6498e754537c328d5b47c"}}}}
{"actor":{"display_login":"sebmarkbage"}}