{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/web-annotation/issues/191","repository_url":"https://api.github.com/repos/w3c/web-annotation","labels_url":"https://api.github.com/repos/w3c/web-annotation/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/w3c/web-annotation/issues/191/comments","events_url":"https://api.github.com/repos/w3c/web-annotation/issues/191/events","html_url":"https://github.com/w3c/web-annotation/issues/191","id":143800706,"number":191,"title":"value or text on the definition of an SVG selector","user":{"login":"iherman","id":520723,"avatar_url":"https://avatars.githubusercontent.com/u/520723?v=3","gravatar_id":"","url":"https://api.github.com/users/iherman","html_url":"https://github.com/iherman","followers_url":"https://api.github.com/users/iherman/followers","following_url":"https://api.github.com/users/iherman/following{/other_user}","gists_url":"https://api.github.com/users/iherman/gists{/gist_id}","starred_url":"https://api.github.com/users/iherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iherman/subscriptions","organizations_url":"https://api.github.com/users/iherman/orgs","repos_url":"https://api.github.com/users/iherman/repos","events_url":"https://api.github.com/users/iherman/events{/privacy}","received_events_url":"https://api.github.com/users/iherman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/w3c/web-annotation/labels/model","name":"model","color":"0052cc"},{"url":"https://api.github.com/repos/w3c/web-annotation/labels/telco","name":"telco","color":"ff9f9f"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-27T11:35:30Z","updated_at":"2016-03-29T10:00:31Z","closed_at":null,"body":"(This issue is *not* aimed at the 2016-03-31 publication, it can be handled for future releases!)\r\n\r\nAt present, the SVGSelector has a the following structure:\r\n\r\nEither the svg is referred to via a URI; in JSON this means that it uses the id:\r\n\r\n```json\r\n\"selector\" : {\r\n   \"type\" : \"SvgSelector\",\r\n   \"id\" : \"http://ex.org/svg\"\r\n}\r\n```\r\nor the svg part in incorporated in the object, ie,\r\n\r\n```json\r\n\"selector\" : {\r\n   \"type\": [\"Selector\",\"Content\"],\r\n   \"text\": \"<svg:svg> ... </svg:svg>\"\r\n}\r\n```\r\n\r\nI have several problems with this\r\n\r\n1. Modeling-wise, in terms of RDF, I believe what we have here is that we add an `rdf:type` to the `http://ex.org/svg`. I do not think this is the right thing to do, it looks a little bit like type hijacking (we may not \"own\" the `http://ex.org/svg`, adding an extra type is not really our thing to do)\r\n2. This is the only place in selectors where an extra type should be used.\r\n3. Everywhere else we use \"value\" when we specify the details of a Selector, the usage of 'text' is a bit odd.\r\n\r\nWhat about:\r\n\r\n```json\r\n\"selector\" : {\r\n   \"type\" : \"SvgSelector\",\r\n   \"source\" : \"http://ex.org/svg\"\r\n}\r\n```\r\nand\r\n\r\n```json\r\n\"selector\" : {\r\n   \"type\" : \"SvgSelector\",\r\n   \"value\": \"<svg:svg> ... </svg:svg>\"\r\n}\r\n```\r\n\r\nThis seems to be more consistent with the rest\r\n"},"comment":{"url":"https://api.github.com/repos/w3c/web-annotation/issues/comments/202815147","html_url":"https://github.com/w3c/web-annotation/issues/191#issuecomment-202815147","issue_url":"https://api.github.com/repos/w3c/web-annotation/issues/191","id":202815147,"user":{"login":"iherman","id":520723,"avatar_url":"https://avatars.githubusercontent.com/u/520723?v=3","gravatar_id":"","url":"https://api.github.com/users/iherman","html_url":"https://github.com/iherman","followers_url":"https://api.github.com/users/iherman/followers","following_url":"https://api.github.com/users/iherman/following{/other_user}","gists_url":"https://api.github.com/users/iherman/gists{/gist_id}","starred_url":"https://api.github.com/users/iherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iherman/subscriptions","organizations_url":"https://api.github.com/users/iherman/orgs","repos_url":"https://api.github.com/users/iherman/repos","events_url":"https://api.github.com/users/iherman/events{/privacy}","received_events_url":"https://api.github.com/users/iherman/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T10:00:31Z","updated_at":"2016-03-29T10:00:31Z","body":"\n> On 28 Mar 2016, at 18:23, Rob Sanderson <notifications@github.com> wrote:\n> \n> We should definitely be consistent between SvgSelector and CssStyle, that's definitely a bug regardless of the outcome of this discussion.\n> \n> It seems the same as a textual body to me as well, from a protocol perspective. I can either retrieve the body/stylesheet/svg by dereferencing the IRI supplied in id, or I can use the content provided in the graph. If all three are consistent, then I'm happy... so ...\n> \n> To extend your proposal, can we drop everything down to using the more generic value and get rid of text, TextualBody and Content completely?\n> \nThat works for me. One additional thing: 'format' might be optional. It is probably fine for the Text, but for, say, an SVGSelector or a CssStyle it is obvious that the value is SVG, resp. CSS, ie, adding a format at that point seems to be unnecessary\n\nIvan\n> e.g. as above, plus change this:\n> \n> {\n>   \"type\": \"Annotation\",\n>   \"body\": {\n>     \"type\": \"TextualBody\",    // oa:TextualBody\n>     \"format\": \"text/plain\",\n>     \"text\": \"I love this page!\"   // oa:text\n>   },\n>   \"target\": \"http://example.com/index.html\"\n> }\n> to:\n> \n> {\n>  \"type\": \"Annotation\",\n>  \"body\": {\n>     \"type\": \"Text\",    //dcmitypes:Text\n>     \"format\": \"text/plain\",\n>     \"value\": \"I love this page!\"    // rdf:value\n>   },\n>   \"target\": \"http://example.com/index.html\"\n> }\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly or view it on GitHub <https://github.com/w3c/web-annotation/issues/191#issuecomment-202470464>\n\n\n----\nIvan Herman, W3C\nDigital Publishing Lead\nHome: http://www.w3.org/People/Ivan/\nmobile: +31-641044153\nORCID ID: http://orcid.org/0000-0003-0782-2704\n\n\n\n\n"}}