{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments/49937113","id":49937113,"diff_hunk":"@@ -51,3 +82,41 @@ def test_get_connect_info(self):\n             'key', 'signature_scheme',\n         ])\n         self.assertEqual(keys, expected)\n+    \n+    @dec.skip_win32\n+    def test_signal_kernel_subprocesses(self):\n+        self._install_test_kernel()\n+        km, kc = start_new_kernel(kernel_name='signaltest')\n+        def execute(cmd):\n+            kc.execute(cmd)\n+            reply = kc.get_shell_msg(TIMEOUT)","path":"jupyter_client/tests/test_kernelmanager.py","position":59,"original_position":59,"commit_id":"7d3a797e361c4c31906efd395f53e7e3099e75ee","original_commit_id":"7d3a797e361c4c31906efd395f53e7e3099e75ee","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=3","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"body":"30 seconds is going to feel like waiting forever if we ever break what you just fixed and the test kernel is suspended. But I guess any shorter and it risks sporadic failures on Travis.","created_at":"2016-01-16T20:59:27Z","updated_at":"2016-01-16T20:59:27Z","html_url":"https://github.com/jupyter/jupyter_client/pull/109#discussion_r49937113","pull_request_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments/49937113"},"html":{"href":"https://github.com/jupyter/jupyter_client/pull/109#discussion_r49937113"},"pull_request":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109","id":56037953,"html_url":"https://github.com/jupyter/jupyter_client/pull/109","diff_url":"https://github.com/jupyter/jupyter_client/pull/109.diff","patch_url":"https://github.com/jupyter/jupyter_client/pull/109.patch","issue_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/109","number":109,"state":"open","locked":false,"title":"start new session instead of setpgrp for detaching kernel","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"setpgrp seems to cause problems with children spawning subprocesses. setsid doesn't cause the same problems, but has its own issues.\n\nThis is WIP because I need to at least add some tests to exercise various subprocesses-of-subprocesses cases.\n\ncc @takluyver who knows more about terminals and process groups than I do.","created_at":"2016-01-14T13:59:39Z","updated_at":"2016-01-16T20:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70873fb95d069f1689a7f7b121275660dd6996c2","assignee":null,"milestone":{"url":"https://api.github.com/repos/jupyter/jupyter_client/milestones/6","html_url":"https://github.com/jupyter/jupyter_client/milestones/4.2","labels_url":"https://api.github.com/repos/jupyter/jupyter_client/milestones/6/labels","id":1337987,"number":6,"title":"4.2","description":null,"creator":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":18,"state":"open","created_at":"2015-10-05T11:24:32Z","updated_at":"2016-01-15T14:33:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109/commits","review_comments_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109/comments","review_comment_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/109/comments","statuses_url":"https://api.github.com/repos/jupyter/jupyter_client/statuses/7d3a797e361c4c31906efd395f53e7e3099e75ee","head":{"label":"minrk:setsid","ref":"setsid","sha":"7d3a797e361c4c31906efd395f53e7e3099e75ee","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"repo":{"id":34010117,"name":"jupyter_client","full_name":"minrk/jupyter_client","owner":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minrk/jupyter_client","description":"Jupyter protocol client APIs","fork":true,"url":"https://api.github.com/repos/minrk/jupyter_client","forks_url":"https://api.github.com/repos/minrk/jupyter_client/forks","keys_url":"https://api.github.com/repos/minrk/jupyter_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minrk/jupyter_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minrk/jupyter_client/teams","hooks_url":"https://api.github.com/repos/minrk/jupyter_client/hooks","issue_events_url":"https://api.github.com/repos/minrk/jupyter_client/issues/events{/number}","events_url":"https://api.github.com/repos/minrk/jupyter_client/events","assignees_url":"https://api.github.com/repos/minrk/jupyter_client/assignees{/user}","branches_url":"https://api.github.com/repos/minrk/jupyter_client/branches{/branch}","tags_url":"https://api.github.com/repos/minrk/jupyter_client/tags","blobs_url":"https://api.github.com/repos/minrk/jupyter_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minrk/jupyter_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minrk/jupyter_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/minrk/jupyter_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minrk/jupyter_client/statuses/{sha}","languages_url":"https://api.github.com/repos/minrk/jupyter_client/languages","stargazers_url":"https://api.github.com/repos/minrk/jupyter_client/stargazers","contributors_url":"https://api.github.com/repos/minrk/jupyter_client/contributors","subscribers_url":"https://api.github.com/repos/minrk/jupyter_client/subscribers","subscription_url":"https://api.github.com/repos/minrk/jupyter_client/subscription","commits_url":"https://api.github.com/repos/minrk/jupyter_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/minrk/jupyter_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/minrk/jupyter_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/minrk/jupyter_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/minrk/jupyter_client/contents/{+path}","compare_url":"https://api.github.com/repos/minrk/jupyter_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minrk/jupyter_client/merges","archive_url":"https://api.github.com/repos/minrk/jupyter_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minrk/jupyter_client/downloads","issues_url":"https://api.github.com/repos/minrk/jupyter_client/issues{/number}","pulls_url":"https://api.github.com/repos/minrk/jupyter_client/pulls{/number}","milestones_url":"https://api.github.com/repos/minrk/jupyter_client/milestones{/number}","notifications_url":"https://api.github.com/repos/minrk/jupyter_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minrk/jupyter_client/labels{/name}","releases_url":"https://api.github.com/repos/minrk/jupyter_client/releases{/id}","created_at":"2015-04-15T18:04:05Z","updated_at":"2015-04-15T18:04:06Z","pushed_at":"2016-01-15T13:08:19Z","git_url":"git://github.com/minrk/jupyter_client.git","ssh_url":"git@github.com:minrk/jupyter_client.git","clone_url":"https://github.com/minrk/jupyter_client.git","svn_url":"https://github.com/minrk/jupyter_client","homepage":null,"size":2067,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"bb0863b55e5e02883935eaead1bdfcc9d6ae0cdc","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33653575,"name":"jupyter_client","full_name":"jupyter/jupyter_client","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/jupyter_client","description":"Jupyter protocol client APIs","fork":false,"url":"https://api.github.com/repos/jupyter/jupyter_client","forks_url":"https://api.github.com/repos/jupyter/jupyter_client/forks","keys_url":"https://api.github.com/repos/jupyter/jupyter_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/jupyter_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/jupyter_client/teams","hooks_url":"https://api.github.com/repos/jupyter/jupyter_client/hooks","issue_events_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/jupyter_client/events","assignees_url":"https://api.github.com/repos/jupyter/jupyter_client/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/jupyter_client/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/jupyter_client/tags","blobs_url":"https://api.github.com/repos/jupyter/jupyter_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/jupyter_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/jupyter_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/jupyter_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/jupyter_client/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/jupyter_client/languages","stargazers_url":"https://api.github.com/repos/jupyter/jupyter_client/stargazers","contributors_url":"https://api.github.com/repos/jupyter/jupyter_client/contributors","subscribers_url":"https://api.github.com/repos/jupyter/jupyter_client/subscribers","subscription_url":"https://api.github.com/repos/jupyter/jupyter_client/subscription","commits_url":"https://api.github.com/repos/jupyter/jupyter_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/jupyter_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/jupyter_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/jupyter_client/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/jupyter_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/jupyter_client/merges","archive_url":"https://api.github.com/repos/jupyter/jupyter_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/jupyter_client/downloads","issues_url":"https://api.github.com/repos/jupyter/jupyter_client/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/jupyter_client/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/jupyter_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/jupyter_client/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/jupyter_client/releases{/id}","created_at":"2015-04-09T06:57:29Z","updated_at":"2016-01-11T19:29:49Z","pushed_at":"2016-01-15T13:08:21Z","git_url":"git://github.com/jupyter/jupyter_client.git","ssh_url":"git@github.com:jupyter/jupyter_client.git","clone_url":"https://github.com/jupyter/jupyter_client.git","svn_url":"https://github.com/jupyter/jupyter_client","homepage":"http://jupyter-client.readthedocs.org/","size":2081,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":16,"forks":48,"open_issues":16,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109"},"html":{"href":"https://github.com/jupyter/jupyter_client/pull/109"},"issue":{"href":"https://api.github.com/repos/jupyter/jupyter_client/issues/109"},"comments":{"href":"https://api.github.com/repos/jupyter/jupyter_client/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/jupyter_client/statuses/7d3a797e361c4c31906efd395f53e7e3099e75ee"}}}}