{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/57072234","id":57072234,"diff_hunk":"@@ -73,6 +73,7 @@ Error: ${e.message}`\n     };\n     activeWS.onmessage = ({data}) => {\n       // Moving to top gives errors due to NativeModules not being initialized\n+      const { AndroidConstants } = require('NativeModules');\n       const HMRLoadingView = require('HMRLoadingView');","path":"Libraries/Utilities/HMRClient.js","position":5,"original_position":5,"commit_id":"a4f3bd8d6ad6e300cf50a3fabd8cca373e5b6b8a","original_commit_id":"a4f3bd8d6ad6e300cf50a3fabd8cca373e5b6b8a","user":{"login":"martinbigio","id":535661,"avatar_url":"https://avatars.githubusercontent.com/u/535661?v=3","gravatar_id":"","url":"https://api.github.com/users/martinbigio","html_url":"https://github.com/martinbigio","followers_url":"https://api.github.com/users/martinbigio/followers","following_url":"https://api.github.com/users/martinbigio/following{/other_user}","gists_url":"https://api.github.com/users/martinbigio/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbigio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbigio/subscriptions","organizations_url":"https://api.github.com/users/martinbigio/orgs","repos_url":"https://api.github.com/users/martinbigio/repos","events_url":"https://api.github.com/users/martinbigio/events{/privacy}","received_events_url":"https://api.github.com/users/martinbigio/received_events","type":"User","site_admin":false},"body":"`AndroidConstants` doesn't exist on iOS :)","created_at":"2016-03-22T21:27:04Z","updated_at":"2016-03-22T21:27:04Z","html_url":"https://github.com/facebook/react-native/pull/6594#discussion_r57072234","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/6594","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/57072234"},"html":{"href":"https://github.com/facebook/react-native/pull/6594#discussion_r57072234"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6594"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/6594","id":63793453,"html_url":"https://github.com/facebook/react-native/pull/6594","diff_url":"https://github.com/facebook/react-native/pull/6594.diff","patch_url":"https://github.com/facebook/react-native/pull/6594.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/6594","number":6594,"state":"open","locked":false,"title":"Fix fetching sourcemap in genymotion. Fixes #5338","user":{"login":"satya164","id":1174278,"avatar_url":"https://avatars.githubusercontent.com/u/1174278?v=3","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"body":"Source maps are broken on Genymotion right now as they aren't being loaded from the correct URL. refer - https://github.com/facebook/react-native/issues/5338#issuecomment-188232402\r\n\r\n**Test plan**\r\n\r\nBuild and install UIExplorer from master branch in genymotion and enable hot reload. When you change a file and save it, you'll see a Yellow box due to source map fetching failed, as per the referenced comment.\r\n\r\nDoing the same for this branch doesn't produce any yellow boxes.","created_at":"2016-03-22T21:09:18Z","updated_at":"2016-03-22T21:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"295926dc9096b896f95ec966e49cf8db70fd7850","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/6594/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/6594/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/6594/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/a4f3bd8d6ad6e300cf50a3fabd8cca373e5b6b8a","head":{"label":"satya164:fix-hmr-genymotion","ref":"fix-hmr-genymotion","sha":"a4f3bd8d6ad6e300cf50a3fabd8cca373e5b6b8a","user":{"login":"satya164","id":1174278,"avatar_url":"https://avatars.githubusercontent.com/u/1174278?v=3","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"repo":{"id":42726415,"name":"react-native","full_name":"satya164/react-native","owner":{"login":"satya164","id":1174278,"avatar_url":"https://avatars.githubusercontent.com/u/1174278?v=3","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/satya164/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/satya164/react-native","forks_url":"https://api.github.com/repos/satya164/react-native/forks","keys_url":"https://api.github.com/repos/satya164/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satya164/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satya164/react-native/teams","hooks_url":"https://api.github.com/repos/satya164/react-native/hooks","issue_events_url":"https://api.github.com/repos/satya164/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/satya164/react-native/events","assignees_url":"https://api.github.com/repos/satya164/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/satya164/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/satya164/react-native/tags","blobs_url":"https://api.github.com/repos/satya164/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satya164/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satya164/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/satya164/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satya164/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/satya164/react-native/languages","stargazers_url":"https://api.github.com/repos/satya164/react-native/stargazers","contributors_url":"https://api.github.com/repos/satya164/react-native/contributors","subscribers_url":"https://api.github.com/repos/satya164/react-native/subscribers","subscription_url":"https://api.github.com/repos/satya164/react-native/subscription","commits_url":"https://api.github.com/repos/satya164/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/satya164/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/satya164/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/satya164/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/satya164/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/satya164/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satya164/react-native/merges","archive_url":"https://api.github.com/repos/satya164/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satya164/react-native/downloads","issues_url":"https://api.github.com/repos/satya164/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/satya164/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/satya164/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/satya164/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satya164/react-native/labels{/name}","releases_url":"https://api.github.com/repos/satya164/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/satya164/react-native/deployments","created_at":"2015-09-18T14:14:48Z","updated_at":"2016-03-21T18:47:23Z","pushed_at":"2016-03-22T20:43:59Z","git_url":"git://github.com/satya164/react-native.git","ssh_url":"git@github.com:satya164/react-native.git","clone_url":"https://github.com/satya164/react-native.git","svn_url":"https://github.com/satya164/react-native","homepage":"http://facebook.github.io/react-native/","size":38540,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"78ad15d85b2ce0aa43274e73c2f96acceddb8a33","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-03-22T20:59:05Z","pushed_at":"2016-03-22T21:09:19Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":84743,"stargazers_count":29166,"watchers_count":29166,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5585,"mirror_url":null,"open_issues_count":759,"forks":5585,"open_issues":759,"watchers":29166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6594"},"html":{"href":"https://github.com/facebook/react-native/pull/6594"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/6594"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/6594/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6594/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6594/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/a4f3bd8d6ad6e300cf50a3fabd8cca373e5b6b8a"}}}}