{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/85842433","pull_request_review_id":6534105,"id":85842433,"diff_hunk":"@@ -1,39 +1,46 @@\n-FROM ubuntu:14.04.4\n+FROM ubuntu:16.04\n MAINTAINER help@dcos.io\n \n RUN apt-get -qq update && apt-get -y install \\\n   autoconf \\\n   automake \\\n   cmake \\\n-  make \\\n-  gcc \\\n   cpp \\\n-  patch \\\n-  python-dev \\\n-  python-pip \\\n-  git \\\n-  libtool \\\n+  curl \\\n   default-jdk \\\n   default-jre \\\n+  dpkg-dev \\\n+  g++-4.8 \\\n+  gcc-4.8 \\\n+  gettext-base \\\n+  git \\\n   gzip \\\n-  zlib1g-dev \\\n+  libapr1-dev \\\n   libcurl4-openssl-dev \\\n-  python-setuptools \\\n-  dpkg-dev \\\n+  libnl-3-dev \\\n+  libnl-genl-3-dev \\\n+  libpcre++-dev \\\n+  libpopt-dev \\\n   libsasl2-dev \\\n-  maven \\\n-  libapr1-dev \\\n   libsvn-dev \\\n+  libtool \\\n+  linux-headers-4.4.0-45-generic \\\n+  make \\\n+  maven \\\n+  patch \\\n+  pkg-config \\\n+  python-dev \\\n+  python-pip \\\n+  python-setuptools \\\n   ruby \\\n-  curl \\\n-  wget \\\n   scala \\\n+  unzip \\\n+  wget \\\n+  xutils-dev \\\n   xz-utils \\\n-  libpopt-dev \\\n-  libnl-3-dev \\\n-  libnl-genl-3-dev \\\n-  linux-headers-3.19.0-21-generic \\\n-  pkg-config \\\n-  gettext-base \\\n-  unzip\n+  zlib1g-dev\n+\n+ENV CC=/usr/bin/gcc-4.8","path":"pkgpanda/docker/dcos-builder/Dockerfile","position":65,"original_position":65,"commit_id":"bbc1b06a8e577a9c0cf89b5eff9b51f7f1835bf4","original_commit_id":"bbc1b06a8e577a9c0cf89b5eff9b51f7f1835bf4","user":{"login":"cmaloney","id":751088,"avatar_url":"https://avatars.githubusercontent.com/u/751088?v=3","gravatar_id":"","url":"https://api.github.com/users/cmaloney","html_url":"https://github.com/cmaloney","followers_url":"https://api.github.com/users/cmaloney/followers","following_url":"https://api.github.com/users/cmaloney/following{/other_user}","gists_url":"https://api.github.com/users/cmaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaloney/subscriptions","organizations_url":"https://api.github.com/users/cmaloney/orgs","repos_url":"https://api.github.com/users/cmaloney/repos","events_url":"https://api.github.com/users/cmaloney/events{/privacy}","received_events_url":"https://api.github.com/users/cmaloney/received_events","type":"User","site_admin":false},"body":"Sounds good for now. Definitely we're going to need to bundle libstdc++ in the future (And maybe libc as well).","created_at":"2016-10-31T21:59:31Z","updated_at":"2016-10-31T21:59:31Z","html_url":"https://github.com/dcos/dcos/pull/905#discussion_r85842433","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/905","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/85842433"},"html":{"href":"https://github.com/dcos/dcos/pull/905#discussion_r85842433"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/905"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/905","id":91281076,"html_url":"https://github.com/dcos/dcos/pull/905","diff_url":"https://github.com/dcos/dcos/pull/905.diff","patch_url":"https://github.com/dcos/dcos/pull/905.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/905","number":905,"state":"open","locked":false,"title":"Change the default build image to Ubuntu 16","user":{"login":"kaysoky","id":1134596,"avatar_url":"https://avatars.githubusercontent.com/u/1134596?v=3","gravatar_id":"","url":"https://api.github.com/users/kaysoky","html_url":"https://github.com/kaysoky","followers_url":"https://api.github.com/users/kaysoky/followers","following_url":"https://api.github.com/users/kaysoky/following{/other_user}","gists_url":"https://api.github.com/users/kaysoky/gists{/gist_id}","starred_url":"https://api.github.com/users/kaysoky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaysoky/subscriptions","organizations_url":"https://api.github.com/users/kaysoky/orgs","repos_url":"https://api.github.com/users/kaysoky/repos","events_url":"https://api.github.com/users/kaysoky/events{/privacy}","received_events_url":"https://api.github.com/users/kaysoky/received_events","type":"User","site_admin":false},"body":"This PR does:\n- Alphabetizes the list of dependencies in the Dockerfile\n- Bumps the base image from `ubuntu:14.04.4` to `ubuntu:16.04`\n  - Changes `gcc` to `gcc-4.8` and `g++-4.8` (the same version that is currently being used) and set `CC` and `CXX` environment variables appropriately.\n  - Bumps the package for `linux-headers` to match the updated kernel\n  - Add `libpcre++-dev` dependency for adminrouter/nginx (the installed library is placed in the same location as before)\n  - Add `xutils-dev` dependency for the `makedepend` utility\n- `s/CXXFLAGS/CPPFLAGS/` in the main Python build, needed to find and build the `_ssl` module\n- Removed extraneous `sudo`s from the Cosmos and Marathon build scripts\n","created_at":"2016-10-27T21:08:24Z","updated_at":"2016-10-31T21:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5596bd9d9fff77b3edadcd71f0a01939eecb7423","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/905/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/905/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/905/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/bbc1b06a8e577a9c0cf89b5eff9b51f7f1835bf4","head":{"label":"mesosphere:ubuntu16-build","ref":"ubuntu16-build","sha":"bbc1b06a8e577a9c0cf89b5eff9b51f7f1835bf4","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":62745648,"name":"dcos","full_name":"mesosphere/dcos","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/mesosphere/dcos","forks_url":"https://api.github.com/repos/mesosphere/dcos/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos/deployments","created_at":"2016-07-06T18:52:22Z","updated_at":"2016-10-15T21:33:16Z","pushed_at":"2016-10-31T18:45:48Z","git_url":"git://github.com/mesosphere/dcos.git","ssh_url":"git@github.com:mesosphere/dcos.git","clone_url":"https://github.com/mesosphere/dcos.git","svn_url":"https://github.com/mesosphere/dcos","homepage":"https://dcos.io","size":2259,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"f8cb6da43c42bd89207040ca60d70c4801a50c89","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2016-10-31T17:29:49Z","pushed_at":"2016-10-31T21:35:44Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":3082,"stargazers_count":1033,"watchers_count":1033,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":42,"forks":174,"open_issues":42,"watchers":1033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/905"},"html":{"href":"https://github.com/dcos/dcos/pull/905"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/905"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/905/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/905/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/905/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/bbc1b06a8e577a9c0cf89b5eff9b51f7f1835bf4"}}}}
{"actor":{"display_login":"cmaloney"}}