{"comment":{"url":"https://api.github.com/repos/MathieuDuponchelle/dbus-deviation/comments/16201337","html_url":"https://github.com/MathieuDuponchelle/dbus-deviation/commit/780d78e2931d1f62f85d492169a9238f9583f818#commitcomment-16201337","id":16201337,"user":{"login":"pwithnall","id":53172,"avatar_url":"https://avatars.githubusercontent.com/u/53172?v=3","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"position":56,"line":62,"path":"dbusapi/ast.py","commit_id":"780d78e2931d1f62f85d492169a9238f9583f818","created_at":"2016-02-19T12:01:10Z","updated_at":"2016-02-19T12:01:10Z","body":"Ah, I see you added `ParsingLog` for that. That means that the entries generated by `Log` and `ParsingLog` will be tuples of differing size, though, so they can’t be handled uniformly. I think the entries in `_create_entry()` here should be standardised as 4-tuples, using the format from `ParsingLog` (which is the same format used by `InterfaceComparator` too).\r\n\r\nIn future, I think it would make sense to use an object, rather than a tuple, for each log message, since then we could expose arbitrary extra data as properties. However, that would be an API break and can be done later."}}