{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/stan/issues/1979","repository_url":"https://api.github.com/repos/stan-dev/stan","labels_url":"https://api.github.com/repos/stan-dev/stan/issues/1979/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/stan/issues/1979/comments","events_url":"https://api.github.com/repos/stan-dev/stan/issues/1979/events","html_url":"https://github.com/stan-dev/stan/pull/1979","id":167590016,"number":1979,"title":"Remove duplicate acceptance procedure, update tests","user":{"login":"betanalpha","id":1527190,"avatar_url":"https://avatars.githubusercontent.com/u/1527190?v=3","gravatar_id":"","url":"https://api.github.com/users/betanalpha","html_url":"https://github.com/betanalpha","followers_url":"https://api.github.com/users/betanalpha/followers","following_url":"https://api.github.com/users/betanalpha/following{/other_user}","gists_url":"https://api.github.com/users/betanalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/betanalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betanalpha/subscriptions","organizations_url":"https://api.github.com/users/betanalpha/orgs","repos_url":"https://api.github.com/users/betanalpha/repos","events_url":"https://api.github.com/users/betanalpha/events{/privacy}","received_events_url":"https://api.github.com/users/betanalpha/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/stan-dev/stan/labels/code%20reviewed","name":"code reviewed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/stan-dev/stan/milestones/20","html_url":"https://github.com/stan-dev/stan/milestones/v2.10.0++","labels_url":"https://api.github.com/repos/stan-dev/stan/milestones/20/labels","id":1672338,"number":20,"title":"v2.10.0++","description":"Version after v2.10.0.","creator":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":15,"state":"open","created_at":"2016-03-29T16:57:05Z","updated_at":"2016-07-26T13:48:37Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-07-26T12:00:04Z","updated_at":"2016-07-26T14:05:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/stan/pulls/1979","html_url":"https://github.com/stan-dev/stan/pull/1979","diff_url":"https://github.com/stan-dev/stan/pull/1979.diff","patch_url":"https://github.com/stan-dev/stan/pull/1979.patch"},"body":"#### Submisison Checklist\r\n\r\n- [x] Run unit tests: `./runTests.py src/test/unit`\r\n- [x] Run cpplint: `make cpplint`\r\n- [x] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary\r\n\r\nRemoves duplicate acceptance procedure in the default NUTS algorithm that was causing chains to push too far out into the tails.\r\n\r\n#### Intended Effect\r\n\r\nRestores correctness of default NUTS algorithm.\r\n\r\n#### How to Verify\r\n\r\nThe following model,\r\n\r\n    parameters {\r\n      real<lower=0, upper=1> x;\r\n    }\r\n    model {\r\n      x ~ uniform(0, 1);\r\n    }\r\n\r\nshould now return an actually uniform distribution.\r\n\r\n#### Side Effects\r\n\r\nSmall changes to all default sampler output.\r\n\r\n#### Documentation\r\n\r\nNone.\r\n\r\n#### Reviewer Suggestions\r\n\r\n@syclik, @bob-carpenter, @bgoodri \r\n\r\n#### Copyright and Licensing\r\n\r\nCopyright: University of Warwick.\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/stan/issues/comments/235277749","html_url":"https://github.com/stan-dev/stan/pull/1979#issuecomment-235277749","issue_url":"https://api.github.com/repos/stan-dev/stan/issues/1979","id":235277749,"user":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T14:05:10Z","updated_at":"2016-07-26T14:05:10Z","body":"Those values are on Mac OS X, so you should be able to run locally."}}
{"actor":{"display_login":"syclik"}}