{"action":"created","comment":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/comments/73236022","id":73236022,"diff_hunk":"@@ -84,7 +84,6 @@ func diffSummaryList(ch chan<- diffSummaryProgress, v1, v2 types.List) {\n \tspliceChan := make(chan types.Splice)\n \tstopChan := make(chan struct{}, 1) // buffer size of 1, so this won't block if diff already finished\n \n-\tdefer stop(stopChan)","path":"cmd/noms/diff/summary.go","position":22,"original_position":22,"commit_id":"9c4f703b94170e0ce1fb8224270e68bf5a66230a","original_commit_id":"9c4f703b94170e0ce1fb8224270e68bf5a66230a","user":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"body":"The summary algo doesn't actually stop, so there is no point sending to the stop channel.","created_at":"2016-08-02T20:58:00Z","updated_at":"2016-08-02T20:58:00Z","html_url":"https://github.com/attic-labs/noms/pull/2249#discussion_r73236022","pull_request_url":"https://api.github.com/repos/attic-labs/noms/pulls/2249","_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments/73236022"},"html":{"href":"https://github.com/attic-labs/noms/pull/2249#discussion_r73236022"},"pull_request":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2249"}}},"pull_request":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/2249","id":79807536,"html_url":"https://github.com/attic-labs/noms/pull/2249","diff_url":"https://github.com/attic-labs/noms/pull/2249.diff","patch_url":"https://github.com/attic-labs/noms/pull/2249.patch","issue_url":"https://api.github.com/repos/attic-labs/noms/issues/2249","number":2249,"state":"open","locked":false,"title":"Make sure that set/map diff has completed before returning from noms log","user":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"body":"This fixes https://github.com/attic-labs/noms/issues/2235 where set/map\r\ndiff was still running when noms log has finished, and already closed\r\nits database. Commonly this would crash.\r\n\r\nI've removed panic-based control flow to make error handling explicit,\r\nand added a \"DiffLeftRight\" method to set/map so that noms log completes\r\nASAP. See the issue for details.","created_at":"2016-08-02T20:57:17Z","updated_at":"2016-08-02T20:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26ef04a9d78b6cd71b6b5d4dc039715580c855cb","assignee":{"login":"rafael-atticlabs","id":12848669,"avatar_url":"https://avatars.githubusercontent.com/u/12848669?v=3","gravatar_id":"","url":"https://api.github.com/users/rafael-atticlabs","html_url":"https://github.com/rafael-atticlabs","followers_url":"https://api.github.com/users/rafael-atticlabs/followers","following_url":"https://api.github.com/users/rafael-atticlabs/following{/other_user}","gists_url":"https://api.github.com/users/rafael-atticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael-atticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael-atticlabs/subscriptions","organizations_url":"https://api.github.com/users/rafael-atticlabs/orgs","repos_url":"https://api.github.com/users/rafael-atticlabs/repos","events_url":"https://api.github.com/users/rafael-atticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rafael-atticlabs/received_events","type":"User","site_admin":false},"assignees":[{"login":"rafael-atticlabs","id":12848669,"avatar_url":"https://avatars.githubusercontent.com/u/12848669?v=3","gravatar_id":"","url":"https://api.github.com/users/rafael-atticlabs","html_url":"https://github.com/rafael-atticlabs","followers_url":"https://api.github.com/users/rafael-atticlabs/followers","following_url":"https://api.github.com/users/rafael-atticlabs/following{/other_user}","gists_url":"https://api.github.com/users/rafael-atticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael-atticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael-atticlabs/subscriptions","organizations_url":"https://api.github.com/users/rafael-atticlabs/orgs","repos_url":"https://api.github.com/users/rafael-atticlabs/repos","events_url":"https://api.github.com/users/rafael-atticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rafael-atticlabs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/attic-labs/noms/pulls/2249/commits","review_comments_url":"https://api.github.com/repos/attic-labs/noms/pulls/2249/comments","review_comment_url":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/attic-labs/noms/issues/2249/comments","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/9c4f703b94170e0ce1fb8224270e68bf5a66230a","head":{"label":"kalman:diff-structure","ref":"diff-structure","sha":"9c4f703b94170e0ce1fb8224270e68bf5a66230a","user":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"repo":{"id":64782667,"name":"noms","full_name":"kalman/noms","owner":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalman/noms","description":"The versioned, forkable, syncable database","fork":true,"url":"https://api.github.com/repos/kalman/noms","forks_url":"https://api.github.com/repos/kalman/noms/forks","keys_url":"https://api.github.com/repos/kalman/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalman/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalman/noms/teams","hooks_url":"https://api.github.com/repos/kalman/noms/hooks","issue_events_url":"https://api.github.com/repos/kalman/noms/issues/events{/number}","events_url":"https://api.github.com/repos/kalman/noms/events","assignees_url":"https://api.github.com/repos/kalman/noms/assignees{/user}","branches_url":"https://api.github.com/repos/kalman/noms/branches{/branch}","tags_url":"https://api.github.com/repos/kalman/noms/tags","blobs_url":"https://api.github.com/repos/kalman/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalman/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalman/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalman/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalman/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/kalman/noms/languages","stargazers_url":"https://api.github.com/repos/kalman/noms/stargazers","contributors_url":"https://api.github.com/repos/kalman/noms/contributors","subscribers_url":"https://api.github.com/repos/kalman/noms/subscribers","subscription_url":"https://api.github.com/repos/kalman/noms/subscription","commits_url":"https://api.github.com/repos/kalman/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalman/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalman/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalman/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalman/noms/contents/{+path}","compare_url":"https://api.github.com/repos/kalman/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalman/noms/merges","archive_url":"https://api.github.com/repos/kalman/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalman/noms/downloads","issues_url":"https://api.github.com/repos/kalman/noms/issues{/number}","pulls_url":"https://api.github.com/repos/kalman/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/kalman/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/kalman/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalman/noms/labels{/name}","releases_url":"https://api.github.com/repos/kalman/noms/releases{/id}","deployments_url":"https://api.github.com/repos/kalman/noms/deployments","created_at":"2016-08-02T18:36:44Z","updated_at":"2016-08-02T18:36:46Z","pushed_at":"2016-08-02T20:56:44Z","git_url":"git://github.com/kalman/noms.git","ssh_url":"git@github.com:kalman/noms.git","clone_url":"https://github.com/kalman/noms.git","svn_url":"https://github.com/kalman/noms","homepage":"","size":24844,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"attic-labs:master","ref":"master","sha":"6f46c0eba34bce01455ad14f37c09f0d79fe0d48","user":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":36778364,"name":"noms","full_name":"attic-labs/noms","owner":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/attic-labs/noms","description":"The versioned, forkable, syncable database","fork":false,"url":"https://api.github.com/repos/attic-labs/noms","forks_url":"https://api.github.com/repos/attic-labs/noms/forks","keys_url":"https://api.github.com/repos/attic-labs/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/attic-labs/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/attic-labs/noms/teams","hooks_url":"https://api.github.com/repos/attic-labs/noms/hooks","issue_events_url":"https://api.github.com/repos/attic-labs/noms/issues/events{/number}","events_url":"https://api.github.com/repos/attic-labs/noms/events","assignees_url":"https://api.github.com/repos/attic-labs/noms/assignees{/user}","branches_url":"https://api.github.com/repos/attic-labs/noms/branches{/branch}","tags_url":"https://api.github.com/repos/attic-labs/noms/tags","blobs_url":"https://api.github.com/repos/attic-labs/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/attic-labs/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/attic-labs/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/attic-labs/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/attic-labs/noms/languages","stargazers_url":"https://api.github.com/repos/attic-labs/noms/stargazers","contributors_url":"https://api.github.com/repos/attic-labs/noms/contributors","subscribers_url":"https://api.github.com/repos/attic-labs/noms/subscribers","subscription_url":"https://api.github.com/repos/attic-labs/noms/subscription","commits_url":"https://api.github.com/repos/attic-labs/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/attic-labs/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/attic-labs/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/attic-labs/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/attic-labs/noms/contents/{+path}","compare_url":"https://api.github.com/repos/attic-labs/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/attic-labs/noms/merges","archive_url":"https://api.github.com/repos/attic-labs/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/attic-labs/noms/downloads","issues_url":"https://api.github.com/repos/attic-labs/noms/issues{/number}","pulls_url":"https://api.github.com/repos/attic-labs/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/attic-labs/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/attic-labs/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/attic-labs/noms/labels{/name}","releases_url":"https://api.github.com/repos/attic-labs/noms/releases{/id}","deployments_url":"https://api.github.com/repos/attic-labs/noms/deployments","created_at":"2015-06-03T03:44:49Z","updated_at":"2016-08-02T20:57:58Z","pushed_at":"2016-08-02T20:57:17Z","git_url":"git://github.com/attic-labs/noms.git","ssh_url":"git@github.com:attic-labs/noms.git","clone_url":"https://github.com/attic-labs/noms.git","svn_url":"https://github.com/attic-labs/noms","homepage":"","size":27041,"stargazers_count":406,"watchers_count":406,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":203,"forks":15,"open_issues":203,"watchers":406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2249"},"html":{"href":"https://github.com/attic-labs/noms/pull/2249"},"issue":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2249"},"comments":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2249/comments"},"review_comments":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2249/comments"},"review_comment":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2249/commits"},"statuses":{"href":"https://api.github.com/repos/attic-labs/noms/statuses/9c4f703b94170e0ce1fb8224270e68bf5a66230a"}}}}
{"actor":{"display_login":"kalman"}}