{"action":"created","comment":{"url":"https://api.github.com/repos/cozybit/authsae/pulls/comments/79652272","id":79652272,"diff_hunk":"@@ -1303,6 +1306,9 @@ meshd_parse_libconfig (struct config_setting_t *meshd_section,\n     CONFIG_LOOKUP(mcast-rate, mcast_rate);\n     CONFIG_LOOKUP(beacon-interval,beacon_interval);\n \n+    config_setting_lookup_int(meshd_section, \"protected-management-frames\",\n+            (config_int_t *) &config->protected_management_frames);","path":"linux/meshd-nl80211.c","position":24,"original_position":24,"commit_id":"d0730006d5b1adab2eb6f6cb349224de21ee5d3a","original_commit_id":"1968eaacd6f0a8fc1b7b5a5c57c461686a0a7ed2","user":{"login":"bcopeland","id":199836,"avatar_url":"https://avatars.githubusercontent.com/u/199836?v=3","gravatar_id":"","url":"https://api.github.com/users/bcopeland","html_url":"https://github.com/bcopeland","followers_url":"https://api.github.com/users/bcopeland/followers","following_url":"https://api.github.com/users/bcopeland/following{/other_user}","gists_url":"https://api.github.com/users/bcopeland/gists{/gist_id}","starred_url":"https://api.github.com/users/bcopeland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcopeland/subscriptions","organizations_url":"https://api.github.com/users/bcopeland/orgs","repos_url":"https://api.github.com/users/bcopeland/repos","events_url":"https://api.github.com/users/bcopeland/events{/privacy}","received_events_url":"https://api.github.com/users/bcopeland/received_events","type":"User","site_admin":false},"body":"Also should we default to \"1\"?  We used to assume IGTK enabled (though using MGTK), on the other hand I'm not sure if there is any kind of good backwards compatibility story here, so maybe there is no reason to choose 1 over 0.  As of kernel 4.8, we'll start encrypting the management frames instead of using BIP, so IGTK isn't necessary for HWMP frames.","created_at":"2016-09-20T16:22:45Z","updated_at":"2016-09-20T16:22:45Z","html_url":"https://github.com/cozybit/authsae/pull/43#discussion_r79652272","pull_request_url":"https://api.github.com/repos/cozybit/authsae/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/cozybit/authsae/pulls/comments/79652272"},"html":{"href":"https://github.com/cozybit/authsae/pull/43#discussion_r79652272"},"pull_request":{"href":"https://api.github.com/repos/cozybit/authsae/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/cozybit/authsae/pulls/43","id":83891481,"html_url":"https://github.com/cozybit/authsae/pull/43","diff_url":"https://github.com/cozybit/authsae/pull/43.diff","patch_url":"https://github.com/cozybit/authsae/pull/43.patch","issue_url":"https://api.github.com/repos/cozybit/authsae/issues/43","number":43,"state":"open","locked":false,"title":"AMPE fixes","user":{"login":"bcopeland","id":199836,"avatar_url":"https://avatars.githubusercontent.com/u/199836?v=3","gravatar_id":"","url":"https://api.github.com/users/bcopeland","html_url":"https://github.com/bcopeland","followers_url":"https://api.github.com/users/bcopeland/followers","following_url":"https://api.github.com/users/bcopeland/following{/other_user}","gists_url":"https://api.github.com/users/bcopeland/gists{/gist_id}","starred_url":"https://api.github.com/users/bcopeland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcopeland/subscriptions","organizations_url":"https://api.github.com/users/bcopeland/orgs","repos_url":"https://api.github.com/users/bcopeland/repos","events_url":"https://api.github.com/users/bcopeland/events{/privacy}","received_events_url":"https://api.github.com/users/bcopeland/received_events","type":"User","site_admin":false},"body":"This PR includes changes to authsae to make it work with wpa_supplicant again, the latter being more compliant with the standard these days.  In particular:\r\n\r\n * use a more correct mesh config in the plink frames, which wpa_s checks but authsae does not\r\n * do not send or expect key data in plink close frames\r\n * separate gtk and igtk, and add an additional configuration to enable igtk (among other things this means that AES_CMAC is no longer a requirement for mesh, though hardware does still need to support multiple-peer group encryption for group addressed privacy frames -- a change in 4.8 kernel will be using encryption instead of BIP in this context)\r\n\r\nI did not test this on hardware but the series enables hwsim to peer and exchange data when one is running wpas and one is running authsae.","created_at":"2016-09-03T09:47:27Z","updated_at":"2016-09-20T16:22:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6d0d9d61e7a92a1b5239f6802338ce1e8378222","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cozybit/authsae/pulls/43/commits","review_comments_url":"https://api.github.com/repos/cozybit/authsae/pulls/43/comments","review_comment_url":"https://api.github.com/repos/cozybit/authsae/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cozybit/authsae/issues/43/comments","statuses_url":"https://api.github.com/repos/cozybit/authsae/statuses/d0730006d5b1adab2eb6f6cb349224de21ee5d3a","head":{"label":"bcopeland:ft-standard-fixes","ref":"ft-standard-fixes","sha":"d0730006d5b1adab2eb6f6cb349224de21ee5d3a","user":{"login":"bcopeland","id":199836,"avatar_url":"https://avatars.githubusercontent.com/u/199836?v=3","gravatar_id":"","url":"https://api.github.com/users/bcopeland","html_url":"https://github.com/bcopeland","followers_url":"https://api.github.com/users/bcopeland/followers","following_url":"https://api.github.com/users/bcopeland/following{/other_user}","gists_url":"https://api.github.com/users/bcopeland/gists{/gist_id}","starred_url":"https://api.github.com/users/bcopeland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcopeland/subscriptions","organizations_url":"https://api.github.com/users/bcopeland/orgs","repos_url":"https://api.github.com/users/bcopeland/repos","events_url":"https://api.github.com/users/bcopeland/events{/privacy}","received_events_url":"https://api.github.com/users/bcopeland/received_events","type":"User","site_admin":false},"repo":{"id":18839387,"name":"authsae","full_name":"bcopeland/authsae","owner":{"login":"bcopeland","id":199836,"avatar_url":"https://avatars.githubusercontent.com/u/199836?v=3","gravatar_id":"","url":"https://api.github.com/users/bcopeland","html_url":"https://github.com/bcopeland","followers_url":"https://api.github.com/users/bcopeland/followers","following_url":"https://api.github.com/users/bcopeland/following{/other_user}","gists_url":"https://api.github.com/users/bcopeland/gists{/gist_id}","starred_url":"https://api.github.com/users/bcopeland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcopeland/subscriptions","organizations_url":"https://api.github.com/users/bcopeland/orgs","repos_url":"https://api.github.com/users/bcopeland/repos","events_url":"https://api.github.com/users/bcopeland/events{/privacy}","received_events_url":"https://api.github.com/users/bcopeland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcopeland/authsae","description":"Simultaneous Authentication of Equals: Unofficial official clone of the now stale http://sourceforge.net/projects/authsae -- currently maintained by cozybit, Inc.","fork":true,"url":"https://api.github.com/repos/bcopeland/authsae","forks_url":"https://api.github.com/repos/bcopeland/authsae/forks","keys_url":"https://api.github.com/repos/bcopeland/authsae/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcopeland/authsae/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcopeland/authsae/teams","hooks_url":"https://api.github.com/repos/bcopeland/authsae/hooks","issue_events_url":"https://api.github.com/repos/bcopeland/authsae/issues/events{/number}","events_url":"https://api.github.com/repos/bcopeland/authsae/events","assignees_url":"https://api.github.com/repos/bcopeland/authsae/assignees{/user}","branches_url":"https://api.github.com/repos/bcopeland/authsae/branches{/branch}","tags_url":"https://api.github.com/repos/bcopeland/authsae/tags","blobs_url":"https://api.github.com/repos/bcopeland/authsae/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcopeland/authsae/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcopeland/authsae/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcopeland/authsae/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcopeland/authsae/statuses/{sha}","languages_url":"https://api.github.com/repos/bcopeland/authsae/languages","stargazers_url":"https://api.github.com/repos/bcopeland/authsae/stargazers","contributors_url":"https://api.github.com/repos/bcopeland/authsae/contributors","subscribers_url":"https://api.github.com/repos/bcopeland/authsae/subscribers","subscription_url":"https://api.github.com/repos/bcopeland/authsae/subscription","commits_url":"https://api.github.com/repos/bcopeland/authsae/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcopeland/authsae/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcopeland/authsae/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcopeland/authsae/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcopeland/authsae/contents/{+path}","compare_url":"https://api.github.com/repos/bcopeland/authsae/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcopeland/authsae/merges","archive_url":"https://api.github.com/repos/bcopeland/authsae/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcopeland/authsae/downloads","issues_url":"https://api.github.com/repos/bcopeland/authsae/issues{/number}","pulls_url":"https://api.github.com/repos/bcopeland/authsae/pulls{/number}","milestones_url":"https://api.github.com/repos/bcopeland/authsae/milestones{/number}","notifications_url":"https://api.github.com/repos/bcopeland/authsae/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcopeland/authsae/labels{/name}","releases_url":"https://api.github.com/repos/bcopeland/authsae/releases{/id}","deployments_url":"https://api.github.com/repos/bcopeland/authsae/deployments","created_at":"2014-04-16T12:48:18Z","updated_at":"2016-09-03T09:26:15Z","pushed_at":"2016-09-03T09:26:58Z","git_url":"git://github.com/bcopeland/authsae.git","ssh_url":"git@github.com:bcopeland/authsae.git","clone_url":"https://github.com/bcopeland/authsae.git","svn_url":"https://github.com/bcopeland/authsae","homepage":"","size":734,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cozybit:master","ref":"master","sha":"813ec0e9f568001790b3a20e83d8367de65d3ae1","user":{"login":"cozybit","id":301335,"avatar_url":"https://avatars.githubusercontent.com/u/301335?v=3","gravatar_id":"","url":"https://api.github.com/users/cozybit","html_url":"https://github.com/cozybit","followers_url":"https://api.github.com/users/cozybit/followers","following_url":"https://api.github.com/users/cozybit/following{/other_user}","gists_url":"https://api.github.com/users/cozybit/gists{/gist_id}","starred_url":"https://api.github.com/users/cozybit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozybit/subscriptions","organizations_url":"https://api.github.com/users/cozybit/orgs","repos_url":"https://api.github.com/users/cozybit/repos","events_url":"https://api.github.com/users/cozybit/events{/privacy}","received_events_url":"https://api.github.com/users/cozybit/received_events","type":"Organization","site_admin":false},"repo":{"id":1321754,"name":"authsae","full_name":"cozybit/authsae","owner":{"login":"cozybit","id":301335,"avatar_url":"https://avatars.githubusercontent.com/u/301335?v=3","gravatar_id":"","url":"https://api.github.com/users/cozybit","html_url":"https://github.com/cozybit","followers_url":"https://api.github.com/users/cozybit/followers","following_url":"https://api.github.com/users/cozybit/following{/other_user}","gists_url":"https://api.github.com/users/cozybit/gists{/gist_id}","starred_url":"https://api.github.com/users/cozybit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozybit/subscriptions","organizations_url":"https://api.github.com/users/cozybit/orgs","repos_url":"https://api.github.com/users/cozybit/repos","events_url":"https://api.github.com/users/cozybit/events{/privacy}","received_events_url":"https://api.github.com/users/cozybit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cozybit/authsae","description":"Simultaneous Authentication of Equals: Unofficial official clone of the now stale http://sourceforge.net/projects/authsae -- currently maintained by cozybit, Inc.","fork":false,"url":"https://api.github.com/repos/cozybit/authsae","forks_url":"https://api.github.com/repos/cozybit/authsae/forks","keys_url":"https://api.github.com/repos/cozybit/authsae/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cozybit/authsae/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cozybit/authsae/teams","hooks_url":"https://api.github.com/repos/cozybit/authsae/hooks","issue_events_url":"https://api.github.com/repos/cozybit/authsae/issues/events{/number}","events_url":"https://api.github.com/repos/cozybit/authsae/events","assignees_url":"https://api.github.com/repos/cozybit/authsae/assignees{/user}","branches_url":"https://api.github.com/repos/cozybit/authsae/branches{/branch}","tags_url":"https://api.github.com/repos/cozybit/authsae/tags","blobs_url":"https://api.github.com/repos/cozybit/authsae/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cozybit/authsae/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cozybit/authsae/git/refs{/sha}","trees_url":"https://api.github.com/repos/cozybit/authsae/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cozybit/authsae/statuses/{sha}","languages_url":"https://api.github.com/repos/cozybit/authsae/languages","stargazers_url":"https://api.github.com/repos/cozybit/authsae/stargazers","contributors_url":"https://api.github.com/repos/cozybit/authsae/contributors","subscribers_url":"https://api.github.com/repos/cozybit/authsae/subscribers","subscription_url":"https://api.github.com/repos/cozybit/authsae/subscription","commits_url":"https://api.github.com/repos/cozybit/authsae/commits{/sha}","git_commits_url":"https://api.github.com/repos/cozybit/authsae/git/commits{/sha}","comments_url":"https://api.github.com/repos/cozybit/authsae/comments{/number}","issue_comment_url":"https://api.github.com/repos/cozybit/authsae/issues/comments{/number}","contents_url":"https://api.github.com/repos/cozybit/authsae/contents/{+path}","compare_url":"https://api.github.com/repos/cozybit/authsae/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cozybit/authsae/merges","archive_url":"https://api.github.com/repos/cozybit/authsae/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cozybit/authsae/downloads","issues_url":"https://api.github.com/repos/cozybit/authsae/issues{/number}","pulls_url":"https://api.github.com/repos/cozybit/authsae/pulls{/number}","milestones_url":"https://api.github.com/repos/cozybit/authsae/milestones{/number}","notifications_url":"https://api.github.com/repos/cozybit/authsae/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cozybit/authsae/labels{/name}","releases_url":"https://api.github.com/repos/cozybit/authsae/releases{/id}","deployments_url":"https://api.github.com/repos/cozybit/authsae/deployments","created_at":"2011-02-02T20:32:25Z","updated_at":"2016-03-16T10:59:43Z","pushed_at":"2016-09-03T09:47:27Z","git_url":"git://github.com/cozybit/authsae.git","ssh_url":"git@github.com:cozybit/authsae.git","clone_url":"https://github.com/cozybit/authsae.git","svn_url":"https://github.com/cozybit/authsae","homepage":"","size":830,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cozybit/authsae/pulls/43"},"html":{"href":"https://github.com/cozybit/authsae/pull/43"},"issue":{"href":"https://api.github.com/repos/cozybit/authsae/issues/43"},"comments":{"href":"https://api.github.com/repos/cozybit/authsae/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/cozybit/authsae/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/cozybit/authsae/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cozybit/authsae/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/cozybit/authsae/statuses/d0730006d5b1adab2eb6f6cb349224de21ee5d3a"}}}}
{"actor":{"display_login":"bcopeland"}}