{"action":"created","comment":{"url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments/48863788","id":48863788,"diff_hunk":"@@ -489,10 +490,22 @@ def configure(self, d=None):\n \n         Returns\n         -------\n-        (old, new) tuple\n+        (old, new) tuple of dictionaries\n         Where old and new are pre- and post-configure configuration states.\n         '''\n-        return {}, {}\n+        old = self.read_configuration()\n+        for key, val in d.items():\n+            if key not in self.configuration_attrs:\n+                # a little extra checking for a more specific error msg\n+                if key not in self.signal_names:\n+                    raise ValueError(\"there is no signal named %s\", key)\n+                else:\n+                    raise ValueError(\"%s is not one of the \"\n+                                     \"configuration_fields, so it cannot be \"\n+                                     \"changed using configure\", key)\n+            getattr(self, key).put(val)","path":"ophyd/controls/device.py","position":31,"original_position":31,"commit_id":"73c11370d06c11f9950a7297dfda95f91bf6b5f8","original_commit_id":"73c11370d06c11f9950a7297dfda95f91bf6b5f8","user":{"login":"klauer","id":5139267,"avatar_url":"https://avatars.githubusercontent.com/u/5139267?v=3","gravatar_id":"","url":"https://api.github.com/users/klauer","html_url":"https://github.com/klauer","followers_url":"https://api.github.com/users/klauer/followers","following_url":"https://api.github.com/users/klauer/following{/other_user}","gists_url":"https://api.github.com/users/klauer/gists{/gist_id}","starred_url":"https://api.github.com/users/klauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klauer/subscriptions","organizations_url":"https://api.github.com/users/klauer/orgs","repos_url":"https://api.github.com/users/klauer/repos","events_url":"https://api.github.com/users/klauer/events{/privacy}","received_events_url":"https://api.github.com/users/klauer/received_events","type":"User","site_admin":false},"body":"@tacaswell serial, not parallel, puts should be the default here (with reference to waiting for them at the end). Underlying AD stuff doesn't usually handle rapid reconfiguration very well.","created_at":"2016-01-05T16:30:43Z","updated_at":"2016-01-05T16:30:43Z","html_url":"https://github.com/NSLS-II/ophyd/pull/189#discussion_r48863788","pull_request_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments/48863788"},"html":{"href":"https://github.com/NSLS-II/ophyd/pull/189#discussion_r48863788"},"pull_request":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189","id":54992277,"html_url":"https://github.com/NSLS-II/ophyd/pull/189","diff_url":"https://github.com/NSLS-II/ophyd/pull/189.diff","patch_url":"https://github.com/NSLS-II/ophyd/pull/189.patch","issue_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/189","number":189,"state":"open","locked":false,"title":"Implement a richer configure method in OphydDevice.","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"body":"We have been returning `{}, {}`. This fills out a basic implementation that returns actual data. It relies on `configuration_attrs`.","created_at":"2016-01-04T16:22:06Z","updated_at":"2016-01-05T16:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"293b9caa8480fd502a6b1906accd963f0736c0dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189/commits","review_comments_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189/comments","review_comment_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/189/comments","statuses_url":"https://api.github.com/repos/NSLS-II/ophyd/statuses/73c11370d06c11f9950a7297dfda95f91bf6b5f8","head":{"label":"danielballan:new-configure","ref":"new-configure","sha":"73c11370d06c11f9950a7297dfda95f91bf6b5f8","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"repo":{"id":33561494,"name":"ophyd","full_name":"danielballan/ophyd","owner":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielballan/ophyd","description":"Python/EPICS based data collection for NSLS-II","fork":true,"url":"https://api.github.com/repos/danielballan/ophyd","forks_url":"https://api.github.com/repos/danielballan/ophyd/forks","keys_url":"https://api.github.com/repos/danielballan/ophyd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielballan/ophyd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielballan/ophyd/teams","hooks_url":"https://api.github.com/repos/danielballan/ophyd/hooks","issue_events_url":"https://api.github.com/repos/danielballan/ophyd/issues/events{/number}","events_url":"https://api.github.com/repos/danielballan/ophyd/events","assignees_url":"https://api.github.com/repos/danielballan/ophyd/assignees{/user}","branches_url":"https://api.github.com/repos/danielballan/ophyd/branches{/branch}","tags_url":"https://api.github.com/repos/danielballan/ophyd/tags","blobs_url":"https://api.github.com/repos/danielballan/ophyd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielballan/ophyd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielballan/ophyd/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielballan/ophyd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielballan/ophyd/statuses/{sha}","languages_url":"https://api.github.com/repos/danielballan/ophyd/languages","stargazers_url":"https://api.github.com/repos/danielballan/ophyd/stargazers","contributors_url":"https://api.github.com/repos/danielballan/ophyd/contributors","subscribers_url":"https://api.github.com/repos/danielballan/ophyd/subscribers","subscription_url":"https://api.github.com/repos/danielballan/ophyd/subscription","commits_url":"https://api.github.com/repos/danielballan/ophyd/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielballan/ophyd/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielballan/ophyd/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielballan/ophyd/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielballan/ophyd/contents/{+path}","compare_url":"https://api.github.com/repos/danielballan/ophyd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielballan/ophyd/merges","archive_url":"https://api.github.com/repos/danielballan/ophyd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielballan/ophyd/downloads","issues_url":"https://api.github.com/repos/danielballan/ophyd/issues{/number}","pulls_url":"https://api.github.com/repos/danielballan/ophyd/pulls{/number}","milestones_url":"https://api.github.com/repos/danielballan/ophyd/milestones{/number}","notifications_url":"https://api.github.com/repos/danielballan/ophyd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielballan/ophyd/labels{/name}","releases_url":"https://api.github.com/repos/danielballan/ophyd/releases{/id}","created_at":"2015-04-07T18:43:53Z","updated_at":"2015-04-07T20:48:43Z","pushed_at":"2016-01-04T16:24:24Z","git_url":"git://github.com/danielballan/ophyd.git","ssh_url":"git@github.com:danielballan/ophyd.git","clone_url":"https://github.com/danielballan/ophyd.git","svn_url":"https://github.com/danielballan/ophyd","homepage":"http://nsls-ii.github.io/","size":1561,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NSLS-II:master","ref":"master","sha":"7a21e6a63dc791248f79817c9495c0b797a98253","user":{"login":"NSLS-II","id":8700262,"avatar_url":"https://avatars.githubusercontent.com/u/8700262?v=3","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"repo":{"id":26235440,"name":"ophyd","full_name":"NSLS-II/ophyd","owner":{"login":"NSLS-II","id":8700262,"avatar_url":"https://avatars.githubusercontent.com/u/8700262?v=3","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NSLS-II/ophyd","description":"Python/EPICS based data collection for NSLS-II","fork":false,"url":"https://api.github.com/repos/NSLS-II/ophyd","forks_url":"https://api.github.com/repos/NSLS-II/ophyd/forks","keys_url":"https://api.github.com/repos/NSLS-II/ophyd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NSLS-II/ophyd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NSLS-II/ophyd/teams","hooks_url":"https://api.github.com/repos/NSLS-II/ophyd/hooks","issue_events_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/events{/number}","events_url":"https://api.github.com/repos/NSLS-II/ophyd/events","assignees_url":"https://api.github.com/repos/NSLS-II/ophyd/assignees{/user}","branches_url":"https://api.github.com/repos/NSLS-II/ophyd/branches{/branch}","tags_url":"https://api.github.com/repos/NSLS-II/ophyd/tags","blobs_url":"https://api.github.com/repos/NSLS-II/ophyd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NSLS-II/ophyd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NSLS-II/ophyd/git/refs{/sha}","trees_url":"https://api.github.com/repos/NSLS-II/ophyd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NSLS-II/ophyd/statuses/{sha}","languages_url":"https://api.github.com/repos/NSLS-II/ophyd/languages","stargazers_url":"https://api.github.com/repos/NSLS-II/ophyd/stargazers","contributors_url":"https://api.github.com/repos/NSLS-II/ophyd/contributors","subscribers_url":"https://api.github.com/repos/NSLS-II/ophyd/subscribers","subscription_url":"https://api.github.com/repos/NSLS-II/ophyd/subscription","commits_url":"https://api.github.com/repos/NSLS-II/ophyd/commits{/sha}","git_commits_url":"https://api.github.com/repos/NSLS-II/ophyd/git/commits{/sha}","comments_url":"https://api.github.com/repos/NSLS-II/ophyd/comments{/number}","issue_comment_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/comments{/number}","contents_url":"https://api.github.com/repos/NSLS-II/ophyd/contents/{+path}","compare_url":"https://api.github.com/repos/NSLS-II/ophyd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NSLS-II/ophyd/merges","archive_url":"https://api.github.com/repos/NSLS-II/ophyd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NSLS-II/ophyd/downloads","issues_url":"https://api.github.com/repos/NSLS-II/ophyd/issues{/number}","pulls_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls{/number}","milestones_url":"https://api.github.com/repos/NSLS-II/ophyd/milestones{/number}","notifications_url":"https://api.github.com/repos/NSLS-II/ophyd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NSLS-II/ophyd/labels{/name}","releases_url":"https://api.github.com/repos/NSLS-II/ophyd/releases{/id}","created_at":"2014-11-05T19:20:01Z","updated_at":"2015-12-10T23:37:22Z","pushed_at":"2016-01-04T16:24:25Z","git_url":"git://github.com/NSLS-II/ophyd.git","ssh_url":"git@github.com:NSLS-II/ophyd.git","clone_url":"https://github.com/NSLS-II/ophyd.git","svn_url":"https://github.com/NSLS-II/ophyd","homepage":"http://nsls-ii.github.io/","size":4429,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":41,"forks":10,"open_issues":41,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189"},"html":{"href":"https://github.com/NSLS-II/ophyd/pull/189"},"issue":{"href":"https://api.github.com/repos/NSLS-II/ophyd/issues/189"},"comments":{"href":"https://api.github.com/repos/NSLS-II/ophyd/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/NSLS-II/ophyd/statuses/73c11370d06c11f9950a7297dfda95f91bf6b5f8"}}}}