{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10255","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10255/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10255/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10255/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10255","id":169356447,"number":10255,"title":"[WIP] Refactor ems_common#show","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-04T11:53:14Z","updated_at":"2016-08-04T12:01:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10255","html_url":"https://github.com/ManageIQ/manageiq/pull/10255","diff_url":"https://github.com/ManageIQ/manageiq/pull/10255.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10255.patch"},"body":"Purpose or Intent\r\n-----------------\r\nsplit `show` into several methods to recover the intent of the original code and get some readability"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/237533094","html_url":"https://github.com/ManageIQ/manageiq/pull/10255#issuecomment-237533094","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10255","id":237533094,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T12:01:38Z","updated_at":"2016-08-04T12:01:38Z","body":"<rubocop />Checked commit https://github.com/martinpovolny/manageiq/commit/9fa61c22129df82b01e6e8a8ac958fd6f4191385 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n2 files checked, 9 offenses detected\n\n**app/controllers/ems_common.rb**\n- [ ] :warning: - [Line 109](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L109), Col 5 - [Lint/Debugger](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/Debugger) - Remove debugger entry point `binding.pry`.\n- [ ] :warning: - [Line 208](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L208), Col 5 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `view_item_name`.\n- [ ] :exclamation: - [Line 184](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L184), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n- [ ] :exclamation: - [Line 36](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L36), Col 80 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :exclamation: - [Line 46](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L46), Col 22 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :exclamation: - [Line 74](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L74), Col 45 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :exclamation: - [Line 76](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L76), Col 1 - [Style/CommentIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/CommentIndentation) - Incorrect indentation detected (column 0 instead of 6).\n- [ ] :exclamation: - [Line 86](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L86), Col 3 - [Style/IndentationWidth](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/IndentationWidth) - Use 2 (not 3) spaces for indentation.\n- [ ] :grey_exclamation: - [Line 25](https://github.com/martinpovolny/manageiq/blob/9fa61c22129df82b01e6e8a8ac958fd6f4191385/app/controllers/ems_common.rb#L25), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for show_ems_folders is too high. [17.49/15]\n"}}
{"actor":{"display_login":"miq-bot"}}