{"action":"created","comment":{"url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments/81772363","pull_request_review_id":2727361,"id":81772363,"diff_hunk":"@@ -2989,142 +3117,81 @@\n \t\t *                          the request.\n \t\t */\n \t\trun: function( deferred ) {\n-\t\t\tvar self   = this,\n+\t\t\tvar previewFrame = this,\n \t\t\t\tloaded = false,\n-\t\t\t\tready  = false;\n+\t\t\t\tready = false,\n+\t\t\t\treadyData = null,\n+\t\t\t\turlParser,\n+\t\t\t\tparams;\n \n-\t\t\tif ( this._ready ) {\n-\t\t\t\tthis.unbind( 'ready', this._ready );\n+\t\t\tif ( previewFrame._ready ) {\n+\t\t\t\tpreviewFrame.unbind( 'ready', previewFrame._ready );\n \t\t\t}\n \n-\t\t\tthis._ready = function() {\n+\t\t\tpreviewFrame._ready = function( data ) {\n \t\t\t\tready = true;\n+\t\t\t\treadyData = data;\n+\t\t\t\tpreviewFrame.container.addClass( 'iframe-ready' );\n+\t\t\t\tif ( ! data ) {\n+\t\t\t\t\treturn;\n+\t\t\t\t}\n \n \t\t\t\tif ( loaded ) {\n-\t\t\t\t\tdeferred.resolveWith( self );\n+\t\t\t\t\tdeferred.resolveWith( previewFrame, [ data ] );\n \t\t\t\t}\n \t\t\t};\n \n-\t\t\tthis.bind( 'ready', this._ready );\n-\n-\t\t\tthis.bind( 'ready', function ( data ) {\n+\t\t\tpreviewFrame.bind( 'ready', previewFrame._ready );\n \n-\t\t\t\tthis.container.addClass( 'iframe-ready' );\n-\n-\t\t\t\tif ( ! data ) {\n-\t\t\t\t\treturn;\n-\t\t\t\t}\n-\n-\t\t\t\t/*\n-\t\t\t\t * Walk over all panels, sections, and controls and set their\n-\t\t\t\t * respective active states to true if the preview explicitly\n-\t\t\t\t * indicates as such.\n-\t\t\t\t */\n-\t\t\t\tvar constructs = {\n-\t\t\t\t\tpanel: data.activePanels,\n-\t\t\t\t\tsection: data.activeSections,\n-\t\t\t\t\tcontrol: data.activeControls\n-\t\t\t\t};\n-\t\t\t\t_( constructs ).each( function ( activeConstructs, type ) {\n-\t\t\t\t\tapi[ type ].each( function ( construct, id ) {\n-\t\t\t\t\t\tvar isDynamicallyCreated = _.isUndefined( api.settings[ type + 's' ][ id ] );\n-\n-\t\t\t\t\t\t/*\n-\t\t\t\t\t\t * If the construct was created statically in PHP (not dynamically in JS)\n-\t\t\t\t\t\t * then consider a missing (undefined) value in the activeConstructs to\n-\t\t\t\t\t\t * mean it should be deactivated (since it is gone). But if it is\n-\t\t\t\t\t\t * dynamically created then only toggle activation if the value is defined,\n-\t\t\t\t\t\t * as this means that the construct was also then correspondingly\n-\t\t\t\t\t\t * created statically in PHP and the active callback is available.\n-\t\t\t\t\t\t * Otherwise, dynamically-created constructs should normally have\n-\t\t\t\t\t\t * their active states toggled in JS rather than from PHP.\n-\t\t\t\t\t\t */\n-\t\t\t\t\t\tif ( ! isDynamicallyCreated || ! _.isUndefined( activeConstructs[ id ] ) ) {\n-\t\t\t\t\t\t\tif ( activeConstructs[ id ] ) {\n-\t\t\t\t\t\t\t\tconstruct.activate();\n-\t\t\t\t\t\t\t} else {\n-\t\t\t\t\t\t\t\tconstruct.deactivate();\n-\t\t\t\t\t\t\t}\n-\t\t\t\t\t\t}\n-\t\t\t\t\t} );\n-\t\t\t\t} );\n+\t\t\t// @todo Wait until 0 === processing?","path":"src/wp-admin/js/customize-controls.js","position":286,"original_position":286,"commit_id":"c4b1abb1dea90a99c033bca2fc057b24f3fa1a01","original_commit_id":"c4b1abb1dea90a99c033bca2fc057b24f3fa1a01","user":{"login":"westonruter","id":134745,"avatar_url":"https://avatars.githubusercontent.com/u/134745?v=3","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"body":"This can be removed because `processing` is being watched in `wp.customize.previewer.refresh()`.","created_at":"2016-10-04T14:41:26Z","updated_at":"2016-10-04T14:41:26Z","html_url":"https://github.com/xwp/wordpress-develop/pull/161#discussion_r81772363","pull_request_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments/81772363"},"html":{"href":"https://github.com/xwp/wordpress-develop/pull/161#discussion_r81772363"},"pull_request":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161","id":87626453,"html_url":"https://github.com/xwp/wordpress-develop/pull/161","diff_url":"https://github.com/xwp/wordpress-develop/pull/161.diff","patch_url":"https://github.com/xwp/wordpress-develop/pull/161.patch","issue_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/161","number":161,"state":"open","locked":false,"title":"[WIP] Trac 30937: Implement Customize Changesets (née Transactions aka Snapshots)","user":{"login":"westonruter","id":134745,"avatar_url":"https://avatars.githubusercontent.com/u/134745?v=3","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"body":"Supersedes #61.\r\n\r\nSee https://core.trac.wordpress.org/ticket/30937#comment:56","created_at":"2016-10-02T06:50:39Z","updated_at":"2016-10-04T14:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99245519acf527932a684fb97cd0536343319d5b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161/commits","review_comments_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161/comments","review_comment_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/161/comments","statuses_url":"https://api.github.com/repos/xwp/wordpress-develop/statuses/c4b1abb1dea90a99c033bca2fc057b24f3fa1a01","head":{"label":"xwp:trac-30937","ref":"trac-30937","sha":"c4b1abb1dea90a99c033bca2fc057b24f3fa1a01","user":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"repo":{"id":17656498,"name":"wordpress-develop","full_name":"xwp/wordpress-develop","owner":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwp/wordpress-develop","description":"Clone of git://develop.git.wordpress.org/ synced once a minute","fork":false,"url":"https://api.github.com/repos/xwp/wordpress-develop","forks_url":"https://api.github.com/repos/xwp/wordpress-develop/forks","keys_url":"https://api.github.com/repos/xwp/wordpress-develop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwp/wordpress-develop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwp/wordpress-develop/teams","hooks_url":"https://api.github.com/repos/xwp/wordpress-develop/hooks","issue_events_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/events{/number}","events_url":"https://api.github.com/repos/xwp/wordpress-develop/events","assignees_url":"https://api.github.com/repos/xwp/wordpress-develop/assignees{/user}","branches_url":"https://api.github.com/repos/xwp/wordpress-develop/branches{/branch}","tags_url":"https://api.github.com/repos/xwp/wordpress-develop/tags","blobs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwp/wordpress-develop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwp/wordpress-develop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwp/wordpress-develop/statuses/{sha}","languages_url":"https://api.github.com/repos/xwp/wordpress-develop/languages","stargazers_url":"https://api.github.com/repos/xwp/wordpress-develop/stargazers","contributors_url":"https://api.github.com/repos/xwp/wordpress-develop/contributors","subscribers_url":"https://api.github.com/repos/xwp/wordpress-develop/subscribers","subscription_url":"https://api.github.com/repos/xwp/wordpress-develop/subscription","commits_url":"https://api.github.com/repos/xwp/wordpress-develop/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwp/wordpress-develop/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwp/wordpress-develop/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwp/wordpress-develop/contents/{+path}","compare_url":"https://api.github.com/repos/xwp/wordpress-develop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwp/wordpress-develop/merges","archive_url":"https://api.github.com/repos/xwp/wordpress-develop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwp/wordpress-develop/downloads","issues_url":"https://api.github.com/repos/xwp/wordpress-develop/issues{/number}","pulls_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls{/number}","milestones_url":"https://api.github.com/repos/xwp/wordpress-develop/milestones{/number}","notifications_url":"https://api.github.com/repos/xwp/wordpress-develop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwp/wordpress-develop/labels{/name}","releases_url":"https://api.github.com/repos/xwp/wordpress-develop/releases{/id}","deployments_url":"https://api.github.com/repos/xwp/wordpress-develop/deployments","created_at":"2014-03-12T05:32:08Z","updated_at":"2016-09-16T16:54:48Z","pushed_at":"2016-10-04T10:38:09Z","git_url":"git://github.com/xwp/wordpress-develop.git","ssh_url":"git@github.com:xwp/wordpress-develop.git","clone_url":"https://github.com/xwp/wordpress-develop.git","svn_url":"https://github.com/xwp/wordpress-develop","homepage":"","size":122429,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":91,"forks":6,"open_issues":91,"watchers":13,"default_branch":"master"}},"base":{"label":"xwp:master","ref":"master","sha":"eef4795716a4394dcd3b38f08cd821bfd342728d","user":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"repo":{"id":17656498,"name":"wordpress-develop","full_name":"xwp/wordpress-develop","owner":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwp/wordpress-develop","description":"Clone of git://develop.git.wordpress.org/ synced once a minute","fork":false,"url":"https://api.github.com/repos/xwp/wordpress-develop","forks_url":"https://api.github.com/repos/xwp/wordpress-develop/forks","keys_url":"https://api.github.com/repos/xwp/wordpress-develop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwp/wordpress-develop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwp/wordpress-develop/teams","hooks_url":"https://api.github.com/repos/xwp/wordpress-develop/hooks","issue_events_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/events{/number}","events_url":"https://api.github.com/repos/xwp/wordpress-develop/events","assignees_url":"https://api.github.com/repos/xwp/wordpress-develop/assignees{/user}","branches_url":"https://api.github.com/repos/xwp/wordpress-develop/branches{/branch}","tags_url":"https://api.github.com/repos/xwp/wordpress-develop/tags","blobs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwp/wordpress-develop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwp/wordpress-develop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwp/wordpress-develop/statuses/{sha}","languages_url":"https://api.github.com/repos/xwp/wordpress-develop/languages","stargazers_url":"https://api.github.com/repos/xwp/wordpress-develop/stargazers","contributors_url":"https://api.github.com/repos/xwp/wordpress-develop/contributors","subscribers_url":"https://api.github.com/repos/xwp/wordpress-develop/subscribers","subscription_url":"https://api.github.com/repos/xwp/wordpress-develop/subscription","commits_url":"https://api.github.com/repos/xwp/wordpress-develop/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwp/wordpress-develop/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwp/wordpress-develop/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwp/wordpress-develop/contents/{+path}","compare_url":"https://api.github.com/repos/xwp/wordpress-develop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwp/wordpress-develop/merges","archive_url":"https://api.github.com/repos/xwp/wordpress-develop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwp/wordpress-develop/downloads","issues_url":"https://api.github.com/repos/xwp/wordpress-develop/issues{/number}","pulls_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls{/number}","milestones_url":"https://api.github.com/repos/xwp/wordpress-develop/milestones{/number}","notifications_url":"https://api.github.com/repos/xwp/wordpress-develop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwp/wordpress-develop/labels{/name}","releases_url":"https://api.github.com/repos/xwp/wordpress-develop/releases{/id}","deployments_url":"https://api.github.com/repos/xwp/wordpress-develop/deployments","created_at":"2014-03-12T05:32:08Z","updated_at":"2016-09-16T16:54:48Z","pushed_at":"2016-10-04T10:38:09Z","git_url":"git://github.com/xwp/wordpress-develop.git","ssh_url":"git@github.com:xwp/wordpress-develop.git","clone_url":"https://github.com/xwp/wordpress-develop.git","svn_url":"https://github.com/xwp/wordpress-develop","homepage":"","size":122429,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":91,"forks":6,"open_issues":91,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161"},"html":{"href":"https://github.com/xwp/wordpress-develop/pull/161"},"issue":{"href":"https://api.github.com/repos/xwp/wordpress-develop/issues/161"},"comments":{"href":"https://api.github.com/repos/xwp/wordpress-develop/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/xwp/wordpress-develop/statuses/c4b1abb1dea90a99c033bca2fc057b24f3fa1a01"}}}}
{"actor":{"display_login":"westonruter"}}