{"action":"created","issue":{"url":"https://api.github.com/repos/cibernox/ember-power-select/issues/433","repository_url":"https://api.github.com/repos/cibernox/ember-power-select","labels_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/433/labels{/name}","comments_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/433/comments","events_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/433/events","html_url":"https://github.com/cibernox/ember-power-select/pull/433","id":146006262,"number":433,"title":"Pass WAI-ARIA states into dropdown","user":{"login":"jmacqueen","id":5197963,"avatar_url":"https://avatars.githubusercontent.com/u/5197963?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacqueen","html_url":"https://github.com/jmacqueen","followers_url":"https://api.github.com/users/jmacqueen/followers","following_url":"https://api.github.com/users/jmacqueen/following{/other_user}","gists_url":"https://api.github.com/users/jmacqueen/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacqueen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacqueen/subscriptions","organizations_url":"https://api.github.com/users/jmacqueen/orgs","repos_url":"https://api.github.com/users/jmacqueen/repos","events_url":"https://api.github.com/users/jmacqueen/events{/privacy}","received_events_url":"https://api.github.com/users/jmacqueen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-05T14:27:14Z","updated_at":"2016-04-06T14:23:32Z","closed_at":"2016-04-06T14:22:49Z","pull_request":{"url":"https://api.github.com/repos/cibernox/ember-power-select/pulls/433","html_url":"https://github.com/cibernox/ember-power-select/pull/433","diff_url":"https://github.com/cibernox/ember-power-select/pull/433.diff","patch_url":"https://github.com/cibernox/ember-power-select/pull/433.patch"},"body":"This will pass the following WAI-ARIA relationship and widget attributes through to `basic-dropdown` in an attempt to complete cibernox/ember-power-select#293\r\n\r\nI have a thing about alphabetizing long property lists to help out when exploring or debugging, I hope that doesn't cause too much trouble. Other than alphabetizing, these are the only actual additions to the templates.\r\n\r\n`power-select` attribute  | WAI-ARIA attribute in DOM |  Note\r\n--------------------------------|--------------------------------------|----------\r\n`ariaDescribedBy`   | `aria-describedby`\r\n`ariaInvalid `            | `aria-invalid`\r\n`ariaLabel `              | `aria-label`                     | This one still needs to be added to `basic-dropdown`, but inclusion here ahead of time doesn't break anything\r\n`ariaLabelledBy `     | `aria-labelledby`\r\n`required`                 |`aria-required`\r\n\r\nI didn't include tests because I'm a bad person. And I didn't want to take the time on the off-chance these changes don't go in :smile: "},"comment":{"url":"https://api.github.com/repos/cibernox/ember-power-select/issues/comments/206396794","html_url":"https://github.com/cibernox/ember-power-select/pull/433#issuecomment-206396794","issue_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/433","id":206396794,"user":{"login":"cibernox","id":265339,"avatar_url":"https://avatars.githubusercontent.com/u/265339?v=3","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T14:23:32Z","updated_at":"2016-04-06T14:23:32Z","body":"Thanks for all the a11y work. \r\n\r\nThis starts to look complete."}}