{"action":"created","comment":{"url":"https://api.github.com/repos/operable/cog/pulls/comments/60070427","id":60070427,"diff_hunk":"@@ -133,4 +133,11 @@ config :cog, Cog.TriggerEndpoint,\n config :cog, :token_lifetime, {1, :week}\n config :cog, :token_reap_period, {1, :day}\n \n+# Trigger timeouts are defined according to the needs of the\n+# requestor, which includes network roundtrip time, as well as Cog's\n+# internal processing. Cog itself can't wait that long to respond, as\n+# that'll be guaranteed to exceed the HTTP requestor's timeout. As\n+# such, we'll bake some slack into our internal timeout.\n+config :cog, :trigger_timeout_slack_sec, (System.get_env(\"COG_TRIGGER_TIMEOUT_SLACK_SEC\") || 2)\n+","path":"config/config.exs","position":10,"original_position":10,"commit_id":"3b4283243b9c19a66968244db2304790cdd334e9","original_commit_id":"3b4283243b9c19a66968244db2304790cdd334e9","user":{"login":"lhaskins","id":5166016,"avatar_url":"https://avatars.githubusercontent.com/u/5166016?v=3","gravatar_id":"","url":"https://api.github.com/users/lhaskins","html_url":"https://github.com/lhaskins","followers_url":"https://api.github.com/users/lhaskins/followers","following_url":"https://api.github.com/users/lhaskins/following{/other_user}","gists_url":"https://api.github.com/users/lhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/lhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhaskins/subscriptions","organizations_url":"https://api.github.com/users/lhaskins/orgs","repos_url":"https://api.github.com/users/lhaskins/repos","events_url":"https://api.github.com/users/lhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/lhaskins/received_events","type":"User","site_admin":false},"body":"To avoid possible confusion, can you change the variable names to not use \"slack\", but maybe \"buffer\"?","created_at":"2016-04-18T14:41:19Z","updated_at":"2016-04-18T14:41:19Z","html_url":"https://github.com/operable/cog/pull/547#discussion_r60070427","pull_request_url":"https://api.github.com/repos/operable/cog/pulls/547","_links":{"self":{"href":"https://api.github.com/repos/operable/cog/pulls/comments/60070427"},"html":{"href":"https://github.com/operable/cog/pull/547#discussion_r60070427"},"pull_request":{"href":"https://api.github.com/repos/operable/cog/pulls/547"}}},"pull_request":{"url":"https://api.github.com/repos/operable/cog/pulls/547","id":66860590,"html_url":"https://github.com/operable/cog/pull/547","diff_url":"https://github.com/operable/cog/pull/547.diff","patch_url":"https://github.com/operable/cog/pull/547.patch","issue_url":"https://api.github.com/repos/operable/cog/issues/547","number":547,"state":"open","locked":false,"title":"Add some slack to trigger timeouts","user":{"login":"christophermaier","id":207178,"avatar_url":"https://avatars.githubusercontent.com/u/207178?v=3","gravatar_id":"","url":"https://api.github.com/users/christophermaier","html_url":"https://github.com/christophermaier","followers_url":"https://api.github.com/users/christophermaier/followers","following_url":"https://api.github.com/users/christophermaier/following{/other_user}","gists_url":"https://api.github.com/users/christophermaier/gists{/gist_id}","starred_url":"https://api.github.com/users/christophermaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophermaier/subscriptions","organizations_url":"https://api.github.com/users/christophermaier/orgs","repos_url":"https://api.github.com/users/christophermaier/repos","events_url":"https://api.github.com/users/christophermaier/events{/privacy}","received_events_url":"https://api.github.com/users/christophermaier/received_events","type":"User","site_admin":false},"body":"Trigger timeouts are defined according to the needs of the\r\nrequestor (e.g. Github webhooks must respond within 30 seconds), which\r\nincludes network roundtrip time, as well as Cog's internal\r\nprocessing. Cog itself can't wait that long to respond, as that'll be\r\nguaranteed to exceed the HTTP requestor's timeout. As such, we'll bake\r\nsome slack into our internal timeout, allowing us to return to the\r\nrequestor within their timeout.\r\n\r\nThis can be configured on a system-wide basis.","created_at":"2016-04-18T14:16:12Z","updated_at":"2016-04-18T14:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba38f8b982f879940404dbc8d561425f3cb45ac0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/operable/cog/pulls/547/commits","review_comments_url":"https://api.github.com/repos/operable/cog/pulls/547/comments","review_comment_url":"https://api.github.com/repos/operable/cog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/operable/cog/issues/547/comments","statuses_url":"https://api.github.com/repos/operable/cog/statuses/3b4283243b9c19a66968244db2304790cdd334e9","head":{"label":"operable:cm/trigger-timeout-fudge-factor","ref":"cm/trigger-timeout-fudge-factor","sha":"3b4283243b9c19a66968244db2304790cdd334e9","user":{"login":"operable","id":6070463,"avatar_url":"https://avatars.githubusercontent.com/u/6070463?v=3","gravatar_id":"","url":"https://api.github.com/users/operable","html_url":"https://github.com/operable","followers_url":"https://api.github.com/users/operable/followers","following_url":"https://api.github.com/users/operable/following{/other_user}","gists_url":"https://api.github.com/users/operable/gists{/gist_id}","starred_url":"https://api.github.com/users/operable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operable/subscriptions","organizations_url":"https://api.github.com/users/operable/orgs","repos_url":"https://api.github.com/users/operable/repos","events_url":"https://api.github.com/users/operable/events{/privacy}","received_events_url":"https://api.github.com/users/operable/received_events","type":"Organization","site_admin":false},"repo":{"id":49292670,"name":"cog","full_name":"operable/cog","owner":{"login":"operable","id":6070463,"avatar_url":"https://avatars.githubusercontent.com/u/6070463?v=3","gravatar_id":"","url":"https://api.github.com/users/operable","html_url":"https://github.com/operable","followers_url":"https://api.github.com/users/operable/followers","following_url":"https://api.github.com/users/operable/following{/other_user}","gists_url":"https://api.github.com/users/operable/gists{/gist_id}","starred_url":"https://api.github.com/users/operable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operable/subscriptions","organizations_url":"https://api.github.com/users/operable/orgs","repos_url":"https://api.github.com/users/operable/repos","events_url":"https://api.github.com/users/operable/events{/privacy}","received_events_url":"https://api.github.com/users/operable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/operable/cog","description":"Bringing the power of the command line to chat","fork":false,"url":"https://api.github.com/repos/operable/cog","forks_url":"https://api.github.com/repos/operable/cog/forks","keys_url":"https://api.github.com/repos/operable/cog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/operable/cog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/operable/cog/teams","hooks_url":"https://api.github.com/repos/operable/cog/hooks","issue_events_url":"https://api.github.com/repos/operable/cog/issues/events{/number}","events_url":"https://api.github.com/repos/operable/cog/events","assignees_url":"https://api.github.com/repos/operable/cog/assignees{/user}","branches_url":"https://api.github.com/repos/operable/cog/branches{/branch}","tags_url":"https://api.github.com/repos/operable/cog/tags","blobs_url":"https://api.github.com/repos/operable/cog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/operable/cog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/operable/cog/git/refs{/sha}","trees_url":"https://api.github.com/repos/operable/cog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/operable/cog/statuses/{sha}","languages_url":"https://api.github.com/repos/operable/cog/languages","stargazers_url":"https://api.github.com/repos/operable/cog/stargazers","contributors_url":"https://api.github.com/repos/operable/cog/contributors","subscribers_url":"https://api.github.com/repos/operable/cog/subscribers","subscription_url":"https://api.github.com/repos/operable/cog/subscription","commits_url":"https://api.github.com/repos/operable/cog/commits{/sha}","git_commits_url":"https://api.github.com/repos/operable/cog/git/commits{/sha}","comments_url":"https://api.github.com/repos/operable/cog/comments{/number}","issue_comment_url":"https://api.github.com/repos/operable/cog/issues/comments{/number}","contents_url":"https://api.github.com/repos/operable/cog/contents/{+path}","compare_url":"https://api.github.com/repos/operable/cog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/operable/cog/merges","archive_url":"https://api.github.com/repos/operable/cog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/operable/cog/downloads","issues_url":"https://api.github.com/repos/operable/cog/issues{/number}","pulls_url":"https://api.github.com/repos/operable/cog/pulls{/number}","milestones_url":"https://api.github.com/repos/operable/cog/milestones{/number}","notifications_url":"https://api.github.com/repos/operable/cog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/operable/cog/labels{/name}","releases_url":"https://api.github.com/repos/operable/cog/releases{/id}","deployments_url":"https://api.github.com/repos/operable/cog/deployments","created_at":"2016-01-08T19:45:06Z","updated_at":"2016-04-18T01:55:49Z","pushed_at":"2016-04-18T14:18:58Z","git_url":"git://github.com/operable/cog.git","ssh_url":"git@github.com:operable/cog.git","clone_url":"https://github.com/operable/cog.git","svn_url":"https://github.com/operable/cog","homepage":"http://operable.io","size":2764,"stargazers_count":317,"watchers_count":317,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":124,"forks":19,"open_issues":124,"watchers":317,"default_branch":"master"}},"base":{"label":"operable:master","ref":"master","sha":"825f97ad2a07972009d7583ad67094a5b36832d4","user":{"login":"operable","id":6070463,"avatar_url":"https://avatars.githubusercontent.com/u/6070463?v=3","gravatar_id":"","url":"https://api.github.com/users/operable","html_url":"https://github.com/operable","followers_url":"https://api.github.com/users/operable/followers","following_url":"https://api.github.com/users/operable/following{/other_user}","gists_url":"https://api.github.com/users/operable/gists{/gist_id}","starred_url":"https://api.github.com/users/operable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operable/subscriptions","organizations_url":"https://api.github.com/users/operable/orgs","repos_url":"https://api.github.com/users/operable/repos","events_url":"https://api.github.com/users/operable/events{/privacy}","received_events_url":"https://api.github.com/users/operable/received_events","type":"Organization","site_admin":false},"repo":{"id":49292670,"name":"cog","full_name":"operable/cog","owner":{"login":"operable","id":6070463,"avatar_url":"https://avatars.githubusercontent.com/u/6070463?v=3","gravatar_id":"","url":"https://api.github.com/users/operable","html_url":"https://github.com/operable","followers_url":"https://api.github.com/users/operable/followers","following_url":"https://api.github.com/users/operable/following{/other_user}","gists_url":"https://api.github.com/users/operable/gists{/gist_id}","starred_url":"https://api.github.com/users/operable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operable/subscriptions","organizations_url":"https://api.github.com/users/operable/orgs","repos_url":"https://api.github.com/users/operable/repos","events_url":"https://api.github.com/users/operable/events{/privacy}","received_events_url":"https://api.github.com/users/operable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/operable/cog","description":"Bringing the power of the command line to chat","fork":false,"url":"https://api.github.com/repos/operable/cog","forks_url":"https://api.github.com/repos/operable/cog/forks","keys_url":"https://api.github.com/repos/operable/cog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/operable/cog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/operable/cog/teams","hooks_url":"https://api.github.com/repos/operable/cog/hooks","issue_events_url":"https://api.github.com/repos/operable/cog/issues/events{/number}","events_url":"https://api.github.com/repos/operable/cog/events","assignees_url":"https://api.github.com/repos/operable/cog/assignees{/user}","branches_url":"https://api.github.com/repos/operable/cog/branches{/branch}","tags_url":"https://api.github.com/repos/operable/cog/tags","blobs_url":"https://api.github.com/repos/operable/cog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/operable/cog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/operable/cog/git/refs{/sha}","trees_url":"https://api.github.com/repos/operable/cog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/operable/cog/statuses/{sha}","languages_url":"https://api.github.com/repos/operable/cog/languages","stargazers_url":"https://api.github.com/repos/operable/cog/stargazers","contributors_url":"https://api.github.com/repos/operable/cog/contributors","subscribers_url":"https://api.github.com/repos/operable/cog/subscribers","subscription_url":"https://api.github.com/repos/operable/cog/subscription","commits_url":"https://api.github.com/repos/operable/cog/commits{/sha}","git_commits_url":"https://api.github.com/repos/operable/cog/git/commits{/sha}","comments_url":"https://api.github.com/repos/operable/cog/comments{/number}","issue_comment_url":"https://api.github.com/repos/operable/cog/issues/comments{/number}","contents_url":"https://api.github.com/repos/operable/cog/contents/{+path}","compare_url":"https://api.github.com/repos/operable/cog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/operable/cog/merges","archive_url":"https://api.github.com/repos/operable/cog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/operable/cog/downloads","issues_url":"https://api.github.com/repos/operable/cog/issues{/number}","pulls_url":"https://api.github.com/repos/operable/cog/pulls{/number}","milestones_url":"https://api.github.com/repos/operable/cog/milestones{/number}","notifications_url":"https://api.github.com/repos/operable/cog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/operable/cog/labels{/name}","releases_url":"https://api.github.com/repos/operable/cog/releases{/id}","deployments_url":"https://api.github.com/repos/operable/cog/deployments","created_at":"2016-01-08T19:45:06Z","updated_at":"2016-04-18T01:55:49Z","pushed_at":"2016-04-18T14:18:58Z","git_url":"git://github.com/operable/cog.git","ssh_url":"git@github.com:operable/cog.git","clone_url":"https://github.com/operable/cog.git","svn_url":"https://github.com/operable/cog","homepage":"http://operable.io","size":2764,"stargazers_count":317,"watchers_count":317,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":124,"forks":19,"open_issues":124,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/operable/cog/pulls/547"},"html":{"href":"https://github.com/operable/cog/pull/547"},"issue":{"href":"https://api.github.com/repos/operable/cog/issues/547"},"comments":{"href":"https://api.github.com/repos/operable/cog/issues/547/comments"},"review_comments":{"href":"https://api.github.com/repos/operable/cog/pulls/547/comments"},"review_comment":{"href":"https://api.github.com/repos/operable/cog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/operable/cog/pulls/547/commits"},"statuses":{"href":"https://api.github.com/repos/operable/cog/statuses/3b4283243b9c19a66968244db2304790cdd334e9"}}}}